12019-06-26T00:00:01 *** Snowstormer has quit IRC
22019-06-26T00:03:58 *** nihui has joined #bitcoin-core-dev
32019-06-26T00:05:06 *** rafalcpp_ has joined #bitcoin-core-dev
42019-06-26T00:05:22 *** rafalcpp has quit IRC
52019-06-26T00:05:53 *** queip has quit IRC
62019-06-26T00:08:56 * luke-jr suggests "if you can articulate a good reason why, it's okay to have mid-commits fail"
72019-06-26T00:08:59 *** aseem has joined #bitcoin-core-dev
82019-06-26T00:11:48 *** queip has joined #bitcoin-core-dev
92019-06-26T00:12:18 *** surja795 has joined #bitcoin-core-dev
102019-06-26T00:19:20 *** aseem has quit IRC
112019-06-26T00:29:37 *** scoop has joined #bitcoin-core-dev
122019-06-26T00:36:33 *** michaelfolkson has joined #bitcoin-core-dev
132019-06-26T00:37:45 *** lightlike has quit IRC
142019-06-26T00:38:50 *** michaelfolkson has quit IRC
152019-06-26T00:41:49 <achow101> meshcollider: I'm fine with doing that. The question is do *you* want to review that commit?
162019-06-26T00:47:53 *** Guest81088 has quit IRC
172019-06-26T00:50:30 <sipa> achow101: i think meshcollider's was suggesting that promag would squash the commits himself, before local review
182019-06-26T00:51:25 <gwillen> luke-jr: do you consider "it would be a huge pain in the ass" to be a good reason
192019-06-26T00:51:29 <gwillen> my sense is that's maybe the case here
202019-06-26T00:51:47 <gwillen> it's probably better to avoid that case but I'm sympathetic because I've gotten into it before
212019-06-26T00:51:55 <promag> sipa: is it possible to have the changes since a bdb cursor?
222019-06-26T00:52:31 <luke-jr> gwillen: if it's not just laziness ;)
232019-06-26T00:52:59 <luke-jr> otoh, we're making our test system more fragile, so dunno, maybe we should just ignore test failrues :/
242019-06-26T00:53:27 <meshcollider> achow101: I prefer smaller commits over 1 massive one even if bisect breaks
252019-06-26T00:53:51 *** scoop has quit IRC
262019-06-26T00:56:28 *** scoop has joined #bitcoin-core-dev
272019-06-26T00:56:42 <achow101> gwillen: luke-jr: it's just super hard to follow if it is one gigantic diff. I tried doing that and quickly got lost in my own changes before I even committed it.
282019-06-26T00:56:45 <sipa> promag: ?
292019-06-26T00:57:06 <promag> achow101: incoming refactor? be gentle :P
302019-06-26T00:57:15 <sipa> achow101: that seems like a plenty strong reason to ignore the rule
312019-06-26T00:57:20 <promag> sipa: scantxoutset takes a cursor then iterates it
322019-06-26T00:57:32 <sipa> achow101: though even better would be small commits that don't break it :)
332019-06-26T00:57:45 <promag> sipa: is is possible to to make then following scantxoutset incremental?
342019-06-26T00:57:45 <gwillen> yeah I think small commits with breakage > large commits that are hard to understand, indeed
352019-06-26T00:57:54 <sipa> promag: what does bdb have to do with it?
362019-06-26T00:57:58 <sipa> that's a wallet thing
372019-06-26T00:58:03 <sipa> scantxoutset has nothing to do with the wallet
382019-06-26T00:58:35 <sipa> promag: ah, i see what you mean
392019-06-26T00:59:19 <sipa> you can have an incremental scantxoutset by filtering only entries with a blockheight later than your previous scan
402019-06-26T00:59:21 <achow101> sipa: I don't think it is possible to make small commits that don't break tests. all this wallet stuff is tied to each other extremely tightly
412019-06-26T00:59:25 <sipa> but that wouldn't speed anything up
422019-06-26T00:59:34 <sipa> achow101: yeah, i believe that
432019-06-26T01:00:32 <promag> sipa: right, I thought the same
442019-06-26T01:01:15 <promag> btw, scantxoutset doesn't take into account mempool, is that intended?
452019-06-26T01:02:44 <sipa> we could add an option to include the mempool i guess
462019-06-26T01:04:20 *** pinheadmz has joined #bitcoin-core-dev
472019-06-26T01:05:37 <promag> achow101: you could add [skip ci] in the commit message, travis only reads this in the HEAD commit but we could use it in broken commits
482019-06-26T01:05:53 <achow101> promag: ah, good idea
492019-06-26T01:08:14 *** dviola has quit IRC
502019-06-26T01:08:53 *** pinheadmz has quit IRC
512019-06-26T01:08:54 *** bajdev has joined #bitcoin-core-dev
522019-06-26T01:09:38 *** bajdev has quit IRC
532019-06-26T01:10:16 *** reallll has joined #bitcoin-core-dev
542019-06-26T01:11:07 *** bajdev has joined #bitcoin-core-dev
552019-06-26T01:13:17 *** bajdev has quit IRC
562019-06-26T01:13:42 *** bajdev has joined #bitcoin-core-dev
572019-06-26T01:13:54 *** belcher has quit IRC
582019-06-26T01:16:21 *** bajdev has quit IRC
592019-06-26T01:16:26 *** e4xit has quit IRC
602019-06-26T01:16:56 *** bajdev has joined #bitcoin-core-dev
612019-06-26T01:20:09 *** pinheadmz has joined #bitcoin-core-dev
622019-06-26T01:22:06 *** bajdev has quit IRC
632019-06-26T01:39:59 *** dviola has joined #bitcoin-core-dev
642019-06-26T01:43:00 *** scoop has quit IRC
652019-06-26T01:44:48 *** Skirmant has joined #bitcoin-core-dev
662019-06-26T01:50:37 *** Henry151 is now known as `
672019-06-26T01:51:06 *** ` is now known as Guest92699
682019-06-26T01:51:46 *** thaumavorio has quit IRC
692019-06-26T01:52:39 *** Guest92699 is now known as Henry151
702019-06-26T01:54:09 *** thaumavorio has joined #bitcoin-core-dev
712019-06-26T01:55:16 *** scoop has joined #bitcoin-core-dev
722019-06-26T01:59:52 *** bralyclow has joined #bitcoin-core-dev
732019-06-26T02:03:04 *** bralyclow01 has quit IRC
742019-06-26T02:11:42 *** PantsMcPants has joined #bitcoin-core-dev
752019-06-26T02:12:18 *** d_t has quit IRC
762019-06-26T02:16:08 *** pinheadmz has quit IRC
772019-06-26T02:24:41 *** scoop has quit IRC
782019-06-26T02:30:01 *** hugohn has joined #bitcoin-core-dev
792019-06-26T02:33:14 *** scoop has joined #bitcoin-core-dev
802019-06-26T02:34:36 *** DeanGuss has joined #bitcoin-core-dev
812019-06-26T02:37:32 *** scoop has quit IRC
822019-06-26T02:38:05 *** d_t has joined #bitcoin-core-dev
832019-06-26T02:45:12 *** kristapsk has quit IRC
842019-06-26T02:45:12 *** DeanGuss has quit IRC
852019-06-26T02:46:13 *** kristapsk has joined #bitcoin-core-dev
862019-06-26T02:46:58 *** mryandao has quit IRC
872019-06-26T02:47:10 *** ghost43 has quit IRC
882019-06-26T02:47:22 *** mryandao has joined #bitcoin-core-dev
892019-06-26T02:47:57 <fanquake> meshcollider are you about to merge that PR. I'm in the middle of doing the same..
902019-06-26T02:48:00 *** morcos has quit IRC
912019-06-26T02:48:18 <meshcollider> Oh yes I am lol
922019-06-26T02:48:43 <meshcollider> Do you want to continue or shall I do it?
932019-06-26T02:48:57 *** ghost43 has joined #bitcoin-core-dev
942019-06-26T02:48:59 <fanquake> I'm basically at sign and push hah
952019-06-26T02:49:04 *** morcos has joined #bitcoin-core-dev
962019-06-26T02:49:13 *** pinheadmz has joined #bitcoin-core-dev
972019-06-26T02:49:18 <meshcollider> Ok go for it :)
982019-06-26T02:50:31 <meshcollider> It's safe to assume I'll see and merge anything tagged with wallet which is RTM within half a day or so, but you beat me to it this time
992019-06-26T02:51:08 <fanquake> cheers, no worries
1002019-06-26T02:54:03 *** bitcoin-git has joined #bitcoin-core-dev
1012019-06-26T02:54:04 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/332c6134bb15...ca80fec973f0
1022019-06-26T02:54:05 <bitcoin-git> bitcoin/master d8bd97d Hennadii Stepanov: Fix GCC 7.4.0 warning
1032019-06-26T02:54:05 <bitcoin-git> bitcoin/master ca80fec fanquake: Merge #16286: refactoring: wallet: Fix GCC 7.4.0 warning
1042019-06-26T02:54:07 *** bitcoin-git has left #bitcoin-core-dev
1052019-06-26T02:55:13 *** bitcoin-git has joined #bitcoin-core-dev
1062019-06-26T02:55:14 <bitcoin-git> [bitcoin] fanquake merged pull request #16286: refactoring: wallet: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
1072019-06-26T02:55:14 *** bitcoin-git has left #bitcoin-core-dev
1082019-06-26T03:00:02 *** nihui has quit IRC
1092019-06-26T03:02:56 *** AaronvanW has joined #bitcoin-core-dev
1102019-06-26T03:04:04 *** Barras2 has joined #bitcoin-core-dev
1112019-06-26T03:07:14 *** surja795 has quit IRC
1122019-06-26T03:13:10 *** DeanGuss has joined #bitcoin-core-dev
1132019-06-26T03:16:36 *** hugohn has quit IRC
1142019-06-26T03:18:44 *** hugohn has joined #bitcoin-core-dev
1152019-06-26T03:35:19 *** AaronvanW has quit IRC
1162019-06-26T03:38:21 *** bralyclow has quit IRC
1172019-06-26T03:44:52 *** hugohn has quit IRC
1182019-06-26T03:46:40 *** hugohn has joined #bitcoin-core-dev
1192019-06-26T03:47:56 *** surja795 has joined #bitcoin-core-dev
1202019-06-26T03:48:13 *** dviola has quit IRC
1212019-06-26T03:49:18 *** bralyclow has joined #bitcoin-core-dev
1222019-06-26T03:50:41 *** bralyclow01 has joined #bitcoin-core-dev
1232019-06-26T03:51:35 *** bralyclo_ has joined #bitcoin-core-dev
1242019-06-26T03:52:57 *** surja795 has quit IRC
1252019-06-26T03:53:23 *** bralycl__ has joined #bitcoin-core-dev
1262019-06-26T03:54:09 *** bralyclow has quit IRC
1272019-06-26T03:55:00 *** bralyclow has joined #bitcoin-core-dev
1282019-06-26T03:55:16 *** bralyclow01 has quit IRC
1292019-06-26T03:56:18 *** bralyclo_ has quit IRC
1302019-06-26T03:57:53 *** bralyclow has quit IRC
1312019-06-26T03:58:34 *** bralycl__ has quit IRC
1322019-06-26T04:00:48 *** kristapsk has quit IRC
1332019-06-26T04:01:23 *** bralyclow has joined #bitcoin-core-dev
1342019-06-26T04:03:14 *** bralyclow01 has joined #bitcoin-core-dev
1352019-06-26T04:06:35 *** AaronvanW has joined #bitcoin-core-dev
1362019-06-26T04:06:39 *** bralyclow has quit IRC
1372019-06-26T04:11:02 *** AaronvanW has quit IRC
1382019-06-26T04:19:00 *** hugohn has quit IRC
1392019-06-26T04:21:32 *** bralyclow01 has quit IRC
1402019-06-26T04:22:43 *** AaronvanW has joined #bitcoin-core-dev
1412019-06-26T04:33:39 *** AaronvanW has quit IRC
1422019-06-26T04:48:46 *** PantsMcPants has quit IRC
1432019-06-26T05:12:51 *** Barras2 has quit IRC
1442019-06-26T05:14:54 *** hebasto has joined #bitcoin-core-dev
1452019-06-26T05:18:42 *** spinza has quit IRC
1462019-06-26T05:22:58 *** total1ty has joined #bitcoin-core-dev
1472019-06-26T05:41:41 *** spinza has joined #bitcoin-core-dev
1482019-06-26T05:49:40 *** luke-jr has quit IRC
1492019-06-26T05:58:45 *** luke-jr has joined #bitcoin-core-dev
1502019-06-26T05:59:25 *** bralyclow has joined #bitcoin-core-dev
1512019-06-26T06:00:01 *** total1ty has quit IRC
1522019-06-26T06:03:33 *** jonatack has joined #bitcoin-core-dev
1532019-06-26T06:05:48 *** jonatack has quit IRC
1542019-06-26T06:10:53 *** jonatack has joined #bitcoin-core-dev
1552019-06-26T06:14:33 *** jonatack has quit IRC
1562019-06-26T06:15:42 *** Dantman has joined #bitcoin-core-dev
1572019-06-26T06:23:29 *** elichai2 has quit IRC
1582019-06-26T06:24:17 *** queip has quit IRC
1592019-06-26T06:24:18 *** tryphe_ is now known as tryphe
1602019-06-26T06:24:55 *** rafalcpp has joined #bitcoin-core-dev
1612019-06-26T06:25:30 *** rafalcpp_ has quit IRC
1622019-06-26T06:30:28 *** queip has joined #bitcoin-core-dev
1632019-06-26T06:31:58 *** d_t has quit IRC
1642019-06-26T06:32:39 *** sipa has quit IRC
1652019-06-26T06:37:55 *** sipa has joined #bitcoin-core-dev
1662019-06-26T06:49:43 *** sipa has quit IRC
1672019-06-26T06:49:57 *** sipa has joined #bitcoin-core-dev
1682019-06-26T06:50:08 *** scoop has joined #bitcoin-core-dev
1692019-06-26T06:56:24 <fanquake> NicolasDorier: Restarted the test for you.
1702019-06-26T07:00:20 *** scoop has quit IRC
1712019-06-26T07:05:47 *** sipa has quit IRC
1722019-06-26T07:06:01 *** sipa has joined #bitcoin-core-dev
1732019-06-26T07:20:21 *** reallll is now known as belcher
1742019-06-26T07:32:04 *** scoop has joined #bitcoin-core-dev
1752019-06-26T07:36:06 *** scoop has quit IRC
1762019-06-26T07:38:13 *** EagleTM has quit IRC
1772019-06-26T07:47:38 *** scoop has joined #bitcoin-core-dev
1782019-06-26T07:51:46 *** scoop has quit IRC
1792019-06-26T08:03:10 *** scoop has joined #bitcoin-core-dev
1802019-06-26T08:07:32 *** scoop has quit IRC
1812019-06-26T08:18:40 *** scoop has joined #bitcoin-core-dev
1822019-06-26T08:20:08 *** double_helix has quit IRC
1832019-06-26T08:23:18 *** scoop has quit IRC
1842019-06-26T08:28:57 *** laptop500 has joined #bitcoin-core-dev
1852019-06-26T08:34:14 *** scoop has joined #bitcoin-core-dev
1862019-06-26T08:38:22 *** scoop has quit IRC
1872019-06-26T08:45:31 *** belcher has quit IRC
1882019-06-26T08:47:51 *** promag_ has joined #bitcoin-core-dev
1892019-06-26T08:49:43 *** scoop has joined #bitcoin-core-dev
1902019-06-26T08:54:06 *** scoop has quit IRC
1912019-06-26T08:54:29 *** sipa has quit IRC
1922019-06-26T08:55:38 *** double_helix has joined #bitcoin-core-dev
1932019-06-26T08:59:24 *** setpill has joined #bitcoin-core-dev
1942019-06-26T09:00:02 *** Dantman has quit IRC
1952019-06-26T09:05:10 *** hebasto has quit IRC
1962019-06-26T09:09:37 *** darosior has joined #bitcoin-core-dev
1972019-06-26T09:14:48 *** sipa has joined #bitcoin-core-dev
1982019-06-26T09:16:48 *** visser_ has joined #bitcoin-core-dev
1992019-06-26T09:23:30 *** EagleTM has joined #bitcoin-core-dev
2002019-06-26T09:27:17 *** goatpig has quit IRC
2012019-06-26T09:31:03 *** promag_ has quit IRC
2022019-06-26T09:32:58 *** timothy has joined #bitcoin-core-dev
2032019-06-26T09:35:17 *** bitcoin-git has joined #bitcoin-core-dev
2042019-06-26T09:35:17 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #16289: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289
2052019-06-26T09:35:18 *** bitcoin-git has left #bitcoin-core-dev
2062019-06-26T09:41:32 <jonasschnelli> MarcoFalke: how is travis caching .ccache? Per job? Or does it combine/merge files in that cache folder?
2072019-06-26T09:41:44 *** bushstar has joined #bitcoin-core-dev
2082019-06-26T09:43:11 *** bitcoin-git has joined #bitcoin-core-dev
2092019-06-26T09:43:11 <bitcoin-git> [bitcoin] Bushstar opened pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290
2102019-06-26T09:43:13 *** bitcoin-git has left #bitcoin-core-dev
2112019-06-26T09:43:14 *** michaelfolkson has joined #bitcoin-core-dev
2122019-06-26T09:43:43 *** Emcy has quit IRC
2132019-06-26T09:50:54 *** bushstar has quit IRC
2142019-06-26T09:56:22 *** Emcy has joined #bitcoin-core-dev
2152019-06-26T09:56:36 *** victorSN has quit IRC
2162019-06-26T09:56:36 *** rockhouse has quit IRC
2172019-06-26T09:57:21 *** queip has quit IRC
2182019-06-26T09:57:42 *** rafalcpp_ has joined #bitcoin-core-dev
2192019-06-26T09:57:54 *** rafalcpp has quit IRC
2202019-06-26T09:58:03 *** sipa has quit IRC
2212019-06-26T10:02:18 *** laptop500 has quit IRC
2222019-06-26T10:03:45 *** queip has joined #bitcoin-core-dev
2232019-06-26T10:05:49 *** promag_ has joined #bitcoin-core-dev
2242019-06-26T10:06:28 *** spinza has quit IRC
2252019-06-26T10:08:18 *** sipa has joined #bitcoin-core-dev
2262019-06-26T10:22:39 *** darosior has quit IRC
2272019-06-26T10:24:40 *** surja795 has joined #bitcoin-core-dev
2282019-06-26T10:27:37 *** laptop500 has joined #bitcoin-core-dev
2292019-06-26T10:31:36 *** bitcoin-git has joined #bitcoin-core-dev
2302019-06-26T10:31:36 <bitcoin-git> [bitcoin] fanquake closed pull request #16290: NULL to nullptr (master...null-to-nullptr) https://github.com/bitcoin/bitcoin/pull/16290
2312019-06-26T10:31:44 *** bitcoin-git has left #bitcoin-core-dev
2322019-06-26T10:32:24 *** michaelfolkson has joined #bitcoin-core-dev
2332019-06-26T10:32:33 *** surja795 has quit IRC
2342019-06-26T10:38:56 *** darosior has joined #bitcoin-core-dev
2352019-06-26T10:39:05 *** spinza has joined #bitcoin-core-dev
2362019-06-26T10:39:48 *** sipa has quit IRC
2372019-06-26T10:40:02 *** sipa has joined #bitcoin-core-dev
2382019-06-26T10:40:35 <fanquake> Be good to get some eyes over #16035. A couple of unclean cherry-picks, important bug fixes etc for 0.18.1.
2392019-06-26T10:40:37 <gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
2402019-06-26T10:46:38 *** csknk has joined #bitcoin-core-dev
2412019-06-26T10:47:29 *** csknk has quit IRC
2422019-06-26T10:49:26 <fanquake> If anyone is interested in some build system review. Cory has a PR open on the bitcoin-core/univalue repo: https://github.com/bitcoin-core/univalue/pull/19
2432019-06-26T10:51:06 *** shesek has joined #bitcoin-core-dev
2442019-06-26T10:51:06 *** shesek has joined #bitcoin-core-dev
2452019-06-26T10:52:00 *** Emcy has joined #bitcoin-core-dev
2462019-06-26T11:12:01 *** rockhouse has joined #bitcoin-core-dev
2472019-06-26T11:12:19 *** victorSN has joined #bitcoin-core-dev
2482019-06-26T11:14:19 *** michaelfolkson has quit IRC
2492019-06-26T11:19:34 *** spinza has quit IRC
2502019-06-26T11:27:39 *** michaelfolkson has joined #bitcoin-core-dev
2512019-06-26T11:28:52 *** mr_burdell has quit IRC
2522019-06-26T11:30:04 *** mr_burdell has joined #bitcoin-core-dev
2532019-06-26T11:30:08 *** shesek has quit IRC
2542019-06-26T11:31:02 *** promag_ has quit IRC
2552019-06-26T11:31:29 *** rafalcpp has joined #bitcoin-core-dev
2562019-06-26T11:31:43 *** rafalcpp_ has quit IRC
2572019-06-26T11:32:02 *** queip has quit IRC
2582019-06-26T11:36:33 *** spinza has joined #bitcoin-core-dev
2592019-06-26T11:37:56 *** queip has joined #bitcoin-core-dev
2602019-06-26T11:40:58 *** michaelfolkson has quit IRC
2612019-06-26T11:41:45 *** darosior has quit IRC
2622019-06-26T11:49:12 *** michaelfolkson has joined #bitcoin-core-dev
2632019-06-26T11:58:16 *** lnostdal has quit IRC
2642019-06-26T11:59:12 *** michaelfolkson has quit IRC
2652019-06-26T12:00:01 *** visser_ has quit IRC
2662019-06-26T12:04:17 *** mr_burdell has quit IRC
2672019-06-26T12:04:29 *** Jayflux has joined #bitcoin-core-dev
2682019-06-26T12:07:00 *** mr_burdell has joined #bitcoin-core-dev
2692019-06-26T12:19:12 *** mr_burdell has quit IRC
2702019-06-26T12:21:54 *** kljasdfvv has joined #bitcoin-core-dev
2712019-06-26T12:22:33 *** cubancorona has quit IRC
2722019-06-26T12:24:00 *** mr_burdell has joined #bitcoin-core-dev
2732019-06-26T12:29:31 *** e4xit has joined #bitcoin-core-dev
2742019-06-26T12:32:33 *** mr_burdell has quit IRC
2752019-06-26T12:36:17 *** michaelfolkson has joined #bitcoin-core-dev
2762019-06-26T12:39:28 *** mr_burdell has joined #bitcoin-core-dev
2772019-06-26T12:40:37 *** michaelfolkson has quit IRC
2782019-06-26T12:45:48 *** DeanGuss has quit IRC
2792019-06-26T12:47:43 *** michaelfolkson has joined #bitcoin-core-dev
2802019-06-26T12:48:31 *** hrofu has quit IRC
2812019-06-26T12:51:08 *** Guest45841 has joined #bitcoin-core-dev
2822019-06-26T12:55:47 *** hesghasaq has joined #bitcoin-core-dev
2832019-06-26T12:56:09 *** hesghasa_ has joined #bitcoin-core-dev
2842019-06-26T12:56:25 *** hesghasa_ has quit IRC
2852019-06-26T12:56:36 *** nijak has joined #bitcoin-core-dev
2862019-06-26T12:57:49 *** hugohn has joined #bitcoin-core-dev
2872019-06-26T12:58:30 *** hugohn has quit IRC
2882019-06-26T12:58:39 *** Emcy has quit IRC
2892019-06-26T12:59:45 *** hugohn has joined #bitcoin-core-dev
2902019-06-26T13:00:07 *** hesghasaq has quit IRC
2912019-06-26T13:00:47 *** nijak has quit IRC
2922019-06-26T13:01:02 *** elichai2 has joined #bitcoin-core-dev
2932019-06-26T13:06:08 <promag> fanquake: will look those backports
2942019-06-26T13:06:38 *** nijak has joined #bitcoin-core-dev
2952019-06-26T13:06:58 *** laptop500 has quit IRC
2962019-06-26T13:08:56 *** spaced0ut has joined #bitcoin-core-dev
2972019-06-26T13:09:51 *** hugohn has quit IRC
2982019-06-26T13:17:13 *** bitcoin-git has joined #bitcoin-core-dev
2992019-06-26T13:17:13 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca80fec973f0...1b28bca04c27
3002019-06-26T13:17:14 <bitcoin-git> bitcoin/master 9824a0d RJ Rybarczyk: Remove extra CBlockIndex declaration
3012019-06-26T13:17:14 <bitcoin-git> bitcoin/master 1b28bca MarcoFalke: Merge #16287: refactor: remove extra CBlockIndex declaration
3022019-06-26T13:17:16 *** bitcoin-git has left #bitcoin-core-dev
3032019-06-26T13:18:18 *** bitcoin-git has joined #bitcoin-core-dev
3042019-06-26T13:18:18 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16287: refactor: remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
3052019-06-26T13:18:20 *** bitcoin-git has left #bitcoin-core-dev
3062019-06-26T13:28:12 *** scoop has joined #bitcoin-core-dev
3072019-06-26T13:29:16 *** michaelfolkson has quit IRC
3082019-06-26T13:30:43 *** michaelfolkson has joined #bitcoin-core-dev
3092019-06-26T13:34:35 *** AaronvanW has joined #bitcoin-core-dev
3102019-06-26T13:38:49 *** aseem has joined #bitcoin-core-dev
3112019-06-26T13:41:18 *** omonk has quit IRC
3122019-06-26T13:41:20 *** Guyver2 has joined #bitcoin-core-dev
3132019-06-26T13:44:28 *** omonk has joined #bitcoin-core-dev
3142019-06-26T13:49:27 *** ricardobessa has joined #bitcoin-core-dev
3152019-06-26T13:50:25 *** d_t has joined #bitcoin-core-dev
3162019-06-26T13:50:28 *** ricardobessa has left #bitcoin-core-dev
3172019-06-26T13:51:05 *** hugohn has joined #bitcoin-core-dev
3182019-06-26T13:52:16 *** bralyclow01 has joined #bitcoin-core-dev
3192019-06-26T13:54:41 *** bralyclow has quit IRC
3202019-06-26T13:55:03 *** d_t has quit IRC
3212019-06-26T13:59:42 *** michaelfolkson has quit IRC
3222019-06-26T14:10:20 *** hugohn has quit IRC
3232019-06-26T14:11:50 *** hugohn has joined #bitcoin-core-dev
3242019-06-26T14:18:04 *** spaced0ut has quit IRC
3252019-06-26T14:33:40 *** bralyclow has joined #bitcoin-core-dev
3262019-06-26T14:34:12 *** mr_burdell has quit IRC
3272019-06-26T14:35:13 *** mr_burdell has joined #bitcoin-core-dev
3282019-06-26T14:36:00 *** michaelfolkson has joined #bitcoin-core-dev
3292019-06-26T14:36:34 *** bralyclow01 has quit IRC
3302019-06-26T14:39:10 *** TheRec has quit IRC
3312019-06-26T14:40:10 *** ccdle12 has joined #bitcoin-core-dev
3322019-06-26T14:43:16 *** TheRec has joined #bitcoin-core-dev
3332019-06-26T14:43:16 *** TheRec has joined #bitcoin-core-dev
3342019-06-26T14:46:09 *** hebasto has joined #bitcoin-core-dev
3352019-06-26T14:48:08 *** michaelfolkson has quit IRC
3362019-06-26T14:48:30 *** kljasdfvv has quit IRC
3372019-06-26T14:52:13 *** scoop has quit IRC
3382019-06-26T14:52:57 *** jason_ has quit IRC
3392019-06-26T14:53:14 *** jason has joined #bitcoin-core-dev
3402019-06-26T14:53:37 *** jason is now known as Guest61179
3412019-06-26T14:54:58 *** scoop has joined #bitcoin-core-dev
3422019-06-26T14:55:05 *** bralyclow has quit IRC
3432019-06-26T14:57:55 *** bralyclow has joined #bitcoin-core-dev
3442019-06-26T15:00:02 *** Jayflux has quit IRC
3452019-06-26T15:01:18 *** Emcy has joined #bitcoin-core-dev
3462019-06-26T15:02:32 *** bralyclow has quit IRC
3472019-06-26T15:03:07 *** goatpig has joined #bitcoin-core-dev
3482019-06-26T15:03:10 *** bralyclow has joined #bitcoin-core-dev
3492019-06-26T15:03:15 *** setpill has quit IRC
3502019-06-26T15:04:00 *** pinheadmz has quit IRC
3512019-06-26T15:04:32 *** Emcy_ has joined #bitcoin-core-dev
3522019-06-26T15:05:23 *** michaelsdunn1 has joined #bitcoin-core-dev
3532019-06-26T15:05:23 *** michaelsdunn1 has quit IRC
3542019-06-26T15:05:23 *** michaelsdunn1 has joined #bitcoin-core-dev
3552019-06-26T15:05:48 *** AaronvanW has quit IRC
3562019-06-26T15:07:44 *** Emcy has quit IRC
3572019-06-26T15:08:19 *** lnostdal has joined #bitcoin-core-dev
3582019-06-26T15:11:51 *** bitcoin-git has joined #bitcoin-core-dev
3592019-06-26T15:11:51 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
3602019-06-26T15:11:53 *** bitcoin-git has left #bitcoin-core-dev
3612019-06-26T15:12:54 *** bralyclow has quit IRC
3622019-06-26T15:13:45 *** bralyclow has joined #bitcoin-core-dev
3632019-06-26T15:18:08 *** mr_burdell has quit IRC
3642019-06-26T15:22:08 *** kaimi1 has joined #bitcoin-core-dev
3652019-06-26T15:22:20 *** mr_burdell has joined #bitcoin-core-dev
3662019-06-26T15:22:50 *** hugohn has quit IRC
3672019-06-26T15:24:12 *** jarthur has joined #bitcoin-core-dev
3682019-06-26T15:24:41 *** dgenr8 has joined #bitcoin-core-dev
3692019-06-26T15:26:11 *** hugohn has joined #bitcoin-core-dev
3702019-06-26T15:39:54 *** hugohn has quit IRC
3712019-06-26T15:41:18 *** aseem has quit IRC
3722019-06-26T15:41:19 *** aseem_ has joined #bitcoin-core-dev
3732019-06-26T15:42:56 *** aseem_ has quit IRC
3742019-06-26T15:46:37 *** hugohn has joined #bitcoin-core-dev
3752019-06-26T15:47:21 *** scoop has quit IRC
3762019-06-26T15:47:25 *** aseem has joined #bitcoin-core-dev
3772019-06-26T15:49:59 *** scoop has joined #bitcoin-core-dev
3782019-06-26T15:58:56 *** csknk has joined #bitcoin-core-dev
3792019-06-26T15:59:28 *** hugohn has quit IRC
3802019-06-26T16:02:18 *** d_t has joined #bitcoin-core-dev
3812019-06-26T16:10:47 *** pinheadmz has joined #bitcoin-core-dev
3822019-06-26T16:12:27 *** michaelfolkson has joined #bitcoin-core-dev
3832019-06-26T16:28:19 *** rafalcpp_ has joined #bitcoin-core-dev
3842019-06-26T16:28:47 *** rafalcpp has quit IRC
3852019-06-26T16:28:47 *** queip has quit IRC
3862019-06-26T16:32:51 *** jtimon has joined #bitcoin-core-dev
3872019-06-26T16:35:13 *** queip has joined #bitcoin-core-dev
3882019-06-26T16:36:31 *** aseem has quit IRC
3892019-06-26T16:36:54 *** aseem has joined #bitcoin-core-dev
3902019-06-26T16:38:00 *** Skirmant has quit IRC
3912019-06-26T16:48:01 *** aseem has quit IRC
3922019-06-26T16:49:58 *** luke-jr has quit IRC
3932019-06-26T16:50:24 *** luke-jr has joined #bitcoin-core-dev
3942019-06-26T16:57:51 *** lightlike has joined #bitcoin-core-dev
3952019-06-26T17:01:36 *** aseem has joined #bitcoin-core-dev
3962019-06-26T17:11:30 *** r8921039 has joined #bitcoin-core-dev
3972019-06-26T17:14:54 *** belcher has joined #bitcoin-core-dev
3982019-06-26T17:17:18 *** cidercider has joined #bitcoin-core-dev
3992019-06-26T17:20:25 *** scoop has quit IRC
4002019-06-26T17:26:13 *** b10c has joined #bitcoin-core-dev
4012019-06-26T17:28:50 *** pinheadmz has quit IRC
4022019-06-26T17:29:17 *** bitcoin-git has joined #bitcoin-core-dev
4032019-06-26T17:29:17 <bitcoin-git> [bitcoin] instagibbs opened pull request #16292: wallet_resendwallettransaction.py: fix coinbase height (master...resend_test_height) https://github.com/bitcoin/bitcoin/pull/16292
4042019-06-26T17:29:18 *** bitcoin-git has left #bitcoin-core-dev
4052019-06-26T17:30:07 *** pinheadmz has joined #bitcoin-core-dev
4062019-06-26T17:31:02 *** pinheadmz has quit IRC
4072019-06-26T17:35:00 <jtimon> regarding https://github.com/bitcoin/bitcoin/pull/8994 I'm not sure it needs conceptual review (I'm sure there's many concept acks buried in the comments), but mostly review and re-review
4082019-06-26T17:39:32 *** dfsg has joined #bitcoin-core-dev
4092019-06-26T17:39:45 *** dfsg has left #bitcoin-core-dev
4102019-06-26T17:41:59 *** michaelfolkson has quit IRC
4112019-06-26T17:50:14 *** Jaamg_ has joined #bitcoin-core-dev
4122019-06-26T17:50:51 *** bitcoin-git has joined #bitcoin-core-dev
4132019-06-26T17:50:52 <bitcoin-git> [bitcoin] practicalswift closed pull request #16045: Skip redundant memset(p, 0, 0) calls where p is not valid for writing (master...redundant-memsets) https://github.com/bitcoin/bitcoin/pull/16045
4142019-06-26T17:50:53 *** bitcoin-git has left #bitcoin-core-dev
4152019-06-26T17:52:31 *** tynes has joined #bitcoin-core-dev
4162019-06-26T17:53:21 *** bitcoin-git has joined #bitcoin-core-dev
4172019-06-26T17:53:22 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16293: test: Make test cases separate functions (master...1906-testNoScopeLeak) https://github.com/bitcoin/bitcoin/pull/16293
4182019-06-26T17:53:23 *** bitcoin-git has left #bitcoin-core-dev
4192019-06-26T17:53:45 *** Jaamg has quit IRC
4202019-06-26T17:53:45 *** phantomcircuit has quit IRC
4212019-06-26T17:53:45 *** tynes_ has quit IRC
4222019-06-26T17:54:18 *** omonk has quit IRC
4232019-06-26T17:55:44 *** dfsg has joined #bitcoin-core-dev
4242019-06-26T17:55:48 *** dfsg has left #bitcoin-core-dev
4252019-06-26T17:56:03 *** phantomcircuit has joined #bitcoin-core-dev
4262019-06-26T17:57:17 *** omonk has joined #bitcoin-core-dev
4272019-06-26T17:57:41 <MarcoFalke> [05:41] <jonasschnelli> MarcoFalke: how is travis caching .ccache? Per job? Or does it combine/merge files in that cache folder?
4282019-06-26T17:57:44 <MarcoFalke> It should be per job
4292019-06-26T17:58:20 <jonasschnelli> so per build? per job would not make much sense?
4302019-06-26T17:58:22 <MarcoFalke> I think they run something like $(env | md5sum) to get the cache name, so that should be different for each entry in the matrix
4312019-06-26T17:58:36 <jonasschnelli> I see...
4322019-06-26T17:58:39 <jonasschnelli> yes. Makes sense
4332019-06-26T17:58:41 <MarcoFalke> each HOST should have their own cache
4342019-06-26T17:59:02 <jonasschnelli> maybe based on the job name or so
4352019-06-26T17:59:13 <jonasschnelli> (or as you said a hash of the env)
4362019-06-26T18:00:01 *** kaimi1 has quit IRC
4372019-06-26T18:01:56 *** hugohn has joined #bitcoin-core-dev
4382019-06-26T18:02:36 *** timothy has quit IRC
4392019-06-26T18:04:12 <MarcoFalke> E.g the arm hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550863420#L160 is 42c149c5429f559658e55580a560c8f631c5a8c8bb2db228b3b73635f0e90558
4402019-06-26T18:04:59 <MarcoFalke> And the win64 hash: https://travis-ci.org/bitcoin/bitcoin/jobs/550927504#L159 is d42e27fad05b3f827b638d9dda4edcac0b86aeefd6658d03f48468bbde9b1845
4412019-06-26T18:06:38 <MarcoFalke> doc: https://docs.travis-ci.com/user/caching/#caches-and-build-matrices
4422019-06-26T18:12:00 *** MTecknology1 has joined #bitcoin-core-dev
4432019-06-26T18:20:15 *** spaced0ut has joined #bitcoin-core-dev
4442019-06-26T18:21:36 *** pinheadmz has joined #bitcoin-core-dev
4452019-06-26T18:22:18 *** dviola has joined #bitcoin-core-dev
4462019-06-26T18:23:47 *** hugohn has quit IRC
4472019-06-26T18:23:52 *** rex4539 has joined #bitcoin-core-dev
4482019-06-26T18:26:34 <dongcarl> For #13989, I'm wondering what the policy is for adding intrinsics like this. According to jamesob's benchmarks here https://github.com/bitcoin/bitcoin/pull/13989#issuecomment-497381424. I see that: 1. The PR significantly improves SHA-intensive microbenchmarks: `micro.gcc.MerkleRoot` and `micro.gcc.SHA256D64_1024`. 2. It does not speed up IBD performance significantly.
4492019-06-26T18:26:36 <gribble> https://github.com/bitcoin/bitcoin/issues/13989 | add avx512 instrinsic by fingera · Pull Request #13989 · bitcoin/bitcoin · GitHub
4502019-06-26T18:27:04 <dongcarl> Is this something that's worth keeping maintained in the codebase? I see that there's precedent already with AVX(2)
4512019-06-26T18:27:22 *** r8921039 has quit IRC
4522019-06-26T18:27:52 *** r8921039 has joined #bitcoin-core-dev
4532019-06-26T18:28:14 <jamesob> imo we shouldn't trust chip manufacturers with SHA implementations unless there's a really compelling performance reason to do so
4542019-06-26T18:29:47 *** scoop has joined #bitcoin-core-dev
4552019-06-26T18:30:45 <jamesob> let me amend that to "imo we shouldn't trust chip manufacturers with SHA implementations" :)
4562019-06-26T18:32:07 *** scoop has quit IRC
4572019-06-26T18:32:34 <sipa> dongcarl: SHA256 performance mainly affects propagation speed, not IBD
4582019-06-26T18:32:43 <sipa> which we don't have good benchmarks for
4592019-06-26T18:33:12 * dongcarl thinking
4602019-06-26T18:33:14 <BlueMatt> sipa: the total CheckBlock time in IBD isn't 0, though?
4612019-06-26T18:33:18 <BlueMatt> especially with assumevalid
4622019-06-26T18:33:25 *** csknk has quit IRC
4632019-06-26T18:34:43 *** hugohn has joined #bitcoin-core-dev
4642019-06-26T18:34:50 *** scoop has joined #bitcoin-core-dev
4652019-06-26T18:34:52 <sipa> BlueMatt: yeah, true
4662019-06-26T18:35:01 <sipa> still, i don't expect IBD to be bottlenecked by sha256
4672019-06-26T18:35:22 <BlueMatt> it is (for now) critical-path, though I do want to change that.....
4682019-06-26T18:36:08 <dongcarl> So is there consensus around whether to continue maintaining intrinsics? Should they be phased out over time, or we just don't add new ones?
4692019-06-26T18:36:15 *** scoop has quit IRC
4702019-06-26T18:36:19 *** scoop_ has joined #bitcoin-core-dev
4712019-06-26T18:36:35 *** cidercider has quit IRC
4722019-06-26T18:36:55 <sipa> dongcarl: i suggest you try comparing performance with versions without any intrinsics :)
4732019-06-26T18:37:11 <sipa> (we have sse4, avx2, and shani based optimized code already, which you may be seeing)
4742019-06-26T18:37:32 <sipa> i don't see any reason why we'd drop them?
4752019-06-26T18:38:04 *** rafalcpp has joined #bitcoin-core-dev
4762019-06-26T18:38:22 *** queip has quit IRC
4772019-06-26T18:38:45 *** rafalcpp_ has quit IRC
4782019-06-26T18:38:46 *** scoop_ has quit IRC
4792019-06-26T18:39:01 *** scoop has joined #bitcoin-core-dev
4802019-06-26T18:39:17 <dongcarl> perhaps I'm misunderstanding but jamesob brought up the point that we might not want to trust chip manufacturers with SHA implementations?
4812019-06-26T18:39:35 <sipa> we're trusting them entirely for everything else already?
4822019-06-26T18:39:43 <jamesob> nvm, I think *I* misunderstood there - I thought the intrinsics were doing more than they rae
4832019-06-26T18:40:19 *** aseem has quit IRC
4842019-06-26T18:41:06 *** aseem has joined #bitcoin-core-dev
4852019-06-26T18:41:06 <dongcarl> sipa: true
4862019-06-26T18:42:31 <dongcarl> have there been previous attempts at benchmarking propagation speed? (what would that even entail?)
4872019-06-26T18:44:07 *** queip has joined #bitcoin-core-dev
4882019-06-26T18:46:35 *** aseem has quit IRC
4892019-06-26T18:47:18 *** aseem has joined #bitcoin-core-dev
4902019-06-26T18:47:46 <sipa> jamesob: they're just syntactic C sugar for platform-specific assembly instructions
4912019-06-26T18:48:55 <jamesob> sipa: gotcha; for some reason I had it in my head that we may be wanting to make use of some sha256 native instruction
4922019-06-26T18:49:15 <sipa> we are; through intrinsics in some cases :)
4932019-06-26T18:51:37 *** scoop has quit IRC
4942019-06-26T18:55:20 *** scoop_ has joined #bitcoin-core-dev
4952019-06-26T18:58:09 *** pinheadmz has joined #bitcoin-core-dev
4962019-06-26T18:59:09 *** scoop has joined #bitcoin-core-dev
4972019-06-26T18:59:17 *** scoop_ has quit IRC
4982019-06-26T19:00:35 *** scoop has quit IRC
4992019-06-26T19:00:42 *** scoop has joined #bitcoin-core-dev
5002019-06-26T19:02:15 *** pinheadmz has quit IRC
5012019-06-26T19:03:32 *** pinheadmz has joined #bitcoin-core-dev
5022019-06-26T19:04:05 *** omonk has quit IRC
5032019-06-26T19:04:23 *** scoop has quit IRC
5042019-06-26T19:04:50 *** scoop has joined #bitcoin-core-dev
5052019-06-26T19:05:03 *** b10c has quit IRC
5062019-06-26T19:05:58 *** pinheadmz has quit IRC
5072019-06-26T19:07:04 *** pinheadmz has joined #bitcoin-core-dev
5082019-06-26T19:07:06 *** omonk has joined #bitcoin-core-dev
5092019-06-26T19:09:00 *** scoop has quit IRC
5102019-06-26T19:11:42 *** hugohn has quit IRC
5112019-06-26T19:12:13 <dongcarl> sipa: The rationale here is that SHA-NI seems to be faster than SSE4/AVX2 in all cases? https://github.com/bitcoin/bitcoin/pull/13386/files#diff-cf563899256ae1ec7ee78b61806e40caR608
5122019-06-26T19:12:25 <sipa> yes
5132019-06-26T19:13:49 *** pinheadmz has quit IRC
5142019-06-26T19:15:32 *** aseem has quit IRC
5152019-06-26T19:15:40 <sipa> dongcarl: it could have been written as an else branch instead
5162019-06-26T19:15:47 <sipa> but it's kinda hard with all the conditional compilation
5172019-06-26T19:15:59 *** aseem has joined #bitcoin-core-dev
5182019-06-26T19:16:09 <sipa> once you've installed a sha-ni based hasher, you don't want it to be overwritten afterwards with a measly sse4-based one
5192019-06-26T19:17:31 <dongcarl> sipa: Right... So when we add AVX512 we should also disable it like you did? Or are benchmarks required before that call can be made?
5202019-06-26T19:19:34 *** aseem has quit IRC
5212019-06-26T19:20:42 <sipa> dongcarl: AVX512 only lets you speed up 16-way hashing; not 8-way, 4-way, 2-way, 1-way, or double-64byte :)
5222019-06-26T19:20:45 <sipa> so no
5232019-06-26T19:21:12 <sipa> AVX2 code right now is also only used for 8-way hashing, but 4-way is still done using the sse4 based code
5242019-06-26T19:21:34 <sipa> this is different from sha-ni which gives you a faster 1-way hash
5252019-06-26T19:22:29 *** aseem has joined #bitcoin-core-dev
5262019-06-26T19:23:22 *** hebasto has quit IRC
5272019-06-26T19:24:25 *** aseem has quit IRC
5282019-06-26T19:24:49 *** aseem has joined #bitcoin-core-dev
5292019-06-26T19:25:22 <sipa> dongcarl: maybe this isn't obvious, but the AVX2/AVX512 instructions really just give you a fast way to implement the computation of 8/16 (for avx2/avx512) hashes simultaneously
5302019-06-26T19:25:51 <sipa> if you'd use AVX512 based code to compute just one hash, you'd need to fill the buffers with 15 pieces of dummy input, and hash those at the same time still
5312019-06-26T19:25:59 * dongcarl digesting and thinking
5322019-06-26T19:26:19 <sipa> but the AVX512 code for 16 hashes is slower than just using naive non-optimized SHA
5332019-06-26T19:26:43 <sipa> so it's only worth it when you actually have 16 things to hash
5342019-06-26T19:27:07 <sipa> it's very likely that AVX512 (for 16 hashes) is also slower than AVX2 (for 8 hashes)
5352019-06-26T19:27:24 <sipa> same as AVX2 (for 8 hashes) is usually slower than using SSE4 (for 4 hashes)
5362019-06-26T19:27:40 <sipa> slower in clock time; per hash it's obviously faster, or we wouldn't have the code at all
5372019-06-26T19:27:50 <sipa> does that make sense?
5382019-06-26T19:28:41 <dongcarl> sipa: I guess I'm not understanding why we disable SSE4/AVX2 when SHA-NI is present, but you're saying we shouldn't disable AVX512?
5392019-06-26T19:29:04 <sipa> dongcarl: because SHA-NI just gives you superfast code to compute *one* hash
5402019-06-26T19:29:28 <sipa> you can't even implement computing *one* hash with AVX512; you always compute 16
5412019-06-26T19:30:04 <sipa> so if you have SHA-NI you want to use it for everything
5422019-06-26T19:30:22 <sipa> with AVX512 you don't only don't want to use it for everything; you can't
5432019-06-26T19:30:58 *** scoop has joined #bitcoin-core-dev
5442019-06-26T19:31:26 <dongcarl> Right I believe I understand that. But thinking along this line of logic, shouldn't we disable AVX512 when SHA-NI is present?
5452019-06-26T19:31:35 <sipa> oh!
5462019-06-26T19:31:36 <sipa> yes
5472019-06-26T19:32:10 <sipa> i thought you were asking if we shouldn't disable SSE4/AVX2 when AVX512 is present; the answer there is no
5482019-06-26T19:32:26 <sipa> SHA-NI will likely be faster than AVX512 code, even for 16 hashes
5492019-06-26T19:32:41 <dongcarl> Haha okay cool that makes perfect sense! Thanks for your patience!
5502019-06-26T19:32:48 <sipa> np!
5512019-06-26T19:35:27 *** scoop has quit IRC
5522019-06-26T19:35:30 <sipa> that's actually something you may want to benchmark, whether 16-way AVX512 isn't faster per hash than SHA-NI
5532019-06-26T19:35:43 <sipa> unfortunately, I don't think any hardware exists with both AVX512 and SHA-NI :p
5542019-06-26T19:37:31 <dongcarl> sipa: True. Why aren't there overlaps in hardware?
5552019-06-26T19:38:04 <sipa> for some reason AMD has been much faster with rolling out SHA-NI support than Intel... which is surprising as SHA-NI was designed and proposed by Intel
5562019-06-26T19:39:22 <dongcarl> sipa: Ahhh... probably doesn't make much sense to benchmark when there isn't a machine that supports both then...
5572019-06-26T19:40:13 <luke-jr> sipa: AFAIK there must have been hardware issues, as earlier Intel CPUs were advertised to have it, then they backed out
5582019-06-26T19:40:14 *** lnostdal has quit IRC
5592019-06-26T19:40:34 <luke-jr> actually, I would think some Atoms have both?
5602019-06-26T19:41:19 *** Emcy_ has quit IRC
5612019-06-26T19:41:41 <sipa> luke-jr: atoms have avx512?
5622019-06-26T19:41:45 <luke-jr> unsure
5632019-06-26T19:42:51 <luke-jr> nah, looks like Intel left it out of them
5642019-06-26T19:43:01 *** Emcy_ has joined #bitcoin-core-dev
5652019-06-26T19:43:46 *** hugohn has joined #bitcoin-core-dev
5662019-06-26T19:44:27 <luke-jr> fwiw, what BFGMiner did for CPU mining, is benchmark all algorithms in separate processes, then use the best performing
5672019-06-26T19:45:00 <luke-jr> (at startup)
5682019-06-26T19:48:21 <sipa> yeah
5692019-06-26T19:48:35 <sipa> that may be necessary at some point
5702019-06-26T20:06:15 *** scoop has joined #bitcoin-core-dev
5712019-06-26T20:07:20 *** hugohn has quit IRC
5722019-06-26T20:08:37 *** scoop_ has joined #bitcoin-core-dev
5732019-06-26T20:10:26 *** scoop has quit IRC
5742019-06-26T20:13:01 *** scoop_ has quit IRC
5752019-06-26T20:13:43 *** belcher has quit IRC
5762019-06-26T20:17:31 *** promag_ has joined #bitcoin-core-dev
5772019-06-26T20:18:16 *** promag__ has joined #bitcoin-core-dev
5782019-06-26T20:19:37 *** Skirmant has joined #bitcoin-core-dev
5792019-06-26T20:21:23 *** e4xit has quit IRC
5802019-06-26T20:26:33 *** hugohn has joined #bitcoin-core-dev
5812019-06-26T20:33:52 *** ccdle12 has quit IRC
5822019-06-26T20:36:09 *** sturles has quit IRC
5832019-06-26T20:36:16 *** sturles has joined #bitcoin-core-dev
5842019-06-26T20:36:16 *** sturles has joined #bitcoin-core-dev
5852019-06-26T20:36:40 *** bitcoin-git has joined #bitcoin-core-dev
5862019-06-26T20:36:40 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
5872019-06-26T20:36:53 *** bitcoin-git has left #bitcoin-core-dev
5882019-06-26T20:43:26 *** Guyver2 has quit IRC
5892019-06-26T20:55:54 *** StopAndDecrypt has quit IRC
5902019-06-26T20:56:49 *** StopAndDecrypt has joined #bitcoin-core-dev
5912019-06-26T20:58:11 *** StopAndDecrypt has quit IRC
5922019-06-26T20:58:11 *** StopAndDecrypt has joined #bitcoin-core-dev
5932019-06-26T20:58:45 <achow101> how do people feel about getting rid of dumpwallet and the import* commands except for importmulti?
5942019-06-26T21:00:01 *** MTecknology1 has quit IRC
5952019-06-26T21:00:08 <sipa> for now dumpwallet is kind of the only way to actually see everything you've imported in the past
5962019-06-26T21:01:45 <achow101> it kind of gets in the way of all of these wallet changes
5972019-06-26T21:02:15 *** e4xit has joined #bitcoin-core-dev
5982019-06-26T21:08:42 <sipa> they can keep working on top of the legacy spkprovider i think?
5992019-06-26T21:09:24 *** pinheadmz has joined #bitcoin-core-dev
6002019-06-26T21:23:56 *** pinheadmz has quit IRC
6012019-06-26T21:25:51 *** rafalcpp_ has joined #bitcoin-core-dev
6022019-06-26T21:26:44 *** rafalcpp has quit IRC
6032019-06-26T21:26:57 *** queip has quit IRC
6042019-06-26T21:28:20 *** jchnak has joined #bitcoin-core-dev
6052019-06-26T21:28:26 *** yano1 has joined #bitcoin-core-dev
6062019-06-26T21:29:19 *** promag has quit IRC
6072019-06-26T21:29:45 <promag__> achow101: really? don't people use dumpwallet and importwallet for backups?
6082019-06-26T21:29:51 *** promag__ is now known as promag
6092019-06-26T21:30:01 <promag> achow101: really? don't people use dumpwallet and importwallet for backups?
6102019-06-26T21:30:08 <achow101> promag: they shouldn't...
6112019-06-26T21:30:10 *** promag_ has joined #bitcoin-core-dev
6122019-06-26T21:30:54 <promag> breaking change alert :P
6132019-06-26T21:31:13 <promag> do you have that refactor pushed?
6142019-06-26T21:31:56 <sipa> achow101: that's not a good reason :)
6152019-06-26T21:32:08 <sipa> there are plenty of things supported that are Bad Ideas (tm)
6162019-06-26T21:32:44 *** queip has joined #bitcoin-core-dev
6172019-06-26T21:33:16 <achow101> promag: https://github.com/achow101/bitcoin/tree/box-the-wallet
6182019-06-26T21:33:27 <promag> sipa: or Were Good Ideas (tm)
6192019-06-26T21:33:30 <sipa> they can certainly be deprecated if there are alternatives, but i suspect here that the expected workflow will be that once you upgrade to a Shiny Descriptor Wallet certain RPCs stop being available, but remain supported on legacy wallets
6202019-06-26T21:38:17 <promag> achow101: oh nice, lots of commits :D
6212019-06-26T21:38:38 <achow101> i'm going to reorganize them after I get the thing to actually work
6222019-06-26T21:41:02 *** promag has quit IRC
6232019-06-26T21:50:02 *** cubancorona has joined #bitcoin-core-dev
6242019-06-26T21:53:43 *** promag has joined #bitcoin-core-dev
6252019-06-26T21:54:57 *** hugohn has quit IRC
6262019-06-26T21:55:33 *** promag has quit IRC
6272019-06-26T21:57:56 *** hugohn has joined #bitcoin-core-dev
6282019-06-26T21:58:18 *** michaelsdunn1 has quit IRC
6292019-06-26T21:58:47 <jb55> achow101: why do you need [ci skip], does CI run on every commit? I thought it only ran on the tip.
6302019-06-26T21:59:15 <achow101> jb55: it's just to note that those commits won't compile/won't pass tests
6312019-06-26T21:59:34 <jb55> I see
6322019-06-26T21:59:42 <achow101> the order is kind of screwed up right now
6332019-06-26T21:59:50 <achow101> all the [ci skip] commits should be at the end
6342019-06-26T22:02:56 *** aseem has quit IRC
6352019-06-26T22:03:48 *** hugohn has quit IRC
6362019-06-26T22:04:33 *** hugohn has joined #bitcoin-core-dev
6372019-06-26T22:06:33 *** rex4539 has quit IRC
6382019-06-26T22:16:10 <luke-jr> eh, why wouldn't they compile at least?
6392019-06-26T22:19:09 *** jarthur has quit IRC
6402019-06-26T22:21:59 *** scoop has joined #bitcoin-core-dev
6412019-06-26T22:23:34 *** goatpig has quit IRC
6422019-06-26T22:24:04 <achow101> cause I fucked up. they'll compile later when I reorganize everything
6432019-06-26T22:24:46 *** scoop_ has joined #bitcoin-core-dev
6442019-06-26T22:26:16 *** scoop has quit IRC
6452019-06-26T22:27:51 *** hugohn has quit IRC
6462019-06-26T22:29:12 *** scoop_ has quit IRC
6472019-06-26T22:30:51 *** Guest45841 has quit IRC
6482019-06-26T22:32:48 *** bitcoin-git has joined #bitcoin-core-dev
6492019-06-26T22:32:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b28bca04c27...3077f11dadff
6502019-06-26T22:32:49 <bitcoin-git> bitcoin/master f466c4c Jonas Schnelli: Add missing ECC_Stop(); in GUI rpcnestedtests.cpp
6512019-06-26T22:32:49 <bitcoin-git> bitcoin/master 3077f11 MarcoFalke: Merge #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp
6522019-06-26T22:32:51 *** bitcoin-git has left #bitcoin-core-dev
6532019-06-26T22:33:59 *** bitcoin-git has joined #bitcoin-core-dev
6542019-06-26T22:33:59 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16289: test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp (master...2019/06/fix_rpcnested_test) https://github.com/bitcoin/bitcoin/pull/16289
6552019-06-26T22:34:00 *** bitcoin-git has left #bitcoin-core-dev
6562019-06-26T22:35:04 *** scoop has joined #bitcoin-core-dev
6572019-06-26T22:39:29 *** scoop has quit IRC
6582019-06-26T22:41:55 *** Zenton has quit IRC
6592019-06-26T22:43:47 *** scoop has joined #bitcoin-core-dev
6602019-06-26T22:46:55 *** scoop_ has joined #bitcoin-core-dev
6612019-06-26T22:46:57 *** scoop has quit IRC
6622019-06-26T22:48:37 *** pinheadmz has joined #bitcoin-core-dev
6632019-06-26T22:51:34 *** scoop_ has quit IRC
6642019-06-26T22:53:09 *** spinza has quit IRC
6652019-06-26T23:07:08 *** spinza has joined #bitcoin-core-dev
6662019-06-26T23:08:41 *** bralyclow01 has joined #bitcoin-core-dev
6672019-06-26T23:10:57 *** bralyclow has quit IRC
6682019-06-26T23:16:53 *** d_t has quit IRC
6692019-06-26T23:25:04 *** scoop has joined #bitcoin-core-dev
6702019-06-26T23:29:20 *** scoop has quit IRC
6712019-06-26T23:39:25 *** promag has joined #bitcoin-core-dev
6722019-06-26T23:40:14 *** pinheadmz has joined #bitcoin-core-dev
6732019-06-26T23:43:49 *** promag has quit IRC
6742019-06-26T23:44:26 *** pinheadmz has quit IRC
6752019-06-26T23:45:12 *** bitcoin-git has joined #bitcoin-core-dev
6762019-06-26T23:45:12 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
6772019-06-26T23:45:15 *** bitcoin-git has left #bitcoin-core-dev
6782019-06-26T23:48:36 *** lightlike has quit IRC
6792019-06-26T23:51:27 *** surja795 has joined #bitcoin-core-dev
6802019-06-26T23:56:09 *** scoop has joined #bitcoin-core-dev