12019-07-10T00:00:01 *** pdurbin1 has quit IRC
22019-07-10T00:04:30 *** hoobop1 has joined #bitcoin-core-dev
32019-07-10T00:05:34 *** scoop has joined #bitcoin-core-dev
42019-07-10T00:05:46 *** Chris_Stewart_5 has quit IRC
52019-07-10T00:09:52 *** scoop has quit IRC
62019-07-10T00:11:04 *** queip has quit IRC
72019-07-10T00:16:01 *** queip has joined #bitcoin-core-dev
82019-07-10T00:18:44 *** MoonJaCk- has quit IRC
92019-07-10T00:19:26 *** MoonJaCk- has joined #bitcoin-core-dev
102019-07-10T00:22:16 *** MoonJaCk- has quit IRC
112019-07-10T00:22:46 *** MoonJaCk- has joined #bitcoin-core-dev
122019-07-10T00:23:45 <jb55> I screwed up my first psbt, I didn't realize core created a sh(wpkh()) change address to m/84' which would have been a funds loss to a regular trezor user. hopefully future wallet devs don't make that mistake.
132019-07-10T00:24:04 *** Xunie has quit IRC
142019-07-10T00:24:13 <jb55> not really "loss" but would require some manual recovery with sign-tx which I just did
152019-07-10T00:24:42 <sipa> jb55: core doesn't care about derivation paths
162019-07-10T00:24:48 <jb55> yeah
172019-07-10T00:24:50 <sipa> it creates whatever you imported as change
182019-07-10T00:24:58 *** Xunie has joined #bitcoin-core-dev
192019-07-10T00:25:36 *** Jackielove4u has quit IRC
202019-07-10T00:25:45 <jb55> I'm just thinking about people building hardware wallet stuff, since core only cares about addresses and not paths, would be a common source of dev errors I predict
212019-07-10T00:27:41 <jb55> afaik native descriptor wallets don't help here either if I understand that PR correctly
222019-07-10T00:28:14 *** Xunie_ has joined #bitcoin-core-dev
232019-07-10T00:30:28 *** Xunie has quit IRC
242019-07-10T00:32:55 <sipa> i don't see how it would be related, no
252019-07-10T00:33:54 <jb55> sipa: with importmulti I imported wpkh addresses, but when I dumpwallet I see sh(wpkh()) addresses. I'm still a bit confused as to what is actually stored on disk
262019-07-10T00:34:29 <jb55> just pubkeys?
272019-07-10T00:36:26 <sipa> jb55: keys and scripts
282019-07-10T00:36:50 <sipa> and what is treated as "mine" is a based om complex historically grown rules that make little sense
292019-07-10T00:37:00 <jb55> it's possible I screwed something up, but I find it weird that it would generate sh(wpkh()) change addresses after a wpkh import. I guess that descriptor info isn't retained and it just does p2sh-segwit by default
302019-07-10T00:37:33 <sipa> jb55: importing something (for now) in now restricts it to be importing just that
312019-07-10T00:38:06 <sipa> it does make sure the result is "policy compatible"; e.g. importing a multisig will never result in your wallet treating payments to individual keys in it as your
322019-07-10T00:38:21 *** keymone has quit IRC
332019-07-10T00:38:36 <sipa> but other than that... the current representation simply has no way to represent one exact type of imported things... it's just keys and script
342019-07-10T00:38:54 <sipa> that's actually the entire reason why i started working on descriptors
352019-07-10T00:39:21 <sipa> *in now -> in no way
362019-07-10T00:41:50 *** keymone has joined #bitcoin-core-dev
372019-07-10T00:42:39 <jb55> sipa: cool. in the meantime I'll be more careful with psbts...
382019-07-10T00:43:15 <sipa> with getrawchangeaddress you can control what type of address you create
392019-07-10T00:45:33 <jb55> yeah and there's a change_type option in createwalletfundedpsbt I just forgot to set it to bech32 :[
402019-07-10T00:47:51 <jb55> s/createwalletfundedpsbt/walletcreatefundedpsbt/
412019-07-10T01:02:09 *** lightlike has quit IRC
422019-07-10T01:14:21 *** scoop has joined #bitcoin-core-dev
432019-07-10T01:31:47 *** BillyGarrison has quit IRC
442019-07-10T01:56:16 *** hugohn has joined #bitcoin-core-dev
452019-07-10T01:59:52 *** DeanWeen has joined #bitcoin-core-dev
462019-07-10T02:01:07 *** ccdle12 has joined #bitcoin-core-dev
472019-07-10T02:02:04 *** justanotheruser has quit IRC
482019-07-10T02:05:15 *** ccdle12 has quit IRC
492019-07-10T02:05:25 *** esotericnonsens_ has joined #bitcoin-core-dev
502019-07-10T02:06:36 *** justanotheruser has joined #bitcoin-core-dev
512019-07-10T02:14:56 *** hugohn has quit IRC
522019-07-10T02:21:56 *** ghost43_ is now known as ghost43
532019-07-10T02:22:12 *** JamesAU has joined #bitcoin-core-dev
542019-07-10T02:26:58 *** hugohn has joined #bitcoin-core-dev
552019-07-10T02:45:21 *** kristapsk has quit IRC
562019-07-10T02:45:40 *** DeanWeen has quit IRC
572019-07-10T02:46:33 *** kristapsk has joined #bitcoin-core-dev
582019-07-10T02:46:34 *** DeanWeen has joined #bitcoin-core-dev
592019-07-10T02:46:38 *** hugohn has quit IRC
602019-07-10T02:59:49 *** JamesAU has quit IRC
612019-07-10T02:59:50 *** hugohn has joined #bitcoin-core-dev
622019-07-10T03:00:01 *** hoobop1 has quit IRC
632019-07-10T03:04:37 *** DeanWeen has quit IRC
642019-07-10T03:04:55 *** kenperkins has joined #bitcoin-core-dev
652019-07-10T03:05:04 *** DeanWeen has joined #bitcoin-core-dev
662019-07-10T03:26:29 *** dviola has quit IRC
672019-07-10T04:18:48 <achow101> jb55: native descriptor wallets will help as you would import one descriptor for change sh(wpkh()) and a different for wpkh() and so on
682019-07-10T04:19:16 <achow101> but the wallet currently treats all keys the same and any key can be used for p2sh-segwit, legacy, or bech32
692019-07-10T04:21:04 <achow101> jb55: if you're using Core + HWI, it shouldn't matter to you whether the path is the type the trezor expects. it will still sign regardless, just complain when the path isn't what it expects
702019-07-10T04:21:24 <jb55> achow101: that means that combo multiimports should do the same thing as any other multiimport on the same range?
712019-07-10T04:21:37 <achow101> right now it does
722019-07-10T04:21:45 <achow101> in theory
732019-07-10T04:23:13 <jb55> achow101: it prompted the change address on the trezor display, because I guess it thought it was someone else's address.
742019-07-10T04:23:32 <jb55> Makes sense in hindsight, thought it was just some bug
752019-07-10T04:24:44 <achow101> IIRC change detection is disabled for trezor by HWI
762019-07-10T04:25:06 <achow101> so that should be expected behavior regardless of derivation path
772019-07-10T04:25:34 *** spinza has quit IRC
782019-07-10T04:25:39 <achow101> I don't think we give it the derivation path for outputs (yet). This is intentional behavior because change detection isn't very smart
792019-07-10T04:26:35 <jb55> ah ok yeah I read about, and assumed that what was happening the first time around
802019-07-10T04:27:21 *** MoonJaCk- has quit IRC
812019-07-10T04:30:57 <jb55> achow101: one thing I couldn't get working was a walletcreatefundedpsbt that was flexible enough to express a sh(wpkh(m/84'/..)) -> wpkh(m/84'/...) tx. I tried specifying a specific change address with no outputs but that wasn't allowed
822019-07-10T04:31:29 <jb55> so I ended up just doing an interactive trezorctl sign-tx
832019-07-10T04:31:54 *** Victor_sueca has joined #bitcoin-core-dev
842019-07-10T04:32:48 <jb55> perhaps createpsbt could do this but I'm not sure how to get that to work with hwi...
852019-07-10T04:33:29 <achow101> jb55: huh? was it not filling in the input, or did it not like the output? what about itwasn't working?
862019-07-10T04:34:28 *** Victorsueca has quit IRC
872019-07-10T04:34:51 <jb55> achow101: input was fine, but I only wanted one output which was the exact same derivation path but as a wpkh output instead of sh(wpkh). I couldn't figure out how to do that with walletcreatefundedpsbt.
882019-07-10T04:35:33 <achow101> just get a new address, set that as the output, and use the option "subtractFeeFromOutputs":[0]
892019-07-10T04:35:47 <jb55> that's the ticket
902019-07-10T04:35:57 <achow101> and send the full input amount to that output
912019-07-10T04:36:11 <achow101> it shouldn't care
922019-07-10T04:36:49 <jb55> that's good to know, I haven't used that option before but that makes sense!
932019-07-10T04:39:03 *** spinza has joined #bitcoin-core-dev
942019-07-10T04:49:54 *** d_t has joined #bitcoin-core-dev
952019-07-10T04:55:01 *** d_t has quit IRC
962019-07-10T04:59:03 *** hebasto has joined #bitcoin-core-dev
972019-07-10T05:13:50 *** queip has quit IRC
982019-07-10T05:20:06 *** queip has joined #bitcoin-core-dev
992019-07-10T05:21:28 *** elichai2 has quit IRC
1002019-07-10T05:22:57 *** wpaulino has quit IRC
1012019-07-10T05:28:31 <hebasto> MarcoFalke: hi! if #16362 has been marked with 0.19.0 milestone, could #16224 be marked 0.19.0 milestone as well?
1022019-07-10T05:28:34 <gribble> https://github.com/bitcoin/bitcoin/issues/16362 | gui: Bilingual translation by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
1032019-07-10T05:28:35 <gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
1042019-07-10T05:30:26 *** wpaulino has joined #bitcoin-core-dev
1052019-07-10T05:50:03 *** state_bits has quit IRC
1062019-07-10T05:51:11 *** ghost43_ has joined #bitcoin-core-dev
1072019-07-10T05:51:14 *** windsok has quit IRC
1082019-07-10T05:51:52 *** ghost43 has quit IRC
1092019-07-10T05:52:14 *** state_bits has joined #bitcoin-core-dev
1102019-07-10T05:53:35 *** windsok has joined #bitcoin-core-dev
1112019-07-10T05:53:35 *** windsok has joined #bitcoin-core-dev
1122019-07-10T05:55:38 *** justanotheruser has quit IRC
1132019-07-10T06:00:02 *** kenperkins has quit IRC
1142019-07-10T06:01:20 *** d_t has joined #bitcoin-core-dev
1152019-07-10T06:13:08 *** justanotheruser has joined #bitcoin-core-dev
1162019-07-10T06:21:22 *** fnichol has joined #bitcoin-core-dev
1172019-07-10T06:32:37 *** hugohn has quit IRC
1182019-07-10T06:43:27 *** scoop has quit IRC
1192019-07-10T06:43:55 *** scoop has joined #bitcoin-core-dev
1202019-07-10T06:44:51 *** d_t has quit IRC
1212019-07-10T06:47:39 *** reallll has joined #bitcoin-core-dev
1222019-07-10T06:50:52 *** belcher has quit IRC
1232019-07-10T06:57:53 *** ghost43 has joined #bitcoin-core-dev
1242019-07-10T06:58:08 *** ghost43_ has quit IRC
1252019-07-10T07:04:26 *** ccdle12 has joined #bitcoin-core-dev
1262019-07-10T07:09:54 *** ccdle12 has quit IRC
1272019-07-10T07:19:12 *** keymone has quit IRC
1282019-07-10T07:19:45 *** keymone has joined #bitcoin-core-dev
1292019-07-10T07:21:51 *** reallll is now known as belcher
1302019-07-10T07:22:51 *** ccdle12 has joined #bitcoin-core-dev
1312019-07-10T07:22:52 *** MoonJaCk- has joined #bitcoin-core-dev
1322019-07-10T07:23:52 *** Jackielove4u has joined #bitcoin-core-dev
1332019-07-10T07:34:51 *** Evel-Knievel has quit IRC
1342019-07-10T07:41:21 *** jungly has joined #bitcoin-core-dev
1352019-07-10T07:44:55 *** promag has quit IRC
1362019-07-10T07:50:17 *** MoonJaCk` has joined #bitcoin-core-dev
1372019-07-10T07:57:20 *** obsrver has joined #bitcoin-core-dev
1382019-07-10T07:58:10 *** queip has quit IRC
1392019-07-10T07:59:50 *** rockhouse has quit IRC
1402019-07-10T07:59:50 *** victorSN has quit IRC
1412019-07-10T08:00:46 *** jonatack has joined #bitcoin-core-dev
1422019-07-10T08:03:22 *** ccdle12 has quit IRC
1432019-07-10T08:04:15 *** ccdle12 has joined #bitcoin-core-dev
1442019-07-10T08:04:33 *** queip has joined #bitcoin-core-dev
1452019-07-10T08:12:42 *** scoop has quit IRC
1462019-07-10T08:17:15 *** torkelrogstad has joined #bitcoin-core-dev
1472019-07-10T08:27:45 *** queip has quit IRC
1482019-07-10T08:34:51 *** queip has joined #bitcoin-core-dev
1492019-07-10T08:36:29 *** jonatack has quit IRC
1502019-07-10T08:37:05 *** Zenton has joined #bitcoin-core-dev
1512019-07-10T08:40:03 *** queip has quit IRC
1522019-07-10T08:46:23 *** queip has joined #bitcoin-core-dev
1532019-07-10T08:46:42 *** timothy has joined #bitcoin-core-dev
1542019-07-10T08:58:04 *** Emcy_ has joined #bitcoin-core-dev
1552019-07-10T08:58:24 *** Emcy_ has quit IRC
1562019-07-10T09:00:01 *** fnichol has quit IRC
1572019-07-10T09:04:16 *** state_bits has quit IRC
1582019-07-10T09:06:24 *** state_bits has joined #bitcoin-core-dev
1592019-07-10T09:06:29 *** wpaulino has quit IRC
1602019-07-10T09:06:38 *** wpaulino has joined #bitcoin-core-dev
1612019-07-10T09:06:38 *** bitbee has quit IRC
1622019-07-10T09:09:18 *** bitbee has joined #bitcoin-core-dev
1632019-07-10T09:16:42 *** behradkhodayar has joined #bitcoin-core-dev
1642019-07-10T09:16:43 *** ccdle12 has quit IRC
1652019-07-10T09:18:37 *** sbc has joined #bitcoin-core-dev
1662019-07-10T09:18:53 *** sbc is now known as Guest94483
1672019-07-10T09:28:08 <fanquake> hebasto: have done
1682019-07-10T09:29:36 <hebasto> fanquake: thanks
1692019-07-10T09:30:28 *** bitbee has quit IRC
1702019-07-10T09:34:13 *** bitbee has joined #bitcoin-core-dev
1712019-07-10T09:34:58 <fanquake> np
1722019-07-10T09:40:16 *** state_bits has quit IRC
1732019-07-10T09:40:23 *** state_bits has joined #bitcoin-core-dev
1742019-07-10T09:42:52 *** Guyver2 has joined #bitcoin-core-dev
1752019-07-10T09:46:36 *** bitcoin-git has joined #bitcoin-core-dev
1762019-07-10T09:46:38 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/357488f660a5...8d1286014c61
1772019-07-10T09:46:38 <bitcoin-git> bitcoin/master 172213b Andrew Chow: Add GetNewDestination to CWallet to fetch new destinations
1782019-07-10T09:46:39 <bitcoin-git> bitcoin/master 33d13ed Andrew Chow: Replace CReserveKey with ReserveDestinatoin
1792019-07-10T09:46:40 <bitcoin-git> bitcoin/master 8e7f930 Andrew Chow: Add GetNewChangeDestination for getting new change Destinations
1802019-07-10T09:46:42 *** bitcoin-git has left #bitcoin-core-dev
1812019-07-10T09:47:31 *** bitcoin-git has joined #bitcoin-core-dev
1822019-07-10T09:47:31 <bitcoin-git> [bitcoin] laanwj merged pull request #16237: Have the wallet give out destinations instead of keys (master...cwallet-getnewaddr) https://github.com/bitcoin/bitcoin/pull/16237
1832019-07-10T09:47:34 *** bitcoin-git has left #bitcoin-core-dev
1842019-07-10T09:50:46 *** behradkhodayar has quit IRC
1852019-07-10T09:54:13 *** queip has quit IRC
1862019-07-10T09:54:41 *** hebasto has quit IRC
1872019-07-10T09:55:13 *** belcher has quit IRC
1882019-07-10T09:55:45 *** behradkhodayar has joined #bitcoin-core-dev
1892019-07-10T09:59:37 *** bitbee has quit IRC
1902019-07-10T10:00:53 *** queip has joined #bitcoin-core-dev
1912019-07-10T10:04:43 *** behradkhodayar has quit IRC
1922019-07-10T10:05:30 *** bitbee has joined #bitcoin-core-dev
1932019-07-10T10:06:52 *** bitcoin-git has joined #bitcoin-core-dev
1942019-07-10T10:06:54 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/1fb747a8007c...410774ab89fd
1952019-07-10T10:06:55 <bitcoin-git> bitcoin/0.18 e2f7677 João Barbosa: gui: Fix missing qRegisterMetaType(WalletModel*)
1962019-07-10T10:06:56 <bitcoin-git> bitcoin/0.18 df695db João Barbosa: qt: Assert QMetaObject::invokeMethod result
1972019-07-10T10:06:58 <bitcoin-git> bitcoin/0.18 410774a Wladimir J. van der Laan: Merge #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result"...
1982019-07-10T10:06:59 *** bitcoin-git has left #bitcoin-core-dev
1992019-07-10T10:07:14 *** bitcoin-git has joined #bitcoin-core-dev
2002019-07-10T10:07:15 <bitcoin-git> [bitcoin] laanwj merged pull request #16359: 0.18: Backport "qt: Assert QMetaObject::invokeMethod result" (0.18...2019-07-0.18-backports) https://github.com/bitcoin/bitcoin/pull/16359
2012019-07-10T10:07:28 *** bitcoin-git has left #bitcoin-core-dev
2022019-07-10T10:13:14 *** Bullit has joined #bitcoin-core-dev
2032019-07-10T10:14:13 *** Bullit has quit IRC
2042019-07-10T10:14:50 *** Bullit has joined #bitcoin-core-dev
2052019-07-10T10:18:46 *** goatpig has quit IRC
2062019-07-10T10:18:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2072019-07-10T10:22:14 *** hebasto has joined #bitcoin-core-dev
2082019-07-10T10:24:06 *** bitcoin-git has joined #bitcoin-core-dev
2092019-07-10T10:24:07 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8d1286014c61...5859b7dc6ff5
2102019-07-10T10:24:08 <bitcoin-git> bitcoin/master 48bcb2a qmma: Disable other targets when enable-fuzz is set
2112019-07-10T10:24:08 <bitcoin-git> bitcoin/master 84edfc7 qmma: Update doc and CI config
2122019-07-10T10:24:09 <bitcoin-git> bitcoin/master 5859b7d Wladimir J. van der Laan: Merge #16338: test: Disable other targets when enable-fuzz is set
2132019-07-10T10:24:10 *** bitcoin-git has left #bitcoin-core-dev
2142019-07-10T10:25:07 *** bitcoin-git has joined #bitcoin-core-dev
2152019-07-10T10:25:08 <bitcoin-git> [bitcoin] laanwj merged pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
2162019-07-10T10:25:20 *** bitcoin-git has left #bitcoin-core-dev
2172019-07-10T10:30:31 *** windsok has quit IRC
2182019-07-10T10:31:24 *** MoonJaCk` has quit IRC
2192019-07-10T10:32:34 *** windsok has joined #bitcoin-core-dev
2202019-07-10T10:32:34 *** windsok has joined #bitcoin-core-dev
2212019-07-10T10:32:51 *** spinza has quit IRC
2222019-07-10T10:33:17 *** hebasto has quit IRC
2232019-07-10T10:38:36 *** hebasto has joined #bitcoin-core-dev
2242019-07-10T10:42:23 *** bitcoin-git has joined #bitcoin-core-dev
2252019-07-10T10:42:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5859b7dc6ff5...d1fc827300e2
2262019-07-10T10:42:24 <bitcoin-git> bitcoin/master 0512f05 fanquake: depends: expat 2.2.7
2272019-07-10T10:42:24 <bitcoin-git> bitcoin/master d1fc827 Wladimir J. van der Laan: Merge #16270: depends: expat 2.2.7
2282019-07-10T10:42:27 *** bitcoin-git has left #bitcoin-core-dev
2292019-07-10T10:43:17 *** bitcoin-git has joined #bitcoin-core-dev
2302019-07-10T10:43:18 <bitcoin-git> [bitcoin] laanwj merged pull request #16270: depends: expat 2.2.7 (master...expat-2-2-7) https://github.com/bitcoin/bitcoin/pull/16270
2312019-07-10T10:43:19 *** bitcoin-git has left #bitcoin-core-dev
2322019-07-10T10:50:55 *** Evel-Knievel has joined #bitcoin-core-dev
2332019-07-10T10:54:11 *** jonatack has joined #bitcoin-core-dev
2342019-07-10T10:54:25 *** spinza has joined #bitcoin-core-dev
2352019-07-10T10:57:34 *** behradkhodayar has joined #bitcoin-core-dev
2362019-07-10T11:06:58 *** queip has quit IRC
2372019-07-10T11:12:43 *** queip has joined #bitcoin-core-dev
2382019-07-10T11:15:37 *** goatpig has joined #bitcoin-core-dev
2392019-07-10T11:30:35 *** behradkhodayar has quit IRC
2402019-07-10T11:31:15 *** behradkhodayar has joined #bitcoin-core-dev
2412019-07-10T11:44:44 *** kristapsk has quit IRC
2422019-07-10T11:45:06 *** kristapsk has joined #bitcoin-core-dev
2432019-07-10T11:47:04 *** Chris_Stewart_5 has quit IRC
2442019-07-10T11:58:59 *** lightlike has joined #bitcoin-core-dev
2452019-07-10T12:00:01 *** Guest94483 has quit IRC
2462019-07-10T12:01:21 *** bitcoin-git has joined #bitcoin-core-dev
2472019-07-10T12:01:21 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d1fc827300e2...6c1e45c4c416
2482019-07-10T12:01:22 <bitcoin-git> bitcoin/master 5c1b971 João Barbosa: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction
2492019-07-10T12:01:22 <bitcoin-git> bitcoin/master 1775501 MarcoFalke: wallet: Remove unreachable code in CreateTransaction
2502019-07-10T12:01:23 <bitcoin-git> bitcoin/master 0d101a3 MarcoFalke: test: Add test for maxtxfee option
2512019-07-10T12:01:24 *** bitcoin-git has left #bitcoin-core-dev
2522019-07-10T12:02:21 *** bitcoin-git has joined #bitcoin-core-dev
2532019-07-10T12:02:21 <bitcoin-git> [bitcoin] laanwj merged pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
2542019-07-10T12:02:26 *** bitcoin-git has left #bitcoin-core-dev
2552019-07-10T12:11:47 *** afb has joined #bitcoin-core-dev
2562019-07-10T12:22:40 *** behradkhodayar has quit IRC
2572019-07-10T12:33:41 *** spinza has quit IRC
2582019-07-10T12:39:06 *** spinza has joined #bitcoin-core-dev
2592019-07-10T12:45:18 *** spaced0ut has joined #bitcoin-core-dev
2602019-07-10T12:47:40 *** DeanWeen has quit IRC
2612019-07-10T12:50:55 *** behradkhodayar has joined #bitcoin-core-dev
2622019-07-10T12:52:16 <provoostenator> Is there a way to run only a subset of functional tests, e.g. just the wallet tests? "python test/functional/wallet*" does not do the trick.
2632019-07-10T13:00:58 *** jungly has quit IRC
2642019-07-10T13:07:53 *** scoop has joined #bitcoin-core-dev
2652019-07-10T13:08:36 *** hexyul has quit IRC
2662019-07-10T13:10:21 *** jungly has joined #bitcoin-core-dev
2672019-07-10T13:13:14 *** dviola has joined #bitcoin-core-dev
2682019-07-10T13:13:40 *** hexyul has joined #bitcoin-core-dev
2692019-07-10T13:14:02 <luke-jr> provoostenator: for test in test/functional/wallet*; do $test; done
2702019-07-10T13:15:25 <luke-jr> or if you want to get fancy: parallel ::: test/functional/wallet*
2712019-07-10T13:16:39 <provoostenator> That works, but it's much more verbose than test_runner and it doesn't stop if any test fails.
2722019-07-10T13:17:12 <luke-jr> --halt now,fail=1
2732019-07-10T13:20:57 <wumpus> you can pass a filter argument to test_runner afaik
2742019-07-10T13:23:55 *** queip has quit IRC
2752019-07-10T13:26:03 *** bitcoin-git has joined #bitcoin-core-dev
2762019-07-10T13:26:04 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
2772019-07-10T13:26:04 *** bitcoin-git has left #bitcoin-core-dev
2782019-07-10T13:30:54 *** queip has joined #bitcoin-core-dev
2792019-07-10T13:31:06 *** promag has joined #bitcoin-core-dev
2802019-07-10T13:32:13 <provoostenator> wumpus: only --exclude
2812019-07-10T13:32:35 *** nijak has joined #bitcoin-core-dev
2822019-07-10T13:33:42 *** davterra has quit IRC
2832019-07-10T13:35:57 *** hebasto has quit IRC
2842019-07-10T13:42:36 <promag> MarcoFalke: to backport #16322 I'll have to include #15638 -> #15778 -> #16257
2852019-07-10T13:42:38 <gribble> https://github.com/bitcoin/bitcoin/issues/16322 | wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16322 · bitcoin/bitcoin · GitHub
2862019-07-10T13:42:40 <gribble> https://github.com/bitcoin/bitcoin/issues/15638 | Move-only: Pull wallet code out of libbitcoin_server by ryanofsky · Pull Request #15638 · bitcoin/bitcoin · GitHub
2872019-07-10T13:42:42 <gribble> https://github.com/bitcoin/bitcoin/issues/15778 | [wallet] Move maxtxfee from node to wallet by jnewbery · Pull Request #15778 · bitcoin/bitcoin · GitHub
2882019-07-10T13:42:44 <gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
2892019-07-10T13:43:49 <promag> maybe I can only pick some commits of these pulls, especially 15638
2902019-07-10T13:44:20 <promag> but let me know if I should proceed
2912019-07-10T13:44:53 <sdaftuar> provoostenator: i think if you're in the test/functional directory, you can do ./test_runner.py wallet* and it works?
2922019-07-10T13:46:48 *** jungly has quit IRC
2932019-07-10T13:50:19 *** d_t has joined #bitcoin-core-dev
2942019-07-10T13:53:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2952019-07-10T14:02:10 *** elichai2 has joined #bitcoin-core-dev
2962019-07-10T14:05:46 *** csknk has joined #bitcoin-core-dev
2972019-07-10T14:13:14 *** MoonJaCk- has quit IRC
2982019-07-10T14:13:55 *** MoonJaCk- has joined #bitcoin-core-dev
2992019-07-10T14:14:46 *** aseem has joined #bitcoin-core-dev
3002019-07-10T14:25:44 <ariard> hey if anyone wants to review some wallet-chain refactoring, I've finally solved the lock issue on #15713 and all tests passed
3012019-07-10T14:25:47 <gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
3022019-07-10T14:26:47 <ariard> IMO, I think we need to preserve lock order (cs_main - cs_wallet) until we are done on Chain::Lock refactoring and swap it at once
3032019-07-10T14:26:49 *** michaelfolkson has joined #bitcoin-core-dev
3042019-07-10T14:29:44 <provoostenator> sdaftuar: bingo! That only works from within the directory itself weirdly enough.
3052019-07-10T14:31:24 <sdaftuar> provoostenator: i think it's just because we don't strip the path when test_runner compares its arguments to what tests it knows about? i didn't investigate though
3062019-07-10T14:32:35 *** nijak_ has joined #bitcoin-core-dev
3072019-07-10T14:33:08 *** hebasto has joined #bitcoin-core-dev
3082019-07-10T14:33:11 *** behradkhodayar has quit IRC
3092019-07-10T14:33:15 *** nijak has quit IRC
3102019-07-10T14:35:09 *** MoonJaCk` has joined #bitcoin-core-dev
3112019-07-10T14:38:02 *** MoonJaCk- has quit IRC
3122019-07-10T14:40:28 *** michaelfolkson has quit IRC
3132019-07-10T14:40:35 *** michaelsdunn1 has joined #bitcoin-core-dev
3142019-07-10T14:41:51 *** michaelfolkson has joined #bitcoin-core-dev
3152019-07-10T14:43:08 *** michaelfolkson has quit IRC
3162019-07-10T14:46:16 *** queip has quit IRC
3172019-07-10T14:50:38 *** hugohn has joined #bitcoin-core-dev
3182019-07-10T14:50:47 *** d_t has quit IRC
3192019-07-10T14:51:54 *** promag has quit IRC
3202019-07-10T14:51:58 *** queip has joined #bitcoin-core-dev
3212019-07-10T14:52:10 *** promag has joined #bitcoin-core-dev
3222019-07-10T14:55:27 *** Chris_Stewart_5 has quit IRC
3232019-07-10T14:56:30 <instagibbs> oh that's cool. test prefix naming makes even more sense now
3242019-07-10T14:56:50 <elichai2> If I want to add manual psbt constructions support, does it makes sense to have it in `bitcoin-tx`? regular bitcoin core rpc or even a new `bitcoin-psbt`?
3252019-07-10T14:57:48 <MarcoFalke> Isn't there already psbt support in the rpc?
3262019-07-10T14:59:20 *** esotericnonsens_ has quit IRC
3272019-07-10T15:00:02 *** afb has quit IRC
3282019-07-10T15:00:55 <instagibbs> should be quite robust already in master
3292019-07-10T15:00:56 <elichai2> MarcoFalke: only commands that constructs it through the wallet (as far as I understand)
3302019-07-10T15:01:01 *** MoonJaCk- has joined #bitcoin-core-dev
3312019-07-10T15:01:26 <instagibbs> `createpsbt`?
3322019-07-10T15:01:36 <instagibbs> there are a number of non-wallet ones
3332019-07-10T15:04:53 <elichai2> instagibbs: it's just the creator role, not the updater, meaning it doesn't add any inputs/outputs to the psbt.
3342019-07-10T15:05:07 <elichai2> it creates a raw transaction and then add empty inputs outputs
3352019-07-10T15:05:30 <elichai2> (so maybe a better thing would be just to extend that command to also accept inputs/outputs?)
3362019-07-10T15:06:14 *** e4xit has quit IRC
3372019-07-10T15:06:22 *** davidblaine has joined #bitcoin-core-dev
3382019-07-10T15:06:31 <instagibbs> might be #bitcoin chat, achow101 would know
3392019-07-10T15:06:32 <elichai2> altough there's `utxoupdatepsbt` which will do the updates but using descriptors.
3402019-07-10T15:07:05 <elichai2> k, i'll talk with him
3412019-07-10T15:07:28 <sipa> t
3422019-07-10T15:07:40 <sipa> there is createpsbt and walletcreatefundedpsbt
3432019-07-10T15:08:04 <sipa> and i think we need a bitcoin-psbt tool that can sign/update a psbt with keys and descriptors
3442019-07-10T15:09:10 <sipa> elichai2: but a generic updater is hard, as it needs access to the outputs/transactions being spent
3452019-07-10T15:09:31 <sipa> so you can't really have all creation/updating done in an offline tool
3462019-07-10T15:09:52 *** davidblaine has quit IRC
3472019-07-10T15:10:22 <elichai2> sipa: you can make the user provide everything that's needed, like createrawtransaction
3482019-07-10T15:11:27 <elichai2> (or signrawtransactionwithkey )
3492019-07-10T15:11:44 <sipa> elichai2: right
3502019-07-10T15:12:21 <elichai2> sipa: i'm mostly trying to figure out if there's a way to integrate p2c and taproot fields into PSBT without adding full wallet support yet(which is a lot more work)
3512019-07-10T15:12:42 <sipa> elichai2: you can if you don't support it
3522019-07-10T15:12:53 <sipa> not sure what "full wallet support" means otherwise
3532019-07-10T15:13:35 <elichai2> adding classes and types for witness v1, adding descriptors to save the full taproot tree, constructing of taproot addresses.. etc
3542019-07-10T15:14:21 <elichai2> I want to add it to the PSBT standard so that other wallets can start working on support this even before it's in bitcoin core's wallet (assuming of course taproot will get activated)
3552019-07-10T15:14:47 <sipa> but a standalone tool which you give a psbt and a bunch of descriptors, private keys, xpubs, previous txn, utxos, ... and just updates everything and optionally signs would be really cool
3562019-07-10T15:16:24 <elichai2> so you think it should be separate from bitcoin-tx
3572019-07-10T15:17:02 <sipa> i think so
3582019-07-10T15:17:35 <elichai2> I think i'll start with a standalone RPC method and hopefully divide it into a separate tool (I want to have some PoC working to start a mailing list conversation around the new PSBT fields)
3592019-07-10T15:18:12 *** scoop has quit IRC
3602019-07-10T15:18:39 *** scoop has joined #bitcoin-core-dev
3612019-07-10T15:18:45 <sipa> bitcoin-tx is really "transformation based" thing which you give an input and then specify some transformations to apply
3622019-07-10T15:19:19 <sipa> for bitcoin-psbt i'm more thinking something which you give a bunch of information and uses it where useful
3632019-07-10T15:19:49 <sipa> elichai2: not everyone likes utility RPCs that could be separate tools instead
3642019-07-10T15:20:31 <sipa> (because then they require a running bitcoind, which is overkill for things that don't need access to blockchain/utxoset/wallet/...)
3652019-07-10T15:20:42 <sipa> though we already have a fair share of those
3662019-07-10T15:21:17 <sipa> elichai2: i think it's also premature to discuss psbt extension for taproot before taproot is final
3672019-07-10T15:22:25 <elichai2> Yeah I think we're already in a point where we have a lot of different RPC methods that do different kinds of things already
3682019-07-10T15:22:37 <elichai2> sipa: why? do you think it's gonna change in any meaningful way?
3692019-07-10T15:23:28 *** scoop has quit IRC
3702019-07-10T15:23:37 <sipa> elichai2: probably
3712019-07-10T15:24:09 *** pinheadmz has quit IRC
3722019-07-10T15:24:14 <sipa> there hasn't been that much discussion
3732019-07-10T15:24:45 *** e4xit has joined #bitcoin-core-dev
3742019-07-10T15:25:00 <sipa> and for wallet support there is a huge amount of time anyway
3752019-07-10T15:27:26 <elichai2> really? I really hope that taproot can be activated in less than 6 months
3762019-07-10T15:27:30 <sipa> lol
3772019-07-10T15:28:34 <sipa> i'm glad to see you're so confident
3782019-07-10T15:28:57 <luke-jr> elichai2: a large amount of the network hasn't even patched the inflation bug yet :<
3792019-07-10T15:30:00 <elichai2> luke-jr: that's a different thing. for taproot we need to: 1. Have an open PR. 2. Have consensus for merging. 3. have it in 0.19. 4. have BIP9 activation by miners
3802019-07-10T15:30:14 <elichai2> you're talking about regular full nodes
3812019-07-10T15:30:33 <luke-jr> elichai2: no. we need community support and deployment to a significant percent of user full nodes.
3822019-07-10T15:30:42 <luke-jr> miners do not decide network rules
3832019-07-10T15:31:00 <luke-jr> and BIP 9 is dead.
3842019-07-10T15:34:23 <sipa> really there is no rush for any of this
3852019-07-10T15:37:36 *** digi_james has joined #bitcoin-core-dev
3862019-07-10T15:41:02 *** lightlike has left #bitcoin-core-dev
3872019-07-10T15:41:09 *** lightlike has joined #bitcoin-core-dev
3882019-07-10T15:47:07 *** dviola has quit IRC
3892019-07-10T15:47:53 *** mengu has joined #bitcoin-core-dev
3902019-07-10T15:52:52 *** lightlike has quit IRC
3912019-07-10T15:53:04 *** lightlike has joined #bitcoin-core-dev
3922019-07-10T15:54:26 *** emilengler has joined #bitcoin-core-dev
3932019-07-10T15:58:22 *** pinheadmz has joined #bitcoin-core-dev
3942019-07-10T16:09:44 *** aseem has quit IRC
3952019-07-10T16:11:04 *** michaelfolkson has joined #bitcoin-core-dev
3962019-07-10T16:20:54 *** michaelfolkson has quit IRC
3972019-07-10T16:21:20 <nijak_> almost like we didn't learn anything from the UASF movement
3982019-07-10T16:21:34 <nijak_> When
3992019-07-10T16:21:48 <nijak_> when is 0.19 meant to be RC'ed? October?
4002019-07-10T16:25:49 *** aseem has joined #bitcoin-core-dev
4012019-07-10T16:26:49 *** nijak has joined #bitcoin-core-dev
4022019-07-10T16:26:59 *** behradkhodayar has joined #bitcoin-core-dev
4032019-07-10T16:27:32 *** nijak_ has quit IRC
4042019-07-10T16:31:20 <instagibbs> please no politics here. timeline for 0.19 here: https://github.com/bitcoin/bitcoin/issues/15940
4052019-07-10T16:31:42 <instagibbs> typically a 6 month cadence
4062019-07-10T16:35:09 *** jarthur has joined #bitcoin-core-dev
4072019-07-10T16:36:56 *** hexyul has quit IRC
4082019-07-10T16:38:28 *** hexyul has joined #bitcoin-core-dev
4092019-07-10T16:38:52 *** lightlike has quit IRC
4102019-07-10T16:39:04 *** lightlike has joined #bitcoin-core-dev
4112019-07-10T16:46:19 *** tynes has quit IRC
4122019-07-10T16:46:22 <sipa> also softforks are not restricted to major releases (but things like full wallet support probably are)
4132019-07-10T16:48:56 <luke-jr> indeed, they are excluded from ;)
4142019-07-10T16:49:45 *** tynes has joined #bitcoin-core-dev
4152019-07-10T16:49:47 *** timothy has quit IRC
4162019-07-10T16:51:45 *** jonatack_ has joined #bitcoin-core-dev
4172019-07-10T16:52:45 *** scoop has joined #bitcoin-core-dev
4182019-07-10T16:53:58 <nijak> understood, thanks instagibbs
4192019-07-10T16:54:03 *** jonatack_ has quit IRC
4202019-07-10T16:55:46 *** clarkmoody has joined #bitcoin-core-dev
4212019-07-10T17:03:29 *** MoonJaCk- has quit IRC
4222019-07-10T17:06:37 *** MoonJaCk- has joined #bitcoin-core-dev
4232019-07-10T17:11:17 *** fl has joined #bitcoin-core-dev
4242019-07-10T17:27:16 *** darosior has quit IRC
4252019-07-10T17:33:13 *** bitcoin-git has joined #bitcoin-core-dev
4262019-07-10T17:33:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c1e45c4c416...ff0aad8a40a0
4272019-07-10T17:33:14 <bitcoin-git> bitcoin/master 96b6dd4 Gregory Sanders: Remove redundant pre-TopUpKeypool checks
4282019-07-10T17:33:15 <bitcoin-git> bitcoin/master ff0aad8 MarcoFalke: Merge #16361: Remove redundant pre-TopUpKeypool check
4292019-07-10T17:33:16 *** bitcoin-git has left #bitcoin-core-dev
4302019-07-10T17:34:04 *** aseem has quit IRC
4312019-07-10T17:34:13 *** bitcoin-git has joined #bitcoin-core-dev
4322019-07-10T17:34:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16361: Remove redundant pre-TopUpKeypool check (master...redundant_topup) https://github.com/bitcoin/bitcoin/pull/16361
4332019-07-10T17:34:15 *** bitcoin-git has left #bitcoin-core-dev
4342019-07-10T17:42:14 *** hebasto has quit IRC
4352019-07-10T17:47:51 *** clarkmoody has quit IRC
4362019-07-10T17:48:09 *** clarkmoody has joined #bitcoin-core-dev
4372019-07-10T17:49:43 *** MoonJaCk- has quit IRC
4382019-07-10T17:50:09 *** MoonJaCk- has joined #bitcoin-core-dev
4392019-07-10T17:50:57 *** queip has quit IRC
4402019-07-10T17:53:56 *** bitcoin-git has joined #bitcoin-core-dev
4412019-07-10T17:53:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff0aad8a40a0...4fcccdac785e
4422019-07-10T17:53:57 <bitcoin-git> bitcoin/master 1aecdf2 Andrew Chow: Move wallet creation out of the createwallet rpc into its own function
4432019-07-10T17:53:57 <bitcoin-git> bitcoin/master 4fcccda MarcoFalke: Merge #16244: Move wallet creation out of the createwallet rpc into its ow...
4442019-07-10T17:53:58 *** bitcoin-git has left #bitcoin-core-dev
4452019-07-10T17:54:51 *** bitcoin-git has joined #bitcoin-core-dev
4462019-07-10T17:54:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16244: Move wallet creation out of the createwallet rpc into its own function (master...mv-createwallet) https://github.com/bitcoin/bitcoin/pull/16244
4472019-07-10T17:54:53 *** bitcoin-git has left #bitcoin-core-dev
4482019-07-10T17:56:18 *** queip has joined #bitcoin-core-dev
4492019-07-10T17:57:38 *** aseem has joined #bitcoin-core-dev
4502019-07-10T18:00:01 *** mengu has quit IRC
4512019-07-10T18:02:11 *** bitcoin-git has joined #bitcoin-core-dev
4522019-07-10T18:02:11 <bitcoin-git> [bitcoin] ryanofsky opened pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367
4532019-07-10T18:02:14 *** bitcoin-git has left #bitcoin-core-dev
4542019-07-10T18:04:01 *** exarkun2 has joined #bitcoin-core-dev
4552019-07-10T18:06:01 *** behrad_khodayar has joined #bitcoin-core-dev
4562019-07-10T18:07:00 *** behradkhodayar has quit IRC
4572019-07-10T18:08:03 *** aseem has quit IRC
4582019-07-10T18:08:34 *** Honthe has joined #bitcoin-core-dev
4592019-07-10T18:12:32 *** instagibbs_ has joined #bitcoin-core-dev
4602019-07-10T18:24:20 *** queip has quit IRC
4612019-07-10T18:26:23 *** aseem has joined #bitcoin-core-dev
4622019-07-10T18:30:10 *** queip has joined #bitcoin-core-dev
4632019-07-10T18:48:19 *** EdThorp has joined #bitcoin-core-dev
4642019-07-10T18:48:53 *** aseem has quit IRC
4652019-07-10T18:54:44 *** MoonJaCk- has quit IRC
4662019-07-10T18:55:22 *** MoonJaCk- has joined #bitcoin-core-dev
4672019-07-10T18:57:47 *** MoonJaCk- has quit IRC
4682019-07-10T18:59:07 *** csknk has quit IRC
4692019-07-10T19:02:52 *** MoonJaCk- has joined #bitcoin-core-dev
4702019-07-10T19:03:23 *** instagibbs_ has quit IRC
4712019-07-10T19:04:12 *** obsrver has quit IRC
4722019-07-10T19:04:32 *** instagibbs_ has joined #bitcoin-core-dev
4732019-07-10T19:07:09 *** instagibbs_ has quit IRC
4742019-07-10T19:07:11 *** rockhouse has joined #bitcoin-core-dev
4752019-07-10T19:11:01 *** RoboTamer has joined #bitcoin-core-dev
4762019-07-10T19:11:13 *** victorSN has joined #bitcoin-core-dev
4772019-07-10T19:11:20 *** timothy has joined #bitcoin-core-dev
4782019-07-10T19:12:23 *** aseem has joined #bitcoin-core-dev
4792019-07-10T19:12:28 *** timothy has quit IRC
4802019-07-10T19:27:10 *** jarthur_ has joined #bitcoin-core-dev
4812019-07-10T19:28:53 *** fl has quit IRC
4822019-07-10T19:29:52 *** aseem has quit IRC
4832019-07-10T19:30:41 *** jarthur has quit IRC
4842019-07-10T19:31:05 *** clarkmoody has quit IRC
4852019-07-10T19:31:42 *** Honthe has quit IRC
4862019-07-10T19:38:06 *** RoboTamer has quit IRC
4872019-07-10T19:41:27 *** MoonJaCk- has quit IRC
4882019-07-10T19:44:25 *** Honthe has joined #bitcoin-core-dev
4892019-07-10T19:45:41 *** BillyGarrison has joined #bitcoin-core-dev
4902019-07-10T19:48:49 *** aseem has joined #bitcoin-core-dev
4912019-07-10T20:00:46 *** jonatack has quit IRC
4922019-07-10T20:03:42 *** jonatack has joined #bitcoin-core-dev
4932019-07-10T20:06:43 *** owowo has quit IRC
4942019-07-10T20:09:44 *** justanotheruser has quit IRC
4952019-07-10T20:12:47 *** goatpig has quit IRC
4962019-07-10T20:13:01 *** owowo has joined #bitcoin-core-dev
4972019-07-10T20:14:13 *** justanotheruser has joined #bitcoin-core-dev
4982019-07-10T20:16:21 *** clarkmoody has joined #bitcoin-core-dev
4992019-07-10T20:20:52 *** clarkmoody has quit IRC
5002019-07-10T20:21:22 *** ryanofsky_ has left #bitcoin-core-dev
5012019-07-10T20:21:37 *** ryanofsky has joined #bitcoin-core-dev
5022019-07-10T20:24:25 *** emilengler has quit IRC
5032019-07-10T20:46:41 *** jarthur_ has quit IRC
5042019-07-10T20:47:20 *** jarthur has joined #bitcoin-core-dev
5052019-07-10T20:47:22 *** scoop has quit IRC
5062019-07-10T20:50:03 *** BillyGarrison has quit IRC
5072019-07-10T20:51:38 *** Guyver2 has quit IRC
5082019-07-10T20:54:02 *** clarkmoody has joined #bitcoin-core-dev
5092019-07-10T20:57:56 <achow101> do we have some way to check if a CTxDestination matches a particular OutputType?
5102019-07-10T20:58:19 *** clarkmoody has quit IRC
5112019-07-10T21:00:02 *** exarkun2 has quit IRC
5122019-07-10T21:03:18 *** clarkmoody has joined #bitcoin-core-dev
5132019-07-10T21:03:49 *** rlaager1 has joined #bitcoin-core-dev
5142019-07-10T21:04:30 <sipa> achow101: there is a .which() function
5152019-07-10T21:04:57 <sipa> which gives a number corresponding to the various positions in the type declaratio
5162019-07-10T21:05:19 <achow101> oh, nice
5172019-07-10T21:06:02 <achow101> sipa: actually, I'm now wondering whether it makes sense to keep the combo() descriptor. it doesn't really fit well into this ScriptPubKeyMan model
5182019-07-10T21:07:22 *** queip has quit IRC
5192019-07-10T21:07:29 <achow101> The main thing is making DescriptorScriptPubKeyMan consistent with the address types that we expect to get from it. For all non-combo descriptors, this is easy. but for combo, it isn't since combo can give all 3 address types
5202019-07-10T21:09:57 <sipa> i guess you could add an IsSingleType function to it or so, which is true fot everything but combo
5212019-07-10T21:10:20 <sipa> and then require descriptors that satisfy that propery in native desceiptor wallets
5222019-07-10T21:11:02 <achow101> if that's the case, what's the point of keeping combo around?
5232019-07-10T21:13:47 *** queip has joined #bitcoin-core-dev
5242019-07-10T21:14:57 *** scoop has joined #bitcoin-core-dev
5252019-07-10T21:16:36 <luke-jr> it's probably better to do a cast than use .which?
5262019-07-10T21:22:10 <sipa> achow101: it's pretty useful for scantxoutset
5272019-07-10T21:22:30 <sipa> and would probably be useful to when converting old wallets into new ones... at least at the time that seemed like a useful thing
5282019-07-10T21:27:10 <jb55> sipa: I played with the idea of some type of union syntax for descriptors since combo seemed a bit hardcoded, but it is probably not that useful
5292019-07-10T21:34:59 *** aseem has quit IRC
5302019-07-10T21:35:59 *** IGHOR has quit IRC
5312019-07-10T21:37:15 *** IGHOR has joined #bitcoin-core-dev
5322019-07-10T21:39:29 *** clarkmoody has quit IRC
5332019-07-10T21:43:49 *** harrigan has quit IRC
5342019-07-10T21:50:10 *** darosior has joined #bitcoin-core-dev
5352019-07-10T22:04:02 *** spinza has quit IRC
5362019-07-10T22:09:17 *** spinza has joined #bitcoin-core-dev
5372019-07-10T22:09:47 *** darosior has quit IRC
5382019-07-10T22:10:25 *** queip has quit IRC
5392019-07-10T22:11:15 *** darosior has joined #bitcoin-core-dev
5402019-07-10T22:16:05 *** queip has joined #bitcoin-core-dev
5412019-07-10T22:16:27 *** darosior has quit IRC
5422019-07-10T22:23:02 *** darosior has joined #bitcoin-core-dev
5432019-07-10T22:32:43 *** spinza has quit IRC
5442019-07-10T22:42:15 *** spinza has joined #bitcoin-core-dev
5452019-07-10T22:43:16 *** michaelsdunn1 has quit IRC
5462019-07-10T22:48:33 *** Victor_sueca has quit IRC
5472019-07-10T22:49:41 *** Victor_sueca has joined #bitcoin-core-dev
5482019-07-10T22:59:14 *** IGHOR has quit IRC
5492019-07-10T23:00:06 *** scoop has quit IRC
5502019-07-10T23:04:23 *** IGHOR has joined #bitcoin-core-dev
5512019-07-10T23:11:36 *** IGHOR has quit IRC
5522019-07-10T23:15:29 *** IGHOR has joined #bitcoin-core-dev
5532019-07-10T23:24:37 *** TheRec has quit IRC
5542019-07-10T23:30:04 *** TheRec has joined #bitcoin-core-dev
5552019-07-10T23:30:04 *** TheRec has joined #bitcoin-core-dev
5562019-07-10T23:35:43 *** jarthur has quit IRC
5572019-07-10T23:49:19 *** Cory has quit IRC
5582019-07-10T23:56:49 *** Honthe has quit IRC
5592019-07-10T23:58:57 *** Honthe has joined #bitcoin-core-dev