12019-07-15T00:00:02 *** scar451 has quit IRC
22019-07-15T00:00:02 *** Zenton has joined #bitcoin-core-dev
32019-07-15T00:04:21 *** penthium2 has joined #bitcoin-core-dev
42019-07-15T00:16:37 *** scoop has quit IRC
52019-07-15T00:17:13 *** scoop has joined #bitcoin-core-dev
62019-07-15T00:17:20 *** spinza has quit IRC
72019-07-15T00:18:54 *** Xunie has quit IRC
82019-07-15T00:21:12 *** EagleTM has joined #bitcoin-core-dev
92019-07-15T00:21:54 *** scoop has quit IRC
102019-07-15T00:23:27 *** spinza has joined #bitcoin-core-dev
112019-07-15T00:30:01 *** Honthe has joined #bitcoin-core-dev
122019-07-15T00:32:51 *** d_t has joined #bitcoin-core-dev
132019-07-15T00:37:22 *** AaronvanW has joined #bitcoin-core-dev
142019-07-15T00:40:58 *** Aaronvan_ has quit IRC
152019-07-15T00:41:09 *** AaronvanW has quit IRC
162019-07-15T00:45:03 *** hebasto has quit IRC
172019-07-15T00:57:03 *** scoop has joined #bitcoin-core-dev
182019-07-15T01:01:27 *** scoop has quit IRC
192019-07-15T01:05:49 *** d_t has quit IRC
202019-07-15T01:07:11 *** pinheadmz has quit IRC
212019-07-15T01:09:35 *** gelmutshmidt has quit IRC
222019-07-15T01:20:52 *** rutyiraw has quit IRC
232019-07-15T01:37:17 *** nijak_ has joined #bitcoin-core-dev
242019-07-15T01:37:20 *** nijak has quit IRC
252019-07-15T01:44:40 *** nijak has joined #bitcoin-core-dev
262019-07-15T01:46:12 *** nijak_ has quit IRC
272019-07-15T01:59:39 *** nijak_ has joined #bitcoin-core-dev
282019-07-15T02:01:48 *** nijak has quit IRC
292019-07-15T02:03:23 *** dviola has quit IRC
302019-07-15T02:16:02 *** EagleTM has quit IRC
312019-07-15T02:19:24 *** behradkhodayar has joined #bitcoin-core-dev
322019-07-15T02:30:29 *** behradkhodayar has quit IRC
332019-07-15T02:35:45 *** behradkhodayar has joined #bitcoin-core-dev
342019-07-15T02:36:44 *** behradkhodayar has quit IRC
352019-07-15T02:43:58 *** nijak has joined #bitcoin-core-dev
362019-07-15T02:45:07 *** nijak_ has quit IRC
372019-07-15T02:45:55 *** kristapsk_ has joined #bitcoin-core-dev
382019-07-15T02:46:02 *** kristapsk has quit IRC
392019-07-15T02:47:36 *** mryandao has quit IRC
402019-07-15T02:47:47 *** mryandao_ has joined #bitcoin-core-dev
412019-07-15T02:47:50 *** ghost43 has quit IRC
422019-07-15T02:49:01 *** mryandao_ is now known as mryandao
432019-07-15T02:49:53 *** ghost43 has joined #bitcoin-core-dev
442019-07-15T03:00:01 *** penthium2 has quit IRC
452019-07-15T03:18:10 *** hebasto has joined #bitcoin-core-dev
462019-07-15T03:42:44 *** mattl1 has joined #bitcoin-core-dev
472019-07-15T03:43:12 *** nijak_ has joined #bitcoin-core-dev
482019-07-15T03:45:16 *** nijak has quit IRC
492019-07-15T03:50:04 *** hebasto has quit IRC
502019-07-15T04:13:22 *** queip has quit IRC
512019-07-15T04:19:13 *** queip has joined #bitcoin-core-dev
522019-07-15T04:58:21 *** scoop has joined #bitcoin-core-dev
532019-07-15T05:03:03 *** scoop has quit IRC
542019-07-15T05:12:01 *** rh0nj has quit IRC
552019-07-15T05:13:07 *** rh0nj has joined #bitcoin-core-dev
562019-07-15T05:14:02 *** rh0nj has quit IRC
572019-07-15T05:15:07 *** rh0nj has joined #bitcoin-core-dev
582019-07-15T06:00:02 *** mattl1 has quit IRC
592019-07-15T06:05:38 *** StephenS1 has joined #bitcoin-core-dev
602019-07-15T06:19:24 *** Krellan has quit IRC
612019-07-15T06:19:29 *** Krellan_ has joined #bitcoin-core-dev
622019-07-15T06:19:57 *** Raystonn has joined #bitcoin-core-dev
632019-07-15T06:23:53 *** queip has quit IRC
642019-07-15T06:26:26 *** davec has quit IRC
652019-07-15T06:26:40 *** Raystonn has quit IRC
662019-07-15T06:28:59 *** Raystonn has joined #bitcoin-core-dev
672019-07-15T06:30:48 *** queip has joined #bitcoin-core-dev
682019-07-15T06:32:13 *** gelmutshmidt has joined #bitcoin-core-dev
692019-07-15T06:44:44 <fanquake> Does anyone know why Travis gets marked as failing, even though all tests are passing? i.e https://travis-ci.org/bitcoin/bitcoin/builds/558768209 is all green, but I see red in the GitHub UI (#16386) .It seems that running the extended lint stage will kick it over to green though..
702019-07-15T06:44:48 <gribble> https://github.com/bitcoin/bitcoin/issues/16386 | depends: disable unused Qt features by fanquake · Pull Request #16386 · bitcoin/bitcoin · GitHub
712019-07-15T06:50:28 *** luke-jr has quit IRC
722019-07-15T06:50:29 *** windsok has quit IRC
732019-07-15T06:50:29 *** Jackielove4u has quit IRC
742019-07-15T06:50:29 *** xHire has quit IRC
752019-07-15T06:50:32 *** TheFuzzStone[m] has quit IRC
762019-07-15T06:50:32 *** infernix has quit IRC
772019-07-15T06:50:32 *** neatnik has quit IRC
782019-07-15T06:50:32 *** wumpus has quit IRC
792019-07-15T06:50:32 *** Isthmus has quit IRC
802019-07-15T06:50:32 *** provoostenator has quit IRC
812019-07-15T06:50:32 *** dmkathayat_ has quit IRC
822019-07-15T06:50:36 *** esotericnonsens_ is now known as esotericnonsense
832019-07-15T06:50:36 *** profmac has quit IRC
842019-07-15T06:50:36 *** gleb has quit IRC
852019-07-15T06:50:36 *** Karyon has quit IRC
862019-07-15T06:50:36 *** Nukeops has quit IRC
872019-07-15T06:50:39 *** tuirektiujm[m] has quit IRC
882019-07-15T06:50:39 *** kewde[m] has quit IRC
892019-07-15T06:50:40 *** adiabat has quit IRC
902019-07-15T06:53:22 *** fanquake has quit IRC
912019-07-15T06:53:57 *** fanquake has joined #bitcoin-core-dev
922019-07-15T06:54:00 *** designwish has quit IRC
932019-07-15T06:57:31 *** designwish has joined #bitcoin-core-dev
942019-07-15T06:58:26 *** bitcoin-git has joined #bitcoin-core-dev
952019-07-15T06:58:26 <bitcoin-git> [bitcoin] fanquake opened pull request #16392: WIP build: macOS toolchain update (master...macos-toolchain-update) https://github.com/bitcoin/bitcoin/pull/16392
962019-07-15T06:58:27 *** bitcoin-git has left #bitcoin-core-dev
972019-07-15T07:01:26 *** davec has joined #bitcoin-core-dev
982019-07-15T07:06:24 *** pinheadmz has joined #bitcoin-core-dev
992019-07-15T07:10:21 *** Krellan has joined #bitcoin-core-dev
1002019-07-15T07:10:55 *** Krellan_ has quit IRC
1012019-07-15T07:16:19 *** profmac has joined #bitcoin-core-dev
1022019-07-15T07:16:19 *** gleb has joined #bitcoin-core-dev
1032019-07-15T07:16:19 *** Karyon has joined #bitcoin-core-dev
1042019-07-15T07:16:19 *** Nukeops has joined #bitcoin-core-dev
1052019-07-15T07:16:19 *** kewde[m] has joined #bitcoin-core-dev
1062019-07-15T07:16:19 *** tuirektiujm[m] has joined #bitcoin-core-dev
1072019-07-15T07:16:19 *** adiabat has joined #bitcoin-core-dev
1082019-07-15T07:16:36 *** esotericnonsense is now known as 17SAA1TBX
1092019-07-15T07:16:45 *** luke-jr has joined #bitcoin-core-dev
1102019-07-15T07:16:45 *** windsok has joined #bitcoin-core-dev
1112019-07-15T07:16:45 *** Jackielove4u has joined #bitcoin-core-dev
1122019-07-15T07:16:45 *** xHire has joined #bitcoin-core-dev
1132019-07-15T07:16:45 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1142019-07-15T07:16:45 *** infernix has joined #bitcoin-core-dev
1152019-07-15T07:16:45 *** neatnik has joined #bitcoin-core-dev
1162019-07-15T07:16:45 *** wumpus has joined #bitcoin-core-dev
1172019-07-15T07:16:45 *** Isthmus has joined #bitcoin-core-dev
1182019-07-15T07:16:45 *** provoostenator has joined #bitcoin-core-dev
1192019-07-15T07:16:45 *** dmkathayat_ has joined #bitcoin-core-dev
1202019-07-15T07:17:02 *** luke-jr has quit IRC
1212019-07-15T07:18:02 *** luke-jr has joined #bitcoin-core-dev
1222019-07-15T07:20:35 *** pinheadmz has quit IRC
1232019-07-15T07:21:35 *** 17SAA1TBX is now known as esotericnonsens_
1242019-07-15T07:37:56 *** jungly has joined #bitcoin-core-dev
1252019-07-15T07:38:58 *** Krellan has quit IRC
1262019-07-15T07:41:19 *** Krellan has joined #bitcoin-core-dev
1272019-07-15T07:42:58 *** jonatack has joined #bitcoin-core-dev
1282019-07-15T07:43:43 *** AaronvanW has joined #bitcoin-core-dev
1292019-07-15T07:50:29 *** Aaronvan_ has joined #bitcoin-core-dev
1302019-07-15T07:54:10 *** AaronvanW has quit IRC
1312019-07-15T07:59:35 *** jonatack has quit IRC
1322019-07-15T08:08:44 *** queip has quit IRC
1332019-07-15T08:16:45 *** queip has joined #bitcoin-core-dev
1342019-07-15T08:17:50 *** setpill has joined #bitcoin-core-dev
1352019-07-15T08:19:23 *** goatpig has quit IRC
1362019-07-15T08:24:58 *** jungly has quit IRC
1372019-07-15T08:25:27 *** luc__ has quit IRC
1382019-07-15T08:26:24 *** profmac has quit IRC
1392019-07-15T08:26:24 *** gleb has quit IRC
1402019-07-15T08:26:25 *** Karyon has quit IRC
1412019-07-15T08:26:25 *** Nukeops has quit IRC
1422019-07-15T08:26:26 *** tuirektiujm[m] has quit IRC
1432019-07-15T08:26:27 *** kewde[m] has quit IRC
1442019-07-15T08:26:27 *** adiabat has quit IRC
1452019-07-15T08:27:06 *** windsok has quit IRC
1462019-07-15T08:27:06 *** Jackielove4u has quit IRC
1472019-07-15T08:27:06 *** xHire has quit IRC
1482019-07-15T08:27:07 *** TheFuzzStone[m] has quit IRC
1492019-07-15T08:27:07 *** infernix has quit IRC
1502019-07-15T08:27:07 *** neatnik has quit IRC
1512019-07-15T08:27:07 *** wumpus has quit IRC
1522019-07-15T08:27:07 *** Isthmus has quit IRC
1532019-07-15T08:27:07 *** provoostenator has quit IRC
1542019-07-15T08:27:08 *** dmkathayat_ has quit IRC
1552019-07-15T08:27:08 *** esotericnonsens_ is now known as esotericnonsense
1562019-07-15T08:35:39 *** xHire has joined #bitcoin-core-dev
1572019-07-15T08:35:41 *** provoostenator has joined #bitcoin-core-dev
1582019-07-15T08:35:41 *** windsok has joined #bitcoin-core-dev
1592019-07-15T08:35:43 *** neatnik has joined #bitcoin-core-dev
1602019-07-15T08:35:45 *** dmkathayat has joined #bitcoin-core-dev
1612019-07-15T08:35:46 *** windsok has quit IRC
1622019-07-15T08:35:47 *** windsok has joined #bitcoin-core-dev
1632019-07-15T08:35:48 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1642019-07-15T08:35:49 *** Isthmus has joined #bitcoin-core-dev
1652019-07-15T08:36:24 *** gleb has joined #bitcoin-core-dev
1662019-07-15T08:36:42 *** Nukeops has joined #bitcoin-core-dev
1672019-07-15T08:36:44 *** wumpus has joined #bitcoin-core-dev
1682019-07-15T08:37:04 *** adiabat has joined #bitcoin-core-dev
1692019-07-15T08:37:11 *** Jackielove4u has joined #bitcoin-core-dev
1702019-07-15T08:37:14 *** jungly has joined #bitcoin-core-dev
1712019-07-15T08:37:19 *** profmac has joined #bitcoin-core-dev
1722019-07-15T08:37:19 *** Karyon has joined #bitcoin-core-dev
1732019-07-15T08:37:54 *** treyzania has quit IRC
1742019-07-15T08:38:34 *** Krellan has quit IRC
1752019-07-15T08:39:22 *** tuirektiujm[m] has joined #bitcoin-core-dev
1762019-07-15T08:40:06 *** Bullit has quit IRC
1772019-07-15T08:40:36 *** treyzania has joined #bitcoin-core-dev
1782019-07-15T08:41:11 *** luc__ has joined #bitcoin-core-dev
1792019-07-15T08:42:37 *** kewde[m] has joined #bitcoin-core-dev
1802019-07-15T08:44:25 *** Eda79Schumm has joined #bitcoin-core-dev
1812019-07-15T08:45:28 *** justanotheruser has quit IRC
1822019-07-15T08:56:14 *** darosior has quit IRC
1832019-07-15T08:58:19 *** behradkhodayar has joined #bitcoin-core-dev
1842019-07-15T08:59:14 *** darosior has joined #bitcoin-core-dev
1852019-07-15T08:59:34 *** infernix has joined #bitcoin-core-dev
1862019-07-15T08:59:40 *** timothy has joined #bitcoin-core-dev
1872019-07-15T08:59:50 *** scoop has joined #bitcoin-core-dev
1882019-07-15T09:00:01 *** StephenS1 has quit IRC
1892019-07-15T09:03:47 *** Eda79Schumm has quit IRC
1902019-07-15T09:04:10 *** jungly has quit IRC
1912019-07-15T09:04:28 *** scoop has quit IRC
1922019-07-15T09:06:47 *** justanotheruser has joined #bitcoin-core-dev
1932019-07-15T09:07:32 *** darosior has quit IRC
1942019-07-15T09:09:29 *** jungly has joined #bitcoin-core-dev
1952019-07-15T09:12:59 *** queip has quit IRC
1962019-07-15T09:13:05 *** luc__ has quit IRC
1972019-07-15T09:18:41 *** queip has joined #bitcoin-core-dev
1982019-07-15T09:20:33 *** sunetoft has joined #bitcoin-core-dev
1992019-07-15T09:32:32 *** asdf44 has joined #bitcoin-core-dev
2002019-07-15T09:56:25 *** jonatack has joined #bitcoin-core-dev
2012019-07-15T09:57:09 *** behradkhodayar has quit IRC
2022019-07-15T09:57:32 *** Honthe has quit IRC
2032019-07-15T10:04:08 *** behradkhodayar has joined #bitcoin-core-dev
2042019-07-15T10:05:26 *** Guyver2 has joined #bitcoin-core-dev
2052019-07-15T10:11:45 *** spinza has quit IRC
2062019-07-15T10:17:23 *** setpill has quit IRC
2072019-07-15T10:22:50 *** spinza has joined #bitcoin-core-dev
2082019-07-15T10:33:55 *** shesek has quit IRC
2092019-07-15T10:34:06 <stevenroose> Is there a limit to the size of the label field for addresses?
2102019-07-15T10:36:26 *** Skirmant has joined #bitcoin-core-dev
2112019-07-15T10:43:23 *** jungly has quit IRC
2122019-07-15T10:45:45 *** jungly has joined #bitcoin-core-dev
2132019-07-15T10:49:59 *** as1nc_ has quit IRC
2142019-07-15T10:50:27 *** as1nc_ has joined #bitcoin-core-dev
2152019-07-15T10:52:18 *** Skirmant has quit IRC
2162019-07-15T10:59:11 *** Bullit has joined #bitcoin-core-dev
2172019-07-15T11:01:37 *** scoop has joined #bitcoin-core-dev
2182019-07-15T11:11:03 *** jungly has quit IRC
2192019-07-15T11:14:07 *** jungly has joined #bitcoin-core-dev
2202019-07-15T11:16:17 *** scoop has quit IRC
2212019-07-15T11:24:26 *** Aaronvan_ is now known as AaronvanW
2222019-07-15T11:26:52 *** behradkhodayar has quit IRC
2232019-07-15T11:27:38 *** shesek has joined #bitcoin-core-dev
2242019-07-15T11:35:18 *** spinza has quit IRC
2252019-07-15T11:43:22 *** rutyiraw has joined #bitcoin-core-dev
2262019-07-15T11:47:34 *** Guyver2 has quit IRC
2272019-07-15T11:49:32 *** afk11 has quit IRC
2282019-07-15T11:49:33 *** jb55 has quit IRC
2292019-07-15T11:49:33 *** lowentropy has quit IRC
2302019-07-15T11:50:46 *** rutyiraw has quit IRC
2312019-07-15T11:51:25 *** queip has quit IRC
2322019-07-15T11:51:37 *** afk11 has joined #bitcoin-core-dev
2332019-07-15T11:51:53 *** sipa has quit IRC
2342019-07-15T11:51:53 *** morcos has quit IRC
2352019-07-15T11:51:53 *** arubi has quit IRC
2362019-07-15T11:52:09 *** sipa has joined #bitcoin-core-dev
2372019-07-15T11:52:11 *** morcos has joined #bitcoin-core-dev
2382019-07-15T11:52:12 *** jb55 has joined #bitcoin-core-dev
2392019-07-15T11:52:19 *** arubi has joined #bitcoin-core-dev
2402019-07-15T11:54:59 *** lowentropy has joined #bitcoin-core-dev
2412019-07-15T11:57:47 *** queip has joined #bitcoin-core-dev
2422019-07-15T12:00:01 *** sunetoft has quit IRC
2432019-07-15T12:03:55 *** spinza has joined #bitcoin-core-dev
2442019-07-15T12:04:08 *** Hobbestigrou1 has joined #bitcoin-core-dev
2452019-07-15T12:04:11 *** bitcoin-git has joined #bitcoin-core-dev
2462019-07-15T12:04:11 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/536590f358dc...0822b44d8a68
2472019-07-15T12:04:11 <bitcoin-git> bitcoin/master 8f250ab Steven Roose: TEST: Replace hard-coded hex tx with classes
2482019-07-15T12:04:12 <bitcoin-git> bitcoin/master 0822b44 MarcoFalke: Merge #15282: test: Replace hard-coded hex tx with class in test framework...
2492019-07-15T12:04:14 *** bitcoin-git has left #bitcoin-core-dev
2502019-07-15T12:04:42 *** bitcoin-git has joined #bitcoin-core-dev
2512019-07-15T12:04:42 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15282: test: Replace hard-coded hex tx with class in test framework (master...util-messages) https://github.com/bitcoin/bitcoin/pull/15282
2522019-07-15T12:04:47 *** bitcoin-git has left #bitcoin-core-dev
2532019-07-15T12:06:45 *** fooman has quit IRC
2542019-07-15T12:09:24 *** shesek has quit IRC
2552019-07-15T12:11:15 *** shesek has joined #bitcoin-core-dev
2562019-07-15T12:11:15 *** shesek has joined #bitcoin-core-dev
2572019-07-15T12:12:58 *** cubancorona has quit IRC
2582019-07-15T12:13:19 *** rutyiraw has joined #bitcoin-core-dev
2592019-07-15T12:29:12 *** jungly has quit IRC
2602019-07-15T12:31:18 *** shesek has quit IRC
2612019-07-15T12:31:36 *** jungly has joined #bitcoin-core-dev
2622019-07-15T12:34:38 *** justanotheruser has quit IRC
2632019-07-15T12:39:23 *** spaced0ut has joined #bitcoin-core-dev
2642019-07-15T12:41:11 *** setpill has joined #bitcoin-core-dev
2652019-07-15T12:45:27 *** scoop has joined #bitcoin-core-dev
2662019-07-15T12:49:01 *** reallll has joined #bitcoin-core-dev
2672019-07-15T12:51:30 *** justanotheruser has joined #bitcoin-core-dev
2682019-07-15T12:52:07 *** belcher has quit IRC
2692019-07-15T13:02:12 *** queip has quit IRC
2702019-07-15T13:02:47 *** shesek has joined #bitcoin-core-dev
2712019-07-15T13:03:45 *** farmerwampum has quit IRC
2722019-07-15T13:04:14 *** Honthe has joined #bitcoin-core-dev
2732019-07-15T13:05:37 *** scoop has quit IRC
2742019-07-15T13:05:44 *** scoop has joined #bitcoin-core-dev
2752019-07-15T13:08:09 *** queip has joined #bitcoin-core-dev
2762019-07-15T13:10:34 *** d_t has joined #bitcoin-core-dev
2772019-07-15T13:17:10 *** spaced0ut has quit IRC
2782019-07-15T13:18:38 *** farmerwampum has joined #bitcoin-core-dev
2792019-07-15T13:34:31 *** Xunie has joined #bitcoin-core-dev
2802019-07-15T13:41:26 *** afk11 has quit IRC
2812019-07-15T13:41:52 *** afk11 has joined #bitcoin-core-dev
2822019-07-15T13:43:37 *** shesek has quit IRC
2832019-07-15T13:48:49 *** d_t has quit IRC
2842019-07-15T13:50:11 *** spaced0ut has joined #bitcoin-core-dev
2852019-07-15T13:50:28 *** d_t has joined #bitcoin-core-dev
2862019-07-15T13:54:42 *** d_t has quit IRC
2872019-07-15T13:59:31 *** obsrver has joined #bitcoin-core-dev
2882019-07-15T14:16:15 *** shesek has joined #bitcoin-core-dev
2892019-07-15T14:16:15 *** shesek has joined #bitcoin-core-dev
2902019-07-15T14:22:27 *** goatpig has joined #bitcoin-core-dev
2912019-07-15T14:30:02 *** queip has quit IRC
2922019-07-15T14:30:11 *** reallll is now known as belcher
2932019-07-15T14:30:28 *** Guyver2 has joined #bitcoin-core-dev
2942019-07-15T14:37:28 *** pinheadmz has joined #bitcoin-core-dev
2952019-07-15T14:37:29 *** queip has joined #bitcoin-core-dev
2962019-07-15T14:37:31 *** pinheadmz has quit IRC
2972019-07-15T14:37:56 *** pinheadmz has joined #bitcoin-core-dev
2982019-07-15T14:41:27 *** mryandao has quit IRC
2992019-07-15T14:41:52 *** mryandao has joined #bitcoin-core-dev
3002019-07-15T14:45:03 *** spaced0ut has quit IRC
3012019-07-15T14:47:38 *** michaelsdunn1 has joined #bitcoin-core-dev
3022019-07-15T14:52:33 *** farmerwampum has quit IRC
3032019-07-15T14:53:48 <jb55> stevenroose: it looks like it's serialized as compactsized-length and then a string, so no.
3042019-07-15T14:54:14 <stevenroose> jb55: cool, thanks!
3052019-07-15T14:54:43 <stevenroose> I need to store multiple pieces of information in there for some project. So I'll fill it with a JSON object with multiple fields :D
3062019-07-15T14:54:45 *** spaced0ut has joined #bitcoin-core-dev
3072019-07-15T14:55:02 <stevenroose> They say blockchain is just a slow database :D
3082019-07-15T14:58:01 *** farmerwampum has joined #bitcoin-core-dev
3092019-07-15T15:00:01 *** Hobbestigrou1 has quit IRC
3102019-07-15T15:00:15 <stevenroose> Something else less core-related: the segwit p2wpkh verification is implemented totally stand-alone, right?
3112019-07-15T15:00:45 <stevenroose> It's not converted into some weird script or so, right? I'm pretty sure it's not. It's just that I'm spending a segwit output in a test script and I'm getting this error:
3122019-07-15T15:01:03 <stevenroose> non-mandatory-script-verify-flag (Script failed an OP_EQUALVERIFY operation) (code 64)
3132019-07-15T15:02:07 <stevenroose> I'm asserting above that this is the script: 0014621daf5f171129d0c56f9d012b9306e215bde726, which is clearly a segwit script and not p2pkh or whatever script with OP_EQUALVERIFY
3142019-07-15T15:10:20 *** jungly has quit IRC
3152019-07-15T15:16:00 *** captjakk has joined #bitcoin-core-dev
3162019-07-15T15:18:43 *** jungly has joined #bitcoin-core-dev
3172019-07-15T15:20:06 <stevenroose> Does segwit also require adding the sighash byte at the end of the signature?
3182019-07-15T15:21:56 <sipa> p2wpkh/p2wsh do
3192019-07-15T15:22:40 <sipa> and p2wpkh uses as redeemscript the equivalent p2pkh script
3202019-07-15T15:24:17 <stevenroose> sipa so for the bip143 sighash calculation, do I need to provide a "witness script"?
3212019-07-15T15:24:31 <stevenroose> I thought that was only for p2wsh.
3222019-07-15T15:24:52 <stevenroose> After adding the sighash byte, I'm getting this: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 64)
3232019-07-15T15:25:16 <stevenroose> It seems that segwit operations somehow enter the script execution code, which confuses me.
3242019-07-15T15:26:29 *** as1nc_ has quit IRC
3252019-07-15T15:26:34 <sipa> stevenroose: the witness script never goes into the sighash
3262019-07-15T15:26:50 <sipa> not in v0 witness or in legacy
3272019-07-15T15:27:07 <sipa> the *executed code* (scriptcode) goes into the sighash
3282019-07-15T15:27:13 <stevenroose> sipa: this field 5. scriptCode of the input (serialized as scripts inside CTxOuts)
3292019-07-15T15:27:23 <stevenroose> Is called "witness_script" in Andrew's Rust implementation.
3302019-07-15T15:27:34 <sipa> that's confusing
3312019-07-15T15:27:35 <stevenroose> What should I provide for that? The output script of the utxo?
3322019-07-15T15:27:39 *** as1nc_ has joined #bitcoin-core-dev
3332019-07-15T15:27:57 <sipa> the executed code
3342019-07-15T15:28:09 <sipa> for p2wsh that is the witness script
3352019-07-15T15:28:20 <sipa> for p2wpkh that is the equivalent p2pkh script
3362019-07-15T15:28:27 <stevenroose> I don't know what the "executed code" or "witness script" refer to?
3372019-07-15T15:28:30 <stevenroose> Witness program?
3382019-07-15T15:28:36 <sipa> bip143 has examples
3392019-07-15T15:28:38 <stevenroose> The p2wpkh script_pubkey?
3402019-07-15T15:28:46 <sipa> the program being executed
3412019-07-15T15:28:59 <sipa> i don't know how i can be clearer :)
3422019-07-15T15:29:04 *** Zenton has quit IRC
3432019-07-15T15:29:15 <stevenroose> ss << static_cast<const CScriptBase&>(scriptCode);
3442019-07-15T15:29:24 *** Zenton has joined #bitcoin-core-dev
3452019-07-15T15:29:39 *** jonatack has quit IRC
3462019-07-15T15:29:41 <sipa> yes
3472019-07-15T15:29:53 <stevenroose> sipa: well I don't know which program is gonna be executed without knowing the internals, right? :) What is more helpful is where I can find that program..
3482019-07-15T15:30:00 <sipa> scriptCode is the script being executes by the script interpreter
3492019-07-15T15:30:16 <sipa> for p2wsh that is the witness program
3502019-07-15T15:30:48 <sipa> for p2wpkh that is the equivalent p2pkh program (dup hash160 <hash> equalverify checksig, iirc)
3512019-07-15T15:31:11 <stevenroose> I'm getting OP_EQUALVERIFY errors, so I'm getting the feeling that segwit validation is somehow done by converting the witness program into a legacy script equivalent. I never heard of such a thing, though, so I'm confused :)
3522019-07-15T15:31:24 <sipa> yes
3532019-07-15T15:31:27 <sipa> i just told you
3542019-07-15T15:31:28 <stevenroose> Ah ok, so there actually *is* some kind of p2wpkh->p2pkh convertion under the hood.
3552019-07-15T15:31:34 <sipa> yes
3562019-07-15T15:32:15 <stevenroose> Wow, that's strange :) Glad that goes with taproot :) Ok, so I have to serialize a legacy p2pkh output script and provide that. Cool, thanks!
3572019-07-15T15:32:50 *** jungly has quit IRC
3582019-07-15T15:32:59 *** as1nc_ has quit IRC
3592019-07-15T15:33:18 *** as1nc_ has joined #bitcoin-core-dev
3602019-07-15T15:37:15 <stevenroose> Yay, that worked!
3612019-07-15T15:38:15 <sipa> :)
3622019-07-15T15:39:33 *** Jayflux has joined #bitcoin-core-dev
3632019-07-15T15:45:15 *** jungly has joined #bitcoin-core-dev
3642019-07-15T15:50:58 *** lnostdal has quit IRC
3652019-07-15T15:57:41 *** cubancorona has joined #bitcoin-core-dev
3662019-07-15T16:04:58 *** jonatack has joined #bitcoin-core-dev
3672019-07-15T16:14:03 *** captjakk has quit IRC
3682019-07-15T16:14:17 *** captjakk has joined #bitcoin-core-dev
3692019-07-15T16:14:41 *** bralyclow has joined #bitcoin-core-dev
3702019-07-15T16:14:48 *** captjakk has quit IRC
3712019-07-15T16:15:02 *** captjakk has joined #bitcoin-core-dev
3722019-07-15T16:15:38 *** AaronvanW has quit IRC
3732019-07-15T16:15:53 *** captjakk has joined #bitcoin-core-dev
3742019-07-15T16:15:58 *** AaronvanW has joined #bitcoin-core-dev
3752019-07-15T16:16:21 *** captjakk has quit IRC
3762019-07-15T16:16:36 *** captjakk has joined #bitcoin-core-dev
3772019-07-15T16:16:51 *** bralyclow has quit IRC
3782019-07-15T16:17:07 *** captjakk has quit IRC
3792019-07-15T16:29:23 *** farmerwampum has quit IRC
3802019-07-15T16:44:14 *** farmerwampum has joined #bitcoin-core-dev
3812019-07-15T16:49:27 *** lnostdal has joined #bitcoin-core-dev
3822019-07-15T16:53:14 *** jarthur has joined #bitcoin-core-dev
3832019-07-15T16:58:19 *** lnostdal has quit IRC
3842019-07-15T17:00:54 *** captjakk has joined #bitcoin-core-dev
3852019-07-15T17:02:11 *** pinheadmz_ has joined #bitcoin-core-dev
3862019-07-15T17:04:13 *** pinheadmz has quit IRC
3872019-07-15T17:04:13 *** pinheadmz_ is now known as pinheadmz
3882019-07-15T17:04:51 *** jonatack has quit IRC
3892019-07-15T17:05:26 *** emilengler has joined #bitcoin-core-dev
3902019-07-15T17:08:27 *** luc__ has joined #bitcoin-core-dev
3912019-07-15T17:09:36 *** timothy has quit IRC
3922019-07-15T17:09:37 *** queip has quit IRC
3932019-07-15T17:14:25 *** queip has joined #bitcoin-core-dev
3942019-07-15T17:24:24 *** luc___ has joined #bitcoin-core-dev
3952019-07-15T17:26:20 *** achow101 has quit IRC
3962019-07-15T17:26:41 *** jungly has quit IRC
3972019-07-15T17:26:51 *** luc__ has quit IRC
3982019-07-15T17:27:33 *** achow101 has joined #bitcoin-core-dev
3992019-07-15T17:30:16 *** captjakk has quit IRC
4002019-07-15T17:34:32 *** setpill has quit IRC
4012019-07-15T17:38:06 *** lnostdal has joined #bitcoin-core-dev
4022019-07-15T17:40:05 *** harrigan has joined #bitcoin-core-dev
4032019-07-15T17:46:01 *** rutyiraw has quit IRC
4042019-07-15T17:47:47 *** captjakk has joined #bitcoin-core-dev
4052019-07-15T17:48:39 <Raystonn> There are way too many cases of CAmount and double being mixed together. That's just unsafe. I'm going to start cleaning those up. CAmount should not be used with floating point types, which can drop digits.
4062019-07-15T17:49:34 <sipa> doubles have 52 bit precision, which is sufficient for any valid BTC amount
4072019-07-15T17:49:42 <sipa> internally, amounts are always represented as CAmount
4082019-07-15T17:49:47 <Raystonn> That makes assumptions as to the internal representation of CAmount.
4092019-07-15T17:49:57 <sipa> CAmount is an int64
4102019-07-15T17:50:01 <Raystonn> This can change in the future.
4112019-07-15T17:50:16 <sipa> sure
4122019-07-15T17:50:40 <Raystonn> Test cases that mix double with CAmount will then start failing.
4132019-07-15T17:50:45 <Raystonn> Not great.
4142019-07-15T17:50:58 <Raystonn> The code shoudl be more robust there. I will clean it up.
4152019-07-15T17:51:49 <sipa> internally everything is represented as CAmounts
4162019-07-15T17:51:58 <sipa> floating point things are only used for feerate policies
4172019-07-15T17:52:17 <Raystonn> I wish that were true.
4182019-07-15T17:52:28 <Raystonn> Lots of mixing in double calculations in core code.
4192019-07-15T17:52:43 <Raystonn> decays, etc.
4202019-07-15T17:52:54 <sipa> where?
4212019-07-15T17:53:19 <sipa> the fee estimation code, sure
4222019-07-15T17:53:31 <sipa> consensus rules only use CAmount
4232019-07-15T17:53:54 <Raystonn> That's a great start.
4242019-07-15T17:53:59 <Raystonn> and certainly required.
4252019-07-15T17:54:19 <sipa> if you were more specific i could give better advice
4262019-07-15T17:55:00 <sipa> you're not going to rewrite the fee estimation code without floating point logic
4272019-07-15T17:57:37 <Raystonn> It's certainly possible. One can break out such code into integer operations that use integer numerator and denominators instead of a single float decay rate. A CAmount can then be multiplied by the numerator, then divided by the denominator, and still get the desired result. The fractional portion of the result will still be truncated when storing the actual fee as a CAmount.
4282019-07-15T17:58:10 <sipa> yes, you can
4292019-07-15T17:58:11 <Raystonn> This would be safe even if CAmount was upgraded to a larger-range type.
4302019-07-15T17:58:13 <sipa> but why would you?
4312019-07-15T17:58:19 <sipa> exact accuracy isn't required for any of that
4322019-07-15T17:58:42 <Raystonn> Whereas use a a floating point type will break the calculations upon any such upgrade in the future.
4332019-07-15T17:58:46 *** queip has quit IRC
4342019-07-15T17:58:58 <sipa> CAmount can't be upgraded to a larger range type
4352019-07-15T17:59:08 <Raystonn> Of course it can.
4362019-07-15T17:59:17 <sipa> and even if it did, nothing would break with feerate calculations
4372019-07-15T17:59:26 <sipa> as those are approximate anyway
4382019-07-15T17:59:44 <Raystonn> It could easily overflow the significant digits available in a double if we upgrade to a 128-bit integer.
4392019-07-15T17:59:59 <sipa> So?
4402019-07-15T18:00:01 *** Jayflux has quit IRC
4412019-07-15T18:00:54 <sipa> a 0.0000000000002% rounding error on a feerate is much less than the variations that are inherent due to inconsistency of mempools
4422019-07-15T18:01:24 <sipa> and again, bitcoin's consensus rules don't permit amounts above 2100000000000000 units
4432019-07-15T18:01:40 <Raystonn> If fees were to move into sub-satoshi range, that rounding errors would be pretty large as everything sub-satoshi gets truncated.
4442019-07-15T18:02:25 <sipa> bitcoin does not have sub-satoshi units
4452019-07-15T18:02:29 <Raystonn> yet
4462019-07-15T18:02:50 <sipa> that would be such an invasive hard fork that the code changes necessary to do it correctly will be the least of our worries
4472019-07-15T18:02:50 <Raystonn> and there's no erason to keep code that woudl break under these circumstances when it's so easy to fix.
4482019-07-15T18:02:58 <sipa> please focus on real issues
4492019-07-15T18:03:14 <Raystonn> I'm not asking you to make any changes.
4502019-07-15T18:03:27 <Raystonn> This is what I'm choosing to look at.
4512019-07-15T18:03:40 <sipa> and i'm suggesting there are better ways to spend your time
4522019-07-15T18:03:53 <Raystonn> That's fine.
4532019-07-15T18:04:01 <Raystonn> We can disagree. ;)
4542019-07-15T18:04:12 <sipa> of course
4552019-07-15T18:05:31 *** queip has joined #bitcoin-core-dev
4562019-07-15T18:08:51 *** udsbotu has joined #bitcoin-core-dev
4572019-07-15T18:11:24 <sipa> but in my opinion, getting rid of floating point logic in places where exact accuracy isn't required would be a waste of your time
4582019-07-15T18:16:15 <Raystonn> Normally I'd agree. But upon testing a change of CAmount to boost::multiprecision::int128_t, the floating point operations aren't even supported. I could add them, but it could lead to dropped precision or accuracy some place where it matters simply by defining the operators.
4592019-07-15T18:16:35 <sipa> there is no need for 128 bit integers
4602019-07-15T18:16:41 <Raystonn> Right now no.
4612019-07-15T18:17:04 <sipa> it seems highly unlikely that a change to the monetary policy will ever happen in bitcoin
4622019-07-15T18:17:29 <sipa> you can prepare for all kinds of theoretical adaptations, but this isn't a realistic one
4632019-07-15T18:17:34 <Raystonn> Bitcoin must remain <= 21 million coins.
4642019-07-15T18:17:54 <Raystonn> Divisibility of those coins can be expanded.
4652019-07-15T18:18:05 <sipa> not without a very invasive hardfork
4662019-07-15T18:18:44 <sipa> and such changes are generally considered off-topic here
4672019-07-15T18:19:27 <Raystonn> Right now I'm just talking about cleaning up use of floating point operations where unneeded.
4682019-07-15T18:19:34 <sipa> they are not unneeded
4692019-07-15T18:19:41 <sipa> they're an engineering choice
4702019-07-15T18:20:13 <sipa> yes you can get rid of them at the cost of replacing them with more complex logic that effectively reimplements it
4712019-07-15T18:20:18 <sipa> but that is not a good trade-off
4722019-07-15T18:20:36 <sipa> there is nothing "unclean" about the use of floating point numbers; they're the right tool for the job, in some places
4732019-07-15T18:22:16 <sipa> and i can't speak for any of the other reviewers of course, but i doubt such a change would be accepted
4742019-07-15T18:25:05 <sipa> now if you find places where floating point logic is used where inaccurancy may actually affect the correctness of the code, i'd very much like to hear it
4752019-07-15T18:25:08 <Raystonn> I certainly have no interest in any fork that might create yet another sh-coin. Not my intention. I'm just trying to make the code more robust to future enhancements without breaking backward compatibility.
4762019-07-15T18:27:48 <Raystonn> Many years into the future I could foresee the desire to continue the block reward into sub-satoshi units, keeping the asymptote at 21,000,000 coins.
4772019-07-15T18:28:07 <sipa> that would be a change to the monetary policy
4782019-07-15T18:28:57 <sipa> and again, i don't see how that would in any way invalidate the use of floating point for feerate calculations
4792019-07-15T18:29:03 *** jarthur has quit IRC
4802019-07-15T18:29:19 <Raystonn> For a code path that has never been executed, and won't for at least 120 years.
4812019-07-15T18:29:48 <sipa> it is executed every block
4822019-07-15T18:30:10 <sipa> so please, if you want to contribute in a useful, focus on other issues
4832019-07-15T18:30:37 <sipa> not long-in-the-future hypotheticals that you still haven't clearly motivated would invalidate the current code
4842019-07-15T18:30:46 <Raystonn> I mean the code path that would be added to support sub-satoshi block rewards... we wouldn't get there for another 120 years.
4852019-07-15T18:30:51 <achow101> Raystonn: please keep in mind that any change you make must be reviewed by others and they must all approve it before a change is merged. It is highly unlikely that such a change will pass review, so I would recommend that you don't waste effort into trying
4862019-07-15T18:31:00 <Raystonn> Anything added there now would never see a fork.
4872019-07-15T18:31:21 <sipa> Raystonn: sorry, hardfork discussions are offtopic here (you can bring that up on the mailinglist if you want)
4882019-07-15T18:32:36 *** jonatack has joined #bitcoin-core-dev
4892019-07-15T18:32:40 <achow101> Raystonn: if we wouldn't gt there for another 120 years, then do it 120 years in the future when it becomes a problem
4902019-07-15T18:32:41 <Raystonn> I will drop the discussion on sub-satoshi block rewards.
4912019-07-15T18:33:09 <Raystonn> 120 years from now it would result in a fork as people are already running the code and getting no reward.
4922019-07-15T18:33:16 <Raystonn> Proper planning prevents...
4932019-07-15T18:35:36 *** hebasto has joined #bitcoin-core-dev
4942019-07-15T18:36:24 *** rutyiraw has joined #bitcoin-core-dev
4952019-07-15T18:37:27 *** scoop has quit IRC
4962019-07-15T18:37:54 *** scoop has joined #bitcoin-core-dev
4972019-07-15T18:43:34 *** spinza has quit IRC
4982019-07-15T18:45:27 *** scoop has quit IRC
4992019-07-15T18:50:56 *** promag_ has joined #bitcoin-core-dev
5002019-07-15T18:50:56 *** promag has quit IRC
5012019-07-15T18:51:23 *** mnarix has joined #bitcoin-core-dev
5022019-07-15T18:51:46 *** rutyiraw has quit IRC
5032019-07-15T18:53:50 *** spinza has joined #bitcoin-core-dev
5042019-07-15T18:57:03 *** MoonJaCk- has quit IRC
5052019-07-15T19:04:38 *** jarthur has joined #bitcoin-core-dev
5062019-07-15T19:05:51 *** promag_ has quit IRC
5072019-07-15T19:06:04 *** promag has joined #bitcoin-core-dev
5082019-07-15T19:18:19 *** scoop has joined #bitcoin-core-dev
5092019-07-15T19:22:37 *** scoop has quit IRC
5102019-07-15T19:25:41 *** bitcoin-git has joined #bitcoin-core-dev
5112019-07-15T19:25:42 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0822b44d8a68...6d37ed888e34
5122019-07-15T19:25:43 <bitcoin-git> bitcoin/master c7f6ce7 Carl Dong: docs: Improve netbase comments
5132019-07-15T19:25:44 <bitcoin-git> bitcoin/master 6d37ed8 Wladimir J. van der Laan: Merge #15824: docs: Improve netbase comments
5142019-07-15T19:25:46 *** bitcoin-git has left #bitcoin-core-dev
5152019-07-15T19:26:20 *** bitcoin-git has joined #bitcoin-core-dev
5162019-07-15T19:26:20 <bitcoin-git> [bitcoin] laanwj merged pull request #15824: docs: Improve netbase comments (master...2019-04-netbase-comments) https://github.com/bitcoin/bitcoin/pull/15824
5172019-07-15T19:26:21 *** bitcoin-git has left #bitcoin-core-dev
5182019-07-15T19:30:18 *** scoop has joined #bitcoin-core-dev
5192019-07-15T19:32:40 *** scoop has quit IRC
5202019-07-15T19:34:06 *** scoop has joined #bitcoin-core-dev
5212019-07-15T19:37:13 *** bitcoin-git has joined #bitcoin-core-dev
5222019-07-15T19:37:13 <bitcoin-git> [bitcoin] achow101 opened pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394
5232019-07-15T19:37:26 *** bitcoin-git has left #bitcoin-core-dev
5242019-07-15T19:38:22 *** owowo has quit IRC
5252019-07-15T19:38:29 *** abacus has quit IRC
5262019-07-15T19:40:50 *** shesek has quit IRC
5272019-07-15T19:44:19 *** owowo has joined #bitcoin-core-dev
5282019-07-15T19:47:49 *** queip has quit IRC
5292019-07-15T19:49:33 *** sipa has quit IRC
5302019-07-15T19:49:47 *** sipa has joined #bitcoin-core-dev
5312019-07-15T19:51:30 *** jb55 has quit IRC
5322019-07-15T19:52:01 *** jb55 has joined #bitcoin-core-dev
5332019-07-15T19:52:08 <stevenroose> Is there a flag for the min tx fee to include in blocks? Equivalent to minrelaytxfee?
5342019-07-15T19:52:51 <stevenroose> -blockmintxfee?
5352019-07-15T19:53:07 <luke-jr> right
5362019-07-15T19:53:34 *** spinza has quit IRC
5372019-07-15T19:54:53 *** queip has joined #bitcoin-core-dev
5382019-07-15T19:57:37 *** jarthur has quit IRC
5392019-07-15T19:58:45 *** mnarix has quit IRC
5402019-07-15T19:58:54 *** abacus has joined #bitcoin-core-dev
5412019-07-15T19:59:01 *** mnarix has joined #bitcoin-core-dev
5422019-07-15T20:00:21 <elichai2> achow101: Hey, any insight of the reason that `createpsbt` need to support 2 different formatting for the outputs? (one as an array another as a dictionary)
5432019-07-15T20:01:11 <achow101> elichai2: createrawtransaction allows both (api changed at some point, but old style kept for backwards compatibility), and the same construction function is used in both so createpsbt takes both
5442019-07-15T20:01:25 *** spinza has joined #bitcoin-core-dev
5452019-07-15T20:03:10 <elichai2> :/ makes it harder to add new stuff there, but i'll figure it out, thanks!
5462019-07-15T20:03:17 *** abacus has quit IRC
5472019-07-15T20:03:32 *** gelmutshmidt has quit IRC
5482019-07-15T20:07:40 <sipa> elichai2: why would you need to touch that rpc?
5492019-07-15T20:08:10 <elichai2> sipa: testing how would taproot look when combined into psbt
5502019-07-15T20:08:42 <sipa> you shouldn't need to touch any of those rpcs
5512019-07-15T20:08:56 <sipa> only the signing/psbt logic
5522019-07-15T20:09:33 <sipa> and descriptors
5532019-07-15T20:11:33 <elichai2> sipa: you're right. but if I go the regular way I need to add: 1. new descriptors. 2. classes and support for WitnessV2 bech32 addresses. 3. Classes for taproot in the wallet. serialization+deserialization of taproot and witness v2 addresses.
5542019-07-15T20:11:44 <elichai2> this is a lot of logic that require more careful handeling
5552019-07-15T20:12:54 <elichai2> and way more work. I'm trying to concentrate around PSBT for now. so i'm using `createpsbt` as a "hack" because that's the only psbt RPC command that doesn't relay on the wallet. (I'll probably move that logic to a seperate "createrawpsbt" or a `bitcoin-psbt` bin)
5562019-07-15T20:13:27 *** abacus has joined #bitcoin-core-dev
5572019-07-15T20:13:33 <sipa> for experimentation purposes that's fine of course
5582019-07-15T20:13:59 <sipa> but i don't think we'll add any taproot support to the wallet except "doing it right"
5592019-07-15T20:14:19 <elichai2> yeah I get the separation of concern for the psbt RPC methods
5602019-07-15T20:15:06 <sipa> no, i mean: nothing in those RPC arguments should change for taproot
5612019-07-15T20:15:07 <elichai2> sipa: does "doing it right" require full taproot support in the wallet? or can it be just psbt support via a raw psbt creation method that doesn't require a wallet?
5622019-07-15T20:15:26 <sipa> elichai2: i don't see how those two options are different :)
5632019-07-15T20:15:52 <achow101> elichai2: it would mean full support in the wallet with walletprocesspsbt handling all of the updating in the background. i.e. the user never provides the taproot info in an rpc
5642019-07-15T20:15:57 <sipa> if we have taproot support in descriptors and psbt, we'll automatically have it in tbe wallet
5652019-07-15T20:16:04 <achow101> just like right now the user never provides keys, utxos, etc. in the rpc
5662019-07-15T20:16:46 <elichai2> achow101: yes. which makes it harder to use if for example this isn't a transaction that you have in your wallet. i.e. there's no equivilant to `createrawtransaction`
5672019-07-15T20:17:02 <sipa> there is createpsbt?
5682019-07-15T20:17:15 <achow101> but that's a problem with updating any psbt right now
5692019-07-15T20:17:24 <elichai2> achow101: right
5702019-07-15T20:17:50 <elichai2> solving that problem will make adding taproot to psbt easier by not needing to add it to the wallet first
5712019-07-15T20:17:58 *** waxwing has quit IRC
5722019-07-15T20:18:05 <sipa> what does "adding it to the wallet" mean?
5732019-07-15T20:18:27 <elichai2> elichai2 sipa: you're right. but if I go the regular way I need to add: 1. new descriptors. 2. classes and support for WitnessV2 bech32 addresses. 3. Classes for taproot in the wallet. serialization+deserialization of taproot and witness v2 addresses.
5742019-07-15T20:18:31 <sipa> and we have psbt support for the full stack of operations outside of the wallet
5752019-07-15T20:18:47 <sipa> taproot can be implemented tested without ever touching the wallet code at all
5762019-07-15T20:18:52 *** obsrver has quit IRC
5772019-07-15T20:19:10 <achow101> *assuming descriptor wallets
5782019-07-15T20:19:12 <sipa> maybe there are some minor changes at some point past descriptor wallets to change the default to taproot addresses or something
5792019-07-15T20:19:19 <elichai2> sipa: what achow101 said
5802019-07-15T20:19:26 <sipa> elichai2: well, not even
5812019-07-15T20:19:57 <sipa> ah, right, we don't have the equivalent of walletprocesspsbt using descriptors yet
5822019-07-15T20:20:02 *** waxwing has joined #bitcoin-core-dev
5832019-07-15T20:20:05 <sipa> maybe we need that first :)
5842019-07-15T20:20:25 <sipa> then all we need is adding taproot to psbt/descriptors, and the full stack of operations would be supported outside of the wallet
5852019-07-15T20:20:42 <sipa> musig is harder though, as it requires state on the signer device
5862019-07-15T20:21:19 <elichai2> as far as I could see, right now if you'll pass a bech32 with segwit v2 it won't know how to parse it. it won't know that the witness program contains a public key. and it doesn't have any structure to handle a tree with multiple scripts
5872019-07-15T20:21:28 <sipa> yes it does
5882019-07-15T20:21:38 <sipa> (the first thing)
5892019-07-15T20:22:22 <sipa> i don't think we need a whole tree structure even
5902019-07-15T20:22:33 <stevenroose> Is there a way to "reset" the Core wallet? I'm using regtest using a client and in between tests, I'd like to sweep the wallet from all imported addresses and transactions.
5912019-07-15T20:22:53 <sipa> elichai2: just a psbt record of the form "this pubkey is derived from this internal pubkey, and this merkle branch, to this script and leaf version"
5922019-07-15T20:23:12 <stevenroose> I tried to unload the active wallet and "createwallet" a new one, but then it expects me to use the /wallet/<walletname> endpoint, which the client we're using doesn't support yet.
5932019-07-15T20:23:28 <elichai2> sipa: for a wallet support we need the whole tree structure, for psbt we don't
5942019-07-15T20:23:39 <sipa> elichai2: the tree would be in the descriptor
5952019-07-15T20:23:44 <sipa> nowhere else
5962019-07-15T20:25:44 <sipa> the 32-byte x coordinate idea (which we may update taproot with) may affect how that psbt record is structured too
5972019-07-15T20:26:07 <elichai2> sipa: correct me if I'm right, but trying to give it bech32 with witnessV1 will make it use `WitnessUnknown`, right? so we need some struct like `WitnessV1PubKey`
5982019-07-15T20:26:16 <sipa> yeah
5992019-07-15T20:26:20 <sipa> that's easy :)
6002019-07-15T20:27:01 <elichai2> sipa: yeah, that's a small change that could be easily changed too :)
6012019-07-15T20:27:05 <sipa> but it's not like we need new parsing code; bech32 parsing is alreasdy generic
6022019-07-15T20:27:50 *** emilengler has quit IRC
6032019-07-15T20:28:57 <sipa> elichai2: i suspect you're overestimating how much work it is to adapt all the structures with taproot
6042019-07-15T20:28:58 <sipa> it's nontrivial of course
6052019-07-15T20:29:16 <sipa> but i think hacking in via additional RPC arguments in various places won't be all that much simpler
6062019-07-15T20:29:28 <elichai2> i'm just trying to figure out if I could make a PoC without while minimizing the areas of the code I'm touching, because I don't know most of the code yet
6072019-07-15T20:29:33 <sipa> though it will touch a lot more different parts
6082019-07-15T20:29:45 <elichai2> because if i'll start editing code all over i'll probably mess things up even more lol
6092019-07-15T20:30:29 <elichai2> I understand that my PoC won't be close to optimal. and that's why I want it for now to be isolated into an RPC, and not doing all of the wallet support
6102019-07-15T20:30:44 <sipa> so why do it in bitcoin core at all then?
6112019-07-15T20:32:33 <elichai2> because I still think that manual psbt without descriptors is still useful? altough you're right that I could've done it in rust-bitcoin and it would probabaly been easier and more native to the code but in the end I do want to get to know bitcoin core's code better so I will be able to make optimal solutions to bitcoin in the future :)
6122019-07-15T20:33:16 <sipa> well if you want to learn bitcoin core better (which i very much encourage you to!), i think it's better to focus on one piece at a time, but actually integrate it
6132019-07-15T20:34:03 <sipa> for example, an RPC that takes a descriptor and a bunch of private keys, and signs with them, would be pretty generally useful
6142019-07-15T20:34:04 *** pinheadmz has quit IRC
6152019-07-15T20:35:48 <sipa> and for the extensions to psbt... i think it's generally too early
6162019-07-15T20:37:05 <elichai2> sipa: my hope is that if people start building things on top of taproot it will increase the chance of merging and activation sooner rather than later
6172019-07-15T20:38:04 <elichai2> so why not start conversations around descriptors extensions, psbt extenstions, tools that build complex taproot trees, early integration into other wallets, ideas on how to use it to make cheaper transactions, etc.
6182019-07-15T20:39:12 <elichai2> but I might be totally wrong
6192019-07-15T20:39:26 <sipa> i don't know, it feels like unnecessary pressure
6202019-07-15T20:39:32 <sipa> we first need to get agreement on a design
6212019-07-15T20:40:15 <elichai2> maybe this will make more people interested in reading into taproot BIP and giving feedback?
6222019-07-15T20:40:27 <sipa> i'm scared of people building things, and then discovering a major change in necessary, and then we end up with invested effort driving a "pfff please don't change the design anymore, we'll need to redo our code!", which is a really bad incentive
6232019-07-15T20:40:33 <elichai2> but I agree that if the design will really change then maybe this will be a big waste of time
6242019-07-15T20:40:36 *** shesek has joined #bitcoin-core-dev
6252019-07-15T20:41:00 <sipa> at a high level, i think all of these things are easy... there is a lot of engineering work to go into making it actually work
6262019-07-15T20:41:24 <sipa> but once taproot is finalized, i think the way to actually add it to psbt for example will be pretty straightforward
6272019-07-15T20:41:26 <elichai2> sipa: now I understand your motivation for discouraging a lot of the things I said that are related to taproot :) thanks :)
6282019-07-15T20:42:08 <elichai2> sipa: how much time it took between segwit activation and full support in core's wallet? I might really be off here but for me it felt a lot
6292019-07-15T20:42:22 <sipa> elichai2: yeah, a lot, and i think that's perfectly fine :)
6302019-07-15T20:42:33 <sipa> but i suspect with psbt and descriptors it will actually be a lot easier
6312019-07-15T20:43:03 <elichai2> don't you think that bitcoin core wallet should be like a reference for other wallets? because in that case other wallets got it faster :/
6322019-07-15T20:43:19 <sipa> i don't think so
6332019-07-15T20:43:28 <sipa> we need reference code in the form of signing logic etc
6342019-07-15T20:43:43 <sipa> and test vectors and examples
6352019-07-15T20:44:00 <sipa> but the variety of things that can be done with taproot is so large... there really isn't a way to be reference for everything
6362019-07-15T20:44:52 <sipa> actually, it was only from august 2017 to feb 2018
6372019-07-15T20:45:12 <elichai2> as far as I could tell in the code psbt is basically a big wrapper(not trying to underestimate the power of it) around the already existing serializations of the classes/structs
6382019-07-15T20:45:22 <sipa> yup
6392019-07-15T20:45:42 <sipa> so what will be needed in terms of data structures is a "taproot derivation" record in signing providers
6402019-07-15T20:45:50 <sipa> and descriptors that can fill that record
6412019-07-15T20:45:57 <sipa> and a way for that record to be serialized in psbt
6422019-07-15T20:46:03 <stevenroose> (nvm my question, btw :))
6432019-07-15T20:46:08 <sipa> and signing logic to use it
6442019-07-15T20:46:32 <elichai2> stevenroose: sorry for spamming it out ð
6452019-07-15T20:46:44 <sipa> stevenroose: delete the file :p
6462019-07-15T20:47:47 <elichai2> sipa: I might need to look into the descriptors code, but basically I wrote a draft BIP for the PSBT extensions and wanted some PoC, so I thought adding manual RPC method for PSBT will be the easiest place to add those extensions without understanding all the structures in the wallet
6472019-07-15T20:48:01 <elichai2> But you might be right and I need to look more into descriptors
6482019-07-15T20:48:23 <elichai2> And my way isn't "the right way" in relation to how the current code is designed
6492019-07-15T20:49:29 <sipa> i think for descriptors we'll probably want a fragment "tap(KEY,[[X,Y],[Z,[T,U]]])" kind of construction, where you give the root key and the leaves in some tree-encoding way
6502019-07-15T20:49:40 <sipa> where the X/Y/Z/T/U are subexpressions
6512019-07-15T20:49:52 <elichai2> and you need the script too
6522019-07-15T20:50:07 <sipa> X,Y,Z,Z,T,U are subexpressions that represent scripts
6532019-07-15T20:50:18 <sipa> they could be pk(), or multi(), ...
6542019-07-15T20:50:32 <sipa> or once we have miniscript probably a whole bunch more things (i hope to publish more about that soon)
6552019-07-15T20:50:54 *** darosior has joined #bitcoin-core-dev
6562019-07-15T20:51:00 <elichai2> oh that's for the whole tree. not just the spending path
6572019-07-15T20:51:09 <sipa> right
6582019-07-15T20:51:34 <elichai2> I'll more need to look into the descriptors code, see how complicated is it
6592019-07-15T20:51:53 <sipa> and that would then get converted into a "taproot key record" for the key path and for each leaf
6602019-07-15T20:51:59 <sipa> in signingprovider/psbt
6612019-07-15T20:52:08 *** darosior has quit IRC
6622019-07-15T20:52:18 *** darosior has joined #bitcoin-core-dev
6632019-07-15T20:52:43 *** ddustin has joined #bitcoin-core-dev
6642019-07-15T20:53:17 *** darosior has quit IRC
6652019-07-15T20:53:27 *** darosior has joined #bitcoin-core-dev
6662019-07-15T20:53:30 <sipa> https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp
6672019-07-15T20:54:11 <sipa> L149-170 is an interface for all the "key" expressions inside descriptors, with a number of implementations (pubkeys, descriptors, origin info)
6682019-07-15T20:54:21 <sipa> s/descriptors/bip32/
6692019-07-15T20:54:47 *** darosior has quit IRC
6702019-07-15T20:54:57 *** darosior has joined #bitcoin-core-dev
6712019-07-15T20:55:01 <sipa> line 335-497 is a generic implementation of a "script" node in a descriptor
6722019-07-15T20:55:24 <sipa> followed by implementations that add node specific logic (pk, pkh, sh, wpkh, wsh, multi, combi, addr, raw)
6732019-07-15T20:55:55 <sipa> and after that is parsing (string to descriptor) and inference (script to descriptor) code
6742019-07-15T20:56:03 *** darosior has quit IRC
6752019-07-15T20:56:13 *** darosior has joined #bitcoin-core-dev
6762019-07-15T20:56:43 *** queip has quit IRC
6772019-07-15T20:57:33 *** darosior has quit IRC
6782019-07-15T20:57:44 *** darosior has joined #bitcoin-core-dev
6792019-07-15T21:00:02 *** udsbotu has quit IRC
6802019-07-15T21:00:21 *** darosior has quit IRC
6812019-07-15T21:00:34 *** jarthur has joined #bitcoin-core-dev
6822019-07-15T21:00:37 *** darosior has joined #bitcoin-core-dev
6832019-07-15T21:00:38 *** darosior has quit IRC
6842019-07-15T21:00:58 *** darosior has joined #bitcoin-core-dev
6852019-07-15T21:02:08 *** queip has joined #bitcoin-core-dev
6862019-07-15T21:02:18 *** darosior has quit IRC
6872019-07-15T21:02:28 *** darosior has joined #bitcoin-core-dev
6882019-07-15T21:06:31 *** rknLA1 has joined #bitcoin-core-dev
6892019-07-15T21:07:36 <elichai2> sipa: Thanks. I'll start looking around
6902019-07-15T21:29:28 *** pinheadmz has joined #bitcoin-core-dev
6912019-07-15T21:30:02 *** cubancorona has quit IRC
6922019-07-15T21:36:43 <sipa> elichai2: cool
6932019-07-15T21:37:14 <elichai2> (really, Thank You!)
6942019-07-15T21:39:21 <sipa> really, yw :)
6952019-07-15T21:44:28 *** ddustin has quit IRC
6962019-07-15T21:45:10 *** ddustin has joined #bitcoin-core-dev
6972019-07-15T21:54:22 *** Guyver2 has quit IRC
6982019-07-15T21:58:29 *** luc___ has quit IRC
6992019-07-15T22:02:56 <jnewbery> sipa: you've mentioned this concern a couple of times:
7002019-07-15T22:03:01 <jnewbery> > i'm scared of people building things, and then discovering a major change in necessary, and then we end up with invested effort driving a "pfff please don't change the design anymore, we'll need to redo our code!", which is a really bad incentive
7012019-07-15T22:03:09 <jnewbery> I think there are a good reasons to start building PoC tools around the schnorr/taproot proposal now.
7022019-07-15T22:03:21 <jnewbery> We'll get much better feedback on the design if people are actually writing code to use schnorr/taproot, rather than just trying to analyse it from a theoretical perspective.
7032019-07-15T22:03:39 <jnewbery> And if those tools are made in a flexible way such that they can be adapted if there are minor design changes, then I don't think it's a waste of engineering time.
7042019-07-15T22:03:52 <jnewbery> I can't think of what kind of major change to the proposal would cause the effort to be wasted.
7052019-07-15T22:04:56 <sipa> jnewbery: of course
7062019-07-15T22:05:10 <sipa> i don't mind PoC tools
7072019-07-15T22:07:31 <sipa> but i also don't think there is any rush
7082019-07-15T22:08:00 <sipa> and if your end goal is integrating things into bitcoin core, i suspect getting familiar with the code is probably the best way to spend time now
7092019-07-15T22:10:50 <jnewbery> I don't think there's a rush, but I'd prefer for these tools to be built now so we can get feedback on the proposal. We're now at the stage that we're gathering feedback on the proposal, so it seems like a good use of time/energy to try to encourage that feedback.
7102019-07-15T22:11:34 <jnewbery> and yes, getting familiar with the code is important, but I don't think those things are mutually exclusive in any way
7112019-07-15T22:12:28 <sipa> i don't disagree
7122019-07-15T22:15:15 <sipa> but do you think hacking in preliminary taproot code in RPCs where it shouldn't be needed is useful as a PoC/
7132019-07-15T22:16:07 <sipa> it's not useful as reference code, and is unlikely to give a good idea of the complexity of real world implementations
7142019-07-15T22:16:52 <sipa> if a PoC is your goal, i suspect there are better codebases to try implementing things in that core's
7152019-07-15T22:17:18 <sipa> and if working towards an eventual production implementation in core, time seems better spent on the actual code rather than bypassing it
7162019-07-15T22:17:52 <sipa> *than
7172019-07-15T22:25:31 *** AaronvanW has joined #bitcoin-core-dev
7182019-07-15T22:29:40 *** michaelsdunn1 has quit IRC
7192019-07-15T22:54:08 *** queip has quit IRC
7202019-07-15T22:55:43 *** infernix has quit IRC
7212019-07-15T22:58:26 *** queip has joined #bitcoin-core-dev
7222019-07-15T22:58:27 *** ddustin has quit IRC
7232019-07-15T22:58:47 *** ddustin has joined #bitcoin-core-dev
7242019-07-15T23:03:28 <jnewbery> > do you think hacking in preliminary taproot code in RPCs where it shouldn't be needed is useful as a PoC?
7252019-07-15T23:04:11 *** goatpig has quit IRC
7262019-07-15T23:04:17 <jnewbery> Possibly not
7272019-07-15T23:04:39 *** jonatack has quit IRC
7282019-07-15T23:12:21 *** scoop has quit IRC
7292019-07-15T23:15:13 *** queip has quit IRC
7302019-07-15T23:20:54 *** queip has joined #bitcoin-core-dev
7312019-07-15T23:21:33 *** hebasto has quit IRC
7322019-07-15T23:37:07 *** infernix has joined #bitcoin-core-dev
7332019-07-15T23:40:27 *** ddustin has quit IRC
7342019-07-15T23:41:21 *** ddustin has joined #bitcoin-core-dev
7352019-07-15T23:42:08 *** ddustin has joined #bitcoin-core-dev
7362019-07-15T23:42:17 *** instagibbs_ has joined #bitcoin-core-dev
7372019-07-15T23:42:37 *** ddustin has quit IRC
7382019-07-15T23:43:15 *** ddustin has joined #bitcoin-core-dev
7392019-07-15T23:53:26 *** scoop has joined #bitcoin-core-dev
7402019-07-15T23:53:35 *** scoop has quit IRC
7412019-07-15T23:57:19 *** goatpig has joined #bitcoin-core-dev
7422019-07-15T23:57:54 *** AaronvanW has quit IRC