12019-07-19T00:00:02 *** nirik-fre has quit IRC
22019-07-19T00:04:21 *** ButterflyOfFire has joined #bitcoin-core-dev
32019-07-19T00:04:42 *** luc__ has joined #bitcoin-core-dev
42019-07-19T00:07:43 *** scoop has quit IRC
52019-07-19T00:09:28 *** luc__ has quit IRC
62019-07-19T00:16:28 *** gribble has joined #bitcoin-core-dev
72019-07-19T00:25:29 *** jarthur has quit IRC
82019-07-19T00:25:37 *** Krellan has joined #bitcoin-core-dev
92019-07-19T00:28:42 *** Scrat has joined #bitcoin-core-dev
102019-07-19T00:30:12 *** Krellan has quit IRC
112019-07-19T00:36:10 *** Scrat has quit IRC
122019-07-19T00:39:27 *** ertewe has joined #bitcoin-core-dev
132019-07-19T00:42:58 *** werrwer has quit IRC
142019-07-19T00:44:35 *** ertewe has quit IRC
152019-07-19T00:44:46 *** bitcoin-git has joined #bitcoin-core-dev
162019-07-19T00:44:46 <bitcoin-git> [bitcoin] zenosage opened pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422
172019-07-19T00:44:59 *** bitcoin-git has left #bitcoin-core-dev
182019-07-19T00:45:38 *** DeanWeen has joined #bitcoin-core-dev
192019-07-19T00:54:38 *** jeremyrubin has quit IRC
202019-07-19T00:57:32 *** Honthe has quit IRC
212019-07-19T01:03:30 *** Krellan has joined #bitcoin-core-dev
222019-07-19T01:05:31 *** Honthe has joined #bitcoin-core-dev
232019-07-19T01:07:24 *** bitcoin-git has joined #bitcoin-core-dev
242019-07-19T01:07:24 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5abb59a9a66...89d7229c9c18
252019-07-19T01:07:25 <bitcoin-git> bitcoin/master 024ecd7 Jonas Schnelli: QA: Fix race condition in wallet_encryption test
262019-07-19T01:07:25 <bitcoin-git> bitcoin/master 89d7229 fanquake: Merge #16420: QA: Fix race condition in wallet_encryption test
272019-07-19T01:07:27 *** bitcoin-git has left #bitcoin-core-dev
282019-07-19T01:08:29 *** bitcoin-git has joined #bitcoin-core-dev
292019-07-19T01:08:29 <bitcoin-git> [bitcoin] fanquake merged pull request #16420: QA: Fix race condition in wallet_encryption test (master...2019/07/wallet_enc_test_fix) https://github.com/bitcoin/bitcoin/pull/16420
302019-07-19T01:08:31 *** bitcoin-git has left #bitcoin-core-dev
312019-07-19T01:13:39 *** nijak has quit IRC
322019-07-19T01:13:41 *** nijak_ has joined #bitcoin-core-dev
332019-07-19T01:13:58 <aj> yay!
342019-07-19T01:17:42 *** nijak has joined #bitcoin-core-dev
352019-07-19T01:19:19 *** nijak_ has quit IRC
362019-07-19T01:21:57 *** scoop has joined #bitcoin-core-dev
372019-07-19T01:22:11 *** DeanWeen has quit IRC
382019-07-19T01:22:30 *** DeanWeen has joined #bitcoin-core-dev
392019-07-19T01:37:56 *** Krellan has quit IRC
402019-07-19T01:47:28 *** kljasdfvv has quit IRC
412019-07-19T01:48:08 *** kljasdfvv has joined #bitcoin-core-dev
422019-07-19T02:09:32 *** DeanWeen has quit IRC
432019-07-19T02:11:41 *** spinza has quit IRC
442019-07-19T02:11:45 *** Krellan has joined #bitcoin-core-dev
452019-07-19T02:16:46 *** Krellan has quit IRC
462019-07-19T02:25:38 *** queip has quit IRC
472019-07-19T02:31:28 *** queip has joined #bitcoin-core-dev
482019-07-19T02:34:27 *** spinza has joined #bitcoin-core-dev
492019-07-19T02:45:51 *** kristapsk_ has joined #bitcoin-core-dev
502019-07-19T02:46:28 *** Krellan has joined #bitcoin-core-dev
512019-07-19T02:47:04 *** kristapsk has quit IRC
522019-07-19T02:47:31 *** ghost43 has quit IRC
532019-07-19T02:48:21 *** ghost43 has joined #bitcoin-core-dev
542019-07-19T03:00:01 *** ButterflyOfFire has quit IRC
552019-07-19T03:03:57 *** Kabaka has joined #bitcoin-core-dev
562019-07-19T03:09:45 *** d_t has joined #bitcoin-core-dev
572019-07-19T03:11:18 *** davterra has joined #bitcoin-core-dev
582019-07-19T03:20:14 *** Krellan has quit IRC
592019-07-19T03:21:02 *** schnerch_ has joined #bitcoin-core-dev
602019-07-19T03:24:32 *** schnerchi has quit IRC
612019-07-19T03:25:35 *** captjakk has joined #bitcoin-core-dev
622019-07-19T03:57:09 *** captjakk has quit IRC
632019-07-19T04:04:41 *** d_t has quit IRC
642019-07-19T04:06:39 *** d_t has joined #bitcoin-core-dev
652019-07-19T04:11:50 *** hebasto has joined #bitcoin-core-dev
662019-07-19T04:13:16 *** hebasto has quit IRC
672019-07-19T04:30:14 *** d_t has quit IRC
682019-07-19T04:31:17 *** jtimon has quit IRC
692019-07-19T04:31:54 *** Victor_sueca has joined #bitcoin-core-dev
702019-07-19T04:34:37 *** Victorsueca has quit IRC
712019-07-19T04:36:39 *** Krellan has joined #bitcoin-core-dev
722019-07-19T05:13:45 *** Taborlin has joined #bitcoin-core-dev
732019-07-19T05:16:03 *** Krellan has quit IRC
742019-07-19T05:17:31 *** Krellan has joined #bitcoin-core-dev
752019-07-19T05:19:41 *** Taborlin has quit IRC
762019-07-19T05:22:10 *** Krellan has quit IRC
772019-07-19T05:31:57 <meshcollider> achow101: There is a wallet meeting scheduled tomorrow
782019-07-19T05:32:14 <meshcollider> But i will be on a bus so I won't be able to host it
792019-07-19T05:32:17 *** Krellan has joined #bitcoin-core-dev
802019-07-19T05:32:27 <meshcollider> Someone else want to volunteer?
812019-07-19T05:33:00 *** lowentropy has quit IRC
822019-07-19T05:38:10 *** d_t has joined #bitcoin-core-dev
832019-07-19T05:46:50 *** Krellan_ has joined #bitcoin-core-dev
842019-07-19T05:47:00 *** scoop_ has joined #bitcoin-core-dev
852019-07-19T05:47:32 *** cornfeedhobo has quit IRC
862019-07-19T05:47:32 *** shtirlic has quit IRC
872019-07-19T05:47:57 *** chainhead has quit IRC
882019-07-19T05:48:05 *** chainhead has joined #bitcoin-core-dev
892019-07-19T05:48:22 *** votesmith has quit IRC
902019-07-19T05:48:24 *** scoop has quit IRC
912019-07-19T05:48:53 *** shtirlic has joined #bitcoin-core-dev
922019-07-19T05:49:37 *** Krellan has quit IRC
932019-07-19T05:49:37 *** rabidus has quit IRC
942019-07-19T05:49:50 *** rabidus has joined #bitcoin-core-dev
952019-07-19T05:51:40 *** votesmith has joined #bitcoin-core-dev
962019-07-19T05:57:52 <kallewoof> Would it be horrible to remove the assume valid stuff from bitcoin core? It feels like signature validation is pretty fast these days.
972019-07-19T06:00:02 *** Kabaka has quit IRC
982019-07-19T06:07:05 *** cornfeedhobo has joined #bitcoin-core-dev
992019-07-19T06:07:25 *** luc__ has joined #bitcoin-core-dev
1002019-07-19T06:11:50 *** luc__ has quit IRC
1012019-07-19T06:18:24 *** seaLne1 has joined #bitcoin-core-dev
1022019-07-19T06:24:02 <mryandao> why not set the default to off instead?
1032019-07-19T06:25:16 <sipa> kallewoof: really?
1042019-07-19T06:26:36 <sipa> i think it's around a week of CPU time to verify all historical signatures
1052019-07-19T06:26:49 <sipa> on a modern x86 cpu
1062019-07-19T06:27:23 <sipa> if you have 32 cores that's perhaps acceptable
1072019-07-19T06:32:10 *** elichai2 has quit IRC
1082019-07-19T06:36:05 *** d_t has quit IRC
1092019-07-19T06:39:09 *** Krellan_ has quit IRC
1102019-07-19T06:39:42 <kallewoof> It's that big of a difference? I must have misheard numbers then.
1112019-07-19T06:55:47 <sipa> it's 50 microseconds or so per signature check
1122019-07-19T06:56:30 <sipa> assuming a billion sigcheck (rough guess) in the chain, that's 5 days of CPU time (divided by the number of threads to get real time)
1132019-07-19T06:57:49 <mryandao> is there a plot that tracks number of sigcheck ops to date?
1142019-07-19T06:57:54 <jonasschnelli> MarcoFalke: are you sure CCACHE_SIZE is the right directive: https://github.com/bitcoin/bitcoin/blob/master/.travis.yml#L49?
1152019-07-19T06:58:11 <jonasschnelli> maybe it's travis special
1162019-07-19T06:58:33 <jonasschnelli> But it looks like that the ccache env var would be CCACHE_MAXSIZE (instead of CCACHE_SIZE) https://ccache.dev/manual/3.4.html#_cache_size_management
1172019-07-19T07:00:35 *** jonatack has quit IRC
1182019-07-19T07:02:57 <fanquake> jonasschnelli: hard to tell. Looks like there are usages of either VAR in .travis.yml files on github. i.e https://github.com/search?l=yaml&q=CCACHE_MAXSIZE&type=Code
1192019-07-19T07:03:20 <jonasschnelli> maybe set both *duck*
1202019-07-19T07:04:37 <kallewoof> CCACHE_MAXSIZE is correct according to man ccache
1212019-07-19T07:07:57 *** queip has quit IRC
1222019-07-19T07:10:27 <kallewoof> Just me or is travis not creating new jobs when pushing to a PR branch..? (it creates local instances for my own repo but not for bitcoin).
1232019-07-19T07:13:41 *** queip has joined #bitcoin-core-dev
1242019-07-19T07:18:39 *** double_helix has quit IRC
1252019-07-19T07:20:39 *** jungly has joined #bitcoin-core-dev
1262019-07-19T07:29:27 *** pinheadmz has quit IRC
1272019-07-19T07:41:20 *** Krellan has joined #bitcoin-core-dev
1282019-07-19T07:49:15 *** EagleTM has joined #bitcoin-core-dev
1292019-07-19T08:00:18 *** jonatack has joined #bitcoin-core-dev
1302019-07-19T08:06:39 *** jonatack has quit IRC
1312019-07-19T08:14:44 *** Krellan has quit IRC
1322019-07-19T08:19:14 *** setpill has joined #bitcoin-core-dev
1332019-07-19T08:22:38 *** jonatack has joined #bitcoin-core-dev
1342019-07-19T08:26:05 *** AaronvanW has joined #bitcoin-core-dev
1352019-07-19T08:28:28 *** timothy has joined #bitcoin-core-dev
1362019-07-19T08:29:23 *** kljasdfvv has quit IRC
1372019-07-19T08:29:45 *** kljasdfvv has joined #bitcoin-core-dev
1382019-07-19T08:34:15 *** Zenton has joined #bitcoin-core-dev
1392019-07-19T08:40:13 *** scoop_ has quit IRC
1402019-07-19T08:42:42 *** EagleTM has quit IRC
1412019-07-19T08:46:02 *** jonatack has quit IRC
1422019-07-19T08:53:23 *** EagleTM has joined #bitcoin-core-dev
1432019-07-19T09:00:02 *** seaLne1 has quit IRC
1442019-07-19T09:00:02 *** jonatack has joined #bitcoin-core-dev
1452019-07-19T09:04:02 *** delinka has joined #bitcoin-core-dev
1462019-07-19T09:05:56 *** Logan63 has joined #bitcoin-core-dev
1472019-07-19T09:06:10 *** Madars_ has quit IRC
1482019-07-19T09:07:33 *** Skirmant has quit IRC
1492019-07-19T09:07:40 *** Madars_ has joined #bitcoin-core-dev
1502019-07-19T09:08:21 *** Logan63 has quit IRC
1512019-07-19T09:26:16 *** Krellan has joined #bitcoin-core-dev
1522019-07-19T09:34:30 *** bitcoin-git has joined #bitcoin-core-dev
1532019-07-19T09:34:30 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/89d7229c9c18...59ce537a4994
1542019-07-19T09:34:31 <bitcoin-git> bitcoin/master 5efcb77 Matt Corallo: Disable bloom filtering by default.
1552019-07-19T09:34:32 <bitcoin-git> bitcoin/master f27309f Matt Corallo: Move DEFAULT_PEERBLOOMFILTERS from validation.h to net_processing.h
1562019-07-19T09:34:33 <bitcoin-git> bitcoin/master bead32e Matt Corallo: Add release notes for DEFAULT_BLOOM change
1572019-07-19T09:34:34 *** bitcoin-git has left #bitcoin-core-dev
1582019-07-19T09:35:19 *** bitcoin-git has joined #bitcoin-core-dev
1592019-07-19T09:35:19 <bitcoin-git> [bitcoin] fanquake merged pull request #16152: Disable bloom filtering by default. (master...2019-06-fix-dos) https://github.com/bitcoin/bitcoin/pull/16152
1602019-07-19T09:35:22 *** bitcoin-git has left #bitcoin-core-dev
1612019-07-19T09:36:18 *** queip has quit IRC
1622019-07-19T09:41:24 *** queip has joined #bitcoin-core-dev
1632019-07-19T10:00:08 *** Krellan has quit IRC
1642019-07-19T10:04:44 *** Aaronvan_ has joined #bitcoin-core-dev
1652019-07-19T10:07:58 *** AaronvanW has quit IRC
1662019-07-19T10:19:46 *** queip has quit IRC
1672019-07-19T10:25:27 *** queip has joined #bitcoin-core-dev
1682019-07-19T10:41:51 *** jonatack has quit IRC
1692019-07-19T10:51:35 *** Aaronvan_ is now known as AaronvanW
1702019-07-19T11:03:44 *** Krellan has joined #bitcoin-core-dev
1712019-07-19T11:14:52 *** morcos has quit IRC
1722019-07-19T11:15:13 *** morcos has joined #bitcoin-core-dev
1732019-07-19T11:15:22 <jonasschnelli> Would someone mind if I add a webhook to bitcoin/bitcoin (a "readonly" webhook) to drive the CI i have built in the last weeks?
1742019-07-19T11:15:42 <jonasschnelli> It's non-invasive (as said, readonly)
1752019-07-19T11:15:52 <jonasschnelli> ^ wumpus, MarcoFalke, fanquake
1762019-07-19T11:16:09 <jonasschnelli> the CI is currently under heave development: https://bitcoinbuilds.org/
1772019-07-19T11:16:28 <jonasschnelli> But I want to test it with some load and integrate building all PR pushes
1782019-07-19T11:26:29 <fanquake> jonasschnelli: Interesting. Is the source for the site going to live here: https://github.com/jonasschnelli/bitcoin-core-ci?
1792019-07-19T11:26:30 <fanquake> What hardware are you running the builds on atm?
1802019-07-19T11:26:57 <jonasschnelli> Yes. The source code will end up at that repo (as soon as its ready)
1812019-07-19T11:27:07 <jonasschnelli> Its running on a relatively powerful physical host
1822019-07-19T11:27:14 <jonasschnelli> It's based on KVM
1832019-07-19T11:27:23 <jonasschnelli> Full custom software though
1842019-07-19T11:27:25 <fanquake> The site looks pretty nice. At least looking at large logs is more responsive than Travis ð
1852019-07-19T11:27:39 <fanquake> I assume you'll be adding macOS and other builds later on?
1862019-07-19T11:27:41 <jonasschnelli> Yeah... travis logs are a nightmare.
1872019-07-19T11:28:00 <jonasschnelli> fanquake: Yes. All possible. Just caping to three platforms right now then later expand
1882019-07-19T11:28:56 <fanquake> Cool. I'm not opposed to a read-only hook if you want to stress / load test for a week or two. Probably worth bring up at a meeting after that.
1892019-07-19T11:29:14 <jonasschnelli> Yes. We can discuss that next thursday
1902019-07-19T11:32:44 *** jtimon has joined #bitcoin-core-dev
1912019-07-19T11:33:39 *** jtimon has quit IRC
1922019-07-19T11:36:49 *** Krellan has quit IRC
1932019-07-19T11:45:20 *** StopAndDecrypt has joined #bitcoin-core-dev
1942019-07-19T12:00:01 *** delinka has quit IRC
1952019-07-19T12:04:38 *** quijote has quit IRC
1962019-07-19T12:09:45 *** luc__ has joined #bitcoin-core-dev
1972019-07-19T12:12:31 *** Greedi has joined #bitcoin-core-dev
1982019-07-19T12:14:26 *** luc__ has quit IRC
1992019-07-19T12:17:56 *** d_t has joined #bitcoin-core-dev
2002019-07-19T12:25:56 *** goatpig has joined #bitcoin-core-dev
2012019-07-19T12:34:15 <kallewoof> Weird. Github claims "all checks passed" for #16411 but in reality, the travis check never actually executed, only the appveyor one. :/
2022019-07-19T12:34:18 <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
2032019-07-19T12:34:59 *** as1nc_ has quit IRC
2042019-07-19T12:35:19 *** as1nc_ has joined #bitcoin-core-dev
2052019-07-19T12:36:17 *** scoop has joined #bitcoin-core-dev
2062019-07-19T12:38:49 *** Krellan has joined #bitcoin-core-dev
2072019-07-19T12:40:42 <fanquake> Travis has a habit of doing weird things like that. Sometimes it'll show Travis failing when in fact all tests have passed.
2082019-07-19T12:46:28 *** d_t has quit IRC
2092019-07-19T12:48:58 *** reallll has joined #bitcoin-core-dev
2102019-07-19T12:52:38 *** belcher has quit IRC
2112019-07-19T13:13:06 *** Krellan has quit IRC
2122019-07-19T13:13:06 *** Cory has quit IRC
2132019-07-19T13:17:26 *** Guyver2 has joined #bitcoin-core-dev
2142019-07-19T13:23:30 *** jonatack has joined #bitcoin-core-dev
2152019-07-19T13:23:46 *** davterra has quit IRC
2162019-07-19T13:24:59 *** setpill has quit IRC
2172019-07-19T13:30:42 *** setpill has joined #bitcoin-core-dev
2182019-07-19T13:39:12 *** d_t has joined #bitcoin-core-dev
2192019-07-19T13:42:28 *** Zenton has quit IRC
2202019-07-19T13:42:51 *** Zenton has joined #bitcoin-core-dev
2212019-07-19T13:44:57 *** d_t has quit IRC
2222019-07-19T13:50:29 *** d_t has joined #bitcoin-core-dev
2232019-07-19T13:54:58 *** d_t has quit IRC
2242019-07-19T13:56:57 *** etwert has joined #bitcoin-core-dev
2252019-07-19T14:08:52 *** pinheadmz has joined #bitcoin-core-dev
2262019-07-19T14:09:32 *** jnewbery has quit IRC
2272019-07-19T14:10:59 *** davterra has joined #bitcoin-core-dev
2282019-07-19T14:13:23 *** jnewbery has joined #bitcoin-core-dev
2292019-07-19T14:16:24 *** hexyul has quit IRC
2302019-07-19T14:16:55 *** davterra has quit IRC
2312019-07-19T14:17:24 *** davterra has joined #bitcoin-core-dev
2322019-07-19T14:20:57 *** bitcoin-git has joined #bitcoin-core-dev
2332019-07-19T14:20:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59ce537a4994...c7b7cf299a9e
2342019-07-19T14:20:58 <bitcoin-git> bitcoin/master 5c3c24c zenosage: test: remove redundant setup in addrman_tests
2352019-07-19T14:20:58 <bitcoin-git> bitcoin/master c7b7cf2 MarcoFalke: Merge #16422: test: remove redundant setup in addrman_tests
2362019-07-19T14:21:11 *** bitcoin-git has left #bitcoin-core-dev
2372019-07-19T14:21:35 *** pinheadmz has quit IRC
2382019-07-19T14:21:55 *** hexyul has joined #bitcoin-core-dev
2392019-07-19T14:22:02 *** bitcoin-git has joined #bitcoin-core-dev
2402019-07-19T14:22:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16422: test: remove redundant setup in addrman_tests (master...addrman_tests) https://github.com/bitcoin/bitcoin/pull/16422
2412019-07-19T14:22:03 *** jb55 has joined #bitcoin-core-dev
2422019-07-19T14:22:03 *** bitcoin-git has left #bitcoin-core-dev
2432019-07-19T14:22:41 *** jarthur has joined #bitcoin-core-dev
2442019-07-19T14:25:38 *** Krellan has joined #bitcoin-core-dev
2452019-07-19T14:29:25 *** davterra has quit IRC
2462019-07-19T14:35:16 *** setpill has quit IRC
2472019-07-19T14:39:56 *** lei15 has joined #bitcoin-core-dev
2482019-07-19T14:42:33 *** pinheadmz has joined #bitcoin-core-dev
2492019-07-19T14:44:08 *** davterra has joined #bitcoin-core-dev
2502019-07-19T14:45:00 *** harrigan has joined #bitcoin-core-dev
2512019-07-19T14:53:14 *** rockhouse has quit IRC
2522019-07-19T14:53:15 *** victorSN has quit IRC
2532019-07-19T14:58:12 *** pinheadmz_ has joined #bitcoin-core-dev
2542019-07-19T14:58:46 *** justanotheruser has quit IRC
2552019-07-19T14:59:24 *** rockhouse has joined #bitcoin-core-dev
2562019-07-19T14:59:42 *** victorSN has joined #bitcoin-core-dev
2572019-07-19T14:59:52 *** Krellan has quit IRC
2582019-07-19T15:00:01 *** Greedi has quit IRC
2592019-07-19T15:00:52 *** pinheadmz has quit IRC
2602019-07-19T15:00:52 *** pinheadmz_ is now known as pinheadmz
2612019-07-19T15:03:47 *** rockhouse has quit IRC
2622019-07-19T15:04:28 *** victorSN has quit IRC
2632019-07-19T15:05:31 *** elichai2 has joined #bitcoin-core-dev
2642019-07-19T15:08:20 *** hebasto has joined #bitcoin-core-dev
2652019-07-19T15:09:01 *** rockhouse has joined #bitcoin-core-dev
2662019-07-19T15:09:15 *** victorSN has joined #bitcoin-core-dev
2672019-07-19T15:11:42 *** Victor_sueca has quit IRC
2682019-07-19T15:12:57 *** MM87 has joined #bitcoin-core-dev
2692019-07-19T15:13:56 *** Leo_Verto1 has joined #bitcoin-core-dev
2702019-07-19T15:14:31 *** emilengler has joined #bitcoin-core-dev
2712019-07-19T15:14:50 *** davterra has quit IRC
2722019-07-19T15:16:58 *** michaelsdunn1 has joined #bitcoin-core-dev
2732019-07-19T15:20:52 *** justanotheruser has joined #bitcoin-core-dev
2742019-07-19T15:20:54 *** bitcoin-git has joined #bitcoin-core-dev
2752019-07-19T15:20:54 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7b7cf299a9e...f4b1fe7165c8
2762019-07-19T15:20:55 <bitcoin-git> bitcoin/master a52818c tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
2772019-07-19T15:20:56 <bitcoin-git> bitcoin/master f4b1fe7 Wladimir J. van der Laan: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN e...
2782019-07-19T15:20:57 *** bitcoin-git has left #bitcoin-core-dev
2792019-07-19T15:21:54 *** bitcoin-git has joined #bitcoin-core-dev
2802019-07-19T15:21:54 <bitcoin-git> [bitcoin] laanwj merged pull request #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (master...bitcoin-poll) https://github.com/bitcoin/bitcoin/pull/16412
2812019-07-19T15:21:57 *** bitcoin-git has left #bitcoin-core-dev
2822019-07-19T15:27:40 *** kljasdfvv has quit IRC
2832019-07-19T15:31:49 *** lei15 has quit IRC
2842019-07-19T15:36:01 *** Krellan has joined #bitcoin-core-dev
2852019-07-19T15:39:54 *** captjakk has joined #bitcoin-core-dev
2862019-07-19T15:40:27 *** Krellan has quit IRC
2872019-07-19T15:50:36 *** emilengler has quit IRC
2882019-07-19T15:55:53 *** Zenton has quit IRC
2892019-07-19T15:56:56 *** jarthur has quit IRC
2902019-07-19T16:00:03 *** bitcoin-git has joined #bitcoin-core-dev
2912019-07-19T16:00:04 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/3f76160087c0...063c8ce7a054
2922019-07-19T16:00:04 <bitcoin-git> bitcoin/0.18 063c8ce tecnovert: net: Make poll in InterruptibleRecv only filter for POLLIN events.
2932019-07-19T16:00:16 *** bitcoin-git has left #bitcoin-core-dev
2942019-07-19T16:00:28 *** Victorsueca has joined #bitcoin-core-dev
2952019-07-19T16:02:52 <MarcoFalke> 0.18.1 can go
2962019-07-19T16:06:39 *** Krellan has joined #bitcoin-core-dev
2972019-07-19T16:08:29 *** teardown has quit IRC
2982019-07-19T16:14:28 <wumpus> MarcoFalke: what about #16414?
2992019-07-19T16:14:30 <gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
3002019-07-19T16:15:22 <wumpus> (I think that is the last one)
3012019-07-19T16:16:20 <wumpus> going to do pre-rc1 translations update
3022019-07-19T16:18:49 *** davterra has joined #bitcoin-core-dev
3032019-07-19T16:29:22 *** etwert has quit IRC
3042019-07-19T16:32:32 *** DeanWeen has joined #bitcoin-core-dev
3052019-07-19T16:34:21 *** timothy has quit IRC
3062019-07-19T16:43:19 *** spinza has quit IRC
3072019-07-19T16:44:34 *** Victorsueca has quit IRC
3082019-07-19T16:44:41 *** Victor_sueca has joined #bitcoin-core-dev
3092019-07-19T16:45:20 *** Victor_sueca has quit IRC
3102019-07-19T16:46:10 *** Victor_sueca has joined #bitcoin-core-dev
3112019-07-19T16:47:01 *** spinza has joined #bitcoin-core-dev
3122019-07-19T16:47:57 *** jnewbery has quit IRC
3132019-07-19T16:48:44 *** sdaftuar has quit IRC
3142019-07-19T16:50:28 *** Victor_sueca has quit IRC
3152019-07-19T16:51:44 *** jungly has quit IRC
3162019-07-19T17:04:40 *** hebasto has quit IRC
3172019-07-19T17:05:01 *** hebasto has joined #bitcoin-core-dev
3182019-07-19T17:06:42 *** sdaftuar has joined #bitcoin-core-dev
3192019-07-19T17:10:55 *** jnewbery has joined #bitcoin-core-dev
3202019-07-19T17:23:16 *** DeanWeen has quit IRC
3212019-07-19T17:27:24 *** harrigan has quit IRC
3222019-07-19T17:31:23 *** etwert has joined #bitcoin-core-dev
3232019-07-19T17:33:58 *** Victor_sueca has joined #bitcoin-core-dev
3242019-07-19T17:40:54 *** jarthur has joined #bitcoin-core-dev
3252019-07-19T17:46:31 *** harrigan has joined #bitcoin-core-dev
3262019-07-19T17:51:49 *** bitcoin-git has joined #bitcoin-core-dev
3272019-07-19T17:51:51 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/063c8ce7a054...a6cba19831da
3282019-07-19T17:51:51 <bitcoin-git> bitcoin/0.18 641b2ff Wladimir J. van der Laan: qt: pre-rc1 translations update
3292019-07-19T17:51:52 <bitcoin-git> bitcoin/0.18 aa2d12a Wladimir J. van der Laan: build: Bump version to 0.18.1rc1
3302019-07-19T17:51:53 <bitcoin-git> bitcoin/0.18 a6cba19 Wladimir J. van der Laan: doc: Update manpages for rc1
3312019-07-19T17:51:55 *** bitcoin-git has left #bitcoin-core-dev
3322019-07-19T17:53:29 <BlueMatt> wumpus: plz2merge #15681
3332019-07-19T17:53:31 <gribble> https://github.com/bitcoin/bitcoin/issues/15681 | [mempool] Allow one extra single-ancestor transaction per package by TheBlueMatt · Pull Request #15681 · bitcoin/bitcoin · GitHub
3342019-07-19T17:53:47 <elichai2> sipa: kallewoof that's not right
3352019-07-19T17:53:51 <wumpus> looks like recent changes in master broke compatibility with c-lightning
3362019-07-19T17:53:55 <wumpus> BlueMatt: looking
3372019-07-19T17:54:18 <elichai2> I did it yesterday. did a full IBD with assumbalid=0 from scratch in ~6 hours
3382019-07-19T17:54:28 <elichai2> *assumevalid
3392019-07-19T17:54:52 <wumpus> user@medea:~ % ./launch-lightning.sh
3402019-07-19T17:54:54 <wumpus> bitcoin-cli getblockchaininfo: invalid response
3412019-07-19T17:54:57 <wumpus> not sure why yet
3422019-07-19T17:56:11 <elichai2> (fair point that I do have 8 cores and 16 threads, NVMe and a ~600MiB internet connection and I set dbcache=4096)
3432019-07-19T17:58:11 <achow101> Could someone help me figure out where the memory leak being reported here is: https://travis-ci.org/bitcoin/bitcoin/jobs/560780816 ?
3442019-07-19T17:59:03 <achow101> It seems like it's something happening in std::map but I don't know why it happens here
3452019-07-19T18:00:01 *** Leo_Verto1 has quit IRC
3462019-07-19T18:00:45 *** bitcoin-git has joined #bitcoin-core-dev
3472019-07-19T18:00:46 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b1fe7165c8...51a6e2c41929
3482019-07-19T18:00:46 <bitcoin-git> bitcoin/master 50cede3 Matt Corallo: [mempool] Allow one extra single-ancestor transaction per package
3492019-07-19T18:00:47 <bitcoin-git> bitcoin/master 51a6e2c Wladimir J. van der Laan: Merge #15681: [mempool] Allow one extra single-ancestor transaction per pa...
3502019-07-19T18:00:48 *** bitcoin-git has left #bitcoin-core-dev
3512019-07-19T18:00:56 <BlueMatt> woooo
3522019-07-19T18:01:25 *** bitcoin-git has joined #bitcoin-core-dev
3532019-07-19T18:01:26 <bitcoin-git> [bitcoin] laanwj merged pull request #15681: [mempool] Allow one extra single-ancestor transaction per package (master...2019-03-lightning-policy) https://github.com/bitcoin/bitcoin/pull/15681
3542019-07-19T18:01:27 *** bitcoin-git has left #bitcoin-core-dev
3552019-07-19T18:02:10 <sipa> elichai2: what kind of hardware?
3562019-07-19T18:02:28 <sipa> ah, just saw the later message
3572019-07-19T18:02:58 <sipa> elichai2: 16 * 6 hours = 4 days
3582019-07-19T18:03:03 <sipa> i don't think i'm far off
3592019-07-19T18:03:51 <elichai2> Most laptops these days have at least 4 threads. And I'm not even entirely sure what was the bottleneck because nothing maxed out
3602019-07-19T18:04:03 <elichai2> Probably the peers internet connection
3612019-07-19T18:04:17 <sipa> with 4 threads it would be a day...
3622019-07-19T18:04:22 *** izaki1 has joined #bitcoin-core-dev
3632019-07-19T18:04:59 <sipa> 6 hours is already pretty terrible on itself
3642019-07-19T18:05:24 <sipa> though admittedly there is little we can do about the time to download the chain (except assumeutxo like security model changes)
3652019-07-19T18:06:34 <sipa> most laptop cpus will also downclock when many cores are used at once, so it may not be fair to assume more threads linearly oncreases speed
3662019-07-19T18:12:28 *** luc__ has joined #bitcoin-core-dev
3672019-07-19T18:13:35 *** luc__ has quit IRC
3682019-07-19T18:17:33 <elichai2> one thing I saw is that there's no logic that chooses prefers peers by their bandwidth
3692019-07-19T18:18:07 *** scoop has quit IRC
3702019-07-19T18:18:11 <elichai2> so when I manually when to https://bitnodes.earn.com and looked for closer peers that share the same ISP and added then via `addnode` I got faster download
3712019-07-19T18:19:35 <elichai2> and if everyone had good cpus we could try and use compression algorithms before sending the blocks around to move some of the weight from the internet to the cpu
3722019-07-19T18:21:02 <sipa> elichai2: not explicitly, though there is the "stall detection" logic which tends to kick out the slowest peers from time to time in many cases
3732019-07-19T18:23:02 <sipa> elichai2: yeah, we have someone working on transaction compression (though primarily aimed at satellite links, where a large amount of CPU to gain some bandwidth is much more acceptable than on the general P2P network), still some of the results are likely useful for a P2P compression mechanism too
3742019-07-19T18:24:22 <elichai2> cool. I was actually impressed by the 6 hours. really thought it will take me at least a day with the `assumevalid=0`
3752019-07-19T18:31:19 *** scoop has joined #bitcoin-core-dev
3762019-07-19T18:32:32 *** scoop has quit IRC
3772019-07-19T18:32:39 *** scoop has joined #bitcoin-core-dev
3782019-07-19T18:33:45 *** Victor_sueca has quit IRC
3792019-07-19T18:36:25 <wumpus> so no-one else has had issues with c-lightning and recent bitcoind yet?
3802019-07-19T18:36:37 <wumpus> trying to bisect it
3812019-07-19T18:38:14 *** Victorsueca has joined #bitcoin-core-dev
3822019-07-19T18:46:37 *** scoop has quit IRC
3832019-07-19T18:49:07 *** scoop has joined #bitcoin-core-dev
3842019-07-19T18:49:35 *** harrigan has quit IRC
3852019-07-19T18:52:10 *** hebasto has quit IRC
3862019-07-19T18:52:26 *** etwert has quit IRC
3872019-07-19T18:52:30 *** hebasto has joined #bitcoin-core-dev
3882019-07-19T18:53:22 *** scoop has quit IRC
3892019-07-19T18:55:33 *** etwert has joined #bitcoin-core-dev
3902019-07-19T18:58:37 *** hebasto has quit IRC
3912019-07-19T19:01:33 *** Zenton has joined #bitcoin-core-dev
3922019-07-19T19:03:43 *** pinheadmz has quit IRC
3932019-07-19T19:16:52 *** teardown has joined #bitcoin-core-dev
3942019-07-19T19:29:19 *** scoop has joined #bitcoin-core-dev
3952019-07-19T19:29:48 *** harrigan has joined #bitcoin-core-dev
3962019-07-19T19:29:51 *** scoop has quit IRC
3972019-07-19T19:29:57 *** scoop has joined #bitcoin-core-dev
3982019-07-19T19:31:23 *** teardown has left #bitcoin-core-dev
3992019-07-19T19:43:09 <dongcarl> wumpus: Thinking about implementation of addrv2... I'm thinking: rework CAddress to be more enum-y and less weird-IPv6-y, and do the weird-IPV6-y tricks in the serialization code only if `s.GetVersion() < GOSSIP_ADDRV2_VERSION`
4002019-07-19T19:43:14 <dongcarl> lmk if that makes sense
4012019-07-19T19:43:37 *** bitcoin-git has joined #bitcoin-core-dev
4022019-07-19T19:43:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
4032019-07-19T19:43:49 *** bitcoin-git has left #bitcoin-core-dev
4042019-07-19T19:52:32 *** pinheadmz has joined #bitcoin-core-dev
4052019-07-19T20:03:52 *** bitcoin-git has joined #bitcoin-core-dev
4062019-07-19T20:03:52 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
4072019-07-19T20:03:53 *** bitcoin-git has left #bitcoin-core-dev
4082019-07-19T20:05:13 *** harrigan has quit IRC
4092019-07-19T20:13:27 <wumpus> dongcarl: rust enums would be really nice here
4102019-07-19T20:13:42 <dongcarl> wumpus: Haha yeah... But, alas...
4112019-07-19T20:13:49 <wumpus> dongcarl: but I don't think you need to change the internal representation for this
4122019-07-19T20:14:06 <wumpus> oh wait, you do, ofc
4132019-07-19T20:14:19 * dongcarl almost got gaslighted
4142019-07-19T20:14:26 <wumpus> sorry
4152019-07-19T20:14:37 <sipa> boost::variant?
4162019-07-19T20:14:39 * sipa ducks
4172019-07-19T20:14:51 <BlueMatt> lets just use rust?
4182019-07-19T20:15:13 <wumpus> tfw no std::variant
4192019-07-19T20:15:32 <BlueMatt> dont we already have rust build support? time to start using it :p
4202019-07-19T20:16:09 <BlueMatt> (only like 90% joke, fwiw)
4212019-07-19T20:17:35 * dongcarl is going to do it the stupid way first
4222019-07-19T20:18:40 <sipa> just a uint256 and an enum?
4232019-07-19T20:19:08 <sipa> how will you deal with serialization in addrman.dat?
4242019-07-19T20:19:20 <sipa> peers.dat, i guess
4252019-07-19T20:21:05 <dongcarl> yes just a uint256 and an enum (do we have uint256's?)
4262019-07-19T20:21:17 * sipa points to uint256.h
4272019-07-19T20:21:51 <dongcarl> oh cool!
4282019-07-19T20:22:32 <sipa> we use 256-bit values here and there in bitcoin :)
4292019-07-19T20:22:41 <dongcarl> lol
4302019-07-19T20:22:48 <dongcarl> I haven't looked at peers.dat serialization...
4312019-07-19T20:23:01 <dongcarl> What are potential problems?
4322019-07-19T20:24:02 <dongcarl> Oh... we need to maintain back-compat I guess?
4332019-07-19T20:25:42 <sipa> yes
4342019-07-19T20:26:01 <sipa> well, not backward compatibility
4352019-07-19T20:26:07 <sipa> that'll be impossible anyway
4362019-07-19T20:26:14 <sipa> but you do need forward compatibility
4372019-07-19T20:26:26 <sipa> (new code will need to be able to read an old peers.dat)
4382019-07-19T20:27:31 <dongcarl> Right, sorry that's what I meant... What's usually done in this case? One-off migration of peers.dat?
4392019-07-19T20:27:52 <sipa> up to you
4402019-07-19T20:28:16 <dongcarl> Cool. Thanks for tips!
4412019-07-19T20:28:20 <sipa> if there is a way to serialize a CADdress (haven't checked if there is) that would be compatible, that would be great
4422019-07-19T20:29:06 <dongcarl> sipa: You mean serialize an addrv2 in a way that's back-compatible with addv1?
4432019-07-19T20:29:18 <sipa> yes
4442019-07-19T20:29:21 <sipa> oh, there is
4452019-07-19T20:29:39 <sipa> SER_DISK mode for CAddress stores a version number
4462019-07-19T20:29:58 *** bitcoin-git has joined #bitcoin-core-dev
4472019-07-19T20:29:58 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16425: addrman: Add sleep to while(1) loops (master...1907-addrmanNomNomCpu) https://github.com/bitcoin/bitcoin/pull/16425
4482019-07-19T20:30:01 *** bitcoin-git has left #bitcoin-core-dev
4492019-07-19T20:30:06 <sipa> you can leverage that to just use old serializtion for things compatible with it
4502019-07-19T20:30:12 <sipa> and new serialization otherwise
4512019-07-19T20:30:31 <sipa> (which you can define i guess identical to how the addrv2 bip encodes addressrs)
4522019-07-19T20:31:42 <sipa> that would be automatically forward compatible
4532019-07-19T20:31:54 <sipa> and backward compatible as long as no new style addresses are stored
4542019-07-19T20:34:32 <dongcarl> sipa: Ah... So if I understand you correctly, this way disk serialization of ipv4, v6, and torv2 will be in the older format... Which means if I generate a peers.dat in a newer client and feed it to an older one, the older client will pick up everything except torv3, i2p, and CJDNS?
4552019-07-19T20:35:04 <sipa> it will just fail to deserialize entirely if it contains torv3/i2p/cjdns
4562019-07-19T20:35:13 <sipa> as it has no idea about the length of the field it's trying to read
4572019-07-19T20:35:29 <sipa> so i think there are two ways:
4582019-07-19T20:35:47 * dongcarl listening
4592019-07-19T20:36:07 *** emilengler has joined #bitcoin-core-dev
4602019-07-19T20:36:47 <sipa> 1) have a global peers.dat-wide field (it has an nVersion for this) that says "this file uses new encoding", and then all addresses in it use new encoding; you'd have read support for the old format, but always write in the new format
4612019-07-19T20:38:46 <sipa> 2) you use the per-address nVersion field to distinguish between old and new (right now the nVersion field there is just the client version number which is a terrible practice anyway; define some cutoff equivalent to say 0.99.0 which means "new format" and stick to 0.18.x for old format), but use old encoding when writing tor/ipv4/ipv6
4622019-07-19T20:39:05 <sipa> the first idea is perhaps simpler and much more compact
4632019-07-19T20:39:19 <sipa> as ipv4 is hugely wasteful in the old serialization
4642019-07-19T20:39:41 <dongcarl> Yeah that makes sense
4652019-07-19T20:39:49 <dongcarl> I'm gunna aim for #1 first
4662019-07-19T20:39:51 <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
4672019-07-19T20:40:05 *** Guyver2 has quit IRC
4682019-07-19T20:40:26 <dongcarl> sipa: Thanks for helping think this thru!
4692019-07-19T20:40:59 *** instagibbs_ has joined #bitcoin-core-dev
4702019-07-19T20:42:07 <sipa> to switch between old and new encoding, i suggest not actually using nVersion directly (it's messy...), but instead ORing some field flag into like, like SERIALIZE_TRANSACTION_NO_WITNESS for transactions
4712019-07-19T20:42:53 <sipa> then you can also use OverrideStream in the P2P code to select between old and new encoding based on what the peer supports
4722019-07-19T20:45:39 <dongcarl> sipa: Hmmm I think the spec wants me to use nVersion? https://github.com/bitcoin/bips/blob/f5174192e2d5fb3dfa7232be62d1b9d586a7f8d6/bip-0155.mediawiki#compatibility
4732019-07-19T20:46:07 <sipa> dongcarl: i mean, don't use the p2p protocol nVersion directly to select between features
4742019-07-19T20:46:33 <sipa> that feels like an enormous layer violation, and makes things messy in addrman (where nVersion is the _client_ version, while on the wire it's the protocol version...)
4752019-07-19T20:47:26 <sipa> even if at connection time nVersion is used to signal readiness for the new protocol, set a flag in CNode or so to remember what addr protocol is used, and then explicitly choose a flag to set when serializing addr messages based on that
4762019-07-19T20:48:05 * dongcarl reading and trying to understand
4772019-07-19T20:48:37 <sipa> dongcarl: basically my opinion is that it's a mistake that there is a single "stream version" number that influences serialization
4782019-07-19T20:49:02 <dongcarl> sipa: You mean like our existing logic for CADDR_TIME_VERSION?
4792019-07-19T20:49:05 <dongcarl> That's the mistake?
4802019-07-19T20:49:06 <sipa> yes
4812019-07-19T20:49:28 <sipa> well, that's historical, and dates from a time when client versions and protocol versions were the same thing
4822019-07-19T20:49:49 <sipa> but right now those two are distinct things, and it's not the CAddress that should know exactly which protocols require which serializations
4832019-07-19T20:50:10 <sipa> it should be the protocol implementations that decide that, and just tell CAddress whether to use v1 or v2 (which is something CAddress should know about)
4842019-07-19T20:51:22 <dongcarl> Okay, I think I understand that. What's a good way of passing the v1 vs v2 info to CAddress so it knows how to serialize?
4852019-07-19T20:52:01 <sipa> by essentially using the high bits of nVersion as a bit field, and using one bit in it to indicate which encoding to use
4862019-07-19T20:52:24 <sipa> like SERIALIZE_TRANSACTION_NO_WITNESS (which is equal to 0x40000000)
4872019-07-19T20:53:17 <dongcarl> Oh I see... Seems hacky but there's no way we're serializing a transaction while we're also serializing an address so that's okay, right?
4882019-07-19T20:53:33 <sipa> right, they don't need to live in the same namespace
4892019-07-19T20:53:35 <sipa> for segwit, based on whether segwit support was negotiated with the peer (and/or whether the witness flag in a CInv request is set), a wrapper makes the stream temporarily report that flag in its nVersion
4902019-07-19T20:54:10 <dongcarl> Okay that makes sense!
4912019-07-19T20:54:42 <dongcarl> sipa: Glad you pointed this out because I was about to copy the CADDR_TIME_VERSION logic
4922019-07-19T20:55:06 <sipa> for example, see the line in net_processing:
4932019-07-19T20:55:07 <sipa> connman->PushMessage(pfrom, msgMaker.Make(SERIALIZE_TRANSACTION_NO_WITNESS, NetMsgType::BLOCK, *pblock));
4942019-07-19T20:55:34 <sipa> or
4952019-07-19T20:55:39 <sipa> int nSendFlags = (inv.type == MSG_TX ? SERIALIZE_TRANSACTION_NO_WITNESS : 0);
4962019-07-19T20:55:43 <sipa> connman->PushMessage(pfrom, msgMaker.Make(nSendFlags, NetMsgType::TX, *mi->second));
4972019-07-19T20:57:11 <dongcarl> Ah! Very good examples... I should probably define a SERIALIZE_ADDR_AS_V2 or something
4982019-07-19T20:57:16 <sipa> right
4992019-07-19T20:58:01 <sipa> in the v2 stuff you can probably drop the nVersion/SER_DISK/... logic too
5002019-07-19T20:58:21 <sipa> no need to encode a per-addr version number if that version is being communicated externally
5012019-07-19T20:58:44 <dongcarl> sipa: True!
5022019-07-19T20:58:59 * dongcarl is glad he understood
5032019-07-19T20:59:32 <sipa> much of this is my personal opinion btw, i don't want to give a false impression that this approach is some commonly agreed upon way of doing things
5042019-07-19T21:00:01 *** izaki1 has quit IRC
5052019-07-19T21:00:53 <dongcarl> sipa: It's certainly given me a solid direction for implementation... Much better than me designing in the dark, and I'm happy to iterate once I have an MVP working. :-)
5062019-07-19T21:04:37 *** greylica has joined #bitcoin-core-dev
5072019-07-19T21:05:24 <sipa> great
5082019-07-19T21:10:14 *** scoop has quit IRC
5092019-07-19T21:23:29 *** instagibbs_ has quit IRC
5102019-07-19T21:33:19 *** scoop has joined #bitcoin-core-dev
5112019-07-19T21:41:34 *** reallll is now known as belcher
5122019-07-19T21:43:54 *** scoop has quit IRC
5132019-07-19T21:46:50 *** _major has joined #bitcoin-core-dev
5142019-07-19T21:47:24 *** pinheadmz has quit IRC
5152019-07-19T21:52:06 *** laftho has joined #bitcoin-core-dev
5162019-07-19T22:02:28 *** michaelsdunn1 has quit IRC
5172019-07-19T22:16:24 *** scoop has joined #bitcoin-core-dev
5182019-07-19T22:27:14 *** scoop has quit IRC
5192019-07-19T22:30:35 *** laftho has quit IRC
5202019-07-19T22:41:19 *** _atos has joined #bitcoin-core-dev
5212019-07-19T22:55:08 *** AaronvanW has quit IRC
5222019-07-19T22:57:51 *** bitcoin-git has joined #bitcoin-core-dev
5232019-07-19T22:57:51 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409
5242019-07-19T22:57:52 *** bitcoin-git has left #bitcoin-core-dev
5252019-07-19T23:12:57 *** jarthur has quit IRC
5262019-07-19T23:13:34 *** EagleTM has quit IRC
5272019-07-19T23:21:29 *** EagleTM has joined #bitcoin-core-dev
5282019-07-19T23:30:33 *** pinheadmz has joined #bitcoin-core-dev
5292019-07-19T23:55:16 *** scoop has joined #bitcoin-core-dev