12019-07-22T00:00:01 *** ariel_1 has quit IRC
22019-07-22T00:04:32 *** chrisch1974 has joined #bitcoin-core-dev
32019-07-22T00:09:44 <hugohn> ok that approach makes the most sense to me as well.
42019-07-22T00:11:47 <hugohn> will update the PR. thanks sipa achow101.
52019-07-22T00:35:00 *** luc__ has joined #bitcoin-core-dev
62019-07-22T00:36:38 *** liberiga has joined #bitcoin-core-dev
72019-07-22T00:39:28 *** luc__ has quit IRC
82019-07-22T00:52:44 *** Eagle[TM] has joined #bitcoin-core-dev
92019-07-22T00:54:58 *** EagleTM has quit IRC
102019-07-22T01:02:54 *** DeanWeen has joined #bitcoin-core-dev
112019-07-22T01:06:12 *** d_t has joined #bitcoin-core-dev
122019-07-22T01:16:55 *** Xunie_ has joined #bitcoin-core-dev
132019-07-22T01:20:54 *** Xunie has quit IRC
142019-07-22T01:21:58 *** scoop has joined #bitcoin-core-dev
152019-07-22T01:22:25 *** scoop has quit IRC
162019-07-22T01:23:05 *** scoop has joined #bitcoin-core-dev
172019-07-22T01:24:57 *** mryandao has quit IRC
182019-07-22T01:27:12 *** mryandao has joined #bitcoin-core-dev
192019-07-22T01:37:26 *** EagleTM has joined #bitcoin-core-dev
202019-07-22T01:40:52 *** Eagle[TM] has quit IRC
212019-07-22T01:41:29 *** pinheadmz has quit IRC
222019-07-22T01:48:28 *** jb55 has quit IRC
232019-07-22T01:57:22 *** scoop has quit IRC
242019-07-22T02:00:00 *** designwish has quit IRC
252019-07-22T02:00:18 *** scoop has joined #bitcoin-core-dev
262019-07-22T02:04:05 *** designwish has joined #bitcoin-core-dev
272019-07-22T02:13:00 *** pinheadmz has joined #bitcoin-core-dev
282019-07-22T02:16:25 *** scoop_ has joined #bitcoin-core-dev
292019-07-22T02:19:38 *** scoop has quit IRC
302019-07-22T02:21:19 *** scoop_ has quit IRC
312019-07-22T02:43:14 *** laptop500 has quit IRC
322019-07-22T03:00:01 *** chrisch1974 has quit IRC
332019-07-22T03:03:22 *** emilengler has quit IRC
342019-07-22T03:05:18 *** gholms1 has joined #bitcoin-core-dev
352019-07-22T03:12:26 *** scoop has joined #bitcoin-core-dev
362019-07-22T03:12:57 *** emilengler has joined #bitcoin-core-dev
372019-07-22T03:13:52 *** profmac has quit IRC
382019-07-22T03:14:55 *** pinheadmz has quit IRC
392019-07-22T03:17:13 *** scoop has quit IRC
402019-07-22T03:17:37 *** schnerchi has joined #bitcoin-core-dev
412019-07-22T03:20:28 *** schnerch_ has quit IRC
422019-07-22T03:22:08 *** pinheadmz has joined #bitcoin-core-dev
432019-07-22T03:22:45 *** Eagle[TM] has joined #bitcoin-core-dev
442019-07-22T03:23:01 *** d_t has quit IRC
452019-07-22T03:23:11 *** EagleTM has quit IRC
462019-07-22T03:26:51 *** profmac has joined #bitcoin-core-dev
472019-07-22T03:56:22 *** d_t has joined #bitcoin-core-dev
482019-07-22T04:09:38 *** d_t has quit IRC
492019-07-22T04:31:55 *** Victor_sueca has joined #bitcoin-core-dev
502019-07-22T04:34:42 *** Victorsueca has quit IRC
512019-07-22T04:47:33 *** rex4539 has quit IRC
522019-07-22T05:01:28 *** mryandao has quit IRC
532019-07-22T05:01:48 *** mryandao has joined #bitcoin-core-dev
542019-07-22T05:13:42 *** scoop has joined #bitcoin-core-dev
552019-07-22T05:18:46 *** scoop has quit IRC
562019-07-22T05:19:14 *** Klox3 has quit IRC
572019-07-22T05:20:50 *** Klox3 has joined #bitcoin-core-dev
582019-07-22T05:22:08 *** Klox has joined #bitcoin-core-dev
592019-07-22T05:22:51 *** d_t has joined #bitcoin-core-dev
602019-07-22T06:00:02 *** gholms1 has quit IRC
612019-07-22T06:01:57 *** d_t has quit IRC
622019-07-22T06:19:20 *** Gunni1 has joined #bitcoin-core-dev
632019-07-22T06:25:14 *** hebasto has joined #bitcoin-core-dev
642019-07-22T06:25:47 *** _atos has joined #bitcoin-core-dev
652019-07-22T06:28:22 *** Eagle[TM] has quit IRC
662019-07-22T06:37:28 *** luc__ has joined #bitcoin-core-dev
672019-07-22T06:41:38 *** luc__ has quit IRC
682019-07-22T07:02:54 *** jonatack has joined #bitcoin-core-dev
692019-07-22T07:22:19 *** andytoshi has quit IRC
702019-07-22T07:29:46 *** andytoshi has joined #bitcoin-core-dev
712019-07-22T07:29:46 *** andytoshi has joined #bitcoin-core-dev
722019-07-22T07:38:05 *** jungly has joined #bitcoin-core-dev
732019-07-22T07:41:23 *** kljasdfvv has joined #bitcoin-core-dev
742019-07-22T07:48:10 *** liberiga has quit IRC
752019-07-22T07:50:08 *** jadi has joined #bitcoin-core-dev
762019-07-22T07:52:56 *** bitcoin-git has joined #bitcoin-core-dev
772019-07-22T07:52:56 <bitcoin-git> [bitcoin] torkelrogstad closed pull request #16076: Docs: Add note on precedence of options in bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16076
782019-07-22T07:52:57 *** bitcoin-git has left #bitcoin-core-dev
792019-07-22T07:53:43 *** jonatack has quit IRC
802019-07-22T08:07:18 *** jonatack has joined #bitcoin-core-dev
812019-07-22T08:13:52 *** bitcoin-git has joined #bitcoin-core-dev
822019-07-22T08:13:52 <bitcoin-git> [bitcoin] hebasto opened pull request #16432: qt: Add privacy to the Overview page (master...20190721-privacy) https://github.com/bitcoin/bitcoin/pull/16432
832019-07-22T08:13:53 *** bitcoin-git has left #bitcoin-core-dev
842019-07-22T08:14:29 *** as1nc has quit IRC
852019-07-22T08:14:49 *** as1nc has joined #bitcoin-core-dev
862019-07-22T08:16:27 *** Guyver2 has joined #bitcoin-core-dev
872019-07-22T08:22:03 *** setpill has joined #bitcoin-core-dev
882019-07-22T08:24:38 *** Jazlyn53Robel has joined #bitcoin-core-dev
892019-07-22T08:39:38 *** Jazlyn53Robel has quit IRC
902019-07-22T09:00:01 *** Gunni1 has quit IRC
912019-07-22T09:06:15 *** ang has joined #bitcoin-core-dev
922019-07-22T09:16:27 *** ang has quit IRC
932019-07-22T09:36:01 *** kristapsk_ is now known as kristapsk
942019-07-22T09:36:30 *** queip has quit IRC
952019-07-22T09:39:12 *** timothy has joined #bitcoin-core-dev
962019-07-22T09:42:13 *** queip has joined #bitcoin-core-dev
972019-07-22T09:49:47 *** jadi has quit IRC
982019-07-22T10:06:22 *** Harekiet1 has joined #bitcoin-core-dev
992019-07-22T10:13:40 *** Sentineo has joined #bitcoin-core-dev
1002019-07-22T10:16:29 *** etwert has joined #bitcoin-core-dev
1012019-07-22T10:21:00 *** goatpig has quit IRC
1022019-07-22T10:32:02 *** jadi has joined #bitcoin-core-dev
1032019-07-22T10:35:08 *** Zenton has joined #bitcoin-core-dev
1042019-07-22T10:48:04 *** sdaftuar has quit IRC
1052019-07-22T10:48:28 *** sdaftuar has joined #bitcoin-core-dev
1062019-07-22T10:50:25 *** laptop500 has joined #bitcoin-core-dev
1072019-07-22T10:55:37 *** bogellone has joined #bitcoin-core-dev
1082019-07-22T10:56:07 *** bogellone has left #bitcoin-core-dev
1092019-07-22T11:00:03 *** harrigan has joined #bitcoin-core-dev
1102019-07-22T11:06:07 *** etwert has quit IRC
1112019-07-22T11:13:26 *** Aaronvan_ has joined #bitcoin-core-dev
1122019-07-22T11:16:28 *** AaronvanW has quit IRC
1132019-07-22T11:33:40 *** kristapsk has quit IRC
1142019-07-22T11:43:26 *** bitcoin-git has joined #bitcoin-core-dev
1152019-07-22T11:43:26 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16433: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN (master...1907-txmempoolNoUnknownDefault) https://github.com/bitcoin/bitcoin/pull/16433
1162019-07-22T11:43:30 *** bitcoin-git has left #bitcoin-core-dev
1172019-07-22T11:50:34 *** etwert has joined #bitcoin-core-dev
1182019-07-22T11:52:06 *** spinza has quit IRC
1192019-07-22T11:54:41 *** Aaronvan_ is now known as AaronvanW
1202019-07-22T12:00:02 *** Harekiet1 has quit IRC
1212019-07-22T12:10:33 *** spinza has joined #bitcoin-core-dev
1222019-07-22T12:11:50 *** goatpig has joined #bitcoin-core-dev
1232019-07-22T12:13:35 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1242019-07-22T12:16:31 *** jonatack has quit IRC
1252019-07-22T12:19:27 <MarcoFalke> wumpus: Could you take another look at #16366?
1262019-07-22T12:19:30 <gribble> https://github.com/bitcoin/bitcoin/issues/16366 | init: Use InitError for all errors in bitcoind/qt by MarcoFalke · Pull Request #16366 · bitcoin/bitcoin · GitHub
1272019-07-22T12:21:22 <MarcoFalke> It fixes the tests and has two acks
1282019-07-22T12:24:53 *** werrwer has joined #bitcoin-core-dev
1292019-07-22T12:25:09 *** etwert has quit IRC
1302019-07-22T12:29:54 *** jonatack has joined #bitcoin-core-dev
1312019-07-22T12:30:32 *** dgfhdfg has joined #bitcoin-core-dev
1322019-07-22T12:30:40 *** werrwer has quit IRC
1332019-07-22T12:30:57 *** Guyver2 has quit IRC
1342019-07-22T12:33:54 *** cryptapus has quit IRC
1352019-07-22T12:36:03 *** jadi has quit IRC
1362019-07-22T12:39:27 *** bitcoin-git has joined #bitcoin-core-dev
1372019-07-22T12:39:28 <bitcoin-git> [bitcoin] domob1812 opened pull request #16434: Specify AM_CPPFLAGS for ZMQ (master...zmq-cppflags) https://github.com/bitcoin/bitcoin/pull/16434
1382019-07-22T12:39:29 *** bitcoin-git has left #bitcoin-core-dev
1392019-07-22T12:40:52 *** DeanWeen has quit IRC
1402019-07-22T12:43:57 *** RD1 has joined #bitcoin-core-dev
1412019-07-22T12:45:22 *** _atos has quit IRC
1422019-07-22T12:48:11 *** astro has quit IRC
1432019-07-22T12:48:32 *** cryptapus has joined #bitcoin-core-dev
1442019-07-22T12:48:32 *** cryptapus has quit IRC
1452019-07-22T12:48:32 *** cryptapus has joined #bitcoin-core-dev
1462019-07-22T12:55:54 *** spaced0ut has joined #bitcoin-core-dev
1472019-07-22T13:13:01 *** rh0nj has quit IRC
1482019-07-22T13:14:08 *** rh0nj has joined #bitcoin-core-dev
1492019-07-22T13:17:14 *** scoop has joined #bitcoin-core-dev
1502019-07-22T13:33:29 *** astro has joined #bitcoin-core-dev
1512019-07-22T13:49:02 *** jonatack has quit IRC
1522019-07-22T13:49:02 *** goatpig has quit IRC
1532019-07-22T13:50:24 *** d_t has joined #bitcoin-core-dev
1542019-07-22T13:59:20 *** davterra has joined #bitcoin-core-dev
1552019-07-22T14:15:26 *** scoop has quit IRC
1562019-07-22T14:18:08 *** scoop has joined #bitcoin-core-dev
1572019-07-22T14:29:03 *** bitcoin-git has joined #bitcoin-core-dev
1582019-07-22T14:29:03 <bitcoin-git> [bitcoin] sdaftuar closed pull request #15505: [p2p] Request NOTFOUND transactions immediately from other outbound peers, when possible (master...2019-02-notfound-requests) https://github.com/bitcoin/bitcoin/pull/15505
1592019-07-22T14:29:10 *** bitcoin-git has left #bitcoin-core-dev
1602019-07-22T14:30:08 <sdaftuar> I'd really like some review on #15305 -- I think it's a relatively straightforward bugfix.
1612019-07-22T14:30:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
1622019-07-22T14:34:47 *** jb55 has joined #bitcoin-core-dev
1632019-07-22T14:43:59 *** michaelsdunn1 has joined #bitcoin-core-dev
1642019-07-22T14:50:40 *** d_t has quit IRC
1652019-07-22T14:51:23 <jonasschnelli> looks like 0.18.1rc1 is ready for codesign? objections?
1662019-07-22T14:53:01 *** ossifrage_ has joined #bitcoin-core-dev
1672019-07-22T14:55:30 *** ossifrage has quit IRC
1682019-07-22T14:57:36 <elichai2> Hi, not sure if this is the best place to ask but is there a good `mediawiki` editor out there?(for BIPs etc.)
1692019-07-22T14:59:06 <jonasschnelli> elichai2: good questions. I use the GitHub gist editor. Probably bad advice.
1702019-07-22T15:00:01 *** RD1 has quit IRC
1712019-07-22T15:00:28 *** farmerwampum has quit IRC
1722019-07-22T15:04:26 *** brycec1 has joined #bitcoin-core-dev
1732019-07-22T15:05:19 *** Honthe has joined #bitcoin-core-dev
1742019-07-22T15:12:34 *** shesek has quit IRC
1752019-07-22T15:13:16 *** farmerwampum has joined #bitcoin-core-dev
1762019-07-22T15:14:25 *** bitcoin-git has joined #bitcoin-core-dev
1772019-07-22T15:14:25 <bitcoin-git> [bitcoin] dongcarl opened pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
1782019-07-22T15:14:36 *** bitcoin-git has left #bitcoin-core-dev
1792019-07-22T15:16:31 *** spaced0ut has quit IRC
1802019-07-22T15:24:21 *** farmerwampum has quit IRC
1812019-07-22T15:24:42 *** farmerwampum has joined #bitcoin-core-dev
1822019-07-22T15:24:59 *** phantomcircuit has quit IRC
1832019-07-22T15:25:17 <jonasschnelli> Somehow "make check" fails on a X86 host while running the linux 32bit tests:
1842019-07-22T15:25:18 <jonasschnelli> https://bitcoinbuilds.org/index.php?ansilog=5ad080d1-51ac-4876-8d1d-397d4d7f2a7c.log#l2990
1852019-07-22T15:25:20 <jonasschnelli> Any ideas?
1862019-07-22T15:25:39 <jonasschnelli> fontconfig / xorg is installed
1872019-07-22T15:26:17 *** phantomcircuit has joined #bitcoin-core-dev
1882019-07-22T15:31:05 *** Guyver2 has joined #bitcoin-core-dev
1892019-07-22T15:31:27 *** bitcoin-git has joined #bitcoin-core-dev
1902019-07-22T15:31:27 <bitcoin-git> [bitcoin] hebasto opened pull request #16436: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
1912019-07-22T15:31:28 *** bitcoin-git has left #bitcoin-core-dev
1922019-07-22T15:36:50 <jb55> how common are 500 errors when doing reviews. dang that is annoying
1932019-07-22T15:38:15 <dongcarl> same here...
1942019-07-22T15:38:55 <hebasto> and here...
1952019-07-22T15:38:57 <dongcarl> jonasschnelli: Did you install from depends?
1962019-07-22T15:39:08 <dongcarl> jonasschnelli: Did you install multilib fontconfig?
1972019-07-22T15:39:37 <jonasschnelli> dongcarl: depends... yes. I only did "apt install xorg" on the x86 host.
1982019-07-22T15:39:44 <jonasschnelli> How do I install multilib fontconfig?
1992019-07-22T15:40:12 <dongcarl> jonasschnelli: You're on Ubuntu?
2002019-07-22T15:40:55 <dongcarl> jonasschnelli: I think... `apt-get install libfontconfig1:i386`
2012019-07-22T15:41:14 <dongcarl> Does `bitcoin-qt` start at least?
2022019-07-22T15:41:17 <dongcarl> Or not even
2032019-07-22T15:41:18 *** spaced0ut has joined #bitcoin-core-dev
2042019-07-22T15:41:33 <jonasschnelli> dongcarl: I haven't tried... only make check with start that minimal qt tests
2052019-07-22T15:41:54 <jonasschnelli> let me try libfontconfig1:i386
2062019-07-22T15:42:03 <dongcarl> jonasschnelli: Let me know 1. If `bitcoin-qt` starts by itself 2. what the output of `ldd bitcoin-qt` is
2072019-07-22T15:43:03 <cfields> gitian builders: detached sigs for v0.18.1rc1 are up
2082019-07-22T15:43:04 <jonasschnelli> dongcarl: its running in the CI,... need to change things in order to do that... but let me check
2092019-07-22T15:43:11 <jonasschnelli> thanks cfields
2102019-07-22T15:44:56 <hebasto> gh seems down...
2112019-07-22T15:45:19 <cfields> jonasschnelli: I'll close the PR when github decides to start doing stuff again.
2122019-07-22T15:46:54 <jb55> I'll review someone's PR if they email me the patchset with git-send-email :]
2132019-07-22T15:47:44 <jb55> *decentralized*
2142019-07-22T15:50:57 <jonasschnelli> dongcarl: E: Unable to locate package libfontconfig1:i386
2152019-07-22T15:51:43 <dongcarl> jonasschnelli: https://blog.teststation.org/ubuntu/2016/05/12/installing-32-bit-software-on-ubuntu-16.04/
2162019-07-22T15:51:54 <jonasschnelli> I guess dpkg --add-architecture frst
2172019-07-22T15:52:17 <dongcarl> This is just speculating a little, I don't know what's really wrong till I have a `ldd bitcoin-qt` or something
2182019-07-22T15:53:26 *** captjakk has joined #bitcoin-core-dev
2192019-07-22T15:53:29 <achow101> is github down again?
2202019-07-22T15:53:35 *** rex4539 has joined #bitcoin-core-dev
2212019-07-22T15:53:49 <achow101> getting 500s when I try to look at any pr
2222019-07-22T15:53:49 <dongcarl> achow101: Appears their pulls and issues are down
2232019-07-22T15:53:55 <cfields> dongcarl: no need to speculate, his log shows that "libfontconfig.so.1" is missing. That's how ldd will report it as well.
2242019-07-22T15:54:36 <dongcarl> cfields: My suspicion is that other 32-bit libs are also missing...
2252019-07-22T15:55:25 <cfields> ah, ok.
2262019-07-22T15:56:26 <dongcarl> While people are here... Anyone got a good trick for identifying serialization call-sites for a class?
2272019-07-22T15:56:46 <sipa> dongcarl: comment it out and see where you get compile errors
2282019-07-22T15:57:20 <dongcarl> sipa: that's... pretty good
2292019-07-22T15:58:28 *** hexyul has quit IRC
2302019-07-22T16:03:09 *** lightlike has joined #bitcoin-core-dev
2312019-07-22T16:07:16 <jb55> https://www.githubstatus.com/incidents/8x69vj1xyp9v
2322019-07-22T16:11:36 <emilengler> 500 Error for me too
2332019-07-22T16:15:24 <emilengler> Is the inital block syncing done by multithreading or async stuff?
2342019-07-22T16:15:49 <emilengler> Like are there multiple threads who are downloading the blockchain simultaneously
2352019-07-22T16:20:45 <jonasschnelli> dongcarl: indeed libfontconfig1:i386 libxcb1:i386 where missing...
2362019-07-22T16:21:02 <dongcarl> jonasschnelli: Haha nice!
2372019-07-22T16:21:06 <dongcarl> It's working now?
2382019-07-22T16:21:31 <jonasschnelli> jup. https://bitcoinbuilds.org/index.php?job=a745c8f1-051a-4cfd-b1fa-cd42a2ac3b01. Thanks
2392019-07-22T16:21:55 *** jungly has quit IRC
2402019-07-22T16:23:52 <dongcarl> jonasschnelli: Very cool tool!
2412019-07-22T16:24:49 *** setpill has quit IRC
2422019-07-22T16:24:55 <jonasschnelli> its evolving...
2432019-07-22T16:25:01 *** Aaronvan_ has joined #bitcoin-core-dev
2442019-07-22T16:25:10 <dongcarl> jonasschnelli: btw just so you're aware, we have #bitcoin-builds
2452019-07-22T16:25:11 *** davterra has quit IRC
2462019-07-22T16:25:31 <jonasschnelli> dongcarl: oh. Yeah. I should join there I guess.
2472019-07-22T16:25:52 <dongcarl> :-)
2482019-07-22T16:27:37 *** AaronvanW has quit IRC
2492019-07-22T16:33:18 *** timothy has quit IRC
2502019-07-22T16:46:27 *** Emcy has quit IRC
2512019-07-22T16:46:39 *** reallll has joined #bitcoin-core-dev
2522019-07-22T16:49:40 *** belcher has quit IRC
2532019-07-22T16:50:12 *** mryandao has quit IRC
2542019-07-22T16:51:32 *** mryandao has joined #bitcoin-core-dev
2552019-07-22T16:52:51 *** reallll is now known as belcher
2562019-07-22T16:57:31 *** cryptapus has quit IRC
2572019-07-22T16:58:32 *** cryptapus has joined #bitcoin-core-dev
2582019-07-22T16:58:33 *** cryptapus has quit IRC
2592019-07-22T16:58:33 *** cryptapus has joined #bitcoin-core-dev
2602019-07-22T17:12:58 *** Chris_Stewart_5 has quit IRC
2612019-07-22T17:15:41 *** scoop has quit IRC
2622019-07-22T17:22:43 *** kljasdfvv has quit IRC
2632019-07-22T17:23:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2642019-07-22T17:23:36 *** kljasdfvv has joined #bitcoin-core-dev
2652019-07-22T17:37:34 *** rex4539 has quit IRC
2662019-07-22T17:39:43 *** BGL has quit IRC
2672019-07-22T17:59:08 *** rex4539 has joined #bitcoin-core-dev
2682019-07-22T18:00:02 *** brycec1 has quit IRC
2692019-07-22T18:02:35 *** scoop has joined #bitcoin-core-dev
2702019-07-22T18:04:25 *** thrig1 has joined #bitcoin-core-dev
2712019-07-22T18:04:48 *** owowo has quit IRC
2722019-07-22T18:07:01 *** scoop has quit IRC
2732019-07-22T18:09:34 *** owowo has joined #bitcoin-core-dev
2742019-07-22T18:22:02 <Raystonn> What's the current mindset on Rust? Any plans to analyze its potential use in portions of Core?
2752019-07-22T18:28:05 *** shtirlic has quit IRC
2762019-07-22T18:28:55 *** shtirlic has joined #bitcoin-core-dev
2772019-07-22T18:29:07 *** shtirlic has quit IRC
2782019-07-22T18:29:31 *** shtirlic has joined #bitcoin-core-dev
2792019-07-22T18:32:58 <jb55> Raystonn: seems unlikely, the engineering effort required for maintaining two different compilers/languages/codebases would be super janky.
2802019-07-22T18:40:00 *** scoop has joined #bitcoin-core-dev
2812019-07-22T18:42:18 *** scoop has quit IRC
2822019-07-22T18:42:20 *** scoop_ has joined #bitcoin-core-dev
2832019-07-22T18:43:11 *** hebasto has quit IRC
2842019-07-22T18:47:00 *** scoop_ has quit IRC
2852019-07-22T18:49:31 *** scoop has joined #bitcoin-core-dev
2862019-07-22T18:52:25 <provoostenator> dongcarl: are the guix instructions supposed to work for 0.18.1 as well? Building Docker now, so can compare...
2872019-07-22T18:53:55 *** scoop has quit IRC
2882019-07-22T18:54:13 <dongcarl> provoostenator: I haven't backported to 0.18.1 yet, but good reminder that I should allow building of any bitcoin git repo, not just the current tree!
2892019-07-22T18:54:28 <provoostenator> Ok, just tag me if you need testing...
2902019-07-22T18:54:34 <dongcarl> provoostenator: <3
2912019-07-22T18:54:40 <dongcarl> will do!
2922019-07-22T18:55:16 <emilengler> In which file/function the blockchain is being downloaded?
2932019-07-22T18:57:59 *** Emcy has joined #bitcoin-core-dev
2942019-07-22T18:59:15 <dongcarl> emilengler: This might be a good start: https://dev.visucore.com/bitcoin/doxygen/net__processing_8cpp.html#a1224d372c5701f0279112c2a61514d98
2952019-07-22T19:00:24 <emilengler> dongcarl, thank you
2962019-07-22T19:30:13 <dongcarl> wumpus: In addrv2, couldn't we save 1 byte per address if we don't encode the `addr` as a `std::vector`? If I'm understanding correctly, encoding `std::vector` means encoding a VarInt for the length first, then the contents, but we can infer the size of `addr` from `networkID`, right?
2972019-07-22T19:30:15 *** bitcoin-git has joined #bitcoin-core-dev
2982019-07-22T19:30:15 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16437: Always connect NotifyEntryRemoved with MempoolEntryRemoved (master...1907-AlwaysNotifyMempoolEntryRemoved) https://github.com/bitcoin/bitcoin/pull/16437
2992019-07-22T19:30:17 *** bitcoin-git has left #bitcoin-core-dev
3002019-07-22T19:31:45 *** liberiga has joined #bitcoin-core-dev
3012019-07-22T19:33:19 <sipa> dongcarl: the mapping between network id and length isn't known for unknown network ids
3022019-07-22T19:33:42 <sipa> and old clients must be able to deserialize addresses of unknown network ids i think
3032019-07-22T19:34:47 <sipa> elichai2: seems my math was off, 1B signature validations at 5us/sig is 50k seconds, not 500k seconds
3042019-07-22T19:35:18 <elichai2> with or without libgmp?
3052019-07-22T19:36:28 <sipa> not relevant :)
3062019-07-22T19:36:32 <sipa> my math was off
3072019-07-22T19:36:45 <sipa> by a factor 10
3082019-07-22T19:42:44 *** Relis has joined #bitcoin-core-dev
3092019-07-22T19:43:44 <luke-jr> Raystonn: Rust can't be securely bootstrapped, so that seems like a bad idea for now
3102019-07-22T19:44:19 *** kristapsk has joined #bitcoin-core-dev
3112019-07-22T19:48:25 <cfields> Uhh, I pushed the detached sigs to github, but I don't see them now. Maybe they got lost in the downtime?
3122019-07-22T19:48:54 <cfields> Did anyone manage to fetch the v0.18.1rc1 tag from bitcoin-detached-sigs ?
3132019-07-22T19:50:58 * cfields pushes again
3142019-07-22T19:54:41 <dongcarl> sipa: Does this matter if we're going to be introducing a new message type? Old clients won't understand this new message type...
3152019-07-22T19:55:02 <sipa> dongcarl: that's not what i'm talking about
3162019-07-22T19:55:09 <sipa> i mean when say Torv4 is introduced
3172019-07-22T19:55:17 <dongcarl> Right
3182019-07-22T19:55:22 <sipa> post-addrv4 but pre-torv4 clients won't understand it
3192019-07-22T19:55:52 <dongcarl> s/post-addrv4/post-addrv2/
3202019-07-22T19:56:05 <sipa> yeah
3212019-07-22T19:56:18 <dongcarl> If they don't understand it... why can't they just drop that address?
3222019-07-22T19:56:51 <sipa> because they can't deserialize _anything_
3232019-07-22T19:57:19 <sipa> you send them an addr with 1000 addresses in it, if there is only one torv4 in there, they can't deserialize the whole vectors
3242019-07-22T19:57:59 *** ossifrage_ is now known as ossifrage
3252019-07-22T19:58:20 <dongcarl> sipa: Ah! That would be unfortunate...
3262019-07-22T20:01:20 <luke-jr> maybe the entire field (not just the address) should be given the length?
3272019-07-22T20:04:37 <dongcarl> luke-jr: What would be the benefit of doing that?
3282019-07-22T20:08:16 *** kristapsk has quit IRC
3292019-07-22T20:08:39 *** kristapsk has joined #bitcoin-core-dev
3302019-07-22T20:09:48 *** pinheadmz has quit IRC
3312019-07-22T20:11:25 *** Aaronvan_ is now known as AaronvanW
3322019-07-22T20:16:22 *** harrigan has quit IRC
3332019-07-22T20:17:31 <achow101> cfields: I was able to fetch them
3342019-07-22T20:21:59 <elichai2> luke-jr: https://guix.gnu.org/blog/2018/bootstrapping-rust/
3352019-07-22T20:23:24 <luke-jr> dongcarl: you could skip each address object if you didn't understand it, whether the confusion is part of the address itself or anything else
3362019-07-22T20:23:49 <luke-jr> elichai2: mrustc only works on backdoored CPUs
3372019-07-22T20:28:11 <sipa> i think the biggest concern with rust is introducing a new programming language to the project few contributors are familiar with
3382019-07-22T20:28:19 *** BGL has joined #bitcoin-core-dev
3392019-07-22T20:31:22 <emilengler> Can someone with permission restart this job?
3402019-07-22T20:31:24 <emilengler> https://travis-ci.org/bitcoin/bitcoin/builds/562237872?utm_source=github_status&utm_medium=notification
3412019-07-22T20:31:45 <emilengler> thanks
3422019-07-22T20:42:56 *** Relis has quit IRC
3432019-07-22T20:46:52 *** jtimon has joined #bitcoin-core-dev
3442019-07-22T20:49:56 *** liberiga has quit IRC
3452019-07-22T20:50:32 *** Relis has joined #bitcoin-core-dev
3462019-07-22T20:52:55 <Raystonn> luke-jr: I assume you mean only on Intel or AMD CPUs?
3472019-07-22T21:00:02 *** thrig1 has quit IRC
3482019-07-22T21:03:43 *** flamingspinach has joined #bitcoin-core-dev
3492019-07-22T21:04:02 *** Chris_Stewart_5 has quit IRC
3502019-07-22T21:10:54 <luke-jr> Raystonn: yes
3512019-07-22T21:22:03 *** mol has joined #bitcoin-core-dev
3522019-07-22T21:25:58 *** scoop has joined #bitcoin-core-dev
3532019-07-22T21:26:03 *** scoop has quit IRC
3542019-07-22T21:26:10 *** scoop_ has joined #bitcoin-core-dev
3552019-07-22T21:34:53 <Raystonn> luke-jr: Is your Bitcoin Core development platform running an ARM processor?
3562019-07-22T21:36:42 *** bitcoin-git has joined #bitcoin-core-dev
3572019-07-22T21:36:42 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
3582019-07-22T21:36:43 *** bitcoin-git has left #bitcoin-core-dev
3592019-07-22T21:43:55 *** Guyver2 has quit IRC
3602019-07-22T22:07:26 *** pinheadmz has joined #bitcoin-core-dev
3612019-07-22T22:11:11 <luke-jr> Raystonn: PPC64
3622019-07-22T22:16:40 <Raystonn> What CPUs, or CPU manufacturers, do you trust?
3632019-07-22T22:17:23 <luke-jr> IBM POWER9 in this case
3642019-07-22T22:20:56 <Raystonn> If we really want to verify, we'd need to start with RISC-V, no?
3652019-07-22T22:21:16 <luke-jr> afaik POWER is more open than RISC-V at the moment
3662019-07-22T22:22:32 *** tynes_ has quit IRC
3672019-07-22T22:23:51 *** tynes has joined #bitcoin-core-dev
3682019-07-22T22:35:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3692019-07-22T22:38:10 *** molly has joined #bitcoin-core-dev
3702019-07-22T22:39:06 *** michaelsdunn1 has quit IRC
3712019-07-22T22:39:54 *** lightlike has quit IRC
3722019-07-22T22:40:43 *** mol has quit IRC
3732019-07-22T23:03:08 *** Chris_Stewart_5 has quit IRC
3742019-07-22T23:08:57 *** pinheadmz has quit IRC
3752019-07-22T23:11:48 *** kristapsk has quit IRC
3762019-07-22T23:13:54 *** pinheadmz has joined #bitcoin-core-dev
3772019-07-22T23:19:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3782019-07-22T23:20:49 *** pinheadmz has quit IRC
3792019-07-22T23:24:47 *** kristapsk has joined #bitcoin-core-dev
3802019-07-22T23:27:35 *** davec has quit IRC
3812019-07-22T23:31:28 *** booyah has joined #bitcoin-core-dev
3822019-07-22T23:33:09 *** davec has joined #bitcoin-core-dev
3832019-07-22T23:35:33 *** pinheadmz has joined #bitcoin-core-dev
3842019-07-22T23:39:32 *** liberiga has joined #bitcoin-core-dev
3852019-07-22T23:50:16 *** ptiyoyip has joined #bitcoin-core-dev
3862019-07-22T23:54:01 *** dgfhdfg has quit IRC
3872019-07-22T23:57:32 *** Chris_Stewart_5 has quit IRC