12019-07-24T00:00:02 *** rah1 has quit IRC
22019-07-24T00:03:00 *** ptiyoyip has joined #bitcoin-core-dev
32019-07-24T00:04:36 *** AntiSpamMeta has joined #bitcoin-core-dev
42019-07-24T00:04:59 *** AntiSpamMeta is now known as Guest42475
52019-07-24T00:05:52 *** ryufghj has joined #bitcoin-core-dev
62019-07-24T00:06:58 *** dgfhdfg has quit IRC
72019-07-24T00:09:51 *** ptiyoyip has quit IRC
82019-07-24T00:12:12 *** captjakk has joined #bitcoin-core-dev
92019-07-24T00:14:10 *** captjakk_ has joined #bitcoin-core-dev
102019-07-24T00:14:10 *** captjakk has quit IRC
112019-07-24T00:23:58 *** Karyon has quit IRC
122019-07-24T00:24:25 *** Karyon has joined #bitcoin-core-dev
132019-07-24T00:24:50 *** dgfhdfg has joined #bitcoin-core-dev
142019-07-24T00:28:12 *** ryufghj has quit IRC
152019-07-24T00:30:12 *** AaronvanW has joined #bitcoin-core-dev
162019-07-24T00:34:42 *** AaronvanW has quit IRC
172019-07-24T00:40:54 *** toto99 has joined #bitcoin-core-dev
182019-07-24T00:42:44 *** laptop500 has quit IRC
192019-07-24T00:50:58 *** captjakk_ has quit IRC
202019-07-24T00:51:24 *** captjakk has joined #bitcoin-core-dev
212019-07-24T00:52:54 *** captjakk has quit IRC
222019-07-24T01:18:48 *** dgfhdfg has quit IRC
232019-07-24T01:22:16 *** AaronvanW has joined #bitcoin-core-dev
242019-07-24T01:38:11 *** elichai2 has quit IRC
252019-07-24T01:40:11 *** toto99 has quit IRC
262019-07-24T01:41:54 *** Chris_Stewart_5 has quit IRC
272019-07-24T01:54:58 *** AaronvanW has quit IRC
282019-07-24T02:28:46 *** DeanWeen has joined #bitcoin-core-dev
292019-07-24T02:44:56 *** rex4539 has quit IRC
302019-07-24T02:47:18 *** ghost43_ has joined #bitcoin-core-dev
312019-07-24T02:47:44 *** ghost43 has quit IRC
322019-07-24T02:48:56 *** sipa has quit IRC
332019-07-24T02:49:24 *** sipa has joined #bitcoin-core-dev
342019-07-24T03:00:02 *** Guest42475 has quit IRC
352019-07-24T03:03:31 *** rob01 has joined #bitcoin-core-dev
362019-07-24T03:07:19 *** pinheadmz has quit IRC
372019-07-24T03:09:26 *** schnerch_ has joined #bitcoin-core-dev
382019-07-24T03:09:54 *** pinheadmz has joined #bitcoin-core-dev
392019-07-24T03:12:07 *** schnerchi has quit IRC
402019-07-24T03:14:05 *** davterra has quit IRC
412019-07-24T03:15:00 *** davterra has joined #bitcoin-core-dev
422019-07-24T03:15:51 *** d_t has joined #bitcoin-core-dev
432019-07-24T03:17:06 *** davterra has quit IRC
442019-07-24T03:18:47 *** davterra has joined #bitcoin-core-dev
452019-07-24T03:32:46 *** davterra has quit IRC
462019-07-24T03:37:55 *** gelmutshmidt has quit IRC
472019-07-24T03:42:22 *** elichai2 has joined #bitcoin-core-dev
482019-07-24T03:52:13 *** AaronvanW has joined #bitcoin-core-dev
492019-07-24T04:08:55 *** liberiga has joined #bitcoin-core-dev
502019-07-24T04:11:06 *** pinheadmz has quit IRC
512019-07-24T04:25:28 *** AaronvanW has quit IRC
522019-07-24T04:50:17 *** d_t has quit IRC
532019-07-24T05:07:32 *** liberiga has quit IRC
542019-07-24T05:46:40 *** Krellan has quit IRC
552019-07-24T05:47:07 *** Krellan has joined #bitcoin-core-dev
562019-07-24T05:50:01 *** d_t has joined #bitcoin-core-dev
572019-07-24T05:52:55 *** Krellan has quit IRC
582019-07-24T05:59:28 *** yufryutf has joined #bitcoin-core-dev
592019-07-24T06:00:01 *** rob01 has quit IRC
602019-07-24T06:00:31 *** yufryutf has quit IRC
612019-07-24T06:04:25 *** mg0314b has joined #bitcoin-core-dev
622019-07-24T06:04:38 *** SRV_DW20 has joined #bitcoin-core-dev
632019-07-24T06:09:56 *** mg0314b has quit IRC
642019-07-24T06:16:55 *** d_t has quit IRC
652019-07-24T06:21:28 *** mg0314b has joined #bitcoin-core-dev
662019-07-24T06:23:02 *** AaronvanW has joined #bitcoin-core-dev
672019-07-24T06:23:04 *** mg0314b_ has joined #bitcoin-core-dev
682019-07-24T06:26:13 *** mg0314b has quit IRC
692019-07-24T06:27:18 *** Krellan has joined #bitcoin-core-dev
702019-07-24T06:30:13 *** mg0314b_ has quit IRC
712019-07-24T06:31:09 *** mg0314b has joined #bitcoin-core-dev
722019-07-24T06:32:42 *** Krellan has quit IRC
732019-07-24T06:33:41 *** bitcoin-git has joined #bitcoin-core-dev
742019-07-24T06:33:41 <bitcoin-git> [bitcoin] fanquake opened pull request #16448: doc: add note on precedence of options in bitcoin.conf (master...options_bitocin_conf) https://github.com/bitcoin/bitcoin/pull/16448
752019-07-24T06:33:42 *** bitcoin-git has left #bitcoin-core-dev
762019-07-24T06:33:57 *** mg0314b has quit IRC
772019-07-24T06:55:27 *** AaronvanW has quit IRC
782019-07-24T07:05:46 *** Krellan has joined #bitcoin-core-dev
792019-07-24T07:26:26 *** IGHOR has quit IRC
802019-07-24T07:28:11 *** elichai2 has quit IRC
812019-07-24T07:35:20 *** liberiga has joined #bitcoin-core-dev
822019-07-24T07:40:28 *** Krellan has quit IRC
832019-07-24T07:50:42 *** kljasdfvv has joined #bitcoin-core-dev
842019-07-24T08:00:57 *** AaronvanW has joined #bitcoin-core-dev
852019-07-24T08:07:55 *** Krellan has joined #bitcoin-core-dev
862019-07-24T08:08:41 *** kristapsk has quit IRC
872019-07-24T08:09:23 *** Aaronvan_ has joined #bitcoin-core-dev
882019-07-24T08:09:59 <wumpus> rc1 binaries up https://bitcoincore.org/bin/bitcoin-core-0.18.1/test.rc1/
892019-07-24T08:10:17 <fanquake> wumpus \o/
902019-07-24T08:10:36 <wumpus> (sorry it took a while, hard to concentrate with these temperatures!)
912019-07-24T08:10:52 <fanquake> too hot or too cold ?
922019-07-24T08:12:05 <wumpus> too hot
932019-07-24T08:12:08 *** AaronvanW has quit IRC
942019-07-24T08:14:20 *** Krellan has quit IRC
952019-07-24T08:37:08 *** Zenton has joined #bitcoin-core-dev
962019-07-24T08:41:48 <wumpus> oh, we still need relesae notes for 0.18.1
972019-07-24T08:42:14 <wumpus> release notes on the 0.18 branch are entirely blank at the moment https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes.md
982019-07-24T08:49:35 *** Krellan has joined #bitcoin-core-dev
992019-07-24T08:54:21 *** laptop500 has joined #bitcoin-core-dev
1002019-07-24T08:59:58 *** liberiga has quit IRC
1012019-07-24T09:00:02 *** SRV_DW20 has quit IRC
1022019-07-24T09:04:58 *** Shabbypenguin has joined #bitcoin-core-dev
1032019-07-24T09:09:11 <fanquake> ð
1042019-07-24T09:09:12 *** setpill has joined #bitcoin-core-dev
1052019-07-24T09:09:37 <fanquake> Good call. Are you putting those together, otherwise I can have a look later tonight
1062019-07-24T09:10:27 *** vincenzopalazzo has joined #bitcoin-core-dev
1072019-07-24T09:23:48 *** Krellan has quit IRC
1082019-07-24T09:24:18 *** timothy has joined #bitcoin-core-dev
1092019-07-24T09:28:45 <wumpus> i'll have a look at it in the evening
1102019-07-24T09:29:02 <wumpus> if you want to put in something already please do :)
1112019-07-24T09:32:15 *** jonatack has quit IRC
1122019-07-24T09:43:42 *** timothy has quit IRC
1132019-07-24T09:50:26 *** Honethe_ has quit IRC
1142019-07-24T09:51:13 *** timothy has joined #bitcoin-core-dev
1152019-07-24T09:55:50 *** Krellan has joined #bitcoin-core-dev
1162019-07-24T10:01:10 *** vincenzopalazzo has quit IRC
1172019-07-24T10:01:22 *** Krellan has quit IRC
1182019-07-24T10:04:32 *** TheFuzzStone[m] has quit IRC
1192019-07-24T10:04:53 *** kewde[m] has quit IRC
1202019-07-24T10:08:05 *** tuirektiujm[m] has quit IRC
1212019-07-24T10:08:21 *** electric-sheep[m has quit IRC
1222019-07-24T10:08:50 *** DavidMitchell[m] has quit IRC
1232019-07-24T10:13:43 *** Honethe_ has joined #bitcoin-core-dev
1242019-07-24T10:16:28 *** Krellan has joined #bitcoin-core-dev
1252019-07-24T10:45:51 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1262019-07-24T10:52:34 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1272019-07-24T10:52:57 *** kewde[m] has joined #bitcoin-core-dev
1282019-07-24T10:52:58 *** tuirektiujm[m] has joined #bitcoin-core-dev
1292019-07-24T10:53:04 *** electric-sheep[m has joined #bitcoin-core-dev
1302019-07-24T10:53:05 *** DavidMitchell[m] has joined #bitcoin-core-dev
1312019-07-24T11:01:30 *** Honethe_ has quit IRC
1322019-07-24T11:07:58 *** jonatack has joined #bitcoin-core-dev
1332019-07-24T11:17:47 *** Chris_Stewart_5 has quit IRC
1342019-07-24T11:18:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1352019-07-24T11:20:02 *** Krellan has quit IRC
1362019-07-24T11:20:57 *** bitcoin-git has joined #bitcoin-core-dev
1372019-07-24T11:20:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67923d6b3c1e...0626b8cbdf0a
1382019-07-24T11:20:58 <bitcoin-git> bitcoin/master c3dfc91 Fabian Jahr: test: Skip flaky p2p_invalid_messages test on macOS
1392019-07-24T11:20:58 <bitcoin-git> bitcoin/master 0626b8c MarcoFalke: Merge #16445: test: Skip flaky p2p_invalid_messages test on macOS
1402019-07-24T11:21:10 *** bitcoin-git has left #bitcoin-core-dev
1412019-07-24T11:22:07 *** bitcoin-git has joined #bitcoin-core-dev
1422019-07-24T11:22:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16445: test: Skip flaky p2p_invalid_messages test on macOS (master...mac_test) https://github.com/bitcoin/bitcoin/pull/16445
1432019-07-24T11:22:08 *** bitcoin-git has left #bitcoin-core-dev
1442019-07-24T11:22:32 *** Chris_Stewart_5 has quit IRC
1452019-07-24T11:23:28 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1462019-07-24T11:28:43 *** bitcoin-git has joined #bitcoin-core-dev
1472019-07-24T11:28:43 <bitcoin-git> [bitcoin] EvertonMelo opened pull request #16449: Update v4.3> zmq.md fix CVE-2019-6250 { doc } (master...patch-22) https://github.com/bitcoin/bitcoin/pull/16449
1482019-07-24T11:28:45 *** bitcoin-git has left #bitcoin-core-dev
1492019-07-24T11:30:53 *** tuirektiujm[m] has quit IRC
1502019-07-24T11:37:04 *** tuirektiujm[m] has joined #bitcoin-core-dev
1512019-07-24T11:38:23 *** Aaronvan_ has quit IRC
1522019-07-24T12:00:01 *** Shabbypenguin has quit IRC
1532019-07-24T12:05:25 *** Aaronvan_ has joined #bitcoin-core-dev
1542019-07-24T12:17:35 *** lightlike has joined #bitcoin-core-dev
1552019-07-24T12:25:10 *** dgfhdfg has joined #bitcoin-core-dev
1562019-07-24T12:28:57 *** Krellan has joined #bitcoin-core-dev
1572019-07-24T12:38:34 *** promag has quit IRC
1582019-07-24T12:38:50 *** promag has joined #bitcoin-core-dev
1592019-07-24T12:40:12 *** DeanWeen has quit IRC
1602019-07-24T12:44:42 *** smtx has joined #bitcoin-core-dev
1612019-07-24T12:45:51 *** Chris_Stewart_5 has quit IRC
1622019-07-24T12:52:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1632019-07-24T13:04:08 *** ollij has joined #bitcoin-core-dev
1642019-07-24T13:06:10 *** Krellan has quit IRC
1652019-07-24T13:18:50 *** goatpig has joined #bitcoin-core-dev
1662019-07-24T13:18:53 *** pinheadmz has joined #bitcoin-core-dev
1672019-07-24T13:25:20 *** shesek has quit IRC
1682019-07-24T13:33:10 *** Krellan has joined #bitcoin-core-dev
1692019-07-24T13:34:17 *** ghost43_ is now known as ghost43
1702019-07-24T13:39:12 *** Krellan has quit IRC
1712019-07-24T13:50:30 *** d_t has joined #bitcoin-core-dev
1722019-07-24T13:56:00 *** elichai2 has joined #bitcoin-core-dev
1732019-07-24T13:58:14 *** davterra has joined #bitcoin-core-dev
1742019-07-24T14:03:31 *** shesek has joined #bitcoin-core-dev
1752019-07-24T14:03:31 *** shesek has joined #bitcoin-core-dev
1762019-07-24T14:03:46 *** davterra has quit IRC
1772019-07-24T14:04:18 *** davterra has joined #bitcoin-core-dev
1782019-07-24T14:08:33 *** IGHOR has joined #bitcoin-core-dev
1792019-07-24T14:08:37 *** Krellan has joined #bitcoin-core-dev
1802019-07-24T14:43:08 *** Krellan has quit IRC
1812019-07-24T14:50:54 *** d_t has quit IRC
1822019-07-24T14:51:05 *** bitcoin-git has joined #bitcoin-core-dev
1832019-07-24T14:51:05 <bitcoin-git> [bitcoin] jnewbery opened pull request #16451: Remove CMerkleTx (master...2019-07-remove-CMerkleTx) https://github.com/bitcoin/bitcoin/pull/16451
1842019-07-24T14:51:10 *** bitcoin-git has left #bitcoin-core-dev
1852019-07-24T14:55:52 *** michaelsdunn1 has joined #bitcoin-core-dev
1862019-07-24T15:00:01 *** smtx has quit IRC
1872019-07-24T15:08:41 *** emilengler has joined #bitcoin-core-dev
1882019-07-24T15:09:01 *** jnewbery has quit IRC
1892019-07-24T15:09:04 *** sdaftuar has quit IRC
1902019-07-24T15:14:45 *** setpill has quit IRC
1912019-07-24T15:15:08 *** sdaftuar has joined #bitcoin-core-dev
1922019-07-24T15:16:19 *** jnewbery has joined #bitcoin-core-dev
1932019-07-24T15:16:46 *** havenwood1 has joined #bitcoin-core-dev
1942019-07-24T15:24:22 *** Aaronvan_ has quit IRC
1952019-07-24T15:24:57 *** AaronvanW has joined #bitcoin-core-dev
1962019-07-24T15:46:05 *** Krellan has joined #bitcoin-core-dev
1972019-07-24T15:54:03 *** kljasdfvv has quit IRC
1982019-07-24T15:57:00 <dongcarl> So my prototype for addrv2 is passing all netbase tests except for one: `ResolveSubNet("::/0").Match(ResolveIP("1.2.3.4"))`
1992019-07-24T15:57:23 <dongcarl> Logically, should we treat IPv4 as a subset of IPv6?
2002019-07-24T15:58:22 <dongcarl> Another question: should we treat an all-0 netmask as meaning _any network_?
2012019-07-24T16:01:17 *** shesek has quit IRC
2022019-07-24T16:12:13 *** promag has quit IRC
2032019-07-24T16:12:58 *** promag has joined #bitcoin-core-dev
2042019-07-24T16:14:28 *** Krellan has quit IRC
2052019-07-24T16:22:48 *** sdaftuar has quit IRC
2062019-07-24T16:23:22 *** jnewbery has quit IRC
2072019-07-24T16:27:51 *** sdaftuar has joined #bitcoin-core-dev
2082019-07-24T16:30:29 *** jnewbery has joined #bitcoin-core-dev
2092019-07-24T16:33:23 *** timothy has quit IRC
2102019-07-24T16:35:16 *** bitcoin-git has joined #bitcoin-core-dev
2112019-07-24T16:35:16 <bitcoin-git> [bitcoin] hebasto closed pull request #16416: -datadir or -datadir="" option implies default datadir (master...20190718-nodatadir) https://github.com/bitcoin/bitcoin/pull/16416
2122019-07-24T16:35:17 *** bitcoin-git has left #bitcoin-core-dev
2132019-07-24T16:39:08 *** sdaftuar has quit IRC
2142019-07-24T16:39:48 *** jnewbery has quit IRC
2152019-07-24T16:42:15 *** jungly has quit IRC
2162019-07-24T16:45:10 <wumpus> dongcarl: we've always regarded IPv4 as a subset of IPv6, I think to change that would need a very good reason, as it might break some things
2172019-07-24T16:45:57 *** belcher has quit IRC
2182019-07-24T16:46:51 *** belcher has joined #bitcoin-core-dev
2192019-07-24T16:49:26 *** csknk has joined #bitcoin-core-dev
2202019-07-24T16:51:18 *** jarthur has joined #bitcoin-core-dev
2212019-07-24T16:57:03 <dongcarl> wumpus: Sounds good
2222019-07-24T16:57:51 *** bpo has joined #bitcoin-core-dev
2232019-07-24T17:00:20 *** shesek has joined #bitcoin-core-dev
2242019-07-24T17:00:20 *** shesek has joined #bitcoin-core-dev
2252019-07-24T17:02:08 *** Chris_Stewart_5 has quit IRC
2262019-07-24T17:03:16 *** f1231l has joined #bitcoin-core-dev
2272019-07-24T17:06:58 *** michaelfolkson has joined #bitcoin-core-dev
2282019-07-24T17:07:34 *** sdaftuar has joined #bitcoin-core-dev
2292019-07-24T17:14:12 *** shesek has quit IRC
2302019-07-24T17:15:09 *** f1231l has quit IRC
2312019-07-24T17:15:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2322019-07-24T17:34:11 *** bitcoin-git has joined #bitcoin-core-dev
2332019-07-24T17:34:12 <bitcoin-git> [bitcoin] ariard opened pull request #16452: refactor : use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
2342019-07-24T17:34:13 *** bitcoin-git has left #bitcoin-core-dev
2352019-07-24T17:39:48 *** jb55 has quit IRC
2362019-07-24T17:43:43 *** Zenton has quit IRC
2372019-07-24T17:47:33 *** jb55 has joined #bitcoin-core-dev
2382019-07-24T17:48:40 *** jonatack has quit IRC
2392019-07-24T17:49:16 *** jonatack has joined #bitcoin-core-dev
2402019-07-24T17:54:40 *** sdaftuar_ has joined #bitcoin-core-dev
2412019-07-24T17:58:00 *** sdaftuar has quit IRC
2422019-07-24T17:59:12 *** kcalvinalvin has joined #bitcoin-core-dev
2432019-07-24T18:00:01 *** havenwood1 has quit IRC
2442019-07-24T18:00:20 *** sdaftuar_ has quit IRC
2452019-07-24T18:02:57 *** kcalvinalvin has quit IRC
2462019-07-24T18:03:19 *** sdaftuar_ has joined #bitcoin-core-dev
2472019-07-24T18:03:51 *** kcalvinalvin has joined #bitcoin-core-dev
2482019-07-24T18:06:58 *** jnewbery_ has joined #bitcoin-core-dev
2492019-07-24T18:08:01 *** bitcoin-git has joined #bitcoin-core-dev
2502019-07-24T18:08:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0626b8cbdf0a...d960d5ca99b7
2512019-07-24T18:08:03 <bitcoin-git> bitcoin/master 0b86e51 Hennadii Stepanov: Refactor out translation.h
2522019-07-24T18:08:04 <bitcoin-git> bitcoin/master 7c45e14 Hennadii Stepanov: Add bilingual message type
2532019-07-24T18:08:05 <bitcoin-git> bitcoin/master 753f7cc Hennadii Stepanov: scripted-diff: Make translation bilingual
2542019-07-24T18:08:07 *** bitcoin-git has left #bitcoin-core-dev
2552019-07-24T18:08:23 *** rex4539 has joined #bitcoin-core-dev
2562019-07-24T18:09:07 *** bitcoin-git has joined #bitcoin-core-dev
2572019-07-24T18:09:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16362: Add bilingual_str type (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362
2582019-07-24T18:09:15 *** rex4539 has quit IRC
2592019-07-24T18:09:21 *** bitcoin-git has left #bitcoin-core-dev
2602019-07-24T18:11:59 *** csknk has quit IRC
2612019-07-24T18:12:16 *** rex4539 has joined #bitcoin-core-dev
2622019-07-24T18:12:50 *** belcher has quit IRC
2632019-07-24T18:14:29 *** michaelfolkson has quit IRC
2642019-07-24T18:15:27 *** bitcoin-git has joined #bitcoin-core-dev
2652019-07-24T18:15:27 <bitcoin-git> [bitcoin] laanwj closed pull request #16449: doc: Update v4.3> zmq.md fix CVE-2019-6250 (master...patch-22) https://github.com/bitcoin/bitcoin/pull/16449
2662019-07-24T18:15:28 *** bitcoin-git has left #bitcoin-core-dev
2672019-07-24T18:17:10 *** belcher has joined #bitcoin-core-dev
2682019-07-24T18:19:16 *** Guest50398 has joined #bitcoin-core-dev
2692019-07-24T18:21:44 *** jkczyz has joined #bitcoin-core-dev
2702019-07-24T18:26:53 *** sipa has quit IRC
2712019-07-24T18:27:08 *** sipa has joined #bitcoin-core-dev
2722019-07-24T18:28:35 *** coreybt has joined #bitcoin-core-dev
2732019-07-24T18:29:31 *** jeremyrubin has joined #bitcoin-core-dev
2742019-07-24T18:31:35 *** ezegom has joined #bitcoin-core-dev
2752019-07-24T18:35:43 *** bpo has quit IRC
2762019-07-24T18:37:59 *** ezegom has quit IRC
2772019-07-24T18:49:33 *** bitcoin-git has joined #bitcoin-core-dev
2782019-07-24T18:49:33 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/a6cba19831da...784e218610d4
2792019-07-24T18:49:33 <bitcoin-git> bitcoin/0.18 784e218 Wladimir J. van der Laan: doc: Update release notes for rc1
2802019-07-24T18:49:35 *** bitcoin-git has left #bitcoin-core-dev
2812019-07-24T18:51:38 *** ollij has quit IRC
2822019-07-24T18:53:40 *** coreybt has quit IRC
2832019-07-24T18:55:06 *** bitcoin-git has joined #bitcoin-core-dev
2842019-07-24T18:55:06 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
2852019-07-24T18:55:07 *** bitcoin-git has left #bitcoin-core-dev
2862019-07-24T18:55:22 *** bitcoin-git has joined #bitcoin-core-dev
2872019-07-24T18:55:22 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
2882019-07-24T18:55:35 *** bitcoin-git has left #bitcoin-core-dev
2892019-07-24T19:06:32 *** kcalvinalvin has quit IRC
2902019-07-24T19:06:51 *** kcalvinalvin has joined #bitcoin-core-dev
2912019-07-24T19:10:07 <hebasto> should I rebase my open PR when a range of its commits are already merged with other PR? (see: #16224, #16362)
2922019-07-24T19:10:10 <gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
2932019-07-24T19:10:12 <gribble> https://github.com/bitcoin/bitcoin/issues/16362 | Add bilingual_str type by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
2942019-07-24T19:15:26 *** jonatack has quit IRC
2952019-07-24T19:33:12 <elichai2> sipa: Hey, I'm trying to figure out what kind of descriptors makes sense *inside* a `tap(internal_key, [...tree..])` desc, I came up with a new pk(let's call it ts_pk for the conversation) and a new multi for CHECKSIGADD scripts(n-of-n), and that's it? maybe `raw()`? (I don't think sh,wsh, pkh, wpkh, combo,addr or regular pk makes sense inside of taproot/tapscripts)
2962019-07-24T19:34:09 *** jonatack has joined #bitcoin-core-dev
2972019-07-24T19:37:07 *** CubicEarth has quit IRC
2982019-07-24T19:38:26 *** captjakk has joined #bitcoin-core-dev
2992019-07-24T19:46:17 <sipa> elichai2: join ##miniscript
3002019-07-24T19:46:37 <sipa> there are many things possible
3012019-07-24T19:47:10 <sipa> wsh/wpkh clearly don't make sense inside taproot, as they're only valid as toplevel things or p2sh by definition
3022019-07-24T19:47:43 <sipa> but i think pk/pkh should be, though perhaps by then we can just only have a miniscript variant for taproot and only support that inside taproot descriptors
3032019-07-24T19:48:08 <elichai2> But tapscript modifies `OP_CHECKSIG` to be with schnorr
3042019-07-24T19:48:14 <sipa> sure
3052019-07-24T19:48:37 <elichai2> so then `pk()` will mean different thing inside and outside of taproot
3062019-07-24T19:48:37 <sipa> but pk could have different semantics inside taproot than inside other things
3072019-07-24T19:48:41 <sipa> that's already the case
3082019-07-24T19:48:44 <elichai2> should it still be the same name?
3092019-07-24T19:48:53 <sipa> inside p2sh the sighash is computed differently than outside
3102019-07-24T19:49:00 <sipa> inside segwit it's computed even more differently
3112019-07-24T19:49:07 <elichai2> he
3122019-07-24T19:49:50 <elichai2> ok, makes sense. pkh doesn't make a lot of sense to me because when do you reveal the pubkey? on the same script you give the hash?
3132019-07-24T19:50:23 <sipa> elichai2: in miniscript we have a pk_h that's actually preferable sometimes to pk
3142019-07-24T19:50:38 <sipa> because you only put a shorter hash inside the script
3152019-07-24T19:51:18 <elichai2> but on the spending script you'll need to supply that key anyway. (in the same tx that you reveal the script with the hash)
3162019-07-24T19:51:18 *** bitcoin-git has joined #bitcoin-core-dev
3172019-07-24T19:51:18 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16453: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
3182019-07-24T19:51:19 *** bitcoin-git has left #bitcoin-core-dev
3192019-07-24T19:51:29 <sipa> elichai2: only if the branch is actually executed
3202019-07-24T19:51:45 <sipa> if the probability for that is low enough, this may be a good tradeoff
3212019-07-24T19:51:55 <sipa> the miniscript compiler can figure that out :)
3222019-07-24T19:52:01 *** davterra has quit IRC
3232019-07-24T19:52:51 *** davterra has joined #bitcoin-core-dev
3242019-07-24T19:52:56 *** Zenton has joined #bitcoin-core-dev
3252019-07-24T19:53:00 <elichai2> to alliveate 32 byte of hashing computation? ok haha, i'm trying to figure out if the current non-miniscript desc makes sense. because it seems that there's some time until miniscript is really public
3262019-07-24T19:53:28 <sipa> elichai2: no, to reduce the size of a satisfaction
3272019-07-24T19:53:51 <sipa> 20 byte hash instead of 33 byte pubkey
3282019-07-24T19:54:30 <elichai2> but if that's not the spending path you reveal only the hash of the branch anyway, right?
3292019-07-24T19:54:39 <sipa> right
3302019-07-24T19:58:11 *** davterra has quit IRC
3312019-07-24T19:58:46 *** davterra has joined #bitcoin-core-dev
3322019-07-24T19:59:38 *** davterra has joined #bitcoin-core-dev
3332019-07-24T20:03:22 *** emilengler has quit IRC
3342019-07-24T20:07:19 <elichai2> what about a SIGHASHADD multi descriptor?(n-of-n) do you think it should be a thing or people should try to stick to musig even when interactivity is a problem?
3352019-07-24T20:08:38 <sipa> elichai2: the signing interactivity won't always be possible, so there definitely should be a way to use CHECKSIGADD-based multisig scripts
3362019-07-24T20:09:09 *** rex4539 has quit IRC
3372019-07-24T20:09:47 <sipa> elichai2: we could have a variant of multi for that in taproot descriptors (and i'd suggest that for that it does get a different name, because the actual opcodes that correspond to it are different)
3382019-07-24T20:10:05 *** jarthur has quit IRC
3392019-07-24T20:11:06 <elichai2> Right. and I think there's no point of talking about a muSig descriptor before musig has at least a standardization proposal
3402019-07-24T20:14:00 <sipa> agree
3412019-07-24T20:14:13 <sipa> i think the same is true about taproot
3422019-07-24T20:14:26 <sipa> but at least in terms of experimental work, we can do both
3432019-07-24T20:14:39 <sipa> but regardless, we can't do without non-musig based thresholds/multisig
3442019-07-24T20:23:03 *** michaelfolkson has joined #bitcoin-core-dev
3452019-07-24T20:26:35 *** michaelfolkson has quit IRC
3462019-07-24T20:33:28 *** stalker` has joined #bitcoin-core-dev
3472019-07-24T20:34:52 *** ezegom has joined #bitcoin-core-dev
3482019-07-24T20:40:36 *** bitcoin-git has joined #bitcoin-core-dev
3492019-07-24T20:40:36 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16455: doc: Remove downgrading warning in release notes, per 0.18 branch (master...1907-docReleaseNotes) https://github.com/bitcoin/bitcoin/pull/16455
3502019-07-24T20:40:37 *** bitcoin-git has left #bitcoin-core-dev
3512019-07-24T20:55:01 *** kcalvinalvin has quit IRC
3522019-07-24T20:58:52 *** state_bits has quit IRC
3532019-07-24T21:00:02 *** Guest50398 has quit IRC
3542019-07-24T21:04:22 *** hcchien has joined #bitcoin-core-dev
3552019-07-24T21:05:35 *** hebasto has quit IRC
3562019-07-24T21:05:54 *** hebasto has joined #bitcoin-core-dev
3572019-07-24T21:06:08 *** bitcoin-git has joined #bitcoin-core-dev
3582019-07-24T21:06:08 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16453: WIP: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
3592019-07-24T21:06:10 *** bitcoin-git has left #bitcoin-core-dev
3602019-07-24T21:10:10 *** Chris_Stewart_5 has quit IRC
3612019-07-24T21:10:30 *** liberiga has joined #bitcoin-core-dev
3622019-07-24T21:10:38 *** stalker` has quit IRC
3632019-07-24T21:12:45 *** goatpig has quit IRC
3642019-07-24T21:13:32 *** michaelfolkson has joined #bitcoin-core-dev
3652019-07-24T21:13:46 *** toto99 has joined #bitcoin-core-dev
3662019-07-24T21:15:51 *** hebasto has quit IRC
3672019-07-24T21:15:57 *** hebasto_ has joined #bitcoin-core-dev
3682019-07-24T21:22:14 *** michaelfolkson has quit IRC
3692019-07-24T21:33:13 *** toto99 has quit IRC
3702019-07-24T21:35:01 *** michaelsdunn1 has quit IRC
3712019-07-24T21:48:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3722019-07-24T22:06:13 *** captjakk has quit IRC
3732019-07-24T22:08:27 *** ezegom has quit IRC
3742019-07-24T22:21:42 *** laptop500 has quit IRC
3752019-07-24T22:25:47 *** promag has quit IRC
3762019-07-24T22:25:59 *** promag has joined #bitcoin-core-dev
3772019-07-24T22:26:25 *** captjakk has joined #bitcoin-core-dev
3782019-07-24T22:27:44 *** liberiga has quit IRC
3792019-07-24T22:28:44 *** michaelfolkson has joined #bitcoin-core-dev
3802019-07-24T22:30:45 *** promag has quit IRC
3812019-07-24T22:31:30 *** promag has joined #bitcoin-core-dev
3822019-07-24T22:31:30 *** Chris_Stewart_5 has quit IRC
3832019-07-24T22:38:59 *** michaelfolkson has quit IRC
3842019-07-24T22:40:03 *** michaelfolkson has joined #bitcoin-core-dev
3852019-07-24T22:50:01 *** rh0nj has quit IRC
3862019-07-24T22:50:25 <elichai2> Is the right way to access the scripts in descriptors is using `ExpandHelper`? (because `MakeScripts` is private) (I have a function that parses a taproot desc and generates a tree with `DescriptorImpl` leafs, and I want to compute the right tweak)
3872019-07-24T22:51:09 *** rh0nj has joined #bitcoin-core-dev
3882019-07-24T22:57:26 *** michaelfolkson has quit IRC
3892019-07-24T23:02:36 *** kristapsk has joined #bitcoin-core-dev
3902019-07-24T23:02:59 <sipa> elichai2: eh depends what you want to do
3912019-07-24T23:03:17 <sipa> MakeScripts is the node-type-specific function to be overridden
3922019-07-24T23:03:26 <sipa> ExpandHelper is what invokes things recursively etc
3932019-07-24T23:05:37 <elichai2> let's say I have a `PKDescriptor` descriptor there I would want to get the `KEY OP_CHECKSIG` script so I can hash it. it seems that naivley MakeScripts does it but it's designed as you said to be used internally by ExpandHelper
3942019-07-24T23:06:26 <sipa> everything is expanded into the FlatSigningProvider
3952019-07-24T23:06:43 *** michaelfolkson has joined #bitcoin-core-dev
3962019-07-24T23:07:41 <sipa> you'll need to add some interface to SigningProvider to access taproot pubkey->key or pubkey->(merklebranch,script) things
3972019-07-24T23:08:10 <elichai2> does it expand in `ParseScript` already? or do I need to call something to make it expand there?
3982019-07-24T23:08:21 <sipa> ParseScript just builds the Descriptor objects
3992019-07-24T23:08:28 *** davterra has quit IRC
4002019-07-24T23:08:35 <sipa> filling the FlatSigningProvider happens through the Expand* functions
4012019-07-24T23:09:12 <elichai2> Ok. So I'll make my TapDescriptor contain DescriptorImpls and not scripts and i'll expand them later when needed. Thanks!
4022019-07-24T23:09:23 <sipa> that sounds right
4032019-07-24T23:13:20 *** AaronvanW has quit IRC
4042019-07-24T23:13:32 *** toto99 has joined #bitcoin-core-dev
4052019-07-24T23:13:36 *** AaronvanW has joined #bitcoin-core-dev
4062019-07-24T23:17:46 *** michaelsdunn1 has joined #bitcoin-core-dev
4072019-07-24T23:17:53 *** michaelfolkson has quit IRC
4082019-07-24T23:24:31 *** toto99 has quit IRC
4092019-07-24T23:29:51 *** ptiyoyip has joined #bitcoin-core-dev
4102019-07-24T23:32:07 *** lightlike has quit IRC
4112019-07-24T23:33:18 *** dgfhdfg has quit IRC
4122019-07-24T23:47:01 *** ptiyoyip has quit IRC
4132019-07-24T23:47:45 *** michaelsdunn1 has quit IRC
4142019-07-24T23:52:30 *** AaronvanW has joined #bitcoin-core-dev
4152019-07-24T23:56:49 *** AaronvanW has quit IRC