12019-07-29T00:00:02  *** EricYuzo has quit IRC
  22019-07-29T00:11:01  *** rh0nj has quit IRC
  32019-07-29T00:12:07  *** rh0nj has joined #bitcoin-core-dev
  42019-07-29T00:19:32  *** Lauwenmark has joined #bitcoin-core-dev
  52019-07-29T00:32:39  *** luke-jr has joined #bitcoin-core-dev
  62019-07-29T01:00:25  *** JamesAU has joined #bitcoin-core-dev
  72019-07-29T01:01:59  *** JamesAU_ has joined #bitcoin-core-dev
  82019-07-29T01:05:39  *** JamesAU has quit IRC
  92019-07-29T01:07:50  *** emilengler has quit IRC
 102019-07-29T01:16:43  *** Xunie__ has joined #bitcoin-core-dev
 112019-07-29T01:20:34  *** Xunie_ has quit IRC
 122019-07-29T01:44:10  *** teardown has quit IRC
 132019-07-29T01:44:30  *** bitcoin-git has joined #bitcoin-core-dev
 142019-07-29T01:44:30  <bitcoin-git> [bitcoin] fanquake closed pull request #15052: Tests: Contract testing for the procedure AddTimeData and related fixes (master...timedata_contract_test2) https://github.com/bitcoin/bitcoin/pull/15052
 152019-07-29T01:44:31  *** bitcoin-git has left #bitcoin-core-dev
 162019-07-29T01:45:40  *** bitcoin-git has joined #bitcoin-core-dev
 172019-07-29T01:45:40  <bitcoin-git> [bitcoin] fanquake closed pull request #15104: Tests: Add unit testing for the CompressScript function (master...compress_contract_test3) https://github.com/bitcoin/bitcoin/pull/15104
 182019-07-29T01:45:41  *** bitcoin-git has left #bitcoin-core-dev
 192019-07-29T01:47:20  *** bitcoin-git has joined #bitcoin-core-dev
 202019-07-29T01:47:20  <bitcoin-git> [bitcoin] fanquake closed pull request #13357: Define SIGHASH_MASK in validation and determine the use of SIGHASH_SINGLE in signing (master...signsingle) https://github.com/bitcoin/bitcoin/pull/13357
 212019-07-29T01:47:23  *** bitcoin-git has left #bitcoin-core-dev
 222019-07-29T02:03:23  *** profmac has quit IRC
 232019-07-29T02:11:59  *** DeanGuss has joined #bitcoin-core-dev
 242019-07-29T02:13:19  *** rex4539 has quit IRC
 252019-07-29T02:16:37  *** profmac has joined #bitcoin-core-dev
 262019-07-29T02:31:25  *** andytoshi has joined #bitcoin-core-dev
 272019-07-29T02:33:13  *** darosior has quit IRC
 282019-07-29T02:55:41  *** dviola has quit IRC
 292019-07-29T03:00:02  *** Lauwenmark has quit IRC
 302019-07-29T03:04:10  *** Lauwenmark has joined #bitcoin-core-dev
 312019-07-29T03:12:11  *** davex_ has joined #bitcoin-core-dev
 322019-07-29T03:14:37  *** davex__ has quit IRC
 332019-07-29T03:22:38  *** liberiga has joined #bitcoin-core-dev
 342019-07-29T03:45:17  *** Eagle[TM] has joined #bitcoin-core-dev
 352019-07-29T03:47:36  *** pinheadmz has joined #bitcoin-core-dev
 362019-07-29T03:48:04  *** EagleTM has quit IRC
 372019-07-29T03:50:16  *** liberiga has quit IRC
 382019-07-29T03:53:33  *** schnerchi has joined #bitcoin-core-dev
 392019-07-29T03:56:37  *** schnerch_ has quit IRC
 402019-07-29T03:58:34  *** kcalvinalvin has joined #bitcoin-core-dev
 412019-07-29T04:05:57  *** Klox has quit IRC
 422019-07-29T04:07:24  *** sipa has quit IRC
 432019-07-29T04:12:40  *** sipa has joined #bitcoin-core-dev
 442019-07-29T04:13:23  *** dviola has joined #bitcoin-core-dev
 452019-07-29T04:44:50  <phantomcircuit> sipa, i added logging of the leveldb wrapper stuff and noticed that there's requests for seemingly everything until block height=227931 where the cache seems to absorb all the requests, does that make any sense or have i just missed something really obvious
 462019-07-29T04:49:29  <sipa> phantomcircuit: elaborate?
 472019-07-29T04:52:30  <phantomcircuit> sipa, i added some LogPrint statements in dbwrapper.h after pdb->Get in Read and Exists
 482019-07-29T04:53:05  <phantomcircuit> i wanted to do a graph of "io" relative to dbcache size during IBD
 492019-07-29T04:53:21  <phantomcircuit> but instead what im seeing in logs seems crazy
 502019-07-29T04:55:36  *** AaronvanW has quit IRC
 512019-07-29T05:00:05  <phantomcircuit> sipa, i changed the logging hang on i'll upload the debug.log...
 522019-07-29T05:00:07  <phantomcircuit> https://github.com/pstratem/bitcoin/commits/2019-07-28-leveldb-detail
 532019-07-29T05:07:39  <phantomcircuit> sipa, https://2083236893.com/debug.log
 542019-07-29T05:15:03  <phantomcircuit> sipa, i think that's the block where bip34 was activated
 552019-07-29T05:16:50  *** dviola has quit IRC
 562019-07-29T05:21:07  <harding> phantomcircuit: BIP90 agrees that 227931 was the BIP34 activationheight.
 572019-07-29T05:21:45  <sipa> phantomcircuit: will look tomorrow
 582019-07-29T05:23:08  <sipa> threre is some interaction between bip34 and the utxo logic
 592019-07-29T05:24:15  <phantomcircuit> oh i see bip30
 602019-07-29T05:26:29  <phantomcircuit> sipa, nvm i understand how, the bip30 logic guarantees at least one utxo db access for each transaction in the block until the bip34 activation block
 612019-07-29T05:26:51  <phantomcircuit> and since it's never going to be in the cache the read always goes to disk
 622019-07-29T05:27:15  <phantomcircuit> there's probably potential to optimize that when assumevalid is set
 632019-07-29T05:28:00  <phantomcircuit> it's 34 million leveldb Get calls
 642019-07-29T05:28:49  *** AaronvanW has joined #bitcoin-core-dev
 652019-07-29T05:34:00  *** AaronvanW has quit IRC
 662019-07-29T06:00:02  *** Lauwenmark has quit IRC
 672019-07-29T06:01:28  *** DeanGuss has quit IRC
 682019-07-29T06:01:45  *** DeanGuss has joined #bitcoin-core-dev
 692019-07-29T06:05:17  *** AaronvanW has joined #bitcoin-core-dev
 702019-07-29T06:13:22  *** DeanGuss has quit IRC
 712019-07-29T06:13:37  *** DeanGuss has joined #bitcoin-core-dev
 722019-07-29T06:14:38  *** rex4539 has joined #bitcoin-core-dev
 732019-07-29T06:15:00  *** davec has quit IRC
 742019-07-29T06:15:24  *** hebasto has joined #bitcoin-core-dev
 752019-07-29T06:17:21  *** DeanGuss has quit IRC
 762019-07-29T06:17:48  *** DeanGuss has joined #bitcoin-core-dev
 772019-07-29T06:22:18  *** davec has joined #bitcoin-core-dev
 782019-07-29T06:38:29  *** Pysis|work has joined #bitcoin-core-dev
 792019-07-29T06:38:39  *** AaronvanW has quit IRC
 802019-07-29T06:50:02  *** kcalvinalvin has quit IRC
 812019-07-29T06:55:26  *** rex4539 has quit IRC
 822019-07-29T07:18:43  *** hebasto has quit IRC
 832019-07-29T07:22:05  *** Guyver2 has joined #bitcoin-core-dev
 842019-07-29T07:37:58  *** Eagle[TM] has quit IRC
 852019-07-29T07:42:00  *** Keshawn1Walker has joined #bitcoin-core-dev
 862019-07-29T07:42:54  *** rex4539 has joined #bitcoin-core-dev
 872019-07-29T07:46:12  *** AaronvanW has joined #bitcoin-core-dev
 882019-07-29T07:55:15  *** Keshawn1Walker has quit IRC
 892019-07-29T08:04:16  *** zrc has joined #bitcoin-core-dev
 902019-07-29T08:05:05  *** JamesAU has joined #bitcoin-core-dev
 912019-07-29T08:07:45  *** JamesAU__ has joined #bitcoin-core-dev
 922019-07-29T08:08:35  *** JamesAU_ has quit IRC
 932019-07-29T08:10:16  *** JamesAU has quit IRC
 942019-07-29T08:20:33  *** bitcoin-git has joined #bitcoin-core-dev
 952019-07-29T08:20:33  <bitcoin-git> [bitcoin] sipsorcery opened pull request #16483: Updated python command in msvc readme (master...update_msvc_readme) https://github.com/bitcoin/bitcoin/pull/16483
 962019-07-29T08:20:34  *** bitcoin-git has left #bitcoin-core-dev
 972019-07-29T08:24:23  *** bitcoin-git has joined #bitcoin-core-dev
 982019-07-29T08:24:23  <bitcoin-git> [bitcoin] fanquake closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
 992019-07-29T08:24:25  *** bitcoin-git has left #bitcoin-core-dev
1002019-07-29T08:28:06  *** kljasdfvv has joined #bitcoin-core-dev
1012019-07-29T08:30:29  *** hebasto has joined #bitcoin-core-dev
1022019-07-29T08:36:09  *** DeanGuss has quit IRC
1032019-07-29T08:36:40  *** DeanGuss has joined #bitcoin-core-dev
1042019-07-29T08:37:55  *** queip has quit IRC
1052019-07-29T08:39:16  <jonasschnelli> hebasto: https://github.com/bitcoin/bitcoin/pull/16476,... 5 labels? :-)
1062019-07-29T08:39:40  <jonasschnelli> Draht added them... I see
1072019-07-29T08:40:39  <fanquake> jonasschnelli: sometimes the bot gets a bit out of control hah
1082019-07-29T08:43:48  *** queip has joined #bitcoin-core-dev
1092019-07-29T08:45:26  *** AaronvanW has quit IRC
1102019-07-29T08:45:42  *** AaronvanW has joined #bitcoin-core-dev
1112019-07-29T08:51:26  *** AaronvanW has quit IRC
1122019-07-29T08:55:29  *** JamesAU has joined #bitcoin-core-dev
1132019-07-29T08:58:34  *** JamesAU_ has joined #bitcoin-core-dev
1142019-07-29T08:59:11  *** JamesAU__ has quit IRC
1152019-07-29T09:00:01  *** Pysis|work has quit IRC
1162019-07-29T09:02:26  *** JamesAU has quit IRC
1172019-07-29T09:11:31  <jonasschnelli> sipa: the PR #16202 is a result of your NACK/comment in 14046. Appreciate your review. Thanks
1182019-07-29T09:11:34  <gribble> https://github.com/bitcoin/bitcoin/issues/16202 | Refactor network message deserialization by jonasschnelli · Pull Request #16202 · bitcoin/bitcoin · GitHub
1192019-07-29T09:13:10  *** mengu has joined #bitcoin-core-dev
1202019-07-29T09:13:33  *** mengu is now known as Guest2233
1212019-07-29T09:15:27  *** JamesAU has joined #bitcoin-core-dev
1222019-07-29T09:18:17  *** timothy has joined #bitcoin-core-dev
1232019-07-29T09:19:00  *** JamesAU_ has quit IRC
1242019-07-29T09:22:04  *** TheFuzzStone[m] has quit IRC
1252019-07-29T09:22:05  *** DavidMitchell[m] has quit IRC
1262019-07-29T09:22:07  *** tuirektiujm[m] has quit IRC
1272019-07-29T09:22:14  *** electric-sheep[m has quit IRC
1282019-07-29T09:22:17  *** kewde[m] has quit IRC
1292019-07-29T09:25:53  *** DeanGuss has quit IRC
1302019-07-29T09:26:52  *** DeanGuss has joined #bitcoin-core-dev
1312019-07-29T09:29:05  *** TheFuzzStone[m] has joined #bitcoin-core-dev
1322019-07-29T09:36:15  *** kewde[m] has joined #bitcoin-core-dev
1332019-07-29T09:36:15  *** tuirektiujm[m] has joined #bitcoin-core-dev
1342019-07-29T09:36:22  *** electric-sheep[m has joined #bitcoin-core-dev
1352019-07-29T09:36:23  *** DavidMitchell[m] has joined #bitcoin-core-dev
1362019-07-29T09:38:06  *** JamesAU has quit IRC
1372019-07-29T09:44:13  *** queip has quit IRC
1382019-07-29T09:51:01  *** queip has joined #bitcoin-core-dev
1392019-07-29T10:03:29  *** setpill has joined #bitcoin-core-dev
1402019-07-29T10:09:01  *** JamesAU has joined #bitcoin-core-dev
1412019-07-29T10:39:45  *** jonatack has quit IRC
1422019-07-29T10:46:04  *** JamesAU has quit IRC
1432019-07-29T10:55:14  *** shtirlic has quit IRC
1442019-07-29T10:56:15  *** shtirlic has joined #bitcoin-core-dev
1452019-07-29T11:03:43  *** dgfhdfg has joined #bitcoin-core-dev
1462019-07-29T11:13:20  *** DeanGuss has quit IRC
1472019-07-29T11:13:46  *** DeanGuss has joined #bitcoin-core-dev
1482019-07-29T11:17:57  *** emilengler has joined #bitcoin-core-dev
1492019-07-29T11:19:19  *** DeanGuss has quit IRC
1502019-07-29T11:59:36  *** rex4539 has quit IRC
1512019-07-29T12:00:02  *** Guest2233 has quit IRC
1522019-07-29T12:04:48  *** j3parker1 has joined #bitcoin-core-dev
1532019-07-29T12:16:48  *** bitcoin-git has joined #bitcoin-core-dev
1542019-07-29T12:16:48  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
1552019-07-29T12:16:56  *** bitcoin-git has left #bitcoin-core-dev
1562019-07-29T12:17:07  *** _Sam-- has joined #bitcoin-core-dev
1572019-07-29T12:18:13  *** bitcoin-git has joined #bitcoin-core-dev
1582019-07-29T12:18:13  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16458: Fix msvc compiler error C4146 (unary minus operator applied to unsigned type (0.17...fix-C4146-in-util-test) https://github.com/bitcoin/bitcoin/pull/16458
1592019-07-29T12:18:14  *** bitcoin-git has left #bitcoin-core-dev
1602019-07-29T12:22:28  *** bitcoin-git has joined #bitcoin-core-dev
1612019-07-29T12:22:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c2885f9b2e3...502ec0227290
1622019-07-29T12:22:29  <bitcoin-git> bitcoin/master fabfcb5 MarcoFalke: build: Treat -Wswitch as error when --enable-werror
1632019-07-29T12:22:29  <bitcoin-git> bitcoin/master 502ec02 MarcoFalke: Merge #16424: build: Treat -Wswitch as error when --enable-werror
1642019-07-29T12:22:31  *** bitcoin-git has left #bitcoin-core-dev
1652019-07-29T12:23:28  *** bitcoin-git has joined #bitcoin-core-dev
1662019-07-29T12:23:28  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16424: build: Treat -Wswitch as error when --enable-werror (master...1907-buildSwitchError) https://github.com/bitcoin/bitcoin/pull/16424
1672019-07-29T12:23:30  *** bitcoin-git has left #bitcoin-core-dev
1682019-07-29T12:27:59  *** setpill has quit IRC
1692019-07-29T12:28:30  *** setpill has joined #bitcoin-core-dev
1702019-07-29T12:28:45  *** goatpig has quit IRC
1712019-07-29T12:33:30  *** bitcoin-git has joined #bitcoin-core-dev
1722019-07-29T12:33:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16484: doc: Remove "trivial" label in CONTRIBUTING (master...1907-docNoTrivial) https://github.com/bitcoin/bitcoin/pull/16484
1732019-07-29T12:33:31  *** bitcoin-git has left #bitcoin-core-dev
1742019-07-29T12:44:28  *** esotericnonsense has quit IRC
1752019-07-29T12:47:23  *** AaronvanW has joined #bitcoin-core-dev
1762019-07-29T12:52:33  *** bitcoin-git has joined #bitcoin-core-dev
1772019-07-29T12:52:34  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/502ec0227290...f735851be294
1782019-07-29T12:52:34  <bitcoin-git> bitcoin/master 07e01d6 Jon Atack: rpc: sendrawtransaction unconditionality/privacy note
1792019-07-29T12:52:35  <bitcoin-git> bitcoin/master f735851 Wladimir J. van der Laan: Merge #16467: rpc: sendrawtransaction help privacy note
1802019-07-29T12:52:37  *** bitcoin-git has left #bitcoin-core-dev
1812019-07-29T12:53:33  *** bitcoin-git has joined #bitcoin-core-dev
1822019-07-29T12:53:33  <bitcoin-git> [bitcoin] laanwj merged pull request #16467: rpc: sendrawtransaction help privacy note (master...sendrawtransaction-privacy-note) https://github.com/bitcoin/bitcoin/pull/16467
1832019-07-29T12:53:34  *** bitcoin-git has left #bitcoin-core-dev
1842019-07-29T13:11:09  *** queip has quit IRC
1852019-07-29T13:17:25  *** queip has joined #bitcoin-core-dev
1862019-07-29T13:21:24  *** JamesAU has joined #bitcoin-core-dev
1872019-07-29T13:23:10  *** Kvaciral has quit IRC
1882019-07-29T13:26:31  *** promag has quit IRC
1892019-07-29T13:28:13  *** promag has joined #bitcoin-core-dev
1902019-07-29T13:33:44  *** bitcoin-git has joined #bitcoin-core-dev
1912019-07-29T13:33:44  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f735851be294...29220250c10e
1922019-07-29T13:33:45  <bitcoin-git> bitcoin/master 98a64bd fanquake: build: disable libjpeg in qt
1932019-07-29T13:33:45  <bitcoin-git> bitcoin/master 0aeb98a fanquake: build: remove jpeg lib check from bitcoin_qt.m4
1942019-07-29T13:33:46  <bitcoin-git> bitcoin/master 1bb1661 fanquake: doc: fix typo in bitcoin_qt.m4 comment
1952019-07-29T13:33:47  *** bitcoin-git has left #bitcoin-core-dev
1962019-07-29T13:34:45  *** bitcoin-git has joined #bitcoin-core-dev
1972019-07-29T13:34:45  <bitcoin-git> [bitcoin] laanwj merged pull request #16441: build: remove qt libjpeg check from bitcoin_qt.m4 (master...remove-qt-libjpeg-check) https://github.com/bitcoin/bitcoin/pull/16441
1982019-07-29T13:34:46  *** bitcoin-git has left #bitcoin-core-dev
1992019-07-29T13:38:00  *** bitcoin-git has joined #bitcoin-core-dev
2002019-07-29T13:38:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/29220250c10e...74ea1f3b0f26
2012019-07-29T13:38:01  <bitcoin-git> bitcoin/master 3199610 Fabian Jahr: Place out args at the end for CreateWallet
2022019-07-29T13:38:01  <bitcoin-git> bitcoin/master d6649d1 Fabian Jahr: Use strong enum for WalletCreationStatus
2032019-07-29T13:38:01  <bitcoin-git> bitcoin/master ba1f128 Fabian Jahr: Return error for ignored passphrase through disable private keys option
2042019-07-29T13:38:13  *** bitcoin-git has left #bitcoin-core-dev
2052019-07-29T13:39:00  *** bitcoin-git has joined #bitcoin-core-dev
2062019-07-29T13:39:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
2072019-07-29T13:39:01  *** bitcoin-git has left #bitcoin-core-dev
2082019-07-29T13:42:42  *** elichai2 has joined #bitcoin-core-dev
2092019-07-29T13:44:16  *** queip has quit IRC
2102019-07-29T13:50:19  *** queip has joined #bitcoin-core-dev
2112019-07-29T13:50:30  *** d_t has joined #bitcoin-core-dev
2122019-07-29T14:20:10  *** laptop500 has joined #bitcoin-core-dev
2132019-07-29T14:33:50  *** nijak_ has joined #bitcoin-core-dev
2142019-07-29T14:35:01  *** nijak has quit IRC
2152019-07-29T14:41:51  *** mdunnio has joined #bitcoin-core-dev
2162019-07-29T14:50:54  *** d_t has quit IRC
2172019-07-29T14:52:18  *** bitcoin-git has joined #bitcoin-core-dev
2182019-07-29T14:52:19  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/74ea1f3b0f26...b21acab82fe9
2192019-07-29T14:52:19  <bitcoin-git> bitcoin/master 9f76e45 Hennadii Stepanov: Drop support of insecure miniUPnPc versions
2202019-07-29T14:52:20  <bitcoin-git> bitcoin/master 91a1b85 Hennadii Stepanov: Use PACKAGE_NAME in UPnP description
2212019-07-29T14:52:21  <bitcoin-git> bitcoin/master 02709e9 Hennadii Stepanov: Align formatting with clang-format
2222019-07-29T14:52:22  *** bitcoin-git has left #bitcoin-core-dev
2232019-07-29T14:53:02  *** bitcoin-git has joined #bitcoin-core-dev
2242019-07-29T14:53:03  <bitcoin-git> [bitcoin] laanwj merged pull request #15993: net: Drop support of the insecure miniUPnPc versions (master...20190506-drop-ancient-miniupnpc-api) https://github.com/bitcoin/bitcoin/pull/15993
2252019-07-29T14:53:13  *** bitcoin-git has left #bitcoin-core-dev
2262019-07-29T14:54:04  <sdaftuar> hi all, if anyone is interested in reviewing or even just testing #15759 i'd appreciate it, as i think it'd be best if p2p changes like this simmer in master with plenty of time before a new release in case of bugs or unintended side effects
2272019-07-29T14:54:08  <gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
2282019-07-29T14:54:33  *** mdunnio has quit IRC
2292019-07-29T14:55:12  *** mdunnio has joined #bitcoin-core-dev
2302019-07-29T14:58:11  *** profmac has quit IRC
2312019-07-29T14:58:39  *** kristapsk_ has joined #bitcoin-core-dev
2322019-07-29T14:59:58  *** mdunnio has quit IRC
2332019-07-29T15:00:02  *** j3parker1 has quit IRC
2342019-07-29T15:01:20  *** kristapsk has quit IRC
2352019-07-29T15:02:02  *** mdunnio has joined #bitcoin-core-dev
2362019-07-29T15:19:24  *** bitcoin-git has joined #bitcoin-core-dev
2372019-07-29T15:19:25  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b21acab82fe9...2a7c3bc498b5
2382019-07-29T15:19:25  <bitcoin-git> bitcoin/master 4057b7a Hennadii Stepanov: wallet: Recognize -disablewallet option early
2392019-07-29T15:19:25  <bitcoin-git> bitcoin/master 2a7c3bc Wladimir J. van der Laan: Merge #16436: gui: Do not create payment server if -disablewallet option p...
2402019-07-29T15:19:37  *** bitcoin-git has left #bitcoin-core-dev
2412019-07-29T15:19:42  <wumpus> sdaftuar: agreed
2422019-07-29T15:19:57  *** |Kin| has joined #bitcoin-core-dev
2432019-07-29T15:20:24  *** bitcoin-git has joined #bitcoin-core-dev
2442019-07-29T15:20:24  <bitcoin-git> [bitcoin] laanwj merged pull request #16436: gui: Do not create payment server if -disablewallet option provided (master...20190722-payment-server) https://github.com/bitcoin/bitcoin/pull/16436
2452019-07-29T15:20:37  *** bitcoin-git has left #bitcoin-core-dev
2462019-07-29T15:24:16  *** profmac has joined #bitcoin-core-dev
2472019-07-29T15:31:19  <sdaftuar> sipa: wumpus: any thoughts on the issue described in #16444? seems like an annoying problem to fix
2482019-07-29T15:31:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16444 | Assertion `setBlockIndexCandidates.count(pindex) failed · Issue #16444 · bitcoin/bitcoin · GitHub
2492019-07-29T15:32:54  <sdaftuar> i think if we want to maintain the invariants we've historically had and not change CheckBlockIndex() at all, then we could add some more code to InvalidateBlock() so that everything works as it used to.
2502019-07-29T15:32:55  *** kljasdfvv has quit IRC
2512019-07-29T15:33:31  <sdaftuar> it just seems a bit tedious and it's not totally clear to me that it's important to maintain our usual invariants in this one specific case
2522019-07-29T15:39:29  *** anemous has joined #bitcoin-core-dev
2532019-07-29T15:55:25  *** anemous has quit IRC
2542019-07-29T16:00:18  *** mdunnio has quit IRC
2552019-07-29T16:05:21  *** mdunnio has joined #bitcoin-core-dev
2562019-07-29T16:11:38  *** dgfhdfg has quit IRC
2572019-07-29T16:20:22  *** lightlike has joined #bitcoin-core-dev
2582019-07-29T16:29:00  *** dgfhdfg has joined #bitcoin-core-dev
2592019-07-29T16:34:04  *** sfhi has joined #bitcoin-core-dev
2602019-07-29T16:37:00  *** mdunnio has quit IRC
2612019-07-29T16:39:09  *** roconnor has joined #bitcoin-core-dev
2622019-07-29T16:48:37  *** setpill has quit IRC
2632019-07-29T16:52:32  *** mdunnio has joined #bitcoin-core-dev
2642019-07-29T16:55:50  *** bitcoin-git has joined #bitcoin-core-dev
2652019-07-29T16:55:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a7c3bc498b5...68da54987df4
2662019-07-29T16:55:51  <bitcoin-git> bitcoin/master 42a5e91 John Newbery: [mempool] log correct messages when CPFP fails
2672019-07-29T16:55:51  <bitcoin-git> bitcoin/master 68da549 Wladimir J. van der Laan: Merge #16471: [mempool] log correct messages when CPFP fails
2682019-07-29T16:55:55  *** bitcoin-git has left #bitcoin-core-dev
2692019-07-29T16:56:50  *** bitcoin-git has joined #bitcoin-core-dev
2702019-07-29T16:56:50  <bitcoin-git> [bitcoin] laanwj merged pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
2712019-07-29T16:56:52  *** bitcoin-git has left #bitcoin-core-dev
2722019-07-29T16:57:28  *** mdunnio has quit IRC
2732019-07-29T16:59:40  *** roconnor has quit IRC
2742019-07-29T17:00:55  *** roconnor has joined #bitcoin-core-dev
2752019-07-29T17:08:43  *** mdunnio has joined #bitcoin-core-dev
2762019-07-29T17:13:03  *** sfhi2 has joined #bitcoin-core-dev
2772019-07-29T17:13:07  *** mdunnio has quit IRC
2782019-07-29T17:17:28  *** sfhi has quit IRC
2792019-07-29T17:19:03  *** mdunnio has joined #bitcoin-core-dev
2802019-07-29T17:21:09  *** pinheadmz has quit IRC
2812019-07-29T17:21:15  *** pinheadmz_ has joined #bitcoin-core-dev
2822019-07-29T17:24:46  *** ezegom has joined #bitcoin-core-dev
2832019-07-29T17:28:32  *** sipa has quit IRC
2842019-07-29T17:34:11  *** sipa has joined #bitcoin-core-dev
2852019-07-29T17:34:52  *** fasdlkfjaslkfj has joined #bitcoin-core-dev
2862019-07-29T17:35:29  *** jonatack has joined #bitcoin-core-dev
2872019-07-29T17:36:10  *** fasdlkfjaslkfj has quit IRC
2882019-07-29T17:39:59  *** bitcoin-git has joined #bitcoin-core-dev
2892019-07-29T17:39:59  <bitcoin-git> [bitcoin] pstratem opened pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
2902019-07-29T17:40:02  *** bitcoin-git has left #bitcoin-core-dev
2912019-07-29T17:43:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2922019-07-29T17:57:38  *** ezegom has quit IRC
2932019-07-29T17:58:00  *** ezegom has joined #bitcoin-core-dev
2942019-07-29T18:00:00  *** bitcoin-git has joined #bitcoin-core-dev
2952019-07-29T18:00:00  <bitcoin-git> [bitcoin] jamesob opened pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
2962019-07-29T18:00:01  *** bitcoin-git has left #bitcoin-core-dev
2972019-07-29T18:00:04  *** |Kin| has quit IRC
2982019-07-29T18:04:10  *** josef641 has joined #bitcoin-core-dev
2992019-07-29T18:04:48  *** mdunnio has quit IRC
3002019-07-29T18:06:24  *** jarthur has joined #bitcoin-core-dev
3012019-07-29T18:12:19  *** jarthur has quit IRC
3022019-07-29T18:14:05  *** mdunnio has joined #bitcoin-core-dev
3032019-07-29T18:15:48  *** dgfhdfg has quit IRC
3042019-07-29T18:17:29  *** dgfhdfg has joined #bitcoin-core-dev
3052019-07-29T18:17:39  *** ezegom has quit IRC
3062019-07-29T18:18:14  *** ezegom has joined #bitcoin-core-dev
3072019-07-29T18:18:40  *** belcher has joined #bitcoin-core-dev
3082019-07-29T18:21:23  *** reallll has quit IRC
3092019-07-29T18:22:33  *** ezegom has quit IRC
3102019-07-29T18:24:13  *** ezegom has joined #bitcoin-core-dev
3112019-07-29T18:47:41  *** JamesAU has quit IRC
3122019-07-29T18:48:22  <phantomcircuit> also the TODO in the BIP30 logic while not exactly immediate should be looked into
3132019-07-29T19:06:30  *** captjakk_ has quit IRC
3142019-07-29T19:21:52  *** Victor_sueca has joined #bitcoin-core-dev
3152019-07-29T19:21:58  *** Victorsueca has quit IRC
3162019-07-29T19:30:36  *** bitcoin-git has joined #bitcoin-core-dev
3172019-07-29T19:30:36  <bitcoin-git> [bitcoin] jonatack opened pull request #16489: log: update bitcoind daemon logging (master...daemon-logging-harmonisation) https://github.com/bitcoin/bitcoin/pull/16489
3182019-07-29T19:30:49  *** bitcoin-git has left #bitcoin-core-dev
3192019-07-29T19:38:27  *** ezegom has quit IRC
3202019-07-29T19:39:01  *** ezegom has joined #bitcoin-core-dev
3212019-07-29T19:40:40  *** ezegom has joined #bitcoin-core-dev
3222019-07-29T19:42:44  *** captjakk has joined #bitcoin-core-dev
3232019-07-29T19:45:45  *** captjakk has quit IRC
3242019-07-29T19:46:18  *** captjakk has joined #bitcoin-core-dev
3252019-07-29T19:50:37  *** captjakk has quit IRC
3262019-07-29T19:51:44  *** captjakk has joined #bitcoin-core-dev
3272019-07-29T19:53:02  *** davterra has joined #bitcoin-core-dev
3282019-07-29T20:00:33  *** davterra has quit IRC
3292019-07-29T20:06:31  *** sfhi2 has quit IRC
3302019-07-29T20:06:37  *** EagleTM has joined #bitcoin-core-dev
3312019-07-29T20:14:23  *** davterra has joined #bitcoin-core-dev
3322019-07-29T20:18:44  *** timothy has quit IRC
3332019-07-29T20:31:21  *** promag has quit IRC
3342019-07-29T20:41:56  *** mdunnio has quit IRC
3352019-07-29T20:44:26  *** sblinn has joined #bitcoin-core-dev
3362019-07-29T20:49:40  *** mdunnio has joined #bitcoin-core-dev
3372019-07-29T20:51:32  *** bitcoin-git has joined #bitcoin-core-dev
3382019-07-29T20:51:32  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
3392019-07-29T20:51:33  *** bitcoin-git has left #bitcoin-core-dev
3402019-07-29T21:00:01  *** josef641 has quit IRC
3412019-07-29T21:02:58  *** ezegom has quit IRC
3422019-07-29T21:03:31  *** ezegom has joined #bitcoin-core-dev
3432019-07-29T21:04:51  *** VitamineD has joined #bitcoin-core-dev
3442019-07-29T21:04:53  *** ezegom has joined #bitcoin-core-dev
3452019-07-29T21:08:40  *** Chris_Stewart_5 has quit IRC
3462019-07-29T21:14:30  *** Guyver2 has quit IRC
3472019-07-29T21:15:08  *** ezegom has quit IRC
3482019-07-29T21:19:39  *** sblinn has quit IRC
3492019-07-29T21:28:37  *** bitcoin-git has joined #bitcoin-core-dev
3502019-07-29T21:28:37  <bitcoin-git> [bitcoin] jonatack opened pull request #16491: qa: fix deprecated log.warn in feature_dbcrash test (master...test-fix-feature_dbcrash-warn-deprecation) https://github.com/bitcoin/bitcoin/pull/16491
3512019-07-29T21:28:45  *** bitcoin-git has left #bitcoin-core-dev
3522019-07-29T21:31:01  *** michagogo has joined #bitcoin-core-dev
3532019-07-29T21:46:27  <sipa> jonasschnelli, BlueMatt: about v2 transport and the question on how to encode the message types. given that 12 bytes is complete overkill anyway, i wonder if an alternative to shortcuts+variable length as proposed currently, it wouldn't be easier to just shrink the message type field; it turns out that first 2 characters + last 2 characters of every message name is unique currently
3542019-07-29T21:46:57  <BlueMatt> why?
3552019-07-29T21:47:07  <BlueMatt> just use the current one-byte proposal with a fallback to 12 bytes?
3562019-07-29T21:47:18  <BlueMatt> or fallback to, I dunno, 8 bytes? whatever you want
3572019-07-29T21:47:22  <sipa> that's also a possibility, but harder to extend
3582019-07-29T21:47:32  <BlueMatt> is it?
3592019-07-29T21:48:06  <sipa> as in: the shortening will only be available to a select number of messages, and probably need a lot of coordination to avoid collisions between them
3602019-07-29T21:48:50  <BlueMatt> a lot of coordination? as in te bip process?
3612019-07-29T21:48:54  <sipa> right
3622019-07-29T21:49:02  <BlueMatt> that seems reasonable to me.
3632019-07-29T21:49:18  <sipa> string messages are unlikely to collide, for 1-byte types you really need to assign sequentially
3642019-07-29T21:49:53  <BlueMatt> how about 8 bytes and you must use the time of when you selected the message :p
3652019-07-29T21:49:55  <sipa> while 4-byte messages for everything doesn't have this problem, is even simpler to implement, gets you most of the savings, and is backward compatible
3662019-07-29T21:50:16  <BlueMatt> ok, or 4 byte message types and you must use the time of when you selected the message mod 2**32 :p
3672019-07-29T21:50:45  <sipa> that could totally work
3682019-07-29T21:51:03  <BlueMatt> I prefer that infinitely over a variable-length message type anyway
3692019-07-29T21:51:26  <sipa> infinity is a lot
3702019-07-29T21:52:31  *** ezegom has joined #bitcoin-core-dev
3712019-07-29T21:53:57  <BlueMatt> YUGE
3722019-07-29T21:55:01  <sipa> filterclear would become "feer".
3732019-07-29T21:55:26  <BlueMatt> limiting to common-char-lower-case-ascii seems like a waste of 4 bytes, but, whatever
3742019-07-29T21:55:41  <sipa> it is; for v2-only messages that restriction wouldn't be needed
3752019-07-29T21:55:58  <sipa> actually it's need needed at all, agree
3762019-07-29T21:58:02  <sipa> or we could use SHA256(message)[0:4] :p
3772019-07-29T21:58:15  <sipa> oh no, double-SHA256(message)[0:4], satoshi style
3782019-07-29T21:59:17  <BlueMatt> rot13(rot13(message))
3792019-07-29T22:00:54  <sipa> i'm only half joking; using a hash function or CRC or so as mapping from string names to 4-byte message type ids has hardly any downsides i think
3802019-07-29T22:01:01  <BlueMatt> true
3812019-07-29T22:01:15  <sipa> an actual implementation wouldn't actually compute the hashes; they'd just be precomputed for every message type
3822019-07-29T22:01:23  <BlueMatt> sure, of course
3832019-07-29T22:01:58  <sipa> anyway, let's see what jonasschnelli thinks
3842019-07-29T22:04:53  <hugohn> sipa: do you think it makes sense for descriptor.cpp->Parse() to return the output type of the descriptor string, along with the Signing Provider? I'm trying to infer the output type through other means without touching descriptor.h/.cpp. But Expand() doesn't work as intermediate redeem scripts are no longer saved to memory with native descriptor wallets (so you can’t peek into them). And string pattern matching
3852019-07-29T22:04:53  <hugohn> (e.g. matching against `"sh(wsh"`) is ugly IMO.
3862019-07-29T22:05:34  <sipa> hugohn: what is 'output type' ?
3872019-07-29T22:06:35  <sipa> and i don't understand why Expand doesn't work
3882019-07-29T22:06:59  *** booyah has quit IRC
3892019-07-29T22:07:06  <sipa> oh, output type as in address type
3902019-07-29T22:07:07  <sipa> hmm
3912019-07-29T22:07:26  <sipa> what about raw multisig, or combo? those don't have a well-defined output type
3922019-07-29T22:07:27  <hugohn> https://github.com/bitcoin/bitcoin/blob/master/src/outputtype.h#L16
3932019-07-29T22:07:39  *** booyah has joined #bitcoin-core-dev
3942019-07-29T22:07:44  *** mdunnio has quit IRC
3952019-07-29T22:07:52  <hugohn> the "buckets" used in the refactored wallet
3962019-07-29T22:10:54  <sipa> Expand() + ExtractDestination should work, i think
3972019-07-29T22:11:26  <sipa> and you should always be able to call Expand on descriptors in the wallet, otherwise how would you participate in signing?
3982019-07-29T22:11:56  <sipa> and you don't need the intermediate redeemscript; just ExtractDestination on the output scriptPubKey should be sufficient
3992019-07-29T22:12:00  <sipa> i may be missing things :)
4002019-07-29T22:13:02  <hugohn> yeah I can call Expand just fine :D my problem is distinguishing between a legacy P2SH & a P2SH-Segwit
4012019-07-29T22:13:31  <sipa> there shouldn't be a need to distinguish between those
4022019-07-29T22:13:51  <sipa> if the sender supports P2SH, he will support both
4032019-07-29T22:13:56  <sipa> as he obviously can't distinguish
4042019-07-29T22:14:38  <sipa> output types currently distinguish between them, as that what the mechanism to determine whether you wanted to use segwit in the wallet or not
4052019-07-29T22:14:57  <sipa> but in a post-descriptor world, i think that distinction would simply be made by having a segwit descriptor or not
4062019-07-29T22:16:20  <hugohn> right, it doesn't make a difference to the user, but I believe in achow101 's proposed new wallet architecture, we would have different scriptPubKeyManager(s) for each of the 3 output types: LEGACY, P2SH_SEGWIT (wrapped Segwit), and BECH32.
4072019-07-29T22:16:51  <sipa> right, and you need a sanity check when creating a new descriptor?
4082019-07-29T22:16:59  *** mdunnio has joined #bitcoin-core-dev
4092019-07-29T22:17:04  <sipa> that the descriptor is compatible with that type
4102019-07-29T22:17:06  <sipa> ?
4112019-07-29T22:26:00  *** mdunnio has quit IRC
4122019-07-29T22:26:06  <achow101> Yes
4132019-07-29T22:26:46  *** mdunnio has joined #bitcoin-core-dev
4142019-07-29T22:26:54  <sipa> arguably we should just get rid of the distinction between P2SH and P2SH-Segwit
4152019-07-29T22:27:53  <achow101> I wrote a function that used the Solver + a SigningProvider in order to determine the address type, but apparently that doesn't work since the p2sh-segwit redeemScript is not put in the SigningProvider by Descriptor Expand or Parse
4162019-07-29T22:27:53  <sipa> though perhaps that's not something to do simultaneously
4172019-07-29T22:28:09  <sipa> hmm, really?
4182019-07-29T22:28:20  <sipa> Expand should put it there
4192019-07-29T22:28:49  <achow101> That's what I thought, but hugohn told me it isn't (haven't had the chance to check)
4202019-07-29T22:29:10  <sipa> that sounds like a major issue if it isn't
4212019-07-29T22:29:52  <sipa> https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L461
4222019-07-29T22:29:55  <hugohn> https://www.irccloud.com/pastebin/NoBXcIt6/ExpandHelper
4232019-07-29T22:30:15  *** ezegom has quit IRC
4242019-07-29T22:31:44  <sipa> hugohn: yes?
4252019-07-29T22:32:43  <hugohn> sorry ignore that snippet. I missed that line you posted above, looks like the redeem script is saved to the Signing Provider.
4262019-07-29T22:33:25  <sipa> hugohn: in general no information should get lost through an Expand
4272019-07-29T22:33:27  <hugohn> then I don't understand why when we look up for the redeemScript later, we don't find it, hmm...
4282019-07-29T22:33:50  <sipa> otherwise InferDescriptor wouldn't be able to reconstruct things
4292019-07-29T22:33:55  <sipa> which afaik has a test
4302019-07-29T22:34:01  *** mdunnio has quit IRC
4312019-07-29T22:37:29  <elichai2> hugohn: maybe it wasn't expanded yet?
4322019-07-29T22:39:15  <hugohn> elichai2: no I made sure it was expanded
4332019-07-29T22:43:07  <hugohn> code for more context: https://github.com/achow101/bitcoin/pull/4/files#diff-b2bb174788c7409b671c46ccc86034bdR4273
4342019-07-29T22:43:17  <hugohn> I'm not getting the correct output type by peeking into an address generated by Expand() here^
4352019-07-29T22:49:45  *** luke-jr has quit IRC
4362019-07-29T22:51:51  *** luke-jr has joined #bitcoin-core-dev
4372019-07-29T22:52:19  <hugohn> implementation for DetermineOutputType: https://github.com/achow101/bitcoin/blob/wallet-of-the-glorious-future/src/outputtype.cpp#L126
4382019-07-29T22:52:48  <hugohn> `provider.GetCScript()` fails to look up the redeem script given the script ID
4392019-07-29T22:56:56  *** ezegom has joined #bitcoin-core-dev
4402019-07-29T22:57:56  <hugohn> nway, very likely I'm doing something wrong, will investigate further. thanks sipa!
4412019-07-29T22:59:59  *** jonatack has quit IRC
4422019-07-29T23:00:26  *** luke-jr has quit IRC
4432019-07-29T23:00:53  *** dgfhdfg has quit IRC
4442019-07-29T23:01:24  <sipa> hugohn: add some debug statements that print the contents of the SigningProvider before calling the code to determine output type
4452019-07-29T23:01:34  *** luke-jr has joined #bitcoin-core-dev
4462019-07-29T23:03:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4472019-07-29T23:04:01  *** ezegom has quit IRC
4482019-07-29T23:06:06  <hugohn> sipa: yes I'm adding printf eveywhere lol. will try that next!
4492019-07-29T23:10:35  *** rex4539 has joined #bitcoin-core-dev
4502019-07-29T23:11:32  *** dviola has joined #bitcoin-core-dev
4512019-07-29T23:20:03  *** Chris_Stewart_5 has quit IRC
4522019-07-29T23:25:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4532019-07-29T23:36:13  *** mdunnio has joined #bitcoin-core-dev
4542019-07-29T23:37:28  *** mdunnio has quit IRC
4552019-07-29T23:38:13  *** lightlike has quit IRC
4562019-07-29T23:39:26  *** mdunnio has joined #bitcoin-core-dev
4572019-07-29T23:46:19  *** ezegom has joined #bitcoin-core-dev