12019-08-02T00:00:01  *** afb has quit IRC
  22019-08-02T00:00:56  <emilengler> Is there a cmake file for bitcoin core?
  32019-08-02T00:00:59  *** promag_ has joined #bitcoin-core-dev
  42019-08-02T00:01:16  *** promag has quit IRC
  52019-08-02T00:04:05  *** rob01 has joined #bitcoin-core-dev
  62019-08-02T00:04:37  <sipa> emilengler: it's an autotools project
  72019-08-02T00:05:13  <fanquake> hebasto: looks like ipglider hasn't been on GH for a while. I'm going to close #15768 as "Up for grabs", feel free to pick it up if interested.
  82019-08-02T00:05:15  <gribble> https://github.com/bitcoin/bitcoin/issues/15768 | gui: Add CMD+W shortcut in macOS by IPGlider · Pull Request #15768 · bitcoin/bitcoin · GitHub
  92019-08-02T00:06:06  *** bitcoin-git has joined #bitcoin-core-dev
 102019-08-02T00:06:06  <bitcoin-git> [bitcoin] fanquake closed pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
 112019-08-02T00:06:08  *** bitcoin-git has left #bitcoin-core-dev
 122019-08-02T00:09:15  *** lightlike has quit IRC
 132019-08-02T00:12:44  *** ezegom has joined #bitcoin-core-dev
 142019-08-02T00:14:08  *** felco has joined #bitcoin-core-dev
 152019-08-02T00:17:07  *** ezegom has quit IRC
 162019-08-02T00:22:07  *** AaronvanW has joined #bitcoin-core-dev
 172019-08-02T00:26:04  <emilengler> In which function/file are the blocks writen to the disk?
 182019-08-02T00:26:08  <emilengler> written*
 192019-08-02T00:26:43  *** AaronvanW has quit IRC
 202019-08-02T00:31:07  *** felco has quit IRC
 212019-08-02T00:31:07  *** felco has joined #bitcoin-core-dev
 222019-08-02T00:32:41  *** felco has quit IRC
 232019-08-02T00:33:08  *** felco has joined #bitcoin-core-dev
 242019-08-02T00:33:41  *** felco has joined #bitcoin-core-dev
 252019-08-02T00:36:26  <mryandao> emilengler: src/validation.cpp:1635 FlushBlockFile.
 262019-08-02T00:36:32  <mryandao> I think.
 272019-08-02T00:37:28  <mryandao> there's a lot of flushing going on in validation.cp
 282019-08-02T00:59:19  *** emilengler has quit IRC
 292019-08-02T00:59:31  *** ptiyoyip has quit IRC
 302019-08-02T01:03:13  *** emilengler has joined #bitcoin-core-dev
 312019-08-02T01:03:30  *** AaronvanW has joined #bitcoin-core-dev
 322019-08-02T01:08:28  *** dgfhdfg has joined #bitcoin-core-dev
 332019-08-02T01:10:59  *** ezegom has joined #bitcoin-core-dev
 342019-08-02T01:11:47  *** pinheadmz has quit IRC
 352019-08-02T01:15:18  *** liberiga has quit IRC
 362019-08-02T01:23:57  *** ezegom has quit IRC
 372019-08-02T01:24:24  *** ezegom has joined #bitcoin-core-dev
 382019-08-02T01:27:22  *** ezegom has quit IRC
 392019-08-02T01:27:30  *** ezegom has joined #bitcoin-core-dev
 402019-08-02T01:37:02  *** AaronvanW has quit IRC
 412019-08-02T01:37:32  *** ezegom has quit IRC
 422019-08-02T01:39:07  *** ezegom has joined #bitcoin-core-dev
 432019-08-02T01:40:25  *** mzygar has joined #bitcoin-core-dev
 442019-08-02T01:44:11  *** tryphe has quit IRC
 452019-08-02T01:44:28  *** mzygar has quit IRC
 462019-08-02T01:44:40  *** tryphe has joined #bitcoin-core-dev
 472019-08-02T01:49:38  *** justanotheruser has joined #bitcoin-core-dev
 482019-08-02T01:51:53  *** ezegom has quit IRC
 492019-08-02T01:53:39  *** ezegom has joined #bitcoin-core-dev
 502019-08-02T01:54:49  *** rex4539 has joined #bitcoin-core-dev
 512019-08-02T01:59:59  *** ezegom has quit IRC
 522019-08-02T02:00:37  *** ezegom has joined #bitcoin-core-dev
 532019-08-02T02:01:54  *** bitcoin-git has joined #bitcoin-core-dev
 542019-08-02T02:01:54  <bitcoin-git> [bitcoin] achow101 opened pull request #16528: [WIP] Native Descriptor Wallets (take 2) (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/16528
 552019-08-02T02:01:56  *** bitcoin-git has left #bitcoin-core-dev
 562019-08-02T02:02:04  <achow101> meshcollider: ^^^
 572019-08-02T02:10:25  *** elichai2 has quit IRC
 582019-08-02T02:18:56  *** rex4539 has quit IRC
 592019-08-02T02:25:03  *** ezegom has quit IRC
 602019-08-02T02:31:50  *** ezegom has joined #bitcoin-core-dev
 612019-08-02T02:37:10  *** captjakk has joined #bitcoin-core-dev
 622019-08-02T02:49:11  *** ezegom has quit IRC
 632019-08-02T02:49:56  *** bitcoin-git has joined #bitcoin-core-dev
 642019-08-02T02:49:56  <bitcoin-git> [bitcoin] Tech1k opened pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530
 652019-08-02T02:50:00  *** bitcoin-git has left #bitcoin-core-dev
 662019-08-02T03:00:02  *** rob01 has quit IRC
 672019-08-02T03:04:23  *** Kater1 has joined #bitcoin-core-dev
 682019-08-02T03:10:24  *** ezegom has joined #bitcoin-core-dev
 692019-08-02T03:14:53  *** ezegom has quit IRC
 702019-08-02T03:25:37  <meshcollider> achow101: \o/
 712019-08-02T03:28:28  *** captjakk has quit IRC
 722019-08-02T03:28:43  *** captjakk has joined #bitcoin-core-dev
 732019-08-02T03:29:14  *** captjakk has quit IRC
 742019-08-02T03:29:31  *** captjakk has joined #bitcoin-core-dev
 752019-08-02T03:30:18  *** captjakk has joined #bitcoin-core-dev
 762019-08-02T03:31:05  *** captjakk has joined #bitcoin-core-dev
 772019-08-02T03:31:51  *** captjakk has joined #bitcoin-core-dev
 782019-08-02T03:32:33  *** captjakk has joined #bitcoin-core-dev
 792019-08-02T03:33:05  *** captjakk has quit IRC
 802019-08-02T03:33:20  *** captjakk has joined #bitcoin-core-dev
 812019-08-02T03:34:08  *** captjakk has joined #bitcoin-core-dev
 822019-08-02T03:34:10  *** AaronvanW has joined #bitcoin-core-dev
 832019-08-02T03:34:37  *** captjakk has quit IRC
 842019-08-02T03:34:53  *** captjakk has joined #bitcoin-core-dev
 852019-08-02T03:39:28  *** captjakk has joined #bitcoin-core-dev
 862019-08-02T03:44:31  *** captjakk has quit IRC
 872019-08-02T03:48:52  *** bitcoin-git has joined #bitcoin-core-dev
 882019-08-02T03:48:52  <bitcoin-git> [bitcoin] harding opened pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532
 892019-08-02T03:48:54  *** bitcoin-git has left #bitcoin-core-dev
 902019-08-02T04:06:58  *** hebasto has quit IRC
 912019-08-02T04:07:35  *** AaronvanW has quit IRC
 922019-08-02T04:09:33  *** emilengler has quit IRC
 932019-08-02T04:11:22  *** captjakk has joined #bitcoin-core-dev
 942019-08-02T04:13:27  <fanquake> If anyone's interested, I've put up some notes about doing bitcoin* binary comparisons: https://github.com/fanquake/core-review/blob/master/binary-compare.md
 952019-08-02T04:19:11  *** justanotheruser has quit IRC
 962019-08-02T04:30:06  *** justanotheruser has joined #bitcoin-core-dev
 972019-08-02T04:37:17  *** bitcoin-git has joined #bitcoin-core-dev
 982019-08-02T04:37:17  <bitcoin-git> [bitcoin] fanquake opened pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
 992019-08-02T04:37:18  *** bitcoin-git has left #bitcoin-core-dev
1002019-08-02T04:43:58  *** captjakk has quit IRC
1012019-08-02T05:04:49  *** Krellan has joined #bitcoin-core-dev
1022019-08-02T05:06:33  *** Krellan has quit IRC
1032019-08-02T05:07:25  *** Krellan has joined #bitcoin-core-dev
1042019-08-02T05:16:36  *** captjakk has joined #bitcoin-core-dev
1052019-08-02T05:40:42  *** mzygar has joined #bitcoin-core-dev
1062019-08-02T05:45:02  *** mzygar has quit IRC
1072019-08-02T05:49:52  *** captjakk has quit IRC
1082019-08-02T05:50:56  *** Krellan has quit IRC
1092019-08-02T05:51:06  <wumpus> fanquake: yes, I think that's very useful to write those things up on how to find what is causing the non-determinism
1102019-08-02T06:00:02  *** Kater1 has quit IRC
1112019-08-02T06:04:47  *** AaronvanW has joined #bitcoin-core-dev
1122019-08-02T06:15:12  <wumpus> how to recognize this qt resource non-determism issue, for ex :)
1132019-08-02T06:17:28  <fanquake> wumpus: heh. From now on if I ever see what looks like language codes in a binary diff that's probably it.
1142019-08-02T06:18:01  *** rh0nj has quit IRC
1152019-08-02T06:19:09  *** rh0nj has joined #bitcoin-core-dev
1162019-08-02T06:19:16  *** Xing` has joined #bitcoin-core-dev
1172019-08-02T06:19:19  <fanquake> wumpus: #16532 in then tag 0.18.1 ?
1182019-08-02T06:19:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16532 | [0.18] Doc: remove old release notes about systemd and riscv changes by harding · Pull Request #16532 · bitcoin/bitcoin · GitHub
1192019-08-02T06:23:57  *** captjakk has joined #bitcoin-core-dev
1202019-08-02T06:24:24  <fanquake> Moved #16414 to 0.18.2
1212019-08-02T06:24:25  <gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
1222019-08-02T06:37:08  *** AaronvanW has quit IRC
1232019-08-02T06:38:49  *** bitcoin-git has joined #bitcoin-core-dev
1242019-08-02T06:38:49  <bitcoin-git> [bitcoin] fanquake reopened pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
1252019-08-02T06:38:52  *** bitcoin-git has left #bitcoin-core-dev
1262019-08-02T06:42:11  *** octomatic has joined #bitcoin-core-dev
1272019-08-02T06:47:16  *** octomatic has quit IRC
1282019-08-02T06:48:39  *** kcalvinalvin has joined #bitcoin-core-dev
1292019-08-02T06:52:51  *** octomati_ has joined #bitcoin-core-dev
1302019-08-02T06:56:12  *** victorSN has joined #bitcoin-core-dev
1312019-08-02T06:57:32  *** captjakk has quit IRC
1322019-08-02T07:01:09  *** AaronvanW has joined #bitcoin-core-dev
1332019-08-02T07:03:30  *** kcalvinalvin has quit IRC
1342019-08-02T07:05:01  *** AaronvanW has quit IRC
1352019-08-02T07:05:16  *** AaronvanW has joined #bitcoin-core-dev
1362019-08-02T07:12:57  *** octomati_ has quit IRC
1372019-08-02T07:34:36  *** captjakk has joined #bitcoin-core-dev
1382019-08-02T07:40:27  *** rex4539 has joined #bitcoin-core-dev
1392019-08-02T07:50:51  *** mzygar has joined #bitcoin-core-dev
1402019-08-02T07:51:17  *** justanotheruser has quit IRC
1412019-08-02T08:07:08  *** captjakk has quit IRC
1422019-08-02T08:11:32  *** jungly has quit IRC
1432019-08-02T08:12:34  *** jungly has joined #bitcoin-core-dev
1442019-08-02T08:34:04  *** Zenton has joined #bitcoin-core-dev
1452019-08-02T08:37:47  *** captjakk has joined #bitcoin-core-dev
1462019-08-02T08:52:06  *** justanotheruser has joined #bitcoin-core-dev
1472019-08-02T09:00:02  *** Xing` has quit IRC
1482019-08-02T09:04:39  *** theStack has joined #bitcoin-core-dev
1492019-08-02T09:04:55  *** DragonEyes1 has joined #bitcoin-core-dev
1502019-08-02T09:06:28  *** setpill has joined #bitcoin-core-dev
1512019-08-02T09:10:36  *** captjakk has quit IRC
1522019-08-02T09:12:08  *** bitcoin-git has joined #bitcoin-core-dev
1532019-08-02T09:12:08  <bitcoin-git> [bitcoin] Bushstar opened pull request #16534: [build] .gitignore add Qt Creator Makefile.am.user (master...patch-3) https://github.com/bitcoin/bitcoin/pull/16534
1542019-08-02T09:12:10  *** bitcoin-git has left #bitcoin-core-dev
1552019-08-02T09:14:47  *** inersha has joined #bitcoin-core-dev
1562019-08-02T09:24:47  *** theStack has quit IRC
1572019-08-02T09:25:44  *** belcher has joined #bitcoin-core-dev
1582019-08-02T09:26:04  *** Guyver2 has joined #bitcoin-core-dev
1592019-08-02T09:29:19  *** mzygar has quit IRC
1602019-08-02T09:35:05  *** timothy has joined #bitcoin-core-dev
1612019-08-02T09:36:42  *** jonatack has quit IRC
1622019-08-02T09:36:59  *** mzygar has joined #bitcoin-core-dev
1632019-08-02T09:45:58  *** captjakk has joined #bitcoin-core-dev
1642019-08-02T09:55:09  <setpill> in https://github.com/bitcoin/bitcoin/blob/master/contrib/init/bitcoind.service#L8-L9, why does the comment state "except for those explicitly specified as arguments in ExecStart="?
1652019-08-02T09:56:10  <setpill> surely aside from "-conf=[..]" the other daemon options can be specified in whatever conf you supply?
1662019-08-02T10:07:10  <jonasschnelli> setpill: I guess because the ones specified in ExecStart are overwritten by ExecStart
1672019-08-02T10:09:21  <setpill> Ah I see, just a matter of suboptimal phrasing then I guess
1682019-08-02T10:09:51  <setpill> To me it sounds like "these options need to be specified as arguments in ExecStart= because they cannot be specified in the conf"
1692019-08-02T10:09:51  <jonasschnelli> I guess -datadir is not possible, since datadir defines where the config file is stored...
1702019-08-02T10:10:01  <wumpus> yes, AFAIK the only option that cannot be specified in the configuration file is -conf, and -datadir if -conf is not used
1712019-08-02T10:10:02  <setpill> I don't think so
1722019-08-02T10:10:23  <setpill> I've used a -conf commandline option with a datadir specified in the referenced conf iirc
1732019-08-02T10:10:25  <wumpus> datadir only defines the standard location of the config file
1742019-08-02T10:10:36  <wumpus> if you override the location of the config file, you can specify a datadir in it
1752019-08-02T10:10:57  <wumpus> this allows putting the configuration file in a separate place e.g. /etc/ while the (writable) datadir is somewhere else
1762019-08-02T10:10:58  <setpill> Also, datadir implies a blocks dir but that can still be overwritten as well
1772019-08-02T10:11:04  <wumpus> right
1782019-08-02T10:18:40  *** captjakk has quit IRC
1792019-08-02T10:20:17  <setpill> 12:10 <wumpus> yes, AFAIK the only option that cannot be specified in the configuration file is -conf, and -datadir if -conf is not used
1802019-08-02T10:20:33  <setpill> would a "datadir" option in the conf file found in the default location not be respected?
1812019-08-02T10:42:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822019-08-02T10:54:04  *** captjakk has joined #bitcoin-core-dev
1832019-08-02T11:17:43  *** Xunie__ has quit IRC
1842019-08-02T11:18:18  *** Xunie__ has joined #bitcoin-core-dev
1852019-08-02T11:28:15  *** captjakk has quit IRC
1862019-08-02T11:29:22  *** justan0theruser has joined #bitcoin-core-dev
1872019-08-02T11:29:41  *** justanotheruser has quit IRC
1882019-08-02T11:46:31  <kanzure> replied about mailing list issues.
1892019-08-02T11:47:06  <kanzure> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-August/017206.html
1902019-08-02T11:47:28  <jonasschnelli> kanzure: thanks!
1912019-08-02T11:48:33  <kanzure> jonasschnelli: "congratulations! you have volunteered to moderate!"
1922019-08-02T11:48:59  <jonasschnelli> kanzure: I'm not qualifying the "neutral" requirement. :)
1932019-08-02T11:49:28  <jonasschnelli> jokes aside: I really think I should not be a moderator
1942019-08-02T11:58:52  *** captjakk has joined #bitcoin-core-dev
1952019-08-02T12:00:02  *** DragonEyes1 has quit IRC
1962019-08-02T12:00:13  <wumpus> jonasschnelli: I agree, same reason I should not be
1972019-08-02T12:00:40  <jonasschnelli> Maybe someone like moneyball or jonatack
1982019-08-02T12:01:01  <kanzure> ideally someone opposite of my timezone (e.g. checks the moderation queue when i am usually sleeping)
1992019-08-02T12:01:46  <wumpus> setpill: that's a good question actually, I don't know, it might!
2002019-08-02T12:18:55  *** bitcoin-git has joined #bitcoin-core-dev
2012019-08-02T12:18:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e653eeff7651...9f54e9ab9038
2022019-08-02T12:18:56  <bitcoin-git> bitcoin/master fa8a823 MarcoFalke: test: Bump rpc_timeout in feature_dbcrash
2032019-08-02T12:18:56  <bitcoin-git> bitcoin/master fa1bb53 MarcoFalke: test: Add -acceptnonstdtxn to self.extra_args[3]
2042019-08-02T12:18:57  <bitcoin-git> bitcoin/master fa36aa4 MarcoFalke: Test: Set -acceptnonstdtxn in feature_fee_estimation
2052019-08-02T12:18:58  *** bitcoin-git has left #bitcoin-core-dev
2062019-08-02T12:20:01  *** bitcoin-git has joined #bitcoin-core-dev
2072019-08-02T12:20:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16493: test: Fix test failures (master...1907-testRpcTimeoutBump) https://github.com/bitcoin/bitcoin/pull/16493
2082019-08-02T12:20:03  *** bitcoin-git has left #bitcoin-core-dev
2092019-08-02T12:20:27  *** lightlike has joined #bitcoin-core-dev
2102019-08-02T12:27:08  *** ezegom has joined #bitcoin-core-dev
2112019-08-02T12:32:10  *** captjakk has quit IRC
2122019-08-02T12:32:31  *** yen_yenny has joined #bitcoin-core-dev
2132019-08-02T12:35:14  <provoostenator> For todays wallet meeting, it would be good to brainstorm if there's a way to avoid all the [ci skip] commits in #16341.
2142019-08-02T12:35:17  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
2152019-08-02T12:35:39  <provoostenator> I can't figure out how.
2162019-08-02T12:36:06  *** pehjota1 has joined #bitcoin-core-dev
2172019-08-02T12:36:23  *** yen_yenny has quit IRC
2182019-08-02T12:36:56  *** yen_yenny has joined #bitcoin-core-dev
2192019-08-02T12:37:21  <provoostenator> It's not that I mind skipping Travis, but I would find this PR much easier to review if it moved stuff to (Legacy)ScriptPubKeyManager more incrementally.
2202019-08-02T12:37:43  *** yen_yenny has quit IRC
2212019-08-02T12:52:07  *** ezegom has quit IRC
2222019-08-02T12:55:00  *** bitcoin-git has joined #bitcoin-core-dev
2232019-08-02T12:55:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9f54e9ab9038...d759b5d26a7e
2242019-08-02T12:55:01  <bitcoin-git> bitcoin/master 4fcb698 Sjors Provoost: [rpc] walletcreatefundedpsbt: use wallet default RBF
2252019-08-02T12:55:01  <bitcoin-git> bitcoin/master 9ed062b Sjors Provoost: [doc] rpc: remove "fallback to" from RBF default help
2262019-08-02T12:55:02  <bitcoin-git> bitcoin/master d6b3640 Sjors Provoost: [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0
2272019-08-02T12:55:12  *** bitcoin-git has left #bitcoin-core-dev
2282019-08-02T12:55:45  *** bitcoin-git has joined #bitcoin-core-dev
2292019-08-02T12:55:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15911: Use wallet RBF default for walletcreatefundedpsbt (master...2019/04/walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/15911
2302019-08-02T12:55:58  *** bitcoin-git has left #bitcoin-core-dev
2312019-08-02T12:56:28  *** ezegom has joined #bitcoin-core-dev
2322019-08-02T13:04:56  *** ezegom has quit IRC
2332019-08-02T13:06:19  *** setpill has quit IRC
2342019-08-02T13:08:15  *** captjakk has joined #bitcoin-core-dev
2352019-08-02T13:14:31  *** bitcoin-git has joined #bitcoin-core-dev
2362019-08-02T13:14:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d759b5d26a7e...be0e8b4bff88
2372019-08-02T13:14:33  <bitcoin-git> bitcoin/master 8c8aa19 Antoine Riard: Add BroadcastTransaction utility usage in Chain interface
2382019-08-02T13:14:34  <bitcoin-git> bitcoin/master 611291c Antoine Riard: Introduce CWalletTx::SubmitMemoryPoolAndRelay
2392019-08-02T13:14:35  <bitcoin-git> bitcoin/master 8753f56 Antoine Riard: Remove duplicate checks in SubmitMemoryPoolAndRelay
2402019-08-02T13:14:37  *** bitcoin-git has left #bitcoin-core-dev
2412019-08-02T13:15:11  *** bitcoin-git has joined #bitcoin-core-dev
2422019-08-02T13:15:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15713: refactor: Replace chain relayTransactions/submitMemoryPool by higher method (master...2019-03-refactor-relay-tx-submit-pool) https://github.com/bitcoin/bitcoin/pull/15713
2432019-08-02T13:15:13  *** bitcoin-git has left #bitcoin-core-dev
2442019-08-02T13:23:50  *** ezegom has joined #bitcoin-core-dev
2452019-08-02T13:31:45  *** keifis has joined #bitcoin-core-dev
2462019-08-02T13:40:52  *** captjakk has quit IRC
2472019-08-02T13:45:59  *** davterra has joined #bitcoin-core-dev
2482019-08-02T13:50:32  *** d_t has joined #bitcoin-core-dev
2492019-08-02T13:56:27  *** elichai2 has joined #bitcoin-core-dev
2502019-08-02T14:01:12  *** sdaftuar has quit IRC
2512019-08-02T14:03:07  *** sdaftuar has joined #bitcoin-core-dev
2522019-08-02T14:09:12  <ariard> at what time is wallet meeting ? I would like to get feedbacks on the rework of rescan logic I'm hacking on
2532019-08-02T14:10:46  *** captjakk has joined #bitcoin-core-dev
2542019-08-02T14:35:29  *** ercwl has joined #bitcoin-core-dev
2552019-08-02T14:39:48  *** mdunnio has joined #bitcoin-core-dev
2562019-08-02T14:42:58  *** captjakk has quit IRC
2572019-08-02T14:43:34  *** mdunnio has quit IRC
2582019-08-02T14:44:53  <achow101> ariard: 1900 utc
2592019-08-02T14:45:09  *** mdunnio has joined #bitcoin-core-dev
2602019-08-02T14:47:50  *** ezegom has quit IRC
2612019-08-02T14:49:17  *** ezegom has joined #bitcoin-core-dev
2622019-08-02T14:49:24  *** jimpo has quit IRC
2632019-08-02T14:50:23  *** ezegom_ has joined #bitcoin-core-dev
2642019-08-02T14:50:23  *** ezegom has quit IRC
2652019-08-02T14:50:25  *** d_t has quit IRC
2662019-08-02T14:51:12  *** ezegom has joined #bitcoin-core-dev
2672019-08-02T14:51:12  *** ezegom_ has quit IRC
2682019-08-02T14:52:13  *** ezegom_ has joined #bitcoin-core-dev
2692019-08-02T14:52:13  *** ezegom has quit IRC
2702019-08-02T14:53:55  *** ezegom has joined #bitcoin-core-dev
2712019-08-02T14:53:55  *** ezegom_ has quit IRC
2722019-08-02T14:54:03  *** michaelfolkson has joined #bitcoin-core-dev
2732019-08-02T14:54:33  *** ezegom has quit IRC
2742019-08-02T14:54:55  *** ezegom has joined #bitcoin-core-dev
2752019-08-02T14:55:46  *** ezegom_ has joined #bitcoin-core-dev
2762019-08-02T14:55:47  *** ezegom has quit IRC
2772019-08-02T14:56:44  *** ezegom has joined #bitcoin-core-dev
2782019-08-02T14:56:44  *** ezegom_ has quit IRC
2792019-08-02T14:57:42  *** ezegom_ has joined #bitcoin-core-dev
2802019-08-02T14:57:43  *** ezegom has quit IRC
2812019-08-02T15:00:02  *** pehjota1 has quit IRC
2822019-08-02T15:01:14  *** kcalvinalvin has joined #bitcoin-core-dev
2832019-08-02T15:01:49  *** ezegom_ has quit IRC
2842019-08-02T15:02:34  *** ercwl has quit IRC
2852019-08-02T15:05:55  *** kephra has joined #bitcoin-core-dev
2862019-08-02T15:08:54  *** emilengler has joined #bitcoin-core-dev
2872019-08-02T15:09:19  *** michaelfolkson has quit IRC
2882019-08-02T15:09:49  *** bitcoin-git has joined #bitcoin-core-dev
2892019-08-02T15:09:49  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
2902019-08-02T15:09:54  *** bitcoin-git has left #bitcoin-core-dev
2912019-08-02T15:11:27  *** nightfall has joined #bitcoin-core-dev
2922019-08-02T15:16:08  *** captjakk has joined #bitcoin-core-dev
2932019-08-02T15:27:02  *** captjakk has quit IRC
2942019-08-02T15:27:25  *** captjakk has joined #bitcoin-core-dev
2952019-08-02T15:28:19  <ariard> thanks achow101
2962019-08-02T15:30:53  *** pinheadmz has joined #bitcoin-core-dev
2972019-08-02T15:30:58  *** ezegom has joined #bitcoin-core-dev
2982019-08-02T15:31:53  *** pinheadmz has quit IRC
2992019-08-02T15:35:28  *** ezegom has quit IRC
3002019-08-02T15:39:11  *** hebasto has joined #bitcoin-core-dev
3012019-08-02T15:39:37  *** mzygar has quit IRC
3022019-08-02T15:40:35  *** emilengler has quit IRC
3032019-08-02T15:43:35  *** jarthur has joined #bitcoin-core-dev
3042019-08-02T15:48:43  *** ezegom has joined #bitcoin-core-dev
3052019-08-02T15:52:57  *** ezegom has quit IRC
3062019-08-02T15:59:31  *** spaced0ut has joined #bitcoin-core-dev
3072019-08-02T16:00:28  *** kcalvinalvin has quit IRC
3082019-08-02T16:04:30  *** kcalvina_ has joined #bitcoin-core-dev
3092019-08-02T16:04:36  <elichai2> Is InferDescriptor *suppose* to add this fingerprint to keys(they started as regular descriptors with private/public keys, no BIP32 stuff involved)? `pkh([1fb31c4f]03462c64aa6089c6e28536c74b6ec4a8f3eaf2f5c5c36e1ae0abf39d563eeaf11e)` (it's something i'm seeing in my descriptors_tests)
3102019-08-02T16:07:15  <sipa> elichai2: it's unnecessary but harmless
3112019-08-02T16:08:50  <elichai2> So it's nothing i've done haha thanks :) (FYI it's starting to look nice, this is what my InferDescriptor *returns* to me :) `tap([46d3fd75]031e34802508ce0bbabb71935832c92129c6df82143a924d731c43362495111319,[pkh([1fb31c4f]03462c64aa6089c6e28536c74b6ec4a8f3eaf2f5c5c36e1ae0abf39d563eeaf11e),pk([2611005f]0257dd0c7c2e9036b845ff4f8a90eeed5daf821e7abd1f98dcbc8b65b0006d28ce)])#umstfklz`)
3122019-08-02T16:10:53  *** ercwl has joined #bitcoin-core-dev
3132019-08-02T16:15:36  <elichai2> (I meant parsing and then inferring the scriptpubkey)
3142019-08-02T16:15:46  <sipa> cool!
3152019-08-02T16:18:10  *** bitcoin-git has joined #bitcoin-core-dev
3162019-08-02T16:18:10  <bitcoin-git> [bitcoin] ariard opened pull request #16536: [doc] Update and extend benchmarking.md (master...2019-08-update-benchmarking-docs) https://github.com/bitcoin/bitcoin/pull/16536
3172019-08-02T16:18:12  *** bitcoin-git has left #bitcoin-core-dev
3182019-08-02T16:19:45  *** bitcoin-git has joined #bitcoin-core-dev
3192019-08-02T16:19:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/be0e8b4bff88...3a3d8b835712
3202019-08-02T16:19:47  <bitcoin-git> bitcoin/master e0e18a1 Hennadii Stepanov: refactoring: Check IsArgKnown() early
3212019-08-02T16:19:47  <bitcoin-git> bitcoin/master e0d187d Hennadii Stepanov: Refactor InterpretNegatedOption() function
3222019-08-02T16:19:49  <bitcoin-git> bitcoin/master 265c1b5 Hennadii Stepanov: Add Flags enum to ArgsManager
3232019-08-02T16:19:50  *** bitcoin-git has left #bitcoin-core-dev
3242019-08-02T16:20:35  *** bitcoin-git has joined #bitcoin-core-dev
3252019-08-02T16:20:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16097: Refactor: Add Flags enum to ArgsManager class (master...20190526-fix-negated-args) https://github.com/bitcoin/bitcoin/pull/16097
3262019-08-02T16:20:38  *** bitcoin-git has left #bitcoin-core-dev
3272019-08-02T16:27:38  *** kljasdfvv has quit IRC
3282019-08-02T16:28:34  *** inersha has left #bitcoin-core-dev
3292019-08-02T16:31:47  *** captjakk has quit IRC
3302019-08-02T16:33:05  *** hebasto has quit IRC
3312019-08-02T16:33:58  *** mdunnio has quit IRC
3322019-08-02T16:34:34  *** hebasto has joined #bitcoin-core-dev
3332019-08-02T16:40:36  *** captjakk has joined #bitcoin-core-dev
3342019-08-02T16:47:22  *** captjakk has quit IRC
3352019-08-02T16:48:21  *** captjakk has joined #bitcoin-core-dev
3362019-08-02T16:56:57  *** emzy_ has quit IRC
3372019-08-02T16:56:57  *** emzy_ has joined #bitcoin-core-dev
3382019-08-02T17:10:54  *** mdunnio has joined #bitcoin-core-dev
3392019-08-02T17:16:22  *** mdunnio has quit IRC
3402019-08-02T17:18:27  *** Zenton has quit IRC
3412019-08-02T17:20:17  *** emilengler has joined #bitcoin-core-dev
3422019-08-02T17:21:27  *** timothy has quit IRC
3432019-08-02T17:23:20  *** mdunnio has joined #bitcoin-core-dev
3442019-08-02T17:25:02  *** kcalvina_ has quit IRC
3452019-08-02T17:26:52  *** ercwl has quit IRC
3462019-08-02T17:26:59  *** pinheadmz has joined #bitcoin-core-dev
3472019-08-02T17:30:22  *** jungly has quit IRC
3482019-08-02T17:31:16  *** kcalvinalvin has joined #bitcoin-core-dev
3492019-08-02T17:40:36  *** captjakk has quit IRC
3502019-08-02T17:50:43  *** kcalvinalvin has quit IRC
3512019-08-02T17:51:13  <elichai2> sipa: arghh. Is it important that every bracket will have it's own significant meaning? because using the same bracket for taproot branches and for bip32 derivations complicates stuff a bit (nothing that can't be handled with a few conditions but still) should be maybe introduce curly brackets?
3522019-08-02T17:52:58  *** mdunnio has quit IRC
3532019-08-02T17:53:33  <sipa> elichai2: if you think curly brackets is easier, sure
3542019-08-02T17:55:45  *** shesek` has joined #bitcoin-core-dev
3552019-08-02T17:56:17  *** mdunnio has joined #bitcoin-core-dev
3562019-08-02T17:56:26  *** jonatack has joined #bitcoin-core-dev
3572019-08-02T17:57:07  *** shesek`` has quit IRC
3582019-08-02T18:00:02  *** kephra has quit IRC
3592019-08-02T18:00:26  *** captjakk has joined #bitcoin-core-dev
3602019-08-02T18:18:07  *** reallll has joined #bitcoin-core-dev
3612019-08-02T18:21:22  *** belcher has quit IRC
3622019-08-02T18:30:27  *** hebasto has quit IRC
3632019-08-02T18:36:47  *** bitcoin-git has joined #bitcoin-core-dev
3642019-08-02T18:36:47  <bitcoin-git> [bitcoin] Sjors closed pull request #15414: [wallet] allow adding pubkeys from imported private keys to keypool (master...2019/02/keypool_import_private_keys) https://github.com/bitcoin/bitcoin/pull/15414
3652019-08-02T18:36:50  *** bitcoin-git has left #bitcoin-core-dev
3662019-08-02T18:59:58  <sipa> TIL: the number of public keys participating in an OP_CHECKMULTISIG and OP_CHECKMULTISIGVERIFY counts towards the 201 non-push opcodes limit, but *only* when executed
3672019-08-02T19:00:21  <meshcollider> #startmeeting
3682019-08-02T19:00:21  <lightningbot> Meeting started Fri Aug  2 19:00:21 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3692019-08-02T19:00:21  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3702019-08-02T19:00:27  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
3712019-08-02T19:00:32  <provoostenator> hi\
3722019-08-02T19:00:32  <achow101> hi
3732019-08-02T19:00:35  <sipa> hi
3742019-08-02T19:01:06  <ariard> hi
3752019-08-02T19:01:07  <meshcollider> any topics? :)
3762019-08-02T19:01:09  <jonatack> hi
3772019-08-02T19:01:27  <jnewbery> hi
3782019-08-02T19:01:39  <achow101> Big news is #16528 opened last night for native descriptor wallets
3792019-08-02T19:01:42  <gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
3802019-08-02T19:01:52  <achow101> only 107 commits :p
3812019-08-02T19:01:53  <ariard> working on a rework of rescan logic https://gist.github.com/ariard/89f9bcc3a7ab9576fc6d15d251032cfa
3822019-08-02T19:02:14  <sipa> achow101: wow
3832019-08-02T19:02:17  <ariard> thanks to feedbacks design from ryanosfky
3842019-08-02T19:02:40  <sipa> ariard: tip for remembering his nickname: ryan of sky
3852019-08-02T19:02:42  <ariard> s/ryanosfky/ryanofsky/g
3862019-08-02T19:02:53  <ariard> sipa: already heard this one
3872019-08-02T19:03:12  <meshcollider> achow101: The 107 commits include the legacy rework PR right :p
3882019-08-02T19:03:18  <achow101> <provoostenator> For todays wallet meeting, it would be good to brainstorm if there's a way to avoid all the [ci skip] commits in #16341.
3892019-08-02T19:03:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
3902019-08-02T19:03:22  <achow101> meshcollider: yes
3912019-08-02T19:03:29  <kanzure> hi
3922019-08-02T19:03:41  <achow101> I think provoostenator has the only topic suggestion today
3932019-08-02T19:03:48  <provoostenator> Yes, maybe it's impossible, but's pretty daunting to review otherwise
3942019-08-02T19:04:03  <meshcollider> Let's start with that then
3952019-08-02T19:04:26  <achow101> I had a look at doing that, and it gave me a headache
3962019-08-02T19:04:47  <meshcollider> #topic Avoiding the [ci skip]s in #16341
3972019-08-02T19:04:49  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
3982019-08-02T19:05:11  <achow101> the problem is that a lot of functions are dependent on other ones, so there would need to be a pretty big commit just to add those
3992019-08-02T19:05:39  <meshcollider> Yeah I thought the whole reason you put them there in the first place was because we decided it was better than one massive commit that doesn't break stuff
4002019-08-02T19:05:41  <achow101> then as you add them into the wallet, things start becoming inconsistent if not all of the things that can effect each other are also added at the same time. these inconsistencies also result in test failures
4012019-08-02T19:06:52  <achow101> One idea I had was to combine implementation of the function in LegacyScriptPubKeyMan and replacement in CWallet, but still leave the CWallet stuff there to operate in parallel
4022019-08-02T19:07:50  <provoostenator> That's what I was thinking as well
4032019-08-02T19:07:51  <achow101> but that seemed kind of pointless because the new code wasn't really doing anything, and we would still need to have the gigantic "delete all the old things" commit at the end
4042019-08-02T19:08:07  <provoostenator> Maybe start with a bunch dummy methods in the LegacyScriptPubKeyMan and then move stuff over?
4052019-08-02T19:08:38  <provoostenator> Then in the end you still need to delete some calls, but no implementations.
4062019-08-02T19:08:39  <achow101> there is also some consistency issues with doing that because the wallet files could be overwritten by two different code paths and become inconsistent, also failing tests
4072019-08-02T19:08:41  <meshcollider> It's the moving which is the problem
4082019-08-02T19:08:43  <elichai2> crazy idea. PR into PR? (that way they could be reviewed seperatly but merged into master together)
4092019-08-02T19:09:31  <sipa> we must go deeper.
4102019-08-02T19:09:39  <achow101> elichai2: they're all separate commits, so it shouldn't actually be that hard to review separately
4112019-08-02T19:10:13  *** _atos has joined #bitcoin-core-dev
4122019-08-02T19:10:44  <achow101> provoostenator: I don't believe that there is a way to avoid having [ci skip] commits because tests will fail
4132019-08-02T19:11:29  <meshcollider> Ease of review > Travis passing on every single commit, as long as the tests pass at the end of the PR I think it's fine :)
4142019-08-02T19:11:40  <provoostenator> meshcollider: agree
4152019-08-02T19:11:58  <achow101> a lot of the commits are really small too
4162019-08-02T19:12:21  <provoostenator> Currently the dimmed-zebra can't help
4172019-08-02T19:12:36  <provoostenator> Which makes it super tedious to check if the new function bodies are the same
4182019-08-02T19:12:41  <sipa> having intermediary commits that pass CI is helpful for review, as you can be sure about things like "this method changes, did all call sites get updated too?" without needing much work
4192019-08-02T19:13:12  <achow101> having them all pass tests would be nice, makes bisect not suck
4202019-08-02T19:13:19  <sipa> yeah
4212019-08-02T19:13:32  <sipa> not saying it's a strict requirement, though it's certainly very helpful as a policy
4222019-08-02T19:13:47  <achow101> I spent a lot of time finding a bug that was introduced in one of the [ci skip] commits but bisect wasn't as helpful since the tests wouldn't get to the part where the bug was triggered
4232019-08-02T19:14:54  <achow101> but even then, having them all pass tests wouldn't be helpful since the new code isn't the one that's actually doing the work. it would still just be the old stuff and bisecting would just point you to the gigantic "change everything over" commit
4242019-08-02T19:15:24  <jonatack> at least the [ci skip] comments signal when the failure is to be expected, so there's that... but from a review perspective hygienic commits are much better
4252019-08-02T19:15:58  <jonatack> commit messages could contain the steps
4262019-08-02T19:17:53  <meshcollider> achow101: can CWallet just have an instance of a LegacyScriptPubkeyManager inside it right from the start and call methods inside it as they're moved into it?
4272019-08-02T19:18:24  <meshcollider> And then do some inheritance refactoring at the end
4282019-08-02T19:18:54  <meshcollider> Then the massive "move everything over" commit would just be deleting methods like foo(){ legacy.foo(); }
4292019-08-02T19:19:25  <achow101> no because methods are dependent on other ones
4302019-08-02T19:20:44  <achow101> for example, I thought that AddKey would be easy, it should be mostly by itself, right? Nope. Requres AddCryptedKey to be implemented, which requires Encryption stuff to be implemented. For some reason it also requires watch only things so you need to have setWatchOnly, HaveWatchOnly, RemoveWatchOnly
4312019-08-02T19:20:54  *** Zenton has joined #bitcoin-core-dev
4322019-08-02T19:21:13  <achow101> and you need AddKey for loading keys in the first place!
4332019-08-02T19:21:32  <sipa> fun.
4342019-08-02T19:22:44  <meshcollider> Yeah... I think the [ci skip] are here to stay then
4352019-08-02T19:23:06  <meshcollider> Does anyone else want to discuss anything this week?
4362019-08-02T19:24:07  <achow101> (If you couldn't tell, I was very annoyed by this and spent a while cursing the person who wrote this code, which was probably sipa :p)
4372019-08-02T19:24:16  * sipa hides.
4382019-08-02T19:25:31  <ariard> meshcollider: if anyone has thoughts on this https://gist.github.com/ariard/89f9bcc3a7ab9576fc6d15d251032cfa it would be welcomed
4392019-08-02T19:25:53  <ariard> (not necessarily now)
4402019-08-02T19:26:25  <achow101> it would be nice for rescan (and other wallet things) to not need cs_main
4412019-08-02T19:26:31  <meshcollider> #action Read and feedback on ariard's proposal
4422019-08-02T19:26:39  <ariard> main idea is just to use a common thread between index and ChainClient to provide blocks in one sequence instead of redoing the work multiple times
4432019-08-02T19:26:57  <achow101> there's been a lot of complaints I've seen recently about RPCs taking a while, probably because cs_main is held by ~everything
4442019-08-02T19:26:58  <ariard> achow101: yes that's the end of goal, not relying at all on cs_main
4452019-08-02T19:27:15  <ariard> but will need multiple PRs to get there to avoid to big diff
4462019-08-02T19:27:52  <ariard> first step move all logic in a thread, future steps  worker thread pool + cache what we need to avoid locking
4472019-08-02T19:28:47  <ariard> hope to submit code next week, people will get a better idea
4482019-08-02T19:29:03  <emilengler> By the way, what does the LOCK and cs_main mean? I see this nearly everywhere when I look in the code
4492019-08-02T19:29:05  <meshcollider> ariard: sounds good!
4502019-08-02T19:29:09  <emilengler> And why it needs to be in the curly brackets
4512019-08-02T19:30:03  <achow101> emilengler: cs_main is one of the locks, while one thread holds it, no other thread can acquire it. it is used to protect things from concurrency issues like race conditions. LOCK(cs_main) is the way to acquire cs_main, if it is held by someone else, the thread will wait
4522019-08-02T19:30:04  <sipa> emilengler: RAII
4532019-08-02T19:30:17  <meshcollider> emilengler: cs_main is something which only one thread can "hold" at once, making sure stuff which it protects isn't written twice at the same time or something which would result in race conditions
4542019-08-02T19:30:26  <sipa> emilengler: it introduces a lock in the scope it's defined at; it automatically unlocks when it goes out of scope
4552019-08-02T19:30:36  <sipa> emilengler: it's a general concept in C++ called RAII
4562019-08-02T19:30:39  <ariard> have a look in sync.h and threadsafety.h
4572019-08-02T19:31:13  <meshcollider> Anyway I think this wraps up the meeting
4582019-08-02T19:31:35  <emilengler> Ok so it is more a C++ thing? I usually don't work that often with multiple threads
4592019-08-02T19:31:47  <meshcollider> We can read the proposal and PR outside
4602019-08-02T19:31:49  <meshcollider> #endmeeting
4612019-08-02T19:31:49  <lightningbot> Meeting ended Fri Aug  2 19:31:49 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4622019-08-02T19:31:49  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-02-19.00.html
4632019-08-02T19:31:49  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-02-19.00.txt
4642019-08-02T19:31:49  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-02-19.00.log.html
4652019-08-02T19:32:05  <achow101> anyone have suggestions for things that should be added to tests for descriptor wallets?
4662019-08-02T19:32:30  <achow101> I added a --descriptors switch to some of the wallet tests so those tests will also run with descriptor wallets
4672019-08-02T19:32:43  <sipa> that's a nice idea
4682019-08-02T19:32:56  <sipa> so you can test things against both old-style wallets and new-style ones?
4692019-08-02T19:33:09  <achow101> yes
4702019-08-02T19:33:26  <meshcollider> emilengler: other languages use locks too for multithreading
4712019-08-02T19:33:45  <meshcollider> I think java does
4722019-08-02T19:33:46  <achow101> sipa: it just needs to avoid things like imports and ismine
4732019-08-02T19:34:09  <meshcollider> achow101: I guess it's easier to suggest more tests when reviewing the tests in the PR
4742019-08-02T19:34:39  <achow101> but at least all of the transaction sending, transaction ismine, etc. things can be tested without writing wholly new tests
4752019-08-02T19:34:59  <achow101> meshcollider: better start reviewing then!
4762019-08-02T19:35:12  <sipa> emilengler: https://en.wikipedia.org/wiki/Resource_acquisition_is_initialization
4772019-08-02T19:36:08  <meshcollider> achow101: just add tests for all the new codepaths :)
4782019-08-02T19:36:22  <meshcollider> You wrote it so you should know how to test it :)))
4792019-08-02T19:36:25  <achow101> I did a coverage report and I think just about everything has been hit
4802019-08-02T19:37:13  *** bitcoin-git has joined #bitcoin-core-dev
4812019-08-02T19:37:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16538: test: Add missing sync_blocks to feature_pruning (master...1908-testPruneNoRace) https://github.com/bitcoin/bitcoin/pull/16538
4822019-08-02T19:37:14  *** bitcoin-git has left #bitcoin-core-dev
4832019-08-02T19:38:16  *** morcos has quit IRC
4842019-08-02T19:38:35  *** morcos has joined #bitcoin-core-dev
4852019-08-02T19:47:46  *** ezegom has joined #bitcoin-core-dev
4862019-08-02T19:51:55  *** luke-jr has quit IRC
4872019-08-02T19:52:47  *** luke-jr has joined #bitcoin-core-dev
4882019-08-02T19:55:38  *** luke-jr has quit IRC
4892019-08-02T19:56:03  *** luke-jr has joined #bitcoin-core-dev
4902019-08-02T19:58:01  *** mdunnio has quit IRC
4912019-08-02T20:06:22  *** Victor_sueca has quit IRC
4922019-08-02T20:07:30  *** Victor_sueca has joined #bitcoin-core-dev
4932019-08-02T20:08:39  *** Bullitje_enable has quit IRC
4942019-08-02T20:12:19  *** mdunnio has joined #bitcoin-core-dev
4952019-08-02T20:15:16  *** bitcoin-git has joined #bitcoin-core-dev
4962019-08-02T20:15:16  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/784e218610d4...673919caf72c
4972019-08-02T20:15:16  <bitcoin-git> bitcoin/0.18 5f5b444 David A. Harding: Doc: remove old release notes about systemd and riscv changes
4982019-08-02T20:15:17  <bitcoin-git> bitcoin/0.18 673919c Wladimir J. van der Laan: Merge #16532: [0.18] Doc: remove old release notes about systemd and riscv...
4992019-08-02T20:15:29  *** bitcoin-git has left #bitcoin-core-dev
5002019-08-02T20:15:46  *** bitcoin-git has joined #bitcoin-core-dev
5012019-08-02T20:15:46  <bitcoin-git> [bitcoin] laanwj merged pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532
5022019-08-02T20:15:47  *** bitcoin-git has left #bitcoin-core-dev
5032019-08-02T20:20:32  *** _atos has quit IRC
5042019-08-02T20:24:23  *** reallll is now known as belcher
5052019-08-02T20:25:01  <emilengler> Where are the qt icons stored?
5062019-08-02T20:25:57  <emilengler> Ok nevermind got it
5072019-08-02T20:26:02  <emilengler> They are in src/qt/res
5082019-08-02T20:26:50  *** bitcoin-git has joined #bitcoin-core-dev
5092019-08-02T20:26:50  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/673919caf72c...bfa7183c4e5a
5102019-08-02T20:26:50  <bitcoin-git> bitcoin/0.18 bfa7183 Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
5112019-08-02T20:26:53  *** bitcoin-git has left #bitcoin-core-dev
5122019-08-02T20:27:01  <wumpus> `git ls-files|grep png`
5132019-08-02T20:28:40  *** bitcoin-git has joined #bitcoin-core-dev
5142019-08-02T20:28:41  <bitcoin-git> [bitcoin] Sjors opened pull request #16539: [wallet] lower -txmaxfee default from 0.1 to 0.01 BTC (master...2019/08/lower_txmaxfee) https://github.com/bitcoin/bitcoin/pull/16539
5152019-08-02T20:28:42  *** bitcoin-git has left #bitcoin-core-dev
5162019-08-02T20:28:48  <emilengler> wumpus: Also thought about doing this but I wasn't sure about the file format
5172019-08-02T20:29:04  <wumpus> we've just disabled jpeg so :-)
5182019-08-02T20:29:44  *** lassulus1 has joined #bitcoin-core-dev
5192019-08-02T20:30:07  <emilengler> Maybe a vector?
5202019-08-02T20:33:48  *** bitcoin-git has joined #bitcoin-core-dev
5212019-08-02T20:33:48  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/bfa7183c4e5a...fa27a0760792
5222019-08-02T20:33:48  <bitcoin-git> bitcoin/0.18 fa27a07 Wladimir J. van der Laan: doc: Bump manpages pre-final
5232019-08-02T20:33:51  *** bitcoin-git has left #bitcoin-core-dev
5242019-08-02T20:33:56  <provoostenator> ^ sorry for the bike-shed risk, but I think it's worth considering every couple of years and it's been 5
5252019-08-02T20:35:41  <wumpus> emilengler: yea there's some svg but they're converted to png before being included afaik, don't think we include any actual vector icons for use by the qt code, but not 100% sure
5262019-08-02T20:36:15  *** bitcoin-git has joined #bitcoin-core-dev
5272019-08-02T20:36:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
5282019-08-02T20:36:18  *** bitcoin-git has left #bitcoin-core-dev
5292019-08-02T20:37:02  *** promag_ has quit IRC
5302019-08-02T20:38:22  <wumpus> provoostenator: sorry i'm not sure what that's about
5312019-08-02T20:38:53  <provoostenator> wumpus: my PR proposes lowering txmaxfee from 0.1 to 0.01 BTC
5322019-08-02T20:39:20  <wumpus> provoostenator: ohh good luck !
5332019-08-02T20:42:27  *** bitcoin-git has joined #bitcoin-core-dev
5342019-08-02T20:42:28  <bitcoin-git> [bitcoin] laanwj pushed tag v0.18.1: https://github.com/bitcoin/bitcoin/compare/v0.18.1
5352019-08-02T20:42:29  *** bitcoin-git has left #bitcoin-core-dev
5362019-08-02T20:45:21  <wumpus> gkrizek: ^^ the bot really does work great
5372019-08-02T20:45:24  <provoostenator> With giant coin joins in mind maybe we should check the max fee per our own inputs, rather than the tx total.
5382019-08-02T20:45:41  <provoostenator> *for
5392019-08-02T20:46:36  <wumpus> yes, tx total has always been kind of a belts and suspenders measure
5402019-08-02T20:46:59  <wumpus> like 'if the total fee is more than *this* it's really absurd and something must be wrong'
5412019-08-02T20:47:37  <wumpus> could be because a wallet generates a transaction that's absurdly large, or because the feerate is absurdly large
5422019-08-02T20:48:40  <provoostenator> In #16257 I covered the case where a user types "1" as the feeRate thinking it's satoshi per byte. That works nicely with the current 0.1 BTC max.
5432019-08-02T20:48:44  <gribble> https://github.com/bitcoin/bitcoin/issues/16257 | [wallet] abort when attempting to fund a transaction above -maxtxfee by Sjors · Pull Request #16257 · bitcoin/bitcoin · GitHub
5442019-08-02T20:49:32  <provoostenator> But there may be other fat finger mistakes possible.
5452019-08-02T20:50:50  <provoostenator> I believe in earlier days people would sometimes forget a change address, though afaik that's pretty hard to do accidentally now in core.
5462019-08-02T20:52:43  <ghost43> provoostenator: is the maxtxfee check still done when using the sendrawtransaction RPC? Not that long ago at least that was the case
5472019-08-02T20:53:13  <provoostenator> I'm not sure, because that's no longer part of the wallet.
5482019-08-02T20:53:31  <ghost43> (I know the check was done there because it was affecting electrum users)
5492019-08-02T20:54:31  <provoostenator> ghost34: yes it still does that check, there's a maxfeerate argument to more easily override it
5502019-08-02T20:54:41  <achow101> ghost43: the absurdly high fee error?
5512019-08-02T20:54:41  *** Guyver2 has quit IRC
5522019-08-02T20:54:46  <ghost43> yes
5532019-08-02T20:55:09  <ghost43> we had users with huge wallets creating almost 100 KB txs
5542019-08-02T20:55:10  <provoostenator> But it's not done for p2p transaction relay?
5552019-08-02T20:55:12  <ghost43> for those, the absurdity is breached around 100 sat/byte
5562019-08-02T20:55:29  <ghost43> but the electrum server is using the bitcoind sendrawtransaction RPC
5572019-08-02T20:55:38  *** bitcoin-git has joined #bitcoin-core-dev
5582019-08-02T20:55:38  <bitcoin-git> [bitcoin] emilengler opened pull request #16541: qt: Add better icon for Open URI (master...2019-08-qt-update-open-uri-icon) https://github.com/bitcoin/bitcoin/pull/16541
5592019-08-02T20:55:42  *** bitcoin-git has left #bitcoin-core-dev
5602019-08-02T20:57:41  <ghost43> tbh, I think a "feerate" absurdity check would make a lot more sense than an "absolute fee" absurdity check
5612019-08-02T21:00:01  *** lassulus1 has quit IRC
5622019-08-02T21:00:04  <achow101> ghost43: I think it's still an absolute fee. We should definitely change that...
5632019-08-02T21:00:13  <achow101> afaik maxtxfee is for the wallet
5642019-08-02T21:03:46  *** davterra has quit IRC
5652019-08-02T21:03:47  <achow101> ghost43: nvm, I'm wrong. it uses maxtxfee. you could also just bypass that check by using the `allowhighfees` parameter
5662019-08-02T21:04:16  *** ezegom has quit IRC
5672019-08-02T21:04:43  *** ezegom has joined #bitcoin-core-dev
5682019-08-02T21:06:00  *** ezegom_ has joined #bitcoin-core-dev
5692019-08-02T21:06:00  *** ezegom has quit IRC
5702019-08-02T21:06:18  *** captjakk has quit IRC
5712019-08-02T21:06:52  *** captjakk has joined #bitcoin-core-dev
5722019-08-02T21:06:57  *** ezegom_ has quit IRC
5732019-08-02T21:07:03  *** ezegom has joined #bitcoin-core-dev
5742019-08-02T21:08:10  *** ezegom_ has joined #bitcoin-core-dev
5752019-08-02T21:08:11  *** ezegom has quit IRC
5762019-08-02T21:09:18  *** ezegom has joined #bitcoin-core-dev
5772019-08-02T21:09:18  *** ezegom_ has quit IRC
5782019-08-02T21:10:23  *** ezegom_ has joined #bitcoin-core-dev
5792019-08-02T21:10:24  *** ezegom has quit IRC
5802019-08-02T21:11:17  *** captjakk has quit IRC
5812019-08-02T21:11:17  *** ezegom_ has quit IRC
5822019-08-02T21:11:28  *** ezegom has joined #bitcoin-core-dev
5832019-08-02T21:12:35  *** ezegom_ has joined #bitcoin-core-dev
5842019-08-02T21:12:35  *** ezegom has quit IRC
5852019-08-02T21:13:41  *** ezegom has joined #bitcoin-core-dev
5862019-08-02T21:13:42  *** ezegom_ has quit IRC
5872019-08-02T21:14:51  *** ezegom_ has joined #bitcoin-core-dev
5882019-08-02T21:14:51  *** ezegom has quit IRC
5892019-08-02T21:15:09  <ghost43> looks like the wallet and the node maximum absolute fees were recently separated: https://github.com/bitcoin/bitcoin/pull/15620
5902019-08-02T21:15:56  *** ezegom has joined #bitcoin-core-dev
5912019-08-02T21:16:10  *** ezegom_ has quit IRC
5922019-08-02T21:16:15  *** mdunnio has quit IRC
5932019-08-02T21:16:43  *** mdunnio has joined #bitcoin-core-dev
5942019-08-02T21:16:43  *** ezegom has quit IRC
5952019-08-02T21:17:03  *** ezegom has joined #bitcoin-core-dev
5962019-08-02T21:18:11  *** ezegom_ has joined #bitcoin-core-dev
5972019-08-02T21:18:11  *** ezegom has quit IRC
5982019-08-02T21:19:41  *** ezegom has joined #bitcoin-core-dev
5992019-08-02T21:20:20  *** davterra has joined #bitcoin-core-dev
6002019-08-02T21:21:22  *** emilengler has quit IRC
6012019-08-02T21:21:51  *** emilengler has joined #bitcoin-core-dev
6022019-08-02T21:22:43  *** ezegom_ has quit IRC
6032019-08-02T21:23:30  *** ezegom has quit IRC
6042019-08-02T21:24:48  *** emilengler has quit IRC
6052019-08-02T21:26:24  *** emilengler has joined #bitcoin-core-dev
6062019-08-02T21:33:12  *** Gaz has joined #bitcoin-core-dev
6072019-08-02T21:45:18  <emilengler> Is the strprintf function for args who take user-input?
6082019-08-02T21:46:24  <sipa> for anything
6092019-08-02T21:46:41  <emilengler> But in init.cpp this function is used sometimes and sometimes not
6102019-08-02T21:46:53  <emilengler> So what is the actual purpose of it?
6112019-08-02T21:47:17  <sipa> it's used to convert things to a string
6122019-08-02T21:47:34  <sipa> i don't know what you mean by "sometimes not"
6132019-08-02T21:48:24  <emilengler> In the init.cpp at the part where the args are being added their is the second parameter sometimes this function or just a string
6142019-08-02T21:48:50  <emilengler> Like in line 356 it isn't used but in 383 it uses for example
6152019-08-02T21:49:05  <sipa> there is nothing to convert to a string in line 356
6162019-08-02T21:49:10  <sipa> it already is one
6172019-08-02T21:49:21  <emilengler> Yep I got it, your previous answer explained it. thanks :)
6182019-08-02T21:55:26  *** ezegom has joined #bitcoin-core-dev
6192019-08-02T21:57:40  *** mdunnio has quit IRC
6202019-08-02T22:10:13  *** captjakk has joined #bitcoin-core-dev
6212019-08-02T22:18:19  *** jarthur_ has joined #bitcoin-core-dev
6222019-08-02T22:20:52  *** jarthur has quit IRC
6232019-08-02T22:22:54  *** jarthur_ has quit IRC
6242019-08-02T22:22:59  *** ezegom has quit IRC
6252019-08-02T22:27:38  *** ezegom has joined #bitcoin-core-dev
6262019-08-02T22:29:24  *** owowo has quit IRC
6272019-08-02T22:30:16  *** owowo has joined #bitcoin-core-dev
6282019-08-02T22:33:00  *** ezegom has quit IRC
6292019-08-02T22:33:28  *** ezegom has joined #bitcoin-core-dev
6302019-08-02T22:37:55  *** ezegom has quit IRC
6312019-08-02T22:40:46  *** davterra has quit IRC
6322019-08-02T22:41:59  *** davterra has joined #bitcoin-core-dev
6332019-08-02T22:46:22  *** justan0theruser is now known as justanotheruser
6342019-08-02T22:46:42  *** Chris_Stewart_5 has quit IRC
6352019-08-02T22:48:49  *** blockstreamspy has joined #bitcoin-core-dev
6362019-08-02T22:49:37  *** blockstreamspy has quit IRC
6372019-08-02T22:57:35  *** ezegom has joined #bitcoin-core-dev
6382019-08-02T23:23:22  *** ezegom has quit IRC
6392019-08-02T23:23:48  *** ezegom has joined #bitcoin-core-dev
6402019-08-02T23:27:55  *** ezegom has quit IRC
6412019-08-02T23:34:15  *** captjakk has quit IRC
6422019-08-02T23:40:00  *** promag has joined #bitcoin-core-dev
6432019-08-02T23:43:02  *** bitcoin-git has joined #bitcoin-core-dev
6442019-08-02T23:43:02  <bitcoin-git> [bitcoin] achow101 opened pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
6452019-08-02T23:43:03  *** bitcoin-git has left #bitcoin-core-dev
6462019-08-02T23:48:15  <achow101> fanquake: maybe we should add a "descriptors" tag as descriptors by themselves aren't wallet related
6472019-08-02T23:48:44  <fanquake> achow101: sure
6482019-08-02T23:55:12  *** captjakk has joined #bitcoin-core-dev
6492019-08-02T23:56:59  *** rex4539 has quit IRC
6502019-08-02T23:58:08  <elichai2> achow101: why doesn't `FillableSigningProvider` derives from `FlatSigningProvider`?