12019-08-03T00:00:02  *** Gaz has quit IRC
  22019-08-03T00:00:21  <elichai2> I guess because his keys are guarded?
  32019-08-03T00:00:26  <achow101> elichai2: to not publicly expose the internals
  42019-08-03T00:00:31  <elichai2> hmm
  52019-08-03T00:00:52  <elichai2> ok, I guess everything I add to `FlatSigningProvider` I need to add to `FillableSigningProvider` but thread safe
  62019-08-03T00:01:07  <achow101> Why do you need FillableSigningProvider?
  72019-08-03T00:01:17  <elichai2> achow101: right in FlatSigningProvider everything is public
  82019-08-03T00:01:54  <elichai2> achow101: I added taproot support for descriptors, it complains now that the `switch (whichType)`  in `IsMine` doesn't cover the new taproot
  92019-08-03T00:01:59  *** dviola has joined #bitcoin-core-dev
 102019-08-03T00:02:14  <achow101> don't use IsMine :)
 112019-08-03T00:02:30  <elichai2> I don't use it, I edited `txnouttype`
 122019-08-03T00:02:31  <achow101> (but seriously, IsMine is changing with all of the wallet stuff)
 132019-08-03T00:02:51  <elichai2> so for now I should just stick to descriptors and then enjoy the rebase? haha
 142019-08-03T00:03:09  <achow101> I don't quite follow what you are trying to do
 152019-08-03T00:03:13  <elichai2> I guess i'll have to manually test that I'm hashing everything the same way the interperter does
 162019-08-03T00:03:57  <elichai2> achow101: `tap(031e34802508ce0bbabb71935832c92129c6df82143a924d731c43362495111319,{{pk(0257dd0c7c2e9036b845ff4f8a90eeed5daf821e7abd1f98dcbc8b65b0006d28ce),{pkh(023e93f827793706dffdca946b64842f69c336c8dd78f32d716ee7e77dfe119418),pk(03ce8db555edec3c68b358cf9bdb7fd9539a9fba064c31bdc9651c68fa658dd6b7)}},pkh(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)})`
 172019-08-03T00:04:03  <elichai2> new descriptor :)
 182019-08-03T00:04:23  <elichai2> ops I copied an invalid one lol
 192019-08-03T00:04:33  <achow101> right, so what does ismine have to do with this?
 202019-08-03T00:05:30  <elichai2> ismine switches over `txnouttype`. I had to add `TX_WITNESS_V1_TAPROOT` to it because `txnouttype` is also used in `InferScript`
 212019-08-03T00:05:55  <elichai2> I can just add return false there for the taproot ones for now
 222019-08-03T00:06:06  <sipa> you should
 232019-08-03T00:06:20  <sipa> the old ismine logic shouldn't be used for taproot stuff
 242019-08-03T00:06:44  <elichai2> so I'll wait for achow101 native descriptors PR for testing wallet support?
 252019-08-03T00:06:48  <achow101> yes
 262019-08-03T00:06:50  <elichai2> ok
 272019-08-03T00:07:17  <sipa> are you writing signing support?
 282019-08-03T00:07:24  <elichai2> I'll start doing manual tests to check that i'm hashing everything correctly
 292019-08-03T00:07:26  <sipa> or just derivation for now
 302019-08-03T00:08:02  <elichai2> the only way to really know that what i'm doing is correct is by having a test that signs and see that it passes your interperter code
 312019-08-03T00:08:24  <elichai2> otherwise my lex ordering or the hashes might be wrong and I won't know
 322019-08-03T00:08:32  <sipa> so signing logic should be independent of descriptors
 332019-08-03T00:08:57  <sipa> and there you'll need to switch based on txnouttype
 342019-08-03T00:09:09  <sipa> but for pretty much everything else i think you can ignore TX_WITNESS_V1_TAPROOT
 352019-08-03T00:11:05  <elichai2> yeah, but then I can import a desc and try to sign with it. but I guess i'm trying to do too much, for now i'll test manually and concentrate on adding more tests for the desc and then either ask someone to give my code a quick look (I am pretty new to bitcoin core's code and to c++)  or look into PSBT/signing, but only after i'm 100% done with the desc
 362019-08-03T00:12:22  <elichai2> (hopefully by then achow101 will finish and I'll be able to rebase on top of him)
 372019-08-03T00:12:25  <sipa> are you adding fields to SignatureData ?
 382019-08-03T00:12:28  <achow101> elichai2: you could base on top of #16528 (native descriptor wallets), but it's wip so it could change. but while no one has reviewed it, it probably won't change
 392019-08-03T00:12:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16528 | [WIP] Native Descriptor Wallets (take 2) by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
 402019-08-03T00:13:00  <elichai2> I'll actually try to review it too next week, though it's a pretty big one heh
 412019-08-03T00:14:36  <elichai2> sipa: didn't yet but I basically have the control block in ProduceSignature
 422019-08-03T00:14:41  <elichai2> so it shouldn't be too hard
 432019-08-03T00:14:43  <sipa> elichai2: i guess the codebase (and the hairy signing logic + descriptor stuff in particular...) can be quite daunting
 442019-08-03T00:14:56  <sipa> but it's great that you're getting accustomed to it
 452019-08-03T00:15:52  <elichai2> yeah, even though there's a lot of things I don't like/don't get both in c++ and in some design choices it's overall not as hard as I thought it will be (assuming people won't say that everything i'm doing is wrong and bad lol)
 462019-08-03T00:17:07  <sipa> yeah, a lot is historical
 472019-08-03T00:17:18  <achow101> it's all sipa's fault
 482019-08-03T00:17:22  <elichai2> lol
 492019-08-03T00:17:23  <sipa> i think maybe at some point we can make the entire signing logic integrated into descriptors
 502019-08-03T00:17:29  <sipa> well, a lot of it is, probably
 512019-08-03T00:17:46  *** paulk has joined #bitcoin-core-dev
 522019-08-03T00:17:50  <elichai2> yeah a lot of the historical stuff are frustrating, but I guess we don't have much of a choice
 532019-08-03T00:17:56  <sipa> but maybe not; i'm not sure
 542019-08-03T00:18:44  <sipa> btw: https://github.com/sipa/bitcoin/tree/201907_miniscript
 552019-08-03T00:18:55  <elichai2> (i.e. the way `ProduceSignature` works is pretty weird/funny)
 562019-08-03T00:19:01  <achow101> sipa: finally
 572019-08-03T00:19:09  <sipa> it's not yet integrated into descriptors or signing logic
 582019-08-03T00:19:12  <elichai2> "bla"
 592019-08-03T00:19:16  <elichai2> :P
 602019-08-03T00:19:52  <sipa> but it is passing tests (randomly generated script, generating a random satisfaction for it, and feeding it to the script interpreter)
 612019-08-03T00:19:53  <achow101> "Various"
 622019-08-03T00:20:03  <sipa> don't look at my commits, lol
 632019-08-03T00:20:04  <achow101> I guess that's better than just "f" (which I frequently do)
 642019-08-03T00:20:13  <sipa> not PR-ready
 652019-08-03T00:20:33  *** ercwl has joined #bitcoin-core-dev
 662019-08-03T00:20:37  <elichai2> So I guess we have another interpreter ha
 672019-08-03T00:20:47  <sipa> but src/script/miniscript.h should be pretty readable
 682019-08-03T00:20:47  <elichai2> what's a gram file?
 692019-08-03T00:21:02  <sipa> elichai2: https://github.com/sipa/gramtropy :)
 702019-08-03T00:21:24  <achow101> sipa: does this mean that miniscript is finalized now and won't be completely rewritten again?
 712019-08-03T00:21:29  <sipa> achow101: yes
 722019-08-03T00:21:47  <sipa> i'll try to write things up and send a mail to the list next week
 732019-08-03T00:21:51  <achow101> yay
 742019-08-03T00:22:01  <elichai2> rightt I saw it somtime in the past. funny tool.
 752019-08-03T00:22:07  <elichai2> sipa: awesome!
 762019-08-03T00:22:29  <elichai2> I'm curious how will the descritors look like
 772019-08-03T00:23:00  <sipa> wsh(and_v(or_c(c:pk(C),or_c(c:pk(C),v:older(1000))),c:pk(C)))
 782019-08-03T00:23:10  <sipa> where C is a pubkey
 792019-08-03T00:23:54  <elichai2> hmm so in theory if you use '(' it would hopefully magically work with my desc
 802019-08-03T00:23:56  <achow101> that will be part of the descriptor module? so the wallet doesn't need anymore changes
 812019-08-03T00:24:17  <elichai2> altough you also use `,` so that might be a problem hmm
 822019-08-03T00:24:34  <sipa> elichai2: i expect things to just Just Work(tm)
 832019-08-03T00:24:51  *** ercwl has quit IRC
 842019-08-03T00:24:52  <sipa> achow101: yeah
 852019-08-03T00:25:20  <sipa> the only change that affects the wallet i expect will be that we can't use IsSolvable/DummySigner anymore to guess fees
 862019-08-03T00:25:23  <elichai2> looks pretty cool :)
 872019-08-03T00:25:28  *** jarthur has joined #bitcoin-core-dev
 882019-08-03T00:25:37  <sipa> because the size of satisfactions depends on which participants are available
 892019-08-03T00:25:53  <sipa> so i think we'll add a method to descriptors to ask them what a satisfaction will cost
 902019-08-03T00:26:31  <sipa> that's also true for taproot btw
 912019-08-03T00:28:21  <elichai2> I'm kind of brute forcing IsSolvable(ProduceSignature) right now, so if the wallet can either 1. sign for the internal key. 2. sign for any of the branches I return cool, which I guess will stop at the first thing that it can sign for
 922019-08-03T00:28:56  <elichai2> though I'm not sure it's the right attitude. maybe at the very least sort it by size and try from lower to higher
 932019-08-03T00:29:17  <sipa> elichai2: my idea is that we add support in descriptors for marking keys as available/unavailable
 942019-08-03T00:29:47  <elichai2> available as in available but not in my wallet? (i.e. multisig)
 952019-08-03T00:29:52  <sipa> and there is a cute algorithm that can find the worst case satisfaction cost given which keys are certainly available, which may be available, and which are definitely not available
 962019-08-03T00:30:02  <sipa> yeah, available meaning "will participate in signing if requested"
 972019-08-03T00:30:39  <sipa> which private keys you have locally should be pretty much completely independent (as your software shouldn't treat having a key locally as different from it being in a hw wallet you control)
 982019-08-03T00:30:41  <elichai2> right now the wallet doesn't do anything like that for multisig, right?
 992019-08-03T00:30:44  *** jarthur has quit IRC
1002019-08-03T00:30:53  <sipa> right
1012019-08-03T00:30:57  <sipa> because it doesn't need to
1022019-08-03T00:31:02  <sipa> all satisfactions are the same size
1032019-08-03T00:31:22  <elichai2> but some keys might be available but not in the wallet
1042019-08-03T00:31:34  <sipa> yeah, currently it distinguishes
1052019-08-03T00:31:36  <sipa> that's bad
1062019-08-03T00:31:57  <sipa> the concept of "watch only" being tied whether you have keys locally is a mistake
1072019-08-03T00:32:21  <achow101> watchonly is no longer a concept in descriptor wallets
1082019-08-03T00:32:28  <sipa> yay
1092019-08-03T00:32:44  <achow101> other than watchonly wallets, i.e. disable private keys
1102019-08-03T00:32:55  <achow101> but ISMINE_WATCHONLY isn't a thing that descriptor wallet ismine can return
1112019-08-03T00:33:19  <sipa> good
1122019-08-03T00:39:15  *** jarthur has joined #bitcoin-core-dev
1132019-08-03T00:39:47  <elichai2> btw if anyone is interested https://github.com/elichai/bitcoin/tree/2019-07-tap-desc (based on a merge between master and sipa/taproot)
1142019-08-03T00:40:21  <elichai2> so how will watch only work with native desc wallet?
1152019-08-03T00:40:40  <emilengler> elichai2: TL;DR can you sum it up please :)
1162019-08-03T00:40:55  <elichai2> emilengler: sum up what?
1172019-08-03T00:41:27  <emilengler> elichai2: You've written if anyone is interested on what? Sorry didn't followed the conversation
1182019-08-03T00:41:40  <achow101> emilengler: that's the code he's working on
1192019-08-03T00:41:43  <elichai2> oh haha, this is my WIP for taproot descriptors
1202019-08-03T00:42:04  <achow101> elichai2: watchonly in native descriptor wallets just means that the wallet doesn't have any private keys at all
1212019-08-03T00:42:32  <emilengler> elichai2: ok cool, good luck
1222019-08-03T00:42:33  <elichai2> achow101: how will you import such thing? just as an address?
1232019-08-03T00:42:37  <elichai2> emilengler: thanks :)
1242019-08-03T00:42:45  <achow101> even still, nothing is ever explicitly labeled as watchonly like how it is with legacy wallets
1252019-08-03T00:43:06  <achow101> e.g. right now, if you import an address, ismine will return ISMINE_WATCHONLY
1262019-08-03T00:43:34  <achow101> in native descriptor wallets, it will return ISMINE_SPENDABLE since ismine in native descriptor wallets is really just a bool
1272019-08-03T00:43:54  <gwillen> with multiwallet, I have claimed and continue to claim that the most reasonable thing is to have spendable and watchonly wallets be completely separate wallet.dat files
1282019-08-03T00:44:06  <gwillen> then there is no need to dispute over what "watch only" means because you pick
1292019-08-03T00:44:10  <sipa> gwillen: yes, that's what's happening
1302019-08-03T00:44:18  <sipa> the concept of watch only goes away with descriptor wallets
1312019-08-03T00:44:37  <achow101> elichai2: there's an importdescriptors RPC to import things into descriptor wallets. the rest of the import RPCs are disallowed for them
1322019-08-03T00:44:42  <sipa> something is treated as ours, or not
1332019-08-03T00:44:50  <gwillen> so then the answer to "how does watchonly work" is "any way you want to, you name one of your wallets watchonly.dat and then import whichever keys you want there"
1342019-08-03T00:45:35  <achow101> gwillen: pretty much. right now descriptor wallets is not allowing a mix of having private keys and not having them. I'll probably change that before it goes out of WIP
1352019-08-03T00:46:07  <gwillen> (I think if you import "just as an address", you can watch, but you won't be able to prepare transactions for offline signing, which would require public keys, redeemscipts, etc. in addition to addresses)
1362019-08-03T00:46:24  <elichai2> sipa: unrelated to anything. rebasing a branch with your subtree commit in it is hell lol (which is why I ended up merging instead)
1372019-08-03T00:46:52  <sipa> elichai2: oh you can't rebase subtrees
1382019-08-03T00:47:04  <sipa> i always just redo them
1392019-08-03T00:47:26  <elichai2> sipa: oh really? so when you'll open the taproot PR you'll redo those commits?
1402019-08-03T00:47:32  <gwillen> (but you can choose which way you do it dependding on what the particular wallet's function is for you)
1412019-08-03T00:47:48  <sipa> elichai2: or anytime i rebase
1422019-08-03T00:47:52  <sipa> they're trivial anyway
1432019-08-03T00:47:57  <achow101> sipa: with miniscript and taproot, is the expectation that the wallet will have some of the keys for satisfying?
1442019-08-03T00:48:09  <sipa> achow101: same as multisig
1452019-08-03T00:48:16  <sipa> i don
1462019-08-03T00:48:25  <sipa> i don't think we should care whether the user has keys locally or not
1472019-08-03T00:48:34  <sipa> if he has any, it'll likely not be all of them
1482019-08-03T00:48:50  <elichai2> ha. I tried to do it using rebasing. I tried every trick in the book lol so I gave up. when my commits will be more than a WIP i'll rebase them on top of a manual thing instead of a rebase
1492019-08-03T00:49:11  <sipa> i'll do a rebase of my taproot branch soon
1502019-08-03T00:49:42  <elichai2> that's fine as long as I don't publish my code there's nothing wrong with it being on top of a merge commit
1512019-08-03T00:49:55  <achow101> sipa: right now in descriptor wallets, if we have private keys enabled, we require all of the private keys to be available in order to import a descriptor. that's probably wrong, but I haven't had the chance to really think through it
1522019-08-03T00:50:05  <sipa> achow101: yeah i think that's wrong
1532019-08-03T00:50:24  <sipa> though it may make sense to configure the wallet to be "strictly single key, all keys present" or so, as a sanity check
1542019-08-03T00:50:49  <sipa> another possible setting for sanity checking could be "have at least one participating key in every descriptor"
1552019-08-03T00:50:58  <elichai2> achow101: right now as in your pr or as in master?
1562019-08-03T00:51:11  <sipa> elichai2: descriptor wallets only exist as a PR
1572019-08-03T00:51:12  <achow101> I was unsure whether to allow importing a descriptor that had to priv keys to a privkey enabled wallet
1582019-08-03T00:51:25  <achow101> s/had to priv keys/had no privkeys
1592019-08-03T00:51:43  <elichai2> sipa: right. that was a sanity check because I don't remember any privkey stuff in the descriptors so I wasn't sure what's up
1602019-08-03T00:52:08  <elichai2> achow101: hmm maybe it should be have enough keys to sign for that desc?
1612019-08-03T00:52:24  <sipa> elichai2: that's uninteresting
1622019-08-03T00:52:37  <achow101> the two ideas I was considering were "enough to sign" and "have at least one key"
1632019-08-03T00:52:42  <sipa> if you have a sufficient number of keys locally to sign, you shouldn't be using anything but single key
1642019-08-03T00:52:51  <achow101> right
1652019-08-03T00:52:57  <achow101> so I think I'll go with the latter
1662019-08-03T00:53:13  <sipa> that makes sense
1672019-08-03T00:53:26  *** pinheadmz has quit IRC
1682019-08-03T00:53:38  <elichai2> hmmm. so after you create the pubkeys map you make sure that you have at least one priv key? (or when you enter them into the map you could just set a bool)
1692019-08-03T00:54:11  <achow101> elichai2: basically
1702019-08-03T00:54:28  <achow101> haven't actually thought through the implementation
1712019-08-03T00:54:40  <elichai2> cool. when do you think the PR will be ready for review?
1722019-08-03T00:54:47  <achow101> elichai2: soon(tm)
1732019-08-03T00:54:51  <achow101> :)
1742019-08-03T00:55:31  <elichai2> what's this tm thing? 😅
1752019-08-03T00:56:06  <sipa> https://en.wikipedia.org/wiki/Trademark_symbol
1762019-08-03T00:56:06  <achow101> It's a meme about Blizzard and Valve taking forever to release video games
1772019-08-03T00:56:08  <achow101> "Soon™: Copyright pending 2004-2019 Blizzard Entertainment, Inc. All rights reserved. "Soon™" does not imply any particular date, time, decade, century, or millennia in the past, present, and certainly not the future. "Soon" shall make no contract or warranty between Blizzard Entertainment and the end user. "Soon" will arrive some day, Blizzard does guarantee that "soon" will be here before the end of time. Maybe. Do not m
1782019-08-03T00:56:09  <achow101> ake plans based on "soon" as Blizzard will not be liable for any misuse, use, or even casual glancing at "soon.""
1792019-08-03T00:56:56  <sipa> it
1802019-08-03T00:57:02  <sipa> it's older than blizzard
1812019-08-03T00:57:15  <elichai2> ohhh
1822019-08-03T00:57:38  <elichai2> I googled `tm` and I actually found the tarkemark but didn't get the joke lol
1832019-08-03T00:59:52  *** lightlike has quit IRC
1842019-08-03T01:02:03  *** captjakk has quit IRC
1852019-08-03T01:04:57  <achow101> elichai2: native descriptor wallets depends on the rework pr (#16341) to be merged first, so it will be ready only after that happens
1862019-08-03T01:05:00  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
1872019-08-03T01:05:04  *** davterra has quit IRC
1882019-08-03T01:05:26  <achow101> given that 16341 is really big, it might take a while
1892019-08-03T01:09:33  *** btcquant has joined #bitcoin-core-dev
1902019-08-03T01:11:56  *** justan0theruser has joined #bitcoin-core-dev
1912019-08-03T01:12:08  *** justanotheruser has quit IRC
1922019-08-03T01:12:16  <elichai2> ok, so I guess I'll try to review that one on Monday :)  (though I don't know too much about the wallet itself)
1932019-08-03T01:13:00  *** justan0theruser is now known as justanotheruser
1942019-08-03T01:13:56  *** emilengler has quit IRC
1952019-08-03T01:17:26  *** jarthur has quit IRC
1962019-08-03T01:17:50  *** emilengler has joined #bitcoin-core-dev
1972019-08-03T01:26:19  *** promag has quit IRC
1982019-08-03T01:43:12  *** promag has joined #bitcoin-core-dev
1992019-08-03T01:50:39  *** Karyon has quit IRC
2002019-08-03T01:52:18  *** Karyon has joined #bitcoin-core-dev
2012019-08-03T02:03:41  *** CubicEarth has quit IRC
2022019-08-03T02:07:46  *** CubicEarth has joined #bitcoin-core-dev
2032019-08-03T02:12:29  <fanquake> achow101: "Descriptors" with a horrible yellow colour
2042019-08-03T02:21:22  <emilengler> Where are the blocks being written to the disk (file, function)?
2052019-08-03T02:21:33  *** promag has quit IRC
2062019-08-03T02:21:39  <emilengler> And how do the blocks are even stored? An urban hymn says through leveldb
2072019-08-03T02:22:16  <emilengler> So is there a concret place in the src where the actual writing process happens?
2082019-08-03T02:22:35  <achow101> emilengler: somewhere in validation.cpp
2092019-08-03T02:23:14  <emilengler> achow101: thanks
2102019-08-03T02:23:15  <achow101> blocks are written to the blk*.dat files in the blocks/ folder. leveldb is used for the indexes and other databases
2112019-08-03T02:24:41  <achow101> emilengler: look at AcceptBlock, FlushStateToDisk, and FlushBlockFile
2122019-08-03T02:25:01  <achow101> and SaveBlockToDisk
2132019-08-03T02:25:28  <emilengler> Ok, I will check it :)
2142019-08-03T02:27:32  *** uagerugh has joined #bitcoin-core-dev
2152019-08-03T02:28:19  *** uagerugh has quit IRC
2162019-08-03T02:29:47  <emilengler> By the way what is the AppVeyor thing and is it normal that it takes forever to finish?
2172019-08-03T02:30:28  <sipa> it's a windows CI
2182019-08-03T02:34:00  <emilengler> It might be buggy, the status on a GitHub PR which I started a month ago isn't being updated even the build was a success
2192019-08-03T02:35:04  <sipa> it absolutely is
2202019-08-03T02:35:12  <sipa> :)
2212019-08-03T02:35:24  <emilengler> Good to know :D
2222019-08-03T02:35:38  <emilengler> No wonder it's windows...
2232019-08-03T02:37:52  <mryandao> is there a reason why lots of the logic going on in validation.cpp does not get refactored out into other files?
2242019-08-03T02:38:14  <sipa> mryandao: because refactoring is hard
2252019-08-03T02:38:20  <sipa> especially consensus critical code
2262019-08-03T02:38:45  <mryandao> I see.
2272019-08-03T02:38:45  *** xzytrewq has joined #bitcoin-core-dev
2282019-08-03T02:41:01  <emilengler> Refactoring can often lead to some new bugs. Bugs in the consensus are a HUGE problem. A refactor of it would probably take lots of testing and reviewing
2292019-08-03T02:45:41  <sipa> there are always efforts to refactor things here and there
2302019-08-03T02:45:45  <sipa> over time lots of code has moved
2312019-08-03T02:46:02  *** xzytrewq has quit IRC
2322019-08-03T02:46:18  <achow101> i remember good ol main.cpp
2332019-08-03T02:47:03  <sipa> in 2010 there was main.cpp which contained all of what is now validation/net_processing/net/wallet/protocol/coins/pow/...
2342019-08-03T02:47:49  <emilengler> I never saw it but the file where the main class is, is mostly bloated. Know this from my personal projects. It might be a curse of C++...
2352019-08-03T02:48:04  <emilengler> Bloated at the beginning at least
2362019-08-03T02:48:13  <mryandao> i believe at 0.12 it was a bloated main.cpp
2372019-08-03T02:48:23  <mryandao> that is not too long ago
2382019-08-03T02:48:26  <achow101> checkout some of the older tags, you'll see it there
2392019-08-03T02:48:47  <mryandao> the hong kong agreement drama times
2402019-08-03T02:49:59  <achow101> main.cpp was only split up and removed in 0.14
2412019-08-03T02:50:21  *** pinheadmz has joined #bitcoin-core-dev
2422019-08-03T02:51:02  <emilengler> I'm currently looking at v0.3.0
2432019-08-03T02:51:20  <emilengler> It is bloated in terms of v0.3.0 but not in terms of v0.18 :P
2442019-08-03T02:51:33  <emilengler> the main file^^
2452019-08-03T02:51:34  <mryandao> i hear poker logic existed in 0.1 or something
2462019-08-03T02:51:34  <sipa> well, the code gained a lot of functionality since then
2472019-08-03T02:51:50  <mryandao> maybe somebody here can verify
2482019-08-03T02:51:51  <sipa> it's unfair to compare total complexity; of course it'll be more complex now
2492019-08-03T02:52:02  <achow101> mryandao: checkout v0.1.5 and look for yourself
2502019-08-03T02:52:03  <emilengler> Sure
2512019-08-03T02:52:08  <sipa> but in https://github.com/bitcoin/bitcoin/blob/v0.3.17/main.cpp you'll find direct calls from main.cpp into the UI :p
2522019-08-03T02:52:16  <sipa> which is unthinkable now
2532019-08-03T02:52:42  <achow101> I seem to remember that at one point in time that main.cpp was large enough (and github shitty enough) that it wouldn't be fully rendered
2542019-08-03T02:52:55  <sipa> yeah
2552019-08-03T02:53:24  *** AaronvanW has quit IRC
2562019-08-03T02:54:07  <emilengler> <joke>If it hadn't been splitted up, it would be a git lfs file today</joke>
2572019-08-03T02:55:05  <mryandao> v0.1.5 is so minimalist
2582019-08-03T02:55:08  <mryandao> i like.
2592019-08-03T02:55:46  <mryandao> could maintain with just vanilla vim without plugins
2602019-08-03T02:56:16  <achow101> it's windows and gui only, so you wouldn't be using vim to dev it
2612019-08-03T02:56:39  <mryandao> there's gvim on windows
2622019-08-03T02:56:47  <emilengler> Is vim that bad on windows?
2632019-08-03T02:57:00  <elichai2> Windows is that bad period.
2642019-08-03T02:57:18  <emilengler> ACK
2652019-08-03T02:57:27  <achow101> well vanilla vim doesn't exist on windows
2662019-08-03T02:57:54  <emilengler> achow101: What do you mean by this
2672019-08-03T02:58:02  <mryandao> i cant find poker in v0.1.5
2682019-08-03T02:58:22  <emilengler> mryandao: IIRC the poker was only a GUI thing
2692019-08-03T02:58:32  <emilengler> You could try to open the project with a wxWidgets editor
2702019-08-03T02:58:38  <emilengler> Then you might find something
2712019-08-03T02:59:05  <mryandao> oh, i see it now.
2722019-08-03T02:59:07  <mryandao> thanks.
2732019-08-03T02:59:28  <mryandao> lol, what a meme.
2742019-08-03T02:59:41  <achow101> I thought poker was pre-release
2752019-08-03T03:00:02  *** paulk has quit IRC
2762019-08-03T03:00:10  <emilengler> achow101: A friend of me is compiling vanilla vim for windows around every 2 days
2772019-08-03T03:00:34  <achow101> emilengler: TIL
2782019-08-03T03:00:37  <emilengler> There is also a real vim binary for windows (Not the gui stuff)
2792019-08-03T03:01:15  <achow101> I didn't know that the vim project actually published windows releases
2802019-08-03T03:02:01  <emilengler> IIRC they still don't
2812019-08-03T03:02:21  <emilengler> You need to compile it on your own or use pre-compiled online binaries from others
2822019-08-03T03:02:46  <emilengler> But they support windows in terms of cross-platform
2832019-08-03T03:03:00  <emilengler> Same with Bitcoin Core and FreeBSD for example
2842019-08-03T03:03:22  <achow101> ah
2852019-08-03T03:03:59  <achow101> fun fact, bitcoin 0.1 was released before Windows 7
2862019-08-03T03:05:47  *** rex4539 has joined #bitcoin-core-dev
2872019-08-03T03:06:11  <emilengler> achow101: You're right but I never thought of it
2882019-08-03T03:06:38  <emilengler> It was probably compiled on Windows XP because the screenshots from satoshi had this old winxp theming
2892019-08-03T03:07:54  *** rex4539 has quit IRC
2902019-08-03T03:08:03  *** esotericnonsense has quit IRC
2912019-08-03T03:08:08  *** emilengler has quit IRC
2922019-08-03T03:09:42  *** esotericnonsense has joined #bitcoin-core-dev
2932019-08-03T03:15:42  *** tryphe has quit IRC
2942019-08-03T03:16:31  *** tryphe has joined #bitcoin-core-dev
2952019-08-03T03:18:23  *** davec has quit IRC
2962019-08-03T03:18:48  *** Toflar has joined #bitcoin-core-dev
2972019-08-03T03:26:18  *** davec has joined #bitcoin-core-dev
2982019-08-03T03:27:40  *** AaronvanW has joined #bitcoin-core-dev
2992019-08-03T03:28:47  *** Victor_sueca has quit IRC
3002019-08-03T03:32:36  *** AaronvanW has quit IRC
3012019-08-03T03:36:52  *** mzygar has joined #bitcoin-core-dev
3022019-08-03T03:40:12  *** jb55 has quit IRC
3032019-08-03T03:41:42  *** mzygar has quit IRC
3042019-08-03T04:01:54  *** AaronvanW has joined #bitcoin-core-dev
3052019-08-03T04:35:37  *** AaronvanW has quit IRC
3062019-08-03T04:50:19  *** bulias has joined #bitcoin-core-dev
3072019-08-03T04:50:41  *** bulias has left #bitcoin-core-dev
3082019-08-03T04:51:38  *** anewjoiner has joined #bitcoin-core-dev
3092019-08-03T04:57:07  *** kcalvinalvin has joined #bitcoin-core-dev
3102019-08-03T05:02:48  *** hebasto has joined #bitcoin-core-dev
3112019-08-03T05:13:54  *** elichai2 has quit IRC
3122019-08-03T05:32:15  *** anewjoiner has quit IRC
3132019-08-03T06:00:01  *** Toflar has quit IRC
3142019-08-03T06:18:54  *** bugbot1 has joined #bitcoin-core-dev
3152019-08-03T06:32:43  *** AaronvanW has joined #bitcoin-core-dev
3162019-08-03T07:05:16  *** AaronvanW has quit IRC
3172019-08-03T07:07:42  *** Victorsueca has joined #bitcoin-core-dev
3182019-08-03T07:09:03  *** octomatic has joined #bitcoin-core-dev
3192019-08-03T07:14:59  *** promag has joined #bitcoin-core-dev
3202019-08-03T07:17:32  *** kcalvinalvin has quit IRC
3212019-08-03T07:26:23  *** promag has quit IRC
3222019-08-03T07:28:07  *** octomatic has quit IRC
3232019-08-03T07:29:50  *** octomatic has joined #bitcoin-core-dev
3242019-08-03T07:31:12  *** AaronvanW has joined #bitcoin-core-dev
3252019-08-03T07:40:28  *** promag has joined #bitcoin-core-dev
3262019-08-03T07:41:23  *** jkczyz has quit IRC
3272019-08-03T07:41:31  *** nappingCommodore has joined #bitcoin-core-dev
3282019-08-03T07:47:18  *** octomati_ has joined #bitcoin-core-dev
3292019-08-03T07:48:31  *** octomatic has quit IRC
3302019-08-03T07:56:30  *** promag has quit IRC
3312019-08-03T07:56:58  *** octomati_ has quit IRC
3322019-08-03T08:01:54  *** jkczyz has joined #bitcoin-core-dev
3332019-08-03T08:26:35  *** nappingCommodore has quit IRC
3342019-08-03T08:44:39  *** justanotheruser has quit IRC
3352019-08-03T08:49:44  *** mzygar has joined #bitcoin-core-dev
3362019-08-03T09:00:02  *** bugbot1 has quit IRC
3372019-08-03T09:05:05  *** justanotheruser has joined #bitcoin-core-dev
3382019-08-03T09:32:26  *** andyrtr1 has joined #bitcoin-core-dev
3392019-08-03T09:33:04  *** mzygar has quit IRC
3402019-08-03T09:43:08  *** Jackielove4u has quit IRC
3412019-08-03T09:43:08  *** wbnns has quit IRC
3422019-08-03T09:43:19  *** Jackielove4u has joined #bitcoin-core-dev
3432019-08-03T09:43:27  *** wbnns has joined #bitcoin-core-dev
3442019-08-03T09:43:30  *** pierre_rochard has quit IRC
3452019-08-03T09:43:30  *** schmidty has quit IRC
3462019-08-03T09:43:45  *** pierre_rochard has joined #bitcoin-core-dev
3472019-08-03T09:43:52  *** hsmiths has quit IRC
3482019-08-03T09:44:36  *** fjahr has quit IRC
3492019-08-03T09:44:36  *** vfP56jSe has quit IRC
3502019-08-03T09:44:36  *** dongcarl has quit IRC
3512019-08-03T09:44:58  *** ccook has quit IRC
3522019-08-03T09:44:58  *** slimcognito has quit IRC
3532019-08-03T09:46:26  *** nothingmuch has quit IRC
3542019-08-03T09:47:22  *** dongcarl has joined #bitcoin-core-dev
3552019-08-03T09:50:18  *** nothingmuch has joined #bitcoin-core-dev
3562019-08-03T09:51:57  *** slimcognito has joined #bitcoin-core-dev
3572019-08-03T09:58:40  *** schmidty has joined #bitcoin-core-dev
3582019-08-03T09:59:02  *** hsmiths has joined #bitcoin-core-dev
3592019-08-03T09:59:47  *** vfP56jSe has joined #bitcoin-core-dev
3602019-08-03T10:00:09  *** ccook has joined #bitcoin-core-dev
3612019-08-03T10:00:23  *** fjahr has joined #bitcoin-core-dev
3622019-08-03T10:02:50  *** ercwl has joined #bitcoin-core-dev
3632019-08-03T10:04:42  *** joseph-dev has joined #bitcoin-core-dev
3642019-08-03T10:31:03  *** ercwl has quit IRC
3652019-08-03T10:37:01  *** tryphe has quit IRC
3662019-08-03T10:37:29  *** tryphe has joined #bitcoin-core-dev
3672019-08-03T10:52:10  *** tryphe has quit IRC
3682019-08-03T10:53:11  *** tryphe has joined #bitcoin-core-dev
3692019-08-03T11:02:33  *** laptop500 has quit IRC
3702019-08-03T11:05:35  *** jonatack has quit IRC
3712019-08-03T11:14:39  *** jonatack has joined #bitcoin-core-dev
3722019-08-03T11:55:10  *** Victorsueca has quit IRC
3732019-08-03T11:55:16  *** Victor_sueca has joined #bitcoin-core-dev
3742019-08-03T11:57:05  *** lnostdal has joined #bitcoin-core-dev
3752019-08-03T12:00:01  *** andyrtr1 has quit IRC
3762019-08-03T12:37:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3772019-08-03T12:53:32  <joseph-dev> Hello?
3782019-08-03T13:05:27  *** manishearth1 has joined #bitcoin-core-dev
3792019-08-03T13:10:02  *** dgfhdfg has joined #bitcoin-core-dev
3802019-08-03T13:11:34  *** laptop500 has joined #bitcoin-core-dev
3812019-08-03T13:13:45  *** lightlike has joined #bitcoin-core-dev
3822019-08-03T13:13:54  *** lightlike has left #bitcoin-core-dev
3832019-08-03T13:14:09  *** lightlike has joined #bitcoin-core-dev
3842019-08-03T13:29:12  *** Victor_sueca has quit IRC
3852019-08-03T13:29:28  *** Victorsueca has joined #bitcoin-core-dev
3862019-08-03T13:29:59  *** mzygar has joined #bitcoin-core-dev
3872019-08-03T13:34:13  *** mzygar has quit IRC
3882019-08-03T13:36:19  *** lnostdal has quit IRC
3892019-08-03T13:36:44  *** justanotheruser has quit IRC
3902019-08-03T13:40:31  *** ptiyoyip has joined #bitcoin-core-dev
3912019-08-03T13:44:08  *** dgfhdfg has quit IRC
3922019-08-03T13:44:26  *** keifis has quit IRC
3932019-08-03T13:47:57  *** Chris_Stewart_5 has quit IRC
3942019-08-03T13:49:29  *** Guyver2 has joined #bitcoin-core-dev
3952019-08-03T13:49:42  *** AaronvanW has quit IRC
3962019-08-03T13:53:17  *** justanotheruser has joined #bitcoin-core-dev
3972019-08-03T14:27:47  *** emzy_ is now known as Emzy
3982019-08-03T14:33:54  *** esotericnonsense has quit IRC
3992019-08-03T14:47:04  *** esotericnonsense has joined #bitcoin-core-dev
4002019-08-03T14:48:52  *** esotericnonsense has quit IRC
4012019-08-03T14:49:38  *** queip has quit IRC
4022019-08-03T14:53:45  *** esotericnonsense has joined #bitcoin-core-dev
4032019-08-03T15:00:02  *** manishearth1 has quit IRC
4042019-08-03T15:01:31  *** justanotheruser has quit IRC
4052019-08-03T15:01:49  *** justanotheruser has joined #bitcoin-core-dev
4062019-08-03T15:03:54  *** queip has joined #bitcoin-core-dev
4072019-08-03T15:15:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4082019-08-03T15:23:45  *** bashco has quit IRC
4092019-08-03T15:23:55  *** bashco has joined #bitcoin-core-dev
4102019-08-03T15:23:57  *** kristapsk has quit IRC
4112019-08-03T15:23:57  *** mryandao has quit IRC
4122019-08-03T15:26:50  *** rah1 has joined #bitcoin-core-dev
4132019-08-03T15:29:32  *** Chris_Stewart_5 has quit IRC
4142019-08-03T15:38:22  *** bitcoin-git has joined #bitcoin-core-dev
4152019-08-03T15:38:22  <bitcoin-git> [bitcoin] mmachicao closed pull request #15137: Tests: Contract test for CCoinsView and CCoinsViewBacked (master...coins_contract_tests) https://github.com/bitcoin/bitcoin/pull/15137
4162019-08-03T15:38:35  *** bitcoin-git has left #bitcoin-core-dev
4172019-08-03T15:42:02  *** ezegom has joined #bitcoin-core-dev
4182019-08-03T15:47:49  *** ercwl has joined #bitcoin-core-dev
4192019-08-03T15:48:31  *** Krellan has joined #bitcoin-core-dev
4202019-08-03T15:48:31  *** ezegom has quit IRC
4212019-08-03T15:48:51  *** ezegom has joined #bitcoin-core-dev
4222019-08-03T15:56:06  *** Xunie__ has quit IRC
4232019-08-03T16:17:51  *** ezegom has quit IRC
4242019-08-03T16:24:37  *** Victorsueca has quit IRC
4252019-08-03T16:28:53  *** mdunnio has joined #bitcoin-core-dev
4262019-08-03T16:36:54  *** mdunnio has quit IRC
4272019-08-03T16:38:15  *** mdunnio has joined #bitcoin-core-dev
4282019-08-03T16:45:28  *** darosior has quit IRC
4292019-08-03T16:52:14  *** mdunnio has quit IRC
4302019-08-03T17:02:09  *** qubenix has quit IRC
4312019-08-03T17:03:13  *** Krellan has quit IRC
4322019-08-03T17:05:37  *** qubenix has joined #bitcoin-core-dev
4332019-08-03T17:26:03  *** rex4539 has joined #bitcoin-core-dev
4342019-08-03T17:27:54  *** ercwl has quit IRC
4352019-08-03T17:30:36  *** mzygar has joined #bitcoin-core-dev
4362019-08-03T17:35:05  *** mzygar has quit IRC
4372019-08-03T18:00:02  *** rah1 has quit IRC
4382019-08-03T18:02:30  *** pinheadmz has quit IRC
4392019-08-03T18:02:38  *** Raystonn has quit IRC
4402019-08-03T18:03:09  *** Raystonn has joined #bitcoin-core-dev
4412019-08-03T18:13:09  *** captjakk has joined #bitcoin-core-dev
4422019-08-03T18:15:28  *** darosior has joined #bitcoin-core-dev
4432019-08-03T18:17:23  *** belcher has quit IRC
4442019-08-03T18:18:00  *** belcher has joined #bitcoin-core-dev
4452019-08-03T18:53:07  *** d_t has joined #bitcoin-core-dev
4462019-08-03T18:57:39  *** d_t has quit IRC
4472019-08-03T19:04:29  *** d_t has joined #bitcoin-core-dev
4482019-08-03T19:19:04  *** lnostdal has joined #bitcoin-core-dev
4492019-08-03T19:35:58  *** jb55 has joined #bitcoin-core-dev
4502019-08-03T19:40:28  *** ryufghj has joined #bitcoin-core-dev
4512019-08-03T19:44:13  *** ptiyoyip has quit IRC
4522019-08-03T19:46:52  *** ryufghj has quit IRC
4532019-08-03T19:47:19  *** ryufghj has joined #bitcoin-core-dev
4542019-08-03T19:53:30  *** byte[]1 has joined #bitcoin-core-dev
4552019-08-03T19:55:22  *** darosior has quit IRC
4562019-08-03T19:57:24  *** darosior has joined #bitcoin-core-dev
4572019-08-03T20:28:58  *** Guyver2 has quit IRC
4582019-08-03T20:31:14  *** lnostdal has quit IRC
4592019-08-03T20:33:28  *** ercwl has joined #bitcoin-core-dev
4602019-08-03T20:33:44  *** Victorsueca has joined #bitcoin-core-dev
4612019-08-03T20:53:45  *** captjakk has quit IRC
4622019-08-03T20:59:11  *** DeanGuss has joined #bitcoin-core-dev
4632019-08-03T21:00:02  *** byte[]1 has quit IRC
4642019-08-03T21:03:48  *** dgenr8 has quit IRC
4652019-08-03T21:09:23  *** darosior has quit IRC
4662019-08-03T21:10:01  *** hebasto has quit IRC
4672019-08-03T21:10:03  *** ossifrage has quit IRC
4682019-08-03T21:10:33  *** ossifrage has joined #bitcoin-core-dev
4692019-08-03T21:11:51  *** hebasto has joined #bitcoin-core-dev
4702019-08-03T21:14:36  *** captjakk has joined #bitcoin-core-dev
4712019-08-03T21:17:51  *** binbasti has joined #bitcoin-core-dev
4722019-08-03T21:30:40  *** mzygar has joined #bitcoin-core-dev
4732019-08-03T21:35:02  *** mzygar has quit IRC
4742019-08-03T21:44:55  *** darosior has joined #bitcoin-core-dev
4752019-08-03T21:49:53  *** emilengler has joined #bitcoin-core-dev
4762019-08-03T21:58:51  *** rex4539 has quit IRC
4772019-08-03T22:02:33  *** darosior has quit IRC
4782019-08-03T22:03:44  *** darosior has joined #bitcoin-core-dev
4792019-08-03T22:27:19  *** ercwl has quit IRC
4802019-08-03T22:35:47  *** elichai2 has joined #bitcoin-core-dev
4812019-08-03T22:44:48  *** dgenr8 has joined #bitcoin-core-dev
4822019-08-03T22:57:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4832019-08-03T23:01:41  *** Victorsueca has quit IRC
4842019-08-03T23:02:49  *** Victorsueca has joined #bitcoin-core-dev
4852019-08-03T23:08:09  *** mryandao has joined #bitcoin-core-dev
4862019-08-03T23:10:28  *** promag has joined #bitcoin-core-dev
4872019-08-03T23:15:52  *** Chris_Stewart_5 has quit IRC
4882019-08-03T23:18:24  *** dgfhdfg has joined #bitcoin-core-dev
4892019-08-03T23:20:39  *** ryufghj has quit IRC
4902019-08-03T23:39:43  <emilengler> Hope it's ok to ask this question here, because I need it for Bitcoin Core development. How can I sign a commit which include squashed commits. Everytime I squash commits the "parent" commit is unsigned
4912019-08-03T23:44:35  <gwillen> emilengler: when you squash commits, you destroy the old commits that you squashed, and signatures on them are no good
4922019-08-03T23:44:45  <gwillen> you would then need to sign the squashed commit
4932019-08-03T23:45:06  <gwillen> perhaps you could elaborate on what you're trying to do
4942019-08-03T23:45:37  *** sdaftuar has quit IRC
4952019-08-03T23:46:03  *** sdaftuar has joined #bitcoin-core-dev
4962019-08-03T23:47:31  *** lightlike has quit IRC
4972019-08-03T23:48:31  *** dgfhdfg has quit IRC