12019-08-14T00:00:02 *** Darki1 has quit IRC
22019-08-14T00:05:07 *** visser_ has joined #bitcoin-core-dev
32019-08-14T00:11:03 *** promag has joined #bitcoin-core-dev
42019-08-14T00:15:31 *** promag has quit IRC
52019-08-14T00:45:12 <pinheadmz> luke-jr: can you elaborate? How can any block not be subject to a better-work chain?
62019-08-14T00:48:40 *** kljasdfvv has quit IRC
72019-08-14T00:48:46 <harding> pinheadmz: the bad block corrupts the utxo db so that other chains don't look like valid chains to the old software.
82019-08-14T00:49:04 *** kljasdfvv has joined #bitcoin-core-dev
92019-08-14T00:50:06 <pinheadmz> harding: weird, thanks.
102019-08-14T00:50:09 *** elichai2 has quit IRC
112019-08-14T00:57:57 *** dviola has quit IRC
122019-08-14T01:05:35 *** lightlike has quit IRC
132019-08-14T01:20:46 *** Dean_Guss has joined #bitcoin-core-dev
142019-08-14T01:27:59 *** xzytrewq has quit IRC
152019-08-14T01:29:29 *** xzytrewq has joined #bitcoin-core-dev
162019-08-14T01:40:08 *** AaronvanW has joined #bitcoin-core-dev
172019-08-14T01:57:32 *** EagleTM has quit IRC
182019-08-14T02:03:49 *** Dean_Guss has quit IRC
192019-08-14T02:05:15 *** Dean_Guss has joined #bitcoin-core-dev
202019-08-14T02:06:03 *** justanotheruser has quit IRC
212019-08-14T02:13:06 *** AaronvanW has quit IRC
222019-08-14T02:14:26 *** justanotheruser has joined #bitcoin-core-dev
232019-08-14T02:25:23 *** hanhua has joined #bitcoin-core-dev
242019-08-14T02:32:27 *** ddustin has joined #bitcoin-core-dev
252019-08-14T02:37:16 *** ddustin has quit IRC
262019-08-14T03:00:02 *** visser_ has quit IRC
272019-08-14T03:02:33 *** pinheadmz has quit IRC
282019-08-14T03:03:55 *** pinheadmz has joined #bitcoin-core-dev
292019-08-14T03:09:28 *** astro has quit IRC
302019-08-14T03:14:17 <kallewoof> luke-jr: I re-pushed it now that the first commit was merged. I assumed it wouldn't break as the commits were identical, but don't assume, I guess. trying to build now.
312019-08-14T03:16:13 *** astro has joined #bitcoin-core-dev
322019-08-14T03:37:06 *** ecrist1 has joined #bitcoin-core-dev
332019-08-14T03:39:40 <kallewoof> luke-jr: it builds fine on my end. (and travis/appveyor seem to have no issues either)
342019-08-14T03:40:55 <luke-jr> weird
352019-08-14T03:51:14 *** seeder has joined #bitcoin-core-dev
362019-08-14T04:09:40 *** AaronvanW has joined #bitcoin-core-dev
372019-08-14T04:13:50 *** hanhua has quit IRC
382019-08-14T04:18:11 *** ddustin has joined #bitcoin-core-dev
392019-08-14T04:30:01 *** hanhua has joined #bitcoin-core-dev
402019-08-14T04:42:57 *** AaronvanW has quit IRC
412019-08-14T04:43:58 *** lalitmee has joined #bitcoin-core-dev
422019-08-14T04:51:41 *** kristapsk has quit IRC
432019-08-14T04:52:07 *** kristapsk has joined #bitcoin-core-dev
442019-08-14T04:53:04 *** ppisati has quit IRC
452019-08-14T04:54:32 *** sdaftuar has quit IRC
462019-08-14T04:54:55 *** sdaftuar has joined #bitcoin-core-dev
472019-08-14T04:59:43 *** ppisati has joined #bitcoin-core-dev
482019-08-14T05:24:28 *** promag has joined #bitcoin-core-dev
492019-08-14T05:28:47 *** promag has quit IRC
502019-08-14T05:41:23 *** anemous has quit IRC
512019-08-14T05:59:01 *** shesek has joined #bitcoin-core-dev
522019-08-14T05:59:01 *** shesek has joined #bitcoin-core-dev
532019-08-14T06:00:01 *** ecrist1 has quit IRC
542019-08-14T06:00:36 *** AaronvanW has joined #bitcoin-core-dev
552019-08-14T06:00:44 *** EagleTM has joined #bitcoin-core-dev
562019-08-14T06:00:52 *** seeder has quit IRC
572019-08-14T06:00:56 *** ddustin has quit IRC
582019-08-14T06:01:32 *** ddustin has joined #bitcoin-core-dev
592019-08-14T06:04:14 *** jonhcw has joined #bitcoin-core-dev
602019-08-14T06:06:04 *** ddustin has quit IRC
612019-08-14T06:13:12 *** bitcoin-git has joined #bitcoin-core-dev
622019-08-14T06:13:12 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b799ebcc17ea...c3b605cf1301
632019-08-14T06:13:13 <bitcoin-git> bitcoin/master fa7789f MarcoFalke: doc: Mention other ways to conserve memory on compilation
642019-08-14T06:13:13 <bitcoin-git> bitcoin/master c3b605c fanquake: Merge #16586: doc: Mention other ways to conserve memory on compilation
652019-08-14T06:13:16 *** bitcoin-git has left #bitcoin-core-dev
662019-08-14T06:14:22 *** bitcoin-git has joined #bitcoin-core-dev
672019-08-14T06:14:22 <bitcoin-git> [bitcoin] fanquake merged pull request #16586: doc: Mention other ways to conserve memory on compilation (master...1908-docLowMem) https://github.com/bitcoin/bitcoin/pull/16586
682019-08-14T06:14:24 *** bitcoin-git has left #bitcoin-core-dev
692019-08-14T06:19:37 *** EagleTM has quit IRC
702019-08-14T06:19:59 *** tryphe has quit IRC
712019-08-14T06:20:24 *** tryphe has joined #bitcoin-core-dev
722019-08-14T06:39:44 *** nosss2 has quit IRC
732019-08-14T06:46:31 *** bitcoin-git has joined #bitcoin-core-dev
742019-08-14T06:46:32 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b605cf1301...05ccbe9a2991
752019-08-14T06:46:32 <bitcoin-git> bitcoin/master afc0966 Elichai Turkel: Moved and renamed hash256 from util.py to zmq_interface.py
762019-08-14T06:46:33 <bitcoin-git> bitcoin/master 05ccbe9 fanquake: Merge #16598: test: Remove confusing hash256 function in util
772019-08-14T06:46:34 *** bitcoin-git has left #bitcoin-core-dev
782019-08-14T06:47:36 *** bitcoin-git has joined #bitcoin-core-dev
792019-08-14T06:47:37 <bitcoin-git> [bitcoin] fanquake merged pull request #16598: test: Remove confusing hash256 function in util (master...2019-08-rename-hash256) https://github.com/bitcoin/bitcoin/pull/16598
802019-08-14T06:47:38 *** bitcoin-git has left #bitcoin-core-dev
812019-08-14T06:54:52 *** sdaftuar has quit IRC
822019-08-14T06:55:18 *** sdaftuar has joined #bitcoin-core-dev
832019-08-14T06:57:04 *** hanhua has quit IRC
842019-08-14T07:04:03 *** AaronvanW has quit IRC
852019-08-14T07:13:04 *** Dean_Guss has quit IRC
862019-08-14T07:13:48 *** lalitmee has quit IRC
872019-08-14T07:19:55 *** jungly has joined #bitcoin-core-dev
882019-08-14T07:34:12 *** xzytrewq has quit IRC
892019-08-14T07:50:45 *** kljasdfvv has quit IRC
902019-08-14T07:52:22 *** kljasdfvv has joined #bitcoin-core-dev
912019-08-14T08:03:20 *** lalitmee has joined #bitcoin-core-dev
922019-08-14T08:14:40 *** bitcoin-git has joined #bitcoin-core-dev
932019-08-14T08:14:40 <bitcoin-git> [bitcoin] fanquake closed pull request #15032: Nit fixes for PR 14565 (master...201812_pr_14565_nits) https://github.com/bitcoin/bitcoin/pull/15032
942019-08-14T08:14:44 *** bitcoin-git has left #bitcoin-core-dev
952019-08-14T08:37:04 *** jpe_ has joined #bitcoin-core-dev
962019-08-14T08:39:03 *** setpill has joined #bitcoin-core-dev
972019-08-14T08:41:09 *** timothy has joined #bitcoin-core-dev
982019-08-14T08:42:33 *** jpe_ has quit IRC
992019-08-14T08:53:56 *** AaronvanW has joined #bitcoin-core-dev
1002019-08-14T08:56:18 *** AaronvanW has quit IRC
1012019-08-14T09:00:01 *** jonhcw has quit IRC
1022019-08-14T09:01:05 *** drizztbsd has joined #bitcoin-core-dev
1032019-08-14T09:01:36 *** timothy has quit IRC
1042019-08-14T09:05:12 *** [42]1 has joined #bitcoin-core-dev
1052019-08-14T09:07:19 *** bitcoin-git has joined #bitcoin-core-dev
1062019-08-14T09:07:19 <bitcoin-git> [bitcoin] fanquake closed pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079
1072019-08-14T09:07:20 *** bitcoin-git has left #bitcoin-core-dev
1082019-08-14T09:15:02 *** AaronvanW has joined #bitcoin-core-dev
1092019-08-14T09:22:37 *** harrigan has joined #bitcoin-core-dev
1102019-08-14T09:28:06 *** jonatack has quit IRC
1112019-08-14T09:37:45 *** bitcoin-git has joined #bitcoin-core-dev
1122019-08-14T09:37:45 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05ccbe9a2991...b120645e8cfc
1132019-08-14T09:37:46 <bitcoin-git> bitcoin/master fa1e9c6 MarcoFalke: travis: Bump timeout from 50 minutes to 90
1142019-08-14T09:37:46 <bitcoin-git> bitcoin/master b120645 Wladimir J. van der Laan: Merge #16595: travis: use extended 90 minute timeout when available
1152019-08-14T09:37:48 *** bitcoin-git has left #bitcoin-core-dev
1162019-08-14T09:38:55 *** bitcoin-git has joined #bitcoin-core-dev
1172019-08-14T09:38:55 <bitcoin-git> [bitcoin] laanwj merged pull request #16595: travis: use extended 90 minute timeout when available (master...1908-travisNoTimeout) https://github.com/bitcoin/bitcoin/pull/16595
1182019-08-14T09:38:59 *** bitcoin-git has left #bitcoin-core-dev
1192019-08-14T09:39:03 <fanquake> I've just closed the 0.18.1 milestone. https://github.com/bitcoin/bitcoin/milestones/41
1202019-08-14T09:45:35 <meshcollider> is it too late to add a missing contributor to the 0.18.1 release notes?
1212019-08-14T09:46:22 <meshcollider> fanquake: advice? ^
1222019-08-14T09:47:28 <fanquake> meshcollider: You could add them to the release notes on GH I guess? Obviously too late for the mailing lists etc
1232019-08-14T09:47:53 <meshcollider> ok just wanted to check there wasn't a policy against amending release notes in branches
1242019-08-14T09:48:13 <meshcollider> specifically it is the reporter of this issue #16011 who followed up with PR #16012 and helped with 16022 among others
1252019-08-14T09:48:14 <gribble> https://github.com/bitcoin/bitcoin/issues/16011 | addmultisigaddress does not fallback to legacy when there are uncompressed public keys in the parameters · Issue #16011 · bitcoin/bitcoin · GitHub
1262019-08-14T09:48:17 <gribble> https://github.com/bitcoin/bitcoin/issues/16012 | rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided by ps1dr3x · Pull Request #16012 · bitcoin/bitcoin · GitHub
1272019-08-14T09:48:22 <meshcollider> I think he should definitely be acknowledged
1282019-08-14T09:50:07 <fanquake> meshcollider fair enough. I don't have a problem with it, and it's right after release. What we don't like it someone turning up and "fixing" typos in the 0.5.x release notes etc
1292019-08-14T09:50:32 <meshcollider> fanquake: yeah, makes sense :)
1302019-08-14T09:58:55 *** bitcoin-git has joined #bitcoin-core-dev
1312019-08-14T09:58:55 <bitcoin-git> [bitcoin] meshcollider opened pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
1322019-08-14T09:58:57 *** bitcoin-git has left #bitcoin-core-dev
1332019-08-14T10:20:53 *** bitcoin-git has joined #bitcoin-core-dev
1342019-08-14T10:20:54 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b120645e8cfc...b49e7796c298
1352019-08-14T10:20:55 <bitcoin-git> bitcoin/master 3303124 fanquake: build: disable libxcb extensions
1362019-08-14T10:20:55 <bitcoin-git> bitcoin/master b49e779 Wladimir J. van der Laan: Merge #16533: build: disable libxcb extensions
1372019-08-14T10:21:07 *** bitcoin-git has left #bitcoin-core-dev
1382019-08-14T10:21:53 *** bitcoin-git has joined #bitcoin-core-dev
1392019-08-14T10:21:54 <bitcoin-git> [bitcoin] laanwj merged pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
1402019-08-14T10:21:55 *** bitcoin-git has left #bitcoin-core-dev
1412019-08-14T10:31:02 *** jonatack has joined #bitcoin-core-dev
1422019-08-14T10:41:04 *** bitcoin-git has joined #bitcoin-core-dev
1432019-08-14T10:41:04 <bitcoin-git> [bitcoin] meshcollider closed pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
1442019-08-14T10:41:18 *** bitcoin-git has left #bitcoin-core-dev
1452019-08-14T10:47:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1462019-08-14T10:50:02 *** jonatack has quit IRC
1472019-08-14T10:52:02 *** jonatack has joined #bitcoin-core-dev
1482019-08-14T11:03:57 *** bitcoin-git has joined #bitcoin-core-dev
1492019-08-14T11:03:57 <bitcoin-git> [bitcoin] meshcollider opened pull request #16605: Add missing contributor to 0.18.1 release notes (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
1502019-08-14T11:03:58 *** bitcoin-git has left #bitcoin-core-dev
1512019-08-14T11:04:01 *** lnostdal has joined #bitcoin-core-dev
1522019-08-14T11:08:08 *** jonatack has quit IRC
1532019-08-14T11:08:25 *** jonatack has joined #bitcoin-core-dev
1542019-08-14T11:08:56 *** bitcoin-git has joined #bitcoin-core-dev
1552019-08-14T11:08:56 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/fa27a0760792...bbc2970082a2
1562019-08-14T11:08:56 <bitcoin-git> bitcoin/0.18 bbc2970 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.1
1572019-08-14T11:08:59 *** bitcoin-git has left #bitcoin-core-dev
1582019-08-14T11:16:29 *** bitcoin-git has joined #bitcoin-core-dev
1592019-08-14T11:16:29 <bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
1602019-08-14T11:16:30 *** bitcoin-git has left #bitcoin-core-dev
1612019-08-14T11:17:15 *** bitcoin-git has joined #bitcoin-core-dev
1622019-08-14T11:17:15 <bitcoin-git> [bitcoin] fanquake closed pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
1632019-08-14T11:17:16 *** bitcoin-git has left #bitcoin-core-dev
1642019-08-14T11:18:31 *** bitcoin-git has joined #bitcoin-core-dev
1652019-08-14T11:18:31 <bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
1662019-08-14T11:18:36 *** bitcoin-git has left #bitcoin-core-dev
1672019-08-14T11:19:06 *** bitcoin-git has joined #bitcoin-core-dev
1682019-08-14T11:19:06 <bitcoin-git> [bitcoin] fanquake closed pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
1692019-08-14T11:19:20 *** bitcoin-git has left #bitcoin-core-dev
1702019-08-14T11:19:53 <wumpus> ugh PR spam
1712019-08-14T11:19:59 *** tryphe has quit IRC
1722019-08-14T11:20:25 *** tryphe has joined #bitcoin-core-dev
1732019-08-14T11:21:31 *** bitcoin-git has joined #bitcoin-core-dev
1742019-08-14T11:21:31 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b49e7796c298...286332495d43
1752019-08-14T11:21:32 <bitcoin-git> bitcoin/master 862cbf3 MeshCollider: Add missing contributor to release notes
1762019-08-14T11:21:32 <bitcoin-git> bitcoin/master 2863324 Wladimir J. van der Laan: Merge #16605: Add missing contributor to 0.18.1 release notes
1772019-08-14T11:21:34 *** bitcoin-git has left #bitcoin-core-dev
1782019-08-14T11:22:36 *** bitcoin-git has joined #bitcoin-core-dev
1792019-08-14T11:22:36 <bitcoin-git> [bitcoin] laanwj merged pull request #16605: Add missing contributor to 0.18.1 release notes (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
1802019-08-14T11:22:37 *** bitcoin-git has left #bitcoin-core-dev
1812019-08-14T11:31:04 *** bitcoin-git has joined #bitcoin-core-dev
1822019-08-14T11:31:06 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/286332495d43...e7df1ecd1758
1832019-08-14T11:31:06 <bitcoin-git> bitcoin/master 2290269 Sjors Provoost: scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg
1842019-08-14T11:31:07 <bitcoin-git> bitcoin/master 2e68ffa Sjors Provoost: [doc] descriptor: explain GetPubKey() usage with cached public key
1852019-08-14T11:31:08 <bitcoin-git> bitcoin/master e7df1ec Wladimir J. van der Laan: Merge #14934: Descriptor expansion cache clarifications
1862019-08-14T11:31:10 *** bitcoin-git has left #bitcoin-core-dev
1872019-08-14T11:31:24 *** bitcoin-git has joined #bitcoin-core-dev
1882019-08-14T11:31:24 <bitcoin-git> [bitcoin] laanwj merged pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
1892019-08-14T11:31:26 *** bitcoin-git has left #bitcoin-core-dev
1902019-08-14T11:32:28 *** queip has quit IRC
1912019-08-14T11:33:28 <fanquake> hopefully he's given up..
1922019-08-14T11:37:33 <fanquake> wumpus did that last pr break compiling on master ?
1932019-08-14T11:37:43 <fanquake> script/descriptor.cpp:495:13: error: use of undeclared identifier 'm_script_arg'
1942019-08-14T11:39:15 <wumpus> oh crap did it?
1952019-08-14T11:39:29 <wumpus> will try and revert if so
1962019-08-14T11:39:40 <fanquake> I think the fix may be trivial
1972019-08-14T11:39:45 <fanquake> just checking
1982019-08-14T11:40:53 <fanquake> wumpus: I can pr a fix now, if you'd rather not revert ?
1992019-08-14T11:42:35 <wumpus> if it's trivial, sure, if not, we might want to revert and go with this through review again
2002019-08-14T11:43:02 <fanquake> Should be a trivial 2-line change, just looks like a missed renaming.
2012019-08-14T11:43:15 <wumpus> must be code that was introduced since the PR
2022019-08-14T11:43:55 <wumpus> yes, it's pretty much documentation PR, and a renamed field, you'd say what can go wrong with it, well apparantly something can
2032019-08-14T11:44:21 *** bitcoin-git has joined #bitcoin-core-dev
2042019-08-14T11:44:22 <bitcoin-git> [bitcoin] Sjors opened pull request #16608: [backport] Use wallet RBF default for walletcreatefundedpsbt (0.18...2018/08/backport-wallet-rbf-default) https://github.com/bitcoin/bitcoin/pull/16608
2052019-08-14T11:44:23 *** bitcoin-git has left #bitcoin-core-dev
2062019-08-14T11:49:13 <provoostenator> wumpus fanquake: I'll take a look
2072019-08-14T11:49:28 <fanquake> provoostenator: I'm about to open a PR.
2082019-08-14T11:49:29 <wumpus> provoostenator: thanks!
2092019-08-14T11:49:42 <provoostenator> Could either revert and then I can rebase, or I make a PR now that fixes the new occurance.
2102019-08-14T11:50:27 <provoostenator> Fix appears trivial, just running tests locall now
2112019-08-14T11:50:40 *** bitcoin-git has joined #bitcoin-core-dev
2122019-08-14T11:50:40 <bitcoin-git> [bitcoin] fanquake opened pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
2132019-08-14T11:50:43 *** bitcoin-git has left #bitcoin-core-dev
2142019-08-14T11:51:27 <provoostenator> Oh I see fanquake beat me to it with the exact same change :-)
2152019-08-14T11:51:38 <wumpus> at least ACK it then
2162019-08-14T11:51:44 <provoostenator> About to
2172019-08-14T11:51:47 *** bitcoin-git has joined #bitcoin-core-dev
2182019-08-14T11:51:47 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #16584: gui: New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
2192019-08-14T11:51:49 *** bitcoin-git has left #bitcoin-core-dev
2202019-08-14T11:52:45 *** queip has joined #bitcoin-core-dev
2212019-08-14T11:55:53 <provoostenator> I would be cool if Drahtbot could detect a silent merge conflict like this one.
2222019-08-14T11:58:26 <wumpus> I think it sometimes does re-run travis on PRs that have been open a long time
2232019-08-14T11:58:54 <wumpus> that's the only way to 'detect' silent merge conflicts, re-running the build and test suite
2242019-08-14T11:59:12 <wumpus> I should have built locally before merging, but this one seemed trivial
2252019-08-14T12:00:02 *** [42]1 has quit IRC
2262019-08-14T12:01:04 <wumpus> didn't think anything could go wrong, but there you seeâ¦
2272019-08-14T12:03:21 *** bitcoin-git has joined #bitcoin-core-dev
2282019-08-14T12:03:21 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7df1ecd1758...034575e9c7a3
2292019-08-14T12:03:22 <bitcoin-git> bitcoin/master 3963856 fanquake: descriptor: fix missed m_script_arg arg renaming in #14934
2302019-08-14T12:03:22 <bitcoin-git> bitcoin/master 034575e MarcoFalke: Merge #16609: descriptor: fix missed m_script_arg arg renaming in #14934
2312019-08-14T12:03:28 *** bitcoin-git has left #bitcoin-core-dev
2322019-08-14T12:03:29 <provoostenator> When running the functional test suite with --jobs=100 a bunch of tests break because of the 60 second node stop timeout.
2332019-08-14T12:03:52 <provoostenator> That should probably be configurable, because CPU and RAM usage weren't particularly bad.
2342019-08-14T12:03:56 <wumpus> To github.com:bitcoin/bitcoin
2352019-08-14T12:03:58 <wumpus> ! [rejected] master -> master (fetch first)
2362019-08-14T12:04:00 <wumpus> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
2372019-08-14T12:04:02 <wumpus> h
2382019-08-14T12:04:12 <wumpus> lol MarcoFalke beat me to merging a millisecond or so
2392019-08-14T12:04:31 *** bitcoin-git has joined #bitcoin-core-dev
2402019-08-14T12:04:31 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
2412019-08-14T12:04:32 *** bitcoin-git has left #bitcoin-core-dev
2422019-08-14T12:09:11 *** lightlike has joined #bitcoin-core-dev
2432019-08-14T12:10:09 *** harrigan has quit IRC
2442019-08-14T12:13:13 *** bitcoin-git has joined #bitcoin-core-dev
2452019-08-14T12:13:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/034575e9c7a3...0753c7392796
2462019-08-14T12:13:14 <bitcoin-git> bitcoin/master 14f7eec Emil Engler: rpc: Fix getblocktemplate CLI example (#16594)
2472019-08-14T12:13:14 <bitcoin-git> bitcoin/master 0753c73 fanquake: Merge #16596: rpc: Fix getblocktemplate CLI example
2482019-08-14T12:13:16 *** bitcoin-git has left #bitcoin-core-dev
2492019-08-14T12:14:23 *** bitcoin-git has joined #bitcoin-core-dev
2502019-08-14T12:14:23 <bitcoin-git> [bitcoin] fanquake merged pull request #16596: rpc: Fix getblocktemplate CLI example (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
2512019-08-14T12:14:26 *** bitcoin-git has left #bitcoin-core-dev
2522019-08-14T12:19:08 *** omega8cc has joined #bitcoin-core-dev
2532019-08-14T12:20:27 *** tryphe_ has joined #bitcoin-core-dev
2542019-08-14T12:20:28 *** bitcoin-git has joined #bitcoin-core-dev
2552019-08-14T12:20:29 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
2562019-08-14T12:20:30 *** bitcoin-git has left #bitcoin-core-dev
2572019-08-14T12:23:47 *** tryphe has quit IRC
2582019-08-14T12:28:05 *** bitcoin-git has joined #bitcoin-core-dev
2592019-08-14T12:28:06 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0753c7392796...24f29790cd7e
2602019-08-14T12:28:06 <bitcoin-git> bitcoin/master fa4ee0d MarcoFalke: build: Remove unused src/obj-test folder
2612019-08-14T12:28:07 <bitcoin-git> bitcoin/master 24f2979 MarcoFalke: Merge #16589: build: Remove unused src/obj-test folder
2622019-08-14T12:28:18 *** bitcoin-git has left #bitcoin-core-dev
2632019-08-14T12:29:14 *** bitcoin-git has joined #bitcoin-core-dev
2642019-08-14T12:29:15 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
2652019-08-14T12:29:28 *** bitcoin-git has left #bitcoin-core-dev
2662019-08-14T12:30:43 *** designwish has quit IRC
2672019-08-14T12:31:58 *** votesmith has quit IRC
2682019-08-14T12:33:56 *** bitcoin-git has joined #bitcoin-core-dev
2692019-08-14T12:33:56 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f29790cd7e...a7aa80902763
2702019-08-14T12:33:57 <bitcoin-git> bitcoin/master 7cd069d Martin Zumsande: Add test for AddTimeData
2712019-08-14T12:33:57 <bitcoin-git> bitcoin/master a7aa809 Wladimir J. van der Laan: Merge #16563: test: Add unit test for AddTimeData
2722019-08-14T12:34:00 *** bitcoin-git has left #bitcoin-core-dev
2732019-08-14T12:35:00 *** bitcoin-git has joined #bitcoin-core-dev
2742019-08-14T12:35:00 <bitcoin-git> [bitcoin] laanwj merged pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
2752019-08-14T12:35:02 *** bitcoin-git has left #bitcoin-core-dev
2762019-08-14T12:35:34 *** votesmith has joined #bitcoin-core-dev
2772019-08-14T12:38:27 *** lalitmee has quit IRC
2782019-08-14T12:38:57 *** designwish has joined #bitcoin-core-dev
2792019-08-14T12:44:01 *** harrigan has joined #bitcoin-core-dev
2802019-08-14T12:54:08 *** mryandao has quit IRC
2812019-08-14T13:00:57 *** bitcoin-git has joined #bitcoin-core-dev
2822019-08-14T13:00:57 <bitcoin-git> [bitcoin] laanwj opened pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
2832019-08-14T13:01:01 *** bitcoin-git has left #bitcoin-core-dev
2842019-08-14T13:15:15 *** mryandao has joined #bitcoin-core-dev
2852019-08-14T13:19:59 *** tryphe_ has quit IRC
2862019-08-14T13:20:23 *** tryphe_ has joined #bitcoin-core-dev
2872019-08-14T13:25:53 *** jonatack has quit IRC
2882019-08-14T13:27:35 *** bsm1175321 has joined #bitcoin-core-dev
2892019-08-14T13:28:56 *** bsm1175321 has quit IRC
2902019-08-14T13:47:32 *** millerti has joined #bitcoin-core-dev
2912019-08-14T13:51:23 *** bitcoin-git has joined #bitcoin-core-dev
2922019-08-14T13:51:26 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/bbc2970082a2...43cf76b19395
2932019-08-14T13:51:26 <bitcoin-git> bitcoin/0.18 2c341e3 MarcoFalke: travis: Properly cache and error on timeout
2942019-08-14T13:51:28 <bitcoin-git> bitcoin/0.18 5aac5e9 MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
2952019-08-14T13:51:29 <bitcoin-git> bitcoin/0.18 80cd3f0 MarcoFalke: travis: Bump timeout from 50 minutes to 90
2962019-08-14T13:51:31 *** bitcoin-git has left #bitcoin-core-dev
2972019-08-14T13:51:47 *** bitcoin-git has joined #bitcoin-core-dev
2982019-08-14T13:51:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
2992019-08-14T13:51:49 *** bitcoin-git has left #bitcoin-core-dev
3002019-08-14T13:57:43 *** justanotheruser has quit IRC
3012019-08-14T14:02:57 *** bitcoin-git has joined #bitcoin-core-dev
3022019-08-14T14:02:58 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
3032019-08-14T14:02:59 *** bitcoin-git has left #bitcoin-core-dev
3042019-08-14T14:03:15 *** bitcoin-git has joined #bitcoin-core-dev
3052019-08-14T14:03:15 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
3062019-08-14T14:03:16 *** bitcoin-git has left #bitcoin-core-dev
3072019-08-14T14:04:51 *** jonatack has joined #bitcoin-core-dev
3082019-08-14T14:04:51 *** jeremyrubin has quit IRC
3092019-08-14T14:05:08 *** alko has joined #bitcoin-core-dev
3102019-08-14T14:06:03 *** rh0nj has quit IRC
3112019-08-14T14:07:08 *** rh0nj has joined #bitcoin-core-dev
3122019-08-14T14:13:58 *** harrigan has quit IRC
3132019-08-14T14:15:07 *** bitcoin-git has joined #bitcoin-core-dev
3142019-08-14T14:15:07 <bitcoin-git> [bitcoin] laanwj opened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
3152019-08-14T14:15:08 *** bitcoin-git has left #bitcoin-core-dev
3162019-08-14T14:18:05 *** justanotheruser has joined #bitcoin-core-dev
3172019-08-14T14:22:27 *** justanotheruser has quit IRC
3182019-08-14T14:25:25 *** justanotheruser has joined #bitcoin-core-dev
3192019-08-14T14:36:56 *** jarthur has joined #bitcoin-core-dev
3202019-08-14T14:37:00 *** seeder has joined #bitcoin-core-dev
3212019-08-14T14:41:04 *** elichai2 has joined #bitcoin-core-dev
3222019-08-14T14:42:36 *** hebasto has joined #bitcoin-core-dev
3232019-08-14T14:47:11 *** Guyver2 has joined #bitcoin-core-dev
3242019-08-14T14:50:11 *** lalitmee has joined #bitcoin-core-dev
3252019-08-14T14:51:47 *** nosss2 has joined #bitcoin-core-dev
3262019-08-14T14:54:16 *** gleb has left #bitcoin-core-dev
3272019-08-14T14:54:19 *** gleb has joined #bitcoin-core-dev
3282019-08-14T14:57:29 *** E_ has joined #bitcoin-core-dev
3292019-08-14T15:00:01 *** omega8cc has quit IRC
3302019-08-14T15:01:20 *** E__ has quit IRC
3312019-08-14T15:04:16 *** DpEpsilon1 has joined #bitcoin-core-dev
3322019-08-14T15:05:56 *** jeremyrubin has joined #bitcoin-core-dev
3332019-08-14T15:07:55 <gleb> I want to discuss #16599 sometime at the meeting, but maybe we should start with âneeds conceptual reviewâ? Do we have room for this discussion in the conceptual review list?
3342019-08-14T15:07:57 <gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
3352019-08-14T15:08:02 *** bitcoin-git has joined #bitcoin-core-dev
3362019-08-14T15:08:02 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a7aa80902763...67be6d7a177c
3372019-08-14T15:08:03 <bitcoin-git> bitcoin/master e5b26de nicolas.dorier: Make whitebind/whitelist permissions more flexible
3382019-08-14T15:08:03 <bitcoin-git> bitcoin/master ecd5cf7 nicolas.dorier: Do not disconnect peer for asking mempool if it has NO_BAN permission
3392019-08-14T15:08:04 <bitcoin-git> bitcoin/master d541fa3 nicolas.dorier: Replace the use of fWhitelisted by permission checks
3402019-08-14T15:08:05 *** bitcoin-git has left #bitcoin-core-dev
3412019-08-14T15:08:51 *** bitcoin-git has joined #bitcoin-core-dev
3422019-08-14T15:08:51 <bitcoin-git> [bitcoin] laanwj merged pull request #16248: Make whitebind/whitelist permissions more flexible (master...feature/permissions) https://github.com/bitcoin/bitcoin/pull/16248
3432019-08-14T15:08:53 *** bitcoin-git has left #bitcoin-core-dev
3442019-08-14T15:10:13 <wumpus> gleb: sure, willl add it to that
3452019-08-14T15:21:17 *** captjakk has joined #bitcoin-core-dev
3462019-08-14T15:22:59 *** tryphe_ has quit IRC
3472019-08-14T15:23:25 *** tryphe_ has joined #bitcoin-core-dev
3482019-08-14T15:25:59 *** tryphe_ has quit IRC
3492019-08-14T15:26:25 *** tryphe_ has joined #bitcoin-core-dev
3502019-08-14T15:27:08 *** tryphe_ has quit IRC
3512019-08-14T15:27:40 *** tryphe_ has joined #bitcoin-core-dev
3522019-08-14T15:28:50 *** tryphe_ has joined #bitcoin-core-dev
3532019-08-14T15:30:03 *** tryphe_ has joined #bitcoin-core-dev
3542019-08-14T15:41:35 *** bitcoin-git has joined #bitcoin-core-dev
3552019-08-14T15:41:36 <bitcoin-git> [bitcoin] practicalswift closed pull request #16273: refactor: Remove unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
3562019-08-14T15:41:49 *** bitcoin-git has left #bitcoin-core-dev
3572019-08-14T15:42:41 *** E__ has joined #bitcoin-core-dev
3582019-08-14T15:46:17 *** E_ has quit IRC
3592019-08-14T15:58:15 *** E_ has joined #bitcoin-core-dev
3602019-08-14T16:02:08 *** E__ has quit IRC
3612019-08-14T16:19:36 *** csknk has joined #bitcoin-core-dev
3622019-08-14T16:19:42 *** EagleTM has joined #bitcoin-core-dev
3632019-08-14T16:24:37 *** michaelfolkson has joined #bitcoin-core-dev
3642019-08-14T16:28:07 *** EagleTM has quit IRC
3652019-08-14T16:28:23 *** E__ has joined #bitcoin-core-dev
3662019-08-14T16:32:03 *** E_ has quit IRC
3672019-08-14T16:32:34 <luke-jr> kallewoof: it might make sense to split out a couple more changes
3682019-08-14T16:33:07 <luke-jr> suggest: fees: FeeModes doc helper function ; RPC/Wallet: Make fee estimate modes case insensitive.
3692019-08-14T16:42:48 *** tryphe has joined #bitcoin-core-dev
3702019-08-14T16:46:17 *** seeder has quit IRC
3712019-08-14T16:48:09 *** kljasdfvv has quit IRC
3722019-08-14T16:48:31 *** kljasdfvv has joined #bitcoin-core-dev
3732019-08-14T16:52:07 *** jcorgan has quit IRC
3742019-08-14T16:59:25 *** jcorgan has joined #bitcoin-core-dev
3752019-08-14T17:01:49 *** seeder has joined #bitcoin-core-dev
3762019-08-14T17:03:01 *** Chris_Stewart_5 has quit IRC
3772019-08-14T17:03:28 *** captjakk has quit IRC
3782019-08-14T17:03:45 *** captjakk has joined #bitcoin-core-dev
3792019-08-14T17:04:31 *** captjakk has joined #bitcoin-core-dev
3802019-08-14T17:05:04 *** captjakk has quit IRC
3812019-08-14T17:05:23 *** captjakk has joined #bitcoin-core-dev
3822019-08-14T17:06:08 *** captjakk has joined #bitcoin-core-dev
3832019-08-14T17:06:56 *** captjakk has joined #bitcoin-core-dev
3842019-08-14T17:13:23 *** sdaftuar has quit IRC
3852019-08-14T17:13:40 *** sdaftuar has joined #bitcoin-core-dev
3862019-08-14T17:16:26 *** pinheadmz has quit IRC
3872019-08-14T17:18:38 *** nosss2 has quit IRC
3882019-08-14T17:20:01 *** tryphe has quit IRC
3892019-08-14T17:20:29 *** tryphe has joined #bitcoin-core-dev
3902019-08-14T17:26:38 *** harrigan has joined #bitcoin-core-dev
3912019-08-14T17:26:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3922019-08-14T17:28:51 *** bitcoin-git has joined #bitcoin-core-dev
3932019-08-14T17:28:51 <bitcoin-git> [bitcoin] gapeman opened pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
3942019-08-14T17:28:53 *** bitcoin-git has left #bitcoin-core-dev
3952019-08-14T17:32:32 *** jungly has quit IRC
3962019-08-14T17:35:44 *** phwalkr_ has quit IRC
3972019-08-14T17:35:46 *** drizztbsd has quit IRC
3982019-08-14T17:37:39 *** harrigan has quit IRC
3992019-08-14T17:38:37 *** jarthur has quit IRC
4002019-08-14T17:38:51 *** jarthur has joined #bitcoin-core-dev
4012019-08-14T17:41:07 *** nosss2 has joined #bitcoin-core-dev
4022019-08-14T17:44:49 *** lalitmee has quit IRC
4032019-08-14T17:45:28 *** nosss2 has quit IRC
4042019-08-14T18:00:02 *** DpEpsilon1 has quit IRC
4052019-08-14T18:03:07 *** michaelfolkson has quit IRC
4062019-08-14T18:04:33 *** cmeiklejohn1 has joined #bitcoin-core-dev
4072019-08-14T18:30:43 *** elichai2 has quit IRC
4082019-08-14T18:34:19 *** peleion has quit IRC
4092019-08-14T18:41:07 *** captjakk has joined #bitcoin-core-dev
4102019-08-14T18:44:03 *** captjakk_ has joined #bitcoin-core-dev
4112019-08-14T18:45:18 *** captjak__ has joined #bitcoin-core-dev
4122019-08-14T18:48:04 *** captjakk has quit IRC
4132019-08-14T18:48:35 *** captjakk_ has quit IRC
4142019-08-14T18:53:59 *** captjak__ has quit IRC
4152019-08-14T18:55:42 *** captjakk has joined #bitcoin-core-dev
4162019-08-14T19:02:06 *** bitcoin-git has joined #bitcoin-core-dev
4172019-08-14T19:02:07 <bitcoin-git> [bitcoin] dongcarl closed pull request #14856: net: remove more CConnman globals (theuni) (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
4182019-08-14T19:02:08 *** bitcoin-git has left #bitcoin-core-dev
4192019-08-14T19:02:16 *** rockhouse has quit IRC
4202019-08-14T19:02:16 *** victorSN has quit IRC
4212019-08-14T19:03:24 *** rockhouse has joined #bitcoin-core-dev
4222019-08-14T19:09:49 *** victorSN has joined #bitcoin-core-dev
4232019-08-14T19:20:29 *** reallll has joined #bitcoin-core-dev
4242019-08-14T19:20:31 *** tryphe has quit IRC
4252019-08-14T19:20:59 *** tryphe has joined #bitcoin-core-dev
4262019-08-14T19:22:03 *** ddustin has joined #bitcoin-core-dev
4272019-08-14T19:22:48 *** morcos has quit IRC
4282019-08-14T19:22:48 *** arubi has quit IRC
4292019-08-14T19:22:48 *** ghost43 has quit IRC
4302019-08-14T19:22:48 *** mryandao has quit IRC
4312019-08-14T19:22:48 *** afk11 has quit IRC
4322019-08-14T19:22:48 *** sipa has quit IRC
4332019-08-14T19:22:48 *** kristapsk has quit IRC
4342019-08-14T19:22:48 *** sdaftuar has quit IRC
4352019-08-14T19:22:48 *** astro has quit IRC
4362019-08-14T19:22:48 *** jb55 has quit IRC
4372019-08-14T19:23:21 *** astro has joined #bitcoin-core-dev
4382019-08-14T19:23:21 *** afk11 has joined #bitcoin-core-dev
4392019-08-14T19:23:47 *** belcher has quit IRC
4402019-08-14T19:24:24 *** jb55 has joined #bitcoin-core-dev
4412019-08-14T19:24:36 *** mryandao has joined #bitcoin-core-dev
4422019-08-14T19:25:08 *** ghost43 has joined #bitcoin-core-dev
4432019-08-14T19:25:56 *** arubi has joined #bitcoin-core-dev
4442019-08-14T19:26:16 *** seeder has quit IRC
4452019-08-14T19:27:37 *** ddustin has quit IRC
4462019-08-14T19:28:04 *** sipa has joined #bitcoin-core-dev
4472019-08-14T19:43:43 *** sdaftuar has joined #bitcoin-core-dev
4482019-08-14T19:51:55 *** captjakk has quit IRC
4492019-08-14T19:55:55 <jnewbery> wumpus: would you consider reverting #16248? It's quite a large PR (~450 LOC) with only your ACK. I'm not sure anyone has actually reviewed the parsing code in detail.
4502019-08-14T19:55:58 <gribble> https://github.com/bitcoin/bitcoin/issues/16248 | Make whitebind/whitelist permissions more flexible by NicolasDorier · Pull Request #16248 · bitcoin/bitcoin · GitHub
4512019-08-14T20:02:54 <wumpus> jnewbery: if you think it's really a risk
4522019-08-14T20:03:38 <wumpus> the parsing code looks fine to me
4532019-08-14T20:03:52 *** setpill has quit IRC
4542019-08-14T20:04:22 <wumpus> imo if it causes trouble we can revert it later, before the 0.19 release
4552019-08-14T20:04:24 *** Chris_Stewart_5 has quit IRC
4562019-08-14T20:06:25 <jnewbery> wumpus: not sure if it's a risk. Just seems under-reviewed to me.
4572019-08-14T20:06:28 <wumpus> tbh I was a bit sick of only merging small refactors and documentation changes, seems we have a lot of trouble merging anything more significant lately
4582019-08-14T20:07:54 *** bitcoin-git has joined #bitcoin-core-dev
4592019-08-14T20:07:55 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67be6d7a177c...f418c3379cba
4602019-08-14T20:07:55 <bitcoin-git> bitcoin/master d6ac25b Carl Dong: autoconf: Sane --enable-debug defaults.
4612019-08-14T20:07:56 <bitcoin-git> bitcoin/master f418c33 Jonas Schnelli: Merge #16435: autoconf: Sane `--enable-debug` defaults.
4622019-08-14T20:07:58 *** bitcoin-git has left #bitcoin-core-dev
4632019-08-14T20:08:54 *** bitcoin-git has joined #bitcoin-core-dev
4642019-08-14T20:08:54 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
4652019-08-14T20:08:57 *** bitcoin-git has left #bitcoin-core-dev
4662019-08-14T20:09:28 <wumpus> and this seems pretty straightforward and has tests, anyhow if you really think it should be reverted instead of fixing the issues with it that's fine with me
4672019-08-14T20:10:44 <jnewbery> I don't pay as much attention to what's being merged as you, but lowering the review burden doesn't seem like the right fix to interesting things not getting merged (at least not without discussion first)
4682019-08-14T20:11:19 <wumpus> it has been open for quite a while
4692019-08-14T20:11:37 <jnewbery> like I say, I haven't looked at the PR in great detail, so I can't say whether it's a big risk. It just seemed like the code change:number of ACKs ratio was unusual
4702019-08-14T20:12:42 <sipa> Code ACK on the string parsing code in that PR.
4712019-08-14T20:12:51 <sipa> there :)
4722019-08-14T20:14:25 *** iamtimmarchant has joined #bitcoin-core-dev
4732019-08-14T20:17:03 <wumpus> I don't know either, sorry okay
4742019-08-14T20:20:31 *** tryphe has quit IRC
4752019-08-14T20:20:50 *** csknk has quit IRC
4762019-08-14T20:20:56 *** tryphe has joined #bitcoin-core-dev
4772019-08-14T20:22:47 <wumpus> sipa: thanks!
4782019-08-14T20:23:02 <wumpus> that's some forward momentum right there :)
4792019-08-14T20:27:37 *** iamtimmarchant has quit IRC
4802019-08-14T20:28:43 <jnewbery> merge driven review :)
4812019-08-14T20:29:12 <wumpus> we did that more often in the past
4822019-08-14T20:32:07 *** baldur has quit IRC
4832019-08-14T20:32:47 <wumpus> it's good to be careful, but also, not everything needs the same level of assurance as changes to the consensus code
4842019-08-14T20:44:55 *** captjakk has joined #bitcoin-core-dev
4852019-08-14T20:45:19 *** baldur has joined #bitcoin-core-dev
4862019-08-14T20:49:27 *** ddustin has joined #bitcoin-core-dev
4872019-08-14T20:57:42 *** EagleTM has joined #bitcoin-core-dev
4882019-08-14T21:00:01 *** cmeiklejohn1 has quit IRC
4892019-08-14T21:02:43 *** Guyver2 has quit IRC
4902019-08-14T21:04:12 *** dhart has joined #bitcoin-core-dev
4912019-08-14T21:09:06 *** hanhua has joined #bitcoin-core-dev
4922019-08-14T21:20:31 *** tryphe has quit IRC
4932019-08-14T21:20:55 *** tryphe has joined #bitcoin-core-dev
4942019-08-14T21:22:07 *** jarthur has quit IRC
4952019-08-14T21:25:18 <aj> wumpus: oh, i kept putting off doing a proper review/ack for 16248, sorry. moneyball was meant to be pinging people to ACK PRs so we got less bogged down in refactors etc, wonder if he's still doing that
4962019-08-14T21:27:19 <moneyball> aj i intend too but sadly have put on back burner as i'm heads down building the square crypto team right now. everyone should bug me again in 1-2 months to make sure i am doing my part to help this project!
4972019-08-14T21:35:02 *** Bullit has quit IRC
4982019-08-14T21:35:49 *** jeremyrubin has quit IRC
4992019-08-14T21:36:30 <fanquake> aj Iâve been ramping up my pinging / reaching out to people.
5002019-08-14T21:40:35 *** ddustin has quit IRC
5012019-08-14T21:46:53 *** learning has joined #bitcoin-core-dev
5022019-08-14T21:47:16 *** ddustin has joined #bitcoin-core-dev
5032019-08-14T21:53:31 <aj> moneyball: ohoh, fanquake's going to render you obsolete
5042019-08-14T21:54:41 <moneyball> fantastic!
5052019-08-14T22:02:36 *** kristapsk has joined #bitcoin-core-dev
5062019-08-14T22:06:23 *** jeremyrubin has joined #bitcoin-core-dev
5072019-08-14T22:07:45 *** ddustin has quit IRC
5082019-08-14T22:10:54 *** ddustin has joined #bitcoin-core-dev
5092019-08-14T22:11:32 *** jeremyrubin has quit IRC
5102019-08-14T22:11:49 *** lnostdal has quit IRC
5112019-08-14T22:24:49 *** KS has joined #bitcoin-core-dev
5122019-08-14T22:32:43 *** jeremyrubin has joined #bitcoin-core-dev
5132019-08-14T22:32:51 *** KS has quit IRC
5142019-08-14T22:36:54 *** promag has joined #bitcoin-core-dev
5152019-08-14T22:38:03 *** ddustin has quit IRC
5162019-08-14T22:38:39 *** ddustin has joined #bitcoin-core-dev
5172019-08-14T22:40:23 *** ddustin has quit IRC
5182019-08-14T22:40:26 *** ddustin_ has joined #bitcoin-core-dev
5192019-08-14T22:42:24 *** hanhua has quit IRC
5202019-08-14T22:45:29 *** pinheadmz has joined #bitcoin-core-dev
5212019-08-14T22:57:15 *** esotericnonsense has quit IRC
5222019-08-14T23:01:24 *** esotericnonsense has joined #bitcoin-core-dev
5232019-08-14T23:08:35 *** ddustin_ has quit IRC
5242019-08-14T23:10:01 *** elichai2 has joined #bitcoin-core-dev
5252019-08-14T23:10:10 *** ddustin has joined #bitcoin-core-dev
5262019-08-14T23:11:13 *** profmac has quit IRC
5272019-08-14T23:13:34 *** ddustin has quit IRC
5282019-08-14T23:17:06 *** ddustin has joined #bitcoin-core-dev
5292019-08-14T23:18:15 *** captjakk_ has joined #bitcoin-core-dev
5302019-08-14T23:20:17 *** captjakk has quit IRC
5312019-08-14T23:21:01 *** tryphe has quit IRC
5322019-08-14T23:21:27 *** tryphe has joined #bitcoin-core-dev
5332019-08-14T23:24:43 *** captjakk_ has quit IRC
5342019-08-14T23:49:54 *** nosss2 has joined #bitcoin-core-dev
5352019-08-14T23:50:28 *** pinheadmz_ has joined #bitcoin-core-dev
5362019-08-14T23:52:07 *** AaronvanW has quit IRC
5372019-08-14T23:52:22 *** ddustin has quit IRC
5382019-08-14T23:52:32 *** pinheadmz has quit IRC
5392019-08-14T23:54:18 *** pinheadmz_ has quit IRC
5402019-08-14T23:55:07 *** pinheadmz has joined #bitcoin-core-dev
5412019-08-14T23:55:16 *** nosss2 has quit IRC