12019-08-18T00:00:01  *** cdb has quit IRC
  22019-08-18T00:04:18  *** hali has joined #bitcoin-core-dev
  32019-08-18T00:17:46  <meshcollider> sipa: we do
  42019-08-18T00:17:58  <meshcollider> fanquake removes them whenever he sees them
  52019-08-18T00:28:45  *** ddustin has joined #bitcoin-core-dev
  62019-08-18T00:36:40  *** exhoplex has quit IRC
  72019-08-18T00:36:40  <sipa> oh cool
  82019-08-18T00:40:17  *** laptop500 has quit IRC
  92019-08-18T00:41:08  *** Krellan has joined #bitcoin-core-dev
 102019-08-18T00:57:12  *** lightlike has quit IRC
 112019-08-18T00:57:58  <fanquake> Yea if you see I’ve edited a PR body, it’s generally either for that, or to fix up the issue auto-closing syntax.
 122019-08-18T01:12:01  *** Krellan has quit IRC
 132019-08-18T01:43:47  *** queip has quit IRC
 142019-08-18T01:53:51  *** queip has joined #bitcoin-core-dev
 152019-08-18T02:18:23  *** captjakk has joined #bitcoin-core-dev
 162019-08-18T02:19:31  *** Krellan has joined #bitcoin-core-dev
 172019-08-18T02:53:24  *** Krellan has quit IRC
 182019-08-18T02:58:16  *** ddustin_ has joined #bitcoin-core-dev
 192019-08-18T02:59:03  *** ddustin has quit IRC
 202019-08-18T02:59:05  *** ddustin__ has joined #bitcoin-core-dev
 212019-08-18T03:00:02  *** hali has quit IRC
 222019-08-18T03:03:04  *** ddustin_ has quit IRC
 232019-08-18T03:08:19  *** emilengler has quit IRC
 242019-08-18T03:11:15  *** emilengler has joined #bitcoin-core-dev
 252019-08-18T03:22:59  *** untwisted has joined #bitcoin-core-dev
 262019-08-18T03:24:40  *** captjakk has quit IRC
 272019-08-18T03:29:27  *** elichai2 has joined #bitcoin-core-dev
 282019-08-18T03:51:59  *** justanotheruser is now known as justanotherchad
 292019-08-18T04:02:00  *** Krellan has joined #bitcoin-core-dev
 302019-08-18T04:04:46  *** dviola has quit IRC
 312019-08-18T04:26:39  *** Karyon has quit IRC
 322019-08-18T04:30:39  *** Karyon has joined #bitcoin-core-dev
 332019-08-18T04:35:15  *** Krellan has quit IRC
 342019-08-18T05:27:02  *** rh0nj has quit IRC
 352019-08-18T05:30:08  *** rh0nj has joined #bitcoin-core-dev
 362019-08-18T05:39:12  *** elichai2 has quit IRC
 372019-08-18T05:39:35  *** Krellan has joined #bitcoin-core-dev
 382019-08-18T05:47:26  *** joe_land1 has joined #bitcoin-core-dev
 392019-08-18T06:00:01  *** untwisted has quit IRC
 402019-08-18T06:03:49  *** Dean_Guss has quit IRC
 412019-08-18T06:04:19  *** directhex1 has joined #bitcoin-core-dev
 422019-08-18T06:04:30  *** Dean_Guss has joined #bitcoin-core-dev
 432019-08-18T06:14:03  *** Krellan has quit IRC
 442019-08-18T06:20:01  *** Krellan has joined #bitcoin-core-dev
 452019-08-18T06:26:28  *** Krellan has quit IRC
 462019-08-18T06:32:25  *** Krellan has joined #bitcoin-core-dev
 472019-08-18T06:59:06  *** Dean_Guss has quit IRC
 482019-08-18T06:59:20  *** Dean_Guss has joined #bitcoin-core-dev
 492019-08-18T07:01:39  *** Dean_Guss has quit IRC
 502019-08-18T07:08:28  *** sipa has quit IRC
 512019-08-18T07:19:15  *** sipa has joined #bitcoin-core-dev
 522019-08-18T07:28:17  *** joe_land1 has quit IRC
 532019-08-18T07:34:37  *** justanotherchad has quit IRC
 542019-08-18T07:42:59  *** hebasto has joined #bitcoin-core-dev
 552019-08-18T07:50:57  *** liberiga has joined #bitcoin-core-dev
 562019-08-18T08:20:15  *** sev_ has quit IRC
 572019-08-18T08:25:42  *** ddustin__ has quit IRC
 582019-08-18T08:33:24  *** liberiga has quit IRC
 592019-08-18T08:33:43  <provoostenator> sipa: I generally don't do that, where did that happen?
 602019-08-18T08:34:40  <provoostenator> Auto-removing them from descriptions during merge makes sense. It would get awkward having to avoid tagging people in the description too.
 612019-08-18T08:37:34  *** harrigan has joined #bitcoin-core-dev
 622019-08-18T09:00:02  *** directhex1 has quit IRC
 632019-08-18T09:10:42  *** tryphe has quit IRC
 642019-08-18T09:11:11  *** tryphe has joined #bitcoin-core-dev
 652019-08-18T09:12:26  *** tryphe has joined #bitcoin-core-dev
 662019-08-18T09:13:31  *** tryphe has joined #bitcoin-core-dev
 672019-08-18T09:14:44  *** tryphe has joined #bitcoin-core-dev
 682019-08-18T09:17:12  *** tryphe has quit IRC
 692019-08-18T09:46:09  *** uptime1 has joined #bitcoin-core-dev
 702019-08-18T09:52:04  *** queip has quit IRC
 712019-08-18T09:56:50  *** justanotheruser has joined #bitcoin-core-dev
 722019-08-18T10:08:22  *** queip has joined #bitcoin-core-dev
 732019-08-18T10:16:35  *** emilengler has quit IRC
 742019-08-18T10:17:20  *** emilengler has joined #bitcoin-core-dev
 752019-08-18T10:24:46  *** queip has quit IRC
 762019-08-18T10:39:47  *** queip has joined #bitcoin-core-dev
 772019-08-18T10:55:46  *** queip has quit IRC
 782019-08-18T11:10:59  *** queip has joined #bitcoin-core-dev
 792019-08-18T11:25:19  *** queip has quit IRC
 802019-08-18T11:37:01  *** queip has joined #bitcoin-core-dev
 812019-08-18T12:00:01  *** uptime1 has quit IRC
 822019-08-18T12:02:31  *** Eagle[TM] has joined #bitcoin-core-dev
 832019-08-18T12:06:04  *** EagleTM has quit IRC
 842019-08-18T12:22:16  *** queip has quit IRC
 852019-08-18T12:29:51  *** queip has joined #bitcoin-core-dev
 862019-08-18T12:43:49  *** xi1 has joined #bitcoin-core-dev
 872019-08-18T12:45:27  <hebasto> fanquake: is Mine8801's activity in the bitcoin repo needed to be moderated?
 882019-08-18T12:55:08  *** kristapsk has joined #bitcoin-core-dev
 892019-08-18T12:56:47  <gleb> It seems like we currently dedicate 16 network groups to various Tor addresses. This means that we can end up exclusively connecting to 8 tor-routed AWS nodes. Am I correct? Should we reduce groups to 4 so that this can't happen? sipa
 902019-08-18T13:08:27  *** bitcoin-git has joined #bitcoin-core-dev
 912019-08-18T13:08:27  <bitcoin-git> [bitcoin] hebasto opened pull request #16643: doc: Add ZMQ dependencies to the Fedora build instructions (master...20190818-doc-fedora-zmq) https://github.com/bitcoin/bitcoin/pull/16643
 922019-08-18T13:08:29  *** bitcoin-git has left #bitcoin-core-dev
 932019-08-18T13:16:39  *** lightlike has joined #bitcoin-core-dev
 942019-08-18T13:17:40  *** queip has quit IRC
 952019-08-18T13:35:57  *** queip has joined #bitcoin-core-dev
 962019-08-18T13:46:08  *** tripleslash has quit IRC
 972019-08-18T14:08:40  *** Karyon has quit IRC
 982019-08-18T14:09:38  *** Processus42 has joined #bitcoin-core-dev
 992019-08-18T14:11:58  *** Karyon has joined #bitcoin-core-dev
1002019-08-18T14:23:02  *** harrigan has quit IRC
1012019-08-18T14:28:47  *** queip has quit IRC
1022019-08-18T14:38:29  <fanquake> hebasto: thanks, cleaned it up.
1032019-08-18T14:40:28  *** queip has joined #bitcoin-core-dev
1042019-08-18T14:40:37  <sipa> provoostenator: yeah sorry for calling you out; it was only indirectly through PR description
1052019-08-18T14:40:56  <sipa> gleb: tor is annoying
1062019-08-18T14:41:02  <sipa> 16 is a lot for sure
1072019-08-18T14:41:38  <sipa> but if there are only 4, what happens if you're only able to make hidden service connections?
1082019-08-18T14:44:52  *** pinheadmz has quit IRC
1092019-08-18T14:55:13  *** Karyon_ has joined #bitcoin-core-dev
1102019-08-18T14:57:05  *** Karyon has quit IRC
1112019-08-18T14:58:33  *** Karyon_ is now known as Karyon
1122019-08-18T15:00:01  *** xi1 has quit IRC
1132019-08-18T15:01:58  <gleb> Currently we would end up connecting to just 4 peers in that case. But it seems simple to adjust the code so that in this particular case we connect to as many as needed (8 or nMaxOutbound)
1142019-08-18T15:02:28  *** queip has quit IRC
1152019-08-18T15:03:06  <gleb> Not sure if the problem is worth adding code.
1162019-08-18T15:05:56  <gleb> By currently I meant with 4 groups instead of 16.
1172019-08-18T15:07:00  *** threadlock has joined #bitcoin-core-dev
1182019-08-18T15:12:30  *** h0ngcha0 has quit IRC
1192019-08-18T15:16:39  *** ExtraCrispy has joined #bitcoin-core-dev
1202019-08-18T15:22:11  *** queip has joined #bitcoin-core-dev
1212019-08-18T15:27:11  *** phwalkr has joined #bitcoin-core-dev
1222019-08-18T15:28:26  *** fox2p_ has joined #bitcoin-core-dev
1232019-08-18T15:29:07  *** fox2p has quit IRC
1242019-08-18T15:30:40  *** phwalkr_ has quit IRC
1252019-08-18T15:40:19  *** Guyver2 has joined #bitcoin-core-dev
1262019-08-18T15:54:43  *** mdunnio has joined #bitcoin-core-dev
1272019-08-18T16:19:47  *** bitcoin-git has joined #bitcoin-core-dev
1282019-08-18T16:19:47  <bitcoin-git> [bitcoin] GChuf opened pull request #16644: scripts: attempt to fix some translations in update-translations.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16644
1292019-08-18T16:19:52  *** bitcoin-git has left #bitcoin-core-dev
1302019-08-18T16:23:24  *** ovovo has joined #bitcoin-core-dev
1312019-08-18T16:24:12  *** mdunnio has quit IRC
1322019-08-18T16:25:26  *** mdunnio has joined #bitcoin-core-dev
1332019-08-18T16:25:48  *** mdunnio has quit IRC
1342019-08-18T16:27:01  *** owowo has quit IRC
1352019-08-18T16:28:01  *** mdunnio has joined #bitcoin-core-dev
1362019-08-18T16:28:51  *** mdunnio has joined #bitcoin-core-dev
1372019-08-18T16:28:58  *** mdunnio has quit IRC
1382019-08-18T16:29:30  *** mdunnio has joined #bitcoin-core-dev
1392019-08-18T16:30:37  <sipa> gleb: i mean, say you only have onion addresses in addrman, what would happen?
1402019-08-18T16:30:50  <sipa> worst case it goes into an infinite loop
1412019-08-18T16:31:13  <sipa> best case it evetually ignores the grouping limit, and makes 8 outgoing connections still
1422019-08-18T16:31:24  *** elichai2 has joined #bitcoin-core-dev
1432019-08-18T16:32:00  <gleb> Yes, I think I know how to add couple lines to achieve the best case while limiting tor groups to 4
1442019-08-18T16:37:24  <sipa> gleb: it could even be progressive
1452019-08-18T16:37:34  <sipa> say you avtually make all of tor one group
1462019-08-18T16:37:59  <sipa> and initially limit to 1, but after a few failed attempts allow 2, etc
1472019-08-18T16:38:48  <gleb> Yeah, but I think it would be harder to diversify tor connections then lol
1482019-08-18T16:39:12  <sipa> i agree
1492019-08-18T16:39:18  <sipa> i don't know how to deal with it well
1502019-08-18T16:39:54  <sipa> but making tor 4 groups or 16, or whatever number different from 1 is artificial
1512019-08-18T16:40:18  <sipa> as spinning up infinity tor hidden services is cheap, regardless of what group they are in
1522019-08-18T16:44:03  <gleb> I still think that 4 is better than 16, but yeah, progressive is better than both. I’ll see how much code complexity is that tomorrow.
1532019-08-18T16:45:48  *** queip has quit IRC
1542019-08-18T16:47:50  *** lnostdal has quit IRC
1552019-08-18T16:48:15  <achow101> Mine8801 is spamming the repo
1562019-08-18T16:56:16  *** queip has joined #bitcoin-core-dev
1572019-08-18T17:04:25  *** promag has joined #bitcoin-core-dev
1582019-08-18T17:05:02  *** nullptr| has quit IRC
1592019-08-18T17:05:44  *** queip has quit IRC
1602019-08-18T17:07:44  *** promag_ has joined #bitcoin-core-dev
1612019-08-18T17:07:47  *** nullptr| has joined #bitcoin-core-dev
1622019-08-18T17:07:53  *** promag_ has quit IRC
1632019-08-18T17:09:38  *** promag has quit IRC
1642019-08-18T17:09:57  *** promag has joined #bitcoin-core-dev
1652019-08-18T17:15:15  *** morcos has joined #bitcoin-core-dev
1662019-08-18T17:16:27  *** promag has quit IRC
1672019-08-18T17:17:14  *** phwalkr has quit IRC
1682019-08-18T17:21:08  *** sfhi has joined #bitcoin-core-dev
1692019-08-18T17:24:08  *** hebasto has quit IRC
1702019-08-18T17:24:37  *** queip has joined #bitcoin-core-dev
1712019-08-18T17:30:01  *** mdunnio has quit IRC
1722019-08-18T17:31:01  *** rh0nj has quit IRC
1732019-08-18T17:32:09  *** rh0nj has joined #bitcoin-core-dev
1742019-08-18T17:39:25  *** ctrlbreak_MAD is now known as ctrlbreak
1752019-08-18T17:48:48  *** queip has quit IRC
1762019-08-18T18:00:02  *** threadlock has quit IRC
1772019-08-18T18:03:42  *** flamingspinach has joined #bitcoin-core-dev
1782019-08-18T18:07:27  *** queip has joined #bitcoin-core-dev
1792019-08-18T18:19:15  *** harrigan has joined #bitcoin-core-dev
1802019-08-18T18:29:34  *** dviola has joined #bitcoin-core-dev
1812019-08-18T18:35:00  *** bralyclow has joined #bitcoin-core-dev
1822019-08-18T18:35:33  *** bralyclow has quit IRC
1832019-08-18T18:39:36  <sipa> achow101: blocked
1842019-08-18T18:42:44  *** queip has quit IRC
1852019-08-18T18:50:37  *** queip has joined #bitcoin-core-dev
1862019-08-18T18:52:48  *** captjakk has joined #bitcoin-core-dev
1872019-08-18T19:03:00  *** captjakk has quit IRC
1882019-08-18T19:20:34  *** kristapsk has quit IRC
1892019-08-18T19:20:55  *** kristapsk has joined #bitcoin-core-dev
1902019-08-18T19:20:56  *** reallll has joined #bitcoin-core-dev
1912019-08-18T19:24:07  *** belcher has quit IRC
1922019-08-18T19:25:45  *** ovovo is now known as owowo
1932019-08-18T19:40:05  *** TheRec has quit IRC
1942019-08-18T19:41:08  *** TheRec has joined #bitcoin-core-dev
1952019-08-18T19:45:03  *** queip has quit IRC
1962019-08-18T19:50:24  *** mdunnio has joined #bitcoin-core-dev
1972019-08-18T19:53:09  *** harrigan has quit IRC
1982019-08-18T19:55:15  *** queip has joined #bitcoin-core-dev
1992019-08-18T19:56:50  <emilengler> Is the blockchain download being done with multiple threads?
2002019-08-18T19:58:19  <sipa> yes and no
2012019-08-18T19:58:31  <sipa> p2p traffic is handled by one thread
2022019-08-18T19:58:57  <sipa> and processing and sending of protocol messages is done in one thread (but a different one from the p2p one)
2032019-08-18T19:59:19  <sipa> and script validation is done in multiple separate threads
2042019-08-18T20:01:40  *** queip has quit IRC
2052019-08-18T20:06:32  *** mdunnio has quit IRC
2062019-08-18T20:12:46  <emilengler> sipa, By processing, do you mean writing to the disk as well?
2072019-08-18T20:13:18  *** queip has joined #bitcoin-core-dev
2082019-08-18T20:14:10  <luke-jr> writing to the disk doesn't really benefit from multiple threads..
2092019-08-18T20:15:36  <emilengler> luke-jr, I was referring to the thread where it being done, in this case if it counts as processing
2102019-08-18T20:17:01  <sipa> "it" is multipke things
2112019-08-18T20:17:20  <sipa> block processing as a whole is single threaded
2122019-08-18T20:17:42  <sipa> but script validation is outsourced to separate script validation threads
2132019-08-18T20:20:24  <emilengler> Ok, I'm still a bit confused at the part where it writes the blocks to the disk. I still don't get which function is exactly responsible for this, there are so many (AcceptBlock, FlushStateToDisk, WriteBlockToDisk)
2142019-08-18T20:22:16  <sipa> writeblocktodisk writes a block to disk
2152019-08-18T20:22:27  <sipa> flushstatetodisk causes the chainstate to be written to disk
2162019-08-18T20:23:14  <sipa> acceptblock is a lot more high level; it deals with all parts of accepting a new block from anywhere
2172019-08-18T20:23:33  <sipa> in particular, acceptblock can deal with invalid blocks
2182019-08-18T20:25:00  <emilengler> sipa: Wow, thanks for this detailed answer :)
2192019-08-18T20:32:03  *** sfhi has quit IRC
2202019-08-18T20:58:25  *** queip has quit IRC
2212019-08-18T21:00:02  *** flamingspinach has quit IRC
2222019-08-18T21:05:42  *** hcchien has joined #bitcoin-core-dev
2232019-08-18T21:09:35  *** queip has joined #bitcoin-core-dev
2242019-08-18T21:36:11  *** queip has quit IRC
2252019-08-18T21:42:19  *** queip has joined #bitcoin-core-dev
2262019-08-18T21:53:26  *** nosss2 has joined #bitcoin-core-dev
2272019-08-18T22:00:19  *** Guyver2 has quit IRC
2282019-08-18T22:05:52  *** Soligor has quit IRC
2292019-08-18T22:08:03  *** Soligor has joined #bitcoin-core-dev
2302019-08-18T22:16:14  *** queip has quit IRC
2312019-08-18T22:24:23  <kakobrekla> why can P2SH address can be equal length to P2PKH, but P2WSH not to P2WPKH
2322019-08-18T22:30:40  *** queip has joined #bitcoin-core-dev
2332019-08-18T22:35:01  *** nosss2 has quit IRC
2342019-08-18T22:35:13  <harding> kakobrekla: that question (and any followups you have) may be better asked in #bitcoin.  The answer is that P2WPKH uses a 20-byte hash RIPEMD(SHA256()) and P2WSH uses a 32-byte hash SHA256().  For details, see https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#P2WSH
2352019-08-18T22:35:56  <kakobrekla> tyvm
2362019-08-18T22:40:23  *** captjakk has joined #bitcoin-core-dev
2372019-08-18T22:48:04  *** bitcoin-git has joined #bitcoin-core-dev
2382019-08-18T22:48:05  <bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1124be6111d6...e8a6d5272465
2392019-08-18T22:48:05  <bitcoin-git> bitcoin/master c325f61 Andrew Chow: Return an error from descriptor Parse that gives more information about wh...
2402019-08-18T22:48:05  <bitcoin-git> bitcoin/master 625534d Andrew Chow: Give more errors for specific failure conditions
2412019-08-18T22:48:07  <bitcoin-git> bitcoin/master 6e1ae58 Andrew Chow: Check error messages in descriptor tests
2422019-08-18T22:48:07  *** bitcoin-git has left #bitcoin-core-dev
2432019-08-18T22:49:06  *** bitcoin-git has joined #bitcoin-core-dev
2442019-08-18T22:49:07  <bitcoin-git> [bitcoin] meshcollider merged pull request #16542: Return more specific errors about invalid descriptors (master...descriptor-errors) https://github.com/bitcoin/bitcoin/pull/16542
2452019-08-18T22:49:20  *** bitcoin-git has left #bitcoin-core-dev
2462019-08-18T22:58:25  *** bitcoin-git has joined #bitcoin-core-dev
2472019-08-18T22:58:25  <bitcoin-git> [bitcoin] jonatack opened pull request #16645: doc: initial RapidCheck property-based testing documentation (master...rapidcheck-documentation) https://github.com/bitcoin/bitcoin/pull/16645
2482019-08-18T22:58:26  *** bitcoin-git has left #bitcoin-core-dev
2492019-08-18T23:07:22  *** joe_land1 has joined #bitcoin-core-dev
2502019-08-18T23:23:06  *** liberiga has joined #bitcoin-core-dev
2512019-08-18T23:44:34  *** promag has joined #bitcoin-core-dev
2522019-08-18T23:48:48  *** promag has quit IRC