12019-08-30T00:00:02 *** billstclair1 has quit IRC
22019-08-30T00:17:40 *** limpkin1 has joined #bitcoin-core-dev
32019-08-30T00:29:53 *** bitcoin-git has joined #bitcoin-core-dev
42019-08-30T00:29:53 <bitcoin-git> [bitcoin] fanquake closed pull request #16759: doc: Fix table syntax (master...2019-08-bitcoin-conf-table) https://github.com/bitcoin/bitcoin/pull/16759
52019-08-30T00:29:55 *** bitcoin-git has left #bitcoin-core-dev
62019-08-30T00:32:18 <fanquake> instagibbs: hope you've got that merge script worked out
72019-08-30T00:47:31 *** bitcoin-git has joined #bitcoin-core-dev
82019-08-30T00:47:31 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bcf7004a8945...74da99e01074
92019-08-30T00:47:32 <bitcoin-git> bitcoin/master fa0b910 MarcoFalke: [doc] chain: Declare BLOCK_VALID_HEADER reserved
102019-08-30T00:47:32 <bitcoin-git> bitcoin/master 74da99e fanquake: Merge #14862: doc: Declare BLOCK_VALID_HEADER reserved
112019-08-30T00:47:34 *** bitcoin-git has left #bitcoin-core-dev
122019-08-30T00:47:51 *** bitcoin-git has joined #bitcoin-core-dev
132019-08-30T00:47:51 <bitcoin-git> [bitcoin] fanquake merged pull request #14862: doc: Declare BLOCK_VALID_HEADER reserved (master...Mf1812-validationDocBLOCK_VALID_HEADER) https://github.com/bitcoin/bitcoin/pull/14862
142019-08-30T00:47:52 *** bitcoin-git has left #bitcoin-core-dev
152019-08-30T00:49:46 <fanquake> meshcollider: Want to take a look at / merge #16753
162019-08-30T00:49:48 <gribble> https://github.com/bitcoin/bitcoin/issues/16753 | wallet: extract PubKey from P2PK script with Solver by theStack · Pull Request #16753 · bitcoin/bitcoin · GitHub
172019-08-30T00:54:00 *** liberiga has joined #bitcoin-core-dev
182019-08-30T00:54:27 *** StopAndDecrypt_ has quit IRC
192019-08-30T00:56:18 *** rafalcpp_ has joined #bitcoin-core-dev
202019-08-30T00:56:21 *** mdunnio has joined #bitcoin-core-dev
212019-08-30T00:57:08 *** rafalcpp has quit IRC
222019-08-30T01:01:23 *** Giszmo has quit IRC
232019-08-30T01:06:04 *** tsujp has joined #bitcoin-core-dev
242019-08-30T01:10:38 <fanquake> Thanks sipa
252019-08-30T01:16:20 *** liberiga has quit IRC
262019-08-30T01:18:30 *** pinheadmz has joined #bitcoin-core-dev
272019-08-30T01:19:58 *** promag has joined #bitcoin-core-dev
282019-08-30T01:20:16 <instagibbs> fanquake, im pretty much a pro don't worry
292019-08-30T01:22:03 *** AaronvanW has quit IRC
302019-08-30T01:23:01 *** bitcoin-git has joined #bitcoin-core-dev
312019-08-30T01:23:02 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74da99e01074...a8ecd0dadaab
322019-08-30T01:23:02 <bitcoin-git> bitcoin/master 798a589 Sebastian Falbesoner: wallet: extract PubKey from P2PK script with Solver
332019-08-30T01:23:03 <bitcoin-git> bitcoin/master a8ecd0d fanquake: Merge #16753: wallet: extract PubKey from P2PK script with Solver
342019-08-30T01:23:05 *** bitcoin-git has left #bitcoin-core-dev
352019-08-30T01:23:29 <meshcollider> fanquake: Oh I was just about to review it haha
362019-08-30T01:23:53 <meshcollider> ð
372019-08-30T01:23:56 *** bitcoin-git has joined #bitcoin-core-dev
382019-08-30T01:23:56 <bitcoin-git> [bitcoin] fanquake merged pull request #16753: wallet: extract PubKey from P2PK script with Solver (master...extractpubkey_with_solver) https://github.com/bitcoin/bitcoin/pull/16753
392019-08-30T01:23:59 *** bitcoin-git has left #bitcoin-core-dev
402019-08-30T01:25:02 <fanquake> meshcollider: hah sorry. If you still want something to review I'd suggest #16724 instead.
412019-08-30T01:25:04 <gribble> https://github.com/bitcoin/bitcoin/issues/16724 | wallet: Remove redundant wpkh script import by bhinesley · Pull Request #16724 · bitcoin/bitcoin · GitHub
422019-08-30T01:34:37 *** tryphe_ has quit IRC
432019-08-30T01:35:01 *** tryphe_ has joined #bitcoin-core-dev
442019-08-30T01:43:34 *** AaronvanW has joined #bitcoin-core-dev
452019-08-30T01:52:22 *** kcalvinalvin has joined #bitcoin-core-dev
462019-08-30T02:02:27 *** mdunnio has quit IRC
472019-08-30T02:06:16 *** emilengler_ has joined #bitcoin-core-dev
482019-08-30T02:08:22 *** emilengler has quit IRC
492019-08-30T02:16:20 *** mdunnio has joined #bitcoin-core-dev
502019-08-30T02:23:16 *** Highway61 has quit IRC
512019-08-30T02:28:13 *** bitcoin-git has joined #bitcoin-core-dev
522019-08-30T02:28:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a8ecd0dadaab...f5db3f2128f0
532019-08-30T02:28:14 <bitcoin-git> bitcoin/master 8b6f5aa Hennadii Stepanov: qt: Replace QFontMetrics::width() with TextWidth()
542019-08-30T02:28:14 <bitcoin-git> bitcoin/master f5db3f2 fanquake: Merge #16758: qt: Replace QFontMetrics::width() with TextWidth()
552019-08-30T02:28:16 *** bitcoin-git has left #bitcoin-core-dev
562019-08-30T02:29:12 *** bitcoin-git has joined #bitcoin-core-dev
572019-08-30T02:29:12 <bitcoin-git> [bitcoin] fanquake merged pull request #16758: qt: Replace QFontMetrics::width() with TextWidth() (master...20190829-pr16701-followup) https://github.com/bitcoin/bitcoin/pull/16758
582019-08-30T02:29:25 *** bitcoin-git has left #bitcoin-core-dev
592019-08-30T02:34:37 *** tryphe_ has quit IRC
602019-08-30T02:35:02 *** tryphe_ has joined #bitcoin-core-dev
612019-08-30T02:36:16 *** cryptoIndio has joined #bitcoin-core-dev
622019-08-30T02:42:58 *** mdunnio has quit IRC
632019-08-30T02:43:07 *** AaronvanW has quit IRC
642019-08-30T02:45:49 *** rafalcpp_ has quit IRC
652019-08-30T02:46:02 *** rafalcpp_ has joined #bitcoin-core-dev
662019-08-30T02:47:29 *** seeder has joined #bitcoin-core-dev
672019-08-30T03:00:02 *** limpkin1 has quit IRC
682019-08-30T03:13:17 *** kcalvinalvin has quit IRC
692019-08-30T03:21:55 *** kcalvinalvin has joined #bitcoin-core-dev
702019-08-30T03:31:55 *** IGHOR has quit IRC
712019-08-30T03:34:38 *** tryphe_ has quit IRC
722019-08-30T03:35:02 *** tryphe_ has joined #bitcoin-core-dev
732019-08-30T03:36:41 *** IGHOR has joined #bitcoin-core-dev
742019-08-30T03:40:58 *** tryphe_ is now known as tryphe
752019-08-30T03:44:52 *** wez has joined #bitcoin-core-dev
762019-08-30T03:45:14 *** kcalvinalvin has quit IRC
772019-08-30T03:57:52 *** hebasto has joined #bitcoin-core-dev
782019-08-30T04:01:32 *** kcalvinalvin has joined #bitcoin-core-dev
792019-08-30T04:08:33 *** hebasto has quit IRC
802019-08-30T04:10:44 *** promag has quit IRC
812019-08-30T04:12:27 *** hhhhhhhhhhh has joined #bitcoin-core-dev
822019-08-30T04:13:08 *** kcalvinalvin has quit IRC
832019-08-30T04:19:14 *** BlueMatt has quit IRC
842019-08-30T04:31:27 *** BlueMatt has joined #bitcoin-core-dev
852019-08-30T04:32:28 *** xzytrewq has joined #bitcoin-core-dev
862019-08-30T04:34:38 *** tryphe has quit IRC
872019-08-30T04:35:02 *** tryphe has joined #bitcoin-core-dev
882019-08-30T04:36:16 *** jtimon has quit IRC
892019-08-30T04:43:26 *** hhhhhhhhhhh has quit IRC
902019-08-30T04:43:43 *** hhhhhhhhhhh has joined #bitcoin-core-dev
912019-08-30T04:57:11 *** seeder has quit IRC
922019-08-30T05:23:46 *** EagleTM has joined #bitcoin-core-dev
932019-08-30T05:34:38 *** tryphe has quit IRC
942019-08-30T05:35:04 *** tryphe has joined #bitcoin-core-dev
952019-08-30T05:59:31 *** Highway61 has joined #bitcoin-core-dev
962019-08-30T06:00:02 *** wez has quit IRC
972019-08-30T06:00:18 *** Giszmo has joined #bitcoin-core-dev
982019-08-30T06:00:56 *** EagleTM has quit IRC
992019-08-30T06:16:38 *** devdsp has joined #bitcoin-core-dev
1002019-08-30T06:35:50 *** rafalcpp has joined #bitcoin-core-dev
1012019-08-30T06:36:36 *** rafalcpp_ has quit IRC
1022019-08-30T06:36:56 *** rafalcpp has quit IRC
1032019-08-30T06:55:02 *** ExEric3 has quit IRC
1042019-08-30T06:55:46 *** ExEric3 has joined #bitcoin-core-dev
1052019-08-30T06:56:00 *** ccdle12 has joined #bitcoin-core-dev
1062019-08-30T07:15:52 *** hhhhhhhhhhh has quit IRC
1072019-08-30T07:17:27 *** ccdle12 has quit IRC
1082019-08-30T07:18:50 *** ccdle12 has joined #bitcoin-core-dev
1092019-08-30T07:22:50 *** kcalvinalvin has joined #bitcoin-core-dev
1102019-08-30T07:33:49 *** ccdle12 has quit IRC
1112019-08-30T07:42:29 *** ccdle12 has joined #bitcoin-core-dev
1122019-08-30T07:51:27 *** jungly has joined #bitcoin-core-dev
1132019-08-30T07:57:30 *** ExEric3 has quit IRC
1142019-08-30T07:58:23 *** ExEric3 has joined #bitcoin-core-dev
1152019-08-30T08:30:02 *** rh0nj has quit IRC
1162019-08-30T08:31:09 *** rh0nj has joined #bitcoin-core-dev
1172019-08-30T08:35:08 *** tryphe has quit IRC
1182019-08-30T08:35:36 *** tryphe has joined #bitcoin-core-dev
1192019-08-30T08:37:38 *** EagleTM has joined #bitcoin-core-dev
1202019-08-30T08:48:31 <fanquake> darosior: I've rebooted those tests for you.
1212019-08-30T08:48:45 <darosior> Thank you :)
1222019-08-30T08:52:07 *** jnewbery has quit IRC
1232019-08-30T08:52:22 *** jnewbery has joined #bitcoin-core-dev
1242019-08-30T08:54:21 *** sdaftuar has quit IRC
1252019-08-30T08:54:53 *** sdaftuar has joined #bitcoin-core-dev
1262019-08-30T08:55:36 *** kcalvinalvin has quit IRC
1272019-08-30T08:55:59 *** kcalvinalvin has joined #bitcoin-core-dev
1282019-08-30T09:00:02 *** devdsp has quit IRC
1292019-08-30T09:02:51 *** EagleTM has quit IRC
1302019-08-30T09:09:49 *** promag has joined #bitcoin-core-dev
1312019-08-30T09:12:56 *** kcalvinalvin has quit IRC
1322019-08-30T09:17:37 *** donri has joined #bitcoin-core-dev
1332019-08-30T09:28:03 *** EagleTM has joined #bitcoin-core-dev
1342019-08-30T09:33:01 *** cryptoIn_ has joined #bitcoin-core-dev
1352019-08-30T09:36:22 *** cryptoIndio has quit IRC
1362019-08-30T09:45:34 *** AaronvanW has joined #bitcoin-core-dev
1372019-08-30T10:10:06 *** promag has quit IRC
1382019-08-30T10:10:26 *** promag has joined #bitcoin-core-dev
1392019-08-30T10:10:42 *** cryptoIn_ has quit IRC
1402019-08-30T10:11:45 *** cryptoIndio has joined #bitcoin-core-dev
1412019-08-30T10:14:58 *** tsujp has quit IRC
1422019-08-30T10:15:53 *** cryptoIndio has quit IRC
1432019-08-30T10:23:44 *** promag has quit IRC
1442019-08-30T10:23:45 *** justanotheruser has quit IRC
1452019-08-30T10:23:45 *** Bullitje has quit IRC
1462019-08-30T10:23:45 *** Karyon has quit IRC
1472019-08-30T10:23:45 *** fox2p has quit IRC
1482019-08-30T10:23:45 *** dongcarl has quit IRC
1492019-08-30T10:23:45 *** hardforkthis has quit IRC
1502019-08-30T10:23:45 *** rabidus has quit IRC
1512019-08-30T10:23:45 *** slimcognito has quit IRC
1522019-08-30T10:23:45 *** Lauda has quit IRC
1532019-08-30T10:23:45 *** commavir has quit IRC
1542019-08-30T10:23:46 *** nanotube has quit IRC
1552019-08-30T10:23:46 *** comboy has quit IRC
1562019-08-30T10:23:46 *** gkrizek has quit IRC
1572019-08-30T10:23:46 *** lio17 has quit IRC
1582019-08-30T10:23:46 *** a5m0 has quit IRC
1592019-08-30T10:23:46 *** asoltys has quit IRC
1602019-08-30T10:23:46 *** adam3us has quit IRC
1612019-08-30T10:23:48 *** tryphe has quit IRC
1622019-08-30T10:23:49 *** pinheadmz has quit IRC
1632019-08-30T10:23:49 *** Victor_sueca has quit IRC
1642019-08-30T10:23:49 *** jcorgan has quit IRC
1652019-08-30T10:23:49 *** spinza has quit IRC
1662019-08-30T10:23:49 *** sleepych has quit IRC
1672019-08-30T10:23:49 *** farmerwampum has quit IRC
1682019-08-30T10:23:50 *** davec has quit IRC
1692019-08-30T10:23:50 *** adiabat has quit IRC
1702019-08-30T10:23:50 *** shtirlic has quit IRC
1712019-08-30T10:23:50 *** Evel-Knievel has quit IRC
1722019-08-30T10:23:50 *** ppisati has quit IRC
1732019-08-30T10:23:50 *** andytoshi has quit IRC
1742019-08-30T10:23:50 *** cdecker has quit IRC
1752019-08-30T10:23:50 *** tynes has quit IRC
1762019-08-30T10:23:50 *** dmkathayat has quit IRC
1772019-08-30T10:23:50 *** earlz has quit IRC
1782019-08-30T10:23:50 *** Jaamg has quit IRC
1792019-08-30T10:23:50 *** hirish has quit IRC
1802019-08-30T10:23:50 *** nodweber has quit IRC
1812019-08-30T10:23:50 *** so has quit IRC
1822019-08-30T10:23:54 *** adam3us has joined #bitcoin-core-dev
1832019-08-30T10:23:57 *** slimcognito_ has joined #bitcoin-core-dev
1842019-08-30T10:24:04 *** comboy has joined #bitcoin-core-dev
1852019-08-30T10:24:06 *** rabidus has joined #bitcoin-core-dev
1862019-08-30T10:24:06 *** asoltys has joined #bitcoin-core-dev
1872019-08-30T10:24:21 *** dongcarl has joined #bitcoin-core-dev
1882019-08-30T10:24:22 *** Bullitje has joined #bitcoin-core-dev
1892019-08-30T10:24:27 *** cdecker has joined #bitcoin-core-dev
1902019-08-30T10:25:45 *** gribble has quit IRC
1912019-08-30T10:25:53 *** promag has joined #bitcoin-core-dev
1922019-08-30T10:26:05 *** tryphe has joined #bitcoin-core-dev
1932019-08-30T10:26:08 *** lio17 has joined #bitcoin-core-dev
1942019-08-30T10:26:19 *** sleepych has joined #bitcoin-core-dev
1952019-08-30T10:26:21 *** Evel-Knievel has joined #bitcoin-core-dev
1962019-08-30T10:26:54 *** hirish has joined #bitcoin-core-dev
1972019-08-30T10:27:08 *** Victorsueca has joined #bitcoin-core-dev
1982019-08-30T10:27:32 *** Lauda has joined #bitcoin-core-dev
1992019-08-30T10:27:32 *** tynes has joined #bitcoin-core-dev
2002019-08-30T10:27:35 *** Lauda has quit IRC
2012019-08-30T10:27:36 *** Lauda has joined #bitcoin-core-dev
2022019-08-30T10:27:38 *** shtirlic has joined #bitcoin-core-dev
2032019-08-30T10:27:39 *** dmkathayat has joined #bitcoin-core-dev
2042019-08-30T10:27:45 *** a5m0 has joined #bitcoin-core-dev
2052019-08-30T10:27:57 *** Karyon has joined #bitcoin-core-dev
2062019-08-30T10:28:38 *** fox2p has joined #bitcoin-core-dev
2072019-08-30T10:28:51 *** pinheadmz has joined #bitcoin-core-dev
2082019-08-30T10:29:06 *** Jaamg has joined #bitcoin-core-dev
2092019-08-30T10:29:07 *** davec has joined #bitcoin-core-dev
2102019-08-30T10:29:11 *** gribble has joined #bitcoin-core-dev
2112019-08-30T10:29:12 *** nodweber has joined #bitcoin-core-dev
2122019-08-30T10:29:27 *** earlz has joined #bitcoin-core-dev
2132019-08-30T10:29:32 *** jcorgan has joined #bitcoin-core-dev
2142019-08-30T10:29:32 *** ppisati has joined #bitcoin-core-dev
2152019-08-30T10:29:38 *** commavir has joined #bitcoin-core-dev
2162019-08-30T10:29:44 *** andytoshi has joined #bitcoin-core-dev
2172019-08-30T10:29:44 *** andytoshi has joined #bitcoin-core-dev
2182019-08-30T10:30:02 *** ccdle12 has quit IRC
2192019-08-30T10:30:32 *** justanotheruser has joined #bitcoin-core-dev
2202019-08-30T10:31:22 *** nanotube has joined #bitcoin-core-dev
2212019-08-30T10:32:07 *** ccdle12 has joined #bitcoin-core-dev
2222019-08-30T10:39:43 *** farmerwampum has joined #bitcoin-core-dev
2232019-08-30T10:40:49 *** adiabat has joined #bitcoin-core-dev
2242019-08-30T10:48:12 *** gelmutshmidt has joined #bitcoin-core-dev
2252019-08-30T10:50:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2262019-08-30T10:58:10 *** shesek has quit IRC
2272019-08-30T11:03:00 *** Chris_Stewart_5 has quit IRC
2282019-08-30T11:09:36 *** spinza has joined #bitcoin-core-dev
2292019-08-30T11:11:55 *** michaelfolkson has joined #bitcoin-core-dev
2302019-08-30T11:15:36 *** michaelfolkson has quit IRC
2312019-08-30T11:18:21 *** michaelfolkson has joined #bitcoin-core-dev
2322019-08-30T11:27:28 *** jtimon has joined #bitcoin-core-dev
2332019-08-30T11:31:43 *** jonatack has quit IRC
2342019-08-30T11:44:12 <meshcollider> Reminder that wallet meeting is this week
2352019-08-30T11:54:00 *** gelmutshmidt has quit IRC
2362019-08-30T12:00:02 *** donri has quit IRC
2372019-08-30T12:05:37 *** emilengler_ is now known as emilengler
2382019-08-30T12:10:37 *** michaelfolkson has quit IRC
2392019-08-30T12:17:36 *** geekosaur has joined #bitcoin-core-dev
2402019-08-30T12:17:59 *** geekosaur is now known as Guest97834
2412019-08-30T12:19:21 *** TheHoliestRoger is now known as TheresaMay
2422019-08-30T13:02:15 *** spaced0ut has joined #bitcoin-core-dev
2432019-08-30T13:02:36 *** EagleTM has quit IRC
2442019-08-30T13:09:38 *** promag has quit IRC
2452019-08-30T13:25:21 *** lightlike has joined #bitcoin-core-dev
2462019-08-30T13:35:38 *** tryphe has quit IRC
2472019-08-30T13:36:04 *** tryphe has joined #bitcoin-core-dev
2482019-08-30T13:38:45 *** jonatack has joined #bitcoin-core-dev
2492019-08-30T13:51:52 *** sipa has quit IRC
2502019-08-30T13:54:24 *** michaelfolkson has joined #bitcoin-core-dev
2512019-08-30T13:58:40 *** sipa has joined #bitcoin-core-dev
2522019-08-30T14:12:12 *** michaelfolkson has quit IRC
2532019-08-30T14:20:45 *** michaelfolkson has joined #bitcoin-core-dev
2542019-08-30T14:27:35 *** michaelfolkson has quit IRC
2552019-08-30T14:36:08 *** tryphe has quit IRC
2562019-08-30T14:36:36 *** tryphe has joined #bitcoin-core-dev
2572019-08-30T14:43:02 *** EagleTM has joined #bitcoin-core-dev
2582019-08-30T14:52:24 *** mdunnio has joined #bitcoin-core-dev
2592019-08-30T15:00:01 *** Guest97834 has quit IRC
2602019-08-30T15:02:43 *** mdunnio has quit IRC
2612019-08-30T15:04:24 *** mdunnio has joined #bitcoin-core-dev
2622019-08-30T15:23:20 *** EagleTM has quit IRC
2632019-08-30T15:26:21 *** pinheadmz has quit IRC
2642019-08-30T15:27:41 *** pinheadmz has joined #bitcoin-core-dev
2652019-08-30T15:32:58 *** bitcoin-git has joined #bitcoin-core-dev
2662019-08-30T15:32:58 <bitcoin-git> [bitcoin] GChuf opened pull request #16764: gui: update description for default language (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16764
2672019-08-30T15:33:02 *** bitcoin-git has left #bitcoin-core-dev
2682019-08-30T15:36:08 *** tryphe has quit IRC
2692019-08-30T15:36:36 *** tryphe has joined #bitcoin-core-dev
2702019-08-30T15:45:18 *** jbarnette has joined #bitcoin-core-dev
2712019-08-30T15:49:48 *** Salve has joined #bitcoin-core-dev
2722019-08-30T16:04:29 *** alko has joined #bitcoin-core-dev
2732019-08-30T16:17:08 *** jarthur has joined #bitcoin-core-dev
2742019-08-30T16:19:24 *** kljasdfvv has quit IRC
2752019-08-30T16:32:18 *** mdunnio has quit IRC
2762019-08-30T16:36:08 *** tryphe has quit IRC
2772019-08-30T16:36:33 *** tryphe has joined #bitcoin-core-dev
2782019-08-30T16:40:53 *** m1rror has quit IRC
2792019-08-30T16:41:21 *** m1rror has joined #bitcoin-core-dev
2802019-08-30T16:47:07 *** Emcy has quit IRC
2812019-08-30T16:52:12 *** jungly has quit IRC
2822019-08-30T17:01:35 *** jamesob has left #bitcoin-core-dev
2832019-08-30T17:01:43 *** jamesob has joined #bitcoin-core-dev
2842019-08-30T17:04:56 *** lowentropy has joined #bitcoin-core-dev
2852019-08-30T17:06:53 *** mdunnio has joined #bitcoin-core-dev
2862019-08-30T17:10:33 *** TheresaMay is now known as Holiest
2872019-08-30T17:10:41 *** Holiest is now known as HoliestRoger
2882019-08-30T17:10:45 *** HoliestRoger is now known as group
2892019-08-30T17:10:49 *** group is now known as HoliestRoger
2902019-08-30T17:11:52 *** mdunnio has quit IRC
2912019-08-30T17:20:11 *** liberiga has joined #bitcoin-core-dev
2922019-08-30T17:24:49 *** mdunnio has joined #bitcoin-core-dev
2932019-08-30T17:36:08 *** tryphe has quit IRC
2942019-08-30T17:36:16 *** Guyver2 has joined #bitcoin-core-dev
2952019-08-30T17:36:32 *** tryphe has joined #bitcoin-core-dev
2962019-08-30T17:38:38 *** mdunnio has quit IRC
2972019-08-30T17:46:40 *** mdunnio has joined #bitcoin-core-dev
2982019-08-30T17:55:01 *** bitcoin-git has joined #bitcoin-core-dev
2992019-08-30T17:55:01 <bitcoin-git> [bitcoin] GChuf closed pull request #16764: gui: update description for default language (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16764
3002019-08-30T17:55:04 *** bitcoin-git has left #bitcoin-core-dev
3012019-08-30T18:00:02 *** owowo has quit IRC
3022019-08-30T18:00:02 *** jbarnette has quit IRC
3032019-08-30T18:01:22 *** owowo has joined #bitcoin-core-dev
3042019-08-30T18:01:39 <jeremyrubin> For IsTrusted, can someone explain why we don't recursively call istrusted on the parent?
3052019-08-30T18:02:13 <jeremyrubin> Currently we iterate over the inputs and check IsMine != Spendable
3062019-08-30T18:03:17 <jeremyrubin> Is that sufficient if we're spending from an unconfirmed tx?
3072019-08-30T18:11:43 *** sleepych has quit IRC
3082019-08-30T18:15:32 *** cprofitt1 has joined #bitcoin-core-dev
3092019-08-30T18:30:16 *** jarthur_ has joined #bitcoin-core-dev
3102019-08-30T18:33:48 *** jarthur has quit IRC
3112019-08-30T18:37:02 *** ccdle12 has quit IRC
3122019-08-30T18:49:28 *** jamesob has left #bitcoin-core-dev
3132019-08-30T18:50:13 *** jamesob has joined #bitcoin-core-dev
3142019-08-30T18:50:19 <jamesob> can anyone hear me yet?
3152019-08-30T18:50:55 <achow101> jamesob: shout louder
3162019-08-30T18:51:02 <jamesob> achow101: hah thanks
3172019-08-30T18:52:58 *** ccdle12 has joined #bitcoin-core-dev
3182019-08-30T18:53:23 <jamesob> sipa: apologies, tried replying to your question but freenode had me muted (or something). haven't tried sparsehash for chainstate but in general it looked not to perform as well as the robin_hood map. is there some reason in particular you think it'd be worth trying?
3192019-08-30T18:53:54 <instagibbs> jeremyrubin, I *think* it's by induction? if the previous output with !IsTrusted parent exists, you won't spend, right?
3202019-08-30T18:54:08 <instagibbs> if somehow you did, say raw API, well SFYL I guess
3212019-08-30T18:54:18 *** Emcy has joined #bitcoin-core-dev
3222019-08-30T18:54:47 *** jarthur_ has quit IRC
3232019-08-30T19:00:25 <meshcollider> #startmeeting
3242019-08-30T19:00:25 <lightningbot> Meeting started Fri Aug 30 19:00:25 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3252019-08-30T19:00:25 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3262019-08-30T19:00:30 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
3272019-08-30T19:00:33 <instagibbs> hi
3282019-08-30T19:00:35 <achow101> hi
3292019-08-30T19:00:35 <kanzure> hi
3302019-08-30T19:00:44 <provoostenator> hi
3312019-08-30T19:00:51 <meshcollider> Topics this week?
3322019-08-30T19:00:52 <awesome-doge> hi
3332019-08-30T19:00:55 <wumpus> hi
3342019-08-30T19:01:13 <sipa> hi
3352019-08-30T19:01:20 <instagibbs> might need some assist reasoning about safety of new arg in #11413
3362019-08-30T19:01:23 <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
3372019-08-30T19:01:51 <instagibbs> I'd like to use the X sat/B etc style as well for my bumpfee PR
3382019-08-30T19:02:22 <jtimon> I guess #16524 could be on-topic for this meeting?
3392019-08-30T19:02:24 <gribble> https://github.com/bitcoin/bitcoin/issues/16524 | Wallet: Disable -fallbackfee by default by jtimon · Pull Request #16524 · bitcoin/bitcoin · GitHub
3402019-08-30T19:02:52 <sipa> i'll try to have a first miniscript pr ready today
3412019-08-30T19:02:59 <achow101> woo miniscript
3422019-08-30T19:03:01 <meshcollider> instagibbs: is that a request for comment in the PR or do you want to discuss it here?
3432019-08-30T19:03:26 <meshcollider> sipa: exciting! :)
3442019-08-30T19:03:52 <instagibbs> meshcollider, the thread I guess? Unless someone has Strong Opinions
3452019-08-30T19:04:17 <instagibbs> problem with that PR is that it's hijacking the conf_target arg, which already has meaning without unit
3462019-08-30T19:04:19 <provoostenator> Probably good to discuss here,
3472019-08-30T19:04:34 <instagibbs> ok I propose as topic then
3482019-08-30T19:04:53 <meshcollider> #topic explicit feerate option (instagibbs)
3492019-08-30T19:05:12 <provoostenator> The easiest would be to make it mandotary to specify, but that is a breaking change.
3502019-08-30T19:06:05 <instagibbs> Right, it's really hard to do it safely without that, even if you don't re-purposed conf_target(unless you have 0 mean not using it?)
3512019-08-30T19:06:46 <provoostenator> I'm going to guess that most automated systems already set the estimate_mode param
3522019-08-30T19:07:01 <provoostenator> So those won't be affected.
3532019-08-30T19:08:28 *** laptop500 has joined #bitcoin-core-dev
3542019-08-30T19:08:31 <provoostenator> If we deprecate & remove the "UNSET" (default) the error will at least be very clear and easy to detect if someone doesn't read the release notes.
3552019-08-30T19:08:39 <provoostenator> But maybe that's already going to far.
3562019-08-30T19:08:57 <instagibbs> that means really basic usage will break
3572019-08-30T19:09:05 <instagibbs> forcing -cli users to put in tons of args
3582019-08-30T19:09:24 <provoostenator> Forcing -cli users to specifiy what they mean with the fee rate seems reasonable to me.
3592019-08-30T19:09:44 <instagibbs> and the comment, comment-to, subtract fee from dest...
3602019-08-30T19:10:22 <achow101> named args gets around having to specify everything else
3612019-08-30T19:10:34 <provoostenator> I don't know if we can change the order to mvoe the fee rate first, in such a way that old invocations are guaranteed to fail
3622019-08-30T19:10:54 <achow101> I would rather not requiring users to have to specify the fee rate
3632019-08-30T19:11:23 <provoostenator> Ideally I would like "sendtoaddress AMOUNT ADDRESS FEE_RATE sat/B"
3642019-08-30T19:11:41 <instagibbs> new RPC command time? :P
3652019-08-30T19:11:46 <instagibbs> time to scope creep
3662019-08-30T19:12:01 <achow101> provoostenator has some ultimate send rpc pr
3672019-08-30T19:12:07 <instagibbs> hmm that's true
3682019-08-30T19:12:08 <provoostenator> #16378
3692019-08-30T19:12:10 <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | [WIP] The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
3702019-08-30T19:12:10 <provoostenator> I was tempted
3712019-08-30T19:12:21 <achow101> maybe we should deprecate all the existing send rpcs and just make one that doesn't suck?
3722019-08-30T19:12:29 <provoostenator> But problem is, it'll be nice for a year or two, and then it sucks again.
3732019-08-30T19:12:48 <provoostenator> But I'm happy to reopen.
3742019-08-30T19:12:57 <sipa> mandatory xkcd: https://xkcd.com/927/
3752019-08-30T19:13:01 <achow101> new rpcs: sendv1, sendv2, sendv3...
3762019-08-30T19:13:19 <provoostenator> Having a new RPC that's safe to use for newbies and useful for advanced forlks, might be worth doing.
3772019-08-30T19:14:20 <instagibbs> maybe brainstorm on how to make changes easier in the future. e.g., require units in args rather than implicit, I don't know
3782019-08-30T19:14:33 <provoostenator> It'd be useful to have an idea of what extra stuff we want that RPC to do in light of miniscript and multisig.
3792019-08-30T19:14:41 <provoostenator> Hopefully "nothing"
3802019-08-30T19:15:28 <instagibbs> If no one has objections to the "Xsat/B" type format I can roll with that for my PR at least
3812019-08-30T19:15:44 <achow101> ideally we would also have fee per weight unit too
3822019-08-30T19:15:46 <provoostenator> We could do something pedanctic like a 5 second delay that the user can abort with ctrl + c, if and only if the user didn't set an explicit argument.
3832019-08-30T19:16:01 <instagibbs> s/Wu :) c-lightning feelz
3842019-08-30T19:16:04 <achow101> I would prefer a single arg that specifies the unit at the end
3852019-08-30T19:16:42 <provoostenator> single arg with unit at the end has my preference too. As well as consistency between RPC calls.
3862019-08-30T19:17:17 <instagibbs> ok, I'll at least adapt my PR with a "standard" proposal
3872019-08-30T19:17:17 <meshcollider> Yes that seems clean
3882019-08-30T19:17:30 <instagibbs> then we can parse them all the same way in the future
3892019-08-30T19:17:33 <meshcollider> So what about kalle's PR
3902019-08-30T19:17:33 <instagibbs> with same code
3912019-08-30T19:17:40 <instagibbs> that's complicated. I don't really know.
3922019-08-30T19:17:52 <instagibbs> deprecate non-specified is the safe behavior
3932019-08-30T19:18:26 <instagibbs> non-specified unit*
3942019-08-30T19:19:52 <instagibbs> maybe kallewoof will have something to say when he awakes
3952019-08-30T19:20:21 <instagibbs> end topic I guess
3962019-08-30T19:21:09 <meshcollider> #topic disable -fallbackfee (jtimon)
3972019-08-30T19:21:33 <meshcollider> #16542
3982019-08-30T19:21:35 <gribble> https://github.com/bitcoin/bitcoin/issues/16542 | Return more specific errors about invalid descriptors by achow101 · Pull Request #16542 · bitcoin/bitcoin · GitHub
3992019-08-30T19:21:38 <meshcollider> Oops
4002019-08-30T19:21:55 <meshcollider> #16524
4012019-08-30T19:21:57 <gribble> https://github.com/bitcoin/bitcoin/issues/16524 | Wallet: Disable -fallbackfee by default by jtimon · Pull Request #16524 · bitcoin/bitcoin · GitHub
4022019-08-30T19:22:22 <jtimon> so what the PR does is having the same defualt for regtest as it has on mainnet, simply decoupling it from the chainparams stuff
4032019-08-30T19:23:13 <achow101> isn't the fallbackkfee useful though?
4042019-08-30T19:23:21 <instagibbs> it's useful to just have tests "Go"
4052019-08-30T19:23:49 <jtimon> it can still be used, you just don't have a different default for regtest
4062019-08-30T19:24:14 <instagibbs> so this is mostly just to pull it out of the chainparams?
4072019-08-30T19:24:42 <jtimon> I mean, I assume at some point we may want to change mainnet's default, but I think that's kind of orthogonal
4082019-08-30T19:24:50 <jtimon> instagibbs: yes
4092019-08-30T19:25:30 <meshcollider> Well it's not really "in" chainparams
4102019-08-30T19:26:20 <instagibbs> I guess I'm -0 on it, unless I see "where it's going" with follow-on changes? network-specific behavior outside of consensus params aren't going away..
4112019-08-30T19:26:33 <jtimon> well, it is, it was just renamed to IsTestChain to couple it with another chainparams that says whether your chain allows you to set acceptnonstdtxs to true or not
4122019-08-30T19:27:26 <jtimon> I have 2 follow up PRs, but they're more related to chainparams than to the wallet: https://github.com/bitcoin/bitcoin/pull/16527 and https://github.com/bitcoin/bitcoin/pull/16526
4132019-08-30T19:28:35 <jtimon> I mean, I guess this is removign a feature, but is it really that important? is it that harsh to ask regtest and testnet users to set -fallbackfee explicitly?
4142019-08-30T19:28:50 <instagibbs> it's one sticking point that requires a restart
4152019-08-30T19:29:09 <instagibbs> that basically any one-off regtest users is going to have to remember to do
4162019-08-30T19:29:21 <instagibbs> anyways, maybe im off base
4172019-08-30T19:29:32 <meshcollider> Regtest will rarely have enough data for fee estimation so it is kinda annoying to have to set it every time but I'm -0 too I guess
4182019-08-30T19:29:44 <jtimon> I guess you won't like #16527 either then
4192019-08-30T19:29:46 <gribble> https://github.com/bitcoin/bitcoin/issues/16527 | B: Get rid of Params().RequireStandard() by jtimon · Pull Request #16527 · bitcoin/bitcoin · GitHub
4202019-08-30T19:30:11 <instagibbs> well that won't help/stop "sendtoaddress" from working
4212019-08-30T19:30:22 <instagibbs> which the fallback PR would
4222019-08-30T19:30:56 <instagibbs> I think it's case by case
4232019-08-30T19:31:02 <provoostenator> It wouldn't be too bad if "1 sat/B" exists
4242019-08-30T19:31:04 <jtimon> so if we don't want to do this, can we at least rename it back to what it was instead of coupling it with other unrelated things with IsTestChain?
4252019-08-30T19:31:30 <instagibbs> could also just decouple it yeah
4262019-08-30T19:33:12 <jtimon> any more thoughts? if people agree with instagibbs I think that's it
4272019-08-30T19:33:22 <jtimon> that's it forf this topic, I mean
4282019-08-30T19:33:32 <meshcollider> Yeah I agree with instagibbs here
4292019-08-30T19:34:03 <meshcollider> sipa: did you want to talk about miniscript or was that just a PSA
4302019-08-30T19:34:11 <jtimon> cool, but to be clear, we agree on decoupling the IsTestChain stuff ?
4312019-08-30T19:34:12 <sipa> i guess
4322019-08-30T19:34:17 <instagibbs> jtimon, concept ACK
4332019-08-30T19:34:25 <instagibbs> (only speaking for self)
4342019-08-30T19:34:29 <jtimon> cool, thanks
4352019-08-30T19:35:04 <instagibbs> sipa, wasn't a yes or no question :P
4362019-08-30T19:35:27 <jtimon> sure, anyone feel free to express any nuances
4372019-08-30T19:35:40 <sipa> so there are really 4 different places miniscript can be integrated into: descriptors themselves (like, be able to write them, check them, compute addresses from), descriptor inference (finding a miniscript descriptor for a miniscript-compatible script), signing (including psbt update/finalize), and size estimation
4382019-08-30T19:35:52 <meshcollider> #topic miniscript (sipa)
4392019-08-30T19:36:20 <sipa> i'm working on a PR that includes just the first one (and maybe the second one), because the latter ones add quite a bit of complexity
4402019-08-30T19:36:28 <sipa> of course, it's also kinda pointless without the last ones
4412019-08-30T19:37:07 <achow101> I think 1 and 3 are the most useful to have first
4422019-08-30T19:37:21 <provoostenator> sipa: does miniscript (or your PR) help with the open issue of composing descriptors (as opposed to parsing string)?
4432019-08-30T19:37:46 <provoostenator> E.g. for hardware wallet support it'd be nice if we can get an xpub from the device and make a descriptor.
4442019-08-30T19:37:52 <provoostenator> Which currently involves hacking strings.
4452019-08-30T19:38:04 <sipa> no
4462019-08-30T19:38:08 <sipa> haven't looked at that
4472019-08-30T19:38:21 <meshcollider> provoostenator: open issue? Isn't that just an implementation feature
4482019-08-30T19:38:30 <provoostenator> Not literally an issue
4492019-08-30T19:38:38 <sipa> yeahh it's an imetail
4502019-08-30T19:38:43 <sipa> could be fixed with a bit of refactoring
4512019-08-30T19:38:50 <sipa> yeah it's an implementation detail
4522019-08-30T19:39:07 <sipa> why is my keyboard randomly dropping some letters
4532019-08-30T19:39:20 <provoostenator> Kind of. It gets more interesting with multisig
4542019-08-30T19:39:23 <sipa> achow101: 3 without 4 is a bit scary
4552019-08-30T19:39:33 *** bitcoin-git has joined #bitcoin-core-dev
4562019-08-30T19:39:34 <bitcoin-git> [bitcoin] godfrey-cw opened pull request #16765: Documentation for `systemd` troubleshooting (master...master) https://github.com/bitcoin/bitcoin/pull/16765
4572019-08-30T19:39:35 *** bitcoin-git has left #bitcoin-core-dev
4582019-08-30T19:39:50 <sipa> right now we do size estimation just using the dummy signer... which works fine for single sig and multisig because every witness has the same size
4592019-08-30T19:40:02 <gwillen> 16IBtbcikinvnffggjcutlcrevrijukb
4602019-08-30T19:40:11 <sipa> gwillen: no begging!
4612019-08-30T19:40:34 <sipa> but with more complicated things it would result in the lowest possible sizes across all possible witnesses
4622019-08-30T19:40:52 <sipa> so that may cause fee underestimation
4632019-08-30T19:40:56 <provoostenator> That's probably not actually gwillen.
4642019-08-30T19:41:58 <gwillen> oops, sorry
4652019-08-30T19:42:00 <gwillen> that's no an address
4662019-08-30T19:42:05 <gwillen> it's an OTP from a yubikey
4672019-08-30T19:42:09 <sipa> haha
4682019-08-30T19:42:11 <provoostenator> LOL
4692019-08-30T19:42:25 <sipa> anyway, there'll be more to discuss when i have code to show
4702019-08-30T19:42:45 <achow101> sipa: maybe temporarily limit signing to single key until size estimation is in?
4712019-08-30T19:42:56 <achow101> like have it all there, but put some gate in the caller
4722019-08-30T19:43:19 <achow101> s/single key/things we already sign for
4732019-08-30T19:43:53 <sipa> but it's an interesting question how to structure things; in particular, the internal satisfaction code is very useful to test other parts of the miniscript logic (e.g., do randomized tests that show the stack size never exceeds the statically predicted max stack size)
4742019-08-30T19:44:13 <sipa> even if it isn't exposed yet because of lack of 4
4752019-08-30T19:45:11 <meshcollider> sipa: sounds good yeah
4762019-08-30T19:45:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4772019-08-30T19:46:01 *** bitcoin-git has joined #bitcoin-core-dev
4782019-08-30T19:46:01 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #16766: Make IsTrusted scan parents recursively (master...recursive-istrusted) https://github.com/bitcoin/bitcoin/pull/16766
4792019-08-30T19:46:02 *** bitcoin-git has left #bitcoin-core-dev
4802019-08-30T19:46:06 <meshcollider> Ok we wait for pr then
4812019-08-30T19:46:10 <meshcollider> Any other topics?
4822019-08-30T19:47:06 <jeremyrubin> Well it is wallet related, but if anyone wants to look at the PR I just opened would be thankful.
4832019-08-30T19:47:51 <jeremyrubin> Trying to patch in covenant detection for OP_SECURETHEBAG so that you know if you can trust funds have been paid
4842019-08-30T19:48:09 <jeremyrubin> But the lack of recursive trust seems like a bug because it breaks transitivity
4852019-08-30T19:48:58 <sipa> jeremyrubin: can you give an example of how parents could be untrusted but a child is false marked as trusted?
4862019-08-30T19:49:37 <jeremyrubin> Sure
4872019-08-30T19:50:11 <jeremyrubin> Suppose I have a txn B which I generated from a output A.0
4882019-08-30T19:50:38 <jeremyrubin> A.0 ISMINE_SPENDABLE
4892019-08-30T19:51:10 <jeremyrubin> But transaction A has an input Z.0 which is not ISMINESPENDABLE
4902019-08-30T19:51:41 <sipa> which of these are confirmed?
4912019-08-30T19:52:04 <jeremyrubin> None have to be I think
4922019-08-30T19:54:02 <sipa> right so you have Z,A,B in the mempool, and A will be correctly marked as !IsTrusted(), but B will be marked as IsTrusted
4932019-08-30T19:54:44 <jeremyrubin> Yeah that sounds right
4942019-08-30T19:55:48 <meshcollider> I thought transactions in the mempool are always untrusted
4952019-08-30T19:55:51 <jeremyrubin> Z also has to be a wallettx I think, which can be accomplished by having a Z.10 which ismine (so we're tacking it)
4962019-08-30T19:56:40 <meshcollider> Dw ignore me
4972019-08-30T19:56:45 <jeremyrubin> No, if the txn ISMINE_SPENDABLE then in theory only we can spend it (we should probably be checking ISMINE and NOT IS_SOMEONEELSES or something too for complex scripts)
4982019-08-30T19:57:17 <sipa> jeremyrubin: multisig is currently never ISMINE_SPENDABLE, unless you literally have all the keys in your wallet (not even just the threshold)
4992019-08-30T19:57:23 <jeremyrubin> Cool
5002019-08-30T19:57:25 <jeremyrubin> Wasn't sure
5012019-08-30T19:57:34 <sipa> i think that's a horrible mistake, though :)
5022019-08-30T19:57:48 <sipa> ownership of funds shouldn't be tied to control over keys
5032019-08-30T19:58:22 <jeremyrubin> In any case, I think that the recursive check fixes the edge condition
5042019-08-30T19:58:46 <sipa> the performance impact is scary
5052019-08-30T19:59:18 <sipa> you can construct a graph of transactions that makes this computation explode without caching
5062019-08-30T19:59:31 <jeremyrubin> I think it's OK given the limits on longchain in the mempool
5072019-08-30T19:59:40 <sipa> i'm not sure
5082019-08-30T19:59:55 <jeremyrubin> It would also be OK to construct a cache per call to IsTrusted
5092019-08-30T20:00:07 <jeremyrubin> but caching across calls to IsTrusted is a bit finicky
5102019-08-30T20:00:20 <jeremyrubin> Would that sort of caching be happier sipa?
5112019-08-30T20:01:10 <sipa> yeah
5122019-08-30T20:01:32 <jeremyrubin> e.g., you can optionally pass a unordered_set<uint256> trustedParents to the call and you query against that and pass it on recursion
5132019-08-30T20:02:00 <jeremyrubin> k I will modify it to work that way
5142019-08-30T20:02:21 <meshcollider> #endmeeting
5152019-08-30T20:02:21 <lightningbot> Meeting ended Fri Aug 30 20:02:21 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5162019-08-30T20:02:21 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.html
5172019-08-30T20:02:21 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.txt
5182019-08-30T20:02:21 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-30-19.00.log.html
5192019-08-30T20:02:28 <sipa> a graph of transactions consisting of 25 levels, with 2 2-in-2-out transactions per level, each spending an output from each of the previous level's transactions
5202019-08-30T20:02:38 <sipa> i think that would fit in the mempool
5212019-08-30T20:02:48 <sipa> but cost 2^26 IsTrusted calls
5222019-08-30T20:04:33 <sipa> with more outputs and inputs the base of the exponentiation goes up
5232019-08-30T20:08:40 *** mdunnio has quit IRC
5242019-08-30T20:13:30 *** Salve has quit IRC
5252019-08-30T20:13:34 <jeremyrubin> Would you also prefer the code to be a non recursive loop?
5262019-08-30T20:14:02 *** pinheadmz has quit IRC
5272019-08-30T20:16:52 *** mdunnio has joined #bitcoin-core-dev
5282019-08-30T20:38:12 *** Guyver2 has quit IRC
5292019-08-30T20:42:47 <jeremyrubin> I think the recursion isn't too big a deal since we're at most up 25 levels -- lmk if you feel differently. I also decided to only cache the ones we detect as being trusted, but we could cache the untrusted ones as well
5302019-08-30T20:43:34 <jeremyrubin> Caching untrusted seems less a big deal because it works out to be at most 25 (assuming a fully loaded trusted cache)
5312019-08-30T20:52:31 *** Randolf has joined #bitcoin-core-dev
5322019-08-30T20:53:16 *** liberiga has quit IRC
5332019-08-30T21:00:02 *** cprofitt1 has quit IRC
5342019-08-30T21:02:55 *** bitcoin-git has joined #bitcoin-core-dev
5352019-08-30T21:02:55 <bitcoin-git> [bitcoin] kristapsk opened pull request #16767: test: Check for codespell in lint-spelling.sh (master...check-for-codespell) https://github.com/bitcoin/bitcoin/pull/16767
5362019-08-30T21:03:00 *** bitcoin-git has left #bitcoin-core-dev
5372019-08-30T21:08:40 *** Chris_Stewart_5 has quit IRC
5382019-08-30T21:10:33 *** pinheadmz has joined #bitcoin-core-dev
5392019-08-30T21:10:58 *** instagibbs has quit IRC
5402019-08-30T21:11:22 *** instagibbs has joined #bitcoin-core-dev
5412019-08-30T21:11:32 *** iamtimmarchant has joined #bitcoin-core-dev
5422019-08-30T21:14:17 *** laptop500 has quit IRC
5432019-08-30T21:14:37 *** laptop500 has joined #bitcoin-core-dev
5442019-08-30T21:14:39 *** iamtimmarchant has quit IRC
5452019-08-30T21:16:08 *** jarthur has joined #bitcoin-core-dev
5462019-08-30T21:16:47 *** laptop500 has quit IRC
5472019-08-30T21:17:07 *** laptop500 has joined #bitcoin-core-dev
5482019-08-30T21:23:41 *** Randolf has quit IRC
5492019-08-30T21:29:04 *** bitcoin-git has joined #bitcoin-core-dev
5502019-08-30T21:29:04 <bitcoin-git> [bitcoin] kristapsk opened pull request #16768: test: Make lint-includes.sh work from any directory (master...lint-includes-anydir) https://github.com/bitcoin/bitcoin/pull/16768
5512019-08-30T21:29:05 *** bitcoin-git has left #bitcoin-core-dev
5522019-08-30T21:33:53 *** captjakk has joined #bitcoin-core-dev
5532019-08-30T21:34:14 *** HoliestRoger is now known as TheHoliestRoger
5542019-08-30T21:41:12 *** mdunnio has quit IRC
5552019-08-30T21:43:11 *** mkrautz1 has joined #bitcoin-core-dev
5562019-08-30T22:03:23 *** ccdle12 has quit IRC
5572019-08-30T22:06:09 *** mdunnio has joined #bitcoin-core-dev
5582019-08-30T22:11:36 *** mdunnio has quit IRC
5592019-08-30T22:12:42 *** jarthur has quit IRC
5602019-08-30T22:37:09 *** tryphe has quit IRC
5612019-08-30T22:37:09 *** Giszmo has quit IRC
5622019-08-30T22:37:35 *** tryphe has joined #bitcoin-core-dev
5632019-08-30T22:39:19 *** Giszmo has joined #bitcoin-core-dev
5642019-08-30T23:23:59 *** davex_ has quit IRC
5652019-08-30T23:24:22 *** davex__ has quit IRC
5662019-08-30T23:24:25 *** davex_ has joined #bitcoin-core-dev
5672019-08-30T23:25:30 *** davex__ has joined #bitcoin-core-dev
5682019-08-30T23:37:08 *** tryphe has quit IRC
5692019-08-30T23:37:32 *** tryphe has joined #bitcoin-core-dev
5702019-08-30T23:49:05 *** rh0nj has quit IRC
5712019-08-30T23:50:09 *** rh0nj has joined #bitcoin-core-dev
5722019-08-30T23:52:42 *** laptop500 has quit IRC
5732019-08-30T23:55:03 *** pinheadmz has quit IRC