12019-09-11T00:00:02 *** brimstone1 has quit IRC
22019-09-11T00:02:58 *** ddustin has quit IRC
32019-09-11T00:03:58 *** ddustin has joined #bitcoin-core-dev
42019-09-11T00:04:03 *** silas26 has quit IRC
52019-09-11T00:09:09 *** ddustin has quit IRC
62019-09-11T00:11:59 *** AaronvanW has joined #bitcoin-core-dev
72019-09-11T00:12:04 *** promag_ has joined #bitcoin-core-dev
82019-09-11T00:16:21 *** AaronvanW has quit IRC
92019-09-11T00:16:27 *** promag_ has quit IRC
102019-09-11T00:17:42 *** furkanmustafa has joined #bitcoin-core-dev
112019-09-11T00:22:33 *** davec has quit IRC
122019-09-11T00:31:58 *** captjakk has joined #bitcoin-core-dev
132019-09-11T00:37:20 *** dviola has quit IRC
142019-09-11T00:48:04 *** AaronvanW has joined #bitcoin-core-dev
152019-09-11T00:55:22 *** mdunnio has joined #bitcoin-core-dev
162019-09-11T00:57:46 *** AaronvanW has quit IRC
172019-09-11T00:58:49 *** mdunnio has quit IRC
182019-09-11T00:59:56 *** mdunnio has joined #bitcoin-core-dev
192019-09-11T01:04:20 *** lightlike has quit IRC
202019-09-11T01:05:33 *** promag has quit IRC
212019-09-11T01:06:10 *** Krellan has joined #bitcoin-core-dev
222019-09-11T01:13:47 *** promag has joined #bitcoin-core-dev
232019-09-11T01:13:54 *** promag_ has joined #bitcoin-core-dev
242019-09-11T01:16:31 *** jayme40 has joined #bitcoin-core-dev
252019-09-11T01:18:23 *** promag_ has quit IRC
262019-09-11T01:19:02 *** davec has joined #bitcoin-core-dev
272019-09-11T01:26:11 *** mdunnio has quit IRC
282019-09-11T01:26:20 *** jayme40 has quit IRC
292019-09-11T01:27:17 *** DeanGuss has joined #bitcoin-core-dev
302019-09-11T01:30:14 *** mdunnio has joined #bitcoin-core-dev
312019-09-11T01:30:38 *** AaronvanW has joined #bitcoin-core-dev
322019-09-11T01:33:55 <luke-jr> achow101: if you want to argue it's technically BIP70-independent since it's not on the network, okay, but the fact is that --disable-bip70 disables that code too :/
332019-09-11T01:35:14 *** AaronvanW has quit IRC
342019-09-11T01:35:17 <achow101> luke-jr: huh? my point was that it isn't something stored in the wallet db that requires bip70 to decode. it's a message, and afaict, it's still shown to the user, it will just look different
352019-09-11T01:37:50 <achow101> if there is something that requires bip70 to decode, could you give me a code ref to it?
362019-09-11T01:41:28 *** Krellan has quit IRC
372019-09-11T01:50:42 <achow101> Also, if there is something that is protobuf encoded that is stored, we can just a do a minial protobuf decoder to get the data that needs to be shown
382019-09-11T01:52:25 *** mdunnio has quit IRC
392019-09-11T01:53:02 <luke-jr> achow101: the part in the #ifdef that's protobuf-encoded
402019-09-11T01:53:37 <achow101> luke-jr: there's a ton of #ifef ENABLE_BIP70 lines
412019-09-11T01:54:00 *** jonatack has quit IRC
422019-09-11T01:59:53 <luke-jr> achow101: looking over the code, I only see the authenticated merchant name in the transactiondesc
432019-09-11T02:00:11 *** niska has quit IRC
442019-09-11T02:00:42 <achow101> Oh.. I see it now
452019-09-11T02:01:24 <luke-jr> looks like that's all I was migrating in #15064 as well
462019-09-11T02:01:26 <gribble> https://github.com/bitcoin/bitcoin/issues/15064 | [PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] by luke-jr · Pull Request #15064 · bitcoin/bitcoin · GitHub
472019-09-11T02:02:12 <luke-jr> I'm not sure extracting it w/o protobuf+OpenSSL is easy, but maybe I'm wrong
482019-09-11T02:04:29 <achow101> i'm not sure that that is necesarily worth trying to keep. If the cert is expired (as it eventually will be), then there won't be a name shown anyways
492019-09-11T02:04:45 <luke-jr> hmm
502019-09-11T02:05:08 <luke-jr> sounds like a bug if we don't use the tx date when checking expiration, but oh well
512019-09-11T02:05:12 <achow101> and there's been recent discussions with the CAB forum to reduce cert expirys to 1 year
522019-09-11T02:05:24 *** niska has joined #bitcoin-core-dev
532019-09-11T02:05:42 *** emilengler_ has joined #bitcoin-core-dev
542019-09-11T02:06:22 *** AaronvanW has joined #bitcoin-core-dev
552019-09-11T02:06:57 *** promag has joined #bitcoin-core-dev
562019-09-11T02:08:27 *** emilengler has quit IRC
572019-09-11T02:09:17 *** elichai2 has quit IRC
582019-09-11T02:11:09 *** promag has quit IRC
592019-09-11T02:11:14 *** AaronvanW has quit IRC
602019-09-11T02:15:52 *** niska has quit IRC
612019-09-11T02:24:26 *** niska has joined #bitcoin-core-dev
622019-09-11T02:28:51 <achow101> luke-jr: could just say that the merchant name is unauthenticated
632019-09-11T02:39:01 <BlueMatt> luke-jr: looks like your pr needs a rebase?
642019-09-11T02:39:02 *** AaronvanW has joined #bitcoin-core-dev
652019-09-11T02:39:12 <BlueMatt> luke-jr: it also looks pretty simple, maybe we can land it for 19?
662019-09-11T02:39:34 <BlueMatt> I mean I dont know anything about the gui, someone else should chime in, but it looks reasonable enough?
672019-09-11T02:43:44 *** AaronvanW has quit IRC
682019-09-11T02:52:24 <achow101> luke-jr: I think both are relatively straightforward to decode. I can work on a decoder to extract the merchant name
692019-09-11T02:53:21 <achow101> it would be preferable if we could get disable bip70 in 0.19 rather than having to wait another version to let people migrate
702019-09-11T03:00:03 *** furkanmustafa has quit IRC
712019-09-11T03:11:20 *** AaronvanW has joined #bitcoin-core-dev
722019-09-11T03:14:24 *** promag has joined #bitcoin-core-dev
732019-09-11T03:15:39 *** AaronvanW has quit IRC
742019-09-11T03:17:30 *** DragonEyes1 has joined #bitcoin-core-dev
752019-09-11T03:18:48 *** promag has quit IRC
762019-09-11T03:26:18 *** kcalvinalvin has joined #bitcoin-core-dev
772019-09-11T03:29:32 *** DeanGuss has quit IRC
782019-09-11T03:37:33 *** Krellan has joined #bitcoin-core-dev
792019-09-11T03:39:08 <luke-jr> BlueMatt: it doesn't make sense if we're disablign BIP70 too
802019-09-11T03:39:26 <luke-jr> in that case, we would need to either just accept the lost metadata, or write a custom decoder
812019-09-11T03:40:16 *** wallet42 has quit IRC
822019-09-11T03:43:22 *** harding has quit IRC
832019-09-11T03:44:56 *** wallet42 has joined #bitcoin-core-dev
842019-09-11T03:48:06 *** davec has quit IRC
852019-09-11T03:48:52 *** AaronvanW has joined #bitcoin-core-dev
862019-09-11T03:49:19 *** promag has joined #bitcoin-core-dev
872019-09-11T03:53:56 *** promag has quit IRC
882019-09-11T03:53:56 *** AaronvanW has quit IRC
892019-09-11T04:01:42 *** davec has joined #bitcoin-core-dev
902019-09-11T04:12:04 *** Krellan has quit IRC
912019-09-11T04:23:27 *** kcalvinalvin has quit IRC
922019-09-11T04:25:29 *** harding has joined #bitcoin-core-dev
932019-09-11T04:26:00 *** AaronvanW has joined #bitcoin-core-dev
942019-09-11T04:30:27 *** AaronvanW has quit IRC
952019-09-11T04:32:27 *** harding has quit IRC
962019-09-11T04:34:29 *** harding has joined #bitcoin-core-dev
972019-09-11T04:49:42 *** davec has quit IRC
982019-09-11T04:55:22 *** davec has joined #bitcoin-core-dev
992019-09-11T05:03:20 *** ppisati has quit IRC
1002019-09-11T05:03:21 *** davec has quit IRC
1012019-09-11T05:09:52 *** davec has joined #bitcoin-core-dev
1022019-09-11T05:09:59 *** ppisati has joined #bitcoin-core-dev
1032019-09-11T05:10:12 <achow101> luke-jr: I'm working on a custom decoder, and it's actually not as complicated as I thought it would be. It looks to be ~200 LOC
1042019-09-11T05:10:40 *** bitcoin-git has joined #bitcoin-core-dev
1052019-09-11T05:10:41 <bitcoin-git> [bitcoin] ajtowns opened pull request #16851: Continue relaying transactions after they expire from mapRelay (master...201909-relayparents) https://github.com/bitcoin/bitcoin/pull/16851
1062019-09-11T05:10:41 *** bitcoin-git has left #bitcoin-core-dev
1072019-09-11T05:12:54 <fanquake> Thanks achow101.
1082019-09-11T05:25:19 *** Guyver2 has joined #bitcoin-core-dev
1092019-09-11T05:26:01 *** bitcoin-git has joined #bitcoin-core-dev
1102019-09-11T05:26:02 <bitcoin-git> [bitcoin] fanquake closed pull request #16833: bitcoin-tx: fix comment about pay-to-witness script type ("addoutpubkey" command) (master...20190908-bitcoin-tx_fix_comment_p2wsh_to_p2wpkh) https://github.com/bitcoin/bitcoin/pull/16833
1112019-09-11T05:26:03 *** bitcoin-git has left #bitcoin-core-dev
1122019-09-11T05:37:17 *** AaronvanW has joined #bitcoin-core-dev
1132019-09-11T05:37:41 *** bitcoin-git has joined #bitcoin-core-dev
1142019-09-11T05:37:43 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1985c4efda56...2296fe65f598
1152019-09-11T05:37:43 <bitcoin-git> bitcoin/master 3c481f8 Anthony Towns: signrawtransactionwithkey: better error messages for bad redeemScript/witn...
1162019-09-11T05:37:44 <bitcoin-git> bitcoin/master ec4c793 Anthony Towns: signrawtransaction*: improve error for partial signing
1172019-09-11T05:37:44 <bitcoin-git> bitcoin/master 2296fe6 fanquake: Merge #16251: Improve signrawtransaction error reporting
1182019-09-11T05:37:46 *** bitcoin-git has left #bitcoin-core-dev
1192019-09-11T05:38:26 *** bitcoin-git has joined #bitcoin-core-dev
1202019-09-11T05:38:27 <bitcoin-git> [bitcoin] fanquake merged pull request #16251: rpc: Improve signrawtransaction error reporting (master...201906-signrawerror) https://github.com/bitcoin/bitcoin/pull/16251
1212019-09-11T05:38:28 *** bitcoin-git has left #bitcoin-core-dev
1222019-09-11T05:42:03 *** AaronvanW has quit IRC
1232019-09-11T05:42:32 *** harding has quit IRC
1242019-09-11T05:44:30 *** harding has joined #bitcoin-core-dev
1252019-09-11T05:46:14 *** Krellan has joined #bitcoin-core-dev
1262019-09-11T05:47:22 *** AaronvanW has joined #bitcoin-core-dev
1272019-09-11T06:00:01 *** DragonEyes1 has quit IRC
1282019-09-11T06:08:18 *** Guyver2 has quit IRC
1292019-09-11T06:14:12 <achow101> instead of having an actual decoder, what about doing just a string search? There's a sequence of a 5 bytes that precede the merchant name that we could just search for in the payment request string itself
1302019-09-11T06:18:32 *** qubenix has quit IRC
1312019-09-11T06:18:42 *** shtirlic has quit IRC
1322019-09-11T06:18:45 *** qubenix has joined #bitcoin-core-dev
1332019-09-11T06:22:00 *** shtirlic has joined #bitcoin-core-dev
1342019-09-11T06:25:00 *** yarwn has joined #bitcoin-core-dev
1352019-09-11T06:29:13 *** yarwn has quit IRC
1362019-09-11T06:33:12 *** yarwn has joined #bitcoin-core-dev
1372019-09-11T06:36:27 *** bitcoin-git has joined #bitcoin-core-dev
1382019-09-11T06:36:28 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2296fe65f598...2324aa1dc409
1392019-09-11T06:36:28 <bitcoin-git> bitcoin/master 1619684 Aaron Clauson: Added libbitcoin_qt and bitcoin-qt to the msbuild configuration.
1402019-09-11T06:36:29 <bitcoin-git> bitcoin/master 2324aa1 fanquake: Merge #15529: Add Qt programs to msvc build (updated, no code changes)
1412019-09-11T06:36:30 *** bitcoin-git has left #bitcoin-core-dev
1422019-09-11T06:37:02 *** bitcoin-git has joined #bitcoin-core-dev
1432019-09-11T06:37:03 <bitcoin-git> [bitcoin] fanquake merged pull request #15529: Add Qt programs to msvc build (updated, no code changes) (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529
1442019-09-11T06:37:04 *** bitcoin-git has left #bitcoin-core-dev
1452019-09-11T06:38:52 *** ccdle12 has joined #bitcoin-core-dev
1462019-09-11T06:48:14 *** Salt1 has joined #bitcoin-core-dev
1472019-09-11T06:49:28 *** Krellan has quit IRC
1482019-09-11T07:05:03 *** Krellan has joined #bitcoin-core-dev
1492019-09-11T07:09:07 *** AaronvanW has quit IRC
1502019-09-11T07:13:19 *** Krellan has quit IRC
1512019-09-11T07:15:18 *** spinza has quit IRC
1522019-09-11T07:17:05 *** spinza has joined #bitcoin-core-dev
1532019-09-11T07:21:16 <wumpus> achow101: that would be the simplest solution, but it doesn't sound too robust in itself, I guess if you add robustness (handling the possible case that that sequence happens somewhere else, and you get crap data) it might not be that much shorter than a simple "skip ahead" decoder
1542019-09-11T07:21:57 *** ddustin has joined #bitcoin-core-dev
1552019-09-11T07:23:31 <sipa> fwiw, just iterating through protobuf fields is pretty easy
1562019-09-11T07:23:47 <sipa> so writing an adhoc decoder should not be hard
1572019-09-11T07:24:08 <achow101> dealing with the protobuf was fairly straightforward. dealing with the DER encoded X.509 certs was less so
1582019-09-11T07:25:43 <sipa> hahaha
1592019-09-11T07:25:47 <sipa> yes.
1602019-09-11T07:26:26 <achow101> the only issues I see with a string search are the string showing up in any of the signatures. the way that the certificates are done requires that the string we want comes in a certain order, otherwise even the current thing wouldn't work
1612019-09-11T07:26:58 <achow101> but it's 6 bytes, so the probability of that is pretty low, and it has to be followed by valid ascii or utf8 (although I guess anything is valid utf8)
1622019-09-11T07:27:08 *** ddustin has quit IRC
1632019-09-11T07:28:49 <achow101> s/valid ascii/subset of ascii defined by ASN.1 as Printable Characters
1642019-09-11T07:30:20 <wumpus> not everything is valid utf8, e.g. it's illegal to represent invalid code points (too high, or the surrogate pairs areas), strings that end in the middle of a code point
1652019-09-11T07:31:10 <wumpus> but sure, I suppose Qt has ways of checking for that, maybe a hack is good enough
1662019-09-11T07:32:05 <wumpus> (also check length; the worst thing that can happen is trying to render a >10000 character string)
1672019-09-11T07:33:29 <achow101> yes, the length is checked against the upper bound of 64
1682019-09-11T07:37:18 <wumpus> seems enough
1692019-09-11T07:40:26 *** fixcrypt has joined #bitcoin-core-dev
1702019-09-11T07:42:06 *** bitcoin-git has joined #bitcoin-core-dev
1712019-09-11T07:42:07 <bitcoin-git> [bitcoin] achow101 opened pull request #16852: gui: When BIP70 is disabled, get PaymentRequest merchant using string search (master...bip70-merchant-decode) https://github.com/bitcoin/bitcoin/pull/16852
1722019-09-11T07:42:08 *** bitcoin-git has left #bitcoin-core-dev
1732019-09-11T07:46:12 *** Krellan has joined #bitcoin-core-dev
1742019-09-11T07:46:55 *** fixcrypt has quit IRC
1752019-09-11T07:47:39 *** AaronvanW has joined #bitcoin-core-dev
1762019-09-11T07:48:15 *** Aaronvan_ has joined #bitcoin-core-dev
1772019-09-11T07:52:08 *** AaronvanW has quit IRC
1782019-09-11T07:53:08 *** ddustin has joined #bitcoin-core-dev
1792019-09-11T08:08:23 *** Krellan has quit IRC
1802019-09-11T08:11:33 *** spinza has quit IRC
1812019-09-11T08:13:22 *** Aaronvan_ has quit IRC
1822019-09-11T08:16:29 *** promag has joined #bitcoin-core-dev
1832019-09-11T08:19:10 *** promag has quit IRC
1842019-09-11T08:19:25 *** promag has joined #bitcoin-core-dev
1852019-09-11T08:31:17 *** spinza has joined #bitcoin-core-dev
1862019-09-11T08:43:43 *** AaronvanW has joined #bitcoin-core-dev
1872019-09-11T08:47:23 *** jonatack has joined #bitcoin-core-dev
1882019-09-11T08:51:26 *** Krellan has joined #bitcoin-core-dev
1892019-09-11T08:55:00 *** promag has quit IRC
1902019-09-11T08:56:53 *** promag has joined #bitcoin-core-dev
1912019-09-11T09:00:00 *** Krellan has quit IRC
1922019-09-11T09:00:02 *** Salt1 has quit IRC
1932019-09-11T09:06:56 *** promag has quit IRC
1942019-09-11T09:07:07 *** promag has joined #bitcoin-core-dev
1952019-09-11T09:09:41 *** promag has quit IRC
1962019-09-11T09:09:43 *** promag_ has joined #bitcoin-core-dev
1972019-09-11T09:10:18 *** jdm has joined #bitcoin-core-dev
1982019-09-11T09:11:20 *** promag_ has quit IRC
1992019-09-11T09:15:43 *** AaronvanW has quit IRC
2002019-09-11T09:18:02 *** promag has joined #bitcoin-core-dev
2012019-09-11T09:24:28 *** ccdle12 has quit IRC
2022019-09-11T09:26:54 *** Giszmo has quit IRC
2032019-09-11T09:27:58 *** Giszmo has joined #bitcoin-core-dev
2042019-09-11T09:31:26 *** AaronvanW has joined #bitcoin-core-dev
2052019-09-11T09:36:45 *** AaronvanW has quit IRC
2062019-09-11T09:47:51 *** Robert3 has joined #bitcoin-core-dev
2072019-09-11T09:50:52 *** bitcoin-git has joined #bitcoin-core-dev
2082019-09-11T09:50:52 <bitcoin-git> [bitcoin] ZENNITTITTHZENTERPRISE opened pull request #16853: Rename CONTRIBUTING.md to ZENNITTITTHZ/CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16853
2092019-09-11T09:50:53 *** bitcoin-git has left #bitcoin-core-dev
2102019-09-11T09:52:16 *** tsujp has quit IRC
2112019-09-11T09:55:25 *** bitcoin-git has joined #bitcoin-core-dev
2122019-09-11T09:55:25 <bitcoin-git> [bitcoin] ZENNITTITTHZENTERPRISE closed pull request #16853: Rename CONTRIBUTING.md to ZENNITTITTHZ/CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16853
2132019-09-11T09:55:26 *** bitcoin-git has left #bitcoin-core-dev
2142019-09-11T09:59:01 *** jonatack has quit IRC
2152019-09-11T10:16:11 *** tsujp has joined #bitcoin-core-dev
2162019-09-11T10:22:27 *** promag has quit IRC
2172019-09-11T10:29:32 *** tsujp has quit IRC
2182019-09-11T10:29:55 *** promag has joined #bitcoin-core-dev
2192019-09-11T10:35:49 *** tsujp has joined #bitcoin-core-dev
2202019-09-11T10:49:26 *** reallll has joined #bitcoin-core-dev
2212019-09-11T10:52:27 *** belcher has quit IRC
2222019-09-11T10:56:25 *** Krellan has joined #bitcoin-core-dev
2232019-09-11T10:57:32 *** jonatack has joined #bitcoin-core-dev
2242019-09-11T11:03:47 *** tsujp has quit IRC
2252019-09-11T11:04:23 *** elichai2 has joined #bitcoin-core-dev
2262019-09-11T11:06:00 *** AaronvanW has joined #bitcoin-core-dev
2272019-09-11T11:07:39 *** Krellan has quit IRC
2282019-09-11T11:13:58 *** promag has quit IRC
2292019-09-11T11:17:13 *** AaronvanW has quit IRC
2302019-09-11T11:17:50 *** tsujp has joined #bitcoin-core-dev
2312019-09-11T11:28:22 *** promag has joined #bitcoin-core-dev
2322019-09-11T11:29:28 *** AaronvanW has joined #bitcoin-core-dev
2332019-09-11T11:37:52 *** tsujp has quit IRC
2342019-09-11T11:38:53 *** spinza has quit IRC
2352019-09-11T11:42:03 *** AaronvanW has quit IRC
2362019-09-11T11:42:04 *** spinza has joined #bitcoin-core-dev
2372019-09-11T11:54:06 *** promag has quit IRC
2382019-09-11T12:00:01 *** Robert3 has quit IRC
2392019-09-11T12:04:50 *** AaronvanW has joined #bitcoin-core-dev
2402019-09-11T12:09:15 *** AaronvanW has quit IRC
2412019-09-11T12:17:37 *** Velociraptor1 has joined #bitcoin-core-dev
2422019-09-11T12:22:38 *** tsujp has joined #bitcoin-core-dev
2432019-09-11T12:47:40 *** AaronvanW has joined #bitcoin-core-dev
2442019-09-11T12:49:54 *** AaronvanW has quit IRC
2452019-09-11T12:52:34 *** rafalcpp has joined #bitcoin-core-dev
2462019-09-11T13:03:23 *** Krellan has joined #bitcoin-core-dev
2472019-09-11T13:06:45 *** lightlike has joined #bitcoin-core-dev
2482019-09-11T13:13:16 *** Krellan has quit IRC
2492019-09-11T13:14:48 *** xzytrewq has quit IRC
2502019-09-11T13:16:19 *** ccdle12 has joined #bitcoin-core-dev
2512019-09-11T13:21:04 *** emilengler_ is now known as emilengler
2522019-09-11T13:22:22 *** AaronvanW has joined #bitcoin-core-dev
2532019-09-11T13:22:51 *** spinza has quit IRC
2542019-09-11T13:24:25 *** AaronvanW has quit IRC
2552019-09-11T13:24:42 *** AaronvanW has joined #bitcoin-core-dev
2562019-09-11T13:28:28 *** AaronvanW has quit IRC
2572019-09-11T13:32:15 *** davec has quit IRC
2582019-09-11T13:35:45 *** Giszmo has quit IRC
2592019-09-11T13:36:38 *** Giszmo has joined #bitcoin-core-dev
2602019-09-11T13:39:07 *** jtimon has joined #bitcoin-core-dev
2612019-09-11T13:40:32 *** spinza has joined #bitcoin-core-dev
2622019-09-11T13:41:05 <jtimon> I wonder if it would make sense to talk about https://github.com/bitcoin/bitcoin/pull/16630#issuecomment-530384445 in one of the meetings. it seems there's different views around that
2632019-09-11T14:02:11 *** cubancorona has joined #bitcoin-core-dev
2642019-09-11T14:15:03 *** csknk has joined #bitcoin-core-dev
2652019-09-11T14:18:17 *** Krellan has joined #bitcoin-core-dev
2662019-09-11T14:22:14 *** justanotheruser has quit IRC
2672019-09-11T14:22:18 *** promag has joined #bitcoin-core-dev
2682019-09-11T14:23:52 *** promag_ has joined #bitcoin-core-dev
2692019-09-11T14:24:40 *** Krellan has quit IRC
2702019-09-11T14:26:27 *** promag has quit IRC
2712019-09-11T14:29:43 *** bitcoin-git has joined #bitcoin-core-dev
2722019-09-11T14:29:43 <bitcoin-git> [bitcoin] stevenroose opened pull request #16854: Prevent UpdateTip log message from being broken up (master...log-break-updatetip) https://github.com/bitcoin/bitcoin/pull/16854
2732019-09-11T14:29:44 *** bitcoin-git has left #bitcoin-core-dev
2742019-09-11T14:30:03 *** dgenr8 has quit IRC
2752019-09-11T14:32:13 *** Krellan has joined #bitcoin-core-dev
2762019-09-11T14:32:33 *** rwang_ has joined #bitcoin-core-dev
2772019-09-11T14:41:39 *** davec has joined #bitcoin-core-dev
2782019-09-11T14:42:35 *** dgenr8 has joined #bitcoin-core-dev
2792019-09-11T14:59:35 *** mdunnio has joined #bitcoin-core-dev
2802019-09-11T15:00:01 *** Velociraptor1 has quit IRC
2812019-09-11T15:06:43 *** captjakk has quit IRC
2822019-09-11T15:07:18 *** captjakk has joined #bitcoin-core-dev
2832019-09-11T15:11:39 *** captjakk has quit IRC
2842019-09-11T15:17:35 *** JohninLex has joined #bitcoin-core-dev
2852019-09-11T15:35:17 *** Krellan has quit IRC
2862019-09-11T15:37:24 *** davterra has joined #bitcoin-core-dev
2872019-09-11T15:39:01 *** mdunnio has quit IRC
2882019-09-11T15:39:56 *** mdunnio has joined #bitcoin-core-dev
2892019-09-11T16:08:20 *** promag has joined #bitcoin-core-dev
2902019-09-11T16:11:20 *** AaronvanW has joined #bitcoin-core-dev
2912019-09-11T16:12:43 *** promag has quit IRC
2922019-09-11T16:17:46 *** Guyver2 has joined #bitcoin-core-dev
2932019-09-11T16:24:20 *** xzytrewq has joined #bitcoin-core-dev
2942019-09-11T16:26:31 *** ccdle12 has quit IRC
2952019-09-11T16:36:14 *** mdunnio has quit IRC
2962019-09-11T16:39:37 *** owowo has quit IRC
2972019-09-11T16:45:00 *** hexyul has joined #bitcoin-core-dev
2982019-09-11T16:46:44 *** owowo has joined #bitcoin-core-dev
2992019-09-11T16:50:29 *** b10c has joined #bitcoin-core-dev
3002019-09-11T17:06:18 *** ccdle12 has joined #bitcoin-core-dev
3012019-09-11T17:10:51 *** ccdle12 has quit IRC
3022019-09-11T17:12:14 *** ccdle12 has joined #bitcoin-core-dev
3032019-09-11T17:12:35 *** nehan has joined #bitcoin-core-dev
3042019-09-11T17:14:02 *** elichai2 has quit IRC
3052019-09-11T17:22:23 *** davec has quit IRC
3062019-09-11T17:22:58 *** sonny59 has joined #bitcoin-core-dev
3072019-09-11T17:26:13 *** shesek has quit IRC
3082019-09-11T17:28:16 *** davex__ has quit IRC
3092019-09-11T17:28:19 *** davex_ has quit IRC
3102019-09-11T17:28:26 *** shesek has joined #bitcoin-core-dev
3112019-09-11T17:28:26 *** shesek has joined #bitcoin-core-dev
3122019-09-11T17:29:07 *** davex__ has joined #bitcoin-core-dev
3132019-09-11T17:30:58 *** davec has joined #bitcoin-core-dev
3142019-09-11T17:32:30 *** Krellan has joined #bitcoin-core-dev
3152019-09-11T17:32:51 *** shesek has quit IRC
3162019-09-11T17:37:45 *** mdunnio has joined #bitcoin-core-dev
3172019-09-11T17:42:38 *** Ox207fffff has quit IRC
3182019-09-11T17:44:03 *** davec has quit IRC
3192019-09-11T17:44:30 *** Ox207fffff has joined #bitcoin-core-dev
3202019-09-11T17:50:22 *** ZigZagg has joined #bitcoin-core-dev
3212019-09-11T17:52:05 *** davec has joined #bitcoin-core-dev
3222019-09-11T18:00:01 *** JohninLex has quit IRC
3232019-09-11T18:05:39 *** Krellan has quit IRC
3242019-09-11T18:17:36 *** FrontSevens has joined #bitcoin-core-dev
3252019-09-11T18:24:58 *** mdunnio has quit IRC
3262019-09-11T18:25:40 *** mdunnio has joined #bitcoin-core-dev
3272019-09-11T18:35:15 *** niska has quit IRC
3282019-09-11T18:35:31 *** rafalcpp_ has joined #bitcoin-core-dev
3292019-09-11T18:35:52 *** rafalcpp has quit IRC
3302019-09-11T18:41:08 *** csknk has quit IRC
3312019-09-11T18:43:42 *** niska has joined #bitcoin-core-dev
3322019-09-11T18:46:05 *** b10c has quit IRC
3332019-09-11T18:48:13 <BlueMatt> luke-jr: right, but the five people who've ever used bip 70 can build once with it on :p
3342019-09-11T18:57:26 *** mdunnio has quit IRC
3352019-09-11T18:57:47 *** sonny59 has quit IRC
3362019-09-11T18:59:11 *** mdunnio has joined #bitcoin-core-dev
3372019-09-11T19:04:43 <instagibbs> "there are dozens of us!"
3382019-09-11T19:22:28 *** captjakk has joined #bitcoin-core-dev
3392019-09-11T19:27:44 *** captjakk has quit IRC
3402019-09-11T19:28:07 *** captjakk has joined #bitcoin-core-dev
3412019-09-11T19:29:10 *** promag has joined #bitcoin-core-dev
3422019-09-11T19:33:22 *** promag has quit IRC
3432019-09-11T19:33:31 *** tdebres has joined #bitcoin-core-dev
3442019-09-11T19:35:53 *** tdebres has quit IRC
3452019-09-11T19:37:16 *** captjakk has quit IRC
3462019-09-11T19:37:35 *** captjakk has joined #bitcoin-core-dev
3472019-09-11T19:38:13 *** yarwn_ has joined #bitcoin-core-dev
3482019-09-11T19:39:02 *** davex__ has quit IRC
3492019-09-11T19:39:02 *** captjakk has quit IRC
3502019-09-11T19:39:04 *** davex_ has joined #bitcoin-core-dev
3512019-09-11T19:39:15 *** captjakk has joined #bitcoin-core-dev
3522019-09-11T19:40:28 *** yarwn has quit IRC
3532019-09-11T19:44:31 *** captjakk has quit IRC
3542019-09-11T19:45:13 *** captjakk has joined #bitcoin-core-dev
3552019-09-11T19:46:10 *** wunpunch has joined #bitcoin-core-dev
3562019-09-11T19:47:37 *** AaronvanW has quit IRC
3572019-09-11T19:48:18 *** captjakk has quit IRC
3582019-09-11T19:49:05 *** captjakk has joined #bitcoin-core-dev
3592019-09-11T19:50:47 *** promag_ has quit IRC
3602019-09-11T19:58:14 *** promag has joined #bitcoin-core-dev
3612019-09-11T19:58:32 *** captjakk has quit IRC
3622019-09-11T20:02:42 *** Krellan has joined #bitcoin-core-dev
3632019-09-11T20:03:05 *** promag has quit IRC
3642019-09-11T20:10:49 *** fox2p has joined #bitcoin-core-dev
3652019-09-11T20:11:45 *** fox2p_ has quit IRC
3662019-09-11T20:18:55 *** promag has joined #bitcoin-core-dev
3672019-09-11T20:19:47 <phantomcircuit> BlueMatt, unfortunately it's not a zero number cause of bitpay
3682019-09-11T20:20:07 <BlueMatt> phantomcircuit: 0 number once you consider that once that certs expire the data is hidden :p
3692019-09-11T20:21:35 <phantomcircuit> wait it is??
3702019-09-11T20:21:56 <phantomcircuit> did any version save the payment request for invalid requests?
3712019-09-11T20:22:02 <phantomcircuit> i cant imagine there's a reason to do that
3722019-09-11T20:23:02 *** promag_ has joined #bitcoin-core-dev
3732019-09-11T20:23:23 *** promag has quit IRC
3742019-09-11T20:27:07 *** promag_ has quit IRC
3752019-09-11T20:27:42 *** elichai2 has joined #bitcoin-core-dev
3762019-09-11T20:27:47 *** davec has quit IRC
3772019-09-11T20:36:53 *** Krellan has quit IRC
3782019-09-11T20:39:39 *** davterra has quit IRC
3792019-09-11T20:40:07 *** davterra has joined #bitcoin-core-dev
3802019-09-11T20:52:58 *** promag has joined #bitcoin-core-dev
3812019-09-11T20:57:15 *** promag has quit IRC
3822019-09-11T21:00:03 *** FrontSevens has quit IRC
3832019-09-11T21:02:51 *** Highway62 has joined #bitcoin-core-dev
3842019-09-11T21:04:02 <luke-jr> phantomcircuit: expire in the future ,after the payments
3852019-09-11T21:04:06 *** Highway61 has quit IRC
3862019-09-11T21:04:06 *** Highway62 is now known as Highway61
3872019-09-11T21:07:21 *** promag has joined #bitcoin-core-dev
3882019-09-11T21:10:23 *** promag_ has joined #bitcoin-core-dev
3892019-09-11T21:11:48 *** promag has quit IRC
3902019-09-11T21:14:37 *** promag_ has quit IRC
3912019-09-11T21:14:48 *** davec has joined #bitcoin-core-dev
3922019-09-11T21:15:34 *** ddustin has quit IRC
3932019-09-11T21:15:55 *** ddustin has joined #bitcoin-core-dev
3942019-09-11T21:15:59 *** bitcoin-git has joined #bitcoin-core-dev
3952019-09-11T21:15:59 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16856: Do not allow descendants of BLOCK_FAILED_VALID blocks to be BLOCK_FAILED_VALID (master...2019-09-invalidate-block-child-invalid) https://github.com/bitcoin/bitcoin/pull/16856
3962019-09-11T21:16:00 *** bitcoin-git has left #bitcoin-core-dev
3972019-09-11T21:16:20 *** ddustin has quit IRC
3982019-09-11T21:16:37 *** ddustin has joined #bitcoin-core-dev
3992019-09-11T21:17:26 *** ddustin has joined #bitcoin-core-dev
4002019-09-11T21:18:09 *** ddustin has joined #bitcoin-core-dev
4012019-09-11T21:18:59 *** ddustin has joined #bitcoin-core-dev
4022019-09-11T21:19:20 *** AaronvanW has joined #bitcoin-core-dev
4032019-09-11T21:19:25 *** ddustin has quit IRC
4042019-09-11T21:19:47 *** ddustin has joined #bitcoin-core-dev
4052019-09-11T21:20:11 *** ddustin has quit IRC
4062019-09-11T21:20:29 *** ddustin has joined #bitcoin-core-dev
4072019-09-11T21:21:19 *** ddustin has joined #bitcoin-core-dev
4082019-09-11T21:21:34 *** mdunnio has quit IRC
4092019-09-11T21:21:46 *** ddustin has quit IRC
4102019-09-11T21:22:05 *** ddustin has joined #bitcoin-core-dev
4112019-09-11T21:22:32 *** ddustin has quit IRC
4122019-09-11T21:22:51 *** ddustin has joined #bitcoin-core-dev
4132019-09-11T21:23:32 *** mdunnio has joined #bitcoin-core-dev
4142019-09-11T21:23:39 *** AaronvanW has quit IRC
4152019-09-11T21:23:39 *** ddustin has joined #bitcoin-core-dev
4162019-09-11T21:24:25 *** ddustin has joined #bitcoin-core-dev
4172019-09-11T21:25:10 *** ddustin has joined #bitcoin-core-dev
4182019-09-11T21:25:56 *** ddustin has joined #bitcoin-core-dev
4192019-09-11T21:26:23 *** ddustin has quit IRC
4202019-09-11T21:26:54 *** ddustin has joined #bitcoin-core-dev
4212019-09-11T21:27:29 *** ddustin has joined #bitcoin-core-dev
4222019-09-11T21:28:17 *** ddustin has joined #bitcoin-core-dev
4232019-09-11T21:28:45 *** Guyver2 has quit IRC
4242019-09-11T21:29:00 *** ddustin has joined #bitcoin-core-dev
4252019-09-11T21:30:35 *** ddustin has joined #bitcoin-core-dev
4262019-09-11T21:32:05 *** ddustin has joined #bitcoin-core-dev
4272019-09-11T21:32:33 *** ddustin has quit IRC
4282019-09-11T21:37:53 *** promag has joined #bitcoin-core-dev
4292019-09-11T21:39:39 *** esotericnonsense has joined #bitcoin-core-dev
4302019-09-11T21:40:13 *** AaronvanW has joined #bitcoin-core-dev
4312019-09-11T21:42:03 *** promag has quit IRC
4322019-09-11T21:45:12 *** ccdle12 has quit IRC
4332019-09-11T21:47:52 *** jungnam has joined #bitcoin-core-dev
4342019-09-11T21:52:56 *** Giszmo has quit IRC
4352019-09-11T21:53:42 *** Giszmo has joined #bitcoin-core-dev
4362019-09-11T22:04:20 *** AaronvanW has quit IRC
4372019-09-11T22:05:32 *** captjakk has joined #bitcoin-core-dev
4382019-09-11T22:10:35 <phantomcircuit> luke-jr, yeah i understand, but why validate them at all if they,re saved in the wallet
4392019-09-11T22:10:39 <phantomcircuit> they're
4402019-09-11T22:15:02 *** promag has joined #bitcoin-core-dev
4412019-09-11T22:19:21 *** promag has quit IRC
4422019-09-11T22:22:34 *** justanotheruser has joined #bitcoin-core-dev
4432019-09-11T22:23:23 *** mdunnio has quit IRC
4442019-09-11T22:25:55 *** BlockX56 has joined #bitcoin-core-dev
4452019-09-11T22:30:25 *** stevenroose has quit IRC
4462019-09-11T22:32:17 *** stevenroose has joined #bitcoin-core-dev
4472019-09-11T22:33:52 *** Krellan has joined #bitcoin-core-dev
4482019-09-11T22:36:50 *** BlockX has joined #bitcoin-core-dev
4492019-09-11T22:45:35 *** stevenroose has quit IRC
4502019-09-11T22:47:33 *** stevenroose has joined #bitcoin-core-dev
4512019-09-11T22:52:54 *** michagogo_ has quit IRC
4522019-09-11T22:52:55 *** michagogo_ has joined #bitcoin-core-dev
4532019-09-11T22:53:05 *** michagogo_ is now known as michagogo
4542019-09-11T22:55:35 *** meshcollider has quit IRC
4552019-09-11T22:56:10 *** da2ce7 has quit IRC
4562019-09-11T22:57:15 *** xzytrewq has quit IRC
4572019-09-11T22:58:32 *** da2ce7 has joined #bitcoin-core-dev
4582019-09-11T23:00:15 *** meshcollider has joined #bitcoin-core-dev
4592019-09-11T23:01:39 *** ZigZagg has quit IRC
4602019-09-11T23:08:13 *** Krellan has quit IRC
4612019-09-11T23:09:01 <achow101> phantomcircuit: because it's dumb. It's the same code used for validating the request when it is received
4622019-09-11T23:09:03 *** stevenroose has quit IRC
4632019-09-11T23:11:39 *** stevenroose has joined #bitcoin-core-dev
4642019-09-11T23:16:08 *** captjakk has quit IRC
4652019-09-11T23:16:42 *** owowo has quit IRC
4662019-09-11T23:17:20 *** captjakk has joined #bitcoin-core-dev
4672019-09-11T23:18:04 *** elichai2 has quit IRC
4682019-09-11T23:19:15 *** captjakk has quit IRC
4692019-09-11T23:35:22 *** lightlike has quit IRC