12019-10-04T00:00:02 *** WhereIsMySpoon has quit IRC
22019-10-04T00:02:42 *** promag has joined #bitcoin-core-dev
32019-10-04T00:06:57 *** promag has quit IRC
42019-10-04T00:11:28 *** lightlike has quit IRC
52019-10-04T00:25:48 *** promag has joined #bitcoin-core-dev
62019-10-04T00:27:39 *** AaronvanW has quit IRC
72019-10-04T00:30:35 *** promag has quit IRC
82019-10-04T00:44:44 *** wm4 has joined #bitcoin-core-dev
92019-10-04T00:45:39 *** arik_ has quit IRC
102019-10-04T00:58:17 *** jkczyz has quit IRC
112019-10-04T01:11:42 *** spinza has quit IRC
122019-10-04T01:13:20 *** spinza has joined #bitcoin-core-dev
132019-10-04T01:15:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
142019-10-04T01:20:38 *** Ox207fffff has quit IRC
152019-10-04T01:29:03 *** justinmoon has quit IRC
162019-10-04T01:30:02 *** wm4 has quit IRC
172019-10-04T01:30:19 *** justinmoon has joined #bitcoin-core-dev
182019-10-04T01:30:27 *** davec has quit IRC
192019-10-04T01:30:27 *** phantomcircuit has quit IRC
202019-10-04T01:31:17 *** roasbeef has quit IRC
212019-10-04T01:31:28 *** davec has joined #bitcoin-core-dev
222019-10-04T01:31:56 *** roasbeef has joined #bitcoin-core-dev
232019-10-04T01:32:11 *** phantomcircuit has joined #bitcoin-core-dev
242019-10-04T01:41:33 *** Usurp1 has joined #bitcoin-core-dev
252019-10-04T02:05:41 *** emilengler_ has joined #bitcoin-core-dev
262019-10-04T02:09:08 *** emilengler_ has quit IRC
272019-10-04T02:09:15 *** emilengler has quit IRC
282019-10-04T02:10:05 *** emilengler has joined #bitcoin-core-dev
292019-10-04T02:20:36 *** rhavar_ has quit IRC
302019-10-04T02:25:01 *** AaronvanW has joined #bitcoin-core-dev
312019-10-04T02:29:32 *** Chris_Stewart_5 has quit IRC
322019-10-04T02:35:38 *** cryptoIndio has joined #bitcoin-core-dev
332019-10-04T02:40:03 *** cryptoIndio has quit IRC
342019-10-04T02:47:14 *** fox2p_ has joined #bitcoin-core-dev
352019-10-04T02:50:02 *** fox2p has quit IRC
362019-10-04T02:57:15 *** AaronvanW has quit IRC
372019-10-04T02:58:17 *** Highway61 has quit IRC
382019-10-04T03:00:02 *** Usurp1 has quit IRC
392019-10-04T03:05:52 *** promag has joined #bitcoin-core-dev
402019-10-04T03:09:57 *** promag has quit IRC
412019-10-04T03:17:51 *** Jarsto1 has joined #bitcoin-core-dev
422019-10-04T03:19:01 *** promag has joined #bitcoin-core-dev
432019-10-04T03:20:23 *** cryptoIndio has joined #bitcoin-core-dev
442019-10-04T03:23:05 *** cryptoIndio has joined #bitcoin-core-dev
452019-10-04T03:23:29 *** promag has quit IRC
462019-10-04T03:26:32 *** m1rror8955363 has joined #bitcoin-core-dev
472019-10-04T03:27:23 *** m1rror895536 has quit IRC
482019-10-04T03:38:16 *** Eagle[TM] has joined #bitcoin-core-dev
492019-10-04T03:40:17 *** EagleTM has quit IRC
502019-10-04T03:42:13 *** cryptoIndio has quit IRC
512019-10-04T03:42:49 *** cryptoIndio has joined #bitcoin-core-dev
522019-10-04T03:42:50 *** alko has joined #bitcoin-core-dev
532019-10-04T03:45:37 *** alko89 has quit IRC
542019-10-04T03:47:39 *** cryptoIndio has quit IRC
552019-10-04T04:01:11 *** nejon has quit IRC
562019-10-04T04:20:03 *** promag has joined #bitcoin-core-dev
572019-10-04T04:24:17 *** promag has quit IRC
582019-10-04T04:29:49 *** cryptoIndio has joined #bitcoin-core-dev
592019-10-04T04:31:44 *** Victor_sueca has joined #bitcoin-core-dev
602019-10-04T04:34:46 *** Victorsueca has quit IRC
612019-10-04T04:37:49 *** funtimer has joined #bitcoin-core-dev
622019-10-04T04:42:08 *** funtimer has quit IRC
632019-10-04T04:55:21 *** AaronvanW has joined #bitcoin-core-dev
642019-10-04T05:16:48 *** m1rror89553638 has joined #bitcoin-core-dev
652019-10-04T05:16:51 *** ajonas has quit IRC
662019-10-04T05:18:27 *** m1rror8955363 has quit IRC
672019-10-04T05:19:19 *** jkczyz has joined #bitcoin-core-dev
682019-10-04T05:21:54 *** m1rror89553638 has quit IRC
692019-10-04T05:22:56 *** m1rror89553638 has joined #bitcoin-core-dev
702019-10-04T05:25:50 *** tryphe has quit IRC
712019-10-04T05:26:14 *** tryphe has joined #bitcoin-core-dev
722019-10-04T05:28:27 *** AaronvanW has quit IRC
732019-10-04T05:30:17 *** m1rror895536388 has joined #bitcoin-core-dev
742019-10-04T05:32:03 *** m1rror89553638 has quit IRC
752019-10-04T05:34:37 *** shesek has quit IRC
762019-10-04T05:35:01 *** shesek has joined #bitcoin-core-dev
772019-10-04T05:39:22 *** m1rror8955363887 has joined #bitcoin-core-dev
782019-10-04T05:41:10 *** m1rror895536388 has quit IRC
792019-10-04T05:41:11 <wumpus> I don't think there's a reason to bump libevent, wide compatibility is good, we don't bump minimum dependency versions just for fun
802019-10-04T05:46:15 <wumpus> fixing a bug like #15363 would be a valid reason, it's just that libevent's release schedule was a mess for a long time, there were lots of betas but never a new stable, so everyone tended up with the same old version ... don't know in how far that's still the case
812019-10-04T05:46:17 <gribble> https://github.com/bitcoin/bitcoin/issues/15363 | wip: http: Exit the event loop as soon as there are no active events by promag · Pull Request #15363 · bitcoin/bitcoin · GitHub
822019-10-04T05:51:02 *** AaronvanW has joined #bitcoin-core-dev
832019-10-04T05:51:04 *** bitcoin-git has joined #bitcoin-core-dev
842019-10-04T05:51:04 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/9fdaaecf4928...6db76c6bc7fe
852019-10-04T05:51:05 <bitcoin-git> bitcoin/0.19 6db76c6 Wladimir J. van der Laan: qt: Periodic translations update
862019-10-04T05:51:07 *** bitcoin-git has left #bitcoin-core-dev
872019-10-04T05:51:39 *** promag has joined #bitcoin-core-dev
882019-10-04T05:55:28 *** jkczyz has quit IRC
892019-10-04T05:55:44 *** AaronvanW has quit IRC
902019-10-04T05:56:02 *** promag has quit IRC
912019-10-04T05:59:12 *** Highway61 has joined #bitcoin-core-dev
922019-10-04T06:00:01 *** Jarsto1 has quit IRC
932019-10-04T06:11:05 *** bitcoin-git has joined #bitcoin-core-dev
942019-10-04T06:11:05 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/6db76c6bc7fe...cd1e7bb06431
952019-10-04T06:11:05 <bitcoin-git> bitcoin/0.19 cd1e7bb Wladimir J. van der Laan: build: Fix boost detection on Ubuntu ARM 18.04
962019-10-04T06:11:07 *** bitcoin-git has left #bitcoin-core-dev
972019-10-04T06:11:42 *** Klox has quit IRC
982019-10-04T06:18:37 *** IGHOR has quit IRC
992019-10-04T06:22:37 *** jkczyz has joined #bitcoin-core-dev
1002019-10-04T06:26:57 *** jkczyz has quit IRC
1012019-10-04T06:28:18 *** face has joined #bitcoin-core-dev
1022019-10-04T06:32:32 *** IGHOR has joined #bitcoin-core-dev
1032019-10-04T06:38:52 <wumpus> ok, going to tag 0.19.0rc1 in a bit
1042019-10-04T06:47:01 *** jackalope has joined #bitcoin-core-dev
1052019-10-04T07:02:37 *** IGHOR has quit IRC
1062019-10-04T07:02:51 *** rafalcpp has joined #bitcoin-core-dev
1072019-10-04T07:03:24 *** rafalcpp_ has quit IRC
1082019-10-04T07:05:36 *** IGHOR has joined #bitcoin-core-dev
1092019-10-04T07:12:31 *** marcoagner has joined #bitcoin-core-dev
1102019-10-04T07:14:28 *** jonatack has quit IRC
1112019-10-04T07:16:27 *** BlueMatt has quit IRC
1122019-10-04T07:16:40 *** BlueMatt has joined #bitcoin-core-dev
1132019-10-04T07:20:42 *** CubicEarth has quit IRC
1142019-10-04T07:30:08 *** belcher has joined #bitcoin-core-dev
1152019-10-04T07:31:29 *** rex4539 has joined #bitcoin-core-dev
1162019-10-04T07:38:29 *** AaronvanW has joined #bitcoin-core-dev
1172019-10-04T07:41:40 *** CubicEarth has joined #bitcoin-core-dev
1182019-10-04T07:41:48 *** CubicEarth has quit IRC
1192019-10-04T07:42:27 *** CubicEarth has joined #bitcoin-core-dev
1202019-10-04T07:42:37 *** Eagle[TM] has quit IRC
1212019-10-04T07:56:28 *** rafalcpp has quit IRC
1222019-10-04T07:56:39 *** rafalcpp has joined #bitcoin-core-dev
1232019-10-04T08:06:28 *** jonatack has joined #bitcoin-core-dev
1242019-10-04T08:14:27 *** jonatack has quit IRC
1252019-10-04T08:16:40 *** jonatack has joined #bitcoin-core-dev
1262019-10-04T08:23:29 *** jkczyz has joined #bitcoin-core-dev
1272019-10-04T08:28:29 *** jkczyz has quit IRC
1282019-10-04T08:44:02 <meshcollider> \o/
1292019-10-04T08:45:08 *** Zenton has joined #bitcoin-core-dev
1302019-10-04T08:49:34 *** promag has joined #bitcoin-core-dev
1312019-10-04T08:56:26 *** rafalcpp_ has joined #bitcoin-core-dev
1322019-10-04T08:56:28 *** rafalcpp has quit IRC
1332019-10-04T08:59:56 *** promag has quit IRC
1342019-10-04T09:00:02 *** jackalope has quit IRC
1352019-10-04T09:00:11 *** m1rror8955363887 has quit IRC
1362019-10-04T09:01:15 *** promag has joined #bitcoin-core-dev
1372019-10-04T09:01:17 *** face has quit IRC
1382019-10-04T09:02:45 *** face has joined #bitcoin-core-dev
1392019-10-04T09:04:20 *** face has quit IRC
1402019-10-04T09:11:59 *** ryanofsky has quit IRC
1412019-10-04T09:13:39 *** ryanofsky has joined #bitcoin-core-dev
1422019-10-04T09:14:52 *** promag has quit IRC
1432019-10-04T09:15:07 *** promag has joined #bitcoin-core-dev
1442019-10-04T09:15:41 *** landonf1 has joined #bitcoin-core-dev
1452019-10-04T09:23:04 *** kcalvinalvin has joined #bitcoin-core-dev
1462019-10-04T09:27:00 <wumpus> I've split the "needs backport" label per branch
1472019-10-04T09:29:06 <wumpus> this separates it from "milestone" which is something different (e.g. something might be tagged for backport to a branch without targeting a specific release)
1482019-10-04T09:37:19 <fanquake> wumpus \o/
1492019-10-04T09:41:42 <fanquake> I think splitting makes sense. It was always a bit confusing when milestones could have multiple meanings
1502019-10-04T10:03:42 *** cryptoIndio has quit IRC
1512019-10-04T10:14:30 *** promag has quit IRC
1522019-10-04T10:20:13 *** bitcoin-git has joined #bitcoin-core-dev
1532019-10-04T10:20:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1f284aa757d...8ddc30393121
1542019-10-04T10:20:14 <bitcoin-git> bitcoin/master 3f89e1e João Barbosa: Prevent processing duplicate payment requests
1552019-10-04T10:20:14 <bitcoin-git> bitcoin/master 8ddc303 fanquake: Merge #17031: gui: Prevent processing duplicate payment requests
1562019-10-04T10:20:16 *** bitcoin-git has left #bitcoin-core-dev
1572019-10-04T10:20:33 *** bitcoin-git has joined #bitcoin-core-dev
1582019-10-04T10:20:33 <bitcoin-git> [bitcoin] fanquake merged pull request #17031: gui: Prevent processing duplicate payment requests (master...2019-10-fix-paymentserver) https://github.com/bitcoin/bitcoin/pull/17031
1592019-10-04T10:20:34 *** bitcoin-git has left #bitcoin-core-dev
1602019-10-04T10:24:26 *** jkczyz has joined #bitcoin-core-dev
1612019-10-04T10:24:27 *** jonatack has quit IRC
1622019-10-04T10:28:51 *** jkczyz has quit IRC
1632019-10-04T10:51:11 *** bitcoin-git has joined #bitcoin-core-dev
1642019-10-04T10:51:12 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8ddc30393121...94e6e9f38dee
1652019-10-04T10:51:12 <bitcoin-git> bitcoin/master fab68a0 MarcoFalke: doc: move-only release notes fragments for 0.20.0
1662019-10-04T10:51:13 <bitcoin-git> bitcoin/master fa8d052 MarcoFalke: doc: Update bips.md for default bech32 addresses in 0.20.0
1672019-10-04T10:51:13 <bitcoin-git> bitcoin/master fad1dbd MarcoFalke: doc: Fix amount typo in release notes
1682019-10-04T10:51:15 *** bitcoin-git has left #bitcoin-core-dev
1692019-10-04T10:51:31 *** bitcoin-git has joined #bitcoin-core-dev
1702019-10-04T10:51:31 <bitcoin-git> [bitcoin] fanquake merged pull request #17026: doc: Update bips.md for default bech32 addresses in 0.20.0 (master...1909-doc0.20Rel) https://github.com/bitcoin/bitcoin/pull/17026
1712019-10-04T10:51:32 *** bitcoin-git has left #bitcoin-core-dev
1722019-10-04T10:54:57 *** promag has joined #bitcoin-core-dev
1732019-10-04T10:58:48 *** rafalcpp_ is now known as rafalcpp
1742019-10-04T10:59:26 *** promag has quit IRC
1752019-10-04T11:14:22 *** promag has joined #bitcoin-core-dev
1762019-10-04T11:31:58 *** zivl has quit IRC
1772019-10-04T11:41:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1782019-10-04T11:46:08 *** jonatack has joined #bitcoin-core-dev
1792019-10-04T11:51:57 *** bitcoin-git has joined #bitcoin-core-dev
1802019-10-04T11:51:57 <bitcoin-git> [bitcoin] GChuf opened pull request #17048: gui: add shortcuts for Options and Command-line options (master...shortcuts) https://github.com/bitcoin/bitcoin/pull/17048
1812019-10-04T11:51:58 *** bitcoin-git has left #bitcoin-core-dev
1822019-10-04T11:52:17 *** bitcoin-git has joined #bitcoin-core-dev
1832019-10-04T11:52:17 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/cd1e7bb06431...bd22dea6331d
1842019-10-04T11:52:18 <bitcoin-git> bitcoin/0.19 bd22dea João Barbosa: Prevent processing duplicate payment requests
1852019-10-04T11:52:20 *** bitcoin-git has left #bitcoin-core-dev
1862019-10-04T11:52:37 *** promag has quit IRC
1872019-10-04T11:56:27 <wumpus> fanquake: exactly; it is quite rare to backport to the previous major release, but especially so close to a major release it's more common and it can get confusing
1882019-10-04T12:00:02 *** landonf1 has quit IRC
1892019-10-04T12:01:32 <wumpus> also, a bot could potentially automatically remove the "Needs backport" tag now when it detects a certain PR has been backported to that branch
1902019-10-04T12:17:41 *** defnordic has joined #bitcoin-core-dev
1912019-10-04T12:25:13 *** jkczyz has joined #bitcoin-core-dev
1922019-10-04T12:30:04 *** jkczyz has quit IRC
1932019-10-04T12:32:32 *** cubancorona has quit IRC
1942019-10-04T12:32:57 *** jonatack has quit IRC
1952019-10-04T12:35:36 *** jonatack has joined #bitcoin-core-dev
1962019-10-04T12:40:00 *** bitcoin-git has joined #bitcoin-core-dev
1972019-10-04T12:40:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17049: build: Release updates on master (take 2) (master...1909-prep20) https://github.com/bitcoin/bitcoin/pull/17049
1982019-10-04T12:40:01 *** bitcoin-git has left #bitcoin-core-dev
1992019-10-04T12:51:27 *** masterdonx2 has joined #bitcoin-core-dev
2002019-10-04T12:53:33 *** MasterdonX has quit IRC
2012019-10-04T12:56:14 *** masterdonx2 has quit IRC
2022019-10-04T12:57:47 *** promag has joined #bitcoin-core-dev
2032019-10-04T13:06:49 *** Aaronvan_ has joined #bitcoin-core-dev
2042019-10-04T13:10:03 *** AaronvanW has quit IRC
2052019-10-04T13:14:31 *** side^effects has joined #bitcoin-core-dev
2062019-10-04T13:17:53 *** bitcoin-git has joined #bitcoin-core-dev
2072019-10-04T13:17:53 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/bd22dea6331d...913972944b4f
2082019-10-04T13:17:53 <bitcoin-git> bitcoin/0.19 9139729 Wladimir J. van der Laan: doc: Update manpages
2092019-10-04T13:17:55 *** bitcoin-git has left #bitcoin-core-dev
2102019-10-04T13:22:32 *** bitcoin-git has joined #bitcoin-core-dev
2112019-10-04T13:22:32 <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.0rc1
2122019-10-04T13:22:33 *** bitcoin-git has left #bitcoin-core-dev
2132019-10-04T13:22:52 *** bitcoin-git has joined #bitcoin-core-dev
2142019-10-04T13:22:52 <bitcoin-git> [bitcoin] practicalswift opened pull request #17050: tests: Add fuzzing harnesses for DecodeRawPSBT(...), ParseHDKeypath(...), ParseScript(...), various number parsing functions and various JSON/univalue parsing functions (master...fuzzers) https://github.com/bitcoin/bitcoin/pull/17050
2152019-10-04T13:22:54 *** bitcoin-git has left #bitcoin-core-dev
2162019-10-04T13:23:48 *** hebasto has joined #bitcoin-core-dev
2172019-10-04T13:26:37 *** MasterdonX has joined #bitcoin-core-dev
2182019-10-04T13:27:56 *** jonatack has quit IRC
2192019-10-04T13:30:47 *** masterdonx2 has joined #bitcoin-core-dev
2202019-10-04T13:32:32 *** MasterdonX has quit IRC
2212019-10-04T13:33:41 *** nejon has joined #bitcoin-core-dev
2222019-10-04T13:42:20 <hebasto> gitian-build.py fails for 0.19.0rc1; digging...
2232019-10-04T13:42:46 <fanquake> hebasto what's the error?
2242019-10-04T13:43:38 <MarcoFalke> hebasto: There is no tag yet
2252019-10-04T13:43:48 <MarcoFalke> oh wait there is
2262019-10-04T13:44:21 <MarcoFalke> [05:27] <wumpus> I've split the "needs backport" label per branch
2272019-10-04T13:44:23 <MarcoFalke> thx ^
2282019-10-04T13:45:12 <fanquake> MarcoFalke: In the ARM CI PR, have you been seeing the permissions errors the whole time?
2292019-10-04T13:46:39 <MarcoFalke> Might be something with DOCKER_EXEC, as it is a bash function
2302019-10-04T13:48:06 <hebasto> fanquake: line 245 subprocess.CalledProcessError: Command '['git', 'pull']' returned non-zero exit status 128.
2312019-10-04T13:48:47 <MarcoFalke> I've seen some github git fetch timeouts yesterday
2322019-10-04T13:49:16 <fanquake> hebasto: yea I'd just retry
2332019-10-04T13:49:51 <hebasto> fanquake: nm; it was my own branch of gitian-builder; sorry
2342019-10-04T14:05:09 *** funtimer has joined #bitcoin-core-dev
2352019-10-04T14:15:10 *** SiAnDoG has joined #bitcoin-core-dev
2362019-10-04T14:21:48 *** dognosewhiskers has joined #bitcoin-core-dev
2372019-10-04T14:21:52 <dognosewhiskers> Bitcoin.conf has "proxy = 127.0.0.1:9150" but the GUI options doesn't have the checkboxes for the proxy settings checked.
2382019-10-04T14:21:55 <dognosewhiskers> What gives?
2392019-10-04T14:22:05 <dognosewhiskers> Is it using Tor or not?
2402019-10-04T14:26:08 *** jkczyz has joined #bitcoin-core-dev
2412019-10-04T14:30:24 *** side^effects has quit IRC
2422019-10-04T14:30:43 *** jkczyz has quit IRC
2432019-10-04T14:31:23 *** bitcoin-git has joined #bitcoin-core-dev
2442019-10-04T14:31:23 <bitcoin-git> [bitcoin] practicalswift opened pull request #17051: tests: Add deserialization fuzzing harnesses (master...fuzzers-deserialize) https://github.com/bitcoin/bitcoin/pull/17051
2452019-10-04T14:31:25 *** bitcoin-git has left #bitcoin-core-dev
2462019-10-04T14:37:50 <dognosewhiskers> Anyone?
2472019-10-04T14:41:40 <sdaftuar> dognosewhiskers: just a guess as i'm not very familiar with the gui, but i seem to recall there being some longstanding issues around qt preferences being stored/tracked differently from bitcoin.conf
2482019-10-04T14:43:29 *** rafalcpp_ has joined #bitcoin-core-dev
2492019-10-04T14:44:01 *** rafalcpp has quit IRC
2502019-10-04T14:54:08 *** bitcoin-git has joined #bitcoin-core-dev
2512019-10-04T14:54:08 <bitcoin-git> [bitcoin] GChuf opened pull request #17052: scripts: update copyright_header script to include additional files (master...copyright-header-script) https://github.com/bitcoin/bitcoin/pull/17052
2522019-10-04T14:54:09 *** bitcoin-git has left #bitcoin-core-dev
2532019-10-04T14:56:43 <dognosewhiskers> sdaftuar: Hmm! That is very scary/confusing!
2542019-10-04T14:57:28 *** bitcoin-git has joined #bitcoin-core-dev
2552019-10-04T14:57:28 <bitcoin-git> [bitcoin] GChuf opened pull request #17053: Update headers for v0.19 (0.19...update-headers-019) https://github.com/bitcoin/bitcoin/pull/17053
2562019-10-04T14:57:29 *** bitcoin-git has left #bitcoin-core-dev
2572019-10-04T14:58:28 *** rex4539 has quit IRC
2582019-10-04T15:00:02 *** defnordic has quit IRC
2592019-10-04T15:05:12 *** cubancorona has joined #bitcoin-core-dev
2602019-10-04T15:07:41 *** kljasdfvv has quit IRC
2612019-10-04T15:16:02 *** jarthur has joined #bitcoin-core-dev
2622019-10-04T15:16:07 *** atomicturtle has joined #bitcoin-core-dev
2632019-10-04T15:24:49 *** cryptapus has quit IRC
2642019-10-04T15:29:43 *** cryptapus has joined #bitcoin-core-dev
2652019-10-04T15:29:43 *** cryptapus has quit IRC
2662019-10-04T15:29:43 *** cryptapus has joined #bitcoin-core-dev
2672019-10-04T15:30:17 *** jkczyz has joined #bitcoin-core-dev
2682019-10-04T15:38:38 *** Zenton has quit IRC
2692019-10-04T15:40:17 *** captjakk has joined #bitcoin-core-dev
2702019-10-04T15:42:50 *** Guyver2 has joined #bitcoin-core-dev
2712019-10-04T15:44:06 *** promag has quit IRC
2722019-10-04T15:45:34 *** rafalcpp_ is now known as rafalcpp
2732019-10-04T15:48:57 *** jkczyz has quit IRC
2742019-10-04T15:51:56 *** bitcoin-git has joined #bitcoin-core-dev
2752019-10-04T15:51:56 <bitcoin-git> [bitcoin] fanquake closed pull request #17053: Update headers for v0.19 (0.19...update-headers-019) https://github.com/bitcoin/bitcoin/pull/17053
2762019-10-04T15:52:07 *** bitcoin-git has left #bitcoin-core-dev
2772019-10-04T16:00:15 *** promag has joined #bitcoin-core-dev
2782019-10-04T16:05:13 *** promag has quit IRC
2792019-10-04T16:13:26 *** Jackielove4u has quit IRC
2802019-10-04T16:22:40 *** funtimer has quit IRC
2812019-10-04T16:43:27 *** jkczyz has joined #bitcoin-core-dev
2822019-10-04T16:44:02 *** lightlike has joined #bitcoin-core-dev
2832019-10-04T16:52:41 *** fox2p has joined #bitcoin-core-dev
2842019-10-04T16:54:22 *** fox2p_ has quit IRC
2852019-10-04T17:04:46 *** promag has joined #bitcoin-core-dev
2862019-10-04T17:14:47 *** promag has quit IRC
2872019-10-04T17:17:27 *** Chris_Stewart_5 has quit IRC
2882019-10-04T17:27:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2892019-10-04T17:34:43 *** arik_ has joined #bitcoin-core-dev
2902019-10-04T17:35:04 *** jkczyz has quit IRC
2912019-10-04T17:39:14 *** jkczyz has joined #bitcoin-core-dev
2922019-10-04T17:47:16 *** bitcoin-git has joined #bitcoin-core-dev
2932019-10-04T17:47:16 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/94e6e9f38dee...94d6a18f23ec
2942019-10-04T17:47:17 <bitcoin-git> bitcoin/master 8e59af5 Gregory Sanders: feefilter: Compute the absolute fee rather than stored rate to match mempo...
2952019-10-04T17:47:17 <bitcoin-git> bitcoin/master 6a51f79 Gregory Sanders: Disallow implicit conversion for CFeeRate constructor
2962019-10-04T17:47:18 <bitcoin-git> bitcoin/master eb7b781 Gregory Sanders: modify p2p_feefilter test to catch rounding error
2972019-10-04T17:47:24 *** rockhouse has quit IRC
2982019-10-04T17:47:25 *** victorSN has quit IRC
2992019-10-04T17:47:27 *** bitcoin-git has left #bitcoin-core-dev
3002019-10-04T17:47:44 *** rockhouse has joined #bitcoin-core-dev
3012019-10-04T17:47:46 *** bitcoin-git has joined #bitcoin-core-dev
3022019-10-04T17:47:46 <bitcoin-git> [bitcoin] fanquake merged pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
3032019-10-04T17:47:57 *** bitcoin-git has left #bitcoin-core-dev
3042019-10-04T17:57:12 *** dognosewhiskers has left #bitcoin-core-dev
3052019-10-04T17:57:16 *** rafalcpp_ has joined #bitcoin-core-dev
3062019-10-04T17:57:37 *** rafalcpp has quit IRC
3072019-10-04T18:00:01 *** atomicturtle has quit IRC
3082019-10-04T18:17:30 *** lcb has joined #bitcoin-core-dev
3092019-10-04T18:24:28 *** bitcoin-git has joined #bitcoin-core-dev
3102019-10-04T18:24:28 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94d6a18f23ec...917d3d9052b5
3112019-10-04T18:24:29 <bitcoin-git> bitcoin/master dffae5a gchuf: scripts: update copyright_header script to include additional files
3122019-10-04T18:24:30 <bitcoin-git> bitcoin/master 917d3d9 fanquake: Merge #17052: scripts: update copyright_header script to include additiona...
3132019-10-04T18:24:40 *** bitcoin-git has left #bitcoin-core-dev
3142019-10-04T18:24:58 *** bitcoin-git has joined #bitcoin-core-dev
3152019-10-04T18:24:58 <bitcoin-git> [bitcoin] fanquake merged pull request #17052: scripts: update copyright_header script to include additional files (master...copyright-header-script) https://github.com/bitcoin/bitcoin/pull/17052
3162019-10-04T18:24:59 *** bitcoin-git has left #bitcoin-core-dev
3172019-10-04T18:26:45 *** promag has joined #bitcoin-core-dev
3182019-10-04T18:30:57 *** promag has quit IRC
3192019-10-04T18:34:36 *** Jackielove4u has joined #bitcoin-core-dev
3202019-10-04T18:40:32 *** bitcoin-git has joined #bitcoin-core-dev
3212019-10-04T18:40:32 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/917d3d9052b5...7b701fef58f6
3222019-10-04T18:40:33 <bitcoin-git> bitcoin/master fa1ad8f MarcoFalke: build: Bump gitian descriptor versions
3232019-10-04T18:40:33 <bitcoin-git> bitcoin/master 7b701fe fanquake: Merge #17049: contrib: Bump gitian descriptors for 0.20
3242019-10-04T18:40:35 *** bitcoin-git has left #bitcoin-core-dev
3252019-10-04T18:40:52 *** bitcoin-git has joined #bitcoin-core-dev
3262019-10-04T18:40:52 <bitcoin-git> [bitcoin] fanquake merged pull request #17049: contrib: Bump gitian descriptors for 0.20 (master...1909-prep20) https://github.com/bitcoin/bitcoin/pull/17049
3272019-10-04T18:40:54 *** bitcoin-git has left #bitcoin-core-dev
3282019-10-04T18:50:49 *** arik_ has quit IRC
3292019-10-04T18:51:11 *** arik_ has joined #bitcoin-core-dev
3302019-10-04T18:56:19 *** victorSN has joined #bitcoin-core-dev
3312019-10-04T19:16:16 *** bitcoin-git has joined #bitcoin-core-dev
3322019-10-04T19:16:16 <bitcoin-git> [bitcoin] lucayepa opened pull request #17054: [0.18.2] Backport of #15706 (master...check-qt-version-0.18) https://github.com/bitcoin/bitcoin/pull/17054
3332019-10-04T19:16:18 *** bitcoin-git has left #bitcoin-core-dev
3342019-10-04T19:22:24 *** fox2p_ has joined #bitcoin-core-dev
3352019-10-04T19:23:31 *** Zenton has joined #bitcoin-core-dev
3362019-10-04T19:23:32 *** fox2p has quit IRC
3372019-10-04T19:41:20 *** tripleslash has joined #bitcoin-core-dev
3382019-10-04T19:43:18 *** bitcoin-git has joined #bitcoin-core-dev
3392019-10-04T19:43:18 <bitcoin-git> [bitcoin] lucayepa opened pull request #17055: [0.19] Backport of #15706 (0.19...check-qt-version-0.19) https://github.com/bitcoin/bitcoin/pull/17055
3402019-10-04T19:43:20 *** bitcoin-git has left #bitcoin-core-dev
3412019-10-04T19:49:41 *** bitcoin-git has joined #bitcoin-core-dev
3422019-10-04T19:49:41 <bitcoin-git> [bitcoin] achow101 opened pull request #17056: Introduce sortedmulti descriptor (master...sortedmulti-desc) https://github.com/bitcoin/bitcoin/pull/17056
3432019-10-04T19:49:43 *** bitcoin-git has left #bitcoin-core-dev
3442019-10-04T19:49:50 *** Aaronvan_ is now known as AaronvanW
3452019-10-04T19:54:51 *** bitcoin-git has joined #bitcoin-core-dev
3462019-10-04T19:54:51 <bitcoin-git> [bitcoin] fanquake opened pull request #17057: build: switch to upstream libdmg-hfsplus (master...upstream_libdmg_hfsplus) https://github.com/bitcoin/bitcoin/pull/17057
3472019-10-04T19:54:53 *** bitcoin-git has left #bitcoin-core-dev
3482019-10-04T19:58:02 *** diogosergio has joined #bitcoin-core-dev
3492019-10-04T20:00:02 *** shesek has quit IRC
3502019-10-04T20:02:07 *** jonatack has joined #bitcoin-core-dev
3512019-10-04T20:03:30 *** diogosergio has quit IRC
3522019-10-04T20:05:08 *** jkczyz has quit IRC
3532019-10-04T20:07:14 *** cubancorona has quit IRC
3542019-10-04T20:07:50 *** promag has joined #bitcoin-core-dev
3552019-10-04T20:20:18 *** tripleslash has quit IRC
3562019-10-04T20:28:45 *** Chris_Stewart_5 has quit IRC
3572019-10-04T20:35:36 *** diogosergio has joined #bitcoin-core-dev
3582019-10-04T20:37:08 *** promag has quit IRC
3592019-10-04T20:40:03 *** diogosergio has quit IRC
3602019-10-04T20:45:39 *** spinza has quit IRC
3612019-10-04T20:45:54 *** jkczyz has joined #bitcoin-core-dev
3622019-10-04T20:51:22 *** spinza has joined #bitcoin-core-dev
3632019-10-04T20:51:43 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3642019-10-04T20:57:04 *** reallll has joined #bitcoin-core-dev
3652019-10-04T20:58:43 *** Guyver2 has quit IRC
3662019-10-04T21:00:02 *** lcb has quit IRC
3672019-10-04T21:00:23 *** Chris_Stewart_5 has quit IRC
3682019-10-04T21:00:49 *** belcher has quit IRC
3692019-10-04T21:05:23 *** promag has joined #bitcoin-core-dev
3702019-10-04T21:05:52 *** cubancorona has joined #bitcoin-core-dev
3712019-10-04T21:17:37 *** guilhermeblanco has joined #bitcoin-core-dev
3722019-10-04T21:18:02 *** rh0nj has quit IRC
3732019-10-04T21:19:07 *** rh0nj has joined #bitcoin-core-dev
3742019-10-04T21:20:51 *** jb55 has quit IRC
3752019-10-04T21:29:54 *** jb55 has joined #bitcoin-core-dev
3762019-10-04T21:31:04 *** rafalcpp has joined #bitcoin-core-dev
3772019-10-04T21:31:52 *** rafalcpp_ has quit IRC
3782019-10-04T21:34:50 *** owowo has quit IRC
3792019-10-04T21:41:01 *** owowo has joined #bitcoin-core-dev
3802019-10-04T21:41:01 *** owowo has joined #bitcoin-core-dev
3812019-10-04T21:42:10 *** lnostdal has quit IRC
3822019-10-04T21:52:05 <promag> emilengler: hi
3832019-10-04T21:52:14 <promag> emilengler: I really don't understand what you mean in https://github.com/bitcoin/bitcoin/pull/17035/files#r331313258
3842019-10-04T21:52:55 <promag> with my suggestion you can avoid adding Intro::on_prune_stateChanged
3852019-10-04T21:53:19 <promag> and the actual call to setSizeWarningLabel is simpler
3862019-10-04T21:53:35 <emilengler> promag: With a connect()?
3872019-10-04T21:53:49 <promag> yes
3882019-10-04T21:54:08 <emilengler> I did it because my approach was common
3892019-10-04T21:54:22 <promag> emilengler: it's not the best though
3902019-10-04T21:54:37 <emilengler> I don't like to change the syntax of a project just becasue of a simple bugfix
3912019-10-04T21:54:54 <emilengler> I totally agree, I don't like the cuurent situation either
3922019-10-04T21:54:56 <promag> emilengler: actually your change is worst
3932019-10-04T21:55:10 <emilengler> How?
3942019-10-04T21:56:54 <promag> what Qt does is it iterates all slots and if it finds that syntax (on_<obj name>_<signal>) it automatically connects to that slots. but this is dynamically, and not compiler checked. for instance, if you rename the object then the connect won't happen unless you also rename the slot
3952019-10-04T21:57:26 <emilengler> Oh
3962019-10-04T21:57:28 <promag> that's why we also dropped SIGNAL() SLOT() connections
3972019-10-04T21:57:33 <emilengler> Yeah it is ugly...
3982019-10-04T21:57:56 <emilengler> But like I said, not only my function is doing this
3992019-10-04T21:58:03 <emilengler> There are several others in the code
4002019-10-04T21:58:13 <promag> new code should not use dynamic connections
4012019-10-04T21:58:40 <emilengler> I thought it should follow the syntax...
4022019-10-04T21:59:51 <promag> this is not syntax
4032019-10-04T22:00:08 <promag> this is not code format
4042019-10-04T22:01:04 <promag> There are several others in the code -> you are free to fix that
4052019-10-04T22:01:16 <emilengler> But is the approach with connect often used in the code? In intro.cpp connect is only used with the FreespaceChecker
4062019-10-04T22:02:01 <emilengler> Ok I will fix it ^^
4072019-10-04T22:04:03 <promag> emilengler: see #13529
4082019-10-04T22:04:05 <gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
4092019-10-04T22:05:14 <promag> also #16348
4102019-10-04T22:05:16 <gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub
4112019-10-04T22:06:18 <promag> see #16261 for some cases with good connect() usage
4122019-10-04T22:06:20 <gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
4132019-10-04T22:07:02 <promag> let me know if you need help
4142019-10-04T22:07:30 <emilengler> Ok, thanks for offering :)
4152019-10-04T22:11:22 *** Victorsueca has joined #bitcoin-core-dev
4162019-10-04T22:11:54 *** Victor_sueca has quit IRC
4172019-10-04T22:19:03 <emilengler> promag: https://github.com/bitcoin/bitcoin/pull/17035/commits/865cf2ddd3d23592b1dbdae377e996def2e65cde
4182019-10-04T22:19:10 <emilengler> Thanks for your snippet btw
4192019-10-04T22:20:50 <promag> add a newline at the end of intro.cpp and squash commits
4202019-10-04T22:21:25 <promag> emilengler: thanks, I'll test the remaining change
4212019-10-04T22:22:01 <emilengler> promag: I have to say thanks :)
4222019-10-04T22:24:38 <emilengler> Done
4232019-10-04T22:26:33 *** profmac has quit IRC
4242019-10-04T22:27:22 *** profmac has joined #bitcoin-core-dev
4252019-10-04T22:32:37 *** jkczyz has quit IRC
4262019-10-04T22:38:19 *** bitcoin-git has joined #bitcoin-core-dev
4272019-10-04T22:38:19 <bitcoin-git> [bitcoin] GChuf opened pull request #17058: GUI: Remove old translation files, reorganize translations (master...translations-fix) https://github.com/bitcoin/bitcoin/pull/17058
4282019-10-04T22:38:20 *** bitcoin-git has left #bitcoin-core-dev
4292019-10-04T22:39:39 *** captjakk has quit IRC
4302019-10-04T22:40:06 *** captjakk has joined #bitcoin-core-dev
4312019-10-04T22:44:17 *** captjakk has quit IRC
4322019-10-04T22:52:30 <sipa> emilengler: generally you should avoid the urge to mimick the surrounding style when writing new code
4332019-10-04T23:20:24 *** nosss2 has joined #bitcoin-core-dev
4342019-10-04T23:26:09 *** promag has quit IRC
4352019-10-04T23:54:39 *** rhavar_ has joined #bitcoin-core-dev
4362019-10-04T23:56:00 *** reallll is now known as belcher