12019-10-12T00:00:01 *** bpalmer1 has quit IRC
22019-10-12T00:00:38 *** marcoagner has quit IRC
32019-10-12T00:04:21 *** Jackielove4u has quit IRC
42019-10-12T00:05:19 *** lightlike has quit IRC
52019-10-12T00:06:14 *** goatpig has joined #bitcoin-core-dev
62019-10-12T00:12:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
72019-10-12T00:22:00 *** phantomcircuit_ is now known as phantomcircuit
82019-10-12T00:24:59 *** promag has quit IRC
92019-10-12T00:31:20 *** jkczyz has joined #bitcoin-core-dev
102019-10-12T00:33:52 *** AaronvanW has quit IRC
112019-10-12T00:33:57 *** promag has joined #bitcoin-core-dev
122019-10-12T00:35:39 *** jkczyz has quit IRC
132019-10-12T00:37:37 *** Highway61 has quit IRC
142019-10-12T00:41:24 *** arik_ has quit IRC
152019-10-12T00:46:13 *** |Kin| has joined #bitcoin-core-dev
162019-10-12T01:06:10 <emilengler> captjakk: I'm not sure but I don't think so
172019-10-12T01:06:38 <emilengler> For example when you prune on a regtest chain, block 1 will still be there I thinx
182019-10-12T01:07:29 <sipa> he's no longer here
192019-10-12T01:07:39 *** Chris_Stewart_5 has quit IRC
202019-10-12T01:11:39 *** millerti has quit IRC
212019-10-12T01:22:45 *** gwollon is now known as gwillen
222019-10-12T01:25:12 *** promag has quit IRC
232019-10-12T01:26:13 *** cubancorona has quit IRC
242019-10-12T01:31:25 *** laptop500 has quit IRC
252019-10-12T01:33:17 *** arik_ has joined #bitcoin-core-dev
262019-10-12T01:34:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
272019-10-12T01:34:59 *** achow101 has quit IRC
282019-10-12T01:38:08 *** arik_ has quit IRC
292019-10-12T01:38:50 *** cubancorona has joined #bitcoin-core-dev
302019-10-12T01:39:05 *** achow101 has joined #bitcoin-core-dev
312019-10-12T01:40:24 *** cubancorona2 has joined #bitcoin-core-dev
322019-10-12T01:43:17 *** cubancorona has quit IRC
332019-10-12T01:50:43 *** michaelfolkson has joined #bitcoin-core-dev
342019-10-12T01:51:51 *** emilengler has quit IRC
352019-10-12T02:02:03 *** michaelfolkson has quit IRC
362019-10-12T02:07:38 *** nosss2_ has joined #bitcoin-core-dev
372019-10-12T02:08:18 *** SiAnDoG has joined #bitcoin-core-dev
382019-10-12T02:09:45 *** emilengler has joined #bitcoin-core-dev
392019-10-12T02:11:17 *** nosss2 has quit IRC
402019-10-12T02:12:35 *** Chris_Stewart_5 has quit IRC
412019-10-12T02:14:32 *** felixfoertsch has quit IRC
422019-10-12T02:14:33 *** felixfoertsch23 has joined #bitcoin-core-dev
432019-10-12T02:25:54 *** promag has joined #bitcoin-core-dev
442019-10-12T02:30:02 *** promag has quit IRC
452019-10-12T02:32:09 *** jkczyz has joined #bitcoin-core-dev
462019-10-12T02:33:00 *** shesek has joined #bitcoin-core-dev
472019-10-12T02:33:00 *** shesek has joined #bitcoin-core-dev
482019-10-12T02:36:56 *** jkczyz has quit IRC
492019-10-12T02:40:01 *** rh0nj has quit IRC
502019-10-12T02:41:10 *** rh0nj has joined #bitcoin-core-dev
512019-10-12T02:43:36 *** arik_ has joined #bitcoin-core-dev
522019-10-12T02:44:57 *** achow101 has quit IRC
532019-10-12T02:57:28 *** arik_ has quit IRC
542019-10-12T02:58:07 *** achow101 has joined #bitcoin-core-dev
552019-10-12T03:00:02 *** |Kin| has quit IRC
562019-10-12T03:08:41 *** jarthur has joined #bitcoin-core-dev
572019-10-12T03:17:24 *** sankarshan1 has joined #bitcoin-core-dev
582019-10-12T03:55:17 *** ddustin has joined #bitcoin-core-dev
592019-10-12T03:56:20 *** BLackArch has joined #bitcoin-core-dev
602019-10-12T04:01:25 *** BLackArch has left #bitcoin-core-dev
612019-10-12T04:02:40 *** Hayro has joined #bitcoin-core-dev
622019-10-12T04:03:33 *** jkczyz has joined #bitcoin-core-dev
632019-10-12T04:07:57 *** jkczyz has quit IRC
642019-10-12T04:12:02 *** jkczyz has joined #bitcoin-core-dev
652019-10-12T04:23:40 *** felixfoertsch23 has quit IRC
662019-10-12T04:23:51 *** felixfoertsch has joined #bitcoin-core-dev
672019-10-12T04:33:39 *** justanotheruser has quit IRC
682019-10-12T04:39:52 *** ajonas has quit IRC
692019-10-12T04:49:45 *** BLackArch has joined #bitcoin-core-dev
702019-10-12T04:50:41 *** justanotheruser has joined #bitcoin-core-dev
712019-10-12T04:51:35 *** Hayro has quit IRC
722019-10-12T04:54:05 *** rex4539 has joined #bitcoin-core-dev
732019-10-12T04:54:57 *** BLackArch has left #bitcoin-core-dev
742019-10-12T05:11:31 *** rex4539 has quit IRC
752019-10-12T05:18:51 *** verno99999 has joined #bitcoin-core-dev
762019-10-12T05:28:26 *** verno99999 has quit IRC
772019-10-12T05:37:51 *** face has joined #bitcoin-core-dev
782019-10-12T05:51:24 *** arik_ has joined #bitcoin-core-dev
792019-10-12T05:58:32 *** rex4539 has joined #bitcoin-core-dev
802019-10-12T05:58:49 *** rex4539 has quit IRC
812019-10-12T06:00:01 *** sankarshan1 has quit IRC
822019-10-12T06:00:25 *** promag has joined #bitcoin-core-dev
832019-10-12T06:04:51 *** promag has quit IRC
842019-10-12T06:17:43 *** kottt has joined #bitcoin-core-dev
852019-10-12T06:31:13 *** face has quit IRC
862019-10-12T06:35:37 *** jkczyz has quit IRC
872019-10-12T07:04:05 *** jkczyz has joined #bitcoin-core-dev
882019-10-12T07:08:38 *** jkczyz has quit IRC
892019-10-12T07:12:04 *** rex4539 has joined #bitcoin-core-dev
902019-10-12T07:29:53 *** lnostdal has joined #bitcoin-core-dev
912019-10-12T07:37:31 *** nickler_ has quit IRC
922019-10-12T07:37:45 *** nickler has joined #bitcoin-core-dev
932019-10-12T07:43:13 *** jonatack has quit IRC
942019-10-12T08:04:24 *** Jackielove4u has joined #bitcoin-core-dev
952019-10-12T08:17:38 *** promag has joined #bitcoin-core-dev
962019-10-12T08:27:25 *** bitcoin-git has joined #bitcoin-core-dev
972019-10-12T08:27:25 <bitcoin-git> [bitcoin] practicalswift opened pull request #17113: tests: Add fuzzing harness for descriptor Span-parsing helpers (master...fuzzers-spanparsing) https://github.com/bitcoin/bitcoin/pull/17113
982019-10-12T08:27:27 *** bitcoin-git has left #bitcoin-core-dev
992019-10-12T08:38:32 *** jonatack has joined #bitcoin-core-dev
1002019-10-12T08:40:07 *** PaulTroon has joined #bitcoin-core-dev
1012019-10-12T08:40:31 *** arik_ has quit IRC
1022019-10-12T08:42:58 <promag> could #16963 be in HP?
1032019-10-12T08:43:00 <gribble> https://github.com/bitcoin/bitcoin/issues/16963 | wallet: Fix unique_ptr usage in boost::signals2 by promag · Pull Request #16963 · bitcoin/bitcoin · GitHub
1042019-10-12T08:44:32 *** rex4539 has quit IRC
1052019-10-12T08:44:46 *** rex4539 has joined #bitcoin-core-dev
1062019-10-12T08:47:56 *** hebasto has joined #bitcoin-core-dev
1072019-10-12T08:48:27 *** jonatack has quit IRC
1082019-10-12T08:49:53 *** jonatack has joined #bitcoin-core-dev
1092019-10-12T08:51:15 *** m1rror8955363887 has quit IRC
1102019-10-12T08:53:09 *** jarthur has quit IRC
1112019-10-12T08:58:06 *** marcoagner has joined #bitcoin-core-dev
1122019-10-12T09:00:02 *** kottt has quit IRC
1132019-10-12T09:04:59 *** jkczyz has joined #bitcoin-core-dev
1142019-10-12T09:09:45 *** jkczyz has quit IRC
1152019-10-12T09:12:57 *** AaronvanW has joined #bitcoin-core-dev
1162019-10-12T09:13:53 *** subdriven1 has joined #bitcoin-core-dev
1172019-10-12T09:15:13 *** morcos has quit IRC
1182019-10-12T09:15:27 *** promag has quit IRC
1192019-10-12T09:15:35 *** morcos has joined #bitcoin-core-dev
1202019-10-12T09:21:55 *** promag has joined #bitcoin-core-dev
1212019-10-12T09:33:57 *** jonatack has quit IRC
1222019-10-12T09:34:08 *** promag has quit IRC
1232019-10-12T09:34:49 *** promag has joined #bitcoin-core-dev
1242019-10-12T09:39:10 *** m8tion has joined #bitcoin-core-dev
1252019-10-12T09:40:35 *** promag has quit IRC
1262019-10-12T09:49:10 *** kakobrekla has quit IRC
1272019-10-12T09:50:31 *** kakobrekla has joined #bitcoin-core-dev
1282019-10-12T09:58:09 *** jonatack has joined #bitcoin-core-dev
1292019-10-12T10:15:07 *** Victor_sueca is now known as Victorsueca
1302019-10-12T10:25:52 *** ddustin has quit IRC
1312019-10-12T10:33:40 *** jkczyz has joined #bitcoin-core-dev
1322019-10-12T10:38:17 *** jkczyz has quit IRC
1332019-10-12T10:42:52 *** Soligor has quit IRC
1342019-10-12T10:45:06 *** Evel-Knievel has quit IRC
1352019-10-12T10:48:40 *** goatpig has quit IRC
1362019-10-12T10:49:59 *** jb55 has quit IRC
1372019-10-12T10:50:56 *** jb55 has joined #bitcoin-core-dev
1382019-10-12T10:51:11 *** mmgen has joined #bitcoin-core-dev
1392019-10-12T10:56:17 *** Soligor has joined #bitcoin-core-dev
1402019-10-12T11:01:38 *** m8tion has quit IRC
1412019-10-12T11:23:27 *** Ap4ch3 has joined #bitcoin-core-dev
1422019-10-12T11:42:59 *** EagleTM has joined #bitcoin-core-dev
1432019-10-12T12:00:01 *** subdriven1 has quit IRC
1442019-10-12T12:05:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1452019-10-12T12:17:32 *** omega8cc has joined #bitcoin-core-dev
1462019-10-12T12:18:48 *** Anduck_ is now known as Anduck
1472019-10-12T12:34:36 *** jkczyz has joined #bitcoin-core-dev
1482019-10-12T12:37:37 *** Highway61 has joined #bitcoin-core-dev
1492019-10-12T12:39:11 *** jkczyz has quit IRC
1502019-10-12T12:52:49 *** goatpig has joined #bitcoin-core-dev
1512019-10-12T12:58:07 *** cubancorona2 has quit IRC
1522019-10-12T13:00:02 *** jb55 has quit IRC
1532019-10-12T13:00:30 *** jb55 has joined #bitcoin-core-dev
1542019-10-12T13:01:02 *** promag has joined #bitcoin-core-dev
1552019-10-12T13:27:16 *** nosss2_ has quit IRC
1562019-10-12T13:27:39 *** promag has quit IRC
1572019-10-12T13:39:57 *** jonatack has quit IRC
1582019-10-12T13:44:15 *** ddustin has joined #bitcoin-core-dev
1592019-10-12T13:47:32 *** PaulTroon has quit IRC
1602019-10-12T13:49:16 *** ddustin has quit IRC
1612019-10-12T13:56:27 *** goatpig has quit IRC
1622019-10-12T14:01:25 *** promag has joined #bitcoin-core-dev
1632019-10-12T14:06:05 *** promag has quit IRC
1642019-10-12T14:08:37 *** bitcoin-git has joined #bitcoin-core-dev
1652019-10-12T14:08:37 <bitcoin-git> [bitcoin] Sjors opened pull request #17118: [build] depends macOS: point --sysroot to SDK (master...2019/10/macos-sysroot) https://github.com/bitcoin/bitcoin/pull/17118
1662019-10-12T14:08:38 *** bitcoin-git has left #bitcoin-core-dev
1672019-10-12T14:13:36 <provoostenator> Any QT build system experts in the house who can demystify https://github.com/bitcoin/bitcoin/pull/16966#issuecomment-541310206 ?
1682019-10-12T14:14:33 <provoostenator> Basically a --disable-wallet Travis build complaining that it can't find certain wallet related headers.
1692019-10-12T14:15:18 <provoostenator> I'm not sure what I'm doing different in terms of including the new QT send screen file I created though.
1702019-10-12T14:18:17 *** EagleTM has quit IRC
1712019-10-12T14:19:56 *** promag has joined #bitcoin-core-dev
1722019-10-12T14:21:12 *** aqquadro has joined #bitcoin-core-dev
1732019-10-12T14:21:12 *** aqquadro has quit IRC
1742019-10-12T14:21:12 *** aqquadro has joined #bitcoin-core-dev
1752019-10-12T14:21:23 <gwillen> provoostenator: I don't think it's actually a QT issue
1762019-10-12T14:21:37 <gwillen> you added an include of "wallet/coincontrol.h" to "qt/sendcompose.h"
1772019-10-12T14:21:45 <gwillen> but I think the former is wallet and the latter is non-wallet
1782019-10-12T14:22:05 <gwillen> (or rather, the latter is conditionally-wallet)
1792019-10-12T14:22:35 <gwillen> (because all the QT stuff gets built no matter whether wallet is enabled or not, as long as qt is enabled, I think)
1802019-10-12T14:23:03 <gwillen> not sure why it wouldn't reproduce locally though
1812019-10-12T14:23:07 <provoostenator> gwillen: but doesn't the current SendCoinsDialog have the same include? https://github.com/bitcoin/bitcoin/blob/master/src/qt/sendcoinsdialog.cpp#L24
1822019-10-12T14:23:09 <gwillen> so perhaps I'm wrong
1832019-10-12T14:23:52 <provoostenator> I can't reproduce it locally either, though trying a few different things.
1842019-10-12T14:23:53 <gwillen> but now it's in the h, where it was in the cpp before
1852019-10-12T14:24:03 <gwillen> that is definitely a significant change
1862019-10-12T14:24:09 <provoostenator> Yeah, I think I added it to the h in an attempt to get rid of that error.
1872019-10-12T14:24:22 <provoostenator> But I'll strip it again
1882019-10-12T14:24:38 <gwillen> ok, *nod*
1892019-10-12T14:24:49 <provoostenator> But trial and error only gets you so far :-)
1902019-10-12T14:25:00 <gwillen> the error you pasted in the PR thread definitely shows it being included in the h, and that would definitely tend to cause this problem I think
1912019-10-12T14:29:57 *** Chris_Stewart_5 has quit IRC
1922019-10-12T14:30:29 <provoostenator> Ah, for some reason sendcoinsdialog.h gets away with not having a "class CCoinControl" forward declaration.
1932019-10-12T14:30:44 <provoostenator> But I can't get away with that in sendcompose.h
1942019-10-12T14:30:56 <provoostenator> Indirect include mysteries ftw
1952019-10-12T14:33:45 <provoostenator> Or maybe because I'm using it with Q_SIGNALS
1962019-10-12T14:34:59 <provoostenator> I can see how that becomes a mess; the .ui and _moc wallet related files are not seperated.
1972019-10-12T14:35:25 *** jkczyz has joined #bitcoin-core-dev
1982019-10-12T14:35:26 <provoostenator> So I can either do something about that, or find a way to pass fewer things around (or both).
1992019-10-12T14:36:22 <gwillen> the problem is the addition of gotoSign, which takes a CCCoinControl
2002019-10-12T14:36:39 <provoostenator> Exactly.
2012019-10-12T14:36:41 <gwillen> because it takes the object by value, callers need to know the size of a CCoinControl so they need the full definition,
2022019-10-12T14:37:06 <gwillen> hmm
2032019-10-12T14:37:39 <provoostenator> I probably want to keep CCoinControl (and the transaction) on SendDialog, instead of passing it around between the tabs.
2042019-10-12T14:37:54 <provoostenator> Just need to make sure to do that without introducing circular references
2052019-10-12T14:38:17 <gwillen> ok so you literally just stuff it into a shared_ptr when it gets there
2062019-10-12T14:38:22 <gwillen> so you could pass it as a shared_ptr instead
2072019-10-12T14:38:52 <gwillen> shared_ptr<CCoinControl> should not need the include
2082019-10-12T14:39:16 <provoostenator> That's what I did before actually and it ended up not updating it between tabs.
2092019-10-12T14:39:20 <gwillen> hmmmm
2102019-10-12T14:39:39 *** jkczyz has quit IRC
2112019-10-12T14:39:47 <provoostenator> So it probably copied it somewhere accidentally.
2122019-10-12T14:40:04 <gwillen> *nod*, that makes sense
2132019-10-12T14:40:10 <provoostenator> pointers are not my strong suite
2142019-10-12T14:40:26 <gwillen> I mean right now you are deliberately just copying it, do you copy it back later, in order for it to update?
2152019-10-12T14:40:39 <gwillen> I agree that refactoring it upwards so you don't have to do that makes the most sense
2162019-10-12T14:40:46 <provoostenator> Well, the way it is right now is tjust the first thing I got working :-)
2172019-10-12T14:41:16 <provoostenator> But the shared pointer approach probably makes more sense. I can try that again.
2182019-10-12T14:41:46 <gwillen> I mean to be clear, I wasn't actually suggesting going back to sharing it rather than copying, I was just suggesting a hack
2192019-10-12T14:42:00 <gwillen> which is, make the interface to gotoSign take a shared_ptr<CCoinControl>
2202019-10-12T14:42:03 <gwillen> to fix the immediate build issue
2212019-10-12T14:42:33 <provoostenator> Well, I don't like that the Compose tab passes a transaction to the SendDialog, which then passes it to the SignTab, which then passes it back, etc
2222019-10-12T14:42:50 <gwillen> yeah, *nod*
2232019-10-12T14:43:11 <gwillen> if the signtab has the senddialog as its parent, it should be easy not to have to do that
2242019-10-12T14:43:16 <provoostenator> Hacks beget nacks.
2252019-10-12T14:43:23 <gwillen> heh, yeah
2262019-10-12T14:44:41 <provoostenator> The sign tab (sendsign.h) has a constructor with a *parent argument, currently QWidget.
2272019-10-12T14:44:46 <provoostenator> The sign tab (sendsign.h) has a constructor with a *parent argument, currently QWidget.
2282019-10-12T14:45:20 <provoostenator> Wouldn't I create a circular reference if I change that to a SendDialog?
2292019-10-12T14:45:32 <gwillen> SendDialog is a type of QWidget
2302019-10-12T14:46:03 <gwillen> you would just pass "this" as the second argument to the SendSign constructor when constructing it in senddialog.cpp
2312019-10-12T14:46:14 <gwillen> right now you're not giving it a parent at all, it's just defaulting to null (it appears)
2322019-10-12T14:46:28 <provoostenator> I know, but SendDialog.cpp includes signcompose.h
2332019-10-12T14:46:50 <provoostenator> Circular includes I should say
2342019-10-12T14:46:58 <gwillen> you don't need to change signcompose.h in order to do this
2352019-10-12T14:47:06 <gwillen> so there's no circular include
2362019-10-12T14:48:12 <gwillen> (I don't know for sure that setting the parent is the right QT thing to do here, but I feel like it probably is)
2372019-10-12T14:48:23 <provoostenator> But QWidget won't have a coinControl property
2382019-10-12T14:49:15 <gwillen> hmmmmmmm that's true. maybe that's not the right way to do this.
2392019-10-12T14:49:28 <provoostenator> Maybe some abstract SignTab class?
2402019-10-12T14:49:33 <gwillen> (it might still be the case that you should set the parent relationship, but it may not help with this issue)
2412019-10-12T14:50:00 <gwillen> actually you could just give SignTab a pointer directly to SendDialog
2422019-10-12T14:50:12 <gwillen> that _still_ will not create a circular include as long as it's a pointer (which it would have to be anyway) and not a copy
2432019-10-12T14:50:12 <provoostenator> I'm probably thinking too much in ObjectiveC terms
2442019-10-12T14:50:33 <gwillen> you can then get away with forward declaring "class SendDialog;" and not including anything
2452019-10-12T14:51:11 <gwillen> er, reverse that
2462019-10-12T14:51:18 <gwillen> give a SendDialog pointer to SignTab
2472019-10-12T14:51:27 <provoostenator> I think I'll try passing a CCoinControl shared pointer to the tab constructor(s) again though, that seems more straight forward
2482019-10-12T14:51:39 <gwillen> *nods*
2492019-10-12T14:52:05 <gwillen> assuming that the SendDialog always outlives the SignTab, a bare pointer would also work
2502019-10-12T14:52:20 <gwillen> I don't know if that's considered acceptable form
2512019-10-12T14:53:01 <provoostenator> SendDialog creates the tabs when it's constructed, and they live until the end of the app.
2522019-10-12T14:53:29 <provoostenator> But I hear shared pointers (or references?) are safer.
2532019-10-12T14:53:39 <gwillen> shared pointers are definitely the safest option
2542019-10-12T15:00:02 *** omega8cc has quit IRC
2552019-10-12T15:02:17 *** lowentropy has quit IRC
2562019-10-12T15:02:31 *** lowentropy has joined #bitcoin-core-dev
2572019-10-12T15:05:28 *** Francisco_ has joined #bitcoin-core-dev
2582019-10-12T15:09:15 *** tsujp has quit IRC
2592019-10-12T15:09:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2602019-10-12T15:12:10 *** michaelfolkson has joined #bitcoin-core-dev
2612019-10-12T15:15:46 *** XhmikosR1 has joined #bitcoin-core-dev
2622019-10-12T15:16:32 *** tsujp has joined #bitcoin-core-dev
2632019-10-12T15:23:09 <provoostenator> Maybe even a unique_ptr, since only 1 tab should be doing anything at any given moment.
2642019-10-12T15:24:52 *** goatpig has joined #bitcoin-core-dev
2652019-10-12T15:30:27 *** davterra has joined #bitcoin-core-dev
2662019-10-12T15:33:17 *** promag has quit IRC
2672019-10-12T15:35:57 *** tsujp has quit IRC
2682019-10-12T15:36:25 *** tsujp_ has joined #bitcoin-core-dev
2692019-10-12T15:38:01 *** Guyver2 has joined #bitcoin-core-dev
2702019-10-12T15:56:09 *** goatpig has quit IRC
2712019-10-12T16:03:55 *** alko has quit IRC
2722019-10-12T16:05:11 *** davterra has quit IRC
2732019-10-12T16:10:16 *** promag has joined #bitcoin-core-dev
2742019-10-12T16:13:04 *** davterra has joined #bitcoin-core-dev
2752019-10-12T16:15:31 *** Evel-Knievel has joined #bitcoin-core-dev
2762019-10-12T16:23:26 *** promag has quit IRC
2772019-10-12T16:30:34 *** alko89 has joined #bitcoin-core-dev
2782019-10-12T16:36:28 *** jkczyz has joined #bitcoin-core-dev
2792019-10-12T16:37:04 *** Deacyde has joined #bitcoin-core-dev
2802019-10-12T16:40:51 *** jkczyz has quit IRC
2812019-10-12T16:45:09 *** goatpig has joined #bitcoin-core-dev
2822019-10-12T16:46:10 *** kristapsk has quit IRC
2832019-10-12T16:52:02 *** promag has joined #bitcoin-core-dev
2842019-10-12T16:54:35 *** nosss2 has joined #bitcoin-core-dev
2852019-10-12T16:56:17 *** promag has quit IRC
2862019-10-12T16:58:41 *** jkczyz has joined #bitcoin-core-dev
2872019-10-12T17:05:17 *** kristapsk has joined #bitcoin-core-dev
2882019-10-12T17:11:55 *** drbrule has quit IRC
2892019-10-12T17:12:31 *** jb55 has quit IRC
2902019-10-12T17:13:05 *** jb55 has joined #bitcoin-core-dev
2912019-10-12T17:14:03 *** Chris_Stewart_5 has quit IRC
2922019-10-12T17:34:23 *** davterra has quit IRC
2932019-10-12T17:34:46 *** jonatack has joined #bitcoin-core-dev
2942019-10-12T17:53:55 *** jarthur has joined #bitcoin-core-dev
2952019-10-12T17:55:30 *** goatpig has quit IRC
2962019-10-12T18:00:02 *** XhmikosR1 has quit IRC
2972019-10-12T18:04:03 *** Deacyde has quit IRC
2982019-10-12T18:10:01 *** davterra has joined #bitcoin-core-dev
2992019-10-12T18:17:34 *** jdsharp has joined #bitcoin-core-dev
3002019-10-12T18:32:55 *** promag has joined #bitcoin-core-dev
3012019-10-12T18:35:28 *** lightlike has joined #bitcoin-core-dev
3022019-10-12T18:37:42 *** promag has quit IRC
3032019-10-12T18:38:34 *** nosss2 has quit IRC
3042019-10-12T18:39:02 *** nosss2 has joined #bitcoin-core-dev
3052019-10-12T18:51:17 *** Emcy has quit IRC
3062019-10-12T18:55:15 *** goatpig has joined #bitcoin-core-dev
3072019-10-12T19:04:49 *** nickler_ has joined #bitcoin-core-dev
3082019-10-12T19:05:31 *** meshcollider has joined #bitcoin-core-dev
3092019-10-12T19:05:41 *** nickler has quit IRC
3102019-10-12T19:05:52 *** nickler has joined #bitcoin-core-dev
3112019-10-12T19:06:56 *** Emcy has joined #bitcoin-core-dev
3122019-10-12T19:12:17 *** jkczyz has quit IRC
3132019-10-12T19:18:19 *** Skirmant has quit IRC
3142019-10-12T19:23:27 <elichai2> Writing a simple tool to create bitcoin keys and to sign+verify messages. now i'm trying to decide if I should add support for `p2wpkh` and `p2shwpkh` for signing and verifying. because AFAIK core doesn't support it. should I? should I add support for core too? or just wait for BIP 322? @instagibbs
3152019-10-12T19:29:01 <provoostenator> elichai2: how is that different from https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki ?
3162019-10-12T19:29:32 <provoostenator> #16440
3172019-10-12T19:29:34 <gribble> https://github.com/bitcoin/bitcoin/issues/16440 | BIP-322: Generic signed message format by kallewoof · Pull Request #16440 · bitcoin/bitcoin · GitHub
3182019-10-12T19:29:49 <elichai2> All I do is assume it's a pay to pubkey hash in the end (meaning I just create a simple bech32 segwit p2wpkh and compare, then wrap it in p2sh and compare)
3192019-10-12T19:29:56 <elichai2> I don't do anything fancy
3202019-10-12T19:30:07 <elichai2> it's not "generic"
3212019-10-12T19:30:30 <provoostenator> I think the initial idea of BIP 322 was not to be fancy :-)
3222019-10-12T19:30:58 <sipa> elichai2: please don't further any message signing except bip322 :)
3232019-10-12T19:31:47 <elichai2> sipa: ok :) it was just too easy in my tool lol. I'll either add a big warning that this isn't supported by core or just remove the whole thing except p2pkh
3242019-10-12T19:32:09 <elichai2> (literally 2 more lines to support the rest lol)
3252019-10-12T19:37:19 <provoostenator> elichai2: there's also this primitive method #16653, shared between Signet and BIP322. Could use some review love.
3262019-10-12T19:37:20 <gribble> https://github.com/bitcoin/bitcoin/issues/16653 | script: add simple signature support (checker/creator) by kallewoof · Pull Request #16653 · bitcoin/bitcoin · GitHub
3272019-10-12T19:39:58 <elichai2> i'll give it a look and if it's in my knwoledge i'll review :)
3282019-10-12T19:40:10 *** Skirmant has joined #bitcoin-core-dev
3292019-10-12T19:44:43 <Bullit> 11782 this piggy drove a would be car VWPOLOHARLEY but was -overdrive 01-08-2019 14:02
3302019-10-12T19:52:40 *** ChanServ sets mode: +o sipa
3312019-10-12T19:52:47 <sipa> Bullit: stop the nonsense
3322019-10-12T19:56:36 *** goatpig has quit IRC
3332019-10-12T20:00:41 *** Emcy_ has joined #bitcoin-core-dev
3342019-10-12T20:02:57 *** Emcy has quit IRC
3352019-10-12T20:04:30 *** jkczyz has joined #bitcoin-core-dev
3362019-10-12T20:08:13 *** promag has joined #bitcoin-core-dev
3372019-10-12T20:10:12 *** jkczyz has quit IRC
3382019-10-12T20:11:40 *** promag has quit IRC
3392019-10-12T20:11:55 *** promag has joined #bitcoin-core-dev
3402019-10-12T20:32:02 *** davterra has quit IRC
3412019-10-12T20:32:43 *** davterra has joined #bitcoin-core-dev
3422019-10-12T20:34:46 *** davterra has joined #bitcoin-core-dev
3432019-10-12T20:35:35 *** davterra has joined #bitcoin-core-dev
3442019-10-12T20:38:13 *** mmgen has quit IRC
3452019-10-12T20:44:10 *** goatpig has joined #bitcoin-core-dev
3462019-10-12T20:46:37 *** davterra has quit IRC
3472019-10-12T20:47:33 *** davterra has joined #bitcoin-core-dev
3482019-10-12T20:56:08 *** bitcoin-git has joined #bitcoin-core-dev
3492019-10-12T20:56:09 <bitcoin-git> [bitcoin] andrewtoth opened pull request #17119: [rpc] Fix broken bitcoin-cli examples (master...example-fixes) https://github.com/bitcoin/bitcoin/pull/17119
3502019-10-12T20:56:10 *** bitcoin-git has left #bitcoin-core-dev
3512019-10-12T21:00:01 *** jdsharp has quit IRC
3522019-10-12T21:00:04 *** jkczyz has joined #bitcoin-core-dev
3532019-10-12T21:05:08 *** jkczyz has quit IRC
3542019-10-12T21:17:37 *** gnrp1 has joined #bitcoin-core-dev
3552019-10-12T21:23:22 *** captjakk has joined #bitcoin-core-dev
3562019-10-12T21:31:00 *** promag has quit IRC
3572019-10-12T21:31:00 *** bitcoin-git has joined #bitcoin-core-dev
3582019-10-12T21:31:00 <bitcoin-git> [bitcoin] promag opened pull request #17120: gui: Fix start timer from non QThread (master...2019-10-fix-timer) https://github.com/bitcoin/bitcoin/pull/17120
3592019-10-12T21:31:04 *** bitcoin-git has left #bitcoin-core-dev
3602019-10-12T21:59:58 *** kristapsk has quit IRC
3612019-10-12T22:00:23 *** kristapsk has joined #bitcoin-core-dev
3622019-10-12T22:03:00 *** jarthur has quit IRC
3632019-10-12T22:19:21 *** Guyver2 has quit IRC
3642019-10-12T22:20:02 *** captjakk has quit IRC
3652019-10-12T22:22:47 *** meshcollider has quit IRC
3662019-10-12T22:37:16 *** jarthur has joined #bitcoin-core-dev
3672019-10-12T22:37:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3682019-10-12T22:39:29 *** meshcollider has joined #bitcoin-core-dev
3692019-10-12T22:44:51 *** Highway61 has quit IRC
3702019-10-12T22:44:51 *** meshcollider has quit IRC
3712019-10-12T22:49:13 *** captjakk has joined #bitcoin-core-dev
3722019-10-12T22:49:47 *** meshcollider has joined #bitcoin-core-dev
3732019-10-12T22:50:20 *** captjakk has quit IRC
3742019-10-12T22:50:56 *** shesek has quit IRC
3752019-10-12T22:56:02 *** goatpig has quit IRC
3762019-10-12T22:57:37 *** Chris_Stewart_5 has quit IRC
3772019-10-12T23:00:28 *** Ox207fffff has quit IRC
3782019-10-12T23:00:47 *** Ox207fffff has joined #bitcoin-core-dev
3792019-10-12T23:00:56 *** jkczyz has joined #bitcoin-core-dev
3802019-10-12T23:00:57 *** meshcollider has quit IRC
3812019-10-12T23:00:57 *** meshcoll- has joined #bitcoin-core-dev
3822019-10-12T23:01:17 *** meshcoll- has left #bitcoin-core-dev
3832019-10-12T23:01:24 *** Ox207fffff has quit IRC
3842019-10-12T23:02:27 *** Ox207fffff has joined #bitcoin-core-dev
3852019-10-12T23:05:36 *** jkczyz has quit IRC
3862019-10-12T23:11:22 *** jkczyz has joined #bitcoin-core-dev
3872019-10-12T23:14:03 *** meshcollider has joined #bitcoin-core-dev
3882019-10-12T23:14:59 *** meshcollider- has joined #bitcoin-core-dev
3892019-10-12T23:15:03 *** meshcollider- has left #bitcoin-core-dev
3902019-10-12T23:15:37 *** jkczyz has quit IRC
3912019-10-12T23:16:36 *** davterra has quit IRC
3922019-10-12T23:17:01 *** davterra has joined #bitcoin-core-dev
3932019-10-12T23:31:36 *** promag has joined #bitcoin-core-dev
3942019-10-12T23:36:20 *** promag has quit IRC
3952019-10-12T23:41:08 *** astro has quit IRC
3962019-10-12T23:44:03 *** astro has joined #bitcoin-core-dev
3972019-10-12T23:44:47 *** goatpig has joined #bitcoin-core-dev
3982019-10-12T23:58:27 *** marcoagner has quit IRC