12019-10-18T00:00:02  *** ski1 has quit IRC
  22019-10-18T00:17:56  *** romtam has joined #bitcoin-core-dev
  32019-10-18T00:23:56  *** bitcoin-git has joined #bitcoin-core-dev
  42019-10-18T00:23:56  <bitcoin-git> [bitcoin] theStack opened pull request #17183: refactor: test/bench: dedup Build{Crediting,Spending}Transaction() (master...20191018-refactor-deduplicate_build_transaction_functions) https://github.com/bitcoin/bitcoin/pull/17183
  52019-10-18T00:23:58  *** bitcoin-git has left #bitcoin-core-dev
  62019-10-18T00:28:10  *** jkczyz has quit IRC
  72019-10-18T00:28:22  *** ddustin has quit IRC
  82019-10-18T00:31:54  *** jkczyz has joined #bitcoin-core-dev
  92019-10-18T00:36:27  *** jkczyz has quit IRC
 102019-10-18T01:00:11  *** lightlike has quit IRC
 112019-10-18T01:22:21  *** emilengler has quit IRC
 122019-10-18T01:25:13  *** morcos has joined #bitcoin-core-dev
 132019-10-18T01:36:51  *** jkczyz has joined #bitcoin-core-dev
 142019-10-18T01:42:29  *** jkczyz has quit IRC
 152019-10-18T01:43:39  *** ddustin has joined #bitcoin-core-dev
 162019-10-18T01:56:18  <achow101> sipa: was it intended that uncompressed pubkeys in segwit are only non-standard? most documentation say it is consensus mandatory, but looking at the code, and testing it, shows otherwise
 172019-10-18T01:56:59  <sipa> achow101: of course it's not intended, but it's the best we could do :)
 182019-10-18T01:57:12  <sipa> if there is documentation saying it's consensus invalid it should be fixed
 192019-10-18T01:57:37  <sipa> it was an afterthought
 202019-10-18T01:58:21  <achow101> why wasn't it consensus enforced?
 212019-10-18T01:58:50  <sipa> because it was too late when we realized it should have been
 222019-10-18T01:59:17  <achow101> ah
 232019-10-18T02:05:40  *** emilengler has joined #bitcoin-core-dev
 242019-10-18T02:07:32  *** felixfoertsch23 has joined #bitcoin-core-dev
 252019-10-18T02:07:50  *** felixfoertsch has quit IRC
 262019-10-18T02:15:36  *** braydonf has quit IRC
 272019-10-18T02:17:30  *** braydonf has joined #bitcoin-core-dev
 282019-10-18T02:18:53  *** spinza has quit IRC
 292019-10-18T02:22:30  *** jkczyz has joined #bitcoin-core-dev
 302019-10-18T02:23:10  *** spinza has joined #bitcoin-core-dev
 312019-10-18T02:24:00  *** braydonf has quit IRC
 322019-10-18T02:25:52  *** braydonf has joined #bitcoin-core-dev
 332019-10-18T02:29:56  *** jkczyz has quit IRC
 342019-10-18T02:47:24  *** Highway61 has joined #bitcoin-core-dev
 352019-10-18T02:48:02  *** arik_ has quit IRC
 362019-10-18T02:50:37  *** jarthur has joined #bitcoin-core-dev
 372019-10-18T03:00:02  *** romtam has quit IRC
 382019-10-18T03:08:20  *** rabidus has quit IRC
 392019-10-18T03:15:04  *** rabidus has joined #bitcoin-core-dev
 402019-10-18T03:17:46  *** directhex1 has joined #bitcoin-core-dev
 412019-10-18T03:28:18  <luke-jr> please reopen #12677
 422019-10-18T03:28:20  <gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
 432019-10-18T04:06:28  *** belcher has quit IRC
 442019-10-18T04:16:20  *** felixfoertsch23 has quit IRC
 452019-10-18T04:16:30  *** felixfoertsch has joined #bitcoin-core-dev
 462019-10-18T04:17:02  *** belcher has joined #bitcoin-core-dev
 472019-10-18T04:19:12  *** Highway61 has quit IRC
 482019-10-18T04:19:34  *** Highway61 has joined #bitcoin-core-dev
 492019-10-18T04:24:20  *** Highway61 has quit IRC
 502019-10-18T04:28:02  *** nosss2 has quit IRC
 512019-10-18T04:29:37  *** nosss2 has joined #bitcoin-core-dev
 522019-10-18T04:34:22  *** nosss2 has quit IRC
 532019-10-18T04:43:30  *** captjakk has quit IRC
 542019-10-18T05:10:56  *** captjakk has joined #bitcoin-core-dev
 552019-10-18T05:29:40  *** jkczyz has joined #bitcoin-core-dev
 562019-10-18T05:31:19  *** Emcy_ has joined #bitcoin-core-dev
 572019-10-18T05:34:32  *** Emcy has quit IRC
 582019-10-18T05:35:50  *** jkczyz has quit IRC
 592019-10-18T05:53:40  *** Emcy has joined #bitcoin-core-dev
 602019-10-18T05:55:05  *** Emcy_ has quit IRC
 612019-10-18T05:59:39  *** Highway61 has joined #bitcoin-core-dev
 622019-10-18T06:00:01  *** directhex1 has quit IRC
 632019-10-18T06:14:15  *** bitcoin-git has joined #bitcoin-core-dev
 642019-10-18T06:14:15  <bitcoin-git> [bitcoin] hebasto opened pull request #17184: util: Filter out macOS process serial number (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17184
 652019-10-18T06:14:16  *** bitcoin-git has left #bitcoin-core-dev
 662019-10-18T06:15:46  *** zyga1 has joined #bitcoin-core-dev
 672019-10-18T07:03:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 682019-10-18T07:03:32  *** captjakk has quit IRC
 692019-10-18T07:08:38  *** promag has quit IRC
 702019-10-18T07:09:10  *** promag has joined #bitcoin-core-dev
 712019-10-18T07:14:18  *** marcoagner has joined #bitcoin-core-dev
 722019-10-18T07:15:40  *** jungly has joined #bitcoin-core-dev
 732019-10-18T07:15:59  *** bitcoin-git has joined #bitcoin-core-dev
 742019-10-18T07:15:59  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4daadce36cfe...b9b58f8f687e
 752019-10-18T07:16:00  <bitcoin-git> bitcoin/master b3b6b6f Ben Carman: gui: don't disable the sync overlay when wallet is disabled
 762019-10-18T07:16:00  <bitcoin-git> bitcoin/master b9b58f8 Jonas Schnelli: Merge #15084: gui: don't disable the sync overlay when wallet is disabled
 772019-10-18T07:16:12  *** bitcoin-git has left #bitcoin-core-dev
 782019-10-18T07:16:17  *** promag has quit IRC
 792019-10-18T07:16:44  *** bitcoin-git has joined #bitcoin-core-dev
 802019-10-18T07:16:44  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15084: gui: don't disable the sync overlay when wallet is disabled (master...sync_overlay_without_wallet) https://github.com/bitcoin/bitcoin/pull/15084
 812019-10-18T07:16:57  *** bitcoin-git has left #bitcoin-core-dev
 822019-10-18T07:26:49  *** jonatack_ has joined #bitcoin-core-dev
 832019-10-18T07:31:14  *** rabidus has quit IRC
 842019-10-18T07:31:39  *** jkczyz has joined #bitcoin-core-dev
 852019-10-18T07:33:14  *** rabidus has joined #bitcoin-core-dev
 862019-10-18T07:34:16  *** Chris_Stewart_5 has quit IRC
 872019-10-18T07:36:44  *** jkczyz has quit IRC
 882019-10-18T07:43:00  *** jonatack_ has quit IRC
 892019-10-18T07:43:28  *** jonatack has joined #bitcoin-core-dev
 902019-10-18T07:51:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 912019-10-18T07:56:53  *** Emcy has quit IRC
 922019-10-18T08:04:18  *** Skirmant has quit IRC
 932019-10-18T08:04:36  *** Skirmant has joined #bitcoin-core-dev
 942019-10-18T08:05:58  *** seeder has joined #bitcoin-core-dev
 952019-10-18T08:09:25  *** promag has joined #bitcoin-core-dev
 962019-10-18T08:09:41  *** Emcy has joined #bitcoin-core-dev
 972019-10-18T08:10:37  *** bitcoin-git has joined #bitcoin-core-dev
 982019-10-18T08:10:37  <bitcoin-git> [bitcoin] Danny-Scott opened pull request #17186: gui: Add placeholder text to the sign message field (master...oct-2019-sign-message) https://github.com/bitcoin/bitcoin/pull/17186
 992019-10-18T08:10:39  *** bitcoin-git has left #bitcoin-core-dev
1002019-10-18T08:10:57  *** Skirmant has quit IRC
1012019-10-18T08:11:16  *** Skirmant has joined #bitcoin-core-dev
1022019-10-18T08:24:40  *** JJ3 has joined #bitcoin-core-dev
1032019-10-18T08:32:52  *** marcoagner has quit IRC
1042019-10-18T08:35:17  *** AaronvanW has joined #bitcoin-core-dev
1052019-10-18T08:39:26  *** Chris_Stewart_5 has quit IRC
1062019-10-18T08:40:20  *** jarthur has quit IRC
1072019-10-18T08:41:14  *** Zenton has joined #bitcoin-core-dev
1082019-10-18T08:48:38  <kallewoof> luke-jr: please assign a BIP number to signet
1092019-10-18T08:49:42  <wumpus> ... we could always switch to rusts' process and assign the BIP number based on the PR number ...
1102019-10-18T08:53:27  <kallewoof> wumpus: not all BIPs have PRs though. (and not all BIPs have PRs to bitcoin core)
1112019-10-18T08:53:38  <kallewoof> oh wait, yoyu mean to the bip repo
1122019-10-18T08:53:42  <kallewoof> that kind of makes sense, yeah
1132019-10-18T08:54:05  <wumpus> yes, the BIP repo, yes there will be holes in assignment (there might be editing PRs) but that's not a problem to them
1142019-10-18T08:54:38  *** timothy has joined #bitcoin-core-dev
1152019-10-18T08:55:09  <kallewoof> *nods* sounds fair enough to me. I guess it could become a bit bloated since *everything* will have a BIP number at that point. so even nonsensical stuff will be talked about as BIP 1234 or such. Don't know if that is a big deal, but people tend to remember BIP numbers.
1162019-10-18T08:55:38  <wumpus> I mean, it might be worth consideration if we've reached the level of silliness where assigning numbers by one person is a bottleneck
1172019-10-18T08:56:03  <wumpus> well, things that don't get merged don't get a BIP number
1182019-10-18T08:56:13  <wumpus> the list in the repository would still be leading
1192019-10-18T08:56:48  <kallewoof> Ah, good point
1202019-10-18T08:59:24  *** davterra has quit IRC
1212019-10-18T09:00:02  *** zyga1 has quit IRC
1222019-10-18T09:05:47  *** alko89 has quit IRC
1232019-10-18T09:17:40  *** tlyu has joined #bitcoin-core-dev
1242019-10-18T09:30:50  *** setpill has joined #bitcoin-core-dev
1252019-10-18T09:32:40  *** jkczyz has joined #bitcoin-core-dev
1262019-10-18T09:32:59  *** Emcy_ has joined #bitcoin-core-dev
1272019-10-18T09:34:43  *** davterra has joined #bitcoin-core-dev
1282019-10-18T09:35:41  *** Emcy has quit IRC
1292019-10-18T09:37:15  *** jkczyz has quit IRC
1302019-10-18T09:38:29  *** promag has quit IRC
1312019-10-18T09:44:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1322019-10-18T09:44:27  *** EagleTM has quit IRC
1332019-10-18T09:46:14  *** Hahaboy has joined #bitcoin-core-dev
1342019-10-18T09:48:27  *** jonatack has quit IRC
1352019-10-18T09:48:39  *** Hahaboy has quit IRC
1362019-10-18T09:59:14  *** promag has joined #bitcoin-core-dev
1372019-10-18T10:04:00  *** promag has quit IRC
1382019-10-18T10:06:41  *** promag has joined #bitcoin-core-dev
1392019-10-18T10:12:31  *** bitcoin-git has joined #bitcoin-core-dev
1402019-10-18T10:12:31  <bitcoin-git> [bitcoin] meshcollider reopened pull request #12677: RPC: Add ancestor{count,size,fees} to listunspent output (master...listunspent_ancestorinfo) https://github.com/bitcoin/bitcoin/pull/12677
1412019-10-18T10:12:32  *** bitcoin-git has left #bitcoin-core-dev
1422019-10-18T10:12:45  <meshcollider> luke-jr: ^
1432019-10-18T10:15:31  *** seeder has quit IRC
1442019-10-18T10:41:45  *** Chris_Stewart_5 has quit IRC
1452019-10-18T10:47:18  *** JJ3 has quit IRC
1462019-10-18T11:02:36  *** willcl_ark has joined #bitcoin-core-dev
1472019-10-18T11:14:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1482019-10-18T11:22:09  *** promag has quit IRC
1492019-10-18T11:23:17  *** jonatack has joined #bitcoin-core-dev
1502019-10-18T11:33:33  *** jkczyz has joined #bitcoin-core-dev
1512019-10-18T11:34:13  *** JJ has joined #bitcoin-core-dev
1522019-10-18T11:38:03  *** jkczyz has quit IRC
1532019-10-18T11:41:39  *** Sentineo has quit IRC
1542019-10-18T11:48:12  *** AaronvanW has quit IRC
1552019-10-18T12:00:01  *** tlyu has quit IRC
1562019-10-18T12:03:01  *** Chris_Stewart_5 has quit IRC
1572019-10-18T12:10:16  *** EagleTM has joined #bitcoin-core-dev
1582019-10-18T12:15:14  *** bitcoin-git has joined #bitcoin-core-dev
1592019-10-18T12:15:14  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9b58f8f687e...f2a094884d98
1602019-10-18T12:15:15  <bitcoin-git> bitcoin/master 7005d6a Danny-Scott: gui: Add placeholder text to the sign message field
1612019-10-18T12:15:15  <bitcoin-git> bitcoin/master f2a0948 fanquake: Merge #17186: gui: Add placeholder text to the sign message field
1622019-10-18T12:15:17  *** bitcoin-git has left #bitcoin-core-dev
1632019-10-18T12:15:34  *** bitcoin-git has joined #bitcoin-core-dev
1642019-10-18T12:15:34  <bitcoin-git> [bitcoin] fanquake merged pull request #17186: gui: Add placeholder text to the sign message field (master...oct-2019-sign-message) https://github.com/bitcoin/bitcoin/pull/17186
1652019-10-18T12:15:35  *** bitcoin-git has left #bitcoin-core-dev
1662019-10-18T12:17:50  *** designwish has quit IRC
1672019-10-18T12:17:53  *** porygon2 has joined #bitcoin-core-dev
1682019-10-18T12:17:55  *** votesmith has quit IRC
1692019-10-18T12:19:26  *** votesmith has joined #bitcoin-core-dev
1702019-10-18T12:23:28  *** AaronvanW has joined #bitcoin-core-dev
1712019-10-18T12:24:02  *** designwish has joined #bitcoin-core-dev
1722019-10-18T12:31:32  *** m1rror8955363887 has quit IRC
1732019-10-18T12:32:09  *** m1rror8955363887 has joined #bitcoin-core-dev
1742019-10-18T12:33:44  *** Aaronvan_ has joined #bitcoin-core-dev
1752019-10-18T12:36:47  *** m1rror8955363887 has quit IRC
1762019-10-18T12:37:04  *** AaronvanW has quit IRC
1772019-10-18T12:37:23  *** m1rror8955363887 has joined #bitcoin-core-dev
1782019-10-18T12:38:02  *** Aaronvan_ has quit IRC
1792019-10-18T12:40:54  *** votesmith has quit IRC
1802019-10-18T12:49:11  *** bitcoin-git has joined #bitcoin-core-dev
1812019-10-18T12:49:12  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17183: refactor: test/bench: dedup Build{Crediting,Spending}Transaction() (master...20191018-refactor-deduplicate_build_transaction_functions) https://github.com/bitcoin/bitcoin/pull/17183
1822019-10-18T12:49:13  *** bitcoin-git has left #bitcoin-core-dev
1832019-10-18T12:49:31  *** bitcoin-git has joined #bitcoin-core-dev
1842019-10-18T12:49:32  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17183: refactor: test/bench: dedup Build{Crediting,Spending}Transaction() (master...20191018-refactor-deduplicate_build_transaction_functions) https://github.com/bitcoin/bitcoin/pull/17183
1852019-10-18T12:49:44  *** bitcoin-git has left #bitcoin-core-dev
1862019-10-18T12:55:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1872019-10-18T13:00:12  *** designwish has quit IRC
1882019-10-18T13:03:24  *** braydonf has quit IRC
1892019-10-18T13:04:11  *** braydonf has joined #bitcoin-core-dev
1902019-10-18T13:04:59  *** designwish has joined #bitcoin-core-dev
1912019-10-18T13:08:15  *** votesmith has joined #bitcoin-core-dev
1922019-10-18T13:15:47  *** JJ has quit IRC
1932019-10-18T13:20:14  *** pinheadmz_ has joined #bitcoin-core-dev
1942019-10-18T13:23:08  *** pinheadmz has quit IRC
1952019-10-18T13:23:08  *** pinheadmz_ is now known as pinheadmz
1962019-10-18T13:24:01  *** rh0nj has quit IRC
1972019-10-18T13:25:08  *** rh0nj has joined #bitcoin-core-dev
1982019-10-18T13:31:56  *** JJ54 has joined #bitcoin-core-dev
1992019-10-18T13:32:50  *** setpill has quit IRC
2002019-10-18T13:33:57  *** Chris_Stewart_5 has quit IRC
2012019-10-18T13:34:20  *** jkczyz has joined #bitcoin-core-dev
2022019-10-18T13:39:05  *** jkczyz has quit IRC
2032019-10-18T13:47:14  *** rabidus has quit IRC
2042019-10-18T13:49:24  *** rabidus has joined #bitcoin-core-dev
2052019-10-18T13:59:39  *** bitcoin-git has joined #bitcoin-core-dev
2062019-10-18T13:59:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f2a094884d98...0ff7cd7d0c07
2072019-10-18T13:59:41  <bitcoin-git> bitcoin/master e65e61c Pieter Wuille: Add some general std::vector utility functions
2082019-10-18T13:59:43  <bitcoin-git> bitcoin/master 7d8d3e6 Pieter Wuille: Add tests for util/vector.h's Cat and Vector
2092019-10-18T13:59:43  <bitcoin-git> bitcoin/master 0ff7cd7 MarcoFalke: Merge #16889: Add some general std::vector utility functions
2102019-10-18T13:59:51  *** bitcoin-git has left #bitcoin-core-dev
2112019-10-18T14:00:09  *** bitcoin-git has joined #bitcoin-core-dev
2122019-10-18T14:00:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16889: Add some general std::vector utility functions (master...210909_vectorutil) https://github.com/bitcoin/bitcoin/pull/16889
2132019-10-18T14:00:10  *** bitcoin-git has left #bitcoin-core-dev
2142019-10-18T14:01:12  *** Skirmant has quit IRC
2152019-10-18T14:01:41  *** Skirmant has joined #bitcoin-core-dev
2162019-10-18T14:15:50  *** Guyver2 has joined #bitcoin-core-dev
2172019-10-18T14:19:43  *** JJ54 has quit IRC
2182019-10-18T14:25:44  *** Emcy_ has quit IRC
2192019-10-18T14:43:13  *** jonatack has quit IRC
2202019-10-18T14:45:29  *** bitcoin-git has joined #bitcoin-core-dev
2212019-10-18T14:45:29  <bitcoin-git> [bitcoin] ViktorBohu opened pull request #17189: gui: Improved German translations of Bitcoin Core (master...master) https://github.com/bitcoin/bitcoin/pull/17189
2222019-10-18T14:45:30  *** bitcoin-git has left #bitcoin-core-dev
2232019-10-18T14:46:24  *** bitcoin-git has joined #bitcoin-core-dev
2242019-10-18T14:46:24  <bitcoin-git> [bitcoin] fanquake closed pull request #17189: gui: Improved German translations of Bitcoin Core (master...master) https://github.com/bitcoin/bitcoin/pull/17189
2252019-10-18T14:46:25  *** bitcoin-git has left #bitcoin-core-dev
2262019-10-18T15:00:01  *** porygon2 has quit IRC
2272019-10-18T15:03:09  *** millerti has joined #bitcoin-core-dev
2282019-10-18T15:13:41  *** captjakk has joined #bitcoin-core-dev
2292019-10-18T15:18:10  *** Highway61 has quit IRC
2302019-10-18T15:21:39  *** rabidus has quit IRC
2312019-10-18T15:25:11  *** jkczyz has joined #bitcoin-core-dev
2322019-10-18T15:29:07  *** rabidus has joined #bitcoin-core-dev
2332019-10-18T15:29:46  *** jkczyz has quit IRC
2342019-10-18T15:35:15  *** drbrule has joined #bitcoin-core-dev
2352019-10-18T15:36:37  *** davterra has quit IRC
2362019-10-18T15:43:51  *** Emcy has joined #bitcoin-core-dev
2372019-10-18T15:48:08  *** Zenton has quit IRC
2382019-10-18T15:48:49  *** Brukhar has joined #bitcoin-core-dev
2392019-10-18T15:50:07  *** mdunnio has joined #bitcoin-core-dev
2402019-10-18T16:00:40  *** mdunnio has quit IRC
2412019-10-18T16:03:40  *** mdunnio has joined #bitcoin-core-dev
2422019-10-18T16:11:02  *** jb551 has quit IRC
2432019-10-18T16:11:02  *** sipa has quit IRC
2442019-10-18T16:11:18  *** sipa has joined #bitcoin-core-dev
2452019-10-18T16:12:06  *** jb551 has joined #bitcoin-core-dev
2462019-10-18T16:12:36  *** davterra has joined #bitcoin-core-dev
2472019-10-18T16:14:34  *** mdunnio has quit IRC
2482019-10-18T16:15:47  *** mdunnio has joined #bitcoin-core-dev
2492019-10-18T16:25:43  *** captjakk has quit IRC
2502019-10-18T16:27:28  *** jkczyz has joined #bitcoin-core-dev
2512019-10-18T16:27:43  *** owowo has joined #bitcoin-core-dev
2522019-10-18T16:27:51  *** captjakk has joined #bitcoin-core-dev
2532019-10-18T16:30:26  *** jungly has quit IRC
2542019-10-18T16:30:27  *** alko89 has joined #bitcoin-core-dev
2552019-10-18T16:30:40  *** justanotheruser has quit IRC
2562019-10-18T16:33:09  *** mmgen has joined #bitcoin-core-dev
2572019-10-18T16:36:40  *** Highway61 has joined #bitcoin-core-dev
2582019-10-18T16:42:16  *** mdunnio has quit IRC
2592019-10-18T16:45:49  *** justanotheruser has joined #bitcoin-core-dev
2602019-10-18T16:46:12  *** captjakk has quit IRC
2612019-10-18T16:46:31  *** captjakk has joined #bitcoin-core-dev
2622019-10-18T16:47:00  *** captjakk has quit IRC
2632019-10-18T16:47:18  *** captjakk has joined #bitcoin-core-dev
2642019-10-18T16:48:06  *** captjakk has joined #bitcoin-core-dev
2652019-10-18T16:48:53  *** captjakk has joined #bitcoin-core-dev
2662019-10-18T16:49:42  *** captjakk has joined #bitcoin-core-dev
2672019-10-18T16:50:36  *** braydonf has quit IRC
2682019-10-18T16:51:40  *** braydonf has joined #bitcoin-core-dev
2692019-10-18T16:54:27  *** jkczyz has quit IRC
2702019-10-18T17:02:25  *** jkczyz has joined #bitcoin-core-dev
2712019-10-18T17:11:54  *** pinheadmz_ has joined #bitcoin-core-dev
2722019-10-18T17:15:04  *** pinheadmz has quit IRC
2732019-10-18T17:15:04  *** pinheadmz__ has joined #bitcoin-core-dev
2742019-10-18T17:16:12  *** mdunnio has joined #bitcoin-core-dev
2752019-10-18T17:17:39  *** pinheadmz_ has quit IRC
2762019-10-18T17:21:05  *** AaronvanW has joined #bitcoin-core-dev
2772019-10-18T17:24:41  *** cryptoIndio has joined #bitcoin-core-dev
2782019-10-18T17:27:51  *** laptop500 has joined #bitcoin-core-dev
2792019-10-18T17:28:50  *** m1rror8955363887 has quit IRC
2802019-10-18T17:29:25  *** m1rror8955363887 has joined #bitcoin-core-dev
2812019-10-18T17:31:25  *** mdunnio has quit IRC
2822019-10-18T17:31:41  *** mdunnio has joined #bitcoin-core-dev
2832019-10-18T17:32:57  *** jarthur has joined #bitcoin-core-dev
2842019-10-18T17:33:15  *** jonatack has joined #bitcoin-core-dev
2852019-10-18T17:33:33  *** laptop500 has quit IRC
2862019-10-18T17:33:50  *** laptop500 has joined #bitcoin-core-dev
2872019-10-18T17:35:26  *** hebasto_ has joined #bitcoin-core-dev
2882019-10-18T17:39:21  *** arik_ has joined #bitcoin-core-dev
2892019-10-18T17:41:28  *** IGHOR has quit IRC
2902019-10-18T17:42:52  *** hebasto_ has quit IRC
2912019-10-18T17:42:56  *** timothy has quit IRC
2922019-10-18T17:43:34  *** AaronvanW has quit IRC
2932019-10-18T17:43:45  *** IGHOR has joined #bitcoin-core-dev
2942019-10-18T17:43:51  *** alko89 has quit IRC
2952019-10-18T17:44:10  *** jkczyz has quit IRC
2962019-10-18T17:46:44  *** jkczyz has joined #bitcoin-core-dev
2972019-10-18T17:49:21  *** ddustin has quit IRC
2982019-10-18T17:50:11  *** hebasto_ has joined #bitcoin-core-dev
2992019-10-18T17:55:20  *** CubicEarth has quit IRC
3002019-10-18T17:55:28  *** hebasto has quit IRC
3012019-10-18T17:58:18  *** CubicEarth has joined #bitcoin-core-dev
3022019-10-18T18:00:01  *** Brukhar has quit IRC
3032019-10-18T18:00:44  *** jarthur has quit IRC
3042019-10-18T18:01:13  *** jarthur has joined #bitcoin-core-dev
3052019-10-18T18:02:02  *** jarthur has joined #bitcoin-core-dev
3062019-10-18T18:05:08  *** laptop500 has quit IRC
3072019-10-18T18:06:48  *** Victor_sueca has joined #bitcoin-core-dev
3082019-10-18T18:07:09  *** Victorsueca has quit IRC
3092019-10-18T18:10:42  *** jarthur_ has joined #bitcoin-core-dev
3102019-10-18T18:11:07  *** jarthur has quit IRC
3112019-10-18T18:18:39  *** Zenton has joined #bitcoin-core-dev
3122019-10-18T18:24:12  *** bitcoin-git has joined #bitcoin-core-dev
3132019-10-18T18:24:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ff7cd7d0c07...ddc3cf26ff12
3142019-10-18T18:24:14  <bitcoin-git> bitcoin/master cc3b528 fanquake: gui: remove OpenSSL PRNG seeding (Windows, Qt only)
3152019-10-18T18:24:14  <bitcoin-git> bitcoin/master ddc3cf2 fanquake: Merge #17151: gui: remove OpenSSL PRNG seeding (Windows, Qt only)
3162019-10-18T18:24:16  *** bitcoin-git has left #bitcoin-core-dev
3172019-10-18T18:24:31  *** bitcoin-git has joined #bitcoin-core-dev
3182019-10-18T18:24:32  <bitcoin-git> [bitcoin] fanquake merged pull request #17151: gui: remove OpenSSL PRNG seeding (Windows, Qt only) (master...windows_qt_openssl_seeding) https://github.com/bitcoin/bitcoin/pull/17151
3192019-10-18T18:24:33  *** bitcoin-git has left #bitcoin-core-dev
3202019-10-18T18:24:52  *** mdunnio has quit IRC
3212019-10-18T18:29:51  *** bitcoin-git has joined #bitcoin-core-dev
3222019-10-18T18:29:52  <bitcoin-git> [bitcoin] fanquake opened pull request #17191: random: remove call to RAND_screen() (Windows only) (master...remove_openssl_rand_screen) https://github.com/bitcoin/bitcoin/pull/17191
3232019-10-18T18:29:53  *** bitcoin-git has left #bitcoin-core-dev
3242019-10-18T18:31:30  *** mdunnio has joined #bitcoin-core-dev
3252019-10-18T18:33:25  *** laptop500 has joined #bitcoin-core-dev
3262019-10-18T18:38:01  *** zonEEE has joined #bitcoin-core-dev
3272019-10-18T18:45:55  *** cryptoIndio has quit IRC
3282019-10-18T18:47:26  *** Jayflux has joined #bitcoin-core-dev
3292019-10-18T18:48:58  <jeremyrubin> So I've been doing  a bit of work to clean up IsTrusted -- one interesting point is that we mark something as Trusted if it has a single confirmation. Should we make confirmations user-configurable there?
3302019-10-18T18:51:44  *** bitcoin-git has joined #bitcoin-core-dev
3312019-10-18T18:51:44  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17192: util: Add CHECK_NONFATAL and use it in src/rpc (master...1910-utilCHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17192
3322019-10-18T18:51:56  *** bitcoin-git has left #bitcoin-core-dev
3332019-10-18T18:54:47  *** laptop500 has quit IRC
3342019-10-18T18:55:05  *** laptop500 has joined #bitcoin-core-dev
3352019-10-18T18:57:07  *** Highway61 has quit IRC
3362019-10-18T19:02:03  *** laptop500 has quit IRC
3372019-10-18T19:02:56  <gleb> jeremyrubin: Well, there is a fundamental difference between 0-conf and 1-conf. A double-spend can replace a 0-conf, while replacing 1-conf requires a reorg (as well as 6-conf).
3382019-10-18T19:03:37  <jeremyrubin> I guess that's true; gives an opportunity for firing off whatever wallet code
3392019-10-18T19:03:39  <gleb> I'm a fan of looking at the tx amount before choosing what's safe, so not sure encouraging a single policy (what's trusted) is a good idea.
3402019-10-18T19:04:25  *** promag has joined #bitcoin-core-dev
3412019-10-18T19:04:36  <jeremyrubin> Well, we could have an option for a lookup table kind of deal to check amount for trustworthiness or something
3422019-10-18T19:05:11  <jeremyrubin> (sounds a bit extra, but I think it would make the wallet code a bit better to support not spending from low-conf txs)
3432019-10-18T19:06:08  <gleb> I would support this, but I have no idea about our wallet, and intuitively I feel like a too major change :)
3442019-10-18T19:06:18  <gleb> Maybe worth bringing up at the wallet meeting?
3452019-10-18T19:08:37  *** promag has quit IRC
3462019-10-18T19:10:41  <gleb> jeremyrubin: I believe the next one is next Friday, although there is no info about it on the internets =\ meshcollider
3472019-10-18T19:21:20  *** promag has joined #bitcoin-core-dev
3482019-10-18T19:26:15  *** mdunnio has quit IRC
3492019-10-18T19:27:40  *** mdunnio has joined #bitcoin-core-dev
3502019-10-18T19:53:59  *** jarthur_ has quit IRC
3512019-10-18T19:54:46  *** jarthur has joined #bitcoin-core-dev
3522019-10-18T19:58:50  *** promag has quit IRC
3532019-10-18T20:01:05  *** promag_ has joined #bitcoin-core-dev
3542019-10-18T20:01:37  *** bitcoin-git has joined #bitcoin-core-dev
3552019-10-18T20:01:38  <bitcoin-git> [bitcoin] JITHIKASAGAR123 opened pull request #17193: Data directory upgradation (master...master) https://github.com/bitcoin/bitcoin/pull/17193
3562019-10-18T20:01:39  *** bitcoin-git has left #bitcoin-core-dev
3572019-10-18T20:02:18  *** bitcoin-git has joined #bitcoin-core-dev
3582019-10-18T20:02:18  <bitcoin-git> [bitcoin] fanquake closed pull request #17193: Data directory upgradation (master...master) https://github.com/bitcoin/bitcoin/pull/17193
3592019-10-18T20:02:19  *** bitcoin-git has left #bitcoin-core-dev
3602019-10-18T20:02:56  *** bitcoin-git has joined #bitcoin-core-dev
3612019-10-18T20:02:57  <bitcoin-git> [bitcoin] fanquake reopened pull request #17193: Data directory upgradation (master...master) https://github.com/bitcoin/bitcoin/pull/17193
3622019-10-18T20:02:58  *** bitcoin-git has left #bitcoin-core-dev
3632019-10-18T20:03:53  *** bitcoin-git has joined #bitcoin-core-dev
3642019-10-18T20:03:53  <bitcoin-git> [bitcoin] JITHIKASAGAR123 closed pull request #17193: Data directory upgradation (master...master) https://github.com/bitcoin/bitcoin/pull/17193
3652019-10-18T20:03:54  *** bitcoin-git has left #bitcoin-core-dev
3662019-10-18T20:05:03  *** bitcoin-git has joined #bitcoin-core-dev
3672019-10-18T20:05:03  <bitcoin-git> [bitcoin] naumenkogs closed pull request #17163: p2p: Avoid relaying ADDR messages to SPV clients (master...addr_relay_optimization) https://github.com/bitcoin/bitcoin/pull/17163
3682019-10-18T20:05:04  *** bitcoin-git has left #bitcoin-core-dev
3692019-10-18T20:05:15  *** promag_ has quit IRC
3702019-10-18T20:11:04  *** Highway61 has joined #bitcoin-core-dev
3712019-10-18T20:13:30  *** EagleTM has quit IRC
3722019-10-18T20:15:34  *** bitcoin-git has joined #bitcoin-core-dev
3732019-10-18T20:15:34  <bitcoin-git> [bitcoin] naumenkogs opened pull request #17194: p2p: Avoid forwarding ADDR messages to SPV nodes  (master...addr_relay_optimization) https://github.com/bitcoin/bitcoin/pull/17194
3742019-10-18T20:15:46  *** bitcoin-git has left #bitcoin-core-dev
3752019-10-18T20:17:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3762019-10-18T20:20:21  *** EagleTM has joined #bitcoin-core-dev
3772019-10-18T20:23:57  *** Highway61 has quit IRC
3782019-10-18T20:25:18  <meshcollider> gleb: yep next wallet meeting is on Friday 25th / Saturday 26th depending on your timezone
3792019-10-18T20:28:56  *** Victor_sueca is now known as Victorsueca
3802019-10-18T20:33:27  *** mmgen has quit IRC
3812019-10-18T20:36:50  *** Highway61 has joined #bitcoin-core-dev
3822019-10-18T20:44:03  *** jkczyz has quit IRC
3832019-10-18T20:45:37  *** Highway61 has quit IRC
3842019-10-18T20:51:36  *** jonatack has quit IRC
3852019-10-18T20:53:00  *** captjakk has joined #bitcoin-core-dev
3862019-10-18T20:57:55  *** bitcoin-git has joined #bitcoin-core-dev
3872019-10-18T20:57:56  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddc3cf26ff12...fd3b4e422d68
3882019-10-18T20:57:56  <bitcoin-git> bitcoin/master bcff8e2 fanquake: build: only pass --disable-dependency-tracking to packages that understand...
3892019-10-18T20:57:56  <bitcoin-git> bitcoin/master 1ba49bc fanquake: build: pass --enable-option-checking to applicable packages
3902019-10-18T20:57:57  <bitcoin-git> bitcoin/master fd3b4e4 fanquake: Merge #16949: build: only pass --disable-dependency-tracking to packages t...
3912019-10-18T20:57:58  *** bitcoin-git has left #bitcoin-core-dev
3922019-10-18T20:58:15  *** bitcoin-git has joined #bitcoin-core-dev
3932019-10-18T20:58:16  <bitcoin-git> [bitcoin] fanquake merged pull request #16949: build: only pass --disable-dependency-tracking to packages that understand it (master...no_disable_dependency_tracking) https://github.com/bitcoin/bitcoin/pull/16949
3942019-10-18T20:58:17  *** bitcoin-git has left #bitcoin-core-dev
3952019-10-18T21:00:02  *** Jayflux has quit IRC
3962019-10-18T21:00:25  *** mdunnio has quit IRC
3972019-10-18T21:04:57  *** Chris_Stewart_5 has quit IRC
3982019-10-18T21:07:39  *** Emcy has quit IRC
3992019-10-18T21:10:23  *** mdunnio has joined #bitcoin-core-dev
4002019-10-18T21:15:44  *** mdunnio has quit IRC
4012019-10-18T21:16:03  *** Guyver2 has quit IRC
4022019-10-18T21:16:56  *** jkczyz has joined #bitcoin-core-dev
4032019-10-18T21:17:45  *** gonemad3 has joined #bitcoin-core-dev
4042019-10-18T21:20:35  *** Emcy has joined #bitcoin-core-dev
4052019-10-18T21:20:58  *** mdunnio has joined #bitcoin-core-dev
4062019-10-18T21:21:46  *** Highway61 has joined #bitcoin-core-dev
4072019-10-18T21:25:29  *** mdunnio has quit IRC
4082019-10-18T21:33:39  *** jkczyz has quit IRC
4092019-10-18T21:35:26  *** zonEE has joined #bitcoin-core-dev
4102019-10-18T21:37:31  *** jkczyz has joined #bitcoin-core-dev
4112019-10-18T21:38:57  *** zonEEE has quit IRC
4122019-10-18T21:39:04  *** bitcoin-git has joined #bitcoin-core-dev
4132019-10-18T21:39:04  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd3b4e422d68...b6e34afe9735
4142019-10-18T21:39:05  <bitcoin-git> bitcoin/master b5f0be3 Hennadii Stepanov: util: Filter out macOS process serial number
4152019-10-18T21:39:05  <bitcoin-git> bitcoin/master b6e34af fanquake: Merge #17184: util: Filter out macOS process serial number
4162019-10-18T21:39:07  *** bitcoin-git has left #bitcoin-core-dev
4172019-10-18T21:39:24  *** bitcoin-git has joined #bitcoin-core-dev
4182019-10-18T21:39:24  <bitcoin-git> [bitcoin] fanquake merged pull request #17184: util: Filter out macOS process serial number (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17184
4192019-10-18T21:39:36  *** bitcoin-git has left #bitcoin-core-dev
4202019-10-18T21:40:57  *** owowo has quit IRC
4212019-10-18T21:41:21  *** mdunnio has joined #bitcoin-core-dev
4222019-10-18T21:42:45  *** owowo has joined #bitcoin-core-dev
4232019-10-18T21:45:54  *** mdunnio has quit IRC
4242019-10-18T21:53:03  *** JCrookshank has joined #bitcoin-core-dev
4252019-10-18T21:57:22  <BlueMatt> sipa: why is ecdsa_signature_parse_der_lax copied into src/pubkey? Instead of just building the contrib/ file in src/secp256k1?
4262019-10-18T21:57:38  <BlueMatt> seems awkward to have it there? or it cause its Consensus?
4272019-10-18T21:58:38  *** justanotheruser has quit IRC
4282019-10-18T21:59:05  <sipa> BlueMatt: yes
4292019-10-18T21:59:26  <elichai2> it seems there's a small difference in replacing `sizeof(size_t)` with 4
4302019-10-18T21:59:44  <elichai2> sipa: but all of libsecp is consensus
4312019-10-18T21:59:46  <sipa> the code in secp256k1 is demo that could diverge from the consensus code used in bitcoin
4322019-10-18T22:00:00  <sipa> elichai2: i don't think that should be true for something called "contrib/" :)
4332019-10-18T22:00:41  <elichai2> if the behavior of `secp256k1_ecdsa_verify` changes them it will break consensus, right?
4342019-10-18T22:00:43  <sipa> "consensus" is not a black and white thing; clearly some parts of libc are consensus critical, but nobody would expect the implementation of libc's dns resolver to matter
4352019-10-18T22:01:12  <sipa> elichai2: yes, obviously
4362019-10-18T22:01:34  <elichai2> hmm so because that lax_der includes also "bugs" than it's 100% because and for consensus
4372019-10-18T22:01:50  <sipa> parse failure
4382019-10-18T22:06:59  <sipa> elichai2: trying to understand what you're saying... but the bugs don't have anything to do with it
4392019-10-18T22:07:37  <sipa> it's just that bitcoin's ecdsa signature parsing is obviously consensus critical, and i don't feel that the demo code in libsecp256k1 should be
4402019-10-18T22:10:26  <elichai2> What do you mean by demo code? And yeah, I think I kind of get it, just weird that it's in both of them. Either libsecp is serving it or it's a bitcoin core detail(Altough it will be a breaking change to remove that from libsecp). Just might be false advertising for users(I.e thinking they're using the Bitcoin core consensus function) if these two impl will ever diverge for some reason
4412019-10-18T22:11:32  <sipa> it's a bitcoin core detail
4422019-10-18T22:11:41  <sipa> it is not served by libsecp at all
4432019-10-18T22:11:56  <sipa> there is just documentation code in libsecp for other users of the library to show how to do something like that
4442019-10-18T22:12:02  <sipa> which, for now, happens to be similar
4452019-10-18T22:12:30  <sipa> no it would not be a breaking change to remove it from libsecp
4462019-10-18T22:12:31  <elichai2> It's not part of the autotools?
4472019-10-18T22:12:35  <sipa> grrr
4482019-10-18T22:12:42  <sipa> can you look at what we're talking about?
4492019-10-18T22:13:19  <elichai2> Oh, that's my mistake. I'm sorry I realize now that Andrew compiled that manually in rust-secp. I was sure it's part of libsecp build system because of that
4502019-10-18T22:13:49  <elichai2> (it's provided in rust-secp)
4512019-10-18T22:13:57  <sipa> probably shouldn't be...
4522019-10-18T22:14:30  <BlueMatt> right, I was just making that point :p
4532019-10-18T22:14:32  <elichai2> Yeah, I'll ping Andrew about it. I realize now what you meant by "demo code"
4542019-10-18T22:14:38  <BlueMatt> (are there any sigs in the chain which require it?)
4552019-10-18T22:14:40  <elichai2> Sorry, a bit late lol
4562019-10-18T22:14:52  <sipa> BlueMatt: pre-BIP66, many
4572019-10-18T22:15:15  <BlueMatt> right, so....kinda awkward to remove it since it means you wont be able to parse part of the chain
4582019-10-18T22:15:30  <sipa> a bitcoin consensus implementation obviously needs this
4592019-10-18T22:15:38  <sipa> i don't think libsecp256k1 or bindings to it need it
4602019-10-18T22:15:58  <sipa> maybe we should just remove it from libsecp
4612019-10-18T22:16:23  <BlueMatt> I mean it doesnt have to be a consensus implementation to want to be able to parse signatures into....things
4622019-10-18T22:16:26  <elichai2> I'm with sipa, if someone is implementing a consensus verification in rust they should also implement that part (or copy)
4632019-10-18T22:16:27  *** Victorsueca has quit IRC
4642019-10-18T22:16:42  <BlueMatt> right, well luckily we have libconsensus bindings that just build pubkey.cpp :)
4652019-10-18T22:16:58  <sipa> BlueMatt: sure, but if it's not consensus you can use whatever lax der parser
4662019-10-18T22:17:04  *** justanotheruser has joined #bitcoin-core-dev
4672019-10-18T22:17:09  *** Victorsueca has joined #bitcoin-core-dev
4682019-10-18T22:17:14  <BlueMatt> right
4692019-10-18T22:17:14  <sipa> that possibly accepts way more than what bitcoin historically did
4702019-10-18T22:17:29  <BlueMatt> well "what bitcoin historically did" is itself poorly-defined :)
4712019-10-18T22:17:33  <sipa> yes
4722019-10-18T22:17:40  <sipa> well, certain versions of OpenSSL
4732019-10-18T22:17:44  <BlueMatt> anyway, off topic for this channel.
4742019-10-18T22:17:54  <sipa> which support way more ridiculous deviations from DER
4752019-10-18T22:17:59  <BlueMatt> right
4762019-10-18T22:18:34  <sipa> actually, that code currently in pubkey.cpp isn't actually even trying to support what bitcoin's consensus rules historically did; just something sufficient for the existing chain
4772019-10-18T22:19:03  <BlueMatt> on-topic for this channel: I have a p2p implementation built in rust linking rust-bitcoin's well-fuzzed network message decoder and such to download the chain in a memory-constrained, no-undefined-behavior way inside of bitcoin core :)
4782019-10-18T22:21:10  *** mdunnio has joined #bitcoin-core-dev
4792019-10-18T22:23:59  *** zonEE has quit IRC
4802019-10-18T22:24:19  <elichai2> That's awesome :)
4812019-10-18T22:25:24  <elichai2> How much time overhead is it to pass the blocks through both decoders?just to get a bool true? (cpp and rust)
4822019-10-18T22:25:34  <BlueMatt> lol I havent gotten that far yet :)
4832019-10-18T22:26:11  <BlueMatt> but, I presume its not trivial....probably makes sense to not bother parsing block messages in rust and just handing the bytes over the wall
4842019-10-18T22:31:26  *** bitcoin-git has joined #bitcoin-core-dev
4852019-10-18T22:31:26  <bitcoin-git> [bitcoin] JeremyCrookshank opened pull request #17195: gui: a default send amount value (master...defaultsendamount) https://github.com/bitcoin/bitcoin/pull/17195
4862019-10-18T22:31:27  *** bitcoin-git has left #bitcoin-core-dev
4872019-10-18T22:41:53  *** JeremyCrookshank has joined #bitcoin-core-dev
4882019-10-18T22:44:03  *** JCrookshank has quit IRC
4892019-10-18T22:47:30  *** cryptoIndio has joined #bitcoin-core-dev
4902019-10-18T22:53:57  *** cryptoIndio has quit IRC
4912019-10-18T22:54:17  *** mdunnio has quit IRC
4922019-10-18T22:56:51  *** jarthur has quit IRC
4932019-10-18T22:57:20  *** Bullit has left #bitcoin-core-dev
4942019-10-18T22:58:26  *** pinheadmz has joined #bitcoin-core-dev
4952019-10-18T22:58:44  *** JeremyCrookshank has quit IRC
4962019-10-18T23:01:16  *** pinheadmz__ has quit IRC
4972019-10-18T23:04:17  *** jkczyz has quit IRC
4982019-10-18T23:07:51  *** jkczyz has joined #bitcoin-core-dev
4992019-10-18T23:14:18  *** captjakk has quit IRC
5002019-10-18T23:42:12  *** willcl_ark has quit IRC
5012019-10-18T23:52:02  *** rh0nj has quit IRC
5022019-10-18T23:53:08  *** rh0nj has joined #bitcoin-core-dev
5032019-10-18T23:54:01  *** rh0nj has quit IRC
5042019-10-18T23:57:07  *** rh0nj has joined #bitcoin-core-dev