12019-10-25T00:00:02  *** b_b1 has quit IRC
  22019-10-25T00:13:37  *** Chris_Stewart_5 has quit IRC
  32019-10-25T00:14:45  *** jkczyz has quit IRC
  42019-10-25T00:24:33  *** dviola has joined #bitcoin-core-dev
  52019-10-25T00:37:27  *** jtimon has quit IRC
  62019-10-25T00:39:45  *** ddustin has joined #bitcoin-core-dev
  72019-10-25T00:42:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  82019-10-25T00:48:05  *** flaburgan1 has joined #bitcoin-core-dev
  92019-10-25T00:58:43  *** Chris_Stewart_5 has quit IRC
 102019-10-25T01:00:37  *** cryptoIndio has joined #bitcoin-core-dev
 112019-10-25T01:02:23  <roasbeef> provoostenator: responded elsewhere, but yeh I think the bip should be modified to raise back to 1k to reduce the number of round trips when catching up, the PR on the bip to move from 1k to 100 was merged w/o any comments, iirc bitcoin has settings to limit upload on a per peer basis as well which can kick in, as it's no diff from spamming a perry with getblocks/getdata messages
 122019-10-25T01:09:07  *** dviola has quit IRC
 132019-10-25T01:16:33  *** jamesl22_ has quit IRC
 142019-10-25T01:17:26  *** jamesl22 has joined #bitcoin-core-dev
 152019-10-25T01:17:30  *** Highway62 has joined #bitcoin-core-dev
 162019-10-25T01:18:57  *** Highway61 has quit IRC
 172019-10-25T01:18:58  *** Highway62 is now known as Highway61
 182019-10-25T01:22:00  *** Highway62 has joined #bitcoin-core-dev
 192019-10-25T01:23:14  *** Highway61 has quit IRC
 202019-10-25T01:25:57  *** Highway62 has quit IRC
 212019-10-25T01:29:38  *** cryptoIndio has quit IRC
 222019-10-25T01:48:36  *** Highway61 has joined #bitcoin-core-dev
 232019-10-25T01:53:24  *** Highway61 has quit IRC
 242019-10-25T02:02:43  *** Highway61 has joined #bitcoin-core-dev
 252019-10-25T02:06:50  *** Highway61 has quit IRC
 262019-10-25T02:08:02  *** emilengler has quit IRC
 272019-10-25T02:09:45  *** emilengler has joined #bitcoin-core-dev
 282019-10-25T02:13:11  *** cryptoIndio has joined #bitcoin-core-dev
 292019-10-25T02:25:09  *** ddustin has quit IRC
 302019-10-25T02:27:13  *** ddustin has joined #bitcoin-core-dev
 312019-10-25T02:30:47  *** AaronvanW has quit IRC
 322019-10-25T02:40:13  *** felixfoertsch23 has joined #bitcoin-core-dev
 332019-10-25T02:42:50  *** felixfoertsch has quit IRC
 342019-10-25T02:44:19  *** jkczyz has joined #bitcoin-core-dev
 352019-10-25T02:44:20  *** ddustin has quit IRC
 362019-10-25T02:44:25  *** Highway61 has joined #bitcoin-core-dev
 372019-10-25T02:44:40  *** ddustin has joined #bitcoin-core-dev
 382019-10-25T02:49:01  *** Highway61 has quit IRC
 392019-10-25T02:49:10  *** captjakk has joined #bitcoin-core-dev
 402019-10-25T02:50:02  *** cryptoIndio has quit IRC
 412019-10-25T02:52:05  *** ddustin has joined #bitcoin-core-dev
 422019-10-25T02:56:17  *** ddustin has quit IRC
 432019-10-25T03:00:02  *** flaburgan1 has quit IRC
 442019-10-25T03:12:01  *** koti has joined #bitcoin-core-dev
 452019-10-25T03:17:35  *** dfkt has joined #bitcoin-core-dev
 462019-10-25T03:23:51  *** ddustin has joined #bitcoin-core-dev
 472019-10-25T03:23:57  *** jkczyz has quit IRC
 482019-10-25T03:29:03  *** ddustin has quit IRC
 492019-10-25T03:30:38  *** captjakk has quit IRC
 502019-10-25T03:32:11  *** captjakk has joined #bitcoin-core-dev
 512019-10-25T03:46:45  *** nosss2 has joined #bitcoin-core-dev
 522019-10-25T04:02:54  *** tryphe has quit IRC
 532019-10-25T04:03:19  *** tryphe has joined #bitcoin-core-dev
 542019-10-25T04:03:33  *** koti has quit IRC
 552019-10-25T04:06:32  *** koti has joined #bitcoin-core-dev
 562019-10-25T04:11:46  *** nosss2 has quit IRC
 572019-10-25T04:14:34  *** koti has quit IRC
 582019-10-25T04:31:27  *** koti has joined #bitcoin-core-dev
 592019-10-25T04:31:52  *** Victor_sueca has joined #bitcoin-core-dev
 602019-10-25T04:34:43  *** Victorsueca has quit IRC
 612019-10-25T04:39:34  *** captjakk has quit IRC
 622019-10-25T04:41:51  *** felixfoertsch23 has quit IRC
 632019-10-25T04:42:07  *** felixfoertsch has joined #bitcoin-core-dev
 642019-10-25T04:45:10  *** jkczyz has joined #bitcoin-core-dev
 652019-10-25T04:50:14  *** jkczyz has quit IRC
 662019-10-25T05:02:15  *** cryptoIndio has joined #bitcoin-core-dev
 672019-10-25T05:03:33  *** koti has quit IRC
 682019-10-25T05:05:35  *** koti has joined #bitcoin-core-dev
 692019-10-25T05:07:33  *** cryptoIndio has quit IRC
 702019-10-25T05:18:39  *** roconnor has quit IRC
 712019-10-25T05:26:33  *** koti has quit IRC
 722019-10-25T05:28:14  *** koti has joined #bitcoin-core-dev
 732019-10-25T05:36:36  *** cryptoIndio has joined #bitcoin-core-dev
 742019-10-25T05:38:13  *** spinza has quit IRC
 752019-10-25T05:42:42  *** cryptoIndio has quit IRC
 762019-10-25T05:45:17  *** spinza has joined #bitcoin-core-dev
 772019-10-25T05:59:27  *** Highway61 has joined #bitcoin-core-dev
 782019-10-25T06:00:01  *** dfkt has quit IRC
 792019-10-25T06:03:28  *** kabaum has joined #bitcoin-core-dev
 802019-10-25T06:12:33  *** koti has quit IRC
 812019-10-25T06:15:38  *** koti has joined #bitcoin-core-dev
 822019-10-25T06:17:42  *** gnomus has joined #bitcoin-core-dev
 832019-10-25T06:30:20  *** jkczyz has joined #bitcoin-core-dev
 842019-10-25T06:35:07  *** jkczyz has quit IRC
 852019-10-25T06:37:36  *** felixfoertsch has quit IRC
 862019-10-25T06:37:44  *** felixfoertsch has joined #bitcoin-core-dev
 872019-10-25T06:46:06  *** cryptoIndio has joined #bitcoin-core-dev
 882019-10-25T06:47:29  *** EagleTM has joined #bitcoin-core-dev
 892019-10-25T06:51:24  *** koti has quit IRC
 902019-10-25T06:53:00  *** cryptoIndio has quit IRC
 912019-10-25T07:04:06  *** EagleTM has quit IRC
 922019-10-25T07:17:48  *** marcoagner has joined #bitcoin-core-dev
 932019-10-25T07:26:37  *** ddustin has joined #bitcoin-core-dev
 942019-10-25T07:30:17  *** baldur has quit IRC
 952019-10-25T07:30:54  *** ddustin has quit IRC
 962019-10-25T07:43:50  *** Stasik has joined #bitcoin-core-dev
 972019-10-25T07:44:05  *** Skirmant has quit IRC
 982019-10-25T07:50:24  *** baldur has joined #bitcoin-core-dev
 992019-10-25T07:52:11  *** Stasik has quit IRC
1002019-10-25T08:01:40  *** promag has joined #bitcoin-core-dev
1012019-10-25T08:24:39  *** ppisati has quit IRC
1022019-10-25T08:30:55  *** bitcoin-git has joined #bitcoin-core-dev
1032019-10-25T08:30:56  <bitcoin-git> [bitcoin] Sjors opened pull request #17246: wallet: avoid knapsack when there's no change (master...2019/10/less-knapsack) https://github.com/bitcoin/bitcoin/pull/17246
1042019-10-25T08:30:56  *** bitcoin-git has left #bitcoin-core-dev
1052019-10-25T08:31:12  *** jkczyz has joined #bitcoin-core-dev
1062019-10-25T08:31:20  *** ppisati has joined #bitcoin-core-dev
1072019-10-25T08:35:48  *** jkczyz has quit IRC
1082019-10-25T08:46:12  *** kristapsk has quit IRC
1092019-10-25T08:48:58  *** timothy has joined #bitcoin-core-dev
1102019-10-25T08:49:06  *** Zenton has joined #bitcoin-core-dev
1112019-10-25T08:49:36  *** cryptoIndio has joined #bitcoin-core-dev
1122019-10-25T08:51:30  *** AaronvanW has joined #bitcoin-core-dev
1132019-10-25T08:54:29  *** cryptoIndio has quit IRC
1142019-10-25T09:00:02  *** gnomus has quit IRC
1152019-10-25T09:00:16  *** Aaronvan_ has joined #bitcoin-core-dev
1162019-10-25T09:01:51  *** jonatack has quit IRC
1172019-10-25T09:03:37  *** AaronvanW has quit IRC
1182019-10-25T09:09:56  *** nijynot has joined #bitcoin-core-dev
1192019-10-25T09:27:23  *** Highway61 has quit IRC
1202019-10-25T09:36:25  *** nijynot has quit IRC
1212019-10-25T09:39:50  *** michaelfolkson has joined #bitcoin-core-dev
1222019-10-25T09:42:20  <wumpus> let's try to have some more ACKs on #17165 soon
1232019-10-25T09:42:22  <gribble> https://github.com/bitcoin/bitcoin/issues/17165 | Remove BIP70 support by fanquake · Pull Request #17165 · bitcoin/bitcoin · GitHub
1242019-10-25T09:42:40  <wumpus> (not only concept, please)
1252019-10-25T09:47:43  *** AimHere1 has joined #bitcoin-core-dev
1262019-10-25T09:50:11  *** ddustin has joined #bitcoin-core-dev
1272019-10-25T09:54:28  *** ddustin has quit IRC
1282019-10-25T10:01:31  *** bitcoin-git has joined #bitcoin-core-dev
1292019-10-25T10:01:31  <bitcoin-git> [bitcoin] laanwj closed pull request #15140: test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (master...test_20190110) https://github.com/bitcoin/bitcoin/pull/15140
1302019-10-25T10:01:33  *** bitcoin-git has left #bitcoin-core-dev
1312019-10-25T10:03:36  *** bitcoin-git has joined #bitcoin-core-dev
1322019-10-25T10:03:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fce7c7542234...366753e46e1f
1332019-10-25T10:03:37  <bitcoin-git> bitcoin/master 50037e9 Cory Fields: depends: fix boost mac cross build with clang 9+
1342019-10-25T10:03:38  <bitcoin-git> bitcoin/master 366753e Wladimir J. van der Laan: Merge #17231: depends: fix boost mac cross build with clang 9+
1352019-10-25T10:03:40  *** bitcoin-git has left #bitcoin-core-dev
1362019-10-25T10:03:52  *** jonatack has joined #bitcoin-core-dev
1372019-10-25T10:03:56  *** bitcoin-git has joined #bitcoin-core-dev
1382019-10-25T10:03:56  <bitcoin-git> [bitcoin] laanwj merged pull request #17231: depends: fix boost mac cross build with clang 9+ (master...fix-boost-clang9) https://github.com/bitcoin/bitcoin/pull/17231
1392019-10-25T10:03:57  *** bitcoin-git has left #bitcoin-core-dev
1402019-10-25T10:04:12  *** wullon has quit IRC
1412019-10-25T10:04:49  *** wullon has joined #bitcoin-core-dev
1422019-10-25T10:13:42  *** scopeh has quit IRC
1432019-10-25T10:14:01  *** scopeh has joined #bitcoin-core-dev
1442019-10-25T10:21:55  <wumpus> what was the flag to make bitcoind log the IPs it's trying to connect to again?
1452019-10-25T10:22:39  <wumpus> #17247 is strange, I'm trying to figure out if they're somehow connecting to false peer addresses or that their ISP is resetting bitcoin connections
1462019-10-25T10:22:40  <gribble> https://github.com/bitcoin/bitcoin/issues/17247 | socket recv error Connection reset by peer (104) · Issue #17247 · bitcoin/bitcoin · GitHub
1472019-10-25T10:26:19  <wumpus> looks like they're in China, too
1482019-10-25T10:26:58  <wumpus> might be a censorship issue @ BlueMatt
1492019-10-25T10:29:12  <wumpus> anyone else from China here experiencing similar problems?
1502019-10-25T10:29:40  <wumpus> or another country for that matter
1512019-10-25T10:32:05  *** jkczyz has joined #bitcoin-core-dev
1522019-10-25T10:37:02  *** rh0nj has quit IRC
1532019-10-25T10:37:28  *** jkczyz has quit IRC
1542019-10-25T10:38:07  *** rh0nj has joined #bitcoin-core-dev
1552019-10-25T10:44:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1562019-10-25T10:49:51  *** halseth has joined #bitcoin-core-dev
1572019-10-25T10:50:28  *** cryptoIndio has joined #bitcoin-core-dev
1582019-10-25T10:52:02  *** michaelfolkson has quit IRC
1592019-10-25T10:58:39  *** cryptoIndio has quit IRC
1602019-10-25T11:06:45  *** roconnor has joined #bitcoin-core-dev
1612019-10-25T11:26:10  *** JeremyCrookshank has joined #bitcoin-core-dev
1622019-10-25T11:34:50  *** cryptoIndio has joined #bitcoin-core-dev
1632019-10-25T11:40:59  *** cryptoIndio has quit IRC
1642019-10-25T11:48:09  *** bitcoin-git has joined #bitcoin-core-dev
1652019-10-25T11:48:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/366753e46e1f...90ed98ae9a2a
1662019-10-25T11:48:10  <bitcoin-git> bitcoin/master fa92813 MarcoFalke: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove...
1672019-10-25T11:48:10  <bitcoin-git> bitcoin/master 90ed98a Wladimir J. van der Laan: Merge #17080: consensus: Explain why fCheckDuplicateInputs can not be skip...
1682019-10-25T11:48:22  *** bitcoin-git has left #bitcoin-core-dev
1692019-10-25T11:48:39  *** bitcoin-git has joined #bitcoin-core-dev
1702019-10-25T11:48:40  <bitcoin-git> [bitcoin] laanwj merged pull request #17080: consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it (master...1909-docCheckInputs) https://github.com/bitcoin/bitcoin/pull/17080
1712019-10-25T11:48:52  *** bitcoin-git has left #bitcoin-core-dev
1722019-10-25T11:50:26  *** Chris_Stewart_5 has quit IRC
1732019-10-25T11:55:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742019-10-25T11:56:31  *** bitcoin-git has joined #bitcoin-core-dev
1752019-10-25T11:56:31  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90ed98ae9a2a...37855ec9df57
1762019-10-25T11:56:32  <bitcoin-git> bitcoin/master b05ec41 marcaiaf: Add unit testing for the CompressScript functions
1772019-10-25T11:56:32  <bitcoin-git> bitcoin/master 37855ec Wladimir J. van der Laan: Merge #17220: tests: Add unit testing for the CompressScript function
1782019-10-25T11:56:34  *** bitcoin-git has left #bitcoin-core-dev
1792019-10-25T11:56:53  *** bitcoin-git has joined #bitcoin-core-dev
1802019-10-25T11:56:53  <bitcoin-git> [bitcoin] laanwj merged pull request #17220: tests: Add unit testing for the CompressScript function (master...add_compress_test_cases) https://github.com/bitcoin/bitcoin/pull/17220
1812019-10-25T11:56:55  *** bitcoin-git has left #bitcoin-core-dev
1822019-10-25T11:59:06  <wumpus> added 0.19.0 milestone to #17135 and removed it from #17035 (bumped to 0.19.1)
1832019-10-25T11:59:09  <gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag · Pull Request #17135 · bitcoin/bitcoin · GitHub
1842019-10-25T11:59:11  <gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler · Pull Request #17035 · bitcoin/bitcoin · GitHub
1852019-10-25T11:59:13  *** michaelfolkson has joined #bitcoin-core-dev
1862019-10-25T12:00:01  *** AimHere1 has quit IRC
1872019-10-25T12:01:40  <fanquake> ACK
1882019-10-25T12:01:55  <fanquake> I will take a look at 17135 this morning
1892019-10-25T12:02:31  <provoostenator> wumpus: the Great Firewall is known to reset connections for stuff it doesn't like; it creates the perception of a crappy website.
1902019-10-25T12:02:51  <wumpus> fanquake: great! we've been making it less scary
1912019-10-25T12:03:01  <provoostenator> But this is the same peer (104) over and over again.
1922019-10-25T12:03:34  <wumpus> provoostenator: yes, I've seen this behavior for other things for the Chinese firewall, which is why it worried me
1932019-10-25T12:04:16  <wumpus> provoostenator: but I'm no longer so worried, there have been no other reports, something like this would be massive
1942019-10-25T12:05:07  <provoostenator> Would be useful if debug=net were to log the IP along with the peer number...
1952019-10-25T12:05:55  <wumpus> yes, that's why I asked, I know there's a setting to enable logging of IPs of the peers it connects to, this would hav allowed me to try the peers myself and see if they have the same behavior from here
1962019-10-25T12:06:16  <wumpus> e.g. to see if it is a *peer problem* or a network problem
1972019-10-25T12:07:12  *** JJ has joined #bitcoin-core-dev
1982019-10-25T12:07:45  <wumpus> provoostenator: (104) is not the peer number but the error number
1992019-10-25T12:08:15  <wumpus> errno -l|grep 104
2002019-10-25T12:08:17  <wumpus> ECONNRESET 104 Connection reset by peer
2012019-10-25T12:08:21  *** JJ has quit IRC
2022019-10-25T12:12:19  *** JJ has joined #bitcoin-core-dev
2032019-10-25T12:13:38  <wumpus> found it, it's `-logips`
2042019-10-25T12:14:41  *** bitcoin-git has joined #bitcoin-core-dev
2052019-10-25T12:14:41  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37855ec9df57...48cb468ce3f5
2062019-10-25T12:14:41  <bitcoin-git> bitcoin/master 0a433fc John Newbery: [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCac...
2072019-10-25T12:14:42  <bitcoin-git> bitcoin/master 48cb468 fanquake: Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMe...
2082019-10-25T12:14:43  *** bitcoin-git has left #bitcoin-core-dev
2092019-10-25T12:15:01  *** bitcoin-git has joined #bitcoin-core-dev
2102019-10-25T12:15:01  <bitcoin-git> [bitcoin] fanquake merged pull request #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache (master...2019-10-checkinputsfrommempool) https://github.com/bitcoin/bitcoin/pull/17242
2112019-10-25T12:15:02  *** bitcoin-git has left #bitcoin-core-dev
2122019-10-25T12:15:53  *** JJ has quit IRC
2132019-10-25T12:17:29  *** porvak has joined #bitcoin-core-dev
2142019-10-25T12:20:00  *** Aaronvan_ is now known as AaronvanW
2152019-10-25T12:22:30  <provoostenator> Is there a command line incantation (for macOS) to reset an outbound connection?
2162019-10-25T12:25:03  *** lowentropy has quit IRC
2172019-10-25T12:25:05  <wumpus> tcpkill ftw
2182019-10-25T12:25:26  *** lowentropy has joined #bitcoin-core-dev
2192019-10-25T12:25:53  <wumpus> (no idea if that's still a thing tbh :)
2202019-10-25T12:27:14  *** jonatack has quit IRC
2212019-10-25T12:32:59  *** jkczyz has joined #bitcoin-core-dev
2222019-10-25T12:37:53  *** jkczyz has quit IRC
2232019-10-25T12:38:43  *** Skirmant has joined #bitcoin-core-dev
2242019-10-25T12:49:59  <provoostenator> This seems similar: https://github.com/google/tcp_killer/pull/1
2252019-10-25T12:50:14  <provoostenator> But it causes a graceful disconnect, so I need to tweak it somehow.
2262019-10-25T12:51:35  *** cryptoIndio has joined #bitcoin-core-dev
2272019-10-25T12:52:17  *** JeremyCrookshank has quit IRC
2282019-10-25T12:52:41  *** Highway61 has joined #bitcoin-core-dev
2292019-10-25T12:54:59  *** Chris_Stewart_5 has quit IRC
2302019-10-25T12:55:08  *** jonatack has joined #bitcoin-core-dev
2312019-10-25T12:58:24  *** cryptoIndio has quit IRC
2322019-10-25T13:05:34  *** halseth has quit IRC
2332019-10-25T13:06:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2342019-10-25T13:11:36  *** alko89 has joined #bitcoin-core-dev
2352019-10-25T13:12:27  *** halseth has joined #bitcoin-core-dev
2362019-10-25T13:14:55  *** bitcoin-git has joined #bitcoin-core-dev
2372019-10-25T13:14:55  <bitcoin-git> [bitcoin] jbeich opened pull request #17249: Unbreak build with boost 1.72 (master...boost) https://github.com/bitcoin/bitcoin/pull/17249
2382019-10-25T13:14:56  *** bitcoin-git has left #bitcoin-core-dev
2392019-10-25T13:19:15  *** bitcoin-git has joined #bitcoin-core-dev
2402019-10-25T13:19:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (master...1910-NoWrongGuess) https://github.com/bitcoin/bitcoin/pull/17250
2412019-10-25T13:19:16  *** bitcoin-git has left #bitcoin-core-dev
2422019-10-25T13:23:17  *** roconnor has quit IRC
2432019-10-25T13:24:35  *** Chris_Stewart_5 has quit IRC
2442019-10-25T13:32:27  *** JJ has joined #bitcoin-core-dev
2452019-10-25T13:32:29  <wumpus> injecting a call to close() seems risky; after that, the fd could be reused for something else (say, a new connection ,or a file), and the program doesn't know
2462019-10-25T13:32:41  *** astro has quit IRC
2472019-10-25T13:32:59  <wumpus> provoostenator: then again it's only for testing one particular thing, I suppose
2482019-10-25T13:33:03  *** astro has joined #bitcoin-core-dev
2492019-10-25T13:33:40  <provoostenator> It's just to test stuff, maybe the Google folks have a better idea:https://github.com/google/tcp_killer/pull/2
2502019-10-25T13:34:52  *** michaelfolkson has quit IRC
2512019-10-25T13:35:04  <wumpus> it's just, it can result in nasty corruptions, if say, leveldb decides to open a file next and the P2P layer keeps writing into the fd that's now owned by the file
2522019-10-25T13:35:34  *** Stas13 has joined #bitcoin-core-dev
2532019-10-25T13:35:36  <wumpus> but you'll have backups I guess
2542019-10-25T13:35:45  *** SiAnDoG has quit IRC
2552019-10-25T13:35:55  *** Stas13 has quit IRC
2562019-10-25T13:36:19  *** SiAnDoG has joined #bitcoin-core-dev
2572019-10-25T13:37:40  *** michaelfolkson has joined #bitcoin-core-dev
2582019-10-25T13:38:15  *** SiAnDoG has quit IRC
2592019-10-25T13:39:02  <provoostenator> Oh that's not healthy indeed...
2602019-10-25T13:40:16  *** jonatack has quit IRC
2612019-10-25T13:41:21  *** bitcoin-git has joined #bitcoin-core-dev
2622019-10-25T13:41:21  <bitcoin-git> [bitcoin] Sjors opened pull request #17251: net: SocketHandler logs peer id for close and disconnect (master...2019/10/net-socket-peer) https://github.com/bitcoin/bitcoin/pull/17251
2632019-10-25T13:41:22  *** bitcoin-git has left #bitcoin-core-dev
2642019-10-25T13:41:35  <provoostenator> I put a warning in the PR description
2652019-10-25T13:42:46  *** halseth has quit IRC
2662019-10-25T13:43:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2672019-10-25T13:43:22  <wumpus> I don't know a good solution that can work from the process itself
2682019-10-25T13:54:15  *** sdaftuar has quit IRC
2692019-10-25T13:54:31  *** sdaftuar_ has joined #bitcoin-core-dev
2702019-10-25T13:54:44  *** Guyver2 has joined #bitcoin-core-dev
2712019-10-25T13:54:53  *** sdaftuar_ is now known as sdaftuar
2722019-10-25T13:56:04  *** astro has quit IRC
2732019-10-25T13:56:55  <instagibbs> sdaftuar_, these slides are actually more complete than I expected, useful resource for starting to understand mempool stuff
2742019-10-25T13:57:00  *** cryptoIndio has joined #bitcoin-core-dev
2752019-10-25T13:57:03  *** Highway61 has quit IRC
2762019-10-25T13:58:15  <fanquake> instagibbs is there a public link?
2772019-10-25T13:58:18  *** astro has joined #bitcoin-core-dev
2782019-10-25T13:58:44  <instagibbs> he shared on gdrive, with permission I can upload the pdf somewhere?
2792019-10-25T13:59:48  *** bitcoin-git has joined #bitcoin-core-dev
2802019-10-25T13:59:48  <bitcoin-git> [bitcoin] promag opened pull request #17252: 0.19: gui: Make polling in ClientModel asynchronous (0.19...2019-10-backport-17135) https://github.com/bitcoin/bitcoin/pull/17252
2812019-10-25T13:59:49  *** bitcoin-git has left #bitcoin-core-dev
2822019-10-25T14:01:02  *** halseth has joined #bitcoin-core-dev
2832019-10-25T14:01:25  <sdaftuar> instagibbs: please do
2842019-10-25T14:01:35  *** cryptoIndio has quit IRC
2852019-10-25T14:01:58  <sdaftuar> if someone wants to turn that into a wiki page, that might be best?
2862019-10-25T14:02:10  <instagibbs> I could strip mine the slides, stick it on the wiki
2872019-10-25T14:02:13  <instagibbs> :P
2882019-10-25T14:02:58  *** thoragh has joined #bitcoin-core-dev
2892019-10-25T14:03:26  *** Skirmant has quit IRC
2902019-10-25T14:09:49  <instagibbs> fanquake, https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Mempool-and-mining
2912019-10-25T14:10:16  <instagibbs> this can obviously be cleaned up. I have at least one clarifying question
2922019-10-25T14:10:27  <fanquake> instagibbs well formatted I see
2932019-10-25T14:10:40  <sdaftuar> lol
2942019-10-25T14:10:42  <instagibbs> i went and added extra lines to break up the slides
2952019-10-25T14:11:03  <instagibbs> pretty much hero level editing
2962019-10-25T14:11:05  <fanquake> Looks good though. Will read through this arvo
2972019-10-25T14:11:08  *** provoostenator has quit IRC
2982019-10-25T14:13:07  *** lightlike has joined #bitcoin-core-dev
2992019-10-25T14:16:01  *** Skirmant has joined #bitcoin-core-dev
3002019-10-25T14:21:03  *** michaelfolkson has quit IRC
3012019-10-25T14:22:32  *** Skirmant has quit IRC
3022019-10-25T14:25:21  *** thoragh has left #bitcoin-core-dev
3032019-10-25T14:27:10  *** michaelfolkson has joined #bitcoin-core-dev
3042019-10-25T14:28:13  *** thoragh has joined #bitcoin-core-dev
3052019-10-25T14:28:46  <luke-jr> sdaftuar: https://github.com/bitcoin/bitcoin/pull/15660#issuecomment-476006719 is that patch posted anywhere?
3062019-10-25T14:29:01  <luke-jr> (maybe the original PR should be reopened with it?)
3072019-10-25T14:29:23  <sdaftuar> oy, i can try to find it
3082019-10-25T14:33:51  *** jkczyz has joined #bitcoin-core-dev
3092019-10-25T14:35:33  <luke-jr> maybe useful: git reflog show --format='%<|(30)%cd %h %gs'
3102019-10-25T14:35:47  *** bitcoin-git has joined #bitcoin-core-dev
3112019-10-25T14:35:47  <bitcoin-git> [bitcoin] elichai opened pull request #17253: Remove boost from time.cpp (master...2019-10-boost_sleep_time) https://github.com/bitcoin/bitcoin/pull/17253
3122019-10-25T14:35:48  *** bitcoin-git has left #bitcoin-core-dev
3132019-10-25T14:36:10  *** mdunnio has joined #bitcoin-core-dev
3142019-10-25T14:36:57  * luke-jr ponders if there's a way to get the ref change date
3152019-10-25T14:38:56  *** jkczyz has quit IRC
3162019-10-25T14:39:03  <sdaftuar> thanks for that command, but can't seem to find it. i'll spend a couple minutes and see how hard it is to redo (since the point of the cleanup was to make it easy)
3172019-10-25T14:54:41  *** cryptoIndio has joined #bitcoin-core-dev
3182019-10-25T14:57:01  <elichai2> wumpus: so basically I should steer away from anything related to threads?
3192019-10-25T14:58:11  *** thoragh has left #bitcoin-core-dev
3202019-10-25T14:58:42  <wumpus> elichai2: nah, not specifically: I think the high-level thing is that all the low-hanging boost replacements have been done, and everything that's left has probably been tried to replace over the last few years but failed, be sure to do some research into previous PRs or ask around first
3212019-10-25T14:59:17  <elichai2> yeah. I didn't know that was the case. next time i'll search the github before
3222019-10-25T14:59:25  *** michaelfolkson has quit IRC
3232019-10-25T14:59:27  <wumpus> e.g. there's probably some annoying death-by-a-thousand-cuts reason why it's still there
3242019-10-25T14:59:49  <elichai2> especially with the note in the scheduler
3252019-10-25T14:59:54  <elichai2> `// boost::thread / boost::chrono should be ported to std::thread / std::chrono // when we support C++11.`
3262019-10-25T15:00:02  *** porvak has quit IRC
3272019-10-25T15:00:05  <elichai2> so it makes it sound like the only reason is no one cared enough :)
3282019-10-25T15:00:10  *** cryptoIndio has quit IRC
3292019-10-25T15:00:53  *** provoostenator has joined #bitcoin-core-dev
3302019-10-25T15:02:05  <wumpus> elichai2: that, or the comment was over-optimistic :)
3312019-10-25T15:02:16  *** bitcoin-git has joined #bitcoin-core-dev
3322019-10-25T15:02:16  <bitcoin-git> [bitcoin] elichai closed pull request #17253: utils: Remove boost from time.cpp (master...2019-10-boost_sleep_time) https://github.com/bitcoin/bitcoin/pull/17253
3332019-10-25T15:02:17  *** bitcoin-git has left #bitcoin-core-dev
3342019-10-25T15:02:51  <wumpus> I, really really wish we could get rid of the boost::sleep madness and it wasn't like this
3352019-10-25T15:03:55  <wumpus> I vaguely remember cfields once did a full replacement of the boost chrono/sleep stuff, including handling thread group interrupts, but even he had to give up !
3362019-10-25T15:04:07  <instagibbs> elichai2, I recommend opening an issue with your sad news. Open issues make problems easier to track
3372019-10-25T15:04:21  <elichai2> :(
3382019-10-25T15:05:01  <elichai2> wumpus: but about the times. isn't it enough to assert now > 0? why was #16117 completley closed?
3392019-10-25T15:05:03  <gribble> https://github.com/bitcoin/bitcoin/issues/16117 | util: Replace boost:: with std:: in utiltime by MarcoFalke · Pull Request #16117 · bitcoin/bitcoin · GitHub
3402019-10-25T15:05:15  <sdaftuar> luke-jr: i think something like this works https://github.com/sdaftuar/bitcoin/commits/test-15633-2 .
3412019-10-25T15:05:45  <wumpus> elichai2: it probably didn't seem worth it anymore after the bad news
3422019-10-25T15:05:51  <elichai2> instagibbs: yeah, I might start with an issue(if doesn't exist yet, I won't make this mistake twice heh) that lists all the known boost right now. and people can comment (and i'll search) for why haven't we replaced them yet. for future references
3432019-10-25T15:06:19  <wumpus> opening an issue is probably a good idea, too many people stepped into this trap
3442019-10-25T15:07:03  <instagibbs> I'm a fan of opening an issue when closing PRs, if the problem is real, but solution somehow insufficient
3452019-10-25T15:07:25  <instagibbs> (if the PR doesn't already link an issue, of course!)
3462019-10-25T15:08:47  *** bitcoin-git has joined #bitcoin-core-dev
3472019-10-25T15:08:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48cb468ce3f5...693e40090ae7
3482019-10-25T15:08:47  <bitcoin-git> bitcoin/master dc2fdb9 practicalswift: tests: Add fuzzing harness for various CScript related functions
3492019-10-25T15:08:47  <bitcoin-git> bitcoin/master 693e400 MarcoFalke: Merge #17083: tests: Add fuzzing harness for various CScript related funct...
3502019-10-25T15:08:48  *** bitcoin-git has left #bitcoin-core-dev
3512019-10-25T15:08:54  <wumpus> yes that'd be the ideal case, that a PR fixes an existing issue
3522019-10-25T15:09:06  *** bitcoin-git has joined #bitcoin-core-dev
3532019-10-25T15:09:06  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17083: tests: Add fuzzing harness for various CScript related functions (master...fuzzers-script) https://github.com/bitcoin/bitcoin/pull/17083
3542019-10-25T15:09:08  *** bitcoin-git has left #bitcoin-core-dev
3552019-10-25T15:09:14  <wumpus> 'replace boost' isn't really an issue in itself (though there's a project that groups issues and PRs around it)
3562019-10-25T15:13:09  <wumpus> maybe "replace the boost thread interrupt system"
3572019-10-25T15:13:48  <wumpus> I think it'd be a partial redesign of things, not necessarily a one to one change
3582019-10-25T15:16:20  *** Skirmant has joined #bitcoin-core-dev
3592019-10-25T15:17:16  *** laxanofido has joined #bitcoin-core-dev
3602019-10-25T15:18:20  *** jkczyz has joined #bitcoin-core-dev
3612019-10-25T15:22:59  *** jkczyz has quit IRC
3622019-10-25T15:23:36  *** Skirmant has quit IRC
3632019-10-25T15:26:31  *** nosss2 has joined #bitcoin-core-dev
3642019-10-25T15:28:47  *** captjakk has joined #bitcoin-core-dev
3652019-10-25T15:34:42  *** davterra has joined #bitcoin-core-dev
3662019-10-25T15:39:26  *** Skirmant has joined #bitcoin-core-dev
3672019-10-25T15:45:30  *** andytoshi has joined #bitcoin-core-dev
3682019-10-25T15:45:31  *** andytoshi has joined #bitcoin-core-dev
3692019-10-25T15:47:57  <luke-jr> fwiw, added a %rd format for git-reflog http://dpaste.com/3BPT9GY
3702019-10-25T15:49:07  *** jkczyz has joined #bitcoin-core-dev
3712019-10-25T15:53:18  *** ddustin has joined #bitcoin-core-dev
3722019-10-25T15:54:17  *** cryptoIndio has joined #bitcoin-core-dev
3732019-10-25T15:57:39  *** ddustin has quit IRC
3742019-10-25T15:58:40  *** captjakk has quit IRC
3752019-10-25T15:59:36  *** captjakk has joined #bitcoin-core-dev
3762019-10-25T16:00:03  *** Zenton has quit IRC
3772019-10-25T16:01:13  *** jkczyz has quit IRC
3782019-10-25T16:08:38  *** cryptoIndio has quit IRC
3792019-10-25T16:19:35  *** mmgen has joined #bitcoin-core-dev
3802019-10-25T16:19:57  *** bitcoin-git has joined #bitcoin-core-dev
3812019-10-25T16:19:57  <bitcoin-git> [bitcoin] adamjonas opened pull request #17254: test: fix script_p2sh_tests OP_PUSHBACK2/4 missing (master...2019-10-missing-OP_PUSHBACK-test) https://github.com/bitcoin/bitcoin/pull/17254
3822019-10-25T16:20:07  *** bitcoin-git has left #bitcoin-core-dev
3832019-10-25T16:21:03  *** justan0theruser has joined #bitcoin-core-dev
3842019-10-25T16:21:24  *** justanotheruser has quit IRC
3852019-10-25T16:21:54  <luke-jr> sdaftuar: now I'm pondering what a non-segwit peer with CBv2 means :P
3862019-10-25T16:23:41  *** jkczyz has joined #bitcoin-core-dev
3872019-10-25T16:25:02  *** JJ has quit IRC
3882019-10-25T16:26:15  *** mdunnio has quit IRC
3892019-10-25T16:27:50  *** mdunnio has joined #bitcoin-core-dev
3902019-10-25T16:30:04  <sipa> luke-jr: spy node?
3912019-10-25T16:31:35  *** dviola has joined #bitcoin-core-dev
3922019-10-25T16:33:26  <luke-jr> sipa: well, sdaftuar changed gmax's check for NODE_SEGWIT to CBv2, I assume for a reason
3932019-10-25T16:33:42  *** Honthe has joined #bitcoin-core-dev
3942019-10-25T16:38:26  *** Chris_Stewart_5 has quit IRC
3952019-10-25T16:40:55  *** mdunnio has quit IRC
3962019-10-25T16:43:14  *** jkczyz has quit IRC
3972019-10-25T16:44:28  *** Deacyde has quit IRC
3982019-10-25T16:45:48  *** jb55 has quit IRC
3992019-10-25T16:47:43  *** jkczyz has joined #bitcoin-core-dev
4002019-10-25T16:49:21  *** jonatack has joined #bitcoin-core-dev
4012019-10-25T16:51:02  *** nosss2 has quit IRC
4022019-10-25T16:54:56  *** cryptoIndio has joined #bitcoin-core-dev
4032019-10-25T16:56:29  <cfields> wumpus: fwiw, it wasn't that I gave up, it's that the end-result was very, very non-c++11-like.
4042019-10-25T16:56:39  <cfields> Ended up having to resort to a bunch of c api's afterall.
4052019-10-25T16:57:34  <cfields> Pretty sure it's still floating around in a branch somewhere, it's just arguably no better than using boost :(
4062019-10-25T16:59:00  *** jarthur has joined #bitcoin-core-dev
4072019-10-25T17:01:39  *** cryptoIndio has quit IRC
4082019-10-25T17:03:55  <cfields> Oh, sorry, this was about the threading interrupt stuff, not wall clock stuff.
4092019-10-25T17:04:21  <cfields> Different branch, but similar outcome :)
4102019-10-25T17:08:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4112019-10-25T17:09:08  *** bitcoin-git has joined #bitcoin-core-dev
4122019-10-25T17:09:09  <bitcoin-git> [bitcoin] emilengler opened pull request #17256: doc: Change apt-get to apt (master...2019-10-apt-get-to-apt) https://github.com/bitcoin/bitcoin/pull/17256
4132019-10-25T17:09:23  *** bitcoin-git has left #bitcoin-core-dev
4142019-10-25T17:12:10  *** timothy has quit IRC
4152019-10-25T17:16:31  *** mdunnio has joined #bitcoin-core-dev
4162019-10-25T17:20:31  *** mdunnio has quit IRC
4172019-10-25T17:20:47  *** mdunnio has joined #bitcoin-core-dev
4182019-10-25T17:22:25  *** Victor_sueca is now known as Victorsueca
4192019-10-25T17:26:25  *** nosss2 has joined #bitcoin-core-dev
4202019-10-25T17:27:02  <jamesob> man, PRs that are like 300+ line changes that aren't scripted diffs considered harmful. having to re-review (and re-review) a giant changeset because review has gone on for another month and a rebase has happened is a drag.
4212019-10-25T17:30:25  *** arik_ has joined #bitcoin-core-dev
4222019-10-25T17:31:26  <luke-jr> typically I do re-review by comparing the diffs
4232019-10-25T17:32:46  *** thoragh has joined #bitcoin-core-dev
4242019-10-25T17:33:09  <instagibbs> 300 lines? you're like a baby :)
4252019-10-25T17:33:14  * instagibbs ducks
4262019-10-25T17:34:23  <luke-jr> gdd() {        local A="$1"; shift        local B="$1"; shift        gd "$A" "$@" >/tmp/a        gd "$B" "$@" >/tmp/b        diff /tmp/{a,b} -u | less }
4272019-10-25T17:34:36  <luke-jr> newlines not included
4282019-10-25T17:36:35  *** bitcoin-git has joined #bitcoin-core-dev
4292019-10-25T17:36:35  <bitcoin-git> [bitcoin] fanquake opened pull request #17257: gui: disable font antialiasing for QR image address (master...disable_qr_font_antialiasing) https://github.com/bitcoin/bitcoin/pull/17257
4302019-10-25T17:36:36  *** bitcoin-git has left #bitcoin-core-dev
4312019-10-25T17:37:45  <fanquake> jamesob 2100 lines waiting for you in 17165
4322019-10-25T17:38:03  <fanquake> although they are easy to review
4332019-10-25T17:39:33  <provoostenator> These "connection reset" log entries look more like a probing attack to me: https://github.com/bitcoin/bitcoin/issues/17247#issuecomment-546444882
4342019-10-25T17:43:38  *** justan0theruser has quit IRC
4352019-10-25T17:43:57  <sdaftuar> luke-jr: see the comment on gmax's original PR.  the code he had there wasn't right
4362019-10-25T17:44:00  <BlueMatt> wumpus: are you sure those connections arent incoming?
4372019-10-25T17:44:36  <ryanofsky> provoostenator, did you ever implement, or start implementing that optionsmodel test? i might pick up on that if you started something
4382019-10-25T17:44:53  <BlueMatt> provoostenator: yes, it is.
4392019-10-25T17:44:56  <provoostenator> ryanofsky: nope, go for it
4402019-10-25T17:48:44  *** lightlike has quit IRC
4412019-10-25T17:53:37  *** justan0theruser has joined #bitcoin-core-dev
4422019-10-25T17:55:12  <jamesob> luke-jr: yup that's what I'll do, but still think that giant PRs are in most cases an antipattern
4432019-10-25T18:00:02  *** laxanofido has quit IRC
4442019-10-25T18:01:42  *** AaronvanW has quit IRC
4452019-10-25T18:02:12  *** roconnor has joined #bitcoin-core-dev
4462019-10-25T18:02:53  *** jkczyz has quit IRC
4472019-10-25T18:03:27  *** jkczyz has joined #bitcoin-core-dev
4482019-10-25T18:04:20  *** sipa has quit IRC
4492019-10-25T18:10:50  *** dviola has quit IRC
4502019-10-25T18:11:10  *** sipa has joined #bitcoin-core-dev
4512019-10-25T18:11:24  *** arik_ has quit IRC
4522019-10-25T18:13:59  *** arik_ has joined #bitcoin-core-dev
4532019-10-25T18:15:20  *** lightlike has joined #bitcoin-core-dev
4542019-10-25T18:15:25  *** Zenton has joined #bitcoin-core-dev
4552019-10-25T18:17:42  *** NikolaiToryzin has joined #bitcoin-core-dev
4562019-10-25T18:26:54  *** arik_ has quit IRC
4572019-10-25T18:28:03  *** arik_ has joined #bitcoin-core-dev
4582019-10-25T18:28:05  *** mdunnio has quit IRC
4592019-10-25T18:29:05  *** rex4539 has joined #bitcoin-core-dev
4602019-10-25T18:29:39  *** rex4539 has quit IRC
4612019-10-25T18:29:58  *** rex4539 has joined #bitcoin-core-dev
4622019-10-25T18:30:56  *** mdunnio has joined #bitcoin-core-dev
4632019-10-25T18:32:23  *** rex4539 has joined #bitcoin-core-dev
4642019-10-25T18:34:11  *** rex4539 has quit IRC
4652019-10-25T18:37:16  *** infernix has quit IRC
4662019-10-25T18:39:42  *** owowo has quit IRC
4672019-10-25T18:39:42  *** AaronvanW has joined #bitcoin-core-dev
4682019-10-25T18:44:06  *** owowo has joined #bitcoin-core-dev
4692019-10-25T18:44:38  *** AaronvanW has quit IRC
4702019-10-25T18:53:53  *** justan0theruser has quit IRC
4712019-10-25T18:58:00  *** thoragh has quit IRC
4722019-10-25T19:00:21  <meshcollider> #startmeeting
4732019-10-25T19:00:21  <lightningbot> Meeting started Fri Oct 25 19:00:21 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
4742019-10-25T19:00:21  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4752019-10-25T19:00:23  <provoostenator> wallet meeting?
4762019-10-25T19:00:23  <jnewbery> hi
4772019-10-25T19:00:26  <provoostenator> hi
4782019-10-25T19:00:27  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
4792019-10-25T19:00:37  *** belcher has quit IRC
4802019-10-25T19:00:46  <fanquake> hi
4812019-10-25T19:00:47  <instagibbs> hi
4822019-10-25T19:00:56  <meshcollider> Topics?
4832019-10-25T19:00:58  <digi_james> hi
4842019-10-25T19:01:40  <achow101> hi
4852019-10-25T19:01:44  *** thoragh has joined #bitcoin-core-dev
4862019-10-25T19:01:44  <provoostenator> Not really. Lots of review work out there, just do it :-)
4872019-10-25T19:01:44  <BlueMatt> <suggestor> now that bitcoin core is defaulting to segwit more, I wonder if it would make sense to change the default on spending unconfirmed change to not spend non-segwit unconfirmed change due to malleability.
4882019-10-25T19:02:12  <instagibbs> BlueMatt, hmm
4892019-10-25T19:02:19  *** belcher has joined #bitcoin-core-dev
4902019-10-25T19:02:40  <instagibbs> achow101, you mentioned something about wanting to work on coin selection again, if you want to mention it here? (I don't know what you were thinking)
4912019-10-25T19:02:44  <provoostenator> Coin selection already prefers confirmed coins, so that seems a bit overkill.
4922019-10-25T19:02:59  <instagibbs> true, it heavily tries deeply-then-shallow-confirmed
4932019-10-25T19:02:59  <achow101> instagibbs: yes, planning on doing some coin selection stuff and reviving SRD
4942019-10-25T19:03:23  <meshcollider> Thanks to everyone who has been reviewing #16341, it's getting very close now which is awesome :)
4952019-10-25T19:03:26  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
4962019-10-25T19:03:29  <provoostenator> I went down the coin selection rabbit hole yesterday. Happy to review attemps by others :-)
4972019-10-25T19:03:43  <instagibbs> Sorry I haven't had time to re-review SPKM PR :/
4982019-10-25T19:04:30  <instagibbs> Honestly knapsack has to die
4992019-10-25T19:04:32  <achow101> BlueMatt: would there even be non-segwit unconfirmed change unless the wallet is configured to addresstype=legacy?
5002019-10-25T19:05:01  <instagibbs> Previously I had tried working on the wallet again, and threw my hands up in dispair because of the knapsack loop behavior
5012019-10-25T19:05:06  <achow101> errr changetype=legacy.. I don't think we make non-segwit change anymore?
5022019-10-25T19:05:20  <BlueMatt> achow101: no, you need to avoid spending any change that came from a transaction with non-segwit inputs
5032019-10-25T19:05:41  <BlueMatt> cause that underlying tx is malleable
5042019-10-25T19:05:46  <achow101> oh right
5052019-10-25T19:06:11  <instagibbs> achow101, so personally speaking, I'd strong concept ACK killing off knapsack if the UTXO simulation story doesn't look awful
5062019-10-25T19:06:43  <instagibbs> imo it's limped along by fear of removing the current UTXO vacuum(that doesn't benefit small wallets anyways!)
5072019-10-25T19:08:27  *** bitcoin-git has joined #bitcoin-core-dev
5082019-10-25T19:08:27  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/693e40090ae7...25d7e2e78137
5092019-10-25T19:08:28  <bitcoin-git> bitcoin/master 04dbdd6 Sjors Provoost: [net] SocketHandler: log peer id for close and disconnect
5102019-10-25T19:08:28  <bitcoin-git> bitcoin/master 25d7e2e fanquake: Merge #17251: net: SocketHandler logs peer id for close and disconnect
5112019-10-25T19:08:30  *** bitcoin-git has left #bitcoin-core-dev
5122019-10-25T19:08:32  <provoostenator> Yeah that loop is horrible. It doesnt' even really start at the top: splitting the fee amongst outputs is done at the top, based on the last iteration.
5132019-10-25T19:08:47  *** bitcoin-git has joined #bitcoin-core-dev
5142019-10-25T19:08:47  <bitcoin-git> [bitcoin] fanquake merged pull request #17251: net: SocketHandler logs peer id for close and disconnect (master...2019/10/net-socket-peer) https://github.com/bitcoin/bitcoin/pull/17251
5152019-10-25T19:08:49  *** bitcoin-git has left #bitcoin-core-dev
5162019-10-25T19:08:49  <provoostenator> ^ yolo merge, before Travis ready :-)
5172019-10-25T19:08:54  <instagibbs> It makes improvements to the wallet basically impossible :(
5182019-10-25T19:08:59  <instagibbs> some improvements*
5192019-10-25T19:09:07  *** bitcoin-git has joined #bitcoin-core-dev
5202019-10-25T19:09:07  <bitcoin-git> [bitcoin] adamjonas opened pull request #17258: Fix issue with conflicted mempool tx in listsinceblock (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/17258
5212019-10-25T19:09:08  *** bitcoin-git has left #bitcoin-core-dev
5222019-10-25T19:09:12  <instagibbs> anyways, stepping off soapbox
5232019-10-25T19:09:42  <instagibbs> f.e., having the wallet implicitly CPFP
5242019-10-25T19:10:02  <provoostenator> instagibbs: you'll like #17246
5252019-10-25T19:10:04  <gribble> https://github.com/bitcoin/bitcoin/issues/17246 | wallet: avoid knapsack when theres no change by Sjors · Pull Request #17246 · bitcoin/bitcoin · GitHub
5262019-10-25T19:10:05  <achow101> BlueMatt: I suppose that idea is reasonable. but, on the topic of unconfirmed change, how do we handle fee bumping a tx from which we've spent the unconfirmed change?
5272019-10-25T19:10:12  <provoostenator> (or some variant thereof)
5282019-10-25T19:10:17  <instagibbs> provoostenator, right, CPFP would have worked for me... only for CPFP case :)
5292019-10-25T19:10:18  <BlueMatt> you dont
5302019-10-25T19:10:21  <BlueMatt> you bump the next one up
5312019-10-25T19:10:24  <BlueMatt> cpfp :)
5322019-10-25T19:10:25  <instagibbs> but I felt that wasn't worth it
5332019-10-25T19:11:14  <jnewbery> topic request: #16341
5342019-10-25T19:11:16  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
5352019-10-25T19:11:40  *** arik_ has quit IRC
5362019-10-25T19:12:06  <achow101> BlueMatt: true. I was about to suggest that maybe we shouldn't allow unconfirmed change at all
5372019-10-25T19:12:50  <achow101> And with upcoming more complex scripts, maybe we shouldn't, because we aren't necessarily the sole owner of those outputs
5382019-10-25T19:13:58  <provoostenator> Instead of spending unconfirmed change, we could RBF and add an output?
5392019-10-25T19:14:09  <provoostenator> That would be a nice fee saving UX improvment.
5402019-10-25T19:14:47  <provoostenator> (though non trivial if the pre-RBF transactions gets mined)
5412019-10-25T19:14:57  <instagibbs> that's the sticky part
5422019-10-25T19:15:19  *** AaronvanW has joined #bitcoin-core-dev
5432019-10-25T19:15:25  <provoostenator> You can sign two variants and start broadcasting the fallback if needed.
5442019-10-25T19:15:38  <provoostenator> But that's less of a set-and-forget than we have now.
5452019-10-25T19:15:44  <instagibbs> our wallet is very "transactional" i nthe wrong sense currently
5462019-10-25T19:15:51  <provoostenator> set-and-quit-and-forget I mean
5472019-10-25T19:15:57  <instagibbs> transaction as in CTransaction rather than logical transaction :)
5482019-10-25T19:18:14  <achow101> next topic?
5492019-10-25T19:18:19  <meshcollider> #topic SPKM PR #16341 (jnewbery)
5502019-10-25T19:18:22  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
5512019-10-25T19:18:33  <achow101> ack 'n merge pls
5522019-10-25T19:18:59  <meshcollider> Go and bug sipa first, he said he wanted to review it
5532019-10-25T19:19:00  <jnewbery> I'd like to help but there's no way I have time to review the PR in the way that it's structured
5542019-10-25T19:19:27  <provoostenator> jnewbery: did you also look at ryanofsky's variant, with the same end result?
5552019-10-25T19:19:30  <jnewbery> I'm particularly concerned about ryanofsky's comment here: https://github.com/bitcoin/bitcoin/pull/16341#issuecomment-541330425
5562019-10-25T19:19:36  <achow101> jnewbery: do you want me to use ryanofsky's structure?
5572019-10-25T19:19:37  *** AaronvanW has quit IRC
5582019-10-25T19:19:43  <provoostenator> I found it useful to review achow101's version first, and then ryanofsky's version
5592019-10-25T19:19:57  <jnewbery> provoostenator achow101: I haven't looked at Russ's version yet
5602019-10-25T19:20:21  <jnewbery> it's mostly about the volume of changes
5612019-10-25T19:20:37  <provoostenator> But I wouldn't either is ideal. Russ' version does a _lot_ of stuff in big increments in the beginning. But his later commits are perhaps better.
5622019-10-25T19:20:56  <jnewbery> I know it'd take me at least a week to review so much code and satisfy myself that there aren't bugs
5632019-10-25T19:21:19  <provoostenator> It's a huge PR indeed. But it's not obvious how to refactor the giant ball of spaghetti in multiple steps
5642019-10-25T19:21:22  *** cryptoIndio has joined #bitcoin-core-dev
5652019-10-25T19:21:46  <ryanofsky> just catching up but my branch has two big commits at the beginning. one is 100% moveonly. one is a bunch of renames
5662019-10-25T19:21:56  <ryanofsky> every other commit is small
5672019-10-25T19:22:17  <meshcollider> Yeah this has come up in discussion a few times, noone has come up with an alternative to either this or more massive commits
5682019-10-25T19:22:38  <jnewbery> ryanofsky: would only merging those first two commits leave us in a bad state (would it be possible to slice those off in their own PR)?
5692019-10-25T19:23:00  <jnewbery> I can definitely review move-only/rename commits
5702019-10-25T19:23:06  <ryanofsky> merging those two commits would be fine, as far as i know
5712019-10-25T19:23:27  <jnewbery> achow101: what do you think about that approach?
5722019-10-25T19:24:19  <meshcollider> If we are going to split this PR up a bit, maybe we should feature-freeze the wallet until all the parts are in to avoid things getting messy half way
5732019-10-25T19:24:46  <achow101> jnewbery: I haven't looked at russ's branch in detail
5742019-10-25T19:24:51  <provoostenator> Maybe the "Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes" can split into one commit that introduces the class, and one that moves the methods over?
5752019-10-25T19:24:53  <instagibbs> that's the other thing true, you're going to force people to rebase 2+ times
5762019-10-25T19:24:58  *** arik_ has joined #bitcoin-core-dev
5772019-10-25T19:24:59  <instagibbs> in serious ways
5782019-10-25T19:25:25  <meshcollider> Well they can just wait til it's all in ^
5792019-10-25T19:25:26  <ryanofsky> just to clarify my github comment from a few weeks ago, i'm fine if achow's pr is merged as is, i just wouldn't want my ack to be a deciding factor
5802019-10-25T19:26:12  <ryanofsky> it's too many scattered changes that i don't fully understand to be confident about all of them
5812019-10-25T19:26:35  <jnewbery> That's my main concern (separate from not being able to review it myself):I'm worried that due to the size of this PR, other people who have reviewed it haven't been able to do so in sufficient detail to avoid merging bugs
5822019-10-25T19:26:37  <achow101> ryanofsky: I think the only reason acks came in quickly after yours is because they were just waiting for you to be done asking for changes before commenting
5832019-10-25T19:26:43  <meshcollider> Yeah it is enormous, I'm feeling the same way
5842019-10-25T19:27:15  <ryanofsky> achow101, yes you're right i probably misinterpreted the timing
5852019-10-25T19:27:25  <meshcollider> That's why I want to merge it early on in the 0.20 release cycle so we have plenty of time to identify bugs before we get close to a release
5862019-10-25T19:27:53  <instagibbs> Yes, I had reviewed once, then waited for velocity to stop, then reviewed the diff between the version I'd reviewed and tip. That said, it deserves more eyes
5872019-10-25T19:27:58  *** cryptoIndio has quit IRC
5882019-10-25T19:28:29  <meshcollider> Smaller PRs would definitely encourage more reviews too
5892019-10-25T19:28:48  <ryanofsky> meshcollider, i don't think this has to be an all or nothing thing merged early in the release cycle. you could merge the moves early, and then let all the little behavior changes get reviewed as normal
5902019-10-25T19:28:50  <provoostenator> For release cycle it doesn't matter much if we wait another week or two for proof-of-newbery
5912019-10-25T19:29:15  <jnewbery> I'm raising it because I'm not getting the sense from any of the reviewers who have ACKed that they're super confident
5922019-10-25T19:29:40  <achow101> I can try to break it up further based on ryanofsky's branch as it seems like people are okay with some big moveonlys and renames
5932019-10-25T19:30:18  <jnewbery> achow101: thanks! I'll also try to take a look at ryanofsky's version next week
5942019-10-25T19:30:23  <achow101> if we want to do it in smaller prs, then I think we should feature freeze the wallet
5952019-10-25T19:30:34  <sipa> (speaking as someone who has not looked at the changes in detail, but plans to)  big moveonlys are still fairly mechanically verifiable, regardless of size
5962019-10-25T19:31:19  <ryanofsky> yeah i think the first big commit which is completely moveonly is basically trivial
5972019-10-25T19:31:40  <achow101> (now I just need to find ryanofsky's branch, I seem to be clikcing all the wrong "Load more comments..")
5982019-10-25T19:31:51  <ryanofsky> the second big commit which is the "rename" commit is kind of eyeglazing but still boring and reviewable i think
5992019-10-25T19:31:52  <MarcoFalke> Can this channel be opened again or at least mention in the title that log in is required?
6002019-10-25T19:31:59  <MarcoFalke> People keep running into this issue
6012019-10-25T19:32:39  <meshcollider> achow101: I'm happy to do that for a while because otherwise this is going to take forever to get in
6022019-10-25T19:33:17  <provoostenator> achow101: https://github.com/ryanofsky/bitcoin/commits/pr/keyman
6032019-10-25T19:33:46  <instagibbs> if feature freeze is the plan, I think people should be allowed a window to squeeze in near-merged features :)
6042019-10-25T19:33:49  <instagibbs> with heads up
6052019-10-25T19:34:10  <instagibbs> unless the freeze is like... a week
6062019-10-25T19:34:25  <achow101> I think some large-ish changes could also become scripted-diffs, so that will help review
6072019-10-25T19:34:25  *** cryptoIndio has joined #bitcoin-core-dev
6082019-10-25T19:34:36  <ryanofsky> i'm fine with a feature freeze, but not sure what a feature freeze would be doing...
6092019-10-25T19:35:08  *** JeremyCrookshank has joined #bitcoin-core-dev
6102019-10-25T19:35:16  <jnewbery> If ryanofsky's branch really is two big commits (that become the first PR) and then a bunch of small commits, I also don't understand the need for a feature freeze
6112019-10-25T19:35:28  <jnewbery> it sounds like the disruptive rebasey part would be those first two commits
6122019-10-25T19:35:33  <sipa> i think it's simpler to have reviewers lined up for a "it will be merged on day X", and then the PR author can rebase that day exactly, everyone give a final ack, and it's merged
6132019-10-25T19:35:34  <jnewbery> and once they're in they're in
6142019-10-25T19:35:42  *** jarthur has quit IRC
6152019-10-25T19:35:43  <ryanofsky> yeah exactly all the commits are small and normal except 2
6162019-10-25T19:37:02  <instagibbs> ok provided you think it's only 1 painful break, fine
6172019-10-25T19:37:11  <ryanofsky> if the concern is difficulty rebasing the 2 big commits, i've done than several times, and it hasn't been a big deal. can continue to do it if desired
6182019-10-25T19:37:15  <instagibbs> let's just do that
6192019-10-25T19:37:21  <meshcollider> Alright achow101 happy?
6202019-10-25T19:37:33  <achow101> ok
6212019-10-25T19:38:02  <meshcollider> Sweet, any other topics?
6222019-10-25T19:38:07  <provoostenator> achow101: if you're replacing the branch, please make a new PR...
6232019-10-25T19:38:18  <achow101> yes, new prs will be opened
6242019-10-25T19:38:38  <jnewbery> thanks!
6252019-10-25T19:38:41  <provoostenator> Great, so I don't have to write a Chrome plugin to auto-click "Load More..."
6262019-10-25T19:38:54  <meshcollider> Please do that anyway :p
6272019-10-25T19:39:31  *** cryptoIndio has quit IRC
6282019-10-25T19:39:56  <JeremyCrookshank> Hello?
6292019-10-25T19:40:00  <instagibbs> since #16944 got un-scope-creeped, I think it's close to merge (selfish reminder)
6302019-10-25T19:40:03  <gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors · Pull Request #16944 · bitcoin/bitcoin · GitHub
6312019-10-25T19:40:32  *** JJ has joined #bitcoin-core-dev
6322019-10-25T19:40:33  <instagibbs> JeremyCrookshank, pong
6332019-10-25T19:40:42  <JeremyCrookshank> Oh thankgod people can see my messages now
6342019-10-25T19:40:45  <JeremyCrookshank> :)
6352019-10-25T19:40:58  *** mmgen has quit IRC
6362019-10-25T19:41:02  *** JJ has quit IRC
6372019-10-25T19:41:05  <meshcollider> Yep I'm going to take a look at that today instagibbs
6382019-10-25T19:41:15  <meshcollider> #endmeeting
6392019-10-25T19:41:15  <lightningbot> Meeting ended Fri Oct 25 19:41:15 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6402019-10-25T19:41:15  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.html
6412019-10-25T19:41:15  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.txt
6422019-10-25T19:41:15  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-25-19.00.log.html
6432019-10-25T19:41:53  <provoostenator> Yes, it can be merged independent of the keypool stuff; it just won't work for keypool-less watch-only wallets.
6442019-10-25T19:42:08  *** ddustin has joined #bitcoin-core-dev
6452019-10-25T19:43:19  *** ddustin has joined #bitcoin-core-dev
6462019-10-25T19:44:01  *** ddustin has quit IRC
6472019-10-25T19:44:42  *** cryptoIndio has joined #bitcoin-core-dev
6482019-10-25T19:44:42  *** ddustin has joined #bitcoin-core-dev
6492019-10-25T19:45:07  *** infernix has joined #bitcoin-core-dev
6502019-10-25T19:45:28  *** ddustin has quit IRC
6512019-10-25T19:46:09  *** ddustin has joined #bitcoin-core-dev
6522019-10-25T19:46:48  *** arik_ has quit IRC
6532019-10-25T19:47:00  *** ddustin has quit IRC
6542019-10-25T19:47:36  *** arik_ has joined #bitcoin-core-dev
6552019-10-25T19:47:49  *** ddustin has joined #bitcoin-core-dev
6562019-10-25T19:48:28  *** ddustin has quit IRC
6572019-10-25T19:48:37  *** jkczyz has quit IRC
6582019-10-25T19:49:12  *** ddustin has joined #bitcoin-core-dev
6592019-10-25T19:49:43  *** cryptoIndio has quit IRC
6602019-10-25T19:49:51  *** ddustin has quit IRC
6612019-10-25T19:49:58  *** belcher has quit IRC
6622019-10-25T19:50:27  *** ddustin has joined #bitcoin-core-dev
6632019-10-25T19:50:52  <JeremyCrookshank> How often are the meetings?
6642019-10-25T19:51:11  *** ddustin has quit IRC
6652019-10-25T19:51:32  <instagibbs> JeremyCrookshank, wallet meetings i think are every-other Friday, beginning of this hour
6662019-10-25T19:51:43  <instagibbs> main meeting is weekly, Thursday, same time
6672019-10-25T19:51:57  *** ddustin has joined #bitcoin-core-dev
6682019-10-25T19:52:05  <JeremyCrookshank> Thank you :)
6692019-10-25T19:52:13  <jnewbery> (scheduled in UTC, so it might be a different local time for you next week depending on where you live)
6702019-10-25T19:52:34  *** ddustin has quit IRC
6712019-10-25T19:52:55  <instagibbs> right, iceland time ;)
6722019-10-25T19:53:18  *** ddustin has joined #bitcoin-core-dev
6732019-10-25T19:53:25  <achow101> My main concern with using ryanofsky's commits is the second one, it's not just a rename as it does introduce LegacyScriptPubKeyMan and changes some wallet things to use that
6742019-10-25T19:54:00  <achow101> maybe it can be broken down further?
6752019-10-25T19:54:19  <ryanofsky> for reference, this is https://github.com/ryanofsky/bitcoin/commit/96beb6b80aed453d30f217481dfc10f14c87d200
6762019-10-25T19:54:39  *** jkczyz has joined #bitcoin-core-dev
6772019-10-25T19:54:41  *** cryptoIndio has joined #bitcoin-core-dev
6782019-10-25T19:54:43  <ryanofsky> yes it could be broken down, sjors has suggested doing rpc file separately for example
6792019-10-25T19:55:05  <ryanofsky> but everything there is a mechanical change, renaming, wrapping aliasing, no changes in behavior. it's just big
6802019-10-25T19:55:36  <ryanofsky> easiest way to see that is to run the git diff commands in the commit description
6812019-10-25T19:55:54  *** AaronvanW has joined #bitcoin-core-dev
6822019-10-25T20:00:17  *** AaronvanW has quit IRC
6832019-10-25T20:02:10  <provoostenator> And maybe also have one commit that introduces the (Legacy)ScriptPubKeyMan class itself
6842019-10-25T20:03:12  <achow101> eyeglazing is an understatement for that commit
6852019-10-25T20:03:39  *** jb55 has joined #bitcoin-core-dev
6862019-10-25T20:05:42  *** ajonas has joined #bitcoin-core-dev
6872019-10-25T20:05:59  <achow101> how many PRs do people want? 2? more?
6882019-10-25T20:06:15  <ryanofsky> provoostenator, i wasn't sure what you meant there. the class without the methods would just be an empty class declaration
6892019-10-25T20:07:27  <ryanofsky> achow, one awkward thing is those 4 commits before the 2 big ones
6902019-10-25T20:07:53  *** cryptoIndio has quit IRC
6912019-10-25T20:07:55  <achow101> ryanofsky: yeah, I was going to see if I could break this up such that those 4 would slide in before whatever changes they are required for
6922019-10-25T20:08:04  <achow101> may need 4 PRs for that
6932019-10-25T20:08:36  <ryanofsky> looking
6942019-10-25T20:10:13  <ryanofsky> i wonder if we could just merge those now
6952019-10-25T20:10:20  <achow101> I'm also looking to drop or merge together the "unsure if necessary" commits with other commits
6962019-10-25T20:10:57  <achow101> also gonna base on mater
6972019-10-25T20:10:59  <achow101> *master
6982019-10-25T20:11:18  <ryanofsky> otherwise i can update my branch to just put the two big commits first
6992019-10-25T20:12:18  <achow101> ryanofsky: I'm pretty sure they can fit in other places. They originally were placed before the commits that required them but moved because semi-unrelated
7002019-10-25T20:12:24  <ryanofsky> which "unsure if necessary" commits do you think are good?
7012019-10-25T20:12:51  <achow101> https://github.com/ryanofsky/bitcoin/commit/a9ee4ca8060f71b8edc2b4aff685f9dbc3841488 and https://github.com/ryanofsky/bitcoin/commit/0a036d2c4af9ee6b40a2028a789c32bc36b1464a
7022019-10-25T20:13:07  <achow101> ScriptPubKeyMan unique_ptr and include <functional.h>
7032019-10-25T20:14:27  *** JeremyCrookshank has quit IRC
7042019-10-25T20:14:27  <ryanofsky> ok why the unique pointer one? it just seems to create a dummy wrapper that doesn't do anything
7052019-10-25T20:16:33  <achow101> wrong commit, nvm
7062019-10-25T20:16:59  <achow101> include functional is the only one to keep
7072019-10-25T20:18:01  <ryanofsky> got it, i understand that one now
7082019-10-25T20:18:37  *** justanotheruser has joined #bitcoin-core-dev
7092019-10-25T20:18:40  <provoostenator> ryanofsky: I meant class with function defitions and maybe noop methods. That way the function bodies can move from one structure to another. But ignore if impractical.
7102019-10-25T20:19:57  *** za-kk has joined #bitcoin-core-dev
7112019-10-25T20:25:43  *** jkczyz has quit IRC
7122019-10-25T20:26:59  <ryanofsky> achow101 just updated https://github.com/ryanofsky/bitcoin/commits/pr/keyman, no big change
7132019-10-25T20:27:57  <ryanofsky> i just moved the two big commits earlier. i think the first three commits would make a good pr: two moveonlys and the eyeglazing rename
7142019-10-25T20:29:43  <ryanofsky> compilation and tests should still pass the whole way through but can reconfirm
7152019-10-25T20:33:54  *** JeremyCrookshank has joined #bitcoin-core-dev
7162019-10-25T20:34:12  *** AaronvanW has joined #bitcoin-core-dev
7172019-10-25T20:34:13  <JeremyCrookshank> ping
7182019-10-25T20:38:35  <ryanofsky> pong
7192019-10-25T20:39:20  *** AaronvanW has quit IRC
7202019-10-25T20:41:04  <sipa> pang
7212019-10-25T20:41:31  <za-kk> peng
7222019-10-25T20:45:19  *** Hazle51Lowe has joined #bitcoin-core-dev
7232019-10-25T20:50:26  *** Hazle51Lowe has quit IRC
7242019-10-25T20:52:51  *** cryptoIndio has joined #bitcoin-core-dev
7252019-10-25T21:00:01  *** NikolaiToryzin has quit IRC
7262019-10-25T21:00:17  *** cryptoIndio has quit IRC
7272019-10-25T21:00:59  *** thoragh has quit IRC
7282019-10-25T21:02:11  *** thoragh has joined #bitcoin-core-dev
7292019-10-25T21:03:25  *** dviola has joined #bitcoin-core-dev
7302019-10-25T21:04:25  *** jkczyz_ has joined #bitcoin-core-dev
7312019-10-25T21:05:03  *** mdunnio has quit IRC
7322019-10-25T21:05:16  *** AaronvanW has joined #bitcoin-core-dev
7332019-10-25T21:08:05  *** cryptoIndio has joined #bitcoin-core-dev
7342019-10-25T21:08:25  *** dviola has quit IRC
7352019-10-25T21:08:25  *** dviola has joined #bitcoin-core-dev
7362019-10-25T21:08:49  *** arik_ has quit IRC
7372019-10-25T21:09:37  *** AaronvanW has quit IRC
7382019-10-25T21:09:53  *** bitcoin-git has joined #bitcoin-core-dev
7392019-10-25T21:09:53  <bitcoin-git> [bitcoin] achow101 closed pull request #16341: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) (master...box-the-wallet) https://github.com/bitcoin/bitcoin/pull/16341
7402019-10-25T21:09:57  *** justanotheruser has quit IRC
7412019-10-25T21:10:04  *** bitcoin-git has left #bitcoin-core-dev
7422019-10-25T21:11:28  *** arik_ has joined #bitcoin-core-dev
7432019-10-25T21:11:53  *** bitcoin-git has joined #bitcoin-core-dev
7442019-10-25T21:11:53  <bitcoin-git> [bitcoin] achow101 opened pull request #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (master...wallet-box-pr-1) https://github.com/bitcoin/bitcoin/pull/17260
7452019-10-25T21:12:04  *** bitcoin-git has left #bitcoin-core-dev
7462019-10-25T21:12:21  *** bitcoin-git has joined #bitcoin-core-dev
7472019-10-25T21:12:21  <bitcoin-git> [bitcoin] emilengler closed pull request #17256: doc: Change apt-get to apt (master...2019-10-apt-get-to-apt) https://github.com/bitcoin/bitcoin/pull/17256
7482019-10-25T21:12:23  *** bitcoin-git has left #bitcoin-core-dev
7492019-10-25T21:12:36  <achow101> ^^ 1st pr open
7502019-10-25T21:15:42  <ryanofsky> thanks, easy ack for me. need to silence the linters thought, i guess
7512019-10-25T21:17:25  *** lahwran has joined #bitcoin-core-dev
7522019-10-25T21:18:02  *** jkczyz_ has quit IRC
7532019-10-25T21:18:21  *** mdunnio has joined #bitcoin-core-dev
7542019-10-25T21:18:25  *** jkczyz has joined #bitcoin-core-dev
7552019-10-25T21:28:25  <jonatack> JeremyCrookshank: Bitcoin Core IRC meetings info here https://github.com/jonatack/bitcoin-development/blob/master/bitcoin-core-dev-irc-meetings.txt
7562019-10-25T21:31:21  <jonatack> JeremyCrookshank: also https://github.com/fanquake/core-review/blob/master/irc.md
7572019-10-25T21:33:03  *** captjakk has quit IRC
7582019-10-25T21:34:05  <achow101> ryanofsky: not all commits compile, so gonna have to make a few changes
7592019-10-25T21:34:15  <achow101> also doing some reordering
7602019-10-25T21:34:45  *** justanotheruser has joined #bitcoin-core-dev
7612019-10-25T21:35:30  *** captjakk has joined #bitcoin-core-dev
7622019-10-25T21:38:15  *** arik_ has quit IRC
7632019-10-25T21:41:02  *** AaronvanW has joined #bitcoin-core-dev
7642019-10-25T21:42:39  *** Chris_Stewart_5 has quit IRC
7652019-10-25T21:42:49  *** Skirmant has quit IRC
7662019-10-25T21:45:50  *** AaronvanW has quit IRC
7672019-10-25T21:47:22  *** Highway61 has joined #bitcoin-core-dev
7682019-10-25T21:47:47  *** jkczyz has quit IRC
7692019-10-25T22:02:01  *** rex4539 has joined #bitcoin-core-dev
7702019-10-25T22:07:44  *** Skirmant has joined #bitcoin-core-dev
7712019-10-25T22:19:04  *** mdunnio has quit IRC
7722019-10-25T22:21:47  *** AaronvanW has joined #bitcoin-core-dev
7732019-10-25T22:25:26  *** ajonas has quit IRC
7742019-10-25T22:26:18  *** AaronvanW has quit IRC
7752019-10-25T22:27:35  *** mdunnio has joined #bitcoin-core-dev
7762019-10-25T22:29:17  *** jkczyz has joined #bitcoin-core-dev
7772019-10-25T22:31:03  *** mdunnio has quit IRC
7782019-10-25T22:32:43  *** Guyver2 has quit IRC
7792019-10-25T22:34:53  *** marcoagner has quit IRC
7802019-10-25T22:40:52  *** Deacyde has joined #bitcoin-core-dev
7812019-10-25T23:00:56  *** AaronvanW has joined #bitcoin-core-dev
7822019-10-25T23:05:21  *** AaronvanW has quit IRC
7832019-10-25T23:07:52  *** ImAFreek has joined #bitcoin-core-dev
7842019-10-25T23:13:38  *** thoragh has quit IRC
7852019-10-25T23:16:05  <JeremyCrookshank> thank you jona
7862019-10-25T23:16:07  <JeremyCrookshank> :)
7872019-10-25T23:17:42  *** ImAFreek has quit IRC
7882019-10-25T23:21:11  *** JeremyCrookshank has quit IRC
7892019-10-25T23:22:54  *** captjakk has quit IRC
7902019-10-25T23:26:52  *** za-kk has quit IRC
7912019-10-25T23:31:14  *** Deacyde has quit IRC
7922019-10-25T23:33:25  *** luigi_ has joined #bitcoin-core-dev
7932019-10-25T23:36:57  *** AaronvanW has joined #bitcoin-core-dev
7942019-10-25T23:38:33  *** SiAnDoG has joined #bitcoin-core-dev
7952019-10-25T23:41:52  *** AaronvanW has quit IRC
7962019-10-25T23:54:49  *** jkczyz has quit IRC
7972019-10-25T23:56:46  *** lightlike has quit IRC
7982019-10-25T23:59:27  *** jkczyz has joined #bitcoin-core-dev