12019-11-06T00:00:01  *** laxanofido has quit IRC
  22019-11-06T00:02:07  *** Zenton has quit IRC
  32019-11-06T00:02:29  *** Zenton has joined #bitcoin-core-dev
  42019-11-06T00:05:18  *** Zenton has quit IRC
  52019-11-06T00:05:36  *** Zenton has joined #bitcoin-core-dev
  62019-11-06T00:07:16  *** ddustin has joined #bitcoin-core-dev
  72019-11-06T00:14:19  *** Zenton has quit IRC
  82019-11-06T00:14:44  *** Zenton has joined #bitcoin-core-dev
  92019-11-06T00:15:10  *** ddustin_ has joined #bitcoin-core-dev
 102019-11-06T00:15:36  *** michaelfolkson has quit IRC
 112019-11-06T00:17:04  *** chipc has joined #bitcoin-core-dev
 122019-11-06T00:17:47  *** Zenton has quit IRC
 132019-11-06T00:18:21  *** Zenton has joined #bitcoin-core-dev
 142019-11-06T00:18:39  *** ddustin has quit IRC
 152019-11-06T00:24:17  *** Zenton has quit IRC
 162019-11-06T00:24:58  *** Zenton has joined #bitcoin-core-dev
 172019-11-06T00:29:26  *** soju has joined #bitcoin-core-dev
 182019-11-06T00:30:50  *** Zenton has quit IRC
 192019-11-06T00:31:31  *** alko89 has quit IRC
 202019-11-06T00:33:20  *** ddustin_ has quit IRC
 212019-11-06T00:34:15  *** soju has quit IRC
 222019-11-06T00:38:50  <wumpus> I might close #17385 again, I have only bad ideas lately
 232019-11-06T00:38:52  <gribble> https://github.com/bitcoin/bitcoin/issues/17385 | refactor: Use our own integer parsing/formatting everywhere by laanwj · Pull Request #17385 · bitcoin/bitcoin · GitHub
 242019-11-06T00:41:53  *** bitcoin-git has joined #bitcoin-core-dev
 252019-11-06T00:41:54  <bitcoin-git> [bitcoin] Empact closed pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
 262019-11-06T00:41:54  *** bitcoin-git has left #bitcoin-core-dev
 272019-11-06T00:47:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 282019-11-06T00:54:57  *** jb55 has quit IRC
 292019-11-06T00:57:25  *** lightlike has quit IRC
 302019-11-06T00:59:57  *** Highway61 has quit IRC
 312019-11-06T01:03:22  *** Zenton has joined #bitcoin-core-dev
 322019-11-06T01:09:41  *** jb55 has joined #bitcoin-core-dev
 332019-11-06T01:10:47  *** pinheadmz has quit IRC
 342019-11-06T01:10:56  *** Chris_Stewart_5 has quit IRC
 352019-11-06T01:15:22  *** bitcoin-git has joined #bitcoin-core-dev
 362019-11-06T01:15:22  <bitcoin-git> [bitcoin] MarceloGra opened pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
 372019-11-06T01:15:23  *** bitcoin-git has left #bitcoin-core-dev
 382019-11-06T01:16:47  *** bitcoin-git has joined #bitcoin-core-dev
 392019-11-06T01:16:47  <bitcoin-git> [bitcoin] MarceloGra closed pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
 402019-11-06T01:16:48  *** bitcoin-git has left #bitcoin-core-dev
 412019-11-06T02:07:29  *** Highway61 has joined #bitcoin-core-dev
 422019-11-06T02:16:01  *** cryptoIndio has joined #bitcoin-core-dev
 432019-11-06T02:19:32  *** cryptoIndio has quit IRC
 442019-11-06T02:20:06  *** cryptoIndio has joined #bitcoin-core-dev
 452019-11-06T02:32:54  *** kristapsk has quit IRC
 462019-11-06T02:32:56  *** kristapsk_ has joined #bitcoin-core-dev
 472019-11-06T02:33:27  *** DeanGuss has quit IRC
 482019-11-06T02:37:27  *** bitcoin-git has joined #bitcoin-core-dev
 492019-11-06T02:37:27  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45e65376ac9e...4e21f72980a7
 502019-11-06T02:37:28  <bitcoin-git> bitcoin/master fa7f5a4 MarcoFalke: doc: Update doc/bips.md with recent changes in master
 512019-11-06T02:37:28  <bitcoin-git> bitcoin/master 4e21f72 fanquake: Merge #17370: doc: Update doc/bips.md with recent changes in master
 522019-11-06T02:37:30  *** bitcoin-git has left #bitcoin-core-dev
 532019-11-06T02:37:47  *** bitcoin-git has joined #bitcoin-core-dev
 542019-11-06T02:37:47  <bitcoin-git> [bitcoin] fanquake merged pull request #17370: doc: Update doc/bips.md with recent changes in master (master...1911-docBips) https://github.com/bitcoin/bitcoin/pull/17370
 552019-11-06T02:37:49  *** bitcoin-git has left #bitcoin-core-dev
 562019-11-06T03:00:01  *** chipc has quit IRC
 572019-11-06T03:05:24  *** ddustin has joined #bitcoin-core-dev
 582019-11-06T03:05:42  *** emilengler_ has joined #bitcoin-core-dev
 592019-11-06T03:08:46  *** emilengler has quit IRC
 602019-11-06T03:09:44  *** ddustin has quit IRC
 612019-11-06T03:11:02  *** nosss2 has joined #bitcoin-core-dev
 622019-11-06T03:14:19  *** felixfoertsch23 has joined #bitcoin-core-dev
 632019-11-06T03:15:03  *** DeanGuss has joined #bitcoin-core-dev
 642019-11-06T03:15:39  *** felixfoertsch has quit IRC
 652019-11-06T03:20:56  *** ddustin has joined #bitcoin-core-dev
 662019-11-06T03:28:06  *** pinheadmz has joined #bitcoin-core-dev
 672019-11-06T03:45:00  *** ddustin has quit IRC
 682019-11-06T03:45:38  *** ddustin has joined #bitcoin-core-dev
 692019-11-06T03:46:47  *** cryptoIndio has quit IRC
 702019-11-06T03:48:30  *** justanotheruser has quit IRC
 712019-11-06T03:49:53  *** ddustin has quit IRC
 722019-11-06T04:13:45  *** iMast777 has joined #bitcoin-core-dev
 732019-11-06T04:17:13  *** Highway61 has quit IRC
 742019-11-06T04:20:13  *** Eagle[TM] has joined #bitcoin-core-dev
 752019-11-06T04:21:39  *** EagleTM has quit IRC
 762019-11-06T04:24:06  *** captjakk has joined #bitcoin-core-dev
 772019-11-06T04:28:41  *** cryptoIndio has joined #bitcoin-core-dev
 782019-11-06T04:31:07  *** justanotheruser has joined #bitcoin-core-dev
 792019-11-06T04:31:28  *** pinheadmz has quit IRC
 802019-11-06T05:03:01  *** nosss2 has quit IRC
 812019-11-06T05:12:39  *** nosss2 has joined #bitcoin-core-dev
 822019-11-06T05:16:51  *** cryptoIn_ has joined #bitcoin-core-dev
 832019-11-06T05:16:51  *** cryptoIndio has quit IRC
 842019-11-06T05:16:58  *** nosss2 has quit IRC
 852019-11-06T05:22:36  *** felixfoertsch23 has quit IRC
 862019-11-06T05:22:45  *** felixfoertsch has joined #bitcoin-core-dev
 872019-11-06T05:59:01  *** rh0nj has quit IRC
 882019-11-06T06:00:01  *** iMast777 has quit IRC
 892019-11-06T06:00:09  *** rh0nj has joined #bitcoin-core-dev
 902019-11-06T06:01:48  *** CubicEarth has quit IRC
 912019-11-06T06:05:56  *** nosss2 has joined #bitcoin-core-dev
 922019-11-06T06:06:47  *** gribble has quit IRC
 932019-11-06T06:06:59  *** thoragh has quit IRC
 942019-11-06T06:10:41  *** nosss2 has quit IRC
 952019-11-06T06:15:17  *** nosss2 has joined #bitcoin-core-dev
 962019-11-06T06:15:28  *** nhandler1 has joined #bitcoin-core-dev
 972019-11-06T06:19:39  *** nosss2 has quit IRC
 982019-11-06T06:22:35  *** nosss2 has joined #bitcoin-core-dev
 992019-11-06T06:25:49  *** cryptoIn_ has quit IRC
1002019-11-06T06:27:31  *** nosss2 has quit IRC
1012019-11-06T06:28:53  *** nosss2 has joined #bitcoin-core-dev
1022019-11-06T06:31:00  *** gribble has joined #bitcoin-core-dev
1032019-11-06T06:33:29  *** nosss2 has quit IRC
1042019-11-06T06:38:30  *** nosss2 has joined #bitcoin-core-dev
1052019-11-06T06:43:22  *** nosss2 has quit IRC
1062019-11-06T06:44:29  *** ghost43 has quit IRC
1072019-11-06T06:47:48  *** ghost43 has joined #bitcoin-core-dev
1082019-11-06T06:48:35  *** nosss2 has joined #bitcoin-core-dev
1092019-11-06T06:53:08  *** nosss2 has quit IRC
1102019-11-06T06:55:01  *** nosss2 has joined #bitcoin-core-dev
1112019-11-06T06:55:09  *** Karyon has quit IRC
1122019-11-06T06:55:55  *** alko89 has joined #bitcoin-core-dev
1132019-11-06T06:59:54  *** nosss2 has quit IRC
1142019-11-06T07:01:02  *** Deacyde has quit IRC
1152019-11-06T07:01:30  *** Deacyde has joined #bitcoin-core-dev
1162019-11-06T07:08:39  *** nosss2 has joined #bitcoin-core-dev
1172019-11-06T07:13:35  *** nosss2 has quit IRC
1182019-11-06T07:15:15  *** andytoshi has quit IRC
1192019-11-06T07:15:26  *** Eagle[TM] has quit IRC
1202019-11-06T07:17:34  *** nosss2 has joined #bitcoin-core-dev
1212019-11-06T07:25:06  *** nosss2 has quit IRC
1222019-11-06T07:31:02  *** Karyon has joined #bitcoin-core-dev
1232019-11-06T07:39:03  *** nosss2 has joined #bitcoin-core-dev
1242019-11-06T07:43:14  *** nosss2 has quit IRC
1252019-11-06T07:56:27  *** tsujp has quit IRC
1262019-11-06T07:58:06  *** tsujp has joined #bitcoin-core-dev
1272019-11-06T07:59:04  *** nosss2 has joined #bitcoin-core-dev
1282019-11-06T08:03:52  *** nosss2 has quit IRC
1292019-11-06T08:04:26  *** nosss2 has joined #bitcoin-core-dev
1302019-11-06T08:07:01  *** TheHoliestRoger has quit IRC
1312019-11-06T08:07:48  *** TheHoliestRoger has joined #bitcoin-core-dev
1322019-11-06T08:08:30  *** nosss2 has quit IRC
1332019-11-06T08:13:28  *** nosss2 has joined #bitcoin-core-dev
1342019-11-06T08:15:16  *** laptop500 has joined #bitcoin-core-dev
1352019-11-06T08:18:47  *** nosss2 has quit IRC
1362019-11-06T08:23:27  *** nosss2 has joined #bitcoin-core-dev
1372019-11-06T08:27:52  *** nosss2 has quit IRC
1382019-11-06T08:31:10  *** nosss2 has joined #bitcoin-core-dev
1392019-11-06T08:35:36  *** nosss2 has quit IRC
1402019-11-06T08:39:51  *** nosss2 has joined #bitcoin-core-dev
1412019-11-06T08:39:55  *** laptop500 has quit IRC
1422019-11-06T08:42:38  *** sdaftuar has quit IRC
1432019-11-06T08:43:01  *** sdaftuar has joined #bitcoin-core-dev
1442019-11-06T08:43:57  *** nosss2 has quit IRC
1452019-11-06T08:46:54  *** timothy has joined #bitcoin-core-dev
1462019-11-06T08:52:43  *** marcoagner has joined #bitcoin-core-dev
1472019-11-06T08:54:17  *** bitcoin-git has joined #bitcoin-core-dev
1482019-11-06T08:54:18  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e21f72980a7...224c19645fa0
1492019-11-06T08:54:18  <bitcoin-git> bitcoin/master 3645e4c Russell Yanofsky: Add missing newline in util_ChainMerge test
1502019-11-06T08:54:19  <bitcoin-git> bitcoin/master 224c196 Wladimir J. van der Laan: Merge #17388: Add missing newline in util_ChainMerge test
1512019-11-06T08:54:23  *** bitcoin-git has left #bitcoin-core-dev
1522019-11-06T08:54:42  *** bitcoin-git has joined #bitcoin-core-dev
1532019-11-06T08:54:42  <bitcoin-git> [bitcoin] laanwj merged pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
1542019-11-06T08:54:53  *** bitcoin-git has left #bitcoin-core-dev
1552019-11-06T08:57:23  *** nosss2 has joined #bitcoin-core-dev
1562019-11-06T08:59:53  *** b10c has joined #bitcoin-core-dev
1572019-11-06T09:00:01  *** nhandler1 has quit IRC
1582019-11-06T09:02:11  *** nosss2 has quit IRC
1592019-11-06T09:04:07  *** bitcoin-git has joined #bitcoin-core-dev
1602019-11-06T09:04:07  <bitcoin-git> [bitcoin] laanwj closed pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
1612019-11-06T09:04:08  *** bitcoin-git has left #bitcoin-core-dev
1622019-11-06T09:05:56  *** laptop500 has joined #bitcoin-core-dev
1632019-11-06T09:11:39  *** nosss2 has joined #bitcoin-core-dev
1642019-11-06T09:12:53  *** IGHOR has quit IRC
1652019-11-06T09:15:42  *** nosss2 has quit IRC
1662019-11-06T09:18:01  *** pabelanger1 has joined #bitcoin-core-dev
1672019-11-06T09:18:22  *** wxss has quit IRC
1682019-11-06T09:28:15  *** willcl_ark has quit IRC
1692019-11-06T09:29:09  *** nosss2 has joined #bitcoin-core-dev
1702019-11-06T09:30:54  *** IGHOR has joined #bitcoin-core-dev
1712019-11-06T09:33:34  *** nosss2 has quit IRC
1722019-11-06T09:44:06  *** willcl_ark has joined #bitcoin-core-dev
1732019-11-06T09:48:17  *** nosss2 has joined #bitcoin-core-dev
1742019-11-06T09:52:56  *** nosss2 has quit IRC
1752019-11-06T09:55:09  *** laptop500 has quit IRC
1762019-11-06T10:01:55  <wumpus> re: leveldb and suggest-override warnings, can we somehow get leveldb upstream to use 'override'
1772019-11-06T10:02:06  <wumpus> this would be better for them and us
1782019-11-06T10:02:10  *** nosss2 has joined #bitcoin-core-dev
1792019-11-06T10:03:14  <wumpus> oh it's already in? https://github.com/google/leveldb/commit/28e6d23
1802019-11-06T10:05:10  *** bitcoin-git has joined #bitcoin-core-dev
1812019-11-06T10:05:11  <bitcoin-git> [bitcoin] gr0kchain opened pull request #17393: Updated config file to include regtest (master...patch-2) https://github.com/bitcoin/bitcoin/pull/17393
1822019-11-06T10:05:11  <wumpus> how does this work, if I wanted to update leveldb to upstream, I guess I first need to update https://github.com/bitcoin-core/leveldb?
1832019-11-06T10:05:12  *** bitcoin-git has left #bitcoin-core-dev
1842019-11-06T10:06:57  *** nosss2 has quit IRC
1852019-11-06T10:07:47  *** bitcoin-git has joined #bitcoin-core-dev
1862019-11-06T10:07:47  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/224c19645fa0...7967104aee05
1872019-11-06T10:07:48  <bitcoin-git> bitcoin/master 3d05d33 fanquake: cli: fix -getinfo output when compiled with no wallet
1882019-11-06T10:07:48  <bitcoin-git> bitcoin/master 7967104 Wladimir J. van der Laan: Merge #17368: cli: fix -getinfo output when compiled with no wallet
1892019-11-06T10:07:50  *** bitcoin-git has left #bitcoin-core-dev
1902019-11-06T10:08:07  *** bitcoin-git has joined #bitcoin-core-dev
1912019-11-06T10:08:07  <bitcoin-git> [bitcoin] laanwj merged pull request #17368: cli: fix -getinfo output when compiled with no wallet (master...fix_getinfo_no_wallet) https://github.com/bitcoin/bitcoin/pull/17368
1922019-11-06T10:08:08  *** bitcoin-git has left #bitcoin-core-dev
1932019-11-06T10:09:00  <aj> wumpus: looks like that's how you did it in the past?
1942019-11-06T10:09:15  *** belcher has quit IRC
1952019-11-06T10:09:23  <wumpus> oh crap the trees have diverged quite a lot
1962019-11-06T10:09:34  <wumpus> aj: yes, it seems so! it was long ago
1972019-11-06T10:10:18  <aj> wumpus: oh, are we maintaining patches on leveldb?
1982019-11-06T10:11:07  <wumpus> yes for windows support mainly
1992019-11-06T10:11:52  *** bitcoin-git has joined #bitcoin-core-dev
2002019-11-06T10:11:53  <bitcoin-git> [bitcoin] sipsorcery closed pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
2012019-11-06T10:11:54  *** bitcoin-git has left #bitcoin-core-dev
2022019-11-06T10:12:38  <wumpus> woohoo, let's create an issue about it
2032019-11-06T10:21:29  *** bitcoin-git has joined #bitcoin-core-dev
2042019-11-06T10:21:29  <bitcoin-git> [bitcoin] sipsorcery reopened pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
2052019-11-06T10:21:30  *** bitcoin-git has left #bitcoin-core-dev
2062019-11-06T10:24:24  *** nosss2 has joined #bitcoin-core-dev
2072019-11-06T10:28:51  *** nosss2 has quit IRC
2082019-11-06T10:31:26  *** jonatack has joined #bitcoin-core-dev
2092019-11-06T10:41:35  <wumpus> I wonder if there is a way to disable the github editing interface (so to create patches from the web site) for a repostiory
2102019-11-06T10:42:20  *** nosss2 has joined #bitcoin-core-dev
2112019-11-06T10:42:23  <wumpus> seems always to be the people we have to explain how squashing works, or that open a new PR for every change in their change
2122019-11-06T10:46:26  *** nosss2 has quit IRC
2132019-11-06T10:51:22  *** nosss2 has joined #bitcoin-core-dev
2142019-11-06T10:56:12  *** nosss2 has quit IRC
2152019-11-06T10:57:50  <wumpus> re: leveldb upstream merge https://github.com/bitcoin-core/leveldb/issues/25
2162019-11-06T11:02:51  <wumpus> is it possible to do git conflict resolution as a series of commits instead of in the merge commit?
2172019-11-06T11:03:04  *** nosss2 has joined #bitcoin-core-dev
2182019-11-06T11:05:21  <wumpus> e.g. what is the best way to document the conflict resolution step by step and make it reviewable
2192019-11-06T11:06:26  *** timothy has quit IRC
2202019-11-06T11:07:55  *** nosss2 has quit IRC
2212019-11-06T11:11:17  *** thoragh has joined #bitcoin-core-dev
2222019-11-06T11:15:52  <wumpus> why is fixing this macos background image giving so much trouble?
2232019-11-06T11:17:25  *** nosss2 has joined #bitcoin-core-dev
2242019-11-06T11:21:52  *** nosss2 has quit IRC
2252019-11-06T11:23:46  *** laptop500 has joined #bitcoin-core-dev
2262019-11-06T11:25:42  <jonatack> A look in GH help didn't turn up anything wrt disabling the GH editing interface. Agree it would be helpful to be able to.
2272019-11-06T11:26:02  <wumpus> jonatack: couldn't find it either :(
2282019-11-06T11:26:03  *** nosss2 has joined #bitcoin-core-dev
2292019-11-06T11:27:29  *** timothy has joined #bitcoin-core-dev
2302019-11-06T11:28:04  <wumpus> nosss2: please fix your link, you've been reconnecting constantly over the last few days
2312019-11-06T11:34:15  *** nosss2 has quit IRC
2322019-11-06T11:34:32  <wumpus> jonatack: the main issue there is that the github editor pretends to be a user friendly git frontend, but then doesn't provide the tools (such as squashing) to make high-quality PRs
2332019-11-06T11:35:16  <wumpus> I don't think the idea behind it is wrong, it's just, a typical user trap, and we end up having to explain how to use git to people
2342019-11-06T11:36:38  <elichai2> I remember there was a specific channel for CIs but anyway, we can potentially use travis to test also arm+arm64! https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support
2352019-11-06T11:36:49  <wumpus> elichai2: we already do!
2362019-11-06T11:36:58  <elichai2> wumpus: really? lol
2372019-11-06T11:37:07  <elichai2> I thought this was a really new feature hehe
2382019-11-06T11:37:17  <wumpus> it is, but MarcoFalke is fast
2392019-11-06T11:37:21  <elichai2> :)
2402019-11-06T11:38:23  <wumpus> see e.g. https://travis-ci.org/bitcoin/bitcoin/builds/607861014?utm_source=github_status&utm_medium=notification, the topmost test build is arm64 now
2412019-11-06T11:39:49  <wumpus> (strictly, it builds for arm32 as that's a slightly more error-prone architecture, but that executes that natively on arm64)
2422019-11-06T11:44:15  *** IGHOR has quit IRC
2432019-11-06T11:45:31  <wumpus> is appveyor stuck?
2442019-11-06T11:45:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2452019-11-06T11:46:10  <wumpus> some PRs have been pending since last night
2462019-11-06T11:53:15  *** real_or_random has quit IRC
2472019-11-06T11:55:33  *** real_or_random has joined #bitcoin-core-dev
2482019-11-06T11:57:01  *** nosss2 has joined #bitcoin-core-dev
2492019-11-06T11:59:30  *** IGHOR has joined #bitcoin-core-dev
2502019-11-06T12:00:02  *** pabelanger1 has quit IRC
2512019-11-06T12:01:34  *** nosss2 has quit IRC
2522019-11-06T12:06:30  *** justanotheruser has quit IRC
2532019-11-06T12:12:28  *** kljasdfvv has quit IRC
2542019-11-06T12:12:35  *** nosss2 has joined #bitcoin-core-dev
2552019-11-06T12:12:52  *** kljasdfvv has joined #bitcoin-core-dev
2562019-11-06T12:13:08  *** rosseaux1 has joined #bitcoin-core-dev
2572019-11-06T12:13:58  *** IGHOR has quit IRC
2582019-11-06T12:16:50  *** nosss2 has quit IRC
2592019-11-06T12:18:07  *** nosss2 has joined #bitcoin-core-dev
2602019-11-06T12:18:47  *** laptop500 has quit IRC
2612019-11-06T12:22:42  *** diogosergio has joined #bitcoin-core-dev
2622019-11-06T12:23:09  *** nosss2 has quit IRC
2632019-11-06T12:33:42  *** nosss2 has joined #bitcoin-core-dev
2642019-11-06T12:37:07  *** Highway61 has joined #bitcoin-core-dev
2652019-11-06T12:43:00  *** bitcoin-git has joined #bitcoin-core-dev
2662019-11-06T12:43:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7967104aee05...22a58811d4ee
2672019-11-06T12:43:02  <bitcoin-git> bitcoin/master 2ad74b7 Hennadii Stepanov: doc: Add ShellCheck to lint tests dependencies
2682019-11-06T12:43:02  <bitcoin-git> bitcoin/master 80c9e66 Hennadii Stepanov: build: Remove install command samples
2692019-11-06T12:43:03  <bitcoin-git> bitcoin/master 22a5881 MarcoFalke: Merge #17353: doc: Add ShellCheck to lint tests dependencies
2702019-11-06T12:43:05  *** bitcoin-git has left #bitcoin-core-dev
2712019-11-06T12:43:20  *** bitcoin-git has joined #bitcoin-core-dev
2722019-11-06T12:43:20  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17353: doc: Add ShellCheck to lint tests dependencies (master...20191102-lint-dependencies) https://github.com/bitcoin/bitcoin/pull/17353
2732019-11-06T12:43:22  *** bitcoin-git has left #bitcoin-core-dev
2742019-11-06T12:45:57  *** nosss2 has quit IRC
2752019-11-06T12:54:11  *** Chris_Stewart_5 has quit IRC
2762019-11-06T12:55:15  *** nosss2 has joined #bitcoin-core-dev
2772019-11-06T12:59:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2782019-11-06T13:00:02  <jonatack> wumpus: appveyor was throwing errors possibly related to merged PR #17357 "bech32_tests.obj : error LNK2001: unresolved external symbol "bool __cdecl CaseInsensitiveEqual"
2792019-11-06T13:00:04  <gribble> https://github.com/bitcoin/bitcoin/issues/17357 | tests: Add fuzzing harness for Bech32 encoding/decoding by practicalswift · Pull Request #17357 · bitcoin/bitcoin · GitHub
2802019-11-06T13:00:14  *** nosss2 has quit IRC
2812019-11-06T13:01:12  *** bitcoin-git has joined #bitcoin-core-dev
2822019-11-06T13:01:12  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22a58811d4ee...86771d431054
2832019-11-06T13:01:13  <bitcoin-git> bitcoin/master 7b78b8d Michael Folkson: doc: Add template for good first issues
2842019-11-06T13:01:13  <bitcoin-git> bitcoin/master 86771d4 Wladimir J. van der Laan: Merge #17339: doc: Add template for good first issues
2852019-11-06T13:01:15  *** bitcoin-git has left #bitcoin-core-dev
2862019-11-06T13:01:32  *** bitcoin-git has joined #bitcoin-core-dev
2872019-11-06T13:01:32  <bitcoin-git> [bitcoin] laanwj merged pull request #17339: doc: Add template for good first issues (master...20191101-first-issue) https://github.com/bitcoin/bitcoin/pull/17339
2882019-11-06T13:01:33  *** bitcoin-git has left #bitcoin-core-dev
2892019-11-06T13:01:39  *** nosss2 has joined #bitcoin-core-dev
2902019-11-06T13:06:16  *** nosss2 has quit IRC
2912019-11-06T13:07:37  *** jonatack has quit IRC
2922019-11-06T13:12:08  *** nosss2 has joined #bitcoin-core-dev
2932019-11-06T13:14:25  <wumpus> nosss2: please fix your connection or I'll have to ban your for now, these constant ping timeouts generate too much noise
2942019-11-06T13:14:52  *** justanotheruser has joined #bitcoin-core-dev
2952019-11-06T13:15:31  *** nosss2 has quit IRC
2962019-11-06T13:16:13  *** nosss2 has joined #bitcoin-core-dev
2972019-11-06T13:20:17  *** nosss2 has quit IRC
2982019-11-06T13:28:06  *** nosss2 has joined #bitcoin-core-dev
2992019-11-06T13:28:20  *** ChanServ sets mode: +o wumpus
3002019-11-06T13:29:59  *** wumpus sets mode: +b *!*@gateway/vpn/privateinternetaccess/nosss2
3012019-11-06T13:30:07  *** ChanServ sets mode: -o wumpus
3022019-11-06T13:30:43  <wumpus> is there any way to add a comment to a ban here? or make it temporary?
3032019-11-06T13:30:58  *** diogosergio has quit IRC
3042019-11-06T13:32:50  *** nosss2 has quit IRC
3052019-11-06T13:44:33  *** Highway61 has quit IRC
3062019-11-06T13:51:15  *** lightlike has joined #bitcoin-core-dev
3072019-11-06T14:05:53  *** Chris_Stewart_5 has quit IRC
3082019-11-06T14:08:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3092019-11-06T14:11:54  *** IGHOR has joined #bitcoin-core-dev
3102019-11-06T14:25:00  *** spaced0ut has joined #bitcoin-core-dev
3112019-11-06T14:29:55  *** jonatack has joined #bitcoin-core-dev
3122019-11-06T14:36:02  *** pinheadmz has joined #bitcoin-core-dev
3132019-11-06T15:00:01  *** rosseaux1 has quit IRC
3142019-11-06T15:06:45  *** kristapsk_ has quit IRC
3152019-11-06T15:14:21  <aj> wumpus: think chanserv should be able to make temporary bans, not sure about comments
3162019-11-06T15:16:46  *** captjakk has quit IRC
3172019-11-06T15:17:31  *** WiQert has joined #bitcoin-core-dev
3182019-11-06T15:17:44  <wumpus> aj: thanks, will check the chanserv docs
3192019-11-06T15:19:46  *** mdunnio has joined #bitcoin-core-dev
3202019-11-06T15:22:26  <aj> looks like chanserv akick will accept a reason but isn't temporary?
3212019-11-06T15:26:18  *** SiAnDoG has joined #bitcoin-core-dev
3222019-11-06T15:26:24  *** mdunnio has quit IRC
3232019-11-06T15:27:26  <wumpus> looks like it can do both, !T <time> and reason (always the last part) can both be specified
3242019-11-06T15:27:45  *** mdunnio has joined #bitcoin-core-dev
3252019-11-06T15:27:52  *** ChanServ sets mode: +o wumpus
3262019-11-06T15:28:05  *** wumpus sets mode: -b *!*@gateway/vpn/privateinternetaccess/nosss2
3272019-11-06T15:28:10  *** ChanServ sets mode: -o wumpus
3282019-11-06T15:34:49  <jb55> wumpus: don't most people filter those? that would drive me insane.
3292019-11-06T15:41:36  <arapaho> I agree, ignoring joins/parts/quits could help.
3302019-11-06T15:43:12  *** nosss2 has joined #bitcoin-core-dev
3312019-11-06T15:43:58  <wumpus> I don't know what most people do tbh
3322019-11-06T15:45:32  <wumpus> I definitely know how to filter them, if you mean that, but I prefer not to for channels I'm op in, as those messages can be used for spamming and such
3332019-11-06T15:46:00  *** goatpig_ is now known as goatpig
3342019-11-06T15:46:02  <jb55> just not sure about banning someone for protocol noise xD
3352019-11-06T15:46:14  <jb55> unless it's was purposeful spamming of course ...
3362019-11-06T15:46:17  <wumpus> sigh... do you really want an argument about htat
3372019-11-06T15:46:22  <jb55> not really
3382019-11-06T15:47:17  <wumpus> it's not like I do that daily, this was just getting annoying
3392019-11-06T15:48:11  *** thoragh has quit IRC
3402019-11-06T15:49:03  *** soju has joined #bitcoin-core-dev
3412019-11-06T16:02:01  *** bitcoin-git has joined #bitcoin-core-dev
3422019-11-06T16:02:02  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86771d431054...6f4e24735791
3432019-11-06T16:02:02  <bitcoin-git> bitcoin/master 286f197 Russell Yanofsky: Add util_ArgParsing test
3442019-11-06T16:02:03  <bitcoin-git> bitcoin/master 6f4e247 Wladimir J. van der Laan: Merge #17390: test: Add util_ArgParsing test
3452019-11-06T16:02:05  *** bitcoin-git has left #bitcoin-core-dev
3462019-11-06T16:02:21  *** bitcoin-git has joined #bitcoin-core-dev
3472019-11-06T16:02:21  <bitcoin-git> [bitcoin] laanwj merged pull request #17390: test: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
3482019-11-06T16:02:22  *** bitcoin-git has left #bitcoin-core-dev
3492019-11-06T16:04:36  *** thoragh has joined #bitcoin-core-dev
3502019-11-06T16:05:21  *** captjakk has joined #bitcoin-core-dev
3512019-11-06T16:06:25  <wumpus> promag: congrats with getting an emoji into a commit message, dunno if it's a first 😃  https://github.com/bitcoin/bitcoin/commit/6f4e2473579168dffd46d54fa1eedd287395200b
3522019-11-06T16:06:54  <luke-jr> lol
3532019-11-06T16:07:35  <sipa> Ĺèŧ ţĥę Ữňîĉởďė çöḿḿịŧš bệğịñ!
3542019-11-06T16:08:42  <wumpus> hehe
3552019-11-06T16:08:49  <fanquake> 👀
3562019-11-06T16:09:28  *** thoragh has quit IRC
3572019-11-06T16:10:30  <fanquake> Thought #13859 might have had one, but no, that may be the first
3582019-11-06T16:10:32  <gribble> https://github.com/bitcoin/bitcoin/issues/13859 | qa: Add emojis to test_runner path and wallet filename by MarcoFalke · Pull Request #13859 · bitcoin/bitcoin · GitHub
3592019-11-06T16:10:45  *** pinheadmz has quit IRC
3602019-11-06T16:10:59  <luke-jr> 😑
3612019-11-06T16:11:00  *** mdunnio has quit IRC
3622019-11-06T16:17:32  *** mdunnio has joined #bitcoin-core-dev
3632019-11-06T16:18:32  *** captjakk_ has joined #bitcoin-core-dev
3642019-11-06T16:22:01  *** captjakk has quit IRC
3652019-11-06T16:23:32  *** lowentropy has quit IRC
3662019-11-06T16:23:47  *** lowentropy has joined #bitcoin-core-dev
3672019-11-06T16:26:27  *** thoragh has joined #bitcoin-core-dev
3682019-11-06T16:29:39  *** bitcoin-git has joined #bitcoin-core-dev
3692019-11-06T16:29:41  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4e24735791...976cc766c428
3702019-11-06T16:29:42  <bitcoin-git> bitcoin/master b07b07c Russell Yanofsky: Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp
3712019-11-06T16:29:42  <bitcoin-git> bitcoin/master 4a0abf6 Russell Yanofsky: Pass CTxDestination to ScriptPubKeyMan::GetMetadata
3722019-11-06T16:29:43  <bitcoin-git> bitcoin/master 491a599 Russell Yanofsky: Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method
3732019-11-06T16:29:52  *** bitcoin-git has left #bitcoin-core-dev
3742019-11-06T16:30:09  *** bitcoin-git has joined #bitcoin-core-dev
3752019-11-06T16:30:10  <bitcoin-git> [bitcoin] laanwj merged pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
3762019-11-06T16:30:22  *** bitcoin-git has left #bitcoin-core-dev
3772019-11-06T16:31:26  *** ddustin has joined #bitcoin-core-dev
3782019-11-06T16:38:50  *** thoragh has left #bitcoin-core-dev
3792019-11-06T16:39:53  *** michaelfolkson has joined #bitcoin-core-dev
3802019-11-06T16:43:37  <promag> wumpus: sorry you can push -f to master :P
3812019-11-06T16:45:21  *** AaronvanW has joined #bitcoin-core-dev
3822019-11-06T16:46:10  <wumpus> promag: push -😡
3832019-11-06T16:47:26  <promag> anyway, I'll stop using emojis :trollface:
3842019-11-06T16:48:34  <wumpus> I didn't mean it as a "don't do this", just thought it was funny
3852019-11-06T16:50:09  *** diogosergio has joined #bitcoin-core-dev
3862019-11-06T16:52:35  <instagibbs> ryanofsky, https://github.com/bitcoin/bitcoin/pull/17258 has all the breadcrumbs necessary in the OP, I think that's plenty of credit
3872019-11-06T16:53:33  <instagibbs> wonder if there's written down policy for this. I recently revived the explicit feerate PR from someone who disappeared, i actually forgot to give myself any credit in the commits... probably only showed up in the merge commit message
3882019-11-06T16:53:52  <instagibbs> which again would be enough to do some detective work
3892019-11-06T16:53:53  *** shesek has joined #bitcoin-core-dev
3902019-11-06T16:53:53  *** shesek has quit IRC
3912019-11-06T16:53:53  *** shesek has joined #bitcoin-core-dev
3922019-11-06T16:54:53  *** Emcy has quit IRC
3932019-11-06T16:56:56  *** emilengler_ has quit IRC
3942019-11-06T16:59:32  *** Emcy has joined #bitcoin-core-dev
3952019-11-06T17:00:18  <wumpus> no, there's no policy for that, in general, just give credit where credit is due and don't be a dick about it
3962019-11-06T17:01:07  <wumpus> better to over-credit than under
3972019-11-06T17:02:27  *** emilengler has joined #bitcoin-core-dev
3982019-11-06T17:06:19  *** bitcoin-git has joined #bitcoin-core-dev
3992019-11-06T17:06:20  <bitcoin-git> [bitcoin] icota opened pull request #17396: build: modest Android improvements (master...2019-11-android-static-libstdc) https://github.com/bitcoin/bitcoin/pull/17396
4002019-11-06T17:06:32  *** bitcoin-git has left #bitcoin-core-dev
4012019-11-06T17:06:42  *** soju has quit IRC
4022019-11-06T17:07:00  *** captjakk_ has quit IRC
4032019-11-06T17:07:03  *** Highway61 has joined #bitcoin-core-dev
4042019-11-06T17:07:35  <wumpus> but also not really sure what ryanofsky's point is here, I mean it's definitely possible to give even more credit than mentioning someone's name in the commit metadata and the commit itself, but what then, I think what count here is that adamjonas did his best to credit
4052019-11-06T17:08:46  <wumpus> should we be angry at him for not crediting enough?
4062019-11-06T17:08:53  <luke-jr> instagibbs: git does record the committer independently from the author
4072019-11-06T17:09:00  <ryanofsky> i'm just saying it is possible to give more credit and explanation than was given, and i usually try to do that by writing comments that give credit
4082019-11-06T17:09:25  <ryanofsky> i have no opinion on "enough". enough credit for me is usually 0, for other people it may be more
4092019-11-06T17:09:27  <wumpus> I mean it's never enough
4102019-11-06T17:09:53  <ryanofsky> wumpus, doubt that is true unless the person is imbalanced or something
4112019-11-06T17:11:05  <wumpus> yes, but your point is basically 'you can always do more'
4122019-11-06T17:11:06  <wumpus> sure
4132019-11-06T17:11:25  <ryanofsky> no, my point is in that specific case, more could have been done
4142019-11-06T17:11:36  <wumpus> yes, it could
4152019-11-06T17:11:59  <luke-jr> I suspect Diapolo left over credit issues
4162019-11-06T17:13:38  *** Highway61 has quit IRC
4172019-11-06T17:19:53  *** captjakk has joined #bitcoin-core-dev
4182019-11-06T17:20:29  *** captjakk has joined #bitcoin-core-dev
4192019-11-06T17:20:51  *** CubicEarth has joined #bitcoin-core-dev
4202019-11-06T17:21:06  <provoostenator> The merge commit could add Reviewed-by or Acked-by tags?
4212019-11-06T17:21:06  <MarcoFalke> promag: We should be using more emojis
4222019-11-06T17:21:39  <MarcoFalke> I will adjust my script to do that. emojis will be signed and timestamped, of course
4232019-11-06T17:22:52  <luke-jr> replace ACKs/NACKs with emoji codes?
4242019-11-06T17:24:04  <MarcoFalke> 👍
4252019-11-06T17:25:00  <luke-jr> (on a serious note, I would find that rather annoying)
4262019-11-06T17:28:08  *** mdunnio has quit IRC
4272019-11-06T17:29:03  *** mdunnio has joined #bitcoin-core-dev
4282019-11-06T17:31:25  *** mdunnio has quit IRC
4292019-11-06T17:33:01  <aj> MarcoFalke: bech32 but with an alphabet of emojis?
4302019-11-06T17:33:05  *** mdunnio has joined #bitcoin-core-dev
4312019-11-06T17:37:03  <MarcoFalke> 🤯
4322019-11-06T17:37:04  <wumpus> there's at least a base1024 encoding with emoji: https://github.com/keith-turner/ecoji
4332019-11-06T17:44:00  <luke-jr> MarcoFalke: I see nothing there
4342019-11-06T17:44:43  *** cncr04s has quit IRC
4352019-11-06T17:47:36  <wumpus> riot.im e2e uses something like that to cross-verify keys (the idea is that a list of emoji+their names is easier to communicate than say, a hex string)
4362019-11-06T17:47:50  *** cncr04s has joined #bitcoin-core-dev
4372019-11-06T17:47:57  *** mdunnio has quit IRC
4382019-11-06T17:59:37  *** bsm1175321 has joined #bitcoin-core-dev
4392019-11-06T18:00:02  *** WiQert has quit IRC
4402019-11-06T18:02:50  *** diogosergio has quit IRC
4412019-11-06T18:08:30  *** andytoshi has joined #bitcoin-core-dev
4422019-11-06T18:08:30  *** andytoshi has joined #bitcoin-core-dev
4432019-11-06T18:11:01  *** michaelfolkson has quit IRC
4442019-11-06T18:18:55  *** thoragh has joined #bitcoin-core-dev
4452019-11-06T18:20:14  *** captjakk has quit IRC
4462019-11-06T18:20:48  *** captjakk has joined #bitcoin-core-dev
4472019-11-06T18:23:04  *** captjakk has quit IRC
4482019-11-06T18:27:06  *** ddustin has quit IRC
4492019-11-06T18:30:13  *** mdunnio has joined #bitcoin-core-dev
4502019-11-06T18:30:18  *** michaelfolkson has joined #bitcoin-core-dev
4512019-11-06T18:39:13  *** pinheadmz has joined #bitcoin-core-dev
4522019-11-06T18:42:21  *** timothy has quit IRC
4532019-11-06T18:46:23  *** netsoundW has joined #bitcoin-core-dev
4542019-11-06T18:49:11  *** owowo has quit IRC
4552019-11-06T18:49:18  *** ovovo has joined #bitcoin-core-dev
4562019-11-06T18:50:16  *** jarthur has joined #bitcoin-core-dev
4572019-11-06T18:55:11  *** bitcoin-git has joined #bitcoin-core-dev
4582019-11-06T18:55:12  <bitcoin-git> [bitcoin] laanwj reopened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
4592019-11-06T18:55:13  *** bitcoin-git has left #bitcoin-core-dev
4602019-11-06T18:55:58  *** justanotheruser has quit IRC
4612019-11-06T18:56:59  *** justanotheruser has joined #bitcoin-core-dev
4622019-11-06T19:03:48  *** ddustin has joined #bitcoin-core-dev
4632019-11-06T19:10:17  *** captjakk has joined #bitcoin-core-dev
4642019-11-06T19:11:11  *** captjakk has joined #bitcoin-core-dev
4652019-11-06T19:14:29  *** captjakk has quit IRC
4662019-11-06T19:21:57  *** b10c has quit IRC
4672019-11-06T19:22:31  *** PaulTroon has joined #bitcoin-core-dev
4682019-11-06T19:28:10  *** PaulTroon has quit IRC
4692019-11-06T19:28:39  *** PaulTroon has joined #bitcoin-core-dev
4702019-11-06T19:37:19  *** kristapsk has joined #bitcoin-core-dev
4712019-11-06T19:43:56  *** PaulTroon has quit IRC
4722019-11-06T19:44:36  *** PaulTroon has joined #bitcoin-core-dev
4732019-11-06T19:50:35  *** PaulTroon has quit IRC
4742019-11-06T19:51:46  *** PaulTroon has joined #bitcoin-core-dev
4752019-11-06T19:54:08  *** PaulTroon has quit IRC
4762019-11-06T19:55:35  *** bsm1175321 has quit IRC
4772019-11-06T20:08:56  *** ddustin has quit IRC
4782019-11-06T20:09:32  *** ddustin has joined #bitcoin-core-dev
4792019-11-06T20:13:38  *** ddustin has quit IRC
4802019-11-06T20:20:05  *** bitcoin-git has joined #bitcoin-core-dev
4812019-11-06T20:20:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/976cc766c428...e65b4160e99f
4822019-11-06T20:20:07  <bitcoin-git> bitcoin/master 646b593 John Newbery: [tests] Speed up rpc_fundrawtransaction.py
4832019-11-06T20:20:08  <bitcoin-git> bitcoin/master 9a85052 John Newbery: [tests] Use -whitelist in rpc_fundrawtransaction.py
4842019-11-06T20:20:09  <bitcoin-git> bitcoin/master af7bae7 John Newbery: [tests] Don't stop-start unnecessarily in rpc_fundrawtransaction.py
4852019-11-06T20:20:11  *** bitcoin-git has left #bitcoin-core-dev
4862019-11-06T20:20:25  *** bitcoin-git has joined #bitcoin-core-dev
4872019-11-06T20:20:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17340: Tests: speed up fundrawtransaction test (master...2019-11-speed-up-fundrawtransaction-test) https://github.com/bitcoin/bitcoin/pull/17340
4882019-11-06T20:20:26  *** bitcoin-git has left #bitcoin-core-dev
4892019-11-06T20:24:12  <wumpus> oh nice, there's a env_windows.cpp in the new upstream leveldb, we might be able to stop maintaining our own env_win https://github.com/bitcoin-core/leveldb/pull/26  this handles the file functions and such, it will be a lot of work to test/investigate the differences though
4902019-11-06T20:25:50  <sipa> nice, and it's not a crazy boost based thing like the old windows branch of leveldb had
4912019-11-06T20:27:14  <wumpus> yup, no boost at all! it's entirely native
4922019-11-06T20:29:24  <wumpus> ARM crc32c will be nice too
4932019-11-06T20:31:43  <sipa> wumpus: so... can we just drop our own fork?
4942019-11-06T20:32:19  <sipa> (for consistency reasons we may not want to actually do that, but equivalently we can just undo all our local modifications?)
4952019-11-06T20:32:59  <sipa> since we have our own build system overriding leveldb's, the forced-no-snappy thing can be dealt with there
4962019-11-06T20:35:17  *** andytoshi has quit IRC
4972019-11-06T20:36:09  <wumpus> there's some changes that I'd like to keep: the GetName on files, used for diagnostics, the "Do not crash if filesystem can't fsync" patch (handle EINVAL on directory sync), but yes, I'm thinking instead of merging, might as well restart with a small patch stack on upstream
4982019-11-06T20:37:23  <sipa> right.
4992019-11-06T20:37:39  <sipa> don't we have some local changes to observe memory usage or so?
5002019-11-06T20:37:47  <sipa> or was that just something i experimented with
5012019-11-06T20:37:51  <jnewbery> has there ever been an effort to upstream those small patches?
5022019-11-06T20:38:22  <wumpus> (also possibly the 1000 to 4096 patch, though if we can use the test interface, it seems we don't need that anymore)
5032019-11-06T20:38:25  <sipa> jnewbery: i don't think so; leveldb used to be very slow in accepting patches, i think maybe that has improved over the past two years
5042019-11-06T20:38:55  <wumpus> I've never tried at least
5052019-11-06T20:39:34  <wumpus> another reason to make a patch stack instead
5062019-11-06T20:39:50  <wumpus> sipa: I don't remember seeing any memory-related changes, let me see
5072019-11-06T20:40:43  <wumpus> LOL this is a change we have:
5082019-11-06T20:40:44  <wumpus> -// where enough posix functionality is available.
5092019-11-06T20:40:46  <wumpus> +// where enough Posix functionality is available.
5102019-11-06T20:41:58  <wumpus> yes, the no_snappy thing we can deal with in your build system
5112019-11-06T20:43:29  *** diogosergio has joined #bitcoin-core-dev
5122019-11-06T20:47:04  <wumpus> HAVE_SNAPPY Define to 1 if you have Google Snappy. -> should be hardwired to 0 for us, obviously
5132019-11-06T20:50:14  *** mdunnio has quit IRC
5142019-11-06T20:50:40  *** diogosergio has quit IRC
5152019-11-06T20:51:19  <sipa> i'll be very happy if we can actually stop relying on our own weird windows port
5162019-11-06T20:51:23  <wumpus> no, there's no memory related changes
5172019-11-06T20:51:32  <sipa> ok.
5182019-11-06T20:52:30  <wumpus> and same :)
5192019-11-06T20:56:28  <sipa> seems they even have tests for the windows port!
5202019-11-06T20:56:41  <sipa> s/port/env/
5212019-11-06T20:58:05  *** michaelfolkson has quit IRC
5222019-11-06T20:58:54  *** diogosergio has joined #bitcoin-core-dev
5232019-11-06T20:59:19  <wumpus> even tests that pass, I'd guess (https://github.com/bitcoin-core/leveldb/issues/8)
5242019-11-06T21:00:01  *** netsoundW has quit IRC
5252019-11-06T21:02:13  *** mdunnio has joined #bitcoin-core-dev
5262019-11-06T21:13:48  <roasbeef> what's the name of the IRC bot y'all use for merges now?
5272019-11-06T21:17:40  *** jhf has joined #bitcoin-core-dev
5282019-11-06T21:25:14  <wumpus> roasbeef: we run our own instance of https://github.com/gkrizek/ghi
5292019-11-06T21:33:37  *** diogosergio has quit IRC
5302019-11-06T21:36:22  *** belcher has joined #bitcoin-core-dev
5312019-11-06T21:47:39  <wumpus> I could add channels to the bot, if you'd rather not host your own
5322019-11-06T21:48:41  *** davterra has joined #bitcoin-core-dev
5332019-11-06T21:54:47  *** PaulTroon has joined #bitcoin-core-dev
5342019-11-06T21:55:30  <wumpus> is it possible to do a git merge and simply ignore all your own files to replace them with upstream?
5352019-11-06T21:56:02  <wumpus> so logically it's a merge but it retains nothing of the original code
5362019-11-06T21:56:39  <gwillen> wumpus: it looks like you can do "git merge -X theirs":https://stackoverflow.com/questions/173919/is-there-a-theirs-version-of-git-merge-s-ours
5372019-11-06T21:56:46  <gwillen> wit some caveats
5382019-11-06T21:57:10  *** mdunnio has quit IRC
5392019-11-06T21:57:23  <sipa> wumpus: yeah, a merge commit is just a commit that has 2 parents
5402019-11-06T21:57:28  <sipa> it can effectively do anything
5412019-11-06T21:57:29  <wumpus> (this is just to make the subtree merge easier, I don't think it'll be happy with a rebase in between)
5422019-11-06T21:57:36  <wumpus> sipa: gwillen  thanks!
5432019-11-06T21:57:46  <sipa> including replacing everything with a completely unrelated tree
5442019-11-06T21:57:59  <gwillen> np!
5452019-11-06T21:58:05  *** vincenzopalazzo has joined #bitcoin-core-dev
5462019-11-06T22:00:03  *** PaulTroon has quit IRC
5472019-11-06T22:04:46  *** andytoshi has joined #bitcoin-core-dev
5482019-11-06T22:04:47  *** andytoshi has joined #bitcoin-core-dev
5492019-11-06T22:05:45  *** diogosergio has joined #bitcoin-core-dev
5502019-11-06T22:07:34  *** vincenzopalazzo has quit IRC
5512019-11-06T22:19:04  *** nosss2 has quit IRC
5522019-11-06T22:20:21  *** nosss2 has joined #bitcoin-core-dev
5532019-11-06T22:24:31  *** pinheadmz has quit IRC
5542019-11-06T22:25:39  <sipa> wumpus: fwiw, git subtree works fine with undoing commits
5552019-11-06T22:25:42  <sipa> in the subtree
5562019-11-06T22:26:31  <sipa> i think we could reasonable create a new branch in bitcoin-core/leveldb which is equal to the google/leveldb one + a few patches
5572019-11-06T22:26:43  <sipa> and then use git subtree to switch our directory to that
5582019-11-06T22:32:26  <wumpus> ok, will ook at that, for now I managed to change the PR to revert all our changes then re-apply the three that still matter
5592019-11-06T22:34:38  <sipa> subtree will in this case just produce a squash commit that has message "Delete commit X; Delete commit Y; Add commit Z; ..."
5602019-11-06T22:35:04  <sipa> the old and the new tree must have a common ancestor, though
5612019-11-06T22:43:45  *** spaced0ut has quit IRC
5622019-11-06T22:44:08  <wumpus> it automatically figures that out? that sounds pretty good
5632019-11-06T22:44:35  *** Chris_Stewart_5 has quit IRC
5642019-11-06T22:55:49  *** thoragh has quit IRC
5652019-11-06T22:56:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5662019-11-06T23:08:10  *** bitcoin-git has joined #bitcoin-core-dev
5672019-11-06T23:08:10  <bitcoin-git> [bitcoin] laanwj opened pull request #17398: WIP: Update leveldb to 1.22+ (master...2019_11_leveldb_upstream) https://github.com/bitcoin/bitcoin/pull/17398
5682019-11-06T23:08:11  *** bitcoin-git has left #bitcoin-core-dev
5692019-11-06T23:15:08  *** Chris_Stewart_5 has quit IRC
5702019-11-06T23:19:00  *** soju has joined #bitcoin-core-dev
5712019-11-06T23:26:59  <promag> MarcoFalke: you could sort includes too in #17384 🍻
5722019-11-06T23:27:01  <gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke · Pull Request #17384 · bitcoin/bitcoin · GitHub
5732019-11-06T23:29:15  *** nosss2 has quit IRC
5742019-11-06T23:48:42  *** marcoagner has quit IRC
5752019-11-06T23:53:51  *** michaelfolkson has joined #bitcoin-core-dev
5762019-11-06T23:53:57  *** diogosergio has quit IRC
5772019-11-06T23:56:21  *** PaulTroon has joined #bitcoin-core-dev
5782019-11-06T23:56:48  *** michaelfolkson has quit IRC
5792019-11-06T23:57:39  *** diogosergio has joined #bitcoin-core-dev