12019-11-14T00:00:01 *** kinouchou has quit IRC
22019-11-14T00:15:14 *** c-cex-finch_ has quit IRC
32019-11-14T00:17:30 *** xrogaan has joined #bitcoin-core-dev
42019-11-14T00:17:53 *** xrogaan is now known as Guest36903
52019-11-14T00:19:38 *** Giszmo has joined #bitcoin-core-dev
62019-11-14T00:21:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
72019-11-14T00:28:06 *** nik-j_ has joined #bitcoin-core-dev
82019-11-14T00:37:17 *** nik-j_ has quit IRC
92019-11-14T00:45:10 *** EagleTM has joined #bitcoin-core-dev
102019-11-14T00:45:41 *** sipsorcery has quit IRC
112019-11-14T00:48:56 *** sipsorcery has joined #bitcoin-core-dev
122019-11-14T00:50:01 *** rh0nj has quit IRC
132019-11-14T00:57:56 *** JamesAU_ has joined #bitcoin-core-dev
142019-11-14T01:01:03 *** JamesAU has quit IRC
152019-11-14T01:11:41 *** JamesAU_ has quit IRC
162019-11-14T01:18:26 *** openoms has quit IRC
172019-11-14T01:31:00 *** Chris_Stewart_5 has quit IRC
182019-11-14T01:56:31 *** soju has quit IRC
192019-11-14T02:02:49 *** soju has joined #bitcoin-core-dev
202019-11-14T02:07:33 *** AaronvanW has quit IRC
212019-11-14T02:24:19 *** EagleTM has quit IRC
222019-11-14T02:31:04 *** Victorsueca has quit IRC
232019-11-14T02:32:13 *** Victorsueca has joined #bitcoin-core-dev
242019-11-14T02:54:21 *** kristapsk has quit IRC
252019-11-14T02:54:37 *** sipsorcery has quit IRC
262019-11-14T02:54:47 *** kristapsk has joined #bitcoin-core-dev
272019-11-14T03:00:02 *** Guest36903 has quit IRC
282019-11-14T03:00:07 *** designwish has quit IRC
292019-11-14T03:09:20 *** Highway61 has quit IRC
302019-11-14T03:09:56 *** designwish has joined #bitcoin-core-dev
312019-11-14T03:16:37 *** IGHOR has quit IRC
322019-11-14T03:17:14 *** felixfoertsch23 has joined #bitcoin-core-dev
332019-11-14T03:17:33 *** pehjota1 has joined #bitcoin-core-dev
342019-11-14T03:18:28 *** felixfoertsch has quit IRC
352019-11-14T03:25:12 *** IGHOR has joined #bitcoin-core-dev
362019-11-14T03:45:48 *** w0lfg4ng has joined #bitcoin-core-dev
372019-11-14T03:50:50 *** sipsorcery has joined #bitcoin-core-dev
382019-11-14T04:00:13 *** w0lfg4ng has quit IRC
392019-11-14T04:23:27 *** Highway61 has joined #bitcoin-core-dev
402019-11-14T04:33:14 *** Highway61 has quit IRC
412019-11-14T04:36:31 *** soju has quit IRC
422019-11-14T04:37:18 *** bitcoin-git has joined #bitcoin-core-dev
432019-11-14T04:37:19 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17473: refactor: Settings code cleanups (master...pr/cleanset) https://github.com/bitcoin/bitcoin/pull/17473
442019-11-14T04:37:20 *** bitcoin-git has left #bitcoin-core-dev
452019-11-14T04:57:15 *** sipsorcery has quit IRC
462019-11-14T04:57:37 *** bitcoin-git has joined #bitcoin-core-dev
472019-11-14T04:57:38 <bitcoin-git> [bitcoin] luke-jr opened pull request #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr (master...bugfix_gui_netlimited_svcbit+refactor) https://github.com/bitcoin/bitcoin/pull/17474
482019-11-14T04:57:50 *** bitcoin-git has left #bitcoin-core-dev
492019-11-14T05:27:50 *** felixfoertsch23 has quit IRC
502019-11-14T05:28:00 *** felixfoertsch has joined #bitcoin-core-dev
512019-11-14T05:34:33 *** thelounge246 has joined #bitcoin-core-dev
522019-11-14T05:35:35 *** thelounge24 has quit IRC
532019-11-14T05:36:24 *** ppisati has quit IRC
542019-11-14T05:40:25 *** thelounge246 has quit IRC
552019-11-14T05:41:13 *** thelounge246 has joined #bitcoin-core-dev
562019-11-14T05:43:03 *** ppisati has joined #bitcoin-core-dev
572019-11-14T05:52:45 *** sipsorcery has joined #bitcoin-core-dev
582019-11-14T06:00:01 *** pehjota1 has quit IRC
592019-11-14T06:05:29 *** cryptapus_ has quit IRC
602019-11-14T06:17:45 *** Kim1 has joined #bitcoin-core-dev
612019-11-14T06:19:31 *** nosss2 has quit IRC
622019-11-14T06:25:58 *** nosss2 has joined #bitcoin-core-dev
632019-11-14T06:30:40 *** nosss2 has quit IRC
642019-11-14T06:59:11 *** sipsorcery has quit IRC
652019-11-14T07:08:33 *** luoqi has joined #bitcoin-core-dev
662019-11-14T07:10:02 *** luoqi has left #bitcoin-core-dev
672019-11-14T07:13:32 *** EagleTM has joined #bitcoin-core-dev
682019-11-14T07:16:21 *** cryptapus_ has joined #bitcoin-core-dev
692019-11-14T07:48:06 *** nobody123 has quit IRC
702019-11-14T07:54:43 *** sipsorcery has joined #bitcoin-core-dev
712019-11-14T08:03:09 *** marcoagner has joined #bitcoin-core-dev
722019-11-14T08:12:14 *** EagleTM has quit IRC
732019-11-14T08:21:35 *** openoms has joined #bitcoin-core-dev
742019-11-14T08:31:13 *** wsm has joined #bitcoin-core-dev
752019-11-14T08:55:01 *** b10c has joined #bitcoin-core-dev
762019-11-14T09:00:01 *** Kim1 has quit IRC
772019-11-14T09:00:59 *** sipsorcery has quit IRC
782019-11-14T09:01:00 *** sipa has quit IRC
792019-11-14T09:01:12 *** sipa has joined #bitcoin-core-dev
802019-11-14T09:02:38 *** sipsorcery has joined #bitcoin-core-dev
812019-11-14T09:12:27 *** bitcoin-git has joined #bitcoin-core-dev
822019-11-14T09:12:28 <bitcoin-git> [bitcoin] practicalswift closed pull request #17129: tests: Add fuzzing harness for miniscript::FromScript(...) (master...fuzzers-miniscript-fromscript) https://github.com/bitcoin/bitcoin/pull/17129
832019-11-14T09:12:28 *** bitcoin-git has left #bitcoin-core-dev
842019-11-14T09:13:17 *** bitcoin-git has joined #bitcoin-core-dev
852019-11-14T09:13:18 <bitcoin-git> [bitcoin] practicalswift closed pull request #16915: doc: Document MemPoolAccept::Finalize(...) precondition (master...clarify-mempoolaccept-finalize-assumptions) https://github.com/bitcoin/bitcoin/pull/16915
862019-11-14T09:13:30 *** bitcoin-git has left #bitcoin-core-dev
872019-11-14T09:13:53 *** kristapsk has quit IRC
882019-11-14T09:13:58 *** kristapsk_ has joined #bitcoin-core-dev
892019-11-14T09:16:50 *** kest10 has joined #bitcoin-core-dev
902019-11-14T09:17:02 *** thelounge2467 has joined #bitcoin-core-dev
912019-11-14T09:18:37 *** thelounge246 has quit IRC
922019-11-14T09:29:03 *** kljasdfvv has quit IRC
932019-11-14T09:30:24 *** kljasdfvv has joined #bitcoin-core-dev
942019-11-14T09:44:37 *** timothy has joined #bitcoin-core-dev
952019-11-14T09:51:55 *** diogosergio has joined #bitcoin-core-dev
962019-11-14T10:13:48 *** kristapsk_ has quit IRC
972019-11-14T10:21:21 *** AaronvanW has joined #bitcoin-core-dev
982019-11-14T10:21:48 *** wsm has quit IRC
992019-11-14T10:41:07 *** rh0nj has joined #bitcoin-core-dev
1002019-11-14T10:59:30 *** brikk has joined #bitcoin-core-dev
1012019-11-14T11:07:52 *** braydonf has quit IRC
1022019-11-14T11:28:43 *** braydonf has joined #bitcoin-core-dev
1032019-11-14T11:35:10 *** andytoshi has quit IRC
1042019-11-14T11:45:48 *** Emcy has quit IRC
1052019-11-14T11:45:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1062019-11-14T12:00:02 *** kest10 has quit IRC
1072019-11-14T12:00:31 *** Emcy has joined #bitcoin-core-dev
1082019-11-14T12:17:11 *** jajm1 has joined #bitcoin-core-dev
1092019-11-14T12:36:32 *** diogosergio has quit IRC
1102019-11-14T12:37:12 *** rex4539 has quit IRC
1112019-11-14T12:51:11 *** felixfoertsch has quit IRC
1122019-11-14T12:51:11 *** justanotheruser has quit IRC
1132019-11-14T12:51:11 *** jonatack has quit IRC
1142019-11-14T12:51:11 *** Zenton has quit IRC
1152019-11-14T12:51:12 *** harrigan has quit IRC
1162019-11-14T12:51:12 *** provoostenator has quit IRC
1172019-11-14T12:51:13 *** fox2p_ has quit IRC
1182019-11-14T12:51:14 *** Lexyon_ has quit IRC
1192019-11-14T12:51:14 *** MarcoFalke has quit IRC
1202019-11-14T12:51:15 *** BlueMatt has quit IRC
1212019-11-14T12:51:15 *** paracyst has quit IRC
1222019-11-14T12:51:15 *** hsmiths has quit IRC
1232019-11-14T12:51:16 *** cdecker has quit IRC
1242019-11-14T12:51:16 *** emzy has quit IRC
1252019-11-14T12:51:16 *** nothingmuch has quit IRC
1262019-11-14T12:51:16 *** jdmark has quit IRC
1272019-11-14T12:51:17 *** Apocalyptic has quit IRC
1282019-11-14T12:51:17 *** Anduck has quit IRC
1292019-11-14T12:51:17 *** shigeya has quit IRC
1302019-11-14T12:51:18 *** Madars has quit IRC
1312019-11-14T12:51:18 *** bsm117532 has quit IRC
1322019-11-14T12:51:18 *** ossifrage has quit IRC
1332019-11-14T12:51:18 *** xHire has quit IRC
1342019-11-14T12:51:19 *** wallet42 has quit IRC
1352019-11-14T12:51:19 *** eragmus_ has quit IRC
1362019-11-14T12:51:19 *** chainhead has quit IRC
1372019-11-14T12:51:19 *** da2ce7 has quit IRC
1382019-11-14T12:51:19 *** nehan has quit IRC
1392019-11-14T12:53:56 *** felixfoertsch has joined #bitcoin-core-dev
1402019-11-14T12:53:56 *** justanotheruser has joined #bitcoin-core-dev
1412019-11-14T12:53:56 *** jonatack has joined #bitcoin-core-dev
1422019-11-14T12:53:56 *** Zenton has joined #bitcoin-core-dev
1432019-11-14T12:53:56 *** harrigan has joined #bitcoin-core-dev
1442019-11-14T12:53:56 *** provoostenator has joined #bitcoin-core-dev
1452019-11-14T12:53:56 *** fox2p_ has joined #bitcoin-core-dev
1462019-11-14T12:53:56 *** Lexyon_ has joined #bitcoin-core-dev
1472019-11-14T12:53:56 *** MarcoFalke has joined #bitcoin-core-dev
1482019-11-14T12:53:56 *** BlueMatt has joined #bitcoin-core-dev
1492019-11-14T12:53:56 *** paracyst has joined #bitcoin-core-dev
1502019-11-14T12:53:56 *** hsmiths has joined #bitcoin-core-dev
1512019-11-14T12:53:56 *** cdecker has joined #bitcoin-core-dev
1522019-11-14T12:53:56 *** emzy has joined #bitcoin-core-dev
1532019-11-14T12:53:56 *** nothingmuch has joined #bitcoin-core-dev
1542019-11-14T12:53:56 *** jdmark has joined #bitcoin-core-dev
1552019-11-14T12:53:56 *** Apocalyptic has joined #bitcoin-core-dev
1562019-11-14T12:53:56 *** Anduck has joined #bitcoin-core-dev
1572019-11-14T12:53:56 *** shigeya has joined #bitcoin-core-dev
1582019-11-14T12:53:56 *** Madars has joined #bitcoin-core-dev
1592019-11-14T12:53:56 *** bsm117532 has joined #bitcoin-core-dev
1602019-11-14T12:53:56 *** ossifrage has joined #bitcoin-core-dev
1612019-11-14T12:53:56 *** eragmus_ has joined #bitcoin-core-dev
1622019-11-14T12:53:56 *** xHire has joined #bitcoin-core-dev
1632019-11-14T12:53:56 *** wallet42 has joined #bitcoin-core-dev
1642019-11-14T12:53:56 *** chainhead has joined #bitcoin-core-dev
1652019-11-14T12:53:56 *** da2ce7 has joined #bitcoin-core-dev
1662019-11-14T12:53:56 *** nehan has joined #bitcoin-core-dev
1672019-11-14T12:54:08 *** wsm has joined #bitcoin-core-dev
1682019-11-14T12:54:08 *** wsm has joined #bitcoin-core-dev
1692019-11-14T12:54:45 *** justanotheruser has quit IRC
1702019-11-14T12:58:40 *** justanotheruser has joined #bitcoin-core-dev
1712019-11-14T13:09:41 *** rex4539 has joined #bitcoin-core-dev
1722019-11-14T13:16:26 *** rex4539 has quit IRC
1732019-11-14T13:16:32 *** Highway61 has joined #bitcoin-core-dev
1742019-11-14T13:18:29 *** diogosergio has joined #bitcoin-core-dev
1752019-11-14T13:40:30 *** EagleTM has joined #bitcoin-core-dev
1762019-11-14T13:46:31 *** rex4539 has joined #bitcoin-core-dev
1772019-11-14T13:47:02 *** davterra has quit IRC
1782019-11-14T13:48:13 *** EagleTM has quit IRC
1792019-11-14T13:49:05 *** EagleTM has joined #bitcoin-core-dev
1802019-11-14T13:49:44 *** Lenna22Oberbrunn has joined #bitcoin-core-dev
1812019-11-14T13:51:49 *** pinheadmz has joined #bitcoin-core-dev
1822019-11-14T13:52:50 *** rex4539 has quit IRC
1832019-11-14T13:54:16 *** EagleTM has quit IRC
1842019-11-14T13:54:17 *** Lenna22Oberbrunn has quit IRC
1852019-11-14T13:55:05 *** EagleTM has joined #bitcoin-core-dev
1862019-11-14T13:58:54 *** sipsorcery has quit IRC
1872019-11-14T14:03:14 *** Chris_Stewart_5 has quit IRC
1882019-11-14T14:03:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1892019-11-14T14:18:36 *** davterra has joined #bitcoin-core-dev
1902019-11-14T14:23:04 *** shesek has quit IRC
1912019-11-14T14:23:30 *** shesek has joined #bitcoin-core-dev
1922019-11-14T14:23:30 *** shesek has joined #bitcoin-core-dev
1932019-11-14T14:26:18 *** sipsorcery has joined #bitcoin-core-dev
1942019-11-14T14:31:38 *** promag has joined #bitcoin-core-dev
1952019-11-14T14:32:10 *** promag has joined #bitcoin-core-dev
1962019-11-14T14:34:43 *** davterra has quit IRC
1972019-11-14T14:38:11 *** promag_ has joined #bitcoin-core-dev
1982019-11-14T14:38:11 *** promag has quit IRC
1992019-11-14T14:41:28 *** rex4539 has joined #bitcoin-core-dev
2002019-11-14T14:46:00 *** rex4539 has quit IRC
2012019-11-14T14:46:40 *** nik-j has joined #bitcoin-core-dev
2022019-11-14T14:48:58 *** davterra has joined #bitcoin-core-dev
2032019-11-14T14:50:34 *** nik-j has quit IRC
2042019-11-14T14:50:54 *** nik-j has joined #bitcoin-core-dev
2052019-11-14T14:52:54 *** bitcoin-git has joined #bitcoin-core-dev
2062019-11-14T14:52:54 <bitcoin-git> [bitcoin] domob1812 closed pull request #14144: Refactoring: Clarify code using encrypted_batch in CWallet (master...encrypted-batch) https://github.com/bitcoin/bitcoin/pull/14144
2072019-11-14T14:52:56 *** bitcoin-git has left #bitcoin-core-dev
2082019-11-14T15:00:01 *** jajm1 has quit IRC
2092019-11-14T15:02:10 *** brianhoffman has joined #bitcoin-core-dev
2102019-11-14T15:07:20 *** kexkey has joined #bitcoin-core-dev
2112019-11-14T15:14:44 *** emilengler has joined #bitcoin-core-dev
2122019-11-14T15:15:07 *** cubancorona2 has quit IRC
2132019-11-14T15:15:30 *** emilengler has quit IRC
2142019-11-14T15:15:41 *** emilengler has joined #bitcoin-core-dev
2152019-11-14T15:17:06 *** arcticmetal has joined #bitcoin-core-dev
2162019-11-14T15:22:33 *** davterra has quit IRC
2172019-11-14T15:23:00 *** sipsorcery has quit IRC
2182019-11-14T15:23:15 *** davterra has joined #bitcoin-core-dev
2192019-11-14T15:27:38 *** jarthur has joined #bitcoin-core-dev
2202019-11-14T15:30:33 *** promag has joined #bitcoin-core-dev
2212019-11-14T15:30:33 *** promag_ has quit IRC
2222019-11-14T15:33:19 *** sipsorcery has joined #bitcoin-core-dev
2232019-11-14T15:35:30 *** mdunnio has joined #bitcoin-core-dev
2242019-11-14T15:36:56 *** mdunnio has quit IRC
2252019-11-14T15:38:36 *** mdunnio has joined #bitcoin-core-dev
2262019-11-14T15:44:22 *** mdunnio has quit IRC
2272019-11-14T15:50:44 *** EagleTM has quit IRC
2282019-11-14T15:51:06 *** EagleTM has joined #bitcoin-core-dev
2292019-11-14T15:59:24 *** promag_ has joined #bitcoin-core-dev
2302019-11-14T15:59:25 *** promag has quit IRC
2312019-11-14T16:04:21 *** spaced0ut has joined #bitcoin-core-dev
2322019-11-14T16:05:25 *** promag has joined #bitcoin-core-dev
2332019-11-14T16:05:25 *** promag_ has quit IRC
2342019-11-14T16:09:37 *** kabaum has quit IRC
2352019-11-14T16:16:25 *** lightlike has joined #bitcoin-core-dev
2362019-11-14T16:21:29 *** bitcoin-git has joined #bitcoin-core-dev
2372019-11-14T16:21:30 <bitcoin-git> [bitcoin] jnewbery opened pull request #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals (master...2019-11-remove-mempool-signals2) https://github.com/bitcoin/bitcoin/pull/17477
2382019-11-14T16:21:42 *** bitcoin-git has left #bitcoin-core-dev
2392019-11-14T16:40:17 *** ExtraCrispy has joined #bitcoin-core-dev
2402019-11-14T16:42:17 *** rex4539 has joined #bitcoin-core-dev
2412019-11-14T16:46:26 *** justanotheruser has quit IRC
2422019-11-14T16:48:20 *** rex4539 has quit IRC
2432019-11-14T16:49:26 *** emilengler has quit IRC
2442019-11-14T16:56:17 *** Talkless has joined #bitcoin-core-dev
2452019-11-14T16:58:25 *** mdunnio has joined #bitcoin-core-dev
2462019-11-14T16:58:51 *** justanotheruser has joined #bitcoin-core-dev
2472019-11-14T17:12:52 *** rex4539 has joined #bitcoin-core-dev
2482019-11-14T17:14:44 *** Randolf has joined #bitcoin-core-dev
2492019-11-14T17:18:00 *** bitcoin-git has joined #bitcoin-core-dev
2502019-11-14T17:18:00 <bitcoin-git> [bitcoin] jnewbery opened pull request #17479: Return BlockValidationState from ProcessNewBlock if CheckBlock/AcceptBlock fails (master...2019-11-processnewblock-early-return) https://github.com/bitcoin/bitcoin/pull/17479
2512019-11-14T17:18:01 *** bitcoin-git has left #bitcoin-core-dev
2522019-11-14T17:24:06 *** mdunnio has quit IRC
2532019-11-14T17:28:48 *** nik-j_ has joined #bitcoin-core-dev
2542019-11-14T17:28:48 *** nik-j has quit IRC
2552019-11-14T17:39:38 *** Chris_Stewart_5 has quit IRC
2562019-11-14T18:00:02 *** arcticmetal has quit IRC
2572019-11-14T18:03:52 *** Randolf has quit IRC
2582019-11-14T18:05:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2592019-11-14T18:05:30 *** TCoho has joined #bitcoin-core-dev
2602019-11-14T18:12:27 *** TCoho has quit IRC
2612019-11-14T18:16:15 *** mdunnio has joined #bitcoin-core-dev
2622019-11-14T18:17:23 *** StopAndDecrypt has quit IRC
2632019-11-14T18:17:30 *** ButterflyOfFire has joined #bitcoin-core-dev
2642019-11-14T18:17:38 *** StopAndDecrypt has joined #bitcoin-core-dev
2652019-11-14T18:17:47 *** StopAndDecrypt has quit IRC
2662019-11-14T18:17:47 *** StopAndDecrypt has joined #bitcoin-core-dev
2672019-11-14T18:21:08 *** kewde[m] has quit IRC
2682019-11-14T18:21:16 *** DavidMitchell[m] has quit IRC
2692019-11-14T18:21:27 *** asd[m] has quit IRC
2702019-11-14T18:21:29 *** electric-sheep[m has quit IRC
2712019-11-14T18:21:32 *** awesome-doge has quit IRC
2722019-11-14T18:27:14 *** EagleTM has quit IRC
2732019-11-14T18:29:55 *** Highway62 has joined #bitcoin-core-dev
2742019-11-14T18:29:58 *** nik-j__ has joined #bitcoin-core-dev
2752019-11-14T18:31:52 *** Highway61 has quit IRC
2762019-11-14T18:31:52 *** Highway62 is now known as Highway61
2772019-11-14T18:32:17 *** nik-j_ has quit IRC
2782019-11-14T18:36:55 *** cubancorona has joined #bitcoin-core-dev
2792019-11-14T18:42:39 *** bitcoin-git has joined #bitcoin-core-dev
2802019-11-14T18:42:39 <bitcoin-git> [bitcoin] theStack opened pull request #17480: test: add unit test for non-standard txs with too large scriptSig (master...20191114-test-check-for-non-standard-txs-with-too-large-scriptsig) https://github.com/bitcoin/bitcoin/pull/17480
2812019-11-14T18:42:40 *** bitcoin-git has left #bitcoin-core-dev
2822019-11-14T18:47:18 *** timothy has quit IRC
2832019-11-14T18:48:09 *** justan0theruser has joined #bitcoin-core-dev
2842019-11-14T18:51:36 *** justanotheruser has quit IRC
2852019-11-14T18:54:44 *** bitcoin-git has joined #bitcoin-core-dev
2862019-11-14T18:54:45 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cd6cb9745e13...21ee676dd6a7
2872019-11-14T18:54:45 <bitcoin-git> bitcoin/master edb6b76 NullFunctor: fix uninitialized variable nMinerConfirmationWindow
2882019-11-14T18:54:46 <bitcoin-git> bitcoin/master 21ee676 fanquake: Merge #17449: fix uninitialized variable nMinerConfirmationWindow
2892019-11-14T18:54:48 *** bitcoin-git has left #bitcoin-core-dev
2902019-11-14T18:55:04 *** bitcoin-git has joined #bitcoin-core-dev
2912019-11-14T18:55:04 <bitcoin-git> [bitcoin] fanquake merged pull request #17449: fix uninitialized variable nMinerConfirmationWindow (master...master) https://github.com/bitcoin/bitcoin/pull/17449
2922019-11-14T18:55:05 *** bitcoin-git has left #bitcoin-core-dev
2932019-11-14T18:59:49 *** nik-j has joined #bitcoin-core-dev
2942019-11-14T18:59:49 *** nik-j__ has quit IRC
2952019-11-14T18:59:57 <wumpus> meeting time?
2962019-11-14T19:00:20 <jnewbery> hi
2972019-11-14T19:00:20 <moneyball> Yup
2982019-11-14T19:00:24 <fjahr> hi
2992019-11-14T19:00:28 <wumpus> #startmeeting
3002019-11-14T19:00:28 <lightningbot> Meeting started Thu Nov 14 19:00:28 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3012019-11-14T19:00:28 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3022019-11-14T19:00:40 <ariard> hi
3032019-11-14T19:00:48 <moneyball> Is it possible for me to speak to my topic first? Should be short and I only have 10 minutes
3042019-11-14T19:00:55 <digi_james> hi
3052019-11-14T19:00:56 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
3062019-11-14T19:00:58 <wumpus> jeremyrubin lightlike
3072019-11-14T19:01:05 <lightlike> hi
3082019-11-14T19:01:08 <wumpus> moneyball: sure!
3092019-11-14T19:01:19 <moneyball> Ty
3102019-11-14T19:01:19 <wumpus> #topic next CoreDev
3112019-11-14T19:01:19 <jamesob> oh man it's thursday already hi
3122019-11-14T19:01:19 <achow101> hi
3132019-11-14T19:02:08 <meshcollider> hi
3142019-11-14T19:02:13 <moneyball> So Iâm proposing next Core dev to be in March in SF. The 3 days prior to Bitcoin 2020 conference
3152019-11-14T19:02:14 <BlueMatt> gogo moneyball
3162019-11-14T19:02:27 <BlueMatt> sgtm
3172019-11-14T19:02:30 <moneyball> Let me know if there are major concerns with this
3182019-11-14T19:02:33 <achow101> we've already had one in sf
3192019-11-14T19:02:53 <moneyball> The conference is willing to find and pay for venue and breakfast and lunch
3202019-11-14T19:03:12 <moneyball> achow101 e we havenât had west coast the past 3
3212019-11-14T19:03:13 <jnewbery> last three have been Europe, Asia, US east coast. Seems reasonable to have the next one on the west coast
3222019-11-14T19:03:15 <BlueMatt> achow101: ehh, its been quite a while though....
3232019-11-14T19:03:27 <moneyball> Europe, Asia, nyc past 3
3242019-11-14T19:03:41 <moneyball> And we are likely to do Europe in the fall 2020
3252019-11-14T19:03:59 <jnewbery> moneyball: do you have somewhere planned for fall 2020?
3262019-11-14T19:04:08 <wumpus> seems fine to me
3272019-11-14T19:04:09 <moneyball> A candidate is London
3282019-11-14T19:04:14 <wumpus> oh cool
3292019-11-14T19:04:14 <moneyball> Scaling bitcoin
3302019-11-14T19:04:17 <jnewbery> +1 :)
3312019-11-14T19:04:24 <moneyball> Thought youâd like
3322019-11-14T19:04:37 <jamesob> I'm amazed moneyball is voluntarily signing up to plan more than one future conference
3332019-11-14T19:05:31 <wumpus> heh
3342019-11-14T19:05:58 <jonatack> hi
3352019-11-14T19:06:14 <wumpus> it seems there's no one with major concerns
3362019-11-14T19:06:19 <moneyball> Ok great
3372019-11-14T19:07:04 <wumpus> #topic High priority for review
3382019-11-14T19:07:24 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 7 blockers, 7 chasing concept ACK again
3392019-11-14T19:07:38 *** pinheadmz has quit IRC
3402019-11-14T19:07:51 <wumpus> anything to be added/removed? or ready for merge?
3412019-11-14T19:07:58 <jamesob> can I add #16945? I think it's pretty close
3422019-11-14T19:08:01 <gribble> https://github.com/bitcoin/bitcoin/issues/16945 | refactor: introduce CChainState::GetCoinsCacheSizeState by jamesob · Pull Request #16945 · bitcoin/bitcoin · GitHub
3432019-11-14T19:08:11 <wumpus> looks like #16323 is closed, let's remove it
3442019-11-14T19:08:14 <gribble> https://github.com/bitcoin/bitcoin/issues/16323 | Call ProcessNewBlock() asynchronously by TheBlueMatt · Pull Request #16323 · bitcoin/bitcoin · GitHub
3452019-11-14T19:08:25 <jamesob> the assumeutxo PRs are probably gonna start to get more... substantial
3462019-11-14T19:08:44 <BlueMatt> indeed, got no review, scary changes are scary, so not worth rebasing.
3472019-11-14T19:08:55 <wumpus> BlueMatt: yeah...
3482019-11-14T19:09:25 <wumpus> added 16945
3492019-11-14T19:09:28 <jamesob> ty!
3502019-11-14T19:09:48 <wumpus> (to blockers, I guess, not chasing concept)
3512019-11-14T19:09:58 <jamesob> wumpus: right
3522019-11-14T19:10:26 <wumpus> #topic version 0.19.0.1
3532019-11-14T19:10:44 <wumpus> so, we were about to do the final release preparation for 0.19.0, then #17449 came up
3542019-11-14T19:10:46 <gribble> https://github.com/bitcoin/bitcoin/issues/17449 | fix uninitialized variable nMinerConfirmationWindow by bitcoinVBR · Pull Request #17449 · bitcoin/bitcoin · GitHub
3552019-11-14T19:11:29 <wumpus> and field of the CChainParams structure is used uninitialized in a computation, and this can have effect on GUI warnings
3562019-11-14T19:12:03 <wumpus> so I guess it's serious enough to forego 0.19.0 and do 0.19.0.1 immediately
3572019-11-14T19:12:15 <MarcoFalke> I'd say so too
3582019-11-14T19:12:18 <achow101> ack
3592019-11-14T19:12:46 <jnewbery> I agree :(
3602019-11-14T19:12:48 <wumpus> this does give some logistical issues, I don't think we've ever skipped a major release, but doing 0.19.0.1 with the 0.19.0 release notes and releasing it as if it is 0.19.0 should work, I guess
3612019-11-14T19:12:55 <MarcoFalke> Even though it seems the compiler might have compiled it correctly with -O2, not worth to rely on that
3622019-11-14T19:13:23 <MarcoFalke> It includes the -cli fix as well
3632019-11-14T19:13:26 <wumpus> it might have cuased #16697
3642019-11-14T19:13:27 <gribble> https://github.com/bitcoin/bitcoin/issues/16697 | Unknown version bit fork activated warning · Issue #16697 · bitcoin/bitcoin · GitHub
3652019-11-14T19:13:32 <MarcoFalke> So a short release notes would make sense?
3662019-11-14T19:13:43 <wumpus> just add them to the 0.19.0 release notes
3672019-11-14T19:13:49 <MarcoFalke> Oh right
3682019-11-14T19:14:42 <wumpus> ok, seems there's agreement on how to go forward, any other topics?
3692019-11-14T19:14:55 <MarcoFalke> no
3702019-11-14T19:15:43 <wumpus> I guess no new rc cycle is needed?
3712019-11-14T19:16:01 *** Highway61 has quit IRC
3722019-11-14T19:17:02 <wumpus> I don't think that is necessary with just the #17417 and #17449
3732019-11-14T19:17:04 <gribble> https://github.com/bitcoin/bitcoin/issues/17417 | [0.19] cli: fix -getinfo output when compiled with no wallet by fanquake · Pull Request #17417 · bitcoin/bitcoin · GitHub
3742019-11-14T19:17:06 <gribble> https://github.com/bitcoin/bitcoin/issues/17449 | fix uninitialized variable nMinerConfirmationWindow by bitcoinVBR · Pull Request #17449 · bitcoin/bitcoin · GitHub
3752019-11-14T19:17:14 <jnewbery> topic suggestion: Maybe I could give people a quick update on review club?
3762019-11-14T19:17:22 <wumpus> otherwise there will be even more delay
3772019-11-14T19:17:26 <wumpus> ok
3782019-11-14T19:17:34 <wumpus> #topic Review club update
3792019-11-14T19:17:59 <jnewbery> we've had ~ 30 review club meetings so far. I'm very happy with the quality of questions that we've had
3802019-11-14T19:18:05 <jnewbery> https://bitcoincore.reviews/
3812019-11-14T19:18:07 <wumpus> 30 already? wow
3822019-11-14T19:18:54 <jnewbery> there are a group of very regular attendees who you might recognize from PR comments: lightlike, jkczyz, zenogais, fjahr, pinheadmz, amiti, ariard, ...
3832019-11-14T19:19:24 <jnewbery> and we've had a few guest hosts as well: harding, MarcoFalke, ...
3842019-11-14T19:19:46 <jnewbery> I still think it's a great way to help new contributors. If you're interested in guest hosting some time, please message me
3852019-11-14T19:20:17 <jnewbery> Also tell your friends who want to start contributing that reviewing/testing is a great way to help, and review club could be a fun way for them to start
3862019-11-14T19:20:45 <wumpus> yes I think it's a great initative to get people involved inreview!
3872019-11-14T19:21:13 <jnewbery> (to clarify: I'm talking about PR review club, not taproot review club, which is another great initiative!)
3882019-11-14T19:21:24 <jnewbery> that's all I had
3892019-11-14T19:22:02 *** diogosergio has quit IRC
3902019-11-14T19:22:15 <wumpus> thank you
3912019-11-14T19:22:38 <wumpus> I'm trying to be involved once in a while too! but usually miss the meetings :(
3922019-11-14T19:22:46 <wumpus> any other topics?
3932019-11-14T19:23:08 <jonatack> i discussed it a fair amount in the latest stephan livera podcast too
3942019-11-14T19:23:27 <jonatack> including links to the club website and twitter account
3952019-11-14T19:23:30 <wumpus> great!
3962019-11-14T19:23:53 <jnewbery> thanks jonatack. I should have included you in the regular attendees list!
3972019-11-14T19:24:42 *** diogosergio has joined #bitcoin-core-dev
3982019-11-14T19:24:47 <jonatack> jnewbery: np!
3992019-11-14T19:24:50 <wumpus> #endmeeting
4002019-11-14T19:24:50 <lightningbot> Meeting ended Thu Nov 14 19:24:50 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4012019-11-14T19:24:50 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-14-19.00.html
4022019-11-14T19:24:50 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-14-19.00.txt
4032019-11-14T19:24:50 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-14-19.00.log.html
4042019-11-14T19:26:11 <fanquake> Sounds good
4052019-11-14T19:29:08 *** ExtraCrispy has quit IRC
4062019-11-14T19:29:17 *** jarthur has quit IRC
4072019-11-14T19:32:35 *** pinheadmz has joined #bitcoin-core-dev
4082019-11-14T19:37:15 *** Highway61 has joined #bitcoin-core-dev
4092019-11-14T19:37:17 *** bitcoin-git has joined #bitcoin-core-dev
4102019-11-14T19:37:18 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/c7c8e3e072a7...6ec0dc195dc6
4112019-11-14T19:37:18 <bitcoin-git> bitcoin/0.19 1e9816d Wladimir J. van der Laan: build: bump version to 0.19.0.1
4122019-11-14T19:37:19 <bitcoin-git> bitcoin/0.19 6ec0dc1 NullFunctor: fix uninitialized variable nMinerConfirmationWindow
4132019-11-14T19:37:21 *** bitcoin-git has left #bitcoin-core-dev
4142019-11-14T19:44:08 *** bitcoin-git has joined #bitcoin-core-dev
4152019-11-14T19:44:08 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/6ec0dc195dc6...890dc0a7cccd
4162019-11-14T19:44:09 <bitcoin-git> bitcoin/0.19 890dc0a Wladimir J. van der Laan: doc: Re-add release notes of 0.19.0
4172019-11-14T19:44:11 *** bitcoin-git has left #bitcoin-core-dev
4182019-11-14T19:50:43 *** diogosergio has quit IRC
4192019-11-14T19:59:38 *** Chris_Stewart_5 has quit IRC
4202019-11-14T20:01:51 *** dr-orlovsky has joined #bitcoin-core-dev
4212019-11-14T20:02:28 *** diogosergio has joined #bitcoin-core-dev
4222019-11-14T20:06:48 *** diogosergio has quit IRC
4232019-11-14T20:17:04 *** Talkless has quit IRC
4242019-11-14T20:22:59 *** emilengler has joined #bitcoin-core-dev
4252019-11-14T20:34:19 *** bitcoin-git has joined #bitcoin-core-dev
4262019-11-14T20:34:19 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17482: util: Disallow network-qualified command line options (master...pr/wdqual) https://github.com/bitcoin/bitcoin/pull/17482
4272019-11-14T20:34:20 *** bitcoin-git has left #bitcoin-core-dev
4282019-11-14T20:34:34 *** EagleTM has joined #bitcoin-core-dev
4292019-11-14T20:35:49 *** pinheadmz has quit IRC
4302019-11-14T20:35:50 *** shigeya has quit IRC
4312019-11-14T20:36:03 *** shigeya has joined #bitcoin-core-dev
4322019-11-14T20:42:12 *** reallll has joined #bitcoin-core-dev
4332019-11-14T20:44:43 *** belcher has quit IRC
4342019-11-14T20:45:21 <jonasschnelli> Sorry for missing the meeting again.
4352019-11-14T20:45:30 *** mdunnio has quit IRC
4362019-11-14T20:45:43 <jonasschnelli> I just saw that the Bitcoin Core Code Signing Association Apple developer programm expires in 15 days
4372019-11-14T20:47:25 <jeremyrubin> is ~everyone post DST now? does it make sense to move the meeting an hour up (or is this a settled matter of sticking to non-adjusted time)
4382019-11-14T20:50:05 <instagibbs> sticking to iceland time seems to be the solution
4392019-11-14T20:51:12 * jeremyrubin misses every meeting till spring
4402019-11-14T20:54:04 *** mdunnio has joined #bitcoin-core-dev
4412019-11-14T20:59:01 *** reallll is now known as belcher
4422019-11-14T21:00:01 *** ButterflyOfFire has quit IRC
4432019-11-14T21:14:44 *** davterra has quit IRC
4442019-11-14T21:15:06 *** davterra has joined #bitcoin-core-dev
4452019-11-14T21:15:09 *** dr-orlovsky has quit IRC
4462019-11-14T21:18:43 *** pinheadmz has joined #bitcoin-core-dev
4472019-11-14T21:21:27 *** emilengler has quit IRC
4482019-11-14T21:21:49 *** nik-j has quit IRC
4492019-11-14T21:32:50 *** jarthur has joined #bitcoin-core-dev
4502019-11-14T21:34:28 *** pinheadmz has quit IRC
4512019-11-14T21:38:02 *** mdunnio has quit IRC
4522019-11-14T21:47:46 *** zule1 has joined #bitcoin-core-dev
4532019-11-14T21:51:18 *** mdunnio has joined #bitcoin-core-dev
4542019-11-14T21:52:38 *** mdunnio has quit IRC
4552019-11-14T22:07:51 *** Guest61 has joined #bitcoin-core-dev
4562019-11-14T22:09:49 *** mdunnio has joined #bitcoin-core-dev
4572019-11-14T22:13:45 *** bitcoin-git has joined #bitcoin-core-dev
4582019-11-14T22:13:45 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17483: scripted-diff: Set gitian arch back to amd64 (master...1911-gitianRevertToAmd64) https://github.com/bitcoin/bitcoin/pull/17483
4592019-11-14T22:13:47 *** bitcoin-git has left #bitcoin-core-dev
4602019-11-14T22:15:25 *** bitcoin-git has joined #bitcoin-core-dev
4612019-11-14T22:15:26 <bitcoin-git> [bitcoin] ariard opened pull request #17484: CWallet: add cached m_is_ibd to remove isInitialBlockDownload (master...2019-11-wallet-remove-isibd) https://github.com/bitcoin/bitcoin/pull/17484
4622019-11-14T22:15:27 *** bitcoin-git has left #bitcoin-core-dev
4632019-11-14T22:22:27 *** pinheadmz has joined #bitcoin-core-dev
4642019-11-14T22:24:44 *** nik-j_ has joined #bitcoin-core-dev
4652019-11-14T22:25:04 *** bitcoin-git has joined #bitcoin-core-dev
4662019-11-14T22:25:04 <bitcoin-git> [bitcoin] jnewbery opened pull request #17485: net processing: Don't reach into CBlockIndex to check for block mutation (master...2019-11-processnewblock-early-return2) https://github.com/bitcoin/bitcoin/pull/17485
4672019-11-14T22:25:05 *** bitcoin-git has left #bitcoin-core-dev
4682019-11-14T22:25:31 *** Caden38Bartolett has joined #bitcoin-core-dev
4692019-11-14T22:28:03 *** nik-j_ has quit IRC
4702019-11-14T22:29:41 *** nosss2 has joined #bitcoin-core-dev
4712019-11-14T22:30:18 *** Caden38Bartolett has quit IRC
4722019-11-14T22:30:29 *** bitcoin-git has joined #bitcoin-core-dev
4732019-11-14T22:30:30 <bitcoin-git> [bitcoin] jamesob closed pull request #16718: Improve speed, memory efficiency with alternate hashmap (master...2019-08-robinhood) https://github.com/bitcoin/bitcoin/pull/16718
4742019-11-14T22:30:42 *** bitcoin-git has left #bitcoin-core-dev
4752019-11-14T22:35:18 *** mdunnio has quit IRC
4762019-11-14T22:37:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4772019-11-14T22:41:45 *** Ted78Nicolas has joined #bitcoin-core-dev
4782019-11-14T22:46:40 *** Ted78Nicolas has quit IRC
4792019-11-14T22:49:03 *** mdunnio has joined #bitcoin-core-dev
4802019-11-14T22:50:22 *** davterra has quit IRC
4812019-11-14T22:51:42 *** jarthur has quit IRC
4822019-11-14T22:52:10 *** jarthur has joined #bitcoin-core-dev
4832019-11-14T22:53:55 *** davterra has joined #bitcoin-core-dev
4842019-11-14T22:55:46 *** mdunnio has quit IRC
4852019-11-14T23:00:02 *** arubi has quit IRC
4862019-11-14T23:00:03 *** wsm has quit IRC
4872019-11-14T23:00:22 *** wsm has joined #bitcoin-core-dev
4882019-11-14T23:00:30 *** arubi has joined #bitcoin-core-dev
4892019-11-14T23:00:33 *** Chris_Stewart_5 has quit IRC
4902019-11-14T23:02:26 *** b10c has quit IRC
4912019-11-14T23:11:40 *** sipsorcery has quit IRC
4922019-11-14T23:11:54 *** sipsorcery has joined #bitcoin-core-dev
4932019-11-14T23:15:00 <luke-jr> wumpus: I'd do 0.19.1 ;)
4942019-11-14T23:17:01 *** Dahlia47Heller has joined #bitcoin-core-dev
4952019-11-14T23:18:26 <darosior> sipa (or anyone who knows): why in https://github.com/bitcoin/bitcoin/commit/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b#diff-d22bc3e058f8982972e2eb381a1df668R154 is GetVirtualTransactionSize as (weight + 3) / 4 while virtual tx size is defined as weight / 4 here
4962019-11-14T23:18:26 <darosior> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-size-calculations ?
4972019-11-14T23:19:38 *** fox2p_ has quit IRC
4982019-11-14T23:20:26 *** fox2p has joined #bitcoin-core-dev
4992019-11-14T23:21:48 *** Dahlia47Heller has quit IRC
5002019-11-14T23:27:33 <sipa> darosior: for compatibility
5012019-11-14T23:28:08 <sipa> weight is the consensus level thing that needs to be exact, and we only want integer arithmetic for
5022019-11-14T23:28:47 <sipa> vsize is the more familiar not as exact thing but that doesn't risk blowing up people's fees by 4, because they're doing estimation per size and then applying it to weight
5032019-11-14T23:28:57 <sipa> as for non-segwit transactions, vsize == size
5042019-11-14T23:32:53 <darosior> sipa: Thank you for your answer. I don't understand the trailing `3` though. For more context I've been working in making core using weight units for every feerate computation (mempool, fee estimation, coin selection, ....) and had two last broken functional test I could not get rid of (0.001% fee approximation wrong). Turned out they were using
5052019-11-14T23:32:53 <darosior> decoderawtransaction which uses this same formula but hardcoded. Using the BIP formula makes the fee estimation match.
5062019-11-14T23:32:57 *** brianhoffman_ has joined #bitcoin-core-dev
5072019-11-14T23:33:57 <sipa> darosior: for fee estimarion purposes rounding up is less harmful than rounding down
5082019-11-14T23:33:58 *** Gilda80Gislason has joined #bitcoin-core-dev
5092019-11-14T23:34:13 <darosior> Ok, thanks
5102019-11-14T23:35:15 <darosior> Then getting rid of that if we don't round up anymore for fee estimation seems ok ? :)
5112019-11-14T23:37:11 *** brianhoffman has quit IRC
5122019-11-14T23:37:11 *** brianhoffman_ is now known as brianhoffman
5132019-11-14T23:38:26 *** Gilda80Gislason has quit IRC
5142019-11-14T23:48:09 *** nik-j has joined #bitcoin-core-dev
5152019-11-14T23:49:45 *** nosss2 has quit IRC
5162019-11-14T23:50:44 *** jasonzhouu has joined #bitcoin-core-dev
5172019-11-14T23:53:45 *** nik-j has quit IRC
5182019-11-14T23:57:59 *** Zenton has quit IRC