12019-11-23T00:00:01 *** Antonet has quit IRC
22019-11-23T00:04:47 *** rafalcpp_ has joined #bitcoin-core-dev
32019-11-23T00:04:50 *** rafalcpp has quit IRC
42019-11-23T00:09:25 *** achow101 has quit IRC
52019-11-23T00:11:34 *** rafalcpp has joined #bitcoin-core-dev
62019-11-23T00:12:14 *** rafalcpp_ has quit IRC
72019-11-23T00:17:18 *** FalconKirtaran has joined #bitcoin-core-dev
82019-11-23T00:19:15 *** achow101 has joined #bitcoin-core-dev
92019-11-23T00:19:22 *** rafalcpp_ has joined #bitcoin-core-dev
102019-11-23T00:19:23 *** rafalcpp has quit IRC
112019-11-23T00:27:28 *** Dev has joined #bitcoin-core-dev
122019-11-23T00:28:23 *** rafalcpp has joined #bitcoin-core-dev
132019-11-23T00:28:26 *** rafalcpp_ has quit IRC
142019-11-23T00:32:37 *** rafalcpp has quit IRC
152019-11-23T00:33:12 *** rafalcpp has joined #bitcoin-core-dev
162019-11-23T00:39:43 *** Highway61 has quit IRC
172019-11-23T00:40:36 *** jasonzhouu_ has joined #bitcoin-core-dev
182019-11-23T00:41:57 *** rafalcpp_ has joined #bitcoin-core-dev
192019-11-23T00:42:26 *** rafalcpp has quit IRC
202019-11-23T00:42:57 *** jasonzhouu has quit IRC
212019-11-23T00:43:21 *** jasonzhouu_ is now known as jasonzhouu
222019-11-23T00:45:38 *** AaronvanW has joined #bitcoin-core-dev
232019-11-23T00:50:30 *** AaronvanW has quit IRC
242019-11-23T00:50:42 *** rafalcpp has joined #bitcoin-core-dev
252019-11-23T00:50:57 *** rafalcpp_ has quit IRC
262019-11-23T00:59:34 *** brakmic has quit IRC
272019-11-23T01:04:42 *** marcoagner has quit IRC
282019-11-23T01:06:33 *** molly has joined #bitcoin-core-dev
292019-11-23T01:09:27 *** rafalcpp_ has joined #bitcoin-core-dev
302019-11-23T01:09:38 *** mol has quit IRC
312019-11-23T01:09:50 *** rafalcpp has quit IRC
322019-11-23T01:11:29 *** jonatack has joined #bitcoin-core-dev
332019-11-23T01:11:58 *** SiAnDoG has joined #bitcoin-core-dev
342019-11-23T01:13:29 *** Dev has quit IRC
352019-11-23T01:13:41 *** cryptoIndio has quit IRC
362019-11-23T01:17:13 *** rafalcpp has joined #bitcoin-core-dev
372019-11-23T01:18:03 *** rafalcpp_ has quit IRC
382019-11-23T01:22:50 *** AaronvanW has joined #bitcoin-core-dev
392019-11-23T01:23:20 *** sipsorcery has quit IRC
402019-11-23T01:23:40 *** nosss2 has quit IRC
412019-11-23T01:24:17 *** nosss2 has joined #bitcoin-core-dev
422019-11-23T01:27:25 *** AaronvanW has quit IRC
432019-11-23T01:28:41 *** nosss2 has quit IRC
442019-11-23T01:29:53 *** SiAnDoG has quit IRC
452019-11-23T01:30:04 *** SiAnDoG has joined #bitcoin-core-dev
462019-11-23T01:32:02 *** rafalcpp_ has joined #bitcoin-core-dev
472019-11-23T01:32:26 *** rafalcpp has quit IRC
482019-11-23T01:34:47 *** Dean_Guss has joined #bitcoin-core-dev
492019-11-23T01:40:47 *** rafalcpp has joined #bitcoin-core-dev
502019-11-23T01:41:17 *** rafalcpp_ has quit IRC
512019-11-23T01:55:33 *** AaronvanW has joined #bitcoin-core-dev
522019-11-23T01:56:37 *** rafalcpp_ has joined #bitcoin-core-dev
532019-11-23T01:56:50 *** rafalcpp has quit IRC
542019-11-23T01:59:52 *** jtimon has quit IRC
552019-11-23T02:00:00 *** AaronvanW has quit IRC
562019-11-23T02:08:08 *** bitcoin-git has joined #bitcoin-core-dev
572019-11-23T02:08:08 <bitcoin-git> [bitcoin] fanquake opened pull request #17567: gui: remove macOS start on login code (master...remove_macos_startup_item) https://github.com/bitcoin/bitcoin/pull/17567
582019-11-23T02:08:21 *** bitcoin-git has left #bitcoin-core-dev
592019-11-23T02:10:37 *** emilengler has quit IRC
602019-11-23T02:11:53 *** bitcoin-git has joined #bitcoin-core-dev
612019-11-23T02:11:54 <bitcoin-git> [bitcoin] fanquake closed pull request #16738: gui: Remove needless GCC diagnostic pragma (master...20190827-gcc-pragmas) https://github.com/bitcoin/bitcoin/pull/16738
622019-11-23T02:11:54 *** bitcoin-git has left #bitcoin-core-dev
632019-11-23T02:13:14 *** rafalcpp_ has quit IRC
642019-11-23T02:13:32 *** rafalcpp_ has joined #bitcoin-core-dev
652019-11-23T02:24:25 *** cryptoIndio has joined #bitcoin-core-dev
662019-11-23T02:24:36 *** cryptoIndio has quit IRC
672019-11-23T02:32:13 *** AaronvanW has joined #bitcoin-core-dev
682019-11-23T02:36:30 *** AaronvanW has quit IRC
692019-11-23T02:38:50 *** rafalcpp_ has quit IRC
702019-11-23T02:39:17 *** rafalcpp_ has joined #bitcoin-core-dev
712019-11-23T02:41:47 *** jasonzhouu has quit IRC
722019-11-23T02:42:11 *** jasonzhouu has joined #bitcoin-core-dev
732019-11-23T02:45:16 *** nik-j has joined #bitcoin-core-dev
742019-11-23T02:48:54 *** nik-j has quit IRC
752019-11-23T02:49:31 *** nik-j has joined #bitcoin-core-dev
762019-11-23T02:53:07 *** rafalcpp has joined #bitcoin-core-dev
772019-11-23T02:53:37 *** rafalcpp_ has quit IRC
782019-11-23T03:00:01 *** FalconKirtaran has quit IRC
792019-11-23T03:00:57 *** rafalcpp_ has joined #bitcoin-core-dev
802019-11-23T03:01:29 *** rafalcpp has quit IRC
812019-11-23T03:06:49 *** felixfoertsch has joined #bitcoin-core-dev
822019-11-23T03:07:17 *** rafalcpp_ has quit IRC
832019-11-23T03:08:16 *** rafalcpp_ has joined #bitcoin-core-dev
842019-11-23T03:08:44 *** felixfoertsch23 has quit IRC
852019-11-23T03:11:38 *** AaronvanW has joined #bitcoin-core-dev
862019-11-23T03:16:50 *** AaronvanW has quit IRC
872019-11-23T03:17:19 *** freakofmimsy has joined #bitcoin-core-dev
882019-11-23T03:21:02 *** rafalcpp has joined #bitcoin-core-dev
892019-11-23T03:22:02 *** rafalcpp_ has quit IRC
902019-11-23T03:26:25 *** reallll has joined #bitcoin-core-dev
912019-11-23T03:29:37 *** belcher has quit IRC
922019-11-23T03:35:15 *** bitcoin-git has joined #bitcoin-core-dev
932019-11-23T03:35:16 <bitcoin-git> [bitcoin] achow101 opened pull request #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs (master...fix-bnb-preset-sub) https://github.com/bitcoin/bitcoin/pull/17568
942019-11-23T03:35:17 *** jasonzhouu has quit IRC
952019-11-23T03:35:21 *** bitcoin-git has left #bitcoin-core-dev
962019-11-23T03:35:41 *** deadlysin has quit IRC
972019-11-23T03:44:47 *** rafalcpp_ has joined #bitcoin-core-dev
982019-11-23T03:46:05 *** rafalcpp has quit IRC
992019-11-23T03:49:43 *** AaronvanW has joined #bitcoin-core-dev
1002019-11-23T03:51:32 *** rafalcpp has joined #bitcoin-core-dev
1012019-11-23T03:52:35 *** rafalcpp_ has quit IRC
1022019-11-23T03:54:10 *** AaronvanW has quit IRC
1032019-11-23T04:08:18 *** rafalcpp_ has joined #bitcoin-core-dev
1042019-11-23T04:09:09 *** rafalcpp has quit IRC
1052019-11-23T04:27:07 *** rafalcpp has joined #bitcoin-core-dev
1062019-11-23T04:27:47 *** dviola has joined #bitcoin-core-dev
1072019-11-23T04:28:02 *** AaronvanW has joined #bitcoin-core-dev
1082019-11-23T04:28:29 *** rafalcpp_ has quit IRC
1092019-11-23T04:32:26 *** AaronvanW has quit IRC
1102019-11-23T04:39:37 *** rafalcpp has quit IRC
1112019-11-23T04:40:02 *** rafalcpp has joined #bitcoin-core-dev
1122019-11-23T04:55:37 *** rafalcpp has quit IRC
1132019-11-23T04:55:48 *** rafalcpp has joined #bitcoin-core-dev
1142019-11-23T05:02:58 *** AaronvanW has joined #bitcoin-core-dev
1152019-11-23T05:04:24 *** felixfoertsch has quit IRC
1162019-11-23T05:04:35 *** felixfoertsch has joined #bitcoin-core-dev
1172019-11-23T05:07:59 *** AaronvanW has quit IRC
1182019-11-23T05:08:37 *** rafalcpp_ has joined #bitcoin-core-dev
1192019-11-23T05:09:17 *** rafalcpp has quit IRC
1202019-11-23T05:27:17 *** rafalcpp_ has quit IRC
1212019-11-23T05:27:24 *** rafalcpp has joined #bitcoin-core-dev
1222019-11-23T05:27:52 *** dviola has quit IRC
1232019-11-23T05:28:23 *** nosss2 has joined #bitcoin-core-dev
1242019-11-23T05:48:12 *** rafalcpp_ has joined #bitcoin-core-dev
1252019-11-23T05:48:17 *** rafalcpp has quit IRC
1262019-11-23T05:49:35 *** molly has quit IRC
1272019-11-23T05:50:33 *** rhavar_ has quit IRC
1282019-11-23T05:51:51 *** tryphe has quit IRC
1292019-11-23T05:52:19 *** tryphe has joined #bitcoin-core-dev
1302019-11-23T05:52:56 *** mol has joined #bitcoin-core-dev
1312019-11-23T05:57:37 *** rafalcpp_ has quit IRC
1322019-11-23T05:58:01 *** rafalcpp_ has joined #bitcoin-core-dev
1332019-11-23T06:00:02 *** freakofmimsy has quit IRC
1342019-11-23T06:02:57 *** rafalcpp has joined #bitcoin-core-dev
1352019-11-23T06:03:01 *** rafalcpp_ has quit IRC
1362019-11-23T06:04:40 *** MrPaz has quit IRC
1372019-11-23T06:09:52 *** rafalcpp_ has joined #bitcoin-core-dev
1382019-11-23T06:09:57 *** rafalcpp has quit IRC
1392019-11-23T06:17:23 *** mmf has joined #bitcoin-core-dev
1402019-11-23T06:18:55 *** cryptoIndio has joined #bitcoin-core-dev
1412019-11-23T06:20:33 *** AaronvanW has joined #bitcoin-core-dev
1422019-11-23T06:20:37 *** rafalcpp has joined #bitcoin-core-dev
1432019-11-23T06:20:47 *** rafalcpp_ has quit IRC
1442019-11-23T06:24:00 *** cryptoIndio has quit IRC
1452019-11-23T06:25:20 *** AaronvanW has quit IRC
1462019-11-23T06:25:55 *** rabidus has quit IRC
1472019-11-23T06:27:18 *** rabidus has joined #bitcoin-core-dev
1482019-11-23T06:31:25 *** rafalcpp_ has joined #bitcoin-core-dev
1492019-11-23T06:32:29 *** rafalcpp has quit IRC
1502019-11-23T06:33:44 *** rabidus has quit IRC
1512019-11-23T06:35:44 *** rabidus has joined #bitcoin-core-dev
1522019-11-23T06:46:17 *** rabidus has quit IRC
1532019-11-23T06:48:19 *** rabidus has joined #bitcoin-core-dev
1542019-11-23T06:49:19 *** provoostenator has quit IRC
1552019-11-23T06:51:41 *** cryptoIndio has joined #bitcoin-core-dev
1562019-11-23T06:54:27 *** rafalcpp has joined #bitcoin-core-dev
1572019-11-23T06:54:38 *** rafalcpp_ has quit IRC
1582019-11-23T06:57:11 *** cryptoIndio has quit IRC
1592019-11-23T07:00:05 *** nosss2 has quit IRC
1602019-11-23T07:01:21 *** provoostenator has joined #bitcoin-core-dev
1612019-11-23T07:07:34 *** tryphe has quit IRC
1622019-11-23T07:08:50 *** rafalcpp has quit IRC
1632019-11-23T07:09:16 *** rafalcpp has joined #bitcoin-core-dev
1642019-11-23T07:14:57 *** rafalcpp has quit IRC
1652019-11-23T07:15:12 *** rafalcpp has joined #bitcoin-core-dev
1662019-11-23T07:21:00 *** rafalcpp_ has joined #bitcoin-core-dev
1672019-11-23T07:21:17 *** rafalcpp has quit IRC
1682019-11-23T07:30:50 *** cryptoIndio has joined #bitcoin-core-dev
1692019-11-23T07:31:52 *** AaronvanW has joined #bitcoin-core-dev
1702019-11-23T07:32:46 *** rafalcpp_ has quit IRC
1712019-11-23T07:32:55 *** rafalcpp_ has joined #bitcoin-core-dev
1722019-11-23T07:34:57 *** cryptoIndio has quit IRC
1732019-11-23T07:36:17 *** AaronvanW has quit IRC
1742019-11-23T07:37:04 *** DougieBot5000_ has joined #bitcoin-core-dev
1752019-11-23T07:40:51 *** DougieBot5000 has quit IRC
1762019-11-23T07:47:46 *** spinza has quit IRC
1772019-11-23T08:03:43 *** rafalcpp has joined #bitcoin-core-dev
1782019-11-23T08:04:08 *** rafalcpp_ has quit IRC
1792019-11-23T08:05:43 *** AaronvanW has joined #bitcoin-core-dev
1802019-11-23T08:10:20 *** AaronvanW has quit IRC
1812019-11-23T08:14:33 *** rafalcpp_ has joined #bitcoin-core-dev
1822019-11-23T08:14:45 *** rafalcpp has quit IRC
1832019-11-23T08:15:38 *** AaronvanW has joined #bitcoin-core-dev
1842019-11-23T08:24:05 *** EagleTM has joined #bitcoin-core-dev
1852019-11-23T08:27:36 *** Talkless has joined #bitcoin-core-dev
1862019-11-23T08:28:07 *** tryphe has joined #bitcoin-core-dev
1872019-11-23T08:28:31 *** Talkless has quit IRC
1882019-11-23T08:29:17 *** rafalcpp_ has quit IRC
1892019-11-23T08:29:22 *** rafalcpp has joined #bitcoin-core-dev
1902019-11-23T08:30:22 *** tryphe has quit IRC
1912019-11-23T08:30:43 *** tryphe has joined #bitcoin-core-dev
1922019-11-23T08:34:02 *** rafalcpp has quit IRC
1932019-11-23T08:34:07 *** rafalcpp_ has joined #bitcoin-core-dev
1942019-11-23T08:37:31 *** cryptoIndio has joined #bitcoin-core-dev
1952019-11-23T08:41:02 *** reallll is now known as belcher
1962019-11-23T08:41:38 *** cryptoIndio has quit IRC
1972019-11-23T08:41:52 *** rafalcpp has joined #bitcoin-core-dev
1982019-11-23T08:42:02 *** rafalcpp_ has quit IRC
1992019-11-23T08:44:13 *** Talkless has joined #bitcoin-core-dev
2002019-11-23T08:51:52 <meshcollider> achow101: I'm not sure why my test passes but yours doesn't
2012019-11-23T08:52:10 <meshcollider> I'm sure I've built the right one and running the right test ð¤
2022019-11-23T08:52:32 <meshcollider> Can someone else test #17568 quickly pls
2032019-11-23T08:52:34 <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
2042019-11-23T08:55:12 *** sipsorcery has joined #bitcoin-core-dev
2052019-11-23T08:58:57 *** EagleTM has quit IRC
2062019-11-23T08:59:37 *** rafalcpp_ has joined #bitcoin-core-dev
2072019-11-23T09:00:01 *** mmf has quit IRC
2082019-11-23T09:00:07 *** rafalcpp has quit IRC
2092019-11-23T09:01:52 *** schmidty has quit IRC
2102019-11-23T09:03:40 *** midnight has quit IRC
2112019-11-23T09:04:28 *** schmidty has joined #bitcoin-core-dev
2122019-11-23T09:10:27 <wumpus> sure i'll test
2132019-11-23T09:12:23 <wumpus> meshcollider: I get "test_framework.authproxy.JSONRPCException: Fee exceeds maximum configured by -maxtxfee (-4)" on master with the new test
2142019-11-23T09:13:16 <meshcollider> Hmm ok it must be something on my end then
2152019-11-23T09:13:39 <wumpus> isn't that what you expected?
2162019-11-23T09:14:19 <meshcollider> It's what is supposed to happen yeah, but it passed when I ran it lol
2172019-11-23T09:14:22 *** rafalcpp has joined #bitcoin-core-dev
2182019-11-23T09:14:31 <wumpus> strange!
2192019-11-23T09:14:37 *** rafalcpp_ has quit IRC
2202019-11-23T09:15:57 <wumpus> now tried to run it a few times, it seems reproducible, rpc_fundrawtransaction.py fails every time
2212019-11-23T09:16:47 *** midnightmagic has joined #bitcoin-core-dev
2222019-11-23T09:17:30 *** aljungberg has joined #bitcoin-core-dev
2232019-11-23T09:19:02 <wumpus> after recompiling with #17568 it passes
2242019-11-23T09:19:04 <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
2252019-11-23T09:19:27 *** AaronvanW has quit IRC
2262019-11-23T09:23:56 *** nosss2 has joined #bitcoin-core-dev
2272019-11-23T09:27:08 *** rafalcpp_ has joined #bitcoin-core-dev
2282019-11-23T09:27:11 *** rafalcpp has quit IRC
2292019-11-23T09:28:16 *** nosss2 has quit IRC
2302019-11-23T09:33:01 *** bitcoin-git has joined #bitcoin-core-dev
2312019-11-23T09:33:01 <bitcoin-git> [bitcoin] laanwj opened pull request #17569: build: Allow export of environ symbols (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
2322019-11-23T09:33:12 *** bitcoin-git has left #bitcoin-core-dev
2332019-11-23T09:33:59 *** rafalcpp has joined #bitcoin-core-dev
2342019-11-23T09:34:52 *** rafalcpp_ has quit IRC
2352019-11-23T09:36:52 <wumpus> fanquake: hopefully #17569 is the last step
2362019-11-23T09:36:54 <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
2372019-11-23T09:38:35 *** nosss2 has joined #bitcoin-core-dev
2382019-11-23T09:38:47 *** rafalcpp_ has joined #bitcoin-core-dev
2392019-11-23T09:40:00 *** rafalcpp has quit IRC
2402019-11-23T09:42:48 *** nosss2 has quit IRC
2412019-11-23T09:49:18 *** nosss2 has joined #bitcoin-core-dev
2422019-11-23T10:00:55 *** nosss2 has joined #bitcoin-core-dev
2432019-11-23T10:02:01 *** bitcoin-git has joined #bitcoin-core-dev
2442019-11-23T10:02:01 <bitcoin-git> [bitcoin] KaanKC opened pull request #17570: test: add unit test for non-standard txs w/ too large tx size (master...test_unit_IsStandardTx_tx-size) https://github.com/bitcoin/bitcoin/pull/17570
2452019-11-23T10:02:02 *** bitcoin-git has left #bitcoin-core-dev
2462019-11-23T10:04:38 *** rafalcpp has joined #bitcoin-core-dev
2472019-11-23T10:04:53 *** rafalcpp_ has quit IRC
2482019-11-23T10:05:26 *** marcoagner has joined #bitcoin-core-dev
2492019-11-23T10:05:41 *** nosss2 has quit IRC
2502019-11-23T10:10:25 *** rafalcpp_ has joined #bitcoin-core-dev
2512019-11-23T10:10:53 *** rafalcpp has quit IRC
2522019-11-23T10:12:03 *** nosss2 has joined #bitcoin-core-dev
2532019-11-23T10:16:18 *** nosss2 has quit IRC
2542019-11-23T10:19:06 *** rafalcpp_ has quit IRC
2552019-11-23T10:19:14 *** rafalcpp_ has joined #bitcoin-core-dev
2562019-11-23T10:22:06 *** spinza has joined #bitcoin-core-dev
2572019-11-23T10:25:48 *** nosss2 has joined #bitcoin-core-dev
2582019-11-23T10:26:33 *** emilengler has joined #bitcoin-core-dev
2592019-11-23T10:27:04 *** rafalcpp has joined #bitcoin-core-dev
2602019-11-23T10:27:30 *** rafalcpp_ has quit IRC
2612019-11-23T10:28:14 *** nosss2 has quit IRC
2622019-11-23T10:29:27 *** mryandao has quit IRC
2632019-11-23T10:29:33 *** AaronvanW has joined #bitcoin-core-dev
2642019-11-23T10:30:11 *** mryandao has joined #bitcoin-core-dev
2652019-11-23T10:31:53 *** rafalcpp_ has joined #bitcoin-core-dev
2662019-11-23T10:32:02 *** rafalcpp has quit IRC
2672019-11-23T10:32:09 *** EagleTM has joined #bitcoin-core-dev
2682019-11-23T10:33:54 *** AaronvanW has quit IRC
2692019-11-23T10:36:42 *** rafalcpp has joined #bitcoin-core-dev
2702019-11-23T10:37:17 *** rafalcpp_ has quit IRC
2712019-11-23T10:37:39 *** nosss2 has joined #bitcoin-core-dev
2722019-11-23T10:38:30 *** cryptoIndio has joined #bitcoin-core-dev
2732019-11-23T10:40:21 *** JeremyCrookshank has joined #bitcoin-core-dev
2742019-11-23T10:41:09 <JeremyCrookshank> Morning, is there a handy guide for developing the GUI using QT? I swear i've seen one but can't find it
2752019-11-23T10:41:37 *** EagleTM has quit IRC
2762019-11-23T10:43:23 *** cryptoIndio has quit IRC
2772019-11-23T10:43:28 <sipsorcery> JeremyCrookshank: only one I've seen is readme at https://github.com/bitcoin/bitcoin/tree/master/src/qt
2782019-11-23T10:44:12 <sipsorcery> someone else asked the same question here last week.
2792019-11-23T10:44:32 *** nosss2_ has joined #bitcoin-core-dev
2802019-11-23T10:44:36 *** nosss2 has quit IRC
2812019-11-23T10:45:02 <JeremyCrookshank> Perfect cheers
2822019-11-23T10:45:32 <emilengler> How can I execute multiple tests in one file?
2832019-11-23T10:45:46 <emilengler> Adding the second class to main does not work :/
2842019-11-23T10:49:21 *** nosss2_ has quit IRC
2852019-11-23T10:51:32 *** rafalcpp_ has joined #bitcoin-core-dev
2862019-11-23T10:51:37 *** rafalcpp has quit IRC
2872019-11-23T10:56:53 *** nosss2 has joined #bitcoin-core-dev
2882019-11-23T10:57:31 <wumpus> JeremyCrookshank: there's a lot of documentation on the Qt site, I think you need to be more specific in your question; FWIW, you can open the .ui files in qt designer
2892019-11-23T10:57:54 <wumpus> emilengler: which kind of tests? unit or functional?
2902019-11-23T10:58:08 <emilengler> wumpus: Functional
2912019-11-23T10:59:15 *** cryptoIndio has joined #bitcoin-core-dev
2922019-11-23T10:59:35 <jonatack> emilengler: did you have a look at test/functional/example_test.py?
2932019-11-23T11:00:11 <emilengler> jonatack: Sure
2942019-11-23T11:00:23 <emilengler> In #17536 it was said that it is possible to add multiple *.main() calls to the main function and then execute them
2952019-11-23T11:00:25 <gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler · Pull Request #17536 · bitcoin/bitcoin · GitHub
2962019-11-23T11:00:39 <wumpus> emilengler: you should only have one class per implementation file there; I'm not sure why you'd want multiple, some bigger tests do logical separateion of parts by having more methods and calling them in turn
2972019-11-23T11:00:55 <emilengler> But it does not work, also a "tail test/functional/*" does not show this aprroach for any other file (as far as I looked so far)
2982019-11-23T11:01:17 <emilengler> wumpus: I need to test two states of a cli arg
2992019-11-23T11:01:26 *** nosss2 has quit IRC
3002019-11-23T11:01:27 <emilengler> foo=0 and foo=1
3012019-11-23T11:01:47 <emilengler> As bitcoind needs a restart for it I thought about doing it in 2 files
3022019-11-23T11:01:58 <wumpus> you can restart bitcoind from your test, no problem
3032019-11-23T11:02:00 <emilengler> Or in one file with multiple classes which seem to not work
3042019-11-23T11:02:14 <emilengler> wumpus: Really? How?
3052019-11-23T11:02:53 <wumpus> there's plenty of tests that check different argument combinations, the easiest way is to have it spawn multiple bitcoind nodes initially, but if that's too much combinations, you can always start and stop nodes on request
3062019-11-23T11:03:19 <emilengler> Ok I will try, thanks :)
3072019-11-23T11:03:24 <wumpus> stop_node, restart_node,..
3082019-11-23T11:03:36 <jonatack> emilengler: test_framework.py:445: def restart_node(self, i, extra_args=None):
3092019-11-23T11:04:35 <jonatack> emilengler: (git grep "def restart")
3102019-11-23T11:08:37 *** rafalcpp_ has quit IRC
3112019-11-23T11:09:02 *** rafalcpp_ has joined #bitcoin-core-dev
3122019-11-23T11:11:21 *** nosss2 has joined #bitcoin-core-dev
3132019-11-23T11:14:28 *** nosss2_ has joined #bitcoin-core-dev
3142019-11-23T11:14:33 *** nosss2 has quit IRC
3152019-11-23T11:16:23 *** emilengler has quit IRC
3162019-11-23T11:17:14 *** rafalcpp_ has quit IRC
3172019-11-23T11:17:46 *** rafalcpp_ has joined #bitcoin-core-dev
3182019-11-23T11:18:50 *** nosss2_ has quit IRC
3192019-11-23T11:26:50 *** cryptoIndio has quit IRC
3202019-11-23T11:27:33 *** rafalcpp has joined #bitcoin-core-dev
3212019-11-23T11:28:01 *** rafalcpp_ has quit IRC
3222019-11-23T11:29:20 *** emilengler has joined #bitcoin-core-dev
3232019-11-23T11:32:20 *** rafalcpp_ has joined #bitcoin-core-dev
3242019-11-23T11:32:22 *** rafalcpp has quit IRC
3252019-11-23T11:37:01 <wumpus> AppVeyor is failing on "bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildSpendingTransaction(class CScript const &,struct CScriptWitness const &,class CTransaction const &)" (?BuildSpendingTransaction@@YA?AUCMutableTrans"
3262019-11-23T11:37:09 <wumpus> did anyone forget to update the MSVC build system?
3272019-11-23T11:37:53 <sipsorcery> wumpus: on master?
3282019-11-23T11:38:27 <wumpus> I think so, I'm seeing the same error in many PRs, even #17561 which only updates docs
3292019-11-23T11:38:29 <gribble> https://github.com/bitcoin/bitcoin/issues/17561 | doc: Changed MiniUPnPc link to https in dependencies.md by sandakersmann · Pull Request #17561 · bitcoin/bitcoin · GitHub
3302019-11-23T11:39:33 <sipsorcery> will check with a local msvc build (otherwise it's a 1hr turn around time for appveyor)
3312019-11-23T11:39:54 *** rafalcpp_ has quit IRC
3322019-11-23T11:40:09 *** rafalcpp_ has joined #bitcoin-core-dev
3332019-11-23T11:41:40 <wumpus> I think #17542 is most likely to have introduced it of recent changes
3342019-11-23T11:41:43 <gribble> https://github.com/bitcoin/bitcoin/issues/17542 | build: Create test utility library from src/test/util/ by brakmic · Pull Request #17542 · bitcoin/bitcoin · GitHub
3352019-11-23T11:42:00 *** nosss2 has joined #bitcoin-core-dev
3362019-11-23T11:43:28 *** AaronvanW has joined #bitcoin-core-dev
3372019-11-23T11:46:33 *** nosss2 has quit IRC
3382019-11-23T11:48:19 *** AaronvanW has quit IRC
3392019-11-23T11:51:12 <sipsorcery> wumpus: yes the msvc build of bench_bitcoin is failing on master. i will investigate.
3402019-11-23T11:52:47 *** nosss2 has joined #bitcoin-core-dev
3412019-11-23T11:52:48 *** rafalcpp_ has quit IRC
3422019-11-23T11:56:21 *** nosss2_ has joined #bitcoin-core-dev
3432019-11-23T11:56:29 *** nosss2 has quit IRC
3442019-11-23T11:58:27 *** rafalcpp_ has joined #bitcoin-core-dev
3452019-11-23T12:00:02 *** aljungberg has quit IRC
3462019-11-23T12:00:50 *** nosss2_ has quit IRC
3472019-11-23T12:06:05 *** cryptoIndio has joined #bitcoin-core-dev
3482019-11-23T12:06:17 *** rafalcpp_ has quit IRC
3492019-11-23T12:06:17 *** rafalcpp has joined #bitcoin-core-dev
3502019-11-23T12:08:47 *** SiAnDoG has quit IRC
3512019-11-23T12:10:01 *** SiAnDoG has joined #bitcoin-core-dev
3522019-11-23T12:13:28 *** nosss2 has joined #bitcoin-core-dev
3532019-11-23T12:15:09 *** cryptoIndio has quit IRC
3542019-11-23T12:15:25 *** cryptoIndio has joined #bitcoin-core-dev
3552019-11-23T12:16:37 *** mol has quit IRC
3562019-11-23T12:17:45 *** nosss2 has quit IRC
3572019-11-23T12:21:56 *** cryptoIndio has quit IRC
3582019-11-23T12:23:18 *** rafalcpp_ has joined #bitcoin-core-dev
3592019-11-23T12:23:36 *** rafalcpp has quit IRC
3602019-11-23T12:23:58 *** AaronvanW has joined #bitcoin-core-dev
3612019-11-23T12:27:48 *** rafalcpp_ has quit IRC
3622019-11-23T12:28:07 *** rafalcpp_ has joined #bitcoin-core-dev
3632019-11-23T12:28:15 *** AaronvanW has quit IRC
3642019-11-23T12:30:36 *** nosss2 has joined #bitcoin-core-dev
3652019-11-23T12:30:56 <wumpus> sipsorcery: thanks!
3662019-11-23T12:32:32 <sipsorcery> wumpus: np. you were correct the new libtest_util lib from #17452 is not part of the msvc build config. i've added and will submit PR imminently.
3672019-11-23T12:32:35 <gribble> https://github.com/bitcoin/bitcoin/issues/17452 | lib: update fuzz directory in .gitignore by jonatack · Pull Request #17452 · bitcoin/bitcoin · GitHub
3682019-11-23T12:34:50 *** nosss2 has quit IRC
3692019-11-23T12:35:07 *** nosss2 has joined #bitcoin-core-dev
3702019-11-23T12:35:21 <darosior> meshcollider, wumpus, achow101: The test added in #17568 pass on master for me as well..
3712019-11-23T12:35:23 <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
3722019-11-23T12:39:33 *** rafalcpp_ has quit IRC
3732019-11-23T12:39:40 *** rafalcpp has joined #bitcoin-core-dev
3742019-11-23T12:40:23 *** nosss2 has quit IRC
3752019-11-23T12:42:18 *** EagleTM has joined #bitcoin-core-dev
3762019-11-23T12:44:09 *** nosss2 has joined #bitcoin-core-dev
3772019-11-23T12:45:25 *** bitcoin-git has joined #bitcoin-core-dev
3782019-11-23T12:45:25 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17571: WIP: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
3792019-11-23T12:45:27 *** bitcoin-git has left #bitcoin-core-dev
3802019-11-23T12:47:03 *** ButterflyOfFire has joined #bitcoin-core-dev
3812019-11-23T12:48:26 *** nosss2 has quit IRC
3822019-11-23T12:48:31 *** cryptoIn_ has joined #bitcoin-core-dev
3832019-11-23T12:49:35 *** cryptoIn_ has quit IRC
3842019-11-23T12:54:32 *** rafalcpp has quit IRC
3852019-11-23T12:54:39 *** nosss2 has joined #bitcoin-core-dev
3862019-11-23T12:55:00 <JeremyCrookshank> Anyone know why Qt-creator says the Bitcoin form .h files aren't part of the project? Not able to add slots because of it
3872019-11-23T12:55:09 <JeremyCrookshank> Doesn't do it on the sample project
3882019-11-23T12:57:55 <wumpus> the .pro isn't a suitable build system for building the project, it simply collects the form files for editing in qt creator / designer, it might be that some advanced functionality doesn't work
3892019-11-23T12:59:06 *** spinza has quit IRC
3902019-11-23T12:59:14 *** AaronvanW has joined #bitcoin-core-dev
3912019-11-23T12:59:16 *** emilengler has quit IRC
3922019-11-23T12:59:30 *** emilengler has joined #bitcoin-core-dev
3932019-11-23T12:59:55 *** jonatack_ has joined #bitcoin-core-dev
3942019-11-23T13:00:23 <JeremyCrookshank> Hmm okay so i'll have to code in slots manually as the qt-creator option doesn't work
3952019-11-23T13:00:31 *** misterwhatever has joined #bitcoin-core-dev
3962019-11-23T13:00:36 <wumpus> yes
3972019-11-23T13:01:02 <JeremyCrookshank> Thats annoying :p
3982019-11-23T13:01:47 *** nosss2 has quit IRC
3992019-11-23T13:03:08 *** jonatack has quit IRC
4002019-11-23T13:03:47 *** AaronvanW has quit IRC
4012019-11-23T13:04:42 <wumpus> yes it is, but it's also not really worth it to maintain another build system for it, and I think most devs prefer implementing the hooks and such manually to have more control over what happens
4022019-11-23T13:05:32 *** gelmutshmidt has joined #bitcoin-core-dev
4032019-11-23T13:05:44 <wumpus> also .pro is very limited as build systems go, I don't think it'd even be possible to use it anymore to build the full project. ofc, your could simply add the .h files to it and see that helps.
4042019-11-23T13:06:09 <wumpus> if it's just a matter of the IDE needing to find the code
4052019-11-23T13:06:17 *** gelmutshmidt has quit IRC
4062019-11-23T13:06:44 *** gelmutshmidt has joined #bitcoin-core-dev
4072019-11-23T13:08:28 <JeremyCrookshank> Yeah tried that already unfortunately
4082019-11-23T13:08:45 *** cryptoIndio has joined #bitcoin-core-dev
4092019-11-23T13:08:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4102019-11-23T13:11:16 *** cryptoIndio has quit IRC
4112019-11-23T13:15:02 *** MrPaz has joined #bitcoin-core-dev
4122019-11-23T13:19:33 *** nosss2 has joined #bitcoin-core-dev
4132019-11-23T13:19:42 *** AaronvanW has joined #bitcoin-core-dev
4142019-11-23T13:20:40 *** misterwhatever has quit IRC
4152019-11-23T13:23:57 *** nosss2 has quit IRC
4162019-11-23T13:27:31 *** Highway61 has joined #bitcoin-core-dev
4172019-11-23T13:28:32 *** spinza has joined #bitcoin-core-dev
4182019-11-23T13:40:50 *** rex4539 has quit IRC
4192019-11-23T13:42:04 *** emilengler has quit IRC
4202019-11-23T13:42:15 *** emilengler has joined #bitcoin-core-dev
4212019-11-23T13:48:46 *** MrPaz has quit IRC
4222019-11-23T13:51:38 *** Chris_Stewart_5 has quit IRC
4232019-11-23T13:57:09 *** Highway62 has joined #bitcoin-core-dev
4242019-11-23T13:57:14 <fanquake> wumpus hopefully ð
4252019-11-23T13:57:14 *** spinza has quit IRC
4262019-11-23T13:59:18 *** Highway61 has quit IRC
4272019-11-23T13:59:18 *** Highway62 is now known as Highway61
4282019-11-23T14:10:58 *** pinheadmz_ has joined #bitcoin-core-dev
4292019-11-23T14:13:17 *** pinheadmz has quit IRC
4302019-11-23T14:13:17 *** pinheadmz_ is now known as pinheadmz
4312019-11-23T14:20:05 *** cryptoIndio has joined #bitcoin-core-dev
4322019-11-23T14:22:41 *** cryptoIndio has quit IRC
4332019-11-23T14:25:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4342019-11-23T14:26:05 *** cryptoIndio has joined #bitcoin-core-dev
4352019-11-23T14:28:33 *** cryptoIndio has quit IRC
4362019-11-23T14:34:00 *** braydonf has quit IRC
4372019-11-23T14:36:15 <wumpus> at least locally it seems to make the gitian linux build pass again
4382019-11-23T14:40:38 *** Chris_Stewart_5 has quit IRC
4392019-11-23T14:47:15 *** braydonf has joined #bitcoin-core-dev
4402019-11-23T14:47:23 *** Aaronvan_ has joined #bitcoin-core-dev
4412019-11-23T14:49:57 *** AaronvanW has quit IRC
4422019-11-23T14:57:02 *** ExtraCrispy has joined #bitcoin-core-dev
4432019-11-23T14:58:10 *** cryptoIndio has joined #bitcoin-core-dev
4442019-11-23T15:00:02 *** ButterflyOfFire has quit IRC
4452019-11-23T15:00:43 *** cryptoIndio has quit IRC
4462019-11-23T15:01:07 *** JamesAU has joined #bitcoin-core-dev
4472019-11-23T15:04:17 *** nik-j has quit IRC
4482019-11-23T15:07:01 *** cryptoIndio has joined #bitcoin-core-dev
4492019-11-23T15:07:41 *** Aaronvan_ is now known as AaronvanW
4502019-11-23T15:17:32 *** dvratil has joined #bitcoin-core-dev
4512019-11-23T15:19:45 *** cryptoIndio has quit IRC
4522019-11-23T15:20:20 *** AaronvanW has quit IRC
4532019-11-23T15:28:39 <wumpus> or not, I get a NX failure after "Checking binary security" for RISC-V now, wtf
4542019-11-23T15:31:57 <wumpus> crap, after a failed build it doesn't cache the dependencies, so it needs to build qt all over again next time...
4552019-11-23T15:33:31 <fanquake> ugh
4562019-11-23T15:35:53 <wumpus> I wonder what broke the rv64 build, it might well be another change entirely, or something is messed up here locally
4572019-11-23T15:36:17 *** rabidus has quit IRC
4582019-11-23T15:38:24 *** rabidus has joined #bitcoin-core-dev
4592019-11-23T15:38:30 *** cryptoIndio has joined #bitcoin-core-dev
4602019-11-23T15:41:10 *** cryptoIndio has quit IRC
4612019-11-23T15:46:32 *** AaronvanW has joined #bitcoin-core-dev
4622019-11-23T15:46:35 *** alex911kz has joined #bitcoin-core-dev
4632019-11-23T15:50:17 *** Highway61 has quit IRC
4642019-11-23T15:50:56 *** Highway61 has joined #bitcoin-core-dev
4652019-11-23T15:52:21 *** owowo has quit IRC
4662019-11-23T15:57:12 *** owowo has joined #bitcoin-core-dev
4672019-11-23T16:02:05 *** cryptoIndio has joined #bitcoin-core-dev
4682019-11-23T16:05:06 *** cryptoIndio has quit IRC
4692019-11-23T16:07:02 *** spinza has joined #bitcoin-core-dev
4702019-11-23T16:07:51 *** Highway61 has quit IRC
4712019-11-23T16:10:37 *** spinza has quit IRC
4722019-11-23T16:12:28 *** jonatack_ has quit IRC
4732019-11-23T16:13:00 *** nik-j has joined #bitcoin-core-dev
4742019-11-23T16:13:54 *** jonatack_ has joined #bitcoin-core-dev
4752019-11-23T16:16:20 *** nik-j has quit IRC
4762019-11-23T16:22:21 *** pinheadmz_ has joined #bitcoin-core-dev
4772019-11-23T16:25:33 *** pinheadmz has quit IRC
4782019-11-23T16:25:33 *** pinheadmz_ is now known as pinheadmz
4792019-11-23T16:30:41 *** bitcoin-git has joined #bitcoin-core-dev
4802019-11-23T16:30:41 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b79caf65801...33c103e2fe67
4812019-11-23T16:30:42 <bitcoin-git> bitcoin/master 794fe91 Hennadii Stepanov: doc: Update and improve Developer Notes
4822019-11-23T16:30:42 <bitcoin-git> bitcoin/master 33c103e fanquake: Merge #17539: doc: Update and improve Developer Notes
4832019-11-23T16:30:44 *** bitcoin-git has left #bitcoin-core-dev
4842019-11-23T16:31:01 *** bitcoin-git has joined #bitcoin-core-dev
4852019-11-23T16:31:01 <bitcoin-git> [bitcoin] fanquake merged pull request #17539: doc: Update and improve Developer Notes (master...20191120-developer-notes) https://github.com/bitcoin/bitcoin/pull/17539
4862019-11-23T16:31:02 *** bitcoin-git has left #bitcoin-core-dev
4872019-11-23T16:31:18 *** emil__ has joined #bitcoin-core-dev
4882019-11-23T16:35:02 *** emilengler has quit IRC
4892019-11-23T16:36:19 *** JamesAU has quit IRC
4902019-11-23T16:38:11 <achow101> meshcollider: darosior: it consistently fails for me on master
4912019-11-23T16:38:56 *** adiabat has quit IRC
4922019-11-23T16:41:48 <wumpus> same here
4932019-11-23T16:42:39 <cfields> jonasschnelli: Looks like your macos sig is invalid :(
4942019-11-23T16:42:40 *** spinza has joined #bitcoin-core-dev
4952019-11-23T16:42:41 <cfields> cory@Macbook:~/dev/bitcoin$ spctl --assess -vv /Volumes/Bitcoin-Core/Bitcoin-Qt.app
4962019-11-23T16:42:41 <cfields> /Volumes/Bitcoin-Core/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified)
4972019-11-23T16:44:36 <cfields> Oh wait, might be my local problem.
4982019-11-23T16:47:30 *** nik-j_ has joined #bitcoin-core-dev
4992019-11-23T16:48:57 *** nosss2 has joined #bitcoin-core-dev
5002019-11-23T16:50:57 <cfields> Yup, all good.
5012019-11-23T16:51:08 <fanquake> ð
5022019-11-23T16:51:08 <cfields> Gitian builders: detached sigs for v0.19.0.1 are up
5032019-11-23T16:51:37 *** nik-j_ has quit IRC
5042019-11-23T16:51:56 *** bitcoin-git has joined #bitcoin-core-dev
5052019-11-23T16:51:56 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17573: Seed RNG with precision timestamps on receipt of net messages. (master...2019-11-rng-netmsg) https://github.com/bitcoin/bitcoin/pull/17573
5062019-11-23T16:51:57 *** bitcoin-git has left #bitcoin-core-dev
5072019-11-23T16:52:42 *** jonatack_ has quit IRC
5082019-11-23T16:52:58 *** jonatack has joined #bitcoin-core-dev
5092019-11-23T16:53:18 *** nosss2 has quit IRC
5102019-11-23T17:04:42 *** cryptoIndio has joined #bitcoin-core-dev
5112019-11-23T17:07:08 *** cryptoIndio has quit IRC
5122019-11-23T17:11:15 <wumpus> cfields: jonasschnelli: great, thanks!
5132019-11-23T17:20:30 *** lnostdal has joined #bitcoin-core-dev
5142019-11-23T17:27:49 *** cryptoIndio has joined #bitcoin-core-dev
5152019-11-23T17:28:36 *** alex911_kz has joined #bitcoin-core-dev
5162019-11-23T17:28:40 *** gelmuth_ has joined #bitcoin-core-dev
5172019-11-23T17:30:17 *** alex911kz has quit IRC
5182019-11-23T17:30:17 *** gelmutshmidt has quit IRC
5192019-11-23T17:30:39 *** cryptoIndio has quit IRC
5202019-11-23T17:33:45 *** nik-j has joined #bitcoin-core-dev
5212019-11-23T17:38:15 *** nik-j has quit IRC
5222019-11-23T17:39:39 *** bitcoin-git has joined #bitcoin-core-dev
5232019-11-23T17:39:39 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33c103e2fe67...2c98e2024d52
5242019-11-23T17:39:40 <bitcoin-git> bitcoin/master b509554 Aaron Clauson: Added libtest_util library to msvc build configuration.
5252019-11-23T17:39:40 <bitcoin-git> bitcoin/master 2c98e20 fanquake: Merge #17571: Add libtest_util library to msvc build configuration
5262019-11-23T17:39:43 *** bitcoin-git has left #bitcoin-core-dev
5272019-11-23T17:39:59 *** bitcoin-git has joined #bitcoin-core-dev
5282019-11-23T17:39:59 <bitcoin-git> [bitcoin] fanquake merged pull request #17571: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
5292019-11-23T17:40:00 *** bitcoin-git has left #bitcoin-core-dev
5302019-11-23T17:49:43 *** Highway61 has joined #bitcoin-core-dev
5312019-11-23T17:54:19 *** jonatack has quit IRC
5322019-11-23T17:54:25 *** Highway61 has quit IRC
5332019-11-23T18:00:02 *** dvratil has quit IRC
5342019-11-23T18:00:19 *** spinza has quit IRC
5352019-11-23T18:00:28 *** JamesAU has joined #bitcoin-core-dev
5362019-11-23T18:01:14 *** cryptoIn_ has joined #bitcoin-core-dev
5372019-11-23T18:10:20 *** nosss2 has joined #bitcoin-core-dev
5382019-11-23T18:10:32 *** ExtraCrispy has quit IRC
5392019-11-23T18:16:19 *** spinza has joined #bitcoin-core-dev
5402019-11-23T18:16:54 *** zone117x1 has joined #bitcoin-core-dev
5412019-11-23T18:18:55 *** spinza has quit IRC
5422019-11-23T18:18:56 *** gelmuth_ has quit IRC
5432019-11-23T18:20:16 *** cryptoIn_ has quit IRC
5442019-11-23T18:27:31 *** AaronvanW has quit IRC
5452019-11-23T18:31:04 *** andrewtoth_ has quit IRC
5462019-11-23T18:31:19 *** spinza has joined #bitcoin-core-dev
5472019-11-23T18:42:39 *** Victorsueca has quit IRC
5482019-11-23T18:43:13 *** Victorsueca has joined #bitcoin-core-dev
5492019-11-23T18:44:26 <provoostenator> ^ rebase time!
5502019-11-23T18:45:00 *** spinza has quit IRC
5512019-11-23T18:47:04 *** Tommy19 has joined #bitcoin-core-dev
5522019-11-23T18:50:45 *** spinza has joined #bitcoin-core-dev
5532019-11-23T18:57:46 *** nosss2 has quit IRC
5542019-11-23T18:58:18 *** nosss2 has joined #bitcoin-core-dev
5552019-11-23T19:02:42 *** JeremyCrookshank has quit IRC
5562019-11-23T19:02:50 *** nosss2 has quit IRC
5572019-11-23T19:02:55 *** adiabat has joined #bitcoin-core-dev
5582019-11-23T19:03:21 *** AaronvanW has joined #bitcoin-core-dev
5592019-11-23T19:07:58 *** AaronvanW has quit IRC
5602019-11-23T19:14:31 *** spinza has quit IRC
5612019-11-23T19:17:37 *** sipsorcery has quit IRC
5622019-11-23T19:17:38 *** spinza has joined #bitcoin-core-dev
5632019-11-23T19:22:41 *** fox2p has quit IRC
5642019-11-23T19:23:08 *** fox2p has joined #bitcoin-core-dev
5652019-11-23T19:33:17 <wumpus> the gitian RV64 check failure is not caused by #17270, it appears, but some later change, I'm bisecting
5662019-11-23T19:33:20 <gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa · Pull Request #17270 · bitcoin/bitcoin · GitHub
5672019-11-23T19:34:43 *** nik-j has joined #bitcoin-core-dev
5682019-11-23T19:34:46 <sipa> wumpus: strange
5692019-11-23T19:35:31 *** nik-j_ has joined #bitcoin-core-dev
5702019-11-23T19:35:54 *** nik-j has quit IRC
5712019-11-23T19:37:39 *** nik-j_ has quit IRC
5722019-11-23T19:40:27 <wumpus> i suspect it's some build system change that makes it eat a required flag
5732019-11-23T19:42:34 *** cino94 has joined #bitcoin-core-dev
5742019-11-23T19:46:49 *** spinza has quit IRC
5752019-11-23T19:47:55 *** cino94 has quit IRC
5762019-11-23T19:49:04 *** llfsdfsdfsfs has joined #bitcoin-core-dev
5772019-11-23T19:53:54 *** llfsdfsdfsfs has quit IRC
5782019-11-23T19:58:58 *** cino94 has joined #bitcoin-core-dev
5792019-11-23T20:03:43 *** cino94 has quit IRC
5802019-11-23T20:05:45 <fanquake> wumpus maybe it was broken when we removed OpenSSL ð
5812019-11-23T20:07:19 <wumpus> definitely possible !
5822019-11-23T20:14:52 *** nik-j_ has joined #bitcoin-core-dev
5832019-11-23T20:19:38 *** nosss2 has joined #bitcoin-core-dev
5842019-11-23T20:19:39 *** nik-j_ has quit IRC
5852019-11-23T20:21:43 *** justanotheruser has joined #bitcoin-core-dev
5862019-11-23T20:26:04 *** justanotheruser has quit IRC
5872019-11-23T20:27:20 *** dviola has joined #bitcoin-core-dev
5882019-11-23T20:28:35 *** alex911kz has joined #bitcoin-core-dev
5892019-11-23T20:31:46 *** alex911_kz has quit IRC
5902019-11-23T20:33:04 *** nosss2 has quit IRC
5912019-11-23T20:33:21 <fanquake> "PS this seems to be causing a noise inversely proportional to the complexity of the change" https://github.com/bitcoin/bitcoin/pull/17563#issuecomment-557829862
5922019-11-23T20:33:33 *** nosss2 has joined #bitcoin-core-dev
5932019-11-23T20:33:37 *** spinza has joined #bitcoin-core-dev
5942019-11-23T20:33:49 <fanquake> What else was he expecting when he PR'd an initially poorly explained change to the ifdef hackery inside random.cpp
5952019-11-23T20:35:49 <wumpus> we're pretty consistent in this, too, I've closed PRs of myself too when 'working around a warning' was just not worth the mess
5962019-11-23T20:37:38 *** nosss2 has quit IRC
5972019-11-23T20:37:48 <fanquake> The initial change just felt like a Debian OpenSSL Valgrind scenario
5982019-11-23T20:40:27 *** justanotheruser has joined #bitcoin-core-dev
5992019-11-23T20:47:23 *** EagleTM has quit IRC
6002019-11-23T20:50:27 <wumpus> bisected it to b49b6b0f7090cc15860d815fb0ef306ddfc718ba, so indeed seems that the change has to do with openssl removal, very curious
6012019-11-23T20:54:01 <fanquake> interesting
6022019-11-23T20:54:10 <wumpus> it's not even a build system change, just the last change that causes no symbols from openssl to be used anymore
6032019-11-23T20:54:28 <sipa> heh
6042019-11-23T20:54:30 *** EagleTM has joined #bitcoin-core-dev
6052019-11-23T20:54:37 *** DougieBot5000 has joined #bitcoin-core-dev
6062019-11-23T20:55:40 <wumpus> it looks like we never explicitly pass -Wl,--noexecstack except to openssl
6072019-11-23T20:56:16 <meshcollider> darosior: thanks for testing, good to know it's not just me haha. I'll try and investigate today
6082019-11-23T20:56:32 <wumpus> all the other architectures default to it, though, so might as well be an ubuntu compiler issue
6092019-11-23T20:56:46 *** spinza has quit IRC
6102019-11-23T20:57:23 *** DougieBot5000_ has quit IRC
6112019-11-23T20:57:34 *** pinheadmz has quit IRC
6122019-11-23T20:59:44 <potatoe_face> %
6132019-11-23T21:00:02 *** zone117x1 has quit IRC
6142019-11-23T21:01:16 *** spinza has joined #bitcoin-core-dev
6152019-11-23T21:04:15 *** pinheadmz has joined #bitcoin-core-dev
6162019-11-23T21:10:06 *** potatoe_face has quit IRC
6172019-11-23T21:11:38 *** potatoe_face has joined #bitcoin-core-dev
6182019-11-23T21:16:09 *** potatoe_face has quit IRC
6192019-11-23T21:16:24 *** potatoe_face has joined #bitcoin-core-dev
6202019-11-23T21:17:02 *** rh0nj has quit IRC
6212019-11-23T21:18:08 *** rh0nj has joined #bitcoin-core-dev
6222019-11-23T21:30:19 *** AaronvanW has joined #bitcoin-core-dev
6232019-11-23T21:35:20 *** AaronvanW has quit IRC
6242019-11-23T21:39:55 *** potatoe_face has quit IRC
6252019-11-23T21:40:16 *** potatoe_face has joined #bitcoin-core-dev
6262019-11-23T21:40:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6272019-11-23T21:42:18 *** justanotheruser has quit IRC
6282019-11-23T21:43:16 *** potatoe_face has quit IRC
6292019-11-23T21:43:35 *** potatoe_face has joined #bitcoin-core-dev
6302019-11-23T21:43:38 *** alex911kz has quit IRC
6312019-11-23T21:47:51 *** MaddinSM has joined #bitcoin-core-dev
6322019-11-23T21:48:33 <wumpus> it's good that we have the security check or we'd never have noticed; the workaround of adding -Wl,-z,noexecstack explicitly on RISC-V in the descriptor seems to work, but I'm still trying to figure out why it doesn't get set automatically there
6332019-11-23T21:56:08 *** Chris_Stewart_5 has quit IRC
6342019-11-23T22:02:46 *** justanotheruser has joined #bitcoin-core-dev
6352019-11-23T22:18:59 *** dviola has quit IRC
6362019-11-23T22:25:11 <fanquake> wumpus good hunting
6372019-11-23T22:30:14 <wumpus> thanks! this one was very sneaky; hopefully this was the last problem and we can start using gitian again
6382019-11-23T22:30:59 *** AaronvanW has joined #bitcoin-core-dev
6392019-11-23T22:37:08 *** Tommy19 has quit IRC
6402019-11-23T22:44:32 *** b10c has joined #bitcoin-core-dev
6412019-11-23T22:54:21 *** jonatack has joined #bitcoin-core-dev
6422019-11-23T23:01:09 *** cryptoIndio has joined #bitcoin-core-dev
6432019-11-23T23:04:17 <achow101> meshcollider: are you sure you have an updated master? The issue was only after #17290 was merged
6442019-11-23T23:04:19 <gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 · Pull Request #17290 · bitcoin/bitcoin · GitHub
6452019-11-23T23:08:21 *** nosss2 has joined #bitcoin-core-dev
6462019-11-23T23:10:47 <meshcollider> well yeah I merged it haha
6472019-11-23T23:11:07 <achow101> could be an old branch/ different worktree, i dunno
6482019-11-23T23:11:21 <meshcollider> Yeah I'll double check later and recompile fresh master
6492019-11-23T23:23:26 *** cryptoIndio has joined #bitcoin-core-dev
6502019-11-23T23:28:18 *** cryptoIndio has quit IRC
6512019-11-23T23:32:00 *** AaronvanW has quit IRC
6522019-11-23T23:32:17 *** AaronvanW has joined #bitcoin-core-dev
6532019-11-23T23:34:51 *** b10c has quit IRC
6542019-11-23T23:49:20 *** Giszmo has joined #bitcoin-core-dev
6552019-11-23T23:51:28 *** emil__ has quit IRC
6562019-11-23T23:58:32 *** nik-j has joined #bitcoin-core-dev