12019-11-25T00:00:01 *** litenull has quit IRC
22019-11-25T00:03:57 *** Chris_Stewart_5 has quit IRC
32019-11-25T00:05:12 *** murray has joined #bitcoin-core-dev
42019-11-25T00:05:35 *** murray is now known as Guest75709
52019-11-25T00:05:58 *** Guest75709 has left #bitcoin-core-dev
62019-11-25T00:06:05 *** cryptoIndio has joined #bitcoin-core-dev
72019-11-25T00:06:42 *** murrayn has joined #bitcoin-core-dev
82019-11-25T00:08:49 *** nosss2 has quit IRC
92019-11-25T00:09:18 *** nosss2 has joined #bitcoin-core-dev
102019-11-25T00:10:31 *** bitcoin-git has joined #bitcoin-core-dev
112019-11-25T00:10:32 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/746318179884...e6f167bfdfc0
122019-11-25T00:10:33 <bitcoin-git> bitcoin/master f6e4225 Wladimir J. van der Laan: build: Allow export of environ symbols
132019-11-25T00:10:34 <bitcoin-git> bitcoin/master eafd259 Wladimir J. van der Laan: build: Add NX workaround for RV64
142019-11-25T00:10:35 <bitcoin-git> bitcoin/master e6f167b MarcoFalke: Merge #17569: build: Allow export of environ symbols and work around rv64 ...
152019-11-25T00:10:41 *** bitcoin-git has left #bitcoin-core-dev
162019-11-25T00:10:59 *** nosss2 has quit IRC
172019-11-25T00:11:01 *** bitcoin-git has joined #bitcoin-core-dev
182019-11-25T00:11:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17569: build: Allow export of environ symbols and work around rv64 toolchain issue (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
192019-11-25T00:11:03 *** bitcoin-git has left #bitcoin-core-dev
202019-11-25T00:13:17 *** Chris_Stewart_5 has joined #bitcoin-core-dev
212019-11-25T00:14:33 *** nijynot_ has quit IRC
222019-11-25T00:15:10 *** nik-j has joined #bitcoin-core-dev
232019-11-25T00:23:54 *** cryptoIndio has quit IRC
242019-11-25T00:24:26 *** Chris_Stewart_5 has quit IRC
252019-11-25T00:25:49 *** nik-j has quit IRC
262019-11-25T00:26:33 *** trudistrongo has quit IRC
272019-11-25T00:26:51 *** cryptoIndio has joined #bitcoin-core-dev
282019-11-25T00:28:42 *** sipsorcery has joined #bitcoin-core-dev
292019-11-25T00:32:21 *** nik-j has joined #bitcoin-core-dev
302019-11-25T00:32:38 *** cryptoIndio has quit IRC
312019-11-25T00:37:09 *** nik-j has quit IRC
322019-11-25T00:39:06 *** promag has joined #bitcoin-core-dev
332019-11-25T00:40:42 *** rabidus has quit IRC
342019-11-25T00:43:13 *** promag has quit IRC
352019-11-25T00:45:22 *** fox2p has quit IRC
362019-11-25T00:46:17 *** Chris_Stewart_5 has joined #bitcoin-core-dev
372019-11-25T00:46:50 *** Phace has joined #bitcoin-core-dev
382019-11-25T00:48:01 *** fox2p has joined #bitcoin-core-dev
392019-11-25T00:49:54 *** rabidus has joined #bitcoin-core-dev
402019-11-25T01:00:47 *** davterra has quit IRC
412019-11-25T01:02:17 *** alex911_kz has joined #bitcoin-core-dev
422019-11-25T01:05:00 *** nik-j has joined #bitcoin-core-dev
432019-11-25T01:12:12 *** Fuzzbawl_ has quit IRC
442019-11-25T01:13:39 *** Fuzzbawls has joined #bitcoin-core-dev
452019-11-25T01:14:17 *** nik-j has quit IRC
462019-11-25T01:15:49 *** marcoagner has quit IRC
472019-11-25T01:15:50 *** cryptoIndio has joined #bitcoin-core-dev
482019-11-25T01:24:00 *** AaronvanW has quit IRC
492019-11-25T01:38:21 *** pinheadmz has joined #bitcoin-core-dev
502019-11-25T01:44:43 *** cubancorona has joined #bitcoin-core-dev
512019-11-25T01:47:43 *** Willo__ has quit IRC
522019-11-25T01:56:54 *** bitcoin-git has joined #bitcoin-core-dev
532019-11-25T01:56:54 <bitcoin-git> [bitcoin] jonatack opened pull request #17585: rpc: deprecate getaddressinfo label (master...deprecate-getaddressinfo-label) https://github.com/bitcoin/bitcoin/pull/17585
542019-11-25T01:56:55 *** bitcoin-git has left #bitcoin-core-dev
552019-11-25T02:00:36 *** sdaftuar has quit IRC
562019-11-25T02:01:33 *** sdaftuar has joined #bitcoin-core-dev
572019-11-25T02:03:49 *** cryptoIndio has quit IRC
582019-11-25T02:07:04 *** cryptoIndio has joined #bitcoin-core-dev
592019-11-25T02:08:26 *** Chris_Stewart_5 has quit IRC
602019-11-25T02:29:39 *** nik-j has joined #bitcoin-core-dev
612019-11-25T02:34:44 *** nik-j has quit IRC
622019-11-25T02:43:30 *** nosss2 has joined #bitcoin-core-dev
632019-11-25T02:44:44 *** rex4539 has quit IRC
642019-11-25T02:50:42 *** rex4539 has joined #bitcoin-core-dev
652019-11-25T02:59:27 *** justanotheruser has joined #bitcoin-core-dev
662019-11-25T03:00:02 *** Phace has quit IRC
672019-11-25T03:02:02 *** achow101 has quit IRC
682019-11-25T03:05:33 *** felixfoertsch23 has joined #bitcoin-core-dev
692019-11-25T03:06:35 *** felixfoertsch has quit IRC
702019-11-25T03:12:26 *** achow101 has joined #bitcoin-core-dev
712019-11-25T03:17:20 *** Mlpearc has joined #bitcoin-core-dev
722019-11-25T03:24:00 *** nik-j has joined #bitcoin-core-dev
732019-11-25T03:26:39 *** reallll has joined #bitcoin-core-dev
742019-11-25T03:28:17 *** nik-j has quit IRC
752019-11-25T03:29:37 *** belcher has quit IRC
762019-11-25T03:51:43 *** cryptoIndio has quit IRC
772019-11-25T04:13:33 *** EagleTM has joined #bitcoin-core-dev
782019-11-25T04:14:11 *** Eagle[TM] has quit IRC
792019-11-25T04:29:13 *** Fuzzbawl_ has joined #bitcoin-core-dev
802019-11-25T04:30:20 *** sipsorcery has quit IRC
812019-11-25T04:30:26 *** Fuzzbawls has quit IRC
822019-11-25T04:39:20 *** cryptoIndio has joined #bitcoin-core-dev
832019-11-25T04:54:26 *** nosss2 has quit IRC
842019-11-25T04:54:55 *** nosss2 has joined #bitcoin-core-dev
852019-11-25T04:58:00 *** nosss2 has quit IRC
862019-11-25T04:58:16 *** nik-j has joined #bitcoin-core-dev
872019-11-25T04:58:42 *** nosss2 has joined #bitcoin-core-dev
882019-11-25T04:58:50 *** deadlysin has quit IRC
892019-11-25T05:02:23 *** nik-j has quit IRC
902019-11-25T05:03:14 *** nosss2 has quit IRC
912019-11-25T05:03:22 *** deadlysin has joined #bitcoin-core-dev
922019-11-25T05:07:01 *** nosss2 has joined #bitcoin-core-dev
932019-11-25T05:15:14 *** felixfoertsch23 has quit IRC
942019-11-25T05:15:24 *** felixfoertsch has joined #bitcoin-core-dev
952019-11-25T05:25:05 *** astro has quit IRC
962019-11-25T05:26:07 *** sipsorcery has joined #bitcoin-core-dev
972019-11-25T05:31:54 *** Victor_sueca has joined #bitcoin-core-dev
982019-11-25T05:34:28 *** Victorsueca has quit IRC
992019-11-25T05:35:18 *** astro has joined #bitcoin-core-dev
1002019-11-25T05:35:30 *** nik-j has joined #bitcoin-core-dev
1012019-11-25T05:39:37 *** nik-j has quit IRC
1022019-11-25T05:49:23 *** DeanWeen has joined #bitcoin-core-dev
1032019-11-25T05:51:24 *** kristapsk_ has joined #bitcoin-core-dev
1042019-11-25T05:52:04 *** Dean_Guss has quit IRC
1052019-11-25T05:52:32 *** kristapsk has quit IRC
1062019-11-25T06:00:01 *** Mlpearc has quit IRC
1072019-11-25T06:00:10 *** sipsorcery has quit IRC
1082019-11-25T06:17:21 *** thrig1 has joined #bitcoin-core-dev
1092019-11-25T06:29:02 *** nik-j has joined #bitcoin-core-dev
1102019-11-25T06:33:56 *** nik-j has quit IRC
1112019-11-25T06:38:46 *** nosss2 has quit IRC
1122019-11-25T06:39:15 *** nosss2 has joined #bitcoin-core-dev
1132019-11-25T06:43:37 *** nosss2 has quit IRC
1142019-11-25T06:50:47 *** nosss2 has joined #bitcoin-core-dev
1152019-11-25T06:55:18 *** nosss2 has quit IRC
1162019-11-25T06:56:04 *** sipsorcery has joined #bitcoin-core-dev
1172019-11-25T07:07:42 *** _andrewtoth_ has joined #bitcoin-core-dev
1182019-11-25T07:09:04 *** andrewtoth_ has quit IRC
1192019-11-25T07:09:28 *** nik-j has joined #bitcoin-core-dev
1202019-11-25T07:12:02 *** EagleTM has quit IRC
1212019-11-25T07:15:42 *** nik-j has quit IRC
1222019-11-25T07:19:39 *** Guyver2 has joined #bitcoin-core-dev
1232019-11-25T07:24:08 *** nik-j has joined #bitcoin-core-dev
1242019-11-25T07:29:51 *** sipsorcery has quit IRC
1252019-11-25T07:35:14 *** nik-j has quit IRC
1262019-11-25T07:36:55 *** nik-j has joined #bitcoin-core-dev
1272019-11-25T07:40:57 *** nik-j has quit IRC
1282019-11-25T07:41:30 *** nik-j has joined #bitcoin-core-dev
1292019-11-25T07:42:01 *** rh0nj has quit IRC
1302019-11-25T07:43:07 *** rh0nj has joined #bitcoin-core-dev
1312019-11-25T07:46:29 *** reallll is now known as belcher
1322019-11-25T07:47:38 *** nik-j has quit IRC
1332019-11-25T07:49:45 *** nik-j has joined #bitcoin-core-dev
1342019-11-25T07:54:02 *** nik-j has quit IRC
1352019-11-25T07:55:37 *** DougieBot5000 has quit IRC
1362019-11-25T08:00:40 *** nik-j has joined #bitcoin-core-dev
1372019-11-25T08:01:40 *** jonatack_ has joined #bitcoin-core-dev
1382019-11-25T08:04:10 *** sipsorcery has joined #bitcoin-core-dev
1392019-11-25T08:04:43 *** jonatack has quit IRC
1402019-11-25T08:04:57 *** nik-j has quit IRC
1412019-11-25T08:08:40 *** EagleTM has joined #bitcoin-core-dev
1422019-11-25T08:11:35 *** nik-j has joined #bitcoin-core-dev
1432019-11-25T08:11:55 *** promag has joined #bitcoin-core-dev
1442019-11-25T08:12:51 *** cryptoIndio has quit IRC
1452019-11-25T08:15:38 *** nik-j has quit IRC
1462019-11-25T08:15:57 *** promag has quit IRC
1472019-11-25T08:17:17 *** EagleTM has quit IRC
1482019-11-25T08:27:15 *** nik-j has joined #bitcoin-core-dev
1492019-11-25T08:29:03 *** b10c has joined #bitcoin-core-dev
1502019-11-25T08:34:16 *** DougieBot5000 has joined #bitcoin-core-dev
1512019-11-25T08:35:17 *** nik-j has quit IRC
1522019-11-25T08:37:40 *** cryptoIndio has joined #bitcoin-core-dev
1532019-11-25T08:39:50 *** b10c has quit IRC
1542019-11-25T08:41:21 *** b10c has joined #bitcoin-core-dev
1552019-11-25T08:49:25 *** nik-j has joined #bitcoin-core-dev
1562019-11-25T08:53:51 <wumpus> appveyor failing: "C:\projects\bitcoin\src\httpserver.cpp(373,5): error C3861: 'evthread_use_windows_threads': identifier not found [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]"
1572019-11-25T08:54:20 <wumpus> that symbol is definitely supposed to exist on windows libevent
1582019-11-25T08:56:02 *** nik-j has quit IRC
1592019-11-25T08:57:17 <meshcollider> when is appveyor *not* failing...
1602019-11-25T08:58:05 <wumpus> I'm not sure what broke it this time, last time it was clear (someone forgot to update the MSVC buidl system) but this is less apparent
1612019-11-25T08:59:30 <wumpus> the most recent libevent related change was #17008 but it definitely passed after that, and the depends version shouldn't affect the version used in appveyor
1622019-11-25T08:59:33 <gribble> https://github.com/bitcoin/bitcoin/issues/17008 | build: bump libevent to 2.1.11 in depends by stefanwouldgo · Pull Request #17008 · bitcoin/bitcoin · GitHub
1632019-11-25T08:59:54 <meshcollider> perhaps some weird header include thing with #17518 ?
1642019-11-25T08:59:57 <gribble> https://github.com/bitcoin/bitcoin/issues/17518 | refactor, wallet: Nuke coincontrol circular dependency by hebasto · Pull Request #17518 · bitcoin/bitcoin · GitHub
1652019-11-25T09:00:01 *** thrig1 has quit IRC
1662019-11-25T09:00:37 <wumpus> I mean the reason that appveyor breaks all the time is because people ignore appveyor before merging, because it breaks all the time, we kind of need to break that circle *shrug*
1672019-11-25T09:01:43 *** sipsorcery has quit IRC
1682019-11-25T09:01:57 *** sipsorcery has joined #bitcoin-core-dev
1692019-11-25T09:02:32 <wumpus> at least gitian builds work again!
1702019-11-25T09:03:46 *** kljasdfvv has joined #bitcoin-core-dev
1712019-11-25T09:07:54 *** marcoagner has joined #bitcoin-core-dev
1722019-11-25T09:09:15 <meshcollider> true, appveyor has failed on pretty much every single open PR so it kinda just becomes cry-wolf
1732019-11-25T09:09:23 <meshcollider> we need to fix it and then rebase every PR at once ;)
1742019-11-25T09:09:32 <hebasto> meshcollider: which include do you mean?
1752019-11-25T09:09:52 <meshcollider> Not sure, it was just the first PR that was merged after the last appveyor fix and appveyor failed on it
1762019-11-25T09:09:56 <meshcollider> https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/29078106
1772019-11-25T09:10:06 *** bitcoin-git has joined #bitcoin-core-dev
1782019-11-25T09:10:06 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/1bc9988993ee...dd198064b5d9
1792019-11-25T09:10:06 <bitcoin-git> bitcoin/0.19 dd19806 Wladimir J. van der Laan: doc: Clear out release notes after 0.19.0.1
1802019-11-25T09:10:17 *** bitcoin-git has left #bitcoin-core-dev
1812019-11-25T09:10:39 <meshcollider> because when fanquake merged #17571, appveyor actually passed
1822019-11-25T09:10:40 <wumpus> I don't think the linking error can be caused by an include change
1832019-11-25T09:10:41 <gribble> https://github.com/bitcoin/bitcoin/issues/17571 | Add libtest_util library to msvc build configuration by sipsorcery · Pull Request #17571 · bitcoin/bitcoin · GitHub
1842019-11-25T09:11:08 <meshcollider> something must have changed in between those two PRs though right, if it passed on one and failed on the other?
1852019-11-25T09:11:17 <wumpus> true
1862019-11-25T09:12:29 <wumpus> though it could also be a change in between when the appveyor test was run on 17571 and merging time, on master
1872019-11-25T09:14:03 *** nosss2 has joined #bitcoin-core-dev
1882019-11-25T09:14:18 <meshcollider> it did pass on the merge commit though
1892019-11-25T09:14:35 <meshcollider> not just sipsorcery's commit
1902019-11-25T09:14:42 <wumpus> right, it could also be something entirely unrelated, like a dependency/cache change by appveyor itself
1912019-11-25T09:15:47 <wumpus> we've had similar things with travis at times
1922019-11-25T09:16:31 *** bitcoin-git has joined #bitcoin-core-dev
1932019-11-25T09:16:32 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/dd198064b5d9...a284bbbee805
1942019-11-25T09:16:33 <bitcoin-git> bitcoin/0.19 2aba76c Hennadii Stepanov: qt: Fix missing qRegisterMetaType for size_t
1952019-11-25T09:16:34 <bitcoin-git> bitcoin/0.19 a284bbb Hennadii Stepanov: refactor: Styling w/ clang-format, comment update
1962019-11-25T09:16:36 *** bitcoin-git has left #bitcoin-core-dev
1972019-11-25T09:16:46 <wumpus> the 0.19 branch is free for merging for 0.19.1
1982019-11-25T09:17:00 *** nijynot_ has joined #bitcoin-core-dev
1992019-11-25T09:17:04 *** chrippa has joined #bitcoin-core-dev
2002019-11-25T09:18:32 *** nosss2 has quit IRC
2012019-11-25T09:18:43 <sipsorcery> for the appveyor job it would be worthwhile to force an update of the vcpkg installed dependencies
2022019-11-25T09:18:56 <hebasto> appveyor complains about error in httpserver.cpp and warning "boost-system's buildsystem uses very long paths and may fail on your system." They seem related to each other/
2032019-11-25T09:19:29 <sipsorcery> i don't get the 'evthread_use_windows_threads' compilation error on my own job and the only difference should be the vcpkg state
2042019-11-25T09:20:03 <sipsorcery> hebasto: that warning has been around for a while and is harmless
2052019-11-25T09:20:08 <wumpus> hebasto: the boost build warning is standard
2062019-11-25T09:20:10 <wumpus> right
2072019-11-25T09:21:57 <sipsorcery> the appveyor job's cache can be triggered to purge by touching the build_msvc\vcpkg-pacakges.txt file, or
2082019-11-25T09:22:46 <sipsorcery> manually by sending a http request of the form curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/sipsorcery/bitcoin-72c17/buildcache
2092019-11-25T09:23:35 <wumpus> ah, something that doesn't involve changing a file in the repository seems preferable
2102019-11-25T09:23:38 <sipsorcery> the latter method is preferable but it requires access to the APPVEYOR_TOKEN
2112019-11-25T09:24:02 <wumpus> does not need a specific person's token?
2122019-11-25T09:24:09 <wumpus> or does it?
2132019-11-25T09:24:14 *** nosss2 has joined #bitcoin-core-dev
2142019-11-25T09:24:29 <wumpus> I see mine under "API key"
2152019-11-25T09:24:30 <sipsorcery> the token needs to be of the account that owns the job
2162019-11-25T09:25:16 <meshcollider> which would be DrahtBot I believe
2172019-11-25T09:26:07 <wumpus> right, I get {"message":"Account not found or access denied."}
2182019-11-25T09:27:06 <wumpus> if it's DrahtBot, let's wait for MarcoFalke
2192019-11-25T09:27:27 *** jungly has joined #bitcoin-core-dev
2202019-11-25T09:27:57 *** murrayn has quit IRC
2212019-11-25T09:28:26 *** nosss2 has quit IRC
2222019-11-25T09:30:41 <sipsorcery> has anyone use the new github actions for bitcoin core builds?
2232019-11-25T09:30:54 <sipsorcery> seems they have linux, windows and mac images
2242019-11-25T09:31:45 <wumpus> I haven't used github actions, as we have our own build process, it doesn't seem particularly useful for us so haven't paid much attention to it
2252019-11-25T09:31:46 *** cryptoIndio has quit IRC
2262019-11-25T09:33:24 <sipsorcery> the appveyor build takes over 2x the time it takes on my average machine
2272019-11-25T09:33:45 <sipsorcery> was wondering if github actions would be faster
2282019-11-25T09:34:02 <sipsorcery> I'll have a play around
2292019-11-25T09:35:28 *** nik-j has joined #bitcoin-core-dev
2302019-11-25T09:36:35 *** marcoagner has quit IRC
2312019-11-25T09:36:42 <wumpus> not very different from travis :)
2322019-11-25T09:39:42 *** nik-j has quit IRC
2332019-11-25T09:45:22 <hebasto> meshcollider: wumpus: I've restored removed header from 17518 - it doesn't help https://ci.appveyor.com/project/hebasto/bitcoin/builds/29095602
2342019-11-25T09:45:58 <meshcollider> hebasto: oh thanks! Good to know
2352019-11-25T09:46:56 <wumpus> I managed to get Drahtbot's token (there's a dropdown in the API key page), but unfortunatly, still get the same "Account not found or access denied." error with that curl command
2362019-11-25T09:48:00 <sipsorcery> you also need to change the owner and project ID to match
2372019-11-25T09:48:28 <sipsorcery> this bit in the url is specific to my account and job "sipsorcery/bitcoin-72c17"
2382019-11-25T09:50:19 *** timothy has joined #bitcoin-core-dev
2392019-11-25T09:51:35 *** nik-j has joined #bitcoin-core-dev
2402019-11-25T09:52:34 <wumpus> ok, tried it with https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache, which at least gives me a different permission denied error :-)
2412019-11-25T09:54:16 <sipsorcery> it won't be DrahtBot/bitcoin
2422019-11-25T09:54:24 <sipsorcery> it will be DrahtBot/bitcoin-xxxx
2432019-11-25T09:54:53 *** rex4539 has quit IRC
2442019-11-25T09:55:01 <sipsorcery> if you open the appveyor project and go to the settings the ID is in the "Project URL slug" field
2452019-11-25T09:55:37 *** nik-j has quit IRC
2462019-11-25T09:56:37 *** nosss2 has joined #bitcoin-core-dev
2472019-11-25T09:58:03 *** promag has joined #bitcoin-core-dev
2482019-11-25T10:00:57 *** nosss2 has quit IRC
2492019-11-25T10:02:15 *** nik-j has joined #bitcoin-core-dev
2502019-11-25T10:05:25 <hebasto> if skip AppVeyor's error in httpserver.cpp it fires another one: torcontrol.cpp(745,5): error C3861: 'evthread_use_windows_threads': identifier not found
2512019-11-25T10:05:35 *** promag_ has joined #bitcoin-core-dev
2522019-11-25T10:06:08 *** promag has quit IRC
2532019-11-25T10:06:13 <hebasto> Interesting that event2/thread.h is included...
2542019-11-25T10:06:17 *** nik-j has quit IRC
2552019-11-25T10:09:55 *** nosss2 has joined #bitcoin-core-dev
2562019-11-25T10:11:20 <sipsorcery> looks like the vcpkg libevent port did change something to do with threads on 25th of Sep, https://bit.ly/2XK3biN
2572019-11-25T10:11:21 <hebasto> So, AppVeyor build uses Libevent that built without support for evthread_use_windows_threads(); submitting an issue.
2582019-11-25T10:13:13 <sipsorcery> my appveyor job does build bitcoin core successfully on master and the only difference will be my job has a more recent update of vcpkg
2592019-11-25T10:13:16 <hebasto> sipsorcery: see #17568
2602019-11-25T10:13:18 <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
2612019-11-25T10:13:41 <hebasto> Sorry: #17586
2622019-11-25T10:13:44 <gribble> https://github.com/bitcoin/bitcoin/issues/17586 | build: AppVeyor build uses Libevent that built without support for evthread_use_windows_threads() · Issue #17586 · bitcoin/bitcoin · GitHub
2632019-11-25T10:14:18 *** promag_ has quit IRC
2642019-11-25T10:14:26 *** nosss2 has quit IRC
2652019-11-25T10:17:28 *** goatpig has joined #bitcoin-core-dev
2662019-11-25T10:18:37 *** nik-j has joined #bitcoin-core-dev
2672019-11-25T10:21:57 *** nosss2 has joined #bitcoin-core-dev
2682019-11-25T10:23:06 <sipsorcery> hebasto: thx, i'll try and reproduce
2692019-11-25T10:23:23 *** nik-j has quit IRC
2702019-11-25T10:26:22 *** nosss2 has quit IRC
2712019-11-25T10:29:25 *** promag has joined #bitcoin-core-dev
2722019-11-25T10:29:48 *** nosss2 has joined #bitcoin-core-dev
2732019-11-25T10:31:17 *** promag has quit IRC
2742019-11-25T10:31:35 *** nik-j has joined #bitcoin-core-dev
2752019-11-25T10:34:17 *** nosss2 has quit IRC
2762019-11-25T10:35:03 *** nosss2 has joined #bitcoin-core-dev
2772019-11-25T10:36:29 *** nik-j has quit IRC
2782019-11-25T10:39:17 *** nosss2 has quit IRC
2792019-11-25T10:39:26 *** bitcoin-git has joined #bitcoin-core-dev
2802019-11-25T10:39:26 <bitcoin-git> [bitcoin] Sjors opened pull request #17587: gui: show watch-only balance in send screen (master...2019/11/send_balance) https://github.com/bitcoin/bitcoin/pull/17587
2812019-11-25T10:39:27 *** bitcoin-git has left #bitcoin-core-dev
2822019-11-25T10:43:53 *** Bullit has quit IRC
2832019-11-25T10:44:25 *** Bullit has joined #bitcoin-core-dev
2842019-11-25T10:45:21 *** misterwhatever has joined #bitcoin-core-dev
2852019-11-25T10:45:57 *** rabidus has quit IRC
2862019-11-25T10:46:42 *** nik-j has joined #bitcoin-core-dev
2872019-11-25T10:46:58 *** chrippa has quit IRC
2882019-11-25T10:47:22 *** nosss2 has joined #bitcoin-core-dev
2892019-11-25T10:47:33 *** promag has joined #bitcoin-core-dev
2902019-11-25T10:48:05 *** rabidus has joined #bitcoin-core-dev
2912019-11-25T10:49:47 *** AaronvanW has joined #bitcoin-core-dev
2922019-11-25T10:51:20 *** nik-j has quit IRC
2932019-11-25T10:51:59 *** jungly has quit IRC
2942019-11-25T10:54:09 *** nosss2 has quit IRC
2952019-11-25T10:57:16 *** misterwhatever has quit IRC
2962019-11-25T10:58:26 *** rabidus has quit IRC
2972019-11-25T10:58:50 *** nosss2 has joined #bitcoin-core-dev
2982019-11-25T11:00:37 *** rabidus has joined #bitcoin-core-dev
2992019-11-25T11:02:30 *** nik-j has joined #bitcoin-core-dev
3002019-11-25T11:02:35 *** jcorgan has quit IRC
3012019-11-25T11:02:57 *** nosss2 has quit IRC
3022019-11-25T11:04:02 *** rex4539 has joined #bitcoin-core-dev
3032019-11-25T11:06:14 *** nosss2 has joined #bitcoin-core-dev
3042019-11-25T11:06:43 *** nik-j has quit IRC
3052019-11-25T11:11:17 *** nosss2 has quit IRC
3062019-11-25T11:12:23 *** rabidus has quit IRC
3072019-11-25T11:12:24 *** subdriven1 has joined #bitcoin-core-dev
3082019-11-25T11:14:12 *** rabidus has joined #bitcoin-core-dev
3092019-11-25T11:15:27 *** nosss2 has joined #bitcoin-core-dev
3102019-11-25T11:15:56 *** jungly has joined #bitcoin-core-dev
3112019-11-25T11:19:59 *** nosss2 has quit IRC
3122019-11-25T11:20:12 *** murray has joined #bitcoin-core-dev
3132019-11-25T11:20:24 *** nik-j has joined #bitcoin-core-dev
3142019-11-25T11:20:36 *** murray is now known as Guest65112
3152019-11-25T11:20:42 *** Guest65112 has left #bitcoin-core-dev
3162019-11-25T11:21:37 *** murrayn has joined #bitcoin-core-dev
3172019-11-25T11:22:06 *** nosss2 has joined #bitcoin-core-dev
3182019-11-25T11:24:53 *** nik-j has quit IRC
3192019-11-25T11:27:14 *** nosss2 has quit IRC
3202019-11-25T11:31:20 *** nosss2 has joined #bitcoin-core-dev
3212019-11-25T11:35:12 *** MarcoFal- has joined #bitcoin-core-dev
3222019-11-25T11:35:45 *** nosss2 has quit IRC
3232019-11-25T11:38:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3242019-11-25T11:39:48 *** MarcoFalke has quit IRC
3252019-11-25T11:39:48 *** baldur has quit IRC
3262019-11-25T11:42:19 *** Victorsueca has joined #bitcoin-core-dev
3272019-11-25T11:42:23 *** nosss2 has joined #bitcoin-core-dev
3282019-11-25T11:43:54 *** TheRec_ has joined #bitcoin-core-dev
3292019-11-25T11:44:49 *** baldur has joined #bitcoin-core-dev
3302019-11-25T11:45:35 *** jungly_ has joined #bitcoin-core-dev
3312019-11-25T11:45:36 *** cfields_ has joined #bitcoin-core-dev
3322019-11-25T11:45:45 *** hex17or has joined #bitcoin-core-dev
3332019-11-25T11:48:32 *** nullptr| has quit IRC
3342019-11-25T11:48:32 *** TheRec has quit IRC
3352019-11-25T11:48:33 *** jungly has quit IRC
3362019-11-25T11:48:33 *** Victor_sueca has quit IRC
3372019-11-25T11:48:33 *** cfields has quit IRC
3382019-11-25T11:48:33 *** hex17or_ has quit IRC
3392019-11-25T11:48:33 *** Murch has quit IRC
3402019-11-25T11:48:33 *** Zenton has quit IRC
3412019-11-25T11:48:33 *** jnewbery has quit IRC
3422019-11-25T11:49:06 *** nosss2 has quit IRC
3432019-11-25T11:49:48 *** nullptr| has joined #bitcoin-core-dev
3442019-11-25T11:49:49 *** misterwhatever has joined #bitcoin-core-dev
3452019-11-25T11:50:58 *** jnewbery has joined #bitcoin-core-dev
3462019-11-25T11:56:46 *** promag has quit IRC
3472019-11-25T11:59:53 *** misterwhatever has quit IRC
3482019-11-25T12:00:02 *** subdriven1 has quit IRC
3492019-11-25T12:00:04 *** nosss2 has joined #bitcoin-core-dev
3502019-11-25T12:02:50 *** promag has joined #bitcoin-core-dev
3512019-11-25T12:04:37 *** nosss2 has quit IRC
3522019-11-25T12:04:51 <wumpus> provoostenator: btw, for the 0.19.0.1 release I've added your torrent tracker to the trackers
3532019-11-25T12:06:38 *** vasil has joined #bitcoin-core-dev
3542019-11-25T12:09:28 *** vasil is now known as vasild
3552019-11-25T12:12:10 *** nosss2 has joined #bitcoin-core-dev
3562019-11-25T12:12:30 *** vasild has quit IRC
3572019-11-25T12:13:50 *** Murch has joined #bitcoin-core-dev
3582019-11-25T12:15:11 *** kpyke has joined #bitcoin-core-dev
3592019-11-25T12:16:24 *** misterwhatever has joined #bitcoin-core-dev
3602019-11-25T12:16:28 *** vasild has joined #bitcoin-core-dev
3612019-11-25T12:16:29 *** nosss2 has quit IRC
3622019-11-25T12:18:24 *** AaronvanW has quit IRC
3632019-11-25T12:19:33 *** nosss2 has joined #bitcoin-core-dev
3642019-11-25T12:24:16 *** nosss2 has quit IRC
3652019-11-25T12:27:34 *** misterwhatever has left #bitcoin-core-dev
3662019-11-25T12:32:46 *** AaronvanW has joined #bitcoin-core-dev
3672019-11-25T12:33:31 *** nosss2 has joined #bitcoin-core-dev
3682019-11-25T12:35:12 *** Emcy_ has quit IRC
3692019-11-25T12:37:28 *** nijynot_ has quit IRC
3702019-11-25T12:37:46 *** nijynot has joined #bitcoin-core-dev
3712019-11-25T12:37:48 *** nosss2 has quit IRC
3722019-11-25T12:40:42 <vasild> jkczyz: What do you think of https://github.com/bitcoin/bitcoin/pull/17577?
3732019-11-25T12:42:18 <wumpus> sipsorcery: from what I understand from the change in https://github.com/microsoft/vcpkg/pull/8349, "thread" needs to be specified as an explicit feature since that change, e.g. libevent[thread]
3742019-11-25T12:43:45 <wumpus> I'm somewhat unsure why anyone in almost-2020 would want to default to a non-thread build, but okay, at least it's an explanation
3752019-11-25T12:45:04 *** nosss2 has joined #bitcoin-core-dev
3762019-11-25T12:46:11 <sipa> wumpus: perhaps there is a significant performance difference?
3772019-11-25T12:47:38 *** promag has quit IRC
3782019-11-25T12:48:25 <sipsorcery> wumpus: ah I see now. I somehow missed "feature packages" being added to vcpkg. I'll test the build again swapping libevent to libevent[thread].
3792019-11-25T12:48:40 *** AaronvanW has quit IRC
3802019-11-25T12:49:04 *** Emcy has joined #bitcoin-core-dev
3812019-11-25T12:49:43 <wumpus> sipa: the threading implementation is pluggable, I don't think there's much overhead on a threading-built libevent with threading not initialized versus one built without threading-- anyhow I definitely hope linux distributions won't do this...
3822019-11-25T12:50:07 <sipsorcery> the vcpkg PR that disabled threads for libevent didn't give an explanation. I've put a whinge in the PR comments to try and get one.
3832019-11-25T12:50:45 *** promag has joined #bitcoin-core-dev
3842019-11-25T12:51:49 *** Chris_Stewart_5 has quit IRC
3852019-11-25T12:51:56 *** nosss2 has quit IRC
3862019-11-25T12:53:12 <wumpus> I'm really happy that this got caught on the missing function instead of silently going to thread-unsafe
3872019-11-25T12:53:23 *** Zenton has joined #bitcoin-core-dev
3882019-11-25T12:54:39 <wumpus> I remember we had an issue in the beginning (2011? 2012?) where for some reason, bitcoin was linked against a single-threaded standard library on windows and this wasn't caught as a compile time issue, resulting in some really ugly unpredictable crashes
3892019-11-25T12:54:57 *** promag has quit IRC
3902019-11-25T12:55:31 *** promag has joined #bitcoin-core-dev
3912019-11-25T12:56:53 *** nosss2 has joined #bitcoin-core-dev
3922019-11-25T12:57:14 *** murrayn has quit IRC
3932019-11-25T12:57:38 *** murray has joined #bitcoin-core-dev
3942019-11-25T12:58:01 *** murray is now known as Guest53584
3952019-11-25T12:58:25 <wumpus> which reminds me I recently stumbled on a mechanism called ".gnu.build.attributes" which fedora uses, it allows auditing that an entire binary (and its dependencies) have been compiled with certain build settings and hardening flags, by storing these per address region
3962019-11-25T12:58:42 <wumpus> this might be something useful for us in the future
3972019-11-25T13:01:08 *** nosss2 has quit IRC
3982019-11-25T13:01:38 *** bitcoin-git has joined #bitcoin-core-dev
3992019-11-25T13:01:38 <bitcoin-git> [bitcoin] muzafa-popo opened pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
4002019-11-25T13:01:39 *** bitcoin-git has left #bitcoin-core-dev
4012019-11-25T13:01:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4022019-11-25T13:02:11 <wumpus> fanquake: that was fast!
4032019-11-25T13:02:13 *** bitcoin-git has joined #bitcoin-core-dev
4042019-11-25T13:02:13 <bitcoin-git> [bitcoin] fanquake closed pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
4052019-11-25T13:02:15 *** bitcoin-git has left #bitcoin-core-dev
4062019-11-25T13:02:32 *** promag has quit IRC
4072019-11-25T13:03:20 <sipa> "fanquake, faster than his shadow bitcoin-git"
4082019-11-25T13:03:28 <wumpus> hehehe
4092019-11-25T13:07:56 *** nosss2 has joined #bitcoin-core-dev
4102019-11-25T13:09:03 *** bitcoin-git has joined #bitcoin-core-dev
4112019-11-25T13:09:03 <bitcoin-git> [bitcoin] elichai opened pull request #17591: Testing bitcoin in a Big Endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
4122019-11-25T13:09:04 *** bitcoin-git has left #bitcoin-core-dev
4132019-11-25T13:11:04 *** daniel has joined #bitcoin-core-dev
4142019-11-25T13:11:46 *** daniel is now known as Guest54499
4152019-11-25T13:11:47 *** nosss2 has quit IRC
4162019-11-25T13:13:24 *** Guyver2 has quit IRC
4172019-11-25T13:15:13 *** davterra has joined #bitcoin-core-dev
4182019-11-25T13:20:01 *** deadlysin has quit IRC
4192019-11-25T13:21:37 *** tryphe has quit IRC
4202019-11-25T13:21:45 *** nik-j has joined #bitcoin-core-dev
4212019-11-25T13:22:25 *** nosss2 has joined #bitcoin-core-dev
4222019-11-25T13:26:57 *** nosss2 has quit IRC
4232019-11-25T13:28:08 *** bitcoin-git has joined #bitcoin-core-dev
4242019-11-25T13:28:08 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
4252019-11-25T13:28:10 *** bitcoin-git has left #bitcoin-core-dev
4262019-11-25T13:35:19 *** bitcoin-git has joined #bitcoin-core-dev
4272019-11-25T13:35:19 <bitcoin-git> [bitcoin] mzumsande opened pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
4282019-11-25T13:35:20 *** bitcoin-git has left #bitcoin-core-dev
4292019-11-25T13:35:51 *** AaronvanW has joined #bitcoin-core-dev
4302019-11-25T13:40:20 *** harrigan has quit IRC
4312019-11-25T13:40:38 *** nik-j has quit IRC
4322019-11-25T13:53:07 *** Chris_Stewart_5 has quit IRC
4332019-11-25T13:57:29 *** Heisenberg_Hunte has joined #bitcoin-core-dev
4342019-11-25T13:58:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4352019-11-25T13:59:53 *** Heisenberg_Hunte has quit IRC
4362019-11-25T14:00:06 *** Heisenberg_Hunte has joined #bitcoin-core-dev
4372019-11-25T14:10:05 *** promag has joined #bitcoin-core-dev
4382019-11-25T14:12:31 *** heisenberg-m80 has joined #bitcoin-core-dev
4392019-11-25T14:13:03 <provoostenator> wumpus: the 0.17.2 seems stuck in limbo?
4402019-11-25T14:13:27 <wumpus> provoostenator: yes
4412019-11-25T14:13:36 <provoostenator> What needs to happen?
4422019-11-25T14:14:26 *** promag has quit IRC
4432019-11-25T14:14:26 <provoostenator> By the way, I whitelisted the 0.19.0.1 on my tracker (thanks for adding that) and it now has the most seeders of all of the trackers :-)
4442019-11-25T14:14:33 <provoostenator> *torrent
4452019-11-25T14:15:01 <wumpus> I don't know, I think 0.17 became EOL while 0.19 was released
4462019-11-25T14:15:51 *** nijynot has quit IRC
4472019-11-25T14:16:21 <wumpus> is the gitian build done? is it just a matter of uploading binaries for it? might still do it in that case
4482019-11-25T14:17:09 <provoostenator> It has 6 signed binaries
4492019-11-25T14:17:51 <provoostenator> So indeed seems like a matter of releasing it. I'll whitelist that torrent as well.
4502019-11-25T14:18:39 *** cubancorona has quit IRC
4512019-11-25T14:19:43 <provoostenator> (looks like we don't link to torrents for old releases anywhere though)
4522019-11-25T14:19:45 *** Heisenberg_Hunte has left #bitcoin-core-dev
4532019-11-25T14:20:34 *** heisenberg-m80 has quit IRC
4542019-11-25T14:21:15 <provoostenator> Might be useful to link those from the release page, because such a link is more likely to survice a .org apocalypse than a binary.
4552019-11-25T14:21:17 <wumpus> oh, I wonder why not
4562019-11-25T14:22:37 <wumpus> I suppose the magnet link is still in the yml files for people intent on finding it; it's just not exposed. FWIW I'm still seeding the latest release on 0.17 0.18 0.19 branch
4572019-11-25T14:22:55 <wumpus> well, 0.17 is not the latest at the moment :)
4582019-11-25T14:25:21 <fanquake> Speaking of older releases. Review beg for #16617.
4592019-11-25T14:25:24 <gribble> https://github.com/bitcoin/bitcoin/issues/16617 | [0.18.2] Backports by fanquake · Pull Request #16617 · bitcoin/bitcoin · GitHub
4602019-11-25T14:27:44 *** sipa has quit IRC
4612019-11-25T14:27:46 <fanquake> Seems this is our second uninitialized var issue in as many weeks: https://github.com/bitcoin/bitcoin/pull/17568#issuecomment-558026462
4622019-11-25T14:28:00 *** justanotheruser has quit IRC
4632019-11-25T14:29:04 <wumpus> fanquake: oh noo
4642019-11-25T14:29:12 *** nijynot has joined #bitcoin-core-dev
4652019-11-25T14:33:19 <elichai2> I guess it's time for a valgrind run in the CI ð
4662019-11-25T14:35:21 *** harrigan has joined #bitcoin-core-dev
4672019-11-25T14:43:40 *** nik-j has joined #bitcoin-core-dev
4682019-11-25T14:48:02 <wumpus> yes, IIRC there's a PR for that
4692019-11-25T14:48:17 *** nik-j has quit IRC
4702019-11-25T14:48:53 *** nik-j has joined #bitcoin-core-dev
4712019-11-25T14:53:47 *** nik-j has quit IRC
4722019-11-25T14:59:22 *** mdunnio has joined #bitcoin-core-dev
4732019-11-25T15:00:01 *** kpyke has quit IRC
4742019-11-25T15:11:37 *** Guyver2 has joined #bitcoin-core-dev
4752019-11-25T15:17:15 *** retroj1 has joined #bitcoin-core-dev
4762019-11-25T15:18:29 *** nijynot has quit IRC
4772019-11-25T15:22:46 *** bitcoin-git has joined #bitcoin-core-dev
4782019-11-25T15:22:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e6f167bfdfc0...89a1f7a250ef
4792019-11-25T15:22:47 <bitcoin-git> bitcoin/master f13e274 Aaron Clauson: Appveyor install libevent[thread] vcpkg
4802019-11-25T15:22:48 <bitcoin-git> bitcoin/master 89a1f7a MarcoFalke: Merge #17592: Appveyor install libevent[thread] vcpkg
4812019-11-25T15:22:50 *** bitcoin-git has left #bitcoin-core-dev
4822019-11-25T15:23:05 *** bitcoin-git has joined #bitcoin-core-dev
4832019-11-25T15:23:05 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
4842019-11-25T15:23:06 *** bitcoin-git has left #bitcoin-core-dev
4852019-11-25T15:23:42 *** nijynot has joined #bitcoin-core-dev
4862019-11-25T15:24:15 *** aqquadro has joined #bitcoin-core-dev
4872019-11-25T15:30:06 *** goatpig has quit IRC
4882019-11-25T15:35:06 *** aqquadro has quit IRC
4892019-11-25T15:41:51 <fanquake> thanks wumpus
4902019-11-25T15:41:55 *** nik-j has joined #bitcoin-core-dev
4912019-11-25T15:43:30 *** bitcoin-git has joined #bitcoin-core-dev
4922019-11-25T15:43:30 <bitcoin-git> [bitcoin] laanwj merged pull request #16617: [0.18.2] Backports (0.18...0_18_2_backports) https://github.com/bitcoin/bitcoin/pull/16617
4932019-11-25T15:43:31 *** bitcoin-git has left #bitcoin-core-dev
4942019-11-25T15:44:51 *** nijynot has quit IRC
4952019-11-25T15:45:06 *** rabidus has quit IRC
4962019-11-25T15:47:04 *** rabidus has joined #bitcoin-core-dev
4972019-11-25T15:52:15 *** nosss2 has joined #bitcoin-core-dev
4982019-11-25T15:54:37 *** nik-j has quit IRC
4992019-11-25T16:14:12 *** nosss2 has quit IRC
5002019-11-25T16:14:42 *** nosss2 has joined #bitcoin-core-dev
5012019-11-25T16:18:57 *** nosss2 has quit IRC
5022019-11-25T16:20:30 *** bitcoin-git has joined #bitcoin-core-dev
5032019-11-25T16:20:30 <bitcoin-git> [bitcoin] dongcarl opened pull request #17595: guix: Enable building for `x86_64-w64-mingw32` target (master...2019-09-guix-staging-win-mingw-6.0.0) https://github.com/bitcoin/bitcoin/pull/17595
5042019-11-25T16:20:31 *** bitcoin-git has left #bitcoin-core-dev
5052019-11-25T16:20:33 *** Talkless has joined #bitcoin-core-dev
5062019-11-25T16:21:38 *** Talkless has quit IRC
5072019-11-25T16:22:25 *** Talkless has joined #bitcoin-core-dev
5082019-11-25T16:30:24 *** nik-j has joined #bitcoin-core-dev
5092019-11-25T16:36:20 <instagibbs_> BlueMatt, Is there any larger discussion on what is left that #17573 is solving? Or is this a general "more is better" approach
5102019-11-25T16:36:22 <gribble> https://github.com/bitcoin/bitcoin/issues/17573 | Seed RNG with precision timestamps on receipt of net messages. by TheBlueMatt · Pull Request #17573 · bitcoin/bitcoin · GitHub
5112019-11-25T16:36:34 <instagibbs_> without derailing that PR which looks reasonable, hence asking here
5122019-11-25T16:40:44 *** nik-j has quit IRC
5132019-11-25T16:43:06 <BlueMatt> instagibbs_: the second
5142019-11-25T16:43:29 <BlueMatt> more is better, especially more *different types* of entropy is better.
5152019-11-25T16:43:40 <BlueMatt> just performance data is fine, but...
5162019-11-25T16:45:46 *** jarthur has joined #bitcoin-core-dev
5172019-11-25T16:47:57 *** sipa has joined #bitcoin-core-dev
5182019-11-25T16:50:12 <instagibbs_> thanks
5192019-11-25T16:52:09 *** AaronvanW has quit IRC
5202019-11-25T16:55:25 *** AaronvanW has joined #bitcoin-core-dev
5212019-11-25T16:57:29 *** justanotheruser has joined #bitcoin-core-dev
5222019-11-25T17:10:53 *** sipsorcery has quit IRC
5232019-11-25T17:23:50 *** rex4539_ has joined #bitcoin-core-dev
5242019-11-25T17:26:53 *** sipsorcery has joined #bitcoin-core-dev
5252019-11-25T17:26:57 *** rex4539 has quit IRC
5262019-11-25T17:33:45 *** b10c1 has joined #bitcoin-core-dev
5272019-11-25T17:34:00 *** b10c has quit IRC
5282019-11-25T17:34:00 *** b10c1 is now known as b10c
5292019-11-25T17:37:15 *** vasild has quit IRC
5302019-11-25T17:37:21 *** kristapsk_ has quit IRC
5312019-11-25T17:37:30 *** vasild has joined #bitcoin-core-dev
5322019-11-25T17:41:06 *** nik-j has joined #bitcoin-core-dev
5332019-11-25T17:41:42 *** jonatack_ has quit IRC
5342019-11-25T17:42:00 *** jonatack has joined #bitcoin-core-dev
5352019-11-25T17:45:41 *** nik-j has quit IRC
5362019-11-25T17:46:21 *** nijynot has joined #bitcoin-core-dev
5372019-11-25T17:52:07 *** rex4539 has joined #bitcoin-core-dev
5382019-11-25T18:00:01 *** retroj1 has quit IRC
5392019-11-25T18:02:27 *** marcoagner has joined #bitcoin-core-dev
5402019-11-25T18:04:37 *** alex911_kz has quit IRC
5412019-11-25T18:05:13 *** morcos has quit IRC
5422019-11-25T18:05:30 *** morcos has joined #bitcoin-core-dev
5432019-11-25T18:09:43 *** kristapsk has joined #bitcoin-core-dev
5442019-11-25T18:10:16 *** dviola has joined #bitcoin-core-dev
5452019-11-25T18:10:38 <dviola> hi
5462019-11-25T18:10:58 <dviola> in bitcoin-qt 0.19.0.1 "Current number of transactions" and "Memory usage" stays at "N/A"
5472019-11-25T18:11:18 <dviola> any ideas?
5482019-11-25T18:11:24 <fanquake> dviola see #17576
5492019-11-25T18:11:26 <gribble> https://github.com/bitcoin/bitcoin/issues/17576 | Mempool fields in Debug Windows show "N/A" · Issue #17576 · bitcoin/bitcoin · GitHub
5502019-11-25T18:11:33 <fanquake> This is a known issue, and will be fixed in 0.19.1
5512019-11-25T18:11:54 *** b10c1 has joined #bitcoin-core-dev
5522019-11-25T18:11:54 <dviola> fanquake: thanks
5532019-11-25T18:12:02 *** b10c has quit IRC
5542019-11-25T18:12:03 *** b10c1 is now known as b10c
5552019-11-25T18:15:22 *** justanotheruser has quit IRC
5562019-11-25T18:17:33 *** SukhE1 has joined #bitcoin-core-dev
5572019-11-25T18:19:47 <wumpus> dviola: please help testing the rc next time :) this only came to light after the RC phase
5582019-11-25T18:20:20 <dviola> wumpus: sure thing
5592019-11-25T18:23:56 *** bitcoin-git has joined #bitcoin-core-dev
5602019-11-25T18:23:56 <bitcoin-git> [bitcoin] laanwj opened pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
5612019-11-25T18:23:58 *** bitcoin-git has left #bitcoin-core-dev
5622019-11-25T18:32:44 *** astro has quit IRC
5632019-11-25T18:34:31 *** astro has joined #bitcoin-core-dev
5642019-11-25T18:40:03 *** MarcoFal- has quit IRC
5652019-11-25T18:40:16 <wumpus> provoostenator: any idea how to do a partial redirect like that in nginx?
5662019-11-25T18:40:29 *** MarcoFalk has joined #bitcoin-core-dev
5672019-11-25T18:42:45 <provoostenator> wumpus: not much better than Google...
5682019-11-25T18:43:01 <wumpus> oh I think I already have it
5692019-11-25T18:44:02 <wumpus> (you do need to clear your cache first because it remembers the old permanent redirect)
5702019-11-25T18:45:06 *** MarcoFalke has joined #bitcoin-core-dev
5712019-11-25T18:45:17 *** nijynot has quit IRC
5722019-11-25T18:46:29 <MarcoFalke> appveyor is green again, btw
5732019-11-25T18:46:38 <wumpus> great!
5742019-11-25T18:54:27 <fanquake> MarcoFalke can you add libevent 2.1.11 to the bots depends fallback
5752019-11-25T18:54:39 <MarcoFalke> sure
5762019-11-25T18:54:45 <MarcoFalke> How do you find these so quick?
5772019-11-25T18:55:56 <fanquake> Just remembered that we'd merged a newer libevent recently
5782019-11-25T19:00:45 *** nijynot has joined #bitcoin-core-dev
5792019-11-25T19:05:17 *** nijynot has quit IRC
5802019-11-25T19:06:42 *** rabidus has quit IRC
5812019-11-25T19:06:50 <provoostenator> Looks like the redirect worked!
5822019-11-25T19:07:23 <provoostenator> Try googling a class name, e.g. WalletModelTransaction
5832019-11-25T19:07:35 <wumpus> provoostenator: thanks for checking
5842019-11-25T19:08:42 *** rabidus has joined #bitcoin-core-dev
5852019-11-25T19:10:29 *** harrigan has quit IRC
5862019-11-25T19:10:56 *** harrigan has joined #bitcoin-core-dev
5872019-11-25T19:11:53 *** emilengler has joined #bitcoin-core-dev
5882019-11-25T19:13:41 *** rabidus_ has joined #bitcoin-core-dev
5892019-11-25T19:15:44 *** rabidus has quit IRC
5902019-11-25T19:17:16 *** andrewtoth_ has joined #bitcoin-core-dev
5912019-11-25T19:17:23 <fanquake> wumpus sipa think you might be about to block Dianne120 for spamming
5922019-11-25T19:17:32 *** _andrewtoth_ has quit IRC
5932019-11-25T19:18:02 *** dddd has joined #bitcoin-core-dev
5942019-11-25T19:18:03 *** nik-j has joined #bitcoin-core-dev
5952019-11-25T19:20:51 *** bitcoin-git has joined #bitcoin-core-dev
5962019-11-25T19:20:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89a1f7a250ef...12230529e330
5972019-11-25T19:20:52 <bitcoin-git> bitcoin/master 41d7db0 Wladimir J. van der Laan: doc: Change doxygen URL to doxygen.bitcoincore.org
5982019-11-25T19:20:53 <bitcoin-git> bitcoin/master 1223052 fanquake: Merge #17596: doc: Change doxygen URL to doxygen.bitcoincore.org
5992019-11-25T19:20:55 *** bitcoin-git has left #bitcoin-core-dev
6002019-11-25T19:21:11 *** bitcoin-git has joined #bitcoin-core-dev
6012019-11-25T19:21:11 <bitcoin-git> [bitcoin] fanquake merged pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
6022019-11-25T19:21:21 *** bitcoin-git has left #bitcoin-core-dev
6032019-11-25T19:23:01 *** bitcoin-git has joined #bitcoin-core-dev
6042019-11-25T19:23:01 <bitcoin-git> [bitcoin] hebasto opened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
6052019-11-25T19:23:02 *** bitcoin-git has left #bitcoin-core-dev
6062019-11-25T19:23:45 *** nik-j has quit IRC
6072019-11-25T19:29:29 <wumpus> fanquake: done
6082019-11-25T19:30:25 *** nik-j has joined #bitcoin-core-dev
6092019-11-25T19:30:36 *** andrewtoth_ has quit IRC
6102019-11-25T19:32:15 <hebasto> if AppVeyor is fixed why do I see red crosses? Timeouts or something else?
6112019-11-25T19:33:34 <wumpus> hebasto: where?
6122019-11-25T19:34:07 *** bitcoin-git has joined #bitcoin-core-dev
6132019-11-25T19:34:07 <bitcoin-git> [bitcoin] hebasto closed pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
6142019-11-25T19:34:09 *** bitcoin-git has left #bitcoin-core-dev
6152019-11-25T19:34:48 <sipsorcery> 3rd last appveyor build had a genuine compilation error which looks like it was introduced by the PR
6162019-11-25T19:35:17 <sipsorcery> 2nd last build failed on the a python test, this is a sporadic issue that needs to be tracked down
6172019-11-25T19:36:01 <hebasto> sipsorcery: I see, thank you for the fix and clarification
6182019-11-25T19:38:22 <sipsorcery> last build (backports on 0.18 branch) failed for what looks to be missing vcpkg packages
6192019-11-25T19:38:52 <fanquake> probably a bunch of stuff that needs to be backported to 0.18 for appveyor
6202019-11-25T19:42:21 *** rabidus_ has quit IRC
6212019-11-25T19:44:01 *** rh0nj has quit IRC
6222019-11-25T19:45:07 *** rh0nj has joined #bitcoin-core-dev
6232019-11-25T19:50:23 *** bitcoin-git has joined #bitcoin-core-dev
6242019-11-25T19:50:23 <bitcoin-git> [bitcoin] hebasto reopened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
6252019-11-25T19:50:25 *** bitcoin-git has left #bitcoin-core-dev
6262019-11-25T19:50:43 *** bitcoin-git has joined #bitcoin-core-dev
6272019-11-25T19:50:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17598: doc: Update release process with latest changes (master...1911-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17598
6282019-11-25T19:50:44 *** bitcoin-git has left #bitcoin-core-dev
6292019-11-25T19:54:21 *** andrewtoth_ has joined #bitcoin-core-dev
6302019-11-25T19:58:38 *** Talkless has quit IRC
6312019-11-25T20:00:18 *** bitcoin-git has joined #bitcoin-core-dev
6322019-11-25T20:00:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12230529e330...2c1c43754b7a
6332019-11-25T20:00:19 <bitcoin-git> bitcoin/master 2fa65e0 Elichai Turkel: Add ci script to install on s390x
6342019-11-25T20:00:20 <bitcoin-git> bitcoin/master da1f153 Elichai Turkel: Add s390x tests to travis
6352019-11-25T20:00:20 <bitcoin-git> bitcoin/master 2c1c437 MarcoFalke: Merge #17591: ci: Add big endian platform - s390x
6362019-11-25T20:00:22 *** bitcoin-git has left #bitcoin-core-dev
6372019-11-25T20:00:38 *** bitcoin-git has joined #bitcoin-core-dev
6382019-11-25T20:00:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17591: ci: Add big endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
6392019-11-25T20:00:39 *** bitcoin-git has left #bitcoin-core-dev
6402019-11-25T20:01:58 *** jonatack_ has joined #bitcoin-core-dev
6412019-11-25T20:05:02 *** bitcoin-git has joined #bitcoin-core-dev
6422019-11-25T20:05:02 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17599: ci: Run functional tests on s390x (master...1911-ciS390x) https://github.com/bitcoin/bitcoin/pull/17599
6432019-11-25T20:05:03 *** bitcoin-git has left #bitcoin-core-dev
6442019-11-25T20:05:08 *** jonatack has quit IRC
6452019-11-25T20:13:04 *** misterwhatever has joined #bitcoin-core-dev
6462019-11-25T20:27:10 *** promag has joined #bitcoin-core-dev
6472019-11-25T20:29:35 <fanquake> So the new hardware has already turned up a bug in the functional tests?
6482019-11-25T20:29:48 <sipa> fanquake: it's a bug in the tests, yes
6492019-11-25T20:30:45 <sipa> (python code interpreting LE data using struct unpack, marking the data as native)
6502019-11-25T20:30:51 *** bitcoin-git has joined #bitcoin-core-dev
6512019-11-25T20:30:51 <bitcoin-git> [bitcoin] hebasto opened pull request #17600: qt: Remove connection for unused accepted() signal in ReceiveRequestDialog (master...20191125-unused-connection) https://github.com/bitcoin/bitcoin/pull/17600
6522019-11-25T20:30:52 *** bitcoin-git has left #bitcoin-core-dev
6532019-11-25T20:35:38 *** promag has quit IRC
6542019-11-25T20:37:31 *** mattcruzz has joined #bitcoin-core-dev
6552019-11-25T20:37:51 *** bitcoin-git has joined #bitcoin-core-dev
6562019-11-25T20:37:51 <bitcoin-git> [bitcoin] jnewbery opened pull request #17601: Validation: Move CheckBlock() mutation guard to AcceptBlock() (master...2019-11-checkblock-in-acceptblock) https://github.com/bitcoin/bitcoin/pull/17601
6572019-11-25T20:37:52 *** bitcoin-git has left #bitcoin-core-dev
6582019-11-25T20:38:21 *** mattcruzz has left #bitcoin-core-dev
6592019-11-25T20:46:47 *** belcher has quit IRC
6602019-11-25T20:48:07 *** tripleslash has quit IRC
6612019-11-25T20:56:13 *** mattcruzz has joined #bitcoin-core-dev
6622019-11-25T20:56:58 *** bitcoin-git has joined #bitcoin-core-dev
6632019-11-25T20:56:58 <bitcoin-git> [bitcoin] dongcarl opened pull request #17602: net: Lower # of IPs learned from a DNS seed (master...2019-11-lower-nMaxIPs) https://github.com/bitcoin/bitcoin/pull/17602
6642019-11-25T20:56:59 *** bitcoin-git has left #bitcoin-core-dev
6652019-11-25T20:57:27 *** emilengler has quit IRC
6662019-11-25T20:58:09 *** mattcruzz has left #bitcoin-core-dev
6672019-11-25T21:00:01 *** SukhE1 has quit IRC
6682019-11-25T21:00:57 *** b10c has quit IRC
6692019-11-25T21:04:34 *** Yakitorifoodie has left #bitcoin-core-dev
6702019-11-25T21:11:53 *** justanotheruser has joined #bitcoin-core-dev
6712019-11-25T21:17:29 *** AIM has joined #bitcoin-core-dev
6722019-11-25T21:26:13 *** dddd has quit IRC
6732019-11-25T21:36:26 *** lightlike has joined #bitcoin-core-dev
6742019-11-25T21:37:04 *** vasild_ has joined #bitcoin-core-dev
6752019-11-25T21:40:18 *** commavir has quit IRC
6762019-11-25T21:40:48 *** vasild has quit IRC
6772019-11-25T21:47:21 *** Chris_Stewart_5 has quit IRC
6782019-11-25T21:47:44 *** commavir has joined #bitcoin-core-dev
6792019-11-25T22:08:22 *** nosss2 has joined #bitcoin-core-dev
6802019-11-25T22:11:47 *** promag has joined #bitcoin-core-dev
6812019-11-25T22:14:51 *** Guyver2 has quit IRC
6822019-11-25T22:15:43 *** diogosergio has joined #bitcoin-core-dev
6832019-11-25T22:17:05 *** promag has quit IRC
6842019-11-25T22:17:49 *** promag has joined #bitcoin-core-dev
6852019-11-25T22:22:47 *** SiAnDoG has quit IRC
6862019-11-25T22:23:13 *** SiAnDoG has joined #bitcoin-core-dev
6872019-11-25T22:31:00 *** benthecarman has joined #bitcoin-core-dev
6882019-11-25T22:33:48 *** benthecarman has joined #bitcoin-core-dev
6892019-11-25T22:36:23 *** diogosergio has quit IRC
6902019-11-25T22:36:53 *** bitcoin-git has joined #bitcoin-core-dev
6912019-11-25T22:36:53 <bitcoin-git> [bitcoin] fanquake opened pull request #17604: doc: correct ScheduleBatchPriority return value documentation (master...fix_ScheduleBatchPriority_comment) https://github.com/bitcoin/bitcoin/pull/17604
6922019-11-25T22:36:55 *** bitcoin-git has left #bitcoin-core-dev
6932019-11-25T23:04:55 *** jarthur has quit IRC
6942019-11-25T23:06:08 *** diogosergio has joined #bitcoin-core-dev
6952019-11-25T23:17:24 *** andrewtoth_ has quit IRC
6962019-11-25T23:21:16 *** mdunnio has quit IRC
6972019-11-25T23:22:32 *** jb55 has quit IRC
6982019-11-25T23:23:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6992019-11-25T23:26:35 <dviola> the git tags in the bitcoin repo and the releases at bitcoincore.org are the same thing, right?
7002019-11-25T23:27:02 *** waxwing has quit IRC
7012019-11-25T23:27:34 *** waxwing has joined #bitcoin-core-dev
7022019-11-25T23:27:43 <dviola> I'm currently using the release tarballs but I might switch to compiling from the repo, this way I can test RCs too
7032019-11-25T23:29:15 *** waxwing has quit IRC
7042019-11-25T23:29:15 *** waxwing has joined #bitcoin-core-dev
7052019-11-25T23:34:39 *** captjakk has joined #bitcoin-core-dev
7062019-11-25T23:36:04 *** SiAnDoG has quit IRC
7072019-11-25T23:37:31 *** lightlike has quit IRC
7082019-11-25T23:46:15 *** belcher has joined #bitcoin-core-dev
7092019-11-25T23:46:39 *** jb55 has joined #bitcoin-core-dev
7102019-11-25T23:48:27 *** sipsorcery has quit IRC
7112019-11-25T23:48:35 *** promag has quit IRC
7122019-11-25T23:51:06 <dviola> are rc tarballs also signed?
7132019-11-25T23:51:48 <achow101> dviola: yes, they are the same. rcs go through the same release process as the final releases so they are signed too
7142019-11-25T23:53:12 <dviola> I see, thanks
7152019-11-25T23:54:02 <dviola> I'll keep using the tarballs but I might switch to using git after a while
7162019-11-25T23:55:26 *** nik-j has quit IRC
7172019-11-25T23:56:16 *** nik-j has joined #bitcoin-core-dev
7182019-11-25T23:58:15 <luke-jr> dviola: no tarballs are signed..
7192019-11-25T23:58:30 <luke-jr> well, except by gitian in separate files
7202019-11-25T23:58:44 <luke-jr> (ie, git-made tarballs are not)
7212019-11-25T23:59:53 <dviola> luke-jr: I was talking about the verification process described here: https://bitcoincore.org/en/download/
7222019-11-25T23:59:59 <dviola> gpg --verify, etc