12019-12-12T00:00:02 *** Leo_Verto1 has quit IRC
22019-12-12T00:17:00 *** mreider has joined #bitcoin-core-dev
32019-12-12T00:19:11 *** Kiminuo has quit IRC
42019-12-12T00:27:06 *** joaojoyce has quit IRC
52019-12-12T01:05:09 *** AaronvanW has quit IRC
62019-12-12T01:30:02 *** marcoagner has quit IRC
72019-12-12T01:33:55 *** bitcoin-git has joined #bitcoin-core-dev
82019-12-12T01:33:55 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5948398b1866...3f1966ead6b2
92019-12-12T01:33:56 <bitcoin-git> bitcoin/master b6f9e35 fanquake: test: re-enable CLI test support by using EncodeDecimal in json.dumps()
102019-12-12T01:33:57 <bitcoin-git> bitcoin/master 3f1966e fanquake: Merge #17705: test: re-enable CLI test support by using EncodeDecimal in j...
112019-12-12T01:33:57 *** Deacyde has joined #bitcoin-core-dev
122019-12-12T01:34:06 *** bitcoin-git has left #bitcoin-core-dev
132019-12-12T01:34:25 *** bitcoin-git has joined #bitcoin-core-dev
142019-12-12T01:34:25 <bitcoin-git> [bitcoin] fanquake merged pull request #17705: test: re-enable CLI test support by using EncodeDecimal in json.dumps() (master...test_framework_json_dumps) https://github.com/bitcoin/bitcoin/pull/17705
152019-12-12T01:34:27 *** bitcoin-git has left #bitcoin-core-dev
162019-12-12T01:38:13 *** AaronvanW has joined #bitcoin-core-dev
172019-12-12T01:42:49 *** AaronvanW has quit IRC
182019-12-12T01:55:45 *** bitcoin-git has joined #bitcoin-core-dev
192019-12-12T01:55:45 <bitcoin-git> [bitcoin] fanquake opened pull request #17730: depends: remove Qt networking features (master...qt_no_lib_system_proxy) https://github.com/bitcoin/bitcoin/pull/17730
202019-12-12T01:55:46 *** bitcoin-git has left #bitcoin-core-dev
212019-12-12T01:56:30 <fanquake> sipsorcery: take a look at the changes in 17730. They remove the need to link against a couple dylibs on macOS. You might be able to drop similar libraries on Windows.
222019-12-12T02:10:11 *** AaronvanW has joined #bitcoin-core-dev
232019-12-12T02:12:49 *** kristapsk has quit IRC
242019-12-12T02:32:57 *** Highway61 has quit IRC
252019-12-12T02:38:07 *** bsm1175321 has quit IRC
262019-12-12T02:42:41 *** AaronvanW has quit IRC
272019-12-12T02:44:28 *** felixfoertsch23 has joined #bitcoin-core-dev
282019-12-12T02:44:53 *** felixfoertsch has quit IRC
292019-12-12T03:00:01 *** mreider has quit IRC
302019-12-12T03:09:13 *** felixfoertsch has joined #bitcoin-core-dev
312019-12-12T03:10:08 *** felixfoertsch23 has quit IRC
322019-12-12T03:17:14 *** johncylee has joined #bitcoin-core-dev
332019-12-12T03:46:41 *** tscco has joined #bitcoin-core-dev
342019-12-12T03:50:18 *** bitcoin-git has joined #bitcoin-core-dev
352019-12-12T03:50:18 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17727: WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. (master...msvc_qtupdate) https://github.com/bitcoin/bitcoin/pull/17727
362019-12-12T03:50:19 *** bitcoin-git has left #bitcoin-core-dev
372019-12-12T03:50:38 *** bitcoin-git has joined #bitcoin-core-dev
382019-12-12T03:50:38 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17727: WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. (master...msvc_qtupdate) https://github.com/bitcoin/bitcoin/pull/17727
392019-12-12T03:50:39 *** bitcoin-git has left #bitcoin-core-dev
402019-12-12T03:52:59 *** molz has joined #bitcoin-core-dev
412019-12-12T04:12:27 *** davterra has quit IRC
422019-12-12T04:18:23 *** tscco has quit IRC
432019-12-12T04:39:56 *** AaronvanW has joined #bitcoin-core-dev
442019-12-12T04:41:41 *** davterra has joined #bitcoin-core-dev
452019-12-12T05:13:38 *** AaronvanW has quit IRC
462019-12-12T06:00:02 *** johncylee has quit IRC
472019-12-12T06:05:39 *** brianhoffman_ has joined #bitcoin-core-dev
482019-12-12T06:08:01 *** brianhoffman has quit IRC
492019-12-12T06:08:01 *** brianhoffman_ is now known as brianhoffman
502019-12-12T06:13:54 *** DougieBot5000 has quit IRC
512019-12-12T06:17:23 *** csharpsteen has joined #bitcoin-core-dev
522019-12-12T06:24:17 *** baldur has quit IRC
532019-12-12T06:32:26 *** DougieBot5000 has joined #bitcoin-core-dev
542019-12-12T06:36:46 *** baldur has joined #bitcoin-core-dev
552019-12-12T07:10:29 *** AaronvanW has joined #bitcoin-core-dev
562019-12-12T07:34:51 *** SiAnDoG__ has quit IRC
572019-12-12T07:35:16 *** SiAnDoG__ has joined #bitcoin-core-dev
582019-12-12T07:42:51 *** AaronvanW has quit IRC
592019-12-12T07:59:12 *** EvaristeGalois has joined #bitcoin-core-dev
602019-12-12T08:13:46 *** brakmic has joined #bitcoin-core-dev
612019-12-12T08:30:52 *** AaronvanW has joined #bitcoin-core-dev
622019-12-12T08:33:57 *** designwi- has quit IRC
632019-12-12T08:54:44 *** Kiminuo has joined #bitcoin-core-dev
642019-12-12T08:57:41 *** designwish has joined #bitcoin-core-dev
652019-12-12T09:00:02 *** csharpsteen has quit IRC
662019-12-12T09:02:59 *** promag has joined #bitcoin-core-dev
672019-12-12T09:03:26 *** MasterdonX has quit IRC
682019-12-12T09:05:00 *** belcher has quit IRC
692019-12-12T09:05:03 <wumpus> heh importing remote desktop services doesn't really make me happy either
702019-12-12T09:07:42 *** MasterdonX has joined #bitcoin-core-dev
712019-12-12T09:10:00 *** kanzure has quit IRC
722019-12-12T09:12:19 *** kanzure has joined #bitcoin-core-dev
732019-12-12T09:12:47 *** gribble has quit IRC
742019-12-12T09:13:29 *** promag_ has joined #bitcoin-core-dev
752019-12-12T09:13:34 *** gribble has joined #bitcoin-core-dev
762019-12-12T09:14:54 *** promag_ has quit IRC
772019-12-12T09:15:07 *** promag_ has joined #bitcoin-core-dev
782019-12-12T09:17:41 <sipsorcery> wumpus: I'll check the msvc build with #17730, hopefully the Wtsapi32.lib can be removed.
792019-12-12T09:17:43 *** jwheare1 has joined #bitcoin-core-dev
802019-12-12T09:18:17 <gribble> https://github.com/bitcoin/bitcoin/issues/17730 | depends: remove Qt networking features by fanquake · Pull Request #17730 · bitcoin/bitcoin · GitHub
812019-12-12T09:18:59 *** promag has quit IRC
822019-12-12T09:19:31 *** promag has joined #bitcoin-core-dev
832019-12-12T09:20:32 *** belcher has joined #bitcoin-core-dev
842019-12-12T09:21:24 *** promag has quit IRC
852019-12-12T09:24:03 *** AaronvanW has quit IRC
862019-12-12T09:24:21 *** AaronvanW has joined #bitcoin-core-dev
872019-12-12T09:24:38 *** promag has joined #bitcoin-core-dev
882019-12-12T09:26:51 *** Guyver2 has joined #bitcoin-core-dev
892019-12-12T09:30:23 *** promag has quit IRC
902019-12-12T09:31:37 *** promag has joined #bitcoin-core-dev
912019-12-12T09:37:26 *** b10c has joined #bitcoin-core-dev
922019-12-12T09:37:27 *** vasild_ has joined #bitcoin-core-dev
932019-12-12T09:37:52 *** promag has quit IRC
942019-12-12T09:38:54 *** promag has joined #bitcoin-core-dev
952019-12-12T09:40:40 *** vasild has quit IRC
962019-12-12T09:43:30 <wumpus> thanks!
972019-12-12T09:44:15 *** promag has quit IRC
982019-12-12T09:46:12 *** promag has joined #bitcoin-core-dev
992019-12-12T09:49:51 <wumpus> I really like PEP 540, 'ignore locale settings, just make everything UTF-8 already'
1002019-12-12T09:50:27 <wumpus> everyone gets the locale wrong on UNIX platforms anyway
1012019-12-12T09:50:33 *** shaunsun_ has joined #bitcoin-core-dev
1022019-12-12T09:50:33 *** shaunsun has joined #bitcoin-core-dev
1032019-12-12T09:51:00 <wumpus> time to just standardize on UTF-8 and not look back...
1042019-12-12T09:56:40 *** hofuv has quit IRC
1052019-12-12T09:57:44 *** bitcoin-git has joined #bitcoin-core-dev
1062019-12-12T09:57:45 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3f1966ead6b2...3914e877c476
1072019-12-12T09:57:46 <bitcoin-git> bitcoin/master 2bcf1fc Pieter Wuille: Pass a maximum output length to DecodeBase58 and DecodeBase58Check
1082019-12-12T09:57:47 <bitcoin-git> bitcoin/master 5909bcd Pieter Wuille: Add bounds checks in key_io before DecodeBase58Check
1092019-12-12T09:57:47 <bitcoin-git> bitcoin/master 3914e87 Wladimir J. van der Laan: Merge #17511: Add bounds checks before base58 decoding
1102019-12-12T09:57:49 *** bitcoin-git has left #bitcoin-core-dev
1112019-12-12T09:58:05 *** bitcoin-git has joined #bitcoin-core-dev
1122019-12-12T09:58:05 <bitcoin-git> [bitcoin] laanwj merged pull request #17511: Add bounds checks before base58 decoding (master...201911_boundedbase58) https://github.com/bitcoin/bitcoin/pull/17511
1132019-12-12T09:58:06 *** bitcoin-git has left #bitcoin-core-dev
1142019-12-12T09:59:34 *** promag__ has joined #bitcoin-core-dev
1152019-12-12T09:59:41 *** promag_ has quit IRC
1162019-12-12T10:08:27 *** molly has joined #bitcoin-core-dev
1172019-12-12T10:12:02 *** molz_ has joined #bitcoin-core-dev
1182019-12-12T10:12:11 *** molz has quit IRC
1192019-12-12T10:15:34 *** molly has quit IRC
1202019-12-12T10:18:13 *** jonatack has quit IRC
1212019-12-12T10:41:09 *** b10c has quit IRC
1222019-12-12T10:41:22 *** b10c has joined #bitcoin-core-dev
1232019-12-12T10:43:37 *** Kiminuo has quit IRC
1242019-12-12T10:43:44 *** vasild_ is now known as vasild
1252019-12-12T10:54:52 *** marcoagner has joined #bitcoin-core-dev
1262019-12-12T11:03:42 *** Rafaela42Renner has joined #bitcoin-core-dev
1272019-12-12T11:08:37 *** Rafaela42Renner has quit IRC
1282019-12-12T11:17:53 *** bitcoin-git has joined #bitcoin-core-dev
1292019-12-12T11:17:54 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3914e877c476...0192bd065230
1302019-12-12T11:17:55 <bitcoin-git> bitcoin/master fd9d6ee Andrew Chow: Add GetEncryptionKey() and HasEncryptionKeys() to WalletStorage
1312019-12-12T11:17:56 <bitcoin-git> bitcoin/master e576b13 Andrew Chow: Replace LegacyScriptPubKeyMan::vMasterKey with GetDecryptionKey()
1322019-12-12T11:17:56 <bitcoin-git> bitcoin/master 97c0374 Andrew Chow: Move Unlock implementation to LegacyScriptPubKeyMan
1332019-12-12T11:17:58 *** bitcoin-git has left #bitcoin-core-dev
1342019-12-12T11:18:18 *** bitcoin-git has joined #bitcoin-core-dev
1352019-12-12T11:18:18 <bitcoin-git> [bitcoin] laanwj merged pull request #17369: Refactor: Move encryption code between KeyMan and Wallet (master...wallet-box-pr-4) https://github.com/bitcoin/bitcoin/pull/17369
1362019-12-12T11:18:19 *** bitcoin-git has left #bitcoin-core-dev
1372019-12-12T11:26:04 *** promag has quit IRC
1382019-12-12T11:31:56 *** shaunsun_ has quit IRC
1392019-12-12T11:32:03 *** shaunsun has quit IRC
1402019-12-12T11:39:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1412019-12-12T11:54:52 *** jonatack has joined #bitcoin-core-dev
1422019-12-12T12:00:01 *** jwheare1 has quit IRC
1432019-12-12T12:02:18 *** bitcoin-git has joined #bitcoin-core-dev
1442019-12-12T12:02:18 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0192bd065230...75a2a4f35744
1452019-12-12T12:02:19 <bitcoin-git> bitcoin/master fabd5b4 MarcoFalke: ci: Use python 3.7 on Windows Github Actions
1462019-12-12T12:02:19 <bitcoin-git> bitcoin/master 75a2a4f fanquake: Merge #17726: ci: Use python 3.7 on Windows Github Actions
1472019-12-12T12:02:21 *** bitcoin-git has left #bitcoin-core-dev
1482019-12-12T12:02:39 *** bitcoin-git has joined #bitcoin-core-dev
1492019-12-12T12:02:40 <bitcoin-git> [bitcoin] fanquake merged pull request #17726: ci: Use python 3.7 on Windows Github Actions (master...1912-ciGitHubWindows) https://github.com/bitcoin/bitcoin/pull/17726
1502019-12-12T12:02:40 *** bitcoin-git has left #bitcoin-core-dev
1512019-12-12T12:06:45 *** bitcoin-git has joined #bitcoin-core-dev
1522019-12-12T12:06:45 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75a2a4f35744...8a01450b642a
1532019-12-12T12:06:46 <bitcoin-git> bitcoin/master fab2f35 MarcoFalke: doc: Update release process with latest changes
1542019-12-12T12:06:46 <bitcoin-git> bitcoin/master 8a01450 fanquake: Merge #17598: doc: Update release process with latest changes
1552019-12-12T12:06:56 *** bitcoin-git has left #bitcoin-core-dev
1562019-12-12T12:07:10 *** bitcoin-git has joined #bitcoin-core-dev
1572019-12-12T12:07:10 <bitcoin-git> [bitcoin] fanquake merged pull request #17598: doc: Update release process with latest changes (master...1911-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17598
1582019-12-12T12:07:12 *** bitcoin-git has left #bitcoin-core-dev
1592019-12-12T12:09:54 *** timothy has joined #bitcoin-core-dev
1602019-12-12T12:20:40 *** promag has joined #bitcoin-core-dev
1612019-12-12T12:24:56 *** bitcoin-git has joined #bitcoin-core-dev
1622019-12-12T12:24:56 <bitcoin-git> [bitcoin] brakmic opened pull request #17732: test: check for valgrind presence and set appropriate exit flags (master...valgrind-detection) https://github.com/bitcoin/bitcoin/pull/17732
1632019-12-12T12:24:59 *** bitcoin-git has left #bitcoin-core-dev
1642019-12-12T12:45:57 *** Chris_Stewart_5 has quit IRC
1652019-12-12T12:46:54 *** beaups1 has joined #bitcoin-core-dev
1662019-12-12T12:52:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1672019-12-12T12:55:15 *** promag has quit IRC
1682019-12-12T12:56:05 *** Highway61 has joined #bitcoin-core-dev
1692019-12-12T12:56:12 *** promag__ has quit IRC
1702019-12-12T13:00:33 *** Highway61 has quit IRC
1712019-12-12T13:03:31 *** Goosie has joined #bitcoin-core-dev
1722019-12-12T13:05:00 *** bitcoin-git has joined #bitcoin-core-dev
1732019-12-12T13:05:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8a01450b642a...cf2f43987696
1742019-12-12T13:05:00 <bitcoin-git> bitcoin/master 034561f Harris: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice
1752019-12-12T13:05:01 <bitcoin-git> bitcoin/master cf2f439 fanquake: Merge #17687: cli: fix Fatal LevelDB error when specifying -blockfilterind...
1762019-12-12T13:05:02 *** bitcoin-git has left #bitcoin-core-dev
1772019-12-12T13:05:20 *** bitcoin-git has joined #bitcoin-core-dev
1782019-12-12T13:05:20 <bitcoin-git> [bitcoin] fanquake merged pull request #17687: cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (master...blockfilter-index-error) https://github.com/bitcoin/bitcoin/pull/17687
1792019-12-12T13:05:30 *** bitcoin-git has left #bitcoin-core-dev
1802019-12-12T13:07:05 *** Highway61 has joined #bitcoin-core-dev
1812019-12-12T13:12:57 *** Deacyde has quit IRC
1822019-12-12T13:21:17 *** molz_ has quit IRC
1832019-12-12T13:25:58 *** mol has joined #bitcoin-core-dev
1842019-12-12T13:26:42 *** Goosie has quit IRC
1852019-12-12T13:32:50 *** mol has quit IRC
1862019-12-12T13:36:22 *** mol has joined #bitcoin-core-dev
1872019-12-12T13:39:59 *** promag has joined #bitcoin-core-dev
1882019-12-12T13:48:37 *** jonatack has quit IRC
1892019-12-12T13:53:08 *** lowentropy has quit IRC
1902019-12-12T13:54:23 *** lowentropy has joined #bitcoin-core-dev
1912019-12-12T14:05:33 *** Kiminuo has joined #bitcoin-core-dev
1922019-12-12T14:09:19 *** andytoshi has joined #bitcoin-core-dev
1932019-12-12T14:09:19 *** andytoshi has quit IRC
1942019-12-12T14:09:19 *** andytoshi has joined #bitcoin-core-dev
1952019-12-12T14:10:57 *** spinza has quit IRC
1962019-12-12T14:10:58 *** roconnor has joined #bitcoin-core-dev
1972019-12-12T14:19:08 *** belcher has quit IRC
1982019-12-12T14:26:07 *** abacus has quit IRC
1992019-12-12T14:26:23 *** abacus has joined #bitcoin-core-dev
2002019-12-12T14:35:27 *** abacus has quit IRC
2012019-12-12T14:37:02 *** abacus has joined #bitcoin-core-dev
2022019-12-12T14:38:17 *** Kiminuo has quit IRC
2032019-12-12T14:58:06 *** jonatack has joined #bitcoin-core-dev
2042019-12-12T15:00:01 *** beaups1 has quit IRC
2052019-12-12T15:00:06 *** belcher has joined #bitcoin-core-dev
2062019-12-12T15:04:08 *** shaunsun has joined #bitcoin-core-dev
2072019-12-12T15:04:10 *** shaunsun_ has joined #bitcoin-core-dev
2082019-12-12T15:08:17 *** shaunsun_ has quit IRC
2092019-12-12T15:09:02 *** shaunsun has quit IRC
2102019-12-12T15:12:35 *** bitcoin-git has joined #bitcoin-core-dev
2112019-12-12T15:12:35 <bitcoin-git> [bitcoin] brakmic opened pull request #17735: build: fix typo (master...github-workflow) https://github.com/bitcoin/bitcoin/pull/17735
2122019-12-12T15:12:46 *** bitcoin-git has left #bitcoin-core-dev
2132019-12-12T15:16:15 *** setpill has joined #bitcoin-core-dev
2142019-12-12T15:17:32 *** Dimlock has joined #bitcoin-core-dev
2152019-12-12T15:18:22 *** promag has quit IRC
2162019-12-12T15:29:28 *** rex4539 has joined #bitcoin-core-dev
2172019-12-12T15:33:52 *** sdaftuar has quit IRC
2182019-12-12T15:33:52 *** jnewbery has quit IRC
2192019-12-12T15:39:10 *** jnewbery has joined #bitcoin-core-dev
2202019-12-12T15:39:43 *** sdaftuar has joined #bitcoin-core-dev
2212019-12-12T15:46:52 *** promag has joined #bitcoin-core-dev
2222019-12-12T15:48:11 <wumpus> this almost has to be the OOM killer right ? #17733
2232019-12-12T15:48:13 <gribble> https://github.com/bitcoin/bitcoin/issues/17733 | bitcoin-qt does not start, terminates with "Killed" and exit code 137 · Issue #17733 · bitcoin/bitcoin · GitHub
2242019-12-12T15:50:33 *** mdunnio has joined #bitcoin-core-dev
2252019-12-12T15:53:26 *** sdaftuar has quit IRC
2262019-12-12T15:53:26 *** jnewbery has quit IRC
2272019-12-12T15:53:48 *** jnewbery has joined #bitcoin-core-dev
2282019-12-12T15:53:48 *** jonatack has quit IRC
2292019-12-12T15:54:04 *** sdaftuar_ has joined #bitcoin-core-dev
2302019-12-12T15:54:14 *** davterra has quit IRC
2312019-12-12T15:54:14 *** jnewbery has quit IRC
2322019-12-12T15:54:16 *** sdaftuar_ has quit IRC
2332019-12-12T15:54:51 *** sdaftuar_ has joined #bitcoin-core-dev
2342019-12-12T15:54:58 *** sdaftuar_ has quit IRC
2352019-12-12T15:55:27 *** sdaftuar_ has joined #bitcoin-core-dev
2362019-12-12T15:56:20 *** bitcoin-git has joined #bitcoin-core-dev
2372019-12-12T15:56:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf2f43987696...54e11a39e14d
2382019-12-12T15:56:21 <bitcoin-git> bitcoin/master 5096baf Harris: build: fix typo
2392019-12-12T15:56:21 <bitcoin-git> bitcoin/master 54e11a3 MarcoFalke: Merge #17735: ci: fix typo
2402019-12-12T15:56:23 *** bitcoin-git has left #bitcoin-core-dev
2412019-12-12T15:56:40 *** bitcoin-git has joined #bitcoin-core-dev
2422019-12-12T15:56:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17735: ci: fix typo (master...github-workflow) https://github.com/bitcoin/bitcoin/pull/17735
2432019-12-12T15:56:41 *** bitcoin-git has left #bitcoin-core-dev
2442019-12-12T15:56:42 <wumpus> oh noo you broke #17727
2452019-12-12T15:56:44 <gribble> https://github.com/bitcoin/bitcoin/issues/17727 | WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. by sipsorcery · Pull Request #17727 · bitcoin/bitcoin · GitHub
2462019-12-12T15:57:42 <fanquake> yea I'm not sure why 17735 was merged
2472019-12-12T15:57:57 <fanquake> Could have at least asked for a proper commit message as well
2482019-12-12T15:58:47 *** jnewbery has joined #bitcoin-core-dev
2492019-12-12T15:59:41 <fanquake> As for 17727, if we need to "make appveyor green", can we pull out the part of that PR that will actually make that happen. Rather than rushing through a qt bump that pulls in a bunch of new dependencies.
2502019-12-12T16:00:18 <wumpus> the problem is that the old qt vcpkg is not built with the new version of msvc
2512019-12-12T16:00:31 <wumpus> so it forces a qt bump indirectly...
2522019-12-12T16:01:14 <fanquake> ugh
2532019-12-12T16:01:24 <wumpus> but yeah we'd never let travis determine our dependency versions for the autotools build system
2542019-12-12T16:02:02 <wumpus> we could give up on appveyor, I think sipsorcery prefers moving to a github action as well
2552019-12-12T16:02:56 <wumpus> getting red crosses for every commit is getting kind of annoying so I understand the desire to make it green
2562019-12-12T16:03:13 <wumpus> also *other* changes that break MSVC will now sneak through
2572019-12-12T16:03:23 <fanquake> Sure. It's very annoying. The other concern is that we tell people to use the precompiled qt binaries to test things on windows, while at the same time are supposedly going to merge changes to the windows (MSVC) build system without even testing/checking them.
2582019-12-12T16:03:49 <wumpus> in some ways a faulty CI is worse than no CI at all
2592019-12-12T16:04:26 <wumpus> well there's a difference in maturity there: the precompiled binaries are the only supported ones, the MSVC build system is extra and experimental
2602019-12-12T16:05:05 <wumpus> it doesn't have nearly the amount of testing the gitian-built executables have
2612019-12-12T16:05:52 <fanquake> I'd be happy if just dropped support for all the "other" ways to build on windows aside from the Ubuntu cross-compiling
2622019-12-12T16:06:35 <wumpus> I think the only reason to support MSVC is to give windows developers an easier way to build and contribute
2632019-12-12T16:06:35 <wumpus> not to actually se MSVC-built bitcoin in production
2642019-12-12T16:06:54 <wumpus> also testing with another compiler has turned up some bugs in the past
2652019-12-12T16:07:16 <wumpus> which is a sensible reason to do a CI run with it
2662019-12-12T16:07:39 <wumpus> (though, this worked just as well without qt)
2672019-12-12T16:08:36 *** andrewtoth has joined #bitcoin-core-dev
2682019-12-12T16:09:30 <fanquake> Yes, the introduction of the precompiled qt is where potential issues are.
2692019-12-12T16:09:55 <fanquake> One being that if no one is going to bother to check the precompiled binaries, while at the same time, windows build system changes are pushed through with no review just to make the CI green. I'm imaging a worst case scenario where it turns out the new qt is malicious, and coupled with something like linking against the Remote Desktop API, bad things may happen.
2702019-12-12T16:10:41 <fanquake> Obviously we do call out that the qt binaries should never be used with funds, testing only etc etc
2712019-12-12T16:13:52 <wumpus> at some point you start to wonder how much time is spent making linters, parallel build systems, CI, etc happy versus solving actual end user issues :)
2722019-12-12T16:14:04 <wumpus> yes, good point w/ pre-built qt
2732019-12-12T16:16:04 <fanquake> > at some point you start to wonder how much time +1
2742019-12-12T16:18:03 *** EvaristeGalois has quit IRC
2752019-12-12T16:18:53 <sipsorcery> in the recent past it's been a LOT of time to sort out msvc CI issues (on top of the time PR authors spend looking into CI failures)
2762019-12-12T16:18:54 *** spinza has joined #bitcoin-core-dev
2772019-12-12T16:19:10 *** EvaristeGalois has joined #bitcoin-core-dev
2782019-12-12T16:20:38 <sipsorcery> the Qt version bump is a separate issue. Concerns about switching to a new version, even for experimental builds, are fair.
2792019-12-12T16:22:04 <wumpus> so we might want to temporarily (or permanently, to replace with github actions) disable appveyor instead
2802019-12-12T16:22:36 <wumpus> instead of doing the qt upgrade just because appveyor forces us to
2812019-12-12T16:23:25 <sipsorcery> well appveyor didn't force a Qt upgrade, it forced a Qt recompile, and I was seeking to kill two birds with one stone.
2822019-12-12T16:24:02 *** EvaristeGalois has quit IRC
2832019-12-12T16:24:12 <sipsorcery> github actions is faster and for that reason it'd get my vote to replace appveyor.
2842019-12-12T16:25:14 *** EvaristeGalois has joined #bitcoin-core-dev
2852019-12-12T16:27:04 <sipsorcery> the advantage travis has had over appveyor, in terms of stability, is the dependencies being locked down
2862019-12-12T16:28:28 <sipsorcery> if the installed vcpkg libraries were built and cached externally to the job (same as Qt currently is) it would make them equivalent.
2872019-12-12T16:28:52 <ryanofsky> dependencies not being locked down could also be an advantage if we want to know about upcoming breakages
2882019-12-12T16:29:22 <ryanofsky> wouldn't it be easy to just ignore all appveyor errors in pull requests if appveyor on master is also broken?
2892019-12-12T16:30:57 <sipsorcery> true but to date it's been about a 50% (guess) hit rate on dependency changes being a genuine issue as compared to the package being tinkered with
2902019-12-12T16:31:00 *** ddustin has joined #bitcoin-core-dev
2912019-12-12T16:32:10 <sipsorcery> e.g. the libevent package build was changed to disable threads by default which broke the appveyor build.
2922019-12-12T16:33:13 <ryanofsky> sipsorcery, was the libevent problem something appveyor specific that wouldn't affect someone who was trying to use msvc?
2932019-12-12T16:33:40 <sipsorcery> no it wasn't appveyor specific
2942019-12-12T16:34:06 <sipsorcery> anyone following the instructions and using vcpkg to install libevent would have had the same issue
2952019-12-12T16:34:58 <sipsorcery> appveyor updating the build image to use a new version of Visual Studio is the same thing.
2962019-12-12T16:35:36 <sipsorcery> anyone who currently attempts to build bitcoin core with Visual Studio 2019 v16.4 will get a compilation error.
2972019-12-12T16:36:04 *** ddustin has quit IRC
2982019-12-12T16:36:28 <ryanofsky> yeah so all of that stuff seems useful to know about and fix as long as there is an msvc build. and i think it's ok if PR authors see red if their PR breaks the MSVC build
2992019-12-12T16:36:33 *** jonatack has joined #bitcoin-core-dev
3002019-12-12T16:36:44 <ryanofsky> but i don't think PR authors should see red if master is also red
3012019-12-12T16:37:09 <ryanofsky> because that is much more likely to be wasting their time
3022019-12-12T16:37:57 *** Krellan has quit IRC
3032019-12-12T16:38:31 *** Krellan has joined #bitcoin-core-dev
3042019-12-12T16:42:39 <sipsorcery> yeah it'd be nice if the build icon could show yellow or orange if master is broken
3052019-12-12T16:43:05 <sipsorcery> i doubt there's a hook in GitHub to control that though
3062019-12-12T16:43:48 <ryanofsky> it's another thing we could ask for an as a workaround (though i'd prefer grey to really be able to ignore it)
3072019-12-12T16:44:01 *** setpill has quit IRC
3082019-12-12T16:44:03 *** Krellan has quit IRC
3092019-12-12T16:44:36 <ryanofsky> as a workaround, maybe if appveyor is failing on a pull request, have it retry the build on master and just show green if both are broken
3102019-12-12T16:46:14 *** bitcoin-git has joined #bitcoin-core-dev
3112019-12-12T16:46:14 <bitcoin-git> [bitcoin] sipsorcery closed pull request #17727: WIP: Update msvc build to ignore warning and bump Qt version to 5.12.6. (master...msvc_qtupdate) https://github.com/bitcoin/bitcoin/pull/17727
3122019-12-12T16:46:15 *** bitcoin-git has left #bitcoin-core-dev
3132019-12-12T16:49:47 *** EvaristeGalois has quit IRC
3142019-12-12T16:55:36 *** Talkless has joined #bitcoin-core-dev
3152019-12-12T16:56:02 *** EvaristeGalois has joined #bitcoin-core-dev
3162019-12-12T16:57:29 *** AaronvanW has quit IRC
3172019-12-12T17:00:27 *** EvaristeGalois has quit IRC
3182019-12-12T17:01:40 *** EvaristeGalois has joined #bitcoin-core-dev
3192019-12-12T17:07:17 *** promag has quit IRC
3202019-12-12T17:07:31 *** AaronvanW has joined #bitcoin-core-dev
3212019-12-12T17:15:07 *** AaronvanW has quit IRC
3222019-12-12T17:16:02 <sipsorcery> moneyball: #proposedmeetingtopic appveyor CI future
3232019-12-12T17:23:20 *** ExtraCrispy has joined #bitcoin-core-dev
3242019-12-12T17:24:30 *** EvaristeGalois has quit IRC
3252019-12-12T17:24:54 *** EvaristeGalois has joined #bitcoin-core-dev
3262019-12-12T17:44:46 <wumpus> the thing is, CI should be reliable, yes dependenies not being locked down shows about upcoming breakages but that's not something you want to be confronted with while focusining on other things
3272019-12-12T17:45:58 <wumpus> it's intrusive and that's annoying, we should set our own priorities based on what is merged and not have it break randomly "oh now you need to stop what you're doing and fix another CI isuse"
3282019-12-12T17:46:08 <luke-jr> can we set some CI instances to only warn?
3292019-12-12T17:46:57 <luke-jr> I guess ultimately, issues with new deps is really a master/branches-only thing, not PRs
3302019-12-12T17:46:58 <wumpus> I don't particularly want all new PRs to fail because there happens to have been a MSVC version that adds a new warning (which wouldn't even be fatal to normal builders)
3312019-12-12T17:47:13 <luke-jr> maybe it's a bad fit for CI
3322019-12-12T17:47:33 <luke-jr> or can CI instances be only for master/stable branches maybe?
3332019-12-12T17:47:34 <wumpus> failing on master it's annoying because it causes *all* PRs to fail, irrespective of that they do
3342019-12-12T17:47:52 <luke-jr> not if it doesn't run for PRs?
3352019-12-12T17:48:05 *** AaronvanW has joined #bitcoin-core-dev
3362019-12-12T17:48:15 <wumpus> if it doesn't run for PRs it's pointlessbecause you don't know when it legitimately breaks the build
3372019-12-12T17:49:00 <luke-jr> ?
3382019-12-12T17:49:24 <luke-jr> I mean have the current CI instances with locked down versions, and new master/stable-only instances that use the latest..
3392019-12-12T17:49:48 <wumpus> the idea of doing a MSVC run is that you can be sure that a PR will work with MSVC, you don't only want to discover that after merge
3402019-12-12T17:50:18 *** AaronvanW has quit IRC
3412019-12-12T17:50:35 *** AaronvanW has joined #bitcoin-core-dev
3422019-12-12T17:50:49 <luke-jr> I mean, we either run PRs with latest versions or we don't..
3432019-12-12T17:51:01 <wumpus> sure, people are free to run master on whatever platform / library / compiler combinations they want
3442019-12-12T17:51:16 <luke-jr> I suppose if we manually check for and fail on warnings, we could exclude ones seen on master
3452019-12-12T17:56:12 <sipa> there is also something to be said about warnings/errors from msvc forcing us to maintain better code
3462019-12-12T17:56:45 <sipa> but if it's a pain to maintain the CI for it to get a good signal, that's probably not worth the effort
3472019-12-12T17:56:47 <wumpus> I don't think anyone is arguing not doing a MSVC build, but it should be stable dependency-wise like the travis one
3482019-12-12T17:56:48 *** lio17 has quit IRC
3492019-12-12T17:57:30 *** lio17 has joined #bitcoin-core-dev
3502019-12-12T17:58:30 <wumpus> all in all we've spent way too much time with CI broken lately, and only a few of those things were due to actual problems introduced in PRs
3512019-12-12T17:58:37 <luke-jr> wumpus: so why can't we do that, and add a master-only unstable build so we get alerted to new issues?
3522019-12-12T17:58:48 <jeremyrubin> I don't have anything technical to add; but I find it really annoying because it takes up a lot of mental space to get the "build broken" emails just for it to be another dumb msvc issue
3532019-12-12T17:58:57 <wumpus> jeremyrubin: same
3542019-12-12T18:00:02 *** Dimlock has quit IRC
3552019-12-12T18:02:09 *** Krellan has joined #bitcoin-core-dev
3562019-12-12T18:02:16 *** Highway62 has joined #bitcoin-core-dev
3572019-12-12T18:03:44 *** Highway61 has quit IRC
3582019-12-12T18:03:44 *** Highway62 is now known as Highway61
3592019-12-12T18:06:46 <jonatack> agree. when we see 2-3 maintainers and several contributors spending a considerable amount of their time dealing with ci issues i'm thinking of the opportunity cost (and motivation cost)
3602019-12-12T18:07:50 <jonatack> make that 4 maintainers actually, just remembered bitcoinbuilds.org
3612019-12-12T18:07:57 *** Krellan has quit IRC
3622019-12-12T18:08:55 <luke-jr> I think there's probably unanimity on that :P
3632019-12-12T18:17:07 *** promag has joined #bitcoin-core-dev
3642019-12-12T18:17:34 *** mackr has joined #bitcoin-core-dev
3652019-12-12T18:20:49 *** Highway61 has quit IRC
3662019-12-12T18:25:12 *** andrewtoth has quit IRC
3672019-12-12T18:30:03 <wumpus> heh
3682019-12-12T18:31:08 <ryanofsky> i think the compromise for appveyor i was suggesting (show red on a PR if the PR appveyor fails and master passes, green if both pass or both fails) has the best of all worlds
3692019-12-12T18:31:43 <ryanofsky> it gives the windows maintainer time to fix problems if anything breaks, while not bothering anybody else, and still showing red if a PR would break the windows build
3702019-12-12T18:31:45 *** jtimon has joined #bitcoin-core-dev
3712019-12-12T18:32:44 *** Highway61 has joined #bitcoin-core-dev
3722019-12-12T18:33:24 *** mdunnio has quit IRC
3732019-12-12T18:33:38 <wumpus> yes, I guess "it's not getting worse" as a measure would work
3742019-12-12T18:33:42 <jeremyrubin> One thing that's annoying about that in terms of diagnosing errors is that given how checkered failures are, there ends up being an assumption of being rebased on master
3752019-12-12T18:34:16 <wumpus> though it could still happen, if the dependency drift still happens, that they change between the run on master (whichwas still succesful) and the PR
3762019-12-12T18:36:16 <wumpus> that assumption is already there, AFAIK the CI always runs on the PR merged into master
3772019-12-12T18:36:39 <ryanofsky> wumpus, i think that could be addressed by writing the appveyor script as: (git checkout pr && make check) || (git checkout master && ! make check)
3782019-12-12T18:37:19 <wumpus> ryanofsky: yes, that would work (though mind, appveyor is already slower than travis)
3792019-12-12T18:37:34 *** mdunnio has joined #bitcoin-core-dev
3802019-12-12T18:38:03 <wumpus> that's why some want to switch to github actions
3812019-12-12T18:39:18 <wumpus> (while others, in the past, have expressed to not want to use github actions, for ex. because it is even more vendor lock-in to github)
3822019-12-12T18:39:54 <wumpus> but for just the MSVC build it'd not be that bad, I think
3832019-12-12T18:47:09 <jtimon> re-review-beg https://github.com/bitcoin/bitcoin/pull/17037
3842019-12-12T18:50:10 *** EvaristeGalois has quit IRC
3852019-12-12T18:52:11 *** emilengler has joined #bitcoin-core-dev
3862019-12-12T18:52:50 *** bitcoin-git has joined #bitcoin-core-dev
3872019-12-12T18:52:50 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17736: Update msvc build for Visual Studio 2019 v16.4 (master...msvc_fix_vs2019) https://github.com/bitcoin/bitcoin/pull/17736
3882019-12-12T18:52:51 *** bitcoin-git has left #bitcoin-core-dev
3892019-12-12T19:00:40 *** Krellan has joined #bitcoin-core-dev
3902019-12-12T19:01:20 <wumpus> #startmeeting
3912019-12-12T19:01:20 <lightningbot> Meeting started Thu Dec 12 19:01:20 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3922019-12-12T19:01:20 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3932019-12-12T19:01:25 <emilengler> hi
3942019-12-12T19:01:27 <moneyball> hi
3952019-12-12T19:01:28 <amiti> hi
3962019-12-12T19:01:28 <sipa> hi
3972019-12-12T19:01:31 <sipsorcery> hi
3982019-12-12T19:01:38 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo
3992019-12-12T19:01:39 <wumpus> marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack
4002019-12-12T19:01:49 <fanquake> hi
4012019-12-12T19:01:49 <jeremyrubin> hi
4022019-12-12T19:01:51 <jonatack> hi
4032019-12-12T19:02:07 *** mdunnio has quit IRC
4042019-12-12T19:02:24 <fjahr> hi
4052019-12-12T19:02:24 *** mdunnio has joined #bitcoin-core-dev
4062019-12-12T19:02:33 <wumpus> one proposed topic for this week in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : appveyor CI future
4072019-12-12T19:02:51 <fanquake> cc sipsorcery
4082019-12-12T19:02:59 <achow101> hi
4092019-12-12T19:03:14 <sipsorcery> my suggestion is to switch from appveyor to github actions (which is Azure CI under the hood) purely for speed
4102019-12-12T19:03:42 <emilengler> I personally think we should use Cirrus CI only as it supports Windows, Linux, macOS and also FreeBSD
4112019-12-12T19:03:44 <wumpus> sorry, that was not the start of the topic
4122019-12-12T19:04:07 <wumpus> this is still the "propose your topics" phase of the meeting, then we'll start with high priority for review
4132019-12-12T19:04:13 <gwillen> I am hoping to get some feedback this week on #17717
4142019-12-12T19:04:14 <gribble> https://github.com/bitcoin/bitcoin/issues/17717 | Proposed PSBT sign/broadcast flow · Issue #17717 · bitcoin/bitcoin · GitHub
4152019-12-12T19:04:16 <kanzure> HI
4162019-12-12T19:04:20 <emilengler> oh sorry
4172019-12-12T19:04:21 <sipsorcery> oops sorry
4182019-12-12T19:04:45 <wumpus> gwillen: ok, let's addd that as topic then
4192019-12-12T19:04:53 <wumpus> #topic High priority for review
4202019-12-12T19:05:02 <jeremyrubin> #proposedmeetingtopic finish up #12763
4212019-12-12T19:05:05 <gribble> https://github.com/bitcoin/bitcoin/issues/12763 | Add RPC Whitelist Feature from #12248 by JeremyRubin · Pull Request #12763 · bitcoin/bitcoin · GitHub
4222019-12-12T19:05:07 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 8 blockers, 7 chasing concept ACK
4232019-12-12T19:05:13 <jeremyrubin> oh sorry *not* high priority
4242019-12-12T19:05:28 *** EvaristeGalois has joined #bitcoin-core-dev
4252019-12-12T19:06:05 <wumpus> anything to add/remove or that is ready for merge?
4262019-12-12T19:06:13 <achow101> #17537 for hi prio
4272019-12-12T19:06:15 <gribble> https://github.com/bitcoin/bitcoin/issues/17537 | wallet: Cleanup and move opportunistic and superfluous TopUp()s by achow101 · Pull Request #17537 · bitcoin/bitcoin · GitHub
4282019-12-12T19:06:46 <nehan> hi
4292019-12-12T19:07:06 <wumpus> achow101: for blockers I guess?
4302019-12-12T19:07:10 <achow101> yes
4312019-12-12T19:07:22 <wumpus> ok, added
4322019-12-12T19:08:14 *** jonatack has quit IRC
4332019-12-12T19:08:17 <wumpus> #topic appveyor CI future (sipsorcery)
4342019-12-12T19:08:29 <emilengler> Like I said, I personally think we should use Cirrus CI only as it supports Windows, Linux, macOS and also FreeBSD
4352019-12-12T19:08:30 <wumpus> sipsorcery | my suggestion is to switch from appveyor to github actions (which is Azure CI under the hood) purely for speed
4362019-12-12T19:08:53 <sipsorcery> second suggestion is to cache the vcpkg dependencies in a .zip file to avoid failures unrelated to PR's.
4372019-12-12T19:09:09 <luke-jr> emilengler: ppc64?
4382019-12-12T19:10:00 <emilengler> luke-jr: I'm not sure about that but we keep using travis for this purpose only
4392019-12-12T19:10:06 <wumpus> I don't think MarcoFalke is here
4402019-12-12T19:10:06 <emilengler> could keep*
4412019-12-12T19:10:43 <wumpus> is anyone against moving to github actions for just the MSVC build?
4422019-12-12T19:10:50 <luke-jr> emilengler: what about distros?
4432019-12-12T19:10:58 <wumpus> (there is no question of moving *all*CI to github actions, to be clear)
4442019-12-12T19:10:59 *** promag has quit IRC
4452019-12-12T19:11:13 <jeremyrubin> wumpus: given that github is a microsoft product seems reasonable :p
4462019-12-12T19:11:27 <wumpus> jeremyrubin: heh!
4472019-12-12T19:11:29 *** EvaristeGalois has quit IRC
4482019-12-12T19:11:36 <fanquake> As long as that involves removing all Appveyor usage.
4492019-12-12T19:11:58 <emilengler> luke-jr: I'm not sure about distros
4502019-12-12T19:12:17 <wumpus> fanquake: yes, it would
4512019-12-12T19:12:22 <emilengler> But anyway, I believe that we should use Cirrus CI in the long term. Maybe only for FreeBSD?
4522019-12-12T19:12:31 <emilengler> But that's anotehr topic
4532019-12-12T19:12:38 *** jonatack has joined #bitcoin-core-dev
4542019-12-12T19:12:38 <wumpus> fanquake: this would be about replacing appveyor
4552019-12-12T19:13:02 *** mol has quit IRC
4562019-12-12T19:13:32 <fanquake> wumpus great. If it's faster, and isn't going to be broken seemingly every thrid day for reasons outside our control.
4572019-12-12T19:13:45 <wumpus> I can't comment on that
4582019-12-12T19:13:53 <fanquake> Maybe the vcpkg maintainers will stop randomly slicing up their packages.
4592019-12-12T19:14:15 <MarcoFalke> I got the appveyor timeout back to 90 minutes
4602019-12-12T19:14:22 <MarcoFalke> Anything else needs to be fixed?
4612019-12-12T19:14:33 *** Chris_Stewart_5 has quit IRC
4622019-12-12T19:14:36 <sipa> but is the issue with appveyor itself, or the fact that vcpkg changes out from under us all the time?
4632019-12-12T19:14:56 *** EvaristeGalois has joined #bitcoin-core-dev
4642019-12-12T19:14:57 <jeremyrubin> My understanding was that it's vcpkg
4652019-12-12T19:15:03 <wumpus> both, appveyor is slow and has a low timeout, and the packages switch under us all the time
4662019-12-12T19:15:08 <jeremyrubin> But that actions will make it less annoying for non windows maintainers
4672019-12-12T19:15:08 <fanquake> There's a good summary of some of the issues in #17736
4682019-12-12T19:15:09 <gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery · Pull Request #17736 · bitcoin/bitcoin · GitHub
4692019-12-12T19:15:14 <sipa> okay, so there are two independent issues to be fixed
4702019-12-12T19:15:37 <fanquake> 3 if you include the compiler issues.
4712019-12-12T19:15:42 <wumpus> yes, I'm not sure in how far they're correlated
4722019-12-12T19:16:16 <ryanofsky> well my earlier suggestion for dealing with vcpkg issues will not work if appveyor is too slow
4732019-12-12T19:16:28 <sipsorcery> at a guesstimate on appveyor failures: 5% genuinely relate to PR's, 30% vcpkg, 25% python functional tests, 5% appveyor image, 30% appveyor timeout, 5% other.
4742019-12-12T19:16:56 <fanquake> a literal roulette wheel
4752019-12-12T19:17:23 <sipsorcery> suspect GitHub, Cirrus or Circle could all be the same excepting the timeouts.
4762019-12-12T19:18:17 <sipsorcery> assuming similar reliability, my vote would go to whichever one is fastest
4772019-12-12T19:18:46 <wumpus> yes
4782019-12-12T19:19:06 <sipsorcery> GitHub is substantially faster than appveyor. I haven't tested any other but would be happy to do so if it would help?
4792019-12-12T19:19:33 <luke-jr> speed seems likely to be dependent on how many projects are using them
4802019-12-12T19:19:39 <luke-jr> ie, if we switch, it will get slow :P
4812019-12-12T19:20:07 <wumpus> fair enough, our test suite is pretty heavy!
4822019-12-12T19:20:21 <wumpus> sipsorcery: let's just try github next imo
4832019-12-12T19:20:32 <wumpus> sipsorcery: no one was strongly against trying them
4842019-12-12T19:20:33 <MarcoFalke> What about #17736 ?
4852019-12-12T19:20:35 <gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery · Pull Request #17736 · bitcoin/bitcoin · GitHub
4862019-12-12T19:21:12 <wumpus> #17736 would be necessary no matter the CI I think
4872019-12-12T19:21:13 <gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery · Pull Request #17736 · bitcoin/bitcoin · GitHub
4882019-12-12T19:21:19 <sipsorcery> if appveyor is being canned 17736 is not required (at least until GitHub upgrade).
4892019-12-12T19:21:25 <wumpus> oh
4902019-12-12T19:21:56 <MarcoFalke> Has anyone tested the GitHub CI and found any issues?
4912019-12-12T19:22:00 <MarcoFalke> I merged it a few days ago
4922019-12-12T19:22:46 <fanquake> I didn't realise that Github seems to automatically turn the CI on for any repos that have the config file? Had to turn it off for my own fork.
4932019-12-12T19:22:58 <fanquake> Didn't realise until a build had failed and it emailed me.
4942019-12-12T19:23:03 <MarcoFalke> Huh
4952019-12-12T19:23:11 <MarcoFalke> It was turned off for bitcoin/bitcoin
4962019-12-12T19:23:12 <sipa> fanquake: maybe you're part of a weird opt in program?
4972019-12-12T19:23:17 <MarcoFalke> ^
4982019-12-12T19:23:57 <fanquake> Yea I'm not talking about bitcoin/bitcoin. Which we had tried to turn "Actions" off for. This was one my fanquake/bitcoin fork.
4992019-12-12T19:24:03 <fanquake> sipa could be
5002019-12-12T19:24:33 <wumpus> someone, not me at least turned 'actions' back on for bitcoin/bitcoin (which is okay if we're going to use it)
5012019-12-12T19:24:49 *** bitcoin-git has joined #bitcoin-core-dev
5022019-12-12T19:24:49 <bitcoin-git> [bitcoin] jamesob opened pull request #17737: Add ChainstateManager, remove BlockManager global (master...2019-12-au.chainman) https://github.com/bitcoin/bitcoin/pull/17737
5032019-12-12T19:24:49 <fanquake> wumpus Yea I was wondering how that happened
5042019-12-12T19:24:50 *** bitcoin-git has left #bitcoin-core-dev
5052019-12-12T19:25:14 <wumpus> in any case, let'stest it and talk about it next meeting or so
5062019-12-12T19:25:26 <MarcoFalke> Ok, so unless there are objections: Merge #17736 as short term fix, and then (next week maybe) switch to GitHub Actions CI?
5072019-12-12T19:25:28 <gribble> https://github.com/bitcoin/bitcoin/issues/17736 | Update msvc build for Visual Studio 2019 v16.4 by sipsorcery · Pull Request #17736 · bitcoin/bitcoin · GitHub
5082019-12-12T19:25:41 <sipsorcery> +1
5092019-12-12T19:25:49 <fanquake> +1
5102019-12-12T19:25:49 <wumpus> ack
5112019-12-12T19:25:52 <emilengler> +1
5122019-12-12T19:25:54 <wumpus> #topic Proposed PSBT sign/broadcast flow (gwillen)
5132019-12-12T19:26:11 <wumpus> #17717
5142019-12-12T19:26:12 <gribble> https://github.com/bitcoin/bitcoin/issues/17717 | Proposed PSBT sign/broadcast flow · Issue #17717 · bitcoin/bitcoin · GitHub
5152019-12-12T19:26:32 <sipa> yay, PSBT guis
5162019-12-12T19:27:11 <gwillen> this is building on top of Sjors' #17509 which is not merged yet
5172019-12-12T19:27:13 <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
5182019-12-12T19:27:33 <gwillen> my general sense is, once we can load PSBTs, the next step is "what are the operations we support on them"
5192019-12-12T19:27:48 <gwillen> so I think introducing a simple dialog to analyze them, sign them, broadcast them, and save them is a good next step
5202019-12-12T19:28:04 <gwillen> (this is simpler than the dialog from my old branch, for those of you who saw that, but it will reuse a lot of the parts)
5212019-12-12T19:28:14 <emilengler> ack
5222019-12-12T19:28:24 <sipa> i agree with the observation that an explicit update step is probably unnecessary
5232019-12-12T19:28:49 <gwillen> yeah my approach has always been to automatically update the PSBT eagerly when loading it, and that seems to produce good results
5242019-12-12T19:29:12 <achow101> seems reasonable
5252019-12-12T19:29:27 <gwillen> anyway I'm trying to make this a small and uncontroversial step, so feedback welcomed on the issue, there will be a PR soon, thanks!
5262019-12-12T19:29:29 <sipa> the only reason why you'd want that to be explicit is because of privacy concerns (you may not want to reveal bip32 paths you know about keys used), but the sentiment in #17264 seems to be that that needs to be solved differently anyway
5272019-12-12T19:29:33 <gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors · Pull Request #17264 · bitcoin/bitcoin · GitHub
5282019-12-12T19:29:46 <gwillen> sipa: hmm *nod*, will go read the notes on that
5292019-12-12T19:29:53 <instagibbs> yeah making PSBT private is not super well defined to begin with, you need additional roles
5302019-12-12T19:31:00 *** phwalkr has joined #bitcoin-core-dev
5312019-12-12T19:31:31 <instagibbs> especially as more special-case fields are entered into it
5322019-12-12T19:31:31 <luke-jr> "update"?
5332019-12-12T19:31:45 <instagibbs> luke-jr, filling fields like hd derivation path, etc
5342019-12-12T19:31:53 <luke-jr> not signing, though, right?
5352019-12-12T19:31:55 <gwillen> luke-jr: it's possible to have a PSBT that doesn't have things like P2SH redeemscripts, witnessscripts, etc. that are required for signing
5362019-12-12T19:32:05 <gwillen> I would never have the UI sign automatically, no
5372019-12-12T19:32:10 <achow101> luke-jr: correct. update is done before signing
5382019-12-12T19:32:12 *** brakmic has quit IRC
5392019-12-12T19:32:12 <sipa> luke-jr: BIP 174 updating is filling in UTXOs/prevtxs, bip32 paths, scripts used
5402019-12-12T19:32:12 <gwillen> thanks for noting that clarification
5412019-12-12T19:32:28 <gwillen> signing is always a big red button that's explicit
5422019-12-12T19:32:31 <luke-jr> hmm
5432019-12-12T19:32:37 <instagibbs> updating is done to "guide" signing, especially for dumb signers
5442019-12-12T19:32:49 <luke-jr> exposing redeemscripts is arguably partially a signature?
5452019-12-12T19:33:10 <gwillen> well the design of PSBT in Core is such that the wallet creating the tx will already include them if it knows them
5462019-12-12T19:33:12 <sipa> luke-jr: it doesn't involve private keys
5472019-12-12T19:33:21 <gwillen> the "update" step only ever occurs separately in unusual cases I think
5482019-12-12T19:33:28 <luke-jr> sipa: I'm thinking the script itself is part of the private key
5492019-12-12T19:33:29 <jb55> oh that's probably why I could never get rawtx to psbt conversion to work, I probably needed to call utxoupdatepsbt?
5502019-12-12T19:33:43 <instagibbs> that conversion is sketchy :)
5512019-12-12T19:33:44 <sipa> luke-jr: it should not be considered that way
5522019-12-12T19:33:56 *** jonatack has quit IRC
5532019-12-12T19:33:57 <sipa> luke-jr: as security should not ever depend on keeping scripts private
5542019-12-12T19:34:26 <luke-jr> hmm
5552019-12-12T19:34:27 *** jonatack has joined #bitcoin-core-dev
5562019-12-12T19:34:29 <sipa> (it may matter for privacy to keep them secret, but that's a much more complicated issue to solve if desired)
5572019-12-12T19:34:45 <gwillen> given that PSBT is pretty dependent on the current workflow, I think the workflow is maybe outside the scope of my specific change
5582019-12-12T19:34:46 <achow101> if you want privacy of scripts and derivations paths, psbt ain't it
5592019-12-12T19:34:54 <gwillen> but might be worth having a discussion about it at some point
5602019-12-12T19:34:55 <luke-jr> I guess the scripts are strictly less a concern than derivation paths
5612019-12-12T19:35:41 <jeremyrubin> sipa: it's sometimes possible to compress a HTLC in a taproot branch I think
5622019-12-12T19:36:08 *** mdunnio has quit IRC
5632019-12-12T19:36:28 <achow101> jeremyrubin: taproot will have it's own set of fields that hopefully better preserve privacy
5642019-12-12T19:36:38 <jb55> should the ui give a privacy warning when copying psbts to clipboard/saving when there's derivation paths included?
5652019-12-12T19:36:41 <instagibbs> you'll still need additional roles/flows imo
5662019-12-12T19:36:56 <sipa> jb55: imho, no - it's generally not actionable
5672019-12-12T19:36:58 <instagibbs> better to me to actually define common flows, and design for those, rather than just guessing
5682019-12-12T19:37:12 <sipa> jb55: you have the choice between private and broken, and non-private and functional
5692019-12-12T19:37:12 *** mdunnio has joined #bitcoin-core-dev
5702019-12-12T19:37:28 <gwillen> I think in general PSBTs are also never intended to be published, they are intended to be shared only with required signers
5712019-12-12T19:37:32 <instagibbs> hww<->host<->curious co-signer, things like that
5722019-12-12T19:37:38 <gwillen> I suspect this really mutes a lot of the privacy issues that could otherwise exist
5732019-12-12T19:37:43 <instagibbs> but there's no RPC flow for this
5742019-12-12T19:37:44 <gwillen> for most people the required signers will only ever be themselves
5752019-12-12T19:37:51 <achow101> gwillen: the main privacy concern is for coinjoins
5762019-12-12T19:37:52 <gwillen> or people they already trust with their privacy
5772019-12-12T19:37:55 <gwillen> *nod*
5782019-12-12T19:38:09 <gwillen> I have not thought a lot about the coinjoin case
5792019-12-12T19:38:27 *** bitcoin-git has joined #bitcoin-core-dev
5802019-12-12T19:38:27 <bitcoin-git> [bitcoin] fanquake opened pull request #17738: build: remove linking librt for backwards compatibility (master...remove_librt_back_compat) https://github.com/bitcoin/bitcoin/pull/17738
5812019-12-12T19:38:28 *** bitcoin-git has left #bitcoin-core-dev
5822019-12-12T19:38:33 <instagibbs> depends on what co-signers require to sign, there can be additional proof data etc
5832019-12-12T19:38:44 <achow101> in coinjoins you don't know or trust the other participants. deriv path and scripts could provide an easy way for a coinjoin participant to deanonymize other coinjoin participatns
5842019-12-12T19:38:48 <sipa> yeah, the (interesting) privacy issues appear when you're combinging multi-party signing for some inputs, and distinct signers for other inputs
5852019-12-12T19:39:18 <sipa> there could be some best effort where we remove bip32 derivation info from finalized inputs
5862019-12-12T19:39:36 <gwillen> we may already do that
5872019-12-12T19:39:45 <achow101> pretty sure we do
5882019-12-12T19:39:46 <gwillen> I know that we strip partial signatures from finalized inputs once we combine them
5892019-12-12T19:39:58 *** andrewtoth has joined #bitcoin-core-dev
5902019-12-12T19:40:01 <achow101> I think the spec for finalizer says drop everything but final sig/witness and utxo
5912019-12-12T19:40:02 <sipa> oh, ok
5922019-12-12T19:40:12 <sipa> achow101: i vaguely remember that indeed
5932019-12-12T19:40:37 <instagibbs> oh that's not too bad then for most uses already
5942019-12-12T19:41:03 <achow101> I think the workflow we should be going for is really the hardware wallet/cold storage one
5952019-12-12T19:41:17 <jb55> I still wish there was some hrp that I could glance at the various states a psbt is in, but I guess that ship has sailed
5962019-12-12T19:41:20 <instagibbs> well that one can be very naive
5972019-12-12T19:42:41 <gwillen> jb55: can you expand "hrp"
5982019-12-12T19:42:55 <achow101> human readable aprt
5992019-12-12T19:42:57 <achow101> *part
6002019-12-12T19:43:01 <gwillen> there is the analyzepsbt rpc which produces what you want, I think
6012019-12-12T19:43:04 <sipa> the stage depends on the input...
6022019-12-12T19:43:14 *** phwalkr has quit IRC
6032019-12-12T19:43:16 <gwillen> and my goal is for my UI to also expose as much of that as makes sense
6042019-12-12T19:43:37 <jb55> yeah perhaps thats just difficulties arising from copying and pasting psbts and the cli, but ui could help a lot here
6052019-12-12T19:43:42 <gwillen> I don't think it would make sense to put an hrp in the PSBT itself, you could attack people by having it be secretly out of sync with the rest
6062019-12-12T19:43:48 <instagibbs> jb55, different signers may expect different input, so it's kind of hard to say. e.g., one may expect xpub for multisig detection, other may not
6072019-12-12T19:46:31 <jeremyrubin> Anything else on this topic?
6082019-12-12T19:46:40 <gwillen> I think further comments on my proposal can go on the issue
6092019-12-12T19:46:48 <wumpus> #topic RPC Whitelist Feature (jeremyrubin)
6102019-12-12T19:47:02 <jeremyrubin> I think this is more or less ready to merge
6112019-12-12T19:47:22 <emilengler> The test (#17536) is also rebased on the squashed commit
6122019-12-12T19:47:23 <jeremyrubin> It adds the ability to whitelist certain RPCs for credentials for those unfamiliar
6132019-12-12T19:47:24 <gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler · Pull Request #17536 · bitcoin/bitcoin · GitHub
6142019-12-12T19:48:26 <instagibbs> could you snipe the test? :) if that's ok emilengler
6152019-12-12T19:48:53 <emilengler> instagibbs: What do you mean?
6162019-12-12T19:48:57 <jeremyrubin> snipe meaning put onto the same branch? I could, I just didn't want to unfairly steal emilengler's merge stats ;)
6172019-12-12T19:49:13 <emilengler> jeremyrubin: It's fine
6182019-12-12T19:49:14 <instagibbs> emilengler, can jeremy cherry-pick into his branch? I don't like features without tests :)
6192019-12-12T19:49:21 <jeremyrubin> big credit to emilengler for putting in the effort to get the tests over the line
6202019-12-12T19:49:22 <emilengler> sure
6212019-12-12T19:49:34 <wumpus> just make sure to keep the author data the same
6222019-12-12T19:49:46 <instagibbs> +1
6232019-12-12T19:49:46 <emilengler> Would be nice if you colud put me into the longer commit description
6242019-12-12T19:50:20 <jeremyrubin> will do
6252019-12-12T19:50:28 <instagibbs> will review
6262019-12-12T19:50:30 <emilengler> thanks :)
6272019-12-12T19:50:34 <luke-jr> do it without an @ or he'll get spammed by altcoins
6282019-12-12T19:50:39 <emilengler> Will close the PR then
6292019-12-12T19:50:49 <luke-jr> (usually just maintaining the Author field is enough?)
6302019-12-12T19:51:24 <jonatack> will review
6312019-12-12T19:52:39 <instagibbs> 8 minutes, any other topics?
6322019-12-12T19:52:41 <wumpus> thanks everyone, I don't think we have any more topics so that concludes the meeting
6332019-12-12T19:52:44 <instagibbs> kk
6342019-12-12T19:52:49 <wumpus> #endmeeting
6352019-12-12T19:52:49 <lightningbot> Meeting ended Thu Dec 12 19:52:49 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6362019-12-12T19:52:49 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.html
6372019-12-12T19:52:49 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.txt
6382019-12-12T19:52:49 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-12-12-19.01.log.html
6392019-12-12T19:52:52 <emilengler> Thanks everyone
6402019-12-12T19:55:20 *** timothy has quit IRC
6412019-12-12T19:55:28 <instagibbs> MarcoFalke, is there hidden meanings in your signed emojis on PRs :)
6422019-12-12T19:56:16 <MarcoFalke> instagibbs: ð§
6432019-12-12T19:59:18 *** mdunnio has quit IRC
6442019-12-12T20:00:14 *** mdunnio has joined #bitcoin-core-dev
6452019-12-12T20:02:21 *** Talkless has quit IRC
6462019-12-12T20:04:21 *** Krellan has quit IRC
6472019-12-12T20:18:39 *** b10c has quit IRC
6482019-12-12T20:22:46 *** jpe_ has joined #bitcoin-core-dev
6492019-12-12T20:29:15 *** bitcoin-git has joined #bitcoin-core-dev
6502019-12-12T20:29:15 <bitcoin-git> [bitcoin] instagibbs closed pull request #17712: sendmany/bumpfee: Avoid address reuse and partial spends as per walle⦠(master...avoid_reuse_sm_bf) https://github.com/bitcoin/bitcoin/pull/17712
6512019-12-12T20:29:25 *** bitcoin-git has left #bitcoin-core-dev
6522019-12-12T20:29:29 *** jpe_ has quit IRC
6532019-12-12T20:47:59 *** promag has joined #bitcoin-core-dev
6542019-12-12T20:50:31 *** emilengler has quit IRC
6552019-12-12T20:52:36 *** promag has quit IRC
6562019-12-12T20:54:41 *** Aaronvan_ has joined #bitcoin-core-dev
6572019-12-12T20:57:09 *** bitcoin-git has joined #bitcoin-core-dev
6582019-12-12T20:57:10 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54e11a39e14d...c5e318aea6ad
6592019-12-12T20:57:10 <bitcoin-git> bitcoin/master 75d9317 Aaron Clauson: Update msvc build for Visual Studio 2019 v16.4
6602019-12-12T20:57:11 <bitcoin-git> bitcoin/master c5e318a MarcoFalke: Merge #17736: Update msvc build for Visual Studio 2019 v16.4
6612019-12-12T20:57:13 *** bitcoin-git has left #bitcoin-core-dev
6622019-12-12T20:57:29 *** bitcoin-git has joined #bitcoin-core-dev
6632019-12-12T20:57:29 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17736: Update msvc build for Visual Studio 2019 v16.4 (master...msvc_fix_vs2019) https://github.com/bitcoin/bitcoin/pull/17736
6642019-12-12T20:57:30 *** bitcoin-git has left #bitcoin-core-dev
6652019-12-12T20:58:03 *** AaronvanW has quit IRC
6662019-12-12T20:58:15 *** Aaronvan_ is now known as AaronvanW
6672019-12-12T21:00:02 *** mackr has quit IRC
6682019-12-12T21:00:11 *** mdunnio has quit IRC
6692019-12-12T21:00:58 *** mdunnio has joined #bitcoin-core-dev
6702019-12-12T21:11:39 *** promag has joined #bitcoin-core-dev
6712019-12-12T21:15:37 *** promag has quit IRC
6722019-12-12T21:17:00 *** SLot has joined #bitcoin-core-dev
6732019-12-12T21:23:31 *** brakmic has joined #bitcoin-core-dev
6742019-12-12T21:24:01 *** Deacyde has joined #bitcoin-core-dev
6752019-12-12T21:33:26 *** Krellan has joined #bitcoin-core-dev
6762019-12-12T21:40:44 *** vasild has quit IRC
6772019-12-12T21:42:15 *** vasild has joined #bitcoin-core-dev
6782019-12-12T21:47:51 *** brakmic_ has joined #bitcoin-core-dev
6792019-12-12T21:50:37 *** brakmic has quit IRC
6802019-12-12T22:06:07 *** Guyver2 has quit IRC
6812019-12-12T22:06:33 *** Krellan has quit IRC
6822019-12-12T22:14:32 *** rex4539 has quit IRC
6832019-12-12T22:18:51 *** Agent69 has joined #bitcoin-core-dev
6842019-12-12T22:22:27 *** Agent69 has left #bitcoin-core-dev
6852019-12-12T22:22:36 *** EvaristeGalois has quit IRC
6862019-12-12T22:31:13 *** EvaristeGalois has joined #bitcoin-core-dev
6872019-12-12T22:38:03 *** b10c has joined #bitcoin-core-dev
6882019-12-12T22:43:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6892019-12-12T22:46:36 *** rex4539 has joined #bitcoin-core-dev
6902019-12-12T22:53:08 *** rex4539 has quit IRC
6912019-12-12T22:57:03 *** Kiminuo has joined #bitcoin-core-dev
6922019-12-12T23:03:18 *** morcos has quit IRC
6932019-12-12T23:07:56 *** brakmic_ has quit IRC
6942019-12-12T23:08:16 *** Kiminuo has quit IRC
6952019-12-12T23:08:16 *** owowo has quit IRC
6962019-12-12T23:08:38 *** morcos has joined #bitcoin-core-dev
6972019-12-12T23:08:39 *** owowo has joined #bitcoin-core-dev
6982019-12-12T23:09:14 *** raj_149 has quit IRC
6992019-12-12T23:09:17 *** achow101_ has joined #bitcoin-core-dev
7002019-12-12T23:09:39 *** MasterdonX has quit IRC
7012019-12-12T23:10:04 *** achow101 has quit IRC
7022019-12-12T23:10:07 *** SLot has quit IRC
7032019-12-12T23:10:07 *** exhoplex_ has quit IRC
7042019-12-12T23:10:20 *** murrayn has quit IRC
7052019-12-12T23:10:28 *** raj_149 has joined #bitcoin-core-dev
7062019-12-12T23:10:31 *** MasterdonX has joined #bitcoin-core-dev
7072019-12-12T23:10:36 *** exhoplex_ has joined #bitcoin-core-dev
7082019-12-12T23:10:36 *** murray has joined #bitcoin-core-dev
7092019-12-12T23:11:00 *** murray is now known as Guest47752
7102019-12-12T23:13:10 *** darkbot-rc4 has joined #bitcoin-core-dev
7112019-12-12T23:19:39 *** shaunsun_ has joined #bitcoin-core-dev
7122019-12-12T23:19:39 *** shaunsun has joined #bitcoin-core-dev
7132019-12-12T23:21:33 *** shaunsun__ has joined #bitcoin-core-dev
7142019-12-12T23:24:03 *** shaunsun_ has quit IRC
7152019-12-12T23:24:03 *** shaunsun has quit IRC
7162019-12-12T23:24:39 *** shaunsun has joined #bitcoin-core-dev
7172019-12-12T23:27:14 *** mdunnio has quit IRC
7182019-12-12T23:32:39 *** rex4539 has joined #bitcoin-core-dev
7192019-12-12T23:37:20 *** Chris_Stewart_5 has quit IRC
7202019-12-12T23:46:34 *** rex4539 has quit IRC
7212019-12-12T23:49:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
7222019-12-12T23:56:50 *** b10c has quit IRC