12020-01-07T00:00:02  *** V3ct0r has quit IRC
  22020-01-07T00:08:17  *** Zenton has quit IRC
  32020-01-07T00:09:31  *** turbo_choo has quit IRC
  42020-01-07T00:10:27  *** marcoagner has quit IRC
  52020-01-07T00:11:31  *** turbo_choo has joined #bitcoin-core-dev
  62020-01-07T00:14:00  *** promag has quit IRC
  72020-01-07T00:14:18  *** promag has joined #bitcoin-core-dev
  82020-01-07T00:17:02  *** izaki1 has joined #bitcoin-core-dev
  92020-01-07T00:20:18  *** promag has quit IRC
 102020-01-07T00:24:08  *** promag has joined #bitcoin-core-dev
 112020-01-07T00:27:19  *** promag has quit IRC
 122020-01-07T00:28:35  *** promag has joined #bitcoin-core-dev
 132020-01-07T00:33:32  *** belcher has quit IRC
 142020-01-07T00:33:34  *** promag has quit IRC
 152020-01-07T00:34:42  *** promag has joined #bitcoin-core-dev
 162020-01-07T00:35:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 172020-01-07T00:39:29  *** promag has quit IRC
 182020-01-07T00:39:36  *** turbo_choo has quit IRC
 192020-01-07T00:45:48  *** promag has joined #bitcoin-core-dev
 202020-01-07T00:47:28  *** turbo_choo has joined #bitcoin-core-dev
 212020-01-07T00:51:41  *** apex944 has quit IRC
 222020-01-07T00:56:56  *** promag has quit IRC
 232020-01-07T00:57:00  *** turbo_choo has quit IRC
 242020-01-07T00:59:32  *** turbo_choo has joined #bitcoin-core-dev
 252020-01-07T01:08:07  *** turbo_choo has quit IRC
 262020-01-07T01:08:25  *** promag has joined #bitcoin-core-dev
 272020-01-07T01:20:01  *** turbo_choo has joined #bitcoin-core-dev
 282020-01-07T01:38:56  *** turbo_choo has quit IRC
 292020-01-07T01:43:27  *** turbo_choo has joined #bitcoin-core-dev
 302020-01-07T01:57:32  *** morcos has quit IRC
 312020-01-07T01:58:19  *** morcos has joined #bitcoin-core-dev
 322020-01-07T02:03:10  *** apex944 has joined #bitcoin-core-dev
 332020-01-07T02:18:24  *** Chris_Stewart_5 has quit IRC
 342020-01-07T02:55:17  *** Highway61 has quit IRC
 352020-01-07T02:56:01  *** apex944 has quit IRC
 362020-01-07T03:00:01  *** izaki1 has quit IRC
 372020-01-07T03:00:48  *** abrissbi1ne has joined #bitcoin-core-dev
 382020-01-07T03:04:16  *** abrissbirne has quit IRC
 392020-01-07T03:07:23  *** turbo_choo has quit IRC
 402020-01-07T03:10:14  *** justanotheruser has quit IRC
 412020-01-07T03:14:01  *** turbo_choo has joined #bitcoin-core-dev
 422020-01-07T03:17:04  *** apex944 has joined #bitcoin-core-dev
 432020-01-07T03:17:05  *** jackgassett has joined #bitcoin-core-dev
 442020-01-07T03:18:42  *** captjakk has joined #bitcoin-core-dev
 452020-01-07T03:26:56  *** justanotheruser has joined #bitcoin-core-dev
 462020-01-07T03:36:53  *** felixfoertsch has joined #bitcoin-core-dev
 472020-01-07T03:38:36  *** felixfoertsch23 has quit IRC
 482020-01-07T03:39:32  *** cryptoIndio has joined #bitcoin-core-dev
 492020-01-07T03:42:02  *** apex944 has quit IRC
 502020-01-07T03:47:58  *** apex944 has joined #bitcoin-core-dev
 512020-01-07T04:00:40  *** bitcoin-git has joined #bitcoin-core-dev
 522020-01-07T04:00:40  <bitcoin-git> [bitcoin] achow101 opened pull request #17886: Restore English translation option (master...fix-en-translate) https://github.com/bitcoin/bitcoin/pull/17886
 532020-01-07T04:00:41  *** bitcoin-git has left #bitcoin-core-dev
 542020-01-07T04:07:14  *** apex944 has quit IRC
 552020-01-07T04:07:27  *** sipa has quit IRC
 562020-01-07T04:07:44  *** sipa has joined #bitcoin-core-dev
 572020-01-07T04:16:42  *** Zenton has joined #bitcoin-core-dev
 582020-01-07T04:20:00  *** justanotheruser has quit IRC
 592020-01-07T04:30:53  *** Relis has quit IRC
 602020-01-07T04:39:32  *** justanotheruser has joined #bitcoin-core-dev
 612020-01-07T04:39:49  *** turbo_choo has quit IRC
 622020-01-07T04:41:56  *** turbo_choo has joined #bitcoin-core-dev
 632020-01-07T04:55:35  *** mol has joined #bitcoin-core-dev
 642020-01-07T04:57:06  *** Relis has joined #bitcoin-core-dev
 652020-01-07T05:13:21  *** Relis has quit IRC
 662020-01-07T05:31:52  *** Victor_sueca has joined #bitcoin-core-dev
 672020-01-07T05:34:41  *** Victorsueca has quit IRC
 682020-01-07T05:41:17  *** captjakk has quit IRC
 692020-01-07T06:00:02  *** jackgassett has quit IRC
 702020-01-07T06:10:33  *** mol has quit IRC
 712020-01-07T06:17:20  *** Y_Ichiro has joined #bitcoin-core-dev
 722020-01-07T06:24:46  *** Y_Ichiro has quit IRC
 732020-01-07T06:29:14  *** mryandao has quit IRC
 742020-01-07T06:29:35  *** mryandao has joined #bitcoin-core-dev
 752020-01-07T06:50:58  *** Darki1 has joined #bitcoin-core-dev
 762020-01-07T07:02:56  *** tryphe_ has joined #bitcoin-core-dev
 772020-01-07T07:04:48  *** tryphe_ has quit IRC
 782020-01-07T07:04:49  *** SiAnDoG__ has quit IRC
 792020-01-07T07:04:49  *** DeanWeen has quit IRC
 802020-01-07T07:04:50  *** kristapsk has quit IRC
 812020-01-07T07:05:04  *** kristapsk has joined #bitcoin-core-dev
 822020-01-07T07:05:05  *** DeanWeen has joined #bitcoin-core-dev
 832020-01-07T07:05:09  *** SiAnDoG__ has joined #bitcoin-core-dev
 842020-01-07T07:05:13  *** tryphe_ has joined #bitcoin-core-dev
 852020-01-07T07:06:33  *** tryphe has quit IRC
 862020-01-07T07:28:45  *** ghost43 has quit IRC
 872020-01-07T07:29:01  *** ghost43 has joined #bitcoin-core-dev
 882020-01-07T07:58:06  *** TheHoliestRoger has quit IRC
 892020-01-07T07:58:54  *** TheHoliestRoger has joined #bitcoin-core-dev
 902020-01-07T08:07:07  *** RandolfR has joined #bitcoin-core-dev
 912020-01-07T08:07:41  *** RandolfR is now known as Randolf
 922020-01-07T08:08:43  *** Randolf has quit IRC
 932020-01-07T08:09:03  *** Randolf has joined #bitcoin-core-dev
 942020-01-07T08:28:05  *** jungly has joined #bitcoin-core-dev
 952020-01-07T08:42:55  *** Kiminuo has joined #bitcoin-core-dev
 962020-01-07T08:56:03  *** SiAnDoG__ has quit IRC
 972020-01-07T08:57:00  *** paultroon has joined #bitcoin-core-dev
 982020-01-07T08:59:19  *** marcoagner has joined #bitcoin-core-dev
 992020-01-07T09:00:02  *** Darki1 has quit IRC
1002020-01-07T09:01:28  *** paultroon has quit IRC
1012020-01-07T09:08:07  *** alec has quit IRC
1022020-01-07T09:09:50  *** aqquadro has joined #bitcoin-core-dev
1032020-01-07T09:21:29  *** alec has joined #bitcoin-core-dev
1042020-01-07T09:33:29  *** belcher has joined #bitcoin-core-dev
1052020-01-07T09:37:44  *** vasild_ has joined #bitcoin-core-dev
1062020-01-07T09:40:23  *** vasild has quit IRC
1072020-01-07T09:47:48  *** Mark_Cockrell has joined #bitcoin-core-dev
1082020-01-07T09:47:50  *** kljasdfvv has quit IRC
1092020-01-07T09:51:57  *** vasild_ has quit IRC
1102020-01-07T10:01:48  *** promag has joined #bitcoin-core-dev
1112020-01-07T10:01:58  *** daniel_ has quit IRC
1122020-01-07T10:05:07  *** vasild has joined #bitcoin-core-dev
1132020-01-07T10:09:33  *** vasild has quit IRC
1142020-01-07T10:10:10  *** vasild has joined #bitcoin-core-dev
1152020-01-07T10:18:44  *** jonatack has quit IRC
1162020-01-07T11:05:12  *** Guyver2 has joined #bitcoin-core-dev
1172020-01-07T11:08:27  *** kljasdfvv has joined #bitcoin-core-dev
1182020-01-07T11:09:12  *** Guest83 has joined #bitcoin-core-dev
1192020-01-07T11:10:32  *** alec has quit IRC
1202020-01-07T11:13:07  *** Guyver2_ has joined #bitcoin-core-dev
1212020-01-07T11:16:51  *** Guyver2 has quit IRC
1222020-01-07T11:19:09  <promag> ariard could be member in gh
1232020-01-07T11:26:54  *** michaelfolkson has joined #bitcoin-core-dev
1242020-01-07T11:34:32  *** michaelfolkson has quit IRC
1252020-01-07T11:36:17  *** Dean_Guss has joined #bitcoin-core-dev
1262020-01-07T11:36:34  *** Guest83 has quit IRC
1272020-01-07T11:36:43  *** DeanWeen has quit IRC
1282020-01-07T11:38:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1292020-01-07T11:40:00  *** timothy has joined #bitcoin-core-dev
1302020-01-07T11:46:47  *** Relis has joined #bitcoin-core-dev
1312020-01-07T11:51:29  *** timothy has quit IRC
1322020-01-07T11:51:46  *** Relis has quit IRC
1332020-01-07T11:52:37  *** Highway61 has joined #bitcoin-core-dev
1342020-01-07T11:53:52  *** timothy has joined #bitcoin-core-dev
1352020-01-07T11:54:08  *** michaelfolkson has joined #bitcoin-core-dev
1362020-01-07T12:00:01  *** Mark_Cockrell has quit IRC
1372020-01-07T12:02:38  *** michaelfolkson has quit IRC
1382020-01-07T12:16:14  *** promag has quit IRC
1392020-01-07T12:17:11  *** aqquadro has quit IRC
1402020-01-07T12:17:26  *** Morgon1 has joined #bitcoin-core-dev
1412020-01-07T12:21:51  *** michaelfolkson has joined #bitcoin-core-dev
1422020-01-07T12:22:51  *** Relis has joined #bitcoin-core-dev
1432020-01-07T12:29:25  *** joncoe has joined #bitcoin-core-dev
1442020-01-07T12:39:32  *** jonatack has joined #bitcoin-core-dev
1452020-01-07T12:44:07  *** Chris_Stewart_5 has quit IRC
1462020-01-07T12:47:11  *** paultroon has joined #bitcoin-core-dev
1472020-01-07T12:54:16  *** mol has joined #bitcoin-core-dev
1482020-01-07T13:01:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1492020-01-07T13:03:55  *** tryphe_ is now known as tryphe
1502020-01-07T13:06:47  *** felixfoertsch has quit IRC
1512020-01-07T13:09:29  *** Relis has quit IRC
1522020-01-07T13:13:19  *** Guest83 has joined #bitcoin-core-dev
1532020-01-07T13:14:05  *** promag has joined #bitcoin-core-dev
1542020-01-07T13:14:45  *** promag_ has joined #bitcoin-core-dev
1552020-01-07T13:16:04  *** promag_ has quit IRC
1562020-01-07T13:18:09  *** promag_ has joined #bitcoin-core-dev
1572020-01-07T13:20:53  *** promag has quit IRC
1582020-01-07T13:27:29  *** turbo_choo has quit IRC
1592020-01-07T13:28:16  *** bitcoin-git has joined #bitcoin-core-dev
1602020-01-07T13:28:16  <bitcoin-git> [bitcoin] kallewoof opened pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887
1612020-01-07T13:28:17  *** bitcoin-git has left #bitcoin-core-dev
1622020-01-07T13:28:20  *** turbo_choo has joined #bitcoin-core-dev
1632020-01-07T13:30:40  *** bitcoin-git has joined #bitcoin-core-dev
1642020-01-07T13:30:40  <bitcoin-git> [bitcoin] xyephy opened pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
1652020-01-07T13:30:41  *** bitcoin-git has left #bitcoin-core-dev
1662020-01-07T13:31:20  *** bitcoin-git has joined #bitcoin-core-dev
1672020-01-07T13:31:20  <bitcoin-git> [bitcoin] fanquake closed pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
1682020-01-07T13:31:21  *** bitcoin-git has left #bitcoin-core-dev
1692020-01-07T13:46:17  *** felixfoertsch has joined #bitcoin-core-dev
1702020-01-07T13:49:02  *** Relis has joined #bitcoin-core-dev
1712020-01-07T13:56:54  *** bitcoin-git has joined #bitcoin-core-dev
1722020-01-07T13:56:54  <bitcoin-git> [bitcoin] promag opened pull request #17889: wallet: Improve CWallet:MarkDestinationsDirty (master...2020-01-wallettx-iscacheempty) https://github.com/bitcoin/bitcoin/pull/17889
1732020-01-07T13:56:56  *** bitcoin-git has left #bitcoin-core-dev
1742020-01-07T14:15:19  *** turbo_choo has quit IRC
1752020-01-07T14:26:06  *** Chris_Stewart_5 has quit IRC
1762020-01-07T14:26:56  *** aqquadro has joined #bitcoin-core-dev
1772020-01-07T14:30:34  *** Kiminuo has quit IRC
1782020-01-07T14:37:21  *** jonatack has quit IRC
1792020-01-07T14:40:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1802020-01-07T14:41:44  *** andrewtoth has joined #bitcoin-core-dev
1812020-01-07T14:41:55  *** jonatack has joined #bitcoin-core-dev
1822020-01-07T14:45:59  *** promag_ has quit IRC
1832020-01-07T15:00:02  *** Morgon1 has quit IRC
1842020-01-07T15:03:55  *** promag has joined #bitcoin-core-dev
1852020-01-07T15:15:23  *** tryphe has quit IRC
1862020-01-07T15:17:23  *** DARKNE55 has joined #bitcoin-core-dev
1872020-01-07T15:17:36  *** michaelfolkson has quit IRC
1882020-01-07T15:17:49  *** jonatack has quit IRC
1892020-01-07T15:20:21  *** michaelfolkson has joined #bitcoin-core-dev
1902020-01-07T15:20:37  *** michaelfolkson has quit IRC
1912020-01-07T15:27:54  *** ctrlbreak_MAD is now known as ctrlbreak
1922020-01-07T15:40:01  *** mdunnio has joined #bitcoin-core-dev
1932020-01-07T15:45:10  *** promag has quit IRC
1942020-01-07T15:48:13  <kallewoof> Why would bitcoin core reopen old rev files after closing their blk files? #17890
1952020-01-07T15:48:14  <gribble> https://github.com/bitcoin/bitcoin/issues/17890 | Non-latest rev files are sometimes re-opened but never re-flushed · Issue #17890 · bitcoin/bitcoin · GitHub
1962020-01-07T15:49:00  <sipa> kallewoof: rev files are written at activation time, which is not the same time as the blocks are written
1972020-01-07T15:49:26  <sipa> (not sure that explains what you're seeing, though0
1982020-01-07T15:49:28  <kallewoof> sipa: we need to flush them afterwards then. maybe always flush after each write, if it is not the current one
1992020-01-07T15:49:59  <kallewoof> sipa: i am seeing 2 separate bugs. 1 bug is that we over-allocate by (file size) amount, and 2nd is that we are not flushing afterwards, leaving some of the rev files in the overblown-size state.
2002020-01-07T15:50:07  <sipa> hmm, we don't mark block index entries dirty when the corresponding block is activated/deactivated?
2012020-01-07T15:50:35  <kallewoof> sipa: we only ever flush a undo file when we close its block file.
2022020-01-07T15:50:51  <kallewoof> sipa: "Leaving block X" is when we flush both blk and rev. Never again after that
2032020-01-07T15:50:57  <sipa> ah, that seems wrong
2042020-01-07T15:51:12  <sipa> i'll have a look
2052020-01-07T15:52:09  *** Guest83 has quit IRC
2062020-01-07T16:19:14  *** Relis has quit IRC
2072020-01-07T16:27:33  *** Relis has joined #bitcoin-core-dev
2082020-01-07T16:27:38  *** morcos has quit IRC
2092020-01-07T16:28:00  *** morcos has joined #bitcoin-core-dev
2102020-01-07T16:28:25  *** bitcoin-git has joined #bitcoin-core-dev
2112020-01-07T16:28:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex (master...2001-c2-CC) https://github.com/bitcoin/bitcoin/pull/17891
2122020-01-07T16:28:26  *** bitcoin-git has left #bitcoin-core-dev
2132020-01-07T16:33:34  *** Randolf has quit IRC
2142020-01-07T16:34:02  <kallewoof> sipa: ok. I'm looking too
2152020-01-07T16:36:48  *** Talkless has joined #bitcoin-core-dev
2162020-01-07T16:40:33  <kallewoof> sipa: I think part of the issue is that blocks are stored to disk and there is a lag between that and the block being connected (probably due to sig checks / utxo etc), and since undo data is written then (at activation time as you said), the system will move on to the next block file but the activation will still be working against the previous one.
2172020-01-07T16:41:58  <kallewoof> I saw the first encounter of 'write to an older rev file' right after closing block file 0, which said it had 'heights=0...119975', but right before that line there was an UpdateTip new best for height 119963, and my code broke when it was about to find undo pos for height 119965.
2182020-01-07T16:42:19  <kallewoof> s/broke/hit my breakpoint/g
2192020-01-07T16:43:23  <kallewoof> looks like a decent fix here is to flush the blk/undo when the activation occurs (as well, probably, to cover both cases).
2202020-01-07T16:43:43  <kallewoof> i mean, when the activation goes from 'X' to 'X+1' in terms of the block file #.
2212020-01-07T16:58:02  <sipa> kallewoof: iirc we only have one set of "dirty" files which are synced at flush time, which covers both blk and rev files
2222020-01-07T16:58:08  <sipa> it seems we'll need to split that up
2232020-01-07T17:01:07  <kallewoof> sipa: there is a setDirtyBlockIndex which is then chucked at a txdb.cpp method which writes a bunch. It's not immediately clear to me if those are the rev/blk or the index stuff.
2242020-01-07T17:01:50  <kallewoof> the only place we flush (truncate to actual used size) the blk/rev is in that one place in validation.cpp. there is another place which calls but with finalize=false which doesn't do that.
2252020-01-07T17:02:05  *** Talkless has quit IRC
2262020-01-07T17:05:30  *** promag has joined #bitcoin-core-dev
2272020-01-07T17:05:37  *** jungly has quit IRC
2282020-01-07T17:05:40  *** aqquadro has quit IRC
2292020-01-07T17:05:52  *** Talkless has joined #bitcoin-core-dev
2302020-01-07T17:10:13  <sipa> kallewoof: ah right
2312020-01-07T17:11:31  *** pinheadmz has quit IRC
2322020-01-07T17:13:52  *** SiAnDoG__ has joined #bitcoin-core-dev
2332020-01-07T17:17:50  *** promag has quit IRC
2342020-01-07T17:19:56  *** promag has joined #bitcoin-core-dev
2352020-01-07T17:27:30  *** jarthur has joined #bitcoin-core-dev
2362020-01-07T17:27:56  *** promag has quit IRC
2372020-01-07T17:37:07  *** paultroon has quit IRC
2382020-01-07T17:44:43  *** Chris_Stewart_5 has quit IRC
2392020-01-07T17:48:25  *** paultroon has joined #bitcoin-core-dev
2402020-01-07T17:53:03  *** paultroon has quit IRC
2412020-01-07T17:53:12  *** tryphe has joined #bitcoin-core-dev
2422020-01-07T17:55:37  <kallewoof> Contrary to what the block file tostring() would have you believe, it seems that blocks are not actually in a strict range inside the blk files. I see block 119776 in blk1 and 119777 in blk0.
2432020-01-07T17:58:28  *** promag has joined #bitcoin-core-dev
2442020-01-07T17:59:01  <goatpig_> hasnt been the case since header first
2452020-01-07T18:00:02  *** DARKNE55 has quit IRC
2462020-01-07T18:00:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2472020-01-07T18:00:35  <kallewoof> i have a sorta working patch but it needs to be reworked around the fact blocks are jumbled. see https://github.com/kallewoof/bitcoin/tree/200108-reflush-undo
2482020-01-07T18:01:26  *** andrewtoth_ has joined #bitcoin-core-dev
2492020-01-07T18:02:23  *** andrewtoth has quit IRC
2502020-01-07T18:02:36  <kallewoof> I think the straightforward solution is to determine the last block in the old rev file beforehand and to have the write for that trigger the flush. But it's 3 am now. /waves
2512020-01-07T18:06:03  *** andrewtoth_ has quit IRC
2522020-01-07T18:06:23  *** bitcoin-git has joined #bitcoin-core-dev
2532020-01-07T18:06:24  <bitcoin-git> [bitcoin] kallewoof opened pull request #17892: bug-fix: re-flush undo files after they have been re-opened (master...200108-reflush-undo) https://github.com/bitcoin/bitcoin/pull/17892
2542020-01-07T18:06:35  *** bitcoin-git has left #bitcoin-core-dev
2552020-01-07T18:17:19  *** derek1 has joined #bitcoin-core-dev
2562020-01-07T18:22:38  *** joncoe has quit IRC
2572020-01-07T18:34:58  *** lowentropy has quit IRC
2582020-01-07T18:39:21  *** paultroon has joined #bitcoin-core-dev
2592020-01-07T18:41:03  *** paultroon has joined #bitcoin-core-dev
2602020-01-07T18:44:39  *** jonatack has joined #bitcoin-core-dev
2612020-01-07T18:56:01  *** Kiminuo has joined #bitcoin-core-dev
2622020-01-07T19:04:38  *** bitcoin-git has joined #bitcoin-core-dev
2632020-01-07T19:04:39  <bitcoin-git> [bitcoin] IPGlider closed pull request #17884: utils: Use fallback for macOS in AllocateFileRange (master...workaround_apfs_allocation_problem) https://github.com/bitcoin/bitcoin/pull/17884
2642020-01-07T19:04:39  *** bitcoin-git has left #bitcoin-core-dev
2652020-01-07T19:09:50  *** Dean_Guss has quit IRC
2662020-01-07T19:12:19  <sipa> e er5~
2672020-01-07T19:12:29  <sipa> oops
2682020-01-07T19:14:47  *** Talkless has quit IRC
2692020-01-07T19:22:14  *** promag has quit IRC
2702020-01-07T19:51:07  *** Highway61 has quit IRC
2712020-01-07T19:54:28  *** ddustin has joined #bitcoin-core-dev
2722020-01-07T19:59:20  *** jarthur has quit IRC
2732020-01-07T20:00:15  *** ddustin has quit IRC
2742020-01-07T20:00:50  *** ddustin has joined #bitcoin-core-dev
2752020-01-07T20:03:26  *** promag has joined #bitcoin-core-dev
2762020-01-07T20:04:50  *** ddustin has quit IRC
2772020-01-07T20:08:19  *** promag has quit IRC
2782020-01-07T20:14:43  *** andrewtoth_ has joined #bitcoin-core-dev
2792020-01-07T20:20:49  *** rex4539 has joined #bitcoin-core-dev
2802020-01-07T20:24:31  *** mryandao has quit IRC
2812020-01-07T20:25:14  *** mryandao has joined #bitcoin-core-dev
2822020-01-07T20:31:00  *** molly has joined #bitcoin-core-dev
2832020-01-07T20:34:03  *** mol has quit IRC
2842020-01-07T20:36:27  *** rex4539 has quit IRC
2852020-01-07T20:49:27  *** rex4539 has joined #bitcoin-core-dev
2862020-01-07T20:53:22  *** jarthur has joined #bitcoin-core-dev
2872020-01-07T21:00:01  *** derek1 has quit IRC
2882020-01-07T21:02:58  *** mr_paz has joined #bitcoin-core-dev
2892020-01-07T21:09:25  *** mr_paz has quit IRC
2902020-01-07T21:11:59  *** mrostecki[m] has joined #bitcoin-core-dev
2912020-01-07T21:17:16  *** mreider has joined #bitcoin-core-dev
2922020-01-07T21:17:59  *** Relis has quit IRC
2932020-01-07T21:21:43  *** tryphe_ has joined #bitcoin-core-dev
2942020-01-07T21:24:11  *** tryphe has quit IRC
2952020-01-07T21:25:47  *** Relis has joined #bitcoin-core-dev
2962020-01-07T21:26:17  <jeremyrubin> Does anyone have any trouble with univalue encoding VARR types?
2972020-01-07T21:26:32  *** rex4539 has joined #bitcoin-core-dev
2982020-01-07T21:26:42  <jeremyrubin> I'm working on an RPC and I'm getting: vector::_M_range_check: __n (which is 1) >= this->size() (which is 1)
2992020-01-07T21:26:52  *** ghost43 has quit IRC
3002020-01-07T21:27:10  *** ghost43 has joined #bitcoin-core-dev
3012020-01-07T21:27:18  <jeremyrubin> (sidebar: the NONFATAL stuff makes debugging these sorts of problems harder, we should add flags to re-enable panic)
3022020-01-07T21:28:31  <sipa> it's probably good to make NONFATAL failures turn into assertion failures in debug builds
3032020-01-07T21:32:35  *** bitcoin-git has joined #bitcoin-core-dev
3042020-01-07T21:32:35  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e8e79958a7b2...bcb4cdcca321
3052020-01-07T21:32:36  <bitcoin-git> bitcoin/master 0950245 Gregory Sanders: IsUsedDestination should count any known single-key address
3062020-01-07T21:32:36  <bitcoin-git> bitcoin/master bcb4cdc Samuel Dobson: Merge #17621: IsUsedDestination should count any known single-key address
3072020-01-07T21:32:38  *** bitcoin-git has left #bitcoin-core-dev
3082020-01-07T21:32:55  *** bitcoin-git has joined #bitcoin-core-dev
3092020-01-07T21:32:55  <bitcoin-git> [bitcoin] meshcollider merged pull request #17621: IsUsedDestination should count any known single-key address (master...actually_no_reuse) https://github.com/bitcoin/bitcoin/pull/17621
3102020-01-07T21:32:56  *** bitcoin-git has left #bitcoin-core-dev
3112020-01-07T21:33:38  *** Highway61 has joined #bitcoin-core-dev
3122020-01-07T21:36:44  <jeremyrubin> sipa: what's the debug flag named (not NDEBUG)
3132020-01-07T21:36:50  *** nodweber has quit IRC
3142020-01-07T21:37:25  <sipa> jeremyrubin: --enable-debug sets some flags; it could set another one that specifically control this behaviour
3152020-01-07T21:37:43  *** vasild_ has joined #bitcoin-core-dev
3162020-01-07T21:38:01  *** nodweber has joined #bitcoin-core-dev
3172020-01-07T21:40:43  *** vasild has quit IRC
3182020-01-07T21:41:30  *** bitcoin-git has joined #bitcoin-core-dev
3192020-01-07T21:41:31  <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bcb4cdcca321...45f151913ef5
3202020-01-07T21:41:31  <bitcoin-git> bitcoin/master 75a5e47 Gregory Sanders: Change bumpfee to use watch-only funds for legacy watchonly wallets
3212020-01-07T21:41:32  <bitcoin-git> bitcoin/master e9b4f94 Gregory Sanders: bumpfee: Return PSBT when wallet has privkeys disabled
3222020-01-07T21:41:32  <bitcoin-git> bitcoin/master 091a876 Gregory Sanders: Test watchonly wallet bumpfee with PSBT return
3232020-01-07T21:41:34  *** bitcoin-git has left #bitcoin-core-dev
3242020-01-07T21:42:20  *** bitcoin-git has joined #bitcoin-core-dev
3252020-01-07T21:42:20  <bitcoin-git> [bitcoin] meshcollider merged pull request #16373: bumpfee: Return PSBT when wallet has privkeys disabled (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
3262020-01-07T21:42:21  *** bitcoin-git has left #bitcoin-core-dev
3272020-01-07T21:44:09  *** echonaut has quit IRC
3282020-01-07T21:45:48  *** echonaut has joined #bitcoin-core-dev
3292020-01-07T21:52:55  *** _andrewtoth_ has joined #bitcoin-core-dev
3302020-01-07T21:54:03  *** andrewtoth_ has quit IRC
3312020-01-07T21:55:03  *** niska has quit IRC
3322020-01-07T21:55:12  *** _andrewtoth_ has quit IRC
3332020-01-07T22:00:20  *** niska has joined #bitcoin-core-dev
3342020-01-07T22:11:05  *** echonaut has quit IRC
3352020-01-07T22:15:25  *** echonaut has joined #bitcoin-core-dev
3362020-01-07T22:17:33  *** Chris_Stewart_5 has quit IRC
3372020-01-07T22:18:46  *** Lox3u has joined #bitcoin-core-dev
3382020-01-07T22:20:35  *** paultroon has quit IRC
3392020-01-07T22:22:22  *** Lox3u has quit IRC
3402020-01-07T22:22:46  <jeremyrubin> Ah; I had a variable x and a string "x" and I did x.pushKV("label", x)
3412020-01-07T22:25:35  *** bitcoin-git has joined #bitcoin-core-dev
3422020-01-07T22:25:36  <bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/45f151913ef5...7ea3b85ecf7b
3432020-01-07T22:25:37  <bitcoin-git> bitcoin/master 7851f14 Jon Atack: rpc: incorporate review feedback from PR 17283
3442020-01-07T22:25:38  <bitcoin-git> bitcoin/master 60aba1f Jon Atack: rpc: simplify getaddressinfo labels, deprecate previous behavior
3452020-01-07T22:25:39  <bitcoin-git> bitcoin/master 8bb405b Jon Atack: test: getaddressinfo labels purpose deprecation test
3462020-01-07T22:25:47  *** bitcoin-git has left #bitcoin-core-dev
3472020-01-07T22:26:05  *** bitcoin-git has joined #bitcoin-core-dev
3482020-01-07T22:26:06  <bitcoin-git> [bitcoin] meshcollider merged pull request #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior (master...deprecate-getaddress-info-labels-purpose) https://github.com/bitcoin/bitcoin/pull/17578
3492020-01-07T22:26:17  *** bitcoin-git has left #bitcoin-core-dev
3502020-01-07T22:30:27  *** bitcoin-git has joined #bitcoin-core-dev
3512020-01-07T22:30:27  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea3b85ecf7b...cab3859a356d
3522020-01-07T22:30:28  <bitcoin-git> bitcoin/master e1e1442 Gregory Sanders: Activate no-privkey -> ISMINE_WATCH_ONLY behavior for LegacySPKM only
3532020-01-07T22:30:28  <bitcoin-git> bitcoin/master cab3859 Samuel Dobson: Merge #17677: Activate watchonly wallet behavior for LegacySPKM only
3542020-01-07T22:30:30  *** bitcoin-git has left #bitcoin-core-dev
3552020-01-07T22:30:47  *** bitcoin-git has joined #bitcoin-core-dev
3562020-01-07T22:30:47  <bitcoin-git> [bitcoin] meshcollider merged pull request #17677: Activate watchonly wallet behavior for LegacySPKM only (master...legacy_spkm_watchonly) https://github.com/bitcoin/bitcoin/pull/17677
3572020-01-07T22:30:48  *** bitcoin-git has left #bitcoin-core-dev
3582020-01-07T22:37:21  <hebasto> ryanofsky: hmm, why test/functional/feature_config_args.py passed on 67518f7cc61bf59ddfa0fd7c8dbbdec3653b9556 ?
3592020-01-07T22:39:39  <hebasto> I see now: test is broken.
3602020-01-07T22:39:59  <ryanofsky> test should be unaffected by that change, do you see a break somewhere?
3612020-01-07T22:41:58  <hebasto> yes: "-connect=0x7fff50369968" != "-connect=0"
3622020-01-07T22:46:18  *** Zenton has quit IRC
3632020-01-07T22:47:49  *** bitcoin-git has joined #bitcoin-core-dev
3642020-01-07T22:47:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cab3859a356d...fcef6dbc15ef
3652020-01-07T22:47:50  <bitcoin-git> bitcoin/master 77ef48d Jon Atack: gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy
3662020-01-07T22:47:51  <bitcoin-git> bitcoin/master fcef6db fanquake: Merge #17452: test: update fuzz directory in .gitignore
3672020-01-07T22:47:53  *** bitcoin-git has left #bitcoin-core-dev
3682020-01-07T22:48:09  *** bitcoin-git has joined #bitcoin-core-dev
3692020-01-07T22:48:09  <bitcoin-git> [bitcoin] fanquake merged pull request #17452: test: update fuzz directory in .gitignore (master...update-fuzz-gitignore) https://github.com/bitcoin/bitcoin/pull/17452
3702020-01-07T22:48:11  *** bitcoin-git has left #bitcoin-core-dev
3712020-01-07T22:49:38  <ryanofsky> Oh I see how that would happen, it should not be a problem in the current PR.
3722020-01-07T22:50:10  <hebasto> going to submit a pr to fix test
3732020-01-07T22:50:48  <ryanofsky> in the commit you mentioned, value is a pointer to a string, and it was printing the pointer address instead of the string on: LogPrintf("Warning: parsed potentially confusing double-negative -%s=%s\n", key, value);
3742020-01-07T22:51:21  <hebasto> correct
3752020-01-07T22:54:41  <ryanofsky> oh I see, test could be fixed to more robust and not accept trailing characters after 0
3762020-01-07T22:59:18  *** Guyver2_ has quit IRC
3772020-01-07T23:00:10  *** captjakk has joined #bitcoin-core-dev
3782020-01-07T23:11:02  *** jarthur has quit IRC
3792020-01-07T23:11:40  *** DeanGuss has joined #bitcoin-core-dev
3802020-01-07T23:15:26  <captjakk> does bitcoind not support the newer 54 char onion addresses for tor?
3812020-01-07T23:15:44  <sipa> no
3822020-01-07T23:16:11  <sipa> needs bip 155 in order to represent those
3832020-01-07T23:17:01  *** Kiminuo has quit IRC
3842020-01-07T23:18:11  <captjakk> what's the timeline on 155, and is it something that could benefit from engineering contributions right now, or is it still being debated what the best approach is to get it in?
3852020-01-07T23:18:36  <sipa> i don't know if anyone is working on it right now
3862020-01-07T23:18:51  <sipa> i don't think there are any known problems with it
3872020-01-07T23:19:23  <captjakk> kk, so if I submit a patch implementing it, are you optimistic it would be merged assuming no implementation problems?
3882020-01-07T23:20:52  <captjakk> I'd imagine since this isn't a consensus issue, the vuln surface is substantially smaller
3892020-01-07T23:30:06  *** mdunnio has quit IRC
3902020-01-07T23:31:05  *** promag has joined #bitcoin-core-dev
3912020-01-07T23:37:02  *** promag has quit IRC
3922020-01-07T23:39:06  *** promag has joined #bitcoin-core-dev
3932020-01-07T23:42:59  *** AaronvanW has quit IRC
3942020-01-07T23:49:41  *** _andrewtoth_ has joined #bitcoin-core-dev
3952020-01-07T23:54:32  *** captjakk has quit IRC
3962020-01-07T23:55:51  *** captjakk has joined #bitcoin-core-dev