12020-01-11T00:00:01 *** sledges has quit IRC
22020-01-11T00:02:16 *** Chris_Stewart_5 has quit IRC
32020-01-11T00:08:08 *** millerti has quit IRC
42020-01-11T00:22:28 *** Giszmo has quit IRC
52020-01-11T00:30:50 *** apex944 has joined #bitcoin-core-dev
62020-01-11T00:31:56 *** turbo_choo has joined #bitcoin-core-dev
72020-01-11T00:34:05 *** bitcoin-git has joined #bitcoin-core-dev
82020-01-11T00:34:05 <bitcoin-git> [bitcoin] Empact opened pull request #17907: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907
92020-01-11T00:34:07 *** bitcoin-git has left #bitcoin-core-dev
102020-01-11T00:35:33 *** apex944 has quit IRC
112020-01-11T00:37:56 *** promag has quit IRC
122020-01-11T00:39:33 *** belcher has quit IRC
132020-01-11T00:45:13 *** jsfan has joined #bitcoin-core-dev
142020-01-11T00:45:18 *** turbo_choo has quit IRC
152020-01-11T00:46:38 *** andytoshi has quit IRC
162020-01-11T00:47:23 *** _andrewtoth_ has quit IRC
172020-01-11T00:52:00 *** turbo_choo has joined #bitcoin-core-dev
182020-01-11T00:56:17 *** emilengler has quit IRC
192020-01-11T01:02:45 *** meshcollider has joined #bitcoin-core-dev
202020-01-11T01:06:43 *** cornfeedhobo has quit IRC
212020-01-11T01:07:35 *** masterdonx2 has quit IRC
222020-01-11T01:07:55 *** MasterdonX has joined #bitcoin-core-dev
232020-01-11T01:10:17 *** cornfeedhobo has joined #bitcoin-core-dev
242020-01-11T01:25:24 *** rex4539 has quit IRC
252020-01-11T01:25:33 *** turbo_choo has quit IRC
262020-01-11T01:39:56 *** hari_seldon has left #bitcoin-core-dev
272020-01-11T01:40:06 *** hari_seldon has joined #bitcoin-core-dev
282020-01-11T01:48:01 *** andytoshi has joined #bitcoin-core-dev
292020-01-11T01:48:02 *** andytoshi has quit IRC
302020-01-11T01:48:02 *** andytoshi has joined #bitcoin-core-dev
312020-01-11T02:08:56 *** turbo_choo has joined #bitcoin-core-dev
322020-01-11T02:19:42 *** marcoagner has quit IRC
332020-01-11T02:31:49 *** apex944 has joined #bitcoin-core-dev
342020-01-11T02:33:03 *** mryandao has quit IRC
352020-01-11T02:36:27 *** apex944 has quit IRC
362020-01-11T02:37:06 *** mryandao has joined #bitcoin-core-dev
372020-01-11T02:39:33 *** AaronvanW has quit IRC
382020-01-11T02:50:47 *** apex944 has joined #bitcoin-core-dev
392020-01-11T02:57:43 *** apex944 has quit IRC
402020-01-11T03:00:01 *** jsfan has quit IRC
412020-01-11T03:01:08 *** pinheadmz has quit IRC
422020-01-11T03:01:18 *** abrissbi1ne has joined #bitcoin-core-dev
432020-01-11T03:03:23 *** sdaftuar has quit IRC
442020-01-11T03:04:26 *** abrissbirne has quit IRC
452020-01-11T03:04:28 *** sdaftuar has joined #bitcoin-core-dev
462020-01-11T03:05:51 *** Kevin_ has joined #bitcoin-core-dev
472020-01-11T03:07:48 *** Kevin_ has quit IRC
482020-01-11T03:09:03 *** shesek has quit IRC
492020-01-11T03:09:29 *** shesek has joined #bitcoin-core-dev
502020-01-11T03:09:29 *** shesek has joined #bitcoin-core-dev
512020-01-11T03:17:22 *** gingerling has joined #bitcoin-core-dev
522020-01-11T03:31:20 *** felixfoertsch has joined #bitcoin-core-dev
532020-01-11T03:34:03 *** felixfoertsch23 has quit IRC
542020-01-11T03:44:12 *** Guest83 has joined #bitcoin-core-dev
552020-01-11T03:53:58 *** Relis has quit IRC
562020-01-11T03:55:16 *** aadams has joined #bitcoin-core-dev
572020-01-11T03:55:40 *** Relis has joined #bitcoin-core-dev
582020-01-11T04:03:10 *** apex944 has joined #bitcoin-core-dev
592020-01-11T04:13:20 *** aadams has quit IRC
602020-01-11T04:14:07 *** Guest83 has quit IRC
612020-01-11T04:14:27 *** AaronvanW has joined #bitcoin-core-dev
622020-01-11T04:15:59 *** Relis has quit IRC
632020-01-11T04:16:34 *** Relis has joined #bitcoin-core-dev
642020-01-11T04:17:46 *** Tic has quit IRC
652020-01-11T04:19:33 *** apex944 has quit IRC
662020-01-11T04:20:50 *** bitcoin-git has joined #bitcoin-core-dev
672020-01-11T04:20:51 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8c69677a1a8...e258ce792a48
682020-01-11T04:20:52 <bitcoin-git> bitcoin/master 498cdbb Ben Woosley: Fix improper Doxygen inline comments
692020-01-11T04:20:53 <bitcoin-git> bitcoin/master e258ce7 fanquake: Merge #17907: doc: Fix improper Doxygen inline comments
702020-01-11T04:20:55 *** bitcoin-git has left #bitcoin-core-dev
712020-01-11T04:21:10 *** bitcoin-git has joined #bitcoin-core-dev
722020-01-11T04:21:10 <bitcoin-git> [bitcoin] fanquake merged pull request #17907: doc: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907
732020-01-11T04:21:23 *** bitcoin-git has left #bitcoin-core-dev
742020-01-11T04:23:48 *** apex944 has joined #bitcoin-core-dev
752020-01-11T04:29:55 *** ddustin has joined #bitcoin-core-dev
762020-01-11T04:33:27 *** ddustin_ has joined #bitcoin-core-dev
772020-01-11T04:35:14 *** Highway61 has quit IRC
782020-01-11T04:36:12 *** ddustin has quit IRC
792020-01-11T04:48:32 *** AaronvanW has quit IRC
802020-01-11T05:00:02 *** apex944 has quit IRC
812020-01-11T05:13:52 *** ddustin_ has quit IRC
822020-01-11T05:13:58 *** ddustin has joined #bitcoin-core-dev
832020-01-11T05:25:38 *** turbo_choo has quit IRC
842020-01-11T05:26:00 *** turbo_choo has joined #bitcoin-core-dev
852020-01-11T05:28:43 *** sdaftuar has quit IRC
862020-01-11T05:31:26 *** sdaftuar has joined #bitcoin-core-dev
872020-01-11T05:38:45 *** Guest83 has joined #bitcoin-core-dev
882020-01-11T05:56:16 *** ddustin has quit IRC
892020-01-11T05:56:55 *** ddustin has joined #bitcoin-core-dev
902020-01-11T06:00:01 *** gingerling has quit IRC
912020-01-11T06:01:08 *** ddustin has quit IRC
922020-01-11T06:04:09 *** felixfoertsch has quit IRC
932020-01-11T06:04:19 *** felixfoertsch has joined #bitcoin-core-dev
942020-01-11T06:09:14 *** turbo_choo has quit IRC
952020-01-11T06:17:28 *** brycec1 has joined #bitcoin-core-dev
962020-01-11T06:28:59 *** Relis has quit IRC
972020-01-11T06:45:17 *** AaronvanW has joined #bitcoin-core-dev
982020-01-11T07:17:45 *** AaronvanW has quit IRC
992020-01-11T07:20:50 *** hari_seldon has left #bitcoin-core-dev
1002020-01-11T07:30:54 *** Guest83 has quit IRC
1012020-01-11T07:59:59 *** Guest83 has joined #bitcoin-core-dev
1022020-01-11T08:27:52 *** turbo_choo has joined #bitcoin-core-dev
1032020-01-11T08:29:56 *** turbo_choo has quit IRC
1042020-01-11T08:35:22 *** emilengler has joined #bitcoin-core-dev
1052020-01-11T08:35:33 *** shesek has quit IRC
1062020-01-11T08:35:56 *** shesek has joined #bitcoin-core-dev
1072020-01-11T08:35:56 *** shesek has joined #bitcoin-core-dev
1082020-01-11T08:42:03 *** midnight has quit IRC
1092020-01-11T08:45:54 *** Talkless has joined #bitcoin-core-dev
1102020-01-11T08:46:55 *** turbo_choo has joined #bitcoin-core-dev
1112020-01-11T08:54:12 *** pinheadmz has joined #bitcoin-core-dev
1122020-01-11T08:54:53 *** turbo_choo has quit IRC
1132020-01-11T08:57:37 *** ddustin has joined #bitcoin-core-dev
1142020-01-11T09:00:02 *** brycec1 has quit IRC
1152020-01-11T09:02:12 *** ddustin has quit IRC
1162020-01-11T09:14:48 *** pinheadmz has quit IRC
1172020-01-11T09:15:17 *** AaronvanW has joined #bitcoin-core-dev
1182020-01-11T09:16:18 *** Guest83 has quit IRC
1192020-01-11T09:17:16 *** unfo- has joined #bitcoin-core-dev
1202020-01-11T09:20:24 *** Guest83 has joined #bitcoin-core-dev
1212020-01-11T09:30:35 *** rex4539 has joined #bitcoin-core-dev
1222020-01-11T09:40:43 *** vasild has quit IRC
1232020-01-11T09:42:40 *** vasild has joined #bitcoin-core-dev
1242020-01-11T10:28:29 *** goatpig has joined #bitcoin-core-dev
1252020-01-11T10:32:34 *** AaronvanW has quit IRC
1262020-01-11T10:50:26 *** murray_ has left #bitcoin-core-dev
1272020-01-11T10:51:01 *** murrayn has joined #bitcoin-core-dev
1282020-01-11T11:00:46 *** Guest83 has joined #bitcoin-core-dev
1292020-01-11T11:03:54 *** Amber36Franecki has joined #bitcoin-core-dev
1302020-01-11T11:04:34 *** Guest83 has joined #bitcoin-core-dev
1312020-01-11T11:12:52 *** jonatack has quit IRC
1322020-01-11T11:16:19 *** marcoagner has joined #bitcoin-core-dev
1332020-01-11T11:19:40 *** Talkless has quit IRC
1342020-01-11T11:31:13 *** Amber36Franecki has quit IRC
1352020-01-11T11:31:42 *** Talkless has joined #bitcoin-core-dev
1362020-01-11T11:37:07 *** AaronvanW has joined #bitcoin-core-dev
1372020-01-11T11:40:11 *** Kiminuo has joined #bitcoin-core-dev
1382020-01-11T11:44:51 *** turbo_choo has joined #bitcoin-core-dev
1392020-01-11T11:45:39 *** belcher has joined #bitcoin-core-dev
1402020-01-11T12:00:01 *** unfo- has quit IRC
1412020-01-11T12:12:19 *** Guest83 has quit IRC
1422020-01-11T12:13:40 *** Guyver2 has joined #bitcoin-core-dev
1432020-01-11T12:14:23 *** Talkless has quit IRC
1442020-01-11T12:17:14 *** MTecknology1 has joined #bitcoin-core-dev
1452020-01-11T12:21:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1462020-01-11T12:29:24 *** Krellan__ has joined #bitcoin-core-dev
1472020-01-11T12:29:24 *** Krellan_ has quit IRC
1482020-01-11T12:31:47 *** Krellan_ has joined #bitcoin-core-dev
1492020-01-11T12:35:07 *** Krellan__ has quit IRC
1502020-01-11T12:47:22 *** bitcoin-git has joined #bitcoin-core-dev
1512020-01-11T12:47:23 <bitcoin-git> [bitcoin] hebasto opened pull request #17908: qa, qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
1522020-01-11T12:47:34 *** bitcoin-git has left #bitcoin-core-dev
1532020-01-11T12:51:12 *** joncoe has joined #bitcoin-core-dev
1542020-01-11T13:01:22 *** Relis has joined #bitcoin-core-dev
1552020-01-11T13:05:31 *** Relis has quit IRC
1562020-01-11T13:10:23 *** alec has quit IRC
1572020-01-11T13:13:09 *** Relis has joined #bitcoin-core-dev
1582020-01-11T13:15:47 *** Highway61 has joined #bitcoin-core-dev
1592020-01-11T13:17:28 *** alec has joined #bitcoin-core-dev
1602020-01-11T13:24:42 *** felixfoertsch has quit IRC
1612020-01-11T13:24:48 <hebasto> hmm, the option to restart travis job is missing for me now...
1622020-01-11T13:28:47 <luke-jr> hebasto: does Travis know you're logged in?
1632020-01-11T13:30:17 <hebasto> sure, I'm logged in. It is possible to "Sign Out"
1642020-01-11T13:32:10 <hebasto> luke-jr: signed out -> signed in. It works now, Thanks!
1652020-01-11T13:32:27 *** Talkless has joined #bitcoin-core-dev
1662020-01-11T13:33:18 *** felixfoertsch has joined #bitcoin-core-dev
1672020-01-11T13:35:14 *** Kiminuo has quit IRC
1682020-01-11T13:38:15 *** goatpig has quit IRC
1692020-01-11T13:38:18 *** Guyver2 has quit IRC
1702020-01-11T13:38:35 *** goatpig has joined #bitcoin-core-dev
1712020-01-11T13:40:33 *** felixfoertsch has quit IRC
1722020-01-11T13:45:38 *** Highway62 has joined #bitcoin-core-dev
1732020-01-11T13:46:53 *** Highway61 has quit IRC
1742020-01-11T13:46:54 *** Highway62 is now known as Highway61
1752020-01-11T13:49:07 *** felixfoertsch has joined #bitcoin-core-dev
1762020-01-11T13:56:02 *** Chris_Stewart_5 has quit IRC
1772020-01-11T14:01:51 *** Guest83 has joined #bitcoin-core-dev
1782020-01-11T14:02:10 *** Relis has quit IRC
1792020-01-11T14:08:13 *** apex944 has joined #bitcoin-core-dev
1802020-01-11T14:21:02 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1812020-01-11T14:23:41 *** goatpig has quit IRC
1822020-01-11T14:23:59 *** goatpig has joined #bitcoin-core-dev
1832020-01-11T14:35:15 *** Relis has joined #bitcoin-core-dev
1842020-01-11T14:38:42 *** owowo has joined #bitcoin-core-dev
1852020-01-11T14:55:32 *** apex944 has quit IRC
1862020-01-11T15:00:01 *** MTecknology1 has quit IRC
1872020-01-11T15:10:16 *** goatpig has quit IRC
1882020-01-11T15:10:31 *** goatpig has joined #bitcoin-core-dev
1892020-01-11T15:17:16 *** sirkitree has joined #bitcoin-core-dev
1902020-01-11T15:19:53 *** apex944 has joined #bitcoin-core-dev
1912020-01-11T15:23:59 *** Highway61 has quit IRC
1922020-01-11T15:25:31 *** Highway61 has joined #bitcoin-core-dev
1932020-01-11T15:41:09 *** apex944 has quit IRC
1942020-01-11T15:50:44 *** Guest83 has quit IRC
1952020-01-11T15:57:18 *** Highway62 has joined #bitcoin-core-dev
1962020-01-11T15:58:01 *** Highway61 has quit IRC
1972020-01-11T15:58:02 *** Highway62 is now known as Highway61
1982020-01-11T16:03:47 *** Chris_Stewart_5 has quit IRC
1992020-01-11T16:20:20 *** Relis has quit IRC
2002020-01-11T16:26:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2012020-01-11T16:29:47 *** brianhoffman_ has joined #bitcoin-core-dev
2022020-01-11T16:30:26 *** Guyver2 has joined #bitcoin-core-dev
2032020-01-11T16:31:03 *** brianhoffman has quit IRC
2042020-01-11T16:31:04 *** brianhoffman_ is now known as brianhoffman
2052020-01-11T16:31:43 *** Relis has joined #bitcoin-core-dev
2062020-01-11T16:38:50 *** arapaho has quit IRC
2072020-01-11T16:38:58 *** arapaho has joined #bitcoin-core-dev
2082020-01-11T16:39:22 *** arapaho is now known as Guest76054
2092020-01-11T16:45:42 *** apex944 has joined #bitcoin-core-dev
2102020-01-11T16:52:08 *** morcos has quit IRC
2112020-01-11T16:52:36 *** morcos has joined #bitcoin-core-dev
2122020-01-11T17:01:06 *** pinheadmz has joined #bitcoin-core-dev
2132020-01-11T17:06:15 *** cdecker has quit IRC
2142020-01-11T17:15:03 *** joncoe has quit IRC
2152020-01-11T17:20:26 *** apex944 has quit IRC
2162020-01-11T17:29:38 *** Chris_Stewart_5 has quit IRC
2172020-01-11T17:36:52 *** pinheadmz has quit IRC
2182020-01-11T17:49:39 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2192020-01-11T17:51:26 *** Relis has quit IRC
2202020-01-11T17:51:27 *** Kiminuo has joined #bitcoin-core-dev
2212020-01-11T17:53:29 *** Relis has joined #bitcoin-core-dev
2222020-01-11T17:55:52 *** apex944 has joined #bitcoin-core-dev
2232020-01-11T17:58:48 <Kiminuo> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L2448 - Could anyone explain this further to me? Is that byte 0x00 required for some specific reason or is it how Satoshi did that?
2242020-01-11T18:00:01 *** sirkitree has quit IRC
2252020-01-11T18:01:24 *** setpill has joined #bitcoin-core-dev
2262020-01-11T18:01:27 *** apex944 has quit IRC
2272020-01-11T18:04:02 *** promag has joined #bitcoin-core-dev
2282020-01-11T18:05:13 <sipa> Kiminuo: the p2p protocol used to have no distinction between cblock and cblockheader
2292020-01-11T18:05:25 <sipa> headers were just submitted as blocks with no transactiond
2302020-01-11T18:10:20 <Kiminuo> thanks, that makes sene
2312020-01-11T18:10:22 <Kiminuo> *sense
2322020-01-11T18:17:09 *** Laat has joined #bitcoin-core-dev
2332020-01-11T18:23:44 *** pinheadmz has joined #bitcoin-core-dev
2342020-01-11T18:26:06 *** promag has quit IRC
2352020-01-11T18:33:53 *** setpill has quit IRC
2362020-01-11T18:35:32 *** tynes_ has joined #bitcoin-core-dev
2372020-01-11T18:36:06 *** tynes has quit IRC
2382020-01-11T18:40:36 *** jeremyrubin has quit IRC
2392020-01-11T18:47:38 *** victorSN has quit IRC
2402020-01-11T18:48:22 *** victorSN has joined #bitcoin-core-dev
2412020-01-11T18:49:14 *** Chris_Stewart_5 has quit IRC
2422020-01-11T18:53:32 *** victorSN6 has joined #bitcoin-core-dev
2432020-01-11T18:54:03 *** sipa has quit IRC
2442020-01-11T18:57:08 *** victorSN has quit IRC
2452020-01-11T18:57:08 *** victorSN6 is now known as victorSN
2462020-01-11T19:00:02 *** dr-orlovsky has quit IRC
2472020-01-11T19:01:17 *** sipa has joined #bitcoin-core-dev
2482020-01-11T19:01:49 *** dr-orlovsky has joined #bitcoin-core-dev
2492020-01-11T19:02:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2502020-01-11T19:10:03 *** pinheadmz has quit IRC
2512020-01-11T19:18:51 *** Relis7 has joined #bitcoin-core-dev
2522020-01-11T19:19:00 *** TheRec_ has joined #bitcoin-core-dev
2532020-01-11T19:19:00 *** TheRec_ has joined #bitcoin-core-dev
2542020-01-11T19:19:48 *** brianhoffman_ has joined #bitcoin-core-dev
2552020-01-11T19:21:44 *** TheRec has quit IRC
2562020-01-11T19:21:44 *** Relis has quit IRC
2572020-01-11T19:21:44 *** victorSN has quit IRC
2582020-01-11T19:21:44 *** brianhoffman has quit IRC
2592020-01-11T19:21:44 *** thaumavorio has quit IRC
2602020-01-11T19:21:45 *** niska has quit IRC
2612020-01-11T19:21:46 *** brianhoffman_ is now known as brianhoffman
2622020-01-11T19:21:47 *** sturles has quit IRC
2632020-01-11T19:22:01 *** thaumavorio_ has joined #bitcoin-core-dev
2642020-01-11T19:22:16 *** GAit has quit IRC
2652020-01-11T19:22:46 *** sturles has joined #bitcoin-core-dev
2662020-01-11T19:22:46 *** sturles has joined #bitcoin-core-dev
2672020-01-11T19:23:38 *** rh0nj has quit IRC
2682020-01-11T19:27:03 *** niska has joined #bitcoin-core-dev
2692020-01-11T19:49:06 *** GAit has joined #bitcoin-core-dev
2702020-01-11T20:02:48 *** Chris_Stewart_5 has quit IRC
2712020-01-11T20:11:19 *** lukedashjr has joined #bitcoin-core-dev
2722020-01-11T20:12:18 *** luke-jr has quit IRC
2732020-01-11T20:16:27 *** lukedashjr is now known as luke-jr
2742020-01-11T20:24:15 *** Relis7 has quit IRC
2752020-01-11T20:26:45 *** promag has joined #bitcoin-core-dev
2762020-01-11T20:28:28 *** apex944 has joined #bitcoin-core-dev
2772020-01-11T20:31:20 *** promag has quit IRC
2782020-01-11T20:32:52 *** real_or_random has quit IRC
2792020-01-11T20:33:08 *** apex944 has quit IRC
2802020-01-11T20:33:23 *** afk11 has quit IRC
2812020-01-11T20:35:18 *** Relis7 has joined #bitcoin-core-dev
2822020-01-11T20:35:26 *** afk11 has joined #bitcoin-core-dev
2832020-01-11T20:38:14 *** real_or_random has joined #bitcoin-core-dev
2842020-01-11T20:50:39 *** promag has joined #bitcoin-core-dev
2852020-01-11T20:54:32 *** captjakk has joined #bitcoin-core-dev
2862020-01-11T20:57:10 *** captjakk has quit IRC
2872020-01-11T21:00:02 *** Laat has quit IRC
2882020-01-11T21:16:31 *** mackr has joined #bitcoin-core-dev
2892020-01-11T21:33:49 *** brianhoffman_ has joined #bitcoin-core-dev
2902020-01-11T21:34:56 *** brianhoffman has quit IRC
2912020-01-11T21:34:56 *** brianhoffman_ is now known as brianhoffman
2922020-01-11T21:40:43 *** vasild has quit IRC
2932020-01-11T21:40:52 *** cdecker has joined #bitcoin-core-dev
2942020-01-11T21:41:23 *** owowo has quit IRC
2952020-01-11T21:42:39 *** vasild has joined #bitcoin-core-dev
2962020-01-11T21:44:51 *** brianhoffman has quit IRC
2972020-01-11T21:45:53 *** owowo has joined #bitcoin-core-dev
2982020-01-11T21:57:08 *** Kiminuo has quit IRC
2992020-01-11T22:08:31 *** Jackielove4u has quit IRC
3002020-01-11T22:09:23 *** brianhoffman has joined #bitcoin-core-dev
3012020-01-11T22:12:31 *** Highway61 has quit IRC
3022020-01-11T22:12:59 *** Highway61 has joined #bitcoin-core-dev
3032020-01-11T22:13:47 *** filchef has joined #bitcoin-core-dev
3042020-01-11T22:15:13 *** filchef has quit IRC
3052020-01-11T22:20:15 *** Highway61 has quit IRC
3062020-01-11T22:20:36 *** Highway61 has joined #bitcoin-core-dev
3072020-01-11T22:24:47 *** jonatack has joined #bitcoin-core-dev
3082020-01-11T22:26:07 *** Highway61 has quit IRC
3092020-01-11T22:26:47 *** victorSN has joined #bitcoin-core-dev
3102020-01-11T22:27:11 *** Highway61 has joined #bitcoin-core-dev
3112020-01-11T22:35:26 *** Guyver2 has quit IRC
3122020-01-11T22:43:38 *** Talkless has quit IRC
3132020-01-11T22:43:59 *** Talkless has joined #bitcoin-core-dev
3142020-01-11T22:47:03 *** Highway61 has quit IRC
3152020-01-11T22:53:04 *** AaronvanW has quit IRC
3162020-01-11T23:03:23 *** mfoolb has quit IRC
3172020-01-11T23:03:56 *** mfoolb has joined #bitcoin-core-dev
3182020-01-11T23:12:19 <emilengler> Is there an efficient way to get the output type from a "WalletAddress"?
3192020-01-11T23:12:37 <emilengler> Or from a CTxDestination
3202020-01-11T23:14:38 <sipa> a CTxDestination is a boost::variant
3212020-01-11T23:15:00 <sipa> it has a bunch of built in methods to query the type
3222020-01-11T23:16:11 <emilengler> sipa: I see but what's the "best way" to get the output type from it
3232020-01-11T23:16:39 *** apex944 has joined #bitcoin-core-dev
3242020-01-11T23:16:46 <emilengler> Looks like there is no function which returns OutputType where CTxDestination is a parameter of
3252020-01-11T23:29:09 <sipa> no, that's impossible
3262020-01-11T23:29:37 <sipa> you can't distinguish p2sh multisig from p2sh-p2wsh multisig for example
3272020-01-11T23:29:46 <sipa> just based on the address
3282020-01-11T23:30:11 <emilengler> Ok thanks
3292020-01-11T23:30:58 <sipa> what are you trying to do?
3302020-01-11T23:31:56 <emilengler> In bitcoin-qt I wanna sort out all non legacy addresses in the sign message dialog as they are useless in this case anyway
3312020-01-11T23:32:10 <emilengler> The addressbook*
3322020-01-11T23:33:35 <luke-jr> can't signmessage with p2sh either, so that's doable
3332020-01-11T23:34:13 <luke-jr> should be able to just use .get
3342020-01-11T23:34:55 <emilengler> luke-jr: get? Of which object?
3352020-01-11T23:35:03 <luke-jr> the CTxDestination
3362020-01-11T23:36:54 *** midnightmagic has joined #bitcoin-core-dev
3372020-01-11T23:37:00 <luke-jr> boost::get<PKHash>(&dest)
3382020-01-11T23:38:22 <emilengler> So I need to check every possible type?
3392020-01-11T23:38:37 <luke-jr> only PKHash because that's the only type that's valid for signing
3402020-01-11T23:38:46 *** owowo has quit IRC
3412020-01-11T23:38:52 <luke-jr> dest.type() is another way, possibly more efficient and more flexible
3422020-01-11T23:38:55 <emilengler> Oh sure
3432020-01-11T23:39:02 <emilengler> thanks
3442020-01-11T23:39:11 <emilengler> what is with .which()
3452020-01-11T23:41:02 *** owowo has joined #bitcoin-core-dev
3462020-01-11T23:42:52 *** cdecker has quit IRC
3472020-01-11T23:43:27 <emilengler> luke-jr: Thx, works
3482020-01-11T23:43:30 *** cdecker has joined #bitcoin-core-dev
3492020-01-11T23:43:45 *** luke-jr has quit IRC
3502020-01-11T23:44:22 *** luke-jr has joined #bitcoin-core-dev