12020-01-23T00:00:02 *** pmuir has quit IRC
22020-01-23T00:01:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
32020-01-23T00:02:15 *** michaelfolkson has joined #bitcoin-core-dev
42020-01-23T00:02:36 *** michaelfolkson has quit IRC
52020-01-23T00:04:58 *** zivl has joined #bitcoin-core-dev
62020-01-23T00:06:02 *** Chris_Stewart_5 has quit IRC
72020-01-23T00:17:28 *** SchwarzeLocke has joined #bitcoin-core-dev
82020-01-23T00:26:17 *** andrewtoth has quit IRC
92020-01-23T00:41:39 *** bitcoin-git has joined #bitcoin-core-dev
102020-01-23T00:41:39 <bitcoin-git> [bitcoin] fanquake opened pull request #17988: [0.19] Final backports for 0.19.1 (0.19...0-19-1-final-backports) https://github.com/bitcoin/bitcoin/pull/17988
112020-01-23T00:41:40 *** bitcoin-git has left #bitcoin-core-dev
122020-01-23T00:43:14 <fanquake> If anyone has backport suggestions other than what is left tagged, https://github.com/bitcoin/bitcoin/labels/Needs%20backport%20%280.19%29, please comment etc
132020-01-23T00:45:16 *** promag has quit IRC
142020-01-23T00:55:37 *** nirved has quit IRC
152020-01-23T00:56:30 *** nirved has joined #bitcoin-core-dev
162020-01-23T01:16:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
172020-01-23T01:19:19 *** promag has joined #bitcoin-core-dev
182020-01-23T01:24:07 *** promag has quit IRC
192020-01-23T01:40:09 <fanquake> Going to backport #17980 as well so that AppVeyor works for 0.19.
202020-01-23T01:40:10 <gribble> https://github.com/bitcoin/bitcoin/issues/17980 | test: add missing #include to fix compiler errors by kallewoof · Pull Request #17980 · bitcoin/bitcoin · GitHub
212020-01-23T02:08:10 *** bitcoin-git has joined #bitcoin-core-dev
222020-01-23T02:08:10 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/a05d14d4a00e...8b67698420e2
232020-01-23T02:08:11 <bitcoin-git> bitcoin/0.18 c89611e Wladimir J. van der Laan: net: Log to net category for exceptions in ProcessMessages
242020-01-23T02:08:12 <bitcoin-git> bitcoin/0.18 8b67698 fanquake: Merge #17974: [0.18] net: Log to net category for exceptions in ProcessMes...
252020-01-23T02:08:13 *** bitcoin-git has left #bitcoin-core-dev
262020-01-23T02:08:25 *** bitcoin-git has joined #bitcoin-core-dev
272020-01-23T02:08:25 <bitcoin-git> [bitcoin] fanquake merged pull request #17974: [0.18] net: Log to net category for exceptions in ProcessMessages (0.18...bp18_network_exceptions) https://github.com/bitcoin/bitcoin/pull/17974
282020-01-23T02:08:37 *** bitcoin-git has left #bitcoin-core-dev
292020-01-23T02:27:46 *** DeanWeen has joined #bitcoin-core-dev
302020-01-23T02:36:45 *** Chris_Stewart_5 has quit IRC
312020-01-23T02:47:47 *** zivl has quit IRC
322020-01-23T02:52:40 *** bitcoin-git has joined #bitcoin-core-dev
332020-01-23T02:52:40 <bitcoin-git> [bitcoin] fanquake closed pull request #17964: doc: Improve contibutor doc formatting and readability (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17964
342020-01-23T02:52:41 *** bitcoin-git has left #bitcoin-core-dev
352020-01-23T03:00:02 *** SchwarzeLocke has quit IRC
362020-01-23T03:01:37 *** abrissbi1ne has joined #bitcoin-core-dev
372020-01-23T03:04:56 *** abrissbirne has quit IRC
382020-01-23T03:09:03 *** davterra has quit IRC
392020-01-23T03:12:38 *** SiAnDoG_ has quit IRC
402020-01-23T03:13:02 *** SiAnDoG_ has joined #bitcoin-core-dev
412020-01-23T03:17:48 *** rknLA1 has joined #bitcoin-core-dev
422020-01-23T03:26:34 *** tys0n_ has quit IRC
432020-01-23T03:54:03 *** felixfoertsch has joined #bitcoin-core-dev
442020-01-23T03:56:32 *** felixfoertsch23 has quit IRC
452020-01-23T04:02:53 *** SiAnDoG_ has quit IRC
462020-01-23T04:03:17 *** SiAnDoG_ has joined #bitcoin-core-dev
472020-01-23T04:06:53 *** pandorian has joined #bitcoin-core-dev
482020-01-23T04:17:23 *** promag has joined #bitcoin-core-dev
492020-01-23T04:22:02 *** promag has quit IRC
502020-01-23T04:22:39 *** Eagle[TM] has joined #bitcoin-core-dev
512020-01-23T04:24:43 *** EagleTM has quit IRC
522020-01-23T04:52:11 *** jeremyrubin has quit IRC
532020-01-23T05:27:23 *** ppisati has quit IRC
542020-01-23T05:30:18 *** rex4539 has quit IRC
552020-01-23T05:34:07 *** ppisati has joined #bitcoin-core-dev
562020-01-23T05:48:53 *** jeremyrubin has joined #bitcoin-core-dev
572020-01-23T05:52:52 *** justanotheruser has quit IRC
582020-01-23T05:53:34 *** VoidVextor0 has joined #bitcoin-core-dev
592020-01-23T05:54:49 *** justanotheruser has joined #bitcoin-core-dev
602020-01-23T05:57:43 *** pandorian has quit IRC
612020-01-23T06:00:02 *** rknLA1 has quit IRC
622020-01-23T06:15:40 *** VoidVextor0 has quit IRC
632020-01-23T06:16:27 *** pandorian has joined #bitcoin-core-dev
642020-01-23T06:17:16 *** patryk2 has joined #bitcoin-core-dev
652020-01-23T07:03:32 *** goatpig has joined #bitcoin-core-dev
662020-01-23T07:13:49 *** Eagle[TM] has quit IRC
672020-01-23T07:14:34 *** sipa has quit IRC
682020-01-23T07:14:49 *** sipa has joined #bitcoin-core-dev
692020-01-23T07:20:51 *** vasild has joined #bitcoin-core-dev
702020-01-23T07:23:43 *** vasild_ has quit IRC
712020-01-23T07:40:03 *** vasild_ has joined #bitcoin-core-dev
722020-01-23T07:43:23 *** vasild has quit IRC
732020-01-23T07:55:22 *** EagleTM has joined #bitcoin-core-dev
742020-01-23T07:58:32 *** icota[m] has quit IRC
752020-01-23T07:58:34 *** Isthmus has quit IRC
762020-01-23T07:58:41 *** provoostenator has quit IRC
772020-01-23T07:58:41 *** dr_orlovsky has quit IRC
782020-01-23T07:58:42 *** TheV01d has quit IRC
792020-01-23T07:58:42 *** jdmark has quit IRC
802020-01-23T07:58:42 *** wumpus has quit IRC
812020-01-23T07:58:42 *** ryanofsky has quit IRC
822020-01-23T07:58:42 *** asoltys has quit IRC
832020-01-23T07:58:42 *** stevenroose has quit IRC
842020-01-23T07:58:42 *** real_or_random has quit IRC
852020-01-23T07:58:43 *** CodeShark__ has quit IRC
862020-01-23T07:58:43 *** balbirs has quit IRC
872020-01-23T07:58:45 *** mrostecki[m] has quit IRC
882020-01-23T07:58:50 *** Lightsword has quit IRC
892020-01-23T07:58:50 *** TD-Linux has quit IRC
902020-01-23T07:58:50 *** Anduck has quit IRC
912020-01-23T07:58:50 *** nothingmuch has quit IRC
922020-01-23T07:58:50 *** nehan_ has quit IRC
932020-01-23T07:58:50 *** emzy has quit IRC
942020-01-23T07:58:50 *** raj_ has quit IRC
952020-01-23T07:58:50 *** dlb76 has quit IRC
962020-01-23T08:01:08 *** mael-rolland[m] has quit IRC
972020-01-23T08:01:10 *** fox2p has quit IRC
982020-01-23T08:01:56 *** DavidMitchell[m] has quit IRC
992020-01-23T08:01:56 *** transist0[m] has quit IRC
1002020-01-23T08:02:00 *** electric-sheep[m has quit IRC
1012020-01-23T08:02:24 *** EagleTM has quit IRC
1022020-01-23T08:02:28 *** castlenine[m] has quit IRC
1032020-01-23T08:02:53 *** real_or_random has joined #bitcoin-core-dev
1042020-01-23T08:02:53 *** CodeShark__ has joined #bitcoin-core-dev
1052020-01-23T08:02:53 *** balbirs has joined #bitcoin-core-dev
1062020-01-23T08:02:53 *** Lightsword has joined #bitcoin-core-dev
1072020-01-23T08:02:53 *** TD-Linux has joined #bitcoin-core-dev
1082020-01-23T08:02:53 *** Anduck has joined #bitcoin-core-dev
1092020-01-23T08:02:53 *** nothingmuch has joined #bitcoin-core-dev
1102020-01-23T08:02:53 *** nehan_ has joined #bitcoin-core-dev
1112020-01-23T08:02:53 *** emzy has joined #bitcoin-core-dev
1122020-01-23T08:02:53 *** raj_ has joined #bitcoin-core-dev
1132020-01-23T08:02:53 *** dlb76 has joined #bitcoin-core-dev
1142020-01-23T08:04:32 *** fox2p has joined #bitcoin-core-dev
1152020-01-23T08:09:36 *** manantial has quit IRC
1162020-01-23T08:10:17 *** promag has joined #bitcoin-core-dev
1172020-01-23T08:10:17 *** abrissbi1ne is now known as abrissbirne
1182020-01-23T08:11:24 *** manantial has joined #bitcoin-core-dev
1192020-01-23T08:12:49 *** promag_ has quit IRC
1202020-01-23T08:14:03 *** promag_ has joined #bitcoin-core-dev
1212020-01-23T08:14:26 *** spinza has quit IRC
1222020-01-23T08:14:55 *** promag has quit IRC
1232020-01-23T08:18:37 *** promag_ has quit IRC
1242020-01-23T08:23:27 *** VoidVextor0 has joined #bitcoin-core-dev
1252020-01-23T08:25:13 *** pandorian has quit IRC
1262020-01-23T08:30:03 *** morcos has quit IRC
1272020-01-23T08:30:26 *** morcos has joined #bitcoin-core-dev
1282020-01-23T08:30:41 *** spinza has joined #bitcoin-core-dev
1292020-01-23T08:45:38 *** Isthmus has joined #bitcoin-core-dev
1302020-01-23T08:45:38 *** provoostenator has joined #bitcoin-core-dev
1312020-01-23T08:45:38 *** dr_orlovsky has joined #bitcoin-core-dev
1322020-01-23T08:45:38 *** TheV01d has joined #bitcoin-core-dev
1332020-01-23T08:45:38 *** jdmark has joined #bitcoin-core-dev
1342020-01-23T08:45:38 *** wumpus has joined #bitcoin-core-dev
1352020-01-23T08:45:38 *** ryanofsky has joined #bitcoin-core-dev
1362020-01-23T08:45:38 *** asoltys has joined #bitcoin-core-dev
1372020-01-23T08:45:38 *** stevenroose has joined #bitcoin-core-dev
1382020-01-23T09:00:02 *** patryk2 has quit IRC
1392020-01-23T09:15:52 *** promag has joined #bitcoin-core-dev
1402020-01-23T09:17:07 *** c9sloud has joined #bitcoin-core-dev
1412020-01-23T09:27:43 *** Guyver2 has joined #bitcoin-core-dev
1422020-01-23T10:22:01 *** emilengler has joined #bitcoin-core-dev
1432020-01-23T10:23:14 *** pandorian has joined #bitcoin-core-dev
1442020-01-23T10:26:42 *** VoidVextor0 has quit IRC
1452020-01-23T10:31:11 *** EagleTM has joined #bitcoin-core-dev
1462020-01-23T10:34:24 *** belcher has quit IRC
1472020-01-23T10:37:47 *** zivl has joined #bitcoin-core-dev
1482020-01-23T10:42:14 *** jcoe has joined #bitcoin-core-dev
1492020-01-23T10:45:37 *** jcoe1 has joined #bitcoin-core-dev
1502020-01-23T10:47:14 *** jcoe has quit IRC
1512020-01-23T10:55:33 *** belcher has joined #bitcoin-core-dev
1522020-01-23T11:03:53 *** Reba49Hickle has joined #bitcoin-core-dev
1532020-01-23T11:15:41 *** vasild_ is now known as vasild
1542020-01-23T11:15:42 *** promag has quit IRC
1552020-01-23T11:29:35 *** jonatack has quit IRC
1562020-01-23T11:34:50 *** Reba49Hickle has quit IRC
1572020-01-23T11:37:01 *** promag_ has joined #bitcoin-core-dev
1582020-01-23T11:38:37 *** SiAnDoG_ has quit IRC
1592020-01-23T11:41:24 *** promag_ has quit IRC
1602020-01-23T11:44:46 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1612020-01-23T11:44:48 *** DavidMitchell[m] has joined #bitcoin-core-dev
1622020-01-23T11:44:52 *** electric-sheep[m has joined #bitcoin-core-dev
1632020-01-23T11:44:53 *** mael-rolland[m] has joined #bitcoin-core-dev
1642020-01-23T11:44:53 *** mrostecki[m]1 has joined #bitcoin-core-dev
1652020-01-23T11:44:54 *** transist0[m] has joined #bitcoin-core-dev
1662020-01-23T11:44:54 *** icota[m] has joined #bitcoin-core-dev
1672020-01-23T11:44:54 *** castlenine[m] has joined #bitcoin-core-dev
1682020-01-23T11:49:59 *** xabbix has joined #bitcoin-core-dev
1692020-01-23T11:52:22 <xabbix> Hi everyone. While syncing a new node, the message received in the rawtx subscription in ZMQ does not contain any identification for the block that the tx is included in. Why is that? Is it possible to include it in some way? (running with txindex=1)
1702020-01-23T11:55:11 <wumpus> I think it's because rawtx is *generally* meant for network transactions, not block transactions
1712020-01-23T11:55:28 *** Guyver2_ has joined #bitcoin-core-dev
1722020-01-23T11:55:39 <wumpus> IIRC transaction notification is even disabled during initial sync because there otherwise would be too many of them
1732020-01-23T11:57:37 <xabbix> wumpus Thanks. Looking for the most efficient way of syncing an external source with JSON data regarding transactions from block 0 to last. Any recommendations?
1742020-01-23T11:57:39 *** Guyver2 has quit IRC
1752020-01-23T11:59:13 *** tsujp has joined #bitcoin-core-dev
1762020-01-23T12:00:01 *** c9sloud has quit IRC
1772020-01-23T12:14:47 *** mrostecki[m]1 has quit IRC
1782020-01-23T12:17:27 *** chrippa has joined #bitcoin-core-dev
1792020-01-23T12:18:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1802020-01-23T12:22:25 *** jonatack has joined #bitcoin-core-dev
1812020-01-23T12:23:02 *** bitcoin-git has joined #bitcoin-core-dev
1822020-01-23T12:23:02 <bitcoin-git> [bitcoin] practicalswift opened pull request #17989: tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer. (master...fuzzers-net-process_message) https://github.com/bitcoin/bitcoin/pull/17989
1832020-01-23T12:23:13 *** bitcoin-git has left #bitcoin-core-dev
1842020-01-23T12:28:50 <wumpus> xabbix: probably the most efficient way is to request the blocks through the REST interface, in binary format is most efficient (IIRC they will be loaded from disk and sent out in raw without intermediate server-side decoding), but if you prefer it in JSON format that's a possibility too
1852020-01-23T12:34:51 *** tsujp has quit IRC
1862020-01-23T12:39:28 *** Chris_Stewart_5 has quit IRC
1872020-01-23T12:42:26 <wumpus> another way to get all the block data is the approach used in contrib/linearize/*.py, it requests only the block headers from the server then, using direct access to the block files, finds the blocks; I'm not sure if I can really recommend that, because there isn't really a guarantee that the format won't change at some point, but it can be really efficient
1882020-01-23T12:44:33 <xabbix> wumpus Thanks for all the help, I'll look into both approaches
1892020-01-23T12:44:33 *** jonatack has quit IRC
1902020-01-23T12:53:46 *** Guyver2_ has quit IRC
1912020-01-23T12:59:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1922020-01-23T13:11:12 *** TheRec has quit IRC
1932020-01-23T13:22:11 *** jonatack has joined #bitcoin-core-dev
1942020-01-23T13:27:14 *** bitcoin-git has joined #bitcoin-core-dev
1952020-01-23T13:27:14 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17991: Add vcpkg custom port files (master...vcpkg-ports) https://github.com/bitcoin/bitcoin/pull/17991
1962020-01-23T13:27:15 *** bitcoin-git has left #bitcoin-core-dev
1972020-01-23T13:34:33 *** bitcoin-git has joined #bitcoin-core-dev
1982020-01-23T13:34:33 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/4cf73504220e...1299a1a11f9b
1992020-01-23T13:34:33 <bitcoin-git> bitcoin/0.19 1299a1a Wladimir J. van der Laan: qt: Translations update pre-rc1
2002020-01-23T13:34:35 *** bitcoin-git has left #bitcoin-core-dev
2012020-01-23T13:58:41 *** xabbix has quit IRC
2022020-01-23T13:59:12 *** IGHOR has quit IRC
2032020-01-23T14:00:22 *** IGHOR has joined #bitcoin-core-dev
2042020-01-23T14:07:38 *** fox2p has quit IRC
2052020-01-23T14:09:55 *** fox2p has joined #bitcoin-core-dev
2062020-01-23T14:11:14 *** bitcoin-git has joined #bitcoin-core-dev
2072020-01-23T14:11:15 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/1299a1a11f9b...1b0afb71a2ad
2082020-01-23T14:11:16 <bitcoin-git> bitcoin/0.19 c3cb602 Wladimir J. van der Laan: build: Bump version to 0.19.1rc1
2092020-01-23T14:11:17 <bitcoin-git> bitcoin/0.19 1b0afb7 Wladimir J. van der Laan: doc: Manpage updates for 0.19.1rc1
2102020-01-23T14:11:19 *** bitcoin-git has left #bitcoin-core-dev
2112020-01-23T14:12:50 *** TheRec has joined #bitcoin-core-dev
2122020-01-23T14:12:50 *** TheRec has joined #bitcoin-core-dev
2132020-01-23T14:21:43 *** TheRec has quit IRC
2142020-01-23T14:23:10 *** SiAnDoG_ has joined #bitcoin-core-dev
2152020-01-23T14:24:04 *** EagleTM has quit IRC
2162020-01-23T14:39:57 *** jcoe1 has quit IRC
2172020-01-23T14:47:01 *** bitcoin-git has joined #bitcoin-core-dev
2182020-01-23T14:47:02 <bitcoin-git> [bitcoin] darosior opened pull request #17992: Correct a small typo in help / manpage (master...typo) https://github.com/bitcoin/bitcoin/pull/17992
2192020-01-23T14:47:13 *** bitcoin-git has left #bitcoin-core-dev
2202020-01-23T15:00:02 *** chrippa has quit IRC
2212020-01-23T15:01:55 *** goatpig has quit IRC
2222020-01-23T15:03:46 *** wedw has joined #bitcoin-core-dev
2232020-01-23T15:10:22 *** jonatack has quit IRC
2242020-01-23T15:16:14 *** promag has joined #bitcoin-core-dev
2252020-01-23T15:17:25 *** rule32 has joined #bitcoin-core-dev
2262020-01-23T15:23:11 *** promag has quit IRC
2272020-01-23T15:23:34 *** promag has joined #bitcoin-core-dev
2282020-01-23T15:28:22 *** jonatack has joined #bitcoin-core-dev
2292020-01-23T15:39:15 *** Guyver2 has joined #bitcoin-core-dev
2302020-01-23T15:40:50 *** jonatack has quit IRC
2312020-01-23T15:51:53 *** goatpig has joined #bitcoin-core-dev
2322020-01-23T15:53:27 *** bitcoin-git has joined #bitcoin-core-dev
2332020-01-23T15:53:27 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7a311fa54a93...fe3b58b95955
2342020-01-23T15:53:28 <bitcoin-git> bitcoin/master 2fa8dc5 darosior: src/init: correct a typo
2352020-01-23T15:53:28 <bitcoin-git> bitcoin/master fe3b58b Wladimir J. van der Laan: Merge #17992: doc: Correct a small typo in help / manpage
2362020-01-23T15:53:30 *** bitcoin-git has left #bitcoin-core-dev
2372020-01-23T15:53:47 *** bitcoin-git has joined #bitcoin-core-dev
2382020-01-23T15:53:47 <bitcoin-git> [bitcoin] laanwj merged pull request #17992: doc: Correct a small typo in help / manpage (master...typo) https://github.com/bitcoin/bitcoin/pull/17992
2392020-01-23T15:53:48 *** bitcoin-git has left #bitcoin-core-dev
2402020-01-23T16:04:47 *** promag has quit IRC
2412020-01-23T16:15:07 *** Talkless has joined #bitcoin-core-dev
2422020-01-23T16:16:59 *** tys0n_ has joined #bitcoin-core-dev
2432020-01-23T16:36:02 *** rex4539 has joined #bitcoin-core-dev
2442020-01-23T16:39:21 *** Talkless has quit IRC
2452020-01-23T17:00:50 *** jonatack has joined #bitcoin-core-dev
2462020-01-23T17:02:47 *** ddustin has joined #bitcoin-core-dev
2472020-01-23T17:23:25 *** promag has joined #bitcoin-core-dev
2482020-01-23T17:26:06 *** ddustin has quit IRC
2492020-01-23T17:26:56 *** ddustin has joined #bitcoin-core-dev
2502020-01-23T17:28:20 *** promag has quit IRC
2512020-01-23T17:31:14 *** ddustin has quit IRC
2522020-01-23T17:34:10 *** ddustin has joined #bitcoin-core-dev
2532020-01-23T17:39:58 *** ddustin has quit IRC
2542020-01-23T18:00:01 *** rule32 has quit IRC
2552020-01-23T18:16:41 *** Chris_Stewart_5 has quit IRC
2562020-01-23T18:17:24 *** Lestaty has joined #bitcoin-core-dev
2572020-01-23T18:17:44 *** Lestaty is now known as Guest98773
2582020-01-23T18:35:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2592020-01-23T18:39:25 *** bitcoin-git has joined #bitcoin-core-dev
2602020-01-23T18:39:25 <bitcoin-git> [bitcoin] furszy opened pull request #17993: gui: Avoid redundant cs_main locks in balance polling. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
2612020-01-23T18:39:26 *** bitcoin-git has left #bitcoin-core-dev
2622020-01-23T18:41:58 *** promag has joined #bitcoin-core-dev
2632020-01-23T18:46:35 *** promag has quit IRC
2642020-01-23T19:02:23 <emilengler> no meeting today?
2652020-01-23T19:02:42 <wumpus> #startmeeting
2662020-01-23T19:02:42 <lightningbot> Meeting started Thu Jan 23 19:02:42 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2672020-01-23T19:02:42 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2682020-01-23T19:03:02 <sipsorcery> hi
2692020-01-23T19:03:05 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
2702020-01-23T19:03:06 <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
2712020-01-23T19:03:08 <emilengler> hi
2722020-01-23T19:03:09 <achow101> hi
2732020-01-23T19:03:11 <hebasto> hi
2742020-01-23T19:03:14 <amiti> hi
2752020-01-23T19:03:19 <jonatack> hi
2762020-01-23T19:03:36 <fjahr> hi
2772020-01-23T19:03:47 <wumpus> no proposed topics for today on https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
2782020-01-23T19:03:47 <gwillen> hi
2792020-01-23T19:03:51 <wumpus> any last minute suggestions?
2802020-01-23T19:03:57 <sipa> hi
2812020-01-23T19:04:00 <emilengler> wumpus: yes
2822020-01-23T19:04:13 <emilengler> let me find just find the PR number
2832020-01-23T19:04:37 <wumpus> PSA: we're planning to tag the 0.19.1 rc1 right after the meeting, after merging the final backports (#17988)
2842020-01-23T19:04:39 <gribble> https://github.com/bitcoin/bitcoin/issues/17988 | [0.19] Final backports for 0.19.1 by fanquake · Pull Request #17988 · bitcoin/bitcoin · GitHub
2852020-01-23T19:04:43 <emilengler> There we go, #17453
2862020-01-23T19:04:46 <gribble> https://github.com/bitcoin/bitcoin/issues/17453 | gui: Fix intro dialog labels when the prune button is toggled by hebasto · Pull Request #17453 · bitcoin/bitcoin · GitHub
2872020-01-23T19:05:05 <wumpus> anything specific you'd like to discuss about that?
2882020-01-23T19:05:06 <emilengler> It isn't that important and also probably too late but I think this PR should get into the code sooner or later
2892020-01-23T19:05:19 <wumpus> ohh just a review beg :D
2902020-01-23T19:05:23 <emilengler> It was already said some time ago that it should get into 0.19.1
2912020-01-23T19:05:52 <emilengler> I was more asking what's the current state of it
2922020-01-23T19:07:36 <wumpus> ok, looks like it has some ACKs, should me merged soon, but I guess it's too late for 0.19.1
2932020-01-23T19:07:51 <hebasto> I'd rather wait for jonasschnelli's ACK
2942020-01-23T19:07:55 <wumpus> it should have had a 0.19 (backport) label
2952020-01-23T19:07:59 <wumpus> right
2962020-01-23T19:08:14 <wumpus> #topic High priority for review
2972020-01-23T19:08:21 <emilengler> Its predecessor had it (#17035)
2982020-01-23T19:08:26 <gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler · Pull Request #17035 · bitcoin/bitcoin · GitHub
2992020-01-23T19:08:41 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 6 chasing concept ACK right now
3002020-01-23T19:09:52 <wumpus> anything to add/remove, or is ready for merge?
3012020-01-23T19:11:50 <wumpus> #17957 seems pretty close
3022020-01-23T19:11:53 <gribble> https://github.com/bitcoin/bitcoin/issues/17957 | Serialization improvements step 3 (compression.h) by sipa · Pull Request #17957 · bitcoin/bitcoin · GitHub
3032020-01-23T19:12:01 <wumpus> also #16702
3042020-01-23T19:12:04 <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
3052020-01-23T19:12:44 <wumpus> though jamesob had some new review comments, I think most of those can be done in follow-up PRs
3062020-01-23T19:13:28 <wumpus> there's also alredy #17812
3072020-01-23T19:13:30 <gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, test: asmap functional tests and feature refinements by jonatack · Pull Request #17812 · bitcoin/bitcoin · GitHub
3082020-01-23T19:14:13 <jonatack> yes - i have some questions on the unit tests to discuss with gleb, and will update the follow-up this weekend
3092020-01-23T19:15:27 <wumpus> #17737 has one ACK, I've been looking at it and will likely ACK it soon too, but it could use some more review still
3102020-01-23T19:15:28 <jonatack> (+1 on getting it in soon)
3112020-01-23T19:15:30 <gribble> https://github.com/bitcoin/bitcoin/issues/17737 | Add ChainstateManager, remove BlockManager global by jamesob · Pull Request #17737 · bitcoin/bitcoin · GitHub
3122020-01-23T19:15:57 <wumpus> jonatack: thanks, yes there's been some more questions about the unit tests, there's some functions (like the interpreter function) that are not tested directly and probably should
3132020-01-23T19:16:23 <wumpus> then again, this could all be added later, I have the idea it would be good to get the basic functionality in soon so iteration can be quicker
3142020-01-23T19:16:35 <jamesob> wumpus (and anyone else): thanks for the review
3152020-01-23T19:17:11 <jonatack> yes, will review https://github.com/sipa/asmap/pull/2 by jamesob
3162020-01-23T19:17:46 <wumpus> #16974 seems ready for merge
3172020-01-23T19:17:47 <gribble> https://github.com/bitcoin/bitcoin/issues/16974 | Walk pindexBestHeader back to ChainActive().Tip() if it is invalid by TheBlueMatt · Pull Request #16974 · bitcoin/bitcoin · GitHub
3182020-01-23T19:17:50 <wumpus> lots of (ut)ACKs
3192020-01-23T19:18:26 <wumpus> #16442 gives me the good old unicorn
3202020-01-23T19:18:31 <gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo · Pull Request #16442 · bitcoin/bitcoin · GitHub
3212020-01-23T19:19:09 <jamesob> re: 16442: I think gleb and ariard have some concept concerns that should be articulated somewhere at some point
3222020-01-23T19:19:12 <wumpus> ah, works not, that one has a lot of open comments still and no ACKs
3232020-01-23T19:20:26 <jamesob> the gist of which is, as far as I can tell, that neutrino is sort of useless for lightning because for sybil-resistance, lightning users need to verify all channel openings on-chain, which would result in downloading every incoming block anyway. but this is probably out of scope for this meeting
3242020-01-23T19:20:39 <wumpus> okay, yes, would be good to discuss concept concerns first before spending a lot of time reviewing code details
3252020-01-23T19:21:14 <sipa> jamesob: that sounds like a discussion for the ML
3262020-01-23T19:21:31 <jamesob> agreed
3272020-01-23T19:21:36 <wumpus> good point
3282020-01-23T19:22:45 <wumpus> ok then there is fanquake's MacOS toolchain update (#16392) which should be straightforward, but I think it's held up on a non-MacoSX way to extract the SDK, not so much review
3292020-01-23T19:22:46 *** promag has joined #bitcoin-core-dev
3302020-01-23T19:22:48 <gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake · Pull Request #16392 · bitcoin/bitcoin · GitHub
3312020-01-23T19:24:06 <wumpus> #16411 just needs more review
3322020-01-23T19:24:11 <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
3332020-01-23T19:24:12 <wumpus> I think that was all of them
3342020-01-23T19:24:34 <wumpus> ah no forgot #17261
3352020-01-23T19:24:39 <gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 · Pull Request #17261 · bitcoin/bitcoin · GitHub
3362020-01-23T19:25:07 *** gleb has left #bitcoin-core-dev
3372020-01-23T19:25:10 *** gleb has joined #bitcoin-core-dev
3382020-01-23T19:25:14 <instagibbs> that one is getting close hopefully
3392020-01-23T19:25:36 <wumpus> seems it has ACKs, if my comment isn't really an issue then it can be merged soon
3402020-01-23T19:25:58 <wumpus> I'm really not sure about non-primitive constants in header files in C++
3412020-01-23T19:26:25 <wumpus> https://github.com/bitcoin/bitcoin/pull/17261#pullrequestreview-345490342 this used to be a problem at some point, but maybe not anymore
3422020-01-23T19:27:18 <wumpus> at least in the rest of our code we define string etc constants in the cpp and only reference them in the header
3432020-01-23T19:27:21 <achow101> wouldn't a simple test of printing out the memory address of that constant resolve it?
3442020-01-23T19:27:33 <wumpus> that only proves it for one compiler
3452020-01-23T19:27:43 *** promag has quit IRC
3462020-01-23T19:27:47 <wumpus> or linker
3472020-01-23T19:28:16 <wumpus> but yeah it's a wayâ¦
3482020-01-23T19:28:52 <wumpus> any other topics?
3492020-01-23T19:29:10 <kanzure> just another request for topics for upcoming physical meeting
3502020-01-23T19:29:38 <wumpus> #action send topic suggestions for upcoming physical meeting to kanzure
3512020-01-23T19:29:48 <kanzure> basically, topics that you would like to hear about or you talk about
3522020-01-23T19:30:04 <kanzure> not mandatory, but it does help organize and figure out how much stuff is on everyone's minds
3532020-01-23T19:31:01 <wumpus> #endmeeting
3542020-01-23T19:31:01 <lightningbot> Meeting ended Thu Jan 23 19:31:01 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3552020-01-23T19:31:01 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.html
3562020-01-23T19:31:01 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.txt
3572020-01-23T19:31:01 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-23-19.02.log.html
3582020-01-23T19:33:26 <hebasto> emilengler: mind adding a commit reference to your ack - https://github.com/bitcoin/bitcoin/pull/17453#issuecomment-576402317
3592020-01-23T19:41:42 *** jeremyrubin has quit IRC
3602020-01-23T19:42:33 *** jeremyrubin has joined #bitcoin-core-dev
3612020-01-23T19:43:03 *** vasild has quit IRC
3622020-01-23T19:45:06 *** vasild has joined #bitcoin-core-dev
3632020-01-23T19:45:54 *** filchef has joined #bitcoin-core-dev
3642020-01-23T19:49:20 <wumpus> going to tag 0.19.1rc1 in a bit
3652020-01-23T19:49:38 *** bitcoin-git has joined #bitcoin-core-dev
3662020-01-23T19:49:40 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/1b0afb71a2ad...178a8346871e
3672020-01-23T19:49:41 <bitcoin-git> bitcoin/0.19 c8ad23c Karl-Johan Alm: bug-fix macos: give free bytes to F_PREALLOCATE
3682020-01-23T19:49:42 <bitcoin-git> bitcoin/0.19 daf2fff Karl-Johan Alm: test: add missing #include to fix compiler errors
3692020-01-23T19:49:43 <bitcoin-git> bitcoin/0.19 178a834 Wladimir J. van der Laan: Merge #17988: [0.19] Final backports for 0.19.1
3702020-01-23T19:49:45 *** bitcoin-git has left #bitcoin-core-dev
3712020-01-23T19:50:03 *** bitcoin-git has joined #bitcoin-core-dev
3722020-01-23T19:50:04 <bitcoin-git> [bitcoin] laanwj merged pull request #17988: [0.19] Final backports for 0.19.1 (0.19...0-19-1-final-backports) https://github.com/bitcoin/bitcoin/pull/17988
3732020-01-23T19:50:04 *** bitcoin-git has left #bitcoin-core-dev
3742020-01-23T19:51:58 <MarcoFalke> wumpus: Are you going to create the list of pulls in the release notes?
3752020-01-23T19:52:09 <MarcoFalke> There was a missing author, which should be added
3762020-01-23T19:52:54 <MarcoFalke> From the discussion in #17258, mchrostowski should be added
3772020-01-23T19:52:58 <gribble> https://github.com/bitcoin/bitcoin/issues/17258 | Fix issue with conflicted mempool tx in listsinceblock by adamjonas · Pull Request #17258 · bitcoin/bitcoin · GitHub
3782020-01-23T19:57:35 *** jeremyrubin has quit IRC
3792020-01-23T19:58:01 *** jeremyrubin has joined #bitcoin-core-dev
3802020-01-23T19:59:56 <wumpus> MarcoFalke: yes, I'm going toâthanks, will keep that in mind
3812020-01-23T20:00:21 <MarcoFalke> thx
3822020-01-23T20:05:03 <emilengler> hebasto: Which should I ACK?
3832020-01-23T20:05:14 <emilengler> I would prefer to ACK a final squashed commit
3842020-01-23T20:05:24 <emilengler> Thats the reason why I asked for the sqash btw
3852020-01-23T20:05:40 <emilengler> But otherwise I will ACK HEAD~1
3862020-01-23T20:11:39 <wumpus> you should always ACK HEAD
3872020-01-23T20:12:44 <wumpus> at least, the topmost commit, this implies you ACK everything below it too
3882020-01-23T20:14:51 <jonatack> emilengler: review locally (not on GitHub, use it only for reading/writing comments) which makes it easy to simply use the topmost (HEAD) commit hash in the PR branch you pulled locally, for the ack commit
3892020-01-23T20:16:19 *** kvaciral has joined #bitcoin-core-dev
3902020-01-23T20:16:19 <jonatack> see https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#technical-specifics
3912020-01-23T20:16:22 <jonatack> or https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#reference-prs-easily-with-refspecs
3922020-01-23T20:16:52 <jonatack> or https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally
3932020-01-23T20:21:01 *** promag has joined #bitcoin-core-dev
3942020-01-23T20:21:10 *** owowo has quit IRC
3952020-01-23T20:22:02 *** fox2p has quit IRC
3962020-01-23T20:24:14 *** orlovsky has quit IRC
3972020-01-23T20:24:54 *** dr-orlovsky has joined #bitcoin-core-dev
3982020-01-23T20:25:00 *** fox2p has joined #bitcoin-core-dev
3992020-01-23T20:25:36 *** bitcoin-git has joined #bitcoin-core-dev
4002020-01-23T20:25:36 <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.1rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.1rc1
4012020-01-23T20:25:49 *** bitcoin-git has left #bitcoin-core-dev
4022020-01-23T20:26:01 *** promag has quit IRC
4032020-01-23T20:26:01 *** owowo has joined #bitcoin-core-dev
4042020-01-23T20:26:01 *** owowo has joined #bitcoin-core-dev
4052020-01-23T20:43:16 *** EagleTM has joined #bitcoin-core-dev
4062020-01-23T20:50:48 *** promag has joined #bitcoin-core-dev
4072020-01-23T20:55:23 *** promag has quit IRC
4082020-01-23T20:58:04 *** goatpig has quit IRC
4092020-01-23T21:00:01 *** Guest98773 has quit IRC
4102020-01-23T21:05:29 *** emilengler has quit IRC
4112020-01-23T21:17:00 *** LaserShark has joined #bitcoin-core-dev
4122020-01-23T21:18:20 *** filchef has quit IRC
4132020-01-23T21:18:20 *** manantial has quit IRC
4142020-01-23T21:18:20 *** Highway61 has quit IRC
4152020-01-23T21:18:21 *** ctrlbreak has quit IRC
4162020-01-23T21:18:21 *** willcl_ark has quit IRC
4172020-01-23T21:18:21 *** tryphe has quit IRC
4182020-01-23T21:18:21 *** gribble has quit IRC
4192020-01-23T21:18:21 *** niska has quit IRC
4202020-01-23T21:18:22 *** jkczyz has quit IRC
4212020-01-23T21:18:22 *** votesmith has quit IRC
4222020-01-23T21:20:59 *** warren_ has quit IRC
4232020-01-23T21:22:02 *** tryphe has joined #bitcoin-core-dev
4242020-01-23T21:22:04 *** ctrlbreak has joined #bitcoin-core-dev
4252020-01-23T21:22:15 *** manantial has joined #bitcoin-core-dev
4262020-01-23T21:24:48 *** warren has joined #bitcoin-core-dev
4272020-01-23T21:25:38 *** jkczyz has joined #bitcoin-core-dev
4282020-01-23T21:32:54 *** gribble has joined #bitcoin-core-dev
4292020-01-23T21:33:08 *** justan0theruser has joined #bitcoin-core-dev
4302020-01-23T21:33:23 *** justanotheruser has quit IRC
4312020-01-23T21:33:29 *** bitcoin-git has joined #bitcoin-core-dev
4322020-01-23T21:33:29 <bitcoin-git> [bitcoin] dongcarl closed pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519
4332020-01-23T21:33:31 *** bitcoin-git has left #bitcoin-core-dev
4342020-01-23T21:33:38 <fanquake> wumpus #16392 mostly held up by getting the 10.14 SDK up somewhere for Travis and the gitian build bot
4352020-01-23T21:34:14 <gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake · Pull Request #16392 · bitcoin/bitcoin · GitHub
4362020-01-23T21:34:16 *** TheRec has joined #bitcoin-core-dev
4372020-01-23T21:34:16 *** TheRec has joined #bitcoin-core-dev
4382020-01-23T21:34:30 <fanquake> The non-macOS extraction works, but is just a bit of a mess around. Obviously getting the SDK not necessarily straight forward either.
4392020-01-23T21:42:34 *** Chris_Stewart_5 has quit IRC
4402020-01-23T21:46:39 *** tys0n_ has quit IRC
4412020-01-23T21:50:13 *** IGHOR has quit IRC
4422020-01-23T21:50:28 *** jonatack has quit IRC
4432020-01-23T21:51:49 *** IGHOR has joined #bitcoin-core-dev
4442020-01-23T21:59:06 *** jonatack has joined #bitcoin-core-dev
4452020-01-23T22:01:41 *** filchef has joined #bitcoin-core-dev
4462020-01-23T22:01:41 *** Highway61 has joined #bitcoin-core-dev
4472020-01-23T22:01:41 *** willcl_ark has joined #bitcoin-core-dev
4482020-01-23T22:01:41 *** niska has joined #bitcoin-core-dev
4492020-01-23T22:01:41 *** votesmith has joined #bitcoin-core-dev
4502020-01-23T22:04:16 *** Highway62 has joined #bitcoin-core-dev
4512020-01-23T22:04:45 *** Highway61 has quit IRC
4522020-01-23T22:04:45 *** Highway62 is now known as Highway61
4532020-01-23T22:07:29 *** millerti has joined #bitcoin-core-dev
4542020-01-23T22:29:30 *** filchef has quit IRC
4552020-01-23T23:13:34 *** SiAnDoG_ has quit IRC
4562020-01-23T23:13:43 *** SiAnDoG_ has joined #bitcoin-core-dev
4572020-01-23T23:14:02 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4582020-01-23T23:33:02 *** Guyver2 has quit IRC
4592020-01-23T23:33:08 *** Zenton has quit IRC
4602020-01-23T23:49:29 *** Chris_Stewart_5 has quit IRC