12020-01-28T00:00:01 *** Alex3 has quit IRC
22020-01-28T00:06:29 *** sipsorcery has quit IRC
32020-01-28T00:15:11 *** diogosergio has quit IRC
42020-01-28T00:17:05 *** willmoffat has joined #bitcoin-core-dev
52020-01-28T00:23:10 *** sipsorcery has joined #bitcoin-core-dev
62020-01-28T00:33:16 *** Krellan_ has joined #bitcoin-core-dev
72020-01-28T00:34:37 *** Dean_Guss has joined #bitcoin-core-dev
82020-01-28T00:36:32 *** DeanWeen has quit IRC
92020-01-28T00:54:58 *** justanotheruser has quit IRC
102020-01-28T01:01:35 *** sipsorcery has quit IRC
112020-01-28T01:08:07 *** Krellan_ has quit IRC
122020-01-28T01:11:05 *** justanotheruser has joined #bitcoin-core-dev
132020-01-28T01:28:23 *** vasild has quit IRC
142020-01-28T01:30:11 *** vasild has joined #bitcoin-core-dev
152020-01-28T01:43:36 *** belcher has quit IRC
162020-01-28T01:44:15 *** lnostdal has joined #bitcoin-core-dev
172020-01-28T02:11:34 *** diogosergio has joined #bitcoin-core-dev
182020-01-28T02:14:01 *** AaronvanW has quit IRC
192020-01-28T02:16:18 *** diogosergio has quit IRC
202020-01-28T02:46:29 *** dr-orlovsky has quit IRC
212020-01-28T02:47:34 *** dr-orlovsky has joined #bitcoin-core-dev
222020-01-28T03:00:02 *** willmoffat has quit IRC
232020-01-28T03:01:14 *** abrissbi1ne has joined #bitcoin-core-dev
242020-01-28T03:04:26 *** abrissbirne has quit IRC
252020-01-28T03:11:35 *** diogosergio has joined #bitcoin-core-dev
262020-01-28T03:16:26 *** diogosergio has quit IRC
272020-01-28T03:16:30 *** zyga1 has joined #bitcoin-core-dev
282020-01-28T03:20:07 *** SiAnDoG__ has quit IRC
292020-01-28T03:20:25 *** SiAnDoG__ has joined #bitcoin-core-dev
302020-01-28T03:37:24 *** Krellan_ has joined #bitcoin-core-dev
312020-01-28T03:50:18 *** felixfoertsch has joined #bitcoin-core-dev
322020-01-28T03:51:00 *** felixfoertsch23 has quit IRC
332020-01-28T04:11:20 *** EagleTM has quit IRC
342020-01-28T04:11:24 *** Eagle[TM] has joined #bitcoin-core-dev
352020-01-28T04:11:34 *** Krellan_ has quit IRC
362020-01-28T04:12:05 *** Krellan_ has joined #bitcoin-core-dev
372020-01-28T04:16:10 *** Soligor has quit IRC
382020-01-28T04:21:24 *** Soligor has joined #bitcoin-core-dev
392020-01-28T05:03:09 *** cryptapus has quit IRC
402020-01-28T06:00:01 *** zyga1 has quit IRC
412020-01-28T06:17:40 *** pwgn has joined #bitcoin-core-dev
422020-01-28T06:25:51 *** mryandao has quit IRC
432020-01-28T06:27:05 *** mryandao has joined #bitcoin-core-dev
442020-01-28T06:41:47 *** BlueMatt has quit IRC
452020-01-28T06:42:02 *** BlueMatt has joined #bitcoin-core-dev
462020-01-28T06:57:09 *** abrissbi1ne is now known as abrissbirne
472020-01-28T07:19:14 *** Eagle[TM] has quit IRC
482020-01-28T07:20:41 *** sipsorcery has joined #bitcoin-core-dev
492020-01-28T07:29:06 *** goatpig has joined #bitcoin-core-dev
502020-01-28T07:39:17 *** tecnecio_ has joined #bitcoin-core-dev
512020-01-28T07:43:23 *** vasild has quit IRC
522020-01-28T07:45:00 *** vasild has joined #bitcoin-core-dev
532020-01-28T07:47:59 *** Soligor has quit IRC
542020-01-28T07:48:27 *** Soligor has joined #bitcoin-core-dev
552020-01-28T08:03:48 *** real_or_random has quit IRC
562020-01-28T08:11:05 *** promag has quit IRC
572020-01-28T08:11:19 *** promag has joined #bitcoin-core-dev
582020-01-28T08:16:52 *** Guyver2 has joined #bitcoin-core-dev
592020-01-28T08:17:19 *** promag has quit IRC
602020-01-28T08:23:12 *** promag has joined #bitcoin-core-dev
612020-01-28T08:24:14 *** Blaz has joined #bitcoin-core-dev
622020-01-28T08:27:38 *** promag has quit IRC
632020-01-28T08:52:53 *** promag has joined #bitcoin-core-dev
642020-01-28T08:57:23 *** promag has quit IRC
652020-01-28T09:00:01 *** pwgn has quit IRC
662020-01-28T09:01:16 *** kljasdfvv has quit IRC
672020-01-28T09:03:06 *** kljasdfvv has joined #bitcoin-core-dev
682020-01-28T09:15:02 *** Guyver2 has quit IRC
692020-01-28T09:15:28 *** bitcoin-git has joined #bitcoin-core-dev
702020-01-28T09:15:29 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b89f2d059937...3774281327c8
712020-01-28T09:15:30 <bitcoin-git> bitcoin/master e605088 Carl Dong: guix: Pin Guix using `guix time-machine`
722020-01-28T09:15:30 <bitcoin-git> bitcoin/master 88c8363 Carl Dong: guix: Update documentation for time-machine
732020-01-28T09:15:31 <bitcoin-git> bitcoin/master 3774281 fanquake: Merge #17933: guix: Pin Guix using `guix time-machine`
742020-01-28T09:15:33 *** bitcoin-git has left #bitcoin-core-dev
752020-01-28T09:15:48 *** bitcoin-git has joined #bitcoin-core-dev
762020-01-28T09:15:48 <bitcoin-git> [bitcoin] fanquake merged pull request #17933: guix: Pin Guix using `guix time-machine` (master...2020-01-guix-time-machine) https://github.com/bitcoin/bitcoin/pull/17933
772020-01-28T09:15:49 *** bitcoin-git has left #bitcoin-core-dev
782020-01-28T09:17:17 *** popey1 has joined #bitcoin-core-dev
792020-01-28T09:21:33 *** promag has joined #bitcoin-core-dev
802020-01-28T09:32:01 *** dr-orlovsky has quit IRC
812020-01-28T09:36:29 *** Zenton has joined #bitcoin-core-dev
822020-01-28T09:47:32 *** diogosergio has joined #bitcoin-core-dev
832020-01-28T09:52:33 *** diogosergio has quit IRC
842020-01-28T10:03:24 *** jdmark has quit IRC
852020-01-28T10:05:59 *** dr-orlovsky has joined #bitcoin-core-dev
862020-01-28T10:07:42 *** Blaz has quit IRC
872020-01-28T10:26:31 *** bitcoin-git has joined #bitcoin-core-dev
882020-01-28T10:26:31 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3774281327c8...2755b2b1092d
892020-01-28T10:26:32 <bitcoin-git> bitcoin/master b3c4d9b Sebastian Falbesoner: test: rename test suite name "tx_validationcache_tests" to match filename
902020-01-28T10:26:33 <bitcoin-git> bitcoin/master 2755b2b fanquake: Merge #18010: test: rename test suite name "tx_validationcache_tests" to m...
912020-01-28T10:26:34 *** bitcoin-git has left #bitcoin-core-dev
922020-01-28T10:26:54 *** bitcoin-git has joined #bitcoin-core-dev
932020-01-28T10:26:54 <bitcoin-git> [bitcoin] fanquake merged pull request #18010: test: rename test suite name "tx_validationcache_tests" to match filename (master...20200127-test-adapt-test-suite-names-to-file-names) https://github.com/bitcoin/bitcoin/pull/18010
942020-01-28T10:26:55 *** bitcoin-git has left #bitcoin-core-dev
952020-01-28T10:38:46 <provoostenator> valgrind
962020-01-28T10:39:11 *** belcher has joined #bitcoin-core-dev
972020-01-28T10:39:14 <provoostenator> Update on the valgrind mystery in #15382; it appears it doesn't like "echo"
982020-01-28T10:39:17 <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
992020-01-28T10:40:50 *** AaronvanW has joined #bitcoin-core-dev
1002020-01-28T10:41:06 *** bitcoin-git has joined #bitcoin-core-dev
1012020-01-28T10:41:07 <bitcoin-git> [bitcoin] Bushstar opened pull request #18012: GBT segwit rule in RPC error msg missing single quotes (master...patch-5) https://github.com/bitcoin/bitcoin/pull/18012
1022020-01-28T10:41:08 *** bitcoin-git has left #bitcoin-core-dev
1032020-01-28T10:42:46 <provoostenator> echo also handles quotes differently between Windows and Linux, so I probably need an alternative incantation for that test anyway.
1042020-01-28T11:00:17 *** timothy has joined #bitcoin-core-dev
1052020-01-28T11:03:56 *** Agustina73Watsic has joined #bitcoin-core-dev
1062020-01-28T11:08:42 *** jcoe has joined #bitcoin-core-dev
1072020-01-28T11:32:28 *** hsmiths has quit IRC
1082020-01-28T11:32:45 *** hsmiths has joined #bitcoin-core-dev
1092020-01-28T11:35:29 *** alec_ is now known as alec
1102020-01-28T11:37:48 *** dr-orlovsky has quit IRC
1112020-01-28T11:37:57 *** orlovsky has joined #bitcoin-core-dev
1122020-01-28T11:43:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1132020-01-28T11:46:02 *** orlovsky has quit IRC
1142020-01-28T11:47:35 *** dr-orlovsky has joined #bitcoin-core-dev
1152020-01-28T11:48:49 *** diogosergio has joined #bitcoin-core-dev
1162020-01-28T11:52:36 *** Agustina73Watsic has quit IRC
1172020-01-28T11:54:02 *** diogosergio has quit IRC
1182020-01-28T11:58:46 *** orlovsky has joined #bitcoin-core-dev
1192020-01-28T12:00:02 *** popey1 has quit IRC
1202020-01-28T12:00:21 *** dr-orlovsky has quit IRC
1212020-01-28T12:15:19 *** rob01 has joined #bitcoin-core-dev
1222020-01-28T12:21:59 *** thelounge2467250 has quit IRC
1232020-01-28T12:22:37 *** thelounge2467250 has joined #bitcoin-core-dev
1242020-01-28T12:36:11 *** jamesob has quit IRC
1252020-01-28T12:36:27 *** jamesob has joined #bitcoin-core-dev
1262020-01-28T12:53:03 *** Chris_Stewart_5 has quit IRC
1272020-01-28T12:53:28 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1282020-01-28T12:55:12 *** jcoe1 has joined #bitcoin-core-dev
1292020-01-28T12:55:45 *** jcoe has quit IRC
1302020-01-28T13:02:01 *** zac94 has joined #bitcoin-core-dev
1312020-01-28T13:08:06 *** promag has quit IRC
1322020-01-28T13:09:23 *** rob01 has quit IRC
1332020-01-28T13:12:46 *** rodarmor has quit IRC
1342020-01-28T13:13:02 *** rodarmor has joined #bitcoin-core-dev
1352020-01-28T13:15:28 *** tryphe_ has joined #bitcoin-core-dev
1362020-01-28T13:18:31 *** tecnecio_ has quit IRC
1372020-01-28T13:18:43 *** tryphe has quit IRC
1382020-01-28T13:20:40 *** tryphe_ is now known as tryphe
1392020-01-28T13:30:58 *** Soligor has quit IRC
1402020-01-28T13:32:53 <fanquake> Qt is ditching LTS releases for non-commercial users, and it looks like a âQt Accountâ will soon be required to even download the open source packages: https://www.qt.io/blog/qt-offering-changes-2020
1412020-01-28T13:34:06 <fanquake> Ooh actually, should still be able to download the source with no account. Looks like itâll just be for the installers?
1422020-01-28T13:36:23 *** NilsHitze has joined #bitcoin-core-dev
1432020-01-28T13:44:45 *** Soligor has joined #bitcoin-core-dev
1442020-01-28T13:49:06 *** orlovsky has quit IRC
1452020-01-28T13:49:56 *** dr-orlovsky has joined #bitcoin-core-dev
1462020-01-28T13:51:29 *** dr-orlovsky has quit IRC
1472020-01-28T13:52:06 *** dr-orlovsky has joined #bitcoin-core-dev
1482020-01-28T13:53:44 *** Chris_Stewart_5 has quit IRC
1492020-01-28T13:56:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1502020-01-28T13:58:09 <luke-jr> fanquake: hmm, LTS only for commercial users sounds like pretty reasonable funding for open source
1512020-01-28T13:59:18 <luke-jr> they should probably think of a more reasonable price for end users tho (not sure how that will mesh with open source licensing)
1522020-01-28T14:01:10 <luke-jr> I guess there are practical complications of such a policy for a library ^^;
1532020-01-28T14:05:25 <luke-jr> is there a reason #16507 wasn't backported? cc fanquake instagibbs
1542020-01-28T14:05:28 <gribble> https://github.com/bitcoin/bitcoin/issues/16507 | feefilter: Compute the absolute fee rather than stored rate by instagibbs · Pull Request #16507 · bitcoin/bitcoin · GitHub
1552020-01-28T14:05:40 *** promag has joined #bitcoin-core-dev
1562020-01-28T14:09:18 *** promag has quit IRC
1572020-01-28T14:09:34 *** promag has joined #bitcoin-core-dev
1582020-01-28T14:21:49 *** dr-orlovsky has quit IRC
1592020-01-28T14:22:00 *** orlovsky has joined #bitcoin-core-dev
1602020-01-28T14:30:29 *** Soligor has quit IRC
1612020-01-28T14:41:14 *** emilengler has joined #bitcoin-core-dev
1622020-01-28T14:46:30 *** torstein18 has joined #bitcoin-core-dev
1632020-01-28T14:49:36 <instagibbs> luke-jr, AFAICT it only matters if min relay fee is changed to something not % 1000 == 0
1642020-01-28T14:49:48 <instagibbs> which no one is talking about doing basically ever
1652020-01-28T14:50:42 <instagibbs> I only found it because I was investigating for liquid related purposes, where DoS is less of a concern...
1662020-01-28T14:55:44 *** Skirmant has joined #bitcoin-core-dev
1672020-01-28T15:00:01 *** NilsHitze has quit IRC
1682020-01-28T15:01:51 *** justanotheruser is now known as FeudalBear
1692020-01-28T15:01:56 *** Skirmant has quit IRC
1702020-01-28T15:05:41 <elichai2> I'm getting this when running `./bench_bitcoin -filter=something` (it doesn't matter what "somethng" is ) `bench_bitcoin: bench/bench.cpp:119: static void benchmark::BenchRunner::RunAll(benchmark::Printer&, uint64_t, double, const string&, bool): Assertion `g_testing_setup == nullptr' failed.`
1712020-01-28T15:07:34 <elichai2> @MarcoFalke ahhm
1722020-01-28T15:08:29 <elichai2> I think I've found the problem+fix
1732020-01-28T15:10:23 *** Soligor has joined #bitcoin-core-dev
1742020-01-28T15:11:15 *** bitcoin-git has joined #bitcoin-core-dev
1752020-01-28T15:11:15 <bitcoin-git> [bitcoin] elichai opened pull request #18013: bench: Fix benchmarks filters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18013
1762020-01-28T15:11:16 *** bitcoin-git has left #bitcoin-core-dev
1772020-01-28T15:17:03 *** meoblast001 has joined #bitcoin-core-dev
1782020-01-28T15:17:26 *** meoblast001 is now known as Guest53426
1792020-01-28T15:23:14 *** Chris_Stewart_5 has quit IRC
1802020-01-28T15:41:47 *** promag has quit IRC
1812020-01-28T15:42:30 *** promag has joined #bitcoin-core-dev
1822020-01-28T15:51:30 *** goatpig has quit IRC
1832020-01-28T15:58:59 *** promag has quit IRC
1842020-01-28T15:59:16 *** promag has joined #bitcoin-core-dev
1852020-01-28T16:27:29 *** aqquadro has joined #bitcoin-core-dev
1862020-01-28T16:27:29 *** aqquadro has quit IRC
1872020-01-28T16:27:29 *** aqquadro has joined #bitcoin-core-dev
1882020-01-28T16:28:47 *** aqquadro has quit IRC
1892020-01-28T16:30:01 *** Talkless has joined #bitcoin-core-dev
1902020-01-28T16:39:23 *** filchef has joined #bitcoin-core-dev
1912020-01-28T16:42:58 *** jcoe has joined #bitcoin-core-dev
1922020-01-28T16:43:15 *** jcoe1 has quit IRC
1932020-01-28T16:43:57 *** promag has quit IRC
1942020-01-28T16:44:31 *** promag has joined #bitcoin-core-dev
1952020-01-28T16:46:28 *** moneyball has quit IRC
1962020-01-28T16:46:43 *** moneyball has joined #bitcoin-core-dev
1972020-01-28T16:53:58 *** RubenSomsen has quit IRC
1982020-01-28T16:54:13 *** RubenSomsen has joined #bitcoin-core-dev
1992020-01-28T17:02:58 *** dr-orlovsky has joined #bitcoin-core-dev
2002020-01-28T17:05:16 *** orlovsky has quit IRC
2012020-01-28T17:10:23 *** andrewtoth has quit IRC
2022020-01-28T17:14:39 *** dr-orlovsky has quit IRC
2032020-01-28T17:17:28 *** dr-orlovsky has joined #bitcoin-core-dev
2042020-01-28T17:23:31 *** orlovsky has joined #bitcoin-core-dev
2052020-01-28T17:26:08 *** dr-orlovsky has quit IRC
2062020-01-28T17:39:39 *** bitcoin-git has joined #bitcoin-core-dev
2072020-01-28T17:39:39 <bitcoin-git> [bitcoin] elichai opened pull request #18014: Optimizing siphash implementation (master...2020-01-siphash) https://github.com/bitcoin/bitcoin/pull/18014
2082020-01-28T17:39:51 *** bitcoin-git has left #bitcoin-core-dev
2092020-01-28T17:39:56 *** promag has quit IRC
2102020-01-28T17:40:11 *** promag has joined #bitcoin-core-dev
2112020-01-28T17:44:58 *** tryphe_ has joined #bitcoin-core-dev
2122020-01-28T17:48:10 *** tryphe has quit IRC
2132020-01-28T17:52:50 <elichai2> I'll do clickbait and say that this PR makes siphash 3X times faster ð
2142020-01-28T17:55:46 <provoostenator> AppVeyor is having a tantrum again, lots of failures like this: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/30410830
2152020-01-28T17:56:33 * elichai2 sigh
2162020-01-28T17:57:21 <provoostenator> (not the same issue as #17976)
2172020-01-28T17:57:23 <gribble> https://github.com/bitcoin/bitcoin/issues/17976 | Appveyor ci fails again · Issue #17976 · bitcoin/bitcoin · GitHub
2182020-01-28T18:00:02 *** Guest53426 has quit IRC
2192020-01-28T18:10:40 *** tecnecio_ has joined #bitcoin-core-dev
2202020-01-28T18:13:57 <elichai2> No space left on s390x again :/ a kick will be appreciated https://travis-ci.org/bitcoin/bitcoin/jobs/643008022
2212020-01-28T18:15:24 *** drybjed1 has joined #bitcoin-core-dev
2222020-01-28T18:17:27 *** promag_ has joined #bitcoin-core-dev
2232020-01-28T18:21:38 *** promag_ has quit IRC
2242020-01-28T18:37:18 *** timothy has quit IRC
2252020-01-28T18:45:10 *** Zenton has quit IRC
2262020-01-28T18:46:58 *** promag has quit IRC
2272020-01-28T18:47:40 *** promag has joined #bitcoin-core-dev
2282020-01-28T18:57:43 <jeremyrubin> wumpus: I think https://github.com/bitcoin/bitcoin/pull/17925 is in a mergeable state (2 acks, 1 looks good)
2292020-01-28T18:59:37 <wumpus> jeremyrubin: will take a look, tahnks
2302020-01-28T18:59:55 <wumpus> btw s390 travis build keeps running out of space
2312020-01-28T19:04:54 *** bitcoin-git has joined #bitcoin-core-dev
2322020-01-28T19:04:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2755b2b1092d...fe48ac8580ae
2332020-01-28T19:04:55 <bitcoin-git> bitcoin/master 0dae5a5 Elichai Turkel: Fix benchmarks filters
2342020-01-28T19:04:55 <bitcoin-git> bitcoin/master fe48ac8 MarcoFalke: Merge #18013: bench: Fix benchmarks filters
2352020-01-28T19:05:06 *** bitcoin-git has left #bitcoin-core-dev
2362020-01-28T19:05:15 *** ajonas has quit IRC
2372020-01-28T19:05:24 *** bitcoin-git has joined #bitcoin-core-dev
2382020-01-28T19:05:24 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18013: bench: Fix benchmarks filters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18013
2392020-01-28T19:05:25 *** bitcoin-git has left #bitcoin-core-dev
2402020-01-28T19:05:27 *** ajonas has joined #bitcoin-core-dev
2412020-01-28T19:15:58 *** promag_ has joined #bitcoin-core-dev
2422020-01-28T19:18:35 <achow101> I think #17156 is rtm?
2432020-01-28T19:18:38 <gribble> https://github.com/bitcoin/bitcoin/issues/17156 | psbt: check that various indexes and amounts are within bounds by achow101 · Pull Request #17156 · bitcoin/bitcoin · GitHub
2442020-01-28T19:19:24 <achow101> and maybe #17261, tho meshcollider needs to ack it
2452020-01-28T19:19:26 <gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 · Pull Request #17261 · bitcoin/bitcoin · GitHub
2462020-01-28T19:20:30 *** promag_ has quit IRC
2472020-01-28T19:21:20 *** promag has quit IRC
2482020-01-28T19:21:34 *** promag has joined #bitcoin-core-dev
2492020-01-28T19:40:12 *** vasild_ has joined #bitcoin-core-dev
2502020-01-28T19:42:34 *** Lexyon___ has quit IRC
2512020-01-28T19:42:47 *** Lexyon___ has joined #bitcoin-core-dev
2522020-01-28T19:44:03 *** vasild has quit IRC
2532020-01-28T19:46:31 *** Guyver2 has joined #bitcoin-core-dev
2542020-01-28T19:47:03 *** zac94 has quit IRC
2552020-01-28T19:49:44 <luke-jr> how about #17843 ?
2562020-01-28T19:49:48 <gribble> https://github.com/bitcoin/bitcoin/issues/17843 | wallet: Reset reused transactions cache by fjahr · Pull Request #17843 · bitcoin/bitcoin · GitHub
2572020-01-28T20:12:11 *** Talkless has quit IRC
2582020-01-28T20:12:40 *** bitcoin-git has joined #bitcoin-core-dev
2592020-01-28T20:12:40 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #17375: Add asymptotes for benchmarking framework (master...asymptotic-benchmarks) https://github.com/bitcoin/bitcoin/pull/17375
2602020-01-28T20:12:44 *** bitcoin-git has left #bitcoin-core-dev
2612020-01-28T20:15:35 *** emilengler has quit IRC
2622020-01-28T20:30:49 *** EagleTM has joined #bitcoin-core-dev
2632020-01-28T20:37:01 *** promag has quit IRC
2642020-01-28T20:37:43 *** promag has joined #bitcoin-core-dev
2652020-01-28T20:39:07 *** vasild_ is now known as vd
2662020-01-28T20:39:10 *** vd is now known as vasild
2672020-01-28T20:45:57 *** jarthur has joined #bitcoin-core-dev
2682020-01-28T20:46:50 *** FeudalBear is now known as justanotheruser
2692020-01-28T21:00:02 *** drybjed1 has quit IRC
2702020-01-28T21:14:30 *** promag has quit IRC
2712020-01-28T21:14:44 *** promag has joined #bitcoin-core-dev
2722020-01-28T21:15:32 *** dbcooper has joined #bitcoin-core-dev
2732020-01-28T21:19:39 <fjahr> luke-jr: maybe wrong pr? That one is already merged.
2742020-01-28T21:24:40 *** promag_ has joined #bitcoin-core-dev
2752020-01-28T21:25:30 *** scottb856 has joined #bitcoin-core-dev
2762020-01-28T21:25:46 *** scottb856 has quit IRC
2772020-01-28T21:32:57 *** Zenton has joined #bitcoin-core-dev
2782020-01-28T21:35:04 *** francisco has quit IRC
2792020-01-28T21:35:18 *** francisco has joined #bitcoin-core-dev
2802020-01-28T21:49:55 <luke-jr> fjahr: not to backports
2812020-01-28T21:56:16 *** Highway61 has quit IRC
2822020-01-28T21:57:45 <fjahr> luke-jr: ah ok, i thought you meant rtm :)
2832020-01-28T21:58:04 <luke-jr> rtm?
2842020-01-28T21:58:12 <jeremyrubin> ready to merge
2852020-01-28T22:08:29 *** Highway61 has joined #bitcoin-core-dev
2862020-01-28T22:11:12 *** Highway62 has joined #bitcoin-core-dev
2872020-01-28T22:13:25 *** Highway61 has quit IRC
2882020-01-28T22:13:25 *** Highway62 is now known as Highway61
2892020-01-28T22:24:06 *** cryptapus has joined #bitcoin-core-dev
2902020-01-28T22:24:26 *** filchef has quit IRC
2912020-01-28T22:37:38 *** tecnecio_ has quit IRC
2922020-01-28T22:40:57 *** bsm117532 has joined #bitcoin-core-dev
2932020-01-28T22:41:10 *** bsm117532 has left #bitcoin-core-dev
2942020-01-28T22:57:28 <gwillen> achow101: (or anybody) -- is it possible to have a PSBT with all inputs signed and yet for some reason we can't finalize and extract it
2952020-01-28T22:57:39 <gwillen> (and is that "in theory" or in practice?)
2962020-01-28T22:58:07 <achow101> no in theory, yes in practice :p
2972020-01-28T22:58:17 <achow101> In theory, the finalizer should be pretty dumb
2982020-01-28T22:58:34 <gwillen> what are the kinds of cases where this can happen in practice?
2992020-01-28T22:58:37 <achow101> but in practice, it verifies the transaction before spitting it out, so in practice, if you have an invalid signature, it won't finalize
3002020-01-28T22:58:47 <gwillen> ahhh, interesting
3012020-01-28T22:58:56 <gwillen> is that the only case you're aware of?
3022020-01-28T22:59:03 <achow101> yes
3032020-01-28T22:59:46 <achow101> other cases are usually that you've done something subtly wrong and it isn't actually signed
3042020-01-28T23:00:54 <sipa> or the scripts used are not understood by the finalizer
3052020-01-28T23:01:14 *** bsm117532 has joined #bitcoin-core-dev
3062020-01-28T23:01:25 <sipa> so despite having enough signatures present, the finalizer doesn't know how to combine them into a full satisfying witness
3072020-01-28T23:01:26 *** jarthur_ has joined #bitcoin-core-dev
3082020-01-28T23:02:58 *** bsm117532 has quit IRC
3092020-01-28T23:04:12 <gwillen> I guess actually, from my perspective if I see that an input is "signed" that already means the signature parts have been combined
3102020-01-28T23:04:26 <gwillen> and as far as I can tell if all inputs are "signed" in that way, then finalization looks like it can't fail
3112020-01-28T23:04:29 <gwillen> nor extraction
3122020-01-28T23:05:23 <gwillen> since PSBTInputSigned declares true if it sees a final_script_sig or a final_script_witness
3132020-01-28T23:05:24 *** jarthur has quit IRC
3142020-01-28T23:05:59 <gwillen> and extraction does nothing but copy those fields out, it does not check anything as long as they exist (although presumbly broadcast will fail if they're bad)
3152020-01-28T23:06:12 *** jarthur_ has quit IRC
3162020-01-28T23:09:05 *** Guyver2 has quit IRC
3172020-01-28T23:09:51 *** bsm117532 has joined #bitcoin-core-dev
3182020-01-28T23:10:07 *** bsm117532 has quit IRC
3192020-01-28T23:11:17 <sipa> gwillen: finalization is creating the final_script_sig etc; if those already exist, then extraction will never fail
3202020-01-28T23:12:08 <sipa> extraction in theory could run a script verifier first; there should be enough information in psbt to do that
3212020-01-28T23:13:36 *** ppisati has quit IRC
3222020-01-28T23:15:20 *** ppisati has joined #bitcoin-core-dev
3232020-01-28T23:31:32 <achow101> sipa: is there a command line descriptor to script compiler somewhere?
3242020-01-28T23:33:07 *** promag_ has quit IRC
3252020-01-28T23:51:35 *** jcoe has quit IRC