12020-01-29T00:00:01  *** dbcooper has quit IRC
  22020-01-29T00:05:33  *** lnostdal has quit IRC
  32020-01-29T00:05:47  *** lnostdal has joined #bitcoin-core-dev
  42020-01-29T00:08:29  *** zavan has joined #bitcoin-core-dev
  52020-01-29T00:13:17  *** kensanata has joined #bitcoin-core-dev
  62020-01-29T00:53:36  *** tryphe_ is now known as tryphe
  72020-01-29T01:13:30  *** kristapsk_ is now known as kristapsk
  82020-01-29T01:38:09  *** AaronvanW has quit IRC
  92020-01-29T01:54:19  *** Victorsueca has joined #bitcoin-core-dev
 102020-01-29T01:54:23  *** SiAnDoG_ has joined #bitcoin-core-dev
 112020-01-29T01:54:36  *** Victor_sueca has quit IRC
 122020-01-29T01:55:36  *** kristapsk has quit IRC
 132020-01-29T01:55:36  *** Dean_Guss has quit IRC
 142020-01-29T01:55:36  *** SiAnDoG__ has quit IRC
 152020-01-29T01:55:51  *** kristapsk has joined #bitcoin-core-dev
 162020-01-29T01:55:53  *** Dean_Guss has joined #bitcoin-core-dev
 172020-01-29T01:56:43  *** braydonf has quit IRC
 182020-01-29T01:57:12  *** braydonf has joined #bitcoin-core-dev
 192020-01-29T02:00:33  *** belcher has quit IRC
 202020-01-29T02:21:27  *** zavan has quit IRC
 212020-01-29T03:00:01  *** kensanata has quit IRC
 222020-01-29T03:00:53  *** abrissbi1ne has joined #bitcoin-core-dev
 232020-01-29T03:04:20  *** abrissbirne has quit IRC
 242020-01-29T03:15:24  *** neutraltc has joined #bitcoin-core-dev
 252020-01-29T04:07:02  *** promag has quit IRC
 262020-01-29T04:08:51  *** Eagle[TM] has joined #bitcoin-core-dev
 272020-01-29T04:11:16  *** EagleTM has quit IRC
 282020-01-29T04:22:49  *** frogar has quit IRC
 292020-01-29T04:28:58  *** mryandao has quit IRC
 302020-01-29T04:29:15  *** mryandao has joined #bitcoin-core-dev
 312020-01-29T04:30:39  *** frogar has joined #bitcoin-core-dev
 322020-01-29T04:46:29  *** bitcoin-git has joined #bitcoin-core-dev
 332020-01-29T04:46:29  <bitcoin-git> [bitcoin] ajtowns opened pull request #18017: txmempool: split epoch logic into class (master...202001-epoch) https://github.com/bitcoin/bitcoin/pull/18017
 342020-01-29T04:46:30  *** bitcoin-git has left #bitcoin-core-dev
 352020-01-29T05:19:15  *** jb55 has quit IRC
 362020-01-29T05:19:42  *** jb55 has joined #bitcoin-core-dev
 372020-01-29T05:38:16  *** Dean_Guss has quit IRC
 382020-01-29T05:38:39  *** Dean_Guss has joined #bitcoin-core-dev
 392020-01-29T05:41:49  *** promag has joined #bitcoin-core-dev
 402020-01-29T05:45:04  *** promag_ has joined #bitcoin-core-dev
 412020-01-29T05:47:25  *** bitcoin-git has joined #bitcoin-core-dev
 422020-01-29T05:47:25  <bitcoin-git> [bitcoin] fanquake opened pull request #18018: tests: reset fIsBareMultisigStd after bare-multisig tests (master...fix_p2sh_tests_failure) https://github.com/bitcoin/bitcoin/pull/18018
 432020-01-29T05:47:37  *** bitcoin-git has left #bitcoin-core-dev
 442020-01-29T05:50:07  *** promag_ has quit IRC
 452020-01-29T06:00:01  *** neutraltc has quit IRC
 462020-01-29T06:00:47  *** retr0 has joined #bitcoin-core-dev
 472020-01-29T06:13:00  *** retr0 has quit IRC
 482020-01-29T06:18:31  *** abrissbi1ne is now known as abrissbirne
 492020-01-29T06:29:03  *** Dean_Guss has quit IRC
 502020-01-29T06:39:34  *** bitcoin-git has joined #bitcoin-core-dev
 512020-01-29T06:39:34  <bitcoin-git> [bitcoin] Bushstar closed pull request #18012: GBT segwit rule in RPC error msg missing single quotes (master...patch-5) https://github.com/bitcoin/bitcoin/pull/18012
 522020-01-29T06:39:36  *** bitcoin-git has left #bitcoin-core-dev
 532020-01-29T06:42:11  *** luto1 has joined #bitcoin-core-dev
 542020-01-29T06:44:03  *** abacus has quit IRC
 552020-01-29T06:46:33  *** hardforkthis7 has quit IRC
 562020-01-29T06:46:52  *** hardforkthis7 has joined #bitcoin-core-dev
 572020-01-29T06:50:10  *** abacus has joined #bitcoin-core-dev
 582020-01-29T06:54:33  *** abacus has quit IRC
 592020-01-29T06:55:13  *** abacus has joined #bitcoin-core-dev
 602020-01-29T07:08:15  *** goatpig has joined #bitcoin-core-dev
 612020-01-29T07:13:54  *** asoltys has quit IRC
 622020-01-29T07:15:02  *** asoltys has joined #bitcoin-core-dev
 632020-01-29T07:23:57  *** tecnecio_ has joined #bitcoin-core-dev
 642020-01-29T07:26:57  *** Eagle[TM] has quit IRC
 652020-01-29T07:28:23  *** abacus has quit IRC
 662020-01-29T07:34:04  *** PaulTroon has joined #bitcoin-core-dev
 672020-01-29T07:40:05  *** abacus has joined #bitcoin-core-dev
 682020-01-29T07:43:23  *** vasild has quit IRC
 692020-01-29T07:45:05  *** abacus has quit IRC
 702020-01-29T07:45:09  *** vasild has joined #bitcoin-core-dev
 712020-01-29T07:52:25  *** abacus has joined #bitcoin-core-dev
 722020-01-29T08:05:05  *** IGHOR has quit IRC
 732020-01-29T08:06:03  *** mryandao has quit IRC
 742020-01-29T08:06:58  *** mryandao has joined #bitcoin-core-dev
 752020-01-29T08:07:46  *** promag has quit IRC
 762020-01-29T08:07:59  *** promag has joined #bitcoin-core-dev
 772020-01-29T08:08:00  *** gribble has quit IRC
 782020-01-29T08:14:04  *** promag has quit IRC
 792020-01-29T08:21:48  *** gribble has joined #bitcoin-core-dev
 802020-01-29T08:28:11  *** IGHOR has joined #bitcoin-core-dev
 812020-01-29T08:29:14  *** torstein18 has joined #bitcoin-core-dev
 822020-01-29T08:34:03  *** torstein18 has quit IRC
 832020-01-29T08:36:08  *** torstein18 has joined #bitcoin-core-dev
 842020-01-29T08:40:20  *** torstein18 has quit IRC
 852020-01-29T08:40:38  *** torstein18 has joined #bitcoin-core-dev
 862020-01-29T08:41:19  *** torstein18 has joined #bitcoin-core-dev
 872020-01-29T09:00:02  *** luto1 has quit IRC
 882020-01-29T09:08:21  *** promag has joined #bitcoin-core-dev
 892020-01-29T09:11:08  *** peutetre has joined #bitcoin-core-dev
 902020-01-29T09:37:07  *** AaronvanW has joined #bitcoin-core-dev
 912020-01-29T09:47:23  *** Emcy has quit IRC
 922020-01-29T10:00:05  *** jcoe has joined #bitcoin-core-dev
 932020-01-29T10:23:06  *** AaronvanW has quit IRC
 942020-01-29T10:27:29  *** timothy has joined #bitcoin-core-dev
 952020-01-29T10:32:50  *** PaulTroon has quit IRC
 962020-01-29T10:40:16  *** timothy has quit IRC
 972020-01-29T10:40:27  *** Emcy has joined #bitcoin-core-dev
 982020-01-29T10:45:05  *** Guyver2 has joined #bitcoin-core-dev
 992020-01-29T11:03:56  *** Alessandra22Mori has joined #bitcoin-core-dev
1002020-01-29T11:05:23  *** belcher has joined #bitcoin-core-dev
1012020-01-29T11:38:27  *** orlovsky has quit IRC
1022020-01-29T11:40:51  *** bitcoin-git has joined #bitcoin-core-dev
1032020-01-29T11:40:52  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fe48ac8580ae...1326092e6cef
1042020-01-29T11:40:52  <bitcoin-git> bitcoin/master f1ef7f0 Andrew Chow: Don't calculate tx fees for PSBTs with invalid money values
1052020-01-29T11:40:53  <bitcoin-git> bitcoin/master deaa6dd Andrew Chow: psbt: check output index is within bounds before accessing
1062020-01-29T11:40:54  <bitcoin-git> bitcoin/master 1326092 fanquake: Merge #17156: psbt: check that various indexes and amounts are within boun...
1072020-01-29T11:40:55  *** bitcoin-git has left #bitcoin-core-dev
1082020-01-29T11:41:36  *** bitcoin-git has joined #bitcoin-core-dev
1092020-01-29T11:41:36  <bitcoin-git> [bitcoin] fanquake merged pull request #17156: psbt: check that various indexes and amounts are within bounds (master...psbt-fuzz-fix) https://github.com/bitcoin/bitcoin/pull/17156
1102020-01-29T11:41:37  *** bitcoin-git has left #bitcoin-core-dev
1112020-01-29T11:48:57  *** dr-orlovsky has joined #bitcoin-core-dev
1122020-01-29T11:49:03  *** dr-orlovsky has quit IRC
1132020-01-29T12:00:01  *** peutetre has quit IRC
1142020-01-29T12:00:13  *** Emcy has quit IRC
1152020-01-29T12:02:39  *** Emcy has joined #bitcoin-core-dev
1162020-01-29T12:10:15  *** AIM` has joined #bitcoin-core-dev
1172020-01-29T12:10:25  *** Alessandra22Mori has quit IRC
1182020-01-29T12:16:36  *** bitcoin-git has joined #bitcoin-core-dev
1192020-01-29T12:16:36  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1326092e6cef...e061b8dc8fba
1202020-01-29T12:16:37  <bitcoin-git> bitcoin/master e80317b Bushstar: refactor: Remove redundant conditional
1212020-01-29T12:16:37  <bitcoin-git> bitcoin/master e061b8d fanquake: Merge #17971: refactor: Remove redundant conditional
1222020-01-29T12:16:39  *** bitcoin-git has left #bitcoin-core-dev
1232020-01-29T12:16:56  *** bitcoin-git has joined #bitcoin-core-dev
1242020-01-29T12:16:56  <bitcoin-git> [bitcoin] fanquake merged pull request #17971: refactor: Remove redundant conditional (master...remove-redundant-conditional) https://github.com/bitcoin/bitcoin/pull/17971
1252020-01-29T12:16:57  *** bitcoin-git has left #bitcoin-core-dev
1262020-01-29T12:23:09  *** PaulTroon has joined #bitcoin-core-dev
1272020-01-29T12:26:35  *** Skirmant has joined #bitcoin-core-dev
1282020-01-29T12:31:20  *** Skirmant has quit IRC
1292020-01-29T12:34:56  <fanquake> Thanks fjahr
1302020-01-29T12:35:19  <fjahr> fanquake: sure :)
1312020-01-29T12:49:20  *** bitcoin-git has joined #bitcoin-core-dev
1322020-01-29T12:49:21  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e061b8dc8fba...c434282d2cb8
1332020-01-29T12:49:21  <bitcoin-git> bitcoin/master b35567f fanquake: test: only declare a main() when fuzzing with AFL
1342020-01-29T12:49:22  <bitcoin-git> bitcoin/master c434282 fanquake: Merge #18008: test: only declare a main() when fuzzing with AFL
1352020-01-29T12:49:31  *** bitcoin-git has left #bitcoin-core-dev
1362020-01-29T12:49:50  *** bitcoin-git has joined #bitcoin-core-dev
1372020-01-29T12:49:51  <bitcoin-git> [bitcoin] fanquake merged pull request #18008: test: only declare a main() when fuzzing with AFL (master...macos_libfuzzer_weak_main) https://github.com/bitcoin/bitcoin/pull/18008
1382020-01-29T12:49:51  *** bitcoin-git has left #bitcoin-core-dev
1392020-01-29T12:50:30  *** filchef has joined #bitcoin-core-dev
1402020-01-29T12:56:17  *** bitcoin-git has joined #bitcoin-core-dev
1412020-01-29T12:56:19  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c434282d2cb8...01fc5891fb57
1422020-01-29T12:56:19  <bitcoin-git> bitcoin/master 8feb4e4 Gleb Naumenko:  Add asmap utility which queries a mapping
1432020-01-29T12:56:20  <bitcoin-git> bitcoin/master ec45646 Gleb Naumenko: Integrate ASN bucketing in Addrman and add tests
1442020-01-29T12:56:21  <bitcoin-git> bitcoin/master e4658aa Gleb Naumenko: Return mapped AS in RPC call getpeerinfo
1452020-01-29T12:56:28  *** bitcoin-git has left #bitcoin-core-dev
1462020-01-29T12:57:12  *** bitcoin-git has joined #bitcoin-core-dev
1472020-01-29T12:57:12  <bitcoin-git> [bitcoin] laanwj merged pull request #16702: p2p: supplying and using asmap to improve IP bucketing in addrman (master...asn_buckets) https://github.com/bitcoin/bitcoin/pull/16702
1482020-01-29T12:57:13  *** bitcoin-git has left #bitcoin-core-dev
1492020-01-29T13:00:49  *** promag has quit IRC
1502020-01-29T13:10:32  *** real_or_random has joined #bitcoin-core-dev
1512020-01-29T13:19:20  *** bitcoin-git has joined #bitcoin-core-dev
1522020-01-29T13:19:20  <bitcoin-git> [bitcoin] laanwj closed pull request #17514: util: Make logging noexcept (master...2019_11_logging_noexcept) https://github.com/bitcoin/bitcoin/pull/17514
1532020-01-29T13:19:21  *** bitcoin-git has left #bitcoin-core-dev
1542020-01-29T13:23:24  *** promag has joined #bitcoin-core-dev
1552020-01-29T13:28:07  *** promag has quit IRC
1562020-01-29T13:37:08  *** jonatack has quit IRC
1572020-01-29T13:47:49  *** bitcoin-git has joined #bitcoin-core-dev
1582020-01-29T13:47:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/01fc5891fb57...3b5b27673414
1592020-01-29T13:47:50  <bitcoin-git> bitcoin/master b6c3e84 Fabian Jahr: doc: Improve fuzzing docs for macOS users
1602020-01-29T13:47:50  <bitcoin-git> bitcoin/master 3b5b276 MarcoFalke: Merge #17942: doc: Improve fuzzing docs for macOS users
1612020-01-29T13:47:52  *** bitcoin-git has left #bitcoin-core-dev
1622020-01-29T13:48:09  *** bitcoin-git has joined #bitcoin-core-dev
1632020-01-29T13:48:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
1642020-01-29T13:48:11  *** bitcoin-git has left #bitcoin-core-dev
1652020-01-29T13:53:45  *** Highway61 has quit IRC
1662020-01-29T13:59:15  <wumpus> replaced #17892 with #17994 in high prio
1672020-01-29T13:59:19  <gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof · Pull Request #17892 · bitcoin/bitcoin · GitHub
1682020-01-29T13:59:20  <gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof · Pull Request #17994 · bitcoin/bitcoin · GitHub
1692020-01-29T14:02:11  *** setpill has joined #bitcoin-core-dev
1702020-01-29T14:08:06  *** promag has joined #bitcoin-core-dev
1712020-01-29T14:11:38  *** bitcoin-git has joined #bitcoin-core-dev
1722020-01-29T14:11:39  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3b5b27673414...c1607b5df487
1732020-01-29T14:11:40  <bitcoin-git> bitcoin/master ca34c5c Pieter Wuille: Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters
1742020-01-29T14:11:40  <bitcoin-git> bitcoin/master 4de934b Pieter Wuille: Convert compression.h to new serialization framework
1752020-01-29T14:11:41  <bitcoin-git> bitcoin/master c1607b5 Wladimir J. van der Laan: Merge #17957: Serialization improvements step 3 (compression.h)
1762020-01-29T14:11:42  *** bitcoin-git has left #bitcoin-core-dev
1772020-01-29T14:11:56  *** bitcoin-git has joined #bitcoin-core-dev
1782020-01-29T14:11:57  <bitcoin-git> [bitcoin] laanwj merged pull request #17957: Serialization improvements step 3 (compression.h) (master...202001_noncastserial_3) https://github.com/bitcoin/bitcoin/pull/17957
1792020-01-29T14:12:09  *** bitcoin-git has left #bitcoin-core-dev
1802020-01-29T14:19:12  *** PaulTroon has quit IRC
1812020-01-29T14:19:43  *** Highway61 has joined #bitcoin-core-dev
1822020-01-29T14:20:27  *** PaulTroon has joined #bitcoin-core-dev
1832020-01-29T14:30:02  *** jb55 has quit IRC
1842020-01-29T14:30:31  *** jb55 has joined #bitcoin-core-dev
1852020-01-29T14:48:17  *** jonatack has joined #bitcoin-core-dev
1862020-01-29T14:55:45  *** bitcoin-git has joined #bitcoin-core-dev
1872020-01-29T14:55:45  <bitcoin-git> [bitcoin] sdaftuar closed pull request #16401: Add package acceptance logic to mempool (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
1882020-01-29T14:55:46  *** bitcoin-git has left #bitcoin-core-dev
1892020-01-29T15:00:01  *** AIM` has quit IRC
1902020-01-29T15:04:04  *** jonatack has quit IRC
1912020-01-29T15:05:16  *** rex4539 has joined #bitcoin-core-dev
1922020-01-29T15:05:35  *** csknk has joined #bitcoin-core-dev
1932020-01-29T15:12:17  *** timothy has joined #bitcoin-core-dev
1942020-01-29T15:15:54  *** dr-orlovsky has joined #bitcoin-core-dev
1952020-01-29T15:19:42  *** timothy has quit IRC
1962020-01-29T15:21:43  *** timothy has joined #bitcoin-core-dev
1972020-01-29T15:31:23  *** timothy has quit IRC
1982020-01-29T15:34:15  *** timothy has joined #bitcoin-core-dev
1992020-01-29T15:35:22  *** cpow has joined #bitcoin-core-dev
2002020-01-29T15:43:12  *** dr-orlovsky has quit IRC
2012020-01-29T15:44:52  *** Emcy has quit IRC
2022020-01-29T15:45:48  *** dr-orlovsky has joined #bitcoin-core-dev
2032020-01-29T15:48:55  *** goatpig has quit IRC
2042020-01-29T15:53:02  *** felixfoertsch has quit IRC
2052020-01-29T15:53:13  *** felixfoertsch23 has joined #bitcoin-core-dev
2062020-01-29T16:00:10  *** dr-orlovsky has quit IRC
2072020-01-29T16:02:54  *** dr-orlovsky has joined #bitcoin-core-dev
2082020-01-29T16:05:04  *** tsujp has joined #bitcoin-core-dev
2092020-01-29T16:15:35  *** setpill has quit IRC
2102020-01-29T16:16:05  *** dr-orlovsky has quit IRC
2112020-01-29T16:19:48  *** dr-orlovsky has joined #bitcoin-core-dev
2122020-01-29T16:21:53  *** frankie has joined #bitcoin-core-dev
2132020-01-29T16:22:17  *** frankie is now known as Guest41554
2142020-01-29T16:27:28  *** Talkless has joined #bitcoin-core-dev
2152020-01-29T16:27:44  *** Talkless has quit IRC
2162020-01-29T16:28:28  *** Talkless has joined #bitcoin-core-dev
2172020-01-29T16:31:03  *** Guest41554 has quit IRC
2182020-01-29T16:31:44  *** Highway61 has joined #bitcoin-core-dev
2192020-01-29T16:34:56  *** dr-orlovsky has quit IRC
2202020-01-29T16:37:05  *** davterra has joined #bitcoin-core-dev
2212020-01-29T16:38:27  *** prettycolors has quit IRC
2222020-01-29T16:43:35  *** goatpig has joined #bitcoin-core-dev
2232020-01-29T16:48:27  *** dr-orlovsky has joined #bitcoin-core-dev
2242020-01-29T16:54:47  *** dr-orlovsky has quit IRC
2252020-01-29T17:05:45  *** Deacyde has joined #bitcoin-core-dev
2262020-01-29T17:05:59  *** Deacyde has quit IRC
2272020-01-29T17:07:21  *** Deacyde has joined #bitcoin-core-dev
2282020-01-29T17:08:16  *** jonatack has joined #bitcoin-core-dev
2292020-01-29T17:12:43  *** ghost43 has quit IRC
2302020-01-29T17:12:56  *** jonatack has quit IRC
2312020-01-29T17:12:57  *** ghost43_ has joined #bitcoin-core-dev
2322020-01-29T17:13:44  *** jonatack has joined #bitcoin-core-dev
2332020-01-29T17:14:47  *** emilengler has joined #bitcoin-core-dev
2342020-01-29T17:20:48  *** andrewtoth has joined #bitcoin-core-dev
2352020-01-29T17:23:13  *** Highway61 has quit IRC
2362020-01-29T17:23:54  *** Emcy has joined #bitcoin-core-dev
2372020-01-29T17:29:49  *** millerti has joined #bitcoin-core-dev
2382020-01-29T17:37:07  *** kiwi_74 has joined #bitcoin-core-dev
2392020-01-29T17:41:04  *** kiwi_74 has quit IRC
2402020-01-29T17:49:42  *** hanhua has joined #bitcoin-core-dev
2412020-01-29T17:52:42  *** pelt has joined #bitcoin-core-dev
2422020-01-29T18:00:01  *** cpow has quit IRC
2432020-01-29T18:03:37  *** jarthur has joined #bitcoin-core-dev
2442020-01-29T18:04:32  *** michaelfolkson has joined #bitcoin-core-dev
2452020-01-29T18:11:41  *** wgolden has joined #bitcoin-core-dev
2462020-01-29T18:14:13  *** tsujp has quit IRC
2472020-01-29T18:15:40  *** Highway61 has joined #bitcoin-core-dev
2482020-01-29T18:21:13  *** tsujp has joined #bitcoin-core-dev
2492020-01-29T18:28:41  <jeremyrubin> Anyone opposed to adding a reference to review #15465 in the style guide?
2502020-01-29T18:28:43  <gribble> https://github.com/bitcoin/bitcoin/issues/15465 | Code style PRs after v0.18 branch split · Issue #15465 · bitcoin/bitcoin · GitHub
2512020-01-29T19:01:22  *** PaulTroon has quit IRC
2522020-01-29T19:07:52  <jonatack> jeremyrubin: I learned a great deal from reading and taking notes on the discussion in that PR. Out of curiosity were there particular comments you are referring to?
2532020-01-29T19:10:40  <gwillen> jeremyrubin: like, adding it as a reference / further explanation where the styleguide talks about when one should or should not make style changes?
2542020-01-29T19:10:48  <gwillen> (and to encourage people not to argue about it without reading this first? :-) )
2552020-01-29T19:16:13  <jeremyrubin> yeah
2562020-01-29T19:16:39  *** michaelfolkson has quit IRC
2572020-01-29T19:24:26  *** tripleslash has joined #bitcoin-core-dev
2582020-01-29T19:30:55  *** bitcoin-git has joined #bitcoin-core-dev
2592020-01-29T19:30:56  <bitcoin-git> [bitcoin] sipa opened pull request #18021: Serialization improvements step 4 (undo.h) (master...202001_noncastserial_4) https://github.com/bitcoin/bitcoin/pull/18021
2602020-01-29T19:30:56  *** bitcoin-git has left #bitcoin-core-dev
2612020-01-29T19:31:38  <gwillen> jeremyrubin: I feel like after reading that thread, one thing that I would love to see would be guidelines for how to _review_ PRs
2622020-01-29T19:32:25  <jeremyrubin> Certainly. I don't want to point at specific examples, as it's a bit more of a general issue with review presently.
2632020-01-29T19:32:53  <gwillen> yeah, and I think it's absolutely not bitcoin-specific, I have had similar problems with code review processes in most contexts where I've had code review
2642020-01-29T19:33:03  <jeremyrubin> But the way I think about style is it's a sub-goal. And as long as the style is flagrantly bad, focusing on the substance of a PR and correctness are priroties
2652020-01-29T19:33:30  <gwillen> is not* I think you meant, but yeah
2662020-01-29T19:33:42  <jeremyrubin> yes
2672020-01-29T19:33:53  * jeremyrubin adds whitespace to the end of every line
2682020-01-29T19:34:10  <jeremyrubin> I also think that unlike other projects perhaps we have a low trust environment, which means that re-review is particularly annoying
2692020-01-29T19:34:21  <gwillen> I think a more-structured review process would be helpful, i.e. "currently we are in design review, next we will be in general code review, then after that is nitpick review"
2702020-01-29T19:34:25  <jonatack> gwillen: been working on guidelines since last Spring https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
2712020-01-29T19:34:43  <jeremyrubin> Paired with a culture of preferring squashed branches it's kind of annoying because you trigger re-review for all prior reviewers
2722020-01-29T19:34:54  <jeremyrubin> Which can then add weeks to the cycle of a PR
2732020-01-29T19:35:18  <gwillen> one problem with any kind of more structured review is that, as you say it's a bit low-trust, and the longer your PR is open the more likely you are to draw a comment that says "please make huge changes", which has a good chance of killing your work
2742020-01-29T19:35:21  *** tripleslash is now known as imsaguy
2752020-01-29T19:35:29  <sipa> really? i've never felt that requests for squashing delay things
2762020-01-29T19:35:32  *** jcoe has quit IRC
2772020-01-29T19:35:34  *** imsaguy is now known as [\\\]
2782020-01-29T19:36:45  <gwillen> well, if you require everybody to re-ack after squash because the commit ID changed, it seems like it would be surprising if it did not create dleay?
2792020-01-29T19:36:58  <sipa> sure, but those acks are trivial
2802020-01-29T19:37:17  <sipa> i mean, obviously it adds something... but i've never seen that being a problem
2812020-01-29T19:38:08  <jeremyrubin> I think they're also just not worth it -- people are likely to be less dilligent in their re-review unless they are actually fetching the branch and diffiing
2822020-01-29T19:38:37  <sipa> i don't think so
2832020-01-29T19:38:47  <sipa> the majority of the work when reviewing a PR is understanding it
2842020-01-29T19:38:57  <gwillen> I have indeed been fetching the branch and diffing the squash
2852020-01-29T19:39:16  <jeremyrubin> Anyways the squashing is a minor issue sipa
2862020-01-29T19:39:18  <sipa> a re-review can be much faster, even if you diligently read every line again, just because you already know what's going on
2872020-01-29T19:39:22  <sipa> jeremyrubin: fair
2882020-01-29T19:39:37  <jeremyrubin> I think that if it's a functional change, fixing a bug, yes, squash it
2892020-01-29T19:39:42  <gwillen> just as a matter of policy I'm not comfortable giving an ack unless I'm confident I know exactly what changed since my last ack
2902020-01-29T19:40:14  *** vasild_ has joined #bitcoin-core-dev
2912020-01-29T19:40:21  <gwillen> but also I tend not to be comfortable giving an ack without a pretty detailed understanding of the change, to the point where doing a re-review (without a diff-since-last-review) does feel like a significant burden
2922020-01-29T19:40:26  <jeremyrubin> but for things like comments improvements or renaming variables for semantics it's not a great use of contributor time compared to a separate fix up
2932020-01-29T19:40:58  <gwillen> is everybody aware that git will show you the diff across a force-push (usually) if you click the words 'force push'
2942020-01-29T19:41:14  <jeremyrubin> click?
2952020-01-29T19:41:32  <sipa> sure, comment improvements can totally be separate commits
2962020-01-29T19:41:42  <gwillen> sorry, github, oops. I have become the thing I despise XD
2972020-01-29T19:42:19  <sipa> git push --force will also show you the diff (in the form of commitid..commitid)
2982020-01-29T19:42:28  <jeremyrubin> sipa: I think this is all we're expressing is a desire to better contextualize when that's OK to just be like "address this later"
2992020-01-29T19:42:52  <sipa> jeremyrubin: i think those things are mostly up to the author really
3002020-01-29T19:43:01  <jeremyrubin> Because pointing to a doc or something that says "in general, style changes are not worth a re-ack unless the author wants to" is good
3012020-01-29T19:43:03  *** vasild has quit IRC
3022020-01-29T19:44:18  <jeremyrubin> I like jonatack's doc
3032020-01-29T19:44:23  <gwillen> it's a little tricky because I'd say you want at least one person other than the contributor to carefully examine it enough to say "yes, this is indeed just a style change"
3042020-01-29T19:44:25  <jonatack> gwillen: even if GitHub can show the diff, i reckon it's best to do git diffing locally after pulling the changes, moreso for final acks
3052020-01-29T19:44:59  <gwillen> jonatack: I agree, but I discovered the other day that if you don't have all the previous branch heads after a force push, you can't easily get them to diff them
3062020-01-29T19:45:05  <jonatack> jeremyrubin: thanks, looks like i need to add a section about re-acking and git diffing
3072020-01-29T19:45:06  <gwillen> there's a trick but it's annoying
3082020-01-29T19:46:53  <jonatack> gwillen: agreed, pulling prev branch heads seems par for the course
3092020-01-29T19:46:53  *** AaronvanW has joined #bitcoin-core-dev
3102020-01-29T19:47:36  <gwillen> well in particular, after a force push of a PR branch from X to Y, if you do not already have X locally, you can't easily get X in order to "git diff X Y"
3112020-01-29T19:47:51  <gwillen> you have to have already done it (which I guess is a good habit to be in anyway, having reviewed it)
3122020-01-29T19:48:02  <sipa> some reviewers prefer not rebasing unless necessary (even if you're rewriting commits)
3132020-01-29T19:48:59  <jeremyrubin> it also might not be the worst to have it be a maintainer script that we maintain a master unsquashed and a master squashed branch -- where master squashed squashes all commits prefixed as a fixup@<hash> to fixup @hash
3142020-01-29T19:49:14  <jeremyrubin> retract that idea
3152020-01-29T19:49:18  <jeremyrubin> sounds like a nightmare
3162020-01-29T19:50:10  <sipa> at some point it's a tradeoff between tangible benefits and process overhead
3172020-01-29T19:51:51  <jeremyrubin> I think it's reasonable to say that style/whatever fixes don't need a rebase. But if there's a bug, which requires a fix, it actually *should* invalidate all acks, because they missed the bug.
3182020-01-29T19:53:37  *** vasild_ is now known as vasild
3192020-01-29T19:53:41  <jeremyrubin> Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable.
3202020-01-29T19:54:57  <jonatack> jeremyrubin: I still update it frequently, but maybe when it settles down
3212020-01-29T20:10:50  *** bitcoin-git has joined #bitcoin-core-dev
3222020-01-29T20:10:51  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1607b5df487...aabec94541e2
3232020-01-29T20:10:51  <bitcoin-git> bitcoin/master f41d589 Antoine Riard: Document better -keypool as a look-ahead safety mechanism
3242020-01-29T20:10:52  <bitcoin-git> bitcoin/master aabec94 Samuel Dobson: Merge #17719: Document better -keypool as a look-ahead safety mechanism
3252020-01-29T20:10:54  *** bitcoin-git has left #bitcoin-core-dev
3262020-01-29T20:11:10  *** bitcoin-git has joined #bitcoin-core-dev
3272020-01-29T20:11:11  <bitcoin-git> [bitcoin] meshcollider merged pull request #17719: Document better -keypool as a look-ahead safety mechanism (master...2019-12-improve-keypool-doc) https://github.com/bitcoin/bitcoin/pull/17719
3282020-01-29T20:11:12  *** bitcoin-git has left #bitcoin-core-dev
3292020-01-29T20:11:20  *** dr-orlovsky has joined #bitcoin-core-dev
3302020-01-29T20:12:21  *** pelt has quit IRC
3312020-01-29T20:13:06  *** AaronvanW has quit IRC
3322020-01-29T20:14:09  *** orlovsky has joined #bitcoin-core-dev
3332020-01-29T20:14:10  *** PaulTroon has joined #bitcoin-core-dev
3342020-01-29T20:17:34  *** dr-orlovsky has quit IRC
3352020-01-29T20:30:27  *** emilengler has quit IRC
3362020-01-29T20:31:39  *** rex4539 has quit IRC
3372020-01-29T20:33:35  *** Talkless has quit IRC
3382020-01-29T20:34:54  *** [\\\] is now known as tripleslash
3392020-01-29T20:35:32  *** EagleTM has joined #bitcoin-core-dev
3402020-01-29T20:40:19  *** rex4539 has joined #bitcoin-core-dev
3412020-01-29T20:53:41  <elichai2> <<jeremyrubin> > Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable. I'd definitely like to read it :)
3422020-01-29T20:57:12  *** jonatack has quit IRC
3432020-01-29T21:00:01  *** wgolden has quit IRC
3442020-01-29T21:03:26  *** goatpig has quit IRC
3452020-01-29T21:03:27  *** tecnecio_ has quit IRC
3462020-01-29T21:03:59  *** manantial has joined #bitcoin-core-dev
3472020-01-29T21:10:31  *** manantial has quit IRC
3482020-01-29T21:12:15  *** manantial has joined #bitcoin-core-dev
3492020-01-29T21:15:35  *** kpyke has joined #bitcoin-core-dev
3502020-01-29T21:45:01  *** filchef has quit IRC
3512020-01-29T21:52:04  *** dr-orlovsky has joined #bitcoin-core-dev
3522020-01-29T21:53:21  *** orlovsky has quit IRC
3532020-01-29T21:58:40  *** bitcoin-git has joined #bitcoin-core-dev
3542020-01-29T21:58:40  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
3552020-01-29T21:58:41  *** bitcoin-git has left #bitcoin-core-dev
3562020-01-29T22:01:46  *** csknk has quit IRC
3572020-01-29T22:03:50  *** PaulTroon has quit IRC
3582020-01-29T22:06:16  *** Guyver2 has quit IRC
3592020-01-29T22:14:34  *** meshcollider has quit IRC
3602020-01-29T22:15:31  *** jarthur has quit IRC
3612020-01-29T22:26:08  *** EagleTM has quit IRC
3622020-01-29T22:40:09  *** dr-orlovsky has quit IRC
3632020-01-29T22:41:24  *** dr-orlovsky has joined #bitcoin-core-dev
3642020-01-29T22:52:56  *** AaronvanW has joined #bitcoin-core-dev
3652020-01-29T23:05:17  *** hanhua has quit IRC
3662020-01-29T23:08:40  *** bitcoin-git has joined #bitcoin-core-dev
3672020-01-29T23:08:40  <bitcoin-git> [bitcoin] sipa opened pull request #18023: Some asmap improvements (master...202001_asmap_nits) https://github.com/bitcoin/bitcoin/pull/18023
3682020-01-29T23:08:42  *** bitcoin-git has left #bitcoin-core-dev
3692020-01-29T23:15:30  *** bitcoin-git has joined #bitcoin-core-dev
3702020-01-29T23:15:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aabec94541e2...638239de7502
3712020-01-29T23:15:31  <bitcoin-git> bitcoin/master fa1a46e MarcoFalke: build: Fix appveyor test_bitcoin build of *.raw
3722020-01-29T23:15:32  <bitcoin-git> bitcoin/master 638239d MarcoFalke: Merge #18022: test: Fix appveyor test_bitcoin build of *.raw
3732020-01-29T23:15:40  *** bitcoin-git has left #bitcoin-core-dev
3742020-01-29T23:15:55  *** bitcoin-git has joined #bitcoin-core-dev
3752020-01-29T23:15:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
3762020-01-29T23:15:57  *** bitcoin-git has left #bitcoin-core-dev
3772020-01-29T23:36:51  *** timothy has quit IRC
3782020-01-29T23:41:14  *** rex4539 has quit IRC