12020-02-03T00:00:02 *** ChrisMarquardt has quit IRC
22020-02-03T00:17:19 *** dhart has joined #bitcoin-core-dev
32020-02-03T00:22:37 *** Meee3333 has joined #bitcoin-core-dev
42020-02-03T00:29:39 *** selevit has quit IRC
52020-02-03T00:33:37 *** selevit has joined #bitcoin-core-dev
62020-02-03T00:38:08 *** selevit has quit IRC
72020-02-03T00:42:42 *** selevit has joined #bitcoin-core-dev
82020-02-03T00:47:38 *** selevit has quit IRC
92020-02-03T00:51:47 *** selevit has joined #bitcoin-core-dev
102020-02-03T00:54:24 *** tsujp has quit IRC
112020-02-03T00:56:20 *** selevit has quit IRC
122020-02-03T01:00:53 *** selevit has joined #bitcoin-core-dev
132020-02-03T01:09:10 *** DeanWeen has quit IRC
142020-02-03T01:10:09 *** DeanWeen has joined #bitcoin-core-dev
152020-02-03T01:10:33 *** promag_ has joined #bitcoin-core-dev
162020-02-03T01:15:08 *** promag_ has quit IRC
172020-02-03T01:18:28 *** promag has quit IRC
182020-02-03T01:51:51 *** promag has joined #bitcoin-core-dev
192020-02-03T01:56:26 *** promag has quit IRC
202020-02-03T02:01:43 *** sdaftuar has quit IRC
212020-02-03T02:02:12 *** dviola has quit IRC
222020-02-03T02:03:01 *** sdaftuar has joined #bitcoin-core-dev
232020-02-03T02:07:30 <kallewoof> gwillen: weird!
242020-02-03T02:14:19 *** waxwing has quit IRC
252020-02-03T02:14:36 *** waxwing has joined #bitcoin-core-dev
262020-02-03T02:32:31 *** waxwing has quit IRC
272020-02-03T02:44:43 *** mryandao has quit IRC
282020-02-03T02:45:43 *** mryandao has joined #bitcoin-core-dev
292020-02-03T02:50:33 *** inoor has joined #bitcoin-core-dev
302020-02-03T02:56:30 *** waxwing has joined #bitcoin-core-dev
312020-02-03T03:00:02 *** dhart has quit IRC
322020-02-03T03:00:59 *** abrissbi1ne has joined #bitcoin-core-dev
332020-02-03T03:04:24 *** abrissbirne has quit IRC
342020-02-03T03:14:12 *** waxwing has quit IRC
352020-02-03T03:14:24 *** waxwing has joined #bitcoin-core-dev
362020-02-03T03:17:31 *** ds has joined #bitcoin-core-dev
372020-02-03T03:34:29 *** glaksmono has joined #bitcoin-core-dev
382020-02-03T03:39:45 *** waxwing has quit IRC
392020-02-03T03:40:19 *** waxwing has joined #bitcoin-core-dev
402020-02-03T03:41:11 *** cadwgan has joined #bitcoin-core-dev
412020-02-03T04:00:50 *** belcher has quit IRC
422020-02-03T04:02:59 *** bitcoin-git has joined #bitcoin-core-dev
432020-02-03T04:03:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d0e532ae029...365c83e6a839
442020-02-03T04:03:00 <bitcoin-git> bitcoin/master 9a299a5 Jon Atack: net: reference instead of copy in BlockConnected range loop
452020-02-03T04:03:01 <bitcoin-git> bitcoin/master 365c83e fanquake: Merge #18054: net: reference instead of copy in BlockConnected range loop
462020-02-03T04:03:03 *** bitcoin-git has left #bitcoin-core-dev
472020-02-03T04:03:08 *** Eagle[TM] has joined #bitcoin-core-dev
482020-02-03T04:03:19 *** bitcoin-git has joined #bitcoin-core-dev
492020-02-03T04:03:19 <bitcoin-git> [bitcoin] fanquake merged pull request #18054: net: reference instead of copy in BlockConnected range loop (master...block-connected-ref-instead-of-copy) https://github.com/bitcoin/bitcoin/pull/18054
502020-02-03T04:03:20 *** bitcoin-git has left #bitcoin-core-dev
512020-02-03T04:05:00 *** EagleTM has quit IRC
522020-02-03T04:48:28 *** cadwgan has quit IRC
532020-02-03T05:01:20 *** EagleTM has joined #bitcoin-core-dev
542020-02-03T05:03:53 *** Eagle[TM] has quit IRC
552020-02-03T05:38:18 *** bitcoin-git has joined #bitcoin-core-dev
562020-02-03T05:38:19 <bitcoin-git> [bitcoin] fanquake closed pull request #17958: rpc: query general daemon information via RPC (master...rpc-implement-getgeneralinfo) https://github.com/bitcoin/bitcoin/pull/17958
572020-02-03T05:38:19 *** bitcoin-git has left #bitcoin-core-dev
582020-02-03T05:49:44 *** GagahPerkasa has joined #bitcoin-core-dev
592020-02-03T05:52:39 *** jeremyrubin has joined #bitcoin-core-dev
602020-02-03T06:00:01 *** ds has quit IRC
612020-02-03T06:00:27 *** TheHoliestRoger has quit IRC
622020-02-03T06:01:24 *** TheHoliestRoger has joined #bitcoin-core-dev
632020-02-03T06:15:55 *** yar1 has joined #bitcoin-core-dev
642020-02-03T06:19:55 *** selevit has quit IRC
652020-02-03T06:20:22 *** selevit has joined #bitcoin-core-dev
662020-02-03T06:22:57 *** bitcoin-git has joined #bitcoin-core-dev
672020-02-03T06:22:57 <bitcoin-git> [bitcoin] fanquake opened pull request #18059: build: add missing attributes to Win installer (master...win_installer_attributes) https://github.com/bitcoin/bitcoin/pull/18059
682020-02-03T06:22:58 *** bitcoin-git has left #bitcoin-core-dev
692020-02-03T06:25:17 *** selevit has quit IRC
702020-02-03T06:26:38 *** bitcoin-git has joined #bitcoin-core-dev
712020-02-03T06:26:38 <bitcoin-git> [bitcoin] fanquake closed pull request #16233: WIP: add basic semaphore2 CI (master...master) https://github.com/bitcoin/bitcoin/pull/16233
722020-02-03T06:26:39 *** bitcoin-git has left #bitcoin-core-dev
732020-02-03T06:29:28 *** selevit has joined #bitcoin-core-dev
742020-02-03T06:36:01 *** Guyver2 has joined #bitcoin-core-dev
752020-02-03T06:40:13 <gwillen> kallewoof: not that weird, Apple hates backwards compatibility almost as much as Microsoft loves it
762020-02-03T06:58:23 *** manantial has joined #bitcoin-core-dev
772020-02-03T06:59:22 *** Highway61 has joined #bitcoin-core-dev
782020-02-03T07:19:36 *** Guyver2 has quit IRC
792020-02-03T07:26:23 *** EagleTM has quit IRC
802020-02-03T07:26:59 *** DaleBewan has joined #bitcoin-core-dev
812020-02-03T07:40:57 *** DaleBewan has quit IRC
822020-02-03T07:43:03 *** vasild has quit IRC
832020-02-03T07:45:10 *** vasild has joined #bitcoin-core-dev
842020-02-03T07:50:53 *** glaksmono has quit IRC
852020-02-03T08:00:41 *** DaleBewan has joined #bitcoin-core-dev
862020-02-03T08:02:39 *** promag has joined #bitcoin-core-dev
872020-02-03T08:02:42 *** abrissbi1ne is now known as abrissbirne
882020-02-03T08:05:03 *** DaleBewan has quit IRC
892020-02-03T08:06:28 *** promag has quit IRC
902020-02-03T08:14:11 *** morcos has quit IRC
912020-02-03T08:14:29 *** morcos has joined #bitcoin-core-dev
922020-02-03T08:25:23 *** alec has quit IRC
932020-02-03T08:26:56 *** alec has joined #bitcoin-core-dev
942020-02-03T08:38:23 *** DaleBewan has joined #bitcoin-core-dev
952020-02-03T08:43:08 *** selevit has quit IRC
962020-02-03T08:49:02 *** selevit has joined #bitcoin-core-dev
972020-02-03T09:00:01 *** yar1 has quit IRC
982020-02-03T09:08:16 *** EagleTM has joined #bitcoin-core-dev
992020-02-03T09:17:28 *** toony1 has joined #bitcoin-core-dev
1002020-02-03T09:25:27 *** selevit has quit IRC
1012020-02-03T09:26:22 *** selevit has joined #bitcoin-core-dev
1022020-02-03T09:37:34 *** jcoe has joined #bitcoin-core-dev
1032020-02-03T09:37:38 *** jcoe has quit IRC
1042020-02-03T09:39:55 *** GagahPerkasa has quit IRC
1052020-02-03T09:41:03 <wumpus> same for apple users
1062020-02-03T09:41:42 <wumpus> (fortunately, because it's more or less impossible to support old apple stuff sanely)
1072020-02-03T09:44:58 *** promag has joined #bitcoin-core-dev
1082020-02-03T09:45:08 <kallewoof> when I was doing ios stuff, as long as you picked the older SDK things tended to just work most of the time (not always tho).
1092020-02-03T09:47:49 *** jcoe has joined #bitcoin-core-dev
1102020-02-03T09:48:15 *** Zenton has joined #bitcoin-core-dev
1112020-02-03T09:51:26 *** inoor has quit IRC
1122020-02-03T10:06:40 *** spinza has quit IRC
1132020-02-03T10:16:07 *** AaronvanW has joined #bitcoin-core-dev
1142020-02-03T10:28:08 *** turbo_choo has quit IRC
1152020-02-03T10:32:06 <wumpus> it's definitely possible, just a lot of work navigating the maze of deprecations and API churn
1162020-02-03T10:32:38 *** Guyver2 has joined #bitcoin-core-dev
1172020-02-03T10:33:49 *** PaulTroon has joined #bitcoin-core-dev
1182020-02-03T10:46:08 *** masterdonx2 has quit IRC
1192020-02-03T10:46:08 *** MasterdonX has joined #bitcoin-core-dev
1202020-02-03T10:51:38 *** EagleTM has quit IRC
1212020-02-03T10:54:59 *** PaulTroon has quit IRC
1222020-02-03T10:55:30 *** bitcoin-git has joined #bitcoin-core-dev
1232020-02-03T10:55:31 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/365c83e6a839...b2df21b32ca9
1242020-02-03T10:55:31 <bitcoin-git> bitcoin/master 2ccb7cc Jeremy Rubin: Add Epoch Guards to CTXMemPoolEntry and CTxMemPool
1252020-02-03T10:55:32 <bitcoin-git> bitcoin/master bd5a026 Jeremy Rubin: Make UpdateTransactionsFromBlock use Epochs
1262020-02-03T10:55:32 <bitcoin-git> bitcoin/master b2df21b Wladimir J. van der Laan: Merge #17925: Improve UpdateTransactionsFromBlock with Epochs
1272020-02-03T10:55:37 *** turbo_choo has joined #bitcoin-core-dev
1282020-02-03T10:55:42 *** bitcoin-git has left #bitcoin-core-dev
1292020-02-03T10:56:00 *** bitcoin-git has joined #bitcoin-core-dev
1302020-02-03T10:56:00 <bitcoin-git> [bitcoin] laanwj merged pull request #17925: Improve UpdateTransactionsFromBlock with Epochs (master...epoch-mempool-clean-split) https://github.com/bitcoin/bitcoin/pull/17925
1312020-02-03T10:56:12 *** bitcoin-git has left #bitcoin-core-dev
1322020-02-03T11:03:50 *** Dalton76Lueilwit has joined #bitcoin-core-dev
1332020-02-03T11:16:59 *** dr-orlovsky has quit IRC
1342020-02-03T11:18:59 *** kristapsk_ has joined #bitcoin-core-dev
1352020-02-03T11:20:49 <aj> oh no, i got @'ed in 17925's merge
1362020-02-03T11:21:23 *** kristapsk has quit IRC
1372020-02-03T11:24:03 *** kristapsk_ has quit IRC
1382020-02-03T11:29:08 *** bitcoin-git has joined #bitcoin-core-dev
1392020-02-03T11:29:08 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b2df21b32ca9...651e34388832
1402020-02-03T11:29:09 <bitcoin-git> bitcoin/master 0a50019 Matt Corallo: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid
1412020-02-03T11:29:10 <bitcoin-git> bitcoin/master 651e343 Wladimir J. van der Laan: Merge #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is i...
1422020-02-03T11:29:11 *** bitcoin-git has left #bitcoin-core-dev
1432020-02-03T11:29:49 *** bitcoin-git has joined #bitcoin-core-dev
1442020-02-03T11:29:49 <bitcoin-git> [bitcoin] laanwj merged pull request #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid (master...2019-09-better-header-knowledge) https://github.com/bitcoin/bitcoin/pull/16974
1452020-02-03T11:29:50 *** bitcoin-git has left #bitcoin-core-dev
1462020-02-03T11:34:52 <fanquake> aj: ugh. Along with a bunch of others in the ajonas comment
1472020-02-03T11:35:56 <jonatack> perhaps the merge script should discount "acks" as opposed to "ack"
1482020-02-03T11:36:16 *** PaulTroon has joined #bitcoin-core-dev
1492020-02-03T11:36:17 <wumpus> ugh
1502020-02-03T11:36:24 <wumpus> btw is #16392 ready now?
1512020-02-03T11:36:27 <gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake · Pull Request #16392 · bitcoin/bitcoin · GitHub
1522020-02-03T11:36:43 <wumpus> looks like the travis passed so it's getting the SDK from the right place?
1532020-02-03T11:36:44 <fanquake> wumpus I haven't pushed yet. Can do in a minute
1542020-02-03T11:36:50 <wumpus> oh
1552020-02-03T11:36:52 <fanquake> Did you restart travis?
1562020-02-03T11:37:10 <wumpus> travis was running on it a few minutes ago
1572020-02-03T11:37:14 <wumpus> I didn't!
1582020-02-03T11:37:29 <fanquake> heh neither
1592020-02-03T11:37:42 <wumpus> fanquake: jonatack: looks like the merge script doesn't warn about @ in ACK comments as it does in the PR description
1602020-02-03T11:38:34 <fanquake> Yea, that wasn't even an actual ACK either. Just a comment mentioning who had and hadn't.
1612020-02-03T11:39:16 <fanquake> Guess I can rebase #17800 on top of that now as well
1622020-02-03T11:39:18 <gribble> https://github.com/bitcoin/bitcoin/issues/17800 | random: dont special case clock usage on macOS by fanquake · Pull Request #17800 · bitcoin/bitcoin · GitHub
1632020-02-03T11:39:18 *** Dalton76Lueilwit has quit IRC
1642020-02-03T11:40:02 <wumpus> travis for #16392 ran "8 minutes ago" https://travis-ci.org/bitcoin/bitcoin/builds/639312311?utm_source=github_status&utm_medium=notification
1652020-02-03T11:40:05 <gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake · Pull Request #16392 · bitcoin/bitcoin · GitHub
1662020-02-03T11:40:28 <wumpus> fanquake: oh it misdetected it, oops
1672020-02-03T11:40:56 <fanquake> I see "--sysroot /home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.14.sdk object... (cached) ok" in the logs.
1682020-02-03T11:41:13 <fanquake> but I'd like to push again anyways.
1692020-02-03T11:43:57 <wumpus> ok
1702020-02-03T11:46:00 *** emilengler has joined #bitcoin-core-dev
1712020-02-03T11:50:53 <jonatack> wumpus: right, looking at it rn
1722020-02-03T11:51:34 *** belcher has joined #bitcoin-core-dev
1732020-02-03T12:00:01 *** toony1 has quit IRC
1742020-02-03T12:03:44 <wumpus> jonatack: thank you!
1752020-02-03T12:05:59 <fanquake> wumpus: there's been some activity in binutils in regards to PE binaries and ASLR (#8248): https://sourceware.org/bugzilla/show_bug.cgi?id=19011#c9
1762020-02-03T12:06:01 <gribble> https://github.com/bitcoin/bitcoin/issues/8248 | ASLR seems not to be working as it should on Windows · Issue #8248 · bitcoin/bitcoin · GitHub
1772020-02-03T12:07:15 <fanquake> They've added a --enable-reloc-section flag, which we'll eventually get as part of --dynamicbase and/or --high-entropy-va
1782020-02-03T12:07:23 <elichai2> Do we save rejected(prev-blk-not-found) orphan blocks so we have them in case the parent appears? or do we discard them?
1792020-02-03T12:07:43 <elichai2> (looking at BlockManager::AcceptBlockHeader it seems like they're not saved)
1802020-02-03T12:10:50 <wumpus> no, rejected blocks are never saved, we never request blocks with unknown parent, also this would be a trivial DoS
1812020-02-03T12:11:25 <wumpus> fanquake: good to know mingw-w64 is making progress on that at least!
1822020-02-03T12:12:06 <elichai2> wumpus: hmm makes sense. forgot for a sec about the headers first :)
1832020-02-03T12:17:29 *** SteveMcIntyre1 has joined #bitcoin-core-dev
1842020-02-03T12:19:13 *** spinza has joined #bitcoin-core-dev
1852020-02-03T12:22:10 <jonatack> wumpus: simple proposal to warn if @ in ACK messages https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/51/
1862020-02-03T12:31:24 *** waxwing has quit IRC
1872020-02-03T12:32:17 *** waxwing has joined #bitcoin-core-dev
1882020-02-03T12:33:30 *** waxwing has quit IRC
1892020-02-03T12:34:04 *** waxwing has joined #bitcoin-core-dev
1902020-02-03T12:36:12 *** waxwing has quit IRC
1912020-02-03T12:36:29 *** waxwing has joined #bitcoin-core-dev
1922020-02-03T12:52:45 *** Guyver2 has quit IRC
1932020-02-03T12:53:16 *** promag has quit IRC
1942020-02-03T13:21:28 *** Guyver2 has joined #bitcoin-core-dev
1952020-02-03T13:23:45 *** promag has joined #bitcoin-core-dev
1962020-02-03T13:28:19 *** promag has quit IRC
1972020-02-03T13:36:36 *** IGHOR has quit IRC
1982020-02-03T13:45:53 *** promag has joined #bitcoin-core-dev
1992020-02-03T13:55:57 *** IGHOR has joined #bitcoin-core-dev
2002020-02-03T14:01:07 *** Highway62 has joined #bitcoin-core-dev
2012020-02-03T14:02:14 *** Highway61 has quit IRC
2022020-02-03T14:02:14 *** Highway62 is now known as Highway61
2032020-02-03T14:06:45 *** dr-orlovsky has joined #bitcoin-core-dev
2042020-02-03T14:12:16 *** promag has quit IRC
2052020-02-03T14:16:07 *** vincenzopalazzo has joined #bitcoin-core-dev
2062020-02-03T14:20:22 *** Highway62 has joined #bitcoin-core-dev
2072020-02-03T14:21:31 *** promag has joined #bitcoin-core-dev
2082020-02-03T14:22:35 *** Highway61 has quit IRC
2092020-02-03T14:22:35 *** Highway62 is now known as Highway61
2102020-02-03T14:24:09 *** DaleBewa_ has joined #bitcoin-core-dev
2112020-02-03T14:28:29 *** DaleBewan has quit IRC
2122020-02-03T14:29:29 *** promag_ has joined #bitcoin-core-dev
2132020-02-03T14:30:29 <elichai2> Looking for things to work on :) any suggestions are wellcome
2142020-02-03T14:31:04 <emilengler> elichai2: Check out good first issues
2152020-02-03T14:31:09 <emilengler> Or in general any issue :P
2162020-02-03T14:31:55 <emilengler> Also reviewing PRs is never wrong also because the PR stack is growing and growing
2172020-02-03T14:33:02 *** timothy has joined #bitcoin-core-dev
2182020-02-03T14:33:55 <elichai2> emilengler: I try to review all the PRs I feel like I have enough knowledge to review. but that's the thing, writing code is a great way to gain knowledge in new parts of the code (which I find harder by "just" reviewing - easier to miss things that you couldn't by writing code (ie tests would fail)). i'll go through the open issues again
2192020-02-03T14:34:18 *** promag_ has quit IRC
2202020-02-03T14:43:11 <promag> elichai2: I find reviewing better to learn - checkout branch/commit-by-commit, build, run, etc
2212020-02-03T14:47:30 <emilengler> I agree with promag, looking up definitons, etc. gives you better understanding of the src
2222020-02-03T14:48:20 <emilengler> Also playing a bit around and modifying the patch to better see what it does is a good approach, at least for me.
2232020-02-03T14:49:57 *** vincenzopalazzo has quit IRC
2242020-02-03T14:50:41 *** dr-orlovsky has quit IRC
2252020-02-03T14:50:53 *** bitcoin-git has joined #bitcoin-core-dev
2262020-02-03T14:50:54 <bitcoin-git> [bitcoin] promag opened pull request #18060: gui: Drop PeerTableModel dependency to ClientModel (master...2020-02-peertablemodel) https://github.com/bitcoin/bitcoin/pull/18060
2272020-02-03T14:50:55 *** bitcoin-git has left #bitcoin-core-dev
2282020-02-03T14:52:13 <elichai2> well sadly people are different and I learn best by writing :/
2292020-02-03T14:55:06 *** dr-orlovsky has joined #bitcoin-core-dev
2302020-02-03T15:00:02 *** SteveMcIntyre1 has quit IRC
2312020-02-03T15:09:29 *** dr-orlovsky has quit IRC
2322020-02-03T15:09:43 *** alec has quit IRC
2332020-02-03T15:14:01 *** alec has joined #bitcoin-core-dev
2342020-02-03T15:17:20 *** regis_ has joined #bitcoin-core-dev
2352020-02-03T15:36:13 *** emilengler has quit IRC
2362020-02-03T15:43:05 <jonatack> elichai2: some ideas: improve the asmap unit tests, see jamesob review comments in #16702
2372020-02-03T15:43:10 <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
2382020-02-03T15:43:35 <jonatack> elichai2: also some good stuff is up for grabs, like #16323 and #16324 by BlueMatt
2392020-02-03T15:43:38 <gribble> https://github.com/bitcoin/bitcoin/issues/16323 | Call ProcessNewBlock() asynchronously by TheBlueMatt · Pull Request #16323 · bitcoin/bitcoin · GitHub
2402020-02-03T15:43:41 <gribble> https://github.com/bitcoin/bitcoin/issues/16324 | Get cs_main out of the critical path in ProcessMessages by TheBlueMatt · Pull Request #16324 · bitcoin/bitcoin · GitHub
2412020-02-03T15:47:29 <jonatack> basically anything labeled up for grabs: https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Up+for+grabs%22+
2422020-02-03T15:55:45 <jonatack> (of course, review is not only really needed, it's also a good way to see things to do)
2432020-02-03T15:56:03 *** selevit has quit IRC
2442020-02-03T16:02:08 *** gkrizek has quit IRC
2452020-02-03T16:06:39 *** selevit has joined #bitcoin-core-dev
2462020-02-03T16:10:20 *** gkrizek has joined #bitcoin-core-dev
2472020-02-03T16:11:08 *** selevit has quit IRC
2482020-02-03T16:17:40 *** DaleBewa_ has quit IRC
2492020-02-03T16:18:39 *** DaleBewan has joined #bitcoin-core-dev
2502020-02-03T16:20:45 *** selevit has joined #bitcoin-core-dev
2512020-02-03T16:23:32 *** DaleBewan has quit IRC
2522020-02-03T16:28:07 *** andrewtoth has joined #bitcoin-core-dev
2532020-02-03T16:29:22 *** pncl has joined #bitcoin-core-dev
2542020-02-03T16:31:26 *** pncl has quit IRC
2552020-02-03T16:36:43 *** DaleBewan has joined #bitcoin-core-dev
2562020-02-03T16:37:17 *** DaleBewan has quit IRC
2572020-02-03T16:37:46 *** DaleBewan has joined #bitcoin-core-dev
2582020-02-03T16:42:34 *** DaleBewan has quit IRC
2592020-02-03T16:44:45 <elichai2> thanks
2602020-02-03T16:45:50 *** selevit has quit IRC
2612020-02-03T16:49:57 *** selevit has joined #bitcoin-core-dev
2622020-02-03T16:50:07 *** SiAnDoG__ has quit IRC
2632020-02-03T16:50:08 *** DaleBewan has joined #bitcoin-core-dev
2642020-02-03T16:50:33 *** SiAnDoG__ has joined #bitcoin-core-dev
2652020-02-03T16:54:28 *** selevit has quit IRC
2662020-02-03T16:54:53 *** DaleBewan has quit IRC
2672020-02-03T16:55:19 *** Talkless has joined #bitcoin-core-dev
2682020-02-03T16:59:00 *** selevit has joined #bitcoin-core-dev
2692020-02-03T17:10:03 *** sipa_ has quit IRC
2702020-02-03T17:11:55 *** sipa has joined #bitcoin-core-dev
2712020-02-03T17:18:44 *** jorijn has joined #bitcoin-core-dev
2722020-02-03T17:19:20 <petezz4> ð @jorijn
2732020-02-03T17:20:24 *** andrewtoth_ has joined #bitcoin-core-dev
2742020-02-03T17:20:25 <jorijn> Hi!
2752020-02-03T17:20:57 *** andrewtoth has quit IRC
2762020-02-03T17:28:18 *** DaleBewan has joined #bitcoin-core-dev
2772020-02-03T17:53:40 *** selevit has quit IRC
2782020-02-03T17:59:59 *** DaleBewan has quit IRC
2792020-02-03T18:00:02 *** regis_ has quit IRC
2802020-02-03T18:00:11 *** DaleBewan has joined #bitcoin-core-dev
2812020-02-03T18:07:03 *** selevit has joined #bitcoin-core-dev
2822020-02-03T18:12:10 *** selevit has quit IRC
2832020-02-03T18:16:43 *** sdaftuar has quit IRC
2842020-02-03T18:17:16 *** sammuel86 has joined #bitcoin-core-dev
2852020-02-03T18:25:08 *** selevit has joined #bitcoin-core-dev
2862020-02-03T18:26:02 *** jeremyrubin has quit IRC
2872020-02-03T18:39:18 *** Highway61 has quit IRC
2882020-02-03T18:41:58 *** kristapsk has joined #bitcoin-core-dev
2892020-02-03T18:44:40 *** Zenton has quit IRC
2902020-02-03T18:45:02 *** alec has quit IRC
2912020-02-03T18:45:13 *** alec has joined #bitcoin-core-dev
2922020-02-03T18:48:33 *** selevit has quit IRC
2932020-02-03T18:49:32 *** selevit has joined #bitcoin-core-dev
2942020-02-03T18:52:59 *** vincenzopalazzo has joined #bitcoin-core-dev
2952020-02-03T18:56:36 *** jkczyz has left #bitcoin-core-dev
2962020-02-03T19:00:14 *** jkczyz has joined #bitcoin-core-dev
2972020-02-03T19:01:39 *** timothy has quit IRC
2982020-02-03T19:01:56 *** selevit has quit IRC
2992020-02-03T19:03:07 *** bitcoin-git has joined #bitcoin-core-dev
3002020-02-03T19:03:07 <bitcoin-git> [bitcoin] elichai opened pull request #18061: util: Reimplement DecodeBase32/64 with std::string to remove `strlen` (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
3012020-02-03T19:03:08 *** bitcoin-git has left #bitcoin-core-dev
3022020-02-03T19:05:47 *** selevit has joined #bitcoin-core-dev
3032020-02-03T19:09:33 *** Highway61 has joined #bitcoin-core-dev
3042020-02-03T19:13:21 *** timothy has joined #bitcoin-core-dev
3052020-02-03T19:14:51 *** pncl has joined #bitcoin-core-dev
3062020-02-03T19:23:53 *** sdaftuar has joined #bitcoin-core-dev
3072020-02-03T19:27:43 *** emilengler has joined #bitcoin-core-dev
3082020-02-03T19:30:06 *** selevit has quit IRC
3092020-02-03T19:35:35 *** promag_ has joined #bitcoin-core-dev
3102020-02-03T19:40:16 *** vasild_ has joined #bitcoin-core-dev
3112020-02-03T19:40:23 *** promag_ has quit IRC
3122020-02-03T19:41:13 <hebasto> MarcoFalke: close #8225 ?
3132020-02-03T19:41:14 <gribble> https://github.com/bitcoin/bitcoin/issues/8225 | Minimise/close and startup bugs · Issue #8225 · bitcoin/bitcoin · GitHub
3142020-02-03T19:42:06 *** vasild_ has quit IRC
3152020-02-03T19:43:03 *** vasild has quit IRC
3162020-02-03T19:43:30 *** selevit has joined #bitcoin-core-dev
3172020-02-03T19:47:01 *** jcoe has quit IRC
3182020-02-03T19:52:54 *** jcoe has joined #bitcoin-core-dev
3192020-02-03T19:59:13 *** Victorsueca has quit IRC
3202020-02-03T20:02:06 *** EagleTM has joined #bitcoin-core-dev
3212020-02-03T20:04:18 *** filchef has joined #bitcoin-core-dev
3222020-02-03T20:06:12 *** bitcoin-git has joined #bitcoin-core-dev
3232020-02-03T20:06:13 <bitcoin-git> [bitcoin] promag opened pull request #18062: gui: Fix unintialized WalletView::progressDialog (master...2020-02-fix-unitialized-progressDialog) https://github.com/bitcoin/bitcoin/pull/18062
3242020-02-03T20:06:14 *** bitcoin-git has left #bitcoin-core-dev
3252020-02-03T20:06:55 *** Victorsueca has joined #bitcoin-core-dev
3262020-02-03T20:07:58 *** selevit has quit IRC
3272020-02-03T20:08:13 *** Talkless has quit IRC
3282020-02-03T20:08:26 *** selevit has joined #bitcoin-core-dev
3292020-02-03T20:14:05 *** pncl has quit IRC
3302020-02-03T20:18:31 *** promag has quit IRC
3312020-02-03T20:18:54 *** pncl has joined #bitcoin-core-dev
3322020-02-03T20:34:10 *** DaleBewan has quit IRC
3332020-02-03T20:34:41 *** DaleBewan has joined #bitcoin-core-dev
3342020-02-03T20:35:31 *** kristapsk has quit IRC
3352020-02-03T20:35:58 *** kristapsk has joined #bitcoin-core-dev
3362020-02-03T20:43:14 *** pncl has quit IRC
3372020-02-03T20:43:31 *** pncl has joined #bitcoin-core-dev
3382020-02-03T20:48:22 *** Highway61 has quit IRC
3392020-02-03T20:48:59 *** Highway61 has joined #bitcoin-core-dev
3402020-02-03T20:52:55 *** jeremyrubin has joined #bitcoin-core-dev
3412020-02-03T20:56:47 *** Highway61 has quit IRC
3422020-02-03T20:57:41 *** Highway61 has joined #bitcoin-core-dev
3432020-02-03T20:58:54 *** Zenton has joined #bitcoin-core-dev
3442020-02-03T21:00:02 *** sammuel86 has quit IRC
3452020-02-03T21:01:56 *** Highway61 has quit IRC
3462020-02-03T21:02:19 *** Highway61 has joined #bitcoin-core-dev
3472020-02-03T21:04:32 *** promag has joined #bitcoin-core-dev
3482020-02-03T21:06:47 *** Guyver2 has quit IRC
3492020-02-03T21:13:13 *** vincentpalazzo has joined #bitcoin-core-dev
3502020-02-03T21:16:13 *** vincenzopalazzo has quit IRC
3512020-02-03T21:17:43 *** goatpig has quit IRC
3522020-02-03T21:24:14 *** timothy has quit IRC
3532020-02-03T21:25:06 *** promag has quit IRC
3542020-02-03T21:27:22 *** bitcoin-git has joined #bitcoin-core-dev
3552020-02-03T21:27:22 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #18063: Improve UpdateForDescendants by using Epochs and Removing CacheMap (master...epoch-mempool-clean-split-2) https://github.com/bitcoin/bitcoin/pull/18063
3562020-02-03T21:27:23 *** bitcoin-git has left #bitcoin-core-dev
3572020-02-03T21:36:45 *** promag has joined #bitcoin-core-dev
3582020-02-03T21:37:11 *** promag has joined #bitcoin-core-dev
3592020-02-03T21:38:44 *** MarcoFalke has quit IRC
3602020-02-03T21:44:51 *** pncl has quit IRC
3612020-02-03T21:46:30 *** jdolan has joined #bitcoin-core-dev
3622020-02-03T21:58:22 *** bitcoin-git has joined #bitcoin-core-dev
3632020-02-03T21:58:22 <bitcoin-git> [bitcoin] promag opened pull request #18064: gui: Drop WalletModel dependency to RecentRequestsTableModel (master...2020-02-recentrequeststablemodel) https://github.com/bitcoin/bitcoin/pull/18064
3642020-02-03T21:58:23 *** bitcoin-git has left #bitcoin-core-dev
3652020-02-03T22:01:39 <promag> going to hold pushing more prs regarding circular dependency until existing ones are merged
3662020-02-03T22:07:07 *** selevit has quit IRC
3672020-02-03T22:07:52 *** selevit has joined #bitcoin-core-dev
3682020-02-03T22:10:03 *** andrewtoth_ has quit IRC
3692020-02-03T22:11:14 *** filchef has quit IRC
3702020-02-03T22:12:30 *** selevit has quit IRC
3712020-02-03T22:20:39 <hebasto> promag: \o/
3722020-02-03T22:20:49 <promag> lol :P
3732020-02-03T22:23:53 *** earlz is now known as waifutime
3742020-02-03T22:23:58 *** waifutime is now known as earlz
3752020-02-03T22:24:17 *** earlz is now known as waifutime
3762020-02-03T22:24:40 *** waifutime is now known as earlz
3772020-02-03T22:25:56 *** selevit has joined #bitcoin-core-dev
3782020-02-03T22:26:54 *** DaleBewa_ has joined #bitcoin-core-dev
3792020-02-03T22:26:55 *** DaleBewan has quit IRC
3802020-02-03T22:30:03 *** selevit has quit IRC
3812020-02-03T22:30:41 <jeremyrubin> Does anyone know what crypter parameters one might see in the wild? E.g. looking here
3822020-02-03T22:30:42 <jeremyrubin> https://github.com/bitcoin/bitcoin/blob/99813a9745fe10a58bedd7a4cb721faf14f907a4/src/wallet/crypter.h#L61
3832020-02-03T22:31:13 <jeremyrubin> If I were to see a value for nDeriveIterations that was not 25000 does anyone have any idea what sort of wallet would generate that
3842020-02-03T22:31:22 *** cryptapus has quit IRC
3852020-02-03T22:32:35 *** vincentpalazzo has quit IRC
3862020-02-03T22:33:32 <sipa> jeremyrubin: it's measured at encryption time
3872020-02-03T22:33:38 <sipa> if you have a faster machine, the number will be higher
3882020-02-03T22:33:48 <jeremyrubin> Ah I see
3892020-02-03T22:33:50 <jeremyrubin> that's funny
3902020-02-03T22:34:20 <phantomcircuit> jeremyrubin, means lots of them have very high numbers and are effectively un-bruteforceable
3912020-02-03T22:34:29 <phantomcircuit> like would take longer to attack and to guess keys at random
3922020-02-03T22:35:08 *** selevit has joined #bitcoin-core-dev
3932020-02-03T22:35:10 *** promag has quit IRC
3942020-02-03T22:35:25 *** cryptapus has joined #bitcoin-core-dev
3952020-02-03T22:35:25 *** cryptapus has quit IRC
3962020-02-03T22:35:25 *** cryptapus has joined #bitcoin-core-dev
3972020-02-03T22:36:08 <jeremyrubin> So it's this logic here https://github.com/bitcoin/bitcoin/blob/2d6e76af240969aa284cd4c3d376493988e218c2/src/wallet/wallet.cpp#L301
3982020-02-03T22:38:19 <jeremyrubin> so we start by doing a check with the default iters for timing, then scale to a second then redo it and save?
3992020-02-03T22:40:48 *** manantial has quit IRC
4002020-02-03T22:41:20 <sipa> yup
4012020-02-03T22:42:39 <midnight> ³/w gmax
4022020-02-03T22:44:53 *** Zenton has quit IRC
4032020-02-03T22:49:18 <jeremyrubin> Interesting... kinda weird that changing you passphrase on a older computer than when you set it originally would decrease security
4042020-02-03T22:49:25 <jeremyrubin> but other than that makes sense
4052020-02-03T22:49:33 <jeremyrubin> Maybe we should make it monotonically increase?
4062020-02-03T22:49:41 <jeremyrubin> May not be lower than a previously set value
4072020-02-03T23:12:25 *** emilengler has quit IRC
4082020-02-03T23:25:15 *** jcoe has quit IRC
4092020-02-03T23:34:38 *** turbo_choo has quit IRC
4102020-02-03T23:35:57 *** turbo_choo has joined #bitcoin-core-dev
4112020-02-03T23:43:57 *** promag has joined #bitcoin-core-dev
4122020-02-03T23:45:15 *** promag has joined #bitcoin-core-dev
4132020-02-03T23:45:48 *** Zenton has joined #bitcoin-core-dev
4142020-02-03T23:47:50 *** jeremyrubin has quit IRC
4152020-02-03T23:58:21 *** Zenton has quit IRC