12020-02-17T00:00:01 *** Voker571 has quit IRC
22020-02-17T00:17:59 *** matael1 has joined #bitcoin-core-dev
32020-02-17T00:20:07 *** promag has quit IRC
42020-02-17T00:20:47 *** promag has joined #bitcoin-core-dev
52020-02-17T00:25:39 *** promag has quit IRC
62020-02-17T00:30:52 *** promag has joined #bitcoin-core-dev
72020-02-17T00:38:26 *** AaronvanW has quit IRC
82020-02-17T00:40:43 *** asukan has joined #bitcoin-core-dev
92020-02-17T00:41:04 <promag> review/merge beg #13339
102020-02-17T00:41:08 <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
112020-02-17T00:46:43 *** promag has quit IRC
122020-02-17T00:52:05 *** sipsorcery has quit IRC
132020-02-17T00:52:34 *** sipsorcery has joined #bitcoin-core-dev
142020-02-17T00:57:56 *** Highway61 has quit IRC
152020-02-17T00:58:46 *** Highway61 has joined #bitcoin-core-dev
162020-02-17T00:59:49 *** asukan has quit IRC
172020-02-17T01:00:10 *** asukan has joined #bitcoin-core-dev
182020-02-17T01:02:18 *** promag has joined #bitcoin-core-dev
192020-02-17T01:02:27 *** promag_ has joined #bitcoin-core-dev
202020-02-17T01:08:51 *** promag has quit IRC
212020-02-17T01:11:39 *** sipsorcery has quit IRC
222020-02-17T01:12:11 *** promag_ has quit IRC
232020-02-17T01:14:58 *** Highway62 has joined #bitcoin-core-dev
242020-02-17T01:16:57 *** Highway61 has quit IRC
252020-02-17T01:16:57 *** Highway62 is now known as Highway61
262020-02-17T01:23:34 *** asukan has quit IRC
272020-02-17T01:23:55 *** asukan has joined #bitcoin-core-dev
282020-02-17T01:29:46 *** bitcoin-git has joined #bitcoin-core-dev
292020-02-17T01:29:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94c0287aec9a...263f53e2d07a
302020-02-17T01:29:47 <bitcoin-git> bitcoin/master fad027f MarcoFalke: scripted-diff: Add missing spaces in RPCResult, Fix type names
312020-02-17T01:29:48 <bitcoin-git> bitcoin/master 263f53e MarcoFalke: Merge #18098: scripted-diff: Add missing spaces in RPCResult, Normalize ty...
322020-02-17T01:29:49 *** bitcoin-git has left #bitcoin-core-dev
332020-02-17T01:30:06 *** bitcoin-git has joined #bitcoin-core-dev
342020-02-17T01:30:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18098: scripted-diff: Add missing spaces in RPCResult, Normalize type names (master...1912-rpcDocFixes) https://github.com/bitcoin/bitcoin/pull/18098
352020-02-17T01:30:08 *** bitcoin-git has left #bitcoin-core-dev
362020-02-17T01:38:32 *** promag has joined #bitcoin-core-dev
372020-02-17T01:42:51 *** promag has quit IRC
382020-02-17T01:50:55 *** gleb has quit IRC
392020-02-17T01:52:01 *** Highway61 has quit IRC
402020-02-17T01:52:38 *** gleb has joined #bitcoin-core-dev
412020-02-17T01:52:44 *** AaronvanW has joined #bitcoin-core-dev
422020-02-17T01:54:49 *** bitcoin-git has joined #bitcoin-core-dev
432020-02-17T01:54:49 <bitcoin-git> [bitcoin] luke-jr opened pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
442020-02-17T01:54:50 *** bitcoin-git has left #bitcoin-core-dev
452020-02-17T02:26:03 *** AaronvanW has quit IRC
462020-02-17T02:34:30 *** molly has joined #bitcoin-core-dev
472020-02-17T02:36:45 *** mol has quit IRC
482020-02-17T02:48:29 *** asukan has quit IRC
492020-02-17T03:00:01 *** matael1 has quit IRC
502020-02-17T03:01:01 *** abrissbi1ne has joined #bitcoin-core-dev
512020-02-17T03:04:08 *** abrissbirne has quit IRC
522020-02-17T03:18:02 *** xorAxAx has joined #bitcoin-core-dev
532020-02-17T03:31:34 *** asukan has joined #bitcoin-core-dev
542020-02-17T03:37:58 *** asukan has joined #bitcoin-core-dev
552020-02-17T03:49:11 *** felixfoertsch has joined #bitcoin-core-dev
562020-02-17T03:51:37 *** felixfoertsch23 has quit IRC
572020-02-17T04:23:13 *** AaronvanW has joined #bitcoin-core-dev
582020-02-17T04:28:08 *** Eagle[TM] has joined #bitcoin-core-dev
592020-02-17T04:30:53 *** EagleTM has quit IRC
602020-02-17T04:56:44 *** AaronvanW has quit IRC
612020-02-17T05:04:32 *** promag has joined #bitcoin-core-dev
622020-02-17T05:08:51 *** promag has quit IRC
632020-02-17T06:00:02 *** xorAxAx has quit IRC
642020-02-17T06:18:10 *** gholms1 has joined #bitcoin-core-dev
652020-02-17T06:50:22 *** justan0theruser has joined #bitcoin-core-dev
662020-02-17T06:53:23 *** justanotheruser has quit IRC
672020-02-17T06:53:49 *** AaronvanW has joined #bitcoin-core-dev
682020-02-17T07:23:48 *** Eagle[TM] has quit IRC
692020-02-17T07:26:51 *** AaronvanW has quit IRC
702020-02-17T07:29:00 *** manantial has joined #bitcoin-core-dev
712020-02-17T07:43:23 *** vasild has quit IRC
722020-02-17T07:45:20 *** vasild has joined #bitcoin-core-dev
732020-02-17T07:58:14 *** EagleTM has joined #bitcoin-core-dev
742020-02-17T08:04:16 *** vasild has quit IRC
752020-02-17T08:06:06 *** vasild has joined #bitcoin-core-dev
762020-02-17T08:09:58 *** Kiminuo has joined #bitcoin-core-dev
772020-02-17T08:13:38 *** mol has joined #bitcoin-core-dev
782020-02-17T08:15:17 *** promag has joined #bitcoin-core-dev
792020-02-17T08:16:31 *** molly has quit IRC
802020-02-17T08:25:55 *** EagleTM has quit IRC
812020-02-17T08:28:34 *** marcoagner has joined #bitcoin-core-dev
822020-02-17T08:30:03 *** ivycheeuf has quit IRC
832020-02-17T08:34:00 *** willcl_ark has quit IRC
842020-02-17T08:34:57 *** willcl_ark has joined #bitcoin-core-dev
852020-02-17T08:35:56 *** sipsorcery has joined #bitcoin-core-dev
862020-02-17T08:52:37 *** wumpus2 is now known as wumpus
872020-02-17T08:57:03 *** TheHoliestRoger has quit IRC
882020-02-17T08:57:53 *** TheHoliestRoger has joined #bitcoin-core-dev
892020-02-17T09:00:02 *** gholms1 has quit IRC
902020-02-17T09:06:43 *** Guyver2 has joined #bitcoin-core-dev
912020-02-17T09:07:20 *** yozaam has joined #bitcoin-core-dev
922020-02-17T09:12:25 *** jkk has joined #bitcoin-core-dev
932020-02-17T09:13:48 *** willcl_ark has quit IRC
942020-02-17T09:14:14 *** willcl_ark has joined #bitcoin-core-dev
952020-02-17T09:14:56 *** jkk has quit IRC
962020-02-17T09:17:58 *** dfreedm has joined #bitcoin-core-dev
972020-02-17T09:18:35 *** promag has quit IRC
982020-02-17T09:24:24 *** AaronvanW has joined #bitcoin-core-dev
992020-02-17T09:33:05 <jonasschnelli> Oh. I can macOS notarize the 0.19.1rc2 binary
1002020-02-17T09:33:06 <jonasschnelli> "message": "The executable does not have the hardened runtime enabled.",
1012020-02-17T09:34:05 <fanquake> jonasschnelli: likely need some additions to a .plist somewhere
1022020-02-17T09:34:19 <jonasschnelli> Probably... strange it worked with rc1?!
1032020-02-17T09:34:34 <fanquake> Interesting
1042020-02-17T09:35:43 <jonasschnelli> maybe they (Apple) just started to enforce it? dunno
1052020-02-17T09:35:55 <fanquake> I think that might be the case, was just trying to find the dates
1062020-02-17T09:36:12 <fanquake> It would have been January when you signed rc1 right? https://developer.apple.com/news/?id=09032019a
1072020-02-17T09:36:26 <fanquake> I assume now that it's Feb something has changed
1082020-02-17T09:38:16 <jonasschnelli> I notarized rc1 5 days ago and Sjors did confirm it worked: https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-585324648
1092020-02-17T09:38:48 <jonasschnelli> Interesting:
1102020-02-17T09:38:48 <jonasschnelli> https://osxapps-ssl.itunes.apple.com/itunes-assets/Enigma124/v4/70/50/9d/70509d8c-c1b2-5e0c-47fc-b0c5df5de7f0/developer_log.json?accessKey=1582126708_7042408886895258564_pAgS0zq76QE9xKf6bLXiRcUifSnsajT%2BOMaGiI2hapSXmKhFdNM%2BgQdCZPgc2Oq5bL7IjkoP1gQQVStu7TIxONtJdQm6jpMTLP%2FsLi2NUGmcycExtzhgKIFBnxbP2Xy1YwM12BR2jhOkh%2BpT3pyzcU1kKGTUBZNv3DdEfdnDWNE%3D
1112020-02-17T09:39:01 <jonasschnelli> Apple had just a warning for the rc1 for the hardening entitlements
1122020-02-17T09:40:57 <fanquake> hmm. I can PR the .plist requirements if you're not already working on it
1132020-02-17T09:45:31 <jonasschnelli> fanquake: Yes. Please do if you know how...
1142020-02-17T09:45:55 <jonasschnelli> There is eventually a flag we need to change during code signing...
1152020-02-17T09:45:59 <jonasschnelli> (just looking into it)
1162020-02-17T09:45:59 <jonasschnelli> OTHER_CODE_SIGN_FLAGS
1172020-02-17T09:46:02 <jonasschnelli> https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues
1182020-02-17T09:47:55 <jonasschnelli> I can't see a difference in the Info.plist when enabling hardening in a sample XCode project..
1192020-02-17T09:48:00 <jonasschnelli> I guess its more on the code signing level?
1202020-02-17T09:48:25 *** asukan has quit IRC
1212020-02-17T09:49:17 <fanquake> I think the changes might actually be in a separate .xml file
1222020-02-17T09:49:42 <fanquake> Which you pass to the codesigning tool
1232020-02-17T09:49:57 <jonasschnelli> https://devblogs.microsoft.com/xamarin/macos-hardened-runtime-notary/
1242020-02-17T09:50:06 <jonasschnelli> fanquake: I think so. Yes.
1252020-02-17T09:50:22 *** promag has joined #bitcoin-core-dev
1262020-02-17T09:50:39 <fanquake> Although we can add that to our tree with the other macdeploy files
1272020-02-17T09:50:47 *** achow101 has quit IRC
1282020-02-17T09:53:13 <jonasschnelli> fanquake: I guess we need `--options runtime` during codesign
1292020-02-17T09:53:19 <jonasschnelli> (detached-sig-create)
1302020-02-17T09:54:05 <jonasschnelli> fanquake: would be nice if you can investigate further and PR. We can make a testbuild for rc2 and make sure we land in rc3 or final
1312020-02-17T09:54:27 <fanquake> Sure. I can take a look at some changes.
1322020-02-17T09:54:59 *** achow101 has joined #bitcoin-core-dev
1332020-02-17T09:56:24 *** timothy has joined #bitcoin-core-dev
1342020-02-17T09:58:23 <wumpus> FWIW I'm not going to be at bitcoin 2020 / coredev next month, sorry, even less eager than normal to go on a long flight like that with the coronavirus and quarantaine scare
1352020-02-17T10:00:23 <jonasschnelli> I won't be there as well...
1362020-02-17T10:00:46 <wumpus> I don't have a good feeling about this tbh
1372020-02-17T10:01:40 <promag> wumpus: keep calm and enjoy merging #13339
1382020-02-17T10:01:44 <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
1392020-02-17T10:05:48 <wumpus> yes these are the times i'm quite happy to work remotely
1402020-02-17T10:07:10 <wumpus> jonasschnelli: glad to see the notarization worked
1412020-02-17T10:10:36 <fanquake> wumpus: If you want to get even more remote, feel free to come hang out on the farm. hah.
1422020-02-17T10:13:39 *** mol has quit IRC
1432020-02-17T10:15:57 *** jcoe has joined #bitcoin-core-dev
1442020-02-17T10:20:09 <wumpus> fanquake: thinking about it :)
1452020-02-17T10:32:51 *** AaronvanW has quit IRC
1462020-02-17T10:34:38 *** pingwindyktator has joined #bitcoin-core-dev
1472020-02-17T10:45:22 *** mol has joined #bitcoin-core-dev
1482020-02-17T11:00:34 *** bitcoin-git has joined #bitcoin-core-dev
1492020-02-17T11:00:35 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/263f53e2d07a...051439813e2c
1502020-02-17T11:00:36 <bitcoin-git> bitcoin/master 9a5b5ee João Barbosa: wallet: Replace %w by wallet name in -walletnotify script
1512020-02-17T11:00:37 <bitcoin-git> bitcoin/master 4e9efac João Barbosa: test: Check wallet name in -walletnotify script
1522020-02-17T11:00:37 <bitcoin-git> bitcoin/master 0514398 Wladimir J. van der Laan: Merge #13339: wallet: Replace %w by wallet name in -walletnotify script
1532020-02-17T11:00:39 *** bitcoin-git has left #bitcoin-core-dev
1542020-02-17T11:00:49 <promag> \o/
1552020-02-17T11:01:28 <promag> wumpus: I was kidding... that PR is really bad
1562020-02-17T11:01:59 *** bitcoin-git has joined #bitcoin-core-dev
1572020-02-17T11:01:59 <bitcoin-git> [bitcoin] laanwj merged pull request #13339: wallet: Replace %w by wallet name in -walletnotify script (master...2018-05-walletnotify) https://github.com/bitcoin/bitcoin/pull/13339
1582020-02-17T11:02:00 *** bitcoin-git has left #bitcoin-core-dev
1592020-02-17T11:02:35 <wumpus> worst PR ever
1602020-02-17T11:02:53 <promag> sorry heh
1612020-02-17T11:03:12 <wumpus> happy we got it over with though, that was one shedpainting party
1622020-02-17T11:03:29 <promag> curious about who is going to pick win support
1632020-02-17T11:03:55 <promag> not me!
1642020-02-17T11:03:58 *** Lambert82Morar has joined #bitcoin-core-dev
1652020-02-17T11:04:28 <promag> #18160
1662020-02-17T11:04:29 <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
1672020-02-17T11:04:53 <promag> this one might fix high cpu of bitcoin-qt
1682020-02-17T11:04:57 <wumpus> me neither, linux and BSD only here
1692020-02-17T11:05:13 <promag> so if you have a big wallet test let me know
1702020-02-17T11:06:08 *** bitcoin-git has joined #bitcoin-core-dev
1712020-02-17T11:06:09 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/051439813e2c...179504ccb6f4
1722020-02-17T11:06:09 <bitcoin-git> bitcoin/master 530d02a fanquake: build: pass -fno-ident in Windows gitian descriptor
1732020-02-17T11:06:10 <bitcoin-git> bitcoin/master 179504c Wladimir J. van der Laan: Merge #17948: build: pass -fno-ident in Windows gitian descriptor
1742020-02-17T11:06:12 *** bitcoin-git has left #bitcoin-core-dev
1752020-02-17T11:06:33 *** bitcoin-git has joined #bitcoin-core-dev
1762020-02-17T11:06:33 <bitcoin-git> [bitcoin] laanwj merged pull request #17948: build: pass -fno-ident in Windows gitian descriptor (master...pass_fno_ident) https://github.com/bitcoin/bitcoin/pull/17948
1772020-02-17T11:06:34 *** bitcoin-git has left #bitcoin-core-dev
1782020-02-17T11:06:45 <promag> I wasn't aware of MODEL_UPDATE_DELAY = 250ms
1792020-02-17T11:07:21 <promag> so we are calling GetBalances 4 times a second
1802020-02-17T11:07:24 *** AaronvanW has joined #bitcoin-core-dev
1812020-02-17T11:07:31 <promag> *always*
1822020-02-17T11:13:40 <wumpus> at least there should be a try_lock there so that lock contention won't hang the whole UI, but yea
1832020-02-17T11:19:54 <promag> don't get fooled with that try_lock
1842020-02-17T11:20:15 <promag> not waiting for locks is nice obviously
1852020-02-17T11:21:41 <wumpus> right it helps a bit but doesn't change that it's still bad to do that polling in the GUI thread
1862020-02-17T11:21:41 <promag> problem is after, if GetBalances takes some time, and also it's called for no good reason
1872020-02-17T11:22:47 <promag> right
1882020-02-17T11:23:21 <promag> also we are caching the last block height but we aren't checking for that as early as possible
1892020-02-17T11:24:09 <wumpus> mind that the balance can change without the block height changing
1902020-02-17T11:24:50 <wumpus> (e.g. if you send, or unconfirmed balance for unconfirmed incoming transactions)
1912020-02-17T11:25:16 <wumpus> then again that's always after a transaction
1922020-02-17T11:25:34 <promag> yeah, there's the force flag for that
1932020-02-17T11:25:35 <wumpus> I guess the polling is only needed if blocks changed
1942020-02-17T11:26:02 <wumpus> (e.g. coinbases becoming mature, transactions confirming)
1952020-02-17T11:26:11 <promag> and if locks couldn't be acquired
1962020-02-17T11:27:20 <promag> I'm planning to move the timer from walletmodel(s) to wallet controller, and move the calls to the background thread
1972020-02-17T11:27:30 <wumpus> makes sense
1982020-02-17T11:28:05 <promag> but that's a bigger change and I think 18160 improves a lot cpu usage and is an easy backport
1992020-02-17T11:28:14 <promag> let's see what jonasschnelli and ryanofsky say
2002020-02-17T11:55:29 *** masterdonx2 has quit IRC
2012020-02-17T11:55:54 *** promag has quit IRC
2022020-02-17T11:58:40 *** MasterdonX has joined #bitcoin-core-dev
2032020-02-17T12:00:01 *** dfreedm has quit IRC
2042020-02-17T12:09:15 *** promag has joined #bitcoin-core-dev
2052020-02-17T12:09:22 *** promag has quit IRC
2062020-02-17T12:12:45 *** promag_ has joined #bitcoin-core-dev
2072020-02-17T12:13:37 *** promag_ has quit IRC
2082020-02-17T12:13:49 *** promag_ has joined #bitcoin-core-dev
2092020-02-17T12:15:23 *** mhzesent has joined #bitcoin-core-dev
2102020-02-17T12:17:49 *** IOMonster1 has joined #bitcoin-core-dev
2112020-02-17T12:20:11 *** Lambert82Morar has quit IRC
2122020-02-17T12:52:42 *** promag_ has quit IRC
2132020-02-17T12:59:42 *** laurentmt has joined #bitcoin-core-dev
2142020-02-17T13:07:06 *** promag has joined #bitcoin-core-dev
2152020-02-17T13:09:00 *** promag has quit IRC
2162020-02-17T13:10:28 *** promag has joined #bitcoin-core-dev
2172020-02-17T13:17:56 *** promag has quit IRC
2182020-02-17T13:22:53 *** promag has joined #bitcoin-core-dev
2192020-02-17T13:28:13 *** laurentmt has quit IRC
2202020-02-17T13:31:19 *** promag has quit IRC
2212020-02-17T13:35:47 *** Guyver2 has quit IRC
2222020-02-17T13:35:51 *** Guyver2_ has joined #bitcoin-core-dev
2232020-02-17T13:39:25 *** mhzesent has quit IRC
2242020-02-17T13:47:39 *** jonatack has quit IRC
2252020-02-17T13:51:59 *** promag has joined #bitcoin-core-dev
2262020-02-17T13:59:10 *** promag has quit IRC
2272020-02-17T14:09:24 *** Highway61 has joined #bitcoin-core-dev
2282020-02-17T14:13:00 *** jonatack has joined #bitcoin-core-dev
2292020-02-17T14:21:13 *** promag has joined #bitcoin-core-dev
2302020-02-17T14:27:58 *** promag has quit IRC
2312020-02-17T14:38:27 *** fox2p has quit IRC
2322020-02-17T14:39:34 *** fox2p has joined #bitcoin-core-dev
2332020-02-17T14:46:17 *** promag has joined #bitcoin-core-dev
2342020-02-17T14:50:53 *** promag has quit IRC
2352020-02-17T14:53:58 *** promag has joined #bitcoin-core-dev
2362020-02-17T14:55:43 *** promag has quit IRC
2372020-02-17T14:56:32 *** promag has joined #bitcoin-core-dev
2382020-02-17T15:00:02 *** IOMonster1 has quit IRC
2392020-02-17T15:00:27 *** promag has quit IRC
2402020-02-17T15:02:54 *** promag has joined #bitcoin-core-dev
2412020-02-17T15:10:49 *** qubenix has quit IRC
2422020-02-17T15:11:23 *** qubenix has joined #bitcoin-core-dev
2432020-02-17T15:17:12 *** promag has quit IRC
2442020-02-17T15:18:11 *** kerbyu has joined #bitcoin-core-dev
2452020-02-17T15:18:46 *** promag has joined #bitcoin-core-dev
2462020-02-17T15:19:02 *** promag_ has joined #bitcoin-core-dev
2472020-02-17T15:19:05 *** promag has quit IRC
2482020-02-17T15:23:46 <luke-jr> wumpus: does RISC-V need #17569 backported? (why not?)
2492020-02-17T15:23:47 <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols and work around rv64 toolchain issue by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
2502020-02-17T15:29:47 *** qubenix has quit IRC
2512020-02-17T15:30:54 *** qubenix has joined #bitcoin-core-dev
2522020-02-17T15:31:24 <wumpus> luke-jr: couldn't hurt at least
2532020-02-17T15:37:31 *** Kiminuo has quit IRC
2542020-02-17T15:39:58 *** SiAnDoG has joined #bitcoin-core-dev
2552020-02-17T15:49:45 *** emilengler has joined #bitcoin-core-dev
2562020-02-17T16:05:14 *** promag_ has quit IRC
2572020-02-17T16:33:34 *** molly has joined #bitcoin-core-dev
2582020-02-17T16:37:16 *** mol has quit IRC
2592020-02-17T16:55:34 *** roconnor has quit IRC
2602020-02-17T17:02:25 <luke-jr> wumpus: well, it means a rc3⦠:/
2612020-02-17T17:03:11 <luke-jr> wumpus: if the rc2 binaries work on RISC-V as-is, then we don't need it in 0.19.1 at least
2622020-02-17T17:03:28 <luke-jr> (IIRC you have a RISC-V system to test on, right?)
2632020-02-17T17:06:19 *** Talkless has joined #bitcoin-core-dev
2642020-02-17T17:06:22 <luke-jr> (to be clear, it's the noexecstack commit that I'm unsure about - obviously gitian builds complete ;P)
2652020-02-17T17:06:36 <hebasto> promag: mind looking into #17966 ?
2662020-02-17T17:06:38 <gribble> https://github.com/bitcoin/bitcoin/issues/17966 | qt, refactor: Optimize signal-slot connections logic by hebasto · Pull Request #17966 · bitcoin/bitcoin · GitHub
2672020-02-17T17:11:20 *** Talkless has quit IRC
2682020-02-17T17:12:00 *** Talkless has joined #bitcoin-core-dev
2692020-02-17T17:15:35 *** Kiminuo has joined #bitcoin-core-dev
2702020-02-17T17:17:21 *** bsm1175321 has joined #bitcoin-core-dev
2712020-02-17T17:21:09 *** afk11 has quit IRC
2722020-02-17T17:21:27 *** afk11 has joined #bitcoin-core-dev
2732020-02-17T17:21:28 *** jcoe1 has joined #bitcoin-core-dev
2742020-02-17T17:21:39 *** jcoe has quit IRC
2752020-02-17T17:37:39 *** Highway61 has quit IRC
2762020-02-17T17:53:19 *** sipsorcery has quit IRC
2772020-02-17T17:55:12 *** promag has joined #bitcoin-core-dev
2782020-02-17T17:55:39 *** luke-jr has quit IRC
2792020-02-17T17:58:17 *** sipsorcery has joined #bitcoin-core-dev
2802020-02-17T17:58:40 *** promag has quit IRC
2812020-02-17T17:58:55 *** promag has joined #bitcoin-core-dev
2822020-02-17T18:00:01 *** kerbyu has quit IRC
2832020-02-17T18:02:46 *** Talkless has quit IRC
2842020-02-17T18:02:48 *** Kiminuo has quit IRC
2852020-02-17T18:03:11 *** Kiminuo has joined #bitcoin-core-dev
2862020-02-17T18:03:24 *** luke-jr has joined #bitcoin-core-dev
2872020-02-17T18:04:06 *** Highway61 has joined #bitcoin-core-dev
2882020-02-17T18:04:42 *** owowo has quit IRC
2892020-02-17T18:05:03 *** braydonf_ has quit IRC
2902020-02-17T18:05:27 *** justan0theruser has quit IRC
2912020-02-17T18:05:49 *** icota[m] has quit IRC
2922020-02-17T18:07:24 *** TheFuzzStone[m] has quit IRC
2932020-02-17T18:07:24 *** mrostecki has quit IRC
2942020-02-17T18:07:28 *** mael-rolland[m] has quit IRC
2952020-02-17T18:09:17 *** owowo has joined #bitcoin-core-dev
2962020-02-17T18:13:20 *** braydonf_ has joined #bitcoin-core-dev
2972020-02-17T18:14:30 *** justan0theruser has joined #bitcoin-core-dev
2982020-02-17T18:14:54 *** spinza has quit IRC
2992020-02-17T18:16:11 *** selenamarie has joined #bitcoin-core-dev
3002020-02-17T18:18:32 *** justan0theruser has quit IRC
3012020-02-17T18:21:37 *** mael-rolland[m] has joined #bitcoin-core-dev
3022020-02-17T18:21:44 *** justan0theruser has joined #bitcoin-core-dev
3032020-02-17T18:22:49 *** mol has joined #bitcoin-core-dev
3042020-02-17T18:24:23 *** icota[m] has joined #bitcoin-core-dev
3052020-02-17T18:24:51 *** molly has quit IRC
3062020-02-17T18:30:38 *** spinza has joined #bitcoin-core-dev
3072020-02-17T18:43:16 <dongcarl> What's the current thinking on running Bitcoin Core on non-ECC devices? Are there enough safe guards in place so that at least casual users can use non-ECC devices?
3082020-02-17T18:43:43 <sipa> what is a non-ECC device?
3092020-02-17T18:43:54 <sipa> elliptic curve crypto?
3102020-02-17T18:44:16 <sipa> error correcting code?
3112020-02-17T18:44:20 <dongcarl> devices without ECC RAM haha
3122020-02-17T18:45:33 <luke-jr> I suspect most people do
3132020-02-17T18:46:03 <luke-jr> IIRC Intel doesn't even allow you to use ECC with their normal CPUs
3142020-02-17T18:46:31 *** owowo has quit IRC
3152020-02-17T18:46:31 <rafalcpp> dongcarl: almost all users sadly sit on non-ECC RAM. and you have no idea what will bitflip, it could be disk driver that will erase wallet or whatever. probably rather pointless to defend in software
3162020-02-17T18:46:41 <sipa> is there *any* consumer oriented CPU that supports ECC?
3172020-02-17T18:46:46 *** mrostecki has joined #bitcoin-core-dev
3182020-02-17T18:47:03 <rafalcpp> sipa: pretty sure AMD Bulldozer supports, for example
3192020-02-17T18:47:05 <luke-jr> rafalcpp: there are places we *should* definitely defend.. your backups won't help you if you bitflip a change address
3202020-02-17T18:47:13 <luke-jr> sipa: POWER9
3212020-02-17T18:47:52 <luke-jr> (not typical, but the 4-core variants are consumer-oriented)
3222020-02-17T18:48:21 <dongcarl> This one too: https://www.96boards.org/product/developerbox/
3232020-02-17T18:48:47 <dongcarl> I guess I'm just trying to understand the specific risks here...
3242020-02-17T18:49:29 <dongcarl> If I want to buy hardware to be my dedicated Bitcoin Core node... Should ECC RAM be a main concern? Or is it outweighed by other concerns
3252020-02-17T18:49:59 <luke-jr> dongcarl: I would put supervisor-free over ECC
3262020-02-17T18:50:56 <dongcarl> luke-jr: supervisor = BMC?
3272020-02-17T18:51:20 *** owowo has joined #bitcoin-core-dev
3282020-02-17T18:52:05 <luke-jr> dongcarl: nah, backdoors like Intel ME and AMD PSP
3292020-02-17T18:52:10 <sipa> dongcarl: if an ECC system is more expensive than a non-ECC system that can run two instances of bitcoind in parallel, pick the latter :)
3302020-02-17T18:52:18 <luke-jr> and the Microsoft ThreadX in Raspberry Pi
3312020-02-17T18:52:32 <rafalcpp> this purity in choosing realiable and not backdoored hardware is highly inspiring at least for me
3322020-02-17T18:53:23 <dongcarl> sipa: That's very true!
3332020-02-17T18:54:23 <dongcarl> luke-jr: Is that normally reported on wikichip? e.g., how do I tell if https://en.wikichip.org/wiki/socionext/sc2a11 has a supervisor?
3342020-02-17T18:54:29 * dongcarl googles Microsoft ThreadX
3352020-02-17T18:54:46 <rafalcpp> 2-of-2 multisign on other, cheap, device would solve it basically, although much less comfortable to use, dongcarl. an idea for future when it becomes non-trivial amount
3362020-02-17T18:54:51 <luke-jr> dongcarl: I don't know :/
3372020-02-17T18:56:52 <dongcarl> rafalcpp: Right, I think the fact that usable SBCs are getting cheaper and cheaper is great. However, setting up clusters is quite a pain still
3382020-02-17T18:58:25 <dongcarl> Another question: When testing out lower-power SBCs, what's a good metric for "runs Bitcoin Core well"? Is "being able to keep up with tip" good enough?
3392020-02-17T18:58:56 <luke-jr> dongcarl: IBD in an hour? :P (haha)
3402020-02-17T19:00:29 <yevaud> dongcarl: even on the upper end SOCs IBD takes days.
3412020-02-17T19:01:27 <yevaud> dongcarl: the cheapest "sbc" with ECC is almost certainly the APU2/APU4, it's still slow and fanless, like any other SBC.
3422020-02-17T19:01:41 <dongcarl> Disregarding IBD I mean... In a steady state, is there anything else that would hinder correct operation and security other than keeping up with tip?
3432020-02-17T19:01:43 *** Highway61 has quit IRC
3442020-02-17T19:03:39 <dongcarl> yevaud: right, from my understanding the apu2 might be affected by PSP, but I'm not sure that the NICs will cooperate if someone wants to attack
3452020-02-17T19:03:44 <yevaud> not really. on most SBCs you're going to see rather high rates of data loss due to MicroSD cards, but they run acceptably in the sync state.
3462020-02-17T19:06:52 <dongcarl> luke-jr: Did you get to look at the apu2 architecture and evaluate the risks closely?
3472020-02-17T19:06:59 <rafalcpp> dongcarl: a cluster? just run two separate instances. If anything is needed, I suppose bitcoind/gui could support 2-2 multisign more easily (if it doesn't yet)
3482020-02-17T19:07:09 <yevaud> dongcarl: yes, it has a PSP core.
3492020-02-17T19:07:24 <luke-jr> dongcarl: no
3502020-02-17T19:08:03 <luke-jr> dongcarl: I saw AMD and closed it
3512020-02-17T19:08:12 <dongcarl> yevaud: Right, but what's the exact attack though? From my understanding you'd need the NICs to cooperate, and PSP isn't in the coreboot payload that PC Engine builds...
3522020-02-17T19:09:12 <dongcarl> rafalcpp: That's true, you could probably do some deduplication at the FS level to save some space too
3532020-02-17T19:09:35 <rafalcpp> dongcarl: well this isn't separate computer then. but just fully prune one (or both) then it is around 6 GB
3542020-02-17T19:09:37 *** promag has quit IRC
3552020-02-17T19:10:00 <yevaud> dongcarl: I don't know without asking PcEngines (do, they're helpful), but I don't think it's a realistic concern in the real world.
3562020-02-17T19:10:35 <luke-jr> I'm not sure PcEngines would know either?
3572020-02-17T19:10:42 <dongcarl> yevaud: That's a good point. Will email.
3582020-02-17T19:11:15 <dongcarl> luke-jr: They have quite a deep understanding of their hardware: https://github.com/pcengines/apu2-documentation
3592020-02-17T19:11:26 *** spaced0ut has quit IRC
3602020-02-17T19:12:32 <luke-jr> dongcarl: but afaik the PSP is inivislbe outside the CPU?
3612020-02-17T19:13:51 <yevaud> luke-jr: on the Intel one it's stored on an external flash chip.
3622020-02-17T19:14:52 <luke-jr> but at least on Intel, if you deprive it, it won't work
3632020-02-17T19:15:21 <yevaud> stands to reason the manufacturer would have to understand that, if it were the case on AMD.
3642020-02-17T19:15:55 * dongcarl has some reading to do
3652020-02-17T19:16:06 *** willcl_ark has quit IRC
3662020-02-17T19:16:25 <luke-jr> yevaud: they might not understand the ramifications of not providing it, even if that is the case
3672020-02-17T19:16:49 <luke-jr> eg, on Intel the IME is used to workaround silicon bugs, so with me_cleaner and such, you're vulnerable to undisclosed vulnerabilities
3682020-02-17T19:17:38 <yevaud> uh, really? the microcode is a separate thing to the ME core.
3692020-02-17T19:18:54 *** bitcoin-git has joined #bitcoin-core-dev
3702020-02-17T19:18:54 <bitcoin-git> [bitcoin] practicalswift opened pull request #18166: ci: Run fuzz testing test cases under valgrind (master...fuzz-test-cases-under-valgrind) https://github.com/bitcoin/bitcoin/pull/18166
3712020-02-17T19:19:04 *** bitcoin-git has left #bitcoin-core-dev
3722020-02-17T19:19:30 <luke-jr> yevaud: someone disclosed or leaked that a while ago. it's not just microcode that patches silicon issues.
3732020-02-17T19:20:04 *** kristapsk has quit IRC
3742020-02-17T19:20:14 <luke-jr> I don't know that any of the specific details of the silicon bug were disclosed, so we can only speculate on why Intel might have done ti that way
3752020-02-17T19:20:53 <luke-jr> (maybe it's a silicon issue with the ME core, and not patching it means external attackers can compromise the ME core?)
3762020-02-17T19:21:59 <dongcarl> (if this is off-topic, someone should let me know)
3772020-02-17T19:22:22 <dongcarl> luke-jr: I think the PSP firmware has to be in the BIOS to be loaded
3782020-02-17T19:22:49 <yevaud> luke-jr: I was under the impression that ME operations against the main cores were effectively a NMI, so having it do any sort of continuous operation would demolish performance.
3792020-02-17T19:22:58 <dongcarl> And in the apu2 case, they did not include it in the coreboot payload: https://coreboot.coreboot.narkive.com/7e2UHc2x/pc-engines-apu2-platform-psp-support
3802020-02-17T19:23:31 <yevaud> luke-jr: but obviously I don't have specific knowledge here, so I'll leave it at that.
3812020-02-17T19:25:44 <luke-jr> yevaud: I'm not sure why that would matter. Injecting a bit of code wouldn't need to be continuous, and most things can be done by reading/changing RAM directly
3822020-02-17T19:25:49 *** willcl_ark has joined #bitcoin-core-dev
3832020-02-17T19:27:35 *** willcl_ark has quit IRC
3842020-02-17T19:37:24 *** willcl_ark has joined #bitcoin-core-dev
3852020-02-17T19:38:34 *** jcoe1 has quit IRC
3862020-02-17T19:43:43 *** vasild has quit IRC
3872020-02-17T19:46:45 *** mrostecki has quit IRC
3882020-02-17T19:46:47 *** mael-rolland[m] has quit IRC
3892020-02-17T19:47:13 *** icota[m] has quit IRC
3902020-02-17T19:49:15 *** sanket1729 has quit IRC
3912020-02-17T19:50:17 *** Kiminuo has quit IRC
3922020-02-17T19:50:18 *** vasild has joined #bitcoin-core-dev
3932020-02-17T19:51:50 *** sanket1729 has joined #bitcoin-core-dev
3942020-02-17T19:55:33 *** jimmysong has joined #bitcoin-core-dev
3952020-02-17T19:55:38 *** jimmysong_ has joined #bitcoin-core-dev
3962020-02-17T19:57:08 *** jimmysong_ has quit IRC
3972020-02-17T20:00:45 *** jimmysong has quit IRC
3982020-02-17T20:02:09 *** rafalcpp has quit IRC
3992020-02-17T20:07:23 <wumpus> luke-jr: they work fine without the patch, #17569 does work around a noexecstack issue (so the stack is executable), I don't think it's worth doing a new rc for but if there is one anyway we could include it
4002020-02-17T20:07:25 <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols and work around rv64 toolchain issue by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
4012020-02-17T20:11:20 *** jimmysong has joined #bitcoin-core-dev
4022020-02-17T20:12:25 <dongcarl> Does anyone know how to setup gribble for another channel? I'm thinking #bitcoin-builds
4032020-02-17T20:14:08 *** Kiminuo has joined #bitcoin-core-dev
4042020-02-17T20:14:11 *** Highway61 has joined #bitcoin-core-dev
4052020-02-17T20:15:25 *** bitcoin-git has joined #bitcoin-core-dev
4062020-02-17T20:15:25 <bitcoin-git> [bitcoin] TheQuantumPhysicist opened pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
4072020-02-17T20:15:26 *** bitcoin-git has left #bitcoin-core-dev
4082020-02-17T20:16:37 *** TheFuzzStone[m] has joined #bitcoin-core-dev
4092020-02-17T20:21:57 *** Guyver2__ has joined #bitcoin-core-dev
4102020-02-17T20:22:12 *** icota[m] has joined #bitcoin-core-dev
4112020-02-17T20:22:12 *** mrostecki has joined #bitcoin-core-dev
4122020-02-17T20:22:18 *** mael-rolland[m] has joined #bitcoin-core-dev
4132020-02-17T20:23:24 *** Guyver2_ has quit IRC
4142020-02-17T20:29:08 *** willcl_ark has quit IRC
4152020-02-17T20:30:01 *** willcl_ark has joined #bitcoin-core-dev
4162020-02-17T20:32:27 *** willcl_ark has quit IRC
4172020-02-17T20:33:26 *** willcl_ark has joined #bitcoin-core-dev
4182020-02-17T20:33:29 *** willcl_ark has quit IRC
4192020-02-17T20:35:41 *** willcl_ark has joined #bitcoin-core-dev
4202020-02-17T20:36:36 *** emilengler has quit IRC
4212020-02-17T20:42:27 *** dr-orlovsky has quit IRC
4222020-02-17T20:45:40 *** dr-orlovsky has joined #bitcoin-core-dev
4232020-02-17T21:00:01 *** selenamarie has quit IRC
4242020-02-17T21:07:55 *** Kiminuo has quit IRC
4252020-02-17T21:08:39 *** proshanta has joined #bitcoin-core-dev
4262020-02-17T21:14:22 *** proshanta has quit IRC
4272020-02-17T21:18:19 *** unknown1 has joined #bitcoin-core-dev
4282020-02-17T21:19:24 *** Highway61 has quit IRC
4292020-02-17T21:25:39 *** promag has joined #bitcoin-core-dev
4302020-02-17T21:29:09 *** Guyver2__ has quit IRC
4312020-02-17T21:36:03 <achow101> dongcarl: talk to nanotube
4322020-02-17T21:40:08 *** promag has quit IRC
4332020-02-17T21:45:43 *** Chris_Stewart_5 has quit IRC
4342020-02-17T22:03:47 *** timothy has quit IRC
4352020-02-17T22:25:01 *** IGHOR has quit IRC
4362020-02-17T22:31:12 *** jarthur has joined #bitcoin-core-dev
4372020-02-17T22:42:22 *** cavemansalem has joined #bitcoin-core-dev
4382020-02-17T22:48:53 *** cavemansalem has quit IRC
4392020-02-17T22:49:14 *** cavemansalem has joined #bitcoin-core-dev
4402020-02-17T22:49:56 *** DeanGuss has joined #bitcoin-core-dev
4412020-02-17T22:55:49 *** promag has joined #bitcoin-core-dev
4422020-02-17T22:58:56 *** manantial has quit IRC
4432020-02-17T23:00:06 *** Highway61 has joined #bitcoin-core-dev
4442020-02-17T23:39:19 *** AaronvanW has quit IRC
4452020-02-17T23:46:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4462020-02-17T23:58:15 *** Zenton has quit IRC