12020-02-24T00:00:03 *** aaronmcadam has quit IRC
22020-02-24T00:04:45 *** setpill has joined #bitcoin-core-dev
32020-02-24T00:06:45 *** justanotheruser has quit IRC
42020-02-24T00:08:31 *** Highway61 has quit IRC
52020-02-24T00:18:02 *** dorena has joined #bitcoin-core-dev
62020-02-24T00:22:23 *** Zenton has quit IRC
72020-02-24T00:22:52 *** Eagle[TM] has joined #bitcoin-core-dev
82020-02-24T00:25:37 *** EagleTM has quit IRC
92020-02-24T00:32:33 *** captjakk has quit IRC
102020-02-24T00:36:06 *** marcoagner has quit IRC
112020-02-24T00:37:46 *** Randolf has quit IRC
122020-02-24T00:50:17 *** setpill has quit IRC
132020-02-24T00:59:21 *** owowo has quit IRC
142020-02-24T00:59:24 *** justanotheruser has joined #bitcoin-core-dev
152020-02-24T01:03:35 *** owowo has joined #bitcoin-core-dev
162020-02-24T01:03:35 *** owowo has joined #bitcoin-core-dev
172020-02-24T01:13:33 *** lnostdal has quit IRC
182020-02-24T01:29:01 *** promag has joined #bitcoin-core-dev
192020-02-24T01:33:34 *** promag has quit IRC
202020-02-24T02:01:42 *** captjakk has joined #bitcoin-core-dev
212020-02-24T02:30:56 *** molly has joined #bitcoin-core-dev
222020-02-24T02:33:31 *** mol has quit IRC
232020-02-24T03:00:01 *** dorena has quit IRC
242020-02-24T03:14:26 *** Highway61 has joined #bitcoin-core-dev
252020-02-24T03:18:01 *** mdrjr1 has joined #bitcoin-core-dev
262020-02-24T03:18:39 *** Highway61 has quit IRC
272020-02-24T03:41:17 *** felixfoertsch23 has joined #bitcoin-core-dev
282020-02-24T03:42:25 *** felixfoertsch has quit IRC
292020-02-24T03:47:49 *** captjakk has quit IRC
302020-02-24T03:47:57 *** captjakk has joined #bitcoin-core-dev
312020-02-24T03:48:47 *** captjakk has quit IRC
322020-02-24T03:50:12 *** captjakk has joined #bitcoin-core-dev
332020-02-24T03:52:15 *** molz_ has joined #bitcoin-core-dev
342020-02-24T03:55:33 *** molly has quit IRC
352020-02-24T04:02:06 *** cryptoIndio has joined #bitcoin-core-dev
362020-02-24T04:02:34 *** cryptoIndio has quit IRC
372020-02-24T04:17:52 *** captjakk has quit IRC
382020-02-24T04:22:43 *** Eagle[TM] has quit IRC
392020-02-24T04:24:03 *** EagleTM has joined #bitcoin-core-dev
402020-02-24T04:59:54 *** captjakk has joined #bitcoin-core-dev
412020-02-24T05:06:30 *** captjakk has quit IRC
422020-02-24T05:16:32 *** TheHoliestRoger has quit IRC
432020-02-24T05:17:23 *** TheHoliestRoger has joined #bitcoin-core-dev
442020-02-24T05:28:50 *** votesmith has quit IRC
452020-02-24T05:29:43 *** promag has joined #bitcoin-core-dev
462020-02-24T05:34:07 *** promag has quit IRC
472020-02-24T05:39:47 *** votesmith has joined #bitcoin-core-dev
482020-02-24T06:00:01 *** mdrjr1 has quit IRC
492020-02-24T06:08:19 *** ddustin has joined #bitcoin-core-dev
502020-02-24T06:11:35 *** ddustin has quit IRC
512020-02-24T06:12:11 *** ddustin has joined #bitcoin-core-dev
522020-02-24T06:13:12 *** ddustin has quit IRC
532020-02-24T06:13:39 *** ddustin has joined #bitcoin-core-dev
542020-02-24T06:15:11 *** achow101 has quit IRC
552020-02-24T06:18:51 *** shrug has joined #bitcoin-core-dev
562020-02-24T06:30:18 *** achow101 has joined #bitcoin-core-dev
572020-02-24T06:42:43 *** votesmith has quit IRC
582020-02-24T06:57:07 *** manantial has joined #bitcoin-core-dev
592020-02-24T06:59:33 *** Highway61 has joined #bitcoin-core-dev
602020-02-24T07:11:20 *** EagleTM has quit IRC
612020-02-24T07:20:31 *** achow101 has quit IRC
622020-02-24T07:23:29 *** achow101 has joined #bitcoin-core-dev
632020-02-24T07:34:25 *** hadjiszs has joined #bitcoin-core-dev
642020-02-24T07:40:32 *** vasild_ has joined #bitcoin-core-dev
652020-02-24T07:43:23 *** vasild has quit IRC
662020-02-24T08:14:21 *** ddustin has quit IRC
672020-02-24T08:15:11 *** ddustin has joined #bitcoin-core-dev
682020-02-24T08:19:26 *** ddustin has quit IRC
692020-02-24T08:27:16 *** Guyver2 has joined #bitcoin-core-dev
702020-02-24T08:35:45 *** votesmith has joined #bitcoin-core-dev
712020-02-24T08:40:31 *** rjected has quit IRC
722020-02-24T08:41:02 *** filchef has joined #bitcoin-core-dev
732020-02-24T08:42:18 *** filchef has quit IRC
742020-02-24T08:44:40 *** yevaud has quit IRC
752020-02-24T08:56:09 *** marcoagner has joined #bitcoin-core-dev
762020-02-24T09:00:02 *** shrug has quit IRC
772020-02-24T09:00:43 *** troy1 has quit IRC
782020-02-24T09:02:21 *** jonatack has joined #bitcoin-core-dev
792020-02-24T09:03:16 *** votesmith has quit IRC
802020-02-24T09:13:27 *** timothy has joined #bitcoin-core-dev
812020-02-24T09:13:52 *** Kiminuo has joined #bitcoin-core-dev
822020-02-24T09:15:40 *** promag has joined #bitcoin-core-dev
832020-02-24T09:20:12 *** promag has quit IRC
842020-02-24T09:31:27 *** ddustin has joined #bitcoin-core-dev
852020-02-24T09:36:37 *** votesmith has joined #bitcoin-core-dev
862020-02-24T09:39:32 *** promag has joined #bitcoin-core-dev
872020-02-24T09:40:27 *** ddustin has quit IRC
882020-02-24T09:40:54 *** Zenton has joined #bitcoin-core-dev
892020-02-24T09:41:53 *** promag_ has joined #bitcoin-core-dev
902020-02-24T09:42:30 *** promag has quit IRC
912020-02-24T09:42:32 *** promag_ is now known as promag
922020-02-24T09:42:36 <promag> wumpus: ping re #18064
932020-02-24T09:42:39 <gribble> https://github.com/bitcoin/bitcoin/issues/18064 | gui: Drop WalletModel dependency to RecentRequestsTableModel by promag · Pull Request #18064 · bitcoin/bitcoin · GitHub
942020-02-24T09:46:04 *** votesmith has quit IRC
952020-02-24T09:46:23 *** promag has quit IRC
962020-02-24T09:46:41 *** promag has joined #bitcoin-core-dev
972020-02-24T09:48:35 *** skinkie1 has joined #bitcoin-core-dev
982020-02-24T09:55:59 *** AaronvanW has joined #bitcoin-core-dev
992020-02-24T10:08:07 *** mol has joined #bitcoin-core-dev
1002020-02-24T10:11:04 *** molz_ has quit IRC
1012020-02-24T10:13:23 *** Guyver2 has quit IRC
1022020-02-24T10:13:37 *** AaronvanW has quit IRC
1032020-02-24T10:29:04 *** Zenton has quit IRC
1042020-02-24T10:30:53 *** AaronvanW has joined #bitcoin-core-dev
1052020-02-24T10:41:51 *** Zenton has joined #bitcoin-core-dev
1062020-02-24T10:44:41 *** Highway61 has quit IRC
1072020-02-24T10:44:54 *** ddustin has joined #bitcoin-core-dev
1082020-02-24T10:46:27 <wumpus> promag: will take a look thanks
1092020-02-24T10:49:35 *** ddustin has quit IRC
1102020-02-24T11:03:17 *** vasild_ is now known as vasild
1112020-02-24T11:04:00 *** Connie83Franecki has joined #bitcoin-core-dev
1122020-02-24T11:11:08 *** AaronvanW has quit IRC
1132020-02-24T11:33:58 *** promag has quit IRC
1142020-02-24T11:36:06 *** jonatack has quit IRC
1152020-02-24T11:38:08 *** AaronvanW has joined #bitcoin-core-dev
1162020-02-24T11:40:40 *** promag has joined #bitcoin-core-dev
1172020-02-24T11:40:52 *** bitcoin-git has joined #bitcoin-core-dev
1182020-02-24T11:40:52 <bitcoin-git> [bitcoin] practicalswift closed pull request #18199: build: Enable AddressSanitizer as part of --enable-debug (master...enable-debug-asan) https://github.com/bitcoin/bitcoin/pull/18199
1192020-02-24T11:40:53 *** bitcoin-git has left #bitcoin-core-dev
1202020-02-24T11:50:42 *** jonatack has joined #bitcoin-core-dev
1212020-02-24T12:00:01 *** skinkie1 has quit IRC
1222020-02-24T12:04:14 *** Guyver2 has joined #bitcoin-core-dev
1232020-02-24T12:09:13 *** ddustin has joined #bitcoin-core-dev
1242020-02-24T12:13:30 *** ddustin has quit IRC
1252020-02-24T12:14:28 *** ddustin has joined #bitcoin-core-dev
1262020-02-24T12:17:49 *** Greedi has joined #bitcoin-core-dev
1272020-02-24T12:19:09 *** ddustin has quit IRC
1282020-02-24T12:31:41 *** Rasmus has joined #bitcoin-core-dev
1292020-02-24T12:46:03 *** ddustin has joined #bitcoin-core-dev
1302020-02-24T12:49:59 *** rafalcpp has quit IRC
1312020-02-24T12:57:57 *** sipsorcery has quit IRC
1322020-02-24T12:58:20 *** sipsorcery has joined #bitcoin-core-dev
1332020-02-24T12:58:36 *** rafalcpp has joined #bitcoin-core-dev
1342020-02-24T13:10:45 *** promag has quit IRC
1352020-02-24T13:18:05 *** Highway61 has joined #bitcoin-core-dev
1362020-02-24T13:27:13 *** bitcoin-git has joined #bitcoin-core-dev
1372020-02-24T13:27:13 <bitcoin-git> [bitcoin] zengyiheng opened pull request #18200: Sebible v0.18.1 prow (master...sebible-v0.18.1-prow) https://github.com/bitcoin/bitcoin/pull/18200
1382020-02-24T13:27:14 *** bitcoin-git has left #bitcoin-core-dev
1392020-02-24T13:30:10 *** setpill has joined #bitcoin-core-dev
1402020-02-24T13:30:12 *** bitcoin-git has joined #bitcoin-core-dev
1412020-02-24T13:30:12 <bitcoin-git> [bitcoin] fanquake closed pull request #18200: Sebible v0.18.1 prow (master...sebible-v0.18.1-prow) https://github.com/bitcoin/bitcoin/pull/18200
1422020-02-24T13:30:13 *** bitcoin-git has left #bitcoin-core-dev
1432020-02-24T13:31:52 *** promag has joined #bitcoin-core-dev
1442020-02-24T13:36:12 *** promag has quit IRC
1452020-02-24T13:36:29 *** emilengler has joined #bitcoin-core-dev
1462020-02-24T13:39:32 *** promag has joined #bitcoin-core-dev
1472020-02-24T13:44:07 *** promag has quit IRC
1482020-02-24T13:46:02 *** ddustin has quit IRC
1492020-02-24T13:47:16 *** Rasmus has quit IRC
1502020-02-24T14:04:02 *** promag has joined #bitcoin-core-dev
1512020-02-24T14:21:42 *** ahmed_ has joined #bitcoin-core-dev
1522020-02-24T14:25:32 <kanzure> #proposedmeetingtopic more topic collection for upcoming physical meeting
1532020-02-24T14:40:54 <instagibbs> achow101, descriptor wallet PR is a *great* place to redefine "IsChange" to be something much more meaningful than "address isn't in address book"
1542020-02-24T14:41:27 <instagibbs> since we're adhering to BIP44/49/84(throwing this out there in case someone thinks this is a bad idea)
1552020-02-24T15:00:02 *** Greedi has quit IRC
1562020-02-24T15:18:08 *** Velociraptor1 has joined #bitcoin-core-dev
1572020-02-24T15:22:50 *** jcoe has joined #bitcoin-core-dev
1582020-02-24T15:23:42 *** jcoe has quit IRC
1592020-02-24T15:28:03 *** hebasto has quit IRC
1602020-02-24T15:41:49 *** Kiminuo has quit IRC
1612020-02-24T15:45:54 *** Emcy has quit IRC
1622020-02-24T15:46:26 *** troy1 has joined #bitcoin-core-dev
1632020-02-24T15:48:00 *** oguzkoroglu has quit IRC
1642020-02-24T15:48:20 *** oguzkoroglu has joined #bitcoin-core-dev
1652020-02-24T15:49:17 *** mdunnio has joined #bitcoin-core-dev
1662020-02-24T15:51:53 *** jarthur has joined #bitcoin-core-dev
1672020-02-24T15:57:12 *** AaronvanW has quit IRC
1682020-02-24T15:59:19 *** Emcy has joined #bitcoin-core-dev
1692020-02-24T16:01:10 *** Connie83Franecki has quit IRC
1702020-02-24T16:02:21 *** bitcoin-git has joined #bitcoin-core-dev
1712020-02-24T16:02:21 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab9de435880c...225aa5d6d519
1722020-02-24T16:02:22 <bitcoin-git> bitcoin/master bca8665 Luke Dashjr: scripted-diff: Wallet: Rename incorrectly named *UsedDestination
1732020-02-24T16:02:23 <bitcoin-git> bitcoin/master 225aa5d MarcoFalke: Merge #18193: scripted-diff: Wallet: Rename incorrectly named *UsedDestina...
1742020-02-24T16:02:24 *** bitcoin-git has left #bitcoin-core-dev
1752020-02-24T16:02:41 *** bitcoin-git has joined #bitcoin-core-dev
1762020-02-24T16:02:41 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18193: scripted-diff: Wallet: Rename incorrectly named *UsedDestination (master...rename_useddest) https://github.com/bitcoin/bitcoin/pull/18193
1772020-02-24T16:02:43 *** bitcoin-git has left #bitcoin-core-dev
1782020-02-24T16:09:04 *** promag has quit IRC
1792020-02-24T16:09:52 *** Kiminuo has joined #bitcoin-core-dev
1802020-02-24T16:14:35 *** shesek has quit IRC
1812020-02-24T16:15:06 *** shesek has joined #bitcoin-core-dev
1822020-02-24T16:20:51 *** shesek has quit IRC
1832020-02-24T16:21:41 *** shesek has joined #bitcoin-core-dev
1842020-02-24T16:23:08 *** shesek has joined #bitcoin-core-dev
1852020-02-24T16:23:08 *** shesek has joined #bitcoin-core-dev
1862020-02-24T16:23:26 *** promag has joined #bitcoin-core-dev
1872020-02-24T16:26:23 *** SiAnDoG has quit IRC
1882020-02-24T16:26:48 *** SiAnDoG has joined #bitcoin-core-dev
1892020-02-24T16:29:49 *** ddustin has joined #bitcoin-core-dev
1902020-02-24T16:34:21 *** bitcoin-git has joined #bitcoin-core-dev
1912020-02-24T16:34:21 <bitcoin-git> [bitcoin] Sjors opened pull request #18201: rpc: sendmany and sendtoaddress return PSBT for wallets without private keys (master...2020/02/sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18201
1922020-02-24T16:34:22 *** bitcoin-git has left #bitcoin-core-dev
1932020-02-24T16:37:15 *** ddustin has quit IRC
1942020-02-24T16:37:48 <achow101> instagibbs: I'm not sure how that would fit in with LegacyScriptPubKeyMan though
1952020-02-24T16:38:20 <achow101> we could have the check be whether a destination belongs to a spkman in m_internal_spk_managers, but for legacy, that doesn't work
1962020-02-24T16:42:35 *** AaronvanW has joined #bitcoin-core-dev
1972020-02-24T16:48:28 <sipa> achow101: have a IsChange(destination, label) function in spkmanagers, which is implemented in legacy as checking if label is empty, and has sane logic in descriptor spkmans?
1982020-02-24T16:49:53 <achow101> spkmans internally don't really have a concept of being change/not-change
1992020-02-24T16:50:09 <achow101> but I guess we can just have IsChange have more conditionals based on spkman type as we already do in a few places
2002020-02-24T16:51:35 <sipa> in an envisioned native descriptor wallet, you'd have separate spkmans for change and non-change, no?
2012020-02-24T16:51:56 <achow101> yes
2022020-02-24T16:53:24 <sipa> but it's not the spkman itself that knows it is for change or not?
2032020-02-24T16:53:32 <achow101> yes
2042020-02-24T16:53:43 <achow101> we would have to check whether a scriptPubKey belongs to a spkman in m_internal_spk_mans
2052020-02-24T16:53:45 <sipa> that makes sense
2062020-02-24T16:53:49 <sipa> but it also.sounds like there shoukd be an easy solution
2072020-02-24T16:57:20 *** tripleslash has joined #bitcoin-core-dev
2082020-02-24T16:57:21 <sipa> right, so the knowledge is in the wallet, not the spkmans
2092020-02-24T17:05:34 *** emilengler has quit IRC
2102020-02-24T17:06:06 *** promag has joined #bitcoin-core-dev
2112020-02-24T17:10:07 *** yevaud has joined #bitcoin-core-dev
2122020-02-24T17:10:29 *** Highway61 has quit IRC
2132020-02-24T17:13:19 *** benthecarman has joined #bitcoin-core-dev
2142020-02-24T17:21:12 *** promag_ has joined #bitcoin-core-dev
2152020-02-24T17:23:09 *** hebasto has joined #bitcoin-core-dev
2162020-02-24T17:25:15 *** promag_ has quit IRC
2172020-02-24T17:27:54 <instagibbs> either way my point is that we should change it *now* before we're stuck with behavior again
2182020-02-24T17:28:16 <instagibbs> legacy spkm has to keep old behavior
2192020-02-24T17:28:22 <instagibbs> anything newer should do something better imo
2202020-02-24T17:28:39 <instagibbs> well, any wallet that employs a non-legacy spkm*
2212020-02-24T17:29:15 *** benthecarman_ has joined #bitcoin-core-dev
2222020-02-24T17:29:43 <luke-jr> [14:40:54] <instagibbs> achow101, descriptor wallet PR is a *great* place to redefine "IsChange" to be something much more meaningful than "address isn't in address book"
2232020-02-24T17:29:48 <luke-jr> we'ver already violated this
2242020-02-24T17:30:09 <luke-jr> see #18192
2252020-02-24T17:30:11 <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
2262020-02-24T17:30:15 <instagibbs> Ok, doesn't change my point :)
2272020-02-24T17:30:32 <luke-jr> instagibbs: we can and should fix it for existing wallets ;)
2282020-02-24T17:31:02 <instagibbs> opt-in damage :P
2292020-02-24T17:31:11 <instagibbs> according to your PR at least
2302020-02-24T17:31:19 *** AaronvanW has quit IRC
2312020-02-24T17:31:46 *** benthecarman has quit IRC
2322020-02-24T17:32:05 <luke-jr> instagibbs: that's why I rename anything that could be misused
2332020-02-24T17:32:12 <luke-jr> any IsChange is inherently opt-in
2342020-02-24T17:42:56 <instagibbs> achow101, only edge cases i can think of is if a particular script is for some reason in both an internal and external spkm in the same wallet(though that's pretty dumb to do)
2352020-02-24T17:45:05 <instagibbs> otherwise yeah, just add a conditional. I wanted to do that previously but hadn't the opportunity
2362020-02-24T17:45:18 *** promag has quit IRC
2372020-02-24T17:45:31 *** promag has joined #bitcoin-core-dev
2382020-02-24T17:45:36 *** molly has joined #bitcoin-core-dev
2392020-02-24T17:47:39 *** mol has quit IRC
2402020-02-24T17:54:34 *** AaronvanW has joined #bitcoin-core-dev
2412020-02-24T17:59:34 <provoostenator> luke-jr: "don't we want such cases to call an external signer and behave as normally?" - not sure what you mean there? (#18201)
2422020-02-24T17:59:36 <gribble> https://github.com/bitcoin/bitcoin/issues/18201 | rpc: sendmany and sendtoaddress return PSBT for wallets without private keys by Sjors · Pull Request #18201 · bitcoin/bitcoin · GitHub
2432020-02-24T18:00:02 *** Velociraptor1 has quit IRC
2442020-02-24T18:01:13 *** pinheadmz has quit IRC
2452020-02-24T18:01:42 <provoostenator> I have a ExternalSignerScriptPubKeyManager subclass of (DescriptorScriptPubManager) which overrides FillPSBT to call an external signer.
2462020-02-24T18:02:11 <provoostenator> Which means that CWallet's FillBSBT will return a complete PSBT in that case.
2472020-02-24T18:02:28 <provoostenator> Whereas with a legacy watch-only wallet it always returns an incomplete one.
2482020-02-24T18:02:55 *** promag_ has joined #bitcoin-core-dev
2492020-02-24T18:04:02 *** setpill has quit IRC
2502020-02-24T18:04:16 <luke-jr> provoostenator: I see. Then the problem is that the return signature changes based on the wallet
2512020-02-24T18:04:28 <luke-jr> and potentially based on whether someone forgot to pass -signer or whatever we end up with
2522020-02-24T18:04:35 <provoostenator> That's the same pattern we have with bumpfee
2532020-02-24T18:04:51 <provoostenator> No, ExternalSigner wallets have a flag
2542020-02-24T18:04:55 <luke-jr> bumpfee returns an Object IIRC?
2552020-02-24T18:05:03 <luke-jr> with different keys in this case
2562020-02-24T18:05:04 <provoostenator> Which causes a throw / exception when -signer isn't set
2572020-02-24T18:05:50 <luke-jr> sendmany on the other hand returns a string txid, which callers may very well ignore (while checking the return status)
2582020-02-24T18:06:15 <provoostenator> Ah yes, bumpfee always returns an object, but I think I've this pattern in other places.
2592020-02-24T18:07:36 *** promag_ has quit IRC
2602020-02-24T18:07:46 *** benthecarman_ has quit IRC
2612020-02-24T18:08:06 *** benthecarman_ has joined #bitcoin-core-dev
2622020-02-24T18:09:08 <provoostenator> sendmany currently just fails if you use it on a watch-only wallet, which all ExternalDescriptor wallets are
2632020-02-24T18:09:20 <provoostenator> Perhaps it makes more sense to always return an object for watch-only wallets?
2642020-02-24T18:09:51 <luke-jr> I'm thinking more like having an input flag passed for the PSBT mode
2652020-02-24T18:10:36 *** benthecarman_ has quit IRC
2662020-02-24T18:10:57 *** benthecarman_ has joined #bitcoin-core-dev
2672020-02-24T18:11:03 <provoostenator> I hate extra params though.
2682020-02-24T18:11:17 *** Randolf has joined #bitcoin-core-dev
2692020-02-24T18:11:41 <luke-jr> provoostenator: but what if you want to use it with a normal wallet? ;)
2702020-02-24T18:11:56 <luke-jr> eg, prepare a PSBT, manipulate it, resign it, then send it
2712020-02-24T18:12:16 <provoostenator> You mean a legacy wallet with imported public keys?
2722020-02-24T18:12:22 <provoostenator> But not watch-only?
2732020-02-24T18:12:28 <luke-jr> sure
2742020-02-24T18:12:42 <provoostenator> Because there's no point in producing a PSBT if you have all the keys
2752020-02-24T18:13:02 <luke-jr> I just gave an example
2762020-02-24T18:13:42 <provoostenator> I think the general idea is to encourage users to not mix private key and watch-only wallets.
2772020-02-24T18:14:04 <provoostenator> So in that case either a wallet is watch-only, and returns an object, or it's not, and returns a string.
2782020-02-24T18:15:17 <provoostenator> Alternatively, maybe easier, we always return an object for non-legacy, and for watch-only legacy.
2792020-02-24T18:15:51 *** MasterGruntR75 has joined #bitcoin-core-dev
2802020-02-24T18:15:54 <luke-jr> having two behaviours like that, is going to confuse callers
2812020-02-24T18:16:14 <luke-jr> and my example is where you would want a PSBT for a non-watch-only wallet
2822020-02-24T18:16:32 <luke-jr> to modify it before sending
2832020-02-24T18:18:01 <luke-jr> remember RPC isn't for bitcoin-cli users; it's for scripts, apps, and such
2842020-02-24T18:18:15 <provoostenator> It's _also_ for bitcoin-cli users
2852020-02-24T18:18:38 <luke-jr> in this context, it doesn't matter
2862020-02-24T18:18:56 <luke-jr> point is, have a call signature that changes based on wallet is going to screw up programs
2872020-02-24T18:19:41 <luke-jr> also, I don't mean throwign it on params - I mean include it in options :P
2882020-02-24T18:19:54 <luke-jr> "options":{"psbt": true}
2892020-02-24T18:20:03 <sipa> probably not, as the failures would occur in situations where the call would fail anyway
2902020-02-24T18:20:09 <provoostenator> Neither sendmany nor sendtoaddress has an options dictionary
2912020-02-24T18:20:14 <sipa> but i do the risk for confusion
2922020-02-24T18:20:17 <sipa> *see
2932020-02-24T18:20:32 <Randolf> Breaking backward compatibility in an API is a very bad idea. Better not to change the call signature.
2942020-02-24T18:20:45 <sipa> it's not breaking compatibility
2952020-02-24T18:20:52 <sipa> right?
2962020-02-24T18:21:18 <provoostenator> My thinking was to deprecate the non-object response, but without breaking existing automation, which currently only works with private key wallets
2972020-02-24T18:21:23 <sipa> it's extending those RPCs to situations where they couldn't be used before
2982020-02-24T18:21:31 <provoostenator> Exactly
2992020-02-24T18:22:33 <Randolf> Adding options is fine as long as those options aren't made mandatory. Otherwise I would expect it to "screw up programs" as luke-jr pointed out.
3002020-02-24T18:23:03 *** Randolf has left #bitcoin-core-dev
3012020-02-24T18:23:09 <luke-jr> provoostenator: add one
3022020-02-24T18:23:24 <luke-jr> sipa: if you call sendtoaddress(â¦) right now and it doesn't throw an error, you assume it worked
3032020-02-24T18:23:41 *** Randolf has joined #bitcoin-core-dev
3042020-02-24T18:23:54 <luke-jr> sipa: if it's returning a PSBT, then it didn't do the job usually expected
3052020-02-24T18:24:04 <luke-jr> ie, it didn't broadcast
3062020-02-24T18:24:55 <provoostenator> luke-jr: that would be a bug, it should neverreturn a PSBT for legacy wallets with private keys enabled.
3072020-02-24T18:25:25 <luke-jr> provoostenator: the caller does not know the type of wallet loaded
3082020-02-24T18:25:55 *** benthecarman_ has quit IRC
3092020-02-24T18:26:13 *** benthecarman_ has joined #bitcoin-core-dev
3102020-02-24T18:26:15 <luke-jr> if I write a program expecting a watch-only wallet, it shouldn't break if I run it with a normal wallet
3112020-02-24T18:26:39 <luke-jr> (nor require extra handling to detect the different situation)
3122020-02-24T18:27:00 <provoostenator> Why not? Having private keys in a wallet is very different from not having them.
3132020-02-24T18:27:58 <luke-jr> having keys is a strict superset of not having them
3142020-02-24T18:28:12 <luke-jr> also, in this case, you would broadcast a transaction intended to just be a PSBT template made!
3152020-02-24T18:28:42 *** ariard_ has quit IRC
3162020-02-24T18:29:20 <sipa> i have a weak preference for doing this in a separate RPC too
3172020-02-24T18:29:40 <sipa> the places you'd use this seem to be distinct from the sending RPCs
3182020-02-24T18:30:20 *** benthecarman__ has joined #bitcoin-core-dev
3192020-02-24T18:30:20 <luke-jr> actually, doesn't fundrawtransaction kind of already do it?
3202020-02-24T18:30:30 <provoostenator> I could revive #16378
3212020-02-24T18:30:34 <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | [WIP] The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
3222020-02-24T18:31:17 <luke-jr> provoostenator: I'd prefer that (if there are actual new use cases)
3232020-02-24T18:31:28 *** benthecarman_ has quit IRC
3242020-02-24T18:31:48 <provoostenator> (which I closed in favor of this approach :-)
3252020-02-24T18:32:16 <provoostenator> Should I still make a PR for the first commit that refactors sendmany & sendtoaddress?
3262020-02-24T18:32:21 *** benthecarman_ has joined #bitcoin-core-dev
3272020-02-24T18:32:44 <provoostenator> Not useful on its own though.
3282020-02-24T18:34:11 *** benthecarman__ has quit IRC
3292020-02-24T18:34:53 *** bitcoin-git has joined #bitcoin-core-dev
3302020-02-24T18:34:53 <bitcoin-git> [bitcoin] Sjors closed pull request #18201: rpc: sendmany and sendtoaddress return PSBT for wallets without private keys (master...2020/02/sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18201
3312020-02-24T18:34:55 *** bitcoin-git has left #bitcoin-core-dev
3322020-02-24T18:35:42 *** ariard has joined #bitcoin-core-dev
3332020-02-24T18:45:38 *** Kiminuo has quit IRC
3342020-02-24T18:49:21 *** Kiminuo has joined #bitcoin-core-dev
3352020-02-24T18:52:57 *** AaronvanW has quit IRC
3362020-02-24T18:59:15 *** troy1 has left #bitcoin-core-dev
3372020-02-24T19:01:56 *** promag_ has joined #bitcoin-core-dev
3382020-02-24T19:04:59 <instagibbs> provoostenator, yes please at least for separate consideration
3392020-02-24T19:05:24 *** promag has quit IRC
3402020-02-24T19:05:57 *** Highway61 has joined #bitcoin-core-dev
3412020-02-24T19:06:35 *** promag_ has quit IRC
3422020-02-24T19:08:25 *** Zenton has quit IRC
3432020-02-24T19:13:27 *** bitcoin-git has joined #bitcoin-core-dev
3442020-02-24T19:13:27 <bitcoin-git> [bitcoin] Sjors opened pull request #18202: refactor: consolidate sendmany and sendtoaddress code (master...2020/02/refactor_sendmany_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/18202
3452020-02-24T19:13:28 <provoostenator> instagibbs: done
3462020-02-24T19:13:29 *** bitcoin-git has left #bitcoin-core-dev
3472020-02-24T19:21:16 *** Highway61 has quit IRC
3482020-02-24T19:22:06 *** benthecarman_ has quit IRC
3492020-02-24T19:23:08 *** benthecarman has joined #bitcoin-core-dev
3502020-02-24T19:27:26 *** benthecarman has quit IRC
3512020-02-24T19:32:07 *** jarthur_ has joined #bitcoin-core-dev
3522020-02-24T19:35:22 *** jarthur has quit IRC
3532020-02-24T19:40:32 *** vasild_ has joined #bitcoin-core-dev
3542020-02-24T19:42:07 *** rafalcpp has quit IRC
3552020-02-24T19:42:52 *** Highway61 has joined #bitcoin-core-dev
3562020-02-24T19:43:43 *** vasild has quit IRC
3572020-02-24T19:47:04 *** Randolf has quit IRC
3582020-02-24T19:48:11 <achow101> instagibbs: I prefer luke-jr's IsChange fix rather than figuring out change based on scriptPubKeyMan
3592020-02-24T19:48:40 <achow101> if solely based on the spkman, we would lose changeness when an internal spkman is changed
3602020-02-24T19:48:43 *** Kiminuo has quit IRC
3612020-02-24T20:02:17 *** Kiminuo has joined #bitcoin-core-dev
3622020-02-24T20:09:40 *** kinlo has quit IRC
3632020-02-24T20:12:54 *** promag has joined #bitcoin-core-dev
3642020-02-24T20:15:49 *** benthecarman has joined #bitcoin-core-dev
3652020-02-24T20:21:17 *** timothy has quit IRC
3662020-02-24T20:25:02 *** shesek has quit IRC
3672020-02-24T20:32:31 *** jarthur_ has quit IRC
3682020-02-24T20:34:04 *** jarthur has joined #bitcoin-core-dev
3692020-02-24T20:34:45 *** jarthur has joined #bitcoin-core-dev
3702020-02-24T20:52:49 *** owowo has quit IRC
3712020-02-24T20:55:46 *** benthecarman has quit IRC
3722020-02-24T20:55:59 *** benthecarman has joined #bitcoin-core-dev
3732020-02-24T20:56:29 <instagibbs> :/
3742020-02-24T20:56:42 *** benthecarman_ has joined #bitcoin-core-dev
3752020-02-24T20:57:25 *** owowo has joined #bitcoin-core-dev
3762020-02-24T21:00:02 *** MasterGruntR75 has quit IRC
3772020-02-24T21:16:10 *** TheCavalry has joined #bitcoin-core-dev
3782020-02-24T21:21:09 *** benthecarman__ has joined #bitcoin-core-dev
3792020-02-24T21:23:03 *** bitcoin-git has joined #bitcoin-core-dev
3802020-02-24T21:23:03 <bitcoin-git> [bitcoin] Sjors reopened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
3812020-02-24T21:23:03 *** fv has joined #bitcoin-core-dev
3822020-02-24T21:23:04 *** bitcoin-git has left #bitcoin-core-dev
3832020-02-24T21:23:20 *** bentheacarman__ has joined #bitcoin-core-dev
3842020-02-24T21:23:26 *** benthecarman_ has quit IRC
3852020-02-24T21:23:38 *** bentheacarman__ has quit IRC
3862020-02-24T21:26:36 *** benthecarman__ has quit IRC
3872020-02-24T21:31:59 <instagibbs> achow101, one large annoyance on today's wallet code is that recovering a wallet will mark every address you didn't "getnewaddress" as change, at least until you "getnewaddress" until you hit that particular address
3882020-02-24T21:33:39 *** bentheacarman__ has joined #bitcoin-core-dev
3892020-02-24T21:34:11 <instagibbs> if you don't want to get confused about changeness, then don't blow away spkms I guess?
3902020-02-24T21:34:57 <achow101> you lose the changeness because they get removed from m_internal_spk_managers
3912020-02-24T21:35:12 <achow101> because they're no longer active
3922020-02-24T21:35:33 <sipa> achow101: hmm
3932020-02-24T21:35:34 <instagibbs> hmm let's take this offline
3942020-02-24T21:35:40 <instagibbs> or not, if sipa is reading
3952020-02-24T21:35:46 <instagibbs> when do they become inactive?
3962020-02-24T21:36:00 <achow101> if you were to import a new descriptor for change
3972020-02-24T21:36:10 <achow101> whatever was there originally gets inactivatated
3982020-02-24T21:36:20 <instagibbs> oh
3992020-02-24T21:36:25 *** manantial has quit IRC
4002020-02-24T21:37:04 <sipa> it shouldn't lose change-info when you import a new active one?
4012020-02-24T21:37:18 <sipa> (would be the ideal behavior, i mean)
4022020-02-24T21:37:53 *** pinheadmz has joined #bitcoin-core-dev
4032020-02-24T21:38:03 <instagibbs> So you have 6 spkm, how does it decide which of the 3 changey ones to deactivate?
4042020-02-24T21:38:26 <achow101> the one that's occupying that address type spot
4052020-02-24T21:38:47 <achow101> if you imported a new change p2sh-segwit descriptor, the existing change p2sh-segwit descriptor becomes inactive
4062020-02-24T21:38:51 <luke-jr> maybe IsChange should pay attention to the derivation of HD keys
4072020-02-24T21:39:00 <achow101> luke-jr: I'd rather not
4082020-02-24T21:39:17 <instagibbs> luke-jr, that was my original attempt years ago, with current API you can have whatever derivation be change when imported at least
4092020-02-24T21:39:19 <sipa> achow101: i feel that the changeness in a descriptor world should be metadata associated with the spkman
4102020-02-24T21:39:27 <sipa> independent of what it's active for
4112020-02-24T21:39:38 <instagibbs> sipa, mhmm
4122020-02-24T21:40:03 <achow101> I guess another m_internal_change_spkmans set could be added where you put all the inactive change spkmans
4132020-02-24T21:40:05 <sipa> there may be other metadata too at some point (say: which hw device to use for signing)
4142020-02-24T21:49:36 <instagibbs> ACK
4152020-02-24T21:49:45 *** Guyver2 has quit IRC
4162020-02-24T21:59:43 *** tripleslash has quit IRC
4172020-02-24T22:04:43 *** tripleslash has joined #bitcoin-core-dev
4182020-02-24T22:06:44 *** Zenton has joined #bitcoin-core-dev
4192020-02-24T22:16:26 *** bentheacarman__ has quit IRC
4202020-02-24T22:16:51 *** Emcy has quit IRC
4212020-02-24T22:17:03 *** benthecarman has quit IRC
4222020-02-24T22:17:49 *** Kiminuo has quit IRC
4232020-02-24T22:19:08 *** Randolf has joined #bitcoin-core-dev
4242020-02-24T22:29:26 *** Emcy has joined #bitcoin-core-dev
4252020-02-24T22:32:03 *** Randolf has quit IRC
4262020-02-24T22:49:17 *** fv has quit IRC
4272020-02-24T22:51:13 *** braydonf_ has quit IRC
4282020-02-24T23:00:51 *** tripleslash has quit IRC
4292020-02-24T23:07:48 *** jarthur has quit IRC
4302020-02-24T23:21:16 *** tripleslash has joined #bitcoin-core-dev
4312020-02-24T23:24:33 *** filchef has joined #bitcoin-core-dev
4322020-02-24T23:25:40 *** filchef has quit IRC
4332020-02-24T23:35:07 <luke-jr> why doesn't C++ have a QFlags equivalent yet? -.-
4342020-02-24T23:48:07 <sipa> std::bitset comes close
4352020-02-24T23:48:48 <sipa> combined with an enum for naming the bits
4362020-02-24T23:52:26 <luke-jr> I mean something compatible with class enums and including proper type checking
4372020-02-24T23:58:44 *** sipsorcery has quit IRC
4382020-02-24T23:58:48 *** mdunnio has quit IRC
4392020-02-24T23:59:21 *** sipsorcery has joined #bitcoin-core-dev
4402020-02-24T23:59:53 *** kinlo has joined #bitcoin-core-dev