12020-02-27T00:00:01 *** jMCg has quit IRC
22020-02-27T00:01:14 *** captjakk has quit IRC
32020-02-27T00:01:23 *** captjakk has joined #bitcoin-core-dev
42020-02-27T00:08:40 *** promag has quit IRC
52020-02-27T00:08:51 *** Zenton has quit IRC
62020-02-27T00:09:12 *** promag has joined #bitcoin-core-dev
72020-02-27T00:14:23 *** vasild_ has quit IRC
82020-02-27T00:17:23 *** captjakk has quit IRC
92020-02-27T00:17:49 *** captjakk has joined #bitcoin-core-dev
102020-02-27T00:18:01 *** GsC_RuL3Z has joined #bitcoin-core-dev
112020-02-27T00:22:55 *** captjakk has quit IRC
122020-02-27T00:36:16 *** lightlike has quit IRC
132020-02-27T00:37:21 *** ghost43 has quit IRC
142020-02-27T00:39:14 *** ghost43 has joined #bitcoin-core-dev
152020-02-27T00:49:37 *** vasild has joined #bitcoin-core-dev
162020-02-27T01:24:43 *** belcher has quit IRC
172020-02-27T01:39:39 *** cubancorona has joined #bitcoin-core-dev
182020-02-27T01:42:46 *** bitcoin-git has joined #bitcoin-core-dev
192020-02-27T01:42:46 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5d47ed8fd37...4502ed7cd1b3
202020-02-27T01:42:47 <bitcoin-git> bitcoin/master fab2527 MarcoFalke: test: Disable mockforward scheduler unit test for now
212020-02-27T01:42:47 <bitcoin-git> bitcoin/master 4502ed7 fanquake: Merge #18211: test: Disable mockforward scheduler unit test for now
222020-02-27T01:42:49 *** bitcoin-git has left #bitcoin-core-dev
232020-02-27T01:43:06 *** bitcoin-git has joined #bitcoin-core-dev
242020-02-27T01:43:06 <bitcoin-git> [bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
252020-02-27T01:43:07 *** bitcoin-git has left #bitcoin-core-dev
262020-02-27T01:43:21 *** bitcoin-git has joined #bitcoin-core-dev
272020-02-27T01:43:21 <bitcoin-git> [bitcoin] fanquake merged pull request #18211: test: Disable mockforward scheduler unit test for now (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
282020-02-27T01:43:22 *** bitcoin-git has left #bitcoin-core-dev
292020-02-27T01:43:41 *** bitcoin-git has joined #bitcoin-core-dev
302020-02-27T01:43:41 <bitcoin-git> [bitcoin] fanquake closed pull request #18174: WIP test: make mockscheduler test more reliable (master...2020-02-fix-scheduler-test) https://github.com/bitcoin/bitcoin/pull/18174
312020-02-27T01:43:42 *** bitcoin-git has left #bitcoin-core-dev
322020-02-27T01:48:47 <fanquake> Kiminuo: Not sure if your still working on it, but rather than continuously pushing to the branch in #18210, can you setup Travis to run on your own repository while your testing/debugging.
332020-02-27T01:48:49 <gribble> https://github.com/bitcoin/bitcoin/issues/18210 | test: type hints in Python tests by kiminuo · Pull Request #18210 · bitcoin/bitcoin · GitHub
342020-02-27T01:49:07 <fanquake> That saves our Travis resources, and saves me (and anyone subscribed to the repo) from continual notifications.
352020-02-27T01:55:42 *** promag has quit IRC
362020-02-27T02:01:16 *** cubancorona has quit IRC
372020-02-27T02:02:13 *** cubancorona has joined #bitcoin-core-dev
382020-02-27T02:32:38 *** hsmiths has quit IRC
392020-02-27T02:35:00 *** promag has joined #bitcoin-core-dev
402020-02-27T02:39:20 *** promag has quit IRC
412020-02-27T03:00:01 *** GsC_RuL3Z has quit IRC
422020-02-27T03:05:16 *** AaronvanW has quit IRC
432020-02-27T03:17:52 *** hollisb has joined #bitcoin-core-dev
442020-02-27T03:37:54 *** felixfoertsch has joined #bitcoin-core-dev
452020-02-27T03:40:01 *** felixfoertsch23 has quit IRC
462020-02-27T03:42:56 *** AaronvanW has joined #bitcoin-core-dev
472020-02-27T03:42:58 *** Chris_Stewart_5 has quit IRC
482020-02-27T03:45:30 *** andrewtoth_ has joined #bitcoin-core-dev
492020-02-27T03:46:02 *** SiAnDoG_ has joined #bitcoin-core-dev
502020-02-27T03:46:34 *** SiAnDoG has quit IRC
512020-02-27T03:46:34 *** _andrewtoth_ has quit IRC
522020-02-27T03:46:34 *** kristapsk has quit IRC
532020-02-27T03:46:50 *** kristapsk has joined #bitcoin-core-dev
542020-02-27T03:47:14 *** AaronvanW has quit IRC
552020-02-27T03:52:23 *** captjakk has joined #bitcoin-core-dev
562020-02-27T03:55:49 *** _andrewtoth_ has joined #bitcoin-core-dev
572020-02-27T03:56:45 *** andrewtoth_ has quit IRC
582020-02-27T03:56:59 *** Highway61 has quit IRC
592020-02-27T04:01:35 *** ghost43 has quit IRC
602020-02-27T04:02:24 *** ghost43 has joined #bitcoin-core-dev
612020-02-27T04:28:12 *** cubancorona has quit IRC
622020-02-27T04:36:25 *** hsmiths has joined #bitcoin-core-dev
632020-02-27T04:38:39 *** AaronvanW has joined #bitcoin-core-dev
642020-02-27T04:47:40 *** captjakk has quit IRC
652020-02-27T04:53:29 *** sdddddd has joined #bitcoin-core-dev
662020-02-27T04:54:02 *** captjakk has joined #bitcoin-core-dev
672020-02-27T05:07:26 *** sdddddd has quit IRC
682020-02-27T05:08:25 *** sdddddd has joined #bitcoin-core-dev
692020-02-27T05:11:22 *** AaronvanW has quit IRC
702020-02-27T05:17:19 *** captjakk has quit IRC
712020-02-27T05:32:19 *** guest534543 has joined #bitcoin-core-dev
722020-02-27T05:34:31 *** Kiminuo has quit IRC
732020-02-27T05:48:51 *** guest534543 has quit IRC
742020-02-27T05:49:13 *** Kiminuo has joined #bitcoin-core-dev
752020-02-27T05:49:40 <Kiminuo> fanquake, Ah, sorry. Thanks for information
762020-02-27T06:00:02 *** hollisb has quit IRC
772020-02-27T06:02:23 *** harrigan_ has joined #bitcoin-core-dev
782020-02-27T06:04:28 *** harrigan has quit IRC
792020-02-27T06:05:49 *** promag has joined #bitcoin-core-dev
802020-02-27T06:10:02 *** promag has quit IRC
812020-02-27T06:15:57 *** Fiver has joined #bitcoin-core-dev
822020-02-27T06:28:46 *** goat_ has quit IRC
832020-02-27T06:34:43 *** Kiminuo has quit IRC
842020-02-27T06:43:11 *** Kiminuo has joined #bitcoin-core-dev
852020-02-27T06:50:25 *** EagleTM has joined #bitcoin-core-dev
862020-02-27T06:58:03 *** jorijn has quit IRC
872020-02-27T06:58:31 *** jorijn has joined #bitcoin-core-dev
882020-02-27T07:00:15 *** goat_ has joined #bitcoin-core-dev
892020-02-27T07:08:32 *** manantial has joined #bitcoin-core-dev
902020-02-27T07:08:33 *** AaronvanW has joined #bitcoin-core-dev
912020-02-27T07:24:55 *** EagleTM has quit IRC
922020-02-27T07:40:29 *** vasild_ has joined #bitcoin-core-dev
932020-02-27T07:42:10 *** AaronvanW has quit IRC
942020-02-27T07:43:43 *** vasild has quit IRC
952020-02-27T08:00:03 *** sipa has quit IRC
962020-02-27T08:02:02 *** sipa has joined #bitcoin-core-dev
972020-02-27T08:07:48 *** promag has joined #bitcoin-core-dev
982020-02-27T08:08:41 *** EagleTM has joined #bitcoin-core-dev
992020-02-27T08:12:35 *** promag has quit IRC
1002020-02-27T08:13:52 <provoostenator> achow101 I don't have strong feelings if we should cache all the things or not. A typical wallet would still be smaller than a single block.
1012020-02-27T08:14:59 <provoostenator> If the performance difference is very small than I'm biased to keeping it lean.
1022020-02-27T08:15:32 <provoostenator> (disk cache I mean)
1032020-02-27T08:16:27 *** vasild_ is now known as vasild
1042020-02-27T08:22:50 *** marcoagner has joined #bitcoin-core-dev
1052020-02-27T08:32:23 *** EagleTM has quit IRC
1062020-02-27T08:39:31 *** jorijn has quit IRC
1072020-02-27T08:39:53 *** jorijn has joined #bitcoin-core-dev
1082020-02-27T08:44:46 *** promag has joined #bitcoin-core-dev
1092020-02-27T08:51:39 *** rafalcpp has quit IRC
1102020-02-27T08:53:26 *** rafalcpp has joined #bitcoin-core-dev
1112020-02-27T08:59:25 *** oguzkoroglu has quit IRC
1122020-02-27T08:59:51 *** oguzkoroglu has joined #bitcoin-core-dev
1132020-02-27T09:00:02 *** Fiver has quit IRC
1142020-02-27T09:06:52 *** promag has quit IRC
1152020-02-27T09:09:10 *** promag has joined #bitcoin-core-dev
1162020-02-27T09:11:53 *** Guyver2 has joined #bitcoin-core-dev
1172020-02-27T09:14:56 *** promag has quit IRC
1182020-02-27T09:18:07 *** Plasmastar1 has joined #bitcoin-core-dev
1192020-02-27T09:25:41 *** RubenSomsen has quit IRC
1202020-02-27T09:26:00 *** RubenSomsen has joined #bitcoin-core-dev
1212020-02-27T09:31:29 *** AaronvanW has joined #bitcoin-core-dev
1222020-02-27T09:31:59 *** jorijn has quit IRC
1232020-02-27T09:32:19 *** jorijn has joined #bitcoin-core-dev
1242020-02-27T09:33:49 *** ghost43 has quit IRC
1252020-02-27T09:35:06 *** ghost43 has joined #bitcoin-core-dev
1262020-02-27T09:36:27 *** murrayn has quit IRC
1272020-02-27T09:37:13 *** rockhouse has quit IRC
1282020-02-27T09:37:42 *** rockhouse has joined #bitcoin-core-dev
1292020-02-27T09:38:00 *** murray has joined #bitcoin-core-dev
1302020-02-27T09:38:24 *** murray is now known as Guest23538
1312020-02-27T09:54:30 *** timothy has joined #bitcoin-core-dev
1322020-02-27T09:56:24 *** AaronvanW has quit IRC
1332020-02-27T09:56:42 *** AaronvanW has joined #bitcoin-core-dev
1342020-02-27T10:00:36 *** promag has joined #bitcoin-core-dev
1352020-02-27T10:03:25 *** jorijn has quit IRC
1362020-02-27T10:03:45 *** ghost43 has quit IRC
1372020-02-27T10:04:21 *** jorijn has joined #bitcoin-core-dev
1382020-02-27T10:04:32 *** ghost43 has joined #bitcoin-core-dev
1392020-02-27T10:13:37 *** rafalcpp has quit IRC
1402020-02-27T10:15:34 *** Emcy has quit IRC
1412020-02-27T10:29:00 *** Emcy has joined #bitcoin-core-dev
1422020-02-27T10:31:35 *** promag has quit IRC
1432020-02-27T10:37:26 *** promag has joined #bitcoin-core-dev
1442020-02-27T11:03:58 *** Meaghan35Fritsch has joined #bitcoin-core-dev
1452020-02-27T11:25:14 *** Zenton has joined #bitcoin-core-dev
1462020-02-27T11:28:09 *** belcher has joined #bitcoin-core-dev
1472020-02-27T11:45:03 *** jorijn has quit IRC
1482020-02-27T11:45:26 *** ghost43 has quit IRC
1492020-02-27T11:45:33 *** jorijn has joined #bitcoin-core-dev
1502020-02-27T11:45:42 *** ghost43 has joined #bitcoin-core-dev
1512020-02-27T11:55:26 *** promag has quit IRC
1522020-02-27T11:55:50 *** promag has joined #bitcoin-core-dev
1532020-02-27T11:57:05 *** promag has quit IRC
1542020-02-27T11:58:14 *** jorijn has quit IRC
1552020-02-27T12:00:02 *** Plasmastar1 has quit IRC
1562020-02-27T12:01:58 *** jorijn has joined #bitcoin-core-dev
1572020-02-27T12:06:17 *** jorijn has quit IRC
1582020-02-27T12:07:56 *** promag has joined #bitcoin-core-dev
1592020-02-27T12:08:04 *** jorijn has joined #bitcoin-core-dev
1602020-02-27T12:12:27 *** jorijn has quit IRC
1612020-02-27T12:17:48 *** esden1 has joined #bitcoin-core-dev
1622020-02-27T12:22:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1632020-02-27T12:23:13 *** jorijn has joined #bitcoin-core-dev
1642020-02-27T12:25:49 *** promag has quit IRC
1652020-02-27T12:25:53 *** _andrewtoth_ has quit IRC
1662020-02-27T12:26:15 *** _andrewtoth_ has joined #bitcoin-core-dev
1672020-02-27T12:27:11 *** Bullitje has joined #bitcoin-core-dev
1682020-02-27T12:27:26 *** sdddddd has quit IRC
1692020-02-27T12:28:54 *** Emcy has quit IRC
1702020-02-27T12:29:17 *** Meaghan35Fritsch has quit IRC
1712020-02-27T12:30:03 *** Bullit has quit IRC
1722020-02-27T12:34:30 *** promag has joined #bitcoin-core-dev
1732020-02-27T12:37:02 *** promag has joined #bitcoin-core-dev
1742020-02-27T12:43:45 *** sdddddd has joined #bitcoin-core-dev
1752020-02-27T12:44:50 *** promag has quit IRC
1762020-02-27T12:54:25 *** timothy has quit IRC
1772020-02-27T12:55:39 *** Highway61 has joined #bitcoin-core-dev
1782020-02-27T12:56:31 *** timothy has joined #bitcoin-core-dev
1792020-02-27T12:59:49 *** Highway61 has quit IRC
1802020-02-27T13:00:25 *** promag has joined #bitcoin-core-dev
1812020-02-27T13:02:20 *** Highway61 has joined #bitcoin-core-dev
1822020-02-27T13:24:10 *** Klox has joined #bitcoin-core-dev
1832020-02-27T13:24:23 *** promag has quit IRC
1842020-02-27T13:25:41 *** promag has joined #bitcoin-core-dev
1852020-02-27T13:27:05 *** promag has quit IRC
1862020-02-27T13:31:38 *** promag has joined #bitcoin-core-dev
1872020-02-27T13:32:52 *** promag has quit IRC
1882020-02-27T13:33:28 *** promag has joined #bitcoin-core-dev
1892020-02-27T13:36:24 *** promag has quit IRC
1902020-02-27T13:43:22 *** promag has joined #bitcoin-core-dev
1912020-02-27T13:47:43 *** filchef has joined #bitcoin-core-dev
1922020-02-27T13:55:02 *** Highway61 has quit IRC
1932020-02-27T13:55:58 *** Highway61 has joined #bitcoin-core-dev
1942020-02-27T14:05:02 *** Emcy has joined #bitcoin-core-dev
1952020-02-27T14:08:24 *** promag has quit IRC
1962020-02-27T14:09:05 *** promag has joined #bitcoin-core-dev
1972020-02-27T14:13:33 *** promag has quit IRC
1982020-02-27T14:16:28 *** bitcoin-git has joined #bitcoin-core-dev
1992020-02-27T14:16:28 <bitcoin-git> [bitcoin] dangershony opened pull request #18212: Add missing step in win deployment instructions. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18212
2002020-02-27T14:16:29 *** bitcoin-git has left #bitcoin-core-dev
2012020-02-27T14:29:18 *** promag has joined #bitcoin-core-dev
2022020-02-27T14:33:52 *** promag has quit IRC
2032020-02-27T14:39:17 *** promag has joined #bitcoin-core-dev
2042020-02-27T14:45:37 <instagibbs> anyone else having trouble getting comments through in github
2052020-02-27T14:46:08 <instagibbs> yeah submitting review giving me an octopus
2062020-02-27T14:54:38 *** mdunnio has joined #bitcoin-core-dev
2072020-02-27T14:57:07 *** promag has quit IRC
2082020-02-27T14:59:17 *** promag has joined #bitcoin-core-dev
2092020-02-27T15:00:01 *** esden1 has quit IRC
2102020-02-27T15:03:11 *** promag has quit IRC
2112020-02-27T15:04:21 *** promag has joined #bitcoin-core-dev
2122020-02-27T15:07:59 *** promag has quit IRC
2132020-02-27T15:14:11 <pinheadmz> instagibbs: https://www.githubstatus.com/ ... guess I'll... go ... outside??
2142020-02-27T15:17:26 *** promag has joined #bitcoin-core-dev
2152020-02-27T15:17:52 *** epicfail^ has joined #bitcoin-core-dev
2162020-02-27T15:21:01 <instagibbs> Going to start e-mailing reviews now
2172020-02-27T15:22:01 *** promag has quit IRC
2182020-02-27T15:22:33 *** Kiminuo has quit IRC
2192020-02-27T15:28:58 *** promag has joined #bitcoin-core-dev
2202020-02-27T15:33:43 *** promag has quit IRC
2212020-02-27T15:34:04 *** ekrok has joined #bitcoin-core-dev
2222020-02-27T15:41:33 *** Chris_Stewart_5 has quit IRC
2232020-02-27T15:42:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2242020-02-27T15:43:38 *** promag has joined #bitcoin-core-dev
2252020-02-27T15:48:55 *** promag has quit IRC
2262020-02-27T15:51:01 *** promag has joined #bitcoin-core-dev
2272020-02-27T16:00:43 *** ddustin has joined #bitcoin-core-dev
2282020-02-27T16:05:15 *** ddustin has quit IRC
2292020-02-27T16:08:41 *** Kiminuo has joined #bitcoin-core-dev
2302020-02-27T16:09:35 *** promag has quit IRC
2312020-02-27T16:13:57 *** promag has joined #bitcoin-core-dev
2322020-02-27T16:16:03 *** promag has quit IRC
2332020-02-27T16:19:05 *** promag has joined #bitcoin-core-dev
2342020-02-27T16:20:48 *** promag has quit IRC
2352020-02-27T17:06:03 *** goat_ has quit IRC
2362020-02-27T17:14:43 *** mdunnio has quit IRC
2372020-02-27T17:17:48 *** captjakk has joined #bitcoin-core-dev
2382020-02-27T17:27:58 *** Highway61 has quit IRC
2392020-02-27T17:29:02 *** Highway61 has joined #bitcoin-core-dev
2402020-02-27T17:33:43 *** _andrewtoth_ has quit IRC
2412020-02-27T17:40:14 *** Talkless has joined #bitcoin-core-dev
2422020-02-27T18:00:02 *** epicfail^ has quit IRC
2432020-02-27T18:10:06 *** promag has joined #bitcoin-core-dev
2442020-02-27T18:17:48 *** wez has joined #bitcoin-core-dev
2452020-02-27T18:20:04 *** promag has quit IRC
2462020-02-27T18:22:36 *** promag has joined #bitcoin-core-dev
2472020-02-27T18:27:42 *** MasterdonX has quit IRC
2482020-02-27T18:27:58 *** MasterdonX has joined #bitcoin-core-dev
2492020-02-27T18:31:28 *** as_pnn1 has quit IRC
2502020-02-27T18:33:42 *** as_pnn has joined #bitcoin-core-dev
2512020-02-27T18:40:36 *** lightlike has joined #bitcoin-core-dev
2522020-02-27T18:40:46 *** mdunnio has joined #bitcoin-core-dev
2532020-02-27T18:42:43 *** Chris_Stewart_5 has quit IRC
2542020-02-27T18:44:16 <jonatack> Apologies to those whose PRs I planned to finish reviewing this week... been fighting off something flu-like this week (despite getting a flu shot last fall)
2552020-02-27T18:44:32 *** Giderey36 has joined #bitcoin-core-dev
2562020-02-27T18:45:16 <jonatack> sounds like GitHub hasn't been cooperating with review, either
2572020-02-27T18:46:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2582020-02-27T18:48:24 *** as_pnn has quit IRC
2592020-02-27T18:53:50 *** goat_ has joined #bitcoin-core-dev
2602020-02-27T18:54:01 *** as_pnn has joined #bitcoin-core-dev
2612020-02-27T18:54:04 *** as_pnn has quit IRC
2622020-02-27T18:54:33 *** Giderey_36 has joined #bitcoin-core-dev
2632020-02-27T18:58:01 *** Giderey36 has quit IRC
2642020-02-27T18:59:47 <elichai2> jonatack: hope you'll feel better soon!
2652020-02-27T19:00:14 *** Giderey_36 has quit IRC
2662020-02-27T19:00:16 *** Zenton has quit IRC
2672020-02-27T19:00:18 *** Giderey36 has joined #bitcoin-core-dev
2682020-02-27T19:00:42 <wumpus> #startmeeting
2692020-02-27T19:00:42 <lightningbot> Meeting started Thu Feb 27 19:00:42 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2702020-02-27T19:00:42 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2712020-02-27T19:00:44 <jonatack> elichai2: thanks! your siphash pr and suhas' wtxid one are top of my list
2722020-02-27T19:01:15 <provoostenator> hi
2732020-02-27T19:01:18 <kanzure> hi
2742020-02-27T19:01:20 <elichai2> Hi
2752020-02-27T19:01:47 <achow101> hi
2762020-02-27T19:01:52 <sipa> hi
2772020-02-27T19:01:56 <jonatack> hi
2782020-02-27T19:02:06 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
2792020-02-27T19:02:07 <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
2802020-02-27T19:02:09 <hebasto> hi
2812020-02-27T19:02:13 <lightlike> hi
2822020-02-27T19:02:14 <promag> hi
2832020-02-27T19:02:28 <fjahr> hi
2842020-02-27T19:02:35 <meshcollider> hi
2852020-02-27T19:02:38 <jonasschnelli> hi
2862020-02-27T19:03:05 <wumpus> two proposed topics in proposedmeetingtopics: macOS notarization (jonasschnelli), more topic collection for upcoming physical meeting (kanzure)
2872020-02-27T19:04:00 <wumpus> any last minute topics?
2882020-02-27T19:04:29 <wumpus> FWIW 0.20.0 feature freeze is in about half a month
2892020-02-27T19:04:45 <instagibbs> hi
2902020-02-27T19:04:58 <wumpus> see for schedule: https://github.com/bitcoin/bitcoin/issues/17432
2912020-02-27T19:05:10 <wumpus> #topic High priority for review
2922020-02-27T19:05:44 <wumpus> 7 blockers, 1 bugfix, 6 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
2932020-02-27T19:06:04 <achow101> Add #18115
2942020-02-27T19:06:08 <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
2952020-02-27T19:06:08 *** goat_ has quit IRC
2962020-02-27T19:06:13 <provoostenator> +1
2972020-02-27T19:06:35 *** goat_ has joined #bitcoin-core-dev
2982020-02-27T19:07:33 <wumpus> added
2992020-02-27T19:07:53 *** mdunnio has quit IRC
3002020-02-27T19:08:12 <wumpus> anything else to add/remove, or that is ready for merge?
3012020-02-27T19:08:47 <provoostenator> I was hoping #17509 is ready, though maybe meshcollider can review first (it's not strictly wallet)
3022020-02-27T19:08:49 <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
3032020-02-27T19:09:03 <wumpus> that one does seem the closest
3042020-02-27T19:09:20 <gleb> hi
3052020-02-27T19:09:27 <jnewbery> hi
3062020-02-27T19:09:41 <ariard> hi
3072020-02-27T19:09:59 <meshcollider> provoostenator: sure, I can review it :) Missed it actually sorry because it's only tagged GUI
3082020-02-27T19:10:16 <sdaftuar> hi
3092020-02-27T19:10:27 <provoostenator> If it makes it in, I pre-nominate gwillen's #18027 after that, nice to get that in for the feature freeze
3102020-02-27T19:10:30 <gribble> https://github.com/bitcoin/bitcoin/issues/18027 | "PSBT Operations" dialog by gwillen · Pull Request #18027 · bitcoin/bitcoin · GitHub
3112020-02-27T19:10:44 <instagibbs> yeah that would be awesome ^
3122020-02-27T19:10:48 <wumpus> that would be very nice
3132020-02-27T19:10:58 <MarcoFalke> Can I add #17809 to high prio? It is a lot of changes, but shouldn't be too hard to review.
3142020-02-27T19:11:02 <gribble> https://github.com/bitcoin/bitcoin/issues/17809 | rpc: Auto-format RPCResult by MarcoFalke · Pull Request #17809 · bitcoin/bitcoin · GitHub
3152020-02-27T19:11:06 <instagibbs> no need to open up -cli/console for anything PSBT related
3162020-02-27T19:11:07 <provoostenator> +1
3172020-02-27T19:11:21 <wumpus> MarcoFalke: sure
3182020-02-27T19:12:10 <wumpus> added
3192020-02-27T19:13:31 <wumpus> #topic macOS notarization (jonasschnelli)
3202020-02-27T19:13:33 <provoostenator> We could try #18187 on v0.19.1rc3; if that's the only change it can be tested very quickly.
3212020-02-27T19:13:35 <gribble> https://github.com/bitcoin/bitcoin/issues/18187 | Add macOS notarization (including stapling) by jonasschnelli · Pull Request #18187 · bitcoin/bitcoin · GitHub
3222020-02-27T19:13:52 <jonasschnelli> 18187 is pretty much it
3232020-02-27T19:14:07 <wumpus> do we need a 0.19.1rc3?
3242020-02-27T19:14:12 <jonasschnelli> It changes the process how we create the final macOS app
3252020-02-27T19:14:35 <jonasschnelli> for the notarization, we don't need a rc3 I think... but it could help
3262020-02-27T19:14:36 <provoostenator> It adds a staple to the signed binary, which is better for privacy
3272020-02-27T19:14:43 <wumpus> thanks for working on this btw
3282020-02-27T19:14:47 <provoostenator> And something we should test ideally
3292020-02-27T19:14:52 <jonasschnelli> yes.
3302020-02-27T19:15:18 <jonasschnelli> if there are any questions or possible problems (privacy / security), ask now! :)
3312020-02-27T19:15:23 <wumpus> yes, we could do a rc3 just to test this, though I think many would like 0.19.1 out of the door, and we could test this for 0.20.0rc1 as well it takes somewhat longer but dunno
3322020-02-27T19:15:50 <wumpus> it's more in line with the usual flow of doing things on master first
3332020-02-27T19:16:07 <wumpus> but no strong opinion
3342020-02-27T19:16:13 <provoostenator> True, but it's nice to test this on a smaller demographic than the 0.20 release
3352020-02-27T19:16:24 <jonasschnelli> We can notarize 0.19.1 anyways (even without 18187)
3362020-02-27T19:16:37 <jonasschnelli> I think targeting the pull for 0.20 makes sense
3372020-02-27T19:16:41 <wumpus> do you think 0.20.0rc1 will have a larger demograhic?
3382020-02-27T19:17:03 <sipa> 0.20.0 likely will have bigger adoption than 0.19.1
3392020-02-27T19:17:11 <sipa> don't know about the rc's
3402020-02-27T19:17:15 <jonasschnelli> Maybe we skip 0.19.1 and focus on a rc
3412020-02-27T19:17:16 <provoostenator> That's what I mean. The rc I can test myself
3422020-02-27T19:17:17 <wumpus> a lot of people wait for .1 fwiw
3432020-02-27T19:17:22 <wumpus> don't know about rcs
3442020-02-27T19:17:26 <jonasschnelli> There is the risk that we corrupt the final dmg otherwise
3452020-02-27T19:17:45 <sipa> no strong opinion either way here
3462020-02-27T19:18:08 <wumpus> ok, lets just merge it for 0.20 then
3472020-02-27T19:18:16 <jonasschnelli> if I publish the notarization ticket together with the code signature, it would automatically end up in the final dmg
3482020-02-27T19:18:20 <wumpus> then backport if it works
3492020-02-27T19:18:22 <jonasschnelli> but we had no test if we go for 0.19.1
3502020-02-27T19:18:32 <provoostenator> I don't like the privacy implications of not stapling, so then I suggest we don't notarize it, and just leave it right-click to install
3512020-02-27T19:18:39 <jonasschnelli> yes. Lets merge and do the process only for 0.20rcX
3522020-02-27T19:18:56 <jonasschnelli> provoostenator: thats a good point.
3532020-02-27T19:19:10 <jonasschnelli> But no-one AFAIK has done a privacy related test.
3542020-02-27T19:19:23 <jonasschnelli> We don't know if the GateKeeper server will not be contacted if the ticket is stapled
3552020-02-27T19:19:30 <jonasschnelli> I haven't tested it (yet)
3562020-02-27T19:19:39 <jonasschnelli> But very likely its completely offline
3572020-02-27T19:20:10 <provoostenator> Well, if not, then they might as well ping gatekeeper for non-notarized binaries too and that's the end of macOS privacy :-)
3582020-02-27T19:20:35 <jonasschnelli> Yes. There are little more we can do...
3592020-02-27T19:20:48 <wumpus> that's what happens with platforms closing up
3602020-02-27T19:21:11 <wumpus> Cory Doctorow was right with his war on general purpose computing
3612020-02-27T19:21:22 <jonasschnelli> Yeah. I guess the staping concept is probably acceptable.
3622020-02-27T19:21:36 <jonasschnelli> But yeah. It's the digital war agains terrorism
3632020-02-27T19:21:45 <jonasschnelli> (== - privacy)
3642020-02-27T19:21:47 <wumpus> yep
3652020-02-27T19:22:10 <jonasschnelli> What if we notarize 0.19.1 without stapeling?
3662020-02-27T19:22:21 <wumpus> okay, one topic left
3672020-02-27T19:22:25 <jonasschnelli> It would run without changing the security settings
3682020-02-27T19:22:40 <wumpus> #topic more topic collection for upcoming physical meeting (kanzure)
3692020-02-27T19:22:44 <provoostenator> But it would potentially doxx users to Apple
3702020-02-27T19:22:47 *** promag has quit IRC
3712020-02-27T19:22:51 <kanzure> hey yeah just a reminder that we have a meeting in a month and i'm collecting topics
3722020-02-27T19:23:01 <kanzure> need to poke jnewbery for survey entries iirc
3732020-02-27T19:23:25 <jonasschnelli> provoostenator: lets talk on 18187
3742020-02-27T19:23:27 <kanzure> i have a short document with a list of things that people have asked about.
3752020-02-27T19:24:51 <kanzure> that's all
3762020-02-27T19:24:59 <kanzure> in other news, HWI irc logs are now available http://gnusha.org/hwi/
3772020-02-27T19:25:26 <wumpus> great!
3782020-02-27T19:26:46 <wumpus> #endmeeting
3792020-02-27T19:26:46 <lightningbot> Meeting ended Thu Feb 27 19:26:46 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3802020-02-27T19:26:46 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-27-19.00.html
3812020-02-27T19:26:46 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-27-19.00.txt
3822020-02-27T19:26:46 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-02-27-19.00.log.html
3832020-02-27T19:30:25 *** timothy has quit IRC
3842020-02-27T19:33:14 <instagibbs> coredev during feature freeze, guess that means more discussion vs merging :)
3852020-02-27T19:36:09 *** bitcoin-git has joined #bitcoin-core-dev
3862020-02-27T19:36:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4502ed7cd1b3...324a6dfeafcb
3872020-02-27T19:36:09 <bitcoin-git> bitcoin/master 2f63ffd practicalswift: tests: Add fuzzing harness for V1TransportDeserializer (P2P transport)
3882020-02-27T19:36:10 <bitcoin-git> bitcoin/master 324a6df MarcoFalke: Merge #17771: tests: Add fuzzing harness for V1TransportDeserializer (P2P ...
3892020-02-27T19:36:18 *** bitcoin-git has left #bitcoin-core-dev
3902020-02-27T19:36:48 *** bitcoin-git has joined #bitcoin-core-dev
3912020-02-27T19:36:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17771: tests: Add fuzzing harness for V1TransportDeserializer (P2P transport) (master...fuzzers-p2p_transport_deserializer) https://github.com/bitcoin/bitcoin/pull/17771
3922020-02-27T19:36:49 *** bitcoin-git has left #bitcoin-core-dev
3932020-02-27T19:40:40 *** vasild_ has joined #bitcoin-core-dev
3942020-02-27T19:43:26 *** Giderey36 has quit IRC
3952020-02-27T19:43:43 *** vasild has quit IRC
3962020-02-27T19:46:03 *** Giderey36 has joined #bitcoin-core-dev
3972020-02-27T19:56:28 *** captjakk has quit IRC
3982020-02-27T20:01:37 *** mol has quit IRC
3992020-02-27T20:03:14 *** mol has joined #bitcoin-core-dev
4002020-02-27T20:03:23 *** bitcoin-git has joined #bitcoin-core-dev
4012020-02-27T20:03:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/324a6dfeafcb...1615043935ef
4022020-02-27T20:03:24 <bitcoin-git> bitcoin/master b902bd6 Sebastian Falbesoner: test: check custom descendant limit in mempool_packages.py
4032020-02-27T20:03:25 <bitcoin-git> bitcoin/master 1615043 MarcoFalke: Merge #17461: test: check custom descendant limit in mempool_packages.py
4042020-02-27T20:03:27 *** bitcoin-git has left #bitcoin-core-dev
4052020-02-27T20:04:00 *** captjakk has joined #bitcoin-core-dev
4062020-02-27T20:04:08 *** bitcoin-git has joined #bitcoin-core-dev
4072020-02-27T20:04:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17461: test: check custom descendant limit in mempool_packages.py (master...20191112-test-check_custom_descendant_limit_in_mempool-packages) https://github.com/bitcoin/bitcoin/pull/17461
4082020-02-27T20:04:10 *** bitcoin-git has left #bitcoin-core-dev
4092020-02-27T20:14:17 *** kvaciral has joined #bitcoin-core-dev
4102020-02-27T20:20:57 *** Chris_Stewart_5 has quit IRC
4112020-02-27T20:21:16 *** Giderey36 has quit IRC
4122020-02-27T20:27:00 *** captjakk has quit IRC
4132020-02-27T20:28:08 *** bitcoin-git has joined #bitcoin-core-dev
4142020-02-27T20:28:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18213: test: Fix race in p2p_segwit (master...2002-qaFixRaceSegwit) https://github.com/bitcoin/bitcoin/pull/18213
4152020-02-27T20:28:09 *** bitcoin-git has left #bitcoin-core-dev
4162020-02-27T20:29:07 *** Emcy has quit IRC
4172020-02-27T20:29:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4182020-02-27T20:30:32 *** Talkless has quit IRC
4192020-02-27T20:33:32 *** captjakk has joined #bitcoin-core-dev
4202020-02-27T20:35:40 <Kiminuo> Hello, anyone willing to take a look at https://github.com/kiminuo/bitcoin/commit/150e950461fdb929e45aee50126766c8a159a2c2 for (pre)review?
4212020-02-27T20:41:45 *** darkbyte1 has joined #bitcoin-core-dev
4222020-02-27T20:42:20 *** Emcy has joined #bitcoin-core-dev
4232020-02-27T20:45:30 *** Zenton has joined #bitcoin-core-dev
4242020-02-27T20:45:54 *** promag has joined #bitcoin-core-dev
4252020-02-27T20:51:17 *** promag has quit IRC
4262020-02-27T20:54:42 *** promag has joined #bitcoin-core-dev
4272020-02-27T21:00:01 *** wez has quit IRC
4282020-02-27T21:02:09 *** owowo has quit IRC
4292020-02-27T21:02:33 *** Emcy has joined #bitcoin-core-dev
4302020-02-27T21:06:18 *** owowo has joined #bitcoin-core-dev
4312020-02-27T21:06:41 <instagibbs> Kiminuo, you should just open a "draft" PR for more visibility
4322020-02-27T21:06:50 <instagibbs> (there's some setting somewhere to make it a draft)
4332020-02-27T21:07:56 <Kiminuo> I have already did that. I have pushed many force-commits and fanquake was unhappy about that. That's why I have turned on Travis for my account and keep shooting commits there :)
4342020-02-27T21:08:10 <Kiminuo> this is draft-of-draft :)
4352020-02-27T21:08:30 <Kiminuo> I'll push it to bitcoin repo when I'm sufficiently happy about it
4362020-02-27T21:15:11 <luke-jr> don't un-notarised DMGs still ping Apple to see if they are notarized?
4372020-02-27T21:15:47 <luke-jr> jonasschnelli:
4382020-02-27T21:16:24 <jonasschnelli> luke-jr: yeah. I have that feeling as well. Otherwise how could the os know its notarized
4392020-02-27T21:16:52 <jonasschnelli> Maybe it doesn't check if one disables the security feature or if he right-click-opens (don't think so though)
4402020-02-27T21:16:59 <luke-jr> jonasschnelli: does anything stop <random Joe> from notarising it "for" us? :x
4412020-02-27T21:17:33 <jonasschnelli> luke-jr: you can only notarize apps with your registered bundle id
4422020-02-27T21:17:37 <jonasschnelli> (AFAIK)
4432020-02-27T21:17:54 <jonasschnelli> so you need to provide username/passphrase during notarization which binds to your registered bundle ids
4442020-02-27T21:18:20 *** promag has quit IRC
4452020-02-27T21:18:27 *** tvn has joined #bitcoin-core-dev
4462020-02-27T21:18:35 <luke-jr> which is tied to the signing we already do?
4472020-02-27T21:18:37 <jonasschnelli> as for privacy,... you'r probably already married with Apple somehow.
4482020-02-27T21:18:51 <jonasschnelli> luke-jr: yes
4492020-02-27T21:19:05 <luke-jr> + Users running macOS Catalina may need to "right-click" and then choose "Open"
4502020-02-27T21:19:06 <luke-jr> + to open the Bitcoin Knots .dmg. This is due to new signing requirements
4512020-02-27T21:19:07 <luke-jr> + imposed by Apple, which the Bitcoin Knots project does not implement.
4522020-02-27T21:19:09 <luke-jr> wumpus: ^ should be re-added to release notes if we're not doing the notary thing yet
4532020-02-27T21:19:17 <luke-jr> err, s/Knots/Core/ ofc ;)
4542020-02-27T21:22:52 <jonasschnelli> luke-jr: do you codesign Knots?
4552020-02-27T21:25:20 <sipa> i had to read that 3 times before realizing you we're asking luke-jr about co-designers of Knots
4562020-02-27T21:25:22 <luke-jr> jonasschnelli: no, but I would welcome signatures
4572020-02-27T21:25:32 <sipa> *weren't
4582020-02-27T21:25:38 <luke-jr> sipa: haha
4592020-02-27T21:25:42 <jonasschnelli> sipa: heh
4602020-02-27T21:26:12 <jonasschnelli> luke-jr: you could register at apple (99$/year) or we could see if we want to sign it with the Bitcoin Core Code Sign Association key.
4612020-02-27T21:26:14 <luke-jr> jonasschnelli: lately, Knots hasn't even come close to the goal of 3+ gitian sigs even tho :/
4622020-02-27T21:26:25 <jonasschnelli> I would be okay with that,... as long as we have a clear policy
4632020-02-27T21:26:37 <luke-jr> jonasschnelli: the latter seems more logical - but IMO we should retain the required gitian signatures first
4642020-02-27T21:26:56 <jonasschnelli> luke-jr: indeed. I'll try to run my builder next time. Just ping me.
4652020-02-27T21:26:58 <luke-jr> without 3+ gitian sigs, BCCSA clearly shouldn't sign it
4662020-02-27T21:27:06 <luke-jr> jonasschnelli: thanks
4672020-02-27T22:04:13 *** bitcoin-git has joined #bitcoin-core-dev
4682020-02-27T22:04:13 <bitcoin-git> [bitcoin] instagibbs opened pull request #18214: Give slightly more understandable advice when needing -fallbackfee (master...fallback_msg) https://github.com/bitcoin/bitcoin/pull/18214
4692020-02-27T22:04:14 *** bitcoin-git has left #bitcoin-core-dev
4702020-02-27T22:34:55 *** kristapsk_ has joined #bitcoin-core-dev
4712020-02-27T22:37:03 *** kristapsk has quit IRC
4722020-02-27T22:43:28 *** darkbyte1 has quit IRC
4732020-02-27T23:02:14 *** oguzkoroglu has quit IRC
4742020-02-27T23:02:37 *** oguzkoroglu has joined #bitcoin-core-dev
4752020-02-27T23:06:52 *** manantial has quit IRC
4762020-02-27T23:07:31 *** darkbyte1 has joined #bitcoin-core-dev
4772020-02-27T23:12:24 *** Guyver2 has quit IRC
4782020-02-27T23:12:29 *** captjakk has quit IRC
4792020-02-27T23:14:43 *** filchef has quit IRC
4802020-02-27T23:19:00 *** promag has joined #bitcoin-core-dev
4812020-02-27T23:23:15 *** promag has quit IRC
4822020-02-27T23:27:54 <stevenroose> Just a heads up, the estimatesmartfee documentation is not optimal:
4832020-02-27T23:27:57 <stevenroose> "confirmation within conf_target blocks if possible and return the number of blocks\n"
4842020-02-27T23:27:59 <stevenroose> "for which the estimate is valid. Uses virtual transaction size as defined\n"
4852020-02-27T23:28:12 <stevenroose> and then " \"blocks\" : n (numeric) block number where estimate was found\n"
4862020-02-27T23:28:28 <stevenroose> It's not really clear what the "blocks" return value is supposed to be.
4872020-02-27T23:28:41 *** promag has joined #bitcoin-core-dev
4882020-02-27T23:29:23 <stevenroose> Is it supposed to be a block height or a block height delta?
4892020-02-27T23:30:28 <stevenroose> Is it the block height at which a tx with the given fee is supposed to go in? Or does it indicate for how long I can reliably keep using the same estimation?
4902020-02-27T23:30:54 <stevenroose> If anyone thinks this is confusing enough for me to open an issue, I'd be happy to. Let me know.
4912020-02-27T23:32:23 *** SiAnDoG_ has quit IRC
4922020-02-27T23:34:57 <fanquake> stevenroose: opening an issue sounds worthwhile
4932020-02-27T23:37:45 <stevenroose> Opening one, if you can tell me with certainty what it actually is, I can also make a PR to improve the documentation, if you prefer.
4942020-02-27T23:43:31 *** bitcoin-git has joined #bitcoin-core-dev
4952020-02-27T23:43:31 <bitcoin-git> [bitcoin] Empact opened pull request #18216: test, build: Enable -Werror=sign-compare (master...2020-02-sign-compare) https://github.com/bitcoin/bitcoin/pull/18216
4962020-02-27T23:43:34 *** bitcoin-git has left #bitcoin-core-dev
4972020-02-27T23:44:53 *** TheRec has quit IRC
4982020-02-27T23:58:18 *** marcoagner has quit IRC