12020-03-06T00:00:02 *** netsoundW1 has quit IRC
22020-03-06T00:00:29 *** promag has quit IRC
32020-03-06T00:01:43 *** jarthur has quit IRC
42020-03-06T00:02:42 *** jarthur_ has quit IRC
52020-03-06T00:04:24 *** sipsorcery has quit IRC
62020-03-06T00:11:46 *** Victorsueca has quit IRC
72020-03-06T00:13:35 *** Victorsueca has joined #bitcoin-core-dev
82020-03-06T00:15:21 *** Victor_sueca has joined #bitcoin-core-dev
92020-03-06T00:18:03 *** Victorsueca has quit IRC
102020-03-06T00:35:09 *** lightlike has quit IRC
112020-03-06T00:51:36 *** anditto has joined #bitcoin-core-dev
122020-03-06T00:54:25 *** shaunsun has quit IRC
132020-03-06T00:55:49 *** Spanktar has joined #bitcoin-core-dev
142020-03-06T01:18:04 *** captjakk_ has quit IRC
152020-03-06T01:19:58 *** pinheadmz_ has joined #bitcoin-core-dev
162020-03-06T01:21:04 *** pinheadmz has quit IRC
172020-03-06T01:21:04 *** pinheadmz_ is now known as pinheadmz
182020-03-06T01:48:51 *** pinheadmz_ has joined #bitcoin-core-dev
192020-03-06T01:49:43 *** pinheadmz has quit IRC
202020-03-06T01:49:43 *** pinheadmz_ is now known as pinheadmz
212020-03-06T01:51:22 *** Dean_Guss has joined #bitcoin-core-dev
222020-03-06T01:52:44 *** tryphe has quit IRC
232020-03-06T01:52:46 *** AaronvanW has quit IRC
242020-03-06T01:53:22 *** AaronvanW has joined #bitcoin-core-dev
252020-03-06T01:53:27 *** tryphe has joined #bitcoin-core-dev
262020-03-06T02:07:47 *** captjakk has joined #bitcoin-core-dev
272020-03-06T02:42:27 *** willcl_ark has quit IRC
282020-03-06T02:51:03 *** captjakk has quit IRC
292020-03-06T02:55:03 *** Dean_Guss has quit IRC
302020-03-06T03:00:01 *** Spanktar has quit IRC
312020-03-06T03:06:37 <luke-jr> aj: yt?
322020-03-06T03:07:57 <aj> luke-jr: yo
332020-03-06T03:08:11 <luke-jr> re https://github.com/bitcoin/bitcoin/pull/18271#issuecomment-595571229
342020-03-06T03:08:25 <luke-jr> wouldn't checking before wait_until result in a race?
352020-03-06T03:08:32 <luke-jr> eg, sleep after the check, then resume before wait_until?
362020-03-06T03:08:59 <luke-jr> the Travis thing is weird - it's crashing the entire VM somehow :/
372020-03-06T03:09:53 <aj> yes, i think you're right there'd still be that window for the bug
382020-03-06T03:10:23 <aj> the travis thing is just causing the test to hang until the travis timeout hits, isn't it?
392020-03-06T03:10:30 <luke-jr> the entire VM hangs
402020-03-06T03:10:49 <luke-jr> I'm running it in debug mode so I can strace/top/etc, and I can't even open a new tmux window
412020-03-06T03:11:01 <aj> wtf
422020-03-06T03:11:15 <aj> does that mean it's busy looping and using all cpu then?
432020-03-06T03:11:33 <luke-jr> that shouldn't be possible unless it was setting realtime prio or something stupid
442020-03-06T03:11:43 <luke-jr> trying catch (boost::thread_interrupted) { throw; } now
452020-03-06T03:12:19 <kallewoof> Anyone got any hints or ideas on why appveyor is complaining here? https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/31265297 (it's from #16411)
462020-03-06T03:12:21 <gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof · Pull Request #16411 · bitcoin/bitcoin · GitHub
472020-03-06T03:12:39 <kallewoof> It doesn't seem to like my RPCResult expressions, but they are identical to the other ones I see...
482020-03-06T03:14:18 <cncr04s> I really miss getinfo
492020-03-06T03:14:45 <luke-jr> why?
502020-03-06T03:15:05 <luke-jr> bitcoin-cli -getinfo
512020-03-06T03:15:49 <cncr04s> i have to type 3 api commands instead of just 1.
522020-03-06T03:16:03 <luke-jr> or just use -getinfo
532020-03-06T03:16:47 <cncr04s> This call was removed in version 0.16.0. Use the appropriate fields from:
542020-03-06T03:17:31 <luke-jr> -
552020-03-06T03:20:03 <aj> kallewoof: i think you need to rebase and update to match #17809 ?
562020-03-06T03:20:06 <gribble> https://github.com/bitcoin/bitcoin/issues/17809 | rpc: Auto-format RPCResult by MarcoFalke · Pull Request #17809 · bitcoin/bitcoin · GitHub
572020-03-06T03:21:02 <kallewoof> aj: Ahh! Okay, thanks, will do
582020-03-06T03:22:13 *** willcl_ark has joined #bitcoin-core-dev
592020-03-06T03:39:32 <kallewoof> aj: That was it. Thanks for the nudge. Will try to remember to rebase on master next time I see a weird error like that.
602020-03-06T03:41:52 <luke-jr> aj: looks like the extra catch and throw fixes it
612020-03-06T03:44:58 <kallewoof> Huh. I actually didn't realize there was a -getinfo command that was not deprecated. Thanks, luke-jr
622020-03-06T03:45:17 <luke-jr> np
632020-03-06T03:45:30 <luke-jr> tbh, I probably opposed it, but as long as it's there, might as well use it
642020-03-06T03:45:57 <kallewoof> cncr04s: in case you didn't get what he was saying, use a minus sign and it's still there.
652020-03-06T03:46:22 <kallewoof> luke-jr: i never really looked into why people were against getinfo in the first place
662020-03-06T03:46:47 <luke-jr> kallewoof: it did too much, took too many locks, etc and usually you only need a few things
672020-03-06T03:46:55 <luke-jr> makes more sense to just batch a bunch of requests together
682020-03-06T03:47:01 <kallewoof> ahh
692020-03-06T03:47:24 <luke-jr> also my perspective is that the RPC is for scripts/code to use, not humans ;P
702020-03-06T03:48:04 <kallewoof> luke-jr: i don't use GUI's if i can avoid it...
712020-03-06T03:48:31 <luke-jr> kallewoof: someone made a curses frontend for the RPC IIRC
722020-03-06T03:49:23 <kallewoof> i kinda just like the terminal experience without curses and such.
732020-03-06T03:49:32 <kallewoof> command. enter. result. rinse
742020-03-06T03:55:37 *** vinai has joined #bitcoin-core-dev
752020-03-06T03:55:57 *** jimmysong has joined #bitcoin-core-dev
762020-03-06T03:57:39 *** felixfoertsch has joined #bitcoin-core-dev
772020-03-06T03:59:34 *** felixfoertsch23 has quit IRC
782020-03-06T04:29:31 *** jarthur has joined #bitcoin-core-dev
792020-03-06T04:40:56 *** xavier_fabric has joined #bitcoin-core-dev
802020-03-06T04:50:40 *** achow101 has quit IRC
812020-03-06T04:51:37 *** xavier_fabric has quit IRC
822020-03-06T04:51:58 *** mol has joined #bitcoin-core-dev
832020-03-06T04:53:07 *** molly has quit IRC
842020-03-06T04:55:03 *** achow101 has joined #bitcoin-core-dev
852020-03-06T04:56:24 *** baldur has quit IRC
862020-03-06T04:57:22 *** jimmysong_ has joined #bitcoin-core-dev
872020-03-06T04:58:42 *** baldur has joined #bitcoin-core-dev
882020-03-06T04:58:51 *** stevenroose has quit IRC
892020-03-06T04:59:06 *** stevenroose has joined #bitcoin-core-dev
902020-03-06T05:00:34 *** jimmysong has quit IRC
912020-03-06T05:05:18 *** bitcoin-git has joined #bitcoin-core-dev
922020-03-06T05:05:18 <bitcoin-git> [bitcoin] kallewoof opened pull request #18274: wallet: set nFeeRet to 0 to avoid garbage value upon error (master...2003-reset-nfeeret) https://github.com/bitcoin/bitcoin/pull/18274
932020-03-06T05:05:19 *** bitcoin-git has left #bitcoin-core-dev
942020-03-06T05:05:23 *** reardencode has quit IRC
952020-03-06T05:12:54 *** bitcoin-git has joined #bitcoin-core-dev
962020-03-06T05:12:55 <bitcoin-git> [bitcoin] kallewoof opened pull request #18275: wallet: error if an explicit fee rate was given but the needed fee rate differed (master...2003-wallet-error-on-feechange) https://github.com/bitcoin/bitcoin/pull/18275
972020-03-06T05:12:56 *** bitcoin-git has left #bitcoin-core-dev
982020-03-06T05:18:02 *** jarthur has quit IRC
992020-03-06T05:18:52 *** jarthur has joined #bitcoin-core-dev
1002020-03-06T05:38:36 *** francisco______ has quit IRC
1012020-03-06T05:47:22 *** Highway61 has quit IRC
1022020-03-06T05:50:59 *** sdddddd has quit IRC
1032020-03-06T05:57:14 *** reardencode has joined #bitcoin-core-dev
1042020-03-06T06:00:02 *** vinai has quit IRC
1052020-03-06T06:13:05 *** pinheadmz has quit IRC
1062020-03-06T06:21:54 *** PeErLesS has joined #bitcoin-core-dev
1072020-03-06T06:22:19 *** PeErLesS is now known as Guest92974
1082020-03-06T06:41:58 *** bitcoin-git has joined #bitcoin-core-dev
1092020-03-06T06:41:58 <bitcoin-git> [bitcoin] yashpatel20 opened pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
1102020-03-06T06:41:59 *** bitcoin-git has left #bitcoin-core-dev
1112020-03-06T06:45:59 *** bitcoin-git has joined #bitcoin-core-dev
1122020-03-06T06:46:00 <bitcoin-git> [bitcoin] fanquake closed pull request #18276: doc: rpcdoc remove redundant type from description#18258 (master...issue#18258) https://github.com/bitcoin/bitcoin/pull/18276
1132020-03-06T06:46:01 *** bitcoin-git has left #bitcoin-core-dev
1142020-03-06T06:59:14 *** Highway61 has joined #bitcoin-core-dev
1152020-03-06T07:08:22 *** emilengler has joined #bitcoin-core-dev
1162020-03-06T07:12:58 *** sipsorcery has joined #bitcoin-core-dev
1172020-03-06T07:21:42 *** anditto has quit IRC
1182020-03-06T07:28:35 *** anditto has joined #bitcoin-core-dev
1192020-03-06T07:29:59 *** jinping has joined #bitcoin-core-dev
1202020-03-06T07:35:05 *** noeyprincess has joined #bitcoin-core-dev
1212020-03-06T07:36:31 *** jinping has quit IRC
1222020-03-06T07:40:40 *** vasild_ has joined #bitcoin-core-dev
1232020-03-06T07:41:38 *** bitcoin-git has joined #bitcoin-core-dev
1242020-03-06T07:41:39 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f826598a42d...97aadf98d0b8
1252020-03-06T07:41:39 <bitcoin-git> bitcoin/master fa4620b MarcoFalke: util: Add UnintrruptibleSleep
1262020-03-06T07:41:40 <bitcoin-git> bitcoin/master fa9af06 MarcoFalke: scripted-diff: Replace MilliSleep with UninterruptibleSleep
1272020-03-06T07:41:41 <bitcoin-git> bitcoin/master fae86c3 MarcoFalke: util: Remove unused MilliSleep
1282020-03-06T07:41:42 *** bitcoin-git has left #bitcoin-core-dev
1292020-03-06T07:42:38 *** bitcoin-git has joined #bitcoin-core-dev
1302020-03-06T07:42:38 <bitcoin-git> [bitcoin] fanquake merged pull request #16117: util: Replace boost sleep with std sleep (master...1905-noBoostUtilTime) https://github.com/bitcoin/bitcoin/pull/16117
1312020-03-06T07:42:39 *** bitcoin-git has left #bitcoin-core-dev
1322020-03-06T07:43:43 *** vasild has quit IRC
1332020-03-06T07:43:51 *** vasild_ is now known as vasild
1342020-03-06T07:54:45 *** sipsorcery has quit IRC
1352020-03-06T08:01:13 *** achow101 has quit IRC
1362020-03-06T08:04:31 *** sipsorcery has joined #bitcoin-core-dev
1372020-03-06T08:04:46 *** anditto has quit IRC
1382020-03-06T08:06:32 *** sdddddd has joined #bitcoin-core-dev
1392020-03-06T08:08:14 *** achow101 has joined #bitcoin-core-dev
1402020-03-06T08:14:34 *** filchef has joined #bitcoin-core-dev
1412020-03-06T08:16:30 *** emilengler has quit IRC
1422020-03-06T08:17:17 *** noellar has joined #bitcoin-core-dev
1432020-03-06T08:17:39 *** noellar has left #bitcoin-core-dev
1442020-03-06T08:22:14 *** noeyprincess has quit IRC
1452020-03-06T08:22:58 *** noellar has joined #bitcoin-core-dev
1462020-03-06T08:23:07 *** noellar has left #bitcoin-core-dev
1472020-03-06T08:25:08 *** noeyprincess_ has joined #bitcoin-core-dev
1482020-03-06T08:47:10 *** promag has joined #bitcoin-core-dev
1492020-03-06T08:47:20 *** marcoagner has joined #bitcoin-core-dev
1502020-03-06T08:51:35 *** promag has quit IRC
1512020-03-06T09:00:02 *** Guest92974 has quit IRC
1522020-03-06T09:02:21 *** Aaronvan_ has joined #bitcoin-core-dev
1532020-03-06T09:05:00 *** AaronvanW has quit IRC
1542020-03-06T09:06:43 *** Aaronvan_ has quit IRC
1552020-03-06T09:07:22 *** AaronvanW has joined #bitcoin-core-dev
1562020-03-06T09:12:57 *** Kiminuo has quit IRC
1572020-03-06T09:22:03 *** ericholscher1 has joined #bitcoin-core-dev
1582020-03-06T09:28:49 *** promag has joined #bitcoin-core-dev
1592020-03-06T09:31:01 *** IGHOR has quit IRC
1602020-03-06T09:31:37 *** promag_ has joined #bitcoin-core-dev
1612020-03-06T09:31:37 *** promag has quit IRC
1622020-03-06T09:31:51 *** promag has joined #bitcoin-core-dev
1632020-03-06T09:33:13 *** promag has quit IRC
1642020-03-06T09:35:24 *** timothy has joined #bitcoin-core-dev
1652020-03-06T09:37:19 *** promag_ has quit IRC
1662020-03-06T09:44:56 *** someone235 has joined #bitcoin-core-dev
1672020-03-06T09:52:56 *** promag has joined #bitcoin-core-dev
1682020-03-06T09:58:14 *** IGHOR has joined #bitcoin-core-dev
1692020-03-06T09:59:51 *** tsujp has joined #bitcoin-core-dev
1702020-03-06T10:17:50 *** promag has quit IRC
1712020-03-06T10:22:58 *** justanotheruser has quit IRC
1722020-03-06T10:24:09 *** noeyprincess_ has quit IRC
1732020-03-06T10:27:13 *** promag has joined #bitcoin-core-dev
1742020-03-06T10:27:56 *** noeyprincess has joined #bitcoin-core-dev
1752020-03-06T10:29:04 *** noeyprincess has quit IRC
1762020-03-06T10:33:28 <kallewoof> Is there a good way to kick travis when it's not even appearing as a task for a PR?
1772020-03-06T10:39:29 *** promag has quit IRC
1782020-03-06T10:42:57 *** promag has joined #bitcoin-core-dev
1792020-03-06T10:44:27 *** Stealthy has joined #bitcoin-core-dev
1802020-03-06T10:44:42 *** promag has quit IRC
1812020-03-06T10:49:16 *** promag has joined #bitcoin-core-dev
1822020-03-06T10:50:12 *** promag_ has joined #bitcoin-core-dev
1832020-03-06T10:50:57 <Stealthy> does anyone know of a nodejs library that will allow to me monitor notifications of transactions or is there another notification mechanism?
1842020-03-06T10:53:46 *** promag has quit IRC
1852020-03-06T10:59:19 <provoostenator> kallewoof: open Travis on a different pull request and check for a notification that your account was flagged for "mining bitcoin"
1862020-03-06T10:59:37 <kallewoof> Stealthy: zmq?
1872020-03-06T10:59:52 <kallewoof> provoostenator: i thought i did. will check agai
1882020-03-06T11:00:13 <kallewoof> provoostenator: other PR's trigger travis tho, so doubt that's it
1892020-03-06T11:00:34 <provoostenator> In that case force pushing something might help.
1902020-03-06T11:00:47 <provoostenator> Otherwise you're basically back to rain dances.
1912020-03-06T11:01:31 * kallewoof rain-dances cause he's force pushed for awhile now to no avail
1922020-03-06T11:01:46 <kallewoof> Maybe closing/reopening will do the trick. Sorry for spam in advance.
1932020-03-06T11:02:12 *** bitcoin-git has joined #bitcoin-core-dev
1942020-03-06T11:02:12 <bitcoin-git> [bitcoin] kallewoof closed pull request #16411: BIP-325: Signet support (master...signet) https://github.com/bitcoin/bitcoin/pull/16411
1952020-03-06T11:02:13 *** bitcoin-git has left #bitcoin-core-dev
1962020-03-06T11:02:28 <kallewoof> O... travis appeared now
1972020-03-06T11:02:30 *** bitcoin-git has joined #bitcoin-core-dev
1982020-03-06T11:02:31 <bitcoin-git> [bitcoin] kallewoof reopened pull request #16411: BIP-325: Signet support (master...signet) https://github.com/bitcoin/bitcoin/pull/16411
1992020-03-06T11:02:32 *** bitcoin-git has left #bitcoin-core-dev
2002020-03-06T11:03:54 *** Makayla36Kreiger has joined #bitcoin-core-dev
2012020-03-06T11:05:11 *** rtt-0 has joined #bitcoin-core-dev
2022020-03-06T11:06:30 <provoostenator> Maybe it's happening! https://github.com/isaacs/github/issues/386#issuecomment-586708040
2032020-03-06T11:07:09 <provoostenator> (an end to Github ordering commits by date)
2042020-03-06T11:08:45 *** rtt-0 has quit IRC
2052020-03-06T11:08:47 *** Makayla36Kreiger has quit IRC
2062020-03-06T11:09:08 *** _Francisco_ has joined #bitcoin-core-dev
2072020-03-06T11:17:54 *** promag_ has quit IRC
2082020-03-06T11:18:30 *** promag has joined #bitcoin-core-dev
2092020-03-06T11:22:27 *** noeyprincess has joined #bitcoin-core-dev
2102020-03-06T11:23:37 *** noeyprincess has joined #bitcoin-core-dev
2112020-03-06T11:25:49 <Stealthy> lol what a weird idea but an idea nonetheless, ty @kallewoof
2122020-03-06T11:26:28 *** noeyprincess has joined #bitcoin-core-dev
2132020-03-06T11:26:59 <kallewoof> Stealthy: Not sure what's so weird about it. I use zmq to log txs and block hashes.
2142020-03-06T11:27:44 <Stealthy> why sockets, why not a plethora of (named) pipes, files, anything
2152020-03-06T11:27:58 <Stealthy> shared memory, databases, callbacks?
2162020-03-06T11:28:01 <Stealthy> :P
2172020-03-06T11:28:14 <Stealthy> just hoped for a nice nodejs library that will let me fully interface
2182020-03-06T11:29:13 <Stealthy> ie api.monitorWallet(..., callback)
2192020-03-06T11:29:42 <kallewoof> Stealthy: zmq works reasonably well, but i hear you. I wouldn't be surprised if there was a nodejs lib out there that does what you want, but most of us here are focused on bitcoin core, as the name of the channel implies.
2202020-03-06T11:29:56 <Stealthy> i see
2212020-03-06T11:30:14 *** Victorsueca has joined #bitcoin-core-dev
2222020-03-06T11:31:01 <Stealthy> then perhaps a more down to earth option, for example the wallet daemon/rpc for Monero has a flag that you can use 'tx-notify' which can run a script or a program
2232020-03-06T11:31:47 <Stealthy> maybe dumb question but i literally just started orienting around 'crypto'
2242020-03-06T11:32:27 *** promag has quit IRC
2252020-03-06T11:32:51 *** Victor_sueca has quit IRC
2262020-03-06T11:34:02 *** promag has joined #bitcoin-core-dev
2272020-03-06T11:38:19 *** promag has quit IRC
2282020-03-06T11:39:09 *** promag has joined #bitcoin-core-dev
2292020-03-06T11:43:38 *** promag has quit IRC
2302020-03-06T11:43:48 <Stealthy> reason i asked that before i install anything is because i just wasted 3 days on quirky monero lol
2312020-03-06T11:44:12 <Stealthy> figured i'd opt for a more mature coin and toolchain but i'm new
2322020-03-06T11:44:45 <Stealthy> i should probably figure out how to get things setup and just take it from there
2332020-03-06T11:46:21 *** promag has joined #bitcoin-core-dev
2342020-03-06T11:47:44 <Stealthy> is there like a more general channel
2352020-03-06T11:48:07 *** promag has quit IRC
2362020-03-06T11:50:44 *** pkr has joined #bitcoin-core-dev
2372020-03-06T11:51:45 <Stealthy> are there any 'full service wallets' that will provide an api of sorts?
2382020-03-06T11:52:08 <Stealthy> does bitcoin-qt?
2392020-03-06T11:55:37 *** roconnor has quit IRC
2402020-03-06T11:57:52 <aqua42> Stealthy bitcoind has an rpc
2412020-03-06T11:59:37 <Stealthy> cool
2422020-03-06T11:59:46 <aqua42> you should head over to #bitcoin though (unless you want to improve the rpc :P), this is for bitcoin-core development
2432020-03-06T11:59:59 <Stealthy> ah :P
2442020-03-06T12:00:01 *** ericholscher1 has quit IRC
2452020-03-06T12:00:04 <Stealthy> alright i'll pop in there
2462020-03-06T12:01:53 *** jimmysong_ has quit IRC
2472020-03-06T12:01:55 *** Victorsueca has quit IRC
2482020-03-06T12:02:17 *** jimmysong_ has joined #bitcoin-core-dev
2492020-03-06T12:02:49 *** kristapsk_ has joined #bitcoin-core-dev
2502020-03-06T12:03:02 *** Victorsueca has joined #bitcoin-core-dev
2512020-03-06T12:03:22 *** cataly5m has quit IRC
2522020-03-06T12:03:42 *** cataly5m has joined #bitcoin-core-dev
2532020-03-06T12:04:23 *** nsh has quit IRC
2542020-03-06T12:04:49 *** shigeya has quit IRC
2552020-03-06T12:04:54 *** TheHoliestRoger has quit IRC
2562020-03-06T12:05:03 *** kristapsk has quit IRC
2572020-03-06T12:06:10 *** TheHoliestRoger has joined #bitcoin-core-dev
2582020-03-06T12:06:16 *** dqx has quit IRC
2592020-03-06T12:06:16 *** murr4y has quit IRC
2602020-03-06T12:06:45 *** andytoshi has quit IRC
2612020-03-06T12:06:46 *** GAit has quit IRC
2622020-03-06T12:06:46 *** Eliel has quit IRC
2632020-03-06T12:07:07 *** Eliel has joined #bitcoin-core-dev
2642020-03-06T12:07:07 *** dqx has joined #bitcoin-core-dev
2652020-03-06T12:07:13 *** andytoshi has joined #bitcoin-core-dev
2662020-03-06T12:07:13 *** andytoshi has quit IRC
2672020-03-06T12:07:13 *** andytoshi has joined #bitcoin-core-dev
2682020-03-06T12:08:12 *** Zenton has quit IRC
2692020-03-06T12:08:54 *** shigeya has joined #bitcoin-core-dev
2702020-03-06T12:09:20 *** GAit has joined #bitcoin-core-dev
2712020-03-06T12:10:30 *** murr4y has joined #bitcoin-core-dev
2722020-03-06T12:12:31 *** nsh has joined #bitcoin-core-dev
2732020-03-06T12:14:58 *** kristapsk_ has quit IRC
2742020-03-06T12:15:02 *** francisco______ has joined #bitcoin-core-dev
2752020-03-06T12:16:11 *** kristapsk_ has joined #bitcoin-core-dev
2762020-03-06T12:20:58 *** nighmi has joined #bitcoin-core-dev
2772020-03-06T12:21:17 *** nighmi is now known as Guest67233
2782020-03-06T12:27:15 *** promag has joined #bitcoin-core-dev
2792020-03-06T12:35:48 *** promag_ has joined #bitcoin-core-dev
2802020-03-06T12:38:33 *** Kiminuo has joined #bitcoin-core-dev
2812020-03-06T12:40:35 *** promag_ has quit IRC
2822020-03-06T12:41:23 *** noeyprincess has quit IRC
2832020-03-06T12:45:44 *** promag has quit IRC
2842020-03-06T12:49:08 *** Kiminuo has quit IRC
2852020-03-06T13:03:07 *** promag_ has joined #bitcoin-core-dev
2862020-03-06T13:16:01 *** _Francisco_ has quit IRC
2872020-03-06T13:31:56 <promag_> provoostenator: hi
2882020-03-06T13:32:01 *** promag_ is now known as promag
2892020-03-06T13:32:04 <provoostenator> promag: hi
2902020-03-06T13:32:09 <provoostenator> _
2912020-03-06T13:32:24 <promag> I think should discuss here instead :D
2922020-03-06T13:32:55 *** felixfoertsch has quit IRC
2932020-03-06T13:33:15 <promag> with your PR, a client can fund with a specific utxo and ask it to be locked
2942020-03-06T13:33:20 <provoostenator> Context #18244
2952020-03-06T13:33:21 <gribble> https://github.com/bitcoin/bitcoin/issues/18244 | rpc: have lockUnspents also lock manually selected coins by Sjors · Pull Request #18244 · bitcoin/bitcoin · GitHub
2962020-03-06T13:33:25 <promag> y
2972020-03-06T13:33:47 <promag> but if that utxo was automatically locked elsewhere then you both clients are racing for it
2982020-03-06T13:33:49 <promag> right?
2992020-03-06T13:34:02 <promag> s/you//
3002020-03-06T13:34:15 <provoostenator> Yes
3012020-03-06T13:34:44 <promag> that's why I think that fund should fail if it's already locked
3022020-03-06T13:34:47 <promag> and it's a simple change
3032020-03-06T13:34:53 <promag> and a simple test
3042020-03-06T13:35:43 <provoostenator> Alternative it means the existing behavior is a feature, not a bug.
3052020-03-06T13:36:06 <provoostenator> An undocumented an scary feature :-)
3062020-03-06T13:36:36 <provoostenator> My original plan was to indeed just honor locks.
3072020-03-06T13:36:37 <promag> yeah, it's the same as saying "I don't care about being locked"
3082020-03-06T13:36:40 *** promag_ has joined #bitcoin-core-dev
3092020-03-06T13:36:49 <promag> which is silly to me
3102020-03-06T13:37:03 <provoostenator> But then it'll be a breaking change. Maybe worth it.
3112020-03-06T13:37:31 <promag> if the client is asking to lock the coins then I agree with the breaking change
3122020-03-06T13:37:32 <provoostenator> Breaking change as in: breaking documented behavior, not just undocumented behavior
3132020-03-06T13:37:45 *** felixfoertsch has joined #bitcoin-core-dev
3142020-03-06T13:38:11 <promag> breaking documented behavior? really?
3152020-03-06T13:38:27 <promag> which doc?
3162020-03-06T13:38:56 <provoostenator> https://bitcoincore.org/en/doc/0.19.0/rpc/wallet/lockunspent/
3172020-03-06T13:39:02 <provoostenator> "A locked transaction output will not be chosen by automatic coin selection, when spending bitcoins."
3182020-03-06T13:39:15 *** bitcoin-git has joined #bitcoin-core-dev
3192020-03-06T13:39:16 <bitcoin-git> [bitcoin] konez2k opened pull request #18277: Ban spamnode (master...ban-spamnode) https://github.com/bitcoin/bitcoin/pull/18277
3202020-03-06T13:39:17 *** bitcoin-git has left #bitcoin-core-dev
3212020-03-06T13:39:21 <provoostenator> Which it implies, though it doesn't litteraly say, manual _does_ get chosen.
3222020-03-06T13:39:36 *** bitcoin-git has joined #bitcoin-core-dev
3232020-03-06T13:39:37 <bitcoin-git> [bitcoin] konez2k closed pull request #18277: Ban spamnode (master...ban-spamnode) https://github.com/bitcoin/bitcoin/pull/18277
3242020-03-06T13:39:37 *** bitcoin-git has left #bitcoin-core-dev
3252020-03-06T13:40:00 <provoostenator> So I guess the assumption was that if you use manual coin selection, you've thought through concurrency. That's a bad assumption though.
3262020-03-06T13:40:02 <promag> right
3272020-03-06T13:40:22 <provoostenator> Because our coin selection isn't amazing.
3282020-03-06T13:40:51 *** promag_ has quit IRC
3292020-03-06T13:41:29 <promag> but note that RPC lockunspent already can fail with "Invalid parameter, output already locked"
3302020-03-06T13:41:55 <promag> it's manual locking, so that's why I think your manual funding should behave the same
3312020-03-06T13:42:08 <provoostenator> Ah well, looks like you wrote the original behavior :-) https://github.com/bitcoin/bitcoin/commit/f2d0944eb372838e05c666ce9b3df119d7da5594
3322020-03-06T13:42:10 <promag> if lockunspent option is set
3332020-03-06T13:42:58 <promag> ah surprise! lol didn't rememeber
3342020-03-06T13:43:11 <provoostenator> Merge script was borked, so we can't see which PR it was.
3352020-03-06T13:43:39 <provoostenator> Or maybe just Github is confused
3362020-03-06T13:44:22 <promag> I can find the PR
3372020-03-06T13:44:32 <fanquake> #7518
3382020-03-06T13:44:35 <gribble> https://github.com/bitcoin/bitcoin/issues/7518 | Add multiple options to fundrawtransaction by promag · Pull Request #7518 · bitcoin/bitcoin · GitHub
3392020-03-06T13:44:46 *** jonatack has quit IRC
3402020-03-06T13:44:50 <fanquake> That's it
3412020-03-06T13:44:53 <promag> thanks captain fanquake!
3422020-03-06T13:44:54 <provoostenator> Thanks, always good to read original disucssion. I'll make a change.
3432020-03-06T13:45:18 <promag> provoostenator: well at least that's my opinion.. maybe wait for others to weight in
3442020-03-06T13:45:28 <promag> in any case, nice catch
3452020-03-06T13:46:26 <provoostenator> I keep running into "interesting" behavior while writing tests for #16378
3462020-03-06T13:46:28 <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
3472020-03-06T13:48:49 <promag> provoostenator: only problem is that if you lock utxo1, utxo2 and fail to lock utxo3 then the others must be unlocked
3482020-03-06T13:49:10 <promag> or before locking, just check that all are unlocked
3492020-03-06T13:51:26 <provoostenator> Ooof, atomic locking?
3502020-03-06T13:53:10 <provoostenator> We have a lock on cs_wallet, so I guess checking if all coins are unlocked makes sense.
3512020-03-06T13:55:24 *** timothy has quit IRC
3522020-03-06T13:58:33 *** Guyver2 has joined #bitcoin-core-dev
3532020-03-06T13:58:58 *** timothy has joined #bitcoin-core-dev
3542020-03-06T13:59:06 *** rafalcpp_ has quit IRC
3552020-03-06T14:00:20 *** jonatack has joined #bitcoin-core-dev
3562020-03-06T14:05:09 <promag> provoostenator: y
3572020-03-06T14:05:40 *** jonatack has quit IRC
3582020-03-06T14:07:36 <provoostenator> Mmm, this does create the opposite problem: you can no longer atomically unlock and use a coin. I could add an option for that.
3592020-03-06T14:07:55 <provoostenator> This is how worms leave cans.
3602020-03-06T14:08:05 *** jonatack has joined #bitcoin-core-dev
3612020-03-06T14:11:12 <instagibbs> who actually uses the lockunspent RPC? <_<
3622020-03-06T14:11:49 <instagibbs> I think anyone who *really* cares writes their own coin selection algo, or separates the utxos into different wallets. Maybe I'm projecting on uses
3632020-03-06T14:13:36 <provoostenator> I would like locks to be persistent, then they're actually quite useful for a individual users too.
3642020-03-06T14:13:42 <promag> well suppose you start with a solution based on locks and then refatocr to custom coin selection
3652020-03-06T14:13:47 <promag> instagibbs: ^
3662020-03-06T14:14:05 <promag> persistent locks -> yeah there's an issue about that
3672020-03-06T14:14:11 <instagibbs> I'm being glib :)
3682020-03-06T14:14:27 <instagibbs> (though mostly serious)
3692020-03-06T14:14:44 <promag> provoostenator: not following your latest use case
3702020-03-06T14:14:56 <promag> "you can no longer atomically unlock and use a coin"
3712020-03-06T14:16:00 <provoostenator> I'm starting to think that use case is undesirable anyway.
3722020-03-06T14:16:15 <promag> the problem with coin locks to me is that you really don't know who is locking. if a client locks a coin and then crashes, that coin is stuck
3732020-03-06T14:16:45 <provoostenator> I guess there's two reason why you'd want a lock with concurrency. One is seperation of funds, which is better handled with seperate wallets.
3742020-03-06T14:17:05 <instagibbs> what's the first use case?
3752020-03-06T14:17:10 <provoostenator> The other is "pending" transactions, where you lock some coins and then unlock them if you no longer need them.
3762020-03-06T14:17:37 <instagibbs> rephrase?
3772020-03-06T14:17:39 <provoostenator> So an unlock_coins options doesn't make sense.
3782020-03-06T14:17:51 <instagibbs> oh "reserving" funds?
3792020-03-06T14:18:12 <promag> instagibbs: yes that's one use case
3802020-03-06T14:18:46 <instagibbs> I've never really heard of that tbh... and strikes me as obscure
3812020-03-06T14:19:23 <provoostenator> For privacy reasons a user may want to lock (toxic) coins. But they might be beter off sending those to a seperate wallet.
3822020-03-06T14:19:46 <promag> so you receive some payment and then you don't want that to be used in your following sends
3832020-03-06T14:19:47 <instagibbs> doesn't prevent dusting(unless you can ban scriptpubkeys wholesale)
3842020-03-06T14:19:51 <provoostenator> Up to recently I didn't even think about the concurrency use case :-)
3852020-03-06T14:20:06 <provoostenator> But that's actually its reason d'etre
3862020-03-06T14:21:10 <provoostenator> promag: well, at least not combined with other coins. But we need a different mechanism for that.
3872020-03-06T14:21:26 <provoostenator> Maybe a "don't mix" flag.
3882020-03-06T14:23:07 <promag> provoostenator: the solution is simple use watchonly until you want to spend
3892020-03-06T14:24:38 <promag> anyway, up until your PR, no coin was allowed to be re-locked
3902020-03-06T14:33:12 *** sipsorcery has quit IRC
3912020-03-06T14:34:56 *** bitcoin-git has joined #bitcoin-core-dev
3922020-03-06T14:34:56 <bitcoin-git> [bitcoin] ryanofsky opened pull request #18278: interfaces: Describe and follow some code conventions (master...pr/ipc-conv) https://github.com/bitcoin/bitcoin/pull/18278
3932020-03-06T14:34:58 *** bitcoin-git has left #bitcoin-core-dev
3942020-03-06T14:35:16 *** bitcoin-git has joined #bitcoin-core-dev
3952020-03-06T14:35:16 <bitcoin-git> [bitcoin] bvbfan opened pull request #18279: Ensure wallet and chain tip are in sync (master...master) https://github.com/bitcoin/bitcoin/pull/18279
3962020-03-06T14:35:17 *** bitcoin-git has left #bitcoin-core-dev
3972020-03-06T14:46:51 *** mol has quit IRC
3982020-03-06T14:54:48 *** justanotheruser has joined #bitcoin-core-dev
3992020-03-06T15:00:02 *** Guest67233 has quit IRC
4002020-03-06T15:05:10 *** jarthur has quit IRC
4012020-03-06T15:08:36 *** puchu has joined #bitcoin-core-dev
4022020-03-06T15:09:22 *** bitcoin-git has joined #bitcoin-core-dev
4032020-03-06T15:09:22 <bitcoin-git> [bitcoin] promag opened pull request #18280: fix: Disconnect validation interface on the queue dispacher (master...2020-03-sync-unregistervalidationinterface) https://github.com/bitcoin/bitcoin/pull/18280
4042020-03-06T15:09:33 *** bitcoin-git has left #bitcoin-core-dev
4052020-03-06T15:09:38 <puchu> hi
4062020-03-06T15:09:53 <puchu> hi ryanofsky, luke-jr told me you are working on the gui hangs?
4072020-03-06T15:10:24 <puchu> is there somewhere a doc about the problems? and which parts need separate thread and not run in the gui thread?
4082020-03-06T15:11:44 <provoostenator> promag: done
4092020-03-06T15:12:10 <promag> I've changed my mind :D
4102020-03-06T15:13:16 <provoostenator> It's locked in
4112020-03-06T15:17:27 <promag> :D
4122020-03-06T15:18:21 *** jarthur has joined #bitcoin-core-dev
4132020-03-06T15:22:19 *** chmac has joined #bitcoin-core-dev
4142020-03-06T15:27:49 *** jarthur_ has joined #bitcoin-core-dev
4152020-03-06T15:31:12 *** jarthur_ has quit IRC
4162020-03-06T15:31:58 *** jarthur_ has joined #bitcoin-core-dev
4172020-03-06T15:32:22 *** mdunnio has joined #bitcoin-core-dev
4182020-03-06T15:33:05 *** jarthur_ has quit IRC
4192020-03-06T15:38:56 *** mol has joined #bitcoin-core-dev
4202020-03-06T15:42:42 *** Zenton has joined #bitcoin-core-dev
4212020-03-06T15:57:51 *** sipsorcery has joined #bitcoin-core-dev
4222020-03-06T16:07:06 *** promag_ has joined #bitcoin-core-dev
4232020-03-06T16:11:42 *** promag_ has quit IRC
4242020-03-06T16:14:20 *** bitcoin-git has joined #bitcoin-core-dev
4252020-03-06T16:14:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18282: util: Use std::chrono for time getters (master...2003-timeChrono) https://github.com/bitcoin/bitcoin/pull/18282
4262020-03-06T16:14:21 *** bitcoin-git has left #bitcoin-core-dev
4272020-03-06T16:25:24 *** promag has quit IRC
4282020-03-06T16:28:30 *** EagleTM has joined #bitcoin-core-dev
4292020-03-06T16:40:54 *** Talkless has joined #bitcoin-core-dev
4302020-03-06T16:42:56 *** puchu has quit IRC
4312020-03-06T16:47:31 *** Victorsueca has quit IRC
4322020-03-06T16:49:03 *** Victorsueca has joined #bitcoin-core-dev
4332020-03-06T16:51:56 *** Chris_Stewart_5 has quit IRC
4342020-03-06T16:52:01 *** jonatack has quit IRC
4352020-03-06T16:54:28 *** jonatack has joined #bitcoin-core-dev
4362020-03-06T17:00:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4372020-03-06T17:00:25 *** bitcoin-git has joined #bitcoin-core-dev
4382020-03-06T17:00:25 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18282: util: Use std::chrono for time getters (master...2003-timeChrono) https://github.com/bitcoin/bitcoin/pull/18282
4392020-03-06T17:00:29 *** bitcoin-git has left #bitcoin-core-dev
4402020-03-06T17:09:16 *** kljasdfvv has quit IRC
4412020-03-06T17:19:58 *** Guyver2_ has joined #bitcoin-core-dev
4422020-03-06T17:22:35 *** Guyver2 has quit IRC
4432020-03-06T17:22:37 *** EagleTM has quit IRC
4442020-03-06T17:28:53 *** bitcoin-git has joined #bitcoin-core-dev
4452020-03-06T17:28:53 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18283: doc: Explain rebase policy in CONTRIBUTING.md (master...2003-docRebase) https://github.com/bitcoin/bitcoin/pull/18283
4462020-03-06T17:28:54 *** bitcoin-git has left #bitcoin-core-dev
4472020-03-06T17:30:03 *** sipa has quit IRC
4482020-03-06T17:30:04 *** jb55 has quit IRC
4492020-03-06T17:32:17 *** jb55 has joined #bitcoin-core-dev
4502020-03-06T17:37:13 *** sipa has joined #bitcoin-core-dev
4512020-03-06T17:52:35 *** zavan has joined #bitcoin-core-dev
4522020-03-06T18:00:01 *** chmac has quit IRC
4532020-03-06T18:12:30 *** Guyver2__ has joined #bitcoin-core-dev
4542020-03-06T18:14:52 *** Guyver2_ has quit IRC
4552020-03-06T18:16:12 *** jtimon has joined #bitcoin-core-dev
4562020-03-06T18:20:49 *** VitamineD has joined #bitcoin-core-dev
4572020-03-06T18:26:01 *** promag has joined #bitcoin-core-dev
4582020-03-06T18:30:03 *** promag has quit IRC
4592020-03-06T18:40:29 *** mdunnio has quit IRC
4602020-03-06T18:47:11 *** mdunnio has joined #bitcoin-core-dev
4612020-03-06T18:47:37 *** marcoagn1 has joined #bitcoin-core-dev
4622020-03-06T18:50:27 *** marcoagner has quit IRC
4632020-03-06T19:13:55 *** promag has joined #bitcoin-core-dev
4642020-03-06T19:18:34 *** promag has quit IRC
4652020-03-06T19:24:15 *** felixfoertsch23 has joined #bitcoin-core-dev
4662020-03-06T19:24:56 *** felixfoertsch has quit IRC
4672020-03-06T19:32:31 *** bitcoin-git has joined #bitcoin-core-dev
4682020-03-06T19:32:31 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/97aadf98d0b8...45cdcd47d99e
4692020-03-06T19:32:31 <bitcoin-git> bitcoin/master 259e290 practicalswift: tests: Add fuzzing harness for locale independence testing
4702020-03-06T19:32:31 <bitcoin-git> bitcoin/master 45cdcd4 MarcoFalke: Merge #18126: tests: Add fuzzing harness testing the locale independence o...
4712020-03-06T19:32:32 *** bitcoin-git has left #bitcoin-core-dev
4722020-03-06T19:32:51 *** bitcoin-git has joined #bitcoin-core-dev
4732020-03-06T19:32:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18126: tests: Add fuzzing harness testing the locale independence of the strencodings.h functions (master...fuzzers-locale) https://github.com/bitcoin/bitcoin/pull/18126
4742020-03-06T19:32:52 *** bitcoin-git has left #bitcoin-core-dev
4752020-03-06T19:34:40 *** promag has joined #bitcoin-core-dev
4762020-03-06T19:39:19 *** promag has quit IRC
4772020-03-06T19:40:37 *** vasild_ has joined #bitcoin-core-dev
4782020-03-06T19:42:11 *** bitcoin-git has joined #bitcoin-core-dev
4792020-03-06T19:42:11 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #18120: Change UpdateForDescendants to use Epochs (master...epoch-mempool-clean-split-updatefordescendants-pt1) https://github.com/bitcoin/bitcoin/pull/18120
4802020-03-06T19:42:12 *** bitcoin-git has left #bitcoin-core-dev
4812020-03-06T19:43:43 *** vasild has quit IRC
4822020-03-06T19:47:27 *** captjakk has joined #bitcoin-core-dev
4832020-03-06T19:51:18 *** bitcoin-git has joined #bitcoin-core-dev
4842020-03-06T19:51:18 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #18063: Improve UpdateForDescendants by using Epochs and Removing CacheMap (master...epoch-mempool-clean-split-2) https://github.com/bitcoin/bitcoin/pull/18063
4852020-03-06T19:51:19 *** bitcoin-git has left #bitcoin-core-dev
4862020-03-06T19:51:36 *** captjakk has quit IRC
4872020-03-06T19:53:09 *** bitcoin-git has joined #bitcoin-core-dev
4882020-03-06T19:53:10 <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/45cdcd47d99e...3516a31eaa77
4892020-03-06T19:53:11 <bitcoin-git> bitcoin/master 306f71b Anthony Towns: scheduler: don't rely on boost interrupt on shutdown
4902020-03-06T19:53:12 <bitcoin-git> bitcoin/master b9c4260 Anthony Towns: sync.h: add REVERSE_LOCK
4912020-03-06T19:53:12 <bitcoin-git> bitcoin/master d0ebd93 Anthony Towns: scheduler: switch from boost to std
4922020-03-06T19:53:14 *** bitcoin-git has left #bitcoin-core-dev
4932020-03-06T19:53:31 *** bitcoin-git has joined #bitcoin-core-dev
4942020-03-06T19:53:31 <bitcoin-git> [bitcoin] laanwj merged pull request #18234: refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler (master...202002-scheduler-deboost) https://github.com/bitcoin/bitcoin/pull/18234
4952020-03-06T19:53:32 *** bitcoin-git has left #bitcoin-core-dev
4962020-03-06T19:55:07 <jeremyrubin> bitcoin 2020 is postponed to Q3
4972020-03-06T19:55:28 <jeremyrubin> We could coordinate having a coredev.tech then?
4982020-03-06T20:00:09 *** captjakk has joined #bitcoin-core-dev
4992020-03-06T20:05:21 <luke-jr> MarcoFalke: where is mockscheduler disabled?
5002020-03-06T20:05:39 <MarcoFalke> luke-jr: Nevermind. It is only in master
5012020-03-06T20:05:54 <MarcoFalke> But 18234 was merged already
5022020-03-06T20:06:05 <luke-jr> right, so this is backport-only now, at most
5032020-03-06T20:06:28 *** bitcoin-git has joined #bitcoin-core-dev
5042020-03-06T20:06:28 <bitcoin-git> [bitcoin] luke-jr closed pull request #18271: scheduler: Workaround negative nsecs bug in boost's wait_until (master...wrkarnd_boost_wait_until) https://github.com/bitcoin/bitcoin/pull/18271
5052020-03-06T20:06:29 *** bitcoin-git has left #bitcoin-core-dev
5062020-03-06T20:07:27 *** ddustin has quit IRC
5072020-03-06T20:08:17 *** ddustin has joined #bitcoin-core-dev
5082020-03-06T20:10:21 *** bitcoin-git has joined #bitcoin-core-dev
5092020-03-06T20:10:22 <bitcoin-git> [bitcoin] luke-jr opened pull request #18284: [0.19] scheduler: Workaround negative nsecs bug in boost's wait_until (0.19...wrkarnd_boost_wait_until) https://github.com/bitcoin/bitcoin/pull/18284
5102020-03-06T20:10:23 *** bitcoin-git has left #bitcoin-core-dev
5112020-03-06T20:10:29 *** vasild_ is now known as vasild
5122020-03-06T20:16:09 *** promag has joined #bitcoin-core-dev
5132020-03-06T20:20:27 *** promag has quit IRC
5142020-03-06T20:21:54 *** ddustin has quit IRC
5152020-03-06T20:36:54 *** promag has joined #bitcoin-core-dev
5162020-03-06T20:41:25 *** promag has quit IRC
5172020-03-06T20:57:42 *** promag has joined #bitcoin-core-dev
5182020-03-06T20:59:19 *** justanotheruser has quit IRC
5192020-03-06T21:00:02 *** VitamineD has quit IRC
5202020-03-06T21:02:13 *** promag has quit IRC
5212020-03-06T21:05:15 *** wxss_ has quit IRC
5222020-03-06T21:05:29 *** filchef has quit IRC
5232020-03-06T21:05:32 *** wxss has joined #bitcoin-core-dev
5242020-03-06T21:05:52 *** filchef has joined #bitcoin-core-dev
5252020-03-06T21:10:55 *** bitcoin-git has joined #bitcoin-core-dev
5262020-03-06T21:10:55 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18285: test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18285
5272020-03-06T21:10:57 *** bitcoin-git has left #bitcoin-core-dev
5282020-03-06T21:11:39 *** pkr has quit IRC
5292020-03-06T21:11:40 *** sturles has quit IRC
5302020-03-06T21:11:40 *** tripleslash has quit IRC
5312020-03-06T21:11:40 *** berndj has quit IRC
5322020-03-06T21:11:40 *** asoltys has quit IRC
5332020-03-06T21:11:40 *** asukan has quit IRC
5342020-03-06T21:11:40 *** qubenix has quit IRC
5352020-03-06T21:11:40 *** grubles has quit IRC
5362020-03-06T21:11:41 *** niska has quit IRC
5372020-03-06T21:11:41 *** hirish_ has quit IRC
5382020-03-06T21:11:41 *** gkrizek has quit IRC
5392020-03-06T21:11:41 *** aqua42 has quit IRC
5402020-03-06T21:11:41 *** gwillen has quit IRC
5412020-03-06T21:11:41 *** a5m0 has quit IRC
5422020-03-06T21:11:41 *** Evel-Knievel has quit IRC
5432020-03-06T21:11:41 *** willcl_ark_ has quit IRC
5442020-03-06T21:11:41 *** tynes_ has quit IRC
5452020-03-06T21:11:42 *** bashco has quit IRC
5462020-03-06T21:11:42 *** ysangkok has quit IRC
5472020-03-06T21:12:40 *** pkr has joined #bitcoin-core-dev
5482020-03-06T21:12:40 *** sturles has joined #bitcoin-core-dev
5492020-03-06T21:12:40 *** tripleslash has joined #bitcoin-core-dev
5502020-03-06T21:12:40 *** asoltys has joined #bitcoin-core-dev
5512020-03-06T21:12:40 *** berndj has joined #bitcoin-core-dev
5522020-03-06T21:12:40 *** asukan has joined #bitcoin-core-dev
5532020-03-06T21:12:40 *** qubenix has joined #bitcoin-core-dev
5542020-03-06T21:12:40 *** grubles has joined #bitcoin-core-dev
5552020-03-06T21:12:40 *** niska has joined #bitcoin-core-dev
5562020-03-06T21:12:40 *** hirish_ has joined #bitcoin-core-dev
5572020-03-06T21:12:40 *** gkrizek has joined #bitcoin-core-dev
5582020-03-06T21:12:40 *** aqua42 has joined #bitcoin-core-dev
5592020-03-06T21:12:40 *** gwillen has joined #bitcoin-core-dev
5602020-03-06T21:12:40 *** a5m0 has joined #bitcoin-core-dev
5612020-03-06T21:12:40 *** Evel-Knievel has joined #bitcoin-core-dev
5622020-03-06T21:12:40 *** willcl_ark_ has joined #bitcoin-core-dev
5632020-03-06T21:12:40 *** tynes_ has joined #bitcoin-core-dev
5642020-03-06T21:12:40 *** bashco has joined #bitcoin-core-dev
5652020-03-06T21:12:40 *** ysangkok has joined #bitcoin-core-dev
5662020-03-06T21:13:38 *** tripleslash has quit IRC
5672020-03-06T21:13:39 *** tynes_ has quit IRC
5682020-03-06T21:13:39 *** niska has quit IRC
5692020-03-06T21:13:55 *** tynes has joined #bitcoin-core-dev
5702020-03-06T21:14:41 *** niska has joined #bitcoin-core-dev
5712020-03-06T21:15:02 *** tripleslash has joined #bitcoin-core-dev
5722020-03-06T21:16:51 *** sturles has quit IRC
5732020-03-06T21:17:20 *** sturles has joined #bitcoin-core-dev
5742020-03-06T21:17:20 *** sturles has joined #bitcoin-core-dev
5752020-03-06T21:17:52 *** jarthur has quit IRC
5762020-03-06T21:18:27 *** promag has joined #bitcoin-core-dev
5772020-03-06T21:22:08 *** stevenm1 has joined #bitcoin-core-dev
5782020-03-06T21:23:04 *** promag has quit IRC
5792020-03-06T21:25:10 *** jimmysong_ has quit IRC
5802020-03-06T21:26:17 *** promag has joined #bitcoin-core-dev
5812020-03-06T21:30:34 *** promag has quit IRC
5822020-03-06T21:39:11 *** promag has joined #bitcoin-core-dev
5832020-03-06T21:43:46 *** promag has quit IRC
5842020-03-06T21:49:19 <Stealthy> how are ListSinceBlock transactions ordered
5852020-03-06T21:49:27 <Stealthy> not chronological for sure
5862020-03-06T21:52:15 *** promag has joined #bitcoin-core-dev
5872020-03-06T21:57:59 *** filchef has quit IRC
5882020-03-06T21:58:40 *** promag has quit IRC
5892020-03-06T22:06:03 *** Guyver2__ has quit IRC
5902020-03-06T22:12:58 *** justanotheruser has joined #bitcoin-core-dev
5912020-03-06T22:19:42 *** puchu has joined #bitcoin-core-dev
5922020-03-06T22:23:10 *** bitcoin-git has joined #bitcoin-core-dev
5932020-03-06T22:23:11 <bitcoin-git> [bitcoin] practicalswift closed pull request #17828: net: Use log categories when logging events that P2P peers can trigger arbitrarily (master...log-categories) https://github.com/bitcoin/bitcoin/pull/17828
5942020-03-06T22:23:12 *** bitcoin-git has left #bitcoin-core-dev
5952020-03-06T22:33:48 <nothingmuch> is there a reccomended approach to creating a json compilation database? bear seems like the simplest approach but it's segfaulting for me and i'm having trouble debugging, and i'm not sure how to convince automake to add -MJ to clang in the right way so that the json files are written separately
5962020-03-06T22:34:23 <fanquake> nothingmuch: try compiledb https://github.com/fanquake/core-review/blob/master/clang-tools.md#generating-a-compilation-database
5972020-03-06T22:34:31 <nothingmuch> thanks!
5982020-03-06T22:36:11 *** promag has joined #bitcoin-core-dev
5992020-03-06T22:40:17 *** promag_ has joined #bitcoin-core-dev
6002020-03-06T22:41:00 *** promag has quit IRC
6012020-03-06T22:47:24 *** captjakk has quit IRC
6022020-03-06T22:47:50 *** captjakk has joined #bitcoin-core-dev
6032020-03-06T22:50:39 *** jonatack has quit IRC
6042020-03-06T22:53:14 *** francisco______ has quit IRC
6052020-03-06T22:54:39 *** jonatack has joined #bitcoin-core-dev
6062020-03-06T22:54:56 *** francisco______ has joined #bitcoin-core-dev
6072020-03-06T22:56:17 <fanquake> So looks like a couple of travis jobs (fuzzing) are going to continually fail until someone adds "locale" seeds to https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus ?
6082020-03-06T22:56:42 *** zavan has quit IRC
6092020-03-06T22:57:04 <fanquake> MarcoFalke: are you are going to do that shortly given you merged #18126 ?
6102020-03-06T22:57:05 <gribble> https://github.com/bitcoin/bitcoin/issues/18126 | tests: Add fuzzing harness testing the locale independence of the strencodings.h functions by practicalswift · Pull Request #18126 · bitcoin/bitcoin · GitHub
6112020-03-06T23:15:36 *** promag_ has quit IRC
6122020-03-06T23:22:31 *** Talkless has quit IRC
6132020-03-06T23:25:23 *** bitcoin-git has joined #bitcoin-core-dev
6142020-03-06T23:25:25 <bitcoin-git> [bitcoin] fanquake pushed 13 commits to master: https://github.com/bitcoin/bitcoin/compare/3516a31eaa77...4d80274b9963
6152020-03-06T23:25:25 <bitcoin-git> bitcoin/master dc2d065 Karl-Johan Alm: make BlockUntilSyncedToCurrentChain() const
6162020-03-06T23:25:26 <bitcoin-git> bitcoin/master ddc9355 Karl-Johan Alm: wallet: make CanGenerateKeys() const
6172020-03-06T23:25:27 <bitcoin-git> bitcoin/master 037fa77 Karl-Johan Alm: wallet: make KeypoolCountExternalKeys() const
6182020-03-06T23:25:29 *** bitcoin-git has left #bitcoin-core-dev
6192020-03-06T23:25:43 *** bitcoin-git has joined #bitcoin-core-dev
6202020-03-06T23:25:43 <bitcoin-git> [bitcoin] fanquake merged pull request #18241: wallet/refactor: refer to CWallet immutably when possible (master...2002-const-fixes) https://github.com/bitcoin/bitcoin/pull/18241
6212020-03-06T23:25:45 *** bitcoin-git has left #bitcoin-core-dev
6222020-03-06T23:26:42 *** justanotheruser has quit IRC
6232020-03-06T23:30:43 *** mdunnio has quit IRC
6242020-03-06T23:32:58 *** bitcoin-git has joined #bitcoin-core-dev
6252020-03-06T23:32:58 <bitcoin-git> [bitcoin] practicalswift opened pull request #18286: build: Add locale fuzzer to FUZZERS_MISSING_CORPORA (and unbreak Travis! :)) (master...unbreak-travis-sorry) https://github.com/bitcoin/bitcoin/pull/18286
6262020-03-06T23:32:59 *** bitcoin-git has left #bitcoin-core-dev
6272020-03-06T23:47:05 *** promag has joined #bitcoin-core-dev
6282020-03-06T23:49:07 *** timothy has quit IRC
6292020-03-06T23:51:15 *** promag has quit IRC
6302020-03-06T23:52:32 *** belcher has joined #bitcoin-core-dev