12020-03-17T00:00:02  *** hwangjy9 has quit IRC
  22020-03-17T00:03:39  *** emilengler has quit IRC
  32020-03-17T00:13:45  *** Deacydal is now known as deacyde
  42020-03-17T00:22:19  *** zeromus1 has joined #bitcoin-core-dev
  52020-03-17T00:31:37  *** diogorsergio has quit IRC
  62020-03-17T00:34:30  <achow101> sipa: hardware wallets can't do the generic way of signing
  72020-03-17T00:34:45  *** tryphe_ is now known as tryphe
  82020-03-17T00:35:03  *** AaronvanW has joined #bitcoin-core-dev
  92020-03-17T00:35:22  <achow101> Our generic way of signing was to get a SigningProvider and pass that to ProduceSignature. but you can't get a SigningProvider with private keys for a hardware wallet
 102020-03-17T00:36:18  <sipa> achow101: hmm, you imagine having a SPKM for hardware wallets?
 112020-03-17T00:36:39  <achow101> yes
 122020-03-17T00:36:54  <achow101> I imagine it would be a subclass of DescriptorScriptPubKeyMan
 132020-03-17T00:37:07  <sipa> hmm, i had never imagined it that way
 142020-03-17T00:37:17  <sipa> it may make sense
 152020-03-17T00:38:14  <achow101> what were you thinking it would be?
 162020-03-17T00:39:33  <sipa> a descriptorscriptpubkeyman that simply had no private keys, and maybe a meta data field saying "use hardware device X", so the UI could suggest the user try PSBT interface/etc
 172020-03-17T00:40:03  <sipa> i wasn't expecting dealing with hardware wallets so deep down in the stack
 182020-03-17T00:43:37  *** marcoagner has quit IRC
 192020-03-17T00:45:09  <sipa> i guess if you want to transparently support hardware wallets, without having the user jump through hoops exporting/importing PSBTs, etc, or specialized UIs for it, this is how you'd do it
 202020-03-17T00:45:44  <achow101> my end goal for hardware wallets is to have the seamless experience where it calls out to the device automatically on send
 212020-03-17T00:45:53  <achow101> so this seemed to be the easiest way to do that
 222020-03-17T00:46:16  <achow101> instead of sprinkling around a bunch of hardware wallet things everywhere we had signing code
 232020-03-17T00:46:16  <sipa> still it feels awkward that SPKMs (which really ought to just deal with keys and scripts) need to be aware of transactions and messages
 242020-03-17T00:48:50  <achow101> i guess
 252020-03-17T00:54:33  <sipa> it also means things like signet (block signing) and generic message signing need to add their own methods to every SPKM implementation?
 262020-03-17T01:08:21  *** AaronvanW has quit IRC
 272020-03-17T01:23:23  <ysangkok> achow101: forgive me if it is a stupid question, but if SignTransaction needs to block and wait for a HW wallet, won't it need to be more complicated than just a function call (because of asynchrony)? i guess it would block for e.g. 1 minute while the user interacts with the HW wallet. is that how it will be?
 282020-03-17T01:31:56  <achow101> sipa: we can have a default implementation that calls a protected GetSigningProvider and then does the signing thing generically. then if the specific SPKM can't do that, they can override it and implement it differently
 292020-03-17T01:32:49  <achow101> ysangkok: it only blocks the thread for that part of the ui (or specific RPC). IIRC we already have async dialogs so it shouldn't be a problem
 302020-03-17T01:32:55  <achow101> but I haven't thought about that too much yet
 312020-03-17T01:42:55  *** diogorsergio has joined #bitcoin-core-dev
 322020-03-17T01:44:04  <sipa> achow101: right
 332020-03-17T01:44:34  <sipa> achow101: SignTransaction can probably be written as a wrapper around PSBT operations, actually
 342020-03-17T01:45:00  <achow101> it'd be nice if the wallet moved entirely to psbt operations
 352020-03-17T01:45:23  <sipa> so maybe it suffices if SPKMs (or even some.other class) can just provide "here is another method you can try to uodate a PSBT"
 362020-03-17T01:46:58  <sipa> maybe related: why does the SigningProvider returned not give access to private keys?
 372020-03-17T01:49:02  <achow101> that SigningProvider is specifically just for the solving date (hence the function name GetSolvingProvider)
 382020-03-17T01:49:04  <midnight> btw, psbt has made offline signing *incredibly much easier*. Seriously, thank you.
 392020-03-17T01:49:50  <achow101> so the no private keys thing is to be explicit about it not actually being useful for signing
 402020-03-17T01:50:14  <sipa> i see
 412020-03-17T01:51:12  <achow101> there was a suggestion of moving the public parts of SigningProvider to a parent SolvingProvider
 422020-03-17T01:51:17  <achow101> to make that clearer
 432020-03-17T01:52:29  <sipa> that may make sense
 442020-03-17T01:52:45  <sipa> but there should be a way to get access to private keys too, no?
 452020-03-17T01:53:00  <sipa> or is that only possible through the SignTransacrion and SignMessage functions?
 462020-03-17T01:53:22  <achow101> i'm not sure that it useful to have the privkeys given SignTransaction and SignMessage
 472020-03-17T01:54:00  <sipa> well i hope that at some point we don't need tx specific logic in SPKMs
 482020-03-17T01:56:23  <sipa> but i see why that's the case now
 492020-03-17T01:56:25  <sipa> thanks
 502020-03-17T02:02:23  *** Highway61 has quit IRC
 512020-03-17T02:09:20  *** captjakk_ has quit IRC
 522020-03-17T02:09:28  *** shibshop has left #bitcoin-core-dev
 532020-03-17T02:29:05  *** bitcoin-git has joined #bitcoin-core-dev
 542020-03-17T02:29:06  <bitcoin-git> [bitcoin] practicalswift opened pull request #18363: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions (master...fuzzers-http_request) https://github.com/bitcoin/bitcoin/pull/18363
 552020-03-17T02:29:06  *** bitcoin-git has left #bitcoin-core-dev
 562020-03-17T02:32:15  *** DeanWeen is now known as DeanGuss
 572020-03-17T03:00:01  *** zeromus1 has quit IRC
 582020-03-17T03:01:09  *** hadjiszs has joined #bitcoin-core-dev
 592020-03-17T03:05:43  *** AaronvanW has joined #bitcoin-core-dev
 602020-03-17T03:12:06  *** ddustin has joined #bitcoin-core-dev
 612020-03-17T03:13:21  *** ddustin has joined #bitcoin-core-dev
 622020-03-17T03:14:41  *** ddustin has joined #bitcoin-core-dev
 632020-03-17T03:15:10  *** ddustin has quit IRC
 642020-03-17T03:21:46  *** geekosaur has joined #bitcoin-core-dev
 652020-03-17T03:21:48  *** geekosaur is now known as Guest11588
 662020-03-17T03:37:39  *** felixfoertsch has joined #bitcoin-core-dev
 672020-03-17T03:37:43  *** felixfoertsch23 has quit IRC
 682020-03-17T03:39:13  *** AaronvanW has quit IRC
 692020-03-17T03:48:09  *** jorijn_ has joined #bitcoin-core-dev
 702020-03-17T03:48:50  *** jorijn has quit IRC
 712020-03-17T04:54:23  *** jb55 has quit IRC
 722020-03-17T04:59:21  *** ghost43 has quit IRC
 732020-03-17T05:31:43  *** kristapsk has quit IRC
 742020-03-17T05:36:17  *** AaronvanW has joined #bitcoin-core-dev
 752020-03-17T05:47:49  *** sipa has quit IRC
 762020-03-17T05:53:04  *** sipa has joined #bitcoin-core-dev
 772020-03-17T06:00:02  *** Guest11588 has quit IRC
 782020-03-17T06:09:13  *** AaronvanW has quit IRC
 792020-03-17T06:19:46  *** chrippa has joined #bitcoin-core-dev
 802020-03-17T06:23:51  *** chrippa has quit IRC
 812020-03-17T06:49:01  *** goatpig has quit IRC
 822020-03-17T06:55:17  *** meshcollider has quit IRC
 832020-03-17T06:55:37  *** maurits has joined #bitcoin-core-dev
 842020-03-17T07:15:46  *** justanotheruser has quit IRC
 852020-03-17T07:29:57  *** kristapsk has joined #bitcoin-core-dev
 862020-03-17T07:40:50  *** vasild_ has joined #bitcoin-core-dev
 872020-03-17T07:44:23  *** vasild has quit IRC
 882020-03-17T07:44:24  *** vasild_ is now known as vasild
 892020-03-17T07:44:41  *** bitcoin-git has joined #bitcoin-core-dev
 902020-03-17T07:44:41  <bitcoin-git> [bitcoin] fanquake opened pull request #18364: random: remove getentropy() fallback for macOS < 10.12 (master...macos_remove_1012_fallback) https://github.com/bitcoin/bitcoin/pull/18364
 912020-03-17T07:44:42  *** bitcoin-git has left #bitcoin-core-dev
 922020-03-17T07:45:49  *** justanotheruser has joined #bitcoin-core-dev
 932020-03-17T08:03:09  *** justanotheruser has quit IRC
 942020-03-17T08:06:03  *** AaronvanW has joined #bitcoin-core-dev
 952020-03-17T08:13:53  *** meshcollider has joined #bitcoin-core-dev
 962020-03-17T08:28:29  <vasild> fanquake: I find it strange that we used to test whether the getentropy() function is present with "if (&getentropy != nullptr)".
 972020-03-17T08:30:39  <vasild> Would it even compile if getentropy() is missing? Maybe old macos versions define the symbol but set it to nullptr!?
 982020-03-17T08:38:27  *** AaronvanW has quit IRC
 992020-03-17T08:40:22  <fanquake> vaslid: From my understanding it would compile, but crash at runtime on a version of macOS, because of the way new SDK symbols are handled. There's some more discussion in #15103
1002020-03-17T08:40:24  <gribble> https://github.com/bitcoin/bitcoin/issues/15103 | fix getentropy import check on osx by jameshilliard · Pull Request #15103 · bitcoin/bitcoin · GitHub
1012020-03-17T08:40:51  <fanquake> opps *vasild
1022020-03-17T08:42:04  *** Guyver2 has joined #bitcoin-core-dev
1032020-03-17T08:43:18  <vasild> good that it is going to be deleted now :)
1042020-03-17T09:00:02  *** maurits has quit IRC
1052020-03-17T09:09:36  *** someone235 has joined #bitcoin-core-dev
1062020-03-17T09:22:01  *** OldMiner has joined #bitcoin-core-dev
1072020-03-17T09:26:23  *** AaronvanW has joined #bitcoin-core-dev
1082020-03-17T09:37:37  *** marcoagner has joined #bitcoin-core-dev
1092020-03-17T09:47:57  *** Highway61 has joined #bitcoin-core-dev
1102020-03-17T10:15:46  *** kinlo has quit IRC
1112020-03-17T10:19:06  *** votesmith has quit IRC
1122020-03-17T10:20:43  *** kinlo has joined #bitcoin-core-dev
1132020-03-17T10:24:49  *** votesmith has joined #bitcoin-core-dev
1142020-03-17T10:26:18  *** gleec has joined #bitcoin-core-dev
1152020-03-17T10:32:34  *** oguzkoroglu has joined #bitcoin-core-dev
1162020-03-17T10:34:33  *** timothy has joined #bitcoin-core-dev
1172020-03-17T10:44:21  *** votesmith has quit IRC
1182020-03-17T10:53:23  *** votesmith has joined #bitcoin-core-dev
1192020-03-17T11:02:20  *** votesmith has quit IRC
1202020-03-17T11:03:57  *** Mathias63Hudson has joined #bitcoin-core-dev
1212020-03-17T11:04:44  *** manantial has joined #bitcoin-core-dev
1222020-03-17T11:23:33  *** votesmith has joined #bitcoin-core-dev
1232020-03-17T11:25:24  *** Mathias63Hudson has quit IRC
1242020-03-17T11:35:17  *** votesmith has quit IRC
1252020-03-17T11:38:10  *** emilengler has joined #bitcoin-core-dev
1262020-03-17T11:39:48  *** meshcollider has quit IRC
1272020-03-17T11:52:35  *** votesmith has joined #bitcoin-core-dev
1282020-03-17T12:00:02  *** OldMiner has quit IRC
1292020-03-17T12:04:31  *** ghost43 has joined #bitcoin-core-dev
1302020-03-17T12:16:13  *** meshcollider has joined #bitcoin-core-dev
1312020-03-17T12:22:30  *** SirVerII has joined #bitcoin-core-dev
1322020-03-17T12:30:23  *** kristapsk has quit IRC
1332020-03-17T12:30:44  *** vasild has quit IRC
1342020-03-17T12:30:44  *** sipa has quit IRC
1352020-03-17T12:30:44  *** sdaftuar has quit IRC
1362020-03-17T12:30:44  *** braydonf has quit IRC
1372020-03-17T12:31:03  *** ghost43 has quit IRC
1382020-03-17T12:31:04  *** DeanGuss has quit IRC
1392020-03-17T12:31:04  *** afk11 has quit IRC
1402020-03-17T12:31:23  *** SiAnDoG__ has quit IRC
1412020-03-17T12:31:37  *** mryandao has quit IRC
1422020-03-17T12:32:51  *** sipa has joined #bitcoin-core-dev
1432020-03-17T12:33:10  *** braydonf has joined #bitcoin-core-dev
1442020-03-17T12:33:28  *** ghost43 has joined #bitcoin-core-dev
1452020-03-17T12:34:27  *** mryandao has joined #bitcoin-core-dev
1462020-03-17T12:36:50  *** vasild has joined #bitcoin-core-dev
1472020-03-17T12:37:54  *** afk11 has joined #bitcoin-core-dev
1482020-03-17T12:37:54  *** sdaftuar has joined #bitcoin-core-dev
1492020-03-17T13:05:29  *** ghost43 has quit IRC
1502020-03-17T13:06:20  *** ghost43 has joined #bitcoin-core-dev
1512020-03-17T13:10:23  *** afk11 has quit IRC
1522020-03-17T13:12:38  *** afk11 has joined #bitcoin-core-dev
1532020-03-17T13:15:47  *** SiAnDoG__ has joined #bitcoin-core-dev
1542020-03-17T13:22:37  *** michagogo has quit IRC
1552020-03-17T13:24:15  *** jonatack has quit IRC
1562020-03-17T13:26:00  *** jonatack has joined #bitcoin-core-dev
1572020-03-17T13:27:13  *** belcher has joined #bitcoin-core-dev
1582020-03-17T13:40:56  *** mdunnio has joined #bitcoin-core-dev
1592020-03-17T13:46:55  *** bitcoin-git has joined #bitcoin-core-dev
1602020-03-17T13:46:56  <bitcoin-git> [bitcoin] jnewbery opened pull request #18366: tests: simplify next_block() function in feature_block (master...2020-03-feature-block-next-block) https://github.com/bitcoin/bitcoin/pull/18366
1612020-03-17T13:46:56  *** bitcoin-git has left #bitcoin-core-dev
1622020-03-17T13:47:03  *** Guyver2 has quit IRC
1632020-03-17T14:02:43  *** justanotheruser has joined #bitcoin-core-dev
1642020-03-17T14:03:34  *** lnostdal has quit IRC
1652020-03-17T14:10:49  *** AaronvanW has quit IRC
1662020-03-17T14:20:20  *** ghost43 has quit IRC
1672020-03-17T14:21:35  *** ghost43 has joined #bitcoin-core-dev
1682020-03-17T14:25:28  *** Guyver2 has joined #bitcoin-core-dev
1692020-03-17T14:25:41  *** bitcoin-git has joined #bitcoin-core-dev
1702020-03-17T14:25:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7060d2d97a28...8fc5f2bdf01d
1712020-03-17T14:25:42  <bitcoin-git> bitcoin/master 612a931 John Newbery: tests: simplify next_block() function in feature_block
1722020-03-17T14:25:43  <bitcoin-git> bitcoin/master 8fc5f2b MarcoFalke: Merge #18366: tests: simplify next_block() function in feature_block
1732020-03-17T14:25:45  *** bitcoin-git has left #bitcoin-core-dev
1742020-03-17T14:26:01  *** bitcoin-git has joined #bitcoin-core-dev
1752020-03-17T14:26:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18366: tests: simplify next_block() function in feature_block (master...2020-03-feature-block-next-block) https://github.com/bitcoin/bitcoin/pull/18366
1762020-03-17T14:26:02  *** bitcoin-git has left #bitcoin-core-dev
1772020-03-17T14:31:47  *** AaronvanW has joined #bitcoin-core-dev
1782020-03-17T14:37:18  *** jorijn_ has quit IRC
1792020-03-17T14:37:38  *** jorijn has joined #bitcoin-core-dev
1802020-03-17T14:38:47  *** manantial has quit IRC
1812020-03-17T14:40:21  *** tsujp has joined #bitcoin-core-dev
1822020-03-17T14:40:23  *** manantial has joined #bitcoin-core-dev
1832020-03-17T14:58:49  *** jorijn has quit IRC
1842020-03-17T14:59:27  *** jorijn has joined #bitcoin-core-dev
1852020-03-17T15:00:01  *** SirVerII has quit IRC
1862020-03-17T15:07:26  *** manantial has quit IRC
1872020-03-17T15:10:39  *** manantial has joined #bitcoin-core-dev
1882020-03-17T15:18:05  *** ghost43 has quit IRC
1892020-03-17T15:19:29  *** ghost43 has joined #bitcoin-core-dev
1902020-03-17T15:21:31  *** r2wj has joined #bitcoin-core-dev
1912020-03-17T15:30:42  *** justanotheruser has quit IRC
1922020-03-17T15:30:56  *** tsujp has quit IRC
1932020-03-17T15:31:23  *** jonatack has quit IRC
1942020-03-17T15:37:11  *** jonatack has joined #bitcoin-core-dev
1952020-03-17T15:39:24  *** TheRec has quit IRC
1962020-03-17T15:48:21  *** justanotheruser has joined #bitcoin-core-dev
1972020-03-17T15:56:06  *** kristapsk has joined #bitcoin-core-dev
1982020-03-17T16:03:56  *** bitcoin-git has joined #bitcoin-core-dev
1992020-03-17T16:03:57  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8fc5f2bdf01d...1d64dfe4fa05
2002020-03-17T16:03:57  <bitcoin-git> bitcoin/master a889711 fanquake: rand: remove getentropy() fallback for macOS < 10.12
2012020-03-17T16:03:58  <bitcoin-git> bitcoin/master f9f210d fanquake: doc: fix GetTimeMicros() comment in random.cpp
2022020-03-17T16:03:58  <bitcoin-git> bitcoin/master 1d64dfe Wladimir J. van der Laan: Merge #18364: random: remove getentropy() fallback for macOS < 10.12
2032020-03-17T16:04:00  *** bitcoin-git has left #bitcoin-core-dev
2042020-03-17T16:04:16  *** bitcoin-git has joined #bitcoin-core-dev
2052020-03-17T16:04:16  <bitcoin-git> [bitcoin] laanwj merged pull request #18364: random: remove getentropy() fallback for macOS < 10.12 (master...macos_remove_1012_fallback) https://github.com/bitcoin/bitcoin/pull/18364
2062020-03-17T16:04:17  *** bitcoin-git has left #bitcoin-core-dev
2072020-03-17T16:05:39  *** ghost43 has quit IRC
2082020-03-17T16:06:46  *** tryphe_ has joined #bitcoin-core-dev
2092020-03-17T16:06:55  *** ghost43 has joined #bitcoin-core-dev
2102020-03-17T16:09:41  *** tryphe has quit IRC
2112020-03-17T16:12:48  *** oguz_ has joined #bitcoin-core-dev
2122020-03-17T16:15:13  *** oguzkoroglu has quit IRC
2132020-03-17T16:26:19  *** Talkless has joined #bitcoin-core-dev
2142020-03-17T16:26:23  *** ghost43 has quit IRC
2152020-03-17T16:27:39  *** ghost43 has joined #bitcoin-core-dev
2162020-03-17T16:30:10  *** captjakk has joined #bitcoin-core-dev
2172020-03-17T16:33:07  *** TheRec has joined #bitcoin-core-dev
2182020-03-17T16:33:07  *** TheRec has joined #bitcoin-core-dev
2192020-03-17T16:38:45  *** Bullit has joined #bitcoin-core-dev
2202020-03-17T16:52:05  *** oguz_ has quit IRC
2212020-03-17T17:03:25  *** jb55 has joined #bitcoin-core-dev
2222020-03-17T17:08:50  *** bitcoin-git has joined #bitcoin-core-dev
2232020-03-17T17:08:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1d64dfe4fa05...d2d0a04a661f
2242020-03-17T17:08:51  <bitcoin-git> bitcoin/master cb4eec1 practicalswift: tests: Add fuzzing harness for count_seconds(...)
2252020-03-17T17:08:51  <bitcoin-git> bitcoin/master 0579a27 practicalswift: tests: Add fuzzing harness for CBlockHeader
2262020-03-17T17:08:51  <bitcoin-git> bitcoin/master 7726f3b practicalswift: tests: Add fuzzing harness for CFeeRate
2272020-03-17T17:08:53  *** bitcoin-git has left #bitcoin-core-dev
2282020-03-17T17:09:10  *** bitcoin-git has joined #bitcoin-core-dev
2292020-03-17T17:09:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18353: tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions (master...fuzzers-coverage) https://github.com/bitcoin/bitcoin/pull/18353
2302020-03-17T17:09:11  *** bitcoin-git has left #bitcoin-core-dev
2312020-03-17T17:23:56  *** ghost43 has quit IRC
2322020-03-17T17:24:57  *** ghost43 has joined #bitcoin-core-dev
2332020-03-17T17:28:58  *** molly has joined #bitcoin-core-dev
2342020-03-17T17:32:01  *** mol has quit IRC
2352020-03-17T17:39:11  *** bitcoin-git has joined #bitcoin-core-dev
2362020-03-17T17:39:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d2d0a04a661f...ad04f0d8a533
2372020-03-17T17:39:12  <bitcoin-git> bitcoin/master f31fc0e John Newbery: [tests] fix flake8 warnings in script.py and bignum.py
2382020-03-17T17:39:12  <bitcoin-git> bitcoin/master 1dc68ae John Newbery: [tests] add function comments to bignum
2392020-03-17T17:39:13  <bitcoin-git> bitcoin/master 9a60bef John Newbery: [tests] don't encode the integer size in bignum
2402020-03-17T17:39:14  *** bitcoin-git has left #bitcoin-core-dev
2412020-03-17T17:39:51  *** bitcoin-git has joined #bitcoin-core-dev
2422020-03-17T17:39:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17319: Tests: remove bignum module (master...2019-10-bignum) https://github.com/bitcoin/bitcoin/pull/17319
2432020-03-17T17:39:52  *** bitcoin-git has left #bitcoin-core-dev
2442020-03-17T18:00:02  *** r2wj has quit IRC
2452020-03-17T18:10:10  *** owowo has quit IRC
2462020-03-17T18:15:02  *** owowo has joined #bitcoin-core-dev
2472020-03-17T18:21:57  *** jchris has joined #bitcoin-core-dev
2482020-03-17T18:28:55  *** bitcoin-git has joined #bitcoin-core-dev
2492020-03-17T18:28:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad04f0d8a533...39497d1f3268
2502020-03-17T18:28:56  <bitcoin-git> bitcoin/master ec30a79 Gregory Sanders: Fix UB with bench on genesis block
2512020-03-17T18:28:57  <bitcoin-git> bitcoin/master 39497d1 MarcoFalke: Merge #15283: log: Fix UB with bench on genesis block
2522020-03-17T18:28:58  *** bitcoin-git has left #bitcoin-core-dev
2532020-03-17T18:30:26  *** bitcoin-git has joined #bitcoin-core-dev
2542020-03-17T18:30:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15283: log: Fix UB with bench on genesis block (master...ub_genesis_bench) https://github.com/bitcoin/bitcoin/pull/15283
2552020-03-17T18:30:27  *** bitcoin-git has left #bitcoin-core-dev
2562020-03-17T18:35:54  *** pinheadmz has quit IRC
2572020-03-17T18:46:16  *** face has quit IRC
2582020-03-17T18:51:20  *** DeanGuss has joined #bitcoin-core-dev
2592020-03-17T18:52:48  *** timothy has quit IRC
2602020-03-17T18:53:36  *** gleec has quit IRC
2612020-03-17T18:53:58  *** pinheadmz has joined #bitcoin-core-dev
2622020-03-17T18:56:30  *** ghost43 has quit IRC
2632020-03-17T18:57:24  *** ghost43 has joined #bitcoin-core-dev
2642020-03-17T19:03:59  *** pinheadmz has quit IRC
2652020-03-17T19:11:20  *** afk11` has joined #bitcoin-core-dev
2662020-03-17T19:11:41  *** nanotube has quit IRC
2672020-03-17T19:12:23  *** afk11 has quit IRC
2682020-03-17T19:13:54  *** ghost43 has quit IRC
2692020-03-17T19:14:19  *** nanotube has joined #bitcoin-core-dev
2702020-03-17T19:14:44  *** ghost43 has joined #bitcoin-core-dev
2712020-03-17T19:16:32  *** Talkless has quit IRC
2722020-03-17T19:24:58  *** pinheadmz has joined #bitcoin-core-dev
2732020-03-17T19:27:40  *** bitcoin-git has joined #bitcoin-core-dev
2742020-03-17T19:27:40  <bitcoin-git> [bitcoin] sipa opened pull request #18367: Avoid strncopy for CMessageHeader::pchCommand (master...202003_strncopy_warning) https://github.com/bitcoin/bitcoin/pull/18367
2752020-03-17T19:27:41  *** bitcoin-git has left #bitcoin-core-dev
2762020-03-17T19:34:37  *** ghost43 has quit IRC
2772020-03-17T19:35:54  *** ghost43 has joined #bitcoin-core-dev
2782020-03-17T19:44:03  *** vasild has quit IRC
2792020-03-17T19:49:40  *** TheRec has quit IRC
2802020-03-17T19:50:48  *** vasild has joined #bitcoin-core-dev
2812020-03-17T20:03:11  *** TheRec has joined #bitcoin-core-dev
2822020-03-17T20:16:23  *** ghost43 has quit IRC
2832020-03-17T20:16:39  *** ghost43 has joined #bitcoin-core-dev
2842020-03-17T20:22:42  *** mol has joined #bitcoin-core-dev
2852020-03-17T20:25:27  *** molly has quit IRC
2862020-03-17T20:30:41  *** Chris_Stewart_5 has quit IRC
2872020-03-17T20:32:25  *** mol has quit IRC
2882020-03-17T20:32:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2892020-03-17T20:36:00  *** bitcoin-git has joined #bitcoin-core-dev
2902020-03-17T20:36:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/39497d1f3268...ce87d5613a55
2912020-03-17T20:36:02  <bitcoin-git> bitcoin/master fa70ccc MarcoFalke: scheduler: Use C++11 member initialization, add shutdown assert
2922020-03-17T20:36:02  <bitcoin-git> bitcoin/master fadafb8 MarcoFalke: scheduler: Make schedule* methods type safe
2932020-03-17T20:36:03  <bitcoin-git> bitcoin/master fa36f3a MarcoFalke: refactor: move DUMP_BANS_INTERVAL to banman.h
2942020-03-17T20:36:13  *** bitcoin-git has left #bitcoin-core-dev
2952020-03-17T20:36:30  *** bitcoin-git has joined #bitcoin-core-dev
2962020-03-17T20:36:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18289: refactor: Make scheduler methods type safe (master...2003-schedTypeChrono) https://github.com/bitcoin/bitcoin/pull/18289
2972020-03-17T20:36:43  *** bitcoin-git has left #bitcoin-core-dev
2982020-03-17T20:38:55  *** emilengler has quit IRC
2992020-03-17T20:57:01  *** GoldmanSats has joined #bitcoin-core-dev
3002020-03-17T21:00:02  *** jchris has quit IRC
3012020-03-17T21:05:17  *** mdunnio has quit IRC
3022020-03-17T21:22:30  *** Eartaker has joined #bitcoin-core-dev
3032020-03-17T21:27:41  *** sonofhan has joined #bitcoin-core-dev
3042020-03-17T21:37:07  *** TheRec has quit IRC
3052020-03-17T21:43:36  *** Krellan_ has joined #bitcoin-core-dev
3062020-03-17T21:50:53  *** TheRec has joined #bitcoin-core-dev
3072020-03-17T21:50:53  *** TheRec has joined #bitcoin-core-dev
3082020-03-17T21:57:07  *** kinlo has quit IRC
3092020-03-17T22:03:13  *** manantial has quit IRC
3102020-03-17T22:03:49  *** sonofhan has quit IRC
3112020-03-17T22:06:00  *** tryphe_ is now known as tryphe
3122020-03-17T22:15:20  *** kinlo has joined #bitcoin-core-dev
3132020-03-17T22:21:18  *** justanotheruser has quit IRC
3142020-03-17T22:24:54  *** mol has joined #bitcoin-core-dev
3152020-03-17T22:29:21  *** captjakk has quit IRC
3162020-03-17T22:29:54  *** captjakk has joined #bitcoin-core-dev
3172020-03-17T22:34:18  *** captjakk has quit IRC
3182020-03-17T22:36:41  *** Dean_Guss has joined #bitcoin-core-dev
3192020-03-17T22:37:28  *** justanotheruser has joined #bitcoin-core-dev
3202020-03-17T22:38:48  *** DeanWeen has joined #bitcoin-core-dev
3212020-03-17T22:38:52  *** Guyver2 has quit IRC
3222020-03-17T22:40:23  *** DeanGuss has quit IRC
3232020-03-17T22:41:43  *** captjakk has joined #bitcoin-core-dev
3242020-03-17T22:42:23  *** Dean_Guss has quit IRC
3252020-03-17T22:59:19  *** someone235 has quit IRC
3262020-03-17T23:04:52  *** captjakk has quit IRC
3272020-03-17T23:15:06  *** captjakk has joined #bitcoin-core-dev
3282020-03-17T23:39:59  <fanquake> aj can you follow up in #13990
3292020-03-17T23:40:01  <gribble> https://github.com/bitcoin/bitcoin/issues/13990 | Allow fee estimation to work with lower fees by ajtowns · Pull Request #13990 · bitcoin/bitcoin · GitHub
3302020-03-17T23:40:22  <aj> fanquake: yeah
3312020-03-17T23:47:25  *** mryandao has quit IRC
3322020-03-17T23:49:33  *** mryandao has joined #bitcoin-core-dev
3332020-03-17T23:50:44  *** captjakk has quit IRC
3342020-03-17T23:53:06  *** apaval has joined #bitcoin-core-dev
3352020-03-17T23:54:05  *** apaval has quit IRC
3362020-03-17T23:54:18  *** apaval has joined #bitcoin-core-dev
3372020-03-17T23:57:23  *** mryandao has quit IRC