12020-03-18T00:00:02 *** Eartaker has quit IRC
22020-03-18T00:04:10 *** apaval has quit IRC
32020-03-18T00:04:21 *** apaval has joined #bitcoin-core-dev
42020-03-18T00:04:36 *** sonofhan has joined #bitcoin-core-dev
52020-03-18T00:05:45 *** apaval has quit IRC
62020-03-18T00:06:16 *** mryandao has joined #bitcoin-core-dev
72020-03-18T00:09:32 *** apaval_ has joined #bitcoin-core-dev
82020-03-18T00:09:49 *** sonofhan has quit IRC
92020-03-18T00:21:48 *** dscho has joined #bitcoin-core-dev
102020-03-18T00:22:02 *** marcoagner has quit IRC
112020-03-18T00:22:03 *** bitcoin-git has joined #bitcoin-core-dev
122020-03-18T00:22:03 <bitcoin-git> [bitcoin] sipa closed pull request #18367: Avoid strncpy for CMessageHeader::pchCommand (master...202003_strncopy_warning) https://github.com/bitcoin/bitcoin/pull/18367
132020-03-18T00:22:04 *** bitcoin-git has left #bitcoin-core-dev
142020-03-18T00:53:58 *** Krellan_ has quit IRC
152020-03-18T00:54:26 *** Krellan_ has joined #bitcoin-core-dev
162020-03-18T00:54:35 *** justanotheruser has quit IRC
172020-03-18T01:00:12 *** Krellan_ has quit IRC
182020-03-18T01:09:53 *** justanotheruser has joined #bitcoin-core-dev
192020-03-18T01:13:19 <fanquake> sipa did you want to review #16995 ?
202020-03-18T01:13:21 <gribble> https://github.com/bitcoin/bitcoin/issues/16995 | Fix gcc 9 warnings by laanwj · Pull Request #16995 · bitcoin/bitcoin · GitHub
212020-03-18T01:13:29 <sipa> fanquake: of course
222020-03-18T01:14:10 * fanquake moves away from the merge button
232020-03-18T01:14:34 <sipa> give me 15 min
242020-03-18T01:14:51 <fanquake> No worries, no rush
252020-03-18T01:19:47 *** jb55 has quit IRC
262020-03-18T01:28:25 *** Highway61 has quit IRC
272020-03-18T01:42:20 *** captjakk has joined #bitcoin-core-dev
282020-03-18T02:01:41 *** AaronvanW has quit IRC
292020-03-18T02:04:35 *** ddustin has joined #bitcoin-core-dev
302020-03-18T02:04:45 *** captjakk has joined #bitcoin-core-dev
312020-03-18T02:06:10 *** sonofhan has joined #bitcoin-core-dev
322020-03-18T02:10:43 *** sonofhan has quit IRC
332020-03-18T02:21:51 *** Krellan_ has joined #bitcoin-core-dev
342020-03-18T02:26:48 *** mol has quit IRC
352020-03-18T02:27:36 *** mol has joined #bitcoin-core-dev
362020-03-18T02:28:10 *** belcher has quit IRC
372020-03-18T02:28:32 *** justanotheruser has quit IRC
382020-03-18T02:30:59 *** ddustin has quit IRC
392020-03-18T02:33:49 *** Krellan_ has quit IRC
402020-03-18T03:00:02 *** dscho has quit IRC
412020-03-18T03:13:16 *** bitcoin-git has joined #bitcoin-core-dev
422020-03-18T03:13:16 <bitcoin-git> [bitcoin] fanquake opened pull request #18371: test: use fs namespace in dbwrapper unicodepath test (master...dbwrapper_use_fs_namespace) https://github.com/bitcoin/bitcoin/pull/18371
432020-03-18T03:13:17 *** bitcoin-git has left #bitcoin-core-dev
442020-03-18T03:14:14 *** deacyde has quit IRC
452020-03-18T03:22:23 *** SynOps has joined #bitcoin-core-dev
462020-03-18T03:33:38 *** Krellan_ has joined #bitcoin-core-dev
472020-03-18T03:35:48 *** felixfoertsch23 has joined #bitcoin-core-dev
482020-03-18T03:37:29 *** felixfoertsch has quit IRC
492020-03-18T03:37:41 *** Rapsil has quit IRC
502020-03-18T03:55:25 *** Randolf has joined #bitcoin-core-dev
512020-03-18T04:06:58 *** sonofhan has joined #bitcoin-core-dev
522020-03-18T04:11:28 *** sonofhan has quit IRC
532020-03-18T04:50:59 *** justanotheruser has joined #bitcoin-core-dev
542020-03-18T05:46:26 *** bitcoin-git has joined #bitcoin-core-dev
552020-03-18T05:46:26 <bitcoin-git> [bitcoin] sipa opened pull request #18374: Bugfix in bn2vch: avoid excessive padding (master...202003_fix_bn2vch) https://github.com/bitcoin/bitcoin/pull/18374
562020-03-18T05:46:27 *** bitcoin-git has left #bitcoin-core-dev
572020-03-18T05:47:53 *** tryphe_ has joined #bitcoin-core-dev
582020-03-18T05:48:42 *** kristapsk_ has joined #bitcoin-core-dev
592020-03-18T05:49:59 *** SiAnDoG__ has quit IRC
602020-03-18T05:50:17 *** SiAnDoG__ has joined #bitcoin-core-dev
612020-03-18T05:50:29 *** kristapsk has quit IRC
622020-03-18T05:50:59 *** niska` has quit IRC
632020-03-18T05:51:09 *** achow101 has quit IRC
642020-03-18T05:51:13 *** tryphe has quit IRC
652020-03-18T05:51:20 *** wraithm has quit IRC
662020-03-18T05:51:29 *** ghost43 has quit IRC
672020-03-18T05:51:40 *** ghost43_ has joined #bitcoin-core-dev
682020-03-18T05:52:26 *** niska has joined #bitcoin-core-dev
692020-03-18T05:52:27 *** achow101 has joined #bitcoin-core-dev
702020-03-18T05:54:20 *** wraithm has joined #bitcoin-core-dev
712020-03-18T05:59:20 *** Highway61 has joined #bitcoin-core-dev
722020-03-18T06:00:01 *** SynOps has quit IRC
732020-03-18T06:03:47 *** Karyon has quit IRC
742020-03-18T06:07:57 *** sonofhan has joined #bitcoin-core-dev
752020-03-18T06:12:34 *** sonofhan has quit IRC
762020-03-18T06:19:31 *** Karyon has joined #bitcoin-core-dev
772020-03-18T06:22:19 *** ldoguin has joined #bitcoin-core-dev
782020-03-18T06:38:50 *** niknebis has joined #bitcoin-core-dev
792020-03-18T06:43:35 *** kristapsk_ has quit IRC
802020-03-18T06:43:35 *** ghost43_ has quit IRC
812020-03-18T06:43:56 *** kristapsk_ has joined #bitcoin-core-dev
822020-03-18T06:44:08 *** niknebis has quit IRC
832020-03-18T06:44:22 *** ghost43 has joined #bitcoin-core-dev
842020-03-18T07:00:37 *** nik23 has joined #bitcoin-core-dev
852020-03-18T07:10:36 *** nik23 has quit IRC
862020-03-18T07:11:43 * fanquake kills his terminal
872020-03-18T07:11:55 * fanquake realises he should have respected LLDBs advice that there were too many frame variables to print
882020-03-18T07:25:02 <fanquake> vasild: see #18372 for why master is broken
892020-03-18T07:25:03 <gribble> https://github.com/bitcoin/bitcoin/issues/18372 | sanitizer: heap-use-after-free in checkinputs_test · Issue #18372 · bitcoin/bitcoin · GitHub
902020-03-18T07:27:59 <vasild> fanquake: so, its not the .md changes that broke it ;D
912020-03-18T07:28:11 <vasild> any idea how did this sneak into master?
922020-03-18T07:29:41 <fanquake> vasild: no, I haven't investigated yet
932020-03-18T07:32:17 <vasild> maybe one of 1. it is undeterministic failure and the PR that introduced it was lucky to get green. or 2. somebody merged a red/broken PR or 3. changes in the travis environment that revealed an existent problem.
942020-03-18T07:40:46 *** vasild_ has joined #bitcoin-core-dev
952020-03-18T07:43:43 *** vasild has quit IRC
962020-03-18T07:43:44 *** vasild_ is now known as vasild
972020-03-18T07:49:55 *** manantial has joined #bitcoin-core-dev
982020-03-18T07:59:10 *** justanotheruser has quit IRC
992020-03-18T08:07:43 <aj> vasild: or it only comes about because of two changes that were independently okay
1002020-03-18T08:08:55 *** sonofhan has joined #bitcoin-core-dev
1012020-03-18T08:13:25 *** sonofhan has quit IRC
1022020-03-18T08:14:41 *** justanotheruser has joined #bitcoin-core-dev
1032020-03-18T08:20:38 *** real_or_random has quit IRC
1042020-03-18T08:21:30 *** real_or_random has joined #bitcoin-core-dev
1052020-03-18T08:22:23 *** kristapsk_ has quit IRC
1062020-03-18T08:26:32 *** ghost43 has quit IRC
1072020-03-18T08:27:50 *** ghost43 has joined #bitcoin-core-dev
1082020-03-18T08:40:32 <vasild> aj: right! lets see...
1092020-03-18T09:00:01 *** ldoguin has quit IRC
1102020-03-18T09:09:31 *** oguzkoroglu has joined #bitcoin-core-dev
1112020-03-18T09:20:15 *** marcoagner has joined #bitcoin-core-dev
1122020-03-18T09:22:17 *** true-asset has joined #bitcoin-core-dev
1132020-03-18T09:59:26 *** Lightsword_ has joined #bitcoin-core-dev
1142020-03-18T10:00:32 *** IGHOR_ has joined #bitcoin-core-dev
1152020-03-18T10:00:45 *** raj_ has joined #bitcoin-core-dev
1162020-03-18T10:00:46 *** willcl_ark__ has joined #bitcoin-core-dev
1172020-03-18T10:01:52 *** kanzure_ has joined #bitcoin-core-dev
1182020-03-18T10:02:18 *** nehan_ has joined #bitcoin-core-dev
1192020-03-18T10:04:49 *** raj_149 has quit IRC
1202020-03-18T10:04:49 *** nehan has quit IRC
1212020-03-18T10:04:49 *** willcl_ark_ has quit IRC
1222020-03-18T10:04:49 *** Lightsword has quit IRC
1232020-03-18T10:04:49 *** pingwindyktator has quit IRC
1242020-03-18T10:04:49 *** treyzania has quit IRC
1252020-03-18T10:04:49 *** kanzure has quit IRC
1262020-03-18T10:04:49 *** IGHOR has quit IRC
1272020-03-18T10:04:49 *** Lightsword_ is now known as Lightsword
1282020-03-18T10:04:57 *** treyzania has joined #bitcoin-core-dev
1292020-03-18T10:06:04 *** pingwindyktator has joined #bitcoin-core-dev
1302020-03-18T10:09:55 *** sonofhan has joined #bitcoin-core-dev
1312020-03-18T10:11:09 *** ghost43 has quit IRC
1322020-03-18T10:12:27 *** timothy has joined #bitcoin-core-dev
1332020-03-18T10:12:28 *** ghost43 has joined #bitcoin-core-dev
1342020-03-18T10:14:45 *** sonofhan has quit IRC
1352020-03-18T10:23:14 *** kristapsk has joined #bitcoin-core-dev
1362020-03-18T10:43:56 *** apaval_ has quit IRC
1372020-03-18T10:44:18 *** apaval_ has joined #bitcoin-core-dev
1382020-03-18T11:04:11 *** Malvina89Heidenr has joined #bitcoin-core-dev
1392020-03-18T11:14:38 *** bitcoin-git has joined #bitcoin-core-dev
1402020-03-18T11:14:38 <bitcoin-git> [bitcoin] AleGiovanardi opened pull request #18375: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18375
1412020-03-18T11:14:40 *** bitcoin-git has left #bitcoin-core-dev
1422020-03-18T11:15:01 *** bitcoin-git has joined #bitcoin-core-dev
1432020-03-18T11:15:01 <bitcoin-git> [bitcoin] AleGiovanardi closed pull request #18375: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18375
1442020-03-18T11:15:02 *** bitcoin-git has left #bitcoin-core-dev
1452020-03-18T11:15:47 *** AaronvanW has joined #bitcoin-core-dev
1462020-03-18T11:17:05 *** manantial has quit IRC
1472020-03-18T11:17:35 *** manantial has joined #bitcoin-core-dev
1482020-03-18T11:49:49 *** braydonf has quit IRC
1492020-03-18T11:50:15 *** braydonf has joined #bitcoin-core-dev
1502020-03-18T12:00:02 *** true-asset has quit IRC
1512020-03-18T12:05:21 *** bitcoin-git has joined #bitcoin-core-dev
1522020-03-18T12:05:22 <bitcoin-git> [bitcoin] vasild opened pull request #18376: net: fix use-after-free in tests (master...fix_use_after_free_issue18372) https://github.com/bitcoin/bitcoin/pull/18376
1532020-03-18T12:05:22 *** bitcoin-git has left #bitcoin-core-dev
1542020-03-18T12:10:55 *** sonofhan has joined #bitcoin-core-dev
1552020-03-18T12:15:39 *** sonofhan has quit IRC
1562020-03-18T12:22:10 *** jjj1 has joined #bitcoin-core-dev
1572020-03-18T12:48:17 *** sipsorcery has quit IRC
1582020-03-18T12:49:17 *** sipsorcery has joined #bitcoin-core-dev
1592020-03-18T12:50:45 *** Malvina89Heidenr has quit IRC
1602020-03-18T12:51:11 *** emilengler has joined #bitcoin-core-dev
1612020-03-18T13:04:37 *** emilengler has quit IRC
1622020-03-18T13:04:50 *** emilengler has joined #bitcoin-core-dev
1632020-03-18T13:08:07 *** meshcollider has quit IRC
1642020-03-18T13:08:20 *** vasild has quit IRC
1652020-03-18T13:08:33 *** vasild has joined #bitcoin-core-dev
1662020-03-18T13:12:18 *** kanzure_ is now known as kanzure
1672020-03-18T13:26:28 *** meshcollider has joined #bitcoin-core-dev
1682020-03-18T13:38:39 *** Guyver2 has joined #bitcoin-core-dev
1692020-03-18T13:42:06 *** captjakk_ has joined #bitcoin-core-dev
1702020-03-18T13:43:33 *** bitcoin-git has joined #bitcoin-core-dev
1712020-03-18T13:43:33 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce87d5613a55...3a8d25064e70
1722020-03-18T13:43:34 <bitcoin-git> bitcoin/master 6afaf2f fanquake: test: use fs namespace in dbwrapper unicodepath test
1732020-03-18T13:43:34 <bitcoin-git> bitcoin/master 3a8d250 MarcoFalke: Merge #18371: test: use fs namespace in dbwrapper unicodepath test
1742020-03-18T13:43:36 *** bitcoin-git has left #bitcoin-core-dev
1752020-03-18T13:43:45 *** Krellan__ has joined #bitcoin-core-dev
1762020-03-18T13:43:53 *** bitcoin-git has joined #bitcoin-core-dev
1772020-03-18T13:43:53 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18371: test: use fs namespace in dbwrapper unicodepath test (master...dbwrapper_use_fs_namespace) https://github.com/bitcoin/bitcoin/pull/18371
1782020-03-18T13:43:54 *** bitcoin-git has left #bitcoin-core-dev
1792020-03-18T13:44:15 *** captjakk has quit IRC
1802020-03-18T13:44:36 *** kanzure has quit IRC
1812020-03-18T13:44:36 *** Karyon has quit IRC
1822020-03-18T13:44:57 *** Krellan_ has quit IRC
1832020-03-18T13:46:31 *** kanzure has joined #bitcoin-core-dev
1842020-03-18T13:48:03 *** Karyon has joined #bitcoin-core-dev
1852020-03-18T13:49:03 *** ghost43 has quit IRC
1862020-03-18T13:49:17 *** ghost43 has joined #bitcoin-core-dev
1872020-03-18T13:59:47 *** mdunnio has joined #bitcoin-core-dev
1882020-03-18T14:01:58 *** cfields_ is now known as cfields
1892020-03-18T14:02:29 <vasild> MarcoFalke: wrt https://github.com/bitcoin/bitcoin/pull/18376#discussion_r394349862 - I will change it as you suggest to just "=" once travis confirms the fix (if I push now it will restart the tests)
1902020-03-18T14:03:19 <vasild> now, if we can explain why travis was green on the PR that introduced the issue I will sleep well tonight
1912020-03-18T14:11:55 *** sonofhan has joined #bitcoin-core-dev
1922020-03-18T14:16:33 *** sonofhan has quit IRC
1932020-03-18T14:34:12 *** kristapsk_ has joined #bitcoin-core-dev
1942020-03-18T14:34:20 *** kristapsk has quit IRC
1952020-03-18T14:42:36 *** Randolf has quit IRC
1962020-03-18T14:45:46 *** oguzkoroglu has quit IRC
1972020-03-18T14:49:35 *** AaronvanW has quit IRC
1982020-03-18T14:51:34 *** TheFuzzStone[m] has quit IRC
1992020-03-18T14:51:34 *** mrostecki has quit IRC
2002020-03-18T14:55:31 *** TheFuzzStone[m] has joined #bitcoin-core-dev
2012020-03-18T14:55:33 *** mrostecki has joined #bitcoin-core-dev
2022020-03-18T14:56:15 *** bitcoin-git has joined #bitcoin-core-dev
2032020-03-18T14:56:15 <bitcoin-git> [bitcoin] brakmic opened pull request #18377: build: fix libevent linking errors for bench-only builds (master...bench-compilation) https://github.com/bitcoin/bitcoin/pull/18377
2042020-03-18T14:56:17 *** bitcoin-git has left #bitcoin-core-dev
2052020-03-18T15:00:02 *** jjj1 has quit IRC
2062020-03-18T15:03:28 *** belcher has joined #bitcoin-core-dev
2072020-03-18T15:06:44 *** brakmic has joined #bitcoin-core-dev
2082020-03-18T15:13:06 *** lukedashjr has joined #bitcoin-core-dev
2092020-03-18T15:14:37 *** sipsorcery has quit IRC
2102020-03-18T15:15:03 *** luke-jr has quit IRC
2112020-03-18T15:17:24 *** lukedashjr is now known as luke-jr
2122020-03-18T15:21:58 *** Perlboy has joined #bitcoin-core-dev
2132020-03-18T15:46:34 <willcl_ark> Is it worth me opening an issue for this project related to with a specific clang version segfaulting during tests, if the solution is to simply upgrade clang?
2142020-03-18T15:47:39 <fanquake> willcl_ark: what version of Clang?
2152020-03-18T15:48:11 <willcl_ark> fanquake: 11.0.0 (bundled with commandlinetools). Upgrading to 11.0.3 fixed.
2162020-03-18T15:48:22 <fanquake> So Apple Clang?
2172020-03-18T15:48:27 <willcl_ark> Indeed
2182020-03-18T15:48:37 <fanquake> Was the issue related to stack checking?
2192020-03-18T15:48:48 <fanquake> Possibly libsecp related?
2202020-03-18T15:49:20 <willcl_ark> yes libsecp test segfaulted too. wait I'll just recall the error
2212020-03-18T15:49:36 <willcl_ark> it was unaligned stack stuff
2222020-03-18T15:50:04 <willcl_ark> I guess this is pretty much the same issue: https://github.com/jedisct1/libsodium/issues/848
2232020-03-18T15:50:27 <fanquake> Yea I assume you're seeing https://github.com/bitcoin-core/secp256k1/issues/674
2242020-03-18T15:51:17 <willcl_ark> ah great, I just wanted to make sure it was documented within this project in some way :)
2252020-03-18T15:52:26 <fanquake> willcl_ark: no worries, thanks for asking
2262020-03-18T15:54:09 *** andrewtoth has joined #bitcoin-core-dev
2272020-03-18T15:57:20 *** sipsorcery has joined #bitcoin-core-dev
2282020-03-18T16:12:55 *** sonofhan has joined #bitcoin-core-dev
2292020-03-18T16:17:27 *** sonofhan has quit IRC
2302020-03-18T16:20:42 *** shaunsun has joined #bitcoin-core-dev
2312020-03-18T16:20:49 *** shaunsun_ has joined #bitcoin-core-dev
2322020-03-18T16:24:15 *** sonofhan has joined #bitcoin-core-dev
2332020-03-18T16:26:33 <stevenroose> I'd like to get a clear summary of the peering strategy for Core nodes. Especially regarding limits (incoming and outgoing) and how the limit applies to `connect=`. Is that written up somewhere?
2342020-03-18T16:27:39 <stevenroose> Personally I assumed that `connect=` configs would have no limit as they are a clear order "make sure you connect to this peer always". But it seems that they might fall under the 8- (or 12?) peer outgoing connection limit?
2352020-03-18T16:28:09 <stevenroose> These policies are quite hard to find in the code, tbh. Hence my Q here :)
2362020-03-18T16:28:43 <harding> stevenroose: the -help documentation for connect= says "Connect only to the specified node"
2372020-03-18T16:29:17 <harding> Oh, your question is how many times you can specify -connect?
2382020-03-18T16:29:18 <stevenroose> Yeah..
2392020-03-18T16:29:47 <stevenroose> No mostly it is "if I specify 30, will it connect to all 30 or will it stop at the 8 (or 12?) limit?"
2402020-03-18T16:29:47 <sipa> i think 8 times
2412020-03-18T16:30:22 <stevenroose> IMO "Connect only to the specified node" should be "Connect to the specified node"
2422020-03-18T16:30:30 <sipa> no
2432020-03-18T16:30:33 *** ddustin has joined #bitcoin-core-dev
2442020-03-18T16:30:33 <stevenroose> Hmm no
2452020-03-18T16:30:41 <sipa> -connect disables the normal automatic connection mechanism
2462020-03-18T16:30:43 <stevenroose> Indeed, because that doesn't rule out that it doesn't connect to others.
2472020-03-18T16:31:33 <stevenroose> sipa: so your understanding is as well that with 9 `connect=`'s, it will just pick 8 of them to connect to? And probably pick the 9th if one of the 9 goes down?
2482020-03-18T16:31:35 *** ddustin has quit IRC
2492020-03-18T16:32:18 <sipa> stevenroose: i believe it's something like that
2502020-03-18T16:32:25 <stevenroose> Is there a way to make a node connect to *all* `connect=`'s? By upping the limit? By config? Or can that only be done through a code change?
2512020-03-18T16:32:39 <sipa> no
2522020-03-18T16:32:42 <sipa> and yes, intentionally
2532020-03-18T16:33:29 <stevenroose> The docs don't mention the limit, though: "This option can be specified multiple times to connect to multiple nodes."
2542020-03-18T16:33:45 <sipa> (because a while ago there was a flurry of people who believed that more connections means better, faster, safer, ...; and were causing the network to run out of connectable ports)
2552020-03-18T16:34:10 <stevenroose> Hmm. Well I understand that having a `-outgoinglimit` flag is exploitable.
2562020-03-18T16:34:23 <stevenroose> But letting `-connect=` go over the limit is way harder to exploit.
2572020-03-18T16:34:32 <yevaud> if you think you need more outgoing connections, you almost certainly don't.
2582020-03-18T16:34:33 <stevenroose> These people would have to keep adding nodes to their config files.
2592020-03-18T16:34:57 <sipa> yeah, generally there is no point
2602020-03-18T16:34:59 <stevenroose> yevaud: special-case situation
2612020-03-18T16:36:03 <yevaud> there's no special cases that justify it, honestly. manually pinning certain peers causes a bunch of issues.
2622020-03-18T16:37:07 <yevaud> for running nodes behind a network of external gateways, sure, but that's a very specific use case which doesn't need a large number of them.
2632020-03-18T16:37:20 <stevenroose> yevaud: briefly explained we're trying to bridge a bunch of internla nodes that only interconnect with the public network through 2 bridges. And we want to ensure the bridges connect to the internal nodes but also at least a few public connections
2642020-03-18T16:37:42 <sipa> stevenroose: you can use -addnode instead
2652020-03-18T16:38:03 <yevaud> you want addnode, which has a different connection pool to outgoing connections.
2662020-03-18T16:38:04 <sipa> which works like -connect, but doesn't disable the normal random peer mechanism
2672020-03-18T16:39:16 <yevaud> and you have that backwards anyway.
2682020-03-18T16:39:36 <yevaud> internal nodes want to be connecting to the bridges, not the other way around.
2692020-03-18T16:40:00 <yevaud> just from a management perspective it's a lot less painful.
2702020-03-18T16:40:07 <stevenroose> yeah so somehow we've been trying to make the bridge not accept incoming connections to prevent them from being DoS'ed (I think), but I'm starting to quesiton that requirement
2712020-03-18T16:40:32 <stevenroose> AFAIU if some public nodes we have and all the internal ones just -addnode the bridges, it should all work
2722020-03-18T16:41:04 <yevaud> read about whitebind, and the docs in general.
2732020-03-18T16:41:59 <sipa> stevenroose: all these nodes (bridges, internal ones) connect over the public internet, right? no VPN or so
2742020-03-18T16:42:19 <stevenroose> sipa: all tor
2752020-03-18T16:42:26 *** Talkless has joined #bitcoin-core-dev
2762020-03-18T16:42:56 <sipa> so if the onion addresses are kept secret, there is no risk for incoming DOS to the bridge nodes
2772020-03-18T16:43:14 <sipa> whitebind won't help in this case
2782020-03-18T16:43:40 <yevaud> for bridges you definitely want whitebind for the transaction relay logic.
2792020-03-18T16:44:38 <stevenroose> hmm yeah I think I'm getting the gist of what we should do. Thanks.
2802020-03-18T16:45:36 *** jb55 has joined #bitcoin-core-dev
2812020-03-18T16:46:31 <yevaud> don't listen on bridges, whitebind on them, and use connect on the "hidden" peers.
2822020-03-18T16:50:12 *** michaelfolkson has joined #bitcoin-core-dev
2832020-03-18T16:51:18 *** AaronvanW has joined #bitcoin-core-dev
2842020-03-18T17:16:17 *** sonofhan has quit IRC
2852020-03-18T17:23:08 *** bitcoin-git has joined #bitcoin-core-dev
2862020-03-18T17:23:08 <bitcoin-git> [bitcoin] sipa opened pull request #18378: Bugfix & simplify bn2vch using int.to_bytes (master...202003_simple_bn2vch) https://github.com/bitcoin/bitcoin/pull/18378
2872020-03-18T17:23:09 *** bitcoin-git has left #bitcoin-core-dev
2882020-03-18T17:23:58 *** justanotheruser has quit IRC
2892020-03-18T17:24:03 *** bitcoin-git has joined #bitcoin-core-dev
2902020-03-18T17:24:03 <bitcoin-git> [bitcoin] sipa closed pull request #18374: Bugfix in bn2vch: avoid excessive padding (master...202003_fix_bn2vch) https://github.com/bitcoin/bitcoin/pull/18374
2912020-03-18T17:24:04 *** bitcoin-git has left #bitcoin-core-dev
2922020-03-18T17:36:25 *** bitcoin-git has joined #bitcoin-core-dev
2932020-03-18T17:36:25 <bitcoin-git> [bitcoin] 4d55397500 opened pull request #18379: Comment fix merkle.cpp (master...4d55397500-patch-1-1) https://github.com/bitcoin/bitcoin/pull/18379
2942020-03-18T17:36:26 *** bitcoin-git has left #bitcoin-core-dev
2952020-03-18T17:38:56 *** justanotheruser has joined #bitcoin-core-dev
2962020-03-18T18:00:01 *** Perlboy has quit IRC
2972020-03-18T18:03:48 *** bitcoin-git has joined #bitcoin-core-dev
2982020-03-18T18:03:49 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a8d25064e70...dbb067da389d
2992020-03-18T18:03:49 <bitcoin-git> bitcoin/master 5b59a19 4d55397500: Update merkle.cpp
3002020-03-18T18:03:50 <bitcoin-git> bitcoin/master dbb067d MarcoFalke: Merge #18379: doc: Comment fix merkle.cpp
3012020-03-18T18:03:52 *** bitcoin-git has left #bitcoin-core-dev
3022020-03-18T18:04:08 *** bitcoin-git has joined #bitcoin-core-dev
3032020-03-18T18:04:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18379: doc: Comment fix merkle.cpp (master...4d55397500-patch-1-1) https://github.com/bitcoin/bitcoin/pull/18379
3042020-03-18T18:04:09 *** bitcoin-git has left #bitcoin-core-dev
3052020-03-18T18:07:26 *** captjakk_ has quit IRC
3062020-03-18T18:21:17 *** Lthere has joined #bitcoin-core-dev
3072020-03-18T18:23:33 *** jarthur has joined #bitcoin-core-dev
3082020-03-18T18:29:14 *** michaelfolkson has quit IRC
3092020-03-18T18:38:25 *** captjakk has joined #bitcoin-core-dev
3102020-03-18T18:41:34 *** captjakk has quit IRC
3112020-03-18T18:44:04 *** michaelfolkson has joined #bitcoin-core-dev
3122020-03-18T18:51:53 *** michaelfolkson has quit IRC
3132020-03-18T18:59:58 *** michaelfolkson has joined #bitcoin-core-dev
3142020-03-18T19:00:41 *** michaelfolkson has quit IRC
3152020-03-18T19:16:43 *** vasild has quit IRC
3162020-03-18T19:16:58 *** vasild has joined #bitcoin-core-dev
3172020-03-18T19:40:46 *** vasild_ has joined #bitcoin-core-dev
3182020-03-18T19:44:23 *** vasild has quit IRC
3192020-03-18T19:44:24 *** vasild_ is now known as vasild
3202020-03-18T19:49:50 *** bitcoin-git has joined #bitcoin-core-dev
3212020-03-18T19:49:50 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dbb067da389d...e83a1de4c03f
3222020-03-18T19:49:50 <bitcoin-git> bitcoin/master 5e47b19 practicalswift: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed...
3232020-03-18T19:49:50 <bitcoin-git> bitcoin/master e83a1de MarcoFalke: Merge #18155: tests: Add harness which fuzzes EvalScript and VerifyScript ...
3242020-03-18T19:49:52 *** bitcoin-git has left #bitcoin-core-dev
3252020-03-18T19:49:53 *** MrSquanchee has joined #bitcoin-core-dev
3262020-03-18T19:50:10 *** bitcoin-git has joined #bitcoin-core-dev
3272020-03-18T19:50:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18155: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker (master...fuzzers-signature_checker) https://github.com/bitcoin/bitcoin/pull/18155
3282020-03-18T19:50:12 *** bitcoin-git has left #bitcoin-core-dev
3292020-03-18T19:52:56 *** bitcoin-git has joined #bitcoin-core-dev
3302020-03-18T19:52:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e83a1de4c03f...5c9d408b2dd8
3312020-03-18T19:52:57 <bitcoin-git> bitcoin/master fa4fa88 MarcoFalke: doc: Remove --disable-ccache from docs
3322020-03-18T19:52:58 <bitcoin-git> bitcoin/master aaaa055 MarcoFalke: fuzz: Add option to merge input dir to test runner
3332020-03-18T19:52:58 <bitcoin-git> bitcoin/master fa3fa27 MarcoFalke: fuzz: Remove option --export_coverage from test_runner
3342020-03-18T19:53:00 *** bitcoin-git has left #bitcoin-core-dev
3352020-03-18T19:53:01 *** captjakk has joined #bitcoin-core-dev
3362020-03-18T19:53:16 *** bitcoin-git has joined #bitcoin-core-dev
3372020-03-18T19:53:16 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18300: fuzz: Add option to merge input dir to test runner (master...Mf1902-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/18300
3382020-03-18T19:53:17 *** bitcoin-git has left #bitcoin-core-dev
3392020-03-18T20:09:09 *** Talkless has quit IRC
3402020-03-18T20:26:55 *** AaronvanW has quit IRC
3412020-03-18T20:42:15 *** bitcoin-git has joined #bitcoin-core-dev
3422020-03-18T20:42:15 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c9d408b2dd8...a421e0a22f12
3432020-03-18T20:42:16 <bitcoin-git> bitcoin/master 7d8e1de Vasil Dimov: net: fix use-after-free in tests
3442020-03-18T20:42:16 <bitcoin-git> bitcoin/master a421e0a MarcoFalke: Merge #18376: net: fix use-after-free in tests
3452020-03-18T20:42:18 *** bitcoin-git has left #bitcoin-core-dev
3462020-03-18T20:42:35 *** bitcoin-git has joined #bitcoin-core-dev
3472020-03-18T20:42:35 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18376: net: fix use-after-free in tests (master...fix_use_after_free_issue18372) https://github.com/bitcoin/bitcoin/pull/18376
3482020-03-18T20:42:36 *** bitcoin-git has left #bitcoin-core-dev
3492020-03-18T20:46:43 *** andrewtoth has quit IRC
3502020-03-18T20:59:33 *** manantial has quit IRC
3512020-03-18T21:00:02 *** Lthere has quit IRC
3522020-03-18T21:02:09 *** andrewtoth has joined #bitcoin-core-dev
3532020-03-18T21:15:06 *** bitcoin-git has joined #bitcoin-core-dev
3542020-03-18T21:15:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18380: doc: Remove html comment in PULL_REQUEST_TEMPLATE (master...2003-docGitHubTemplateNoComment) https://github.com/bitcoin/bitcoin/pull/18380
3552020-03-18T21:15:07 *** bitcoin-git has left #bitcoin-core-dev
3562020-03-18T21:21:26 *** Kenya53Schuster has joined #bitcoin-core-dev
3572020-03-18T21:22:04 *** kaeru has joined #bitcoin-core-dev
3582020-03-18T21:28:36 *** kexkey has joined #bitcoin-core-dev
3592020-03-18T21:32:32 *** Kenya53Schuster has quit IRC
3602020-03-18T21:33:50 *** andrewtoth_ has joined #bitcoin-core-dev
3612020-03-18T21:34:43 *** andrewtoth has quit IRC
3622020-03-18T21:38:33 *** timothy has quit IRC
3632020-03-18T21:39:13 *** AaronvanW has joined #bitcoin-core-dev
3642020-03-18T21:40:14 *** andrewtoth_ has quit IRC
3652020-03-18T21:51:56 *** MrSquanchee has quit IRC
3662020-03-18T21:55:25 *** owowo has quit IRC
3672020-03-18T22:01:17 *** owowo has joined #bitcoin-core-dev
3682020-03-18T22:04:38 *** mdunnio has quit IRC
3692020-03-18T22:14:20 *** captjakk_ has joined #bitcoin-core-dev
3702020-03-18T22:15:19 *** Deacyde has joined #bitcoin-core-dev
3712020-03-18T22:20:31 *** bitcoin-git has joined #bitcoin-core-dev
3722020-03-18T22:20:31 <bitcoin-git> [bitcoin] practicalswift closed pull request #18308: depends: Make it possible to build Boost dependency using a clang toolset (./b2 toolset=clang) (master...b2-toolset-clang) https://github.com/bitcoin/bitcoin/pull/18308
3732020-03-18T22:20:32 *** bitcoin-git has left #bitcoin-core-dev
3742020-03-18T22:21:14 *** AaronvanW has quit IRC
3752020-03-18T22:59:17 *** AaronvanW has joined #bitcoin-core-dev
3762020-03-18T23:00:01 *** apaval_ has quit IRC
3772020-03-18T23:00:20 *** apaval has joined #bitcoin-core-dev
3782020-03-18T23:04:25 *** AaronvanW has quit IRC
3792020-03-18T23:10:25 *** nullptr_ has quit IRC
3802020-03-18T23:12:19 *** emilengler has quit IRC
3812020-03-18T23:14:22 *** justanotheruser has quit IRC
3822020-03-18T23:14:33 *** nullptr| has joined #bitcoin-core-dev
3832020-03-18T23:17:44 *** Guyver2 has quit IRC
3842020-03-18T23:29:58 *** justanotheruser has joined #bitcoin-core-dev
3852020-03-18T23:30:56 *** captjakk_ has quit IRC
3862020-03-18T23:38:15 *** captjakk_ has joined #bitcoin-core-dev
3872020-03-18T23:39:23 *** captjakk has quit IRC
3882020-03-18T23:39:29 *** gleb1 has joined #bitcoin-core-dev
3892020-03-18T23:39:56 *** captjakk has joined #bitcoin-core-dev
3902020-03-18T23:42:03 *** gleb1 has quit IRC
3912020-03-18T23:43:30 *** sonofhan has joined #bitcoin-core-dev
3922020-03-18T23:43:58 *** sonofhan has quit IRC
3932020-03-18T23:44:13 *** captjakk has quit IRC
3942020-03-18T23:49:55 *** captjakk_ has quit IRC
3952020-03-18T23:51:22 *** AaronvanW has joined #bitcoin-core-dev
3962020-03-18T23:51:29 *** gleb has joined #bitcoin-core-dev
3972020-03-18T23:55:01 *** captjakk has joined #bitcoin-core-dev