12020-04-03T00:00:01 *** vkmc1 has quit IRC
22020-04-03T00:03:52 *** PaulTroon has quit IRC
32020-04-03T00:05:17 *** dviola has quit IRC
42020-04-03T00:08:58 *** mdunnio has quit IRC
52020-04-03T00:15:47 *** justanotheruser has joined #bitcoin-core-dev
62020-04-03T00:17:41 *** AaronvanW has joined #bitcoin-core-dev
72020-04-03T00:20:33 *** promag has joined #bitcoin-core-dev
82020-04-03T00:21:21 *** iMast777 has joined #bitcoin-core-dev
92020-04-03T00:25:19 *** promag has quit IRC
102020-04-03T00:29:37 *** nodweber has quit IRC
112020-04-03T00:32:45 *** bitcoin-git has joined #bitcoin-core-dev
122020-04-03T00:32:45 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18509: fuzz: Avoid running over all inputs after merging them (master...2004-fuzzMergeOnce) https://github.com/bitcoin/bitcoin/pull/18509
132020-04-03T00:32:46 *** bitcoin-git has left #bitcoin-core-dev
142020-04-03T00:39:52 *** mdunnio has joined #bitcoin-core-dev
152020-04-03T00:43:09 <achow101> is it intentional that a new default wallet cannot be created when running with -nowallet?
162020-04-03T00:44:44 *** mdunnio has quit IRC
172020-04-03T00:54:54 <luke-jr> achow101: afaik -nowallet currently emulates a build w/o wallet support
182020-04-03T00:55:22 <achow101> you can make and add new wallets even when -nowallet
192020-04-03T00:55:45 <achow101> I think this is just a bug because who would want to make a wallet with no name
202020-04-03T01:04:13 *** AaronvanW has quit IRC
212020-04-03T01:08:06 *** bitcoin-git has joined #bitcoin-core-dev
222020-04-03T01:08:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18510: fuzz: Add CScriptNum::getint coverage (master...2004-fuzzScriptNumGetInt) https://github.com/bitcoin/bitcoin/pull/18510
232020-04-03T01:08:07 *** bitcoin-git has left #bitcoin-core-dev
242020-04-03T01:08:33 *** promag has joined #bitcoin-core-dev
252020-04-03T01:12:54 *** promag has quit IRC
262020-04-03T01:19:27 *** afk11` has quit IRC
272020-04-03T01:19:52 *** afk11` has joined #bitcoin-core-dev
282020-04-03T01:28:54 *** promag has joined #bitcoin-core-dev
292020-04-03T01:31:43 *** stackingcore21 has joined #bitcoin-core-dev
302020-04-03T01:33:29 *** promag has quit IRC
312020-04-03T01:34:53 *** bitcoin-git has joined #bitcoin-core-dev
322020-04-03T01:34:53 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
332020-04-03T01:34:54 *** bitcoin-git has left #bitcoin-core-dev
342020-04-03T01:35:13 *** bitcoin-git has joined #bitcoin-core-dev
352020-04-03T01:35:13 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
362020-04-03T01:35:15 *** bitcoin-git has left #bitcoin-core-dev
372020-04-03T01:37:14 *** Chris_Stewart_5 has quit IRC
382020-04-03T01:38:01 *** Highway61 has quit IRC
392020-04-03T01:46:24 *** Emcy has quit IRC
402020-04-03T02:04:27 *** PaulTroon has joined #bitcoin-core-dev
412020-04-03T02:09:27 *** Dean_Guss has joined #bitcoin-core-dev
422020-04-03T02:09:47 *** PaulTroon has quit IRC
432020-04-03T02:09:54 *** meshcollider has quit IRC
442020-04-03T02:10:23 *** DeanWeen has quit IRC
452020-04-03T02:10:59 *** Emcy has joined #bitcoin-core-dev
462020-04-03T02:18:11 *** meshcollider has joined #bitcoin-core-dev
472020-04-03T02:20:22 *** bitcoin-git has joined #bitcoin-core-dev
482020-04-03T02:20:23 <bitcoin-git> [bitcoin] sipa opened pull request #18512: Improve asmap checks and add sanity check (master...202003_asmap_checks) https://github.com/bitcoin/bitcoin/pull/18512
492020-04-03T02:20:34 *** bitcoin-git has left #bitcoin-core-dev
502020-04-03T02:24:43 *** molz_ has quit IRC
512020-04-03T02:44:11 *** Deacyde has joined #bitcoin-core-dev
522020-04-03T02:58:30 <luke-jr> MarcoFalke: I have a working test for the bug #18192 fixes; should I leave it for another PR since it already has 2 ACKs?
532020-04-03T02:58:32 <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
542020-04-03T03:00:02 *** iMast777 has quit IRC
552020-04-03T03:16:58 *** pehjota1 has joined #bitcoin-core-dev
562020-04-03T03:36:29 *** mdunnio has joined #bitcoin-core-dev
572020-04-03T03:37:00 *** captjakk has quit IRC
582020-04-03T03:37:34 *** captjakk has joined #bitcoin-core-dev
592020-04-03T03:40:54 *** mdunnio has quit IRC
602020-04-03T03:42:18 *** captjakk has quit IRC
612020-04-03T03:44:24 *** captjakk has joined #bitcoin-core-dev
622020-04-03T03:51:36 *** AaronvanW has joined #bitcoin-core-dev
632020-04-03T03:52:10 *** EagleTM has joined #bitcoin-core-dev
642020-04-03T03:54:14 *** Eagle[TM] has quit IRC
652020-04-03T04:04:30 *** mdunnio has joined #bitcoin-core-dev
662020-04-03T04:04:56 *** mdunnio has quit IRC
672020-04-03T04:12:00 *** captjakk has quit IRC
682020-04-03T04:12:36 *** captjakk has joined #bitcoin-core-dev
692020-04-03T04:17:24 *** captjakk has quit IRC
702020-04-03T04:23:23 *** AaronvanW has quit IRC
712020-04-03T04:27:16 *** mol has joined #bitcoin-core-dev
722020-04-03T04:43:59 *** captjakk has joined #bitcoin-core-dev
732020-04-03T04:49:00 *** captjakk has quit IRC
742020-04-03T05:22:59 *** Kiminuo has quit IRC
752020-04-03T05:25:51 *** tryphe has joined #bitcoin-core-dev
762020-04-03T05:28:28 *** tryphe_ has quit IRC
772020-04-03T05:30:13 *** Kiminuo has joined #bitcoin-core-dev
782020-04-03T05:49:57 *** ddustin has joined #bitcoin-core-dev
792020-04-03T05:52:26 *** ddustin has quit IRC
802020-04-03T05:59:30 *** Highway61 has joined #bitcoin-core-dev
812020-04-03T06:00:02 *** pehjota1 has quit IRC
822020-04-03T06:05:41 *** PaulTroon has joined #bitcoin-core-dev
832020-04-03T06:10:54 *** PaulTroon has quit IRC
842020-04-03T06:12:13 *** jarthur_ has joined #bitcoin-core-dev
852020-04-03T06:15:46 *** jarthur has quit IRC
862020-04-03T06:19:23 *** kristapsk has quit IRC
872020-04-03T06:19:58 *** ToBeFree has joined #bitcoin-core-dev
882020-04-03T06:20:16 *** ToBeFree is now known as Guest52194
892020-04-03T06:20:24 *** AaronvanW has joined #bitcoin-core-dev
902020-04-03T06:25:26 *** jorijn has quit IRC
912020-04-03T06:28:42 *** jorijn has joined #bitcoin-core-dev
922020-04-03T06:36:49 *** jorijn has quit IRC
932020-04-03T06:37:55 *** jorijn has joined #bitcoin-core-dev
942020-04-03T06:44:52 *** captjakk has joined #bitcoin-core-dev
952020-04-03T06:44:54 *** mryandao has quit IRC
962020-04-03T06:45:22 *** mryandao has joined #bitcoin-core-dev
972020-04-03T06:49:15 *** captjakk has quit IRC
982020-04-03T06:53:00 *** AaronvanW has quit IRC
992020-04-03T06:54:40 *** jorijn has quit IRC
1002020-04-03T07:00:10 *** jorijn has joined #bitcoin-core-dev
1012020-04-03T07:04:29 *** dviola has joined #bitcoin-core-dev
1022020-04-03T07:05:12 *** PaulTroon has joined #bitcoin-core-dev
1032020-04-03T07:08:57 *** manantial has joined #bitcoin-core-dev
1042020-04-03T07:10:23 *** manantial has quit IRC
1052020-04-03T07:11:22 *** jorijn has quit IRC
1062020-04-03T07:12:09 *** manantial has joined #bitcoin-core-dev
1072020-04-03T07:15:53 *** lucaferr has joined #bitcoin-core-dev
1082020-04-03T07:19:09 *** jorijn has joined #bitcoin-core-dev
1092020-04-03T07:22:08 *** Talkless has joined #bitcoin-core-dev
1102020-04-03T07:23:34 *** jorijn has quit IRC
1112020-04-03T07:26:46 *** alec_ has joined #bitcoin-core-dev
1122020-04-03T07:27:23 *** alec has quit IRC
1132020-04-03T07:41:06 *** vasild_ has joined #bitcoin-core-dev
1142020-04-03T07:43:07 *** jorijn has joined #bitcoin-core-dev
1152020-04-03T07:44:03 *** vasild has quit IRC
1162020-04-03T07:44:04 *** vasild_ is now known as vasild
1172020-04-03T07:45:38 *** AaronvanW has joined #bitcoin-core-dev
1182020-04-03T07:51:24 *** emilengler has joined #bitcoin-core-dev
1192020-04-03T07:59:54 *** TheHoliestRoger has quit IRC
1202020-04-03T08:10:12 *** TheHoliestRoger has joined #bitcoin-core-dev
1212020-04-03T08:14:17 *** marcoagner has joined #bitcoin-core-dev
1222020-04-03T08:31:23 *** Dean_Guss has quit IRC
1232020-04-03T08:36:57 *** AaronvanW has quit IRC
1242020-04-03T08:37:12 *** AaronvanW has joined #bitcoin-core-dev
1252020-04-03T08:41:39 *** manantial has quit IRC
1262020-04-03T08:45:53 *** captjakk has joined #bitcoin-core-dev
1272020-04-03T08:47:38 *** timothy has joined #bitcoin-core-dev
1282020-04-03T08:50:09 *** captjakk has quit IRC
1292020-04-03T08:54:59 <jonatack> fanquake: see the edit message, "Removed "macOS does not yet support dark mode". I believe it does since at least 10.14.6 and Apple is aggressive in pushing updates. Feel free to revert/update if I'm wrong."
1302020-04-03T08:58:05 <jonatack> fanquake: also added release notes for the removal of the deprecated totalFee arg from rpc bumpfee, for rpc getpeerinfo now including "mapped_as" (mapped Asynchronous System) used for diversifying peer networking, and GUI Peers window now showing "Mapped AS" for the same.
1312020-04-03T09:00:01 *** Guest52194 has quit IRC
1322020-04-03T09:05:11 <fanquake> jonatack: it doesnât support dark mode, and we explicitly opt out. Donât think qt 5.9 supports dark mode in any case.
1332020-04-03T09:05:47 *** manantial has joined #bitcoin-core-dev
1342020-04-03T09:06:01 <fanquake> #14593
1352020-04-03T09:06:04 <gribble> https://github.com/bitcoin/bitcoin/issues/14593 | gui: explicitly disable "Dark Mode" appearance on macOS by fanquake · Pull Request #14593 · bitcoin/bitcoin · GitHub
1362020-04-03T09:14:40 *** ccdle12 has joined #bitcoin-core-dev
1372020-04-03T09:27:02 *** cycheng has joined #bitcoin-core-dev
1382020-04-03T09:34:32 *** molly has joined #bitcoin-core-dev
1392020-04-03T09:37:54 *** mol has quit IRC
1402020-04-03T09:39:50 *** promag has joined #bitcoin-core-dev
1412020-04-03T09:42:20 *** kristapsk has joined #bitcoin-core-dev
1422020-04-03T09:52:34 *** FunPika has joined #bitcoin-core-dev
1432020-04-03T10:03:59 *** Kelton24Gerlach has joined #bitcoin-core-dev
1442020-04-03T10:11:33 *** bitcoin-git has joined #bitcoin-core-dev
1452020-04-03T10:11:33 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dce6f3b29b41...6ec42df32b06
1462020-04-03T10:11:34 <bitcoin-git> bitcoin/master 332f373 Sebastian Falbesoner: [scripts] previous_release: improve failed download error message
1472020-04-03T10:11:35 <bitcoin-git> bitcoin/master 6ec42df fanquake: Merge #18426: scripts: previous_release: improve behaviour on failed downl...
1482020-04-03T10:11:36 *** bitcoin-git has left #bitcoin-core-dev
1492020-04-03T10:11:37 *** EagleTM has quit IRC
1502020-04-03T10:11:53 *** bitcoin-git has joined #bitcoin-core-dev
1512020-04-03T10:11:53 <bitcoin-git> [bitcoin] fanquake merged pull request #18426: scripts: previous_release: improve behaviour on failed download (master...20200324-scripts-previous-release-show-error-message-if-download-fails) https://github.com/bitcoin/bitcoin/pull/18426
1522020-04-03T10:11:54 *** bitcoin-git has left #bitcoin-core-dev
1532020-04-03T10:13:46 *** justanotheruser has quit IRC
1542020-04-03T10:17:38 *** bitcoin-git has joined #bitcoin-core-dev
1552020-04-03T10:17:39 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6ec42df32b06...d478595fad6e
1562020-04-03T10:17:39 <bitcoin-git> bitcoin/master d695eb4 Vasil Dimov: doc: note the costs of fetching all pull requests
1572020-04-03T10:17:40 <bitcoin-git> bitcoin/master d478595 fanquake: Merge #18382: doc: note the costs of fetching all pull requests
1582020-04-03T10:17:42 *** bitcoin-git has left #bitcoin-core-dev
1592020-04-03T10:17:58 *** bitcoin-git has joined #bitcoin-core-dev
1602020-04-03T10:17:58 <bitcoin-git> [bitcoin] fanquake merged pull request #18382: doc: note the costs of fetching all pull requests (master...note_fetch_all_cost) https://github.com/bitcoin/bitcoin/pull/18382
1612020-04-03T10:17:59 *** bitcoin-git has left #bitcoin-core-dev
1622020-04-03T10:21:49 *** molly has quit IRC
1632020-04-03T10:25:08 *** bitcoin-git has joined #bitcoin-core-dev
1642020-04-03T10:25:08 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d478595fad6e...be60e37e4041
1652020-04-03T10:25:09 <bitcoin-git> bitcoin/master 7b2975a Suriyaa Sundararuban: doc: Update webchat URLs in README.md
1662020-04-03T10:25:09 <bitcoin-git> bitcoin/master be60e37 fanquake: Merge #18505: doc: Update webchat URLs in README.md
1672020-04-03T10:25:11 *** bitcoin-git has left #bitcoin-core-dev
1682020-04-03T10:25:28 *** bitcoin-git has joined #bitcoin-core-dev
1692020-04-03T10:25:28 <bitcoin-git> [bitcoin] fanquake merged pull request #18505: doc: Update webchat URLs in README.md (master...update-webchat-urls) https://github.com/bitcoin/bitcoin/pull/18505
1702020-04-03T10:25:29 *** bitcoin-git has left #bitcoin-core-dev
1712020-04-03T10:30:40 *** cycheng has quit IRC
1722020-04-03T10:32:57 *** EagleTM has joined #bitcoin-core-dev
1732020-04-03T10:34:55 *** gets has joined #bitcoin-core-dev
1742020-04-03T10:36:14 *** gets has quit IRC
1752020-04-03T10:44:01 *** justanotheruser has joined #bitcoin-core-dev
1762020-04-03T10:46:44 *** alec_ is now known as alec
1772020-04-03T10:48:15 *** frogar has quit IRC
1782020-04-03T10:48:34 *** frogar has joined #bitcoin-core-dev
1792020-04-03T10:53:55 *** bitcoin-git has joined #bitcoin-core-dev
1802020-04-03T10:53:55 <bitcoin-git> [bitcoin] HashUnlimited opened pull request #18513: [doc] fix git add argument (master...master) https://github.com/bitcoin/bitcoin/pull/18513
1812020-04-03T10:53:56 *** bitcoin-git has left #bitcoin-core-dev
1822020-04-03T11:05:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1832020-04-03T11:09:05 *** mol has joined #bitcoin-core-dev
1842020-04-03T11:11:50 *** bitcoin-git has joined #bitcoin-core-dev
1852020-04-03T11:11:51 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/be60e37e4041...08c4994969be
1862020-04-03T11:11:51 <bitcoin-git> bitcoin/master fad2f68 MarcoFalke: init: Replace URL_WEBSITE with PACKAGE_URL
1872020-04-03T11:11:52 <bitcoin-git> bitcoin/master 08c4994 fanquake: Merge #18503: init: Replace URL_WEBSITE with PACKAGE_URL
1882020-04-03T11:12:02 *** bitcoin-git has left #bitcoin-core-dev
1892020-04-03T11:12:19 *** bitcoin-git has joined #bitcoin-core-dev
1902020-04-03T11:12:20 <bitcoin-git> [bitcoin] fanquake merged pull request #18503: init: Replace URL_WEBSITE with PACKAGE_URL (master...2004-initRebrand) https://github.com/bitcoin/bitcoin/pull/18503
1912020-04-03T11:12:20 *** bitcoin-git has left #bitcoin-core-dev
1922020-04-03T11:18:47 <jonatack> fanquake: thanks. i found the release notes surprising this time aroun, as i have an old 2012 macbook pro running a node on mojave 10.14.6 and qt 5.14.1 and dark mode looks good (not like in 14593). perhaps we should mention what versions of qt or macOS do/don't work
1932020-04-03T11:19:48 <fanquake> jonatack: that's expected. If you're self compiling, and just running src/qt/bitcoin-qt, it will work. If you run deploy and use the app bundle (as releases are built) it wont.
1942020-04-03T11:20:28 <fanquake> I don't think we need to mention anything more in the readme, as releases are not affected.
1952020-04-03T11:20:34 <fanquake> s/readme/release-notes
1962020-04-03T11:21:16 <jonatack> fanquake: ok. i'll revert the notes change then if you haven't already. here's what dark mode looks like for me: https://github.com/bitcoin/bitcoin/pull/16923#issuecomment-606770987
1972020-04-03T11:21:28 *** Kelton24Gerlach has quit IRC
1982020-04-03T11:26:22 <jonatack> fanquake: it says: "Additionally, Bitcoin Core does not yet change appearance when macOS "dark mode" is activated." -> what say you to appending ", except if compiling from source." or similar, for dummies like me :)
1992020-04-03T11:27:49 <jonatack> (done, reverted the removal)
2002020-04-03T11:29:54 *** bitcoin-git has joined #bitcoin-core-dev
2012020-04-03T11:29:54 <bitcoin-git> [bitcoin] fanquake opened pull request #18514: test: remove rapidcheck integration and tests (master...remove_rapidcheck) https://github.com/bitcoin/bitcoin/pull/18514
2022020-04-03T11:29:55 *** bitcoin-git has left #bitcoin-core-dev
2032020-04-03T11:32:05 *** bitcoin-git has joined #bitcoin-core-dev
2042020-04-03T11:32:05 <bitcoin-git> [bitcoin] Christewart closed pull request #14430: Add more property based tests for basic bitcoin data structures (master...add_tests_from_8469) https://github.com/bitcoin/bitcoin/pull/14430
2052020-04-03T11:32:07 *** bitcoin-git has left #bitcoin-core-dev
2062020-04-03T11:32:45 *** bitcoin-git has joined #bitcoin-core-dev
2072020-04-03T11:32:45 <bitcoin-git> [bitcoin] fanquake closed pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
2082020-04-03T11:32:51 *** bitcoin-git has left #bitcoin-core-dev
2092020-04-03T11:37:48 *** bitcoin-git has joined #bitcoin-core-dev
2102020-04-03T11:37:49 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/08c4994969be...f0d6487e2907
2112020-04-03T11:37:50 <bitcoin-git> bitcoin/master 4928a99 Michael Polzer: [doc] fix git add argument
2122020-04-03T11:37:51 <bitcoin-git> bitcoin/master f0d6487 fanquake: Merge #18513: doc: fix git add argument
2132020-04-03T11:37:53 *** bitcoin-git has left #bitcoin-core-dev
2142020-04-03T11:38:08 *** bitcoin-git has joined #bitcoin-core-dev
2152020-04-03T11:38:08 <bitcoin-git> [bitcoin] fanquake merged pull request #18513: doc: fix git add argument (master...master) https://github.com/bitcoin/bitcoin/pull/18513
2162020-04-03T11:38:09 *** bitcoin-git has left #bitcoin-core-dev
2172020-04-03T11:40:15 *** jonatack has quit IRC
2182020-04-03T11:45:21 *** jonatack has joined #bitcoin-core-dev
2192020-04-03T11:51:58 *** cycheng has joined #bitcoin-core-dev
2202020-04-03T12:00:01 *** FunPika has quit IRC
2212020-04-03T12:05:16 *** cycheng has quit IRC
2222020-04-03T12:06:27 *** mol has quit IRC
2232020-04-03T12:08:08 *** EagleTM has quit IRC
2242020-04-03T12:43:55 <instagibbs> provoostenator, change detection is not a "can I sign this" question, that's a "can I understand what's mine" question
2252020-04-03T12:44:48 <instagibbs> if the signer sees additional outputs going to stuff the wallet doesn't recognise/user has to look up, what's the damage
2262020-04-03T12:47:22 <instagibbs> As long as the user is prompted with useful information, I don't see what issue "eager" signing causes.
2272020-04-03T12:47:25 *** captjakk has joined #bitcoin-core-dev
2282020-04-03T12:51:08 *** dholbach has joined #bitcoin-core-dev
2292020-04-03T12:52:23 *** captjakk has quit IRC
2302020-04-03T13:03:37 *** MasterdonX has joined #bitcoin-core-dev
2312020-04-03T13:04:44 *** masterdonx2 has quit IRC
2322020-04-03T13:06:56 *** Victorsueca has quit IRC
2332020-04-03T13:07:59 *** EagleTM has joined #bitcoin-core-dev
2342020-04-03T13:11:29 *** mol has joined #bitcoin-core-dev
2352020-04-03T13:14:01 *** Victorsueca has joined #bitcoin-core-dev
2362020-04-03T13:18:34 *** Victorsueca has quit IRC
2372020-04-03T13:22:59 *** jarthur has joined #bitcoin-core-dev
2382020-04-03T13:25:04 *** Victorsueca has joined #bitcoin-core-dev
2392020-04-03T13:27:32 *** kljasdfvv has quit IRC
2402020-04-03T13:35:37 *** Victorsueca has quit IRC
2412020-04-03T13:40:33 *** michagogo has joined #bitcoin-core-dev
2422020-04-03T13:50:52 *** Victorsueca has joined #bitcoin-core-dev
2432020-04-03T13:54:36 *** cycheng has joined #bitcoin-core-dev
2442020-04-03T13:58:04 *** EagleTM has quit IRC
2452020-04-03T14:04:16 *** Highway61 has quit IRC
2462020-04-03T14:07:18 *** Kiminuo has quit IRC
2472020-04-03T14:11:36 *** Dean_Guss has joined #bitcoin-core-dev
2482020-04-03T14:11:45 *** Highway61 has joined #bitcoin-core-dev
2492020-04-03T14:16:41 *** captjakk has joined #bitcoin-core-dev
2502020-04-03T14:20:11 *** mol has quit IRC
2512020-04-03T14:22:35 *** mol has joined #bitcoin-core-dev
2522020-04-03T14:24:35 *** braydonf has quit IRC
2532020-04-03T14:25:04 *** braydonf has joined #bitcoin-core-dev
2542020-04-03T14:25:12 *** Deacyde has quit IRC
2552020-04-03T14:35:52 *** mol has quit IRC
2562020-04-03T14:41:01 *** mol has joined #bitcoin-core-dev
2572020-04-03T14:44:21 *** bitcoin-git has joined #bitcoin-core-dev
2582020-04-03T14:44:21 <bitcoin-git> [bitcoin] theStack opened pull request #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py (master...20200403-test-check-for-CVE20135700-vuln-in-bip37-tests) https://github.com/bitcoin/bitcoin/pull/18515
2592020-04-03T14:44:22 *** bitcoin-git has left #bitcoin-core-dev
2602020-04-03T14:45:26 *** ccdle12 has quit IRC
2612020-04-03T14:46:59 *** Guyver2 has joined #bitcoin-core-dev
2622020-04-03T14:48:33 *** molly has joined #bitcoin-core-dev
2632020-04-03T14:50:36 <gleb> I just hanged the process (it's stuck for minutes) by sending SIGINT multiple times during "FlushStateToDisk: write coins cache". Is this expected? :)
2642020-04-03T14:52:04 *** mol has quit IRC
2652020-04-03T14:54:20 <vasild> What is it doing?
2662020-04-03T14:58:25 <gleb> It's just stuck with that line being last in the logs forever. I then used "kill -9" to kill the process.
2672020-04-03T14:59:48 <vasild> SIGINT would cause StartShutdown() to be called which only sets a boolean fRequestShutdown to true. Shouldn't cause issues if executed multiple times.
2682020-04-03T15:00:02 *** dholbach has quit IRC
2692020-04-03T15:00:44 <vasild> If its possible to reproduce then maybe try to attach gdb and see what it is doing.
2702020-04-03T15:03:16 <gleb> I was more generally curious, if I see something like this, is it a worthy bug looking at? I don't have an intuition about the expectations in a case like this. If it is, I'll try to reproduce and take a closer look.
2712020-04-03T15:03:18 <vasild> maybe some of the writes or flushes being executed gets interrupted due to the (second) signal arrival and the code mishandles that?
2722020-04-03T15:05:03 <vasild> Any hang looks like a (serious) bug to me. In a sense maybe even worse than a crash because in a crash the user or some automated system can detect it and start it again.
2732020-04-03T15:05:33 *** ccdle12 has joined #bitcoin-core-dev
2742020-04-03T15:07:22 *** Victorsueca has quit IRC
2752020-04-03T15:08:30 *** andrewtoth has joined #bitcoin-core-dev
2762020-04-03T15:08:50 *** molly has quit IRC
2772020-04-03T15:10:15 *** justanotheruser has quit IRC
2782020-04-03T15:12:38 *** dr-orlovsky has joined #bitcoin-core-dev
2792020-04-03T15:13:46 *** Victorsueca has joined #bitcoin-core-dev
2802020-04-03T15:15:49 *** emilengler has quit IRC
2812020-04-03T15:16:16 *** emilengler has joined #bitcoin-core-dev
2822020-04-03T15:18:27 *** Victorsueca has quit IRC
2832020-04-03T15:19:45 *** mol has joined #bitcoin-core-dev
2842020-04-03T15:19:48 <wumpus> it's worth reporting though if it's not easy to reproduce, *please* add information, such as where in the code it hangs (e.g. gdb output)
2852020-04-03T15:21:47 <wumpus> always get a backtrace when there's a hang
2862020-04-03T15:22:05 *** matael1 has joined #bitcoin-core-dev
2872020-04-03T15:24:02 *** Victorsueca has joined #bitcoin-core-dev
2882020-04-03T15:25:47 *** justanotheruser has joined #bitcoin-core-dev
2892020-04-03T15:26:26 *** bitcoin-git has joined #bitcoin-core-dev
2902020-04-03T15:26:26 <bitcoin-git> [bitcoin] jonatack opened pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
2912020-04-03T15:26:27 *** bitcoin-git has left #bitcoin-core-dev
2922020-04-03T15:33:46 *** Victorsueca has quit IRC
2932020-04-03T15:37:18 *** belcher has joined #bitcoin-core-dev
2942020-04-03T15:43:11 *** EagleTM has joined #bitcoin-core-dev
2952020-04-03T15:45:12 *** Highway61 has quit IRC
2962020-04-03T15:45:34 *** Highway61 has joined #bitcoin-core-dev
2972020-04-03T15:49:13 *** Kiminuo has joined #bitcoin-core-dev
2982020-04-03T15:56:35 *** Guyver2_ has joined #bitcoin-core-dev
2992020-04-03T15:58:22 *** Guyver2 has quit IRC
3002020-04-03T16:04:52 *** cycheng has quit IRC
3012020-04-03T16:05:36 *** AaronvanW has quit IRC
3022020-04-03T16:54:05 *** jarthur has quit IRC
3032020-04-03T16:55:12 *** jarthur has joined #bitcoin-core-dev
3042020-04-03T17:03:25 *** AaronvanW has joined #bitcoin-core-dev
3052020-04-03T17:28:06 *** captjakk has quit IRC
3062020-04-03T17:28:38 *** captjakk has joined #bitcoin-core-dev
3072020-04-03T17:30:25 *** bitcoin-git has joined #bitcoin-core-dev
3082020-04-03T17:30:26 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18518: fuzz: Extend descriptor fuzz test (master...2004-fuzDesc) https://github.com/bitcoin/bitcoin/pull/18518
3092020-04-03T17:30:27 *** bitcoin-git has left #bitcoin-core-dev
3102020-04-03T17:33:23 *** bitcoin-git has joined #bitcoin-core-dev
3112020-04-03T17:33:23 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18519: fuzz: Extend script fuzz test (master...2004-fuzzScript) https://github.com/bitcoin/bitcoin/pull/18519
3122020-04-03T17:33:24 *** bitcoin-git has left #bitcoin-core-dev
3132020-04-03T17:35:51 *** captjakk has quit IRC
3142020-04-03T17:36:07 *** captjakk has joined #bitcoin-core-dev
3152020-04-03T17:48:30 *** sdaftuar_ has quit IRC
3162020-04-03T17:49:10 *** sdaftuar_ has joined #bitcoin-core-dev
3172020-04-03T17:50:26 *** theStack has quit IRC
3182020-04-03T17:50:47 *** ghost43 has quit IRC
3192020-04-03T17:51:07 *** ghost43 has joined #bitcoin-core-dev
3202020-04-03T17:52:04 *** ddustin has joined #bitcoin-core-dev
3212020-04-03T17:53:07 *** ddustin has quit IRC
3222020-04-03T17:57:55 *** ddustin has joined #bitcoin-core-dev
3232020-04-03T18:00:02 *** matael1 has quit IRC
3242020-04-03T18:14:56 *** Chris_Stewart_5 has quit IRC
3252020-04-03T18:20:20 *** Snuupy1 has joined #bitcoin-core-dev
3262020-04-03T18:21:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3272020-04-03T18:25:55 *** jb55 has quit IRC
3282020-04-03T18:28:16 *** jb55 has joined #bitcoin-core-dev
3292020-04-03T18:30:33 *** jb55 has quit IRC
3302020-04-03T18:31:51 *** ghost43 has quit IRC
3312020-04-03T18:32:59 *** ghost43 has joined #bitcoin-core-dev
3322020-04-03T18:40:05 *** jb55 has joined #bitcoin-core-dev
3332020-04-03T19:02:54 *** owowo has quit IRC
3342020-04-03T19:04:19 *** molly has joined #bitcoin-core-dev
3352020-04-03T19:06:50 *** mol has quit IRC
3362020-04-03T19:07:43 *** owowo has joined #bitcoin-core-dev
3372020-04-03T19:07:44 *** owowo has joined #bitcoin-core-dev
3382020-04-03T19:09:53 *** bitcoin-git has joined #bitcoin-core-dev
3392020-04-03T19:09:53 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f0d6487e2907...e35e118656e9
3402020-04-03T19:09:54 <bitcoin-git> bitcoin/master eca65ca Luke Dashjr: Bugfix: RPC: Add missing commas and correct indentation of explicit ELISION
3412020-04-03T19:09:54 <bitcoin-git> bitcoin/master 26dcf39 Luke Dashjr: Bugfix: RPC: Don't use a continuation elipsis after an elision elipsis
3422020-04-03T19:09:55 <bitcoin-git> bitcoin/master f32ab44 Luke Dashjr: Bugfix: RPC: JSON null is not "None"
3432020-04-03T19:09:56 *** bitcoin-git has left #bitcoin-core-dev
3442020-04-03T19:10:13 *** bitcoin-git has joined #bitcoin-core-dev
3452020-04-03T19:10:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18508: RPC: Fix more formatting nits (master...rpcdoc_format_20200402) https://github.com/bitcoin/bitcoin/pull/18508
3462020-04-03T19:10:14 *** bitcoin-git has left #bitcoin-core-dev
3472020-04-03T19:16:40 *** bitcoin-git has joined #bitcoin-core-dev
3482020-04-03T19:16:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e35e118656e9...c8971547d9c9
3492020-04-03T19:16:41 <bitcoin-git> bitcoin/master fab3255 MarcoFalke: rpc: Make rpc documentation not depend on rpc args
3502020-04-03T19:16:41 <bitcoin-git> bitcoin/master c897154 MarcoFalke: Merge #18499: rpc: Make rpc documentation not depend on call-time rpc args...
3512020-04-03T19:16:42 *** bitcoin-git has left #bitcoin-core-dev
3522020-04-03T19:16:56 *** bitcoin-git has joined #bitcoin-core-dev
3532020-04-03T19:16:57 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18499: rpc: Make rpc documentation not depend on call-time rpc args (master...2004-rpcStaticDoc) https://github.com/bitcoin/bitcoin/pull/18499
3542020-04-03T19:16:57 *** bitcoin-git has left #bitcoin-core-dev
3552020-04-03T19:38:03 *** vaibs26 has joined #bitcoin-core-dev
3562020-04-03T19:40:59 *** vasild_ has joined #bitcoin-core-dev
3572020-04-03T19:43:59 *** andrewtoth has quit IRC
3582020-04-03T19:44:23 *** vasild has quit IRC
3592020-04-03T19:44:24 *** vasild_ is now known as vasild
3602020-04-03T19:44:40 *** andrewtoth has joined #bitcoin-core-dev
3612020-04-03T19:47:51 *** vaibs26 has quit IRC
3622020-04-03T19:48:15 *** guest534543 has joined #bitcoin-core-dev
3632020-04-03T19:50:32 *** jarthur_ has joined #bitcoin-core-dev
3642020-04-03T19:51:25 *** Kiminuo has quit IRC
3652020-04-03T19:53:59 *** jarthur has quit IRC
3662020-04-03T19:59:37 *** Guyver2_ has quit IRC
3672020-04-03T20:09:20 *** captjakk has quit IRC
3682020-04-03T20:09:55 *** captjakk has joined #bitcoin-core-dev
3692020-04-03T20:10:21 *** ghost43 has quit IRC
3702020-04-03T20:11:50 *** ghost43 has joined #bitcoin-core-dev
3712020-04-03T20:13:45 *** andrewtoth has quit IRC
3722020-04-03T20:13:49 *** andrewtoth_ has joined #bitcoin-core-dev
3732020-04-03T20:14:35 *** captjakk has quit IRC
3742020-04-03T20:16:39 *** jarthur_ is now known as jarthur
3752020-04-03T20:18:34 *** justanotheruser has quit IRC
3762020-04-03T20:18:58 *** captjakk has joined #bitcoin-core-dev
3772020-04-03T20:19:41 *** stackingcore21 has joined #bitcoin-core-dev
3782020-04-03T20:35:16 *** ddustin has quit IRC
3792020-04-03T20:37:05 *** ddustin has joined #bitcoin-core-dev
3802020-04-03T20:41:57 *** ddustin has quit IRC
3812020-04-03T20:56:00 *** ghost43 has quit IRC
3822020-04-03T20:56:20 *** ghost43 has joined #bitcoin-core-dev
3832020-04-03T21:00:02 *** Snuupy1 has quit IRC
3842020-04-03T21:02:46 *** PaulTroon has quit IRC
3852020-04-03T21:13:25 *** promag has quit IRC
3862020-04-03T21:15:23 *** Highway61 has quit IRC
3872020-04-03T21:16:33 *** Highway61 has joined #bitcoin-core-dev
3882020-04-03T21:16:55 *** Highway61 has quit IRC
3892020-04-03T21:17:16 *** Highway61 has joined #bitcoin-core-dev
3902020-04-03T21:18:57 *** emilengler has quit IRC
3912020-04-03T21:20:48 *** manantial has quit IRC
3922020-04-03T21:21:58 *** lugosi1 has joined #bitcoin-core-dev
3932020-04-03T21:22:25 *** promag has joined #bitcoin-core-dev
3942020-04-03T21:24:03 *** bitcoin-git has joined #bitcoin-core-dev
3952020-04-03T21:24:03 <bitcoin-git> [bitcoin] theStack opened pull request #18520: test: remaining replacements of (send_message+sync_with_ping) with send_and_ping (master...20200403-test-remaining-send_and_ping-substitutes) https://github.com/bitcoin/bitcoin/pull/18520
3962020-04-03T21:24:04 *** bitcoin-git has left #bitcoin-core-dev
3972020-04-03T21:25:25 *** ddustin has joined #bitcoin-core-dev
3982020-04-03T21:30:22 *** filchef has joined #bitcoin-core-dev
3992020-04-03T21:34:52 *** promag has quit IRC
4002020-04-03T21:35:47 *** Highway61 has quit IRC
4012020-04-03T21:36:35 *** Highway61 has joined #bitcoin-core-dev
4022020-04-03T21:50:10 <fjahr> Just repeating it here in case someone is missing it on Twitter: there are fishing emails going around seemingly targeting email addresses from Github commits, made to look like official emails from Github. At least some of them seem to get around spam filters. Some topics I got: "Activate your account", "Accept Terms of Service change", "Complete your profile" etc.
4032020-04-03T21:50:18 *** promag has joined #bitcoin-core-dev
4042020-04-03T21:51:16 <sipa> fjahr: i just got a "File has been modified from your private repository"
4052020-04-03T21:55:07 *** promag has quit IRC
4062020-04-03T21:56:18 *** jarthur has quit IRC
4072020-04-03T21:56:32 <jonatack> same. strange sender address was the tip-off: "Support Github app71076620@skydropx.com via sendgrid.me". stay alert.
4082020-04-03T22:04:46 *** Talkless has quit IRC
4092020-04-03T22:10:59 <gwillen> jonatack: if you have one of those in your inbox, and it appears to be genuinely coming via sendgrid, you should forward it to their abuse address
4102020-04-03T22:11:06 <gwillen> so they can take out the sender's account
4112020-04-03T22:11:48 <gwillen> I'm not consistent about reporting stuff like this because there's just too much of it, but if it's worth a warning it's probably worth a report
4122020-04-03T22:12:30 *** Dean_Guss has quit IRC
4132020-04-03T22:12:44 *** Dean_Guss has joined #bitcoin-core-dev
4142020-04-03T22:22:49 *** jarthur has joined #bitcoin-core-dev
4152020-04-03T22:23:45 *** jarthur has quit IRC
4162020-04-03T22:24:02 *** Murch has quit IRC
4172020-04-03T22:24:11 *** jarthur has joined #bitcoin-core-dev
4182020-04-03T22:33:57 *** ddustin has quit IRC
4192020-04-03T22:40:23 *** sdaftuar_ has quit IRC
4202020-04-03T22:42:15 *** sdaftuar_ has joined #bitcoin-core-dev
4212020-04-03T22:57:15 *** ddustin has joined #bitcoin-core-dev
4222020-04-03T23:03:56 *** ddustin has quit IRC
4232020-04-03T23:06:23 *** timothy has quit IRC
4242020-04-03T23:14:57 *** jarthur_ has joined #bitcoin-core-dev
4252020-04-03T23:17:44 *** jarthur__ has joined #bitcoin-core-dev
4262020-04-03T23:17:51 *** jarthur__ has quit IRC
4272020-04-03T23:18:52 *** jarthur has quit IRC
4282020-04-03T23:21:12 *** jarthur_ has quit IRC
4292020-04-03T23:22:58 *** Chris_Stewart_5 has quit IRC
4302020-04-03T23:38:54 *** justanotheruser has joined #bitcoin-core-dev
4312020-04-03T23:51:30 *** ddustin has joined #bitcoin-core-dev
4322020-04-03T23:55:15 *** promag has joined #bitcoin-core-dev
4332020-04-03T23:57:22 *** ddustin has quit IRC