12020-05-13T00:00:02 *** cassier has quit IRC
22020-05-13T00:00:54 *** dfmb_ has quit IRC
32020-05-13T00:06:10 *** tryphe__ has joined #bitcoin-core-dev
42020-05-13T00:06:37 *** tryphe_ has quit IRC
52020-05-13T00:08:31 *** lightlike has quit IRC
62020-05-13T00:10:56 *** Luke has joined #bitcoin-core-dev
72020-05-13T00:13:04 *** promag has quit IRC
82020-05-13T00:22:09 *** bstarr has joined #bitcoin-core-dev
92020-05-13T00:40:58 *** proofofkeags has quit IRC
102020-05-13T00:41:33 *** proofofkeags has joined #bitcoin-core-dev
112020-05-13T00:44:18 *** mol has quit IRC
122020-05-13T00:44:32 *** promag has joined #bitcoin-core-dev
132020-05-13T00:46:21 *** proofofkeags has quit IRC
142020-05-13T00:46:26 *** surja795 has joined #bitcoin-core-dev
152020-05-13T00:57:14 *** promag has quit IRC
162020-05-13T01:00:54 *** AaronvanW has quit IRC
172020-05-13T01:02:17 *** Luke has quit IRC
182020-05-13T01:09:27 *** tryphe__ is now known as tryphe
192020-05-13T01:11:10 *** proofofkeags has joined #bitcoin-core-dev
202020-05-13T01:25:28 *** Highway61 has quit IRC
212020-05-13T01:48:57 *** mol_ has joined #bitcoin-core-dev
222020-05-13T02:03:33 *** bitdex has joined #bitcoin-core-dev
232020-05-13T02:15:23 *** bitcoin-git has joined #bitcoin-core-dev
242020-05-13T02:15:23 <bitcoin-git> [bitcoin] 10xcryptodev opened pull request #18965: tests: implement base58_decode (master...tests_base58decode) https://github.com/bitcoin/bitcoin/pull/18965
252020-05-13T02:15:25 *** bitcoin-git has left #bitcoin-core-dev
262020-05-13T02:26:12 *** geeker has quit IRC
272020-05-13T02:37:43 *** shesek has quit IRC
282020-05-13T02:38:11 *** shesek has joined #bitcoin-core-dev
292020-05-13T02:38:11 *** promag_ has quit IRC
302020-05-13T02:38:11 *** shesek has quit IRC
312020-05-13T02:38:11 *** shesek has joined #bitcoin-core-dev
322020-05-13T02:38:41 *** promag has joined #bitcoin-core-dev
332020-05-13T02:39:21 *** promag has joined #bitcoin-core-dev
342020-05-13T02:41:09 *** Chris_Stewart_5 has quit IRC
352020-05-13T02:42:03 *** jarthur has quit IRC
362020-05-13T02:53:12 *** molz_ has joined #bitcoin-core-dev
372020-05-13T02:56:58 *** mol_ has quit IRC
382020-05-13T03:00:02 *** bstarr has quit IRC
392020-05-13T03:05:48 *** Eagle[TM] has joined #bitcoin-core-dev
402020-05-13T03:06:18 *** EagleTM has quit IRC
412020-05-13T03:18:51 *** Xing`1 has joined #bitcoin-core-dev
422020-05-13T03:25:26 *** surja795 has quit IRC
432020-05-13T03:30:44 *** tryphe_ has joined #bitcoin-core-dev
442020-05-13T03:31:15 *** tryphe has quit IRC
452020-05-13T03:32:31 *** surja795 has joined #bitcoin-core-dev
462020-05-13T03:35:43 *** tryphe_ has quit IRC
472020-05-13T03:37:15 *** surja795 has quit IRC
482020-05-13T04:16:08 *** jnewbery has quit IRC
492020-05-13T04:16:45 *** proofofkeags has quit IRC
502020-05-13T04:17:21 *** proofofkeags has joined #bitcoin-core-dev
512020-05-13T04:19:58 *** vasild_ has joined #bitcoin-core-dev
522020-05-13T04:21:44 *** proofofkeags has quit IRC
532020-05-13T04:23:03 *** vasild has quit IRC
542020-05-13T04:23:04 *** vasild_ is now known as vasild
552020-05-13T04:32:33 *** jnewbery has joined #bitcoin-core-dev
562020-05-13T04:34:07 *** ppisati has quit IRC
572020-05-13T04:40:48 *** ppisati has joined #bitcoin-core-dev
582020-05-13T04:58:52 *** mol_ has joined #bitcoin-core-dev
592020-05-13T05:01:47 *** molz_ has quit IRC
602020-05-13T05:10:10 *** proofofkeags has joined #bitcoin-core-dev
612020-05-13T05:14:43 *** proofofkeags has quit IRC
622020-05-13T05:33:09 *** mol_ has quit IRC
632020-05-13T05:33:31 *** mol_ has joined #bitcoin-core-dev
642020-05-13T05:59:21 *** Highway61 has joined #bitcoin-core-dev
652020-05-13T06:00:02 *** Xing`1 has quit IRC
662020-05-13T06:01:14 *** manantial has joined #bitcoin-core-dev
672020-05-13T06:17:23 *** Greedi has joined #bitcoin-core-dev
682020-05-13T06:24:38 *** promag_ has joined #bitcoin-core-dev
692020-05-13T06:24:42 *** promag has quit IRC
702020-05-13T06:25:54 *** promag has joined #bitcoin-core-dev
712020-05-13T06:25:54 *** promag_ has quit IRC
722020-05-13T06:27:09 *** Guyver2 has joined #bitcoin-core-dev
732020-05-13T06:28:19 *** vasild has quit IRC
742020-05-13T06:28:31 *** vasild has joined #bitcoin-core-dev
752020-05-13T06:41:01 *** tmoc has joined #bitcoin-core-dev
762020-05-13T07:08:07 *** harrigan has quit IRC
772020-05-13T07:10:47 *** harrigan has joined #bitcoin-core-dev
782020-05-13T07:18:34 *** exhoplex1 has quit IRC
792020-05-13T07:18:42 *** Guyver2 has quit IRC
802020-05-13T07:19:27 *** exhoplex has quit IRC
812020-05-13T07:19:36 *** bitcoin-git has joined #bitcoin-core-dev
822020-05-13T07:19:38 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8da1e43b63cb...219c55da752d
832020-05-13T07:19:38 <bitcoin-git> bitcoin/master de5e91c Hennadii Stepanov: refactor: Add BerkeleyDatabaseVersion() function
842020-05-13T07:19:39 <bitcoin-git> bitcoin/master 839add1 Hennadii Stepanov: build: Enable -Wsuggest-override
852020-05-13T07:19:39 <bitcoin-git> bitcoin/master 219c55d fanquake: Merge #16710: build: Enable -Wsuggest-override if available
862020-05-13T07:19:40 *** bitcoin-git has left #bitcoin-core-dev
872020-05-13T07:20:58 *** bitcoin-git has joined #bitcoin-core-dev
882020-05-13T07:20:58 <bitcoin-git> [bitcoin] fanquake merged pull request #16710: build: Enable -Wsuggest-override if available (master...20190824-consistent-override) https://github.com/bitcoin/bitcoin/pull/16710
892020-05-13T07:20:59 *** bitcoin-git has left #bitcoin-core-dev
902020-05-13T07:36:51 *** emilengler has joined #bitcoin-core-dev
912020-05-13T07:40:14 *** luke-jr has quit IRC
922020-05-13T07:43:25 *** Eagle[TM] has quit IRC
932020-05-13T07:46:49 *** tmoc has quit IRC
942020-05-13T07:50:35 *** marcoagner has joined #bitcoin-core-dev
952020-05-13T08:00:51 *** luke-jr has joined #bitcoin-core-dev
962020-05-13T08:05:54 *** luke-jr has quit IRC
972020-05-13T08:07:20 *** go121212 has joined #bitcoin-core-dev
982020-05-13T08:10:02 *** go11111111111 has quit IRC
992020-05-13T08:13:50 *** bitcoin-git has joined #bitcoin-core-dev
1002020-05-13T08:13:50 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/219c55da752d...8d17f8dc1773
1012020-05-13T08:13:51 <bitcoin-git> bitcoin/master e8123ea João Barbosa: gui: Fix itemWalletAddress leak when not tree mode
1022020-05-13T08:13:51 <bitcoin-git> bitcoin/master 8d17f8d Jonas Schnelli: Merge #18578: gui: Fix leak in CoinControlDialog::updateView
1032020-05-13T08:13:53 *** bitcoin-git has left #bitcoin-core-dev
1042020-05-13T08:14:25 *** bitcoin-git has joined #bitcoin-core-dev
1052020-05-13T08:14:25 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18578: gui: Fix leak in CoinControlDialog::updateView (master...2020-fix-coincontroldialog-leak) https://github.com/bitcoin/bitcoin/pull/18578
1062020-05-13T08:14:26 *** bitcoin-git has left #bitcoin-core-dev
1072020-05-13T08:16:12 *** bitcoin-git has joined #bitcoin-core-dev
1082020-05-13T08:16:12 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d17f8dc1773...246e878e7845
1092020-05-13T08:16:13 <bitcoin-git> bitcoin/master a8b5f1b João Barbosa: gui: Fix manual coin control with multiple wallets loaded
1102020-05-13T08:16:13 <bitcoin-git> bitcoin/master 246e878 Jonas Schnelli: Merge #18894: gui: Fix manual coin control with multiple wallets loaded
1112020-05-13T08:16:14 *** bitcoin-git has left #bitcoin-core-dev
1122020-05-13T08:16:32 *** bitcoin-git has joined #bitcoin-core-dev
1132020-05-13T08:16:32 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894
1142020-05-13T08:16:34 *** bitcoin-git has left #bitcoin-core-dev
1152020-05-13T08:27:55 *** promag_ has joined #bitcoin-core-dev
1162020-05-13T08:27:56 *** emilengler has joined #bitcoin-core-dev
1172020-05-13T08:28:09 *** luke-jr has joined #bitcoin-core-dev
1182020-05-13T08:48:37 *** timothy has joined #bitcoin-core-dev
1192020-05-13T08:57:51 *** promag_ has quit IRC
1202020-05-13T09:00:01 *** Greedi has quit IRC
1212020-05-13T09:05:52 *** promag has quit IRC
1222020-05-13T09:06:08 *** promag has joined #bitcoin-core-dev
1232020-05-13T09:10:54 *** promag has quit IRC
1242020-05-13T09:11:30 *** promag has joined #bitcoin-core-dev
1252020-05-13T09:12:01 *** mol_ has quit IRC
1262020-05-13T09:21:38 *** fajro has joined #bitcoin-core-dev
1272020-05-13T09:34:05 *** Victorsueca has quit IRC
1282020-05-13T09:36:37 *** bitcoin-git has joined #bitcoin-core-dev
1292020-05-13T09:36:38 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/246e878e7845...a33901cb6d82
1302020-05-13T09:36:38 <bitcoin-git> bitcoin/master a2e6db5 João Barbosa: rpc: Add mutex to guard deadlineTimers
1312020-05-13T09:36:38 <bitcoin-git> bitcoin/master 9f59dde João Barbosa: rpc: Relock wallet only if most recent callback
1322020-05-13T09:36:39 <bitcoin-git> bitcoin/master a33901c fanquake: Merge #18814: rpc: Relock wallet only if most recent callback
1332020-05-13T09:36:41 *** bitcoin-git has left #bitcoin-core-dev
1342020-05-13T09:36:56 *** bitcoin-git has joined #bitcoin-core-dev
1352020-05-13T09:36:56 <bitcoin-git> [bitcoin] fanquake merged pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814
1362020-05-13T09:37:07 *** bitcoin-git has left #bitcoin-core-dev
1372020-05-13T09:52:53 *** cataly5m7 has quit IRC
1382020-05-13T09:53:17 *** cataly5m has joined #bitcoin-core-dev
1392020-05-13T09:54:20 *** promag has quit IRC
1402020-05-13T09:54:34 *** promag has joined #bitcoin-core-dev
1412020-05-13T10:01:42 *** cataly5m is now known as m1rror
1422020-05-13T10:02:42 *** braydonf has quit IRC
1432020-05-13T10:03:11 *** braydonf has joined #bitcoin-core-dev
1442020-05-13T10:09:29 <midnight> sipa: I'm getting a kick out of how you're just did it in Perl and C.
1452020-05-13T10:14:16 *** promag_ has joined #bitcoin-core-dev
1462020-05-13T10:14:16 *** promag has quit IRC
1472020-05-13T10:15:39 *** AaronvanW has joined #bitcoin-core-dev
1482020-05-13T10:21:45 *** EagleTM has joined #bitcoin-core-dev
1492020-05-13T10:27:53 *** Rikudouainsoph has joined #bitcoin-core-dev
1502020-05-13T10:42:07 *** AaronvanW has quit IRC
1512020-05-13T10:43:03 *** jb55 has quit IRC
1522020-05-13T10:45:15 *** surja795 has joined #bitcoin-core-dev
1532020-05-13T10:55:17 *** jb55 has joined #bitcoin-core-dev
1542020-05-13T11:00:56 *** jb55 has quit IRC
1552020-05-13T11:02:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1562020-05-13T11:05:05 *** EagleTM has quit IRC
1572020-05-13T11:06:05 *** jb55 has joined #bitcoin-core-dev
1582020-05-13T11:07:38 *** IGHOR has quit IRC
1592020-05-13T11:13:41 *** IGHOR has joined #bitcoin-core-dev
1602020-05-13T11:16:03 *** jb55 has quit IRC
1612020-05-13T11:18:09 *** Dean_Guss has joined #bitcoin-core-dev
1622020-05-13T11:19:23 *** DeanWeen has quit IRC
1632020-05-13T11:20:39 *** Izl has joined #bitcoin-core-dev
1642020-05-13T11:21:14 *** mol has joined #bitcoin-core-dev
1652020-05-13T11:24:21 *** jb55 has joined #bitcoin-core-dev
1662020-05-13T11:39:06 *** bitdex has quit IRC
1672020-05-13T11:48:29 *** mol has quit IRC
1682020-05-13T11:52:55 *** Dean_Guss has quit IRC
1692020-05-13T11:53:04 *** DeanWeen has joined #bitcoin-core-dev
1702020-05-13T11:56:32 *** promag_ has quit IRC
1712020-05-13T11:57:07 *** promag has joined #bitcoin-core-dev
1722020-05-13T12:00:02 *** fajro has quit IRC
1732020-05-13T12:02:10 *** Rikudouainsoph has quit IRC
1742020-05-13T12:05:11 *** thanks has joined #bitcoin-core-dev
1752020-05-13T12:07:43 *** thanks has quit IRC
1762020-05-13T12:09:11 *** proofofkeags has joined #bitcoin-core-dev
1772020-05-13T12:11:25 *** dfmb_ has joined #bitcoin-core-dev
1782020-05-13T12:13:56 *** EagleTM has joined #bitcoin-core-dev
1792020-05-13T12:14:01 *** proofofkeags has quit IRC
1802020-05-13T12:21:55 *** kierra has joined #bitcoin-core-dev
1812020-05-13T12:22:14 *** kierra is now known as Guest67738
1822020-05-13T12:22:51 *** mol has joined #bitcoin-core-dev
1832020-05-13T12:26:32 *** AaronvanW has joined #bitcoin-core-dev
1842020-05-13T12:34:57 *** Rikudouainsoph has joined #bitcoin-core-dev
1852020-05-13T12:35:48 *** luke-jr has quit IRC
1862020-05-13T12:42:17 *** luke-jr has joined #bitcoin-core-dev
1872020-05-13T12:50:03 *** afk11` has quit IRC
1882020-05-13T12:50:29 *** afk11` has joined #bitcoin-core-dev
1892020-05-13T12:52:14 *** EagleTM has quit IRC
1902020-05-13T12:53:15 <wumpus> meshcollider: I think the run-time "is this WSL" detection raised a few eyebrows
1912020-05-13T13:02:27 <jonasschnelli> Wasn't #18877 rather a quick merge for a impactful p2p change? Just a 7 day window?
1922020-05-13T13:02:30 <gribble> https://github.com/bitcoin/bitcoin/issues/18877 | Serve cfcheckpt requests by jnewbery · Pull Request #18877 · bitcoin/bitcoin · GitHub
1932020-05-13T13:03:09 <wumpus> it's a fast turnaround for sure
1942020-05-13T13:03:30 <wumpus> though otoh it did get a lot of review, and it's an optional thing disabled by default
1952020-05-13T13:04:26 <jonasschnelli> Yes. I agree. Just it looks like there is no clear conceptual ACK on serving filters after BIP157 (don't get me wrong, I'm all for serving BIP157).
1962020-05-13T13:04:50 <jonasschnelli> I just think 6 days was to short for a reasonable discussion
1972020-05-13T13:05:30 *** Rikudouainsoph has quit IRC
1982020-05-13T13:05:49 <wumpus> but it's sure very fast given that we're kind of in slow times
1992020-05-13T13:08:24 <fanquake> ðï¸
2002020-05-13T13:09:22 <fanquake> One thing that's not getting faster is how long it takes to run all 160 tests of the functional test suite
2012020-05-13T13:09:36 <wumpus> luke-jr: look, I disagree, personally I'd prefer not to include to autogenerated cruft at all, and there's more people that don't, so I don't see it as a regression. Spliting up the PR makes sure there is at least progress on parts that we do agree on. IF that isn't a positive thing I honestly don't know.
2022020-05-13T13:10:27 *** Highway61 has quit IRC
2032020-05-13T13:10:32 <jonasschnelli> ðð
2042020-05-13T13:11:21 <jonatack> jonasschnelli: the conceptual discussion is ongoing (at least for me) on bip157, but the changes in that PR didn't seem dangerous on their own after reviewing them, and reversible before the next release
2052020-05-13T13:12:05 <jonasschnelli> jonatack: I agree. Though an progressive merge behaviour is usually not the mode the project has worked in the past
2062020-05-13T13:12:14 *** sipa has quit IRC
2072020-05-13T13:12:16 <wumpus> this is not very welcoming to new contributors: https://github.com/bitcoin/bitcoin/pull/18965#issuecomment-627972210 please make sure that TODOs in the code are actual TODOs
2082020-05-13T13:13:19 <wumpus> I think maybe we shouldn't include TODOs in the code at all and open a github issue instead, this is easier to manage
2092020-05-13T13:13:37 <jonatack> jonasschnelli: i can understand that. there is also an opportunity cost in review resources.
2102020-05-13T13:13:48 *** molakala has joined #bitcoin-core-dev
2112020-05-13T13:14:27 <jonasschnelli> jonatack: Yes. Agree. I just think leaving it open for a while would not have had an big impact on resources.
2122020-05-13T13:14:51 <jonasschnelli> (have more feedback, improve quality and get a conceptual agreement)
2132020-05-13T13:15:12 <fanquake> wumpus: Could do. Although looks like most are in validation & net processing, so might not be great as "good first issues"
2142020-05-13T13:16:03 <wumpus> fanquake: they don't strictly need to be "good first issues", usually it's just a way to mark technical debt I guess :)
2152020-05-13T13:16:15 <jonatack> jonasschnelli: can't disagree with that. and at some point the conceptual issuens need to be addressed. belcher's ML post about it today is interesting.
2162020-05-13T13:16:28 <wumpus> it's fine to have them if they're actually TODOs but such opinions tend to change over time, while they languish in the source code
2172020-05-13T13:16:59 <wumpus> (e.g. it was an opinion of one developer that it was a TODO at the time the code was originally written)
2182020-05-13T13:17:26 <fanquake> heh. There are definitely opinionated TODOs
2192020-05-13T13:17:28 <fanquake> "// TODO: Handle this much more gracefully (10 DoS points is super arbitrary)"
2202020-05-13T13:17:35 *** bitcoin-git has joined #bitcoin-core-dev
2212020-05-13T13:17:36 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a33901cb6d82...6c647c89db28
2222020-05-13T13:17:37 <bitcoin-git> bitcoin/master 0c63f80 Hennadii Stepanov: build: Suppress -Wdeprecated-copy warnings
2232020-05-13T13:17:37 <bitcoin-git> bitcoin/master 6c647c8 fanquake: Merge #18738: build: Suppress -Wdeprecated-copy warnings
2242020-05-13T13:17:38 *** bitcoin-git has left #bitcoin-core-dev
2252020-05-13T13:17:56 *** bitcoin-git has joined #bitcoin-core-dev
2262020-05-13T13:17:56 <bitcoin-git> [bitcoin] fanquake merged pull request #18738: build: Suppress -Wdeprecated-copy warnings (master...200422-qt-warn) https://github.com/bitcoin/bitcoin/pull/18738
2272020-05-13T13:17:57 *** bitcoin-git has left #bitcoin-core-dev
2282020-05-13T13:18:14 *** sipa has joined #bitcoin-core-dev
2292020-05-13T13:19:15 <wumpus> I think that's an okay one, it could be written as "This could be handlded much more gracefully" without losing it's meaning, it's not like the one in the tests a fragment "todo: def base58 decoding" *why*
2302020-05-13T13:25:41 *** EagleTM has joined #bitcoin-core-dev
2312020-05-13T13:37:32 <jnewbery> jonasschnelli: 18877 is the first 3 commits from 16442, which has been open for almost a year. It had 7 ACKs + 2 implicit ACKs from jimpo and me + 6 concept ACKs. How can one year and 15 [concept] ACKs possibly be considered too short or not enough discussion?
2322020-05-13T13:38:56 *** EagleTM has quit IRC
2332020-05-13T13:41:51 *** per has joined #bitcoin-core-dev
2342020-05-13T13:46:01 *** fearbeag has joined #bitcoin-core-dev
2352020-05-13T13:47:56 *** proofofkeags has joined #bitcoin-core-dev
2362020-05-13T13:51:35 *** cryptoIndio has quit IRC
2372020-05-13T13:53:32 *** bitcoin-git has joined #bitcoin-core-dev
2382020-05-13T13:53:33 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c647c89db28...99c03728c07c
2392020-05-13T13:53:34 <bitcoin-git> bitcoin/master f963a68 Russell Yanofsky: test: Add test for conflicted wallet tx notifications
2402020-05-13T13:53:34 <bitcoin-git> bitcoin/master 99c0372 Wladimir J. van der Laan: Merge #18878: test: Add test for conflicted wallet tx notifications
2412020-05-13T13:53:36 *** bitcoin-git has left #bitcoin-core-dev
2422020-05-13T13:53:51 *** jonatack has quit IRC
2432020-05-13T13:53:52 *** bitcoin-git has joined #bitcoin-core-dev
2442020-05-13T13:53:53 <bitcoin-git> [bitcoin] laanwj merged pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878
2452020-05-13T13:54:04 *** bitcoin-git has left #bitcoin-core-dev
2462020-05-13T13:58:40 <jonasschnelli> jnewbery: good point. The PR description was not refering to 16442. I missed that. I just think we need to make sure everyone has been heard and ideally agrees on the concept.
2472020-05-13T13:58:40 *** promag has quit IRC
2482020-05-13T13:59:02 *** promag has joined #bitcoin-core-dev
2492020-05-13T13:59:23 <jonasschnelli> Dont get me wrong. Iâm totally pro BIP157.
2502020-05-13T13:59:31 *** promag has quit IRC
2512020-05-13T13:59:52 *** promag has joined #bitcoin-core-dev
2522020-05-13T14:00:58 *** Guest67738 has quit IRC
2532020-05-13T14:03:59 <wumpus> psa: please do not add anything to the 0.20.0 milestone anymore unless it's a critical bugfix for a regression, at this pace we're noever going to be able to do rc2 let alone a release
2542020-05-13T14:05:23 <wumpus> everything else (if it needs to go into 0.20 at all) can go into 0.20.1
2552020-05-13T14:05:32 <instagibbs> unless it's a weird concept or lots of code I see no harm in the base58_decode PR :shrug:
2562020-05-13T14:05:55 <instagibbs> agree in general TODOs need to be motivated
2572020-05-13T14:05:58 <wumpus> no harm but also no gain unless you see a use case?
2582020-05-13T14:06:41 <wumpus> we shouldn't just randomly add functions, it needs to be motivated
2592020-05-13T14:07:11 <instagibbs> i kind of disagree, unless you think there's just no useful test to write with it
2602020-05-13T14:07:20 <wumpus> that's not the point
2612020-05-13T14:07:21 <instagibbs> (maybe not!)
2622020-05-13T14:07:29 <wumpus> it can be added when a test needs it
2632020-05-13T14:07:58 *** mdunnio has joined #bitcoin-core-dev
2642020-05-13T14:07:59 <wumpus> the library is wholly to support our own use case, there shouldn't be anything 'just in case' in there
2652020-05-13T14:08:37 <wumpus> I mean, otherwise I'm sure in half a year or less someone will go through it and helpfully remove unused functions and we're round
2662020-05-13T14:08:48 <wumpus> in any case if *you* need it for a test it's good to add it
2672020-05-13T14:09:47 <instagibbs> tell him to add a test then? :)
2682020-05-13T14:09:48 <instagibbs> I did
2692020-05-13T14:10:11 <wumpus> a test for bitcoind that uses it, to be clear, not just a test for the function itself :)
2702020-05-13T14:11:20 <instagibbs> anyways, if I ever need it I'll just try to remember the future-ly closed PR and cherry-pick
2712020-05-13T14:12:18 <wumpus> fair enough
2722020-05-13T14:12:19 <ryanofsky> i definitely think #18965 is useful in its current form, even without a round trip test, though a round trip test would be useful
2732020-05-13T14:12:21 <gribble> https://github.com/bitcoin/bitcoin/issues/18965 | tests: implement base58_decode by 10xcryptodev · Pull Request #18965 · bitcoin/bitcoin · GitHub
2742020-05-13T14:13:28 <ryanofsky> i spent an embarrasing amount of time trying to debug byte_to_base58 recently for what turned out to be a byte order issue in #18878
2752020-05-13T14:13:30 <gribble> https://github.com/bitcoin/bitcoin/issues/18878 | test: Add test for conflicted wallet tx notifications by ryanofsky · Pull Request #18878 · bitcoin/bitcoin · GitHub
2762020-05-13T14:14:18 <ryanofsky> having a decode function could have saved me going that that rabbit hole
2772020-05-13T14:15:28 <theStack> given that base58_decoded is needed, for me it seems kind of nonsensical to reinvent the wheel and manually code it out again; that's as absurd as if someone would implemented sha256 by hand in the test suite
2782020-05-13T14:15:33 <theStack> of course base58 is not part of the python standard library, but i'd either use a tested widespread library, or (if we
2792020-05-13T14:15:36 <theStack> don't want dependencies) copy it from that library
2802020-05-13T14:30:13 <jnewbery> jonasschnelli: ah, you're right. I should have linked back to the full PR in 18877. The last comment before merge lists out all the places that people have [concept] ACKed.
2812020-05-13T14:30:41 *** mol_ has joined #bitcoin-core-dev
2822020-05-13T14:33:20 *** mol has quit IRC
2832020-05-13T14:35:36 *** mol_ has quit IRC
2842020-05-13T14:54:46 <promag> MarcoFalke: 18964 is not for 0.20 is it?
2852020-05-13T15:03:14 *** Highway61 has joined #bitcoin-core-dev
2862020-05-13T15:04:28 <jnewbery> I don't think it's unreasonable to add a decode function if the encode function is there. At least that means we can test the encoder with round-trips.
2872020-05-13T15:05:13 <jnewbery> (but agree that we should remove TODOs if they're of only marginal benefit to the project. The issue system seems like a more appropriate place for those)
2882020-05-13T15:06:06 *** proofofkeags has quit IRC
2892020-05-13T15:08:24 *** proofofkeags has joined #bitcoin-core-dev
2902020-05-13T15:10:44 *** proofofk_ has joined #bitcoin-core-dev
2912020-05-13T15:11:29 *** proofofk_ has quit IRC
2922020-05-13T15:11:53 *** proofofkeags has quit IRC
2932020-05-13T15:11:58 *** proofofk_ has joined #bitcoin-core-dev
2942020-05-13T15:14:56 *** proofofk_ has quit IRC
2952020-05-13T15:15:10 *** proofofkeags has joined #bitcoin-core-dev
2962020-05-13T15:20:13 *** veleiro has joined #bitcoin-core-dev
2972020-05-13T15:21:05 *** ThunderChicken1 has joined #bitcoin-core-dev
2982020-05-13T15:23:26 *** rmoura has joined #bitcoin-core-dev
2992020-05-13T15:23:46 *** morcos has quit IRC
3002020-05-13T15:24:03 *** morcos has joined #bitcoin-core-dev
3012020-05-13T15:24:49 *** rmoura has quit IRC
3022020-05-13T15:27:30 *** rmoura has joined #bitcoin-core-dev
3032020-05-13T15:30:27 *** EagleTM has joined #bitcoin-core-dev
3042020-05-13T15:36:59 *** veleiro` has joined #bitcoin-core-dev
3052020-05-13T15:38:47 *** veleiro has quit IRC
3062020-05-13T15:42:47 *** jonatack has joined #bitcoin-core-dev
3072020-05-13T15:43:17 *** justanotheruser has quit IRC
3082020-05-13T15:44:47 *** EagleTM has quit IRC
3092020-05-13T15:45:04 *** EagleTM has joined #bitcoin-core-dev
3102020-05-13T15:50:45 *** proofofkeags has quit IRC
3112020-05-13T15:51:21 *** proofofkeags has joined #bitcoin-core-dev
3122020-05-13T15:52:47 *** mol has joined #bitcoin-core-dev
3132020-05-13T15:52:55 *** proofofkeags has quit IRC
3142020-05-13T15:53:01 *** proofofk_ has joined #bitcoin-core-dev
3152020-05-13T15:57:38 *** proofofk_ has quit IRC
3162020-05-13T15:57:55 *** proofofkeags has joined #bitcoin-core-dev
3172020-05-13T16:10:40 *** promag has quit IRC
3182020-05-13T16:11:03 *** shaunsun has joined #bitcoin-core-dev
3192020-05-13T16:11:16 *** promag has joined #bitcoin-core-dev
3202020-05-13T16:12:22 *** kristapsk has joined #bitcoin-core-dev
3212020-05-13T16:13:43 *** EagleTM is now known as Eagle[TM]
3222020-05-13T16:14:19 *** Eagle[TM] is now known as EagleTM
3232020-05-13T16:15:41 *** EagleTM has joined #bitcoin-core-dev
3242020-05-13T16:19:43 *** nehan has quit IRC
3252020-05-13T16:20:00 *** vasild_ has joined #bitcoin-core-dev
3262020-05-13T16:20:01 *** nehan has joined #bitcoin-core-dev
3272020-05-13T16:20:16 *** pinheadm_ has joined #bitcoin-core-dev
3282020-05-13T16:20:36 *** ghost43 has quit IRC
3292020-05-13T16:20:42 *** per has quit IRC
3302020-05-13T16:20:59 *** pinheadm_ has quit IRC
3312020-05-13T16:21:01 *** pinheadmz has quit IRC
3322020-05-13T16:21:25 *** ghost43 has joined #bitcoin-core-dev
3332020-05-13T16:21:51 *** dongcarl has quit IRC
3342020-05-13T16:22:00 *** dongcarl has joined #bitcoin-core-dev
3352020-05-13T16:22:42 *** pinheadmz has joined #bitcoin-core-dev
3362020-05-13T16:23:23 *** vasild has quit IRC
3372020-05-13T16:23:24 *** vasild_ is now known as vasild
3382020-05-13T16:25:06 *** per has joined #bitcoin-core-dev
3392020-05-13T16:25:59 *** tryphe has joined #bitcoin-core-dev
3402020-05-13T16:26:54 *** lightlike has joined #bitcoin-core-dev
3412020-05-13T16:29:51 *** justanotheruser has joined #bitcoin-core-dev
3422020-05-13T16:38:34 *** proofofkeags has quit IRC
3432020-05-13T16:39:30 *** troygiorshev has joined #bitcoin-core-dev
3442020-05-13T16:42:15 *** veleiro`` has joined #bitcoin-core-dev
3452020-05-13T16:43:53 *** veleiro` has quit IRC
3462020-05-13T16:45:50 *** proofofkeags has joined #bitcoin-core-dev
3472020-05-13T16:46:21 *** veleiro`` has left #bitcoin-core-dev
3482020-05-13T16:47:13 *** veleiro has joined #bitcoin-core-dev
3492020-05-13T16:48:43 *** EagleTM has quit IRC
3502020-05-13T16:50:08 *** michaelfolkson has joined #bitcoin-core-dev
3512020-05-13T16:52:54 *** b10c has joined #bitcoin-core-dev
3522020-05-13T16:55:55 *** kristapsk has quit IRC
3532020-05-13T16:56:17 *** kristapsk has joined #bitcoin-core-dev
3542020-05-13T16:57:30 *** veleiro` has joined #bitcoin-core-dev
3552020-05-13T16:59:36 *** veleiro has quit IRC
3562020-05-13T17:00:06 *** Processus42 has quit IRC
3572020-05-13T17:00:20 *** andrewtoth has joined #bitcoin-core-dev
3582020-05-13T17:00:52 *** Processus42 has joined #bitcoin-core-dev
3592020-05-13T17:03:46 *** r251d has joined #bitcoin-core-dev
3602020-05-13T17:04:13 *** michaelf_ has joined #bitcoin-core-dev
3612020-05-13T17:05:30 *** michaelfolkson has quit IRC
3622020-05-13T17:05:36 *** michaelf_ has quit IRC
3632020-05-13T17:06:08 *** michaelfolkson has joined #bitcoin-core-dev
3642020-05-13T17:09:59 *** jarthur has joined #bitcoin-core-dev
3652020-05-13T17:13:07 *** michaelf_ has joined #bitcoin-core-dev
3662020-05-13T17:15:15 *** michaelfolkson has quit IRC
3672020-05-13T17:16:31 *** michaelf_ has quit IRC
3682020-05-13T17:17:06 *** michaelfolkson has joined #bitcoin-core-dev
3692020-05-13T17:25:57 *** michaelf_ has joined #bitcoin-core-dev
3702020-05-13T17:26:37 *** michaelfolkson has quit IRC
3712020-05-13T17:28:47 *** michaelf_ has quit IRC
3722020-05-13T17:29:17 *** michaelfolkson has joined #bitcoin-core-dev
3732020-05-13T17:29:29 *** michaelfolkson is now known as michaelfolkson2
3742020-05-13T17:31:43 *** Guyver2 has joined #bitcoin-core-dev
3752020-05-13T17:32:10 *** michaelfolkson2 is now known as michaelfolkson
3762020-05-13T17:36:05 *** bitcoin-git has joined #bitcoin-core-dev
3772020-05-13T17:36:07 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99c03728c07c...5d18c0ae1827
3782020-05-13T17:36:07 <bitcoin-git> bitcoin/master 8bf1540 fanquake: build: remove fdelt_chk backwards compatibility code
3792020-05-13T17:36:08 <bitcoin-git> bitcoin/master df6bde0 fanquake: test: remove glibc fdelt sanity check
3802020-05-13T17:36:09 <bitcoin-git> bitcoin/master 5d18c0a Wladimir J. van der Laan: Merge #18862: Remove fdelt_chk back-compat code and sanity check
3812020-05-13T17:36:11 *** bitcoin-git has left #bitcoin-core-dev
3822020-05-13T17:36:25 *** bitcoin-git has joined #bitcoin-core-dev
3832020-05-13T17:36:25 <bitcoin-git> [bitcoin] laanwj merged pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
3842020-05-13T17:36:26 *** bitcoin-git has left #bitcoin-core-dev
3852020-05-13T17:38:18 *** rmoura has quit IRC
3862020-05-13T17:40:35 *** promag_ has joined #bitcoin-core-dev
3872020-05-13T17:40:36 *** promag has quit IRC
3882020-05-13T17:41:48 *** promag has joined #bitcoin-core-dev
3892020-05-13T17:41:48 *** promag_ has quit IRC
3902020-05-13T17:55:11 *** rmoura has joined #bitcoin-core-dev
3912020-05-13T17:59:41 *** bitcoin-git has joined #bitcoin-core-dev
3922020-05-13T17:59:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
3932020-05-13T17:59:42 *** bitcoin-git has left #bitcoin-core-dev
3942020-05-13T18:00:02 *** ThunderChicken1 has quit IRC
3952020-05-13T18:03:02 *** r251d has quit IRC
3962020-05-13T18:04:37 *** timothy has quit IRC
3972020-05-13T18:09:48 *** theStack has quit IRC
3982020-05-13T18:15:21 *** bitcoin-git has joined #bitcoin-core-dev
3992020-05-13T18:15:21 <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5d18c0ae1827...fc895d7700f9
4002020-05-13T18:15:22 <bitcoin-git> bitcoin/master 1e06bb6 Hennadii Stepanov: Drop unused CLIENT_VERSION_SUFFIX macro
4012020-05-13T18:15:22 <bitcoin-git> bitcoin/master dc1fba9 Hennadii Stepanov: scripted-diff: Rename share/genbuild.sh macros to more meaningful ones
4022020-05-13T18:15:23 <bitcoin-git> bitcoin/master 35f1189 Hennadii Stepanov: build: Rename BUILD_* macros and the code self-descriptive
4032020-05-13T18:15:24 *** bitcoin-git has left #bitcoin-core-dev
4042020-05-13T18:15:45 *** bitcoin-git has joined #bitcoin-core-dev
4052020-05-13T18:15:46 <bitcoin-git> [bitcoin] laanwj merged pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
4062020-05-13T18:15:46 *** bitcoin-git has left #bitcoin-core-dev
4072020-05-13T18:22:43 *** andrewtoth has quit IRC
4082020-05-13T18:31:06 *** bitcoin-git has joined #bitcoin-core-dev
4092020-05-13T18:31:07 <bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc895d7700f9...51825aea7fa0
4102020-05-13T18:31:07 <bitcoin-git> bitcoin/master fe05dd0 Hennadii Stepanov: util: Enhance bilingual_str
4112020-05-13T18:31:08 <bitcoin-git> bitcoin/master 4c9b9a4 Hennadii Stepanov: util: Enhance Join()
4122020-05-13T18:31:08 <bitcoin-git> bitcoin/master da16f95 Hennadii Stepanov: gui: Do not translate InitWarning messages in debug.log
4132020-05-13T18:31:09 *** bitcoin-git has left #bitcoin-core-dev
4142020-05-13T18:31:25 *** bitcoin-git has joined #bitcoin-core-dev
4152020-05-13T18:31:26 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922
4162020-05-13T18:31:26 *** bitcoin-git has left #bitcoin-core-dev
4172020-05-13T18:40:20 <MarcoFalke> [23:19] <luke-jr> would be nice if Travis sent an email to the PR creator when it failed :x
4182020-05-13T18:40:30 <MarcoFalke> You can enable travis in your own repo to get emails
4192020-05-13T18:53:46 *** ecrist1 has joined #bitcoin-core-dev
4202020-05-13T18:56:51 <MarcoFalke> Btw, I have a lot of good first issues to work on. If someone is out there that wants them, please contact me. If I don't hear back, I will put them on the main repo maybe next week.
4212020-05-13T18:59:08 <shesek> how do conflicting transactions fit into the most recent sorting of listttransactions? do they get sorted as the most recent like the negative confirmations number might imply? or at their original height? also, are there any guarantees for the ordering of unconfirmed transactions among themselves?
4222020-05-13T19:12:52 *** tryphe_ has joined #bitcoin-core-dev
4232020-05-13T19:15:06 *** tryphe has quit IRC
4242020-05-13T19:30:49 *** owowo has quit IRC
4252020-05-13T19:35:16 *** owowo has joined #bitcoin-core-dev
4262020-05-13T19:38:14 *** bitcoin-git has joined #bitcoin-core-dev
4272020-05-13T19:38:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51825aea7fa0...a9a6d946e41b
4282020-05-13T19:38:15 <bitcoin-git> bitcoin/master faa26d3 MarcoFalke: test: Remove RPCOverloadWrapper boilerplate
4292020-05-13T19:38:15 <bitcoin-git> bitcoin/master a9a6d94 MarcoFalke: Merge #18888: test: Remove RPCOverloadWrapper boilerplate
4302020-05-13T19:38:17 *** bitcoin-git has left #bitcoin-core-dev
4312020-05-13T19:38:34 *** bitcoin-git has joined #bitcoin-core-dev
4322020-05-13T19:38:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
4332020-05-13T19:38:35 *** bitcoin-git has left #bitcoin-core-dev
4342020-05-13T19:40:34 *** b10c has quit IRC
4352020-05-13T19:48:17 *** Kiminuo has joined #bitcoin-core-dev
4362020-05-13T20:00:50 <MarcoFalke> begging for one or two more ACKs on #18742 . I think we should make some progress on rc2
4372020-05-13T20:00:54 <gribble> https://github.com/bitcoin/bitcoin/issues/18742 | miner: Avoid stack-use-after-return in validationinterface by MarcoFalke · Pull Request #18742 · bitcoin/bitcoin · GitHub
4382020-05-13T20:12:52 *** michaelfolkson has quit IRC
4392020-05-13T20:15:23 *** michaelfolkson has joined #bitcoin-core-dev
4402020-05-13T20:20:46 *** bitcoin-git has joined #bitcoin-core-dev
4412020-05-13T20:20:47 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9a6d946e41b...04c09553d898
4422020-05-13T20:20:48 <bitcoin-git> bitcoin/master a30b0a2 Vasil Dimov: build: enable -Werror=gnu
4432020-05-13T20:20:49 <bitcoin-git> bitcoin/master 04c0955 Wladimir J. van der Laan: Merge #18887: build: enable -Werror=gnu
4442020-05-13T20:20:58 *** bitcoin-git has left #bitcoin-core-dev
4452020-05-13T20:21:16 *** bitcoin-git has joined #bitcoin-core-dev
4462020-05-13T20:21:17 <bitcoin-git> [bitcoin] laanwj merged pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887
4472020-05-13T20:21:28 *** bitcoin-git has left #bitcoin-core-dev
4482020-05-13T20:40:15 *** michaelfolkson has quit IRC
4492020-05-13T20:40:42 *** michaelfolkson has joined #bitcoin-core-dev
4502020-05-13T20:43:39 *** michaelfolkson has quit IRC
4512020-05-13T20:47:26 *** ghost43 has quit IRC
4522020-05-13T20:47:43 *** ghost43 has joined #bitcoin-core-dev
4532020-05-13T20:47:48 *** michaelfolkson has joined #bitcoin-core-dev
4542020-05-13T20:49:59 *** michaelf_ has joined #bitcoin-core-dev
4552020-05-13T20:50:02 *** dviola has joined #bitcoin-core-dev
4562020-05-13T20:51:46 *** fearbeag has quit IRC
4572020-05-13T20:55:47 *** michaelf_ has quit IRC
4582020-05-13T20:57:42 *** michaelf_ has joined #bitcoin-core-dev
4592020-05-13T20:57:57 *** Kiminuo has quit IRC
4602020-05-13T21:00:02 *** ecrist1 has quit IRC
4612020-05-13T21:03:12 *** Guyver2 has quit IRC
4622020-05-13T21:04:18 *** michaelf_ has quit IRC
4632020-05-13T21:04:24 *** nubescaeli has joined #bitcoin-core-dev
4642020-05-13T21:04:44 *** michaelf_ has joined #bitcoin-core-dev
4652020-05-13T21:07:31 *** michaelf_ has quit IRC
4662020-05-13T21:08:00 *** michaelf_ has joined #bitcoin-core-dev
4672020-05-13T21:08:50 *** manantial has quit IRC
4682020-05-13T21:11:10 *** michaelf_ has quit IRC
4692020-05-13T21:11:35 *** michaelf_ has joined #bitcoin-core-dev
4702020-05-13T21:13:07 *** michaelf_ has quit IRC
4712020-05-13T21:13:33 *** michaelf_ has joined #bitcoin-core-dev
4722020-05-13T21:17:06 *** emilengler has quit IRC
4732020-05-13T21:18:12 *** Steini- has joined #bitcoin-core-dev
4742020-05-13T21:20:12 *** michaelf_ has quit IRC
4752020-05-13T21:20:47 *** michaelf_ has joined #bitcoin-core-dev
4762020-05-13T21:22:02 *** Izl has quit IRC
4772020-05-13T21:23:09 *** promag has quit IRC
4782020-05-13T21:23:25 *** promag has joined #bitcoin-core-dev
4792020-05-13T21:24:11 *** Kiminuo has joined #bitcoin-core-dev
4802020-05-13T21:24:12 *** troygiorshev has quit IRC
4812020-05-13T21:26:21 *** molakala has quit IRC
4822020-05-13T21:27:15 *** promag_ has joined #bitcoin-core-dev
4832020-05-13T21:27:17 *** promag has quit IRC
4842020-05-13T21:29:19 *** michaelf_ has quit IRC
4852020-05-13T21:29:56 *** michaelf_ has joined #bitcoin-core-dev
4862020-05-13T21:41:39 *** michaelf_ has quit IRC
4872020-05-13T21:46:01 *** jeremyrubin has joined #bitcoin-core-dev
4882020-05-13T21:49:31 *** michaelf_ has joined #bitcoin-core-dev
4892020-05-13T21:53:02 *** surja795 has quit IRC
4902020-05-13T21:53:59 *** surja795 has joined #bitcoin-core-dev
4912020-05-13T21:58:26 *** michaelf_ has quit IRC
4922020-05-13T21:59:08 *** surja795 has quit IRC
4932020-05-13T22:00:50 *** veleiro`` has joined #bitcoin-core-dev
4942020-05-13T22:01:23 *** michaelf_ has joined #bitcoin-core-dev
4952020-05-13T22:04:11 *** veleiro` has quit IRC
4962020-05-13T22:05:21 *** Livestradamus has quit IRC
4972020-05-13T22:05:34 *** warren has quit IRC
4982020-05-13T22:05:39 *** Livestradamus has joined #bitcoin-core-dev
4992020-05-13T22:06:31 *** warren has joined #bitcoin-core-dev
5002020-05-13T22:07:29 *** Anduck has quit IRC
5012020-05-13T22:08:05 *** Anduck has joined #bitcoin-core-dev
5022020-05-13T22:20:53 *** tmoc has joined #bitcoin-core-dev
5032020-05-13T22:22:17 *** justanotheruser has quit IRC
5042020-05-13T22:22:36 *** justanotheruser has joined #bitcoin-core-dev
5052020-05-13T22:34:00 *** michael__ has joined #bitcoin-core-dev
5062020-05-13T22:34:37 *** michaelf_ has quit IRC
5072020-05-13T22:38:20 *** michael__ has quit IRC
5082020-05-13T22:47:56 *** bitcoin-git has joined #bitcoin-core-dev
5092020-05-13T22:47:56 <bitcoin-git> [bitcoin] promag closed pull request #18791: wip: Only support shared validation interfaces (master...2020-04-only-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18791
5102020-05-13T22:47:57 *** bitcoin-git has left #bitcoin-core-dev
5112020-05-13T22:55:58 *** marcoagner has quit IRC
5122020-05-13T22:58:31 *** dfmb_ has quit IRC
5132020-05-13T23:14:41 *** mdunnio has quit IRC
5142020-05-13T23:19:23 *** DeanWeen has quit IRC
5152020-05-13T23:30:14 *** bitdex has joined #bitcoin-core-dev
5162020-05-13T23:31:58 *** DeanWeen has joined #bitcoin-core-dev
5172020-05-13T23:36:43 *** shaunsun has quit IRC
5182020-05-13T23:37:19 *** lightlike has quit IRC
5192020-05-13T23:38:40 *** niska has quit IRC
5202020-05-13T23:44:05 *** justanotheruser has quit IRC
5212020-05-13T23:56:26 *** IGHOR has quit IRC
5222020-05-13T23:58:17 *** tryphe_ is now known as tryphe