12020-05-14T00:00:01 *** Steini- has quit IRC
22020-05-14T00:02:26 *** surja795 has joined #bitcoin-core-dev
32020-05-14T00:02:35 *** IGHOR has joined #bitcoin-core-dev
42020-05-14T00:03:22 *** Guest75362 has joined #bitcoin-core-dev
52020-05-14T00:04:33 *** bitcoin-git has joined #bitcoin-core-dev
62020-05-14T00:04:34 <bitcoin-git> [bitcoin] achow101 opened pull request #18971: wallet: Refactor the classes in wallet/db.{cpp/h} (master...refactor-storage) https://github.com/bitcoin/bitcoin/pull/18971
72020-05-14T00:04:35 *** bitcoin-git has left #bitcoin-core-dev
82020-05-14T00:07:26 *** surja795 has quit IRC
92020-05-14T00:08:21 *** niska has joined #bitcoin-core-dev
102020-05-14T00:09:43 *** veleiro`` has left #bitcoin-core-dev
112020-05-14T00:10:01 *** veleiro has joined #bitcoin-core-dev
122020-05-14T00:20:21 *** jden has joined #bitcoin-core-dev
132020-05-14T00:25:26 *** promag_ has quit IRC
142020-05-14T00:26:03 *** promag has joined #bitcoin-core-dev
152020-05-14T00:28:39 *** veleiro` has joined #bitcoin-core-dev
162020-05-14T00:32:29 *** veleiro has quit IRC
172020-05-14T00:34:01 *** surja795 has joined #bitcoin-core-dev
182020-05-14T00:35:24 *** AaronvanW has quit IRC
192020-05-14T00:36:07 *** Highway61 has quit IRC
202020-05-14T00:42:39 *** EagleTM has joined #bitcoin-core-dev
212020-05-14T00:45:25 *** promag has quit IRC
222020-05-14T00:45:38 *** promag has joined #bitcoin-core-dev
232020-05-14T00:48:43 *** ghost43_ has joined #bitcoin-core-dev
242020-05-14T00:49:23 *** ghost43 has quit IRC
252020-05-14T01:22:35 *** EagleTM has quit IRC
262020-05-14T01:32:05 *** bitcoin-git has joined #bitcoin-core-dev
272020-05-14T01:32:05 <bitcoin-git> [bitcoin] luke-jr opened pull request #18972: WIP: net: Add blockfilters white{bind,list} permission flag (master...neutrino_whitelist) https://github.com/bitcoin/bitcoin/pull/18972
282020-05-14T01:32:06 *** bitcoin-git has left #bitcoin-core-dev
292020-05-14T01:42:08 *** spinza has quit IRC
302020-05-14T01:43:18 *** Guest75362 has quit IRC
312020-05-14T01:44:24 *** spinza has joined #bitcoin-core-dev
322020-05-14T01:46:57 *** Guest75362 has joined #bitcoin-core-dev
332020-05-14T02:12:37 *** promag has quit IRC
342020-05-14T02:18:03 *** desperad0 has joined #bitcoin-core-dev
352020-05-14T02:30:03 *** sdaftuar has quit IRC
362020-05-14T02:32:36 *** sdaftuar has joined #bitcoin-core-dev
372020-05-14T02:37:46 *** shesek has quit IRC
382020-05-14T02:38:11 *** shesek has joined #bitcoin-core-dev
392020-05-14T02:38:11 *** shesek has joined #bitcoin-core-dev
402020-05-14T02:47:40 *** Pasha is now known as Cory
412020-05-14T03:00:02 *** jden has quit IRC
422020-05-14T03:03:43 *** surja795 has quit IRC
432020-05-14T03:19:43 *** Kiminuo has quit IRC
442020-05-14T03:24:11 *** Kiminuo has joined #bitcoin-core-dev
452020-05-14T03:40:07 *** proofofkeags has quit IRC
462020-05-14T03:40:40 *** proofofkeags has joined #bitcoin-core-dev
472020-05-14T03:40:56 *** dviola has quit IRC
482020-05-14T03:45:20 *** proofofkeags has quit IRC
492020-05-14T03:53:26 *** greynix has joined #bitcoin-core-dev
502020-05-14T03:55:12 *** mol_ has joined #bitcoin-core-dev
512020-05-14T03:55:26 *** mol has quit IRC
522020-05-14T03:55:27 *** go11111111111 has joined #bitcoin-core-dev
532020-05-14T03:58:25 *** go121212 has quit IRC
542020-05-14T04:19:58 *** vasild_ has joined #bitcoin-core-dev
552020-05-14T04:23:03 *** vasild has quit IRC
562020-05-14T04:23:04 *** vasild_ is now known as vasild
572020-05-14T04:32:42 *** Guest75362 is now known as justanotheruser
582020-05-14T04:37:57 *** bitcoin-git has joined #bitcoin-core-dev
592020-05-14T04:37:57 <bitcoin-git> [bitcoin] fanquake opened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
602020-05-14T04:37:58 *** bitcoin-git has left #bitcoin-core-dev
612020-05-14T05:58:15 *** Kiminuo has quit IRC
622020-05-14T06:00:02 *** greynix has quit IRC
632020-05-14T06:03:24 *** manantial has joined #bitcoin-core-dev
642020-05-14T06:05:06 *** _Francisco_ has joined #bitcoin-core-dev
652020-05-14T06:18:09 *** Kiminuo has joined #bitcoin-core-dev
662020-05-14T06:20:07 *** MarconM has joined #bitcoin-core-dev
672020-05-14T06:28:30 *** rjected has quit IRC
682020-05-14T06:29:07 *** MarconM has quit IRC
692020-05-14T06:36:31 *** rjected has joined #bitcoin-core-dev
702020-05-14T06:37:48 *** Kiminuo has quit IRC
712020-05-14T06:46:31 *** bitcoin-git has joined #bitcoin-core-dev
722020-05-14T06:46:31 <bitcoin-git> [bitcoin] elichai closed pull request #17953: refactor: Abstract boost::variant out (master...2020-01-variant) https://github.com/bitcoin/bitcoin/pull/17953
732020-05-14T06:46:32 *** bitcoin-git has left #bitcoin-core-dev
742020-05-14T06:48:45 *** Cory is now known as Pasha
752020-05-14T06:49:46 *** Pasha has quit IRC
762020-05-14T06:53:50 *** OneFixt has joined #bitcoin-core-dev
772020-05-14T06:57:40 *** Cory has joined #bitcoin-core-dev
782020-05-14T07:13:41 *** luke-jr has quit IRC
792020-05-14T07:16:01 *** nubescaeli has quit IRC
802020-05-14T07:30:22 *** luke-jr has joined #bitcoin-core-dev
812020-05-14T07:35:22 *** DeanWeen has quit IRC
822020-05-14T07:35:31 *** DeanWeen has joined #bitcoin-core-dev
832020-05-14T07:54:12 *** marcoagner has joined #bitcoin-core-dev
842020-05-14T08:00:52 *** Cory has quit IRC
852020-05-14T08:00:53 *** Cory has joined #bitcoin-core-dev
862020-05-14T08:13:42 *** Guyver2 has joined #bitcoin-core-dev
872020-05-14T08:14:52 *** _Francisco_ has quit IRC
882020-05-14T08:17:28 *** tmoc has quit IRC
892020-05-14T08:43:14 *** AaronvanW has joined #bitcoin-core-dev
902020-05-14T08:43:29 *** goatpig has joined #bitcoin-core-dev
912020-05-14T08:43:41 <goatpig> hi
922020-05-14T08:43:54 <goatpig> would a transaction with no outputs be valid?
932020-05-14T09:00:02 *** OneFixt has quit IRC
942020-05-14T09:00:38 <aj> goatpig: https://github.com/bitcoin/bitcoin/blob/master/src/consensus/tx_check.cpp#L15
952020-05-14T09:00:52 <goatpig> thanks
962020-05-14T09:03:22 *** mol_ has quit IRC
972020-05-14T09:05:06 *** theStack has joined #bitcoin-core-dev
982020-05-14T09:15:32 *** desperad0 has quit IRC
992020-05-14T09:17:52 *** dfmb_ has joined #bitcoin-core-dev
1002020-05-14T09:18:06 *** tty11 has joined #bitcoin-core-dev
1012020-05-14T09:21:12 *** _Francisco_ has joined #bitcoin-core-dev
1022020-05-14T09:25:31 *** DeanWeen has quit IRC
1032020-05-14T09:25:53 *** DeanWeen has joined #bitcoin-core-dev
1042020-05-14T09:25:54 *** promag has joined #bitcoin-core-dev
1052020-05-14T09:27:26 *** timothy has joined #bitcoin-core-dev
1062020-05-14T09:56:09 *** surja795 has joined #bitcoin-core-dev
1072020-05-14T09:58:27 *** milieu__ has joined #bitcoin-core-dev
1082020-05-14T09:58:43 *** SiAnDoG_ has quit IRC
1092020-05-14T10:00:51 *** Highway61 has joined #bitcoin-core-dev
1102020-05-14T10:01:25 *** filchef has joined #bitcoin-core-dev
1112020-05-14T10:19:06 *** jarthur has quit IRC
1122020-05-14T10:19:35 *** braydonf has quit IRC
1132020-05-14T10:22:00 *** braydonf has joined #bitcoin-core-dev
1142020-05-14T10:32:24 *** surja795 has quit IRC
1152020-05-14T10:33:47 *** Victorsueca has joined #bitcoin-core-dev
1162020-05-14T10:39:50 *** surja795 has joined #bitcoin-core-dev
1172020-05-14T10:44:23 *** surja795 has quit IRC
1182020-05-14T10:54:57 *** milieu__ has quit IRC
1192020-05-14T10:55:19 *** milieu__ has joined #bitcoin-core-dev
1202020-05-14T11:04:18 *** ghost43_ has quit IRC
1212020-05-14T11:04:36 *** ghost43 has joined #bitcoin-core-dev
1222020-05-14T11:19:23 *** DeanWeen has quit IRC
1232020-05-14T11:24:52 *** _Francisco_ has quit IRC
1242020-05-14T11:30:55 *** Izl has joined #bitcoin-core-dev
1252020-05-14T11:34:56 <theStack> has anyone ever used the functional test framework to interact with an already running full node? for some (performance) tests it would make sense to use the mainnet i think
1262020-05-14T11:42:18 <fjahr> theStack: have you seen the TestShell class from James Chiang? It is used in the jupyter notebooks for the optech Taproot course, that might be helpful for you.
1272020-05-14T11:42:28 *** bitdex has quit IRC
1282020-05-14T11:42:31 <fjahr> https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_shell.py
1292020-05-14T11:42:50 *** owowo has quit IRC
1302020-05-14T11:44:35 <theStack> fjahr: thanks for the hint, will take a look at it!
1312020-05-14T11:44:59 <fjahr> I am not sure about the already running part though. Should probably work if you just change the pid? But I have not tried it.
1322020-05-14T11:52:18 *** luke-jr has quit IRC
1332020-05-14T11:55:43 *** vasild has quit IRC
1342020-05-14T11:57:47 *** vasild has joined #bitcoin-core-dev
1352020-05-14T11:58:56 *** andytoshi has quit IRC
1362020-05-14T12:00:01 *** tty11 has quit IRC
1372020-05-14T12:08:21 *** luke-jr has joined #bitcoin-core-dev
1382020-05-14T12:12:42 *** mol has joined #bitcoin-core-dev
1392020-05-14T12:13:02 *** luke-jr has quit IRC
1402020-05-14T12:15:56 *** luke-jr has joined #bitcoin-core-dev
1412020-05-14T12:19:46 *** gonemad3 has joined #bitcoin-core-dev
1422020-05-14T12:20:45 *** andytoshi has joined #bitcoin-core-dev
1432020-05-14T12:20:45 *** andytoshi has quit IRC
1442020-05-14T12:20:45 *** andytoshi has joined #bitcoin-core-dev
1452020-05-14T12:23:14 *** promag has quit IRC
1462020-05-14T12:23:49 *** promag has joined #bitcoin-core-dev
1472020-05-14T12:31:22 *** shaunsun has joined #bitcoin-core-dev
1482020-05-14T12:32:06 *** molakala has joined #bitcoin-core-dev
1492020-05-14T12:33:11 *** shaunsun_ has joined #bitcoin-core-dev
1502020-05-14T12:35:45 *** Guyver2 has quit IRC
1512020-05-14T12:36:02 *** shaunsun has quit IRC
1522020-05-14T12:38:25 *** bitcoin-git has joined #bitcoin-core-dev
1532020-05-14T12:38:25 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
1542020-05-14T12:38:25 *** bitcoin-git has left #bitcoin-core-dev
1552020-05-14T12:39:19 <fanquake> promag: can you check the coin control backports in #18973
1562020-05-14T12:39:21 <gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
1572020-05-14T12:41:22 *** bitcoin-git has joined #bitcoin-core-dev
1582020-05-14T12:41:23 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/04c09553d898...b9c504cbc4ba
1592020-05-14T12:41:23 <bitcoin-git> bitcoin/master fab6d06 MarcoFalke: test: Add unregister_validation_interface_race test
1602020-05-14T12:41:24 <bitcoin-git> bitcoin/master fa770ce MarcoFalke: validationinterface: Rework documentation, Rename pwalletIn to callbacks
1612020-05-14T12:41:25 <bitcoin-git> bitcoin/master fa5ceb2 MarcoFalke: test: Remove UninterruptibleSleep from test and replace it by SyncWithVali...
1622020-05-14T12:41:26 *** bitcoin-git has left #bitcoin-core-dev
1632020-05-14T12:41:47 *** bitcoin-git has joined #bitcoin-core-dev
1642020-05-14T12:41:47 <bitcoin-git> [bitcoin] fanquake merged pull request #18742: miner: Avoid stack-use-after-return in validationinterface (master...2004-minerNoCrash) https://github.com/bitcoin/bitcoin/pull/18742
1652020-05-14T12:41:48 *** bitcoin-git has left #bitcoin-core-dev
1662020-05-14T12:41:51 *** ghost43 has quit IRC
1672020-05-14T12:42:37 *** ghost43 has joined #bitcoin-core-dev
1682020-05-14T12:43:20 *** fearbeag has joined #bitcoin-core-dev
1692020-05-14T12:43:22 <theStack> fjahr: the interesting part for me would be that it doesn't start a new chain from scratch; if i need 100000s of blocks for performance tests starting a new regtest chain is not an option
1702020-05-14T12:44:30 <theStack> creating a TestNode() instance with right parameters could maybe work
1712020-05-14T12:45:02 *** mol_ has joined #bitcoin-core-dev
1722020-05-14T12:46:42 *** shaunsun_ has quit IRC
1732020-05-14T12:48:36 *** mol has quit IRC
1742020-05-14T12:48:37 <jnewbery> theStack: I made some modifications to test_shell to connect to a running full node: https://github.com/jnewbery/bitcoin/tree/node-shell YMMV
1752020-05-14T12:49:45 <jnewbery> were you planning to do some perf testing for 18960?
1762020-05-14T12:52:36 <fanquake> MarcoFalke: is there anything obvious to backport into the 0.20 branch to fix the test failures in 18973. Looks like it's mostly in the valgrind builds
1772020-05-14T12:53:16 <theStack> jnewbery: sounds like exactly what i need, will take a look. thanks!
1782020-05-14T12:53:52 <jnewbery> fanquake: #18899 removes the valgrind build from travis because it was timing out jobs
1792020-05-14T12:53:54 <gribble> https://github.com/bitcoin/bitcoin/issues/18899 | travis: Remove valgrind by MarcoFalke · Pull Request #18899 · bitcoin/bitcoin · GitHub
1802020-05-14T12:54:11 <theStack> jnewbery: yes indeed i was planning to repeatedly fetch the bip 157 checkpoint headers, comparing how long it takes in master and 18960 branches
1812020-05-14T12:55:26 <theStack> (maybe also compare it with the original proposed solutions by jimpo)
1822020-05-14T12:55:41 <fanquake> jnewbery: guess that might be worth backporting as well then
1832020-05-14T12:56:13 <jnewbery> theStack: great. Thanks! The first time you send a getcfcheckpt, it's reading the values from disk, so it should be slower than the second and subsequent requests
1842020-05-14T12:57:35 <jnewbery> fanquake: as long as it's not hiding and actual bugs that need to be backported. https://travis-ci.org/github/bitcoin/bitcoin/builds/686857580 do actually look like actual test failures rather than timeouts.
1852020-05-14T12:59:08 *** promag has quit IRC
1862020-05-14T12:59:22 *** promag has joined #bitcoin-core-dev
1872020-05-14T13:11:11 <fanquake> jnewbery: if you've got test backport suggestions I'm all ears. I see some process_message related in the fuzzer, which I assume we've fixed.
1882020-05-14T13:13:16 <fanquake> I'm going to untag #18287 for 0.20.0. Only myself and sipsorcery have tested it, and neither of us could verify that the change is fixing the actual problem. The patch does fix libevents getaddrinfo detection, but Core still doesn't behave as expected; so I think this needs further testing, and shouldn't be bundled in last minute.
1892020-05-14T13:13:18 <gribble> https://github.com/bitcoin/bitcoin/issues/18287 | depends: Patch libevent build to fix IPv6 -rpcbind on Windows by luke-jr · Pull Request #18287 · bitcoin/bitcoin · GitHub
1902020-05-14T13:14:45 <theStack> jnewbery: do you think that is also true for the version without the cache implementation (i.e. master branch)? i don't know if BDB does caching internally (or maybe even the OS?), but there must be something as some people have expressed their doubt if the cache implementation is really improving anything
1912020-05-14T13:14:53 <theStack> but anyways, i will hopefully find out soon through the benchmarks :)
1922020-05-14T13:19:50 *** davterra has joined #bitcoin-core-dev
1932020-05-14T13:28:59 <jnewbery> theStack: perhaps. It's worth testing.
1942020-05-14T13:29:30 <jnewbery> (the block filter index uses leveldb, not bdb. bdb is only used in the wallet)
1952020-05-14T13:29:51 *** sipsorcery has joined #bitcoin-core-dev
1962020-05-14T13:44:37 <jnewbery> fanquake: looks like you'll need #18757 to avoid those false fuzzing failures
1972020-05-14T13:44:39 <gribble> https://github.com/bitcoin/bitcoin/issues/18757 | test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer by practicalswift · Pull Request #18757 · bitcoin/bitcoin · GitHub
1982020-05-14T13:53:11 *** troygiorshev has joined #bitcoin-core-dev
1992020-05-14T14:07:46 *** mdunnio has joined #bitcoin-core-dev
2002020-05-14T14:09:13 *** per has quit IRC
2012020-05-14T14:14:37 *** per has joined #bitcoin-core-dev
2022020-05-14T14:18:48 *** Guyver2 has joined #bitcoin-core-dev
2032020-05-14T14:21:57 *** Kiminuo has joined #bitcoin-core-dev
2042020-05-14T14:29:24 *** Kiminuo has quit IRC
2052020-05-14T14:31:21 *** emilengler has joined #bitcoin-core-dev
2062020-05-14T14:31:58 *** jonatack has quit IRC
2072020-05-14T14:33:09 *** molz_ has joined #bitcoin-core-dev
2082020-05-14T14:33:32 *** bitcoin-git has joined #bitcoin-core-dev
2092020-05-14T14:33:32 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
2102020-05-14T14:33:33 *** bitcoin-git has left #bitcoin-core-dev
2112020-05-14T14:33:52 *** bitcoin-git has joined #bitcoin-core-dev
2122020-05-14T14:33:52 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
2132020-05-14T14:33:53 *** bitcoin-git has left #bitcoin-core-dev
2142020-05-14T14:35:54 *** mol_ has quit IRC
2152020-05-14T14:37:39 *** promag has quit IRC
2162020-05-14T14:38:15 *** promag has joined #bitcoin-core-dev
2172020-05-14T14:46:08 *** proofofkeags has joined #bitcoin-core-dev
2182020-05-14T14:48:44 <vasild> ResolveSubNet("::/0").Match(ResolveIP("1.2.3.4")) -- is true
2192020-05-14T14:48:53 <vasild> ResolveSubNet("::AAAA:0:0/80").Match(ResolveIP("1.2.3.4")) -- is true
2202020-05-14T14:49:06 <vasild> but
2212020-05-14T14:49:10 <vasild> ResolveSubNet("::FFFF:0:0/96").Match(ResolveIP("1.2.3.4")) -- is false
2222020-05-14T14:49:37 <vasild> is this a bug?
2232020-05-14T14:51:46 <vasild> I think it is strange to match IPv4 addresses as belonging to some IPv6 network, so IMO all should be false. But if I accept that we should, for some reason, match IPv4 addresses as belonging to some IPv6 networks, then also the last one should be true.
2242020-05-14T14:53:52 <vasild> It is not true because "::FFFF:0:0" is interpreted as an IPv4 address (0.0.0.0) and the netmask /96 bricks it. It is the same as "0.0.0.0/96".
2252020-05-14T14:54:45 <wumpus> it's somewhat strange, but it's a by-effect of IPv4 addresses have always been encoded as a kind of IPv6 address in bitcoin
2262020-05-14T14:55:14 <wumpus> not sure this should affect anything in practice
2272020-05-14T14:56:54 <vasild> What about stopping to accept IPv4 as IPv6 addresses? That is - all of the above return false?
2282020-05-14T14:57:16 <vasild> Sorry, "stopping to accept IPv4 as belonging to some IPv6 networks"
2292020-05-14T14:59:45 <vasild> I am modifying this code wrt ADDRv2 and the new code would return false for all of the above 3 tests. So I wonder if this change in behavior would be ok. In order to mimic the current (strange) behavor a few twists and tweaks would have to be made to the new code, making it less straight forward and a bit more difficult to review.
2302020-05-14T15:00:02 *** gonemad3 has quit IRC
2312020-05-14T15:11:27 <vasild> I will go for "no change in behavior" (+some twists in the patch). If it turns out that we don't need to accept IPv4 as part of IPv6 networks (e.g. `::/0`), then the patch can be simplified.
2322020-05-14T15:16:06 *** maxfragg1 has joined #bitcoin-core-dev
2332020-05-14T15:17:18 <wumpus> I think that's fine, I don't think it'll affect anything in practice
2342020-05-14T15:17:35 <wumpus> there's no reason to do mixed IPv6 IPv4 subnet matching
2352020-05-14T15:18:19 <wumpus> so having it always return false if someone tries seems ok to me
2362020-05-14T15:19:23 *** Izl has quit IRC
2372020-05-14T15:19:58 <vasild> ah, excellent!
2382020-05-14T15:23:16 *** Brenna40Balistre has joined #bitcoin-core-dev
2392020-05-14T15:24:41 *** DeanGuss has joined #bitcoin-core-dev
2402020-05-14T15:26:01 *** Brenna40Balistre has quit IRC
2412020-05-14T15:27:08 *** Kelsi26Mitchell has joined #bitcoin-core-dev
2422020-05-14T15:29:19 *** proofofkeags has quit IRC
2432020-05-14T15:29:49 *** Leonie66Hegmann has joined #bitcoin-core-dev
2442020-05-14T15:29:54 *** proofofkeags has joined #bitcoin-core-dev
2452020-05-14T15:32:01 *** russo has joined #bitcoin-core-dev
2462020-05-14T15:33:12 *** goatpig has quit IRC
2472020-05-14T15:34:12 *** proofofkeags has quit IRC
2482020-05-14T15:35:12 *** proofofkeags has joined #bitcoin-core-dev
2492020-05-14T15:39:51 *** brianhoffman has joined #bitcoin-core-dev
2502020-05-14T15:43:07 *** Pavlenex has joined #bitcoin-core-dev
2512020-05-14T15:43:50 *** Leonie66Hegmann has quit IRC
2522020-05-14T15:44:39 <Pavlenex> Hello. I've asked before but got no reply. Serbian translation for 0.20 is ready, it was translated from scratch basically as the language never got much translators. However the language does not have a coordinator or reviewer so it can't be pushed as complete. Who is in charge of Transifex that can provide me with an access so we can proceed? Thanks.
2532020-05-14T15:53:00 <wumpus> Pavlenex: I should be able to set someone as coordinator
2542020-05-14T15:54:14 <Pavlenex> wumpus: Hey! https://www.transifex.com/user/profile/nedved/ is my transifex username. However if you want to set somebody else from that team instead, it's fine as long as we can proceed with a review.
2552020-05-14T15:55:49 *** justanotheruser has quit IRC
2562020-05-14T15:56:50 <Pavlenex> If I can suggest alternative member that would be casperBGD, he continued on my initial efforts and completed the translations. Thanks in advance.
2572020-05-14T15:56:54 *** bitcoin-git has joined #bitcoin-core-dev
2582020-05-14T15:56:55 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/5747c4ca1bf8...7d87ba0e0227
2592020-05-14T15:56:55 <bitcoin-git> bitcoin/0.20 7d87ba0 MarcoFalke: travis: Remove valgrind
2602020-05-14T15:56:57 *** bitcoin-git has left #bitcoin-core-dev
2612020-05-14T15:57:28 *** bitcoin-git has joined #bitcoin-core-dev
2622020-05-14T15:57:29 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/7d87ba0e0227...aa7c6858e6e4
2632020-05-14T15:57:29 <bitcoin-git> bitcoin/0.20 aa7c685 MarcoFalke: travis: Remove s390x
2642020-05-14T15:57:31 *** bitcoin-git has left #bitcoin-core-dev
2652020-05-14T15:57:37 <wumpus> Pavlenex: okay! let me see
2662020-05-14T16:01:09 <wumpus> Pavlenex: I added you as coordinator for all the Serbian languages, I think you should be able to add other reviewers now
2672020-05-14T16:02:03 <Pavlenex> wumpus: Yup, just got the notification. Thanks. I'll try to begin the review process asap.
2682020-05-14T16:02:20 <wumpus> thank you!
2692020-05-14T16:03:14 *** molz_ has quit IRC
2702020-05-14T16:05:45 *** geeker has joined #bitcoin-core-dev
2712020-05-14T16:10:45 *** promag has quit IRC
2722020-05-14T16:12:45 *** justanotheruser has joined #bitcoin-core-dev
2732020-05-14T16:23:23 *** vasild has quit IRC
2742020-05-14T16:26:39 *** lightlike has joined #bitcoin-core-dev
2752020-05-14T16:30:46 *** bitcoin-git has joined #bitcoin-core-dev
2762020-05-14T16:30:46 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
2772020-05-14T16:30:47 *** bitcoin-git has left #bitcoin-core-dev
2782020-05-14T16:31:06 *** bitcoin-git has joined #bitcoin-core-dev
2792020-05-14T16:31:06 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
2802020-05-14T16:31:07 *** bitcoin-git has left #bitcoin-core-dev
2812020-05-14T16:32:35 *** jb55 has quit IRC
2822020-05-14T16:32:50 *** mol has joined #bitcoin-core-dev
2832020-05-14T16:35:00 *** vasild has joined #bitcoin-core-dev
2842020-05-14T16:35:57 *** jb55 has joined #bitcoin-core-dev
2852020-05-14T16:42:13 *** jonatack has joined #bitcoin-core-dev
2862020-05-14T16:42:27 *** bitcoin-git has joined #bitcoin-core-dev
2872020-05-14T16:42:27 <bitcoin-git> [bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
2882020-05-14T16:42:29 *** bitcoin-git has left #bitcoin-core-dev
2892020-05-14T16:43:52 *** bitcoin-git has joined #bitcoin-core-dev
2902020-05-14T16:43:52 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
2912020-05-14T16:43:53 *** bitcoin-git has left #bitcoin-core-dev
2922020-05-14T16:48:29 *** andrewtoth has joined #bitcoin-core-dev
2932020-05-14T16:53:47 *** molakala has quit IRC
2942020-05-14T16:58:08 *** bitcoin-git has joined #bitcoin-core-dev
2952020-05-14T16:58:09 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
2962020-05-14T16:58:10 *** bitcoin-git has left #bitcoin-core-dev
2972020-05-14T17:00:07 <theStack> jnewbery: i posted the results of my getcfcheckpt cache (#18960) research in the PR thread, with a link to the script; there doesn't seem to be any difference, any request up to block 630000 takes 50ms on my machine
2982020-05-14T17:00:09 <gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
2992020-05-14T17:03:52 *** promag has joined #bitcoin-core-dev
3002020-05-14T17:04:13 *** promag_ has joined #bitcoin-core-dev
3012020-05-14T17:07:24 *** timothy has quit IRC
3022020-05-14T17:08:36 <MarcoFalke> hi, I won't make it to today's meeting, but I'd like to put something up for high prio
3032020-05-14T17:08:38 <MarcoFalke> #proposedmeetingtopic Add #18638 to high prio (MarcoFalke, not actually a topic)
3042020-05-14T17:08:40 <gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
3052020-05-14T17:16:36 *** tmoc has joined #bitcoin-core-dev
3062020-05-14T17:17:46 *** Kiminuo has joined #bitcoin-core-dev
3072020-05-14T17:22:33 *** russo_ has joined #bitcoin-core-dev
3082020-05-14T17:24:12 *** russo has quit IRC
3092020-05-14T17:26:49 *** bitcoin-git has joined #bitcoin-core-dev
3102020-05-14T17:26:50 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b9c504cbc4ba...4dd2e5255a7f
3112020-05-14T17:26:51 <bitcoin-git> bitcoin/master fa182a8 MarcoFalke: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T...
3122020-05-14T17:26:51 <bitcoin-git> bitcoin/master fa1f840 MarcoFalke: rpcwallet: Replace pwallet-> with wallet.
3132020-05-14T17:26:52 <bitcoin-git> bitcoin/master 4dd2e52 Wladimir J. van der Laan: Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple a...
3142020-05-14T17:26:53 *** bitcoin-git has left #bitcoin-core-dev
3152020-05-14T17:27:09 *** bitcoin-git has joined #bitcoin-core-dev
3162020-05-14T17:27:10 <bitcoin-git> [bitcoin] laanwj merged pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
3172020-05-14T17:27:11 *** bitcoin-git has left #bitcoin-core-dev
3182020-05-14T17:34:25 *** russo_ has quit IRC
3192020-05-14T17:38:38 *** Sentineo has quit IRC
3202020-05-14T17:41:49 *** gzhao408 has joined #bitcoin-core-dev
3212020-05-14T17:48:44 *** Sentineo has joined #bitcoin-core-dev
3222020-05-14T17:51:28 *** Pavlenex has quit IRC
3232020-05-14T17:53:17 *** gzhao408 has quit IRC
3242020-05-14T18:00:02 *** maxfragg1 has quit IRC
3252020-05-14T18:00:50 *** Kiminuo has quit IRC
3262020-05-14T18:00:51 *** bitcoin-git has joined #bitcoin-core-dev
3272020-05-14T18:00:52 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4dd2e5255a7f...2d7489be8f77
3282020-05-14T18:00:52 <bitcoin-git> bitcoin/master 061acf6 fanquake: scripts: no-longer check for 32 bit windows in security-check.py
3292020-05-14T18:00:53 <bitcoin-git> bitcoin/master 13f606b fanquake: scripts: remove NONFATAL from security-check.py
3302020-05-14T18:00:53 <bitcoin-git> bitcoin/master 83d063e fanquake: scripts: add run_command to security-check.py
3312020-05-14T18:00:55 *** bitcoin-git has left #bitcoin-core-dev
3322020-05-14T18:01:11 *** bitcoin-git has joined #bitcoin-core-dev
3332020-05-14T18:01:11 <bitcoin-git> [bitcoin] laanwj merged pull request #18796: scripts: security-check.py refactors (master...security_check_no_more_32bit) https://github.com/bitcoin/bitcoin/pull/18796
3342020-05-14T18:01:12 *** bitcoin-git has left #bitcoin-core-dev
3352020-05-14T18:18:49 *** owowo has joined #bitcoin-core-dev
3362020-05-14T18:19:21 *** kik1 has joined #bitcoin-core-dev
3372020-05-14T18:27:37 *** pinheadmz has quit IRC
3382020-05-14T18:31:16 *** molakala has joined #bitcoin-core-dev
3392020-05-14T18:32:54 *** geeker has quit IRC
3402020-05-14T18:32:58 *** tryphe has quit IRC
3412020-05-14T18:33:11 *** tryphe has joined #bitcoin-core-dev
3422020-05-14T18:33:53 *** pinheadmz has joined #bitcoin-core-dev
3432020-05-14T18:42:31 *** theStack has quit IRC
3442020-05-14T18:43:11 *** promag has quit IRC
3452020-05-14T18:43:45 *** promag has joined #bitcoin-core-dev
3462020-05-14T18:44:22 *** bitcoin-git has joined #bitcoin-core-dev
3472020-05-14T18:44:22 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d7489be8f77...553bb3fc3d95
3482020-05-14T18:44:23 <bitcoin-git> bitcoin/master 7467366 John Newbery: [net processing] Only send a getheaders for one block in an INV
3492020-05-14T18:44:24 <bitcoin-git> bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
3502020-05-14T18:44:25 *** bitcoin-git has left #bitcoin-core-dev
3512020-05-14T18:44:42 *** bitcoin-git has joined #bitcoin-core-dev
3522020-05-14T18:44:42 <bitcoin-git> [bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
3532020-05-14T18:44:43 *** bitcoin-git has left #bitcoin-core-dev
3542020-05-14T18:46:30 *** ctrlbreak has quit IRC
3552020-05-14T18:46:56 *** ctrlbreak has joined #bitcoin-core-dev
3562020-05-14T18:56:01 *** Kiminuo has joined #bitcoin-core-dev
3572020-05-14T18:57:48 *** dgenr8 has quit IRC
3582020-05-14T19:00:31 <wumpus> #startmeeting
3592020-05-14T19:00:31 <lightningbot> Meeting started Thu May 14 19:00:31 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3602020-05-14T19:00:31 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3612020-05-14T19:00:38 <kanzure> hi
3622020-05-14T19:00:44 <sipsorcery> hi
3632020-05-14T19:00:53 <elichai2> Hi
3642020-05-14T19:00:55 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
3652020-05-14T19:00:57 <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
3662020-05-14T19:01:00 <jonasschnelli> Hi
3672020-05-14T19:01:03 *** per has quit IRC
3682020-05-14T19:01:04 <hebasto> hi
3692020-05-14T19:01:05 <jnewbery> hi
3702020-05-14T19:01:08 <fjahr> hi
3712020-05-14T19:01:10 <jkczyz> hi
3722020-05-14T19:01:33 <meshcollider> hi
3732020-05-14T19:01:35 <aj> hi
3742020-05-14T19:01:48 <jeremyrubin> hola
3752020-05-14T19:02:07 <wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (only a suggestion for high prio for review)
3762020-05-14T19:02:48 <achow101> hi
3772020-05-14T19:03:04 <jeremyrubin> w.r.t. hi prio, i'd like to get the mempool project back on track it's review blocked
3782020-05-14T19:03:15 <sipa> i have a topic: ok to update to boost 1.59? and if so, when?
3792020-05-14T19:03:19 <wumpus> any any last minute proposals?
3802020-05-14T19:03:51 <wumpus> sipa: sgtm (though I'm not sure everyone is here wrt that discussion)
3812020-05-14T19:04:01 <wumpus> #topic High priority for review
3822020-05-14T19:04:35 <wumpus> Add #18638 to high prio (MarcoFalke, not actually a topic)
3832020-05-14T19:04:37 <gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
3842020-05-14T19:05:01 <jnewbery> Could we add #18960 as a blocker?
3852020-05-14T19:05:02 <gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
3862020-05-14T19:05:23 *** sdaftuar has quit IRC
3872020-05-14T19:05:26 <wumpus> sure
3882020-05-14T19:05:59 <wumpus> added
3892020-05-14T19:06:06 <jnewbery> thanks!
3902020-05-14T19:06:06 *** sdaftuar has joined #bitcoin-core-dev
3912020-05-14T19:06:58 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 6 blockers, 1 bugfix, 4 chasing concept ACK now
3922020-05-14T19:07:21 <jeremyrubin> Can we add https://github.com/bitcoin/bitcoin/pull/18191?
3932020-05-14T19:07:24 <wumpus> jeremyrubin: do you have any specific suggestions wrt prs?
3942020-05-14T19:07:28 <wumpus> ah thanks
3952020-05-14T19:08:12 <wumpus> added
3962020-05-14T19:09:28 <wumpus> #topic required boost to 1.59 (sipa)
3972020-05-14T19:09:50 <sipa> hi
3982020-05-14T19:10:04 <wumpus> see also #8875
3992020-05-14T19:10:04 <sipa> i'm considering various approaches to improving to some of the p2p tx download logic
4002020-05-14T19:10:05 <gribble> https://github.com/bitcoin/bitcoin/issues/8875 | Bump minimum required Boost version · Issue #8875 · bitcoin/bitcoin · GitHub
4012020-05-14T19:10:51 <sipa> and one of them would rely on boost multi_index's ranked indexes
4022020-05-14T19:11:00 <sipa> which were added in boost 1.59
4032020-05-14T19:11:14 <sipa> so i was wondering if that's a possibility for 0.21
4042020-05-14T19:11:23 <sipa> or if i should consider other options (which i may do anyway)
4052020-05-14T19:11:24 <wumpus> that seems a fair enough reason
4062020-05-14T19:11:42 * luke-jr grumbles about RHEL/CentOS packages being hard to search
4072020-05-14T19:11:49 <wumpus> I think the most important thing to check is the versions in currently supported linux distros for building
4082020-05-14T19:12:14 <wumpus> "Version 1.59.0 August 13th, 2015 15:23 GMT" that sounds old enough, but knowing what old crap some distros ship with, it doesn't say everything
4092020-05-14T19:12:42 <sipa> well if we're going to be building with c++17, it seems we'd be relying on compilers newer than that anyway
4102020-05-14T19:13:01 <hebasto> https://github.com/bitcoin/bitcoin/pull/16381#issuecomment-511277755
4112020-05-14T19:13:03 <wumpus> yes
4122020-05-14T19:13:16 <jeremyrubin> sipa: ranked indexes look pretty cool
4132020-05-14T19:13:21 <sipa> they're very cool
4142020-05-14T19:13:32 <luke-jr> sounds like RHEL/CentOS 8 has boost 1.66
4152020-05-14T19:13:56 <wumpus> sipa: the dumbest way to find out would be to do a PR that uses that feature and see if it passes travis :)
4162020-05-14T19:14:14 <wumpus> luke-jr: oh! that's surprisingly new
4172020-05-14T19:14:14 <luke-jr> Debian has 1.67
4182020-05-14T19:14:40 <sipa> ok, will try opening a dummy PR and see what happens
4192020-05-14T19:14:43 <sipa> good enough for me
4202020-05-14T19:14:48 <jeremyrubin> does it make sense to do a minimum bump for feature or to bump to the highest minimum target we support?
4212020-05-14T19:14:51 <luke-jr> wumpus: not 100% sure
4222020-05-14T19:15:07 <wumpus> well sipa has a good reason now
4232020-05-14T19:15:08 <jeremyrubin> sipa: maybe check there's no bug-fixes to that new functionality in newer versions?
4242020-05-14T19:15:22 <wumpus> the reason #16381 was closed is that it wasn't important/urgent at the time
4252020-05-14T19:15:23 <gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
4262020-05-14T19:15:36 <sipa> 1.64 has a bug fix related to ranked indices
4272020-05-14T19:15:48 *** Pavlenex has joined #bitcoin-core-dev
4282020-05-14T19:15:56 <jeremyrubin> sipa: how severe?
4292020-05-14T19:15:58 <sipa> but the bug is just something that doesn't compile, which should
4302020-05-14T19:16:01 <sipa> so not severe at all
4312020-05-14T19:16:21 <wumpus> "it's eight years old" isn't enough to bump a minimum version, "I need this new data structure" well might be
4322020-05-14T19:16:58 <luke-jr> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/8.0_release_notes/index "Boost updated to version 1.66"
4332020-05-14T19:17:08 <wumpus> we already use boost 1.70 in depends so that's definitely new enough
4342020-05-14T19:17:15 <sipa> oh!
4352020-05-14T19:17:16 <sipa> ok
4362020-05-14T19:17:38 <wumpus> so yeah the current version used for gitian builds doesn't need to be bumped, only the minimum version
4372020-05-14T19:17:43 <sipa> that's enough for my topic
4382020-05-14T19:17:45 <jeremyrubin> sipa: are you adding this to mempool or to a diff data structure?
4392020-05-14T19:17:48 <wumpus> (supported at all)
4402020-05-14T19:18:07 <luke-jr> Ubuntu LTS is at 1.71
4412020-05-14T19:18:14 <luke-jr> Arch has 1.72
4422020-05-14T19:18:15 <jeremyrubin> Just worried that if it goes to mempool multiindex it looks like there's a non-trivial perfromance overhead on all erases
4432020-05-14T19:18:24 <luke-jr> Gentoo stablre is 1.72
4442020-05-14T19:18:25 <wumpus> if luke-jr is right it's complely uncontroversial to bump the minimum to 1.59
4452020-05-14T19:18:28 <jeremyrubin> but this is less build systemy and more about how you're using it
4462020-05-14T19:18:46 <wumpus> (it likely depends on CenOS which is alwasys slowest)
4472020-05-14T19:19:18 <luke-jr> SuSE is 1.66
4482020-05-14T19:19:25 <sipa> jeremyrubin: no, this is unrelated to mempool
4492020-05-14T19:19:29 <luke-jr> any other popular distros these days?
4502020-05-14T19:19:40 <sipa> it's in net processing
4512020-05-14T19:19:57 <jeremyrubin> cool looking forward to seeing it.
4522020-05-14T19:20:48 <jeremyrubin> use might actually have some speedups for mempool come to think of it for the eviction logic & mining logic. will noodle on that.
4532020-05-14T19:21:50 <wumpus> any other topics for this week?
4542020-05-14T19:21:59 <wumpus> PSA: we're wrapping up 0.20.0rc2 at the moment
4552020-05-14T19:22:05 <sipa> they add 1 pointer memory usage per entry, fwiw (compared to ordered_index)
4562020-05-14T19:22:11 <luke-jr> wumpus: do you want me to try to reduce the size of my 0.20 release tarball fixes PR?
4572020-05-14T19:22:17 <wumpus> #18973
4582020-05-14T19:22:19 <gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
4592020-05-14T19:22:22 <wumpus> (finally)
4602020-05-14T19:22:24 <jeremyrubin> sipa: it's the log n erase that's more worrisome
4612020-05-14T19:22:46 <wumpus> luke-jr: sure, but we're not going to hold up the rc on it
4622020-05-14T19:23:37 <luke-jr> wumpus: it's a security violation for users who build from source
4632020-05-14T19:23:44 *** tryphe_ has joined #bitcoin-core-dev
4642020-05-14T19:23:45 <luke-jr> to answer how relevant it is
4652020-05-14T19:24:08 <wumpus> how so?
4662020-05-14T19:24:11 <luke-jr> and can result in leaking user private info to the network
4672020-05-14T19:24:25 <luke-jr> wumpus: it's looking at every parent directory to the source code for a git repo
4682020-05-14T19:24:33 <wumpus> I mean, it's been absurd how long it's taking to roll this release
4692020-05-14T19:24:33 <luke-jr> and taking whatever HEAD hash it finds into the version number
4702020-05-14T19:25:03 <luke-jr> pulling a hash out of an unrelated git repo the user might have, and publishing it, isn't very nice
4712020-05-14T19:25:16 <wumpus> I agree
4722020-05-14T19:25:19 <sipa> that sounds like something we should fix
4732020-05-14T19:25:29 <luke-jr> (Gentoo will kill the build instead)
4742020-05-14T19:26:01 <wumpus> but honestly we should cut a release at some point, there's aalways some edge case
4752020-05-14T19:26:13 <luke-jr> this is a regression, too
4762020-05-14T19:27:16 <wumpus> also #18902 rewrites a large part of the gitian descriptor and changes 6 files, can't this be fixed with some small patch?
4772020-05-14T19:27:18 <gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
4782020-05-14T19:27:21 *** tryphe has quit IRC
4792020-05-14T19:27:32 <luke-jr> probably
4802020-05-14T19:27:55 <luke-jr> I was trying to avoid conflicts with the autogen fix, but I guess we're missing that?
4812020-05-14T19:28:04 <wumpus> in any case: I agree it should be fixed, but I don't think it's terribly urgent
4822020-05-14T19:28:39 <hebasto> as a workaround a user could use BITCOIN_GENBUILD_NO_GIT variable
4832020-05-14T19:28:59 <luke-jr> maybe a release notes mention of the known issues
4842020-05-14T19:29:07 <wumpus> yes
4852020-05-14T19:29:21 <wumpus> I think that's fine
4862020-05-14T19:31:11 <luke-jr> current draft is in wiki still? or git?
4872020-05-14T19:31:56 <wumpus> wiki https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft
4882020-05-14T19:32:09 *** dongcarl has quit IRC
4892020-05-14T19:32:15 <luke-jr> k, I'll see about writing something up for that
4902020-05-14T19:32:22 <wumpus> thanks!
4912020-05-14T19:32:56 <luke-jr> should I reduce the footprint of #18902 and/or #18909 also?
4922020-05-14T19:32:58 <gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
4932020-05-14T19:32:59 <gribble> https://github.com/bitcoin/bitcoin/issues/18909 | [0.20] Fix release tarball by luke-jr · Pull Request #18909 · bitcoin/bitcoin · GitHub
4942020-05-14T19:33:58 <luke-jr> would be nice to just get 18902 merged to master as-is to fix all the issues at once :x but maybe reducing 18909 makes more sense
4952020-05-14T19:35:30 <wumpus> fwiw the git_check_in_repo() check looks straightforward enough
4962020-05-14T19:35:42 <wumpus> why isn't that enough?
4972020-05-14T19:36:25 <wumpus> (or alternatively, check if a .git is in the top level of the source directory)
4982020-05-14T19:37:11 <wumpus> besides that change in genbuild.sh, are any other changes needed to fix this?
4992020-05-14T19:37:57 <hebasto> it is all about "version hack"
5002020-05-14T19:38:18 <hebasto> in gitian builds
5012020-05-14T19:38:28 <luke-jr> wumpus: we'd need to restore the "version hack"
5022020-05-14T19:38:38 <wumpus> luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
5032020-05-14T19:38:40 <luke-jr> the genbuild changes in 18902 are a proper fix for that
5042020-05-14T19:39:03 <wumpus> (I mean, in the right git repo)
5052020-05-14T19:39:22 <wumpus> yes my question is why isn't that the only change needed?
5062020-05-14T19:40:16 <wumpus> hebasto: so we can fix this by reverting a change too?
5072020-05-14T19:40:23 <hebasto> #18349 probably has simpler approach
5082020-05-14T19:40:24 <luke-jr> those are the only commits specific to 18902 - the other 3 are inherited from 18818
5092020-05-14T19:40:25 <gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
5102020-05-14T19:40:30 <wumpus> (at least in 0.20)
5112020-05-14T19:41:04 <hebasto> wumpus: not sure
5122020-05-14T19:41:44 <luke-jr> reverting a change would be the first commit of 18902 + restoring the "version hack"
5132020-05-14T19:42:05 <wumpus> ok
5142020-05-14T19:42:10 <luke-jr> (to literally revert, would be undoing all of the git-archive stuff)
5152020-05-14T19:42:18 <wumpus> so it's much more complex than I thought
5162020-05-14T19:42:38 <luke-jr> wumpus: it can be simplified with a few hours I suspect
5172020-05-14T19:42:41 <wumpus> let's just add a note to the release notes then
5182020-05-14T19:42:50 <wumpus> any other topics?
5192020-05-14T19:44:05 <wumpus> #endmeeting
5202020-05-14T19:44:05 <lightningbot> Meeting ended Thu May 14 19:44:05 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5212020-05-14T19:44:05 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.html
5222020-05-14T19:44:05 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.txt
5232020-05-14T19:44:05 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.log.html
5242020-05-14T19:46:26 <luke-jr> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft#known-bugs
5252020-05-14T19:46:52 *** TheRec has quit IRC
5262020-05-14T19:48:51 *** TheRec has joined #bitcoin-core-dev
5272020-05-14T19:48:51 *** TheRec has joined #bitcoin-core-dev
5282020-05-14T19:50:45 <wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most
5292020-05-14T19:54:02 <wumpus> FWIW for releases *and RCs all the version information in in configure.ac
5302020-05-14T19:54:19 <wumpus> I'm not sure what it gets from git at all
5312020-05-14T19:55:11 <sipa> random brainstorming (and highly unsure it's worth spending time on): what if we create a file that contains a list of (sha512 tree hash, version string) pairs, and at build time we compare the tree with that file, and use its name if found, tree hash otherwise
5322020-05-14T19:55:23 <sipa> that would disentangle version naming entirely from git
5332020-05-14T19:56:30 <wumpus> that's pretty much what git tags are
5342020-05-14T19:57:19 <wumpus> I mean all the version information is in configure.ac. My point is I don't see why any external information is needed.
5352020-05-14T19:57:31 <wumpus> neither from git tags nor any external file
5362020-05-14T19:57:50 <sipa> fair
5372020-05-14T19:58:27 <wumpus> this used to be differnt, to be clear, at some point the build process derives the rcX from the git tag
5382020-05-14T19:58:47 <wumpus> but we've already made everything explicit now
5392020-05-14T19:58:53 <sipa> oh, ok
5402020-05-14T19:58:55 <wumpus> derived*
5412020-05-14T19:58:57 <sipa> i was not aware of that
5422020-05-14T19:59:21 *** promag has quit IRC
5432020-05-14T19:59:31 *** fearbeag has quit IRC
5442020-05-14T19:59:37 *** promag has joined #bitcoin-core-dev
5452020-05-14T20:00:31 *** Pavlenex has quit IRC
5462020-05-14T20:00:59 <wumpus> no worries, I don't have a full grasp in the version logic actually used either :)
5472020-05-14T20:02:23 <luke-jr> wumpus: but then we can't build non-releases with correct version info?
5482020-05-14T20:03:06 <wumpus> luke-jr: what is 'correct version info' in that case anyway?
5492020-05-14T20:03:13 <luke-jr> [19:50:46] <wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most <-- I suppose we could just not publish the tarball
5502020-05-14T20:03:22 <luke-jr> wumpus: a commit hash abbreviation seems fine
5512020-05-14T20:03:53 <wumpus> well the tarballs are fine, they are for releases and thus contain correct version info
5522020-05-14T20:04:07 <luke-jr> something like git-describe
5532020-05-14T20:04:09 <wumpus> they don't need *any* reference to git
5542020-05-14T20:04:21 <luke-jr> wumpus: currently, they don't..
5552020-05-14T20:04:23 *** promag has quit IRC
5562020-05-14T20:04:34 <wumpus> luke-jr: they contain configure.ac, which has all the version info
5572020-05-14T20:04:50 <wumpus> including rc level
5582020-05-14T20:05:00 *** promag has joined #bitcoin-core-dev
5592020-05-14T20:06:21 <wumpus> I know this because I have to set this every time before a rc
5602020-05-14T20:06:31 <luke-jr> hmm
5612020-05-14T20:10:11 *** sipsorcery has quit IRC
5622020-05-14T20:27:15 *** promag has quit IRC
5632020-05-14T20:27:31 *** promag has joined #bitcoin-core-dev
5642020-05-14T20:28:12 *** surja795 has joined #bitcoin-core-dev
5652020-05-14T20:32:36 *** promag has quit IRC
5662020-05-14T20:33:12 *** promag has joined #bitcoin-core-dev
5672020-05-14T20:35:20 *** tryphe_ is now known as tryphe
5682020-05-14T20:46:27 *** emilengler has quit IRC
5692020-05-14T21:00:02 *** kik1 has quit IRC
5702020-05-14T21:00:59 *** Kiminuo has quit IRC
5712020-05-14T21:04:34 *** Chris_Stewart_5 has quit IRC
5722020-05-14T21:05:12 *** molakala has quit IRC
5732020-05-14T21:11:37 *** CubicEarth has quit IRC
5742020-05-14T21:17:06 *** Highway61 has quit IRC
5752020-05-14T21:17:59 *** alexsuraci has joined #bitcoin-core-dev
5762020-05-14T21:22:09 *** manantial has quit IRC
5772020-05-14T21:22:14 *** _Francisco_ has joined #bitcoin-core-dev
5782020-05-14T21:23:54 *** CubicEarth has joined #bitcoin-core-dev
5792020-05-14T21:25:14 *** Guyver2 has quit IRC
5802020-05-14T21:33:28 *** surja795 has quit IRC
5812020-05-14T21:34:02 *** surja795 has joined #bitcoin-core-dev
5822020-05-14T21:35:26 *** shesek has quit IRC
5832020-05-14T21:37:23 *** shesek has joined #bitcoin-core-dev
5842020-05-14T21:37:23 *** shesek has joined #bitcoin-core-dev
5852020-05-14T21:38:39 *** surja795 has quit IRC
5862020-05-14T21:41:12 *** promag_ has quit IRC
5872020-05-14T21:42:12 *** shesek has quit IRC
5882020-05-14T21:43:23 *** mol has quit IRC
5892020-05-14T21:44:37 *** troygiorshev has quit IRC
5902020-05-14T21:46:07 *** Highway61 has joined #bitcoin-core-dev
5912020-05-14T21:46:33 *** mol has joined #bitcoin-core-dev
5922020-05-14T21:49:13 *** filchef has quit IRC
5932020-05-14T22:05:55 *** dfmbbtc has joined #bitcoin-core-dev
5942020-05-14T22:09:28 *** dfmb_ has quit IRC
5952020-05-14T22:20:50 *** troygiorshev has joined #bitcoin-core-dev
5962020-05-14T22:27:40 *** dfmbbtc has quit IRC
5972020-05-14T22:38:07 *** marcoagner has quit IRC
5982020-05-14T22:45:14 *** bitcoin-git has joined #bitcoin-core-dev
5992020-05-14T22:45:15 <bitcoin-git> [bitcoin] sipa opened pull request #18977: Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
6002020-05-14T22:45:15 *** bitcoin-git has left #bitcoin-core-dev
6012020-05-14T22:50:22 *** troygiorshev has quit IRC
6022020-05-14T22:50:28 *** jarthur has joined #bitcoin-core-dev
6032020-05-14T22:59:17 *** tryphe_ has joined #bitcoin-core-dev
6042020-05-14T22:59:30 *** tryphe has quit IRC
6052020-05-14T23:00:01 *** andrewtoth has quit IRC
6062020-05-14T23:06:46 *** mdunnio has quit IRC
6072020-05-14T23:10:37 <sipa> it seems xenial only have boost 1.58
6082020-05-14T23:11:47 <jeremyrubin> so.... not till 2021 then?
6092020-05-14T23:12:27 <jeremyrubin> (Xenial is 16.04 LTS, which goes out of mantenance and to security only in 2021
6102020-05-14T23:13:13 <jeremyrubin> Personally I think it's probably OK given that it's 4 LTS's old, but it is still in maintenance so conceivable someone is relying on it still...
6112020-05-14T23:14:21 <jeremyrubin> err 3 LTS's old, not 4 (or 2 depending on how you count the current one)
6122020-05-14T23:14:22 <MarcoFalke> copy the hpp to our repo? I wanted to remove boost for 0.22.0
6132020-05-14T23:14:40 <sipa> remove boost? how are you going to do that?
6142020-05-14T23:14:55 <jeremyrubin> MarcoFalke: IDK if it's feasible givent that multiindex uses like all of boost internally.
6152020-05-14T23:14:57 <MarcoFalke> Switch to c++17 ;)
6162020-05-14T23:15:21 <MarcoFalke> If we need a single boost file we could subtree that single file?
6172020-05-14T23:15:25 <sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
6182020-05-14T23:15:41 <sipa> it's a zillion .hpp files
6192020-05-14T23:15:46 <sipa> across various boost packages
6202020-05-14T23:15:51 <jeremyrubin> MarcoFalke: I don't think that's feasible, you can try bcp'ing multiindex out and it's big
6212020-05-14T23:16:11 <MarcoFalke> Ok, didn't know how big it is
6222020-05-14T23:16:50 <sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
6232020-05-14T23:16:51 <sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
6242020-05-14T23:16:54 <sipa> heh
6252020-05-14T23:16:58 <sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
6262020-05-14T23:17:01 <sipa> 78
6272020-05-14T23:17:08 <MarcoFalke> ouch
6282020-05-14T23:17:21 <jeremyrubin> Oh 78? I thought surely it was more than 80, so let's do it!
6292020-05-14T23:17:39 <sipa> which depends on boost mpl, boost move, a bunch of shared boost utility stuff, ...
6302020-05-14T23:18:00 <MarcoFalke> fanquake: Looks like you can do your bump ^
6312020-05-14T23:18:06 <jeremyrubin> MarcoFalke: OTOH rewriting multiindex for our specific use cases seems doable.
6322020-05-14T23:18:09 <sipa> boost mpl is 1045 files...
6332020-05-14T23:18:22 <fanquake> ð
6342020-05-14T23:18:42 <MarcoFalke> jeremyrubin: Can you write one in less than 100 LOC (clang-formatted)?
6352020-05-14T23:18:47 <sipa> lol
6362020-05-14T23:19:04 <sipa> i do not want to write and maintain a copy of multi_index
6372020-05-14T23:19:10 <jeremyrubin> You can't even define a concrete type for the one we have in less than 100 LOC
6382020-05-14T23:19:17 <sipa> wahaha
6392020-05-14T23:19:23 *** DeanGuss has quit IRC
6402020-05-14T23:20:00 <jeremyrubin> sipa: I think it wouldn't be writing a custom one, but writing a non template concrete impl for the one that we currently use.
6412020-05-14T23:20:23 <sipa> jeremyrubin: i spent 2 weeks trying to design a custom data structure for the thing i want :)
6422020-05-14T23:20:26 <sipa> and gave up
6432020-05-14T23:20:43 <jeremyrubin> Yeah. I'm just prodding MarcoFalke if he wants to ever get rid of boost
6442020-05-14T23:21:19 <sipa> i mean, it obviously could be done
6452020-05-14T23:21:46 <sipa> but it'd be far harder to review, and a properly abstracted version would like tend to have some minimal multi_index like reimplementation anyway
6462020-05-14T23:22:24 <luke-jr> sipa: jeremyrubin: since when do we support anything more than the latest LTS?
6472020-05-14T23:22:38 <sipa> MarcoFalke: i think as an intermediate goal maybe it's worth trying to only have header-only boost dependencies
6482020-05-14T23:22:42 <luke-jr> MarcoFalke: copying the hpp is strictly worse than depending on boost
6492020-05-14T23:22:50 <luke-jr> removing boost doesn't seem like a goal
6502020-05-14T23:22:58 <luke-jr> just using C++11 (or C++17 eventually) instead
6512020-05-14T23:23:13 <sipa> i think replacing boost with standard replacements when they're appropriate is great
6522020-05-14T23:23:19 <sipa> removing boost at all costs seems counter-productive
6532020-05-14T23:23:24 <luke-jr> exactly
6542020-05-14T23:23:41 <luke-jr> and we want to add boost::process soon for several things
6552020-05-14T23:23:53 <luke-jr> which AFAIK there is no C++ std alternative to
6562020-05-14T23:24:00 <sipa> what for?
6572020-05-14T23:24:02 <sipa> (just curous)
6582020-05-14T23:24:12 <jeremyrubin> smooth brain: replacing boost multiindex; galaxy brain: getting multiindex into c++next std
6592020-05-14T23:24:25 <luke-jr> sipa: HWI, Tor, IIRC there were a few others
6602020-05-14T23:24:39 <sipa> jeremyrubin: great, let's switch to C++29
6612020-05-14T23:24:47 <MarcoFalke> ACK
6622020-05-14T23:25:36 <jeremyrubin> TBH capnproto sounds like a better step to do than boost::process
6632020-05-14T23:25:40 *** DeanGuss has joined #bitcoin-core-dev
6642020-05-14T23:25:59 <jeremyrubin> Should be able to handle similar use cases?
6652020-05-14T23:26:18 <sipa> ?
6662020-05-14T23:26:30 <sipa> i don't see how they're related
6672020-05-14T23:27:03 <luke-jr> jeremyrubin: totally different things..
6682020-05-14T23:27:13 <jeremyrubin> Isn't boost::process just some inter-process glue stuff? IIRC capnproto allows you to setup similar constructs but I could be off.
6692020-05-14T23:27:28 <luke-jr> boost::process lets us manage running other processes
6702020-05-14T23:27:29 <sipa> jeremyrubin: that's like saying JSON can replace TCP-IP
6712020-05-14T23:28:06 <jeremyrubin> gotcha, I just glanced at boost::process and saw that it was talking about IPC stuff
6722020-05-14T23:28:46 <sipa> i'm not convinced we need boost::process btw, but i haven't thought hard about it
6732020-05-14T23:32:02 *** _Francisco_ has quit IRC
6742020-05-14T23:32:15 *** gzhao408 has joined #bitcoin-core-dev
6752020-05-14T23:32:51 <MarcoFalke> If we require boost::process, we also need to ditch bionic
6762020-05-14T23:34:04 <fanquake> Just require Debian sid from here on out
6772020-05-14T23:36:44 <MarcoFalke> At least the switch to C++20 will be included for free /s
6782020-05-14T23:37:35 <luke-jr> latest stable Ubuntu is focal
6792020-05-14T23:37:58 <luke-jr> anything older is not guaranteed supported
6802020-05-14T23:38:26 <luke-jr> also, boost::process can/will probably be optional at first?
6812020-05-14T23:39:14 *** justanotheruser has quit IRC
6822020-05-14T23:40:50 *** bitcoin-git has joined #bitcoin-core-dev
6832020-05-14T23:40:50 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
6842020-05-14T23:40:51 *** bitcoin-git has left #bitcoin-core-dev
6852020-05-14T23:41:10 *** bitcoin-git has joined #bitcoin-core-dev
6862020-05-14T23:41:10 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
6872020-05-14T23:41:11 *** bitcoin-git has left #bitcoin-core-dev
6882020-05-14T23:42:42 *** fearbeag has joined #bitcoin-core-dev
6892020-05-14T23:45:10 <MarcoFalke> And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
6902020-05-14T23:45:27 <sipa> which bug?
6912020-05-14T23:45:30 <MarcoFalke> https://github.com/boostorg/thread/issues/308
6922020-05-14T23:45:46 <sipa> ha
6932020-05-14T23:45:55 *** lightlike has quit IRC
6942020-05-14T23:46:03 <sipa> i think the quality differs a lot between boost libraries
6952020-05-14T23:46:46 <sipa> and for every goal, we should find the right solution
6962020-05-14T23:46:59 <sipa> whether that's boost or something else
6972020-05-14T23:47:29 <sipa> like... boost filesystem and boost shared_ptr effectively turned into c++ stl
6982020-05-14T23:47:44 <jeremyrubin> Well I think to MarcoFalke's point, if something like multiindex is thousands of files/78 modules
6992020-05-14T23:47:57 <sipa> yes, and it's great
7002020-05-14T23:48:03 <sipa> i know nothing that compares to it
7012020-05-14T23:48:14 <MarcoFalke> Just saying we should be cautious about pulling in dependencies
7022020-05-14T23:48:22 <sipa> MarcoFalke: absolutely
7032020-05-14T23:48:26 <jeremyrubin> I think MarcoFalke point is more around security than on features
7042020-05-14T23:48:35 *** troygiorshev has joined #bitcoin-core-dev
7052020-05-14T23:48:38 <sipa> but "it's boost" on itself is not a point against a particular solution
7062020-05-14T23:48:45 <sipa> "it's unmaintained" is
7072020-05-14T23:49:07 <sipa> or "it's a logistical pain for our build system" is
7082020-05-14T23:49:20 <fanquake> MarcoFalke: did you save the log that you wanted. I'm about to push more commits
7092020-05-14T23:49:45 <MarcoFalke> fanquake: I reset the build, which archives the log. Go ahead!
7102020-05-14T23:50:10 <MarcoFalke> Let's pray the issue is just a race in the test
7112020-05-14T23:50:26 <MarcoFalke> At least it is not a regression
7122020-05-14T23:51:48 <MarcoFalke> sipa: I guess your feature wouldn't make sense if it was enabled conditionally on boost multi_index being available?
7132020-05-14T23:52:21 <MarcoFalke> So xenial users can still compile, but wouldn't get your feature
7142020-05-14T23:52:47 <sipa> MarcoFalke: it can be worked around with O(n) complexity instead of O(log n)
7152020-05-14T23:53:32 <sipa> which is probably not terrible in practice, but harder to guarantee no remotely-triggerable extreme conditions that become very slow
7162020-05-14T23:54:12 *** AaronvanW has quit IRC
7172020-05-14T23:55:45 *** justanotheruser has joined #bitcoin-core-dev
7182020-05-14T23:56:42 <jeremyrubin> sipa: Out of curiosity for the design you're making, wouldn't you have to take an action for everything in that rank group anyways?
7192020-05-14T23:57:18 *** troygiorshev has quit IRC
7202020-05-14T23:57:38 <jeremyrubin> e.g., isn't this fundamentally O(N)?
7212020-05-14T23:57:42 <jeremyrubin> *ie
7222020-05-14T23:59:24 <sipa> jeremyrubin: no