12020-05-18T00:00:01 *** IOMonster1 has quit IRC
22020-05-18T00:00:59 <shesek> I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them
32020-05-18T00:02:26 *** proofofkeags has quit IRC
42020-05-18T00:05:04 *** SiAnDoG_ has quit IRC
52020-05-18T00:05:14 <shesek> and to make yet another not very useful request: it is somewhat annoying that `listtransactions` doesn't list the block height directly, but only the block hash and number of confirmations. it would typically mean that you'll need an extra rpc request per transaction to figure the height out (that's what electrum-personal-server does for example)
62020-05-18T00:05:23 <shesek> I hacked around it in a different way - I first check the tip, then fetch `listtransactions`, then make sure the tip hasn't moved in the meanwhile (and retry if it did), then calculate the block height is tip_height-confirmations+1. which isn't very ideal either :)
72020-05-18T00:05:26 *** SiAnDoG_ has joined #bitcoin-core-dev
82020-05-18T00:20:50 *** proofofkeags has joined #bitcoin-core-dev
92020-05-18T00:22:09 *** dhaumann has joined #bitcoin-core-dev
102020-05-18T00:28:31 *** mol_ has quit IRC
112020-05-18T00:31:27 *** mol has joined #bitcoin-core-dev
122020-05-18T00:38:44 <luke-jr> sipa: it might make sense to show the sum of fees pushing for unconfirmed transactions
132020-05-18T00:38:51 <luke-jr> ie, including descendants in it
142020-05-18T00:39:10 *** rottensox has joined #bitcoin-core-dev
152020-05-18T00:39:27 *** rottensox has left #bitcoin-core-dev
162020-05-18T00:43:00 *** surja795 has quit IRC
172020-05-18T00:44:05 *** surja795 has joined #bitcoin-core-dev
182020-05-18T01:16:13 *** proofofkeags has quit IRC
192020-05-18T01:16:50 *** proofofkeags has joined #bitcoin-core-dev
202020-05-18T01:21:12 *** Relis has quit IRC
212020-05-18T01:22:38 *** proofofkeags has quit IRC
222020-05-18T01:22:59 *** Relis has joined #bitcoin-core-dev
232020-05-18T01:24:13 *** justanotheruser has quit IRC
242020-05-18T01:24:16 <kanzure> shesek: document in a ticket
252020-05-18T01:28:03 *** per has quit IRC
262020-05-18T01:36:28 *** go11111111111 has joined #bitcoin-core-dev
272020-05-18T01:39:10 *** go121212 has quit IRC
282020-05-18T01:41:51 *** go121212 has joined #bitcoin-core-dev
292020-05-18T01:44:26 *** go11111111111 has quit IRC
302020-05-18T01:48:21 *** proofofkeags has joined #bitcoin-core-dev
312020-05-18T01:53:52 *** geeker has joined #bitcoin-core-dev
322020-05-18T01:54:10 *** geeker has joined #bitcoin-core-dev
332020-05-18T01:54:28 *** justanotheruser has joined #bitcoin-core-dev
342020-05-18T01:56:52 *** bitcoin-git has joined #bitcoin-core-dev
352020-05-18T01:56:52 <bitcoin-git> [bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
362020-05-18T01:56:53 *** bitcoin-git has left #bitcoin-core-dev
372020-05-18T01:56:59 <shesek> kanzure, ^
382020-05-18T02:31:45 *** mol has quit IRC
392020-05-18T02:34:57 *** mol has joined #bitcoin-core-dev
402020-05-18T02:37:57 *** shesek has quit IRC
412020-05-18T02:38:25 *** shesek has joined #bitcoin-core-dev
422020-05-18T02:38:25 *** shesek has joined #bitcoin-core-dev
432020-05-18T02:52:34 *** surja795 has quit IRC
442020-05-18T03:00:02 *** dhaumann has quit IRC
452020-05-18T03:17:14 *** belcher has quit IRC
462020-05-18T03:20:36 *** jeremyb has joined #bitcoin-core-dev
472020-05-18T03:21:00 *** jeremyb is now known as Guest18050
482020-05-18T03:31:12 *** mol has quit IRC
492020-05-18T03:38:11 *** Relis has quit IRC
502020-05-18T03:57:39 *** Eagle[TM] has joined #bitcoin-core-dev
512020-05-18T03:59:43 *** EagleTM has quit IRC
522020-05-18T04:07:03 * luke-jr prods people to review #17946 <.<
532020-05-18T04:07:04 <gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr · Pull Request #17946 · bitcoin/bitcoin · GitHub
542020-05-18T04:08:05 <luke-jr> (apparently this bug is causing segwit transactions to not get mined)
552020-05-18T04:12:15 *** proofofkeags has quit IRC
562020-05-18T04:12:30 *** morcos has quit IRC
572020-05-18T04:12:46 *** morcos has joined #bitcoin-core-dev
582020-05-18T04:12:50 *** proofofkeags has joined #bitcoin-core-dev
592020-05-18T04:15:02 *** morcos has quit IRC
602020-05-18T04:15:15 *** morcos has joined #bitcoin-core-dev
612020-05-18T04:17:36 *** proofofkeags has quit IRC
622020-05-18T04:20:00 *** vasild_ has joined #bitcoin-core-dev
632020-05-18T04:23:23 *** vasild has quit IRC
642020-05-18T04:23:24 *** vasild_ is now known as vasild
652020-05-18T04:27:19 *** go11111111111 has joined #bitcoin-core-dev
662020-05-18T04:29:47 *** go121212 has quit IRC
672020-05-18T04:31:40 *** bitdex has quit IRC
682020-05-18T04:32:25 *** bitdex has joined #bitcoin-core-dev
692020-05-18T04:53:23 *** TheHoliestRoger has quit IRC
702020-05-18T04:54:13 *** TheHoliestRoger has joined #bitcoin-core-dev
712020-05-18T04:59:40 <shesek> luke-jr, you helped convince me to avoid reporting a fee for incoming payments altogether, this is indeed pretty useless without taking parent and child fees into account as well. saved me a bunch work, thanks :p
722020-05-18T05:02:47 *** Dean_Guss has joined #bitcoin-core-dev
732020-05-18T05:05:05 *** tmoc has quit IRC
742020-05-18T05:06:00 *** tmoc has joined #bitcoin-core-dev
752020-05-18T05:06:47 *** mol has joined #bitcoin-core-dev
762020-05-18T05:12:05 *** Talkless has joined #bitcoin-core-dev
772020-05-18T05:19:05 *** mol has quit IRC
782020-05-18T05:23:38 *** davec has quit IRC
792020-05-18T05:32:07 *** davec has joined #bitcoin-core-dev
802020-05-18T05:38:18 *** mol has joined #bitcoin-core-dev
812020-05-18T05:47:32 *** cryptapus has quit IRC
822020-05-18T06:00:02 *** Guest18050 has quit IRC
832020-05-18T06:12:33 <hebasto> wumpus: kindly reminder -- is it time to upload rc2 to https://bitcoincore.org/bin/bitcoin-core-0.20.0/ ?
842020-05-18T06:15:39 *** EagleTM has joined #bitcoin-core-dev
852020-05-18T06:17:59 *** Eagle[TM] has quit IRC
862020-05-18T06:19:36 *** dfmb_ has joined #bitcoin-core-dev
872020-05-18T06:19:59 *** daim2k5 has joined #bitcoin-core-dev
882020-05-18T06:49:50 *** Guyver2 has joined #bitcoin-core-dev
892020-05-18T07:08:43 <shesek> sipa, getmempoolentry is useful indeed, not sure why I haven't considered it (I do ideally need this for confirmed transactions too, but its not as important). thanks.
902020-05-18T07:09:37 <shesek> but now I'm no longer sure that I should be providing raw feerate info for incoming transactions. what would be a sensible way to display fee information that takes ancestors/descendants into account to a user? ideally I'm thinking of a metric that says "if the miner clears transactions paying X sat/vB, this transaction should get included"
912020-05-18T07:11:17 *** tmoc has quit IRC
922020-05-18T07:11:56 <shesek> taking ancestors into account seems easy enough - total fees divided by total vsize. but descendants are more tricky because you only need to take the ones that increase the combined feerate into account, right?
932020-05-18T07:12:41 *** tmoc has joined #bitcoin-core-dev
942020-05-18T07:12:42 <shesek> I guess that means recursively iterating over `spentby` and figuring it out?
952020-05-18T07:13:13 <sipa> shesek: if you want to make a guess for inclusion... run getblocktemplate
962020-05-18T07:14:17 <sipa> perhaps we could expose a way that uses the same algorithm, but without the block weight/sigops restrictions, to have an idea how far down every transaction gets included
972020-05-18T07:15:51 <shesek> I'm not trying to determine the feerate needed to get included in the next block, I'm trying to tell how low the feerate has to be in order for the transaction package to get included
982020-05-18T07:17:02 <sipa> yeah, i know
992020-05-18T07:17:31 <shesek> oh, sorry. I misunderstood you. how can I use getblocktemplate for that?
1002020-05-18T07:18:08 <sipa> the current algorithm that GBT uses (but this is an implementation detail and subject to change) basically includes transactions in feerate order
1012020-05-18T07:18:19 <sipa> (package feerate)
1022020-05-18T07:18:56 <sipa> so you can see how far down in the GBT result you are, to see how many kB worth of block spaces goes to other transactions before it
1032020-05-18T07:19:03 <sipa> of course, that is restricted to 1 block
1042020-05-18T07:19:25 <sipa> but it's not too hard to modify things to have a (non-GBT) way to computing the same thing for more than just 1 block
1052020-05-18T07:24:59 <shesek> so basically make larger and larger blocks until I see the transaction is able to get in? clever, but terribly inefficient :)
1062020-05-18T07:26:09 <shesek> I guess there's no --bitcoin-unlimited parameter that would easily let me make blocks that are larger than the weight limit, right? :p
1072020-05-18T07:27:16 <shesek> but it wouldn't be relevant for my purposes anyway, its aimed for personal use on a low-resource environment
1082020-05-18T07:27:43 <sipa> not larger and larger; just once for a huge size, and keep track of the order
1092020-05-18T07:28:58 <shesek> assuming a very large mempool and a transaction that's paying a high fee rate relative to others, it could be quite wasteful. like, maybe it would've been enough to create a 10kb block, but you're creating a 50mb one instead anyway
1102020-05-18T07:29:58 <shesek> so hmm, how about I simply use `ancestorfees/ancestorsize`? this would at least take low feerate ancestors into account, making the feerate less misleading. it still won't take cpfp into account, but still better than just the raw feerate
1112020-05-18T07:31:46 <shesek> thanks for all the help and your time btw, its very appreciated
1122020-05-18T07:35:40 *** marcoagner has joined #bitcoin-core-dev
1132020-05-18T07:47:20 *** Pavlenex has joined #bitcoin-core-dev
1142020-05-18T08:00:59 *** kljasdfvv has joined #bitcoin-core-dev
1152020-05-18T08:03:19 *** marcoagner has quit IRC
1162020-05-18T08:30:33 *** promag has quit IRC
1172020-05-18T08:30:50 *** promag has joined #bitcoin-core-dev
1182020-05-18T08:35:34 *** promag has quit IRC
1192020-05-18T08:36:10 *** promag has joined #bitcoin-core-dev
1202020-05-18T08:43:27 *** manantial has joined #bitcoin-core-dev
1212020-05-18T08:50:36 *** DeanWeen has joined #bitcoin-core-dev
1222020-05-18T08:52:43 *** Dean_Guss has quit IRC
1232020-05-18T09:00:01 *** daim2k5 has quit IRC
1242020-05-18T09:07:55 *** bitcoin-git has joined #bitcoin-core-dev
1252020-05-18T09:07:55 <bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19004: script: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
1262020-05-18T09:08:06 *** bitcoin-git has left #bitcoin-core-dev
1272020-05-18T09:10:22 *** timothy has joined #bitcoin-core-dev
1282020-05-18T09:12:03 *** Guyver2 has quit IRC
1292020-05-18T09:14:31 *** AaronvanW has joined #bitcoin-core-dev
1302020-05-18T09:19:02 *** tmoc has quit IRC
1312020-05-18T09:22:26 *** nitind1 has joined #bitcoin-core-dev
1322020-05-18T09:26:32 *** promag has quit IRC
1332020-05-18T09:26:48 *** promag has joined #bitcoin-core-dev
1342020-05-18T09:32:13 *** belcher has joined #bitcoin-core-dev
1352020-05-18T09:32:33 *** Relis has joined #bitcoin-core-dev
1362020-05-18T09:35:43 <harding> I'm not sure knowing how deep a transaction is in the package-feerate sorted mempool is useful to normal users. E.g., knowing that a transaction is 3 block candidates deep in the mempool doesn't mean it's likely to be mined three blocks from now---during active periods, it's likely to be mined much later than that as additional relayed transactions arrive paying next-block and second-to-next-block feerates. If you want to give
1372020-05-18T09:35:43 <harding> useful information to the use, I think you want to (1) use getmempoolentry recursively to enumerate all of its descendents (this is limited to 25 by default), (2) find whichever one of those descendents has the highest package feerate (ancestorfees / ancestorsize), (3) loop over the estimatesmartfee estimates for the closest feerate match and report to the user something like "estimated to confirm within 30 blocks".
1382020-05-18T09:40:10 <aj> harding: i think getblocktemplate is useful for the case where you have P at 1kB + 1000sat, A spending P:0 at 200B, 6000sat, and B spending P:1 at 200B, 800 sat -- gbt will include P+A at 5sat/byte, then B at 4sat/byte, even though B's ancestor fee rate is only 1.5sat/byte
1392020-05-18T09:42:40 <harding> aj: which of those transactions is the one affecting the user's wallet?
1402020-05-18T09:43:11 <harding> The one the user wants to know whether it needs to be fee bumped?
1412020-05-18T09:43:19 <aj> harding: B
1422020-05-18T09:44:34 *** EagleTM has quit IRC
1432020-05-18T09:49:21 <harding> Hmm. That's a good point, but I think it means that both methods might suck for anything that's not in the next-block top of the mempool. If P+A gets mined without B, then B drops much further down in the mempool.
1442020-05-18T09:51:17 *** Pavlenex has quit IRC
1452020-05-18T09:51:45 *** afk11` has quit IRC
1462020-05-18T09:52:00 <aj> harding: no, 4sat/byte is B's fee rate on its own, it won't move lower
1472020-05-18T09:52:09 *** afk11` has joined #bitcoin-core-dev
1482020-05-18T09:52:11 <harding> Yeah, sorry.
1492020-05-18T09:52:34 <aj> harding: otherwise, yeah
1502020-05-18T10:13:21 *** Marie20Altenwert has joined #bitcoin-core-dev
1512020-05-18T10:20:26 *** Marie20Altenwert has quit IRC
1522020-05-18T10:21:52 *** Pavlenex has joined #bitcoin-core-dev
1532020-05-18T10:28:25 *** promag_ has joined #bitcoin-core-dev
1542020-05-18T10:30:02 *** Pavlenex has joined #bitcoin-core-dev
1552020-05-18T10:30:30 *** surja795 has joined #bitcoin-core-dev
1562020-05-18T10:33:15 *** promag_ has quit IRC
1572020-05-18T10:35:26 *** surja795 has quit IRC
1582020-05-18T10:41:08 *** qubenix has quit IRC
1592020-05-18T10:46:37 *** qubenix has joined #bitcoin-core-dev
1602020-05-18T10:53:13 <wumpus> PSA rc2 binaries up https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc2/
1612020-05-18T10:54:23 *** morcos has quit IRC
1622020-05-18T10:58:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1632020-05-18T11:01:15 <wumpus> hebasto: yes, thanks for the reminder, didn't get around to it in the weekend
1642020-05-18T11:03:54 *** berndj has quit IRC
1652020-05-18T11:03:58 <hebasto> \o/
1662020-05-18T11:05:42 *** berndj has joined #bitcoin-core-dev
1672020-05-18T11:07:01 <hebasto> downloaded rc2 source archive looks nice :)
1682020-05-18T11:11:39 *** surja795 has joined #bitcoin-core-dev
1692020-05-18T11:16:21 *** surja795 has quit IRC
1702020-05-18T11:18:07 *** Dean_Guss has joined #bitcoin-core-dev
1712020-05-18T11:19:23 *** DeanWeen has quit IRC
1722020-05-18T11:21:36 *** theStack has joined #bitcoin-core-dev
1732020-05-18T11:31:31 *** Pavlenex has joined #bitcoin-core-dev
1742020-05-18T11:41:34 *** cryptapus has joined #bitcoin-core-dev
1752020-05-18T11:41:34 *** cryptapus has quit IRC
1762020-05-18T11:41:34 *** cryptapus has joined #bitcoin-core-dev
1772020-05-18T11:44:33 *** Pavlenex has quit IRC
1782020-05-18T11:45:33 *** bitdex has quit IRC
1792020-05-18T11:50:33 *** surja795 has joined #bitcoin-core-dev
1802020-05-18T11:55:41 *** surja795 has quit IRC
1812020-05-18T12:00:02 *** nitind1 has quit IRC
1822020-05-18T12:01:02 *** surja795 has joined #bitcoin-core-dev
1832020-05-18T12:22:19 *** justMaD has joined #bitcoin-core-dev
1842020-05-18T12:25:15 *** bitcoin-git has joined #bitcoin-core-dev
1852020-05-18T12:25:15 <bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC⦠(master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
1862020-05-18T12:25:23 *** Eliz has joined #bitcoin-core-dev
1872020-05-18T12:25:26 *** bitcoin-git has left #bitcoin-core-dev
1882020-05-18T12:25:46 *** Eliz is now known as Guest30063
1892020-05-18T12:27:35 *** rmoura has quit IRC
1902020-05-18T12:39:50 *** troygiorshev has joined #bitcoin-core-dev
1912020-05-18T12:40:19 *** troygiorshev has joined #bitcoin-core-dev
1922020-05-18T12:45:44 *** justMaD has quit IRC
1932020-05-18T12:48:48 *** EagleTM has joined #bitcoin-core-dev
1942020-05-18T13:04:16 *** surja795 has quit IRC
1952020-05-18T13:12:08 *** bitcoin-git has joined #bitcoin-core-dev
1962020-05-18T13:12:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
1972020-05-18T13:12:09 *** bitcoin-git has left #bitcoin-core-dev
1982020-05-18T13:13:10 *** surja795 has joined #bitcoin-core-dev
1992020-05-18T13:14:38 *** bowfin has joined #bitcoin-core-dev
2002020-05-18T13:16:26 *** bowfin has left #bitcoin-core-dev
2012020-05-18T13:17:58 *** surja795 has quit IRC
2022020-05-18T13:18:34 *** surja795 has joined #bitcoin-core-dev
2032020-05-18T13:20:07 *** dgenr8 has joined #bitcoin-core-dev
2042020-05-18T13:23:08 *** surja795 has quit IRC
2052020-05-18T13:40:42 *** filchef has joined #bitcoin-core-dev
2062020-05-18T13:54:13 *** timothy has quit IRC
2072020-05-18T13:59:07 <jonasschnelli> ugh. #12783 introduced a nasty mac only GUI blocking issue
2082020-05-18T13:59:10 <gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
2092020-05-18T14:01:39 *** AimHere1 has joined #bitcoin-core-dev
2102020-05-18T14:14:02 *** Pavlenex has joined #bitcoin-core-dev
2112020-05-18T14:19:32 *** Pavlenex has quit IRC
2122020-05-18T14:34:57 *** bitcoin-git has joined #bitcoin-core-dev
2132020-05-18T14:34:57 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
2142020-05-18T14:34:58 *** bitcoin-git has left #bitcoin-core-dev
2152020-05-18T14:35:52 *** emilengler has joined #bitcoin-core-dev
2162020-05-18T14:38:27 *** surja795 has joined #bitcoin-core-dev
2172020-05-18T14:43:02 *** surja795 has quit IRC
2182020-05-18T14:43:27 *** mdunnio has joined #bitcoin-core-dev
2192020-05-18T14:44:57 *** surja795 has joined #bitcoin-core-dev
2202020-05-18T14:45:12 *** Relis has quit IRC
2212020-05-18T14:49:17 *** surja795 has quit IRC
2222020-05-18T14:57:37 *** Relis has joined #bitcoin-core-dev
2232020-05-18T15:00:02 *** AimHere1 has quit IRC
2242020-05-18T15:04:09 *** Guyver2 has joined #bitcoin-core-dev
2252020-05-18T15:04:48 *** Pavlenex has joined #bitcoin-core-dev
2262020-05-18T15:05:09 *** promag has quit IRC
2272020-05-18T15:05:50 *** promag has joined #bitcoin-core-dev
2282020-05-18T15:06:42 *** promag has quit IRC
2292020-05-18T15:06:56 *** promag has joined #bitcoin-core-dev
2302020-05-18T15:14:27 *** surja795 has joined #bitcoin-core-dev
2312020-05-18T15:14:30 *** promag has quit IRC
2322020-05-18T15:14:56 *** promag has joined #bitcoin-core-dev
2332020-05-18T15:16:06 *** troygiorshev has quit IRC
2342020-05-18T15:18:39 *** promag_ has joined #bitcoin-core-dev
2352020-05-18T15:18:39 *** promag has quit IRC
2362020-05-18T15:19:17 *** surja795 has quit IRC
2372020-05-18T15:20:55 *** surja795 has joined #bitcoin-core-dev
2382020-05-18T15:21:33 *** sirkitree has joined #bitcoin-core-dev
2392020-05-18T15:25:31 *** surja795 has quit IRC
2402020-05-18T15:26:54 *** troygiorshev has joined #bitcoin-core-dev
2412020-05-18T15:27:51 *** troygiorshev has joined #bitcoin-core-dev
2422020-05-18T15:28:47 *** Pavlenex has quit IRC
2432020-05-18T15:28:50 *** promag_ has quit IRC
2442020-05-18T15:30:18 *** troygiorshev has joined #bitcoin-core-dev
2452020-05-18T15:30:38 *** justanotheruser has quit IRC
2462020-05-18T15:35:17 *** surja795 has joined #bitcoin-core-dev
2472020-05-18T15:35:43 *** troygiorshev has quit IRC
2482020-05-18T15:35:57 *** troygiorshev has joined #bitcoin-core-dev
2492020-05-18T15:36:05 *** Pavlenex has joined #bitcoin-core-dev
2502020-05-18T15:36:47 *** promag has joined #bitcoin-core-dev
2512020-05-18T15:39:34 *** surja795 has quit IRC
2522020-05-18T15:40:21 *** promag has quit IRC
2532020-05-18T15:40:27 *** promag has joined #bitcoin-core-dev
2542020-05-18T15:44:32 *** troygiorshev has quit IRC
2552020-05-18T15:44:48 *** troygiorshev has joined #bitcoin-core-dev
2562020-05-18T15:47:19 *** justanotheruser has joined #bitcoin-core-dev
2572020-05-18T15:51:07 *** promag has quit IRC
2582020-05-18T15:51:43 *** promag has joined #bitcoin-core-dev
2592020-05-18T15:59:32 *** brianhoffman has quit IRC
2602020-05-18T16:00:47 *** proofofkeags has joined #bitcoin-core-dev
2612020-05-18T16:02:23 *** brianhoffman has joined #bitcoin-core-dev
2622020-05-18T16:02:39 *** proofofkeags has quit IRC
2632020-05-18T16:03:12 *** proofofkeags has joined #bitcoin-core-dev
2642020-05-18T16:05:08 *** promag_ has joined #bitcoin-core-dev
2652020-05-18T16:08:02 *** proofofkeags has quit IRC
2662020-05-18T16:18:52 *** surja795 has joined #bitcoin-core-dev
2672020-05-18T16:20:10 *** vasild_ has joined #bitcoin-core-dev
2682020-05-18T16:23:03 *** vasild has quit IRC
2692020-05-18T16:23:04 *** vasild_ is now known as vasild
2702020-05-18T16:23:30 *** Pavlenex has quit IRC
2712020-05-18T16:23:37 *** surja795 has quit IRC
2722020-05-18T16:26:29 *** promag_ has quit IRC
2732020-05-18T16:28:43 *** proofofkeags has joined #bitcoin-core-dev
2742020-05-18T16:33:31 *** proofofkeags has quit IRC
2752020-05-18T16:40:35 *** real_or_random has quit IRC
2762020-05-18T16:41:43 *** real_or_random has joined #bitcoin-core-dev
2772020-05-18T16:42:26 *** Guest30063 has quit IRC
2782020-05-18T16:59:57 *** proofofkeags has joined #bitcoin-core-dev
2792020-05-18T17:04:08 *** EagleTM has quit IRC
2802020-05-18T17:19:09 *** Pavlenex has joined #bitcoin-core-dev
2812020-05-18T17:30:59 *** bitcoin-git has joined #bitcoin-core-dev
2822020-05-18T17:31:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19008: ci: tsan on focal (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
2832020-05-18T17:31:00 *** bitcoin-git has left #bitcoin-core-dev
2842020-05-18T17:39:06 *** bitcoin-git has joined #bitcoin-core-dev
2852020-05-18T17:39:06 <bitcoin-git> [bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
2862020-05-18T17:39:07 *** bitcoin-git has left #bitcoin-core-dev
2872020-05-18T17:53:57 *** troygiorshev has quit IRC
2882020-05-18T18:00:02 *** sirkitree has quit IRC
2892020-05-18T18:01:37 *** nickler is now known as nix-bitcoin
2902020-05-18T18:01:53 *** nix-bitcoin is now known as nickler
2912020-05-18T18:06:06 *** Pavlenex has quit IRC
2922020-05-18T18:10:24 *** Pavlenex has joined #bitcoin-core-dev
2932020-05-18T18:13:12 *** marcoagner has joined #bitcoin-core-dev
2942020-05-18T18:17:41 *** ironhelix has joined #bitcoin-core-dev
2952020-05-18T18:22:06 *** MasterGruntR75 has joined #bitcoin-core-dev
2962020-05-18T18:29:20 *** EagleTM has joined #bitcoin-core-dev
2972020-05-18T18:41:24 *** proofofkeags has quit IRC
2982020-05-18T18:41:57 *** proofofkeags has joined #bitcoin-core-dev
2992020-05-18T18:46:29 *** go121212 has joined #bitcoin-core-dev
3002020-05-18T18:46:38 *** proofofkeags has quit IRC
3012020-05-18T18:49:10 *** go11111111111 has quit IRC
3022020-05-18T18:52:35 *** DeanWeen has joined #bitcoin-core-dev
3032020-05-18T18:52:37 *** Dean_Guss has quit IRC
3042020-05-18T18:53:03 *** owowo has quit IRC
3052020-05-18T18:57:58 *** owowo has joined #bitcoin-core-dev
3062020-05-18T18:58:38 *** bitcoin-git has joined #bitcoin-core-dev
3072020-05-18T18:58:38 <bitcoin-git> [bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
3082020-05-18T18:58:46 *** bitcoin-git has left #bitcoin-core-dev
3092020-05-18T19:07:55 *** proofofkeags has joined #bitcoin-core-dev
3102020-05-18T19:10:20 *** promag_ has joined #bitcoin-core-dev
3112020-05-18T19:12:37 *** proofofkeags has quit IRC
3122020-05-18T19:13:38 *** promag_ has quit IRC
3132020-05-18T19:14:32 *** Talkless has quit IRC
3142020-05-18T19:19:24 *** promag_ has joined #bitcoin-core-dev
3152020-05-18T19:21:14 *** emilengler has quit IRC
3162020-05-18T19:29:02 *** troygiorshev has joined #bitcoin-core-dev
3172020-05-18T19:30:03 *** MrSquanchee has joined #bitcoin-core-dev
3182020-05-18T19:30:19 *** EagleTM has quit IRC
3192020-05-18T19:33:39 *** troygiorshev has quit IRC
3202020-05-18T19:40:05 *** dfmb_ has quit IRC
3212020-05-18T19:45:02 *** kristapsk_ has quit IRC
3222020-05-18T19:47:17 *** EagleTM has joined #bitcoin-core-dev
3232020-05-18T19:47:51 <pierre_rochard> For those interested, https://bitcoinacks.com is back up, feel free to send pull requests / feature ideas
3242020-05-18T19:47:53 *** promag_ has quit IRC
3252020-05-18T19:52:10 *** MrSquanchee has left #bitcoin-core-dev
3262020-05-18T19:52:16 <michaelfolkson> Awesome. I'm assuming from the above you have the time to maintain it pierre_rochard going forward?
3272020-05-18T19:53:35 <pierre_rochard> Yes for the foreseeable future, if that changes I'll notify here and hand it over if there are users.
3282020-05-18T19:54:03 <michaelfolkson> Cool, that's great. Thanks
3292020-05-18T20:03:21 <harding> pierre_rochard: thanks!
3302020-05-18T20:05:44 *** MasterGruntR75 has quit IRC
3312020-05-18T20:14:35 *** bitcoin-git has joined #bitcoin-core-dev
3322020-05-18T20:14:35 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
3332020-05-18T20:14:36 *** bitcoin-git has left #bitcoin-core-dev
3342020-05-18T20:14:52 <tryphe> is there any way to resolve these review comments? i guess i've selected the wrong review type but it looks ugly to see all of my comments expanded: https://github.com/bitcoin/bitcoin/pull/19004#pullrequestreview-413807305
3352020-05-18T20:15:09 <tryphe> or maybe i can't and will have to select the right one in the future
3362020-05-18T20:16:23 *** proofofkeags has joined #bitcoin-core-dev
3372020-05-18T20:18:53 <jonasschnelli> tryphe: don't you have a "Resolve conversation" button?
3382020-05-18T20:18:56 <sipa> tryphe: i marked them resolved for you
3392020-05-18T20:19:11 <jonasschnelli> (or is that an admin thing?)
3402020-05-18T20:19:23 <tryphe> sipa, thanks
3412020-05-18T20:19:34 <tryphe> jonasschnelli, i had selected the first type of review, something like "general comments"
3422020-05-18T20:19:48 <sipa> tryphe: not sure what you mean by review type
3432020-05-18T20:19:49 <tryphe> i guess the resolve button is only available for the other 2 choices
3442020-05-18T20:20:44 *** promag has quit IRC
3452020-05-18T20:21:00 *** promag has joined #bitcoin-core-dev
3462020-05-18T20:21:48 <tryphe> sipa, when you press "start a review" there's multiple choices, and i wasn't able to unexpand my comments from showing up in the default thread without you doing it
3472020-05-18T20:22:26 <tryphe> will use the other ones in the future
3482020-05-18T20:25:20 <tryphe> i guess maybe only the author and admins can resolve the conversation?
3492020-05-18T20:25:55 <tryphe> author/PR author
3502020-05-18T20:26:42 <sipa> huh, never seen that
3512020-05-18T20:27:18 <tryphe> yeah i had figured i could resolve it, but honestly i don't do much review and didn't know which review type to select
3522020-05-18T20:33:09 *** aqu4 has joined #bitcoin-core-dev
3532020-05-18T20:34:23 *** kristapsk has joined #bitcoin-core-dev
3542020-05-18T20:37:56 *** promag has quit IRC
3552020-05-18T20:52:13 *** surja795 has joined #bitcoin-core-dev
3562020-05-18T20:52:50 *** EagleTM has quit IRC
3572020-05-18T20:53:17 *** filchef has quit IRC
3582020-05-18T21:00:02 *** aqu4 has quit IRC
3592020-05-18T21:04:47 *** kristapsk has quit IRC
3602020-05-18T21:06:20 *** Guyver2 has quit IRC
3612020-05-18T21:13:12 *** kristapsk has joined #bitcoin-core-dev
3622020-05-18T21:21:47 *** r2wj has joined #bitcoin-core-dev
3632020-05-18T21:26:03 *** mrostecki has quit IRC
3642020-05-18T21:32:38 *** Pavlenex has quit IRC
3652020-05-18T21:34:16 *** Chris_Stewart_5 has quit IRC
3662020-05-18T21:36:12 *** promag has joined #bitcoin-core-dev
3672020-05-18T21:38:23 *** DeanWeen has quit IRC
3682020-05-18T21:38:58 *** Manats has joined #bitcoin-core-dev
3692020-05-18T21:40:03 *** Manats has quit IRC
3702020-05-18T21:40:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3712020-05-18T21:42:58 *** mrostecki has joined #bitcoin-core-dev
3722020-05-18T21:44:01 *** shesek has quit IRC
3732020-05-18T21:47:32 *** shesek has joined #bitcoin-core-dev
3742020-05-18T21:47:32 *** shesek has joined #bitcoin-core-dev
3752020-05-18T21:47:51 *** manantial has quit IRC
3762020-05-18T21:54:13 *** shesek has quit IRC
3772020-05-18T21:55:23 *** shesek has joined #bitcoin-core-dev
3782020-05-18T21:55:23 *** shesek has joined #bitcoin-core-dev
3792020-05-18T21:56:27 *** mdunnio has quit IRC
3802020-05-18T21:59:58 *** shesek has quit IRC
3812020-05-18T22:00:42 *** proofofkeags has quit IRC
3822020-05-18T22:01:08 *** proofofkeags has joined #bitcoin-core-dev
3832020-05-18T22:04:01 *** shesek has joined #bitcoin-core-dev
3842020-05-18T22:04:01 *** shesek has joined #bitcoin-core-dev
3852020-05-18T22:05:43 *** proofofkeags has quit IRC
3862020-05-18T22:11:00 *** promag has quit IRC
3872020-05-18T22:18:14 *** roconnor has quit IRC
3882020-05-18T22:21:26 *** marcoagner has quit IRC
3892020-05-18T22:22:11 *** roconnor has joined #bitcoin-core-dev
3902020-05-18T22:28:02 *** troygiorshev has joined #bitcoin-core-dev
3912020-05-18T22:28:20 *** promag has joined #bitcoin-core-dev
3922020-05-18T22:34:15 *** pinheadmz has quit IRC
3932020-05-18T22:34:59 *** pinheadmz has joined #bitcoin-core-dev
3942020-05-18T22:35:04 *** troygiorshev has quit IRC
3952020-05-18T23:00:31 *** mrostecki has quit IRC
3962020-05-18T23:10:41 *** mrostecki has joined #bitcoin-core-dev
3972020-05-18T23:26:43 *** vasild has quit IRC
3982020-05-18T23:26:58 *** vasild has joined #bitcoin-core-dev
3992020-05-18T23:31:55 *** promag has quit IRC
4002020-05-18T23:37:34 *** justanotheruser has quit IRC
4012020-05-18T23:52:29 *** niklas54 has joined #bitcoin-core-dev
4022020-05-18T23:54:07 *** justanotheruser has joined #bitcoin-core-dev