12020-05-20T00:00:02 *** rule32 has quit IRC
22020-05-20T00:00:27 *** dfmb_ has quit IRC
32020-05-20T00:13:08 *** lightlike has quit IRC
42020-05-20T00:21:49 *** Dean_Guss has joined #bitcoin-core-dev
52020-05-20T00:21:49 *** dorena has joined #bitcoin-core-dev
62020-05-20T00:27:23 *** AaronvanW has joined #bitcoin-core-dev
72020-05-20T00:29:32 *** AaronvanW has quit IRC
82020-05-20T00:30:48 *** Aaronvan_ has quit IRC
92020-05-20T00:38:05 *** proofofkeags has quit IRC
102020-05-20T00:50:26 *** troygiorshev has joined #bitcoin-core-dev
112020-05-20T00:52:53 *** jarthur has quit IRC
122020-05-20T00:57:47 *** mdunnio has quit IRC
132020-05-20T01:13:21 *** proofofkeags has joined #bitcoin-core-dev
142020-05-20T01:14:12 *** baldur has quit IRC
152020-05-20T01:18:39 *** proofofkeags has quit IRC
162020-05-20T01:23:36 *** troygiorshev has quit IRC
172020-05-20T01:27:00 *** baldur has joined #bitcoin-core-dev
182020-05-20T01:29:17 *** dunks has quit IRC
192020-05-20T01:29:42 *** dunks has joined #bitcoin-core-dev
202020-05-20T01:32:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
212020-05-20T01:37:21 *** proofofkeags has joined #bitcoin-core-dev
222020-05-20T01:58:12 *** Chris_Stewart_5 has quit IRC
232020-05-20T02:06:36 *** tmoc has joined #bitcoin-core-dev
242020-05-20T02:08:26 *** promag has quit IRC
252020-05-20T02:14:09 *** tmoc has quit IRC
262020-05-20T02:16:12 *** bitcoin-git has joined #bitcoin-core-dev
272020-05-20T02:16:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa8d76806c74...0aa2ff0f660e
282020-05-20T02:16:13 <bitcoin-git> bitcoin/master e8a8cff fanquake: build: enforce minimum required Windows version (7)
292020-05-20T02:16:14 <bitcoin-git> bitcoin/master 0aa2ff0 fanquake: Merge #18956: build: enforce minimum required Windows version (7)
302020-05-20T02:16:16 *** bitcoin-git has left #bitcoin-core-dev
312020-05-20T02:16:32 *** bitcoin-git has joined #bitcoin-core-dev
322020-05-20T02:16:32 <bitcoin-git> [bitcoin] fanquake merged pull request #18956: build: enforce minimum required Windows version (7) (master...window_enforce_runtime_version) https://github.com/bitcoin/bitcoin/pull/18956
332020-05-20T02:16:33 *** bitcoin-git has left #bitcoin-core-dev
342020-05-20T02:23:08 *** promag has joined #bitcoin-core-dev
352020-05-20T02:32:32 *** surja795 has quit IRC
362020-05-20T02:50:47 *** geeker has quit IRC
372020-05-20T02:51:17 *** geeker has joined #bitcoin-core-dev
382020-05-20T02:54:02 <jb55> I'm still new to the codebase, sorry if dumb question: but looking at undo blocks/rev*.dat files: does a node really need to store (37GB on my node currently) worth of undo blocks? is this just an optimization? couldn't you do this on the fly?
392020-05-20T02:54:20 <sipa> define "on the fly" ?
402020-05-20T02:55:10 <sipa> if you mean "at disconnect time", no, that would be extremely slow (it would need a linear scan through all previous block to find the outputs being spent)
412020-05-20T02:55:22 <sipa> if you mean created at connect time, that's what it's doing
422020-05-20T02:56:14 <sipa> in non-pruning mode you could see it as an optimization, but only in so far that the concept of a UTXO set is an optimization...
432020-05-20T02:56:25 <sipa> in pruning node it's data that's not otherwise available
442020-05-20T02:57:07 <jb55> ah ok I think I was missing the linear scan to find outputs bit
452020-05-20T02:57:49 <sipa> you can see blocks as patches to the UTXO set "delete this UTXO, add this UTXO", plus witnesses that authenticate the patch
462020-05-20T02:58:20 <sipa> the undo data is the reverse patch; it contains the actual UTXO data deleted by a block
472020-05-20T02:59:54 <jb55> sipa: how many patches are kept, is there a way to tweak that?
482020-05-20T03:00:01 *** dorena has quit IRC
492020-05-20T03:00:13 <sipa> jb55: for every block you keep, the undo data is kept
502020-05-20T03:00:27 <sipa> if you prune blocks, the undo data is also pruned along with it
512020-05-20T03:00:56 *** ctrlbreak_MAD has quit IRC
522020-05-20T03:01:06 <sipa> there could be a knob to change that, in case you're ok with not being able to reorg back to block height H, but still want to be able to that block to others on the network
532020-05-20T03:01:20 *** ctrlbreak_MAD has joined #bitcoin-core-dev
542020-05-20T03:01:21 <sipa> or want it for rescanning
552020-05-20T03:01:43 <sipa> undo data is around 9x smaller than the corresponding block data iirc
562020-05-20T03:02:04 *** proofofkeags has quit IRC
572020-05-20T03:03:12 <jb55> sipa: so if you pruned the undos you couldn't rescan before a certain point? it has to apply those patches back to the rescan point to determine the utxo state at that height?
582020-05-20T03:03:54 <sipa> jb55: if you prune you don't have the blocks either, so you lose the ability to rescan anyway
592020-05-20T03:04:07 <sipa> and rescanning is about finding transactions, not UTXOs
602020-05-20T03:04:40 <sipa> undo data is solely used for disconnecting block (though there is a PR open to also use it for some block statistics, i think)
612020-05-20T03:04:52 <jb55> was just thinking if there was an option to prune the undo blocks, was wondering what the consequences were
622020-05-20T03:05:04 <sipa> you'd be unable to reorg back
632020-05-20T03:05:27 <sipa> which is extremely unlikely to be a problem beyond a few 100 or 1000 blocks
642020-05-20T03:07:38 <jb55> yeah I would like to prune undo blocks past 100 or so, and would try to PR it if it makes sense
652020-05-20T03:07:40 <sipa> ah, i forgot: https://github.com/bitcoin/bitcoin/pull/16083 added statistics using undo data
662020-05-20T03:08:10 <sipa> pruning is restricted to keeping at least 288 blocks, i think
672020-05-20T03:08:21 <sipa> it may make sense to have the same limit
682020-05-20T03:08:30 <jb55> sure
692020-05-20T03:08:54 <gwillen> I think it's already the case that if we reorg more than 100 blocks deep, things have gone very wrong, yeah?
702020-05-20T03:09:27 <jb55> proof of aliens trolling us
712020-05-20T03:09:48 <sipa> jb55: on the other hand... if you care getting rid of 10% of disk usage, maybe you should consider just pruning
722020-05-20T03:10:38 <sipa> it's not a perfect argument; there are things you can do with blocks that don't need undo data... but undo data is also an order of magnitude smaller
732020-05-20T03:11:34 <jb55> sipa: I like the full db for analysis and rescan. any optimization on top of that is nice.
742020-05-20T03:13:47 *** tryphe has joined #bitcoin-core-dev
752020-05-20T03:17:46 *** proofofkeags has joined #bitcoin-core-dev
762020-05-20T03:21:51 *** Wolfy87 has joined #bitcoin-core-dev
772020-05-20T03:22:41 *** proofofkeags has quit IRC
782020-05-20T03:23:14 *** bitcoin-git has joined #bitcoin-core-dev
792020-05-20T03:23:14 <bitcoin-git> [bitcoin] fanquake opened pull request #19025: [0.19] Backports (0.19...0_19_2_backports) https://github.com/bitcoin/bitcoin/pull/19025
802020-05-20T03:23:15 *** bitcoin-git has left #bitcoin-core-dev
812020-05-20T03:28:39 *** dunks has quit IRC
822020-05-20T03:29:06 *** dunks has joined #bitcoin-core-dev
832020-05-20T03:31:06 *** dunks has quit IRC
842020-05-20T03:46:43 *** afk11` has quit IRC
852020-05-20T03:49:23 *** afk11` has joined #bitcoin-core-dev
862020-05-20T03:56:11 *** Eagle[TM] has joined #bitcoin-core-dev
872020-05-20T03:57:58 *** EagleTM has quit IRC
882020-05-20T03:59:43 *** wangchun has joined #bitcoin-core-dev
892020-05-20T04:20:06 *** vasild_ has joined #bitcoin-core-dev
902020-05-20T04:23:43 *** vasild has quit IRC
912020-05-20T04:23:44 *** vasild_ is now known as vasild
922020-05-20T04:28:01 *** mol has joined #bitcoin-core-dev
932020-05-20T04:31:29 *** mol_ has quit IRC
942020-05-20T04:36:16 *** mol has quit IRC
952020-05-20T04:38:27 *** mol has joined #bitcoin-core-dev
962020-05-20T04:49:27 *** d_t has quit IRC
972020-05-20T04:52:13 *** Talkless has joined #bitcoin-core-dev
982020-05-20T04:55:18 *** TheFuzzStone[m] has quit IRC
992020-05-20T04:56:35 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1002020-05-20T05:05:16 *** davec has quit IRC
1012020-05-20T05:07:30 *** lesderid has quit IRC
1022020-05-20T05:11:55 *** mol has quit IRC
1032020-05-20T05:13:38 *** lesderid has joined #bitcoin-core-dev
1042020-05-20T05:15:36 *** geeker has quit IRC
1052020-05-20T05:30:27 *** davec has joined #bitcoin-core-dev
1062020-05-20T05:40:28 *** berndj has quit IRC
1072020-05-20T05:51:43 *** berndj has joined #bitcoin-core-dev
1082020-05-20T05:53:26 *** berndj has quit IRC
1092020-05-20T05:53:46 *** berndj has joined #bitcoin-core-dev
1102020-05-20T05:59:26 *** mol has joined #bitcoin-core-dev
1112020-05-20T06:00:04 *** Wolfy87 has quit IRC
1122020-05-20T06:08:45 *** jarthur has joined #bitcoin-core-dev
1132020-05-20T06:13:27 *** jarthur has quit IRC
1142020-05-20T06:21:20 *** kephra has joined #bitcoin-core-dev
1152020-05-20T06:34:44 *** troygiorshev has joined #bitcoin-core-dev
1162020-05-20T06:39:24 *** troygiorshev has quit IRC
1172020-05-20T06:49:52 <fanquake> Thanks elichai2. Looks like GitHub does send two email notifications
1182020-05-20T06:50:38 <elichai2> actually it's not that ridiculous because its probably sending 2 unrelated emails. 1 for notifying about the PR. 2. for telling you you were chosen to review a PR. right?
1192020-05-20T06:50:53 <fanquake> Correct
1202020-05-20T06:52:29 <fanquake> https://imgur.com/a/KYgbJlV
1212020-05-20T06:52:54 *** marcoagner has joined #bitcoin-core-dev
1222020-05-20T07:19:37 *** kristapsk has quit IRC
1232020-05-20T07:19:58 *** kristapsk has joined #bitcoin-core-dev
1242020-05-20T07:20:52 *** Randolf has joined #bitcoin-core-dev
1252020-05-20T07:25:24 *** sipsorcery has joined #bitcoin-core-dev
1262020-05-20T07:27:23 *** [\\\] has quit IRC
1272020-05-20T07:28:47 *** tripleslash has joined #bitcoin-core-dev
1282020-05-20T07:32:59 *** promag has quit IRC
1292020-05-20T07:38:36 *** sdaftuar has quit IRC
1302020-05-20T07:39:12 *** sdaftuar has joined #bitcoin-core-dev
1312020-05-20T07:39:18 <elichai2> ha, too bad they didn't special-case the CODEOWNERS to merge this emails into 1
1322020-05-20T07:39:38 <elichai2> at least it's under the same subject though
1332020-05-20T07:43:34 <willcl_ark> Does BIP30 / BIP34 completely prevent there from existing two transactions with same txid, or are there still edge-cases where this can happen?
1342020-05-20T07:45:26 <willcl_ark> BIP30 appears to leave some room for re-orgs, but I can't tell if "spent" transactions (in different blocks) could still be allowed to have had identical txids
1352020-05-20T07:46:59 <sipa> willcl_ark: BIP30 doesn't prevent duplicate txids; it only prevents one transaction that would overwrite an earlier one
1362020-05-20T07:49:13 *** PaulTroon has joined #bitcoin-core-dev
1372020-05-20T07:52:05 <sipa> BIP34 prevents duplicate txids (assuming collision resistance of double-SHA256...)
1382020-05-20T07:55:06 *** Pavlenex has joined #bitcoin-core-dev
1392020-05-20T08:09:49 *** jarthur has joined #bitcoin-core-dev
1402020-05-20T08:12:28 <PaulTroon> BIP34 was an interesting historic read - is Gavin's speculation about a duplicate coinbase in 2048 technically impossible for a malicous miner? https://github.com/bitcoin/bitcoin/pull/1526#issuecomment-6796145
1412020-05-20T08:12:45 <PaulTroon> s/impossible/possible
1422020-05-20T08:14:47 *** jarthur has quit IRC
1432020-05-20T08:15:39 *** promag has joined #bitcoin-core-dev
1442020-05-20T08:16:37 <sipa> 2048?
1452020-05-20T08:17:26 <sipa> ah
1462020-05-20T08:17:43 <PaulTroon> A pre-BIP34 coinbase with matching signature for block height 1,983,702 (approx year 2048)
1472020-05-20T08:17:55 <sipa> BIP141 solved that
1482020-05-20T08:18:02 <PaulTroon> 'signature' I mean push of block height in coinbase
1492020-05-20T08:18:10 <yevaud> PaulTroon: that's super implausible at best to begin with.
1502020-05-20T08:18:34 <yevaud> and any impact is pretty minimal even if it wasn't.
1512020-05-20T08:18:41 <PaulTroon> yevaud: sure, just a thought experiment
1522020-05-20T08:19:37 <sipa> all txouts of the block 164384 coinbase transaction are redeemed
1532020-05-20T08:19:48 <sipa> so it won't matter even if it could happen
1542020-05-20T08:19:54 *** promag has quit IRC
1552020-05-20T08:20:07 *** promag has joined #bitcoin-core-dev
1562020-05-20T08:20:07 *** AaronvanW has joined #bitcoin-core-dev
1572020-05-20T08:20:08 *** promag_ has joined #bitcoin-core-dev
1582020-05-20T08:20:13 <PaulTroon> sipa: because BIP30 allows duplicate tx's if all outputs are spent?
1592020-05-20T08:20:22 <sipa> yes
1602020-05-20T08:20:32 <sipa> well, yes, but that's not what I mean
1612020-05-20T08:20:41 <yevaud> PaulTroon: I still have no clue why the format specified is a partly valid CScript.
1622020-05-20T08:21:08 <sipa> the problem that BIP30 was trying to solve is txout _overwriting_
1632020-05-20T08:21:30 <sipa> since all the outputs are already spent, there is nothing to be overwritten, so the problem doesn't exist in the first place
1642020-05-20T08:22:01 <sipa> BIP30 thankfully has an exception that in that case doesn't prevent creation, because otherwise we'd need to keep track of every spent utxo forever
1652020-05-20T08:29:00 <PaulTroon> I was also trying to understand that BIP30 attack scenario, snot sure if I understand it.. a coinbase_1 with an unspent txout to A, and then create a duplicate coinbase_2 that has a txout to B ?
1662020-05-20T08:30:07 <PaulTroon> So then a tx that spends the txout to A is invalid because coinbase_2 does not have that txout A ?
1672020-05-20T08:30:33 <sipa> PaulTroon: coinbase_1 is created, the chain forks into branch A and branch B (just a 1 or 2 block reorg, otherwise harmless); in branch A, coinbase_2 overwrites coinbase_1; in branch B this does not happen
1682020-05-20T08:30:37 <sipa> branch B eventually wins
1692020-05-20T08:31:00 *** Guyver2 has joined #bitcoin-core-dev
1702020-05-20T08:31:22 <sipa> nodes that have seen branch A will have overwritten coinbase_1, and then _deleted_ it when switching to branch B (as they're "undoing" the creation of coinbase_2, having forgotten something was overwritten)
1712020-05-20T08:31:37 <sipa> nodes that have not seen branch A will think coinbase_1 still exists
1722020-05-20T08:32:02 <sipa> if now someone spends the coinbase_1 output, it permanently forks the network between those that have seen branch A and those who have not
1732020-05-20T08:34:14 <PaulTroon> thanks sipa, the commentary from bip30 makes more sense now
1742020-05-20T08:35:50 *** Relis has quit IRC
1752020-05-20T08:40:37 <PaulTroon> hmm, one more question, if branch A wins and coinbase_2 overwrites coinbase_1, are the unspent tx_outs that spend coinbase_1 now invalid in branch A?
1762020-05-20T08:47:11 *** PaulTroon has quit IRC
1772020-05-20T08:49:28 *** PaulTroon has joined #bitcoin-core-dev
1782020-05-20T08:50:17 *** timothy has joined #bitcoin-core-dev
1792020-05-20T09:00:01 *** kephra has quit IRC
1802020-05-20T09:06:10 <PaulTroon> to try and answer my own question, in a winning branch A scenario the UTXOs are valid from both coinbase_1 and coinbase_2 as long as no rollback occurs to pull the rug out.
1812020-05-20T09:09:01 *** Randolf has quit IRC
1822020-05-20T09:10:34 *** bitcoin-git has joined #bitcoin-core-dev
1832020-05-20T09:10:35 <bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0aa2ff0f660e...a587f85853ec
1842020-05-20T09:10:35 <bitcoin-git> bitcoin/master 83f69fa Russell Yanofsky: Switch transaction table to use wallet height not node height
1852020-05-20T09:10:36 <bitcoin-git> bitcoin/master 2bc9b92 Russell Yanofsky: Cancel wallet balance timer when shutdown requested
1862020-05-20T09:10:37 <bitcoin-git> bitcoin/master bf0a510 Russell Yanofsky: gui: Avoid wallet tryGetBalances calls before TransactionChanged or BlockT...
1872020-05-20T09:10:38 *** bitcoin-git has left #bitcoin-core-dev
1882020-05-20T09:11:08 *** bitcoin-git has joined #bitcoin-core-dev
1892020-05-20T09:11:09 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18587: gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged (master...pr/ipc-bal) https://github.com/bitcoin/bitcoin/pull/18587
1902020-05-20T09:11:09 *** bitcoin-git has left #bitcoin-core-dev
1912020-05-20T09:18:38 *** pcmanus has joined #bitcoin-core-dev
1922020-05-20T09:20:49 *** bbbbos has joined #bitcoin-core-dev
1932020-05-20T09:29:37 *** DeanWeen has joined #bitcoin-core-dev
1942020-05-20T09:31:43 *** Dean_Guss has quit IRC
1952020-05-20T09:41:25 *** dfmb_ has joined #bitcoin-core-dev
1962020-05-20T09:45:18 *** gleb has quit IRC
1972020-05-20T09:55:58 *** Pavlenex1 has joined #bitcoin-core-dev
1982020-05-20T09:56:49 *** Guyver2 has quit IRC
1992020-05-20T09:58:54 *** Eagle[TM] has quit IRC
2002020-05-20T09:59:16 *** Pavlenex has quit IRC
2012020-05-20T09:59:17 *** Pavlenex1 is now known as Pavlenex
2022020-05-20T10:03:22 *** Jessica87Barrows has joined #bitcoin-core-dev
2032020-05-20T10:05:10 *** ghost43 has quit IRC
2042020-05-20T10:07:20 *** bbbbos has quit IRC
2052020-05-20T10:07:36 *** surja795 has joined #bitcoin-core-dev
2062020-05-20T10:08:10 *** Jessica87Barrows has quit IRC
2072020-05-20T10:10:30 *** jarthur has joined #bitcoin-core-dev
2082020-05-20T10:15:13 *** jarthur has quit IRC
2092020-05-20T10:34:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2102020-05-20T10:36:48 *** justanotheruser has quit IRC
2112020-05-20T11:00:19 *** promag has quit IRC
2122020-05-20T11:00:52 *** promag has joined #bitcoin-core-dev
2132020-05-20T11:04:52 *** EagleTM has joined #bitcoin-core-dev
2142020-05-20T11:05:02 *** bitdex has quit IRC
2152020-05-20T11:17:11 *** PaulTroon has quit IRC
2162020-05-20T11:19:23 *** DeanWeen has quit IRC
2172020-05-20T11:19:51 *** vasild has quit IRC
2182020-05-20T11:20:04 *** vasild has joined #bitcoin-core-dev
2192020-05-20T11:27:55 *** bitcoin-git has joined #bitcoin-core-dev
2202020-05-20T11:27:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a587f85853ec...bd5ec7c5284d
2212020-05-20T11:27:57 <bitcoin-git> bitcoin/master fa83b39 MarcoFalke: init: Remove confusing and redundant InitError
2222020-05-20T11:27:58 <bitcoin-git> bitcoin/master fa12a37 MarcoFalke: test: Replace inline-comments with logs, pep8 formatting
2232020-05-20T11:27:59 <bitcoin-git> bitcoin/master faf45d1 MarcoFalke: http: Avoid crash when g_thread_http was never started
2242020-05-20T11:28:00 *** bitcoin-git has left #bitcoin-core-dev
2252020-05-20T11:28:17 *** bitcoin-git has joined #bitcoin-core-dev
2262020-05-20T11:28:17 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19006: rpc: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
2272020-05-20T11:28:28 *** bitcoin-git has left #bitcoin-core-dev
2282020-05-20T11:30:13 *** bitcoin-git has joined #bitcoin-core-dev
2292020-05-20T11:30:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bd5ec7c5284d...e20e964cb1ab
2302020-05-20T11:30:15 <bitcoin-git> bitcoin/master facdeea MarcoFalke: net: Remove un-actionable TODO
2312020-05-20T11:30:15 <bitcoin-git> bitcoin/master fabea6d MarcoFalke: net: Run clang-format on protocol.h
2322020-05-20T11:30:16 <bitcoin-git> bitcoin/master e20e964 MarcoFalke: Merge #18996: net: Remove un-actionable TODO
2332020-05-20T11:30:18 *** bitcoin-git has left #bitcoin-core-dev
2342020-05-20T11:30:41 *** bitcoin-git has joined #bitcoin-core-dev
2352020-05-20T11:30:41 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18996: net: Remove un-actionable TODO (master...2005-netNoTodo) https://github.com/bitcoin/bitcoin/pull/18996
2362020-05-20T11:30:42 *** bitcoin-git has left #bitcoin-core-dev
2372020-05-20T11:30:43 *** vasild has quit IRC
2382020-05-20T11:30:56 *** vasild has joined #bitcoin-core-dev
2392020-05-20T11:32:43 *** bitcoin-git has joined #bitcoin-core-dev
2402020-05-20T11:32:44 <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e20e964cb1ab...448bdff26307
2412020-05-20T11:32:45 <bitcoin-git> bitcoin/master 769ee5f Pieter Wuille: Merge BigEndian functionality into CustomUintFormatter
2422020-05-20T11:32:45 <bitcoin-git> bitcoin/master 6f9a1e5 Russell Yanofsky: Extend CustomUintFormatter to support enums
2432020-05-20T11:32:46 <bitcoin-git> bitcoin/master d06fedd Russell Yanofsky: Add SER_READ and SER_WRITE for read/write-dependent statements
2442020-05-20T11:32:48 *** bitcoin-git has left #bitcoin-core-dev
2452020-05-20T11:33:18 *** bitcoin-git has joined #bitcoin-core-dev
2462020-05-20T11:33:18 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18317: Serialization improvements step 6 (all except wallet/gui) (master...202003_noncastserial_6) https://github.com/bitcoin/bitcoin/pull/18317
2472020-05-20T11:33:30 *** bitcoin-git has left #bitcoin-core-dev
2482020-05-20T11:35:40 *** Pavlenex has quit IRC
2492020-05-20T11:35:59 *** PaulTroon has joined #bitcoin-core-dev
2502020-05-20T11:47:46 *** EagleTM has quit IRC
2512020-05-20T11:48:21 *** Guyver2 has joined #bitcoin-core-dev
2522020-05-20T11:51:13 *** promag has quit IRC
2532020-05-20T11:52:16 *** promag_ has quit IRC
2542020-05-20T11:53:34 *** mol has quit IRC
2552020-05-20T12:00:02 *** pcmanus has quit IRC
2562020-05-20T12:11:33 *** jarthur has joined #bitcoin-core-dev
2572020-05-20T12:16:17 *** jarthur has quit IRC
2582020-05-20T12:21:36 *** Barras2 has joined #bitcoin-core-dev
2592020-05-20T12:29:34 *** dongcarl has quit IRC
2602020-05-20T12:30:08 *** dongcarl has joined #bitcoin-core-dev
2612020-05-20T12:37:09 <willcl_ark> sipa: thanks for your earlier reply re BIP30/34
2622020-05-20T12:37:48 *** vasild has quit IRC
2632020-05-20T12:38:06 *** vasild has joined #bitcoin-core-dev
2642020-05-20T12:39:01 *** mol has joined #bitcoin-core-dev
2652020-05-20T12:45:15 *** troygiorshev has joined #bitcoin-core-dev
2662020-05-20T12:54:10 *** Relis has joined #bitcoin-core-dev
2672020-05-20T12:59:34 *** troygiorshev has quit IRC
2682020-05-20T13:09:30 *** CodeShark___ has joined #bitcoin-core-dev
2692020-05-20T13:10:47 *** CodeShark__ has quit IRC
2702020-05-20T13:20:43 *** jb55 has quit IRC
2712020-05-20T13:22:21 *** jb55 has joined #bitcoin-core-dev
2722020-05-20T13:27:39 *** dfmb_ has quit IRC
2732020-05-20T13:28:33 *** vasild has quit IRC
2742020-05-20T13:28:48 *** vasild has joined #bitcoin-core-dev
2752020-05-20T13:30:42 *** Ivan24 has joined #bitcoin-core-dev
2762020-05-20T13:35:51 *** davterra has joined #bitcoin-core-dev
2772020-05-20T13:46:47 *** mdunnio has joined #bitcoin-core-dev
2782020-05-20T13:50:30 *** d_t has joined #bitcoin-core-dev
2792020-05-20T13:52:14 *** Relis has quit IRC
2802020-05-20T13:59:38 *** mol has quit IRC
2812020-05-20T14:05:43 *** justanotheruser has joined #bitcoin-core-dev
2822020-05-20T14:08:12 *** mol has joined #bitcoin-core-dev
2832020-05-20T14:10:25 <shesek> I released a new open-source project, an HD wallet indexer similar to EPS, implemented in Rust. Apart from supporting the Electrum RPC protocol, it also provides a more modern HTTP REST API and convenient real-time updates. https://github.com/shesek/bwt
2842020-05-20T14:10:34 <shesek> (apologies for the off-topicness, I figured there might be people who find it interesting here)
2852020-05-20T14:10:35 *** cryptomanas has joined #bitcoin-core-dev
2862020-05-20T14:12:14 *** jarthur has joined #bitcoin-core-dev
2872020-05-20T14:15:57 <jb55> shesek: nice, looks neat
2882020-05-20T14:17:17 *** jarthur has quit IRC
2892020-05-20T14:29:23 *** sdaftuar has quit IRC
2902020-05-20T14:30:40 *** sdaftuar has joined #bitcoin-core-dev
2912020-05-20T14:42:30 <kanzure> shesek: it would be helpful if this could do something about offline consumer applications to provide updates (such as reorgs or anything modifying the application's last processed tip) to an application that was offline for a while.
2922020-05-20T14:42:46 *** jarthur has joined #bitcoin-core-dev
2932020-05-20T14:45:46 *** Relis has joined #bitcoin-core-dev
2942020-05-20T14:49:20 *** promag has joined #bitcoin-core-dev
2952020-05-20T14:50:11 *** d_t has quit IRC
2962020-05-20T14:54:14 <shesek> kanzure, the closest thing currently available is the /txs/since/:height endpoint, but I have an issue for something similar to what you suggested: https://github.com/shesek/bwt/issues/6
2972020-05-20T14:55:39 <shesek> reorgs are being reported when happen in the live server-sent-events stream, but the fact that they happened isn't kept around after that (also, bwt is currently entirely in-memory, so it would get lost if bwt itself shuts down)
2982020-05-20T14:57:37 <shesek> I setup a live bwt demo server on regtest if anyone wants to experiment. its on https://demo.bwt.dev/. you can try the https://demo.bwt.dev/stream endpoint (a transaction should happen every 10 seconds) or https://demo.bwt.dev/hd to see the tracked wallets
2992020-05-20T14:58:43 *** Pavlenex has joined #bitcoin-core-dev
3002020-05-20T15:00:02 *** Barras2 has quit IRC
3012020-05-20T15:02:45 *** ctrlbreak_MAD has quit IRC
3022020-05-20T15:03:13 *** ctrlbreak_MAD has joined #bitcoin-core-dev
3032020-05-20T15:03:19 <shesek> (ugh, its not actually working, fixing it..)
3042020-05-20T15:05:19 <shesek> its good now
3052020-05-20T15:05:44 *** dfmb_ has joined #bitcoin-core-dev
3062020-05-20T15:14:40 *** proofofkeags has joined #bitcoin-core-dev
3072020-05-20T15:19:01 *** gribble has quit IRC
3082020-05-20T15:19:17 *** patryk_ has joined #bitcoin-core-dev
3092020-05-20T15:20:37 *** justanotheruser has quit IRC
3102020-05-20T15:22:39 *** cnich has joined #bitcoin-core-dev
3112020-05-20T15:24:07 *** jonatack has quit IRC
3122020-05-20T15:25:28 *** Pavlenex has quit IRC
3132020-05-20T15:26:35 *** Pavlenex has joined #bitcoin-core-dev
3142020-05-20T15:30:06 *** gribble has joined #bitcoin-core-dev
3152020-05-20T15:30:35 *** promag has quit IRC
3162020-05-20T15:31:56 *** Guyver2_ has joined #bitcoin-core-dev
3172020-05-20T15:32:43 *** promag has joined #bitcoin-core-dev
3182020-05-20T15:34:58 *** Guyver2 has quit IRC
3192020-05-20T15:36:05 *** bitcoin-git has joined #bitcoin-core-dev
3202020-05-20T15:36:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19028: test: Set -logthreadnames in unit tests (master...2005-testThreadNames) https://github.com/bitcoin/bitcoin/pull/19028
3212020-05-20T15:36:06 *** bitcoin-git has left #bitcoin-core-dev
3222020-05-20T15:37:44 *** justanotheruser has joined #bitcoin-core-dev
3232020-05-20T15:38:50 *** cryptomanas has quit IRC
3242020-05-20T15:39:58 *** davterra has quit IRC
3252020-05-20T15:40:53 *** davterra has joined #bitcoin-core-dev
3262020-05-20T15:41:01 *** jonatack has joined #bitcoin-core-dev
3272020-05-20T15:45:39 *** Deacyde has joined #bitcoin-core-dev
3282020-05-20T15:49:51 *** bitcoin-git has joined #bitcoin-core-dev
3292020-05-20T15:49:51 <bitcoin-git> [bitcoin] hebasto opened pull request #19029: net: Fix CThreadInterrupt::sleep_for TSan issues (master...200520-interrupts) https://github.com/bitcoin/bitcoin/pull/19029
3302020-05-20T15:49:52 *** bitcoin-git has left #bitcoin-core-dev
3312020-05-20T15:55:09 *** DeanWeen has joined #bitcoin-core-dev
3322020-05-20T15:58:34 *** promag has quit IRC
3332020-05-20T16:03:18 *** dongcarl has quit IRC
3342020-05-20T16:03:27 *** promag has joined #bitcoin-core-dev
3352020-05-20T16:04:02 *** dongcarl has joined #bitcoin-core-dev
3362020-05-20T16:10:04 <hebasto> jonasschnelli: mind looking into the small #18424 ?
3372020-05-20T16:10:06 <gribble> https://github.com/bitcoin/bitcoin/issues/18424 | qt: Use parent-child relation to manage lifetime of OptionsModel object by hebasto · Pull Request #18424 · bitcoin/bitcoin · GitHub
3382020-05-20T16:10:29 *** ryzeb has joined #bitcoin-core-dev
3392020-05-20T16:16:47 *** bitcoin-git has joined #bitcoin-core-dev
3402020-05-20T16:16:47 <bitcoin-git> [bitcoin] vasild opened pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031
3412020-05-20T16:16:48 *** bitcoin-git has left #bitcoin-core-dev
3422020-05-20T16:20:04 *** vasild_ has joined #bitcoin-core-dev
3432020-05-20T16:20:48 <jamesob> sorry for the absence last few months; IRC client back on now
3442020-05-20T16:23:43 *** vasild has quit IRC
3452020-05-20T16:23:44 *** vasild_ is now known as vasild
3462020-05-20T16:26:58 *** d_t has joined #bitcoin-core-dev
3472020-05-20T16:37:00 *** andrewtoth has joined #bitcoin-core-dev
3482020-05-20T16:38:00 *** Ivan24 has quit IRC
3492020-05-20T16:40:09 *** lightlike has joined #bitcoin-core-dev
3502020-05-20T16:40:38 *** troygiorshev has joined #bitcoin-core-dev
3512020-05-20T16:41:40 *** davterra has quit IRC
3522020-05-20T16:42:04 *** davterra has joined #bitcoin-core-dev
3532020-05-20T16:43:05 *** Chris_Stewart_5 has quit IRC
3542020-05-20T16:50:13 *** bitcoin-git has joined #bitcoin-core-dev
3552020-05-20T16:50:13 <bitcoin-git> [bitcoin] dongcarl closed pull request #16748: [WIP] Add support for addrv2 (BIP155) (master...2019-07-addrv2v4) https://github.com/bitcoin/bitcoin/pull/16748
3562020-05-20T16:50:14 *** bitcoin-git has left #bitcoin-core-dev
3572020-05-20T16:53:47 *** PaulTroon has quit IRC
3582020-05-20T17:01:08 *** Relis has quit IRC
3592020-05-20T17:11:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3602020-05-20T17:14:08 *** Relis has joined #bitcoin-core-dev
3612020-05-20T17:15:55 *** promag has quit IRC
3622020-05-20T17:18:07 *** reardencode has quit IRC
3632020-05-20T17:25:42 *** jarthur has quit IRC
3642020-05-20T17:26:01 *** promag has joined #bitcoin-core-dev
3652020-05-20T17:26:08 *** jarthur has joined #bitcoin-core-dev
3662020-05-20T17:26:40 *** d_t has quit IRC
3672020-05-20T17:30:27 *** promag has quit IRC
3682020-05-20T17:32:26 *** mol has quit IRC
3692020-05-20T17:33:05 *** timothy has quit IRC
3702020-05-20T17:33:52 *** r251d has joined #bitcoin-core-dev
3712020-05-20T17:44:55 *** promag has joined #bitcoin-core-dev
3722020-05-20T17:50:13 *** mol has joined #bitcoin-core-dev
3732020-05-20T17:50:19 *** cornfeedhobo has quit IRC
3742020-05-20T17:51:43 *** DeanWeen has quit IRC
3752020-05-20T17:54:06 *** cornfeedhobo has joined #bitcoin-core-dev
3762020-05-20T17:56:41 *** davterra has quit IRC
3772020-05-20T18:00:02 *** patryk_ has quit IRC
3782020-05-20T18:01:22 *** owowo has quit IRC
3792020-05-20T18:03:38 *** mol_ has joined #bitcoin-core-dev
3802020-05-20T18:03:42 *** promag has quit IRC
3812020-05-20T18:05:18 *** mol has quit IRC
3822020-05-20T18:06:04 *** owowo has joined #bitcoin-core-dev
3832020-05-20T18:07:13 *** promag has joined #bitcoin-core-dev
3842020-05-20T18:11:12 *** proofofkeags has quit IRC
3852020-05-20T18:11:46 *** proofofkeags has joined #bitcoin-core-dev
3862020-05-20T18:13:55 *** jb55 has quit IRC
3872020-05-20T18:14:56 *** proofofkeags has quit IRC
3882020-05-20T18:15:10 *** proofofkeags has joined #bitcoin-core-dev
3892020-05-20T18:16:27 *** jonatack has quit IRC
3902020-05-20T18:16:52 *** bitcoin-git has joined #bitcoin-core-dev
3912020-05-20T18:16:53 <bitcoin-git> [bitcoin] sipa opened pull request #19032: Serialization improvements: final step (master...202005_noncastserial_final) https://github.com/bitcoin/bitcoin/pull/19032
3922020-05-20T18:16:54 *** bitcoin-git has left #bitcoin-core-dev
3932020-05-20T18:18:26 *** Pavlenex has quit IRC
3942020-05-20T18:18:28 *** jb55 has joined #bitcoin-core-dev
3952020-05-20T18:22:21 *** Chainsaw has joined #bitcoin-core-dev
3962020-05-20T18:22:27 *** Chainsaw is now known as Guest17803
3972020-05-20T18:24:23 *** jb55 has quit IRC
3982020-05-20T18:24:53 *** DeanWeen has joined #bitcoin-core-dev
3992020-05-20T18:26:56 *** promag has quit IRC
4002020-05-20T18:33:22 *** dongcarl has quit IRC
4012020-05-20T18:34:07 *** dongcarl has joined #bitcoin-core-dev
4022020-05-20T18:34:38 *** Pavlenex has joined #bitcoin-core-dev
4032020-05-20T18:38:05 *** jb55 has joined #bitcoin-core-dev
4042020-05-20T18:54:04 *** owowo has quit IRC
4052020-05-20T18:54:30 *** PaulTroon has joined #bitcoin-core-dev
4062020-05-20T18:59:09 *** owowo has joined #bitcoin-core-dev
4072020-05-20T18:59:23 *** PaulTroon has quit IRC
4082020-05-20T19:06:41 *** theStack has quit IRC
4092020-05-20T19:12:03 *** molz_ has joined #bitcoin-core-dev
4102020-05-20T19:13:54 <achow101> how do I run the travis lsan build locally?
4112020-05-20T19:14:15 *** bitcoin-git has joined #bitcoin-core-dev
4122020-05-20T19:14:15 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/448bdff26307...3eda7ea9ba72
4132020-05-20T19:14:16 <bitcoin-git> bitcoin/master eeaaa58 Sebastian Falbesoner: test: replace inv type magic numbers by constants
4142020-05-20T19:14:16 <bitcoin-git> bitcoin/master b35e1d2 Sebastian Falbesoner: test: add inventory type constant MSG_CMPCT_BLOCK
4152020-05-20T19:14:17 <bitcoin-git> bitcoin/master 4a614ff Sebastian Falbesoner: test: explicit imports from test_framework.messages in p2p_invalid_message...
4162020-05-20T19:14:18 *** bitcoin-git has left #bitcoin-core-dev
4172020-05-20T19:14:40 *** d_t has joined #bitcoin-core-dev
4182020-05-20T19:14:45 *** bitcoin-git has joined #bitcoin-core-dev
4192020-05-20T19:14:45 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18764: refactor: test: replace inv type magic numbers by constants (master...20200425-test-replace_inv_types_by_constants) https://github.com/bitcoin/bitcoin/pull/18764
4202020-05-20T19:14:46 *** bitcoin-git has left #bitcoin-core-dev
4212020-05-20T19:14:51 *** mol_ has quit IRC
4222020-05-20T19:17:15 *** Talkless has quit IRC
4232020-05-20T19:17:33 *** tryphe_ has joined #bitcoin-core-dev
4242020-05-20T19:20:10 *** tryphe has quit IRC
4252020-05-20T19:22:26 *** owowo has quit IRC
4262020-05-20T19:23:21 *** Pavlenex has quit IRC
4272020-05-20T19:25:44 *** Pavlenex has joined #bitcoin-core-dev
4282020-05-20T19:25:58 *** Chris_Stewart_5 has quit IRC
4292020-05-20T19:26:57 *** r251d has quit IRC
4302020-05-20T19:27:42 *** owowo has joined #bitcoin-core-dev
4312020-05-20T19:33:33 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4322020-05-20T19:53:03 *** marcoagn1 has joined #bitcoin-core-dev
4332020-05-20T19:53:31 *** jnewbery has quit IRC
4342020-05-20T19:54:31 *** marcoagner has quit IRC
4352020-05-20T19:55:01 *** jnewbery has joined #bitcoin-core-dev
4362020-05-20T19:58:56 *** dongcarl has quit IRC
4372020-05-20T20:13:47 *** lightlike has quit IRC
4382020-05-20T20:14:09 *** d_t has quit IRC
4392020-05-20T20:14:51 *** dongcarl has joined #bitcoin-core-dev
4402020-05-20T20:15:01 *** promag has joined #bitcoin-core-dev
4412020-05-20T20:27:22 *** marcoagn1 has quit IRC
4422020-05-20T20:29:21 *** Pavlenex has quit IRC
4432020-05-20T20:29:33 *** marcoagner has joined #bitcoin-core-dev
4442020-05-20T20:31:50 *** Victor_sueca has joined #bitcoin-core-dev
4452020-05-20T20:34:24 *** jarthur_ has joined #bitcoin-core-dev
4462020-05-20T20:34:46 *** Victorsueca has quit IRC
4472020-05-20T20:37:57 *** jarthur has quit IRC
4482020-05-20T20:57:50 *** promag_ has joined #bitcoin-core-dev
4492020-05-20T21:00:02 *** Guest17803 has quit IRC
4502020-05-20T21:06:06 *** bitcoin-git has joined #bitcoin-core-dev
4512020-05-20T21:06:07 <bitcoin-git> [bitcoin] promag opened pull request #19033: http: Fix workQueue race on InterruptHTTPServer (master...2020-05-fix-race-interrupt-http-server) https://github.com/bitcoin/bitcoin/pull/19033
4522020-05-20T21:06:08 *** bitcoin-git has left #bitcoin-core-dev
4532020-05-20T21:10:08 *** promag has quit IRC
4542020-05-20T21:11:03 *** PaulTroon has joined #bitcoin-core-dev
4552020-05-20T21:16:31 *** PaulTroon has quit IRC
4562020-05-20T21:21:30 *** mreider has joined #bitcoin-core-dev
4572020-05-20T21:26:23 *** troygiorshev has quit IRC
4582020-05-20T21:30:47 *** marcoagner has quit IRC
4592020-05-20T21:41:07 *** proofofkeags has quit IRC
4602020-05-20T21:41:26 *** proofofkeags has joined #bitcoin-core-dev
4612020-05-20T21:42:32 *** shesek has quit IRC
4622020-05-20T21:43:33 *** shesek has joined #bitcoin-core-dev
4632020-05-20T21:43:33 *** shesek has joined #bitcoin-core-dev
4642020-05-20T21:48:24 *** shesek has quit IRC
4652020-05-20T21:49:07 *** shesek has joined #bitcoin-core-dev
4662020-05-20T21:49:07 *** shesek has quit IRC
4672020-05-20T21:49:07 *** shesek has joined #bitcoin-core-dev
4682020-05-20T21:51:46 *** Guyver2_ has quit IRC
4692020-05-20T22:02:14 *** filchef has joined #bitcoin-core-dev
4702020-05-20T22:03:24 *** filchef has quit IRC
4712020-05-20T22:15:42 *** bitdex has joined #bitcoin-core-dev
4722020-05-20T22:31:20 *** promag has joined #bitcoin-core-dev
4732020-05-20T22:35:18 *** Relis has quit IRC
4742020-05-20T22:35:57 *** proofofkeags has quit IRC
4752020-05-20T22:36:15 *** dfmb_ has quit IRC
4762020-05-20T22:39:43 *** proofofkeags has joined #bitcoin-core-dev
4772020-05-20T22:39:43 *** proofofkeags has quit IRC
4782020-05-20T22:39:55 *** proofofkeags has joined #bitcoin-core-dev
4792020-05-20T22:41:21 *** DeanWeen has quit IRC
4802020-05-20T22:41:34 *** DeanWeen has joined #bitcoin-core-dev
4812020-05-20T22:44:41 *** mrostecki has quit IRC
4822020-05-20T22:45:07 *** mrostecki has joined #bitcoin-core-dev
4832020-05-20T22:47:43 *** dfmb_ has joined #bitcoin-core-dev
4842020-05-20T22:48:11 *** dfmb_ has quit IRC
4852020-05-20T22:54:05 *** mdunnio has quit IRC
4862020-05-20T22:59:25 *** Relis has joined #bitcoin-core-dev
4872020-05-20T23:00:51 *** troygiorshev has joined #bitcoin-core-dev
4882020-05-20T23:05:48 *** troygiorshev has quit IRC
4892020-05-20T23:08:12 *** dfmb_ has joined #bitcoin-core-dev
4902020-05-20T23:09:49 *** justanotheruser has quit IRC
4912020-05-20T23:13:05 *** mrostecki has quit IRC
4922020-05-20T23:15:04 *** mrostecki has joined #bitcoin-core-dev
4932020-05-20T23:17:16 *** dfmb_ has quit IRC
4942020-05-20T23:17:47 *** Dean_Guss has joined #bitcoin-core-dev
4952020-05-20T23:19:23 *** DeanWeen has quit IRC
4962020-05-20T23:23:52 *** jarthur_ has quit IRC
4972020-05-20T23:24:29 *** jarthur has joined #bitcoin-core-dev
4982020-05-20T23:27:00 *** justanotheruser has joined #bitcoin-core-dev
4992020-05-20T23:32:16 *** mrostecki has quit IRC
5002020-05-20T23:33:34 *** Relis has quit IRC
5012020-05-20T23:33:48 <promag> "verificationprogress": 1.882374845250915e-09 <- is it worth such precision?
5022020-05-20T23:36:39 <sipa> "you're REALLY far off still"
5032020-05-20T23:36:47 <sipa> promag: not sure what the alternative is?
5042020-05-20T23:37:44 <promag> heh, i'm instrumenting -qt and see where it "hangs"
5052020-05-20T23:39:50 <promag> sipa: round to say 5 decimal places? so it's more human friendly
5062020-05-20T23:40:15 <promag> "verificationprogress": 0.005865895479773644 VS "verificationprogress": 0.005867
5072020-05-20T23:42:26 *** mrostecki has joined #bitcoin-core-dev
5082020-05-20T23:57:38 *** ironhelix has joined #bitcoin-core-dev