12020-05-27T00:00:03  *** Trixar_za has quit IRC
  22020-05-27T00:01:54  *** jonatack has quit IRC
  32020-05-27T00:21:20  *** pixel_ has joined #bitcoin-core-dev
  42020-05-27T01:07:24  <achow101> any opinions on sqlite3 amalgamation source code (a ginormous sqlite3.c file that is all of sqlite's source code, provided by them), or linking against system/depends?
  52020-05-27T01:10:51  <sipa> given their strong guarantees for forward and backward compatibility, i think we should just link against the system version
  62020-05-27T01:11:32  <sipa> (and pin one version in depends)
  72020-05-27T01:12:10  <achow101> the only issue that could be a problem is if the system version was compiled with some option like THREADSAFE=0 which probably wouldn't be good
  82020-05-27T01:17:01  <luke-jr> achow101: hard NACK on bundling it..
  92020-05-27T01:17:16  <luke-jr> why does our end need to use threads for sqlite?
 102020-05-27T01:17:24  <luke-jr> bdb isn't threadsafe, is ti?
 112020-05-27T01:17:35  <achow101> bdb is definitely threadsafe
 122020-05-27T01:17:59  <achow101> we don't need to use threads, but I'm not convinced that we don't
 132020-05-27T01:18:17  *** Relis has quit IRC
 142020-05-27T01:18:41  <achow101> and I'd rather that the library does the threadsafe stuff even if it isn't needed
 152020-05-27T01:20:54  <luke-jr> sqlite3_threadsafe()
 162020-05-27T01:21:46  <luke-jr> would be nicer to detect during configure tho
 172020-05-27T01:22:24  <sipa> at configure time you can't know what flags the runtime version the user will be dynamically linking against has enabled...
 182020-05-27T01:22:33  <luke-jr> right
 192020-05-27T01:24:34  *** Relis has joined #bitcoin-core-dev
 202020-05-27T01:36:14  *** mdunnio has quit IRC
 212020-05-27T01:38:05  *** ppisati has quit IRC
 222020-05-27T01:38:18  *** ppisati has joined #bitcoin-core-dev
 232020-05-27T01:55:35  *** promag has joined #bitcoin-core-dev
 242020-05-27T02:00:19  *** promag has quit IRC
 252020-05-27T02:10:30  *** mdunnio has joined #bitcoin-core-dev
 262020-05-27T02:14:39  *** mdunnio has quit IRC
 272020-05-27T02:16:43  *** owowo has quit IRC
 282020-05-27T02:22:39  *** surja795 has quit IRC
 292020-05-27T02:32:16  *** surja795 has joined #bitcoin-core-dev
 302020-05-27T02:39:53  *** shesek has quit IRC
 312020-05-27T02:40:16  *** shesek has joined #bitcoin-core-dev
 322020-05-27T02:40:16  *** shesek has joined #bitcoin-core-dev
 332020-05-27T02:42:25  *** bitcoin-git has joined #bitcoin-core-dev
 342020-05-27T02:42:25  <bitcoin-git> [bitcoin] achow101 opened pull request #19077: wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets (master...sqlite-wallet) https://github.com/bitcoin/bitcoin/pull/19077
 352020-05-27T02:42:26  *** bitcoin-git has left #bitcoin-core-dev
 362020-05-27T02:45:18  <fanquake> + 240'000 lines
 372020-05-27T02:45:33  <fanquake> sqlite3.c is quite the amalgamation
 382020-05-27T02:45:35  <achow101> the sqlite3.c amalgamation file is very large
 392020-05-27T02:51:28  <sipa> achow101: as luke-jr mentioned, if we need thread-safeness, you can include an assert(sqlite_threadsafe())
 402020-05-27T02:51:37  *** surja795 has quit IRC
 412020-05-27T02:52:09  <sipa> so i don't think that's a reason to bundle
 422020-05-27T02:52:36  *** bitcoin-git has joined #bitcoin-core-dev
 432020-05-27T02:52:36  <bitcoin-git> [bitcoin] meshcollider pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/4af01b37d402...520e435b5e56
 442020-05-27T02:52:37  <bitcoin-git> bitcoin/master c877709 Andrew Chow: wallettool: Add a salvage command
 452020-05-27T02:52:37  <bitcoin-git> bitcoin/master cdd955e Andrew Chow: Add basic test for bitcoin-wallet salvage
 462020-05-27T02:52:38  <bitcoin-git> bitcoin/master d321046 Andrew Chow: wallet: remove -salvagewallet
 472020-05-27T02:52:39  *** bitcoin-git has left #bitcoin-core-dev
 482020-05-27T02:52:56  *** bitcoin-git has joined #bitcoin-core-dev
 492020-05-27T02:52:56  <bitcoin-git> [bitcoin] meshcollider merged pull request #18918: wallet: Move salvagewallet into wallettool (master...wallettool-salvagewallet) https://github.com/bitcoin/bitcoin/pull/18918
 502020-05-27T02:52:57  *** bitcoin-git has left #bitcoin-core-dev
 512020-05-27T02:53:11  <fanquake> The linter is having an absolute meltdown over sqlite3.c heh: https://travis-ci.org/github/bitcoin/bitcoin/jobs/691575513
 522020-05-27T02:53:26  <achow101> yeah, trying to figure out how to exlucde it from everything
 532020-05-27T02:54:17  <achow101> sipa: there are some other options that could be problematic. I haven't fully explored them yet
 542020-05-27T02:54:34  <luke-jr> achow101: don't, just remove it
 552020-05-27T02:54:36  <meshcollider> Please explore them quickly then :)
 562020-05-27T02:54:46  <sipa> achow101: i doubt that, as long as we use no crazy extensions
 572020-05-27T03:00:02  *** pixel_ has quit IRC
 582020-05-27T03:01:06  <achow101> SQLITE_DEFAULT_FILE_FORMAT could be useful in the future for compatibility stuff
 592020-05-27T03:01:26  <achow101> but I suppose if that matters we can deal with it later
 602020-05-27T03:06:38  <luke-jr> achow101: you can configure it at runtime..
 612020-05-27T03:14:39  <achow101> now I need to figure out how to add sqlite to depends and travis
 622020-05-27T03:18:20  *** alex12 has joined #bitcoin-core-dev
 632020-05-27T03:30:57  <luke-jr> Travis should be easy :x
 642020-05-27T03:50:46  *** pinheadm_ has joined #bitcoin-core-dev
 652020-05-27T03:52:14  *** pinheadm_ has quit IRC
 662020-05-27T03:53:16  *** pinheadm_ has joined #bitcoin-core-dev
 672020-05-27T03:53:20  *** pinheadmz has quit IRC
 682020-05-27T03:53:41  *** pinheadm_ has quit IRC
 692020-05-27T04:02:08  *** wangchun has quit IRC
 702020-05-27T04:20:14  *** vasild_ has joined #bitcoin-core-dev
 712020-05-27T04:23:23  *** vasild has quit IRC
 722020-05-27T04:23:24  *** vasild_ is now known as vasild
 732020-05-27T04:28:50  *** justanotheruser has quit IRC
 742020-05-27T04:29:08  *** justanotheruser has joined #bitcoin-core-dev
 752020-05-27T04:46:35  *** instagibbs has quit IRC
 762020-05-27T04:47:40  *** luke-jr has quit IRC
 772020-05-27T04:47:52  *** instagibbs has joined #bitcoin-core-dev
 782020-05-27T04:49:02  *** luke-jr has joined #bitcoin-core-dev
 792020-05-27T05:13:41  *** jeremyrubin has quit IRC
 802020-05-27T05:14:35  *** jeremyrubin has joined #bitcoin-core-dev
 812020-05-27T05:32:03  *** justanotheruser has quit IRC
 822020-05-27T05:32:55  *** alex12 has quit IRC
 832020-05-27T05:37:22  *** marcoagner has joined #bitcoin-core-dev
 842020-05-27T05:38:32  *** justanotheruser has joined #bitcoin-core-dev
 852020-05-27T05:55:24  *** total1ty has joined #bitcoin-core-dev
 862020-05-27T05:55:26  *** total1ty is now known as Guest98047
 872020-05-27T06:00:01  *** Guest98047 has quit IRC
 882020-05-27T06:22:21  *** andrea has joined #bitcoin-core-dev
 892020-05-27T06:22:45  *** andrea is now known as Guest5579
 902020-05-27T06:56:23  *** promag has joined #bitcoin-core-dev
 912020-05-27T07:01:05  *** promag has quit IRC
 922020-05-27T07:01:13  *** Pavlenex1 has joined #bitcoin-core-dev
 932020-05-27T07:03:33  *** Pavlenex1 is now known as Pavlenex
 942020-05-27T07:12:41  *** jonatack_ has quit IRC
 952020-05-27T07:13:34  *** jonatack_ has joined #bitcoin-core-dev
 962020-05-27T07:23:22  *** PaulTroon has joined #bitcoin-core-dev
 972020-05-27T07:24:57  *** Relis has quit IRC
 982020-05-27T07:25:28  *** Guyver2 has joined #bitcoin-core-dev
 992020-05-27T07:47:30  *** Kiminuo has joined #bitcoin-core-dev
1002020-05-27T07:49:17  *** Kiminuo has quit IRC
1012020-05-27T07:53:49  *** skypper has joined #bitcoin-core-dev
1022020-05-27T07:53:49  *** jonatack_ has quit IRC
1032020-05-27T07:58:29  *** jonatack has joined #bitcoin-core-dev
1042020-05-27T08:05:55  *** skypper has left #bitcoin-core-dev
1052020-05-27T08:06:11  *** skypper has joined #bitcoin-core-dev
1062020-05-27T08:12:34  *** jkczyz_ has joined #bitcoin-core-dev
1072020-05-27T08:12:46  *** NicolasDorier_ has joined #bitcoin-core-dev
1082020-05-27T08:20:07  *** jkczyz has quit IRC
1092020-05-27T08:20:07  *** NicolasDorier has quit IRC
1102020-05-27T08:20:08  *** cncr04s has quit IRC
1112020-05-27T08:20:13  *** jkczyz_ is now known as jkczyz
1122020-05-27T08:20:13  *** NicolasDorier_ is now known as NicolasDorier
1132020-05-27T08:22:42  *** cncr04s_ has joined #bitcoin-core-dev
1142020-05-27T08:29:54  *** timothy has joined #bitcoin-core-dev
1152020-05-27T08:36:09  *** promag has joined #bitcoin-core-dev
1162020-05-27T08:50:39  *** skypper has quit IRC
1172020-05-27T09:00:01  *** Guest5579 has quit IRC
1182020-05-27T09:21:03  *** shortdudey1231 has joined #bitcoin-core-dev
1192020-05-27T09:26:18  *** EagleTM has joined #bitcoin-core-dev
1202020-05-27T09:26:47  *** provoostenator has joined #bitcoin-core-dev
1212020-05-27T09:26:59  <provoostenator> harding: #17219 was merged on April 17th, which if after 0.20 branched off
1222020-05-27T09:27:02  <gribble> https://github.com/bitcoin/bitcoin/issues/17219 | wallet: allow transaction without change if keypool is empty by Sjors · Pull Request #17219 · bitcoin/bitcoin · GitHub
1232020-05-27T09:31:58  <provoostenator> I plan to do a write-up on hardware wallet pull requests and they relate. The meat and potatos is in #16546, which I keep up to date regularly.
1242020-05-27T09:32:01  <gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
1252020-05-27T09:34:05  <provoostenator> It depends on an improvment to sendmany  sendaddress to work with PSBT. There's multiple ways to do that, including writing a whole new send RPC method like in #16378
1262020-05-27T09:34:08  <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
1272020-05-27T09:34:42  <provoostenator> It also needs a way to communicate with the device, which for now I'm using Boost::Process for. Similar to the dicussion with multiprocess, that method can be swapped out later
1282020-05-27T09:35:11  <provoostenator> But I haven't seen any worked out alternatives in over a year, so #15382  appears the way to go.
1292020-05-27T09:35:15  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
1302020-05-27T09:36:32  <provoostenator> Finally there's a GUI PR which is more rough, and depends on all the above. But it nicely illustrates what a relatively user friendly experience could look like. #16546
1312020-05-27T09:36:34  <gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
1322020-05-27T09:36:55  <provoostenator> I mean #16549
1332020-05-27T09:36:58  <gribble> https://github.com/bitcoin/bitcoin/issues/16549 | UI external signer support (e.g. hardware wallet) by Sjors · Pull Request #16549 · bitcoin/bitcoin · GitHub
1342020-05-27T09:37:46  <provoostenator> I keep that one rebased too.
1352020-05-27T09:38:31  <provoostenator> Everything is designed to work with HWI, but any other script or program with the same interface works too.
1362020-05-27T09:39:45  <provoostenator> Which I imagine could be more than just a locally connected hardware wallet. E.g. perhaps an online multisig cosigner service.
1372020-05-27T09:43:14  *** Pavlenex has quit IRC
1382020-05-27T09:47:50  <jonatack> provoostenator: per our recent discussion offline, it would be great to move these forward by highlighting the highest or first priority one to focus review on, and maybe add to the blockers tomorrow... 15382 or 16546 IIUC?
1392020-05-27T09:48:44  <provoostenator> 15382 would make sense for that, since it has no dependencies
1402020-05-27T09:50:07  *** AaronvanW has joined #bitcoin-core-dev
1412020-05-27T09:50:22  <provoostenator> But also kallewoof's #11413 (though he has a Signet PR in prioriy list)
1422020-05-27T09:50:25  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
1432020-05-27T09:51:17  <provoostenator> ^ that PR is a such a bit change to the send RPC calls that it blocks other work on them
1442020-05-27T09:51:36  *** bitcoin-git has joined #bitcoin-core-dev
1452020-05-27T09:51:36  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/520e435b5e56...48e114e0a86f
1462020-05-27T09:51:37  <bitcoin-git> bitcoin/master 1c91ffe pad: doc : add link to readme.md in the first section
1472020-05-27T09:51:37  <bitcoin-git> bitcoin/master 48e114e fanquake: Merge #19061: doc: Add link to Visual Studio build readme
1482020-05-27T09:51:48  *** bitcoin-git has left #bitcoin-core-dev
1492020-05-27T09:52:06  *** bitcoin-git has joined #bitcoin-core-dev
1502020-05-27T09:52:06  <bitcoin-git> [bitcoin] fanquake merged pull request #19061: doc: Add link to Visual Studio build readme (master...master) https://github.com/bitcoin/bitcoin/pull/19061
1512020-05-27T09:52:07  *** bitcoin-git has left #bitcoin-core-dev
1522020-05-27T09:52:39  *** EagleTM has quit IRC
1532020-05-27T09:52:55  <jonatack> provoostenator: ok, noting for my review list. (i probably won't be at the irc meeting since they are during my sleep hours ATM, but i'll check the blockers list anyway)
1542020-05-27T09:56:44  *** rmoura has joined #bitcoin-core-dev
1552020-05-27T10:03:22  *** Diego42Wiza has joined #bitcoin-core-dev
1562020-05-27T10:03:29  *** Pavlenex has joined #bitcoin-core-dev
1572020-05-27T10:09:29  *** harrigan has quit IRC
1582020-05-27T10:10:19  *** surja795 has joined #bitcoin-core-dev
1592020-05-27T10:12:07  *** harrigan has joined #bitcoin-core-dev
1602020-05-27T10:15:33  *** PaulTroon has quit IRC
1612020-05-27T10:18:35  *** Pavlenex has quit IRC
1622020-05-27T10:24:32  *** dfmb_ has joined #bitcoin-core-dev
1632020-05-27T10:25:33  *** Pavlenex has joined #bitcoin-core-dev
1642020-05-27T10:36:19  *** bitcoin-git has joined #bitcoin-core-dev
1652020-05-27T10:36:19  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48e114e0a86f...cffbf1eb9a47
1662020-05-27T10:36:20  <bitcoin-git> bitcoin/master 4c82579 Elichai Turkel: Remove outdated comment about DER encoding
1672020-05-27T10:36:20  <bitcoin-git> bitcoin/master cffbf1e fanquake: Merge #19073: Remove outdated comment about DER encoding
1682020-05-27T10:36:22  *** bitcoin-git has left #bitcoin-core-dev
1692020-05-27T10:36:39  *** bitcoin-git has joined #bitcoin-core-dev
1702020-05-27T10:36:39  <bitcoin-git> [bitcoin] fanquake merged pull request #19073: Remove outdated comment about DER encoding (master...2020-05-remove-der-comment) https://github.com/bitcoin/bitcoin/pull/19073
1712020-05-27T10:36:40  *** bitcoin-git has left #bitcoin-core-dev
1722020-05-27T10:40:07  *** jonatack has quit IRC
1732020-05-27T10:41:50  <harding> provoostenator: yeah, I don't know why 17219 seemed to be described in the 0.20 draft release notes.  Let me see if I can figure out who added it.
1742020-05-27T10:42:30  <fanquake> It might have been achow101 on my misdirection. I thought that PR was part of 0.20.0
1752020-05-27T10:43:44  <fanquake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/c5bd4e39348402cd9d2cbadf9bbc049836a9df16
1762020-05-27T10:45:15  <harding> Ok, mystery solved.  I just wanted to make sure I wasn't removing something that actually did apply to 0.20.  I've got it queued for a PR to master for when I finish editing all the 0.20 stuff.
1772020-05-27T10:45:39  *** Diego42Wiza has quit IRC
1782020-05-27T10:46:30  *** jonatack has joined #bitcoin-core-dev
1792020-05-27T10:47:50  *** PaulTroon has joined #bitcoin-core-dev
1802020-05-27T11:11:47  *** jonatack has quit IRC
1812020-05-27T11:12:14  <meshcollider> instagibbs: I *will* get around to reviewing #17331 (and its parent) next week even though I hate coin selection, I promise. The next couple of days are just going to be super busy but after that, as you requested...
1822020-05-27T11:12:17  <gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
1832020-05-27T11:13:14  *** promag has quit IRC
1842020-05-27T11:14:17  *** jonatack has joined #bitcoin-core-dev
1852020-05-27T11:14:37  *** Guyver2 has quit IRC
1862020-05-27T11:15:04  <meshcollider> Same with #18275, sorry kalle, it's been on my list for a while but I promise it isn't forgotten
1872020-05-27T11:15:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18275 | wallet: error if an explicit fee rate was given but the needed fee rate differed by kallewoof · Pull Request #18275 · bitcoin/bitcoin · GitHub
1882020-05-27T11:16:00  *** Pavlenex has quit IRC
1892020-05-27T11:18:47  *** bitcoin-git has joined #bitcoin-core-dev
1902020-05-27T11:18:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cffbf1eb9a47...9ccaee1d5e2e
1912020-05-27T11:18:48  <bitcoin-git> bitcoin/master c57f03c Calvin Kim: refactor: Replace const char* to std::string
1922020-05-27T11:18:49  <bitcoin-git> bitcoin/master 9ccaee1 MarcoFalke: Merge #19004: refactor: Replace const char* to std::string
1932020-05-27T11:18:51  *** bitcoin-git has left #bitcoin-core-dev
1942020-05-27T11:19:03  *** DeanWeen has quit IRC
1952020-05-27T11:19:08  *** bitcoin-git has joined #bitcoin-core-dev
1962020-05-27T11:19:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19004: refactor: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
1972020-05-27T11:19:09  *** bitcoin-git has left #bitcoin-core-dev
1982020-05-27T11:42:08  *** Pavlenex has joined #bitcoin-core-dev
1992020-05-27T11:52:30  *** pinheadmz has joined #bitcoin-core-dev
2002020-05-27T11:58:14  <elichai2> Hi, why is the nVersion of the block header the top bits instead of the "regular" ones? (ie why `0x20000000UL` instead of `4`)
2012020-05-27T11:58:22  *** someone235 has joined #bitcoin-core-dev
2022020-05-27T12:00:02  *** shortdudey1231 has quit IRC
2032020-05-27T12:18:07  *** cltrbreak_MAD2 has quit IRC
2042020-05-27T12:18:33  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
2052020-05-27T12:19:07  *** tasmo has joined #bitcoin-core-dev
2062020-05-27T12:20:20  *** Pavlenex has quit IRC
2072020-05-27T12:34:43  *** promag has joined #bitcoin-core-dev
2082020-05-27T12:41:18  *** bitcoin-git has joined #bitcoin-core-dev
2092020-05-27T12:41:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
2102020-05-27T12:41:19  *** bitcoin-git has left #bitcoin-core-dev
2112020-05-27T12:42:37  *** troygiorshev has joined #bitcoin-core-dev
2122020-05-27T12:49:58  <harding> I added some previously-undocumented changes to the 0.20 release notes draft.  Review is appreciated; I'm happy to make any edits: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/cd86fd949c5dc3bf8c85f7f4935cac0c1ae0fb55...d87bc6f05e506ae1ff358ccff4e7f4cbbe2c1fb3
2132020-05-27T12:57:12  <fanquake> harding: probably just squashing the "build system" section added at the bottom with the "build system section" at the top of the notes. Unless they were kept split for a reason.
2142020-05-27T13:06:11  <jonatack> harding: lgtm. micro-nit: s/parameter than can be used/parameter that can be used/
2152020-05-27T13:13:29  *** wullon5 has quit IRC
2162020-05-27T13:24:16  *** lehnberg has joined #bitcoin-core-dev
2172020-05-27T13:24:56  *** mdunnio has joined #bitcoin-core-dev
2182020-05-27T13:29:59  *** Pavlenex has joined #bitcoin-core-dev
2192020-05-27T13:50:34  *** d_t has joined #bitcoin-core-dev
2202020-05-27T13:54:54  *** d_t has quit IRC
2212020-05-27T14:06:02  *** Pavlenex1 has joined #bitcoin-core-dev
2222020-05-27T14:06:41  *** Pavlenex has quit IRC
2232020-05-27T14:07:09  *** Relis has joined #bitcoin-core-dev
2242020-05-27T14:07:19  *** Pavlenex has joined #bitcoin-core-dev
2252020-05-27T14:09:12  *** Pavlenex has quit IRC
2262020-05-27T14:10:45  *** Pavlenex1 has quit IRC
2272020-05-27T14:20:38  *** Pavlenex has joined #bitcoin-core-dev
2282020-05-27T14:27:39  *** Pavlenex has quit IRC
2292020-05-27T14:29:22  *** Pavlenex has joined #bitcoin-core-dev
2302020-05-27T14:30:04  *** Pavlenex has quit IRC
2312020-05-27T14:30:22  *** Pavlenex has joined #bitcoin-core-dev
2322020-05-27T14:30:53  <harding> fanquake, jonatack: thanks!
2332020-05-27T14:32:51  *** Pavlenex has quit IRC
2342020-05-27T14:57:47  *** rmoura has quit IRC
2352020-05-27T15:00:01  *** tasmo has quit IRC
2362020-05-27T15:00:49  *** cltrbreak_MAD2 has quit IRC
2372020-05-27T15:01:16  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
2382020-05-27T15:08:32  *** DeanWeen has joined #bitcoin-core-dev
2392020-05-27T15:10:04  *** promag has quit IRC
2402020-05-27T15:16:47  *** jarthur_ has joined #bitcoin-core-dev
2412020-05-27T15:19:14  *** jarthur_ has quit IRC
2422020-05-27T15:20:18  *** jarthur has quit IRC
2432020-05-27T15:22:08  *** engil1 has joined #bitcoin-core-dev
2442020-05-27T15:32:59  *** promag has joined #bitcoin-core-dev
2452020-05-27T15:39:22  *** sipsorcery has quit IRC
2462020-05-27T15:41:20  *** Talkless has joined #bitcoin-core-dev
2472020-05-27T15:44:06  *** promag has quit IRC
2482020-05-27T15:45:10  *** owowo has joined #bitcoin-core-dev
2492020-05-27T15:45:10  *** owowo has joined #bitcoin-core-dev
2502020-05-27T15:45:51  *** promag has joined #bitcoin-core-dev
2512020-05-27T15:46:14  *** Pavlenex has joined #bitcoin-core-dev
2522020-05-27T15:48:39  *** roconnor has joined #bitcoin-core-dev
2532020-05-27T15:48:53  *** justanotheruser has quit IRC
2542020-05-27T15:49:04  *** wullon5 has joined #bitcoin-core-dev
2552020-05-27T15:50:33  *** promag has quit IRC
2562020-05-27T15:57:23  <roconnor> elichai2: See BIP-9
2572020-05-27T15:58:09  *** owowo has quit IRC
2582020-05-27T16:02:37  *** owowo has joined #bitcoin-core-dev
2592020-05-27T16:03:50  *** justanotheruser has joined #bitcoin-core-dev
2602020-05-27T16:03:53  *** wullon5 has quit IRC
2612020-05-27T16:09:54  *** sipsorcery has joined #bitcoin-core-dev
2622020-05-27T16:11:58  *** DeanWeen has quit IRC
2632020-05-27T16:13:24  *** DeanWeen has joined #bitcoin-core-dev
2642020-05-27T16:20:20  *** vasild_ has joined #bitcoin-core-dev
2652020-05-27T16:23:23  *** vasild has quit IRC
2662020-05-27T16:23:24  *** vasild_ is now known as vasild
2672020-05-27T16:24:27  *** Pavlenex has quit IRC
2682020-05-27T16:24:33  *** troygiorshev has quit IRC
2692020-05-27T16:24:47  *** Pavlenex has joined #bitcoin-core-dev
2702020-05-27T16:26:12  *** Landryl has joined #bitcoin-core-dev
2712020-05-27T16:29:32  *** Talkless has quit IRC
2722020-05-27T16:34:47  *** Landryl has quit IRC
2732020-05-27T16:35:26  *** Landryl has joined #bitcoin-core-dev
2742020-05-27T16:44:47  *** Landryl has quit IRC
2752020-05-27T16:45:24  *** Landryl has joined #bitcoin-core-dev
2762020-05-27T16:49:48  *** kristapsk has quit IRC
2772020-05-27T16:50:09  *** kristapsk has joined #bitcoin-core-dev
2782020-05-27T16:50:40  *** dongcarl has quit IRC
2792020-05-27T16:51:25  *** shaunsun has joined #bitcoin-core-dev
2802020-05-27T16:51:28  *** troygiorshev has joined #bitcoin-core-dev
2812020-05-27T16:55:10  *** r251d has joined #bitcoin-core-dev
2822020-05-27T17:00:27  *** tarboss has joined #bitcoin-core-dev
2832020-05-27T17:01:07  *** promag has joined #bitcoin-core-dev
2842020-05-27T17:03:42  *** Landryl has quit IRC
2852020-05-27T17:07:45  *** bitcoin-git has joined #bitcoin-core-dev
2862020-05-27T17:07:45  <bitcoin-git> [bitcoin] gillichu opened pull request #19082: Moved the CScriptNum asserts into the unit test in script.py (master...issue24) https://github.com/bitcoin/bitcoin/pull/19082
2872020-05-27T17:07:53  *** bitcoin-git has left #bitcoin-core-dev
2882020-05-27T17:11:57  *** jarthur has joined #bitcoin-core-dev
2892020-05-27T17:18:17  *** Landryl has joined #bitcoin-core-dev
2902020-05-27T17:22:10  *** sipsorcery has quit IRC
2912020-05-27T17:24:35  *** Ridwan102 has joined #bitcoin-core-dev
2922020-05-27T17:25:42  *** Talkless has joined #bitcoin-core-dev
2932020-05-27T17:25:42  *** sipsorcery has joined #bitcoin-core-dev
2942020-05-27T17:25:58  *** dongcarl has joined #bitcoin-core-dev
2952020-05-27T17:29:32  *** promag has quit IRC
2962020-05-27T17:30:06  *** r251d has quit IRC
2972020-05-27T17:32:00  *** Landryl has quit IRC
2982020-05-27T17:32:37  *** Landryl has joined #bitcoin-core-dev
2992020-05-27T17:33:13  *** mdunnio has quit IRC
3002020-05-27T17:38:06  *** someone235 has quit IRC
3012020-05-27T17:39:54  *** shaunsun has quit IRC
3022020-05-27T17:45:58  *** shaunsun has joined #bitcoin-core-dev
3032020-05-27T17:46:01  *** mdunnio has joined #bitcoin-core-dev
3042020-05-27T17:52:17  *** Ridwan102 has quit IRC
3052020-05-27T17:52:17  *** pinheadm_ has joined #bitcoin-core-dev
3062020-05-27T17:54:14  *** pinheadmz has quit IRC
3072020-05-27T18:00:02  *** engil1 has quit IRC
3082020-05-27T18:01:54  *** tarboss has quit IRC
3092020-05-27T18:10:52  *** danielyin has joined #bitcoin-core-dev
3102020-05-27T18:20:59  *** Ceriand has joined #bitcoin-core-dev
3112020-05-27T18:34:27  *** dfmb_ has quit IRC
3122020-05-27T19:11:36  *** bitcoin-git has joined #bitcoin-core-dev
3132020-05-27T19:11:36  <bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19063: rpc: testmempoolaccept returns transaction fee (master...fee-in-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/19063
3142020-05-27T19:11:38  *** bitcoin-git has left #bitcoin-core-dev
3152020-05-27T19:12:09  *** Pavlenex has quit IRC
3162020-05-27T19:24:28  *** Talkless has quit IRC
3172020-05-27T19:29:23  *** lehnberg_ has joined #bitcoin-core-dev
3182020-05-27T19:30:50  *** cltrbreak_MAD2 has quit IRC
3192020-05-27T19:31:14  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
3202020-05-27T19:32:14  *** lehnberg has quit IRC
3212020-05-27T19:35:00  *** tryphe has quit IRC
3222020-05-27T19:35:29  *** tryphe has joined #bitcoin-core-dev
3232020-05-27T19:38:14  *** pingwindyktator has quit IRC
3242020-05-27T19:38:39  *** pingwindyktator has joined #bitcoin-core-dev
3252020-05-27T19:48:23  *** PaulTroon has quit IRC
3262020-05-27T19:55:10  *** troygiorshev has quit IRC
3272020-05-27T19:57:37  *** Guyver2 has joined #bitcoin-core-dev
3282020-05-27T20:03:08  *** troygiorshev has joined #bitcoin-core-dev
3292020-05-27T20:10:54  *** PaulTroon has joined #bitcoin-core-dev
3302020-05-27T20:26:21  *** troygiorshev has quit IRC
3312020-05-27T20:27:11  *** jonatack has quit IRC
3322020-05-27T20:29:40  *** jonatack has joined #bitcoin-core-dev
3332020-05-27T20:31:40  *** lehnberg_ has quit IRC
3342020-05-27T20:41:09  *** promag has joined #bitcoin-core-dev
3352020-05-27T20:48:21  *** ghost43 has quit IRC
3362020-05-27T20:48:40  *** ghost43 has joined #bitcoin-core-dev
3372020-05-27T20:49:07  *** marcoagner has quit IRC
3382020-05-27T20:51:52  *** SiAnDoG has joined #bitcoin-core-dev
3392020-05-27T21:00:02  *** Ceriand has quit IRC
3402020-05-27T21:01:50  *** go11111111111 has joined #bitcoin-core-dev
3412020-05-27T21:05:25  *** go121212 has quit IRC
3422020-05-27T21:21:20  *** variable has joined #bitcoin-core-dev
3432020-05-27T21:21:31  *** variable is now known as Guest8623
3442020-05-27T21:25:07  *** ghost43 has quit IRC
3452020-05-27T21:25:34  *** ghost43 has joined #bitcoin-core-dev
3462020-05-27T21:27:02  *** proofofkeags has joined #bitcoin-core-dev
3472020-05-27T21:27:29  *** Guyver2 has quit IRC
3482020-05-27T21:35:49  *** pinheadm_ has quit IRC
3492020-05-27T21:36:17  *** pinheadmz has joined #bitcoin-core-dev
3502020-05-27T21:48:37  *** sipsorcery has quit IRC
3512020-05-27T22:04:06  *** bitcoin-git has joined #bitcoin-core-dev
3522020-05-27T22:04:06  <bitcoin-git> [bitcoin] gzhao408 opened pull request #19083: test: msg_mempool, fRelay, and other bloomfilter tests (master...test-bloomfilter) https://github.com/bitcoin/bitcoin/pull/19083
3532020-05-27T22:04:07  *** bitcoin-git has left #bitcoin-core-dev
3542020-05-27T22:14:59  *** sipsorcery has joined #bitcoin-core-dev
3552020-05-27T22:31:37  *** sipsorcery has quit IRC
3562020-05-27T22:40:40  *** timothy has quit IRC
3572020-05-27T22:47:48  *** CubicEarth has quit IRC
3582020-05-27T22:51:12  *** CubicEarth has joined #bitcoin-core-dev
3592020-05-27T22:59:27  *** promag has quit IRC
3602020-05-27T23:00:15  *** ghost43 has quit IRC
3612020-05-27T23:00:52  *** ghost43 has joined #bitcoin-core-dev
3622020-05-27T23:04:21  *** mdunnio has quit IRC
3632020-05-27T23:04:38  *** proofofk_ has joined #bitcoin-core-dev
3642020-05-27T23:06:47  *** proofofk_ has quit IRC
3652020-05-27T23:07:07  *** proofofk_ has joined #bitcoin-core-dev
3662020-05-27T23:07:33  *** proofofkeags has quit IRC
3672020-05-27T23:09:37  *** jonatack_ has joined #bitcoin-core-dev
3682020-05-27T23:12:38  *** jonatack has quit IRC
3692020-05-27T23:14:31  *** shaunsun has quit IRC
3702020-05-27T23:19:03  *** DeanWeen has quit IRC
3712020-05-27T23:19:04  *** proofofk_ has quit IRC
3722020-05-27T23:19:11  *** proofofkeags has joined #bitcoin-core-dev
3732020-05-27T23:19:47  *** DeanWeen has joined #bitcoin-core-dev
3742020-05-27T23:20:43  *** justanotheruser has quit IRC
3752020-05-27T23:24:32  *** justanotheruser has joined #bitcoin-core-dev
3762020-05-27T23:32:25  *** PaulTroon has quit IRC
3772020-05-27T23:34:14  *** bitcoin-git has joined #bitcoin-core-dev
3782020-05-27T23:34:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9ccaee1d5e2e...55b4c65bd1d8
3792020-05-27T23:34:15  <bitcoin-git> bitcoin/master c3cf2f5 Anthony Towns: rpc/blockchain.cpp: Remove g_utxosetscan mutex that is only protecting a s...
3802020-05-27T23:34:15  <bitcoin-git> bitcoin/master de7c5f4 Anthony Towns: wallet/wallet.h: Remove mutexScanning which was only protecting a single a...
3812020-05-27T23:34:16  <bitcoin-git> bitcoin/master 8b5af3d Anthony Towns: net: fMsgProcWake use LOCK instead of lock_guard
3822020-05-27T23:34:16  *** bitcoin-git has left #bitcoin-core-dev
3832020-05-27T23:35:44  *** bitcoin-git has joined #bitcoin-core-dev
3842020-05-27T23:35:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16127: More thread safety annotation coverage (master...201905-locking) https://github.com/bitcoin/bitcoin/pull/16127
3852020-05-27T23:35:45  *** bitcoin-git has left #bitcoin-core-dev
3862020-05-27T23:45:37  *** promag_ has quit IRC
3872020-05-27T23:47:22  *** promag has joined #bitcoin-core-dev
3882020-05-27T23:51:07  *** kaftejiman has joined #bitcoin-core-dev
3892020-05-27T23:54:25  *** justanotheruser has quit IRC