12020-05-29T00:00:01 *** JesusFreke has quit IRC
22020-05-29T00:05:00 *** cltrbreak_MAD2 has quit IRC
32020-05-29T00:05:26 *** cltrbreak_MAD2 has joined #bitcoin-core-dev
42020-05-29T00:09:52 *** promag has quit IRC
52020-05-29T00:11:50 *** ghost43 has quit IRC
62020-05-29T00:12:07 *** ghost43 has joined #bitcoin-core-dev
72020-05-29T00:16:24 *** IGHOR has quit IRC
82020-05-29T00:16:57 *** langseth1 has joined #bitcoin-core-dev
92020-05-29T00:17:39 *** troygiorshev has quit IRC
102020-05-29T00:18:02 *** IGHOR has joined #bitcoin-core-dev
112020-05-29T00:21:42 *** proofofkeags has quit IRC
122020-05-29T00:31:47 *** Relis has quit IRC
132020-05-29T00:32:10 *** Relis has joined #bitcoin-core-dev
142020-05-29T00:37:37 <jamesob> fanquake: roger that, will queue. Expect some bitcoinperf developments soon
152020-05-29T00:42:10 *** AaronvanW has quit IRC
162020-05-29T00:43:34 *** bitcoin-git has joined #bitcoin-core-dev
172020-05-29T00:43:35 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea3e9e0b84c5...fc1fb4dd7c05
182020-05-29T00:43:35 <bitcoin-git> bitcoin/master 399d84d Wladimir J. van der Laan: build: Only allow ASCII identifiers
192020-05-29T00:43:36 <bitcoin-git> bitcoin/master fc1fb4d fanquake: Merge #19094: build: Only allow ASCII identifiers
202020-05-29T00:43:38 *** bitcoin-git has left #bitcoin-core-dev
212020-05-29T00:43:54 *** bitcoin-git has joined #bitcoin-core-dev
222020-05-29T00:43:54 <bitcoin-git> [bitcoin] fanquake merged pull request #19094: build: Only allow ASCII identifiers (master...2020_05_no_extended_identifiers) https://github.com/bitcoin/bitcoin/pull/19094
232020-05-29T00:43:55 *** bitcoin-git has left #bitcoin-core-dev
242020-05-29T00:51:53 *** jarthur has joined #bitcoin-core-dev
252020-05-29T00:54:14 *** troygiorshev has joined #bitcoin-core-dev
262020-05-29T00:54:47 *** EagleTM has quit IRC
272020-05-29T01:02:49 *** proofofkeags has joined #bitcoin-core-dev
282020-05-29T01:07:38 *** proofofkeags has quit IRC
292020-05-29T01:09:30 *** jarthur has quit IRC
302020-05-29T01:09:53 *** Chris_Stewart_5 has quit IRC
312020-05-29T01:10:14 *** jarthur has joined #bitcoin-core-dev
322020-05-29T01:14:55 *** filchef has joined #bitcoin-core-dev
332020-05-29T01:17:54 *** troygiorshev has quit IRC
342020-05-29T01:19:56 *** troygiorshev has joined #bitcoin-core-dev
352020-05-29T01:27:43 *** troygiorshev has quit IRC
362020-05-29T01:28:03 *** bitcoin-git has joined #bitcoin-core-dev
372020-05-29T01:28:04 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc1fb4dd7c05...adc143fc2b9a
382020-05-29T01:28:04 <bitcoin-git> bitcoin/master 79b0a69 Andrew Chow: Add missing QPainterPath include
392020-05-29T01:28:05 <bitcoin-git> bitcoin/master adc143f fanquake: Merge #19097: qt: Add missing QPainterPath include
402020-05-29T01:28:07 *** bitcoin-git has left #bitcoin-core-dev
412020-05-29T01:28:23 *** bitcoin-git has joined #bitcoin-core-dev
422020-05-29T01:28:23 <bitcoin-git> [bitcoin] fanquake merged pull request #19097: qt: Add missing QPainterPath include (master...qpainterpath-include) https://github.com/bitcoin/bitcoin/pull/19097
432020-05-29T01:28:24 *** bitcoin-git has left #bitcoin-core-dev
442020-05-29T01:29:05 <fanquake> jamesob: sounds good
452020-05-29T01:29:52 *** troygiorshev has joined #bitcoin-core-dev
462020-05-29T01:38:03 *** troygiorshev has quit IRC
472020-05-29T01:46:22 *** jarthur has quit IRC
482020-05-29T01:48:01 *** proofofkeags has joined #bitcoin-core-dev
492020-05-29T01:48:34 *** jarthur has joined #bitcoin-core-dev
502020-05-29T01:53:57 *** troygiorshev has joined #bitcoin-core-dev
512020-05-29T02:42:15 *** surja795 has quit IRC
522020-05-29T02:49:57 *** surja795 has joined #bitcoin-core-dev
532020-05-29T02:57:40 *** surja795 has quit IRC
542020-05-29T02:58:56 *** surja795 has joined #bitcoin-core-dev
552020-05-29T03:00:02 *** langseth1 has quit IRC
562020-05-29T03:02:23 *** kristapsk has quit IRC
572020-05-29T03:02:31 *** kristapsk_ has joined #bitcoin-core-dev
582020-05-29T03:10:50 <luke-jr> I wonder if #19097 warrants a rc3 :x
592020-05-29T03:10:52 <gribble> https://github.com/bitcoin/bitcoin/issues/19097 | qt: Add missing QPainterPath include by achow101 · Pull Request #19097 · bitcoin/bitcoin · GitHub
602020-05-29T03:11:46 <luke-jr> certainly could use a backport at least
612020-05-29T03:12:15 <fanquake> Given that 5.15 only came out 3 days ago, I don't think there's any need to delay 0.20.0
622020-05-29T03:12:19 <fanquake> Can backport into 0.20.1
632020-05-29T03:13:26 <luke-jr> lots of other sw needs fixing too, so at least we're not that unusual in this
642020-05-29T03:13:44 <luke-jr> (been idly noticing it dealt with as Gentoo rolls it out)
652020-05-29T03:21:43 *** hoobop1 has joined #bitcoin-core-dev
662020-05-29T03:31:07 *** surja795 has quit IRC
672020-05-29T03:36:12 *** surja795 has joined #bitcoin-core-dev
682020-05-29T03:41:01 *** surja795 has quit IRC
692020-05-29T03:51:53 *** proofofkeags has quit IRC
702020-05-29T03:52:26 *** proofofkeags has joined #bitcoin-core-dev
712020-05-29T03:55:56 *** Lessie75Barton has joined #bitcoin-core-dev
722020-05-29T03:56:34 *** proofofkeags has quit IRC
732020-05-29T04:01:01 *** Relis has quit IRC
742020-05-29T04:02:52 *** vasild has quit IRC
752020-05-29T04:03:05 *** vasild has joined #bitcoin-core-dev
762020-05-29T04:23:23 *** vasild has quit IRC
772020-05-29T04:29:58 *** Lessie75Barton has quit IRC
782020-05-29T04:30:12 *** vasild has joined #bitcoin-core-dev
792020-05-29T04:34:03 *** joerodgers has quit IRC
802020-05-29T04:43:32 *** luke-jr has quit IRC
812020-05-29T04:44:00 *** luke-jr has joined #bitcoin-core-dev
822020-05-29T04:48:13 *** mrostecki has quit IRC
832020-05-29T04:48:30 *** mrostecki has joined #bitcoin-core-dev
842020-05-29T04:54:40 *** mazout has joined #bitcoin-core-dev
852020-05-29T04:55:32 *** mazout has left #bitcoin-core-dev
862020-05-29T05:26:54 *** ineedhelp has joined #bitcoin-core-dev
872020-05-29T05:34:12 *** marcoagner has joined #bitcoin-core-dev
882020-05-29T05:59:20 *** Highway61 has joined #bitcoin-core-dev
892020-05-29T06:00:02 *** hoobop1 has quit IRC
902020-05-29T06:09:28 *** jarthur has quit IRC
912020-05-29T06:10:01 *** jarthur has joined #bitcoin-core-dev
922020-05-29T06:17:10 *** ineedhelp has quit IRC
932020-05-29T06:22:20 *** Antonet has joined #bitcoin-core-dev
942020-05-29T06:26:18 *** troygiorshev has quit IRC
952020-05-29T06:27:27 *** jarthur_ has joined #bitcoin-core-dev
962020-05-29T06:29:21 *** jarthur has quit IRC
972020-05-29T06:34:21 *** morcos has quit IRC
982020-05-29T06:35:10 *** morcos has joined #bitcoin-core-dev
992020-05-29T06:55:53 *** bitcoin-git has joined #bitcoin-core-dev
1002020-05-29T06:55:54 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/adc143fc2b9a...5f75c5e7df14
1012020-05-29T06:55:54 <bitcoin-git> bitcoin/master 73d8ef7 Hennadii Stepanov: qt: Add BitcoinUnits::formatWithPrivacy() function
1022020-05-29T06:55:55 <bitcoin-git> bitcoin/master 8d75115 Hennadii Stepanov: qt: Add privacy feature to Overview page
1032020-05-29T06:55:55 <bitcoin-git> bitcoin/master 5f75c5e Jonas Schnelli: Merge #16432: qt: Add privacy to the Overview page
1042020-05-29T06:55:57 *** bitcoin-git has left #bitcoin-core-dev
1052020-05-29T06:57:23 *** bitcoin-git has joined #bitcoin-core-dev
1062020-05-29T06:57:23 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16432: qt: Add privacy to the Overview page (master...20190721-privacy) https://github.com/bitcoin/bitcoin/pull/16432
1072020-05-29T06:57:24 *** bitcoin-git has left #bitcoin-core-dev
1082020-05-29T07:00:51 *** bitcoin-git has joined #bitcoin-core-dev
1092020-05-29T07:00:52 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12833: [qt] move QSettings to bitcoin_rw.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
1102020-05-29T07:00:53 *** bitcoin-git has left #bitcoin-core-dev
1112020-05-29T07:17:40 *** bitcoin-git has joined #bitcoin-core-dev
1122020-05-29T07:17:40 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
1132020-05-29T07:17:41 *** bitcoin-git has left #bitcoin-core-dev
1142020-05-29T07:22:37 <jonasschnelli> promag_: #15202 could use a rebase
1152020-05-29T07:22:39 <gribble> https://github.com/bitcoin/bitcoin/issues/15202 | gui: Add Close All Wallets action by promag · Pull Request #15202 · bitcoin/bitcoin · GitHub
1162020-05-29T07:24:02 *** bitcoin-git has joined #bitcoin-core-dev
1172020-05-29T07:24:03 <bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
1182020-05-29T07:24:03 *** bitcoin-git has left #bitcoin-core-dev
1192020-05-29T07:25:12 *** bitcoin-git has joined #bitcoin-core-dev
1202020-05-29T07:25:13 <bitcoin-git> [bitcoin] rajarshimaitra reopened pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
1212020-05-29T07:25:14 *** bitcoin-git has left #bitcoin-core-dev
1222020-05-29T07:29:25 <jonasschnelli> ryanofsky: I guess #15935 could be taken out of draft
1232020-05-29T07:29:27 <gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
1242020-05-29T07:30:56 *** lehnberg has joined #bitcoin-core-dev
1252020-05-29T07:32:51 *** Guyver2 has joined #bitcoin-core-dev
1262020-05-29T07:33:02 *** bitcoin-git has joined #bitcoin-core-dev
1272020-05-29T07:33:03 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #16876: gui: Drop calls to QCoreApplication::processEvents (master...2019-09-drop-processevents) https://github.com/bitcoin/bitcoin/pull/16876
1282020-05-29T07:33:04 *** bitcoin-git has left #bitcoin-core-dev
1292020-05-29T07:40:45 *** EagleTM has joined #bitcoin-core-dev
1302020-05-29T07:41:45 *** as_pnn has quit IRC
1312020-05-29T07:44:10 *** as_pnn has joined #bitcoin-core-dev
1322020-05-29T07:45:32 <jonasschnelli> MarcoFalke: can you ack/nack/comment on #17227 (contains [squashes]commits of yours)
1332020-05-29T07:45:35 <gribble> https://github.com/bitcoin/bitcoin/issues/17227 | Qt: Add Android packaging support by icota · Pull Request #17227 · bitcoin/bitcoin · GitHub
1342020-05-29T08:02:55 *** Highway61 has quit IRC
1352020-05-29T08:03:02 *** bitcoin-git has joined #bitcoin-core-dev
1362020-05-29T08:03:03 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f75c5e7df14...343169998193
1372020-05-29T08:03:03 <bitcoin-git> bitcoin/master 68288ef Hennadii Stepanov: qt: Overhaul ReceiveRequestDialog
1382020-05-29T08:03:04 <bitcoin-git> bitcoin/master 73529f0 Hennadii Stepanov: qt: Rename slot to updateDisplayUnit()
1392020-05-29T08:03:05 <bitcoin-git> bitcoin/master 3431699 Jonas Schnelli: Merge #17597: qt: Fix height of QR-less ReceiveRequestDialog
1402020-05-29T08:03:07 *** bitcoin-git has left #bitcoin-core-dev
1412020-05-29T08:03:11 *** Highway61 has joined #bitcoin-core-dev
1422020-05-29T08:04:07 *** bitcoin-git has joined #bitcoin-core-dev
1432020-05-29T08:04:07 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
1442020-05-29T08:04:08 *** bitcoin-git has left #bitcoin-core-dev
1452020-05-29T08:07:03 *** mrostecki has quit IRC
1462020-05-29T08:12:14 *** mrostecki has joined #bitcoin-core-dev
1472020-05-29T08:20:17 *** bitcoin-git has joined #bitcoin-core-dev
1482020-05-29T08:20:17 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/343169998193...c2c15ea54eb1
1492020-05-29T08:20:17 <bitcoin-git> bitcoin/master 1122817 Hennadii Stepanov: qt: Remove QFont warnings with QPA=minimal
1502020-05-29T08:20:18 <bitcoin-git> bitcoin/master c2c15ea Jonas Schnelli: Merge #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal
1512020-05-29T08:20:20 *** bitcoin-git has left #bitcoin-core-dev
1522020-05-29T08:21:14 *** kristapsk_ is now known as kristapsk
1532020-05-29T08:21:17 *** bitcoin-git has joined #bitcoin-core-dev
1542020-05-29T08:21:17 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
1552020-05-29T08:21:18 *** bitcoin-git has left #bitcoin-core-dev
1562020-05-29T08:23:32 *** bitcoin-git has joined #bitcoin-core-dev
1572020-05-29T08:23:33 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2c15ea54eb1...a9024a42fcec
1582020-05-29T08:23:33 <bitcoin-git> bitcoin/master c4ea501 Emil Engler: qt: Hide non PKHash-Addresses in signing address book
1592020-05-29T08:23:34 <bitcoin-git> bitcoin/master a9024a4 Jonas Schnelli: Merge #17918: qt: Hide non PKHash-Addresses in signing address book
1602020-05-29T08:23:35 *** bitcoin-git has left #bitcoin-core-dev
1612020-05-29T08:24:27 *** bitcoin-git has joined #bitcoin-core-dev
1622020-05-29T08:24:28 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17918: qt: Hide non PKHash-Addresses in signing address book (master...2020-01-hide-non-pkhash-addresses) https://github.com/bitcoin/bitcoin/pull/17918
1632020-05-29T08:24:28 *** bitcoin-git has left #bitcoin-core-dev
1642020-05-29T08:25:15 *** promag has joined #bitcoin-core-dev
1652020-05-29T08:29:43 *** bitcoin-git has joined #bitcoin-core-dev
1662020-05-29T08:29:44 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9024a42fcec...0d5c18204b73
1672020-05-29T08:29:44 <bitcoin-git> bitcoin/master 2b18fd2 Kristaps Kaupe: Disable unavailable context menu items in transactions tab
1682020-05-29T08:29:44 <bitcoin-git> bitcoin/master 0d5c182 Jonas Schnelli: Merge #17956: gui: Disable unavailable context menu items in transactions ...
1692020-05-29T08:29:46 *** bitcoin-git has left #bitcoin-core-dev
1702020-05-29T08:30:40 *** bitcoin-git has joined #bitcoin-core-dev
1712020-05-29T08:30:40 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17956: gui: Disable unavailable context menu items in transactions tab (master...tx-menu-disable) https://github.com/bitcoin/bitcoin/pull/17956
1722020-05-29T08:30:41 *** bitcoin-git has left #bitcoin-core-dev
1732020-05-29T08:30:59 *** bitcoin-git has joined #bitcoin-core-dev
1742020-05-29T08:30:59 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d5c18204b73...beb3844c45c5
1752020-05-29T08:30:59 <bitcoin-git> bitcoin/master 4fc1df4 Hennadii Stepanov: qt: Track QEvent::Resize during animation
1762020-05-29T08:31:00 <bitcoin-git> bitcoin/master beb3844 Jonas Schnelli: Merge #17968: qt: Ensure that ModalOverlay is resized properly
1772020-05-29T08:31:07 *** bitcoin-git has left #bitcoin-core-dev
1782020-05-29T08:31:54 *** bitcoin-git has joined #bitcoin-core-dev
1792020-05-29T08:31:54 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968
1802020-05-29T08:31:55 *** bitcoin-git has left #bitcoin-core-dev
1812020-05-29T08:32:33 *** jarthur_ has quit IRC
1822020-05-29T08:54:25 *** Relis has joined #bitcoin-core-dev
1832020-05-29T08:55:38 *** provoostenator_ has joined #bitcoin-core-dev
1842020-05-29T08:59:01 *** provoostenator has quit IRC
1852020-05-29T08:59:41 *** promag has quit IRC
1862020-05-29T09:00:02 *** Antonet has quit IRC
1872020-05-29T09:00:03 *** promag_ is now known as promag
1882020-05-29T09:00:16 <promag> jonasschnelli: +1
1892020-05-29T09:00:28 <jonasschnelli> spring cleaning...
1902020-05-29T09:00:29 *** Relis has quit IRC
1912020-05-29T09:00:30 *** promag_ has joined #bitcoin-core-dev
1922020-05-29T09:00:50 <promag> jonasschnelli: \o/
1932020-05-29T09:01:21 <promag> #17355 needs rebase
1942020-05-29T09:01:23 <gribble> https://github.com/bitcoin/bitcoin/issues/17355 | gui: grey out used address in address book by za-kk · Pull Request #17355 · bitcoin/bitcoin · GitHub
1952020-05-29T09:01:36 *** bitcoin-git has joined #bitcoin-core-dev
1962020-05-29T09:01:37 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/beb3844c45c5...f4b603cff63a
1972020-05-29T09:01:37 <bitcoin-git> bitcoin/master 2f86720 furszy: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
1982020-05-29T09:01:38 <bitcoin-git> bitcoin/master a06e845 furszy: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTi...
1992020-05-29T09:01:39 <bitcoin-git> bitcoin/master f4b603c Jonas Schnelli: Merge #17993: gui: Balance/TxStatus polling update based on last block has...
2002020-05-29T09:01:40 *** bitcoin-git has left #bitcoin-core-dev
2012020-05-29T09:02:31 *** bitcoin-git has joined #bitcoin-core-dev
2022020-05-29T09:02:31 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17993: gui: Balance/TxStatus polling update based on last block hash. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
2032020-05-29T09:02:35 *** bitcoin-git has left #bitcoin-core-dev
2042020-05-29T09:06:31 *** bitcoin-git has joined #bitcoin-core-dev
2052020-05-29T09:06:32 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b603cff63a...de369c7ea577
2062020-05-29T09:06:33 <bitcoin-git> bitcoin/master cea91a1 Luke Dashjr: Bugfix: GUI: Use unsigned long long type to avoid implicit conversion of M...
2072020-05-29T09:06:33 <bitcoin-git> bitcoin/master c31bc5b Luke Dashjr: Consolidate service flag bit-to-name conversion to a shared serviceFlagToS...
2082020-05-29T09:06:34 <bitcoin-git> bitcoin/master de369c7 Jonas Schnelli: Merge #18165: Consolidate service flag bit-to-name conversion to a shared ...
2092020-05-29T09:06:34 *** bitcoin-git has left #bitcoin-core-dev
2102020-05-29T09:07:22 *** bitcoin-git has joined #bitcoin-core-dev
2112020-05-29T09:07:22 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
2122020-05-29T09:07:30 *** bitcoin-git has left #bitcoin-core-dev
2132020-05-29T09:08:59 *** bitcoin-git has joined #bitcoin-core-dev
2142020-05-29T09:09:00 <bitcoin-git> [bitcoin] promag opened pull request #19104: gui, test: Fix Cannot queue arguments of type size_t (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
2152020-05-29T09:09:01 *** bitcoin-git has left #bitcoin-core-dev
2162020-05-29T09:09:33 *** bitcoin-git has joined #bitcoin-core-dev
2172020-05-29T09:09:34 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de369c7ea577...d7f5e01e3093
2182020-05-29T09:09:34 <bitcoin-git> bitcoin/master 8e08d00 Hennadii Stepanov: qt: Use parent-child relation to manage lifetime of OptionsModel object
2192020-05-29T09:09:35 <bitcoin-git> bitcoin/master d7f5e01 Jonas Schnelli: Merge #18424: qt: Use parent-child relation to manage lifetime of OptionsM...
2202020-05-29T09:09:36 *** bitcoin-git has left #bitcoin-core-dev
2212020-05-29T09:10:13 *** bitcoin-git has joined #bitcoin-core-dev
2222020-05-29T09:10:14 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18424: qt: Use parent-child relation to manage lifetime of OptionsModel object (master...20200324-options-model) https://github.com/bitcoin/bitcoin/pull/18424
2232020-05-29T09:10:15 *** bitcoin-git has left #bitcoin-core-dev
2242020-05-29T09:14:10 *** |Kin| has joined #bitcoin-core-dev
2252020-05-29T09:14:56 <hebasto> jonasschnelli: mind looking into ##17127 which is alternative to #13389 ?
2262020-05-29T09:14:58 <gribble> https://github.com/bitcoin/bitcoin/issues/17127 | util: Correct permissions for datadir and wallets subdir by hebasto · Pull Request #17127 · bitcoin/bitcoin · GitHub
2272020-05-29T09:15:01 <gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub
2282020-05-29T09:17:19 <jonasschnelli> hebasto: thanks for pointing that to me. Since this is not GUI only,... it needs more review before we can merge this.
2292020-05-29T09:17:48 <hebasto> jonasschnelli: sure
2302020-05-29T09:18:16 <jonasschnelli> hebasto, promag: maybe interested to fix #19103?
2312020-05-29T09:18:17 <gribble> https://github.com/bitcoin/bitcoin/issues/19103 | QRCode address in image is not readable · Issue #19103 · bitcoin/bitcoin · GitHub
2322020-05-29T09:18:21 <jonasschnelli> Make sure it respects HiDPI
2332020-05-29T09:18:49 <promag> I was going to see if changing font fixes it
2342020-05-29T09:19:11 *** Relis has joined #bitcoin-core-dev
2352020-05-29T09:19:36 <hebasto> jonasschnelli: not sure if I could test on my equipment
2362020-05-29T09:21:46 *** belcher has quit IRC
2372020-05-29T09:31:01 *** provoostenator_ has quit IRC
2382020-05-29T09:31:10 <jonasschnelli> hebasto: good point. I wonder if the issue is also present on HiDPI ubuntu
2392020-05-29T09:32:41 *** provoostenator has joined #bitcoin-core-dev
2402020-05-29T09:36:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2412020-05-29T09:43:52 *** Relis has quit IRC
2422020-05-29T09:44:17 <promag> jonasschnelli: I can test that
2432020-05-29T09:45:31 <promag> I'm getting
2442020-05-29T09:45:31 <promag> CoreText note: Client requested name ".SFNSMono-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
2452020-05-29T09:51:13 *** AaronvanW has joined #bitcoin-core-dev
2462020-05-29T10:03:20 *** Jany7Nader has joined #bitcoin-core-dev
2472020-05-29T10:10:20 *** Jany7Nader has quit IRC
2482020-05-29T10:15:38 *** surja795 has joined #bitcoin-core-dev
2492020-05-29T10:16:47 *** shaunsun_ has joined #bitcoin-core-dev
2502020-05-29T10:16:49 *** belcher has joined #bitcoin-core-dev
2512020-05-29T10:18:01 *** Relis has joined #bitcoin-core-dev
2522020-05-29T10:18:42 *** shaunsun__ has joined #bitcoin-core-dev
2532020-05-29T10:19:26 *** thunderbiscuit[m has left #bitcoin-core-dev
2542020-05-29T10:21:15 *** shaunsun_ has quit IRC
2552020-05-29T10:24:45 *** bitcoin-git has joined #bitcoin-core-dev
2562020-05-29T10:24:46 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f5e01e3093...73407ff65cef
2572020-05-29T10:24:47 <bitcoin-git> bitcoin/master fa5894f Anthony Towns: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known
2582020-05-29T10:24:48 <bitcoin-git> bitcoin/master 96954d1 Anthony Towns: DNS seeds: don't query DNS while network is inactive
2592020-05-29T10:24:49 <bitcoin-git> bitcoin/master 73407ff fanquake: Merge #16939: p2p: Delay querying DNS seeds
2602020-05-29T10:24:57 *** bitcoin-git has left #bitcoin-core-dev
2612020-05-29T10:26:00 *** bitcoin-git has joined #bitcoin-core-dev
2622020-05-29T10:26:01 <bitcoin-git> [bitcoin] fanquake merged pull request #16939: p2p: Delay querying DNS seeds (master...201909-avoid-dns-if-addrman-populated) https://github.com/bitcoin/bitcoin/pull/16939
2632020-05-29T10:26:02 *** bitcoin-git has left #bitcoin-core-dev
2642020-05-29T10:31:34 *** IGHOR has quit IRC
2652020-05-29T10:33:06 *** jarthur has joined #bitcoin-core-dev
2662020-05-29T10:34:03 *** IGHOR has joined #bitcoin-core-dev
2672020-05-29T10:35:56 *** timothy has joined #bitcoin-core-dev
2682020-05-29T10:36:03 *** timothy has joined #bitcoin-core-dev
2692020-05-29T10:36:50 *** timothy has quit IRC
2702020-05-29T10:37:53 *** jarthur has quit IRC
2712020-05-29T10:38:43 *** kristapsk has quit IRC
2722020-05-29T10:53:38 *** shaunsun__ has quit IRC
2732020-05-29T11:08:23 *** Pavlenex has joined #bitcoin-core-dev
2742020-05-29T11:23:49 *** timothy has joined #bitcoin-core-dev
2752020-05-29T11:31:15 *** cltrbreak_MAD2 has quit IRC
2762020-05-29T11:31:42 *** cltrbreak_MAD2 has joined #bitcoin-core-dev
2772020-05-29T11:34:05 *** bitdex has quit IRC
2782020-05-29T11:34:50 *** bitdex has joined #bitcoin-core-dev
2792020-05-29T11:41:50 *** Pavlenex has quit IRC
2802020-05-29T11:58:15 *** bitcoin-git has joined #bitcoin-core-dev
2812020-05-29T11:58:16 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
2822020-05-29T11:58:17 *** bitcoin-git has left #bitcoin-core-dev
2832020-05-29T11:58:35 *** bitcoin-git has joined #bitcoin-core-dev
2842020-05-29T11:58:36 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
2852020-05-29T11:58:36 *** bitcoin-git has left #bitcoin-core-dev
2862020-05-29T12:00:02 *** |Kin| has quit IRC
2872020-05-29T12:06:44 *** bitcoin-git has joined #bitcoin-core-dev
2882020-05-29T12:06:44 <bitcoin-git> [bitcoin] fjahr opened pull request #19105: Add Muhash3072 implementation in Python (master...csi-2-muhash-py) https://github.com/bitcoin/bitcoin/pull/19105
2892020-05-29T12:06:45 *** bitcoin-git has left #bitcoin-core-dev
2902020-05-29T12:15:01 *** troygiorshev has joined #bitcoin-core-dev
2912020-05-29T12:18:28 *** boily has joined #bitcoin-core-dev
2922020-05-29T12:35:16 *** provoostenator has quit IRC
2932020-05-29T12:36:39 *** provoostenator has joined #bitcoin-core-dev
2942020-05-29T12:42:41 *** bitcoin-git has joined #bitcoin-core-dev
2952020-05-29T12:42:41 <bitcoin-git> [bitcoin] jonasschnelli reopened pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
2962020-05-29T12:42:43 *** bitcoin-git has left #bitcoin-core-dev
2972020-05-29T12:43:26 *** bitcoin-git has joined #bitcoin-core-dev
2982020-05-29T12:43:26 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/73407ff65cef...f2e2c5ebcccf
2992020-05-29T12:43:26 <bitcoin-git> bitcoin/master 9760293 Ben Carman: wallet: Fix for exported confirmation field in payment to self transactions
3002020-05-29T12:43:26 <bitcoin-git> bitcoin/master f2e2c5e Jonas Schnelli: Merge #14988: wallet: Fix for confirmed column in csv export for payment t...
3012020-05-29T12:43:28 *** bitcoin-git has left #bitcoin-core-dev
3022020-05-29T12:45:00 *** bitcoin-git has joined #bitcoin-core-dev
3032020-05-29T12:45:00 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
3042020-05-29T12:45:02 *** bitcoin-git has left #bitcoin-core-dev
3052020-05-29T12:46:39 *** provoostenator has quit IRC
3062020-05-29T13:30:13 *** Highway61 has quit IRC
3072020-05-29T13:37:18 *** joerodgers has joined #bitcoin-core-dev
3082020-05-29T13:42:41 *** igr has joined #bitcoin-core-dev
3092020-05-29T13:48:48 *** mdunnio has joined #bitcoin-core-dev
3102020-05-29T13:50:19 *** bitcoin-git has joined #bitcoin-core-dev
3112020-05-29T13:50:19 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2e2c5ebcccf...e4bfd51acc11
3122020-05-29T13:50:19 <bitcoin-git> bitcoin/master da73f15 Hennadii Stepanov: qt: Fix shutdown when waitfor* cmds are called from RPC console
3132020-05-29T13:50:20 <bitcoin-git> bitcoin/master e4bfd51 Jonas Schnelli: Merge #18452: qt: Fix shutdown when waitfor* cmds are called from RPC cons...
3142020-05-29T13:50:28 *** bitcoin-git has left #bitcoin-core-dev
3152020-05-29T13:50:53 *** d_t has joined #bitcoin-core-dev
3162020-05-29T13:50:59 *** bitcoin-git has joined #bitcoin-core-dev
3172020-05-29T13:50:59 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18452: qt: Fix shutdown when waitfor* cmds are called from RPC console (master...20200327-waitfor) https://github.com/bitcoin/bitcoin/pull/18452
3182020-05-29T13:51:08 *** bitcoin-git has left #bitcoin-core-dev
3192020-05-29T13:52:41 *** waxwing_ has left #bitcoin-core-dev
3202020-05-29T13:53:27 *** waxwing has joined #bitcoin-core-dev
3212020-05-29T13:57:31 *** bitcoin-git has joined #bitcoin-core-dev
3222020-05-29T13:57:31 <bitcoin-git> [bitcoin] vasild opened pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
3232020-05-29T13:57:32 *** bitcoin-git has left #bitcoin-core-dev
3242020-05-29T14:00:53 *** timothy has quit IRC
3252020-05-29T14:01:28 *** timothy has joined #bitcoin-core-dev
3262020-05-29T14:04:56 <instagibbs> oh hey I can restart travis jobs again
3272020-05-29T14:12:10 *** igr has quit IRC
3282020-05-29T14:27:07 *** proofofkeags has joined #bitcoin-core-dev
3292020-05-29T14:27:34 *** Highway61 has joined #bitcoin-core-dev
3302020-05-29T14:30:25 *** d_t has quit IRC
3312020-05-29T14:30:39 *** kexkey has joined #bitcoin-core-dev
3322020-05-29T14:33:34 *** jarthur has joined #bitcoin-core-dev
3332020-05-29T14:37:57 *** jarthur has quit IRC
3342020-05-29T14:39:19 *** proofofkeags has quit IRC
3352020-05-29T14:39:54 *** proofofkeags has joined #bitcoin-core-dev
3362020-05-29T14:44:13 *** proofofkeags has quit IRC
3372020-05-29T14:55:05 *** Landryl has quit IRC
3382020-05-29T15:00:02 *** boily has quit IRC
3392020-05-29T15:02:29 *** kljasdfvv has quit IRC
3402020-05-29T15:12:06 *** kristapsk has joined #bitcoin-core-dev
3412020-05-29T15:16:20 *** maop has joined #bitcoin-core-dev
3422020-05-29T15:18:29 *** timothy has quit IRC
3432020-05-29T15:18:54 *** timothy has joined #bitcoin-core-dev
3442020-05-29T15:21:04 *** provoostenator has joined #bitcoin-core-dev
3452020-05-29T15:21:30 *** provoostenator has quit IRC
3462020-05-29T15:25:19 *** Pavlenex has joined #bitcoin-core-dev
3472020-05-29T15:29:13 *** bitcoin-git has joined #bitcoin-core-dev
3482020-05-29T15:29:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4bfd51acc11...c19fd96694d1
3492020-05-29T15:29:15 <bitcoin-git> bitcoin/master fa2ca0c MarcoFalke: test: Fix intermittent failure in feature_dbcrash
3502020-05-29T15:29:15 <bitcoin-git> bitcoin/master c19fd96 MarcoFalke: Merge #19022: test: Fix intermittent failure in feature_dbcrash
3512020-05-29T15:29:22 *** bitcoin-git has left #bitcoin-core-dev
3522020-05-29T15:29:38 *** bitcoin-git has joined #bitcoin-core-dev
3532020-05-29T15:29:39 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
3542020-05-29T15:29:40 *** bitcoin-git has left #bitcoin-core-dev
3552020-05-29T15:32:17 *** provoostenator has joined #bitcoin-core-dev
3562020-05-29T15:36:45 *** owowo has quit IRC
3572020-05-29T15:41:43 *** owowo has joined #bitcoin-core-dev
3582020-05-29T15:41:43 *** owowo has joined #bitcoin-core-dev
3592020-05-29T15:46:52 *** provoostenator has quit IRC
3602020-05-29T15:54:07 *** bitcoin-git has joined #bitcoin-core-dev
3612020-05-29T15:54:07 <bitcoin-git> [bitcoin] troygiorshev opened pull request #19107: p2p: Refactor, move all header verification into the network layer, without changing behavior (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
3622020-05-29T15:54:08 *** bitcoin-git has left #bitcoin-core-dev
3632020-05-29T15:56:01 *** Highway61 has quit IRC
3642020-05-29T15:58:32 *** Highway61 has joined #bitcoin-core-dev
3652020-05-29T16:05:04 *** MarcoFalke has quit IRC
3662020-05-29T16:08:47 *** provoostenator has joined #bitcoin-core-dev
3672020-05-29T16:09:52 *** Talkless has joined #bitcoin-core-dev
3682020-05-29T16:15:01 *** Guest7387 has joined #bitcoin-core-dev
3692020-05-29T16:16:04 *** Pavlenex has quit IRC
3702020-05-29T16:20:24 *** vasild_ has joined #bitcoin-core-dev
3712020-05-29T16:24:03 *** vasild has quit IRC
3722020-05-29T16:24:04 *** vasild_ is now known as vasild
3732020-05-29T16:24:21 *** justanotheruser has quit IRC
3742020-05-29T16:28:06 *** proofofkeags has joined #bitcoin-core-dev
3752020-05-29T16:40:11 *** Victorsueca has joined #bitcoin-core-dev
3762020-05-29T16:41:04 *** justanotheruser has joined #bitcoin-core-dev
3772020-05-29T16:44:10 *** Elsie85Block has joined #bitcoin-core-dev
3782020-05-29T16:48:59 *** Elsie85Block has quit IRC
3792020-05-29T16:52:45 *** kristapsk_ has joined #bitcoin-core-dev
3802020-05-29T16:54:12 *** drizztbsd has joined #bitcoin-core-dev
3812020-05-29T16:54:44 *** bitdex has quit IRC
3822020-05-29T16:54:44 *** mrostecki has quit IRC
3832020-05-29T16:55:03 *** vasild has quit IRC
3842020-05-29T16:55:04 *** timothy has quit IRC
3852020-05-29T16:56:00 *** bitdex has joined #bitcoin-core-dev
3862020-05-29T16:59:03 *** kristapsk has quit IRC
3872020-05-29T17:04:53 *** bitdex has quit IRC
3882020-05-29T17:05:18 *** bitdex has joined #bitcoin-core-dev
3892020-05-29T17:05:41 *** mrostecki has joined #bitcoin-core-dev
3902020-05-29T17:05:45 *** vasild has joined #bitcoin-core-dev
3912020-05-29T17:09:07 *** drizztbsd is now known as timothy
3922020-05-29T17:12:57 *** troygiorshev has quit IRC
3932020-05-29T17:21:06 *** troygiorshev has joined #bitcoin-core-dev
3942020-05-29T17:22:02 *** mol_ has joined #bitcoin-core-dev
3952020-05-29T17:24:04 *** mol has quit IRC
3962020-05-29T17:32:27 *** Zenton has joined #bitcoin-core-dev
3972020-05-29T17:32:33 *** bitcoin-git has joined #bitcoin-core-dev
3982020-05-29T17:32:34 <bitcoin-git> [bitcoin] hebasto opened pull request #19108: qt, refactor: Drop unneeded Q_DECLARE_METATYPE (master...200529-metatype) https://github.com/bitcoin/bitcoin/pull/19108
3992020-05-29T17:32:35 *** bitcoin-git has left #bitcoin-core-dev
4002020-05-29T17:36:07 *** jarthur has joined #bitcoin-core-dev
4012020-05-29T17:39:33 *** Pavlenex has joined #bitcoin-core-dev
4022020-05-29T17:43:39 *** bitcoin-git has joined #bitcoin-core-dev
4032020-05-29T17:43:41 <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c19fd96694d1...8ad5f1c376fe
4042020-05-29T17:43:42 <bitcoin-git> bitcoin/master fbacad1 Vasil Dimov: util: simplify the interface of serviceFlagToStr()
4052020-05-29T17:43:42 <bitcoin-git> bitcoin/master 189ae0c Vasil Dimov: util: dedup code in callers of serviceFlagToStr()
4062020-05-29T17:43:43 <bitcoin-git> bitcoin/master 8ad5f1c Jonas Schnelli: Merge #19106: util: simplify the interface of serviceFlagToStr()
4072020-05-29T17:43:45 *** bitcoin-git has left #bitcoin-core-dev
4082020-05-29T17:43:59 *** bitcoin-git has joined #bitcoin-core-dev
4092020-05-29T17:44:00 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
4102020-05-29T17:44:11 *** bitcoin-git has left #bitcoin-core-dev
4112020-05-29T17:53:50 *** troygiorshev has quit IRC
4122020-05-29T17:54:30 *** troygiorshev has joined #bitcoin-core-dev
4132020-05-29T18:00:09 *** maop has quit IRC
4142020-05-29T18:01:37 *** mdunnio has quit IRC
4152020-05-29T18:18:01 *** Windurr has joined #bitcoin-core-dev
4162020-05-29T18:18:31 *** troygiorshev has quit IRC
4172020-05-29T18:24:56 *** ryzeb has quit IRC
4182020-05-29T18:25:16 *** bitcoin-git has joined #bitcoin-core-dev
4192020-05-29T18:25:18 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8ad5f1c376fe...cb88de3e3d37
4202020-05-29T18:25:19 <bitcoin-git> bitcoin/master 357f02b glowang: Create a local class inherited from BasicTestingSetup with a localized arg...
4212020-05-29T18:25:19 <bitcoin-git> bitcoin/master f871f15 glowang: scripted-diff: replace gArgs with argsman
4222020-05-29T18:25:20 <bitcoin-git> bitcoin/master cb88de3 MarcoFalke: Merge #18926: test: Pass ArgsManager into getarg_tests
4232020-05-29T18:25:22 *** bitcoin-git has left #bitcoin-core-dev
4242020-05-29T18:25:42 *** bitcoin-git has joined #bitcoin-core-dev
4252020-05-29T18:25:42 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18926: test: Pass ArgsManager into getarg_tests (master...replace_global_gArgs_with_local_argsman) https://github.com/bitcoin/bitcoin/pull/18926
4262020-05-29T18:25:43 *** bitcoin-git has left #bitcoin-core-dev
4272020-05-29T18:27:04 *** lehnberg has quit IRC
4282020-05-29T18:32:06 *** mdunnio has joined #bitcoin-core-dev
4292020-05-29T18:33:58 *** kristapsk_ is now known as kristapsk
4302020-05-29T18:34:00 *** lehnberg has joined #bitcoin-core-dev
4312020-05-29T18:35:42 *** justanotheruser has quit IRC
4322020-05-29T18:38:20 *** troygiorshev has joined #bitcoin-core-dev
4332020-05-29T18:38:48 *** lehnberg has quit IRC
4342020-05-29T18:39:21 *** lehnberg has joined #bitcoin-core-dev
4352020-05-29T18:42:22 *** justanotheruser has joined #bitcoin-core-dev
4362020-05-29T18:42:55 *** MarcoFalke has joined #bitcoin-core-dev
4372020-05-29T18:52:30 *** lehnberg has quit IRC
4382020-05-29T18:54:36 *** Pavlenex has quit IRC
4392020-05-29T18:55:09 *** lehnberg has joined #bitcoin-core-dev
4402020-05-29T18:55:32 *** kristapsk has quit IRC
4412020-05-29T18:55:47 *** kristapsk has joined #bitcoin-core-dev
4422020-05-29T19:01:22 *** bitcoin-git has joined #bitcoin-core-dev
4432020-05-29T19:01:22 <bitcoin-git> [bitcoin] sipa opened pull request #19109: Only allow getdata of recently announced invs (master...202005_bloom_relay) https://github.com/bitcoin/bitcoin/pull/19109
4442020-05-29T19:01:23 *** bitcoin-git has left #bitcoin-core-dev
4452020-05-29T19:04:48 *** tylerdmace has quit IRC
4462020-05-29T19:05:48 *** lehnberg has quit IRC
4472020-05-29T19:06:44 *** cltrbreak_MAD2 has quit IRC
4482020-05-29T19:07:09 *** cltrbreak_MAD2 has joined #bitcoin-core-dev
4492020-05-29T19:07:23 <vasild> Assertion failed: detected inconsistent lock order at /home/vd/gh/bitcoin/bitcoin/src/sync.cpp:128, details in debug log.
4502020-05-29T19:07:26 <vasild> Abort trap (core dumped)
4512020-05-29T19:07:28 <vasild> hmm
4522020-05-29T19:07:32 *** troygiorshev has quit IRC
4532020-05-29T19:07:46 *** lehnberg has joined #bitcoin-core-dev
4542020-05-29T19:09:37 *** troygiorshev has joined #bitcoin-core-dev
4552020-05-29T19:10:25 *** timothy has quit IRC
4562020-05-29T19:11:02 *** troygiorshev has joined #bitcoin-core-dev
4572020-05-29T19:11:06 *** tylerdmace has joined #bitcoin-core-dev
4582020-05-29T19:15:24 *** lehnberg has quit IRC
4592020-05-29T19:15:49 *** kristapsk_ has joined #bitcoin-core-dev
4602020-05-29T19:15:55 *** kristapsk has quit IRC
4612020-05-29T19:16:15 *** bitdex has quit IRC
4622020-05-29T19:18:16 *** lehnberg has joined #bitcoin-core-dev
4632020-05-29T19:19:37 *** kristapsk_ is now known as kristapsk
4642020-05-29T19:25:10 <dongcarl> Hey jonasschnelli, I wanted to confirm my overall understanding of the topology of the open PRs related to BIP324. Here?s my understanding:
4652020-05-29T19:25:10 <dongcarl> - #14032 is an old PR that has many of its changes already merged, is superseded by jonasschnelli:2019/08/net_v2, and could potentially be closed. Question here: is there anything there that isn?t in jonasschnelli:2019/08/net_v2?
4662020-05-29T19:25:10 <dongcarl> - #18242 -> #14032 seems to be the main line of progression
4672020-05-29T19:25:10 <dongcarl> - #15197 + #15206 seem to be additional improvements that 1. Can be merged independently of the main line of progression, 2. Can help/simplify the implementation of BIP324. Question here: Could you give concrete examples as to how they help/simplify the implementation?
4682020-05-29T19:25:13 <gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
4692020-05-29T19:25:16 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
4702020-05-29T19:25:16 <gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
4712020-05-29T19:25:18 <gribble> https://github.com/bitcoin/bitcoin/issues/15197 | Refactor and slightly stricter p2p message processing by jonasschnelli · Pull Request #15197 · bitcoin/bitcoin · GitHub
4722020-05-29T19:25:21 <gribble> https://github.com/bitcoin/bitcoin/issues/15206 | Immediately disconnect on invalid net message checksum by jonasschnelli · Pull Request #15206 · bitcoin/bitcoin · GitHub
4732020-05-29T19:26:41 <dongcarl> Sorry, some of my apostrophes got converted to question marks. *shakes fist at Synergy*
4742020-05-29T19:33:54 *** bitcoin-git has joined #bitcoin-core-dev
4752020-05-29T19:33:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19110: test: Explain that a bug should be filed when the tests fail (master...2005-testBug) https://github.com/bitcoin/bitcoin/pull/19110
4762020-05-29T19:33:55 *** bitcoin-git has left #bitcoin-core-dev
4772020-05-29T19:37:06 *** Guest7387 has quit IRC
4782020-05-29T19:45:50 <jonasschnelli> dongcarl: 14032 was an overview/concept. The only relevant PR now is 18242
4792020-05-29T19:46:06 <jonasschnelli> 15206/15197 are now BIP324 irrelevant
4802020-05-29T19:47:02 <jonasschnelli> So as for BIP342, just focus on #18242
4812020-05-29T19:47:05 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
4822020-05-29T19:47:29 <jonasschnelli> The rest are just relicts that might be a refactor/improvement on its own.
4832020-05-29T19:48:06 *** lehnberg has quit IRC
4842020-05-29T19:48:49 <jonasschnelli> Once 18242 is merged,... I would like to "complete" it with the ECDH handshake (another mid size PR).
4852020-05-29T19:50:02 <jonasschnelli> After that,... i could be enabled behind an experimental off-by-default runtime argument
4862020-05-29T19:51:38 <dongcarl> jonasschnelli: I see, so after #18242, we need #14049, and then BIP324 handshake + BIP324 ECDH calc + BIP324 HKDF key deriv (last few commits from 2019/08/net_v2)?
4872020-05-29T19:51:41 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
4882020-05-29T19:51:43 <gribble> https://github.com/bitcoin/bitcoin/issues/14049 | Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli · Pull Request #14049 · bitcoin/bitcoin · GitHub
4892020-05-29T19:52:56 <jonasschnelli> Yeah. It needs 14049 with some actual handshake implementation. My remote branch you may look at could be outdated and if recent, it may only be the concept.
4902020-05-29T19:53:29 <dongcarl> Sounds good, I think we're on the same page
4912020-05-29T19:53:35 <jonasschnelli> HKDF is already implemented,... but not the actually symmetric key derivation from the ecdh_secret
4922020-05-29T19:53:39 <jonasschnelli> But...
4932020-05-29T19:53:44 <jonasschnelli> (there is always a but)
4942020-05-29T19:53:49 <dongcarl> haha
4952020-05-29T19:54:06 <jonasschnelli> BIP342 is still in discussion.
4962020-05-29T19:54:19 <jonasschnelli> Questions came up about the missing MAC of the encrypted length field
4972020-05-29T19:54:38 <jonasschnelli> https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52#gistcomment-3295536
4982020-05-29T19:54:58 <jonasschnelli> (sipa eventually likes to take a deeper look)
4992020-05-29T19:55:16 <jonasschnelli> I think it is fine since we use a different encryption context for it.
5002020-05-29T19:55:50 <jonasschnelli> then... secondly, there are discussions about possible handshake upgrades with downgrade protection (which are currently not directly supported by the bip).
5012020-05-29T19:56:06 <jonasschnelli> Thats the main reason why the BIP is still not submitted
5022020-05-29T19:56:25 <jonasschnelli> (as well as the fact that the implementation often reveals conceptual issues)
5032020-05-29T19:57:31 <jonasschnelli> despite the â eventually â altering BIP324, I think we can finalise the implementation and hide it behind an experimental runtime parameter.
5042020-05-29T19:58:20 <jonasschnelli> (which will still allow changing it without users getting mad)
5052020-05-29T19:58:57 <dongcarl> I see I see, I didn't see that discussion in the gist before, will take a closer look there.
5062020-05-29T19:59:53 <dongcarl> any links to the discussions about downgrade protection?
5072020-05-29T20:00:17 <jonasschnelli> I guess it is email only,... mainly real_or_random and sipa
5082020-05-29T20:00:27 <sipa> i need to respond :)
5092020-05-29T20:00:31 <jonasschnelli> We hoped for a coredev meeting to tackle it.
5102020-05-29T20:00:36 <jonasschnelli> sipa: no hurry.
5112020-05-29T20:00:44 <sipa> we've been talking to boneh about our authentication scheme as well
5122020-05-29T20:00:53 <sipa> (a week or two ago)
5132020-05-29T20:01:04 <jonasschnelli> the blind auth scheme?
5142020-05-29T20:01:10 <sipa> yeah
5152020-05-29T20:01:22 <jonasschnelli> okay... thats next step of next step. :)
5162020-05-29T20:01:51 <jonasschnelli> sipa: do you think it could have implications for v2/BIP342?
5172020-05-29T20:02:07 <jonasschnelli> or would it be more "on the top"?
5182020-05-29T20:02:15 <sipa> it's why we think we need an upgrade mechanism in BIP342
5192020-05-29T20:02:43 <sipa> so that the authentication can be done as part of the handshake, rather than as a application level thing later on
5202020-05-29T20:02:55 <jonasschnelli> ah.. i see
5212020-05-29T20:03:23 <sipa> but i think the upgrade mechanism can be very simple; just the connecting party sending a "i'm done; here is my hash of the session key"
5222020-05-29T20:03:25 <jonasschnelli> Yeah. Would be great to have a place/time to discuss the upgrade mechanism
5232020-05-29T20:03:37 <sipa> and the other side responding "ok, here is my hash"
5242020-05-29T20:04:12 <dongcarl> is the blind auth scheme you guys are talking about just the new version of the single-party countersign?
5252020-05-29T20:04:13 <sipa> anything else would be left unspecified, and close the connection
5262020-05-29T20:04:16 <sipa> dongcarl: yes
5272020-05-29T20:06:41 <jonasschnelli> I'll take it up soon (the upgrade mechanism) and will bother sipa and real_or_random with a concrete BIP change
5282020-05-29T20:08:14 <dongcarl> ð
5292020-05-29T20:16:54 *** shesek has joined #bitcoin-core-dev
5302020-05-29T20:16:54 *** shesek has joined #bitcoin-core-dev
5312020-05-29T20:17:47 *** Guyver2 has quit IRC
5322020-05-29T20:20:48 *** Chris_Stewart_5 has quit IRC
5332020-05-29T20:21:19 *** shesek has quit IRC
5342020-05-29T20:25:46 *** Talkless has quit IRC
5352020-05-29T20:33:03 *** harrigan has quit IRC
5362020-05-29T20:34:03 *** proofofkeags has quit IRC
5372020-05-29T20:34:05 *** harrigan has joined #bitcoin-core-dev
5382020-05-29T20:34:29 *** proofofkeags has joined #bitcoin-core-dev
5392020-05-29T20:35:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5402020-05-29T20:38:34 *** proofofkeags has quit IRC
5412020-05-29T20:47:28 *** proofofkeags has joined #bitcoin-core-dev
5422020-05-29T21:00:01 *** Windurr has quit IRC
5432020-05-29T21:17:25 *** ghghjghjghjghjgh has joined #bitcoin-core-dev
5442020-05-29T21:26:50 *** bitcoin-git has joined #bitcoin-core-dev
5452020-05-29T21:26:51 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19111: Limit scope of all global std::once_flag (master...2005-NoGlobalOnce) https://github.com/bitcoin/bitcoin/pull/19111
5462020-05-29T21:26:51 *** bitcoin-git has left #bitcoin-core-dev
5472020-05-29T21:32:22 *** proofofkeags has quit IRC
5482020-05-29T21:32:49 *** proofofkeags has joined #bitcoin-core-dev
5492020-05-29T21:37:08 *** proofofkeags has quit IRC
5502020-05-29T21:45:53 *** marcoagner has quit IRC
5512020-05-29T21:49:06 *** PeErLesS has joined #bitcoin-core-dev
5522020-05-29T21:50:49 *** ghghjghjghjghjgh has quit IRC
5532020-05-29T22:06:23 *** bitcoin-git has joined #bitcoin-core-dev
5542020-05-29T22:06:24 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19112: rpc: Remove special case for unknown service flags (master...2005-rpcServiceFlagsUnknown) https://github.com/bitcoin/bitcoin/pull/19112
5552020-05-29T22:06:24 *** bitcoin-git has left #bitcoin-core-dev
5562020-05-29T22:12:51 *** proofofkeags has joined #bitcoin-core-dev
5572020-05-29T22:16:54 *** proofofkeags has quit IRC
5582020-05-29T22:17:58 *** proofofkeags has joined #bitcoin-core-dev
5592020-05-29T22:18:57 <ariard> jonasschnelli: fyi will host a Review Club session on seralizer/deserializer commits of #18242 in 2 weeks
5602020-05-29T22:19:00 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
5612020-05-29T22:19:24 <ariard> will dig into the rational of MACIng the encrypted length field or not for the occasion
5622020-05-29T22:33:46 *** belcher has quit IRC
5632020-05-29T22:34:10 *** proofofkeags has quit IRC
5642020-05-29T22:34:38 *** proofofkeags has joined #bitcoin-core-dev
5652020-05-29T22:38:14 *** belcher has joined #bitcoin-core-dev
5662020-05-29T22:38:51 *** proofofkeags has quit IRC
5672020-05-29T22:44:37 *** Zenton has quit IRC
5682020-05-29T22:57:00 *** proofofkeags has joined #bitcoin-core-dev
5692020-05-29T22:58:22 *** proofofkeags has quit IRC
5702020-05-29T22:58:49 *** proofofkeags has joined #bitcoin-core-dev
5712020-05-29T23:03:00 *** proofofkeags has quit IRC
5722020-05-29T23:10:12 *** mdunnio has quit IRC
5732020-05-29T23:16:53 *** justanotheruser has quit IRC
5742020-05-29T23:23:13 *** dgenr8 has quit IRC
5752020-05-29T23:23:31 *** dgenr8 has joined #bitcoin-core-dev
5762020-05-29T23:33:26 *** justanotheruser has joined #bitcoin-core-dev
5772020-05-29T23:36:35 *** proofofkeags has joined #bitcoin-core-dev
5782020-05-29T23:39:21 *** bitdex has joined #bitcoin-core-dev
5792020-05-29T23:40:54 *** proofofkeags has quit IRC
5802020-05-29T23:42:38 *** mdunnio has joined #bitcoin-core-dev
5812020-05-29T23:47:14 *** mdunnio has quit IRC
5822020-05-29T23:57:58 *** pinheadm_ has joined #bitcoin-core-dev