12020-06-06T00:00:02 *** pntbr has quit IRC
22020-06-06T00:18:38 *** dgenr8 has quit IRC
32020-06-06T00:18:52 *** ctrlbreak has quit IRC
42020-06-06T00:19:16 *** ctrlbreak has joined #bitcoin-core-dev
52020-06-06T00:21:24 *** peeja has joined #bitcoin-core-dev
62020-06-06T00:26:47 *** promag has quit IRC
72020-06-06T00:29:08 *** Chris_Stewart_5 has quit IRC
82020-06-06T00:31:33 *** dgenr8 has joined #bitcoin-core-dev
92020-06-06T00:41:05 *** Relis has quit IRC
102020-06-06T00:49:24 *** mol has quit IRC
112020-06-06T00:50:06 *** mol has joined #bitcoin-core-dev
122020-06-06T00:55:30 *** Relis has joined #bitcoin-core-dev
132020-06-06T00:58:09 *** Relis has quit IRC
142020-06-06T00:58:44 *** Relis has joined #bitcoin-core-dev
152020-06-06T01:07:12 *** AaronvanW has quit IRC
162020-06-06T01:38:01 *** Relis has quit IRC
172020-06-06T01:46:24 *** jarthur has joined #bitcoin-core-dev
182020-06-06T02:14:12 *** proofofkeags has joined #bitcoin-core-dev
192020-06-06T02:19:42 *** jarthur has quit IRC
202020-06-06T02:23:55 *** proofofkeags has quit IRC
212020-06-06T02:27:41 *** bitcoin-git has joined #bitcoin-core-dev
222020-06-06T02:27:41 <bitcoin-git> [bitcoin] sipa opened pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184
232020-06-06T02:27:42 *** bitcoin-git has left #bitcoin-core-dev
242020-06-06T02:31:37 *** jarthur has joined #bitcoin-core-dev
252020-06-06T03:00:01 *** peeja has quit IRC
262020-06-06T03:05:34 *** pi has joined #bitcoin-core-dev
272020-06-06T03:10:07 *** pi has quit IRC
282020-06-06T03:21:18 *** sendak has joined #bitcoin-core-dev
292020-06-06T03:33:56 *** tryphe_ has joined #bitcoin-core-dev
302020-06-06T03:35:50 *** shesek has quit IRC
312020-06-06T03:36:14 *** shesek has joined #bitcoin-core-dev
322020-06-06T03:36:14 *** shesek has joined #bitcoin-core-dev
332020-06-06T03:36:54 *** tryphe has quit IRC
342020-06-06T03:47:34 *** proofofkeags has joined #bitcoin-core-dev
352020-06-06T03:52:06 *** proofofkeags has quit IRC
362020-06-06T04:20:35 *** vasild_ has joined #bitcoin-core-dev
372020-06-06T04:23:27 *** proofofkeags has joined #bitcoin-core-dev
382020-06-06T04:23:43 *** vasild has quit IRC
392020-06-06T04:23:44 *** vasild_ is now known as vasild
402020-06-06T04:27:20 *** morcos has quit IRC
412020-06-06T04:28:33 *** proofofkeags has quit IRC
422020-06-06T04:34:06 *** Highway61 has quit IRC
432020-06-06T04:35:42 *** morcos has joined #bitcoin-core-dev
442020-06-06T05:00:26 *** Highway61 has joined #bitcoin-core-dev
452020-06-06T06:00:02 *** sendak has quit IRC
462020-06-06T06:20:54 *** tryphe_ is now known as tryphe
472020-06-06T06:21:49 *** langseth1 has joined #bitcoin-core-dev
482020-06-06T06:24:13 *** proofofkeags has joined #bitcoin-core-dev
492020-06-06T06:25:34 *** bitcoin-git has joined #bitcoin-core-dev
502020-06-06T06:25:35 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0fc6ea216c00...17cfa52d3806
512020-06-06T06:25:35 <bitcoin-git> bitcoin/master 7dda912 Hennadii Stepanov: test: Do not swallow flake8 exit code
522020-06-06T06:25:36 <bitcoin-git> bitcoin/master 5d77549 Hennadii Stepanov: doc: Add mypy to test dependencies
532020-06-06T06:25:36 <bitcoin-git> bitcoin/master 17cfa52 fanquake: Merge #19172: test: Do not swallow flake8 exit code
542020-06-06T06:25:38 *** bitcoin-git has left #bitcoin-core-dev
552020-06-06T06:25:54 *** bitcoin-git has joined #bitcoin-core-dev
562020-06-06T06:25:54 <bitcoin-git> [bitcoin] fanquake merged pull request #19172: test: Do not swallow flake8 exit code (master...200605-mypy) https://github.com/bitcoin/bitcoin/pull/19172
572020-06-06T06:25:55 *** bitcoin-git has left #bitcoin-core-dev
582020-06-06T06:28:33 *** proofofkeags has quit IRC
592020-06-06T06:31:17 *** Kiminuo has joined #bitcoin-core-dev
602020-06-06T06:49:36 *** braydonf has joined #bitcoin-core-dev
612020-06-06T07:02:15 *** bitcoin-git has joined #bitcoin-core-dev
622020-06-06T07:02:15 <bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
632020-06-06T07:02:16 *** bitcoin-git has left #bitcoin-core-dev
642020-06-06T07:02:35 *** bitcoin-git has joined #bitcoin-core-dev
652020-06-06T07:02:35 <bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
662020-06-06T07:02:36 *** bitcoin-git has left #bitcoin-core-dev
672020-06-06T07:21:59 *** Talkless has joined #bitcoin-core-dev
682020-06-06T07:30:34 *** Talkless has quit IRC
692020-06-06T08:04:56 *** Talkless has joined #bitcoin-core-dev
702020-06-06T08:08:30 *** marcoagner has joined #bitcoin-core-dev
712020-06-06T08:16:11 <jonatack> any preference in naming for an assertion that an amount has the expected number of digits after the decimal? i'm thinking "assert_scale", "assert_fractional_part_size", "assert_mantissa_length", "assert_decimal_places", etc.
722020-06-06T08:23:38 <jonatack> going with "assert_scale" and an explanatory docstring for now
732020-06-06T08:25:10 *** proofofkeags has joined #bitcoin-core-dev
742020-06-06T08:29:48 *** proofofkeags has quit IRC
752020-06-06T08:36:10 *** harrigan has quit IRC
762020-06-06T08:36:22 *** harrigan has joined #bitcoin-core-dev
772020-06-06T09:00:01 *** langseth1 has quit IRC
782020-06-06T09:21:41 *** jdsharp has joined #bitcoin-core-dev
792020-06-06T09:22:41 *** Relis has joined #bitcoin-core-dev
802020-06-06T09:25:52 *** AaronvanW has joined #bitcoin-core-dev
812020-06-06T09:26:49 *** promag has joined #bitcoin-core-dev
822020-06-06T09:27:18 *** promag has quit IRC
832020-06-06T09:29:14 *** harrigan has quit IRC
842020-06-06T09:30:56 *** harrigan has joined #bitcoin-core-dev
852020-06-06T09:32:31 *** Relis has quit IRC
862020-06-06T10:03:18 *** Kade88Reilly has joined #bitcoin-core-dev
872020-06-06T10:17:16 *** Relis has joined #bitcoin-core-dev
882020-06-06T10:26:54 *** baldur has quit IRC
892020-06-06T10:31:05 *** Kade88Reilly has quit IRC
902020-06-06T10:38:02 *** Kiminuo has quit IRC
912020-06-06T10:38:10 *** AaronvanW has quit IRC
922020-06-06T10:39:58 *** baldur has joined #bitcoin-core-dev
932020-06-06T10:41:41 <ryanofsky> phantomcircuit, to fix link errors you may need to move blockfilter.cpp from libbitcoin_server library to libbitcoin_util library in makefile
942020-06-06T10:42:36 <ryanofsky> wallet isn't linked against libbitcoin_server to prevent wallet code from trying to access node global variables
952020-06-06T10:43:55 <ryanofsky> but a lot of things in libbitcoin_server that are just utilities without server state don't really belong there
962020-06-06T11:00:30 *** justanotheruser has quit IRC
972020-06-06T11:13:26 *** bitcoin-git has joined #bitcoin-core-dev
982020-06-06T11:13:27 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
992020-06-06T11:13:27 *** bitcoin-git has left #bitcoin-core-dev
1002020-06-06T11:15:40 *** bitcoin-git has joined #bitcoin-core-dev
1012020-06-06T11:15:40 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
1022020-06-06T11:15:41 *** bitcoin-git has left #bitcoin-core-dev
1032020-06-06T11:17:51 *** EagleTM has joined #bitcoin-core-dev
1042020-06-06T11:30:19 *** justanotheruser has joined #bitcoin-core-dev
1052020-06-06T11:32:40 *** bitcoin-git has joined #bitcoin-core-dev
1062020-06-06T11:32:41 <bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
1072020-06-06T11:32:50 *** bitcoin-git has left #bitcoin-core-dev
1082020-06-06T11:33:05 *** bitcoin-git has joined #bitcoin-core-dev
1092020-06-06T11:33:06 <bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
1102020-06-06T11:33:06 *** bitcoin-git has left #bitcoin-core-dev
1112020-06-06T12:00:02 *** jdsharp has quit IRC
1122020-06-06T12:15:00 *** bitcoin-git has joined #bitcoin-core-dev
1132020-06-06T12:15:01 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19188: 2006 test no shadow field (master...2006-testNoShadowField) https://github.com/bitcoin/bitcoin/pull/19188
1142020-06-06T12:15:02 *** bitcoin-git has left #bitcoin-core-dev
1152020-06-06T12:20:24 *** sendak has joined #bitcoin-core-dev
1162020-06-06T12:26:55 *** proofofkeags has joined #bitcoin-core-dev
1172020-06-06T12:28:06 *** Guyver2 has joined #bitcoin-core-dev
1182020-06-06T12:31:43 *** proofofkeags has quit IRC
1192020-06-06T12:46:49 *** dviola has joined #bitcoin-core-dev
1202020-06-06T12:49:53 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1212020-06-06T13:03:56 *** Kiminuo has joined #bitcoin-core-dev
1222020-06-06T13:04:24 *** sendak has quit IRC
1232020-06-06T13:05:00 *** guest534543 has joined #bitcoin-core-dev
1242020-06-06T13:08:36 *** Kiminuo has quit IRC
1252020-06-06T13:53:03 *** bitcoin-git has joined #bitcoin-core-dev
1262020-06-06T13:53:04 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/17cfa52d3806...b1b173994406
1272020-06-06T13:53:05 <bitcoin-git> bitcoin/master fa3999f MarcoFalke: net: Reformat excessively long if condition into multiple lines
1282020-06-06T13:53:06 <bitcoin-git> bitcoin/master fa9604c MarcoFalke: doc: noban precludes maxuploadtarget disconnects
1292020-06-06T13:53:06 <bitcoin-git> bitcoin/master b1b1739 MarcoFalke: Merge #18968: doc: noban precludes maxuploadtarget disconnects
1302020-06-06T13:53:08 *** bitcoin-git has left #bitcoin-core-dev
1312020-06-06T13:53:23 *** bitcoin-git has joined #bitcoin-core-dev
1322020-06-06T13:53:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
1332020-06-06T13:53:24 *** bitcoin-git has left #bitcoin-core-dev
1342020-06-06T13:55:39 *** EagleTM has quit IRC
1352020-06-06T14:02:32 *** bitcoin-git has joined #bitcoin-core-dev
1362020-06-06T14:02:32 <bitcoin-git> [bitcoin] hebasto opened pull request #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp (master...200605-timedata) https://github.com/bitcoin/bitcoin/pull/19189
1372020-06-06T14:02:33 *** bitcoin-git has left #bitcoin-core-dev
1382020-06-06T14:15:31 *** ernesto has joined #bitcoin-core-dev
1392020-06-06T14:16:10 *** ernesto has left #bitcoin-core-dev
1402020-06-06T14:21:12 *** DuncanT1 has joined #bitcoin-core-dev
1412020-06-06T14:37:48 *** bitcoin-git has joined #bitcoin-core-dev
1422020-06-06T14:37:48 <bitcoin-git> [bitcoin] hebasto opened pull request #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp (master...200606-netbase) https://github.com/bitcoin/bitcoin/pull/19190
1432020-06-06T14:37:49 *** bitcoin-git has left #bitcoin-core-dev
1442020-06-06T14:43:24 *** Relis has quit IRC
1452020-06-06T14:54:20 *** Relis has joined #bitcoin-core-dev
1462020-06-06T15:00:01 *** DuncanT1 has quit IRC
1472020-06-06T15:02:04 *** proofofkeags has joined #bitcoin-core-dev
1482020-06-06T15:05:38 *** bitcoin-git has joined #bitcoin-core-dev
1492020-06-06T15:05:38 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19191: net: Extract download permission from noban (master...2006-netPerDow) https://github.com/bitcoin/bitcoin/pull/19191
1502020-06-06T15:05:39 *** bitcoin-git has left #bitcoin-core-dev
1512020-06-06T15:20:43 *** Bjarki has joined #bitcoin-core-dev
1522020-06-06T15:35:42 *** mol has quit IRC
1532020-06-06T15:38:40 *** mol has joined #bitcoin-core-dev
1542020-06-06T16:19:06 *** owowo has quit IRC
1552020-06-06T16:23:43 *** owowo has joined #bitcoin-core-dev
1562020-06-06T16:23:43 *** vasild has quit IRC
1572020-06-06T16:30:41 *** vasild has joined #bitcoin-core-dev
1582020-06-06T16:38:23 *** EagleTM has joined #bitcoin-core-dev
1592020-06-06T16:47:41 *** Kiminuo has joined #bitcoin-core-dev
1602020-06-06T16:51:33 *** guest534543 has quit IRC
1612020-06-06T16:52:13 *** promag has joined #bitcoin-core-dev
1622020-06-06T16:56:48 *** promag has quit IRC
1632020-06-06T17:20:42 *** bitcoin-git has joined #bitcoin-core-dev
1642020-06-06T17:20:42 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19192: doc: Extract net permissions doc (master...2006-docNetPerm) https://github.com/bitcoin/bitcoin/pull/19192
1652020-06-06T17:20:43 *** bitcoin-git has left #bitcoin-core-dev
1662020-06-06T17:26:55 *** EagleTM has quit IRC
1672020-06-06T17:35:20 *** bitcoin-git has joined #bitcoin-core-dev
1682020-06-06T17:35:21 <bitcoin-git> [bitcoin] hebasto opened pull request #19193: refactor, qt, net: Deduplicate NumConnections enum (master...200606-numconn) https://github.com/bitcoin/bitcoin/pull/19193
1692020-06-06T17:35:21 *** bitcoin-git has left #bitcoin-core-dev
1702020-06-06T17:56:28 *** bitcoin-git has joined #bitcoin-core-dev
1712020-06-06T17:56:28 <bitcoin-git> [bitcoin] miztake opened pull request #19194: util: Don't reference errno when pthread fails. (master...prototype) https://github.com/bitcoin/bitcoin/pull/19194
1722020-06-06T17:56:29 *** bitcoin-git has left #bitcoin-core-dev
1732020-06-06T18:00:02 *** Bjarki has quit IRC
1742020-06-06T18:06:21 *** jarthur has quit IRC
1752020-06-06T18:07:02 *** jarthur has joined #bitcoin-core-dev
1762020-06-06T18:11:26 <jarthur> Does the REST API use libevent goodness?
1772020-06-06T18:13:01 <fjahr> jarthur: yes
1782020-06-06T18:13:05 <jarthur> ty
1792020-06-06T18:14:38 *** dviola has quit IRC
1802020-06-06T18:21:11 <phantomcircuit> eyyyy using a filter with fixed siphash parameters and 30 bits does a wallet rescan in 4.6 minutes
1812020-06-06T18:55:16 *** harrigan has quit IRC
1822020-06-06T18:56:21 *** Iam_thor has joined #bitcoin-core-dev
1832020-06-06T18:57:00 *** harrigan has joined #bitcoin-core-dev
1842020-06-06T19:00:56 *** belcher has quit IRC
1852020-06-06T19:03:17 *** bitdex has joined #bitcoin-core-dev
1862020-06-06T19:11:30 <sipa> phantomcircuit: nice
1872020-06-06T19:20:58 *** EagleTM has joined #bitcoin-core-dev
1882020-06-06T19:37:40 *** Relis has quit IRC
1892020-06-06T19:38:54 *** Relis has joined #bitcoin-core-dev
1902020-06-06T20:19:44 <phantomcircuit> sipa, i also realized last night i was still loading the blocks when i did the BASIC filter benchmarks so im redoing those correctly
1912020-06-06T20:19:55 <phantomcircuit> i can tell from the heat of my laptop that it's much much slower though
1922020-06-06T20:25:49 *** dongcarl has quit IRC
1932020-06-06T20:32:54 *** Kiminuo has quit IRC
1942020-06-06T20:40:51 *** promag has joined #bitcoin-core-dev
1952020-06-06T20:42:41 *** EagleTM has quit IRC
1962020-06-06T20:43:46 *** Guyver2 has quit IRC
1972020-06-06T20:48:59 *** EagleTM has joined #bitcoin-core-dev
1982020-06-06T20:53:40 <phantomcircuit> sipa, there's some house keeping stuff to do in the ScanForWalletTransactions method that could be a separate pr and are trivial, should i do that?
1992020-06-06T20:53:48 <phantomcircuit> im not sure what the thinking is on that right now
2002020-06-06T21:00:02 *** Iam_thor has quit IRC
2012020-06-06T21:20:46 *** bitcoin-git has joined #bitcoin-core-dev
2022020-06-06T21:20:47 <bitcoin-git> [bitcoin] pstratem opened pull request #19195: wallet: ScanForWalletTransactions cleanup (master...2020-06-06-scanforwallettransactions-cleanup) https://github.com/bitcoin/bitcoin/pull/19195
2032020-06-06T21:20:47 *** bitcoin-git has left #bitcoin-core-dev
2042020-06-06T21:21:14 *** kormoc1 has joined #bitcoin-core-dev
2052020-06-06T21:27:39 <phantomcircuit> btw is master broken? make check "ERROR: ConnectBlock(): coinbase pays too much (actual=5010000000 vs limit=5000000000)"
2062020-06-06T21:30:04 <sipa> phantomcircuit: when?
2072020-06-06T21:34:00 <phantomcircuit> no it's just my branch that has nothing to do with the coinbase values
2082020-06-06T21:34:01 <phantomcircuit> what
2092020-06-06T21:36:20 *** EagleTM has quit IRC
2102020-06-06T21:37:39 *** filchef has joined #bitcoin-core-dev
2112020-06-06T21:55:41 *** jarthur has quit IRC
2122020-06-06T21:58:32 *** jarthur has joined #bitcoin-core-dev
2132020-06-06T22:02:09 *** harrigan- has joined #bitcoin-core-dev
2142020-06-06T22:02:29 <phantomcircuit> oh hmm findNextBlock has identical results for a reorg and a straight failure to load the block
2152020-06-06T22:03:14 <phantomcircuit> so the wallet test is expecting FAILURE when im returning success because the reorg flag is set, but the reorg flag doesn't mean reorg it means reorg or the block couldn't be found
2162020-06-06T22:03:39 *** harrigan has quit IRC
2172020-06-06T22:04:51 *** EagleTM has joined #bitcoin-core-dev
2182020-06-06T22:05:28 *** lightlike has joined #bitcoin-core-dev
2192020-06-06T22:17:38 <phantomcircuit> right there's no way to distinguish between the start block is invalid and the start block was reorg'd so this test is just bad
2202020-06-06T22:18:30 *** Talkless has quit IRC
2212020-06-06T22:28:57 *** lightlike has quit IRC
2222020-06-06T22:29:39 *** marcoagner has quit IRC
2232020-06-06T22:37:24 *** jarthur has quit IRC
2242020-06-06T22:54:38 *** jeremyrubin has quit IRC
2252020-06-06T23:03:03 *** Zenton has quit IRC
2262020-06-06T23:03:21 *** Zenton has joined #bitcoin-core-dev
2272020-06-06T23:07:03 *** ja has left #bitcoin-core-dev
2282020-06-06T23:51:10 *** promag has quit IRC
2292020-06-06T23:53:26 *** mol has quit IRC
2302020-06-06T23:53:51 *** mol has joined #bitcoin-core-dev
2312020-06-06T23:55:36 *** jarthur has joined #bitcoin-core-dev
2322020-06-06T23:56:04 *** jarthur_ has joined #bitcoin-core-dev
2332020-06-06T23:59:41 *** jarthur has quit IRC