12020-06-07T00:00:01 *** kormoc1 has quit IRC
22020-06-07T00:02:14 *** michagogo_ is now known as michagogo
32020-06-07T00:06:00 *** pretyflaco has joined #bitcoin-core-dev
42020-06-07T00:21:39 *** justanotheruser has quit IRC
52020-06-07T00:21:52 *** ajpiano1 has joined #bitcoin-core-dev
62020-06-07T00:22:20 *** promag has joined #bitcoin-core-dev
72020-06-07T00:27:14 *** promag has quit IRC
82020-06-07T00:29:22 *** justanotheruser has joined #bitcoin-core-dev
92020-06-07T00:41:39 *** mol_ has joined #bitcoin-core-dev
102020-06-07T00:44:02 *** mol has quit IRC
112020-06-07T00:44:33 *** jarthur_ has quit IRC
122020-06-07T00:47:13 *** jarthur has joined #bitcoin-core-dev
132020-06-07T00:47:51 *** jarthur_ has joined #bitcoin-core-dev
142020-06-07T00:51:32 *** jarthur has quit IRC
152020-06-07T01:00:17 *** bitcoin-git has joined #bitcoin-core-dev
162020-06-07T01:00:17 <bitcoin-git> [bitcoin] svannord opened pull request #19196: Create Starting Out (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19196
172020-06-07T01:00:18 *** bitcoin-git has left #bitcoin-core-dev
182020-06-07T01:01:02 *** bitcoin-git has joined #bitcoin-core-dev
192020-06-07T01:01:02 <bitcoin-git> [bitcoin] fanquake closed pull request #19196: Create Starting Out (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19196
202020-06-07T01:01:03 *** bitcoin-git has left #bitcoin-core-dev
212020-06-07T01:12:55 *** promag has joined #bitcoin-core-dev
222020-06-07T01:14:35 *** justanotheruser has quit IRC
232020-06-07T01:17:55 *** justanotheruser has joined #bitcoin-core-dev
242020-06-07T01:30:17 *** mdunnio has joined #bitcoin-core-dev
252020-06-07T01:38:47 *** mdunnio has quit IRC
262020-06-07T01:39:54 *** Squidicc has quit IRC
272020-06-07T01:44:31 *** Relis has quit IRC
282020-06-07T01:54:45 *** Relis has joined #bitcoin-core-dev
292020-06-07T02:12:49 *** pretyflaco has quit IRC
302020-06-07T02:14:15 *** promag has quit IRC
312020-06-07T02:38:30 *** Relis has quit IRC
322020-06-07T03:00:02 *** ajpiano1 has quit IRC
332020-06-07T03:01:07 *** jarthur_ is now known as jarthur
342020-06-07T03:04:28 <phantomcircuit> sipa, for the asmap stuff is there a simple "is this ip in this asn?" function?
352020-06-07T03:17:24 <sipa> phantomcircuit: my asmap tool PR has a lookup function
362020-06-07T03:17:36 <sipa> i also have python code that can do the same
372020-06-07T03:18:01 <sipa> #18573
382020-06-07T03:18:04 <gribble> https://github.com/bitcoin/bitcoin/issues/18573 | [RFC] bitcoin-asmap utility by sipa · Pull Request #18573 · bitcoin/bitcoin · GitHub
392020-06-07T03:20:13 <sipa> also testmap.py in https://github.com/sipa/asmap
402020-06-07T03:20:22 *** Eagle[TM] has joined #bitcoin-core-dev
412020-06-07T03:21:50 <sipa> phantomcircuit: or you mean inside bitcoin core codebase? GetMappedAs in CNetAddr
422020-06-07T03:21:57 *** EagleTM has quit IRC
432020-06-07T03:22:21 *** rob01 has joined #bitcoin-core-dev
442020-06-07T03:35:34 *** justan0theruser has joined #bitcoin-core-dev
452020-06-07T03:35:53 *** shesek has quit IRC
462020-06-07T03:36:20 *** shesek has joined #bitcoin-core-dev
472020-06-07T03:36:20 *** shesek has joined #bitcoin-core-dev
482020-06-07T03:37:05 *** justanotheruser has quit IRC
492020-06-07T04:20:38 *** vasild_ has joined #bitcoin-core-dev
502020-06-07T04:21:46 *** mdunnio has joined #bitcoin-core-dev
512020-06-07T04:23:43 *** vasild has quit IRC
522020-06-07T04:23:44 *** vasild_ is now known as vasild
532020-06-07T04:24:33 *** Highway61 has quit IRC
542020-06-07T04:27:38 *** vasild has quit IRC
552020-06-07T04:35:57 *** vasild has joined #bitcoin-core-dev
562020-06-07T04:36:11 *** mdunnio has quit IRC
572020-06-07T04:40:18 *** mdunnio has joined #bitcoin-core-dev
582020-06-07T04:46:36 *** mdunnio has quit IRC
592020-06-07T05:12:58 *** sdaftuar has quit IRC
602020-06-07T05:13:47 *** sdaftuar has joined #bitcoin-core-dev
612020-06-07T05:37:45 *** bitcoin-git has joined #bitcoin-core-dev
622020-06-07T05:37:45 <bitcoin-git> [bitcoin] fanquake opened pull request #19197: init: use std::thread for ThreadImport() (master...thread_import_no_boost) https://github.com/bitcoin/bitcoin/pull/19197
632020-06-07T05:37:46 *** bitcoin-git has left #bitcoin-core-dev
642020-06-07T05:38:01 *** rh0nj has quit IRC
652020-06-07T05:39:08 *** rh0nj has joined #bitcoin-core-dev
662020-06-07T05:58:28 *** Kiminuo has joined #bitcoin-core-dev
672020-06-07T06:00:01 *** rob01 has quit IRC
682020-06-07T06:12:58 *** justan0theruser has quit IRC
692020-06-07T06:16:00 *** justanotheruser has joined #bitcoin-core-dev
702020-06-07T06:22:21 *** jaekwon has joined #bitcoin-core-dev
712020-06-07T06:31:15 <phantomcircuit> sipa, i mean for banning by AS
722020-06-07T06:33:55 <phantomcircuit> sipa, is there a reason the asmap isn't a global? seems like something that should be a global
732020-06-07T06:41:57 <sipa> phantomcircuit: i think connman or addrman is a reasonable place for.it
742020-06-07T06:42:03 <sipa> i forget where it's held
752020-06-07T07:29:44 *** Talkless has joined #bitcoin-core-dev
762020-06-07T07:35:28 *** mdunnio has joined #bitcoin-core-dev
772020-06-07T07:51:58 *** mdunnio has quit IRC
782020-06-07T08:17:31 *** filchef has joined #bitcoin-core-dev
792020-06-07T08:21:38 *** justanotheruser has quit IRC
802020-06-07T08:23:21 *** ccook_ has joined #bitcoin-core-dev
812020-06-07T08:23:27 *** ccook has quit IRC
822020-06-07T08:23:27 *** ccook_ is now known as ccook
832020-06-07T08:25:30 *** justanotheruser has joined #bitcoin-core-dev
842020-06-07T08:25:31 *** marcinja has quit IRC
852020-06-07T08:25:43 *** marcinja has joined #bitcoin-core-dev
862020-06-07T08:35:06 *** pinheadmz has quit IRC
872020-06-07T08:35:06 *** sanket1729 has quit IRC
882020-06-07T08:35:06 *** cncr04s has quit IRC
892020-06-07T08:36:01 *** pinheadmz has joined #bitcoin-core-dev
902020-06-07T08:36:21 *** sanket1729 has joined #bitcoin-core-dev
912020-06-07T08:36:21 *** cncr04s has joined #bitcoin-core-dev
922020-06-07T08:48:41 *** Eagle[TM] has quit IRC
932020-06-07T09:00:02 *** jaekwon has quit IRC
942020-06-07T09:03:15 *** Kiminuo has quit IRC
952020-06-07T09:22:32 *** nickr has joined #bitcoin-core-dev
962020-06-07T09:33:00 *** promag has joined #bitcoin-core-dev
972020-06-07T09:34:22 *** ctrlbreak_MAD has joined #bitcoin-core-dev
982020-06-07T09:37:27 *** ctrlbreak has quit IRC
992020-06-07T09:47:46 *** AaronvanW has joined #bitcoin-core-dev
1002020-06-07T09:57:20 *** Emcy has quit IRC
1012020-06-07T10:02:46 *** sdaftuar has quit IRC
1022020-06-07T10:03:21 *** Myra34Moore has joined #bitcoin-core-dev
1032020-06-07T10:03:29 *** sdaftuar has joined #bitcoin-core-dev
1042020-06-07T10:08:15 *** Myra34Moore has quit IRC
1052020-06-07T10:27:09 *** Emcy has joined #bitcoin-core-dev
1062020-06-07T10:28:52 *** promag has quit IRC
1072020-06-07T10:31:13 *** jarthur has quit IRC
1082020-06-07T10:38:39 *** Landryl has quit IRC
1092020-06-07T10:43:41 *** bitcoin-git has joined #bitcoin-core-dev
1102020-06-07T10:43:42 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1b173994406...1b90a7b61a37
1112020-06-07T10:43:42 <bitcoin-git> bitcoin/master 501e6ab Calvin Kim: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call
1122020-06-07T10:43:42 <bitcoin-git> bitcoin/master 1b90a7b MarcoFalke: Merge #19005: doc: Add documentation for 'checklevel' argument in 'verifyc...
1132020-06-07T10:43:43 *** bitcoin-git has left #bitcoin-core-dev
1142020-06-07T10:44:01 *** bitcoin-git has joined #bitcoin-core-dev
1152020-06-07T10:44:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC⦠(master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
1162020-06-07T10:44:03 *** bitcoin-git has left #bitcoin-core-dev
1172020-06-07T11:21:30 *** Relis has joined #bitcoin-core-dev
1182020-06-07T11:26:56 *** Relis has quit IRC
1192020-06-07T11:28:48 *** Highway61 has joined #bitcoin-core-dev
1202020-06-07T11:43:59 *** pretyflaco has joined #bitcoin-core-dev
1212020-06-07T11:44:32 *** pretyflaco1 has joined #bitcoin-core-dev
1222020-06-07T11:45:13 *** pretyflaco has quit IRC
1232020-06-07T11:54:29 *** Relis has joined #bitcoin-core-dev
1242020-06-07T11:56:32 *** Relis has quit IRC
1252020-06-07T11:58:47 *** Kiminuo has joined #bitcoin-core-dev
1262020-06-07T12:00:02 *** nickr has quit IRC
1272020-06-07T12:01:30 *** Relis has joined #bitcoin-core-dev
1282020-06-07T12:14:20 *** AaronvanW has quit IRC
1292020-06-07T12:17:40 *** pretyflaco1 is now known as pretyflaco
1302020-06-07T12:21:01 *** ski1 has joined #bitcoin-core-dev
1312020-06-07T12:30:25 *** gribble has quit IRC
1322020-06-07T12:40:49 *** gribble has joined #bitcoin-core-dev
1332020-06-07T12:48:34 *** pretyflaco has quit IRC
1342020-06-07T12:50:42 *** pretyflaco has joined #bitcoin-core-dev
1352020-06-07T13:03:14 *** pretyflaco has quit IRC
1362020-06-07T13:07:35 *** Landryl has joined #bitcoin-core-dev
1372020-06-07T13:41:16 *** DeanGuss has quit IRC
1382020-06-07T13:44:17 *** bitcoin-git has joined #bitcoin-core-dev
1392020-06-07T13:44:17 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19198: test: Check that peers with forcerelay permission are not asked to feefilter (master...2006-testForcerelayFeefilter) https://github.com/bitcoin/bitcoin/pull/19198
1402020-06-07T13:44:18 *** bitcoin-git has left #bitcoin-core-dev
1412020-06-07T14:05:26 *** dviola has joined #bitcoin-core-dev
1422020-06-07T14:08:21 *** Bullitje has joined #bitcoin-core-dev
1432020-06-07T14:09:26 *** Bullitje has quit IRC
1442020-06-07T14:09:47 *** troygiorshev has quit IRC
1452020-06-07T14:09:57 *** bitcoin-git has joined #bitcoin-core-dev
1462020-06-07T14:09:57 <bitcoin-git> [bitcoin] jonatack opened pull request #19200: rpc: remove deprecated getaddressinfo fields (master...remove-deprecated-getaddressinfo-fields) https://github.com/bitcoin/bitcoin/pull/19200
1472020-06-07T14:09:58 *** bitcoin-git has left #bitcoin-core-dev
1482020-06-07T14:10:41 *** Bullitje has joined #bitcoin-core-dev
1492020-06-07T14:16:45 *** looping747 has joined #bitcoin-core-dev
1502020-06-07T14:17:00 *** molz_ has joined #bitcoin-core-dev
1512020-06-07T14:19:51 *** mol_ has quit IRC
1522020-06-07T14:23:08 *** looping747 has quit IRC
1532020-06-07T14:24:28 *** Guyver2 has joined #bitcoin-core-dev
1542020-06-07T14:26:42 *** mol_ has joined #bitcoin-core-dev
1552020-06-07T14:30:14 *** molz_ has quit IRC
1562020-06-07T14:32:19 *** bitcoin-git has joined #bitcoin-core-dev
1572020-06-07T14:32:19 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201
1582020-06-07T14:32:20 *** bitcoin-git has left #bitcoin-core-dev
1592020-06-07T14:34:07 *** promag has joined #bitcoin-core-dev
1602020-06-07T14:37:49 *** troygiorshev has joined #bitcoin-core-dev
1612020-06-07T14:42:34 *** promag has quit IRC
1622020-06-07T14:42:59 *** bitcoin-git has joined #bitcoin-core-dev
1632020-06-07T14:42:59 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b90a7b61a37...43695b0cf851
1642020-06-07T14:43:00 <bitcoin-git> bitcoin/master fa4cd1f MarcoFalke: ci: Switch to bitcoincore.org download
1652020-06-07T14:43:00 <bitcoin-git> bitcoin/master 43695b0 MarcoFalke: Merge #19201: ci: Switch to bitcoincore.org download
1662020-06-07T14:43:02 *** bitcoin-git has left #bitcoin-core-dev
1672020-06-07T14:43:19 *** bitcoin-git has joined #bitcoin-core-dev
1682020-06-07T14:43:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201
1692020-06-07T14:43:20 *** bitcoin-git has left #bitcoin-core-dev
1702020-06-07T14:51:11 *** mol_ has quit IRC
1712020-06-07T14:52:11 *** mol has joined #bitcoin-core-dev
1722020-06-07T14:52:34 *** troygiorshev has quit IRC
1732020-06-07T15:00:02 *** ski1 has quit IRC
1742020-06-07T15:15:33 *** Victorsueca has quit IRC
1752020-06-07T15:18:59 *** someone235 has quit IRC
1762020-06-07T15:21:56 *** k0da has joined #bitcoin-core-dev
1772020-06-07T15:26:28 *** proofofkeags has quit IRC
1782020-06-07T15:32:16 *** bitcoin-git has joined #bitcoin-core-dev
1792020-06-07T15:32:16 <bitcoin-git> [bitcoin] jonatack opened pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202
1802020-06-07T15:32:17 *** bitcoin-git has left #bitcoin-core-dev
1812020-06-07T15:33:54 *** promag has joined #bitcoin-core-dev
1822020-06-07T15:54:24 *** Kad34 has joined #bitcoin-core-dev
1832020-06-07T15:55:13 *** promag has quit IRC
1842020-06-07T15:56:32 *** Kad34 has quit IRC
1852020-06-07T16:12:22 *** AaronvanW has joined #bitcoin-core-dev
1862020-06-07T16:12:32 *** XORder has joined #bitcoin-core-dev
1872020-06-07T16:16:11 *** davterra has quit IRC
1882020-06-07T16:17:15 *** Luke has joined #bitcoin-core-dev
1892020-06-07T16:20:34 *** vasild_ has joined #bitcoin-core-dev
1902020-06-07T16:23:43 *** vasild has quit IRC
1912020-06-07T16:23:44 *** vasild_ is now known as vasild
1922020-06-07T16:32:22 *** promag has joined #bitcoin-core-dev
1932020-06-07T16:32:40 *** bitcoin-git has joined #bitcoin-core-dev
1942020-06-07T16:32:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/43695b0cf851...b3091b2be7d1
1952020-06-07T16:32:41 <bitcoin-git> bitcoin/master 4c0c893 Jon Atack: log: remove deprecated `db` log category
1962020-06-07T16:32:42 <bitcoin-git> bitcoin/master c514a4f Jon Atack: doc: release note for `db` log category removal
1972020-06-07T16:32:42 <bitcoin-git> bitcoin/master b3091b2 MarcoFalke: Merge #19202: log: remove deprecated `db` log category
1982020-06-07T16:32:44 *** bitcoin-git has left #bitcoin-core-dev
1992020-06-07T16:33:00 *** bitcoin-git has joined #bitcoin-core-dev
2002020-06-07T16:33:00 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202
2012020-06-07T16:33:01 *** bitcoin-git has left #bitcoin-core-dev
2022020-06-07T16:37:03 *** promag has quit IRC
2032020-06-07T16:46:50 *** Luke has quit IRC
2042020-06-07T16:49:59 *** proofofkeags has joined #bitcoin-core-dev
2052020-06-07T16:51:11 *** dviola has quit IRC
2062020-06-07T16:57:59 *** proofofkeags has quit IRC
2072020-06-07T16:58:32 *** proofofkeags has joined #bitcoin-core-dev
2082020-06-07T17:02:41 *** jonatack has quit IRC
2092020-06-07T17:03:18 *** Bullitje has quit IRC
2102020-06-07T17:03:22 *** proofofkeags has quit IRC
2112020-06-07T17:10:23 *** pretyflaco has joined #bitcoin-core-dev
2122020-06-07T17:15:08 <phantomcircuit> sipa, can i get all of the subnets in an asn from the asmap?
2132020-06-07T17:15:28 <sipa> not without decoding the entire thing
2142020-06-07T17:15:36 <phantomcircuit> it looks like no
2152020-06-07T17:15:45 <sipa> but that's still pretty fast
2162020-06-07T17:16:00 <phantomcircuit> that makes adding asn based bans much harder but yeah definitely still doable
2172020-06-07T17:16:11 <sipa> ah i see
2182020-06-07T17:16:21 <sipa> you want to translate banned ASes to subnets
2192020-06-07T17:16:31 <phantomcircuit> would it be reasonable to do that when adding asn bans? cause that changes it to like two lines of code from many more
2202020-06-07T17:17:43 <luke-jr> maybe the banlist should support ASNs directly?
2212020-06-07T17:17:51 <sipa> that would certainly be cleaner
2222020-06-07T17:17:58 <sipa> but i see how that would be harder to implement
2232020-06-07T17:18:26 <sipa> i think if banlists on disk supported ASes natively, but at runtime they're converted to subnets, maybe it's ok?
2242020-06-07T17:18:39 <phantomcircuit> i can definitely support asn's directly instead, it's not something where one approach is obviously better to me though
2252020-06-07T17:18:42 <sipa> so that they correctly persist across restarts if asmap gets updated
2262020-06-07T17:20:42 <phantomcircuit> adding support naively will break backwards compat with banlist.dat though
2272020-06-07T17:20:44 <luke-jr> sipa: nah imo
2282020-06-07T17:21:10 <luke-jr> sipa: setban should support adding/removing AS bans, without affecting overlapping subnet bans, IMO
2292020-06-07T17:21:18 <sipa> luke-jr: that's reasonable
2302020-06-07T17:21:23 <luke-jr> plus we might want to update ASmaps at runtime someday
2312020-06-07T17:22:00 *** davterra has joined #bitcoin-core-dev
2322020-06-07T17:22:01 <sipa> phantomcircuit: i think it's expected that banlist.dat compatibility breaks when you ban an AS - there is no way for an old version to behave correctly
2332020-06-07T17:22:17 *** Pavlenex has joined #bitcoin-core-dev
2342020-06-07T17:22:18 <sipa> you wouldn't want to run with a partial set of bans
2352020-06-07T17:22:26 <phantomcircuit> sipa, no i mean doing this naively would mean clearing all your old bans
2362020-06-07T17:22:34 <sipa> why?
2372020-06-07T17:22:47 <luke-jr> hmm
2382020-06-07T17:23:04 <luke-jr> sipa: do we have a way to sanely handle an incompatible banlist in current/old versions?
2392020-06-07T17:23:11 <sipa> no clue
2402020-06-07T17:23:18 <luke-jr> losing the banlist entirely would be strictly worse than just losing AS bans
2412020-06-07T17:23:19 <sipa> i have never looked at its serialization
2422020-06-07T17:24:26 <sipa> agree
2432020-06-07T17:24:31 <sipa> well
2442020-06-07T17:24:39 <phantomcircuit> sipa, banlist.dat is basically just a serialized banmap_t which is a map of subnets
2452020-06-07T17:24:49 <sipa> i think that if you add an AS ban, you should not lose existing subnet bans
2462020-06-07T17:25:17 <sipa> but if you add an AS ban, and then downgrade to a version that does not support AS bans, ideally it just fails to start
2472020-06-07T17:25:52 *** Pavlenex has quit IRC
2482020-06-07T17:25:53 <sipa> phantomcircuit: banlist serialized entries have a version number
2492020-06-07T17:26:04 <sipa> so there is no problem
2502020-06-07T17:26:23 <sipa> just increment the version number of AS-based bans; but keep supporting the old subnet-only one in the deserializer
2512020-06-07T17:27:09 <sipa> unfortunately the version number is not enforced
2522020-06-07T17:27:21 <sipa> so old versions with read corrupted data
2532020-06-07T17:28:04 <luke-jr> looks like if we change the root type (currently map<CSubNet, CBanEntry>) old versions should refuse to load it
2542020-06-07T17:28:08 <phantomcircuit> that means changing a bunch of the logic for serialize/deserialize
2552020-06-07T17:28:10 <luke-jr> and refuse to start
2562020-06-07T17:28:40 <phantomcircuit> or i could just map asn's to subnet and it's potentially much less code and compatible...
2572020-06-07T17:28:46 <luke-jr> sipa: there's a checksum to stop corrupted data
2582020-06-07T17:29:05 <luke-jr> phantomcircuit: could make a new type that serialises the same for subnets?
2592020-06-07T17:29:57 <luke-jr> and just serialise ::0/0 followed by AS info for anAS ban
2602020-06-07T17:30:08 <luke-jr> the checksum should stop it from loading that as ::0/0 in old versions
2612020-06-07T17:30:57 <luke-jr> (possibly stored as ::ASN/0 in memory to avoid wasting extra RAM
2622020-06-07T17:30:58 <sipa> phantomcircuit: i'll have a look at making the ser/deser code more upgradable
2632020-06-07T17:32:14 <phantomcircuit> sipa, the addrdb and bandb share the ser/deser logic to do this they probably just need to be split
2642020-06-07T17:32:36 <sipa> phantomcircuit: perhaps
2652020-06-07T17:32:49 <sipa> phantomcircuit: std::map is serialized with a size prefix
2662020-06-07T17:33:07 <sipa> so we could change the serialization to stary with a giant number
2672020-06-07T17:33:15 <sipa> to indicate a new version
2682020-06-07T17:33:26 <sipa> so that it will fail to load on old versions
2692020-06-07T17:33:32 <sipa> *start
2702020-06-07T17:34:22 <phantomcircuit> just start with a dummy db that has a bad checksum
2712020-06-07T17:34:36 <sipa> that's also possible
2722020-06-07T17:35:33 <phantomcircuit> that seems like it would be more obvious
2732020-06-07T17:35:55 *** XORder has quit IRC
2742020-06-07T17:37:23 <phantomcircuit> also changing banmap_t is going to effect a whole bunch of logic
2752020-06-07T17:38:05 <sipa> i know
2762020-06-07T17:38:26 <sipa> but that code is due for a cleanup anyway, o think
2772020-06-07T17:39:36 <sipa> *i
2782020-06-07T17:40:44 <luke-jr> â¦
2792020-06-07T17:41:33 <luke-jr> these all sound much more complex than what I just suggested :P
2802020-06-07T17:42:20 <sipa> which is?
2812020-06-07T17:45:52 <luke-jr> [17:29:56] <luke-jr> and just serialise ::0/0 followed by AS info for anAS ban
2822020-06-07T17:46:49 <sipa> that won't work
2832020-06-07T17:47:05 <luke-jr> why not?
2842020-06-07T17:47:14 <sipa> it will result in old software reading corrupted datae
2852020-06-07T17:47:20 <luke-jr> which will fail the checksum
2862020-06-07T17:47:49 <sipa> ah, indeed!
2872020-06-07T17:47:58 *** Sylveste has joined #bitcoin-core-dev
2882020-06-07T17:48:18 *** justanotheruser has quit IRC
2892020-06-07T17:48:44 <sipa> so you'd need a new data type instead of CSubNet to use as key in the map
2902020-06-07T17:49:00 <sipa> which can represent either a CSubNet or an ASN
2912020-06-07T17:49:10 <luke-jr> yes
2922020-06-07T17:49:16 <sipa> and csubnet's remain serialized as-is
2932020-06-07T17:49:20 <luke-jr> exactly
2942020-06-07T17:49:37 *** pretyflaco has quit IRC
2952020-06-07T17:49:53 *** pretyflaco has joined #bitcoin-core-dev
2962020-06-07T17:50:17 <sipa> and ASN are serialized as some sentinel value that's unlikely to be already present in banmans (::0/0 seems right as luke-jr suggests) + version number + ASN
2972020-06-07T17:50:38 *** Sylveste has quit IRC
2982020-06-07T17:51:00 <luke-jr> I mean, we could use the CSubNet part for ASN data too, so long as we don't end up with the same length
2992020-06-07T17:51:20 <sipa> it needs to be recognizable as an AS entry to the deserializer
3002020-06-07T17:51:47 <sipa> CSubNets do not have an explicit length in their serialization afaik
3012020-06-07T17:52:04 <luke-jr> ah
3022020-06-07T17:59:12 <phantomcircuit> uh whuch checksum would that fail?
3032020-06-07T17:59:37 <phantomcircuit> i dont see any reason that would fail the checksum in DeserializeDB
3042020-06-07T18:00:01 *** k0da has quit IRC
3052020-06-07T18:00:35 <sipa> phantomcircuit: because the data deserialized wouldn't match
3062020-06-07T18:00:44 <sipa> so it would read a checksum in the wrong place
3072020-06-07T18:01:48 <phantomcircuit> i mean we can just append the asn stuff then and the checksum will be wrong that way to
3082020-06-07T18:02:36 <sipa> yes, but how would a deserializer notice that there is more stuff to follow?
3092020-06-07T18:02:50 <sipa> it would need to distinguish ban entries from the checksum...
3102020-06-07T18:05:43 <phantomcircuit> start/data/data/hash and try to read data as both a hash and a map of asns
3112020-06-07T18:06:51 <sipa> that's pretty ugly i think, but yes it will work
3122020-06-07T18:06:59 <sipa> i think it's a bigger change
3132020-06-07T18:08:38 *** justanotheruser has joined #bitcoin-core-dev
3142020-06-07T18:09:34 <phantomcircuit> sipa, could equally just have v1/v2 deserializers
3152020-06-07T18:09:59 <sipa> phantomcircuit: and try both?
3162020-06-07T18:10:03 <phantomcircuit> yeah
3172020-06-07T18:10:45 <sipa> well, see it this way: i think you're going to need a data type that represents "subnet or ASN" anyway, to put in the banmap map as key
3182020-06-07T18:11:20 <sipa> if you give that data type a serialization that's identical to a subnet's for subsets, and to some sentinal + ASN for asns, you have no other serialization issues
3192020-06-07T18:12:07 *** Pavlenex has joined #bitcoin-core-dev
3202020-06-07T18:12:48 <sipa> *sentinel
3212020-06-07T18:14:23 <phantomcircuit> yeah that's a good point
3222020-06-07T18:14:58 <phantomcircuit> why is it `using banman_t = std::map...` and not a typedef ?
3232020-06-07T18:15:36 <sipa> using is the newer syntax
3242020-06-07T18:15:44 <sipa> it does the same as a typedef, but is more flexible
3252020-06-07T18:16:50 <sipa> https://stackoverflow.com/questions/10747810/what-is-the-difference-between-typedef-and-using-in-c11
3262020-06-07T18:20:01 <phantomcircuit> ok so they can still be templated where typedef cannot be
3272020-06-07T18:20:02 <phantomcircuit> interesting
3282020-06-07T18:20:14 *** Pavlenex has quit IRC
3292020-06-07T18:22:09 *** Bille has joined #bitcoin-core-dev
3302020-06-07T18:24:14 <phantomcircuit> sipa, oh CSubNet has a bool is valid flag
3312020-06-07T18:24:29 *** davterra has quit IRC
3322020-06-07T18:25:35 *** davterra has joined #bitcoin-core-dev
3332020-06-07T18:25:49 <sipa> oh, and it's serialized!
3342020-06-07T18:37:54 <sipa> so all you need to do is serialize ASN entries as something that gets read as valid=false by old nodes, and has a different length
3352020-06-07T18:39:15 *** jonatack has joined #bitcoin-core-dev
3362020-06-07T18:43:01 *** jonatack has quit IRC
3372020-06-07T18:44:01 *** jonatack has joined #bitcoin-core-dev
3382020-06-07T18:47:21 *** DeanGuss has joined #bitcoin-core-dev
3392020-06-07T19:02:27 *** davterra has quit IRC
3402020-06-07T19:06:52 *** Talkless has quit IRC
3412020-06-07T19:07:36 <luke-jr> nice
3422020-06-07T19:11:37 *** justanotheruser has quit IRC
3432020-06-07T19:20:54 *** owowo has quit IRC
3442020-06-07T19:22:22 *** adiabat has quit IRC
3452020-06-07T19:22:49 <phantomcircuit> CSubNetOrAsn ?
3462020-06-07T19:23:04 <phantomcircuit> CNetworkBlock?
3472020-06-07T19:23:05 <sipa> BanMatch ?
3482020-06-07T19:23:09 <phantomcircuit> im bad at naming things
3492020-06-07T19:23:13 <sipa> (no more C prefix for classes)
3502020-06-07T19:23:37 <phantomcircuit> banmatch is good
3512020-06-07T19:24:25 <phantomcircuit> asn's are being represented just as a 32bit number right
3522020-06-07T19:24:56 <sipa> yeah
3532020-06-07T19:25:51 *** owowo has joined #bitcoin-core-dev
3542020-06-07T19:25:52 *** owowo has joined #bitcoin-core-dev
3552020-06-07T19:30:09 *** promag has joined #bitcoin-core-dev
3562020-06-07T19:30:40 *** EagleTM has joined #bitcoin-core-dev
3572020-06-07T19:32:08 *** jarthur has joined #bitcoin-core-dev
3582020-06-07T20:06:37 *** bitdex has quit IRC
3592020-06-07T20:06:46 *** guest534543 has joined #bitcoin-core-dev
3602020-06-07T20:07:00 *** sanket1729 has quit IRC
3612020-06-07T20:07:32 *** bitdex has joined #bitcoin-core-dev
3622020-06-07T20:08:10 *** sanket1729 has joined #bitcoin-core-dev
3632020-06-07T20:09:14 *** Kiminuo has quit IRC
3642020-06-07T20:09:46 *** EagleTM has quit IRC
3652020-06-07T20:21:19 *** jonatack_ has joined #bitcoin-core-dev
3662020-06-07T20:21:51 *** jonatack has quit IRC
3672020-06-07T20:24:11 *** bitcoin-git has joined #bitcoin-core-dev
3682020-06-07T20:24:12 <bitcoin-git> [bitcoin] practicalswift opened pull request #19203: tests/net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket. Add thin SOCKET wrapper. (master...fuzzers-Socks5) https://github.com/bitcoin/bitcoin/pull/19203
3692020-06-07T20:24:13 *** bitcoin-git has left #bitcoin-core-dev
3702020-06-07T20:24:39 *** promag has quit IRC
3712020-06-07T20:25:33 *** jarthur_ has joined #bitcoin-core-dev
3722020-06-07T20:28:57 *** jarthur has quit IRC
3732020-06-07T20:51:49 *** ppisati has quit IRC
3742020-06-07T20:58:26 *** ppisati has joined #bitcoin-core-dev
3752020-06-07T21:00:02 *** Bille has quit IRC
3762020-06-07T21:06:45 *** jarthur has joined #bitcoin-core-dev
3772020-06-07T21:10:19 *** jarthur_ has quit IRC
3782020-06-07T21:13:22 *** jeremyrubin has joined #bitcoin-core-dev
3792020-06-07T21:21:00 *** filchef has quit IRC
3802020-06-07T21:22:00 *** kaeru has joined #bitcoin-core-dev
3812020-06-07T21:23:11 *** EagleTM has joined #bitcoin-core-dev
3822020-06-07T21:25:39 *** AaronvanW has quit IRC
3832020-06-07T21:27:20 *** Chris_Stewart_5 has quit IRC
3842020-06-07T21:29:11 *** justanotheruser has joined #bitcoin-core-dev
3852020-06-07T21:31:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3862020-06-07T21:33:05 *** davterra has joined #bitcoin-core-dev
3872020-06-07T21:39:18 *** Guyver2 has quit IRC
3882020-06-07T21:48:14 *** dviola has joined #bitcoin-core-dev
3892020-06-07T21:48:58 *** davterra has quit IRC
3902020-06-07T21:51:50 *** ilu has joined #bitcoin-core-dev
3912020-06-07T21:52:07 *** davterra has joined #bitcoin-core-dev
3922020-06-07T21:53:23 *** ctrlbreak_MAD has quit IRC
3932020-06-07T21:53:51 *** baldur has quit IRC
3942020-06-07T21:53:52 *** tryphe has quit IRC
3952020-06-07T21:53:52 *** meshcollider has quit IRC
3962020-06-07T21:53:52 *** NicolasDorier has quit IRC
3972020-06-07T21:53:52 *** digi_james has quit IRC
3982020-06-07T21:53:52 *** valwal_ has quit IRC
3992020-06-07T21:53:52 *** fanquake has quit IRC
4002020-06-07T21:53:52 *** peltre has quit IRC
4012020-06-07T21:53:52 *** bosma has quit IRC
4022020-06-07T21:53:52 *** provoostenator has quit IRC
4032020-06-07T21:53:52 *** nullptr| has quit IRC
4042020-06-07T21:54:09 *** baldur has joined #bitcoin-core-dev
4052020-06-07T21:54:09 *** tryphe has joined #bitcoin-core-dev
4062020-06-07T21:54:09 *** meshcollider has joined #bitcoin-core-dev
4072020-06-07T21:54:09 *** NicolasDorier has joined #bitcoin-core-dev
4082020-06-07T21:54:09 *** digi_james has joined #bitcoin-core-dev
4092020-06-07T21:54:09 *** valwal_ has joined #bitcoin-core-dev
4102020-06-07T21:54:09 *** fanquake has joined #bitcoin-core-dev
4112020-06-07T21:54:09 *** peltre has joined #bitcoin-core-dev
4122020-06-07T21:54:09 *** bosma has joined #bitcoin-core-dev
4132020-06-07T21:54:09 *** provoostenator has joined #bitcoin-core-dev
4142020-06-07T21:54:09 *** nullptr| has joined #bitcoin-core-dev
4152020-06-07T21:54:25 *** ilu has quit IRC
4162020-06-07T21:54:32 *** peltre has quit IRC
4172020-06-07T21:54:33 *** ilu has joined #bitcoin-core-dev
4182020-06-07T21:55:09 *** takinbo has quit IRC
4192020-06-07T21:55:09 *** asoltys has quit IRC
4202020-06-07T21:55:09 *** isis_ has quit IRC
4212020-06-07T21:55:09 *** a5m0_ has quit IRC
4222020-06-07T21:55:09 *** hadjiszs_ has quit IRC
4232020-06-07T21:55:09 *** enasigurd_ has quit IRC
4242020-06-07T21:55:09 *** DougieBot5000 has quit IRC
4252020-06-07T21:55:09 *** hex17or has quit IRC
4262020-06-07T21:55:09 *** esotericnonsense has quit IRC
4272020-06-07T21:55:10 *** CubicEarth has quit IRC
4282020-06-07T21:55:10 *** tripleslash has quit IRC
4292020-06-07T21:55:10 *** MarcoFalke has quit IRC
4302020-06-07T21:55:10 *** waxwing has quit IRC
4312020-06-07T21:55:10 *** jnewbery has quit IRC
4322020-06-07T21:55:10 *** tynes_ has quit IRC
4332020-06-07T21:55:10 *** GAit has quit IRC
4342020-06-07T21:55:10 *** wraithm has quit IRC
4352020-06-07T21:55:10 *** IPGlider has quit IRC
4362020-06-07T21:55:28 *** takinbo has joined #bitcoin-core-dev
4372020-06-07T21:55:28 *** asoltys has joined #bitcoin-core-dev
4382020-06-07T21:55:28 *** isis_ has joined #bitcoin-core-dev
4392020-06-07T21:55:28 *** a5m0_ has joined #bitcoin-core-dev
4402020-06-07T21:55:28 *** hadjiszs_ has joined #bitcoin-core-dev
4412020-06-07T21:55:28 *** enasigurd_ has joined #bitcoin-core-dev
4422020-06-07T21:55:28 *** DougieBot5000 has joined #bitcoin-core-dev
4432020-06-07T21:55:28 *** hex17or has joined #bitcoin-core-dev
4442020-06-07T21:55:28 *** esotericnonsense has joined #bitcoin-core-dev
4452020-06-07T21:55:28 *** CubicEarth has joined #bitcoin-core-dev
4462020-06-07T21:55:28 *** tripleslash has joined #bitcoin-core-dev
4472020-06-07T21:55:28 *** MarcoFalke has joined #bitcoin-core-dev
4482020-06-07T21:55:28 *** waxwing has joined #bitcoin-core-dev
4492020-06-07T21:55:28 *** jnewbery has joined #bitcoin-core-dev
4502020-06-07T21:55:28 *** tynes_ has joined #bitcoin-core-dev
4512020-06-07T21:55:28 *** GAit has joined #bitcoin-core-dev
4522020-06-07T21:55:28 *** wraithm has joined #bitcoin-core-dev
4532020-06-07T21:55:28 *** IPGlider has joined #bitcoin-core-dev
4542020-06-07T21:55:45 *** esotericnonsense has quit IRC
4552020-06-07T21:55:49 *** Chris_Stewart_5 has quit IRC
4562020-06-07T21:56:02 *** mrostecki[m] has quit IRC
4572020-06-07T21:56:15 *** esotericnonsense has joined #bitcoin-core-dev
4582020-06-07T21:56:16 *** mrostecki[m] has joined #bitcoin-core-dev
4592020-06-07T21:56:37 *** TheFuzzStone[m] has quit IRC
4602020-06-07T21:56:38 *** jorijn has quit IRC
4612020-06-07T21:56:40 *** windsok has quit IRC
4622020-06-07T21:56:44 *** davterra has quit IRC
4632020-06-07T21:56:48 *** mrostecki[m] has quit IRC
4642020-06-07T21:57:15 *** shesek has quit IRC
4652020-06-07T21:57:38 *** tryphe has quit IRC
4662020-06-07T21:57:51 *** shesek has joined #bitcoin-core-dev
4672020-06-07T21:57:53 *** mmitech_ has quit IRC
4682020-06-07T21:57:53 *** nejon has quit IRC
4692020-06-07T21:57:53 *** kinlo has quit IRC
4702020-06-07T21:57:59 *** tryphe has joined #bitcoin-core-dev
4712020-06-07T21:58:10 *** mmitech_ has joined #bitcoin-core-dev
4722020-06-07T21:58:10 *** nejon has joined #bitcoin-core-dev
4732020-06-07T21:58:10 *** kinlo has joined #bitcoin-core-dev
4742020-06-07T21:58:27 *** windsok has joined #bitcoin-core-dev
4752020-06-07T21:58:29 *** windsok has joined #bitcoin-core-dev
4762020-06-07T21:58:32 *** jorijn has joined #bitcoin-core-dev
4772020-06-07T21:58:32 *** thaumavorio has quit IRC
4782020-06-07T21:58:33 *** z3232 has quit IRC
4792020-06-07T21:58:33 *** Henry151 has quit IRC
4802020-06-07T21:58:33 *** wullon5 has quit IRC
4812020-06-07T21:58:33 *** luke-jr has quit IRC
4822020-06-07T21:58:33 *** Lightsword has quit IRC
4832020-06-07T21:58:33 *** willcl_ark has quit IRC
4842020-06-07T21:58:33 *** instagibbs has quit IRC
4852020-06-07T21:58:33 *** bsm117532 has quit IRC
4862020-06-07T21:58:33 *** chjj has quit IRC
4872020-06-07T21:58:33 *** rhiaro has quit IRC
4882020-06-07T21:58:33 *** raj_149 has quit IRC
4892020-06-07T21:58:33 *** hirish_ has quit IRC
4902020-06-07T21:58:33 *** dlb76 has quit IRC
4912020-06-07T21:58:34 *** gwillen has quit IRC
4922020-06-07T21:58:34 *** sturles has quit IRC
4932020-06-07T21:58:34 *** wxss has quit IRC
4942020-06-07T21:58:34 *** earlz has quit IRC
4952020-06-07T21:58:34 *** balbirs has quit IRC
4962020-06-07T21:59:38 *** z3232 has joined #bitcoin-core-dev
4972020-06-07T21:59:38 *** thaumavorio has joined #bitcoin-core-dev
4982020-06-07T21:59:38 *** Henry151 has joined #bitcoin-core-dev
4992020-06-07T21:59:38 *** wullon5 has joined #bitcoin-core-dev
5002020-06-07T21:59:38 *** luke-jr has joined #bitcoin-core-dev
5012020-06-07T21:59:38 *** Lightsword has joined #bitcoin-core-dev
5022020-06-07T21:59:38 *** willcl_ark has joined #bitcoin-core-dev
5032020-06-07T21:59:38 *** instagibbs has joined #bitcoin-core-dev
5042020-06-07T21:59:38 *** bsm117532 has joined #bitcoin-core-dev
5052020-06-07T21:59:38 *** chjj has joined #bitcoin-core-dev
5062020-06-07T21:59:38 *** rhiaro has joined #bitcoin-core-dev
5072020-06-07T21:59:38 *** raj_149 has joined #bitcoin-core-dev
5082020-06-07T21:59:38 *** hirish_ has joined #bitcoin-core-dev
5092020-06-07T21:59:38 *** dlb76 has joined #bitcoin-core-dev
5102020-06-07T21:59:38 *** gwillen has joined #bitcoin-core-dev
5112020-06-07T21:59:38 *** sturles has joined #bitcoin-core-dev
5122020-06-07T21:59:38 *** wxss has joined #bitcoin-core-dev
5132020-06-07T21:59:38 *** earlz has joined #bitcoin-core-dev
5142020-06-07T21:59:38 *** balbirs has joined #bitcoin-core-dev
5152020-06-07T22:00:02 *** davterra has joined #bitcoin-core-dev
5162020-06-07T22:00:04 *** Bullit has quit IRC
5172020-06-07T22:00:05 *** Henry151 has quit IRC
5182020-06-07T22:01:07 *** Bullit has joined #bitcoin-core-dev
5192020-06-07T22:01:12 *** Henry151 has joined #bitcoin-core-dev
5202020-06-07T22:01:51 *** peltre has joined #bitcoin-core-dev
5212020-06-07T22:09:30 *** guest534543 has quit IRC
5222020-06-07T22:19:43 *** TheFuzzStone[m] has joined #bitcoin-core-dev
5232020-06-07T22:22:29 *** mrostecki[m] has joined #bitcoin-core-dev
5242020-06-07T22:33:32 *** promag has joined #bitcoin-core-dev
5252020-06-07T22:55:06 *** kvaciral has quit IRC
5262020-06-07T23:04:02 *** jarthur has quit IRC
5272020-06-07T23:04:33 *** jarthur has joined #bitcoin-core-dev
5282020-06-07T23:10:30 *** Randolf has joined #bitcoin-core-dev
5292020-06-07T23:35:46 *** proofofkeags has joined #bitcoin-core-dev
5302020-06-07T23:45:14 *** rafalcpp has joined #bitcoin-core-dev
5312020-06-07T23:50:58 *** mol has quit IRC
5322020-06-07T23:51:32 *** mol has joined #bitcoin-core-dev
5332020-06-07T23:51:37 *** proofofkeags has quit IRC
5342020-06-07T23:52:10 *** proofofkeags has joined #bitcoin-core-dev
5352020-06-07T23:53:00 *** bitcoin-git has joined #bitcoin-core-dev
5362020-06-07T23:53:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19204: p2p: Reduce inv traffic during IBD (master...2006-netInvWaste) https://github.com/bitcoin/bitcoin/pull/19204
5372020-06-07T23:53:11 *** bitcoin-git has left #bitcoin-core-dev
5382020-06-07T23:56:38 *** proofofkeags has quit IRC