12020-06-08T00:00:01 *** kaeru has quit IRC
22020-06-08T00:31:50 *** dviola has quit IRC
32020-06-08T00:33:51 *** proofofkeags has joined #bitcoin-core-dev
42020-06-08T00:35:20 *** proofofkeags has quit IRC
52020-06-08T00:35:56 *** proofofkeags has joined #bitcoin-core-dev
62020-06-08T00:40:26 *** proofofkeags has quit IRC
72020-06-08T00:43:45 *** Randolf has quit IRC
82020-06-08T00:57:16 *** hack_bot has joined #bitcoin-core-dev
92020-06-08T01:01:26 *** bitcoin-git has joined #bitcoin-core-dev
102020-06-08T01:01:26 <bitcoin-git> [bitcoin] bliotti opened pull request #19205: script: previous_release.sh rewritten in python (master...previous-release-py) https://github.com/bitcoin/bitcoin/pull/19205
112020-06-08T01:01:27 *** bitcoin-git has left #bitcoin-core-dev
122020-06-08T01:05:07 *** Zenton has quit IRC
132020-06-08T01:05:32 *** Zenton has joined #bitcoin-core-dev
142020-06-08T01:06:18 *** Relis has quit IRC
152020-06-08T01:08:31 *** Chris_Stewart_5 has joined #bitcoin-core-dev
162020-06-08T01:16:03 <phantomcircuit> currently the ScanForWalletTransactions function handles keypool TopUp implicitly, since it's checking every output with the Solver, i'd like to have the wallet set a flag when the keypool has been topped up and just do the entire scan again until it's not topping up anymore
172020-06-08T01:16:30 <phantomcircuit> for the current logic this wouldn't be good, but using block filter indexes with per node siphash parameters it wouldn't be that bad
182020-06-08T01:17:13 <phantomcircuit> doing this would make handling having different sets of filters much easier, that way i can just as the chain implementation for blocks it thinks match against a list of script pubkeys
192020-06-08T01:17:26 <phantomcircuit> instead of having all the chain walking logic in the wallet
202020-06-08T01:18:41 *** Chris_Stewart_5 has quit IRC
212020-06-08T01:19:50 *** Relis has joined #bitcoin-core-dev
222020-06-08T01:41:29 *** Relis has quit IRC
232020-06-08T01:45:10 *** promag has quit IRC
242020-06-08T01:45:28 *** jarthur has quit IRC
252020-06-08T01:46:10 <phantomcircuit> MarcoFalke, ^ any opinion?
262020-06-08T01:55:46 *** proofofkeags has joined #bitcoin-core-dev
272020-06-08T02:01:15 *** proofofkeags has quit IRC
282020-06-08T02:01:47 *** proofofkeags has joined #bitcoin-core-dev
292020-06-08T02:06:18 *** proofofkeags has quit IRC
302020-06-08T02:08:38 *** rafalcpp has quit IRC
312020-06-08T02:11:30 *** Relis has joined #bitcoin-core-dev
322020-06-08T02:16:16 *** mrostecki has quit IRC
332020-06-08T02:26:28 *** mrostecki has joined #bitcoin-core-dev
342020-06-08T02:27:04 *** Relis has quit IRC
352020-06-08T03:00:02 *** hack_bot has quit IRC
362020-06-08T03:19:58 *** Eagle[TM] has joined #bitcoin-core-dev
372020-06-08T03:20:34 *** Leo-WAC-WAC has joined #bitcoin-core-dev
382020-06-08T03:21:53 *** EagleTM has quit IRC
392020-06-08T04:06:19 *** jarthur has joined #bitcoin-core-dev
402020-06-08T04:10:04 *** troygiorshev has joined #bitcoin-core-dev
412020-06-08T04:23:43 *** vasild has quit IRC
422020-06-08T04:25:30 *** vasild has joined #bitcoin-core-dev
432020-06-08T04:41:42 *** mol_ has joined #bitcoin-core-dev
442020-06-08T04:43:25 <phantomcircuit> also i noticed that absolutely everything that calls ScanForWalletTransactions looks up the block hash by height just before calling it
452020-06-08T04:45:50 *** mol has quit IRC
462020-06-08T04:47:49 *** molz_ has joined #bitcoin-core-dev
472020-06-08T04:48:00 *** bitdex has quit IRC
482020-06-08T04:48:25 *** bitdex has joined #bitcoin-core-dev
492020-06-08T04:49:27 *** Randolf has joined #bitcoin-core-dev
502020-06-08T04:51:50 *** mol_ has quit IRC
512020-06-08T04:55:45 *** tryphe has quit IRC
522020-06-08T05:01:20 *** tryphe has joined #bitcoin-core-dev
532020-06-08T05:03:38 <sipa> phantomcircuit: if it's through CChain, that's O(1) thankfully
542020-06-08T05:05:02 *** troygiorshev has quit IRC
552020-06-08T05:07:37 *** TheHoliestRoger has quit IRC
562020-06-08T05:09:55 *** TheHoliestRoger has joined #bitcoin-core-dev
572020-06-08T05:11:05 <phantomcircuit> sipa, yeah just saying there's no reason for it to have the weird block_hash/block_height dual argument
582020-06-08T05:13:08 <sipa> ah
592020-06-08T05:16:33 <phantomcircuit> it also simplifies the handling of the reorg stuff if the first block can't be a reorg
602020-06-08T05:17:57 <luke-jr> trying to think of a case where you'd want to use a non-main-chain block, but can't :/
612020-06-08T05:19:53 <phantomcircuit> yeah neither can i
622020-06-08T05:34:17 *** S3RK has joined #bitcoin-core-dev
632020-06-08T05:36:18 *** jarthur has quit IRC
642020-06-08T05:48:25 *** bitcoin-git has joined #bitcoin-core-dev
652020-06-08T05:48:26 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b3091b2be7d1...807b9f811479
662020-06-08T05:48:26 <bitcoin-git> bitcoin/master fa16e78 MarcoFalke: build: Add -Wshadow-field
672020-06-08T05:48:27 <bitcoin-git> bitcoin/master fac6b9b MarcoFalke: test: Avoid overwriting the NodeContext member of the testing setup
682020-06-08T05:48:27 <bitcoin-git> bitcoin/master 807b9f8 fanquake: Merge #19188: test: Avoid overwriting the NodeContext member of the testin...
692020-06-08T05:48:28 *** bitcoin-git has left #bitcoin-core-dev
702020-06-08T05:48:45 *** bitcoin-git has joined #bitcoin-core-dev
712020-06-08T05:48:46 <bitcoin-git> [bitcoin] fanquake merged pull request #19188: test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field] (master...2006-testNoShadowField) https://github.com/bitcoin/bitcoin/pull/19188
722020-06-08T05:48:50 *** bitcoin-git has left #bitcoin-core-dev
732020-06-08T05:53:20 *** Relis has joined #bitcoin-core-dev
742020-06-08T05:55:03 *** Relis has quit IRC
752020-06-08T05:55:34 *** S3RK has quit IRC
762020-06-08T05:56:01 *** S3RK has joined #bitcoin-core-dev
772020-06-08T06:00:02 *** Leo-WAC-WAC has quit IRC
782020-06-08T06:00:23 *** jorijn has quit IRC
792020-06-08T06:02:30 *** jorijn has joined #bitcoin-core-dev
802020-06-08T06:21:54 *** matp has joined #bitcoin-core-dev
812020-06-08T06:55:04 *** Pavlenex has joined #bitcoin-core-dev
822020-06-08T07:13:28 *** MasterdonX has joined #bitcoin-core-dev
832020-06-08T07:13:59 *** masterdonx2 has quit IRC
842020-06-08T07:45:59 *** Pavlenex has quit IRC
852020-06-08T07:52:26 *** S3RK has quit IRC
862020-06-08T07:52:32 *** S3RK has joined #bitcoin-core-dev
872020-06-08T08:05:38 *** Highway61 has quit IRC
882020-06-08T08:07:43 *** jonatack_ has quit IRC
892020-06-08T08:13:07 *** pretyflaco has quit IRC
902020-06-08T08:16:52 *** kljasdfvv has joined #bitcoin-core-dev
912020-06-08T08:23:36 *** jonatack has joined #bitcoin-core-dev
922020-06-08T08:23:56 <TheHoliestRoger> sipa can i pm you?
932020-06-08T08:27:04 *** Pavlenex has joined #bitcoin-core-dev
942020-06-08T08:42:41 *** Pavlenex has quit IRC
952020-06-08T08:57:32 *** jorijn has quit IRC
962020-06-08T08:57:57 *** jorijn has joined #bitcoin-core-dev
972020-06-08T09:00:01 *** matp has quit IRC
982020-06-08T09:01:59 *** rafalcpp has joined #bitcoin-core-dev
992020-06-08T09:08:17 *** riordant has joined #bitcoin-core-dev
1002020-06-08T09:08:54 *** BGL has quit IRC
1012020-06-08T09:21:38 *** hggdh1 has joined #bitcoin-core-dev
1022020-06-08T09:27:22 *** promag has joined #bitcoin-core-dev
1032020-06-08T09:27:44 <promag> Can I request a gitian build for #18790?
1042020-06-08T09:27:46 <gribble> https://github.com/bitcoin/bitcoin/issues/18790 | gui: Improve thread naming by hebasto · Pull Request #18790 · bitcoin/bitcoin · GitHub
1052020-06-08T09:31:58 *** S3RK has quit IRC
1062020-06-08T09:47:08 <fanquake> promag: done
1072020-06-08T09:48:51 <promag> ty!
1082020-06-08T09:54:35 *** Victorsueca has joined #bitcoin-core-dev
1092020-06-08T09:54:42 *** Deinogalerix21 has joined #bitcoin-core-dev
1102020-06-08T09:55:08 *** Deinogalerix21 has quit IRC
1112020-06-08T10:03:20 *** Anabel19Hilpert has joined #bitcoin-core-dev
1122020-06-08T10:07:10 *** S3RK has joined #bitcoin-core-dev
1132020-06-08T10:07:54 *** Anabel19Hilpert has quit IRC
1142020-06-08T10:12:07 *** S3RK has quit IRC
1152020-06-08T10:21:50 *** jeremyrubin has quit IRC
1162020-06-08T10:21:52 *** S3RK has joined #bitcoin-core-dev
1172020-06-08T10:26:00 *** Relis has joined #bitcoin-core-dev
1182020-06-08T10:28:21 *** Relis has quit IRC
1192020-06-08T10:33:03 *** Relis has joined #bitcoin-core-dev
1202020-06-08T10:39:37 *** BGL has joined #bitcoin-core-dev
1212020-06-08T10:48:02 *** jeremyrubin has joined #bitcoin-core-dev
1222020-06-08T10:57:23 *** bitcoin-git has joined #bitcoin-core-dev
1232020-06-08T10:57:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/807b9f811479...399a0d9dc7a1
1242020-06-08T10:57:24 <bitcoin-git> bitcoin/master 1a9ef1d Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in Shutdown()
1252020-06-08T10:57:24 <bitcoin-git> bitcoin/master 399a0d9 MarcoFalke: Merge #19180: refactor: Replace RecursiveMutex with Mutex in Shutdown()
1262020-06-08T10:57:26 *** bitcoin-git has left #bitcoin-core-dev
1272020-06-08T10:57:43 *** bitcoin-git has joined #bitcoin-core-dev
1282020-06-08T10:57:43 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19180: refactor: Replace RecursiveMutex with Mutex in Shutdown() (master...200605-shutdown) https://github.com/bitcoin/bitcoin/pull/19180
1292020-06-08T10:57:44 *** bitcoin-git has left #bitcoin-core-dev
1302020-06-08T11:03:40 *** bitcoin-git has joined #bitcoin-core-dev
1312020-06-08T11:03:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/399a0d9dc7a1...8496dbeba687
1322020-06-08T11:03:41 <bitcoin-git> bitcoin/master 78c8f4f Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in netbase.cpp
1332020-06-08T11:03:41 <bitcoin-git> bitcoin/master 8496dbe MarcoFalke: Merge #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp
1342020-06-08T11:03:43 *** bitcoin-git has left #bitcoin-core-dev
1352020-06-08T11:04:00 *** bitcoin-git has joined #bitcoin-core-dev
1362020-06-08T11:04:00 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp (master...200606-netbase) https://github.com/bitcoin/bitcoin/pull/19190
1372020-06-08T11:04:01 *** bitcoin-git has left #bitcoin-core-dev
1382020-06-08T11:06:48 *** bitcoin-git has joined #bitcoin-core-dev
1392020-06-08T11:06:49 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8496dbeba687...374fd6fc8b4c
1402020-06-08T11:06:50 <bitcoin-git> bitcoin/master c2410ce Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in timedata.cpp
1412020-06-08T11:06:50 <bitcoin-git> bitcoin/master cc5c0d2 Hennadii Stepanov: refactor: Fix formatting of timedata.cpp
1422020-06-08T11:06:50 <bitcoin-git> bitcoin/master 374fd6f MarcoFalke: Merge #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp
1432020-06-08T11:06:52 *** bitcoin-git has left #bitcoin-core-dev
1442020-06-08T11:07:08 *** bitcoin-git has joined #bitcoin-core-dev
1452020-06-08T11:07:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp (master...200605-timedata) https://github.com/bitcoin/bitcoin/pull/19189
1462020-06-08T11:07:09 *** bitcoin-git has left #bitcoin-core-dev
1472020-06-08T11:13:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1482020-06-08T11:13:17 *** justanotheruser has quit IRC
1492020-06-08T11:13:23 *** shesek has quit IRC
1502020-06-08T11:19:19 *** Chris_Stewart_5 has quit IRC
1512020-06-08T11:19:23 *** S3RK has quit IRC
1522020-06-08T11:19:49 *** S3RK has joined #bitcoin-core-dev
1532020-06-08T11:22:08 *** Relis has quit IRC
1542020-06-08T11:22:56 *** AaronvanW has joined #bitcoin-core-dev
1552020-06-08T11:24:27 *** S3RK has quit IRC
1562020-06-08T11:24:31 *** Deinogalerix21 has joined #bitcoin-core-dev
1572020-06-08T11:25:15 *** Deinogalerix21 has joined #bitcoin-core-dev
1582020-06-08T11:27:55 *** S3RK has joined #bitcoin-core-dev
1592020-06-08T11:29:36 *** bitcoin-git has joined #bitcoin-core-dev
1602020-06-08T11:29:36 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/374fd6fc8b4c...41fb69404c03
1612020-06-08T11:29:37 <bitcoin-git> bitcoin/master fa2c2b5 MarcoFalke: doc: Extract net permissions doc
1622020-06-08T11:29:37 <bitcoin-git> bitcoin/master 41fb694 MarcoFalke: Merge #19192: doc: Extract net permissions doc
1632020-06-08T11:29:39 *** bitcoin-git has left #bitcoin-core-dev
1642020-06-08T11:29:56 *** bitcoin-git has joined #bitcoin-core-dev
1652020-06-08T11:29:56 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19192: doc: Extract net permissions doc (master...2006-docNetPerm) https://github.com/bitcoin/bitcoin/pull/19192
1662020-06-08T11:29:57 *** bitcoin-git has left #bitcoin-core-dev
1672020-06-08T11:30:14 *** Deinogalerix21 has quit IRC
1682020-06-08T11:36:55 *** bitcoin-git has joined #bitcoin-core-dev
1692020-06-08T11:36:56 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/41fb69404c03...9573d2b55b45
1702020-06-08T11:36:56 <bitcoin-git> bitcoin/master cb38b06 MIZUTA Takeshi: util: Don't reference errno when pthread fails.
1712020-06-08T11:36:57 <bitcoin-git> bitcoin/master 9573d2b fanquake: Merge #19194: util: Don't reference errno when pthread fails.
1722020-06-08T11:36:59 *** bitcoin-git has left #bitcoin-core-dev
1732020-06-08T11:37:04 *** S3RK has quit IRC
1742020-06-08T11:37:15 *** bitcoin-git has joined #bitcoin-core-dev
1752020-06-08T11:37:15 <bitcoin-git> [bitcoin] fanquake merged pull request #19194: util: Don't reference errno when pthread fails. (master...prototype) https://github.com/bitcoin/bitcoin/pull/19194
1762020-06-08T11:37:16 *** bitcoin-git has left #bitcoin-core-dev
1772020-06-08T11:42:52 *** justanotheruser has joined #bitcoin-core-dev
1782020-06-08T11:45:50 *** instagibbs has quit IRC
1792020-06-08T11:46:04 *** instagibbs has joined #bitcoin-core-dev
1802020-06-08T11:50:14 *** bitdex has quit IRC
1812020-06-08T11:55:37 *** Relis has joined #bitcoin-core-dev
1822020-06-08T12:00:01 *** hggdh1 has quit IRC
1832020-06-08T12:06:25 *** shesek has joined #bitcoin-core-dev
1842020-06-08T12:12:18 *** bitcoin-git has joined #bitcoin-core-dev
1852020-06-08T12:12:18 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19206: test: Remove leftover comment in mining_basic (master...2006-testComment) https://github.com/bitcoin/bitcoin/pull/19206
1862020-06-08T12:12:19 *** bitcoin-git has left #bitcoin-core-dev
1872020-06-08T12:19:46 *** troygiorshev has joined #bitcoin-core-dev
1882020-06-08T12:20:03 *** troygiorshev has quit IRC
1892020-06-08T12:20:20 *** troygiorshev has joined #bitcoin-core-dev
1902020-06-08T12:22:14 *** Jaykul1 has joined #bitcoin-core-dev
1912020-06-08T12:27:23 *** Eagle[TM] has quit IRC
1922020-06-08T12:30:47 *** bitcoin-git has joined #bitcoin-core-dev
1932020-06-08T12:30:47 <bitcoin-git> [bitcoin] jonatack opened pull request #19207: doc: -whitelist/-whitebind documentation improvements (master...whitelist-whitebind-doc-improvements) https://github.com/bitcoin/bitcoin/pull/19207
1942020-06-08T12:30:48 *** bitcoin-git has left #bitcoin-core-dev
1952020-06-08T12:35:03 *** riordant has quit IRC
1962020-06-08T12:35:11 *** dr-orlovsky has quit IRC
1972020-06-08T12:53:37 *** S3RK has joined #bitcoin-core-dev
1982020-06-08T12:58:14 *** S3RK has quit IRC
1992020-06-08T13:00:03 *** bitcoin-git has joined #bitcoin-core-dev
2002020-06-08T13:00:03 <bitcoin-git> [bitcoin] ycshao opened pull request #19208: test: move `sync_blocks` and `sync_mempool` functions to `test_framework.py` (master...issue-18930) https://github.com/bitcoin/bitcoin/pull/19208
2012020-06-08T13:00:04 *** bitcoin-git has left #bitcoin-core-dev
2022020-06-08T13:01:11 *** shesek has quit IRC
2032020-06-08T13:02:11 *** jeremyrubin has quit IRC
2042020-06-08T13:02:53 *** Kiminuo has joined #bitcoin-core-dev
2052020-06-08T13:09:00 *** pretyflaco has joined #bitcoin-core-dev
2062020-06-08T13:10:44 *** shesek has joined #bitcoin-core-dev
2072020-06-08T13:10:44 *** shesek has joined #bitcoin-core-dev
2082020-06-08T13:15:09 *** bitcoin-git has joined #bitcoin-core-dev
2092020-06-08T13:15:10 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9573d2b55b45...b3ec1fe8114a
2102020-06-08T13:15:10 <bitcoin-git> bitcoin/master a9bd1f9 Danny Lee: test: warn if nodes not connected before disconnect_nodes
2112020-06-08T13:15:11 <bitcoin-git> bitcoin/master e6e7abd Danny Lee: test: remove redundant two-way disconnect_nodes calls
2122020-06-08T13:15:11 *** pretyflaco has quit IRC
2132020-06-08T13:15:12 <bitcoin-git> bitcoin/master 34e641a Danny Lee: test: Remove unnecessary disconnect_nodes call in rpc_psbt.py
2142020-06-08T13:15:12 *** bitcoin-git has left #bitcoin-core-dev
2152020-06-08T13:15:40 *** bitcoin-git has joined #bitcoin-core-dev
2162020-06-08T13:15:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890
2172020-06-08T13:15:49 *** bitcoin-git has left #bitcoin-core-dev
2182020-06-08T13:28:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2192020-06-08T13:31:22 *** Highway61 has joined #bitcoin-core-dev
2202020-06-08T13:33:06 *** roconnor has joined #bitcoin-core-dev
2212020-06-08T13:35:35 *** Kiminuo has quit IRC
2222020-06-08T13:35:56 *** mol has joined #bitcoin-core-dev
2232020-06-08T13:38:59 *** molz_ has quit IRC
2242020-06-08T13:46:53 *** dr-orlovsky has joined #bitcoin-core-dev
2252020-06-08T13:46:55 *** troygiorshev has quit IRC
2262020-06-08T13:48:29 *** Highway61 has quit IRC
2272020-06-08T13:48:56 *** mol_ has joined #bitcoin-core-dev
2282020-06-08T13:49:06 *** Highway61 has joined #bitcoin-core-dev
2292020-06-08T13:51:24 *** troygiorshev has joined #bitcoin-core-dev
2302020-06-08T13:51:26 *** mol has quit IRC
2312020-06-08T13:56:32 *** bitcoin-git has joined #bitcoin-core-dev
2322020-06-08T13:56:32 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3ec1fe8114a...3e58734e55ee
2332020-06-08T13:56:33 <bitcoin-git> bitcoin/master a9d28af Hennadii Stepanov: qt: Display warnings as rich text
2342020-06-08T13:56:33 <bitcoin-git> bitcoin/master 3e58734 MarcoFalke: Merge #18898: gui: Display warnings as rich text
2352020-06-08T13:56:35 *** bitcoin-git has left #bitcoin-core-dev
2362020-06-08T13:57:02 *** bitcoin-git has joined #bitcoin-core-dev
2372020-06-08T13:57:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
2382020-06-08T13:57:03 *** bitcoin-git has left #bitcoin-core-dev
2392020-06-08T13:58:52 *** bitcoin-git has joined #bitcoin-core-dev
2402020-06-08T13:58:52 <bitcoin-git> [bitcoin] hebasto opened pull request #19210: qt: Get rid of cursor in out-of-focus labels (master...200608-cursor) https://github.com/bitcoin/bitcoin/pull/19210
2412020-06-08T13:58:53 *** bitcoin-git has left #bitcoin-core-dev
2422020-06-08T14:03:47 *** bitcoin-git has joined #bitcoin-core-dev
2432020-06-08T14:03:47 <bitcoin-git> [bitcoin] hebasto closed pull request #14810: qt: Enable tabbing through labels (master...20181124-tab-through-labels) https://github.com/bitcoin/bitcoin/pull/14810
2442020-06-08T14:03:48 *** bitcoin-git has left #bitcoin-core-dev
2452020-06-08T14:05:44 *** proofofkeags has joined #bitcoin-core-dev
2462020-06-08T14:18:13 *** Highway62 has joined #bitcoin-core-dev
2472020-06-08T14:18:29 *** Highway61 has quit IRC
2482020-06-08T14:18:29 *** Highway62 is now known as Highway61
2492020-06-08T14:20:30 *** bitcoin-git has joined #bitcoin-core-dev
2502020-06-08T14:20:31 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e58734e55ee...297466b49ff3
2512020-06-08T14:20:32 <bitcoin-git> bitcoin/master 3e44210 Rod Vagg: Expose txinwitness for coinbase in JSON form
2522020-06-08T14:20:33 <bitcoin-git> bitcoin/master 34645c4 Rod Vagg: Test txinwitness is accessible on coinbase vin
2532020-06-08T14:20:34 <bitcoin-git> bitcoin/master 297466b MarcoFalke: Merge #18826: Expose txinwitness for coinbase in JSON form from RPC
2542020-06-08T14:20:35 *** bitcoin-git has left #bitcoin-core-dev
2552020-06-08T14:21:10 *** bitcoin-git has joined #bitcoin-core-dev
2562020-06-08T14:21:11 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18826: Expose txinwitness for coinbase in JSON form from RPC (master...rvagg/txinwitness-for-coinbase) https://github.com/bitcoin/bitcoin/pull/18826
2572020-06-08T14:21:19 *** bitcoin-git has left #bitcoin-core-dev
2582020-06-08T14:22:20 *** rafalcpp has quit IRC
2592020-06-08T14:24:08 *** Highway62 has joined #bitcoin-core-dev
2602020-06-08T14:24:45 *** rafalcpp has joined #bitcoin-core-dev
2612020-06-08T14:26:53 *** Highway61 has quit IRC
2622020-06-08T14:26:53 *** Highway62 is now known as Highway61
2632020-06-08T14:35:03 *** Deacyde has joined #bitcoin-core-dev
2642020-06-08T14:37:02 *** davterra has quit IRC
2652020-06-08T14:37:24 *** davterra has joined #bitcoin-core-dev
2662020-06-08T14:38:47 *** bitcoin-git has joined #bitcoin-core-dev
2672020-06-08T14:38:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/297466b49ff3...a79bca2f1fb2
2682020-06-08T14:38:48 <bitcoin-git> bitcoin/master b00266f Sebastian Falbesoner: refactor: replace pointers by references within tx_verify.{h,cpp}
2692020-06-08T14:38:49 <bitcoin-git> bitcoin/master a79bca2 MarcoFalke: Merge #19069: refactor: replace pointers by references within tx_verify.{h...
2702020-06-08T14:38:50 *** bitcoin-git has left #bitcoin-core-dev
2712020-06-08T14:39:07 *** bitcoin-git has joined #bitcoin-core-dev
2722020-06-08T14:39:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19069: refactor: replace pointers by references within tx_verify.{h,cpp} (master...20200526-refactor-replace-pointers-by-refs-in-tx_verify) https://github.com/bitcoin/bitcoin/pull/19069
2732020-06-08T14:39:08 *** bitcoin-git has left #bitcoin-core-dev
2742020-06-08T14:43:29 *** adiabat has joined #bitcoin-core-dev
2752020-06-08T14:56:59 *** proofofkeags has quit IRC
2762020-06-08T14:57:35 *** proofofkeags has joined #bitcoin-core-dev
2772020-06-08T15:00:02 *** Jaykul1 has quit IRC
2782020-06-08T15:01:53 *** proofofkeags has quit IRC
2792020-06-08T15:09:48 *** S3RK has joined #bitcoin-core-dev
2802020-06-08T15:09:54 *** pretyflaco has joined #bitcoin-core-dev
2812020-06-08T15:10:07 *** Talkless has joined #bitcoin-core-dev
2822020-06-08T15:14:41 *** S3RK has quit IRC
2832020-06-08T15:18:02 *** Relis has quit IRC
2842020-06-08T15:20:33 *** suriro has joined #bitcoin-core-dev
2852020-06-08T15:31:17 *** Relis has joined #bitcoin-core-dev
2862020-06-08T15:40:58 *** Guyver2 has joined #bitcoin-core-dev
2872020-06-08T15:56:27 *** jeremyrubin has joined #bitcoin-core-dev
2882020-06-08T16:12:09 *** proofofkeags has joined #bitcoin-core-dev
2892020-06-08T16:14:18 <vasild> MarcoFalke: jonatack: the scripts to "filter" a code coverage report: https://github.com/vasild/filter_coverage
2902020-06-08T16:14:53 *** Kiminuo has joined #bitcoin-core-dev
2912020-06-08T16:16:17 <vasild> I also generate an additional report with just the modified and not covered lines: https://people.freebsd.org/~vd/pr19031_coverage_of_modified_code/modified_and_not_covered.html to ease finding them (some source files may begin with 1000s of lines not touched by a change and scrolling to find "bright" lines is not covenient)
2922020-06-08T16:16:23 *** justanotheruser has quit IRC
2932020-06-08T16:19:26 *** Kiminuo has quit IRC
2942020-06-08T16:20:37 *** vasild_ has joined #bitcoin-core-dev
2952020-06-08T16:23:43 *** vasild has quit IRC
2962020-06-08T16:23:44 *** vasild_ is now known as vasild
2972020-06-08T16:32:41 *** justanotheruser has joined #bitcoin-core-dev
2982020-06-08T16:33:50 <jonatack> thanks vasild, will ping you if questions
2992020-06-08T16:34:38 <vasild> ok :)
3002020-06-08T16:37:47 *** mol_ has quit IRC
3012020-06-08T16:39:14 *** troygiorshev has quit IRC
3022020-06-08T16:39:47 *** jarthur has joined #bitcoin-core-dev
3032020-06-08T16:40:59 *** troygiorshev has joined #bitcoin-core-dev
3042020-06-08T16:57:03 *** mol has joined #bitcoin-core-dev
3052020-06-08T17:02:01 *** mol_ has joined #bitcoin-core-dev
3062020-06-08T17:05:38 *** mol has quit IRC
3072020-06-08T17:10:42 *** lnostdal has joined #bitcoin-core-dev
3082020-06-08T17:12:28 *** proofofkeags has quit IRC
3092020-06-08T17:12:55 *** proofofkeags has joined #bitcoin-core-dev
3102020-06-08T17:17:45 *** proofofkeags has quit IRC
3112020-06-08T17:28:39 *** proofofkeags has joined #bitcoin-core-dev
3122020-06-08T17:32:43 <luke-jr> MarcoFalke: #12677 is on my todo list
3132020-06-08T17:32:45 <gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
3142020-06-08T17:44:47 *** rafalcpp has quit IRC
3152020-06-08T17:46:54 *** promag_ has joined #bitcoin-core-dev
3162020-06-08T17:52:15 *** lnostdal has quit IRC
3172020-06-08T17:54:42 *** bitcoin-git has joined #bitcoin-core-dev
3182020-06-08T17:54:42 <bitcoin-git> [bitcoin] hebasto opened pull request #19213: refactor: Replace RecursiveMutex with Mutex in Get{Data,Blocks}Dir() (master...200608-path-mx) https://github.com/bitcoin/bitcoin/pull/19213
3192020-06-08T17:54:43 *** bitcoin-git has left #bitcoin-core-dev
3202020-06-08T18:00:01 *** suriro has quit IRC
3212020-06-08T18:03:21 *** lnostdal has joined #bitcoin-core-dev
3222020-06-08T18:07:58 *** proofofkeags has quit IRC
3232020-06-08T18:08:23 *** proofofkeags has joined #bitcoin-core-dev
3242020-06-08T18:12:34 *** proofofkeags has quit IRC
3252020-06-08T18:18:48 *** justanotheruser has quit IRC
3262020-06-08T18:19:16 <harding> wumpus: FYI, I've heard from someone that they can't verify the releases because they have "weak-digest sha1" in their gpg.conf (based on a recommendation they heard from petertodd) and the release signing key is self-signed using sha1. I explained the situation to them, but long-term I think that's a reasonable option for people to be setting and so maybe it's time to update the release key to use a stronger digest.
3272020-06-08T18:25:32 *** bitcoin-git has joined #bitcoin-core-dev
3282020-06-08T18:25:33 <bitcoin-git> [bitcoin] sipa opened pull request #19214: Auto-detect SHA256 implementation in benchmarks (master...202006_hw_sha_bench) https://github.com/bitcoin/bitcoin/pull/19214
3292020-06-08T18:25:34 *** bitcoin-git has left #bitcoin-core-dev
3302020-06-08T18:28:15 *** Randolf has quit IRC
3312020-06-08T18:34:44 *** justanotheruser has joined #bitcoin-core-dev
3322020-06-08T18:41:15 *** molz_ has joined #bitcoin-core-dev
3332020-06-08T18:44:08 *** mol_ has quit IRC
3342020-06-08T18:45:12 *** S3RK has joined #bitcoin-core-dev
3352020-06-08T18:49:02 *** rafalcpp has joined #bitcoin-core-dev
3362020-06-08T18:49:55 *** S3RK has quit IRC
3372020-06-08T18:55:23 *** shesek has quit IRC
3382020-06-08T18:55:35 *** IAm_thor3 has joined #bitcoin-core-dev
3392020-06-08T19:09:34 *** EagleTM has joined #bitcoin-core-dev
3402020-06-08T19:13:35 *** proofofkeags has joined #bitcoin-core-dev
3412020-06-08T19:15:43 *** Talkless has quit IRC
3422020-06-08T19:28:21 *** proofofkeags has quit IRC
3432020-06-08T19:28:47 *** proofofkeags has joined #bitcoin-core-dev
3442020-06-08T19:28:57 <wumpus> harding: sure, do you perhaps know how to do this?
3452020-06-08T19:29:29 <harding> wumpus: I tried doing it several years ago, but I couldn't figure out how and ended up just creating a new key. :-(
3462020-06-08T19:29:56 <wumpus> hmm generating a new release keys seems much worse
3472020-06-08T19:33:33 *** proofofkeags has quit IRC
3482020-06-08T19:36:06 <harding> wumpus: yeah, agreed. You can still sign the new release keys with the old release keys to create a clear trust path, but it's probably worth waiting to see if anyone reading this knows a way to just upgrade the existing key.
3492020-06-08T19:37:27 <wumpus> looks like it should just be "gpg --cert-digest-algo sha512 --expert --edit-key", then "sign", going to try...
3502020-06-08T19:42:03 <harding> wumpus: if that works and if you figured it out from just reading the manual page or doing a quick web search, I'm going to have hang my head in shame because I know I spent more than an hour researching this a couple years ago.
3512020-06-08T19:42:44 *** pinheadm_ has joined #bitcoin-core-dev
3522020-06-08T19:43:27 <phantomcircuit> sipa, no idea why the auto detect is actually slower
3532020-06-08T19:43:54 <phantomcircuit> definitely running a gcc old enough that the asm should beat the naive implementation significantly
3542020-06-08T19:43:59 *** owowo has quit IRC
3552020-06-08T19:45:23 *** pinheadmz has quit IRC
3562020-06-08T19:46:33 <sipa> phantomcircuit: if you run bitcoind, what gets reported in debug.log?
3572020-06-08T19:46:42 <sipa> (it tells you which implementation is selected)
3582020-06-08T19:47:09 <sipa> in one of the first output lines
3592020-06-08T19:47:22 <sipa> 2020-03-15T20:46:14.743702Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
3602020-06-08T19:47:34 <phantomcircuit> Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
3612020-06-08T19:48:09 <sipa> any particular configure flags or CXXFLAGS?
3622020-06-08T19:48:50 *** rafalcpp has quit IRC
3632020-06-08T19:48:54 <phantomcircuit> --with-incompatible-bdb --without-gui
3642020-06-08T19:49:08 <sipa> very surprising
3652020-06-08T19:49:16 *** owowo has joined #bitcoin-core-dev
3662020-06-08T19:49:20 <sipa> and the sse4 code is actually assembly, not intrinsics
3672020-06-08T19:49:28 <sipa> so a compiler can't be fucking that up
3682020-06-08T19:50:30 <phantomcircuit> hmm i wonder if im having build issues one sec
3692020-06-08T19:51:48 <phantomcircuit> it is actually `using sse4(1way),sse41(4way),avx2(8way)` in the benchmark too
3702020-06-08T19:52:27 <sipa> only the 1-way code matters for the benchmarks you're listing
3712020-06-08T19:52:37 <sipa> how does the merkle root benchmark compare?
3722020-06-08T19:52:59 <wumpus> harding: well I did that and pushed my re-signed key to the keyservers, hope it worked (no idea how to test)
3732020-06-08T19:53:01 <sipa> -filter=MerkleRoot
3742020-06-08T19:53:09 <phantomcircuit> it's slower too
3752020-06-08T19:53:19 <phantomcircuit> bench_master.txt:MerkleRoot, 5, 800, 4.61105, 0.00114375, 0.00117359, 0.00114912
3762020-06-08T19:53:20 <phantomcircuit> bench_sipa.txt:MerkleRoot, 5, 800, 4.71484, 0.00116899, 0.00119543, 0.00117554
3772020-06-08T19:53:59 <wumpus> harding: (well I can verify bitcoin core SHA256SUMS.asc using "weak-digest sha1", but haven't ever seen it fail)
3782020-06-08T19:54:00 <sipa> wth
3792020-06-08T19:54:04 <sipa> phantomcircuit: that's ridiculous
3802020-06-08T19:54:10 <sipa> it should be 5x faster
3812020-06-08T19:54:22 <harding> wumpus: It's failed for me with weak-digest sha1, so I'll try testing now.
3822020-06-08T19:54:59 <phantomcircuit> sipa, it's a laptop cpu possibly the sse4/avx2 instructions are just comically broken?
3832020-06-08T19:56:45 <sipa> phantomcircuit: but your numbers are fast
3842020-06-08T19:56:57 <sipa> unreasonably fast for the naive implementation
3852020-06-08T19:57:02 <sipa> MerkleRoot, 5, 800, 42.6441, 0.0106318, 0.0107271, 0.0106534
3862020-06-08T19:57:12 <sipa> ^ that's on my laptop with naive SHA256
3872020-06-08T19:57:15 <harding> wumpus: did you upload to keyserver.ubuntu.com? I still get a failure after running --refresh-keys from there.
3882020-06-08T19:57:51 <wumpus> "gpg --fingerprint --check-sigs 0x90C8019E36C2E964" does show two self-signatures
3892020-06-08T19:57:59 <wumpus> of course it doesn't show the algorithm used
3902020-06-08T19:58:33 <phantomcircuit> i mean i just did `git clean -fdx && git checkout master && ./autogen.sh && ./configure --with-incompatible-bdb --without-gui && make -j4 && ./src/bench/bench_bitcoin --filter='(SHA256|Merkle).*'` and got the same result for master
3912020-06-08T19:58:36 <phantomcircuit> which i see as b1b173994406158e5faa3c83b113da9d971ac104
3922020-06-08T19:59:56 <harding> wumpus: ah, now it works for me and my friend also says it works. Thanks!
3932020-06-08T20:00:14 <harding> (I had to request the specific key with --refresh-keys)
3942020-06-08T20:00:29 <phantomcircuit> i'll clear ccache as well lets try this agian...
3952020-06-08T20:00:35 <wumpus> "You can validate signatures are using non-SHA1 by using gpg --list-packets < SIGFILE, and checking that digest algo (aka hash algorithm) is not "2" (SHA1). For SHA512, you'd want "10" (see RFC4880 section 9.4 for details): " of course list-packets, of course
3962020-06-08T20:00:57 <sipa> haha
3972020-06-08T20:01:08 <harding> haha
3982020-06-08T20:01:11 <wumpus> harding: great! thanks for checking
3992020-06-08T20:01:15 <sipa> the gpg binary format is not too hard
4002020-06-08T20:01:28 <sipa> it's probably easier to learn to read a hexdump than to learn gpg's command line options
4012020-06-08T20:01:36 <wumpus> :-)
4022020-06-08T20:02:13 <sipa> i have edited gpg files using hd, head & tail
4032020-06-08T20:02:34 <sipa> phantomcircuit: i'm baffled
4042020-06-08T20:03:10 <phantomcircuit> it's gonna end up being some insane ccache issue except my original master benchmark is before i had even checked out the pr
4052020-06-08T20:03:12 <phantomcircuit> so uh
4062020-06-08T20:03:16 * phantomcircuit shrugs
4072020-06-08T20:04:10 <sipa> ok, i'm going to run this:
4082020-06-08T20:04:12 <sipa> $ ./autogen.sh && ./configure --with-incompatible-bdb --without-gui && make -j9 -C src bench/bench_bitcoin && ./src/bench/bench_bitcoin --filter='(SHA256|Merkle).*'
4092020-06-08T20:04:42 <sipa> with a git clean -dfx before it
4102020-06-08T20:05:05 *** shesek has joined #bitcoin-core-dev
4112020-06-08T20:06:00 <sipa> this is on a i7-7820HQ fwiw
4122020-06-08T20:08:54 <phantomcircuit> running the exact same command against master now
4132020-06-08T20:09:35 *** shesek has quit IRC
4142020-06-08T20:09:43 <phantomcircuit> sipa, i think your cpu should generally be faster
4152020-06-08T20:11:11 <wumpus> sipa: wow! I've never editited gpg files that low-level, did apparently mess around with gpgsplit at some point to turn an attached signature into a detached signature https://github.com/bitcoin-core/gitian.sigs/blob/master/scripts/extract-sig.py
4162020-06-08T20:11:45 <sipa> phantomcircuit: except your *naive* numbers are faster than my sse4 numbers!
4172020-06-08T20:12:03 <phantomcircuit> sipa, yeah im confused to
4182020-06-08T20:12:32 <sipa> and for the 1-way sse4 code, i'd believe it that an implementation may be sufficiently broken that it offers no gain
4192020-06-08T20:12:53 <sipa> but for the 8-way AVX2 ode to be effectively 8x slower than naive seems a severe stretch
4202020-06-08T20:13:16 *** promag_ has joined #bitcoin-core-dev
4212020-06-08T20:13:50 <sipa> wumpus: i had to make the same edit to many different files, but it was the same byte range for all
4222020-06-08T20:16:55 <phantomcircuit> sipa, and now the numbers make sense, master is MerkleRoot, 5, 800, 26.4366, 0.00647519, 0.00678599, 0.00659338
4232020-06-08T20:17:15 <phantomcircuit> 19214 is MerkleRoot, 5, 800, 4.56617, 0.00113032, 0.00114694, 0.00114392
4242020-06-08T20:17:18 <phantomcircuit> so ??????
4252020-06-08T20:17:29 <phantomcircuit> i swear i didn't mix them up either
4262020-06-08T20:18:28 *** proofofkeags has joined #bitcoin-core-dev
4272020-06-08T20:18:32 *** proofofkeags has quit IRC
4282020-06-08T20:18:37 <phantomcircuit> i mean that's still kind of unreasonably fast for the naive implementation but at least they're in the right ratio?
4292020-06-08T20:18:40 <sipa> that looks more reasonable
4302020-06-08T20:18:46 *** proofofkeags has joined #bitcoin-core-dev
4312020-06-08T20:22:18 <sipa> phantomcircuit: well whatever glitch happened on your CPU, if you figure it out you may want to inform intel that naive SHA256 code can beat a AVX2 parallel one :)
4322020-06-08T20:22:51 <phantomcircuit> the weird thing is that i did the master benchmark before i checked out the pr
4332020-06-08T20:23:22 <phantomcircuit> i checked my shell history to confirm that too
4342020-06-08T20:27:10 *** davterra has quit IRC
4352020-06-08T20:27:40 *** promag_ has quit IRC
4362020-06-08T20:32:05 *** promag_ has joined #bitcoin-core-dev
4372020-06-08T20:48:30 *** jonatack has quit IRC
4382020-06-08T20:49:21 *** jonatack has joined #bitcoin-core-dev
4392020-06-08T20:51:13 <phantomcircuit> sipa, oh do any of the other benchmarks maybe end up calling something that would call the auto detect?
4402020-06-08T20:53:33 <sipa> phantomcircuit: i don't think so
4412020-06-08T20:56:58 *** S3RK has joined #bitcoin-core-dev
4422020-06-08T21:00:02 *** IAm_thor3 has quit IRC
4432020-06-08T21:01:01 *** proofofkeags has quit IRC
4442020-06-08T21:01:43 *** S3RK has quit IRC
4452020-06-08T21:12:03 *** proofofkeags has joined #bitcoin-core-dev
4462020-06-08T21:27:45 *** pretyflaco1 has joined #bitcoin-core-dev
4472020-06-08T21:27:50 *** promag_ has quit IRC
4482020-06-08T21:27:59 *** pretyflaco has quit IRC
4492020-06-08T21:32:42 <phantomcircuit> i'd like to basically start over on ScanForWalletTransactions and split it into a call to a chain interface method that returns a list of candidate blocks and logic to (optionally, but by default) rescan if anything in the keypool changed
4502020-06-08T21:33:12 <phantomcircuit> as it stands the scanning logic can miss transactions if you use keypool keys out of order
4512020-06-08T21:33:32 <phantomcircuit> (i doubt that's ever actually happened to anybody though)
4522020-06-08T21:35:36 <sipa> phantomcircuit: how does that interact with work to make rescanning of all wallets happen simultaneously?
4532020-06-08T21:36:15 <phantomcircuit> is there a pr or an issue describing the strategy for that? (i don't see any reason it would be incompatible)
4542020-06-08T21:38:24 <sipa> no idea; just vaguely heard in mentioned
4552020-06-08T21:42:14 *** Guyver2 has quit IRC
4562020-06-08T21:43:39 *** rafalcpp has joined #bitcoin-core-dev
4572020-06-08T21:44:02 *** proofofkeags has quit IRC
4582020-06-08T21:45:27 *** proofofkeags has joined #bitcoin-core-dev
4592020-06-08T21:49:54 <luke-jr> wumpus: did you manage to re-self-sign without SHA1?
4602020-06-08T21:50:07 <luke-jr> wumpus: I did it a few years ago - maybe I can look up how I did it
4612020-06-08T21:55:34 *** Oejet has joined #bitcoin-core-dev
4622020-06-08T22:01:39 *** pretyflaco1 has quit IRC
4632020-06-08T22:02:09 *** pretyflaco has joined #bitcoin-core-dev
4642020-06-08T22:07:42 *** DeanGuss has quit IRC
4652020-06-08T22:08:48 *** DeanGuss has joined #bitcoin-core-dev
4662020-06-08T22:09:32 *** promag has quit IRC
4672020-06-08T22:10:48 *** promag has joined #bitcoin-core-dev
4682020-06-08T22:15:35 *** promag has quit IRC
4692020-06-08T22:18:46 *** davterra has joined #bitcoin-core-dev
4702020-06-08T22:20:22 *** proofofkeags has quit IRC
4712020-06-08T22:25:50 *** proofofkeags has joined #bitcoin-core-dev
4722020-06-08T22:28:28 *** jb55 has quit IRC
4732020-06-08T22:29:25 *** jb55 has joined #bitcoin-core-dev
4742020-06-08T22:30:09 *** _flow_ has quit IRC
4752020-06-08T22:34:24 *** proofofkeags has quit IRC
4762020-06-08T22:34:37 *** filchef has joined #bitcoin-core-dev
4772020-06-08T22:38:07 *** proofofkeags has joined #bitcoin-core-dev
4782020-06-08T22:38:50 *** _flow_ has joined #bitcoin-core-dev
4792020-06-08T22:39:38 *** dongcarl has joined #bitcoin-core-dev
4802020-06-08T22:39:55 *** Mercury_Vapor has quit IRC
4812020-06-08T22:39:58 *** proofofkeags has quit IRC
4822020-06-08T22:40:22 *** Mercury_Vapor has joined #bitcoin-core-dev
4832020-06-08T22:41:08 *** proofofkeags has joined #bitcoin-core-dev
4842020-06-08T22:41:44 *** proofofkeags has quit IRC
4852020-06-08T22:41:50 *** proofofkeags has joined #bitcoin-core-dev
4862020-06-08T22:44:43 *** proofofkeags has quit IRC
4872020-06-08T22:44:49 *** promag has joined #bitcoin-core-dev
4882020-06-08T22:47:11 *** proofofkeags has joined #bitcoin-core-dev
4892020-06-08T22:48:45 *** proofofkeags has quit IRC
4902020-06-08T22:52:37 *** mrostecki has quit IRC
4912020-06-08T22:54:57 *** braydonf has quit IRC
4922020-06-08T22:55:42 *** braydonf has joined #bitcoin-core-dev
4932020-06-08T23:02:49 *** mrostecki has joined #bitcoin-core-dev
4942020-06-08T23:04:37 *** proofofkeags has joined #bitcoin-core-dev
4952020-06-08T23:07:24 *** proofofkeags has quit IRC
4962020-06-08T23:07:53 *** proofofkeags has joined #bitcoin-core-dev
4972020-06-08T23:11:46 *** bitdex has joined #bitcoin-core-dev
4982020-06-08T23:14:12 *** proofofkeags has quit IRC
4992020-06-08T23:15:14 *** justanotheruser has quit IRC
5002020-06-08T23:16:03 *** S3RK has joined #bitcoin-core-dev
5012020-06-08T23:21:42 *** S3RK has quit IRC
5022020-06-08T23:25:42 *** Deacyde has quit IRC
5032020-06-08T23:30:01 *** proofofkeags has joined #bitcoin-core-dev
5042020-06-08T23:34:17 *** proofofkeags has quit IRC
5052020-06-08T23:34:23 *** bitcoin-git has joined #bitcoin-core-dev
5062020-06-08T23:34:23 <bitcoin-git> [bitcoin] achow101 opened pull request #19215: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs (master...psbt-segwit-fixes) https://github.com/bitcoin/bitcoin/pull/19215
5072020-06-08T23:34:24 *** bitcoin-git has left #bitcoin-core-dev
5082020-06-08T23:48:07 *** pretyflaco has quit IRC