12020-06-10T00:00:02 *** retroj1 has quit IRC
22020-06-10T00:06:00 *** lightlike has quit IRC
32020-06-10T00:06:17 *** lightlike has joined #bitcoin-core-dev
42020-06-10T00:06:25 *** proofofkeags has joined #bitcoin-core-dev
52020-06-10T00:21:59 *** suriro has joined #bitcoin-core-dev
62020-06-10T00:22:50 *** pretyflaco has quit IRC
72020-06-10T00:30:18 *** AaronvanW has quit IRC
82020-06-10T00:41:57 *** Relis has quit IRC
92020-06-10T00:44:25 *** Relis has joined #bitcoin-core-dev
102020-06-10T00:47:39 *** S3RK has joined #bitcoin-core-dev
112020-06-10T00:52:30 *** bitcoin-git has joined #bitcoin-core-dev
122020-06-10T00:52:30 <bitcoin-git> [bitcoin] sipa opened pull request #19230: [TESTS] Move base58 to own module to break circular dependency (master...202006_addr_base58) https://github.com/bitcoin/bitcoin/pull/19230
132020-06-10T00:52:32 *** bitcoin-git has left #bitcoin-core-dev
142020-06-10T00:55:44 *** S3RK has quit IRC
152020-06-10T01:00:20 *** lightlike has quit IRC
162020-06-10T01:07:19 *** roconnor has joined #bitcoin-core-dev
172020-06-10T01:16:09 *** Relis has quit IRC
182020-06-10T01:37:06 *** Relis has joined #bitcoin-core-dev
192020-06-10T01:37:10 *** S3RK has joined #bitcoin-core-dev
202020-06-10T01:37:34 <sipa> qt/bitcoin.cpp: In function âint GuiMain(int, char**)â:
212020-06-10T01:37:35 <sipa> qt/bitcoin.cpp:460:35: error: âUntranslatedâ was not declared in this scope
222020-06-10T01:37:37 <sipa> node->initError(strprintf(Untranslated("Error parsing command line arguments: %s\n"), error));
232020-06-10T01:37:40 <sipa> ^~~~~~~~~~~~
242020-06-10T01:40:42 <fanquake> Looks like #19176 was merged even though broken for one of the builds
252020-06-10T01:40:44 <gribble> https://github.com/bitcoin/bitcoin/issues/19176 | refactor: Error message bilingual_str consistency by laanwj · Pull Request #19176 · bitcoin/bitcoin · GitHub
262020-06-10T01:42:21 *** jarthur has quit IRC
272020-06-10T01:44:36 <sipa> fanquake: ci looks green for that PR?
282020-06-10T01:44:43 <sipa> also i can't reproduce this locally
292020-06-10T01:45:31 <fanquake> Yea green for the PR, but one build failed in the merge: https://travis-ci.org/github/bitcoin/bitcoin/builds/696627533
302020-06-10T01:45:47 <fanquake> I also am not seeing it locally
312020-06-10T01:47:00 *** Dean_Guss has quit IRC
322020-06-10T01:50:02 *** Highway61 has quit IRC
332020-06-10T01:54:51 *** Highway61 has joined #bitcoin-core-dev
342020-06-10T02:00:18 *** Highway61 has quit IRC
352020-06-10T02:01:57 <fanquake> Reproduced in a bionic container.
362020-06-10T02:02:03 <fanquake> Will probably PR a fix
372020-06-10T02:04:38 *** mdunnio has joined #bitcoin-core-dev
382020-06-10T02:14:00 *** bitcoin-git has joined #bitcoin-core-dev
392020-06-10T02:14:00 <bitcoin-git> [bitcoin] fanquake opened pull request #19231: gui: add missing translation.h include to fix build (master...translations_gui_fixup) https://github.com/bitcoin/bitcoin/pull/19231
402020-06-10T02:14:01 *** bitcoin-git has left #bitcoin-core-dev
412020-06-10T02:21:14 *** harrigan has quit IRC
422020-06-10T02:21:20 *** justanotheruser has quit IRC
432020-06-10T02:21:24 *** harrigan has joined #bitcoin-core-dev
442020-06-10T02:22:18 *** proofofkeags has quit IRC
452020-06-10T02:22:53 *** proofofkeags has joined #bitcoin-core-dev
462020-06-10T02:27:20 *** proofofkeags has quit IRC
472020-06-10T02:31:27 *** proofofkeags has joined #bitcoin-core-dev
482020-06-10T02:33:03 *** justanotheruser has joined #bitcoin-core-dev
492020-06-10T02:35:12 *** Relis has quit IRC
502020-06-10T02:40:31 *** rafalcpp has quit IRC
512020-06-10T02:45:34 *** mdunnio has quit IRC
522020-06-10T02:49:09 *** proofofkeags has quit IRC
532020-06-10T02:55:55 *** mdunnio has joined #bitcoin-core-dev
542020-06-10T03:00:02 *** suriro has quit IRC
552020-06-10T03:17:36 *** EagleTM has joined #bitcoin-core-dev
562020-06-10T03:17:57 *** Eagle[TM] has quit IRC
572020-06-10T03:21:54 *** Arthimus has joined #bitcoin-core-dev
582020-06-10T03:26:20 *** Dean_Guss has joined #bitcoin-core-dev
592020-06-10T03:28:44 *** MM77788811 has joined #bitcoin-core-dev
602020-06-10T03:28:55 *** proofofkeags has joined #bitcoin-core-dev
612020-06-10T03:29:48 *** tryphe_ has joined #bitcoin-core-dev
622020-06-10T03:31:04 *** troygiorshev has quit IRC
632020-06-10T03:32:38 *** MM77788811 has quit IRC
642020-06-10T03:33:14 *** proofofkeags has quit IRC
652020-06-10T03:33:18 *** tryphe has quit IRC
662020-06-10T03:46:06 *** promag has joined #bitcoin-core-dev
672020-06-10T03:50:38 *** promag has quit IRC
682020-06-10T04:02:09 *** mdunnio has quit IRC
692020-06-10T04:04:27 *** mdunnio has joined #bitcoin-core-dev
702020-06-10T04:05:40 *** mdunnio has quit IRC
712020-06-10T04:17:45 *** proofofkeags has joined #bitcoin-core-dev
722020-06-10T04:20:32 *** vasild_ has joined #bitcoin-core-dev
732020-06-10T04:21:53 *** proofofkeags has quit IRC
742020-06-10T04:24:04 *** vasild has quit IRC
752020-06-10T04:24:04 *** vasild_ is now known as vasild
762020-06-10T04:27:52 *** MM77788811 has joined #bitcoin-core-dev
772020-06-10T04:29:01 *** MM77788811 has quit IRC
782020-06-10T05:13:37 *** Kiminuo has joined #bitcoin-core-dev
792020-06-10T05:29:54 *** tryphe_ is now known as tryphe
802020-06-10T05:43:13 *** S3RK has quit IRC
812020-06-10T05:43:41 *** S3RK has joined #bitcoin-core-dev
822020-06-10T05:49:02 *** S3RK has quit IRC
832020-06-10T05:49:16 *** riordant has joined #bitcoin-core-dev
842020-06-10T05:51:27 *** S3RK has joined #bitcoin-core-dev
852020-06-10T06:00:01 *** Arthimus has quit IRC
862020-06-10T06:05:48 *** S3RK has quit IRC
872020-06-10T06:16:15 *** mol has quit IRC
882020-06-10T06:16:34 *** murrayn has quit IRC
892020-06-10T06:16:41 *** mol has joined #bitcoin-core-dev
902020-06-10T06:16:53 *** murray_ has joined #bitcoin-core-dev
912020-06-10T06:17:43 *** murray_ has left #bitcoin-core-dev
922020-06-10T06:18:29 *** murrayn has joined #bitcoin-core-dev
932020-06-10T06:18:38 *** proofofkeags has joined #bitcoin-core-dev
942020-06-10T06:21:58 *** kest10 has joined #bitcoin-core-dev
952020-06-10T06:23:41 *** proofofkeags has quit IRC
962020-06-10T06:34:06 *** Guyver2 has joined #bitcoin-core-dev
972020-06-10T06:35:52 *** S3RK has joined #bitcoin-core-dev
982020-06-10T06:36:20 *** kest10 has quit IRC
992020-06-10T06:43:30 *** dr-orlovsky has quit IRC
1002020-06-10T06:43:57 *** Kiminuo has quit IRC
1012020-06-10T06:48:26 *** S3RK has quit IRC
1022020-06-10T06:55:14 *** hollisb has joined #bitcoin-core-dev
1032020-06-10T06:56:24 *** proofofkeags has joined #bitcoin-core-dev
1042020-06-10T07:00:25 *** promag has joined #bitcoin-core-dev
1052020-06-10T07:01:02 *** proofofkeags has quit IRC
1062020-06-10T07:04:38 *** promag has quit IRC
1072020-06-10T07:14:55 *** MasterdonX has quit IRC
1082020-06-10T07:17:10 *** MasterdonX has joined #bitcoin-core-dev
1092020-06-10T07:30:33 *** proofofkeags has joined #bitcoin-core-dev
1102020-06-10T07:36:14 *** proofofkeags has quit IRC
1112020-06-10T07:50:39 *** Guyver2_ has joined #bitcoin-core-dev
1122020-06-10T07:54:26 *** Guyver2 has quit IRC
1132020-06-10T07:55:37 *** dr-orlovsky has joined #bitcoin-core-dev
1142020-06-10T08:02:53 *** S3RK has joined #bitcoin-core-dev
1152020-06-10T08:05:35 *** Guyver2_ is now known as Guyver2
1162020-06-10T08:07:18 *** S3RK has quit IRC
1172020-06-10T08:08:08 *** IGHOR has quit IRC
1182020-06-10T08:16:05 *** AaronvanW has joined #bitcoin-core-dev
1192020-06-10T08:44:08 *** kljasdfvv has quit IRC
1202020-06-10T08:44:31 *** S3RK has joined #bitcoin-core-dev
1212020-06-10T08:45:34 *** kljasdfvv has joined #bitcoin-core-dev
1222020-06-10T08:50:24 *** afk11` has quit IRC
1232020-06-10T08:50:53 *** S3RK has quit IRC
1242020-06-10T08:51:18 *** afk11` has joined #bitcoin-core-dev
1252020-06-10T08:54:36 *** peltre has quit IRC
1262020-06-10T08:55:43 *** peltre has joined #bitcoin-core-dev
1272020-06-10T08:58:20 *** jorijn has quit IRC
1282020-06-10T09:00:02 *** hollisb has quit IRC
1292020-06-10T09:02:35 *** AaronvanW has quit IRC
1302020-06-10T09:10:45 *** jorijn has joined #bitcoin-core-dev
1312020-06-10T09:13:15 *** bitcoin-git has joined #bitcoin-core-dev
1322020-06-10T09:13:16 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8364df25070...20e95313790c
1332020-06-10T09:13:16 <bitcoin-git> bitcoin/master 948f113 fanquake: gui: add missing translation.h include to fix build
1342020-06-10T09:13:17 <bitcoin-git> bitcoin/master 20e9531 fanquake: Merge #19231: gui: add missing translation.h include to fix build
1352020-06-10T09:13:26 *** bitcoin-git has left #bitcoin-core-dev
1362020-06-10T09:13:40 *** bitcoin-git has joined #bitcoin-core-dev
1372020-06-10T09:13:40 <bitcoin-git> [bitcoin] fanquake merged pull request #19231: gui: add missing translation.h include to fix build (master...translations_gui_fixup) https://github.com/bitcoin/bitcoin/pull/19231
1382020-06-10T09:13:41 *** bitcoin-git has left #bitcoin-core-dev
1392020-06-10T09:14:02 *** Pavlenex has joined #bitcoin-core-dev
1402020-06-10T09:16:17 *** Bullit has quit IRC
1412020-06-10T09:20:05 *** Bullit has joined #bitcoin-core-dev
1422020-06-10T09:22:08 *** Sho_1 has joined #bitcoin-core-dev
1432020-06-10T09:31:27 *** S3RK has joined #bitcoin-core-dev
1442020-06-10T09:35:22 *** AaronvanW has joined #bitcoin-core-dev
1452020-06-10T09:40:50 *** rafalcpp has joined #bitcoin-core-dev
1462020-06-10T09:43:32 *** Relis has joined #bitcoin-core-dev
1472020-06-10T09:48:31 *** AaronvanW has quit IRC
1482020-06-10T09:49:28 *** bitcoin-git has joined #bitcoin-core-dev
1492020-06-10T09:49:28 <bitcoin-git> [bitcoin] hebasto opened pull request #19233: Make SetMiscWarning() accept bilingual_str argument (master...200610-bi-warn) https://github.com/bitcoin/bitcoin/pull/19233
1502020-06-10T09:49:29 *** bitcoin-git has left #bitcoin-core-dev
1512020-06-10T09:52:53 *** Relis has quit IRC
1522020-06-10T09:54:22 *** Relis has joined #bitcoin-core-dev
1532020-06-10T10:00:24 *** Relis has quit IRC
1542020-06-10T10:00:26 *** shesek has joined #bitcoin-core-dev
1552020-06-10T10:03:20 *** Evangeline12Mill has joined #bitcoin-core-dev
1562020-06-10T10:08:26 *** Evangeline12Mill has quit IRC
1572020-06-10T10:12:40 *** proofofkeags has joined #bitcoin-core-dev
1582020-06-10T10:18:06 *** proofofkeags has quit IRC
1592020-06-10T10:22:57 *** luke-jr has quit IRC
1602020-06-10T10:24:16 *** luke-jr has joined #bitcoin-core-dev
1612020-06-10T10:36:00 *** AaronvanW has joined #bitcoin-core-dev
1622020-06-10T10:39:20 *** AaronvanW has quit IRC
1632020-06-10T11:00:30 *** Relis has joined #bitcoin-core-dev
1642020-06-10T11:02:27 *** Relis has quit IRC
1652020-06-10T11:07:23 *** Relis has joined #bitcoin-core-dev
1662020-06-10T11:08:04 *** afk11` has quit IRC
1672020-06-10T11:08:34 *** S3RK has quit IRC
1682020-06-10T11:10:10 *** Pavlenex has joined #bitcoin-core-dev
1692020-06-10T11:10:27 *** afk11` has joined #bitcoin-core-dev
1702020-06-10T11:24:16 *** Pavlenex has quit IRC
1712020-06-10T11:32:23 *** rafalcpp has quit IRC
1722020-06-10T11:43:58 *** rafalcpp has joined #bitcoin-core-dev
1732020-06-10T11:50:59 *** dr-orlovsky has quit IRC
1742020-06-10T11:51:11 <shesek> 0.20.0 does not appear to report descriptor information in getaddressinfo. is this a known bug? or am I missing something? here's a simple reproduction script (basically a simple `importmulti` followed by a `getaddressinfo`) and the output I'm seeing for 0.19.1 and 0.20.0: https://gist.github.com/shesek/cecfe7f154f7a0356d8882f694713e20
1752020-06-10T11:52:30 *** S3RK has joined #bitcoin-core-dev
1762020-06-10T11:55:17 <shesek> oh wait, I'm using pk() and treating it as a base58 address, which it isn't
1772020-06-10T11:56:36 <harding> Yeah, I think the question is why bitcoin-cli -regtest deriveaddresses 'pk(0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798)#gn28ywm7' returns a P2PKH address.
1782020-06-10T11:57:19 *** S3RK has quit IRC
1792020-06-10T11:59:08 <shesek> is that for 0.19, 0.20 or both?
1802020-06-10T12:00:02 *** Sho_1 has quit IRC
1812020-06-10T12:00:35 <harding> Both 0.19.0.1 and 0.20.0 (just tested).
1822020-06-10T12:00:43 <shesek> the missing descriptor info was indeed due to using pk() and then requesting the base58 address, it does work as expected with pkh()
1832020-06-10T12:01:53 <shesek> harding, yes, it definitely shouldn't do that :)
1842020-06-10T12:01:56 *** riordant has quit IRC
1852020-06-10T12:03:28 *** owowo has quit IRC
1862020-06-10T12:04:16 <shesek> so what changed between 0.19 and 0.20? it seems like something in 0.20 no longer considers pk() to be p2pkh-like-base58-encodeable
1872020-06-10T12:10:05 *** Asbestos_Vapor has joined #bitcoin-core-dev
1882020-06-10T12:12:47 *** Mercury_Vapor has quit IRC
1892020-06-10T12:22:06 *** RiscTaker1 has joined #bitcoin-core-dev
1902020-06-10T12:22:28 <shesek> not treating p2pk as base58 encodable in esplora is probably the #1 cause for complaints I'm hearing from people, especially around times when old stashes move around and everyone wants to look them up on the explorers. its hard enough to explain that other block explorers are wrong, but bitcoind doing it too makes this quite more challenging :p (in some other places too)
1912020-06-10T12:22:30 <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
1922020-06-10T12:23:06 *** Kiminuo has joined #bitcoin-core-dev
1932020-06-10T12:25:39 <shesek> harding, oddly enough, it seems like importing a pk() descriptor with a label on 0.20, then calling getaddressesbylabel with that label, does return the p2pkh address. and the label does show up in `getaddressinfo` for the p2pkh address, while the `ismine`/`iswatchonly` fields are set to `false`
1942020-06-10T12:27:00 <shesek> importing with a label and using getaddressesbylabel is actually how I found myself using the p2pkh address format of a p2pk script in the first place
1952020-06-10T12:40:20 *** Mercury_Vapor has joined #bitcoin-core-dev
1962020-06-10T12:43:26 *** Asbestos_Vapor has quit IRC
1972020-06-10T12:44:52 <wumpus> fanquake: thanks for fixing the build after #19176, it's kind of strange, pretty sure the PR passed all the checks
1982020-06-10T12:45:02 <gribble> https://github.com/bitcoin/bitcoin/issues/19176 | refactor: Error message bilingual_str consistency by laanwj · Pull Request #19176 · bitcoin/bitcoin · GitHub
1992020-06-10T12:50:50 *** cryptapus has quit IRC
2002020-06-10T12:55:03 *** cryptapus has joined #bitcoin-core-dev
2012020-06-10T12:55:03 *** cryptapus has quit IRC
2022020-06-10T12:55:03 *** cryptapus has joined #bitcoin-core-dev
2032020-06-10T12:58:01 <fanquake> wumpus: no worries ð
2042020-06-10T12:58:11 *** fvccvncvnbsfg has joined #bitcoin-core-dev
2052020-06-10T13:01:36 *** kljasdfvv has quit IRC
2062020-06-10T13:01:36 *** _flow_ has quit IRC
2072020-06-10T13:01:38 *** TheFuzzStone[m] has quit IRC
2082020-06-10T13:01:40 *** windsok has quit IRC
2092020-06-10T13:01:40 *** cncr04s has quit IRC
2102020-06-10T13:01:46 *** pretyflaco has joined #bitcoin-core-dev
2112020-06-10T13:02:16 *** Highway61 has joined #bitcoin-core-dev
2122020-06-10T13:07:06 *** TheFuzzStone[m] has joined #bitcoin-core-dev
2132020-06-10T13:07:06 *** windsok has joined #bitcoin-core-dev
2142020-06-10T13:07:06 *** cncr04s has joined #bitcoin-core-dev
2152020-06-10T13:20:51 *** troygiorshev has joined #bitcoin-core-dev
2162020-06-10T13:22:11 *** _flow_ has joined #bitcoin-core-dev
2172020-06-10T13:25:55 *** bitcoin-git has joined #bitcoin-core-dev
2182020-06-10T13:25:56 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20e95313790c...bc933aeaf044
2192020-06-10T13:25:58 <bitcoin-git> bitcoin/master fa7b46c MarcoFalke: test: Add BerkeleyDatabase tsan suppression
2202020-06-10T13:25:58 <bitcoin-git> bitcoin/master bc933ae Wladimir J. van der Laan: Merge #19226: test: Add BerkeleyDatabase tsan suppression
2212020-06-10T13:26:01 *** bitcoin-git has left #bitcoin-core-dev
2222020-06-10T13:26:41 *** bitcoin-git has joined #bitcoin-core-dev
2232020-06-10T13:26:41 <bitcoin-git> [bitcoin] laanwj merged pull request #19226: test: Add BerkeleyDatabase tsan suppression (master...2006-ciTsanSupWallet) https://github.com/bitcoin/bitcoin/pull/19226
2242020-06-10T13:26:41 *** bitcoin-git has left #bitcoin-core-dev
2252020-06-10T13:34:43 *** bitcoin-git has joined #bitcoin-core-dev
2262020-06-10T13:34:43 <bitcoin-git> [bitcoin] Sjors closed pull request #13818: More intuitive GUI settings behavior when -proxy is set (master...2018/07/gui-proxy) https://github.com/bitcoin/bitcoin/pull/13818
2272020-06-10T13:34:44 *** bitcoin-git has left #bitcoin-core-dev
2282020-06-10T13:37:03 *** justanotheruser has quit IRC
2292020-06-10T13:38:13 <provoostenator> Review nag for #18030; one of those situations where just documenting the confusion seems faster than fixing it :-)
2302020-06-10T13:38:14 <gribble> https://github.com/bitcoin/bitcoin/issues/18030 | doc: Coin::IsSpent() can also mean never existed by Sjors · Pull Request #18030 · bitcoin/bitcoin · GitHub
2312020-06-10T13:41:24 <provoostenator> Somehwat similar, though this one requires action within the next decade :-) #13875
2322020-06-10T13:41:26 <gribble> https://github.com/bitcoin/bitcoin/issues/13875 | [doc] nChainTx needs to become a 64-bit earlier due to SegWit by Sjors · Pull Request #13875 · bitcoin/bitcoin · GitHub
2332020-06-10T13:51:29 *** mol has quit IRC
2342020-06-10T13:51:48 *** mol has joined #bitcoin-core-dev
2352020-06-10T13:52:48 *** bitcoin-git has joined #bitcoin-core-dev
2362020-06-10T13:52:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc933aeaf044...371a73e94043
2372020-06-10T13:52:49 <bitcoin-git> bitcoin/master 38e33aa Hennadii Stepanov: refactor: Make GetWarnings() bilingual_str aware internally
2382020-06-10T13:52:49 <bitcoin-git> bitcoin/master d1ae7c0 Hennadii Stepanov: Make GetWarnings() return bilingual_str
2392020-06-10T13:52:50 <bitcoin-git> bitcoin/master d49612f Hennadii Stepanov: Make SetMiscWarning() accept bilingual_str argument
2402020-06-10T13:52:51 *** bitcoin-git has left #bitcoin-core-dev
2412020-06-10T13:53:08 *** bitcoin-git has joined #bitcoin-core-dev
2422020-06-10T13:53:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19233: Make SetMiscWarning() accept bilingual_str argument (master...200610-bi-warn) https://github.com/bitcoin/bitcoin/pull/19233
2432020-06-10T13:53:09 *** bitcoin-git has left #bitcoin-core-dev
2442020-06-10T13:55:29 *** dfmb_ has joined #bitcoin-core-dev
2452020-06-10T14:04:27 *** Asbestos_Vapor has joined #bitcoin-core-dev
2462020-06-10T14:05:20 *** proofofkeags has joined #bitcoin-core-dev
2472020-06-10T14:06:35 *** Mercury_Vapor has quit IRC
2482020-06-10T14:07:15 *** justanotheruser has joined #bitcoin-core-dev
2492020-06-10T14:09:49 <shesek> harding, I reported this at https://github.com/bitcoin/bitcoin/issues/19236
2502020-06-10T14:13:01 *** lightlike has joined #bitcoin-core-dev
2512020-06-10T14:15:07 <shesek> is there a customary notation for referring to the nth script of a descriptor identified by its checksum? something like <checksum>/<index>, akin to <bip32-fingerprint>/<index>?
2522020-06-10T14:19:01 <provoostenator> Hardware wallet support write up: https://gist.github.com/Sjors/29d06728c685e6182828c1ce9b74483d
2532020-06-10T14:19:08 *** lightlike has quit IRC
2542020-06-10T14:23:16 *** dfmb_ has quit IRC
2552020-06-10T14:25:13 *** Kiminuo has quit IRC
2562020-06-10T14:25:50 *** bitcoin-git has joined #bitcoin-core-dev
2572020-06-10T14:25:50 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/371a73e94043...6762a627ecb8
2582020-06-10T14:25:51 <bitcoin-git> bitcoin/master c75de5d Pieter Wuille: [TESTS] Move base58 to own module to break circular dependency
2592020-06-10T14:25:52 <bitcoin-git> bitcoin/master 6762a62 MarcoFalke: Merge #19230: [TESTS] Move base58 to own module to break circular dependen...
2602020-06-10T14:25:53 *** bitcoin-git has left #bitcoin-core-dev
2612020-06-10T14:26:10 *** bitcoin-git has joined #bitcoin-core-dev
2622020-06-10T14:26:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19230: [TESTS] Move base58 to own module to break circular dependency (master...202006_addr_base58) https://github.com/bitcoin/bitcoin/pull/19230
2632020-06-10T14:26:11 *** bitcoin-git has left #bitcoin-core-dev
2642020-06-10T14:26:27 *** jarthur has joined #bitcoin-core-dev
2652020-06-10T14:26:51 *** justanotheruser has quit IRC
2662020-06-10T14:30:34 *** S3RK has joined #bitcoin-core-dev
2672020-06-10T14:34:55 *** S3RK has quit IRC
2682020-06-10T14:40:08 *** bitcoin-git has joined #bitcoin-core-dev
2692020-06-10T14:40:09 <bitcoin-git> [bitcoin] elichai opened pull request #19237: Check size after unserializing a pubkey (master...2020-06-pubkey) https://github.com/bitcoin/bitcoin/pull/19237
2702020-06-10T14:40:10 *** bitcoin-git has left #bitcoin-core-dev
2712020-06-10T14:41:47 *** sipsorcery has quit IRC
2722020-06-10T14:54:58 *** sipsorcery has joined #bitcoin-core-dev
2732020-06-10T14:55:33 *** IGHOR has joined #bitcoin-core-dev
2742020-06-10T14:59:53 *** Chris_Stewart_5 has quit IRC
2752020-06-10T15:00:02 *** RiscTaker1 has quit IRC
2762020-06-10T15:00:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2772020-06-10T15:16:53 *** justanotheruser has joined #bitcoin-core-dev
2782020-06-10T15:24:05 <provoostenator> For some reason Travis isn't running on #15382, but I don't think my account is flagged (this time)...
2792020-06-10T15:24:08 <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
2802020-06-10T15:24:41 <wumpus> provoostenator: nice, thanks for writing that up
2812020-06-10T15:26:50 <jonatack> thanks provoostenator
2822020-06-10T15:29:59 *** Relis has quit IRC
2832020-06-10T15:30:11 *** justanotheruser has quit IRC
2842020-06-10T15:35:26 *** owowo has joined #bitcoin-core-dev
2852020-06-10T15:35:26 *** owowo has joined #bitcoin-core-dev
2862020-06-10T15:40:06 *** bitcoin-git has joined #bitcoin-core-dev
2872020-06-10T15:40:07 <bitcoin-git> [bitcoin] hebasto opened pull request #19238: refactor: Replace RecursiveMutex with Mutex in CAddrMan (master...200610-addrman-mx) https://github.com/bitcoin/bitcoin/pull/19238
2882020-06-10T15:40:07 *** bitcoin-git has left #bitcoin-core-dev
2892020-06-10T15:42:08 *** Kiminuo has joined #bitcoin-core-dev
2902020-06-10T15:43:06 *** Relis has joined #bitcoin-core-dev
2912020-06-10T15:56:23 <Kiminuo> wumpus, Hi, I have been investigating std::filesystem in c++17 a bit (see https://github.com/bitcoin/bitcoin/pull/19183#issuecomment-641321318) and I would like to lay the groundwork for a worthy PR. I'm just wondering whether you would be willing to answer a few questions along the way - given that you know the old issues with boost::filesystem.
2922020-06-10T15:56:24 *** dfmb_ has joined #bitcoin-core-dev
2932020-06-10T15:57:24 *** vasild has quit IRC
2942020-06-10T16:01:18 *** justanotheruser has joined #bitcoin-core-dev
2952020-06-10T16:02:14 *** vasild has joined #bitcoin-core-dev
2962020-06-10T16:13:06 *** bitcoin-git has joined #bitcoin-core-dev
2972020-06-10T16:13:06 <bitcoin-git> [bitcoin] jnewbery opened pull request #19239: tests: move generate_wif_key to wallet_util.py (master...2020-06-generate-wif-key) https://github.com/bitcoin/bitcoin/pull/19239
2982020-06-10T16:13:07 *** bitcoin-git has left #bitcoin-core-dev
2992020-06-10T16:23:14 *** proofofk_ has joined #bitcoin-core-dev
3002020-06-10T16:23:43 *** vasild has quit IRC
3012020-06-10T16:24:33 *** proofofkeags has quit IRC
3022020-06-10T16:25:32 *** vasild has joined #bitcoin-core-dev
3032020-06-10T16:27:36 *** Talkless has joined #bitcoin-core-dev
3042020-06-10T16:29:08 *** justanotheruser has quit IRC
3052020-06-10T16:35:27 <wumpus> Kiminuo: sure! though, I'm not sure I'm aware of all the old issues with boost::filesystem, just that there's a long history of them
3062020-06-10T16:37:28 <wumpus> (and as said I'm most worried about windows support, it tends to be that the mingw c++ library support lags beind unix/linux â but if it passes all the unit and functional tests even on that platform it's a good indication at least )
3072020-06-10T16:45:42 *** andrewtoth has joined #bitcoin-core-dev
3082020-06-10T16:53:43 <Kiminuo> wumpus, well, I have two projects in MSVS, one with boost and one with c++17 and so far I have problems with unicode in boost project but c++17 & unicode works well for me - I use fs::u8path (https://en.cppreference.com/w/cpp/filesystem/path/u8path) and not fs::path. This makes me believe that c++17 may actually help with unicode issues. No guarantees at this point though. It's just it may not be that crazy idea to change fs::path -> fs:u8path.
3092020-06-10T16:53:43 <Kiminuo> But it's very hard for me to assess whether it's a good idea or not and if it sounds good whether there are corner cases (different platforms, different Bitcoin features,...)
3102020-06-10T16:56:43 <Kiminuo> One notable new issue with c++17 is that fs::unique_path is not implemented because https://stackoverflow.com/questions/43316527/what-is-the-c17-equivalent-to-boostfilesystemunique-path
3112020-06-10T16:57:09 <Kiminuo> However, the implementation is not that hard https://github.com/boostorg/filesystem/blob/boost-1.73.0/src/unique_path.cpp#L127
3122020-06-10T16:57:31 <Kiminuo> Lot's of things :)
3132020-06-10T16:57:36 *** S3RK has joined #bitcoin-core-dev
3142020-06-10T17:02:10 *** S3RK has quit IRC
3152020-06-10T17:02:28 *** dfmb_ has quit IRC
3162020-06-10T17:02:47 *** mol_ has joined #bitcoin-core-dev
3172020-06-10T17:03:23 *** filchef has joined #bitcoin-core-dev
3182020-06-10T17:05:54 *** mol has quit IRC
3192020-06-10T17:11:42 *** rafalcpp has quit IRC
3202020-06-10T17:14:17 *** justanotheruser has joined #bitcoin-core-dev
3212020-06-10T17:17:29 *** rafalcpp has joined #bitcoin-core-dev
3222020-06-10T17:33:48 *** promag has joined #bitcoin-core-dev
3232020-06-10T17:37:04 *** promag has quit IRC
3242020-06-10T17:48:18 <sipsorcery> Kiminuo: If you need I can check/help with changes to the file path logic on Windows.
3252020-06-10T17:49:07 <sipsorcery> iirc there were a few PR's to fix some Windows unicode issues a year or so ago.
3262020-06-10T17:49:50 <Kiminuo> sipsorcery, great! I'll try to prepare a draft PR in coming days and it will be great to collaborate on that then :-)
3272020-06-10T17:50:31 <Kiminuo> sipsorcery, if you know about any of that issue, could you send a link? It would be helpful to compile a list of those issues to make review easier
3282020-06-10T17:50:47 <sipa> Kiminuo: i briefly looked into replacing fs with something std::filesystem based, but didn't get very far
3292020-06-10T17:51:02 <sipa> i did notice that it'd require a separate unique_path
3302020-06-10T17:51:07 <sipsorcery> It'd be great to get rid of the Win32 CreateDirectoryA/CreateDirectoryW etc calls and replace with std library calls.
3312020-06-10T17:51:14 <sipsorcery> I'll dig up the PR's.
3322020-06-10T17:51:44 <Kiminuo> sipa, Yes, it's true about the unique_path, unfortunately. But given a random generator, one can generate a random file name, right?
3332020-06-10T17:52:07 <sipa> sure
3342020-06-10T17:52:09 <Kiminuo> sipsorcery, thank you
3352020-06-10T17:53:48 <sipsorcery> https://github.com/bitcoin/bitcoin/issues/13103
3362020-06-10T17:53:55 <sipsorcery> https://github.com/bitcoin/bitcoin/pull/13787
3372020-06-10T17:55:32 <provoostenator> #13103 #13787 (for previews)
3382020-06-10T17:55:33 <gribble> https://github.com/bitcoin/bitcoin/issues/13103 | Invalid wallet path with Chinese characters in windows · Issue #13103 · bitcoin/bitcoin · GitHub
3392020-06-10T17:55:35 <gribble> https://github.com/bitcoin/bitcoin/issues/13787 | Test for Windows encoding issue by ken2812221 · Pull Request #13787 · bitcoin/bitcoin · GitHub
3402020-06-10T17:56:07 <Kiminuo> I know about this: https://github.com/bitcoin/bitcoin/pull/6093 it's very old though
3412020-06-10T17:58:20 <sipsorcery> Upstream PR from leveldb that has been merged into Bitcoin Core https://github.com/google/leveldb/pull/760
3422020-06-10T18:02:29 *** andrewtoth has quit IRC
3432020-06-10T18:02:55 *** rafalcpp has quit IRC
3442020-06-10T18:06:14 *** lightlike has joined #bitcoin-core-dev
3452020-06-10T18:09:25 *** rafalcpp has joined #bitcoin-core-dev
3462020-06-10T18:10:56 *** MM77788811 has joined #bitcoin-core-dev
3472020-06-10T18:13:51 *** MM77788811 has quit IRC
3482020-06-10T18:15:39 *** AaronvanW has joined #bitcoin-core-dev
3492020-06-10T18:22:06 *** zepheiryan has joined #bitcoin-core-dev
3502020-06-10T18:32:33 *** sdaftuar has quit IRC
3512020-06-10T18:33:22 *** sdaftuar has joined #bitcoin-core-dev
3522020-06-10T18:42:06 *** peechay has joined #bitcoin-core-dev
3532020-06-10T18:42:11 *** peechay has left #bitcoin-core-dev
3542020-06-10T18:47:14 *** lightlike has quit IRC
3552020-06-10T18:52:00 <Kiminuo> *thumbs up*
3562020-06-10T18:56:43 *** harrigan has quit IRC
3572020-06-10T18:56:53 *** harrigan has joined #bitcoin-core-dev
3582020-06-10T19:15:04 *** Talkless has quit IRC
3592020-06-10T19:15:32 *** pretyflaco1 has joined #bitcoin-core-dev
3602020-06-10T19:19:55 *** pretyflaco has quit IRC
3612020-06-10T19:23:33 *** lightlike has joined #bitcoin-core-dev
3622020-06-10T19:26:44 *** Highway61 has quit IRC
3632020-06-10T19:27:43 *** Highway61 has joined #bitcoin-core-dev
3642020-06-10T19:31:19 *** dviola has quit IRC
3652020-06-10T19:32:14 *** Highway61 has quit IRC
3662020-06-10T19:32:53 *** dviola has joined #bitcoin-core-dev
3672020-06-10T19:33:22 *** Highway61 has joined #bitcoin-core-dev
3682020-06-10T19:38:43 <achow101> i have a possibly very dumb idea: hack sqlite's btree module to use the bdb file format
3692020-06-10T19:45:56 <sipa> why...?
3702020-06-10T19:48:04 <achow101> to keep backwards compatibility and avoid all of the issues with refactoring existing bdb handling code
3712020-06-10T19:48:20 <achow101> i also haven't thought this through at all
3722020-06-10T19:48:47 <sipa> it sounds like combining the worst of all worlds :)
3732020-06-10T19:49:32 <sipa> bdb dependency, complexity of sqlite, and still have a new file format that's not compatible with old software
3742020-06-10T19:50:39 <achow101> I think it would be compatible with old software and still remove the bdb dependency
3752020-06-10T19:50:59 <luke-jr> O.o
3762020-06-10T19:50:59 <achow101> the only reason I thought of this was because I found sqlightning which is sqlite but using lmdb as the btree module
3772020-06-10T19:51:07 <luke-jr> so you mean reimplementing bdb?
3782020-06-10T19:51:15 <achow101> only the file format
3792020-06-10T19:51:41 <luke-jr> also, bdb has no concept of tables/etc
3802020-06-10T19:52:09 <luke-jr> 2) sqlite doesn't accept outside patches, 3) it would take years for distros to release this version
3812020-06-10T19:52:28 <sipa> if you seriously want to implement bdb's file format, please revive logdb instead
3822020-06-10T19:53:23 <achow101> the idea was to just be able to toss out the existing bdb handling code without breaking existing compatibility
3832020-06-10T19:54:05 <sipa> i'm very confused by what you're suggesting then
3842020-06-10T19:54:52 <achow101> basically use sqlite but have it read and write bdb format files. so new wallets can still be opened by old software and old wallets opened by new
3852020-06-10T19:55:22 <achow101> so we can use sqlite's acid guarantees and easier implementation but still remain compatible
3862020-06-10T19:55:48 <achow101> and not have to maintain the separate stuff to deal with bdb
3872020-06-10T19:56:05 <achow101> that was the half baked idea
3882020-06-10T19:59:05 <luke-jr> achow101: I don't see how sqlite is easier to implement.. or what problems we have from bdb
3892020-06-10T19:59:08 <luke-jr> it seems to be working fine
3902020-06-10T20:00:16 <achow101> luke-jr: in the refactor to prepare for other db systems, there's a few questions about whether that has introduced regressions because it's difficult to work out the exact flushing and closing behavior
3912020-06-10T20:00:19 <sipa> achow101: i'm baffled how you think introducing sqlite would not break compatibility
3922020-06-10T20:00:56 <achow101> sipa: because we would be modifying it to write data in the same way bdb does
3932020-06-10T20:00:57 <luke-jr> achow101: okay, but the fact is right now we have years of no problems
3942020-06-10T20:01:06 <achow101> luke-jr: no?
3952020-06-10T20:01:09 <sipa> achow101: then what's the point?
3962020-06-10T20:01:19 <sipa> that seems like a huge task for no gain
3972020-06-10T20:01:29 <luke-jr> achow101: ?
3982020-06-10T20:01:38 <achow101> sipa: then old software would still be able to read those files
3992020-06-10T20:01:55 <sipa> achow101: i must be missing something
4002020-06-10T20:02:39 <achow101> sipa: sqlite does a bunch of other things unrelated to the storage format to guarantee consistency
4012020-06-10T20:02:47 <achow101> so we would be able to take advantage of those
4022020-06-10T20:02:52 <achow101> and just have a different file format
4032020-06-10T20:03:53 <sipa> it seems the cost/benefit of such an effort are about 100x worse than staying with bdb, or switching to logdb
4042020-06-10T20:05:38 *** MM77788811 has joined #bitcoin-core-dev
4052020-06-10T20:05:42 <achow101> it seemed to me to be easier to implement/copy a file format implementation than to logic my way through when and how to flush and close bdb for the refactor
4062020-06-10T20:05:56 <luke-jr> achow101: what problems do you think need solving?
4072020-06-10T20:06:36 <sipa> making (a) a new backend to sqlite and (b) making and keeping it compatible with bdb eaxh individually seem like far more work (in implementation+testing/qa combined) then just creating a dumb key/value store from scratch
4082020-06-10T20:07:06 *** MM77788811 has quit IRC
4092020-06-10T20:07:40 <sipa> the advantage of sqlite is getting a well-tested robust format and implementation for free; if it needs large customization, i don't see why we'd even pick it in the first place
4102020-06-10T20:07:50 *** lightlike has quit IRC
4112020-06-10T20:08:06 *** lightlike has joined #bitcoin-core-dev
4122020-06-10T20:08:23 <luke-jr> sipa: bdb4.8 is currently/already well-tested and robust in our usage though
4132020-06-10T20:08:51 <luke-jr> only point in switching to sqlite IMO is if we want to use the relational features
4142020-06-10T20:11:27 <achow101> sipa: to take advantage of how they do atomic commits, do locking and concurrency, etc. the things which are independent of the file format itself.
4152020-06-10T20:11:47 <sipa> i don't comprehend how that can seem worth it
4162020-06-10T20:13:37 <achow101> for example, sqlite flushes to the database file after every write. this behavior is independent of the database file. because it does this, we could remove the need for PeriodicFlush. We would remove the need for WalletDatabase::Flush entirely
4172020-06-10T20:13:56 <sipa> ok?
4182020-06-10T20:14:15 <sipa> and that's worth a huge engineering effort to develop and maintain a new backend to sqlite?
4192020-06-10T20:14:23 <sipa> to avoid a wrapper in our logic?
4202020-06-10T20:15:03 <luke-jr> one advantage of bdb is since it isn't maintained, what we learn about its inner workings *won't* change :p
4212020-06-10T20:15:04 <achow101> depends on how huge the engineering effort is
4222020-06-10T20:15:15 <achow101> we have a lot of very confusing logic in our code related to flushing
4232020-06-10T20:15:32 *** Asbestos_Vapor has quit IRC
4242020-06-10T20:15:36 <luke-jr> achow101: we *could* just flush on every change to bdb
4252020-06-10T20:15:55 <luke-jr> there might be reasons we don't, but if so, then switching to sqlite would have the same problems
4262020-06-10T20:16:04 <achow101> and the flushing logic is the cause of a lot of confusion in the refactor
4272020-06-10T20:16:18 <sipa> i'm sure we'll get through that
4282020-06-10T20:16:33 <achow101> luke-jr: we do "flush", but it flushes to the transaction log, not the database file
4292020-06-10T20:16:41 <wumpus> I like using sqlite, to be honest, I don't think rolling a new database just for bitcoin core's database is a good idea, yes a dumb store would be enough for key storage, but for transactions it's likely that some more advanced query functionality would be useful at some point
4302020-06-10T20:17:00 <sipa> wumpus: i just sqlite because it's so well tested
4312020-06-10T20:17:04 <sipa> *like
4322020-06-10T20:17:06 <achow101> and getting it to flush into the database file is, apparently, a major task and pain in the ass
4332020-06-10T20:17:13 <achow101> but trivial for sqlite
4342020-06-10T20:17:44 <wumpus> it's also very well tested
4352020-06-10T20:17:47 <wumpus> agree
4362020-06-10T20:18:16 <luke-jr> sipa: but so is db4.8 specifically in our use
4372020-06-10T20:19:16 <sipa> and maintained
4382020-06-10T20:19:17 <wumpus> achow101: yes, the flush has never really been a flush but 'database consolidation'
4392020-06-10T20:19:42 <wumpus> (which happens to also do a flush, but that's not the point, the point was to have things in one file)
4402020-06-10T20:20:21 <luke-jr> if you want things in one file, look at what backupwallet does
4412020-06-10T20:22:56 *** bitcoin-git has joined #bitcoin-core-dev
4422020-06-10T20:22:56 <bitcoin-git> [bitcoin] dongcarl opened pull request #19240: 2020 06 macos sdkgen simplify (master...2020-06-macos-sdkgen-simplify) https://github.com/bitcoin/bitcoin/pull/19240
4432020-06-10T20:23:06 *** bitcoin-git has left #bitcoin-core-dev
4442020-06-10T20:24:09 *** lightlike has quit IRC
4452020-06-10T20:25:02 *** promag has joined #bitcoin-core-dev
4462020-06-10T20:25:45 *** bitcoin-git has joined #bitcoin-core-dev
4472020-06-10T20:25:45 <bitcoin-git> [bitcoin] dongcarl closed pull request #18072: Use `libc++` headers from macOS SDK instead of from clang (master...2020-01-macos-sdk-with-headers) https://github.com/bitcoin/bitcoin/pull/18072
4482020-06-10T20:25:46 *** bitcoin-git has left #bitcoin-core-dev
4492020-06-10T20:31:23 *** ycshao has joined #bitcoin-core-dev
4502020-06-10T20:32:43 <ycshao> Anyone has suggestions to how to fix travis failure of https://github.com/bitcoin/bitcoin/pull/19208? I took a look and don't think the failure is caused by my change.
4512020-06-10T20:36:04 *** ycshao has quit IRC
4522020-06-10T20:37:56 *** ycshao has joined #bitcoin-core-dev
4532020-06-10T20:38:10 <ycshao> A related question is do all CIs have to pass before PR can be merged? I saw a few PRs merged with failed CI, like this one https://github.com/bitcoin/bitcoin/pull/19201#partial-pull-merging
4542020-06-10T20:39:21 <sipa> ycshao: there currently are two unrelated issues that break CI regularly in master
4552020-06-10T20:39:24 <sipa> they'll be fixed soon
4562020-06-10T20:39:29 <sipa> they're not your fault
4572020-06-10T20:40:13 <ycshao> Got it sipa.
4582020-06-10T20:45:11 <ycshao> I always got disconnected from the channel after some time. Is this a channel setting or on my client side?
4592020-06-10T20:47:17 <sipa> it seems like a problem on your side
4602020-06-10T20:49:56 *** promag has quit IRC
4612020-06-10T20:50:17 *** troygiorshev has quit IRC
4622020-06-10T20:53:05 *** filchef has quit IRC
4632020-06-10T20:54:50 *** ycshao has quit IRC
4642020-06-10T20:57:28 *** promag has joined #bitcoin-core-dev
4652020-06-10T20:57:45 *** promag has quit IRC
4662020-06-10T20:57:57 *** promag has joined #bitcoin-core-dev
4672020-06-10T21:00:02 *** zepheiryan has quit IRC
4682020-06-10T21:22:20 *** Kiminuo has quit IRC
4692020-06-10T21:22:29 *** flo1 has joined #bitcoin-core-dev
4702020-06-10T21:23:11 *** ycshao has joined #bitcoin-core-dev
4712020-06-10T21:26:38 *** ycshao has joined #bitcoin-core-dev
4722020-06-10T21:28:01 *** ycshao has quit IRC
4732020-06-10T21:32:31 *** Guyver2 has quit IRC
4742020-06-10T21:32:53 *** ycshao has joined #bitcoin-core-dev
4752020-06-10T21:33:41 *** justanotheruser has quit IRC
4762020-06-10T21:51:14 *** justanotheruser has joined #bitcoin-core-dev
4772020-06-10T22:26:49 *** S3RK has joined #bitcoin-core-dev
4782020-06-10T22:26:54 *** dfmb_ has joined #bitcoin-core-dev
4792020-06-10T22:30:57 *** promag has quit IRC
4802020-06-10T22:31:34 *** S3RK has quit IRC
4812020-06-10T22:31:51 *** dfmb_ has quit IRC
4822020-06-10T22:34:35 *** promag has joined #bitcoin-core-dev
4832020-06-10T22:39:40 *** rafalcpp has quit IRC
4842020-06-10T22:46:01 *** bitdex has joined #bitcoin-core-dev
4852020-06-10T22:48:46 *** ycshao has quit IRC
4862020-06-10T22:49:53 *** Mercury_Vapor has joined #bitcoin-core-dev
4872020-06-10T22:57:37 *** Dean_Guss has quit IRC
4882020-06-10T22:57:50 *** Dean_Guss has joined #bitcoin-core-dev
4892020-06-10T23:06:11 *** justanotheruser has quit IRC
4902020-06-10T23:09:18 *** ycshao has joined #bitcoin-core-dev
4912020-06-10T23:10:54 *** ycshao has joined #bitcoin-core-dev
4922020-06-10T23:15:48 *** ycshao has quit IRC
4932020-06-10T23:35:54 *** justanotheruser has joined #bitcoin-core-dev
4942020-06-10T23:46:40 *** promag has quit IRC
4952020-06-10T23:59:17 <fanquake> ycshao: if you rebase on master both of those issues should now be fixed