12020-06-26T00:00:02 *** drewdrew has quit IRC
22020-06-26T00:21:57 *** brrr has joined #bitcoin-core-dev
32020-06-26T00:27:22 *** mol has joined #bitcoin-core-dev
42020-06-26T00:29:54 *** mol_ has quit IRC
52020-06-26T00:40:09 *** proofofkeags has quit IRC
62020-06-26T00:40:14 *** Bullitje has left #bitcoin-core-dev
72020-06-26T01:00:54 *** proofofkeags has joined #bitcoin-core-dev
82020-06-26T01:23:52 *** rodarmor has quit IRC
92020-06-26T01:40:04 *** dviola has joined #bitcoin-core-dev
102020-06-26T01:43:28 *** isis_ is now known as isis
112020-06-26T01:48:13 *** proofofkeags has quit IRC
122020-06-26T01:59:54 *** Highway61 has quit IRC
132020-06-26T02:11:43 *** bitdex has joined #bitcoin-core-dev
142020-06-26T02:18:40 *** shesek has quit IRC
152020-06-26T02:19:07 *** shesek has joined #bitcoin-core-dev
162020-06-26T02:19:07 *** shesek has joined #bitcoin-core-dev
172020-06-26T02:19:34 *** proofofkeags has joined #bitcoin-core-dev
182020-06-26T02:21:04 *** ppisati has quit IRC
192020-06-26T02:22:24 <cfields> sipa: did you use cppreference as a template for implementing span?
202020-06-26T02:23:12 <cfields> trying to figure out some weirdness.
212020-06-26T02:23:35 <sipa> cfields: yeah
222020-06-26T02:23:43 *** proofofkeags has quit IRC
232020-06-26T02:23:59 <sipa> but just because it lists a copy constructor doesn't mean the implementation needs one explicitly of course
242020-06-26T02:24:38 <cfields> sipa: sure, not concerned about that.
252020-06-26T02:26:31 <cfields> sipa: I believe cppreference is using an outdated draft. Just wanted to see if that's what you were going by.
262020-06-26T02:26:43 <cfields> will dig deeper tomorrow.
272020-06-26T02:27:52 <sipa> cfields: at least it's up to date with using size_t as size type (it used to be ssize_t in an even older draft)
282020-06-26T02:29:22 <cfields> sipa: aha, right. Thanks, that helps.
292020-06-26T02:42:37 <cfields> sipa: specifically, ctor #7 is absent from the current draft: https://en.cppreference.com/w/cpp/container/span/span
302020-06-26T02:42:40 <gribble> https://github.com/bitcoin/bitcoin/issues/7 | Block-header-only, faster startup client · Issue #7 · bitcoin/bitcoin · GitHub
312020-06-26T02:42:57 <cfields> as implemented by libc++: https://github.com/llvm/llvm-project/blob/master/libcxx/include/span
322020-06-26T02:46:35 <sipa> cfields: cppreference.cpp is a wiki ;)
332020-06-26T02:48:20 <luke-jr> lol
342020-06-26T02:48:33 <cfields> haha, fair enough.
352020-06-26T02:48:45 <cfields> s/will dig deeper tomorrow/will perform surgery tomorrow/
362020-06-26T02:48:46 <cfields> :)
372020-06-26T02:52:51 *** proofofkeags has joined #bitcoin-core-dev
382020-06-26T02:55:42 <sipa> cfields: fwiw, https://godbolt.org/z/B5VHgu
392020-06-26T02:56:09 <sipa> gcc trunk works; no clang version on godbolt seems to support span at all
402020-06-26T02:57:09 <cfields> sipa: any chance there's a "g++ -stdlib=libc++" option ?
412020-06-26T02:58:59 *** Deacyde has joined #bitcoin-core-dev
422020-06-26T02:59:02 <sipa> g++: error: unrecognized command-line option '-stdlib=libc++'
432020-06-26T02:59:43 *** ppisati has joined #bitcoin-core-dev
442020-06-26T03:00:02 *** brrr has quit IRC
452020-06-26T03:00:02 <cfields> ok, thanks.
462020-06-26T03:00:20 <cfields> well I'm about 10 kinds of confused. Going to call it a night.
472020-06-26T03:00:25 <sipa> are you sure that's the right syntax?
482020-06-26T03:00:31 *** afk11` has quit IRC
492020-06-26T03:00:35 *** bitdex has quit IRC
502020-06-26T03:00:49 <sipa> i see no -stdlib=... documented in gcc's manpage
512020-06-26T03:00:58 *** bitdex has joined #bitcoin-core-dev
522020-06-26T03:01:21 <cfields> sipa: https://github.com/bitcoin/bitcoin/blob/master/depends/hosts/darwin.mk#L9
532020-06-26T03:01:26 *** afk11` has joined #bitcoin-core-dev
542020-06-26T03:01:32 <cfields> Oh, maybe gcc hasn't learned that? I could've sworn you could select it there too.
552020-06-26T03:02:15 <cfields> sipa: huh, guess you're right.
562020-06-26T03:02:28 *** tryphe_ is now known as tryphe
572020-06-26T03:05:32 *** EagleTM has joined #bitcoin-core-dev
582020-06-26T03:06:02 <fanquake> cfields: https://gcc.gnu.org/pipermail/gcc/2020-March/000230.html
592020-06-26T03:06:08 <fanquake> Maybe coming in GCC 11
602020-06-26T03:06:12 <sipa> https://libcxx.llvm.org/docs/UsingLibcxx.html#using-libc-with-gcc
612020-06-26T03:07:34 *** Eagle[TM] has quit IRC
622020-06-26T03:08:27 <cfields> sipa: that example compiles for me locally with clang and libc++. Another helpful data point, thanks.
632020-06-26T03:09:43 <cfields> fanquake: ah, nice :)
642020-06-26T03:10:10 *** Deacyde has quit IRC
652020-06-26T03:24:14 *** troygiorshev has quit IRC
662020-06-26T03:30:23 *** troygiorshev has joined #bitcoin-core-dev
672020-06-26T03:40:59 *** vasild_ has joined #bitcoin-core-dev
682020-06-26T03:43:43 *** vasild has quit IRC
692020-06-26T03:43:44 *** vasild_ is now known as vasild
702020-06-26T03:45:07 <sipa> cfields: constructor 7 is https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L62L65 and https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L226L240
712020-06-26T03:45:50 <sipa> they don't have an explicit universal reference constructor, instead relying on temporaries binding with const lvalue reference
722020-06-26T03:46:05 <sipa> that's a more elegant way of doing it actually
732020-06-26T03:46:11 *** S3RK has joined #bitcoin-core-dev
742020-06-26T03:54:39 <sipa> https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L400L410 actually
752020-06-26T03:55:00 *** daim2k5 has joined #bitcoin-core-dev
762020-06-26T04:08:12 *** proofofkeags has quit IRC
772020-06-26T04:08:44 *** proofofkeags has joined #bitcoin-core-dev
782020-06-26T04:12:55 *** proofofkeags has quit IRC
792020-06-26T04:12:56 *** troygiorshev has quit IRC
802020-06-26T04:13:50 *** troygiorshev has joined #bitcoin-core-dev
812020-06-26T04:35:16 *** ghost43 has quit IRC
822020-06-26T04:36:03 *** ghost43 has joined #bitcoin-core-dev
832020-06-26T04:59:02 *** rh0nj has quit IRC
842020-06-26T05:00:08 *** rh0nj has joined #bitcoin-core-dev
852020-06-26T05:01:28 *** S3RK has quit IRC
862020-06-26T05:01:59 *** S3RK has joined #bitcoin-core-dev
872020-06-26T05:06:41 *** S3RK has quit IRC
882020-06-26T05:12:13 *** troygiorshev has quit IRC
892020-06-26T05:12:34 *** troygiorshev has joined #bitcoin-core-dev
902020-06-26T05:36:25 *** promag has joined #bitcoin-core-dev
912020-06-26T05:41:08 *** promag has quit IRC
922020-06-26T06:00:02 *** daim2k5 has quit IRC
932020-06-26T06:06:17 *** S3RK has joined #bitcoin-core-dev
942020-06-26T06:10:31 *** S3RK has quit IRC
952020-06-26T06:10:58 *** marcoagner has joined #bitcoin-core-dev
962020-06-26T06:12:04 *** S3RK has joined #bitcoin-core-dev
972020-06-26T06:16:51 *** S3RK has quit IRC
982020-06-26T06:22:05 *** iMast777 has joined #bitcoin-core-dev
992020-06-26T06:51:07 *** nullptr| has joined #bitcoin-core-dev
1002020-06-26T06:57:11 *** jonatack has joined #bitcoin-core-dev
1012020-06-26T07:09:50 *** S3RK has joined #bitcoin-core-dev
1022020-06-26T07:13:54 *** S3RK has quit IRC
1032020-06-26T07:31:37 *** S3RK has joined #bitcoin-core-dev
1042020-06-26T08:01:10 *** RCasatta has joined #bitcoin-core-dev
1052020-06-26T08:08:29 *** S3RK has quit IRC
1062020-06-26T08:09:52 *** dr-orlovsky has joined #bitcoin-core-dev
1072020-06-26T08:15:33 *** AaronvanW has joined #bitcoin-core-dev
1082020-06-26T08:27:03 *** promag has joined #bitcoin-core-dev
1092020-06-26T08:35:42 *** Pavlenex has joined #bitcoin-core-dev
1102020-06-26T08:43:50 *** Mercury_Vapor has quit IRC
1112020-06-26T08:44:16 *** Mercury_Vapor has joined #bitcoin-core-dev
1122020-06-26T08:47:37 *** S3RK has joined #bitcoin-core-dev
1132020-06-26T08:52:03 *** S3RK has quit IRC
1142020-06-26T09:00:02 *** iMast777 has quit IRC
1152020-06-26T09:12:07 *** dr-orlovsky has quit IRC
1162020-06-26T09:21:14 *** Squidicc has quit IRC
1172020-06-26T09:22:06 *** omega8cc has joined #bitcoin-core-dev
1182020-06-26T09:35:53 *** S3RK has joined #bitcoin-core-dev
1192020-06-26T09:36:13 *** RCasatta has quit IRC
1202020-06-26T10:03:20 *** Arturo11Mayer has joined #bitcoin-core-dev
1212020-06-26T10:06:25 *** omega8cc has quit IRC
1222020-06-26T10:20:41 *** bitcoin-git has joined #bitcoin-core-dev
1232020-06-26T10:20:41 <bitcoin-git> [bitcoin] S3RK opened pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
1242020-06-26T10:20:48 *** bitcoin-git has left #bitcoin-core-dev
1252020-06-26T10:23:32 *** dr-orlovsky has joined #bitcoin-core-dev
1262020-06-26T10:25:22 *** Arturo11Mayer has quit IRC
1272020-06-26T10:28:21 *** Alphi has joined #bitcoin-core-dev
1282020-06-26T10:51:47 *** reallll has joined #bitcoin-core-dev
1292020-06-26T10:55:09 *** belcher has quit IRC
1302020-06-26T10:58:40 *** reallll is now known as belcher
1312020-06-26T11:29:27 *** S3RK has quit IRC
1322020-06-26T11:30:03 *** S3RK has joined #bitcoin-core-dev
1332020-06-26T11:34:04 *** S3RK_ has joined #bitcoin-core-dev
1342020-06-26T11:34:05 *** S3RK has quit IRC
1352020-06-26T11:38:27 *** S3RK_ has quit IRC
1362020-06-26T11:39:04 *** dr-orlovsky has quit IRC
1372020-06-26T11:49:13 *** dr-orlovsky has joined #bitcoin-core-dev
1382020-06-26T11:53:02 *** sdaftuar has quit IRC
1392020-06-26T11:53:28 *** sdaftuar has joined #bitcoin-core-dev
1402020-06-26T11:54:32 *** mol_ has joined #bitcoin-core-dev
1412020-06-26T11:57:49 *** mol has quit IRC
1422020-06-26T12:00:02 *** Alphi has quit IRC
1432020-06-26T12:22:00 *** ogelbukh has joined #bitcoin-core-dev
1442020-06-26T12:32:53 *** Highway61 has joined #bitcoin-core-dev
1452020-06-26T12:42:17 *** Guyver2 has joined #bitcoin-core-dev
1462020-06-26T12:52:50 *** SteveyG has joined #bitcoin-core-dev
1472020-06-26T12:57:03 *** SteveyG has quit IRC
1482020-06-26T13:15:30 *** Eagle[TM] has joined #bitcoin-core-dev
1492020-06-26T13:15:44 *** molz_ has joined #bitcoin-core-dev
1502020-06-26T13:16:34 *** EagleTM has quit IRC
1512020-06-26T13:18:35 *** mol_ has quit IRC
1522020-06-26T13:21:39 *** dr-orlovsky has quit IRC
1532020-06-26T13:25:25 *** Pavlenex has quit IRC
1542020-06-26T13:26:53 *** Pavlenex has joined #bitcoin-core-dev
1552020-06-26T13:42:33 *** mol has joined #bitcoin-core-dev
1562020-06-26T13:44:34 *** molz_ has quit IRC
1572020-06-26T14:05:52 *** bitcoin-git has joined #bitcoin-core-dev
1582020-06-26T14:05:53 <bitcoin-git> [bitcoin] yancyribbens opened pull request #19385: test: Change default test logging directory (master...unit-log-location) https://github.com/bitcoin/bitcoin/pull/19385
1592020-06-26T14:05:53 *** bitcoin-git has left #bitcoin-core-dev
1602020-06-26T14:20:01 *** sipsorcery has quit IRC
1612020-06-26T14:30:14 *** promag has quit IRC
1622020-06-26T14:34:19 *** Guyver2 has quit IRC
1632020-06-26T14:40:02 *** sipsorcery has joined #bitcoin-core-dev
1642020-06-26T14:42:58 *** kljasdfvv has quit IRC
1652020-06-26T14:47:34 *** Highway61 has quit IRC
1662020-06-26T14:47:53 *** Highway61 has joined #bitcoin-core-dev
1672020-06-26T14:52:25 *** troygiorshev has quit IRC
1682020-06-26T14:52:52 *** troygiorshev has joined #bitcoin-core-dev
1692020-06-26T14:54:04 *** mol_ has joined #bitcoin-core-dev
1702020-06-26T14:56:50 *** mol has quit IRC
1712020-06-26T14:58:51 *** gribble has quit IRC
1722020-06-26T15:00:02 *** ogelbukh has quit IRC
1732020-06-26T15:03:18 *** jb55 has joined #bitcoin-core-dev
1742020-06-26T15:10:37 *** bitdex has quit IRC
1752020-06-26T15:13:51 *** gribble has joined #bitcoin-core-dev
1762020-06-26T15:16:10 <cfields> sipa: right, sorry, I didn't mean to imply that the construction was no longer possible. Only that it's no longer a universal reference.
1772020-06-26T15:17:15 *** Pavlenex has quit IRC
1782020-06-26T15:21:13 *** leafstorm has joined #bitcoin-core-dev
1792020-06-26T15:40:37 *** Talkless has joined #bitcoin-core-dev
1802020-06-26T15:40:46 *** promag has joined #bitcoin-core-dev
1812020-06-26T15:44:03 *** vasild has quit IRC
1822020-06-26T15:47:03 *** alko89 has joined #bitcoin-core-dev
1832020-06-26T15:50:03 *** molz_ has joined #bitcoin-core-dev
1842020-06-26T15:52:56 *** mol_ has quit IRC
1852020-06-26T16:01:37 *** proofofkeags has joined #bitcoin-core-dev
1862020-06-26T16:04:21 *** molz_ has quit IRC
1872020-06-26T16:04:45 *** molz_ has joined #bitcoin-core-dev
1882020-06-26T16:06:09 *** vasild has joined #bitcoin-core-dev
1892020-06-26T16:12:52 *** troygiorshev has quit IRC
1902020-06-26T16:13:58 *** troygiorshev has joined #bitcoin-core-dev
1912020-06-26T16:27:01 *** Pavlenex has joined #bitcoin-core-dev
1922020-06-26T16:35:57 *** Guyver2 has joined #bitcoin-core-dev
1932020-06-26T16:41:58 *** mol has joined #bitcoin-core-dev
1942020-06-26T16:43:36 *** troygiorshev has quit IRC
1952020-06-26T16:43:55 *** troygiorshev has joined #bitcoin-core-dev
1962020-06-26T16:44:19 *** Talkless has quit IRC
1972020-06-26T16:44:43 *** Pavlenex has quit IRC
1982020-06-26T16:44:47 *** molz_ has quit IRC
1992020-06-26T16:45:39 *** proofofkeags has quit IRC
2002020-06-26T16:46:06 *** proofofkeags has joined #bitcoin-core-dev
2012020-06-26T16:49:04 *** mol_ has joined #bitcoin-core-dev
2022020-06-26T16:51:00 *** proofofkeags has quit IRC
2032020-06-26T16:52:05 *** mol has quit IRC
2042020-06-26T16:53:33 *** justan0theruser has quit IRC
2052020-06-26T16:57:19 *** proofofkeags has joined #bitcoin-core-dev
2062020-06-26T17:05:07 *** kristapsk has quit IRC
2072020-06-26T17:10:05 *** mol has joined #bitcoin-core-dev
2082020-06-26T17:12:47 *** mol_ has quit IRC
2092020-06-26T17:19:22 *** justan0theruser has joined #bitcoin-core-dev
2102020-06-26T17:20:07 *** mol_ has joined #bitcoin-core-dev
2112020-06-26T17:22:34 *** mol has quit IRC
2122020-06-26T17:22:44 *** proofofkeags has quit IRC
2132020-06-26T17:23:11 *** proofofkeags has joined #bitcoin-core-dev
2142020-06-26T17:25:06 <cfields> sipa: I'm regretting starting down this path now, I don't think it's really worth the effort. I'm mainly seeing it through now as a learning experience...
2152020-06-26T17:25:11 <cfields> that said.. what do you think of this: https://github.com/theuni/bitcoin/commit/bb75cdf5634da606fb592b462b3ca24fc818cfdb ?
2162020-06-26T17:26:07 <cfields> That ensures that trivial copies are sent through the trivial constructor, and splits out the const reference case so that we can apply lifetimebound specifically to it.
2172020-06-26T17:27:21 *** Pavlenex has joined #bitcoin-core-dev
2182020-06-26T17:27:35 <sipa> any reason why you wouldn't want the lifetimebound on both?
2192020-06-26T17:27:43 *** proofofkeags has quit IRC
2202020-06-26T17:27:51 <sipa> ah, because temporaries just wouldn't bind against the mutable lvalue reference one?
2212020-06-26T17:28:05 <cfields> Right, no reason other than I don't see the need.
2222020-06-26T17:28:13 <sipa> but as i understand it, there is no harm in applying it to both
2232020-06-26T17:28:41 <cfields> sure, not opposed.
2242020-06-26T17:29:22 <sipa> in the second one, i think you need const V in the type checks?
2252020-06-26T17:30:05 <cfields> yup, nice catch.
2262020-06-26T17:30:34 <sipa> also, does that compile? it looks like the template argument to std::enable_if<... is not closed
2272020-06-26T17:30:47 <sipa> oh, it is
2282020-06-26T17:30:48 <sipa> nvm
2292020-06-26T17:31:09 <cfields> hehe. it's an arg enable_if now, not a template one.
2302020-06-26T17:31:47 <sipa> ah, is that preferable?
2312020-06-26T17:33:19 <sipa> i think it makes sense to more closely match the exact conditions used in an actual std lib
2322020-06-26T17:34:37 <cfields> that's why i switched it, I'm not sure if it's preferred though. Might be part of some overload matching rule that I'll never understand.
2332020-06-26T17:35:04 <sipa> i've had to fight with old compiler versions in travis a few times to make it work
2342020-06-26T17:35:23 <sipa> but i think this approach of splitting up const and nonconst is pretty elegant, and perhaps more likely to work
2352020-06-26T17:35:39 <sipa> *more likely to work on the first try
2362020-06-26T17:35:49 <cfields> oh, fun. guess I'll start that process.
2372020-06-26T17:37:00 <cfields> sipa: I'm guessing you didn't add the std::array overload because Extent isn't implemented?
2382020-06-26T17:38:11 *** mol has joined #bitcoin-core-dev
2392020-06-26T17:38:13 <cfields> std::array constructor, sorry.
2402020-06-26T17:38:32 <sipa> yeah, it should be captured by the container constructor
2412020-06-26T17:38:45 *** proofofkeags has joined #bitcoin-core-dev
2422020-06-26T17:39:24 <cfields> ack
2432020-06-26T17:39:24 *** proofofkeags has quit IRC
2442020-06-26T17:39:50 *** proofofkeags has joined #bitcoin-core-dev
2452020-06-26T17:39:58 <sipa> actually, the criterion to avoid arrays in your type expressions is superfluous too, i think
2462020-06-26T17:40:05 *** proofofkeags has quit IRC
2472020-06-26T17:40:08 <sipa> as arrays don't have .data() and .size() member functions
2482020-06-26T17:40:12 *** proofofk_ has joined #bitcoin-core-dev
2492020-06-26T17:40:21 *** proofofk_ has quit IRC
2502020-06-26T17:40:43 *** mol_ has quit IRC
2512020-06-26T17:40:59 <sipa> C++17 adds std::data and std::size, which generalize the data and size member functions to arrays
2522020-06-26T17:41:05 *** proofofkeags has joined #bitcoin-core-dev
2532020-06-26T17:41:07 <cfields> Aha, right... they use the newer generic data(foo) rather than foo.data(), which must have an overload
2542020-06-26T17:41:07 *** Pavlenex has quit IRC
2552020-06-26T17:41:50 <cfields> will remove
2562020-06-26T17:43:11 <hebasto> do we have a functional test for orphan tx eviction when a new block is connected? couldn't find it...
2572020-06-26T17:43:39 <sipa> hebasto: break it, and see if tests fail :)
2582020-06-26T17:43:53 <hebasto> yes!
2592020-06-26T17:44:01 <hebasto> thanks :)
2602020-06-26T17:44:54 <cfields> hehe
2612020-06-26T17:45:55 *** proofofkeags has quit IRC
2622020-06-26T17:47:13 *** alko89 has quit IRC
2632020-06-26T17:49:10 *** alko89 has joined #bitcoin-core-dev
2642020-06-26T17:49:15 *** Pavlenex has joined #bitcoin-core-dev
2652020-06-26T17:51:13 *** bitcoin-git has joined #bitcoin-core-dev
2662020-06-26T17:51:13 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19386: rpc: Assert that RPCArg names are equal to CRPCCommand ones (server) (master...2006-rpcManServer) https://github.com/bitcoin/bitcoin/pull/19386
2672020-06-26T17:51:14 *** bitcoin-git has left #bitcoin-core-dev
2682020-06-26T17:52:42 *** Pavlenex has quit IRC
2692020-06-26T17:57:06 <hebasto> I've broke a half of `PeerLogicValidation::BlockConnected()` but functional test passed... It seems we need more tests :)
2702020-06-26T18:00:02 *** leafstorm has quit IRC
2712020-06-26T18:04:23 *** bitcoin-git has joined #bitcoin-core-dev
2722020-06-26T18:04:23 <bitcoin-git> [bitcoin] theuni closed pull request #19382: span: Add lifetimebound attribute to guard against temporary lifetime issues (master...lifetimebound) https://github.com/bitcoin/bitcoin/pull/19382
2732020-06-26T18:04:34 *** bitcoin-git has left #bitcoin-core-dev
2742020-06-26T18:12:02 *** mol_ has joined #bitcoin-core-dev
2752020-06-26T18:15:22 *** mol has quit IRC
2762020-06-26T18:20:58 *** greynix has joined #bitcoin-core-dev
2772020-06-26T18:24:20 *** bitcoin-git has joined #bitcoin-core-dev
2782020-06-26T18:24:20 <bitcoin-git> [bitcoin] theuni opened pull request #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute (master...lifetimebound2) https://github.com/bitcoin/bitcoin/pull/19387
2792020-06-26T18:24:21 *** bitcoin-git has left #bitcoin-core-dev
2802020-06-26T18:30:37 *** vincenzopalazzo has joined #bitcoin-core-dev
2812020-06-26T18:45:29 *** bitcoin-git has joined #bitcoin-core-dev
2822020-06-26T18:45:29 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f32f7e907a5e...3bbd8225b92d
2832020-06-26T18:45:29 <bitcoin-git> bitcoin/master 1087807 practicalswift: tests: Provide main(...) function in fuzzer
2842020-06-26T18:45:30 <bitcoin-git> bitcoin/master 3bbd822 MarcoFalke: Merge #19366: tests: Provide main(...) function in fuzzer. Allow building ...
2852020-06-26T18:45:31 *** bitcoin-git has left #bitcoin-core-dev
2862020-06-26T18:45:49 *** bitcoin-git has joined #bitcoin-core-dev
2872020-06-26T18:45:49 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
2882020-06-26T18:45:50 *** bitcoin-git has left #bitcoin-core-dev
2892020-06-26T18:46:54 *** bitcoin-git has joined #bitcoin-core-dev
2902020-06-26T18:46:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bbd8225b92d...49464004701e
2912020-06-26T18:46:55 <bitcoin-git> bitcoin/master d906aaa Hennadii Stepanov: qt: Fix regression in TransactionTableModel
2922020-06-26T18:46:56 <bitcoin-git> bitcoin/master 4946400 MarcoFalke: Merge bitcoin-core/gui#8: Fix regression in TransactionTableModel
2932020-06-26T18:46:58 *** bitcoin-git has left #bitcoin-core-dev
2942020-06-26T18:54:31 *** kristapsk has joined #bitcoin-core-dev
2952020-06-26T18:59:33 <jamesob> do we have release signing pubkeys referenced anywhere in the repo?
2962020-06-26T19:03:39 *** kristapsk has quit IRC
2972020-06-26T19:05:54 *** kristapsk has joined #bitcoin-core-dev
2982020-06-26T19:20:23 <jamesob> (we do: https://github.com/bitcoin/bitcoin/tree/master/contrib/verifybinaries, though the key I retrieved differs from the one on bitcoin.org: https://bitcoin.org/laanwj-releases.asc)
2992020-06-26T19:30:31 *** splunkworth has joined #bitcoin-core-dev
3002020-06-26T19:32:05 *** splunkworth has quit IRC
3012020-06-26T19:35:21 *** Pavlenex has joined #bitcoin-core-dev
3022020-06-26T19:35:58 <luke-jr> should encourage people to use the gitian sigs more anyway imo
3032020-06-26T19:36:28 <jamesob> did we ever figure out distribution for asmap? is the recommended method just to use sipa's python repo and build it yourself?
3042020-06-26T19:36:40 *** Pavlenex has quit IRC
3052020-06-26T19:36:41 <sipa> jamesob: you're behind :p
3062020-06-26T19:36:57 <jamesob> too true
3072020-06-26T19:37:08 <sipa> the answer is no, but the encoder in https://github.com/bitcoin/bitcoin/pull/18573 is far better than my python scripts
3082020-06-26T19:38:05 <sipa> however, actually gathering the routing information... i don't really have a solution, except having some people build it independently and compare
3092020-06-26T19:40:20 <jamesob> would be nice to have a script in contrib that makes it easy to build one (with parameterized routing sources or something)
3102020-06-26T19:40:32 <sipa> and unless you have access to routing tables yourself like BlueMatt... you'll be relying on someone giving you a dump
3112020-06-26T19:40:41 <sipa> which necessarily puts trust in that entity
3122020-06-26T19:40:59 <sipa> there is https://github.com/rrybarczyk/asmap-rs
3132020-06-26T19:41:11 <sipa> (which only gathers/aggregates dumps, it doesn't encode)
3142020-06-26T19:43:49 <BlueMatt> right, given there's at least 3 public routing table dumps I'm aware of that can be found online, and likely many more possible, plus a few folks who have access to the routing table, I dont think its unreasonable to ship something presuming we have some ability to diff asmaps
3152020-06-26T19:44:42 <BlueMatt> ripe ris, oregon route views, caidia bgpstream are all good resources, plus anyone who is on a super small isp can probably just ask for a relevant routing table dump if you ping the noc.
3162020-06-26T19:45:14 <BlueMatt> you can probably find some other random route servers that have the ability to generate a dump left on
3172020-06-26T19:45:16 <sipa> BlueMatt: thanks for the reminder that i should add a asmap diff tool
3182020-06-26T19:45:18 <sipa> somewhefe
3192020-06-26T19:45:47 <BlueMatt> right, cerainly not practical to ship anything without a diff tool.
3202020-06-26T19:45:50 * luke-jr wonders if there's any way for random joes to monitor BGP or whatever directly
3212020-06-26T19:46:08 *** proofofkeags has joined #bitcoin-core-dev
3222020-06-26T19:46:41 <BlueMatt> directly? ask your isp for a session. indirectly? see the list i just wrote above :)
3232020-06-26T20:32:05 *** Talkless has joined #bitcoin-core-dev
3242020-06-26T20:34:55 *** justan0theruser has quit IRC
3252020-06-26T20:35:13 *** justanotheruser has joined #bitcoin-core-dev
3262020-06-26T20:35:56 *** proofofkeags has quit IRC
3272020-06-26T20:36:23 *** proofofkeags has joined #bitcoin-core-dev
3282020-06-26T20:40:38 *** proofofkeags has quit IRC
3292020-06-26T20:44:39 *** gribble has quit IRC
3302020-06-26T20:53:17 *** proofofkeags has joined #bitcoin-core-dev
3312020-06-26T20:57:26 *** gribble has joined #bitcoin-core-dev
3322020-06-26T21:00:01 *** greynix has quit IRC
3332020-06-26T21:13:29 *** proofofkeags has quit IRC
3342020-06-26T21:13:55 *** proofofkeags has joined #bitcoin-core-dev
3352020-06-26T21:18:26 *** proofofkeags has quit IRC
3362020-06-26T21:20:08 *** bitcoin-git has joined #bitcoin-core-dev
3372020-06-26T21:20:09 <bitcoin-git> [bitcoin] luke-jr opened pull request #19390: doc/REST-interface: Remove stale info (master...restdoc_rm_stale) https://github.com/bitcoin/bitcoin/pull/19390
3382020-06-26T21:20:10 *** bitcoin-git has left #bitcoin-core-dev
3392020-06-26T21:21:08 *** filchef has joined #bitcoin-core-dev
3402020-06-26T21:22:09 *** Xorlev has joined #bitcoin-core-dev
3412020-06-26T21:22:21 *** filchef has quit IRC
3422020-06-26T21:24:19 *** bitcoin-git has joined #bitcoin-core-dev
3432020-06-26T21:24:19 <bitcoin-git> [bitcoin] luke-jr opened pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
3442020-06-26T21:24:20 *** bitcoin-git has left #bitcoin-core-dev
3452020-06-26T21:29:26 * luke-jr peers at BSD CI failing on doc change O.o
3462020-06-26T21:39:13 *** troygiorshev has quit IRC
3472020-06-26T21:39:59 *** Guyver2 has quit IRC
3482020-06-26T21:41:33 <sipa> cfields: Span<const int> bad{MakeSpan(std::vector<int>{})} works fine :(
3492020-06-26T21:41:41 <sipa> without lifetimebound warning
3502020-06-26T21:44:47 *** kristapsk has quit IRC
3512020-06-26T21:46:12 *** kristapsk has joined #bitcoin-core-dev
3522020-06-26T21:48:23 *** jarthur has quit IRC
3532020-06-26T21:54:39 *** marcoagner has quit IRC
3542020-06-26T22:02:11 *** davterra has quit IRC
3552020-06-26T22:03:59 *** sipsorcery has quit IRC
3562020-06-26T22:10:41 *** proofofkeags has joined #bitcoin-core-dev
3572020-06-26T22:13:16 <midnight> seeing an odd fdatasync() problem starting up a regtest instance to complete unit tests on a NetBSD vm, in the leveldb code.. :-/
3582020-06-26T22:13:35 *** Talkless has quit IRC
3592020-06-26T22:17:07 *** kristapsk has quit IRC
3602020-06-26T22:17:28 *** justanotheruser has quit IRC
3612020-06-26T22:35:03 *** justanotheruser has joined #bitcoin-core-dev
3622020-06-26T22:35:23 *** proofofkeags has quit IRC
3632020-06-26T22:35:49 *** proofofkeags has joined #bitcoin-core-dev
3642020-06-26T22:40:20 *** proofofkeags has quit IRC
3652020-06-26T22:42:57 *** sipsorcery has joined #bitcoin-core-dev
3662020-06-26T22:43:20 *** proofofkeags has joined #bitcoin-core-dev
3672020-06-26T22:43:50 *** proofofkeags has quit IRC
3682020-06-26T22:44:17 *** proofofkeags has joined #bitcoin-core-dev
3692020-06-26T22:48:44 *** proofofkeags has quit IRC
3702020-06-26T23:01:43 *** davterra has joined #bitcoin-core-dev
3712020-06-26T23:20:20 *** proofofkeags has joined #bitcoin-core-dev
3722020-06-26T23:24:40 *** mol_ has quit IRC
3732020-06-26T23:24:46 *** proofofkeags has quit IRC
3742020-06-26T23:25:54 *** proofofkeags has joined #bitcoin-core-dev
3752020-06-26T23:29:38 *** mol has joined #bitcoin-core-dev
3762020-06-26T23:30:47 *** proofofkeags has quit IRC
3772020-06-26T23:31:15 *** baldur has quit IRC
3782020-06-26T23:34:27 *** baldur has joined #bitcoin-core-dev
3792020-06-26T23:41:32 *** proofofkeags has joined #bitcoin-core-dev
3802020-06-26T23:45:47 *** proofofkeags has quit IRC
3812020-06-26T23:46:40 *** AaronvanW has quit IRC