12020-07-23T00:00:02 *** vladan1 has quit IRC
22020-07-23T00:02:58 *** MasterdonX has joined #bitcoin-core-dev
32020-07-23T00:06:18 *** troygiorshev has quit IRC
42020-07-23T00:07:16 *** troygiorshev has joined #bitcoin-core-dev
52020-07-23T00:07:52 *** proofofkeags has quit IRC
62020-07-23T00:10:52 *** AaronvanW has joined #bitcoin-core-dev
72020-07-23T00:11:23 *** troygiorshev has quit IRC
82020-07-23T00:12:02 *** mdunnio has quit IRC
92020-07-23T00:12:23 *** Giszmo has joined #bitcoin-core-dev
102020-07-23T00:12:29 *** troygiorshev has joined #bitcoin-core-dev
112020-07-23T00:12:41 *** promag has quit IRC
122020-07-23T00:13:22 *** promag has joined #bitcoin-core-dev
132020-07-23T00:15:49 *** AaronvanW has quit IRC
142020-07-23T00:17:58 *** promag has quit IRC
152020-07-23T00:19:25 *** proofofkeags has joined #bitcoin-core-dev
162020-07-23T00:21:52 *** s7ry9r3 has joined #bitcoin-core-dev
172020-07-23T00:22:15 *** bpalmer1 has joined #bitcoin-core-dev
182020-07-23T00:25:04 *** Deacyde has joined #bitcoin-core-dev
192020-07-23T00:26:05 *** S3RK has joined #bitcoin-core-dev
202020-07-23T00:30:34 *** S3RK has quit IRC
212020-07-23T00:44:56 <ariard> sipa: yeah no hurry for 19184, better to favor 18044 follow-ups/integrations
222020-07-23T00:45:16 <ariard> and I still need to dig into the fuzzer coverage
232020-07-23T00:45:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
242020-07-23T00:47:51 *** mdunnio has joined #bitcoin-core-dev
252020-07-23T00:53:02 *** mdunnio has quit IRC
262020-07-23T00:53:23 *** S3RK has joined #bitcoin-core-dev
272020-07-23T00:53:56 *** AaronvanW has joined #bitcoin-core-dev
282020-07-23T00:59:39 *** bitcoin-git has joined #bitcoin-core-dev
292020-07-23T00:59:39 <bitcoin-git> [bitcoin] sipa opened pull request #19569: Enable fetching of orphan parents from wtxid peers (master...202007_wtxid_followup) https://github.com/bitcoin/bitcoin/pull/19569
302020-07-23T00:59:40 *** bitcoin-git has left #bitcoin-core-dev
312020-07-23T01:03:13 *** harrigan has quit IRC
322020-07-23T01:05:02 *** harrigan has joined #bitcoin-core-dev
332020-07-23T01:18:34 *** sipa has quit IRC
342020-07-23T01:18:52 *** sipa has joined #bitcoin-core-dev
352020-07-23T01:26:37 *** AaronvanW has quit IRC
362020-07-23T01:27:13 *** Chris_Stewart_5 has quit IRC
372020-07-23T01:32:27 *** proofofkeags has quit IRC
382020-07-23T01:44:35 *** Giszmo has quit IRC
392020-07-23T02:03:50 *** proofofkeags has joined #bitcoin-core-dev
402020-07-23T02:06:28 *** bpalmer1 has quit IRC
412020-07-23T02:18:56 *** arowser has joined #bitcoin-core-dev
422020-07-23T02:20:43 *** Giszmo has joined #bitcoin-core-dev
432020-07-23T02:22:35 *** s7ry9r3 has quit IRC
442020-07-23T02:24:43 *** factoid has quit IRC
452020-07-23T02:33:52 *** coolacid1 has joined #bitcoin-core-dev
462020-07-23T02:36:23 *** yanmaani has quit IRC
472020-07-23T02:55:05 *** Giszmo1 has joined #bitcoin-core-dev
482020-07-23T02:55:06 *** Giszmo has quit IRC
492020-07-23T02:59:51 *** Giszmo has joined #bitcoin-core-dev
502020-07-23T03:00:02 *** coolacid1 has quit IRC
512020-07-23T03:04:25 *** Giszmo1 has quit IRC
522020-07-23T03:06:08 *** arowser has quit IRC
532020-07-23T03:06:33 *** arowser has joined #bitcoin-core-dev
542020-07-23T03:07:22 *** mol_ has joined #bitcoin-core-dev
552020-07-23T03:09:59 *** jarthur_ has joined #bitcoin-core-dev
562020-07-23T03:10:22 *** mol has quit IRC
572020-07-23T03:13:43 *** jarthur has quit IRC
582020-07-23T03:22:02 *** bitdex has joined #bitcoin-core-dev
592020-07-23T03:22:04 *** dougsko1 has joined #bitcoin-core-dev
602020-07-23T03:23:14 *** bitcoin-git has joined #bitcoin-core-dev
612020-07-23T03:23:16 <bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ccef10261efc...9d4b3d86b694
622020-07-23T03:23:16 <bitcoin-git> bitcoin/master 27b2766 Andrew Chow: walletdb: Move BerkeleyDatabase::Flush(true) to Close()
632020-07-23T03:23:17 <bitcoin-git> bitcoin/master 71d28e7 Andrew Chow: walletdb: Introduce AddRef and RemoveRef functions
642020-07-23T03:23:18 <bitcoin-git> bitcoin/master 2179dbc Andrew Chow: walletdb: Add BerkeleyDatabase::Open dummy function
652020-07-23T03:23:20 *** bitcoin-git has left #bitcoin-core-dev
662020-07-23T03:23:34 *** bitcoin-git has joined #bitcoin-core-dev
672020-07-23T03:23:34 <bitcoin-git> [bitcoin] meshcollider merged pull request #19334: wallet: Introduce WalletDatabase abstract class (master...bdb-add-walletdb) https://github.com/bitcoin/bitcoin/pull/19334
682020-07-23T03:23:35 *** AaronvanW has joined #bitcoin-core-dev
692020-07-23T03:23:35 *** bitcoin-git has left #bitcoin-core-dev
702020-07-23T03:25:46 <achow101> \o/
712020-07-23T03:29:52 *** arowser has quit IRC
722020-07-23T03:31:02 *** vasild_ has joined #bitcoin-core-dev
732020-07-23T03:34:03 *** vasild has quit IRC
742020-07-23T03:34:04 *** vasild_ is now known as vasild
752020-07-23T03:36:41 *** arowser has joined #bitcoin-core-dev
762020-07-23T03:53:56 *** S3RK has quit IRC
772020-07-23T03:54:41 *** S3RK has joined #bitcoin-core-dev
782020-07-23T03:56:45 *** AaronvanW has quit IRC
792020-07-23T03:58:38 *** Deacyde has quit IRC
802020-07-23T03:58:45 *** S3RK has quit IRC
812020-07-23T04:00:45 *** arowser has quit IRC
822020-07-23T04:02:35 *** arowser has joined #bitcoin-core-dev
832020-07-23T04:10:43 *** proofofkeags has quit IRC
842020-07-23T04:11:16 *** proofofkeags has joined #bitcoin-core-dev
852020-07-23T04:15:42 *** proofofkeags has quit IRC
862020-07-23T04:17:06 *** S3RK has joined #bitcoin-core-dev
872020-07-23T04:19:11 *** arowser has quit IRC
882020-07-23T04:21:15 *** arowser has joined #bitcoin-core-dev
892020-07-23T04:32:53 *** molz_ has joined #bitcoin-core-dev
902020-07-23T04:36:14 *** mol_ has quit IRC
912020-07-23T04:43:08 *** arowser has quit IRC
922020-07-23T04:43:32 *** arowser has joined #bitcoin-core-dev
932020-07-23T05:04:45 *** Klox04 has quit IRC
942020-07-23T05:09:02 *** rh0nj has quit IRC
952020-07-23T05:10:07 *** rh0nj has joined #bitcoin-core-dev
962020-07-23T05:16:45 *** arowser has quit IRC
972020-07-23T05:20:28 *** arowser has joined #bitcoin-core-dev
982020-07-23T05:29:53 *** promag has joined #bitcoin-core-dev
992020-07-23T05:32:05 *** S3RK has quit IRC
1002020-07-23T05:34:05 *** promag has quit IRC
1012020-07-23T05:36:45 *** arowser has quit IRC
1022020-07-23T05:43:20 *** arowser has joined #bitcoin-core-dev
1032020-07-23T05:52:50 *** EagleTM has joined #bitcoin-core-dev
1042020-07-23T05:53:20 *** AaronvanW has joined #bitcoin-core-dev
1052020-07-23T05:57:05 *** EagleTM has quit IRC
1062020-07-23T05:58:03 *** S3RK has joined #bitcoin-core-dev
1072020-07-23T06:00:02 *** dougsko1 has quit IRC
1082020-07-23T06:02:19 *** go11111111111 has joined #bitcoin-core-dev
1092020-07-23T06:02:50 *** S3RK has quit IRC
1102020-07-23T06:04:45 *** go121212 has quit IRC
1112020-07-23T06:15:16 *** davec has quit IRC
1122020-07-23T06:21:12 *** ElectroBNC has joined #bitcoin-core-dev
1132020-07-23T06:22:18 *** davec has joined #bitcoin-core-dev
1142020-07-23T06:26:46 *** AaronvanW has quit IRC
1152020-07-23T06:29:03 *** jonatack has quit IRC
1162020-07-23T06:29:54 *** Pavlenex has joined #bitcoin-core-dev
1172020-07-23T06:41:37 *** Guyver2 has joined #bitcoin-core-dev
1182020-07-23T06:47:00 *** Pavlenex has quit IRC
1192020-07-23T06:47:04 *** marcoagner has joined #bitcoin-core-dev
1202020-07-23T06:56:43 *** arowser has quit IRC
1212020-07-23T06:57:47 *** S3RK has joined #bitcoin-core-dev
1222020-07-23T06:58:43 *** Pavlenex has joined #bitcoin-core-dev
1232020-07-23T06:59:44 *** dviola has quit IRC
1242020-07-23T07:02:22 *** S3RK has quit IRC
1252020-07-23T07:03:12 *** arowser has joined #bitcoin-core-dev
1262020-07-23T07:08:21 *** Pavlenex has quit IRC
1272020-07-23T07:10:39 *** jarthur_ is now known as jarthur
1282020-07-23T07:10:53 *** arowser has quit IRC
1292020-07-23T07:15:51 *** S3RK has joined #bitcoin-core-dev
1302020-07-23T07:16:05 *** marcoagner has quit IRC
1312020-07-23T07:20:33 *** S3RK has quit IRC
1322020-07-23T07:23:07 *** arowser has joined #bitcoin-core-dev
1332020-07-23T07:28:59 *** jarthur has quit IRC
1342020-07-23T07:34:48 *** S3RK has joined #bitcoin-core-dev
1352020-07-23T08:06:20 *** mdunnio has joined #bitcoin-core-dev
1362020-07-23T08:10:20 *** arowser has quit IRC
1372020-07-23T08:11:08 *** arowser has joined #bitcoin-core-dev
1382020-07-23T08:11:10 *** mdunnio has quit IRC
1392020-07-23T08:12:17 *** promag has joined #bitcoin-core-dev
1402020-07-23T08:14:27 *** S3RK has quit IRC
1412020-07-23T08:14:59 *** S3RK has joined #bitcoin-core-dev
1422020-07-23T08:19:25 *** S3RK has quit IRC
1432020-07-23T08:23:55 *** AaronvanW has joined #bitcoin-core-dev
1442020-07-23T08:31:36 *** sipsorcery has quit IRC
1452020-07-23T08:32:59 *** sipsorcery has joined #bitcoin-core-dev
1462020-07-23T08:34:37 <fanquake> #proposedmeetingtopic: tag rc1
1472020-07-23T08:38:37 *** S3RK has joined #bitcoin-core-dev
1482020-07-23T08:42:27 *** ElectroBNC has quit IRC
1492020-07-23T08:43:22 *** S3RK has quit IRC
1502020-07-23T08:46:14 *** EagleTM has joined #bitcoin-core-dev
1512020-07-23T08:53:58 <fanquake> Just realized this should have been _release_ rc1
1522020-07-23T08:54:30 <fanquake> Has obviously already been tagged, and got 4-5 sigs on the signed asserts
1532020-07-23T08:56:42 *** kristapsk has quit IRC
1542020-07-23T09:08:07 *** promag has quit IRC
1552020-07-23T09:09:18 *** Pavlenex has joined #bitcoin-core-dev
1562020-07-23T09:14:37 *** jonatack has joined #bitcoin-core-dev
1572020-07-23T09:22:17 *** Lestaty has joined #bitcoin-core-dev
1582020-07-23T09:22:41 *** Lestaty is now known as Guest3500
1592020-07-23T09:23:20 *** Pavlenex has quit IRC
1602020-07-23T09:30:14 *** promag has joined #bitcoin-core-dev
1612020-07-23T09:33:46 *** AaronvanW has quit IRC
1622020-07-23T09:41:15 *** EagleTM has quit IRC
1632020-07-23T09:57:46 *** Pavlenex has joined #bitcoin-core-dev
1642020-07-23T10:01:23 *** Guest3500 has quit IRC
1652020-07-23T10:03:18 *** arowser has quit IRC
1662020-07-23T10:03:20 *** Godfrey32Kozey has joined #bitcoin-core-dev
1672020-07-23T10:05:01 *** davec has quit IRC
1682020-07-23T10:05:30 <achow101> Might not be at the meeting today, so #19335 for my hi prio
1692020-07-23T10:05:32 <gribble> https://github.com/bitcoin/bitcoin/issues/19335 | wallet: Cleanup and separate BerkeleyDatabase and BerkeleyBatch by achow101 · Pull Request #19335 · bitcoin/bitcoin · GitHub
1702020-07-23T10:05:55 *** davec has joined #bitcoin-core-dev
1712020-07-23T10:08:47 *** AaronvanW has joined #bitcoin-core-dev
1722020-07-23T10:11:37 *** davec has quit IRC
1732020-07-23T10:13:30 *** davec has joined #bitcoin-core-dev
1742020-07-23T10:15:36 *** arowser has joined #bitcoin-core-dev
1752020-07-23T10:28:14 *** Eartaker has joined #bitcoin-core-dev
1762020-07-23T10:30:41 *** arowser has quit IRC
1772020-07-23T10:34:05 *** jonatack has quit IRC
1782020-07-23T10:35:45 *** Godfrey32Kozey has quit IRC
1792020-07-23T10:35:59 *** jonatack has joined #bitcoin-core-dev
1802020-07-23T10:37:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1812020-07-23T10:39:51 *** yanmaani has joined #bitcoin-core-dev
1822020-07-23T10:42:13 <elichai2> How stable are blocks/*.dat files? (thinking of writing a parser so you could easily query questions over all the history)
1832020-07-23T10:46:04 *** vincenzopalazzo has joined #bitcoin-core-dev
1842020-07-23T10:46:57 *** jeremyrubin has quit IRC
1852020-07-23T10:53:08 *** arowser has joined #bitcoin-core-dev
1862020-07-23T10:53:41 *** belcher_ has joined #bitcoin-core-dev
1872020-07-23T10:54:43 *** bitdex has quit IRC
1882020-07-23T10:56:59 *** belcher has quit IRC
1892020-07-23T11:02:17 *** cato_ has quit IRC
1902020-07-23T11:02:27 *** cato_ has joined #bitcoin-core-dev
1912020-07-23T11:05:24 *** arowser has quit IRC
1922020-07-23T11:05:38 *** masterdonx2 has joined #bitcoin-core-dev
1932020-07-23T11:06:02 *** MasterdonX has quit IRC
1942020-07-23T11:06:02 *** sipa has quit IRC
1952020-07-23T11:06:13 *** sipa has joined #bitcoin-core-dev
1962020-07-23T11:07:28 *** arowser has joined #bitcoin-core-dev
1972020-07-23T11:16:24 *** Pavlenex1 has joined #bitcoin-core-dev
1982020-07-23T11:18:13 *** arowser has quit IRC
1992020-07-23T11:19:00 *** Pavlenex has quit IRC
2002020-07-23T11:19:01 *** Pavlenex1 is now known as Pavlenex
2012020-07-23T11:32:59 *** vincenzopalazzo has quit IRC
2022020-07-23T11:33:49 *** vincenzopalazzo has joined #bitcoin-core-dev
2032020-07-23T11:35:04 <cato_> elichai2: what do you mean with stable?
2042020-07-23T11:35:25 <elichai2> cato_: the format of the file
2052020-07-23T11:37:25 <cato_> well, if you want to access data in blocks/*.dat you first need metadata from blocks/index/
2062020-07-23T11:39:27 *** justanotheruser has quit IRC
2072020-07-23T11:39:43 <cato_> which is a key-value leveldb. more or less you use block hashes as keys and it'll tell you where in blocks/*.dat you'll find a particular block
2082020-07-23T11:41:19 *** justanotheruser has joined #bitcoin-core-dev
2092020-07-23T12:00:02 *** Eartaker has quit IRC
2102020-07-23T12:00:36 *** S3RK has joined #bitcoin-core-dev
2112020-07-23T12:01:08 *** arowser has joined #bitcoin-core-dev
2122020-07-23T12:01:55 *** Pavlenex has quit IRC
2132020-07-23T12:05:11 *** S3RK has quit IRC
2142020-07-23T12:06:05 *** arowser has quit IRC
2152020-07-23T12:07:58 *** arowser has joined #bitcoin-core-dev
2162020-07-23T12:11:27 *** Highway61 has joined #bitcoin-core-dev
2172020-07-23T12:13:25 *** jonatack has quit IRC
2182020-07-23T12:21:23 *** JLP has joined #bitcoin-core-dev
2192020-07-23T12:35:05 *** Davterra has quit IRC
2202020-07-23T12:35:16 *** Guyver2 has quit IRC
2212020-07-23T13:01:47 *** arowser has quit IRC
2222020-07-23T13:02:45 *** arowser has joined #bitcoin-core-dev
2232020-07-23T13:04:09 *** arowser has quit IRC
2242020-07-23T13:04:29 *** arowser has joined #bitcoin-core-dev
2252020-07-23T13:05:08 *** arowser has quit IRC
2262020-07-23T13:05:26 *** arowser has joined #bitcoin-core-dev
2272020-07-23T13:06:09 *** arowser has quit IRC
2282020-07-23T13:06:28 *** arowser has joined #bitcoin-core-dev
2292020-07-23T13:06:44 *** vincentpalazzo has joined #bitcoin-core-dev
2302020-07-23T13:09:30 *** vincenzopalazzo has quit IRC
2312020-07-23T13:10:11 *** arowser has quit IRC
2322020-07-23T13:10:40 *** arowser has joined #bitcoin-core-dev
2332020-07-23T13:11:08 *** arowser has quit IRC
2342020-07-23T13:11:46 *** arowser has joined #bitcoin-core-dev
2352020-07-23T13:16:56 *** davec has quit IRC
2362020-07-23T13:18:53 *** davec has joined #bitcoin-core-dev
2372020-07-23T13:22:14 *** vasild has quit IRC
2382020-07-23T13:22:59 *** arowser has quit IRC
2392020-07-23T13:26:31 *** arowser has joined #bitcoin-core-dev
2402020-07-23T13:26:52 *** jonatack has joined #bitcoin-core-dev
2412020-07-23T13:30:21 *** proofofkeags has joined #bitcoin-core-dev
2422020-07-23T13:33:05 *** davec has quit IRC
2432020-07-23T13:38:38 *** shesek has joined #bitcoin-core-dev
2442020-07-23T13:40:25 *** S3RK has joined #bitcoin-core-dev
2452020-07-23T13:44:35 *** S3RK has quit IRC
2462020-07-23T13:46:02 *** davec has joined #bitcoin-core-dev
2472020-07-23T13:47:38 *** vincentpalazzo has quit IRC
2482020-07-23T13:47:51 *** vincenzopalazzo has joined #bitcoin-core-dev
2492020-07-23T14:00:39 *** mdunnio has joined #bitcoin-core-dev
2502020-07-23T14:02:17 *** davec has quit IRC
2512020-07-23T14:05:45 *** troygiorshev has quit IRC
2522020-07-23T14:06:51 *** vasild has joined #bitcoin-core-dev
2532020-07-23T14:06:54 *** troygiorshev has joined #bitcoin-core-dev
2542020-07-23T14:18:13 *** Giszmo has quit IRC
2552020-07-23T14:23:29 *** davec has joined #bitcoin-core-dev
2562020-07-23T14:26:01 *** vincentpalazzo has joined #bitcoin-core-dev
2572020-07-23T14:26:32 *** vincentpalazzo has joined #bitcoin-core-dev
2582020-07-23T14:27:03 *** vincentpalazzo has quit IRC
2592020-07-23T14:27:15 *** vincentpalazzo has joined #bitcoin-core-dev
2602020-07-23T14:28:27 *** palazzovincenzo has joined #bitcoin-core-dev
2612020-07-23T14:28:47 *** palazzovincenzo has quit IRC
2622020-07-23T14:28:54 *** vincenzopalazzo has quit IRC
2632020-07-23T14:30:23 *** Guyver2 has joined #bitcoin-core-dev
2642020-07-23T14:30:42 *** vincenzopalazzo has joined #bitcoin-core-dev
2652020-07-23T14:30:58 *** sorcus has quit IRC
2662020-07-23T14:33:37 *** Giszmo has joined #bitcoin-core-dev
2672020-07-23T14:41:51 <harding> elichai2: https://github.com/rustyrussell/bitcoin-iterate
2682020-07-23T14:44:12 *** arowser has quit IRC
2692020-07-23T14:44:32 *** arowser has joined #bitcoin-core-dev
2702020-07-23T14:49:05 *** proofofkeags has quit IRC
2712020-07-23T14:49:40 *** proofofkeags has joined #bitcoin-core-dev
2722020-07-23T14:54:00 *** Davterra has joined #bitcoin-core-dev
2732020-07-23T14:54:20 *** proofofkeags has quit IRC
2742020-07-23T15:00:02 *** JLP has quit IRC
2752020-07-23T15:03:45 *** mdunnio has quit IRC
2762020-07-23T15:06:50 *** bitcoin-git has joined #bitcoin-core-dev
2772020-07-23T15:06:50 <bitcoin-git> [bitcoin] instagibbs opened pull request #19572: ZMQ: Create "sequence" notifier, enabling client-side mempool tracking (master...zmq_sequence_all) https://github.com/bitcoin/bitcoin/pull/19572
2782020-07-23T15:06:51 *** bitcoin-git has left #bitcoin-core-dev
2792020-07-23T15:10:19 *** proofofkeags has joined #bitcoin-core-dev
2802020-07-23T15:18:10 *** arowser has quit IRC
2812020-07-23T15:22:14 *** blathijs1 has joined #bitcoin-core-dev
2822020-07-23T15:25:09 *** Giszmo1 has joined #bitcoin-core-dev
2832020-07-23T15:27:58 *** Giszmo has quit IRC
2842020-07-23T15:30:19 *** arowser has joined #bitcoin-core-dev
2852020-07-23T15:33:10 <yanmaani> I have what seems to be a Heisenbug in my test; about 50% of the times I run it it gives an error. Are there any known non-deterministic footguns in the testing framework?
2862020-07-23T15:33:18 <wumpus> elichai2: AFAIK the format of the block files has never been changed, there are no guarantees though, data files are not an external interface
2872020-07-23T15:34:13 <wumpus> but to be honest I expect them to remain like this, it's simply a magic value then the block data, the metadata (as said) is in the database
2882020-07-23T15:34:23 *** vasild has quit IRC
2892020-07-23T15:34:55 <yanmaani> If I have two nodes, is it always guaranteed that the blocks will propagate on time?
2902020-07-23T15:35:05 <yanmaani> Or is there a way to make them ensure everything is synced?
2912020-07-23T15:36:00 * yanmaani thanks the channel for the rubberducking
2922020-07-23T15:36:00 <elichai2> wumpus: thanks. I can assume the db metadata is also quite stable? (obviously no promises)
2932020-07-23T15:36:15 *** vasild has joined #bitcoin-core-dev
2942020-07-23T15:36:42 <elichai2> yanmaani: obv all network operations can be non-deterministic
2952020-07-23T15:36:44 <wumpus> it's usually at least backward compatible
2962020-07-23T15:38:33 <wumpus> yanmaani: if you have two nodes and they are connected then they should eventually sync
2972020-07-23T15:38:46 <yanmaani> No, I found it
2982020-07-23T15:38:57 <yanmaani> there's a specific call you can do to wait until they're all synced
2992020-07-23T15:39:28 <wumpus> (there are some exceptions, e.g. a mainnet/testnet node that isn't up to date with the network won't let other nodes sync from it, but none that sould affect writing regtest tests)
3002020-07-23T15:39:52 <wumpus> yes, you definitely need to wait for it, I just mean it eventually happens, there is no time guarantee
3012020-07-23T15:41:12 <wumpus> fanquake: I'm going to upload rc1 executables, thanks for the reminder, I don't think this needs to be a meeting topic :)
3022020-07-23T15:41:56 *** Emcy has quit IRC
3032020-07-23T15:42:37 <instagibbs> yanmaani, there's one for blocks, one for mempool, and one for both. Typically the last is sufficient, just can make tests slower if not necessary
3042020-07-23T15:43:09 <instagibbs> pretty much any time your test "alternates" between two nodes it can be necessary for non-flakey behavior
3052020-07-23T15:45:29 *** Emcy has joined #bitcoin-core-dev
3062020-07-23T15:46:07 *** Pavlenex has joined #bitcoin-core-dev
3072020-07-23T15:55:24 <instagibbs> getting pretty consistent mempool_packages.py failures, which I don't think is my fault? https://travis-ci.org/github/bitcoin/bitcoin/jobs/711137623
3082020-07-23T15:58:00 <wumpus> rc1 binaries up https://bitcoincore.org/bin/bitcoin-core-0.20.1/test.rc1/
3092020-07-23T16:11:24 *** Highway61 has quit IRC
3102020-07-23T16:11:50 *** arowser has quit IRC
3112020-07-23T16:12:07 <instagibbs> actually could very well be my fault/my PR exposing that issue, nevermind
3122020-07-23T16:12:59 *** Talkless has joined #bitcoin-core-dev
3132020-07-23T16:13:50 *** arowser has joined #bitcoin-core-dev
3142020-07-23T16:14:22 <troygiorshev> instagibbs: fwiw that test passes on master on my machine
3152020-07-23T16:17:31 <instagibbs> yeah no it's definitely my fault, just didn't see the connection until just now
3162020-07-23T16:18:07 *** S3RK has joined #bitcoin-core-dev
3172020-07-23T16:22:25 *** S3RK has quit IRC
3182020-07-23T16:24:56 *** jeremyrubin has joined #bitcoin-core-dev
3192020-07-23T16:25:01 <jeremyrubin> elichai2: there are some decent parsers that exist rn. format is stable, but iirc you still need to filter to handle connection logic.
3202020-07-23T16:25:16 *** troygiorshev has quit IRC
3212020-07-23T16:25:19 *** proofofk_ has joined #bitcoin-core-dev
3222020-07-23T16:25:57 *** troygiorshev has joined #bitcoin-core-dev
3232020-07-23T16:27:14 <sipa> wumpus, elichai2: the only major changes to the disk format were permitting out-of-order blocks since 0.10, and obviously segwit in 0
3242020-07-23T16:27:18 <sipa> .13
3252020-07-23T16:27:34 <sipa> s/major /g
3262020-07-23T16:27:52 <sipa> i think those may actually be the only changes ever
3272020-07-23T16:28:13 *** proofofkeags has quit IRC
3282020-07-23T16:30:54 *** bitcoin-git has joined #bitcoin-core-dev
3292020-07-23T16:30:55 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/cac7a9809a3d...58feb9ecb647
3302020-07-23T16:30:55 <bitcoin-git> bitcoin/0.20 58feb9e Wladimir J. van der Laan: doc: Add changelog and authors to release notes for 0.20.1
3312020-07-23T16:30:56 *** bitcoin-git has left #bitcoin-core-dev
3322020-07-23T16:31:47 <wumpus> sipa: yes, exactly
3332020-07-23T16:35:59 *** bitcoin-git has joined #bitcoin-core-dev
3342020-07-23T16:36:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9d4b3d86b694...6ee36a263c5a
3352020-07-23T16:36:00 <bitcoin-git> bitcoin/master 62fe6aa Hennadii Stepanov: net: Add -networkactive option
3362020-07-23T16:36:01 <bitcoin-git> bitcoin/master 3c58129 Hennadii Stepanov: net: Log network activity status change unconditionally
3372020-07-23T16:36:02 <bitcoin-git> bitcoin/master 2aac093 Hennadii Stepanov: test: Add test coverage for -networkactive option
3382020-07-23T16:36:03 *** bitcoin-git has left #bitcoin-core-dev
3392020-07-23T16:36:19 *** bitcoin-git has joined #bitcoin-core-dev
3402020-07-23T16:36:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19473: net: Add -networkactive option (master...200709-setnet) https://github.com/bitcoin/bitcoin/pull/19473
3412020-07-23T16:36:20 *** bitcoin-git has left #bitcoin-core-dev
3422020-07-23T16:38:21 *** somethingsomethi has joined #bitcoin-core-dev
3432020-07-23T16:42:39 *** bitcoin-git has joined #bitcoin-core-dev
3442020-07-23T16:42:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6ee36a263c5a...f4cfa6d01900
3452020-07-23T16:42:41 <bitcoin-git> bitcoin/master eb682c5 Russell Yanofsky: util: Add ReadSettings and WriteSettings functions
3462020-07-23T16:42:42 <bitcoin-git> bitcoin/master 9c69cfe Russell Yanofsky: Add <datadir>/settings.json persistent settings storage.
3472020-07-23T16:42:43 <bitcoin-git> bitcoin/master f4cfa6d MarcoFalke: Merge #15935: Add <datadir>/settings.json persistent settings storage
3482020-07-23T16:42:45 *** bitcoin-git has left #bitcoin-core-dev
3492020-07-23T16:43:59 *** Highway61 has joined #bitcoin-core-dev
3502020-07-23T16:44:24 *** bitcoin-git has joined #bitcoin-core-dev
3512020-07-23T16:44:24 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15935: Add <datadir>/settings.json persistent settings storage (master...pr/rwset) https://github.com/bitcoin/bitcoin/pull/15935
3522020-07-23T16:44:25 *** bitcoin-git has left #bitcoin-core-dev
3532020-07-23T16:50:13 *** arowser has quit IRC
3542020-07-23T16:50:33 *** arowser has joined #bitcoin-core-dev
3552020-07-23T16:50:56 *** EagleTM has joined #bitcoin-core-dev
3562020-07-23T16:53:34 *** jarthur has joined #bitcoin-core-dev
3572020-07-23T16:54:10 *** arowser has quit IRC
3582020-07-23T16:54:28 *** arowser has joined #bitcoin-core-dev
3592020-07-23T16:55:40 <somethingsomethi> #proposedmeetingtopic taproot in 0.20
3602020-07-23T17:01:30 *** troygiorshev has quit IRC
3612020-07-23T17:02:22 *** troygiorshev has joined #bitcoin-core-dev
3622020-07-23T17:11:49 *** bitcoin-git has joined #bitcoin-core-dev
3632020-07-23T17:11:50 <bitcoin-git> [bitcoin] jonatack closed pull request #19405: rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` (master...in-and-out-connections) https://github.com/bitcoin/bitcoin/pull/19405
3642020-07-23T17:11:51 *** bitcoin-git has left #bitcoin-core-dev
3652020-07-23T17:14:25 *** bitcoin-git has joined #bitcoin-core-dev
3662020-07-23T17:14:25 <bitcoin-git> [bitcoin] jonatack closed pull request #19455: rpc generate: print useful help and error message (master...rpc-generate-helpful-error_message) https://github.com/bitcoin/bitcoin/pull/19455
3672020-07-23T17:14:26 *** bitcoin-git has left #bitcoin-core-dev
3682020-07-23T17:15:51 *** bitcoin-git has joined #bitcoin-core-dev
3692020-07-23T17:15:51 <bitcoin-git> [bitcoin] jonatack closed pull request #19397: test: resyncing to tip of blocks generated after invalidateblock (master...p2p-invalidateblock-tests) https://github.com/bitcoin/bitcoin/pull/19397
3702020-07-23T17:15:52 *** bitcoin-git has left #bitcoin-core-dev
3712020-07-23T17:16:29 <jonatack> Cleaning out stuff with no ACKs to make room for the new.
3722020-07-23T17:16:49 <wumpus> jonatack: fwiw I just didn't get around to reviewing #19405 again in detail yet, I'm definitely not against it
3732020-07-23T17:16:51 <gribble> https://github.com/bitcoin/bitcoin/issues/19405 | rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` by jonatack · Pull Request #19405 · bitcoin/bitcoin · GitHub
3742020-07-23T17:21:41 *** vincenzopalazzo has quit IRC
3752020-07-23T17:21:50 *** owowo has quit IRC
3762020-07-23T17:22:13 *** vincenzopalazzo has joined #bitcoin-core-dev
3772020-07-23T17:22:46 <wumpus> of course it's up to you if you close your PRs or not, but it might make sense to ask for more review instead, things have just been a bit slow for a while with regard to review compared to the number of PRs submitted
3782020-07-23T17:26:38 *** Pavlenex has quit IRC
3792020-07-23T17:26:39 *** owowo has joined #bitcoin-core-dev
3802020-07-23T17:27:25 *** EagleTM has quit IRC
3812020-07-23T17:33:29 *** proofofk_ has quit IRC
3822020-07-23T17:34:04 *** proofofkeags has joined #bitcoin-core-dev
3832020-07-23T17:38:28 <jonatack> wumpus: thanks, there are more interesting things i want to work on and don't want to encumber the too-high PR stack with proposals that aren't "hell yes" or have more than a handful of PRs open
3842020-07-23T17:38:57 *** proofofkeags has quit IRC
3852020-07-23T17:39:01 *** proofofk_ has joined #bitcoin-core-dev
3862020-07-23T17:40:52 <jonatack> also, i think modding your script into a custom dashboard i'm using to observe connections in much more detail by type and eviction criteria made just having in/out seem a little pale :)
3872020-07-23T17:42:07 *** arowser has quit IRC
3882020-07-23T17:43:11 *** vincenzopalazzo has quit IRC
3892020-07-23T17:43:25 *** vincenzopalazzo has joined #bitcoin-core-dev
3902020-07-23T17:43:56 *** S3RK has joined #bitcoin-core-dev
3912020-07-23T17:44:30 <wumpus> Ok :)
3922020-07-23T17:48:31 *** S3RK has quit IRC
3932020-07-23T17:48:44 *** arowser has joined #bitcoin-core-dev
3942020-07-23T17:51:37 <fjahr> jonatack: maybe 19405 can still be marked as "up for grabs"?
3952020-07-23T17:54:12 *** Highway61 has quit IRC
3962020-07-23T17:56:57 <jonatack> fjahr: sgtm
3972020-07-23T18:00:01 *** blathijs1 has quit IRC
3982020-07-23T18:01:45 *** Pavlenex has joined #bitcoin-core-dev
3992020-07-23T18:03:41 *** Pavlenex has quit IRC
4002020-07-23T18:08:43 *** Highway61 has joined #bitcoin-core-dev
4012020-07-23T18:16:20 *** Pavlenex has joined #bitcoin-core-dev
4022020-07-23T18:22:04 *** Cadair1 has joined #bitcoin-core-dev
4032020-07-23T18:42:06 *** EagleTM has joined #bitcoin-core-dev
4042020-07-23T18:48:41 *** Talkless has quit IRC
4052020-07-23T18:51:18 *** jb55 has quit IRC
4062020-07-23T18:51:53 *** jb55 has joined #bitcoin-core-dev
4072020-07-23T18:52:36 *** vincenzopalazzo has quit IRC
4082020-07-23T18:52:52 *** vincenzopalazzo has joined #bitcoin-core-dev
4092020-07-23T18:53:30 *** gzhao408 has joined #bitcoin-core-dev
4102020-07-23T18:53:32 *** gzhao408 has quit IRC
4112020-07-23T18:54:20 *** gzhao408 has joined #bitcoin-core-dev
4122020-07-23T19:00:20 <wumpus> #startmeeting
4132020-07-23T19:00:20 <lightningbot> Meeting started Thu Jul 23 19:00:20 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4142020-07-23T19:00:20 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4152020-07-23T19:00:25 *** arowser has quit IRC
4162020-07-23T19:01:22 <sipa> hi
4172020-07-23T19:01:28 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
4182020-07-23T19:01:29 <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
4192020-07-23T19:01:37 <meshcollider> hi
4202020-07-23T19:01:40 <jeremyrubin> hi
4212020-07-23T19:01:52 <jonasschnelli> Hi
4222020-07-23T19:01:54 <luke-jr> hi
4232020-07-23T19:01:58 <fjahr> hi
4242020-07-23T19:02:04 <jeremyrubin> hi
4252020-07-23T19:02:10 <amiti> hi
4262020-07-23T19:02:12 <jkczyz> hi
4272020-07-23T19:02:20 <phantomcircuit> hi
4282020-07-23T19:02:36 <ariard> hi
4292020-07-23T19:02:42 <instagibbs> hi
4302020-07-23T19:02:46 <pinheadmz> hi
4312020-07-23T19:02:53 <wumpus> one proposed meeting topic for this week: taproot in 0.20 (somethingsomethi)
4322020-07-23T19:02:54 <aj> hi
4332020-07-23T19:03:15 <somethingsomethi> hi
4342020-07-23T19:03:25 <wumpus> any last-minute topics?
4352020-07-23T19:03:30 <sipa> given that 0.20 is already released, this seems hard
4362020-07-23T19:03:42 <kanzure> hi
4372020-07-23T19:03:42 <luke-jr> sipa: 0.20.2
4382020-07-23T19:03:48 <meshcollider> 8:34 PM <fanquake> #proposedmeetingtopic: tag rc1
4392020-07-23T19:03:50 <wumpus> 0.20.0 (and 0.20.1) have been almost released
4402020-07-23T19:04:06 *** arowser has joined #bitcoin-core-dev
4412020-07-23T19:04:16 <somethingsomethi> yes
4422020-07-23T19:04:23 <somethingsomethi> let me explain
4432020-07-23T19:04:34 <somethingsomethi> This is something that came up in the taproot-activation channel: When could we actually start an activation cycle?
4442020-07-23T19:04:40 <wumpus> meshcollider: that's already done, nothing to discuss about that in the meeting I think?
4452020-07-23T19:04:44 <jeremyrubin> somethingsomethi: usually we wait till the actual topic is switched to
4462020-07-23T19:04:49 <somethingsomethi> ok
4472020-07-23T19:04:58 <jnewbery> hi
4482020-07-23T19:05:02 <meshcollider> wumpus: Yeah I'm confused too haha dw
4492020-07-23T19:05:02 <aj> wumpus: he meant release not tag
4502020-07-23T19:05:10 <meshcollider> Isn't it already released?
4512020-07-23T19:05:11 <wumpus> aj: that's also been done
4522020-07-23T19:05:14 *** promag_ has joined #bitcoin-core-dev
4532020-07-23T19:05:20 <wumpus> not at the time he posted that
4542020-07-23T19:05:31 <meshcollider> 3:58 AM <wumpus> rc1 binaries up https://bitcoincore.org/bin/bitcoin-core-0.20.1/test.rc1/
4552020-07-23T19:05:37 <meshcollider> \o/
4562020-07-23T19:05:39 <wumpus> ya
4572020-07-23T19:05:50 <wumpus> #topic High priority for review
4582020-07-23T19:05:53 <meshcollider> Easy topic then ;)
4592020-07-23T19:05:57 *** promag has quit IRC
4602020-07-23T19:05:58 *** promag_ is now known as promag
4612020-07-23T19:06:06 <promag> hi
4622020-07-23T19:06:09 <meshcollider> achow101 wanted #19335 on HP
4632020-07-23T19:06:11 <gribble> https://github.com/bitcoin/bitcoin/issues/19335 | wallet: Cleanup and separate BerkeleyDatabase and BerkeleyBatch by achow101 · Pull Request #19335 · bitcoin/bitcoin · GitHub
4642020-07-23T19:06:19 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 3 chasing concept ACK
4652020-07-23T19:06:26 <troygiorshev> hi
4662020-07-23T19:06:35 *** promag_ has joined #bitcoin-core-dev
4672020-07-23T19:07:18 <jeremyrubin> I'll add #19478 as a blocker for me (I don't have any currently slotted)
4682020-07-23T19:07:21 <gribble> https://github.com/bitcoin/bitcoin/issues/19478 | Remove CTxMempool::mapLinks data structure member by JeremyRubin · Pull Request #19478 · bitcoin/bitcoin · GitHub
4692020-07-23T19:07:39 <wumpus> meshcollider:added
4702020-07-23T19:08:25 <wumpus> jeremyrubin: well if it is a blocker for you it should be added as blocker, if not not, it's not like everyone needs to have a blocker slotted every week :)
4712020-07-23T19:09:10 <jnewbery> I'd like to make some progress on #19398. The first PR in that sequence is #19472 so perhaps that could be added to high priority?
4722020-07-23T19:09:11 <gribble> https://github.com/bitcoin/bitcoin/issues/19398 | Move remaining application layer data to net processing · Issue #19398 · bitcoin/bitcoin · GitHub
4732020-07-23T19:09:16 <gribble> https://github.com/bitcoin/bitcoin/issues/19472 | [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() by jnewbery · Pull Request #19472 · bitcoin/bitcoin · GitHub
4742020-07-23T19:09:22 <jeremyrubin> There's like 70 commits worth of other work that is queued up pending on progress on similar stuff for like the last 6-9 months
4752020-07-23T19:09:53 <sipa> jeremyrubin: ok, so it's a blocker; no other justification needed :)
4762020-07-23T19:10:25 <jeremyrubin> Those could be all parallelized I guess, but I don't want to overwhelm review
4772020-07-23T19:11:19 <wumpus> jeremyrubin: jnewbery added
4782020-07-23T19:11:46 <jnewbery> wumpus: dank
4792020-07-23T19:11:50 <jeremyrubin> tx
4802020-07-23T19:12:57 <wumpus> #topic taproot in 0.20 (somethingsomethi)
4812020-07-23T19:13:28 <somethingsomethi> Like I said, this came up in the taproot-activation channel: When could we really start an activation cycle?
4822020-07-23T19:13:43 <somethingsomethi> Going by the segwit playbook, the activation params would be released in 0.21.1, which is probably about 8 months from now, so some people were wondering if this could be shortened
4832020-07-23T19:13:56 <wumpus> welcome btw somethingsomethi I don't remember seeing you in a meeting before
4842020-07-23T19:14:11 <somethingsomethi> yeah, made this account just two hours ago :-)
4852020-07-23T19:14:28 <somethingsomethi> I'm really more trying to pass messages between irc channels
4862020-07-23T19:14:41 <luke-jr> I was expecting a 0.20.2 with it, but apparently there's a dependency on wtxid relay?
4872020-07-23T19:15:36 <wumpus> I think the question of whether to backport it to 0.20.x is completely independent of shortening anything
4882020-07-23T19:15:51 <jeremyrubin> I think there's sort of a tradeoff; how incompatible is master with 0.20 right now v.s. how incompatible will 0.21 be with 0.20?
4892020-07-23T19:15:51 <somethingsomethi> for the purposes of the taproot-activation channel, it would be interesting to know how much time there is before anything starts
4902020-07-23T19:16:02 <luke-jr> wumpus: well, if it didn't have the wtxid dependency, we could release 0.20.2 in a few weeks with itâ¦
4912020-07-23T19:16:05 <wumpus> I think the expectation is to backport it to that branch when it's ready
4922020-07-23T19:16:22 <luke-jr> (assuming the usual requirements get met quickly)
4932020-07-23T19:16:33 <instagibbs> wumpus, that meaning 0.20(handwaving away deps)
4942020-07-23T19:16:35 <instagibbs> ?
4952020-07-23T19:16:43 <jeremyrubin> wumpus: or maybe backport it to the current major release/last major release when it's ready
4962020-07-23T19:16:45 <instagibbs> or whatever branch is ready by then
4972020-07-23T19:16:54 <wumpus> jeremyrubin: yes
4982020-07-23T19:17:01 <jeremyrubin> +1, here's to hoping that does mean 0.20 tho
4992020-07-23T19:17:18 <wumpus> in any case it shouldn't end up in a .0 first
5002020-07-23T19:17:38 <sipa> i think it's very reasonable that the consensus logic for it goes into a .0
5012020-07-23T19:17:48 <instagibbs> activation I presume he meant
5022020-07-23T19:17:48 <sipa> and then activation goes into a .1
5032020-07-23T19:17:50 <luke-jr> I suppose another option would be to just start the 0.21.0 release process after 0.20.1 gets finalised, so that 0.21.1 could be sooner
5042020-07-23T19:18:01 <wumpus> I mean the actual activation
5052020-07-23T19:18:01 <sipa> the real question here is when the consensus logic can be in a release, as that's a lower bound
5062020-07-23T19:18:15 <wumpus> of course ,preparations can go in sooner
5072020-07-23T19:18:38 <jeremyrubin> I'm somewhat of the opinion that if a release cycle schedule is holding up when we think a consensus thing gets put out then it makes sense to shift around the release windows, so i agree with luke-jr
5082020-07-23T19:18:55 <wumpus> but is this really a problem right now?
5092020-07-23T19:19:08 <jeremyrubin> mac recently released an OS with two version numbers btw so that, e.g., 20.2 is identical to 21.1
5102020-07-23T19:19:28 <sipa> if there is an expectation to backport the consensus logic to a 0.20 branch, we could take some care to avoid having too many preparation changes in master first
5112020-07-23T19:19:31 <jeremyrubin> wumpus: in the ##taproot-activation discussion, yes
5122020-07-23T19:19:38 <wumpus> I'd prefer not to shift along major version schedules too much
5132020-07-23T19:19:40 <luke-jr> wumpus: I think generally there's a sense that we should have at least a 1 year timeout, and waiting a year before even starting that annoys people :p
5142020-07-23T19:20:28 <sipa> i wasn't expecting taproot in a 0.20 branch- but i also sympethize with the argument that consensus changes, when reviewed and agreed upon, shouldn't be too strongly affected by bitcoin core's release schedule
5152020-07-23T19:20:56 <wumpus> in any case, the release schedule for 0.21 is in #18947, is this a problem? do you think it should be moved backward or forward?
5162020-07-23T19:20:57 <gribble> https://github.com/bitcoin/bitcoin/issues/18947 | Release schedule for 0.21.0 · Issue #18947 · bitcoin/bitcoin · GitHub
5172020-07-23T19:21:01 *** vincenzopalazzo has quit IRC
5182020-07-23T19:21:19 <jeremyrubin> I think also that if 0.21 has a bunch of other changes, then people may not upgrade out of major upgrade conservatism
5192020-07-23T19:21:31 <luke-jr> wumpus: if we're not backporting to 0.20, the sooner 0.21.0 is released the better IMO
5202020-07-23T19:21:39 <jeremyrubin> So we might be further lengthening adoption until, e.g., 0.22 major
5212020-07-23T19:22:26 <wumpus> what is the major difference between 0.20 and the curent master branch that you think warrants an early 0.21 release?
5222020-07-23T19:22:43 <luke-jr> wumpus: my thought is, as soon as 0.20.1 is released and Taproot logic merged, move the 2020-10-01 date to the next day
5232020-07-23T19:22:59 <jeremyrubin> wumpus: generally I think most end users are woefully confused about what our version number system means.
5242020-07-23T19:23:02 <luke-jr> wumpus: this would be if wtxid relay + Taproot is seen as too big to backport
5252020-07-23T19:23:13 <wumpus> we've never based releases on features
5262020-07-23T19:23:33 <somethingsomethi> except segwit wallet release :-)
5272020-07-23T19:23:34 <instagibbs> didn't we do it for segwit(and wumpus got upset :) )
5282020-07-23T19:23:37 <sipa> luke-jr: the goal is having wtxid _deployed on the network_ before a new segwit softfork
5292020-07-23T19:23:40 <wumpus> every 6 months a new major version is released, minor versions are released for bugfixes and softforks
5302020-07-23T19:23:41 <wumpus> that's it
5312020-07-23T19:23:45 *** EagleTM has quit IRC
5322020-07-23T19:23:53 <luke-jr> sipa: yes, that'd be why releasing 0.21.0 ASAP?
5332020-07-23T19:24:02 <sipa> that seems reckles
5342020-07-23T19:24:22 <luke-jr> sipa: how?
5352020-07-23T19:24:22 <aj> sipa: i was thinking we should consider not relaying txs with taproot inputs except to wtxid peers
5362020-07-23T19:24:30 <wumpus> I don't see the need for hurry here to be honest
5372020-07-23T19:24:36 <luke-jr> sipa: I don't mean bypassing the release process, just starting it sooner.
5382020-07-23T19:24:48 <sipa> luke-jr: sure, but why?
5392020-07-23T19:25:00 <cfields_> wumpus: +1
5402020-07-23T19:25:04 <wumpus> I don't think 'users want this sooner' is a good reason, quality before everything
5412020-07-23T19:25:19 <jeremyrubin> doesn't prove anything but I did two twitter polls https://twitter.com/JeremyRubin/status/1283873417301639169 and https://twitter.com/JeremyRubin/status/1283879638435950594 which shows people don't really understand versioning fwiw
5422020-07-23T19:25:26 <luke-jr> wumpus: the release schedule isn't a matter of quality, though, is it?
5432020-07-23T19:25:46 <sipa> luke-jr: agree, but it's a matter of development cadence
5442020-07-23T19:25:55 <wumpus> I'm fairly sure a predictable schedule helps there
5452020-07-23T19:26:04 *** kristapsk has joined #bitcoin-core-dev
5462020-07-23T19:26:12 <wumpus> if people on twitter don't understand the release schedule, explain it to them
5472020-07-23T19:26:45 <jeremyrubin> i tried and they told me that I'm trying to attack bitcoin :p
5482020-07-23T19:26:50 <luke-jr> I suppose I could put it in Knots..
5492020-07-23T19:26:58 <wumpus> sigh
5502020-07-23T19:26:59 <somethingsomethi> so 0.21.1 around feb it is then?
5512020-07-23T19:27:02 <luke-jr> was planning to wait in case the protocol has any further changes though
5522020-07-23T19:27:07 <wumpus> that sounds like just riling up things
5532020-07-23T19:27:17 <luke-jr> wumpus: ?
5542020-07-23T19:27:22 <sipa> if there is a strong desire to have taproot earlier in a bitcoin core release, i think we should prefer backporting to 0.20 over accelerating 0.21
5552020-07-23T19:27:30 <wumpus> "that I"m trying to attack bitcoin" I mean
5562020-07-23T19:27:32 <luke-jr> ah
5572020-07-23T19:27:35 <instagibbs> sipa, ok that's fair enough
5582020-07-23T19:27:37 <sipa> (whether that desire exists, i have no opinion about)
5592020-07-23T19:27:44 <wumpus> there's lots of trolls on twitter we know that
5602020-07-23T19:27:44 <luke-jr> sipa: so two backports?
5612020-07-23T19:27:56 <luke-jr> sipa: one with wtxid relay, then the next with Taproot?
5622020-07-23T19:28:22 <sipa> luke-jr: i don't have a good answer here -i feel that wtxid deployment will take way longer than people here seem to tolerate for taproot
5632020-07-23T19:28:31 <sipa> regardless of what releases it goes into
5642020-07-23T19:28:42 <sipa> as it takes sometimes ~years to get new releases deployed...
5652020-07-23T19:28:45 <jeremyrubin> it also matches roconnor's complaints
5662020-07-23T19:28:57 <luke-jr> well, at least then we can tell people "not enough wtxid relay users yet" if they whine about the delay? :p
5672020-07-23T19:28:59 <jeremyrubin> people should care much more about wtxid relay than taproot in some respects
5682020-07-23T19:29:16 <sipa> wtxid doesn't really hurt until there are major relay policy changes
5692020-07-23T19:29:21 <sipa> s/hurt/help/
5702020-07-23T19:29:33 <wumpus> this is the first time I hear about wtxid relay being a problem for taproot
5712020-07-23T19:29:43 <wumpus> if I knew this sooner I would not have merged it
5722020-07-23T19:29:48 <ariard> we talked about it like 2 or 3 meeting away
5732020-07-23T19:29:50 <luke-jr> wumpus: the lack of it is the problem..
5742020-07-23T19:29:55 <ariard> when moneyball brought taproot topic
5752020-07-23T19:30:12 <wumpus> we can still revert that PR I suppose though it sounds like a mess
5762020-07-23T19:30:19 <sipa> wumpus: the opposite; wtxid is arguably required to be deployed on the network, before we can make major relay policy changes
5772020-07-23T19:30:25 <sipa> (such as taproot would imply)
5782020-07-23T19:30:32 <wumpus> ok
5792020-07-23T19:30:38 <luke-jr> sdaftuar: is wtxid relay protocol stable? should we update the BIP to Proposed status?
5802020-07-23T19:30:42 <sipa> or any script extension on top of segwit
5812020-07-23T19:30:59 <ariard> luke-jr: it has been merged yesterday, sipa has some follow-ups needed
5822020-07-23T19:31:18 <sipa> the follow-ups don't change the (specified part of) protocol
5832020-07-23T19:31:25 <wumpus> so at least merging it is progress right?
5842020-07-23T19:31:31 <sipa> yes, definitely
5852020-07-23T19:31:43 <jeremyrubin> I think the problem is that people are proposing a 4 year rollout timeline for the soft fork, to be conservative. If we're not releasing any clients for that until february it's like 5 years. I think we're inviting controversy if we do that.
5862020-07-23T19:32:11 <somethingsomethi> any guesstimate on how long the gap between wtxid and taproot would have to be?
5872020-07-23T19:32:12 <luke-jr> jeremyrubin: ?
5882020-07-23T19:32:19 <wumpus> february?
5892020-07-23T19:32:32 <luke-jr> jeremyrubin: I don't see the community tolerating 4 years
5902020-07-23T19:32:33 <somethingsomethi> *wtxid and taproot rollout
5912020-07-23T19:32:36 <jeremyrubin> "proposed 0.21.1 release"
5922020-07-23T19:32:44 <luke-jr> somethingsomethi: depends on how long it takes nodes to upgrade
5932020-07-23T19:33:07 <somethingsomethi> luke-jr that's why I wrote guesstimate :-)
5942020-07-23T19:33:09 <jeremyrubin> I don't see it being tolerated either, but I think that's what a decent number of people are expecting and proposing.
5952020-07-23T19:33:43 <jeremyrubin> By being slow we end up inviting a big kerfuffle UASF thing again.
5962020-07-23T19:33:50 <wumpus> I really dislike this discussion about tolerating, things are ready when they're ready
5972020-07-23T19:34:03 <wumpus> it sounds like you're trying to pressure us and I really dislike this
5982020-07-23T19:34:29 <ariard> You can build most of applications improved by schorr/taproot today (in hacky way though)
5992020-07-23T19:34:35 <jeremyrubin> you can draw a line between what I'm expressing and what I'm relaying
6002020-07-23T19:34:36 <somethingsomethi> It's not so much about pressure, if everyone agrees it's at least a year out, then at least we can plan accordingly
6012020-07-23T19:34:37 <ariard> like ecdsa scriptless scripts
6022020-07-23T19:34:46 <instagibbs> ariard, i.e., probably not at all :)
6032020-07-23T19:35:00 <jeremyrubin> sorry if it's coming across as *me* pressuring
6042020-07-23T19:35:11 <jeremyrubin> I agree with the "release when it's ready" mentality
6052020-07-23T19:35:22 <wumpus> if you want to push this I'm going to quit as maintainer
6062020-07-23T19:35:43 *** grubles has quit IRC
6072020-07-23T19:36:13 <wumpus> I feel enough responsibility for this to not like if things like this get rushed
6082020-07-23T19:36:38 <sipa> fwiw, i don't think there is much in master today that interacts with taproot, that would be hard to backport
6092020-07-23T19:37:08 <sipa> i think the bigger question may be wtxid relay
6102020-07-23T19:37:10 *** grubles has joined #bitcoin-core-dev
6112020-07-23T19:37:35 <ariard> instagibbs: I disagree a bit, some people instead of complaining are building on ecdsa while envisioning to upgrade to schnorr
6122020-07-23T19:37:40 <luke-jr> I guess I can look into backporting that
6132020-07-23T19:37:41 <ariard> for their use-case, when ready
6142020-07-23T19:37:48 <aj> sipa: updating secp in a backport would be large, but self-contained, so preumably fine?
6152020-07-23T19:37:49 <jeremyrubin> sipa: I think we can reasonably release taproot without wtxid relay, no? Taproot blocksonly validation, don't accept things to mempool?
6162020-07-23T19:37:50 <instagibbs> fantastic ariard
6172020-07-23T19:37:55 <wumpus> FWIW I like taproot but this is not some shitcoin where we rush features in to boost the price or something like that
6182020-07-23T19:38:29 <sipa> jeremyrubin: ugh...
6192020-07-23T19:38:33 <ariard> jeremryrubin: hmmm wouldn't this break compactblock?
6202020-07-23T19:38:48 <sipa> aj: yes
6212020-07-23T19:38:56 <luke-jr> ariard: no?
6222020-07-23T19:39:05 <instagibbs> sipa, ok so you said it takes time for wtxid relay to propagate, how much time? Is this a hard blocker from even setting a signaling window?
6232020-07-23T19:39:22 <jeremyrubin> sipa: I mean, whatever is less software work to get it so that clients can take a backport...
6242020-07-23T19:39:34 *** EagleTM has joined #bitcoin-core-dev
6252020-07-23T19:39:39 *** afk11` has quit IRC
6262020-07-23T19:39:44 <luke-jr> instagibbs: IMO we shouldn't set a signaling window until at the very least Taproot is merged into master..
6272020-07-23T19:39:45 <ariard> luke-jr: I mean loosing the propagation benefits of validating transaction before seeing them in a block?
6282020-07-23T19:39:54 <instagibbs> luke-jr, right I assumed that
6292020-07-23T19:40:02 *** afk11` has joined #bitcoin-core-dev
6302020-07-23T19:40:06 <instagibbs> I'm asking *bare* minimum
6312020-07-23T19:40:17 <instagibbs> obviously things take time on top
6322020-07-23T19:40:25 <luke-jr> ariard: sure, but that's true even without Taproot logic
6332020-07-23T19:40:29 <jeremyrubin> ariard: the idea would be that wtxid can't be backported, so it's in 0.21. 0.20 gets degraded compactblock performance
6342020-07-23T19:41:00 <jeremyrubin> luke-jr: good point, all old clients get degraded compactblock
6352020-07-23T19:41:44 <sipa> instagibbs: i need to think about that
6362020-07-23T19:41:56 <luke-jr> it would be interesting to split policy acceptance of Taproot, from Taproot consensus deployment
6372020-07-23T19:42:07 <instagibbs> sipa, roger
6382020-07-23T19:42:08 <cfields_> jeremyrubin: that sounds interesting to me. sipa: why "Ugh" to that?
6392020-07-23T19:42:09 <ariard> that sounds a bit awful for network robustness, you will favor connections to upgraded nodes
6402020-07-23T19:42:36 <luke-jr> ariard: there is no uniform network policy anyway, nor is the network dependent on that
6412020-07-23T19:42:56 <sipa> well, the network won't actually have any taproot-spending transactions until activation, so i think anything before activation doesn't matter
6422020-07-23T19:43:34 <jeremyrubin> instagibbs: an interesting corollary of your point is it may be good to try to backport wtxid relay even earlier (e.g., 0.19 if possible) to boost those #'s
6432020-07-23T19:43:47 <instagibbs> that might be too difficult/dangerous
6442020-07-23T19:43:52 <instagibbs> (I dont know)
6452020-07-23T19:44:32 <luke-jr> well, if we split Taproot consensus vs policy⦠we only need wtxid relay for policy, right?
6462020-07-23T19:44:39 <ariard> luke-jr: I was thinking consequences on peer eviction/selection, if you degrade performances of a whole subset of them
6472020-07-23T19:44:40 <aj> there's been a punch of p2p changes since 0.20 that will probably make backporting wtxid relay a bit hard at this point (not very hard if you just rewrite it; pretty annoying if you try cherry-picking/rebasing)
6482020-07-23T19:44:42 <luke-jr> so that can proceed in parallel to the consensus/activation
6492020-07-23T19:46:21 <sipa> luke-jr: i don't see how that is related to splitting anything
6502020-07-23T19:46:27 <luke-jr> if activation happens ~a year from now, having only consensus logic in 0.20, and wtxid relay + Taproot policy only with 0.21+ seems fine?
6512020-07-23T19:46:31 <sipa> relay of those relevant transactions won't happen until activation
6522020-07-23T19:47:20 <luke-jr> sipa: right, which is why we don't need to sort relay issues until closer to activation
6532020-07-23T19:47:28 <sipa> yes, i agree with that
6542020-07-23T19:48:08 <luke-jr> we could start the Taproot activation process, and even in the worst case scenario (too few updated to 0.21) have it activate without changing the node policy
6552020-07-23T19:48:18 <instagibbs> mmmm
6562020-07-23T19:48:31 <sipa> wumpus: do we have any other topics?
6572020-07-23T19:48:54 <sipa> i feel the part of the discussion relevant to bitcoin core's release process is over
6582020-07-23T19:49:35 <wumpus> no, that was all
6592020-07-23T19:49:37 <wumpus> #endmeeting
6602020-07-23T19:49:37 <lightningbot> Meeting ended Thu Jul 23 19:49:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6612020-07-23T19:49:37 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-23-19.00.html
6622020-07-23T19:49:37 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-23-19.00.txt
6632020-07-23T19:49:37 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-23-19.00.log.html
6642020-07-23T19:50:45 <somethingsomethi> ok, so bottom line: There are a couple of interesting ideas, but probably it'll be 0.21.1, and relay might come some time after that. Is that about right?
6652020-07-23T19:51:08 <sipa> relay after that? what?
6662020-07-23T19:51:11 <aj> wtxid relay is already merged in master, so will be in 0.21.0
6672020-07-23T19:51:24 <aj> (unless there's some horrible bug or something)
6682020-07-23T19:51:32 <jeremyrubin> I think luke-jr is going to try to summarize in ##taproot-activation
6692020-07-23T19:51:55 <instagibbs> I think a summary would be great, I think I grasped the main points at least
6702020-07-23T19:52:01 <instagibbs> thanks for input sipa wumpus
6712020-07-23T19:52:11 <luke-jr> yeah, I dropped 3 lines; feel free to add more if I forgot anything
6722020-07-23T19:52:37 <luke-jr> somethingsomethi: the split of consensus/relay is only needed if we do deployment of Taproot on 0.20
6732020-07-23T19:52:38 <ariard> for folks working on p2p, what's your opinon between transaction request overhaul or erlay getting first ?
6742020-07-23T19:52:41 <somethingsomethi> sipa: I mean the first step could be just to activate the validation parts, but not relay transactions until wtxid is sufficiently widespread
6752020-07-23T19:52:55 <ariard> (a gleb question who is away to decide on rebase order)
6762020-07-23T19:52:58 <sipa> somethingsomethi: then what's the point?
6772020-07-23T19:53:10 <sipa> "taproot is active, but you can't actually spend anything yet!"
6782020-07-23T19:53:11 <somethingsomethi> luke-jr ah ok. I though it might be an option either way if wtixd uptake is too slow
6792020-07-23T19:53:12 <aj> ariard: overhaul first was my thought
6802020-07-23T19:53:35 <luke-jr> sipa: the point is to have the consensus side ready when the rest is
6812020-07-23T19:54:01 <luke-jr> sipa: since the consensus side may have a long simply-waiting period for activation
6822020-07-23T19:54:25 <jeremyrubin> realistically it will be like a year after activation before there's any big uptake on taproot anyways
6832020-07-23T19:54:26 <sipa> sure, but having it active before it can be used due to relay reasons is pointless
6842020-07-23T19:54:27 <somethingsomethi> sipa: Well, sure. You could look at it as a way to de-risk deployment, but yeah, it wouldn't be overly useful
6852020-07-23T19:54:46 <somethingsomethi> at least the second part wouldn't require so much coordination though
6862020-07-23T19:54:59 <jeremyrubin> clients can reject invalid spending blocks which is super useful for deployed infra
6872020-07-23T19:55:06 <luke-jr> sipa: hopefully 0.21 will be widespread enough before the actual activation occurs
6882020-07-23T19:55:38 <instagibbs> It could theoretically happen if phased consensus->relay deployment had the 2nd part delayed, so important to think about? Meanwhile people can still uptake
6892020-07-23T19:56:06 <sipa> aj, ariard: if erlay is done without the 128-bit txids (which perhaps it should), i think it's almost orthogonal to the tx request overhaul
6902020-07-23T19:56:22 <sipa> as erlay would reuse inv/getdata for the final stage in that setup
6912020-07-23T19:56:56 <aj> sipa: oh no, are you attacking my excuse for not reviewing erlay yet?
6922020-07-23T19:57:19 <sipa> aj: thanks for reminding _me_ i don't have an excuse not to review it!
6932020-07-23T19:57:27 <ariard> I think the last erlay version doesn't have 128-bit txids and new invtx/gettx compare to bip
6942020-07-23T19:59:39 <instagibbs> aj, "I'm lazy" <--- good enough
6952020-07-23T19:59:51 <instagibbs> ariard, you're correct(at least last time i talked to gleb)
6962020-07-23T20:00:44 <aj> instagibbs: too generic
6972020-07-23T20:08:51 *** S3RK has joined #bitcoin-core-dev
6982020-07-23T20:09:21 *** somethingsomethi has quit IRC
6992020-07-23T20:10:19 *** promag has quit IRC
7002020-07-23T20:13:24 *** S3RK has quit IRC
7012020-07-23T20:25:41 *** justanotheruser has quit IRC
7022020-07-23T20:29:29 *** proofofk_ has quit IRC
7032020-07-23T20:30:02 *** shesek has quit IRC
7042020-07-23T20:30:03 *** proofofkeags has joined #bitcoin-core-dev
7052020-07-23T20:33:51 *** kristapsk has quit IRC
7062020-07-23T20:34:05 *** proofofkeags has quit IRC
7072020-07-23T20:37:02 *** AaronvanW has quit IRC
7082020-07-23T20:37:26 *** Guyver2 has quit IRC
7092020-07-23T20:39:06 *** Cadair1 has quit IRC
7102020-07-23T20:42:26 *** proofofkeags has joined #bitcoin-core-dev
7112020-07-23T20:45:20 *** kristapsk has joined #bitcoin-core-dev
7122020-07-23T20:45:47 *** troygiorshev has quit IRC
7132020-07-23T20:46:07 *** troygiorshev has joined #bitcoin-core-dev
7142020-07-23T20:49:29 *** promag has joined #bitcoin-core-dev
7152020-07-23T21:02:10 *** bitcoin-git has joined #bitcoin-core-dev
7162020-07-23T21:02:11 <bitcoin-git> [bitcoin] luke-jr opened pull request #19573: [WIP] Replace unused BIP 9 logic with BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573
7172020-07-23T21:02:12 *** bitcoin-git has left #bitcoin-core-dev
7182020-07-23T21:04:31 *** vincenzopalazzo has joined #bitcoin-core-dev
7192020-07-23T21:06:17 *** arowser has quit IRC
7202020-07-23T21:10:09 *** shesek has joined #bitcoin-core-dev
7212020-07-23T21:12:23 *** jb55 has quit IRC
7222020-07-23T21:14:11 *** shesek has quit IRC
7232020-07-23T21:15:39 *** vincenzopalazzo has quit IRC
7242020-07-23T21:16:11 *** jb55 has joined #bitcoin-core-dev
7252020-07-23T21:18:33 *** arowser has joined #bitcoin-core-dev
7262020-07-23T21:19:07 *** vincenzopalazzo has joined #bitcoin-core-dev
7272020-07-23T21:22:20 *** cubancorona has joined #bitcoin-core-dev
7282020-07-23T21:22:35 *** troygiorshev has quit IRC
7292020-07-23T21:26:50 *** EagleTM has quit IRC
7302020-07-23T21:31:31 *** Klox04 has joined #bitcoin-core-dev
7312020-07-23T21:38:47 *** shesek has joined #bitcoin-core-dev
7322020-07-23T21:43:21 *** promag has quit IRC
7332020-07-23T21:43:37 *** vincenzopalazzo has quit IRC
7342020-07-23T21:43:48 *** promag has joined #bitcoin-core-dev
7352020-07-23T21:45:20 *** EagleTM has joined #bitcoin-core-dev
7362020-07-23T21:55:17 *** justanotheruser has joined #bitcoin-core-dev
7372020-07-23T21:57:11 *** voet has joined #bitcoin-core-dev
7382020-07-23T22:10:37 *** bitcoin-git has joined #bitcoin-core-dev
7392020-07-23T22:10:37 <bitcoin-git> [bitcoin] promag opened pull request #19578: wallet: Avoid duplicate checks on signing failure (master...2020-07-signtransaction) https://github.com/bitcoin/bitcoin/pull/19578
7402020-07-23T22:10:38 *** bitcoin-git has left #bitcoin-core-dev
7412020-07-23T22:23:11 *** kristapsk has quit IRC
7422020-07-23T22:24:09 *** kristapsk has joined #bitcoin-core-dev
7432020-07-23T22:42:26 *** Eagle[TM] has joined #bitcoin-core-dev
7442020-07-23T22:44:46 *** EagleTM has quit IRC
7452020-07-23T22:52:16 *** smurfjack has quit IRC
7462020-07-23T22:54:40 <fanquake> wumpus: thanks
7472020-07-23T22:55:09 *** sipsorcery has quit IRC
7482020-07-23T23:00:35 *** afk11` is now known as afk11
7492020-07-23T23:02:55 *** Davterra has quit IRC
7502020-07-23T23:03:13 *** Davterra has joined #bitcoin-core-dev
7512020-07-23T23:03:59 *** Bullit has joined #bitcoin-core-dev
7522020-07-23T23:17:11 *** grubles has quit IRC
7532020-07-23T23:18:26 *** grubles has joined #bitcoin-core-dev
7542020-07-23T23:38:00 *** sipsorcery has joined #bitcoin-core-dev
7552020-07-23T23:39:45 *** Klox04 has quit IRC
7562020-07-23T23:39:59 *** promag has quit IRC
7572020-07-23T23:46:04 <yanmaani> What's the deal with named parameters? Why are they so rarely used? Were they added recently?
7582020-07-23T23:46:56 <sipa> define rarely used?
7592020-07-23T23:47:21 <yanmaani> Compared to Electrum for example. Most RPC calls take positional args.
7602020-07-23T23:47:48 <sipa> all RPCs accept both
7612020-07-23T23:48:20 <sipa> what people actually use i don't know
7622020-07-23T23:48:31 <yanmaani> oh ok, thanks
7632020-07-23T23:49:49 <sipa> since version 0.14, fwiw
7642020-07-23T23:53:25 *** Eagle[TM] has quit IRC
7652020-07-23T23:53:54 *** cryptapus_ has joined #bitcoin-core-dev
7662020-07-23T23:53:54 *** cryptapus_ has quit IRC
7672020-07-23T23:53:54 *** cryptapus_ has joined #bitcoin-core-dev
7682020-07-23T23:53:56 *** cryptapus has quit IRC