12020-07-27T00:00:03 *** xorAxAx has quit IRC
22020-07-27T00:15:23 *** gzhao408 has quit IRC
32020-07-27T00:22:20 *** noirin has joined #bitcoin-core-dev
42020-07-27T00:39:42 *** promag has quit IRC
52020-07-27T00:42:59 *** Victorsueca has quit IRC
62020-07-27T00:44:03 *** jarthur_ has joined #bitcoin-core-dev
72020-07-27T00:47:46 *** jarthur has quit IRC
82020-07-27T00:49:32 *** Victorsueca has joined #bitcoin-core-dev
92020-07-27T00:58:40 *** troygiorshev has quit IRC
102020-07-27T00:59:15 *** troygiorshev has joined #bitcoin-core-dev
112020-07-27T01:01:01 *** arowser has quit IRC
122020-07-27T01:01:27 *** arowser has joined #bitcoin-core-dev
132020-07-27T01:05:10 *** arowser has quit IRC
142020-07-27T01:05:29 *** arowser has joined #bitcoin-core-dev
152020-07-27T01:10:59 *** Victorsueca has quit IRC
162020-07-27T01:14:51 *** Victorsueca has joined #bitcoin-core-dev
172020-07-27T01:38:08 *** arowser has quit IRC
182020-07-27T01:39:15 *** arowser has joined #bitcoin-core-dev
192020-07-27T01:46:07 *** arowser has quit IRC
202020-07-27T01:46:28 *** gzhao408 has joined #bitcoin-core-dev
212020-07-27T01:48:40 *** jarthur_ is now known as jarthur
222020-07-27T01:49:38 *** arowser_ has joined #bitcoin-core-dev
232020-07-27T01:54:35 *** arowser_ has quit IRC
242020-07-27T01:55:20 *** Victorsueca has quit IRC
252020-07-27T01:58:51 *** Victorsueca has joined #bitcoin-core-dev
262020-07-27T02:01:59 *** arowser_ has joined #bitcoin-core-dev
272020-07-27T02:05:46 *** noirin has quit IRC
282020-07-27T02:11:35 *** shesek has joined #bitcoin-core-dev
292020-07-27T02:11:35 *** shesek has joined #bitcoin-core-dev
302020-07-27T02:13:23 *** Victorsueca has quit IRC
312020-07-27T02:15:05 *** arowser_ has quit IRC
322020-07-27T02:15:34 *** arowser_ has joined #bitcoin-core-dev
332020-07-27T02:20:35 *** arowser_ has quit IRC
342020-07-27T02:22:09 *** arowser_ has joined #bitcoin-core-dev
352020-07-27T02:22:53 *** Victorsueca has joined #bitcoin-core-dev
362020-07-27T02:30:57 *** stranger64 has joined #bitcoin-core-dev
372020-07-27T02:41:11 *** arowser_ has quit IRC
382020-07-27T02:41:36 *** arowser_ has joined #bitcoin-core-dev
392020-07-27T02:50:57 *** arowser_ has quit IRC
402020-07-27T03:00:01 *** stranger64 has quit IRC
412020-07-27T03:03:08 *** arowser_ has joined #bitcoin-core-dev
422020-07-27T03:13:42 *** bitcoin-git has joined #bitcoin-core-dev
432020-07-27T03:13:42 <bitcoin-git> [bitcoin] freenancial closed pull request #19480: build: Only use `@` prefix for `echo` command in Makefiles (master...remove_at_sign_makefile) https://github.com/bitcoin/bitcoin/pull/19480
442020-07-27T03:13:43 *** bitcoin-git has left #bitcoin-core-dev
452020-07-27T03:14:06 *** Victorsueca has quit IRC
462020-07-27T03:18:04 *** Victorsueca has joined #bitcoin-core-dev
472020-07-27T03:22:21 *** seefischer has joined #bitcoin-core-dev
482020-07-27T03:30:27 *** troygiorshev has quit IRC
492020-07-27T03:30:56 *** troygiorshev has joined #bitcoin-core-dev
502020-07-27T03:31:12 *** vasild_ has joined #bitcoin-core-dev
512020-07-27T03:34:03 *** vasild has quit IRC
522020-07-27T03:34:04 *** vasild_ is now known as vasild
532020-07-27T03:41:16 *** Highway61 has quit IRC
542020-07-27T03:44:38 *** Guest416 has joined #bitcoin-core-dev
552020-07-27T03:49:03 *** bitdex has quit IRC
562020-07-27T03:50:25 *** bitdex has joined #bitcoin-core-dev
572020-07-27T03:52:03 *** justan0theruser has quit IRC
582020-07-27T03:52:44 *** Guest416 has left #bitcoin-core-dev
592020-07-27T04:01:32 *** bitcoin-git has joined #bitcoin-core-dev
602020-07-27T04:01:32 <bitcoin-git> [bitcoin] sdaftuar opened pull request #19596: Deduplicate parent txid loop of requested transactions and missing parents of orphan transactions (master...2020-07-dedup-inputs) https://github.com/bitcoin/bitcoin/pull/19596
612020-07-27T04:01:33 *** bitcoin-git has left #bitcoin-core-dev
622020-07-27T04:01:46 *** arowser_ has quit IRC
632020-07-27T04:03:00 *** arowser_ has joined #bitcoin-core-dev
642020-07-27T04:05:25 *** gzhao408 has quit IRC
652020-07-27T04:12:05 *** arowser_ has quit IRC
662020-07-27T04:34:39 *** arowser_ has joined #bitcoin-core-dev
672020-07-27T04:41:07 *** jarthur has quit IRC
682020-07-27T04:41:58 *** jarthur has joined #bitcoin-core-dev
692020-07-27T05:03:32 *** TheHoliestRoger has quit IRC
702020-07-27T05:04:26 *** TheHoliestRoger has joined #bitcoin-core-dev
712020-07-27T05:09:03 *** Asbestos_Vapor has quit IRC
722020-07-27T05:19:05 *** arowser_ has quit IRC
732020-07-27T05:20:13 *** arowser_ has joined #bitcoin-core-dev
742020-07-27T05:42:38 *** justanotheruser has joined #bitcoin-core-dev
752020-07-27T05:42:59 *** jonatack has quit IRC
762020-07-27T05:49:11 *** mdunnio has joined #bitcoin-core-dev
772020-07-27T05:53:58 *** mdunnio has quit IRC
782020-07-27T06:00:01 *** seefischer has quit IRC
792020-07-27T06:11:02 *** arowser_ has quit IRC
802020-07-27T06:11:28 *** arowser_ has joined #bitcoin-core-dev
812020-07-27T06:22:45 *** jonatack has joined #bitcoin-core-dev
822020-07-27T06:24:16 *** icota[m] has joined #bitcoin-core-dev
832020-07-27T06:41:01 *** arowser_ has quit IRC
842020-07-27T06:47:36 *** arowser_ has joined #bitcoin-core-dev
852020-07-27T06:51:59 *** marcoagner has joined #bitcoin-core-dev
862020-07-27T06:55:59 *** Xorlev has joined #bitcoin-core-dev
872020-07-27T07:00:50 *** arowser_ has quit IRC
882020-07-27T07:02:08 *** arowser_ has joined #bitcoin-core-dev
892020-07-27T07:12:41 *** infernix has quit IRC
902020-07-27T07:23:01 *** justanotheruser has quit IRC
912020-07-27T07:28:32 *** justanotheruser has joined #bitcoin-core-dev
922020-07-27T07:29:03 *** jarthur has quit IRC
932020-07-27T07:31:11 *** jarthur has joined #bitcoin-core-dev
942020-07-27T07:34:41 <vasild> sipa: I need varint in order to be able to create and parse addrv2 messages: https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki "time" and "services" use VARINT
952020-07-27T07:36:28 *** jonatack has quit IRC
962020-07-27T07:37:28 <sipa> vasild: heh, that's quite underspecified
972020-07-27T07:37:49 <sipa> bitcoin core's internal varint type isn't used in the p2p protocol anywhere
982020-07-27T07:37:52 <vasild> I implemented (de)ser_varint: https://bpa.st/HTBA, it will end up in some of the addrv2 PRs (still I am only playing with it locally)
992020-07-27T07:38:26 <sipa> vasild: could it just mean compactsize ?
1002020-07-27T07:38:50 <sipa> that's the varint type that's used elsewhere in the p2p protocol
1012020-07-27T07:38:55 <vasild> Isn't used _yet_ ;-)
1022020-07-27T07:39:03 <vasild> I agree it is underspecified other than "see bitcoin core source code"
1032020-07-27T07:39:28 <sipa> i don't even see that?
1042020-07-27T07:39:32 <vasild> no idea if it is supposed to mean compactsize, wumpus ?
1052020-07-27T07:41:43 <vasild> "i don't even see that?" -- yes, not even "see bitcoin core source code", but I think that would be undesirable because the code may change
1062020-07-27T07:42:10 <vasild> why are there two encodings, compactsize and varint?
1072020-07-27T07:43:07 <sipa> compactsize is the one the original source code and protocol from satoshi's time used
1082020-07-27T07:43:44 <sipa> which was called varint everywhere, but compactsize inside the source code (as it was only used to serialize the length of things)
1092020-07-27T07:44:37 <sipa> the varint one was inspired by BER's length encoding, with a slight (and in retrospect not worthwhile) efficiency improvement i came up with
1102020-07-27T07:45:36 <sipa> it was part of the database redesign in 0.8 that introduced the utxo set chainstate database
1112020-07-27T07:45:55 <sipa> where i think it performed better than the compactsize we had
1122020-07-27T07:46:20 <vasild> I see
1132020-07-27T07:47:00 <vasild> is compactsize specified anywhere (other than "look at the code")?
1142020-07-27T07:47:20 <sipa> and maybe part of the confusion here is because the compactsize encoding is often jusy referred to as varint
1152020-07-27T07:48:03 <sipa> vasild: not in any BIPs afaik; things that existed in the protocol before the BIPs process existed as generally just taken as gospel
1162020-07-27T07:48:26 <vasild> maybe the new type should have been named something else than varint
1172020-07-27T07:50:35 <vasild> Ok, so neither one of varint or compactsize is defined in BIPs, but compact size is already used in other places in the p2p protocol whereas varint is not.
1182020-07-27T07:50:44 <vasild> BIP155 says:
1192020-07-27T07:50:44 <vasild> - Jonas Schnelli: change services field to VARINT, to make the message more compact in the likely case instead of always using 8 bytes.
1202020-07-27T07:50:45 <vasild> - Luke-Jr: change time field to VARINT, for post-2038 compatibility.
1212020-07-27T07:51:10 <vasild> jonasschnelli: luke-jr: ^^^ Did you mean compactsize instead of varint? Should we change that to compactsize now?
1222020-07-27T07:52:18 <sipa> for BIP152 there was initially an intention to use varint, but it was changed to compactsize to simplify specification
1232020-07-27T07:52:18 <jonasschnelli> what is the difference between compact size and varint?
1242020-07-27T07:52:32 <sipa> vasild: ^ that's what i mean :p
1252020-07-27T07:52:39 <vasild> Or, well, if in other specs the word "VARINT" is used to mean "compactsize", then should the BIP155 C++ source code use compactsize?
1262020-07-27T07:53:01 <sipa> when people say varint in the context of the protocol, it usually refers to what is known as compactsize in the source code
1272020-07-27T07:53:39 <sipa> jonasschnelli: scroll up a few lines, i gave the history :)
1282020-07-27T07:53:50 <jonasschnelli> just read back... :)
1292020-07-27T07:54:50 *** arowser_ has quit IRC
1302020-07-27T07:59:56 *** arowser_ has joined #bitcoin-core-dev
1312020-07-27T08:02:34 <vasild> git grep -il varint ./bip-0* # 8 occurrences
1322020-07-27T08:02:41 <vasild> s/8 occurrences/mentioned in 8 BIPs/
1332020-07-27T08:03:00 <vasild> and "compactsize" is mentioned in 6 BIPs
1342020-07-27T08:03:02 <sipa> which ones?
1352020-07-27T08:03:23 <vasild> varint:
1362020-07-27T08:03:25 <vasild> bip-0010.mediawiki
1372020-07-27T08:03:25 <vasild> bip-0023.mediawiki
1382020-07-27T08:03:25 <vasild> bip-0037.mediawiki
1392020-07-27T08:03:25 <vasild> bip-0098.mediawiki
1402020-07-27T08:03:25 <vasild> bip-0154.mediawiki
1412020-07-27T08:03:26 <vasild> bip-0155.mediawiki
1422020-07-27T08:03:26 <vasild> bip-0180.mediawiki
1432020-07-27T08:03:26 <vasild> bip-0322.mediawiki
1442020-07-27T08:03:57 <vasild> compactsize:
1452020-07-27T08:04:07 <vasild> bip-0152.mediawiki
1462020-07-27T08:04:07 <vasild> bip-0157.mediawiki
1472020-07-27T08:04:07 <vasild> bip-0158.mediawiki
1482020-07-27T08:04:07 <vasild> bip-0330.mediawiki
1492020-07-27T08:04:07 <vasild> bip-0341.mediawiki
1502020-07-27T08:04:08 <vasild> bip-0342.mediawiki
1512020-07-27T08:07:32 <vasild> Anyway, given that compact size is used in p2p and not varint, I suggest that we change the spec to say "compactsize" instead of "varint" with some clarification like "For the purposes of this section, CompactSize refers to the variable-length integer encoding used acros..." (from bip152) and also change the code to use compactsize instead of varint (the code is in
1522020-07-27T08:07:36 <vasild> https://github.com/bitcoin/bitcoin/pull/19031)
1532020-07-27T08:09:17 <vasild> jonasschnelli: luke-jr: sipa: wumpus: what do you think, (s/VARINT/CompactSize/ in BIP155)?
1542020-07-27T08:09:57 *** promag has joined #bitcoin-core-dev
1552020-07-27T08:10:12 *** promag has quit IRC
1562020-07-27T08:10:30 *** promag has joined #bitcoin-core-dev
1572020-07-27T08:17:24 *** EagleTM has joined #bitcoin-core-dev
1582020-07-27T08:19:25 *** jonatack has joined #bitcoin-core-dev
1592020-07-27T08:23:03 *** Pavlenex has joined #bitcoin-core-dev
1602020-07-27T08:29:38 *** promag_ has joined #bitcoin-core-dev
1612020-07-27T08:30:13 *** infernix has joined #bitcoin-core-dev
1622020-07-27T08:31:05 *** arowser_ has quit IRC
1632020-07-27T08:32:10 *** arowser_ has joined #bitcoin-core-dev
1642020-07-27T08:34:20 *** promag_ has quit IRC
1652020-07-27T08:36:27 *** Xorlev has quit IRC
1662020-07-27T08:47:35 *** promag_ has joined #bitcoin-core-dev
1672020-07-27T08:50:56 <luke-jr> vasild: https://en.bitcoin.it/wiki/Protocol_documentation#Variable_length_integer
1682020-07-27T08:51:04 *** promag_ has quit IRC
1692020-07-27T08:52:48 *** promag_ has joined #bitcoin-core-dev
1702020-07-27T08:52:51 <luke-jr> I'm not sure it makes sense to use the old varint for time/services.. benefits more from the new varint
1712020-07-27T09:02:15 *** promag_ has quit IRC
1722020-07-27T09:22:07 *** kierank1 has joined #bitcoin-core-dev
1732020-07-27T09:34:57 *** promag_ has joined #bitcoin-core-dev
1742020-07-27T09:42:03 *** AaronvanW has joined #bitcoin-core-dev
1752020-07-27T09:56:48 *** promag_ has quit IRC
1762020-07-27T09:58:32 *** promag_ has joined #bitcoin-core-dev
1772020-07-27T10:03:18 *** Marcelino9Daniel has joined #bitcoin-core-dev
1782020-07-27T10:03:18 *** promag_ has quit IRC
1792020-07-27T10:04:45 *** arowser_ has quit IRC
1802020-07-27T10:06:50 *** arowser_ has joined #bitcoin-core-dev
1812020-07-27T10:20:14 *** Marcelino9Daniel has quit IRC
1822020-07-27T10:21:47 *** mutatrum has joined #bitcoin-core-dev
1832020-07-27T10:47:25 *** arowser_ has quit IRC
1842020-07-27T10:47:44 *** arowser_ has joined #bitcoin-core-dev
1852020-07-27T10:50:01 *** infernix has quit IRC
1862020-07-27T10:53:09 *** arowser_ has quit IRC
1872020-07-27T10:53:31 *** arowser_ has joined #bitcoin-core-dev
1882020-07-27T10:53:57 *** belcher_ has joined #bitcoin-core-dev
1892020-07-27T10:57:43 *** belcher has quit IRC
1902020-07-27T10:59:36 *** promag_ has joined #bitcoin-core-dev
1912020-07-27T11:00:56 *** AaronvanW has quit IRC
1922020-07-27T11:04:30 *** promag_ has quit IRC
1932020-07-27T11:09:32 <vasild> luke-jr: actually 4 bytes unsigned integer supports time up to year 2106. Only signed 4 bytes will brick after 2038
1942020-07-27T11:12:03 <vasild> CAddress::nTime is uint32_t - it will work as is in master until 2106. I think there is no need to change it to varint or compact size in order to make it post-2038 proof. varint or compactsize would need 5 bytes today.
1952020-07-27T11:19:47 *** arowser_ has quit IRC
1962020-07-27T11:21:39 <vasild> For services - both varint and compact size will use 1 byte if NODE_NETWORK_LIMITED is not involved.
1972020-07-27T11:22:06 <vasild> And if NODE_NETWORK_LIMITED is set, then compactsize will use 3 bytes whereas varint will use 2 bytes.
1982020-07-27T11:23:11 *** bitcoin-git has joined #bitcoin-core-dev
1992020-07-27T11:23:12 <bitcoin-git> [bitcoin] theStack opened pull request #19597: test: test decodepsbt fee calculation (count input value only once per UTXO) (master...20200726-test-check-deceodepsbt-fee-calculation) https://github.com/bitcoin/bitcoin/pull/19597
2002020-07-27T11:23:13 *** bitcoin-git has left #bitcoin-core-dev
2012020-07-27T11:23:26 <vasild> Is saving 1 byte worth introducing a new encoding?
2022020-07-27T11:23:33 *** Victorsueca has quit IRC
2032020-07-27T11:27:59 *** Victorsueca has joined #bitcoin-core-dev
2042020-07-27T11:32:12 *** arowser_ has joined #bitcoin-core-dev
2052020-07-27T11:32:25 *** Pavlenex has quit IRC
2062020-07-27T11:39:49 *** AaronvanW has joined #bitcoin-core-dev
2072020-07-27T11:41:41 *** troygiorshev has quit IRC
2082020-07-27T11:42:26 *** Mercury_Vapor has joined #bitcoin-core-dev
2092020-07-27T11:42:44 *** troygiorshev has joined #bitcoin-core-dev
2102020-07-27T11:43:43 *** Pavlenex has joined #bitcoin-core-dev
2112020-07-27T11:44:37 *** AaronvanW has quit IRC
2122020-07-27T11:46:25 *** arowser_ has quit IRC
2132020-07-27T11:46:55 <wumpus> vasild: does it introduce a new encoding?
2142020-07-27T11:47:41 <wumpus> saving a byte per address sounds good actually
2152020-07-27T11:48:20 *** arowser_ has joined #bitcoin-core-dev
2162020-07-27T11:48:22 <vasild> wumpus: as it turns out VARINT is not used anywhere in P2P, CompactSize is used instead.
2172020-07-27T11:49:02 <wumpus> ok
2182020-07-27T11:49:16 <vasild> So from P2P point of view VARINT is a new encoding.
2192020-07-27T11:49:38 <wumpus> so VARINT is only used in on-disk files?
2202020-07-27T11:49:50 <wumpus> agree that it'd be preferable not to introduce it into P2P then
2212020-07-27T11:50:00 <wumpus> though it's not a complex encoding
2222020-07-27T11:50:12 <vasild> btw, I did not check that myself, but I trust sipa on it
2232020-07-27T11:50:32 <vasild> both varint and compactsize are mentioned in some BIPs
2242020-07-27T11:51:11 <vasild> but I gather "varint" in BIPs may be used to denote what the source code calls compactsize
2252020-07-27T11:51:45 <wumpus> I'm definitely going with sipa's judgement on this :)
2262020-07-27T11:51:48 *** AaronvanW has joined #bitcoin-core-dev
2272020-07-27T11:52:29 <vasild> yes, it is not complex - I did the python implementation in order to do some more testing of it, python ser/deser: https://bpa.st/HTBA
2282020-07-27T11:52:59 *** vincenzopalazzo has joined #bitcoin-core-dev
2292020-07-27T11:54:51 <vasild> btw, there is one more concern wrt VARINT - it supports unlimited size and the deserializer would throw an exception for a code like: uint64_t x; stream >> VARINT(x); given a specially crafted sequence of bytes
2302020-07-27T11:55:36 <vasild> e.g. 9 bytes that all have the first bit set would overflow uint64_t
2312020-07-27T11:57:04 *** promag_ has joined #bitcoin-core-dev
2322020-07-27T11:57:21 <vasild> So, any code that reads varint from the network has to do: try { stream >> VARINT(x); } catch (...) { aha! }
2332020-07-27T11:58:02 *** bitcoin-git has joined #bitcoin-core-dev
2342020-07-27T11:58:02 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d2b4098a9e...b62fbf9e1c19
2352020-07-27T11:58:03 <bitcoin-git> bitcoin/master 7b3851e Hennadii Stepanov: refactor: Drop unused CBufferedFile::Seek()
2362020-07-27T11:58:03 <bitcoin-git> bitcoin/master b62fbf9 Wladimir J. van der Laan: Merge #19593: refactor: Drop unused CBufferedFile::Seek()
2372020-07-27T11:58:05 *** bitcoin-git has left #bitcoin-core-dev
2382020-07-27T11:58:22 *** bitcoin-git has joined #bitcoin-core-dev
2392020-07-27T11:58:22 <bitcoin-git> [bitcoin] laanwj merged pull request #19593: refactor: Drop unused CBufferedFile::Seek() (master...200726-seek) https://github.com/bitcoin/bitcoin/pull/19593
2402020-07-27T11:58:23 *** bitcoin-git has left #bitcoin-core-dev
2412020-07-27T12:00:02 *** kierank1 has quit IRC
2422020-07-27T12:01:47 *** bitcoin-git has joined #bitcoin-core-dev
2432020-07-27T12:01:47 <bitcoin-git> [bitcoin] troygiorshev opened pull request #19599: Clean message_count and last_message (master...2020-07-clean-message_count) https://github.com/bitcoin/bitcoin/pull/19599
2442020-07-27T12:01:48 *** bitcoin-git has left #bitcoin-core-dev
2452020-07-27T12:01:54 *** promag_ has quit IRC
2462020-07-27T12:10:07 *** bitcoin-git has joined #bitcoin-core-dev
2472020-07-27T12:10:07 <bitcoin-git> [bitcoin] troygiorshev closed pull request #19580: test: Remove message_count (master...2020-07-remove-message_count) https://github.com/bitcoin/bitcoin/pull/19580
2482020-07-27T12:10:08 *** bitcoin-git has left #bitcoin-core-dev
2492020-07-27T12:10:12 *** arowser_ has quit IRC
2502020-07-27T12:10:42 *** arowser_ has joined #bitcoin-core-dev
2512020-07-27T12:11:24 *** mably has joined #bitcoin-core-dev
2522020-07-27T12:16:07 *** promag_ has joined #bitcoin-core-dev
2532020-07-27T12:18:54 *** arowser_ has quit IRC
2542020-07-27T12:20:11 *** promag_ has quit IRC
2552020-07-27T12:21:40 *** amcrae1 has joined #bitcoin-core-dev
2562020-07-27T12:24:11 *** Pavlenex has quit IRC
2572020-07-27T12:25:24 *** Pavlenex has joined #bitcoin-core-dev
2582020-07-27T12:31:05 *** arowser_ has joined #bitcoin-core-dev
2592020-07-27T12:34:14 *** Pavlenex has quit IRC
2602020-07-27T12:41:48 *** Davterra has quit IRC
2612020-07-27T12:41:56 *** Davterra has joined #bitcoin-core-dev
2622020-07-27T12:44:05 *** Guyver2 has joined #bitcoin-core-dev
2632020-07-27T12:46:40 *** EagleTM has quit IRC
2642020-07-27T12:49:39 *** EagleTM has joined #bitcoin-core-dev
2652020-07-27T12:56:42 *** arowser_ has quit IRC
2662020-07-27T12:56:49 *** Deacyde has joined #bitcoin-core-dev
2672020-07-27T12:58:36 *** arowser_ has joined #bitcoin-core-dev
2682020-07-27T13:01:10 *** Deacyde has quit IRC
2692020-07-27T13:07:11 *** arowser_ has quit IRC
2702020-07-27T13:07:31 *** arowser_ has joined #bitcoin-core-dev
2712020-07-27T13:08:08 *** arowser_ has quit IRC
2722020-07-27T13:08:32 *** arowser_ has joined #bitcoin-core-dev
2732020-07-27T13:09:11 *** arowser_ has quit IRC
2742020-07-27T13:09:30 *** arowser_ has joined #bitcoin-core-dev
2752020-07-27T13:10:15 *** arowser_ has quit IRC
2762020-07-27T13:10:25 *** vasild_ has joined #bitcoin-core-dev
2772020-07-27T13:10:47 *** arowser_ has joined #bitcoin-core-dev
2782020-07-27T13:12:11 *** arowser_ has quit IRC
2792020-07-27T13:12:29 *** arowser_ has joined #bitcoin-core-dev
2802020-07-27T13:12:43 *** vasild has quit IRC
2812020-07-27T13:12:44 *** vasild_ is now known as vasild
2822020-07-27T13:15:14 *** infernix has joined #bitcoin-core-dev
2832020-07-27T13:23:01 *** arowser_ has quit IRC
2842020-07-27T13:23:54 *** Victorsueca has quit IRC
2852020-07-27T13:29:37 *** arowser_ has joined #bitcoin-core-dev
2862020-07-27T13:30:02 *** harrigan has quit IRC
2872020-07-27T13:30:13 *** harrigan has joined #bitcoin-core-dev
2882020-07-27T13:30:41 *** proofofkeags has joined #bitcoin-core-dev
2892020-07-27T13:32:19 *** Victorsueca has joined #bitcoin-core-dev
2902020-07-27T13:40:11 *** Victorsueca has quit IRC
2912020-07-27T13:42:31 *** infernix has quit IRC
2922020-07-27T13:45:30 *** Victorsueca has joined #bitcoin-core-dev
2932020-07-27T13:45:35 *** mdunnio has joined #bitcoin-core-dev
2942020-07-27T13:45:56 *** Earnest16Gottlie has joined #bitcoin-core-dev
2952020-07-27T13:50:44 *** bitdex has quit IRC
2962020-07-27T13:51:12 *** arowser_ has quit IRC
2972020-07-27T13:51:14 *** Earnest16Gottlie has quit IRC
2982020-07-27T13:51:39 *** arowser_ has joined #bitcoin-core-dev
2992020-07-27T13:57:54 *** Victorsueca has quit IRC
3002020-07-27T14:01:47 *** infernix has joined #bitcoin-core-dev
3012020-07-27T14:02:08 *** Victorsueca has joined #bitcoin-core-dev
3022020-07-27T14:09:25 *** Victorsueca has quit IRC
3032020-07-27T14:11:11 *** Victorsueca has joined #bitcoin-core-dev
3042020-07-27T14:13:11 *** mdunnio has quit IRC
3052020-07-27T14:13:15 *** arowser_ has quit IRC
3062020-07-27T14:13:33 *** mdunnio has joined #bitcoin-core-dev
3072020-07-27T14:13:34 *** arowser_ has joined #bitcoin-core-dev
3082020-07-27T14:18:45 *** proofofkeags has quit IRC
3092020-07-27T14:29:57 *** mably has quit IRC
3102020-07-27T14:30:49 *** jb55 has quit IRC
3112020-07-27T14:31:46 *** jb55 has joined #bitcoin-core-dev
3122020-07-27T14:32:04 *** arowser_ has quit IRC
3132020-07-27T14:32:44 *** Davterra has quit IRC
3142020-07-27T14:40:03 *** Davterra has joined #bitcoin-core-dev
3152020-07-27T14:44:37 *** arowser_ has joined #bitcoin-core-dev
3162020-07-27T14:57:41 *** Davterra has quit IRC
3172020-07-27T14:59:58 *** Davterra has joined #bitcoin-core-dev
3182020-07-27T15:00:02 *** amcrae1 has quit IRC
3192020-07-27T15:01:06 *** hack_you_now has joined #bitcoin-core-dev
3202020-07-27T15:03:56 *** Deacyde has joined #bitcoin-core-dev
3212020-07-27T15:07:47 *** infernix has quit IRC
3222020-07-27T15:11:44 *** Guyver2 has quit IRC
3232020-07-27T15:14:43 *** Guyver2 has joined #bitcoin-core-dev
3242020-07-27T15:17:47 *** arowser_ has quit IRC
3252020-07-27T15:20:35 *** Victorsueca has quit IRC
3262020-07-27T15:21:25 *** gnomus has joined #bitcoin-core-dev
3272020-07-27T15:25:59 *** Victorsueca has joined #bitcoin-core-dev
3282020-07-27T15:29:56 *** arowser_ has joined #bitcoin-core-dev
3292020-07-27T15:31:11 *** vasild_ has joined #bitcoin-core-dev
3302020-07-27T15:35:03 *** vasild has quit IRC
3312020-07-27T15:35:04 *** vasild_ is now known as vasild
3322020-07-27T15:35:30 *** roconnor has quit IRC
3332020-07-27T15:35:52 *** roconnor has joined #bitcoin-core-dev
3342020-07-27T15:37:18 *** EagleTM has quit IRC
3352020-07-27T15:41:32 *** gnomus has quit IRC
3362020-07-27T15:56:05 *** wgolden has joined #bitcoin-core-dev
3372020-07-27T15:56:40 *** infernix has joined #bitcoin-core-dev
3382020-07-27T15:57:05 *** arowser_ has quit IRC
3392020-07-27T15:58:03 *** arowser_ has joined #bitcoin-core-dev
3402020-07-27T15:59:03 *** Victorsueca has quit IRC
3412020-07-27T16:04:06 *** Victorsueca has joined #bitcoin-core-dev
3422020-07-27T16:07:14 *** proofofkeags has joined #bitcoin-core-dev
3432020-07-27T16:11:39 *** infernix has quit IRC
3442020-07-27T16:28:00 *** jarthur_ has joined #bitcoin-core-dev
3452020-07-27T16:28:49 *** Talkless has joined #bitcoin-core-dev
3462020-07-27T16:30:41 *** jarthur has quit IRC
3472020-07-27T16:39:40 <alko89> hi, I have a question about segwit (I know late...)
3482020-07-27T16:39:51 <alko89> so if the segwit data is separated and not part of the blockchain
3492020-07-27T16:39:57 <alko89> what is the incentive to store that data?
3502020-07-27T16:40:06 <sipa> it is part of the blockchain, and committed to by blocks
3512020-07-27T16:40:20 <sipa> just not by the txid that are used by other transactions that refer back to it
3522020-07-27T16:40:29 <alko89> but the block is 1MB and the withess data is 4MB right?
3532020-07-27T16:40:40 <alko89> ahhh
3542020-07-27T16:41:03 <alko89> so when the utxo is spent, the data gets removed?
3552020-07-27T16:41:07 <sipa> no
3562020-07-27T16:41:16 <sipa> it's part of the blockchain just as much as everything else
3572020-07-27T16:41:19 <sipa> it's just separate
3582020-07-27T16:41:38 <sipa> but it is data that never enters the utxo set, so it has less impact on nodes' operations
3592020-07-27T16:41:43 <alko89> hmmmm...but that means the block size did increase with segwit update :P
3602020-07-27T16:41:50 <sipa> yes, of course
3612020-07-27T16:42:06 <alko89> awwwwwwww!!!!
3622020-07-27T16:42:10 <alko89> thanks!
3632020-07-27T16:42:17 <sipa> https://bitcoin.stackexchange.com/questions/52196/is-segwit-a-blocksize-increase-or-more-efficient-use-of-blockspace
3642020-07-27T16:47:13 <alko89> another question: If I'm not mistaken segwit transactions are visible by the old nodes as being spendable by all?
3652020-07-27T16:47:46 *** infernix has joined #bitcoin-core-dev
3662020-07-27T16:48:19 <sipa> bitcoin.stackexchange.com is probably a better place to ask
3672020-07-27T16:48:42 <sipa> there are plenty of questions on that topic already
3682020-07-27T16:53:06 *** Pavlenex has joined #bitcoin-core-dev
3692020-07-27T17:00:25 *** proofofkeags has quit IRC
3702020-07-27T17:05:01 *** rh0nj has quit IRC
3712020-07-27T17:05:08 *** asoltys has joined #bitcoin-core-dev
3722020-07-27T17:05:20 *** troygiorshev has quit IRC
3732020-07-27T17:05:39 *** troygiorshev has joined #bitcoin-core-dev
3742020-07-27T17:06:08 *** rh0nj has joined #bitcoin-core-dev
3752020-07-27T17:06:15 *** promag_ has joined #bitcoin-core-dev
3762020-07-27T17:10:25 *** promag_ has quit IRC
3772020-07-27T17:11:25 *** esotericnonsense has quit IRC
3782020-07-27T17:15:14 *** Pavlenex has quit IRC
3792020-07-27T17:16:10 *** Pavlenex has joined #bitcoin-core-dev
3802020-07-27T17:19:34 *** pinheadmz has quit IRC
3812020-07-27T17:19:46 *** mutatrum has quit IRC
3822020-07-27T17:20:13 *** Pavlenex has joined #bitcoin-core-dev
3832020-07-27T17:21:13 *** Victorsueca has quit IRC
3842020-07-27T17:22:52 *** jarthur_ is now known as jarthur
3852020-07-27T17:24:49 *** esotericnonsense has joined #bitcoin-core-dev
3862020-07-27T17:26:31 *** Victorsueca has joined #bitcoin-core-dev
3872020-07-27T17:34:11 *** Victorsueca has quit IRC
3882020-07-27T17:35:03 *** someone235 has quit IRC
3892020-07-27T17:39:05 *** proofofkeags has joined #bitcoin-core-dev
3902020-07-27T17:41:31 *** Victorsueca has joined #bitcoin-core-dev
3912020-07-27T17:44:14 *** bitcoin-git has joined #bitcoin-core-dev
3922020-07-27T17:44:15 <bitcoin-git> [bitcoin] hebasto opened pull request #19600: doc: Fix log message for -reindex (master...200727-load-log) https://github.com/bitcoin/bitcoin/pull/19600
3932020-07-27T17:44:16 *** bitcoin-git has left #bitcoin-core-dev
3942020-07-27T17:48:05 *** Victorsueca has quit IRC
3952020-07-27T17:52:41 *** earlz has joined #bitcoin-core-dev
3962020-07-27T17:56:50 *** Victorsueca has joined #bitcoin-core-dev
3972020-07-27T17:57:36 *** troygiorshev has quit IRC
3982020-07-27T17:58:17 *** troygiorshev has joined #bitcoin-core-dev
3992020-07-27T18:00:02 *** wgolden has quit IRC
4002020-07-27T18:00:05 *** proofofkeags has quit IRC
4012020-07-27T18:03:05 *** Victorsueca has quit IRC
4022020-07-27T18:04:13 *** Pavlenex has quit IRC
4032020-07-27T18:06:42 *** mutatrum has joined #bitcoin-core-dev
4042020-07-27T18:10:56 * midnight prods sipa re: graphs..?
4052020-07-27T18:10:59 *** Victorsueca has joined #bitcoin-core-dev
4062020-07-27T18:16:30 *** hack_you_now has quit IRC
4072020-07-27T18:18:01 *** thunderbiscuit has joined #bitcoin-core-dev
4082020-07-27T18:21:26 *** dscho has joined #bitcoin-core-dev
4092020-07-27T18:27:30 <sipa> midnight: oops, on it
4102020-07-27T18:28:59 *** Chris_Stewart_5 has quit IRC
4112020-07-27T18:31:55 <midnight> <3
4122020-07-27T18:32:35 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4132020-07-27T18:34:15 *** thunderbiscuit1 has joined #bitcoin-core-dev
4142020-07-27T18:37:47 *** mutatrum has quit IRC
4152020-07-27T18:55:45 *** troygiorshev has quit IRC
4162020-07-27T18:57:02 *** troygiorshev has joined #bitcoin-core-dev
4172020-07-27T18:57:23 *** vasild has quit IRC
4182020-07-27T19:00:03 *** Talkless has quit IRC
4192020-07-27T19:01:14 *** arowser_ has quit IRC
4202020-07-27T19:01:39 *** arowser_ has joined #bitcoin-core-dev
4212020-07-27T19:02:22 *** proofofkeags has joined #bitcoin-core-dev
4222020-07-27T19:06:43 *** proofofkeags has quit IRC
4232020-07-27T19:12:05 *** arowser_ has quit IRC
4242020-07-27T19:12:23 *** arowser_ has joined #bitcoin-core-dev
4252020-07-27T19:12:32 <sipa> midnight: better?
4262020-07-27T19:15:35 *** isis is now known as isis_
4272020-07-27T19:23:10 *** Victorsueca has quit IRC
4282020-07-27T19:26:46 <midnight> sipa: beautiful!
4292020-07-27T19:28:24 <ahmed_> https://gist.github.com/ahmedbodi/c19eae5afddb72348a53d7b71b185bae <- does anyone have any ideas what im doing wrong here? i get a CDataStream error while trying to connect to the P2P port of bitcoind
4302020-07-27T19:29:28 <sipa> ahmed_: most likely that means you sent a message that's shorter than expected
4312020-07-27T19:30:26 <ahmed_> @sipa thats why im confused, ive pulled CAddress code from @petertodd's bitcoin-python and the Version message code is tidied up version of the msg_version code in his repo
4322020-07-27T19:30:44 *** Victorsueca has joined #bitcoin-core-dev
4332020-07-27T19:32:56 *** vasild has joined #bitcoin-core-dev
4342020-07-27T19:35:09 *** mutatrum has joined #bitcoin-core-dev
4352020-07-27T19:40:42 *** proofofkeags has joined #bitcoin-core-dev
4362020-07-27T19:45:47 *** proofofkeags has quit IRC
4372020-07-27T19:46:30 *** mutatrum has quit IRC
4382020-07-27T20:01:56 *** proofofkeags has joined #bitcoin-core-dev
4392020-07-27T20:02:27 *** bitcoin-git has joined #bitcoin-core-dev
4402020-07-27T20:02:27 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071) (master...refactoring-hashers-2) https://github.com/bitcoin/bitcoin/pull/19601
4412020-07-27T20:02:28 *** bitcoin-git has left #bitcoin-core-dev
4422020-07-27T20:04:36 *** filchef has joined #bitcoin-core-dev
4432020-07-27T20:05:27 *** filchef has quit IRC
4442020-07-27T20:11:03 *** ossifrage has quit IRC
4452020-07-27T20:18:32 *** dscho has quit IRC
4462020-07-27T20:22:42 *** bitcoin-git has joined #bitcoin-core-dev
4472020-07-27T20:22:42 <bitcoin-git> [bitcoin] achow101 opened pull request #19602: wallet: Migrate legacy wallets to descriptor wallets (master...descriptor-wallet-migration) https://github.com/bitcoin/bitcoin/pull/19602
4482020-07-27T20:22:43 *** bitcoin-git has left #bitcoin-core-dev
4492020-07-27T20:25:37 *** mutatrum has joined #bitcoin-core-dev
4502020-07-27T20:34:55 *** alpounet has joined #bitcoin-core-dev
4512020-07-27T20:55:41 *** owowo has joined #bitcoin-core-dev
4522020-07-27T20:55:42 *** owowo has joined #bitcoin-core-dev
4532020-07-27T21:00:02 *** alpounet has quit IRC
4542020-07-27T21:14:20 *** isis_ is now known as isis
4552020-07-27T21:14:41 *** isis is now known as isis_
4562020-07-27T21:17:23 *** Victorsueca has quit IRC
4572020-07-27T21:21:17 *** ogelbukh has joined #bitcoin-core-dev
4582020-07-27T21:27:00 *** Victorsueca has joined #bitcoin-core-dev
4592020-07-27T21:32:29 *** Victorsueca has quit IRC
4602020-07-27T21:45:48 *** pinheadmz has joined #bitcoin-core-dev
4612020-07-27T21:46:35 *** arowser_ has quit IRC
4622020-07-27T21:52:13 *** Victorsueca has joined #bitcoin-core-dev
4632020-07-27T21:52:52 *** Guyver2 has quit IRC
4642020-07-27T21:53:05 *** arowser_ has joined #bitcoin-core-dev
4652020-07-27T22:00:13 *** Victorsueca has quit IRC
4662020-07-27T22:33:36 *** Chris_Stewart_5 has quit IRC
4672020-07-27T22:34:22 *** marcoagner has quit IRC
4682020-07-27T22:37:44 *** ossifrage has joined #bitcoin-core-dev
4692020-07-27T22:44:55 *** owowo has quit IRC
4702020-07-27T22:55:02 *** EagleTM has joined #bitcoin-core-dev
4712020-07-27T23:01:30 *** arowser_ has quit IRC
4722020-07-27T23:02:12 *** arowser_ has joined #bitcoin-core-dev
4732020-07-27T23:19:23 *** Evel-Knievel has quit IRC
4742020-07-27T23:19:42 *** Evel-Knievel has joined #bitcoin-core-dev
4752020-07-27T23:21:13 *** mdunnio has quit IRC
4762020-07-27T23:41:25 *** troygiorshev has quit IRC
4772020-07-27T23:46:48 *** vincenzopalazzo has quit IRC
4782020-07-27T23:48:18 *** proofofkeags has quit IRC
4792020-07-27T23:49:38 *** nckx is now known as ^
4802020-07-27T23:50:37 *** ^ is now known as nckx
4812020-07-27T23:54:25 *** EagleTM has quit IRC