12020-08-03T00:00:02 *** strattog has quit IRC
22020-08-03T00:00:33 *** Pavlenex has joined #bitcoin-core-dev
32020-08-03T00:08:44 *** justanotheruser has joined #bitcoin-core-dev
42020-08-03T00:13:59 *** Pavlenex has quit IRC
52020-08-03T00:20:02 *** justanotheruser has quit IRC
62020-08-03T00:20:11 *** AaronvanW has joined #bitcoin-core-dev
72020-08-03T00:21:57 *** traph has joined #bitcoin-core-dev
82020-08-03T00:27:58 *** gzhao408 has joined #bitcoin-core-dev
92020-08-03T00:33:14 *** promag has quit IRC
102020-08-03T00:50:20 *** AaronvanW has quit IRC
112020-08-03T01:03:37 *** bitcoin-git has joined #bitcoin-core-dev
122020-08-03T01:03:37 <bitcoin-git> [bitcoin] instagibbs opened pull request #19649: Restore test case for p2p transaction blinding (master...p2p_segwit_reject) https://github.com/bitcoin/bitcoin/pull/19649
132020-08-03T01:03:38 *** bitcoin-git has left #bitcoin-core-dev
142020-08-03T01:05:05 *** tomahawk has joined #bitcoin-core-dev
152020-08-03T01:06:19 *** tomahawk has quit IRC
162020-08-03T01:11:55 *** troygiorshev has joined #bitcoin-core-dev
172020-08-03T01:44:29 *** gzhao408 has quit IRC
182020-08-03T01:51:13 *** shesek has quit IRC
192020-08-03T01:53:09 *** mdunnio has joined #bitcoin-core-dev
202020-08-03T01:57:23 *** mdunnio has quit IRC
212020-08-03T02:05:10 *** arowser_ has quit IRC
222020-08-03T02:05:38 *** arowser_ has joined #bitcoin-core-dev
232020-08-03T02:12:20 *** proofofkeags has joined #bitcoin-core-dev
242020-08-03T02:19:36 *** AaronvanW has joined #bitcoin-core-dev
252020-08-03T02:21:50 *** Highway61 has quit IRC
262020-08-03T02:23:09 *** Bullitje has joined #bitcoin-core-dev
272020-08-03T02:25:53 *** Bullit has quit IRC
282020-08-03T02:27:59 *** gzhao408 has joined #bitcoin-core-dev
292020-08-03T02:48:12 *** justanotheruser has joined #bitcoin-core-dev
302020-08-03T02:49:12 *** arowser_ has quit IRC
312020-08-03T02:49:40 *** arowser_ has joined #bitcoin-core-dev
322020-08-03T02:52:35 *** AaronvanW has quit IRC
332020-08-03T02:55:53 *** proofofkeags has quit IRC
342020-08-03T02:56:26 *** proofofkeags has joined #bitcoin-core-dev
352020-08-03T03:00:01 *** traph has quit IRC
362020-08-03T03:01:00 *** proofofkeags has quit IRC
372020-08-03T03:05:11 *** arowser_ has quit IRC
382020-08-03T03:05:39 *** arowser_ has joined #bitcoin-core-dev
392020-08-03T03:08:03 *** luke-jr has quit IRC
402020-08-03T03:08:58 *** luke-jr has joined #bitcoin-core-dev
412020-08-03T03:12:12 *** cfields_ has quit IRC
422020-08-03T03:12:22 *** cfields has joined #bitcoin-core-dev
432020-08-03T03:12:38 *** AaronvanW has joined #bitcoin-core-dev
442020-08-03T03:14:08 *** cfields has quit IRC
452020-08-03T03:15:03 *** cfields has joined #bitcoin-core-dev
462020-08-03T03:15:45 *** cfields has quit IRC
472020-08-03T03:22:18 *** glidenote has joined #bitcoin-core-dev
482020-08-03T03:23:59 *** arowser_ has quit IRC
492020-08-03T03:24:24 *** arowser_ has joined #bitcoin-core-dev
502020-08-03T03:28:59 *** rabidus has quit IRC
512020-08-03T03:29:39 *** berndj has quit IRC
522020-08-03T03:29:59 *** rabidus has joined #bitcoin-core-dev
532020-08-03T03:30:15 *** berndj has joined #bitcoin-core-dev
542020-08-03T03:38:16 *** justanotheruser has quit IRC
552020-08-03T03:38:54 *** justanotheruser has joined #bitcoin-core-dev
562020-08-03T03:41:21 *** bitcoin-git has joined #bitcoin-core-dev
572020-08-03T03:41:21 <bitcoin-git> [bitcoin] kallewoof reopened pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
582020-08-03T03:41:22 *** bitcoin-git has left #bitcoin-core-dev
592020-08-03T03:46:47 *** jarthur_ has joined #bitcoin-core-dev
602020-08-03T03:47:32 *** jarthur has quit IRC
612020-08-03T04:01:11 *** arowser_ has quit IRC
622020-08-03T04:01:37 *** arowser_ has joined #bitcoin-core-dev
632020-08-03T04:02:14 *** gzhao408 has quit IRC
642020-08-03T04:31:06 *** shesek has joined #bitcoin-core-dev
652020-08-03T04:31:06 *** shesek has joined #bitcoin-core-dev
662020-08-03T05:02:58 *** dviola has joined #bitcoin-core-dev
672020-08-03T05:06:57 *** dviola has quit IRC
682020-08-03T05:09:03 *** Talkless has joined #bitcoin-core-dev
692020-08-03T06:00:02 *** glidenote has quit IRC
702020-08-03T06:06:25 *** onokatio has quit IRC
712020-08-03T06:21:32 *** arowser_ has quit IRC
722020-08-03T06:22:11 *** Snuupy1 has joined #bitcoin-core-dev
732020-08-03T06:22:35 *** luke-jr has quit IRC
742020-08-03T06:23:35 *** arowser_ has joined #bitcoin-core-dev
752020-08-03T06:25:28 *** luke-jr has joined #bitcoin-core-dev
762020-08-03T07:15:38 *** marcoagner has joined #bitcoin-core-dev
772020-08-03T07:19:23 *** TheHoliestRoger has quit IRC
782020-08-03T07:21:40 *** TheHoliestRoger has joined #bitcoin-core-dev
792020-08-03T07:36:06 *** justanotheruser has quit IRC
802020-08-03T07:43:54 *** promag has joined #bitcoin-core-dev
812020-08-03T07:48:36 *** jonatack has quit IRC
822020-08-03T07:48:52 *** promag has quit IRC
832020-08-03T07:56:44 *** dviola has joined #bitcoin-core-dev
842020-08-03T07:57:52 *** promag has joined #bitcoin-core-dev
852020-08-03T08:00:08 *** arowser_ has quit IRC
862020-08-03T08:00:36 *** arowser_ has joined #bitcoin-core-dev
872020-08-03T08:02:28 *** promag has quit IRC
882020-08-03T08:21:36 *** victorSN has quit IRC
892020-08-03T08:21:36 *** rockhouse has quit IRC
902020-08-03T08:24:11 *** rockhouse has joined #bitcoin-core-dev
912020-08-03T08:24:32 *** victorSN has joined #bitcoin-core-dev
922020-08-03T08:28:57 *** Guyver2 has joined #bitcoin-core-dev
932020-08-03T08:31:01 *** promag has joined #bitcoin-core-dev
942020-08-03T08:35:50 *** promag has quit IRC
952020-08-03T08:38:35 *** arowser_ has quit IRC
962020-08-03T08:38:59 *** arowser_ has joined #bitcoin-core-dev
972020-08-03T08:40:12 *** arowser_ has quit IRC
982020-08-03T08:40:51 *** arowser_ has joined #bitcoin-core-dev
992020-08-03T08:41:11 *** arowser_ has quit IRC
1002020-08-03T08:41:31 *** arowser_ has joined #bitcoin-core-dev
1012020-08-03T08:53:04 *** arowser_ has quit IRC
1022020-08-03T08:56:43 *** arowser_ has joined #bitcoin-core-dev
1032020-08-03T09:00:02 *** Snuupy1 has quit IRC
1042020-08-03T09:01:34 *** wullon5 has quit IRC
1052020-08-03T09:04:59 *** SergeySherkunov[ has quit IRC
1062020-08-03T09:05:14 *** promag has joined #bitcoin-core-dev
1072020-08-03T09:06:04 *** Pavlenex has joined #bitcoin-core-dev
1082020-08-03T09:12:41 *** BGL has quit IRC
1092020-08-03T09:13:21 *** infamously[m] has left #bitcoin-core-dev
1102020-08-03T09:16:38 *** jonas_ has joined #bitcoin-core-dev
1112020-08-03T09:17:43 *** Pavlenex has quit IRC
1122020-08-03T09:20:45 *** Gunni1 has joined #bitcoin-core-dev
1132020-08-03T09:21:32 *** belcher_ has joined #bitcoin-core-dev
1142020-08-03T09:24:45 *** belcher has quit IRC
1152020-08-03T09:25:43 *** jb55 has quit IRC
1162020-08-03T09:31:17 *** promag has quit IRC
1172020-08-03T09:31:54 *** promag has joined #bitcoin-core-dev
1182020-08-03T09:33:45 *** arowser_ has quit IRC
1192020-08-03T09:36:11 *** promag has quit IRC
1202020-08-03T09:36:49 *** jonatack has joined #bitcoin-core-dev
1212020-08-03T09:37:23 *** arowser_ has joined #bitcoin-core-dev
1222020-08-03T09:37:23 *** jonatack has quit IRC
1232020-08-03T09:38:40 *** promag has joined #bitcoin-core-dev
1242020-08-03T09:39:17 *** jb55 has joined #bitcoin-core-dev
1252020-08-03T09:43:38 *** jonatack has joined #bitcoin-core-dev
1262020-08-03T09:44:25 *** promag has quit IRC
1272020-08-03T09:45:02 *** promag has joined #bitcoin-core-dev
1282020-08-03T09:49:41 *** promag has quit IRC
1292020-08-03T09:53:08 *** arowser_ has quit IRC
1302020-08-03T09:53:36 *** arowser_ has joined #bitcoin-core-dev
1312020-08-03T09:56:02 *** jonas_ has quit IRC
1322020-08-03T10:03:26 *** Annie78Runte has joined #bitcoin-core-dev
1332020-08-03T10:05:39 *** promag has joined #bitcoin-core-dev
1342020-08-03T10:08:56 *** Pavlenex has joined #bitcoin-core-dev
1352020-08-03T10:11:48 *** promag_ has joined #bitcoin-core-dev
1362020-08-03T10:13:25 *** arowser_ has quit IRC
1372020-08-03T10:15:05 *** promag has quit IRC
1382020-08-03T10:15:16 *** BGL has joined #bitcoin-core-dev
1392020-08-03T10:16:05 *** belcher_ has quit IRC
1402020-08-03T10:16:17 *** promag_ has quit IRC
1412020-08-03T10:16:47 *** promag has joined #bitcoin-core-dev
1422020-08-03T10:16:58 *** arowser_ has joined #bitcoin-core-dev
1432020-08-03T10:18:15 *** wullon5 has joined #bitcoin-core-dev
1442020-08-03T10:22:26 <jnewbery> wumpus MarcoFalke fanquake: I think #18991 may be ready for merge. It's had a ton of review and has three ACKs on the most recent branch (and a bunch more ACKs/concept ACKs on previous branches)
1452020-08-03T10:22:29 <gribble> https://github.com/bitcoin/bitcoin/issues/18991 | Cache responses to GETADDR to prevent topology leaks by naumenkogs · Pull Request #18991 · bitcoin/bitcoin · GitHub
1462020-08-03T10:24:41 *** Annie78Runte has quit IRC
1472020-08-03T10:27:36 *** Pavlenex has quit IRC
1482020-08-03T10:28:46 *** Highway61 has joined #bitcoin-core-dev
1492020-08-03T10:36:29 *** Highway61 has quit IRC
1502020-08-03T10:41:37 *** promag has quit IRC
1512020-08-03T10:42:09 *** arowser_ has quit IRC
1522020-08-03T10:42:32 *** arowser_ has joined #bitcoin-core-dev
1532020-08-03T10:43:09 *** arowser_ has quit IRC
1542020-08-03T10:43:38 *** arowser_ has joined #bitcoin-core-dev
1552020-08-03T10:52:26 *** Highway61 has joined #bitcoin-core-dev
1562020-08-03T10:55:08 *** harrigan has quit IRC
1572020-08-03T10:55:24 *** harrigan has joined #bitcoin-core-dev
1582020-08-03T10:55:41 *** vasild_ has joined #bitcoin-core-dev
1592020-08-03T10:58:43 *** vasild has quit IRC
1602020-08-03T10:58:45 *** vasild_ is now known as vasild
1612020-08-03T11:02:35 *** promag has joined #bitcoin-core-dev
1622020-08-03T11:06:41 *** andreacab has joined #bitcoin-core-dev
1632020-08-03T11:06:55 *** jonatack has quit IRC
1642020-08-03T11:07:10 *** promag has quit IRC
1652020-08-03T11:39:38 *** andreacab has quit IRC
1662020-08-03T11:40:05 *** andreacab has joined #bitcoin-core-dev
1672020-08-03T11:43:17 *** Mercury_Vapor has quit IRC
1682020-08-03T11:44:33 *** andreacab has quit IRC
1692020-08-03T11:47:05 *** IGHOR has quit IRC
1702020-08-03T11:47:23 *** bitcoin-git has joined #bitcoin-core-dev
1712020-08-03T11:47:23 <bitcoin-git> [bitcoin] S3RK opened pull request #19651: wallet: allow import same descriptor twice (master...importdescriptors_twice) https://github.com/bitcoin/bitcoin/pull/19651
1722020-08-03T11:47:24 *** bitcoin-git has left #bitcoin-core-dev
1732020-08-03T11:48:49 *** troygiorshev has quit IRC
1742020-08-03T11:49:32 *** Mercury_Vapor has joined #bitcoin-core-dev
1752020-08-03T11:49:33 *** troygiorshev has joined #bitcoin-core-dev
1762020-08-03T11:51:22 *** shesek has quit IRC
1772020-08-03T11:54:59 *** harrigan has quit IRC
1782020-08-03T11:56:02 *** harrigan has joined #bitcoin-core-dev
1792020-08-03T12:00:02 *** Gunni1 has quit IRC
1802020-08-03T12:02:16 *** proofofkeags has joined #bitcoin-core-dev
1812020-08-03T12:02:28 <wumpus> jnewbery: thanks will take a look
1822020-08-03T12:08:17 *** proofofkeags has quit IRC
1832020-08-03T12:08:53 *** proofofkeags has joined #bitcoin-core-dev
1842020-08-03T12:12:12 *** proofofkeags has quit IRC
1852020-08-03T12:20:43 *** jb55 has quit IRC
1862020-08-03T12:21:16 *** langseth1 has joined #bitcoin-core-dev
1872020-08-03T12:21:20 *** jb55 has joined #bitcoin-core-dev
1882020-08-03T12:24:18 *** Pavlenex has joined #bitcoin-core-dev
1892020-08-03T12:31:17 *** proofofkeags has joined #bitcoin-core-dev
1902020-08-03T12:44:46 *** shesek has joined #bitcoin-core-dev
1912020-08-03T12:44:46 *** shesek has joined #bitcoin-core-dev
1922020-08-03T12:50:04 *** bitcoin-git has joined #bitcoin-core-dev
1932020-08-03T12:50:05 <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a78742830aa3...14ceddd29085
1942020-08-03T12:50:05 <bitcoin-git> bitcoin/master ded742b Gleb Naumenko: Move filtering banned addrs inside GetAddresses()
1952020-08-03T12:50:06 <bitcoin-git> bitcoin/master 7cc0e81 Gleb Naumenko: Remove useless 2500 limit on AddrMan queries
1962020-08-03T12:50:06 <bitcoin-git> bitcoin/master acd6135 Gleb Naumenko: Cache responses to addr requests
1972020-08-03T12:50:09 *** bitcoin-git has left #bitcoin-core-dev
1982020-08-03T12:50:49 *** bitcoin-git has joined #bitcoin-core-dev
1992020-08-03T12:50:49 <bitcoin-git> [bitcoin] laanwj merged pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991
2002020-08-03T12:50:58 *** bitcoin-git has left #bitcoin-core-dev
2012020-08-03T12:57:17 *** arowser_ has quit IRC
2022020-08-03T12:57:41 *** arowser_ has joined #bitcoin-core-dev
2032020-08-03T13:03:57 *** Pavlenex has quit IRC
2042020-08-03T13:06:19 *** arowser_ has quit IRC
2052020-08-03T13:06:43 *** arowser_ has joined #bitcoin-core-dev
2062020-08-03T13:08:10 *** arowser_ has quit IRC
2072020-08-03T13:08:44 *** arowser_ has joined #bitcoin-core-dev
2082020-08-03T13:09:11 *** arowser_ has quit IRC
2092020-08-03T13:09:39 *** arowser_ has joined #bitcoin-core-dev
2102020-08-03T13:10:09 *** arowser_ has quit IRC
2112020-08-03T13:10:37 *** arowser_ has joined #bitcoin-core-dev
2122020-08-03T13:11:14 *** arowser_ has quit IRC
2132020-08-03T13:11:33 *** arowser_ has joined #bitcoin-core-dev
2142020-08-03T13:13:16 *** arowser_ has quit IRC
2152020-08-03T13:13:41 *** arowser_ has joined #bitcoin-core-dev
2162020-08-03T13:23:28 *** promag has joined #bitcoin-core-dev
2172020-08-03T13:24:04 *** LuisAranguren has quit IRC
2182020-08-03T13:26:24 *** bitcoin-git has joined #bitcoin-core-dev
2192020-08-03T13:26:24 <bitcoin-git> [bitcoin] hebasto opened pull request #19652: Add thread safety annotations to Mempool{Info}ToJSON() (master...200803-mmx-2) https://github.com/bitcoin/bitcoin/pull/19652
2202020-08-03T13:26:25 *** bitcoin-git has left #bitcoin-core-dev
2212020-08-03T13:45:45 *** mdunnio has joined #bitcoin-core-dev
2222020-08-03T13:45:53 *** proofofkeags has quit IRC
2232020-08-03T13:51:18 *** Davterra has quit IRC
2242020-08-03T13:52:16 *** arowser_ has quit IRC
2252020-08-03T13:52:36 *** arowser_ has joined #bitcoin-core-dev
2262020-08-03T13:53:09 *** Davterra has joined #bitcoin-core-dev
2272020-08-03T13:53:45 <hebasto> jeremyrubin: did you see recent #18710 update and its benchmarks by martinus?
2282020-08-03T13:53:48 <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
2292020-08-03T13:54:15 *** arowser_ has quit IRC
2302020-08-03T13:54:43 *** arowser_ has joined #bitcoin-core-dev
2312020-08-03T14:11:53 *** mdunnio has quit IRC
2322020-08-03T14:12:07 *** mdunnio has joined #bitcoin-core-dev
2332020-08-03T14:13:15 <aj> hebasto: why do you think adding GUARDED_BY is a design change? it's just those members existed before bitcoin source had thread safety annotations, as far as i know?
2342020-08-03T14:13:44 *** Tralfaz has joined #bitcoin-core-dev
2352020-08-03T14:14:10 <hebasto> aj: it changes class invariants
2362020-08-03T14:14:24 <aj> hebasto: no it doesn't? (or: i don't see how?)
2372020-08-03T14:14:48 *** Pavlenex has joined #bitcoin-core-dev
2382020-08-03T14:14:49 <aj> hebasto: (i'd say that it *documents* class invariants, just like the rest of your pr)
2392020-08-03T14:15:21 *** Davterra has quit IRC
2402020-08-03T14:16:09 <hebasto> aj: ok, if new GUARDED_BY will not cause to introduce new need to acquire a lock somewhere
2412020-08-03T14:16:28 <aj> hebasto: seemed to work fine for me, fwiw
2422020-08-03T14:17:08 <aj> hebasto: (if it did demand a lock was acquired somewhere, i'd expect that to be a bug worth fixing anyway)
2432020-08-03T14:17:09 *** proofofkeags has joined #bitcoin-core-dev
2442020-08-03T14:18:16 <hebasto> btw, `AssertLock{Not}Held` were my tools to transit `CTxMemPool::cs` to `RecursiveMutex` in #19306
2452020-08-03T14:18:18 <gribble> https://github.com/bitcoin/bitcoin/issues/19306 | refactor: Replace RecursiveMutex with Mutex in CTxMemPool by hebasto · Pull Request #19306 · bitcoin/bitcoin · GitHub
2462020-08-03T14:18:33 <aj> hebasto: yep
2472020-08-03T14:18:47 <hebasto> oops s/RecursiveMutex/Mutex/
2482020-08-03T14:19:01 <aj> s/to/from/ would've been shorter
2492020-08-03T14:19:11 * hebasto :)
2502020-08-03T14:21:50 *** proofofkeags has quit IRC
2512020-08-03T14:21:54 <hebasto> aj: sudden run-time error that were not caught by compile-time thread safety analysis could be (almost) eliminated with full annotation coverage
2522020-08-03T14:24:23 *** Tralfaz has quit IRC
2532020-08-03T14:25:21 <aj> hebasto: it crossed my mind that maybe DEBUG_LOCKORDER should check for accidental recursive locking attempts with Mutex (or even RecursiveMutex if it just logged a warning on first occurence or so?)
2542020-08-03T14:26:47 <aj> hebasto: hmm, "EX_LOCKS_REQ(!cs)" complaints are only warnings, not errors?
2552020-08-03T14:27:59 <hebasto> we could always pass -Werror, no?
2562020-08-03T14:28:20 <aj> hebasto: i thought we were?
2572020-08-03T14:29:05 <aj> no, apparently not? did i do configure wrong?
2582020-08-03T14:29:13 *** arowser_ has quit IRC
2592020-08-03T14:29:15 *** Davterra has joined #bitcoin-core-dev
2602020-08-03T14:29:36 *** Pavlenex has quit IRC
2612020-08-03T14:29:38 *** arowser_ has joined #bitcoin-core-dev
2622020-08-03T14:30:18 <aj> ah, missed --enable-werror i guess?
2632020-08-03T14:30:30 <hebasto> by default `--enable-werror=no`
2642020-08-03T14:31:16 <aj> yeah, there's already '-Werror=thread-safety' by default
2652020-08-03T14:32:15 <aj> or not?
2662020-08-03T14:33:13 <hebasto> you should add `--enable-werror`
2672020-08-03T14:33:15 *** rafalcpp has joined #bitcoin-core-dev
2682020-08-03T14:34:14 <aj> yeah, have done so. weird i haven't felt forced to before
2692020-08-03T14:37:49 *** Luke has joined #bitcoin-core-dev
2702020-08-03T14:39:25 <aj> hebasto: hmm, apart from a missing EXCLUSIVE_LOCKS_REQUIRED(!cs_wallet) in BlockUntilSyncedToCurrentChain(), it seems possible to annotate AssertLockNotHeldInternal with EXCLUSIVE_LOCKS_REQUIRED(!*cs) (have to templatize it to avoid "dereferencing" a void* too of course)
2712020-08-03T14:40:14 *** bitdex has quit IRC
2722020-08-03T14:41:11 <hebasto> aj: did you see #19337 ?
2732020-08-03T14:41:12 *** arowser_ has quit IRC
2742020-08-03T14:41:14 <gribble> https://github.com/bitcoin/bitcoin/issues/19337 | sync: detect double lock from the same thread by vasild · Pull Request #19337 · bitcoin/bitcoin · GitHub
2752020-08-03T14:41:40 *** arowser_ has joined #bitcoin-core-dev
2762020-08-03T14:47:25 <aj> hebasto: yay!
2772020-08-03T14:49:52 *** Davterra has quit IRC
2782020-08-03T14:51:18 *** proofofkeags has joined #bitcoin-core-dev
2792020-08-03T15:00:02 *** langseth1 has quit IRC
2802020-08-03T15:00:13 *** rafalcpp has quit IRC
2812020-08-03T15:17:41 *** Deinogalerix21 has joined #bitcoin-core-dev
2822020-08-03T15:19:47 *** Guyver2 has quit IRC
2832020-08-03T15:19:59 *** Guyver2 has joined #bitcoin-core-dev
2842020-08-03T15:20:48 *** Pavlenex has joined #bitcoin-core-dev
2852020-08-03T15:22:17 *** directhex1 has joined #bitcoin-core-dev
2862020-08-03T15:28:24 *** bitcoin-git has joined #bitcoin-core-dev
2872020-08-03T15:28:25 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/14ceddd29085...34eb2362581d
2882020-08-03T15:28:26 <bitcoin-git> bitcoin/master 131a2f0 Pieter Wuille: scripted-diff: rename base_blob::data to m_data
2892020-08-03T15:28:27 <bitcoin-git> bitcoin/master 5678250 Pieter Wuille: Make uint256 Span-convertible by adding ::data()
2902020-08-03T15:28:27 <bitcoin-git> bitcoin/master e63dcc3 Pieter Wuille: Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2912020-08-03T15:28:29 *** bitcoin-git has left #bitcoin-core-dev
2922020-08-03T15:28:49 *** bitcoin-git has joined #bitcoin-core-dev
2932020-08-03T15:28:49 <bitcoin-git> [bitcoin] laanwj merged pull request #19326: Simplify hash.h interface using Spans (master...202006_spanhashes) https://github.com/bitcoin/bitcoin/pull/19326
2942020-08-03T15:28:54 *** rafalcpp has joined #bitcoin-core-dev
2952020-08-03T15:28:58 *** bitcoin-git has left #bitcoin-core-dev
2962020-08-03T15:39:15 <hebasto> aj: to feel safe a "clone" of `AssertLockHeld()` needed but without `ASSERT_EXCLUSIVE_LOCK()`
2972020-08-03T15:39:28 <hebasto> how it could be named?
2982020-08-03T15:39:55 <aj> hebasto: RequireLockHeld or ExpectLockHeld maybe? *shrug*
2992020-08-03T15:41:05 <hebasto> `RequireLockHeld` looks good!
3002020-08-03T15:47:05 *** Pavlenex has quit IRC
3012020-08-03T15:57:13 *** Highway61 has quit IRC
3022020-08-03T15:59:15 *** promag_ has joined #bitcoin-core-dev
3032020-08-03T16:03:12 *** Highway61 has joined #bitcoin-core-dev
3042020-08-03T16:04:32 *** promag_ has quit IRC
3052020-08-03T16:08:12 *** arowser_ has quit IRC
3062020-08-03T16:08:40 *** arowser_ has joined #bitcoin-core-dev
3072020-08-03T16:19:25 *** jonatack has joined #bitcoin-core-dev
3082020-08-03T16:21:08 *** Luke has quit IRC
3092020-08-03T16:22:20 <warren> jonasschnelli: hey. Curious whatever happened to BIP150 and 151. Did that end up getting rolled into a replacement BIP?
3102020-08-03T16:23:40 <sipa> warren: BIP324 will replace BIP151
3112020-08-03T16:24:03 <warren> thanks
3122020-08-03T16:25:40 <warren> is any authentication scheme currently favored in conjunction with this?
3132020-08-03T16:26:07 <sipa> we have some theoretic work, a successor to countersign, but nothing published
3142020-08-03T16:26:47 *** jarthur has joined #bitcoin-core-dev
3152020-08-03T16:28:33 *** jarthur_ has quit IRC
3162020-08-03T16:30:17 *** Davterra has joined #bitcoin-core-dev
3172020-08-03T16:46:39 *** proofofkeags has quit IRC
3182020-08-03T16:49:05 *** alko89 has quit IRC
3192020-08-03T16:52:22 *** Pavlenex has joined #bitcoin-core-dev
3202020-08-03T17:01:12 *** arowser_ has quit IRC
3212020-08-03T17:01:34 *** arowser_ has joined #bitcoin-core-dev
3222020-08-03T17:06:21 *** justanotheruser has joined #bitcoin-core-dev
3232020-08-03T17:11:35 *** Davterra has quit IRC
3242020-08-03T17:22:35 *** pinheadmz has quit IRC
3252020-08-03T17:23:34 *** Highway61 has quit IRC
3262020-08-03T17:24:06 <jeremyrubin> Does the linter need to be kicked?
3272020-08-03T17:24:08 <jeremyrubin> https://travis-ci.org/github/bitcoin/bitcoin/jobs/714556846
3282020-08-03T17:25:35 <fjahr> jeremyrubin: seems so, I saw this yesterday: https://github.com/bitcoin/bitcoin/pull/19439#issuecomment-667732466
3292020-08-03T17:25:52 <fjahr> But it doesn't fail locally for me
3302020-08-03T17:27:05 *** hanhua has joined #bitcoin-core-dev
3312020-08-03T17:27:30 <fjahr> seems to be an error specific to the CI environment, but maybe someone else can reproduce it?
3322020-08-03T17:32:19 <jeremyrubin> that seemed to be the issue thanks
3332020-08-03T17:32:54 *** proofofkeags has joined #bitcoin-core-dev
3342020-08-03T17:38:09 *** arowser_ has quit IRC
3352020-08-03T17:38:37 *** arowser_ has joined #bitcoin-core-dev
3362020-08-03T17:45:33 *** Guyver2_ has joined #bitcoin-core-dev
3372020-08-03T17:48:13 *** Guyver2 has quit IRC
3382020-08-03T18:00:02 *** directhex1 has quit IRC
3392020-08-03T18:04:05 *** shesek has quit IRC
3402020-08-03T18:13:38 *** alko89 has joined #bitcoin-core-dev
3412020-08-03T18:16:28 *** pinheadmz has joined #bitcoin-core-dev
3422020-08-03T18:17:38 *** Talkless has quit IRC
3432020-08-03T18:21:58 *** stranger64 has joined #bitcoin-core-dev
3442020-08-03T18:25:02 *** Deacyde has joined #bitcoin-core-dev
3452020-08-03T18:34:18 *** owowo has joined #bitcoin-core-dev
3462020-08-03T18:40:44 *** Davterra has joined #bitcoin-core-dev
3472020-08-03T18:41:10 *** mdrollette has quit IRC
3482020-08-03T18:44:44 *** mdrollette has joined #bitcoin-core-dev
3492020-08-03T18:59:09 *** Pavlenex has quit IRC
3502020-08-03T19:12:47 *** troygiorshev has quit IRC
3512020-08-03T19:13:35 *** troygiorshev has joined #bitcoin-core-dev
3522020-08-03T19:16:06 *** alko89 has quit IRC
3532020-08-03T19:18:07 *** hanhua has quit IRC
3542020-08-03T19:18:47 *** alko89 has joined #bitcoin-core-dev
3552020-08-03T19:22:35 *** Davterra has quit IRC
3562020-08-03T19:23:56 *** Pavlenex has joined #bitcoin-core-dev
3572020-08-03T19:24:14 *** Davterra has joined #bitcoin-core-dev
3582020-08-03T19:32:05 *** mutatrum has joined #bitcoin-core-dev
3592020-08-03T19:33:32 *** Pavlenex has quit IRC
3602020-08-03T19:38:26 *** ovovo has joined #bitcoin-core-dev
3612020-08-03T19:40:39 *** Pavlenex has joined #bitcoin-core-dev
3622020-08-03T19:42:22 *** owowo has quit IRC
3632020-08-03T19:43:40 *** pinheadmz has quit IRC
3642020-08-03T19:47:31 *** pinheadmz has joined #bitcoin-core-dev
3652020-08-03T19:48:59 *** pinheadmz has quit IRC
3662020-08-03T20:03:03 *** jb55 has quit IRC
3672020-08-03T20:15:55 *** jb55 has joined #bitcoin-core-dev
3682020-08-03T20:19:40 *** bitcoin-git has joined #bitcoin-core-dev
3692020-08-03T20:19:40 <bitcoin-git> [bitcoin] achow101 opened pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
3702020-08-03T20:19:41 *** bitcoin-git has left #bitcoin-core-dev
3712020-08-03T20:26:54 *** pinheadmz has joined #bitcoin-core-dev
3722020-08-03T20:34:10 <luke-jr> achow101: please introduce and remove in separate PRs..
3732020-08-03T20:35:19 <achow101> luke-jr: it's moving one functionality to another place
3742020-08-03T20:35:24 <achow101> we did the same thing for upgradewallet
3752020-08-03T20:36:29 <luke-jr> pretty sure I said the same for that too
3762020-08-03T20:50:05 *** mutatrum has quit IRC
3772020-08-03T20:52:58 *** isis is now known as isis_
3782020-08-03T20:57:33 *** Guyver2_ has quit IRC
3792020-08-03T21:00:02 *** stranger64 has quit IRC
3802020-08-03T21:05:06 *** cfields has joined #bitcoin-core-dev
3812020-08-03T21:06:12 *** filchef has joined #bitcoin-core-dev
3822020-08-03T21:07:04 *** filchef has quit IRC
3832020-08-03T21:15:00 *** Joy has joined #bitcoin-core-dev
3842020-08-03T21:20:39 *** erwin_bullet has joined #bitcoin-core-dev
3852020-08-03T21:55:34 *** dviola has quit IRC
3862020-08-03T21:56:45 *** Joy has quit IRC
3872020-08-03T22:02:03 *** bitdex has joined #bitcoin-core-dev
3882020-08-03T22:03:59 *** proofofkeags has quit IRC
3892020-08-03T22:11:57 *** proofofkeags has joined #bitcoin-core-dev
3902020-08-03T22:25:05 *** Pavlenex has joined #bitcoin-core-dev
3912020-08-03T22:27:21 *** Pavlenex has quit IRC
3922020-08-03T22:31:24 *** proofofkeags has quit IRC
3932020-08-03T22:50:52 *** proofofkeags has joined #bitcoin-core-dev
3942020-08-03T22:55:38 *** vasild_ has joined #bitcoin-core-dev
3952020-08-03T22:55:57 *** proofofkeags has quit IRC
3962020-08-03T22:55:58 *** marcoagner has quit IRC
3972020-08-03T22:58:43 *** vasild has quit IRC
3982020-08-03T22:58:45 *** vasild_ is now known as vasild
3992020-08-03T23:11:58 *** Chris_Stewart_5 has quit IRC
4002020-08-03T23:27:52 *** proofofkeags has joined #bitcoin-core-dev
4012020-08-03T23:28:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4022020-08-03T23:31:09 *** kristapsk has joined #bitcoin-core-dev
4032020-08-03T23:33:17 *** proofofkeags has quit IRC
4042020-08-03T23:42:53 *** mdunnio has quit IRC
4052020-08-03T23:43:36 *** mdrollette has quit IRC
4062020-08-03T23:43:55 *** mdrollette has joined #bitcoin-core-dev
4072020-08-03T23:51:04 *** dviola has joined #bitcoin-core-dev