12020-08-06T00:00:02  *** jwheare1 has quit IRC
  22020-08-06T00:02:19  *** mrostecki has quit IRC
  32020-08-06T00:09:47  *** mdunnio has quit IRC
  42020-08-06T00:11:34  *** adaminsky has joined #bitcoin-core-dev
  52020-08-06T00:15:44  *** adaminsky has quit IRC
  62020-08-06T00:20:05  *** AaronvanW has quit IRC
  72020-08-06T00:22:07  *** slewis has joined #bitcoin-core-dev
  82020-08-06T00:28:26  *** mrostecki has joined #bitcoin-core-dev
  92020-08-06T00:41:41  *** jarthur_ has joined #bitcoin-core-dev
 102020-08-06T00:46:07  *** jarthur has quit IRC
 112020-08-06T00:57:05  *** gzhao408 has joined #bitcoin-core-dev
 122020-08-06T01:05:24  *** proofofkeags has quit IRC
 132020-08-06T01:23:03  *** Dean_Guss has joined #bitcoin-core-dev
 142020-08-06T01:23:06  *** DeanWeen has quit IRC
 152020-08-06T01:23:24  *** slewis has quit IRC
 162020-08-06T01:24:58  *** Davterra has joined #bitcoin-core-dev
 172020-08-06T01:27:03  *** Tralfaz has joined #bitcoin-core-dev
 182020-08-06T01:27:09  *** arowser_ has quit IRC
 192020-08-06T01:27:27  *** arowser_ has joined #bitcoin-core-dev
 202020-08-06T01:29:25  *** jarthur_ has quit IRC
 212020-08-06T01:29:38  *** Davterra has quit IRC
 222020-08-06T01:30:49  *** jarthur has joined #bitcoin-core-dev
 232020-08-06T01:31:40  *** AaronvanW has joined #bitcoin-core-dev
 242020-08-06T01:31:41  *** troygiorshev has quit IRC
 252020-08-06T01:32:45  *** troygiorshev has joined #bitcoin-core-dev
 262020-08-06T01:39:32  *** shesek has quit IRC
 272020-08-06T02:02:37  *** AaronvanW has quit IRC
 282020-08-06T02:02:47  *** watersnake1 has joined #bitcoin-core-dev
 292020-08-06T02:11:37  *** proofofkeags has joined #bitcoin-core-dev
 302020-08-06T02:15:19  *** bitcoin-git has joined #bitcoin-core-dev
 312020-08-06T02:15:19  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3272ff2907c...19f812c57b42
 322020-08-06T02:15:20  <bitcoin-git> bitcoin/master fa5288c MarcoFalke: contrib: Fixup valgrind suppressions file
 332020-08-06T02:15:20  <bitcoin-git> bitcoin/master 19f812c fanquake: Merge #19669: contrib: Fixup valgrind suppressions file
 342020-08-06T02:15:21  *** bitcoin-git has left #bitcoin-core-dev
 352020-08-06T02:15:39  *** bitcoin-git has joined #bitcoin-core-dev
 362020-08-06T02:15:39  <bitcoin-git> [bitcoin] fanquake merged pull request #19669: contrib: Fixup valgrind suppressions file (master...2008-valSupp) https://github.com/bitcoin/bitcoin/pull/19669
 372020-08-06T02:15:40  *** bitcoin-git has left #bitcoin-core-dev
 382020-08-06T02:16:22  *** proofofkeags has quit IRC
 392020-08-06T02:26:35  *** arowser_ has quit IRC
 402020-08-06T02:28:31  *** arowser_ has joined #bitcoin-core-dev
 412020-08-06T02:37:12  *** chipc has joined #bitcoin-core-dev
 422020-08-06T02:37:25  *** dviola has quit IRC
 432020-08-06T02:42:10  *** arowser_ has quit IRC
 442020-08-06T02:42:46  *** dviola has joined #bitcoin-core-dev
 452020-08-06T02:47:41  *** troygiorshev has quit IRC
 462020-08-06T02:48:33  *** dviola has quit IRC
 472020-08-06T02:48:37  *** arowser_ has joined #bitcoin-core-dev
 482020-08-06T02:58:06  *** luke-jr has quit IRC
 492020-08-06T02:58:26  *** luke-jr has joined #bitcoin-core-dev
 502020-08-06T03:00:01  *** chipc has quit IRC
 512020-08-06T03:08:08  *** arowser_ has quit IRC
 522020-08-06T03:08:28  *** arowser_ has joined #bitcoin-core-dev
 532020-08-06T03:15:49  *** Highway61 has quit IRC
 542020-08-06T03:21:26  *** AaronvanW has joined #bitcoin-core-dev
 552020-08-06T03:26:19  *** gzhao408 has quit IRC
 562020-08-06T03:31:23  *** proofofkeags has joined #bitcoin-core-dev
 572020-08-06T03:33:13  *** nanotube has quit IRC
 582020-08-06T03:45:49  *** nanotube has joined #bitcoin-core-dev
 592020-08-06T03:46:15  <kallewoof> Should btcdeb be moved into the bitcoin github repo?
 602020-08-06T03:54:35  *** AaronvanW has quit IRC
 612020-08-06T03:55:16  <luke-jr> kallewoof: we're trying to move things out, not in.. why? :p
 622020-08-06T03:56:23  *** Philantrop2 has joined #bitcoin-core-dev
 632020-08-06T04:01:12  <kallewoof> luke-jr: oh, okay. i thought there was talk about moving btcdeb into the bitcoin org at one point. feels like that might encourage contributors and would make it easier to provide binaries too
 642020-08-06T04:02:36  <luke-jr> kallewoof: maybe it would make sense to move it to the bitcoin-core org as a new repo, but we're also trying to keep stuff off the bitcoin org now IIRC
 652020-08-06T04:03:01  <kallewoof> okay
 662020-08-06T04:15:05  *** watersnake1 has quit IRC
 672020-08-06T04:15:13  *** proofofkeags has quit IRC
 682020-08-06T04:15:50  *** proofofkeags has joined #bitcoin-core-dev
 692020-08-06T04:20:05  *** proofofkeags has quit IRC
 702020-08-06T04:20:50  *** jarthur has quit IRC
 712020-08-06T04:21:19  *** jarthur has joined #bitcoin-core-dev
 722020-08-06T04:33:14  *** arowser_ has quit IRC
 732020-08-06T04:33:34  *** arowser_ has joined #bitcoin-core-dev
 742020-08-06T04:43:01  *** jules23 has joined #bitcoin-core-dev
 752020-08-06T04:47:31  *** bitcoin-git has joined #bitcoin-core-dev
 762020-08-06T04:47:31  <bitcoin-git> [bitcoin] Crypt-iQ opened pull request #19672: build: make clean removes .gcda and .gcno files from fuzz directory (master...fuzz_cov_cleanup_0806) https://github.com/bitcoin/bitcoin/pull/19672
 772020-08-06T04:47:32  *** bitcoin-git has left #bitcoin-core-dev
 782020-08-06T04:48:10  *** arowser_ has quit IRC
 792020-08-06T04:48:29  *** arowser_ has joined #bitcoin-core-dev
 802020-08-06T04:52:45  *** jules23 has quit IRC
 812020-08-06T04:54:03  *** sdaftuar has quit IRC
 822020-08-06T04:56:16  *** sdaftuar has joined #bitcoin-core-dev
 832020-08-06T04:57:07  *** arowser_ has quit IRC
 842020-08-06T04:57:29  *** arowser_ has joined #bitcoin-core-dev
 852020-08-06T04:57:51  *** sipsorcery has quit IRC
 862020-08-06T05:24:14  *** arowser_ has quit IRC
 872020-08-06T05:24:39  *** arowser_ has joined #bitcoin-core-dev
 882020-08-06T05:43:07  *** sipsorcery has joined #bitcoin-core-dev
 892020-08-06T05:52:16  *** AaronvanW has joined #bitcoin-core-dev
 902020-08-06T05:52:44  *** shesek has joined #bitcoin-core-dev
 912020-08-06T05:52:44  *** shesek has joined #bitcoin-core-dev
 922020-08-06T05:59:13  *** arowser_ has quit IRC
 932020-08-06T05:59:33  *** arowser_ has joined #bitcoin-core-dev
 942020-08-06T06:00:02  *** Philantrop2 has quit IRC
 952020-08-06T06:17:27  *** jonatack has quit IRC
 962020-08-06T06:18:17  *** mdunnio has joined #bitcoin-core-dev
 972020-08-06T06:21:34  *** wgolden has joined #bitcoin-core-dev
 982020-08-06T06:24:46  *** mdunnio has quit IRC
 992020-08-06T06:24:49  *** AaronvanW has quit IRC
1002020-08-06T06:25:11  *** arowser_ has quit IRC
1012020-08-06T06:30:14  *** Guyver2 has joined #bitcoin-core-dev
1022020-08-06T06:32:05  *** arowser_ has joined #bitcoin-core-dev
1032020-08-06T06:38:48  *** arowser_ has quit IRC
1042020-08-06T06:39:10  *** arowser_ has joined #bitcoin-core-dev
1052020-08-06T07:04:33  *** marcoagner has joined #bitcoin-core-dev
1062020-08-06T07:18:10  *** arowser_ has quit IRC
1072020-08-06T07:19:06  *** Livestradamus has quit IRC
1082020-08-06T07:19:26  *** Livestradamus has joined #bitcoin-core-dev
1092020-08-06T07:31:50  <jeremyrubin> Question Of The Day: empty scriptpubkeys are valid but not standard, correct? Is an empty p2sh script also valid? Can I satisfy it with OP_1 {}?
1102020-08-06T07:32:58  <sipa> yes, yes (as far as i remember)
1112020-08-06T07:33:16  <jeremyrubin> This is also true in segwit v0 and v1?
1122020-08-06T07:34:40  <sipa> i believe so
1132020-08-06T07:34:47  <jeremyrubin> TIL
1142020-08-06T07:35:09  <sipa> did you know that a zero-of-zero checkmultisig is valid?
1152020-08-06T07:35:57  <jeremyrubin> that I think I did know, and makes more sense?
1162020-08-06T07:36:09  <jeremyrubin> what about a 0 of 2 multisig?
1172020-08-06T07:40:50  *** davec has quit IRC
1182020-08-06T07:40:54  *** arowser_ has joined #bitcoin-core-dev
1192020-08-06T07:50:56  *** wgolden has quit IRC
1202020-08-06T07:51:17  *** davec has joined #bitcoin-core-dev
1212020-08-06T08:02:41  *** Dantman has joined #bitcoin-core-dev
1222020-08-06T08:04:22  *** jonatack has joined #bitcoin-core-dev
1232020-08-06T08:10:28  *** andreacab has joined #bitcoin-core-dev
1242020-08-06T08:12:10  *** arowser_ has quit IRC
1252020-08-06T08:15:05  *** andreacab has quit IRC
1262020-08-06T08:15:59  *** AaronvanW has joined #bitcoin-core-dev
1272020-08-06T08:19:04  *** arowser_ has joined #bitcoin-core-dev
1282020-08-06T08:28:58  *** BGL has quit IRC
1292020-08-06T08:29:25  *** davec has quit IRC
1302020-08-06T08:29:59  *** andreacab has joined #bitcoin-core-dev
1312020-08-06T08:35:46  *** andreacab has quit IRC
1322020-08-06T08:36:04  *** andreacab has joined #bitcoin-core-dev
1332020-08-06T08:39:13  *** justanotheruser has quit IRC
1342020-08-06T08:42:21  *** andreacab has quit IRC
1352020-08-06T08:42:48  *** andreacab has joined #bitcoin-core-dev
1362020-08-06T08:47:20  *** andreacab has quit IRC
1372020-08-06T08:47:27  *** andreacab has joined #bitcoin-core-dev
1382020-08-06T08:47:29  *** davec has joined #bitcoin-core-dev
1392020-08-06T09:00:02  *** Dantman has quit IRC
1402020-08-06T09:00:32  *** andreacab has quit IRC
1412020-08-06T09:03:47  *** andreacab has joined #bitcoin-core-dev
1422020-08-06T09:10:09  *** arowser_ has quit IRC
1432020-08-06T09:10:24  *** andreacab has quit IRC
1442020-08-06T09:10:55  *** arowser_ has joined #bitcoin-core-dev
1452020-08-06T09:17:07  *** jeremyrubin has quit IRC
1462020-08-06T09:19:05  *** AaronvanW has quit IRC
1472020-08-06T09:20:21  *** jemarch1 has joined #bitcoin-core-dev
1482020-08-06T09:24:23  *** jarthur has quit IRC
1492020-08-06T09:26:11  *** jarthur has joined #bitcoin-core-dev
1502020-08-06T09:32:42  *** dr-orlovsky has joined #bitcoin-core-dev
1512020-08-06T09:43:58  *** dr-orlovsky has quit IRC
1522020-08-06T09:44:19  *** BGL has joined #bitcoin-core-dev
1532020-08-06T09:44:23  *** AaronvanW has joined #bitcoin-core-dev
1542020-08-06T09:48:12  *** arowser_ has quit IRC
1552020-08-06T09:49:01  *** arowser_ has joined #bitcoin-core-dev
1562020-08-06T10:02:01  *** dr-orlovsky has joined #bitcoin-core-dev
1572020-08-06T10:03:23  *** Herminia38Simoni has joined #bitcoin-core-dev
1582020-08-06T10:11:50  *** Tennis has joined #bitcoin-core-dev
1592020-08-06T10:30:20  *** davec has quit IRC
1602020-08-06T10:30:36  *** davec has joined #bitcoin-core-dev
1612020-08-06T10:42:58  *** Guyver2_ has joined #bitcoin-core-dev
1622020-08-06T10:45:32  *** Guyver2 has quit IRC
1632020-08-06T10:45:39  *** Highway61 has joined #bitcoin-core-dev
1642020-08-06T10:55:06  *** Pavlenex has joined #bitcoin-core-dev
1652020-08-06T10:59:03  *** vasild has quit IRC
1662020-08-06T11:05:29  *** vasild has joined #bitcoin-core-dev
1672020-08-06T11:16:27  *** arowser_ has quit IRC
1682020-08-06T11:23:24  *** arowser_ has joined #bitcoin-core-dev
1692020-08-06T11:27:27  *** dr_orlovsky has joined #bitcoin-core-dev
1702020-08-06T11:29:04  *** dr-orlovsky has quit IRC
1712020-08-06T11:29:49  *** bitcoin-git has joined #bitcoin-core-dev
1722020-08-06T11:29:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/19f812c57b42...82127d27c900
1732020-08-06T11:29:50  <bitcoin-git> bitcoin/master 70452a0 fanquake: build: set minimum required Boost to 1.58
1742020-08-06T11:29:51  <bitcoin-git> bitcoin/master 82127d2 fanquake: Merge #19667: build: set minimum required Boost to 1.58.0
1752020-08-06T11:29:53  *** bitcoin-git has left #bitcoin-core-dev
1762020-08-06T11:30:04  *** arowser_ has quit IRC
1772020-08-06T11:30:09  *** bitcoin-git has joined #bitcoin-core-dev
1782020-08-06T11:30:09  <bitcoin-git> [bitcoin] fanquake merged pull request #19667: build: set minimum required Boost to 1.58.0 (master...boost_1_58_0) https://github.com/bitcoin/bitcoin/pull/19667
1792020-08-06T11:30:10  *** bitcoin-git has left #bitcoin-core-dev
1802020-08-06T11:36:08  *** Herminia38Simoni has quit IRC
1812020-08-06T11:37:49  *** arowser_ has joined #bitcoin-core-dev
1822020-08-06T11:41:09  <wumpus> kallewoof: sgtm to move it to bitcoin-core org, but not to bitcoin (that's really only for legacy repos)
1832020-08-06T11:50:09  *** Highway61 has quit IRC
1842020-08-06T11:57:49  *** BGL has quit IRC
1852020-08-06T11:58:31  *** Highway61 has joined #bitcoin-core-dev
1862020-08-06T12:00:02  *** jemarch1 has quit IRC
1872020-08-06T12:03:43  *** Victor_sueca has joined #bitcoin-core-dev
1882020-08-06T12:04:09  *** Victorsueca has quit IRC
1892020-08-06T12:08:37  *** arowser_ has quit IRC
1902020-08-06T12:09:11  *** arowser_ has joined #bitcoin-core-dev
1912020-08-06T12:14:26  *** belcher_ has joined #bitcoin-core-dev
1922020-08-06T12:17:47  *** belcher has quit IRC
1932020-08-06T12:20:39  *** atiti has joined #bitcoin-core-dev
1942020-08-06T12:32:38  *** arowser_ has quit IRC
1952020-08-06T12:33:37  *** arowser_ has joined #bitcoin-core-dev
1962020-08-06T12:37:03  *** cato_ has quit IRC
1972020-08-06T12:39:59  *** cato_ has joined #bitcoin-core-dev
1982020-08-06T12:42:57  *** Guyver2_ has quit IRC
1992020-08-06T12:44:03  *** troygiorshev has joined #bitcoin-core-dev
2002020-08-06T12:44:10  *** jarthur has quit IRC
2012020-08-06T12:48:52  *** dviola has joined #bitcoin-core-dev
2022020-08-06T12:51:33  *** jarthur has joined #bitcoin-core-dev
2032020-08-06T12:58:14  *** arowser_ has quit IRC
2042020-08-06T13:04:15  *** gzhao408 has joined #bitcoin-core-dev
2052020-08-06T13:05:10  *** arowser_ has joined #bitcoin-core-dev
2062020-08-06T13:06:11  *** arowser_ has quit IRC
2072020-08-06T13:06:36  *** arowser_ has joined #bitcoin-core-dev
2082020-08-06T13:09:13  *** arowser_ has quit IRC
2092020-08-06T13:09:37  *** arowser_ has joined #bitcoin-core-dev
2102020-08-06T13:10:13  *** arowser_ has quit IRC
2112020-08-06T13:10:32  *** arowser_ has joined #bitcoin-core-dev
2122020-08-06T13:11:11  *** arowser_ has quit IRC
2132020-08-06T13:11:37  *** arowser_ has joined #bitcoin-core-dev
2142020-08-06T13:12:00  *** Tralfaz is now known as davterra
2152020-08-06T13:12:13  *** arowser_ has quit IRC
2162020-08-06T13:12:38  *** arowser_ has joined #bitcoin-core-dev
2172020-08-06T13:13:12  *** arowser_ has quit IRC
2182020-08-06T13:13:30  *** arowser_ has joined #bitcoin-core-dev
2192020-08-06T13:14:11  *** arowser_ has quit IRC
2202020-08-06T13:14:30  *** arowser_ has joined #bitcoin-core-dev
2212020-08-06T13:19:07  *** gzhao408 has quit IRC
2222020-08-06T13:20:10  *** arowser_ has quit IRC
2232020-08-06T13:20:25  *** davec has quit IRC
2242020-08-06T13:20:39  *** arowser_ has joined #bitcoin-core-dev
2252020-08-06T13:28:37  *** gzhao408 has joined #bitcoin-core-dev
2262020-08-06T13:30:47  *** BGL has joined #bitcoin-core-dev
2272020-08-06T13:32:18  *** dr_orlovsky has quit IRC
2282020-08-06T13:33:43  *** mdunnio has joined #bitcoin-core-dev
2292020-08-06T13:34:32  *** dr-orlovsky has joined #bitcoin-core-dev
2302020-08-06T13:42:12  *** arowser_ has quit IRC
2312020-08-06T13:42:36  *** arowser_ has joined #bitcoin-core-dev
2322020-08-06T13:44:23  *** bitdex has quit IRC
2332020-08-06T14:05:38  *** MarcoFalke has quit IRC
2342020-08-06T14:06:56  *** MarcoFalke has joined #bitcoin-core-dev
2352020-08-06T14:14:50  *** fox2p_ has joined #bitcoin-core-dev
2362020-08-06T14:15:46  *** fox2p has quit IRC
2372020-08-06T14:17:47  *** davec has joined #bitcoin-core-dev
2382020-08-06T14:20:25  *** Chris_Stewart_5 has quit IRC
2392020-08-06T14:28:48  *** dr-orlovsky has quit IRC
2402020-08-06T14:29:05  *** vincenzopalazzo has joined #bitcoin-core-dev
2412020-08-06T14:32:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2422020-08-06T14:32:57  *** joerodgers has joined #bitcoin-core-dev
2432020-08-06T14:33:12  *** arowser_ has quit IRC
2442020-08-06T14:33:40  *** arowser_ has joined #bitcoin-core-dev
2452020-08-06T14:35:07  *** dr-orlovsky has joined #bitcoin-core-dev
2462020-08-06T14:37:09  *** troygiorshev has quit IRC
2472020-08-06T14:37:40  *** troygiorshev has joined #bitcoin-core-dev
2482020-08-06T14:39:15  *** sdaftuar has quit IRC
2492020-08-06T14:39:39  *** sdaftuar has joined #bitcoin-core-dev
2502020-08-06T14:44:04  *** Zenton has quit IRC
2512020-08-06T14:44:24  *** Zenton has joined #bitcoin-core-dev
2522020-08-06T14:48:48  *** EagleTM has joined #bitcoin-core-dev
2532020-08-06T14:49:31  *** justanotheruser has joined #bitcoin-core-dev
2542020-08-06T14:50:08  *** EagleTM has joined #bitcoin-core-dev
2552020-08-06T14:53:48  *** gzhao408 has quit IRC
2562020-08-06T14:54:05  *** Pavlenex has joined #bitcoin-core-dev
2572020-08-06T14:55:09  *** EagleTM has quit IRC
2582020-08-06T15:00:02  *** atiti has quit IRC
2592020-08-06T15:04:20  *** proofofkeags has joined #bitcoin-core-dev
2602020-08-06T15:14:03  *** Chris_Stewart_5 has quit IRC
2612020-08-06T15:19:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2622020-08-06T15:20:11  *** afk11 has quit IRC
2632020-08-06T15:21:17  *** joeykrim1 has joined #bitcoin-core-dev
2642020-08-06T15:25:08  *** Guyver2 has joined #bitcoin-core-dev
2652020-08-06T15:26:15  *** mekster has joined #bitcoin-core-dev
2662020-08-06T15:29:56  *** frogar has quit IRC
2672020-08-06T15:33:43  *** Talkless has joined #bitcoin-core-dev
2682020-08-06T15:36:15  *** arowser_ has quit IRC
2692020-08-06T15:36:35  *** arowser_ has joined #bitcoin-core-dev
2702020-08-06T15:38:45  *** frogar has joined #bitcoin-core-dev
2712020-08-06T15:39:14  *** alko has joined #bitcoin-core-dev
2722020-08-06T15:55:38  *** el_yapoo has joined #bitcoin-core-dev
2732020-08-06T15:56:05  *** el_yapooo has joined #bitcoin-core-dev
2742020-08-06T15:56:29  *** el_yapooo has quit IRC
2752020-08-06T15:56:41  *** el_yapoo has quit IRC
2762020-08-06T16:00:36  *** bitcoin-git has joined #bitcoin-core-dev
2772020-08-06T16:00:36  <bitcoin-git> [bitcoin] troygiorshev opened pull request #19673: Move cs_vSend into SocketSendData and resolve RecordBytesSent lock inconsistency (master...2020-08-socketsenddata) https://github.com/bitcoin/bitcoin/pull/19673
2782020-08-06T16:00:37  *** bitcoin-git has left #bitcoin-core-dev
2792020-08-06T16:06:41  *** pinheadmz has quit IRC
2802020-08-06T16:08:12  *** Pavlenex has quit IRC
2812020-08-06T16:11:56  *** roconnor has quit IRC
2822020-08-06T16:13:57  *** justanotheruser has quit IRC
2832020-08-06T16:18:50  *** tripleslash has quit IRC
2842020-08-06T16:20:50  *** gzhao408 has joined #bitcoin-core-dev
2852020-08-06T16:21:43  *** joerodgers has quit IRC
2862020-08-06T16:25:25  *** tripleslash has joined #bitcoin-core-dev
2872020-08-06T16:28:10  *** arowser_ has quit IRC
2882020-08-06T16:31:51  *** arowser_ has joined #bitcoin-core-dev
2892020-08-06T16:43:38  *** Pavlenex has joined #bitcoin-core-dev
2902020-08-06T16:47:44  <sdaftuar> MarcoFalke: around? wondering if you have any advice on the CI failures in #19620
2912020-08-06T16:47:46  <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
2922020-08-06T16:48:29  <sdaftuar> aside from the CI failures, i think that PR is ready
2932020-08-06T16:48:45  <sdaftuar> (ie i don't think the ci failures are my fault! :) )
2942020-08-06T16:58:18  *** dr-orlovsky has quit IRC
2952020-08-06T17:13:33  *** Pavlenex has quit IRC
2962020-08-06T17:14:47  *** dr-orlovsky has joined #bitcoin-core-dev
2972020-08-06T17:15:27  *** gzhao408 has quit IRC
2982020-08-06T17:16:02  *** gzhao408 has joined #bitcoin-core-dev
2992020-08-06T17:22:05  *** jb55 has quit IRC
3002020-08-06T17:22:34  *** justanotheruser has joined #bitcoin-core-dev
3012020-08-06T17:25:10  *** bitcoin-git has joined #bitcoin-core-dev
3022020-08-06T17:25:10  <bitcoin-git> [bitcoin] theStack opened pull request #19674: refactor: test: use throwaway _ variable for unused loop counters (master...20200804-refactor-test-use-underscore-variable) https://github.com/bitcoin/bitcoin/pull/19674
3032020-08-06T17:25:12  *** bitcoin-git has left #bitcoin-core-dev
3042020-08-06T17:27:17  *** dr-orlovsky has quit IRC
3052020-08-06T17:33:52  *** fox2p_ has quit IRC
3062020-08-06T17:58:42  *** pinheadmz has joined #bitcoin-core-dev
3072020-08-06T17:59:55  *** Asbestos_Vapor has quit IRC
3082020-08-06T18:00:02  *** joeykrim1 has quit IRC
3092020-08-06T18:02:27  *** pinheadmz has quit IRC
3102020-08-06T18:03:05  *** dr-orlovsky has joined #bitcoin-core-dev
3112020-08-06T18:07:38  *** pinheadmz has joined #bitcoin-core-dev
3122020-08-06T18:10:35  *** fox2p has joined #bitcoin-core-dev
3132020-08-06T18:10:50  *** gzhao408 has quit IRC
3142020-08-06T18:15:54  *** lightlike has joined #bitcoin-core-dev
3152020-08-06T18:22:10  *** Suntop1 has joined #bitcoin-core-dev
3162020-08-06T18:24:02  *** jb55 has joined #bitcoin-core-dev
3172020-08-06T18:24:14  *** gzhao408 has joined #bitcoin-core-dev
3182020-08-06T18:37:31  *** dr-orlovsky has quit IRC
3192020-08-06T18:41:16  *** proofofkeags has quit IRC
3202020-08-06T18:41:42  *** proofofkeags has joined #bitcoin-core-dev
3212020-08-06T18:48:07  *** arowser_ has quit IRC
3222020-08-06T18:48:32  *** arowser_ has joined #bitcoin-core-dev
3232020-08-06T18:50:07  *** arowser_ has quit IRC
3242020-08-06T18:50:35  *** arowser_ has joined #bitcoin-core-dev
3252020-08-06T18:56:37  *** dr-orlovsky has joined #bitcoin-core-dev
3262020-08-06T18:58:07  *** arowser_ has quit IRC
3272020-08-06T18:58:27  *** arowser_ has joined #bitcoin-core-dev
3282020-08-06T19:01:03  <dongcarl> Did meeting time change?
3292020-08-06T19:01:05  <wumpus> #startmeeting
3302020-08-06T19:01:05  <lightningbot> Meeting started Thu Aug  6 19:01:05 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3312020-08-06T19:01:05  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3322020-08-06T19:01:16  <wumpus> I don't think so!
3332020-08-06T19:01:22  <kanzure> hi
3342020-08-06T19:01:24  <hebasto> hi
3352020-08-06T19:01:25  <sipsorcery> hi
3362020-08-06T19:01:26  <pinheadmz> hi
3372020-08-06T19:01:30  <meshcollider> hi
3382020-08-06T19:01:32  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
3392020-08-06T19:01:33  <dongcarl> :)
3402020-08-06T19:01:34  <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
3412020-08-06T19:01:35  <achow101> hi
3422020-08-06T19:01:43  <jb55> hi
3432020-08-06T19:01:48  *** jeremyrubin has joined #bitcoin-core-dev
3442020-08-06T19:01:57  <sipa> dongcarl: the meeting timestamp increases by around 604800 seconds per meeting
3452020-08-06T19:02:04  <wumpus> two pre-proposed meeting topics for today
3462020-08-06T19:02:08  <ariard> hi
3472020-08-06T19:02:09  <jeremyrubin> hi
3482020-08-06T19:02:09  <wumpus> (marcofalke) add #19629 to high prio, discuss whether to remove the pulls that need rebase from high prio. (MarcoFalke, but won't be around)
3492020-08-06T19:02:11  <gribble> https://github.com/bitcoin/bitcoin/issues/19629 | Pass mempool pointer to chainstate constructor by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
3502020-08-06T19:02:25  <wumpus> (achow101) what to do about zapwallettxes
3512020-08-06T19:02:35  <dongcarl> sipa: rings true!
3522020-08-06T19:02:52  <wumpus> the first is mergeable with the normal high prio for review topic
3532020-08-06T19:03:01  <ariard> dongcarl: don't trust NTP
3542020-08-06T19:03:54  <wumpus> any other topics?
3552020-08-06T19:04:00  <wumpus> sipa: yup, exactly
3562020-08-06T19:04:39  <wumpus> meetings are scheulded 0.6048 megaseconds apart
3572020-08-06T19:04:53  <wumpus> #topic High priority for review
3582020-08-06T19:05:31  <wumpus> MarcoFalke's PR was already added
3592020-08-06T19:05:36  <jnewbery> hi
3602020-08-06T19:05:45  <wumpus> 10 blockers 1 bugfix 3 chasing concept ACK
3612020-08-06T19:05:56  <wumpus> https://github.com/bitcoin/bitcoin/projects/8
3622020-08-06T19:06:26  <wumpus> anything to add / remove, or that is ready for merge?
3632020-08-06T19:06:56  <wumpus> Marco suggested removing PRs that have needed rebase for a while
3642020-08-06T19:07:05  <sdaftuar> oh, hi
3652020-08-06T19:07:41  <wumpus> I think this is mostly #18242
3662020-08-06T19:07:43  <jnewbery> I count three that need rebase: #18242 #19055 #11082
3672020-08-06T19:07:47  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
3682020-08-06T19:07:47  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
3692020-08-06T19:07:50  <gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
3702020-08-06T19:07:51  <wumpus> jnewbery: oh!
3712020-08-06T19:07:52  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
3722020-08-06T19:08:21  <jnewbery> (just going by the tags)
3732020-08-06T19:08:36  <sdaftuar> #19620 is not high priority, but i would like it to be (though really it's ready for merge, i think)
3742020-08-06T19:08:38  <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
3752020-08-06T19:08:46  <sdaftuar> because once it's merged i'll be backporting
3762020-08-06T19:08:56  <wumpus> sdaftuar: will add
3772020-08-06T19:09:01  <sdaftuar> thank you!
3782020-08-06T19:09:35  <jnewbery> wumpus: just merge it. It has 5 ACKs :)
3792020-08-06T19:09:55  <wumpus> jnewbery: ok, after the meeting :)
3802020-08-06T19:10:27  <hebasto> is #11082 compatible with merged #15935 ?
3812020-08-06T19:10:28  <wumpus> jonasschnelli fjahr luke-jr anyone of you here?
3822020-08-06T19:10:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
3832020-08-06T19:10:33  <gribble> https://github.com/bitcoin/bitcoin/issues/15935 | Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
3842020-08-06T19:10:49  <achow101> hebasto: yes, they are compatible
3852020-08-06T19:11:14  <sipa> is there still a point?
3862020-08-06T19:11:17  <wumpus> please rebase your PR this week
3872020-08-06T19:12:04  <sipa> ah, i guess bitcoin_rw is for changing config options through UI etc, while settings.json is for other things like bans?
3882020-08-06T19:12:24  <wumpus> I'm not exactly sure what is the difference either
3892020-08-06T19:12:43  <wumpus> I guess one is for persisting the other is for changing it through RPC?
3902020-08-06T19:12:53  <hebasto> I thought they were two alternatives
3912020-08-06T19:12:53  <jnewbery> I think settings.json can be used for changing config options through GUI or RPC. The idea is to keep dynamic config in sync between bitcoind and bitcoin-qt
3922020-08-06T19:12:58  <achow101> my understanding was that bitcoin_rw was to let users also change the options
3932020-08-06T19:13:07  <achow101> and settings.json is only for bitcoind/bitcoin-qt
3942020-08-06T19:13:35  <achow101> I always viewed it as bitcoin_rw.conf was to supersede bitcoin.conf
3952020-08-06T19:13:36  <sipa> ah yes _rw would be accessible by bitcoin-cli etc as well
3962020-08-06T19:13:44  <fjahr> wumpus: will do, just wanted to answer your question as well at the same time
3972020-08-06T19:13:48  <wumpus> this doesn't add two separate settings mechanisms I hope?
3982020-08-06T19:13:49  <jnewbery> achow101: I don't think it makes sense to have yet another config source. How many do we have now?
3992020-08-06T19:14:00  <wumpus> jnewbery: hehe right
4002020-08-06T19:14:08  <achow101> jnewbery: 3. bitcoin.conf, settings.json, and QSettings
4012020-08-06T19:14:09  *** Talkless has quit IRC
4022020-08-06T19:14:11  <wumpus> bitcoin-qt is a maze of different config sources already
4032020-08-06T19:14:24  <achow101> settings.json and QSettings are supposed to be combined I think
4042020-08-06T19:14:27  <achow101> but not yet
4052020-08-06T19:14:28  <wumpus> it's really subtle in which order they need to be interpreted to not break any existing things
4062020-08-06T19:14:29  <sipa> and command line
4072020-08-06T19:14:41  <jnewbery> and command line, and overrides in the source
4082020-08-06T19:15:02  <wumpus> right
4092020-08-06T19:15:13  <sipa> well i think we need ryanofsky and luke-jr to discuss this properly
4102020-08-06T19:15:14  *** el_yapoo has joined #bitcoin-core-dev
4112020-08-06T19:15:20  *** el_yapooo has joined #bitcoin-core-dev
4122020-08-06T19:15:22  <jnewbery> After settings.json, QSettings should only be used for QT GUI configuration (eg window size/location)
4132020-08-06T19:15:28  * jeremyrubin maybe a setting to let you pick which settings you are using
4142020-08-06T19:15:29  <wumpus> I understand the long-term goal is to drop qsettings for everything but the datadir path
4152020-08-06T19:15:40  <wumpus> oh and that
4162020-08-06T19:16:00  <wumpus> but that doesn't overlap with bitcoin.conf so isn't an issue :)
4172020-08-06T19:16:06  <achow101> wumpus: I think datadir path would want to be in settings.json
4182020-08-06T19:16:17  <wumpus> achow101: that creates a chicken egg problem !
4192020-08-06T19:16:22  <sipa> we should go back to storing settings in wallet.dat
4202020-08-06T19:16:33  * sipa hides
4212020-08-06T19:16:41  <sdaftuar> sipa: i was going to add an environment variable for enabling such behavior
4222020-08-06T19:16:55  <wumpus> e.g. on windows, QSettings is in the registry, on linux it's in the standard ~/.config path, it's the only root-of-settings really
4232020-08-06T19:16:57  <achow101> wumpus: i suppose it does, but it unifies qt and bitcoind datadir paths
4242020-08-06T19:17:26  <wumpus> I won't pretent to understand it anymore, sorry
4252020-08-06T19:17:28  <achow101> well conf always overrides qt anyways
4262020-08-06T19:17:32  <achow101> I think
4272020-08-06T19:17:54  <sdaftuar> perhaps a good first contributor project would be to document this somewhere, eg on our wiki
4282020-08-06T19:18:03  <wumpus> heh, yes
4292020-08-06T19:18:13  <achow101> i'm not sure a first contributor would be able to figure out this mess
4302020-08-06T19:18:25  <sdaftuar> achow101: fair point!
4312020-08-06T19:18:25  <wumpus> I'm terrified by that code in bitcoin-qt
4322020-08-06T19:18:34  <wumpus> took me a lot of work to get it exactly right so be careful
4332020-08-06T19:18:52  <wumpus> we don't have any tests for it because that's hard for GUI stuff
4342020-08-06T19:19:56  <wumpus> and yes, conf overrides qt except the initial datadir
4352020-08-06T19:20:02  <sipa> another reason to aim to move things out of qsettings
4362020-08-06T19:20:14  <sipa> as it unifies testing across bitcoind and bitcoin-qtr
4372020-08-06T19:20:19  <wumpus> yes
4382020-08-06T19:21:19  <wumpus> but on inital use of the GUI, it asks you to select a data directory, it needs to store this somewhere that is not in the data drectory
4392020-08-06T19:21:32  <sipa> indeed
4402020-08-06T19:21:43  <wumpus> I'm okay with this being somewhere else than QSettings but I'm not sure where :)
4412020-08-06T19:22:34  <wumpus> #topic what to do about zapwallettxes (achow101)
4422020-08-06T19:22:41  <sipa> zap it
4432020-08-06T19:22:52  <jeremyrubin> PR #?
4442020-08-06T19:22:53  <wumpus> #19671
4452020-08-06T19:22:55  <gribble> https://github.com/bitcoin/bitcoin/issues/19671 | wallet: Remove -zapwallettxes by achow101 · Pull Request #19671 · bitcoin/bitcoin · GitHub
4462020-08-06T19:22:57  <achow101> I think it's obvious that the -zapwallettxes startup option needs to go
4472020-08-06T19:22:59  *** filchef has joined #bitcoin-core-dev
4482020-08-06T19:23:08  <wumpus> sipa: +1
4492020-08-06T19:23:09  <achow101> but there's a question of where to put it
4502020-08-06T19:23:18  <achow101> options are wallet tool, rpc, or ditch it entirely
4512020-08-06T19:23:19  <sipa> wallet tool
4522020-08-06T19:23:20  <sipa> ?
4532020-08-06T19:23:23  <wumpus> also #19653
4542020-08-06T19:23:25  <gribble> https://github.com/bitcoin/bitcoin/issues/19653 | wallet: Replace -zapwallettxes with zapwallettxes RPC by achow101 · Pull Request #19653 · bitcoin/bitcoin · GitHub
4552020-08-06T19:23:38  <achow101> Since we have abandontransaction, I think ditching it is the way to go
4562020-08-06T19:23:53  *** filchef has quit IRC
4572020-08-06T19:23:56  <wumpus> I think abandontransaction is superior *if* it can replace all uses
4582020-08-06T19:24:00  <achow101> unless people used it for anything other than trying to RBF transactions
4592020-08-06T19:24:01  <wumpus> as it's more granular
4602020-08-06T19:24:13  <wumpus> if you don't need a sledgehammer you shouldn't use one
4612020-08-06T19:24:40  <wumpus> with abandontransaction you can remove any conflicted or non-confirmed transaction?
4622020-08-06T19:24:57  <wumpus> I don't think it's useful for transactions that are already in a block
4632020-08-06T19:25:02  <achow101> wumpus: so long as they are not confirmed and not in the mempool, I believe so
4642020-08-06T19:25:11  <wumpus> ok, right, makes sense
4652020-08-06T19:25:11  <sipa> abandontransaction only works for things that aren't in the mempool
4662020-08-06T19:25:14  <achow101> well they remain in history
4672020-08-06T19:25:14  <jeremyrubin> Shouldn't we deprecate and then remove something like this?
4682020-08-06T19:25:23  <wumpus> yes, well with zapwalettx you need to nuke the mempool too
4692020-08-06T19:25:25  <jeremyrubin> Is there any reason to remove all at once?
4702020-08-06T19:25:29  <achow101> but we also have removeprunedfunds which actually removes them from the wallet I think
4712020-08-06T19:25:48  <wumpus> jeremyrubin: it's not a RPC
4722020-08-06T19:26:06  <wumpus> yet
4732020-08-06T19:26:44  <achow101> to go the full abandontransaction route, we might need to add an rpc to clear the mempool, or at least evict a particular transaction from it
4742020-08-06T19:26:47  <wumpus> it's not an option someone would normally use except for recoery so there's no need to go through a deprecation cycle
4752020-08-06T19:26:48  <achow101> but that might not be desirable
4762020-08-06T19:27:05  <sipa> all of these things are recovery sledgehammers
4772020-08-06T19:27:11  <sipa> some just smaller than others
4782020-08-06T19:27:12  <sdaftuar> it strikes me as dangerous to encourage people to manually remove a tx from the mempool so that abandontransaction could be called on it
4792020-08-06T19:27:22  <achow101> sdaftuar: me too
4802020-08-06T19:27:25  <sipa> but anything that requires evicting things from the mempool shouldn't be needed on a regular basis
4812020-08-06T19:27:28  <sipa> sdaftuar: exactly
4822020-08-06T19:27:35  <wumpus> well if it's less dangerous to remove *all* transactions from the wallet?
4832020-08-06T19:27:40  <jeremyrubin> wumpus: i just don't want to give anyone reason to not upgrade, but it's probably fine in this case
4842020-08-06T19:27:43  <wumpus> that's what zapwallettx does
4852020-08-06T19:28:12  <achow101> also, RBF is on by default anyways, so none of these things should matter today
4862020-08-06T19:28:34  <wumpus> in any case my initial proposal was to move it to the wallet tool
4872020-08-06T19:28:47  <wumpus> which is intended for maintenance and recovery like this
4882020-08-06T19:28:50  <sdaftuar> wumpus: that sounds very reasonable
4892020-08-06T19:28:56  <sipa> yeah, it may be that the only use for zapwallettx is for completely corrupted scenarios, where you should be using savagewallet instead...
4902020-08-06T19:29:05  <wumpus> only if *no one* needs it, ever, we can just remove it
4912020-08-06T19:29:10  <sdaftuar> l
4922020-08-06T19:29:16  <achow101> wumpus: the main concern I have about that is zapwallettxes requires a rescan afterwards
4932020-08-06T19:29:16  <sipa> sdaftuar: i know ;)
4942020-08-06T19:29:28  <achow101> and the wallettol isn't going to do that
4952020-08-06T19:29:38  <wumpus> do it on next start ?
4962020-08-06T19:29:47  <wumpus> set the current block of the wallet to 0
4972020-08-06T19:29:47  <sdaftuar> jeremyrubin: salvagewallet
4982020-08-06T19:30:01  <jeremyrubin> fair.
4992020-08-06T19:30:14  <jnewbery> achow101: can't the wallet tool reset the wallet's best block to force a rescan?
5002020-08-06T19:30:26  <wumpus> right
5012020-08-06T19:30:28  <achow101> sure
5022020-08-06T19:30:29  <wumpus> it should
5032020-08-06T19:30:40  <sipa> it doesn't already?
5042020-08-06T19:30:40  <wumpus> as that information is unknown from there on
5052020-08-06T19:30:45  <achow101> startup rescan is always unfun though
5062020-08-06T19:30:55  <wumpus> zapwallettx rescan is not unfun?
5072020-08-06T19:30:57  <sipa> yes, just making the rescan automatic doesn't mean it goes away
5082020-08-06T19:31:00  <wumpus> it's the same IIRC
5092020-08-06T19:31:42  <achow101> I seem to remember that -rescan on qt stuck you at the splashscreen until it finished
5102020-08-06T19:31:42  <wumpus> I mean the current zapwallettx already forces a rescan at startup rght?
5112020-08-06T19:31:56  <wumpus> so this would not make it worse
5122020-08-06T19:32:01  <wumpus> it's for rare recovery operations
5132020-08-06T19:32:03  <wumpus> not for fun
5142020-08-06T19:32:17  <achow101> right
5152020-08-06T19:32:52  <jeremyrubin> wumpus: maybe it should have had a less fun name
5162020-08-06T19:32:53  <sipa> right
5172020-08-06T19:32:55  <wumpus> it sounds too much fun
5182020-08-06T19:32:59  <wumpus> jeremyrubin: exactly!
5192020-08-06T19:33:07  <sipa> jeremyrubin: fun draw transaction?
5202020-08-06T19:33:21  <sdaftuar> sipa: that confused me for so long
5212020-08-06T19:33:23  * jeremyrubin pew pew tx go bye
5222020-08-06T19:33:46  <sipa> also gcc -fun roll loops
5232020-08-06T19:33:48  <achow101> i'm still not convinved that zapwallettxes is actually useful though
5242020-08-06T19:34:01  <wumpus> abandontransaction is more fun in that regard, you could make an UI that allows zapping transactions one by one in a space invaders game :')
5252020-08-06T19:34:23  <achow101> We have CWallet::ZapSelectTx :)
5262020-08-06T19:34:29  <achow101> for removeprunedfunds
5272020-08-06T19:34:30  <wumpus> achow101: me netiher, but how to we find out
5282020-08-06T19:35:22  <jeremyrubin> Are there other topics?
5292020-08-06T19:35:38  <wumpus> like the biggest risk for these kind of things is that it's documented on a wiki somewhere and people try it as a random sledgehammer to fix wallet issues
5302020-08-06T19:35:41  <wumpus> no, I don't think so
5312020-08-06T19:35:53  <jnewbery> I was going to propose a time for the p2p meeting
5322020-08-06T19:36:02  <achow101> wumpus: either way whatever is documented won't work when we remove the startup option anyways
5332020-08-06T19:36:10  <wumpus> #topic P2P meeting (jnewbery)
5342020-08-06T19:36:18  <jnewbery> Thanks wumpus
5352020-08-06T19:36:18  <wumpus> achow101: right!
5362020-08-06T19:36:44  <jnewbery> I suggest 17:00 UTC on alternate Tuesdays, starting next week (Aug 11)
5372020-08-06T19:37:12  <wumpus> sgtm
5382020-08-06T19:37:30  <moneyball> yay p2p meeting
5392020-08-06T19:37:36  <wumpus> so it's two hours earlier than this meeting
5402020-08-06T19:37:52  <jnewbery> that's 2 hours before now (10am west coast, 1pm east coast, 6pm UK, 7pm most of europe)
5412020-08-06T19:38:11  *** prk has joined #bitcoin-core-dev
5422020-08-06T19:38:15  <hebasto> Good for Eastern Europe
5432020-08-06T19:38:22  <sipa> 3 am for aj?
5442020-08-06T19:38:29  <sdaftuar> :(
5452020-08-06T19:38:31  <jnewbery> sorry aj :(
5462020-08-06T19:38:42  <wumpus> this reminds me we need to document all the meetings on https://bitcoincore.org/en/meetings/ probably
5472020-08-06T19:39:05  <harding> wumpus: I'll work on updating that page.
5482020-08-06T19:39:12  <wumpus> harding: thank you!
5492020-08-06T19:39:18  <jnewbery> that +- an hour or two is the only time that spans west coast US to eastern europe
5502020-08-06T19:39:32  <sdaftuar> i would try to make that time, but if there's a better time that would get aj too i think it's worth trying to make it work for him
5512020-08-06T19:39:50  <sipa> i'm ok with up to 2 hours earlier than what is suggested
5522020-08-06T19:39:52  <aj> 5am that's not a saturday is vaguely plausible, 3am isn't
5532020-08-06T19:39:57  <sdaftuar> aj!
5542020-08-06T19:40:15  <sipa> aj: oh wow, a morning person
5552020-08-06T19:40:18  <achow101> aj: 3am is just a late night
5562020-08-06T19:40:33  <wumpus> I'm also fine with earlier (but that;s obvious for Europe)
5572020-08-06T19:40:34  <jnewbery> 5am would be 19:00 UTC (same time as this meeting)
5582020-08-06T19:41:10  <aj> achow101: it's sleeping all day the next day which gets old
5592020-08-06T19:41:16  <jnewbery> that'd be 9pm central europe I think, and 10pm for eastern
5602020-08-06T19:41:42  <sipa> hebasto: up to what time is acceptable to you?
5612020-08-06T19:41:54  <hebasto> Any
5622020-08-06T19:41:57  <sipa> as you seem to be on the other end of the spectrum
5632020-08-06T19:42:04  *** gzhao408 has quit IRC
5642020-08-06T19:42:17  <aj> 1am/1500UTC might be doable, not sure
5652020-08-06T19:42:27  <hebasto> 19:00 utc is ok
5662020-08-06T19:42:41  <jnewbery> aj: is 5am really ok for you?
5672020-08-06T19:42:45  *** roconnor has joined #bitcoin-core-dev
5682020-08-06T19:43:17  <aj> jnewbery: as long as it's not on saturday (like the wallet meeting)
5692020-08-06T19:43:17  <jnewbery> 1500 UTC is 8am for west coast, which might not suit some people (sipa?)
5702020-08-06T19:43:51  <sipa> i can do 8 am
5712020-08-06T19:44:19  <jnewbery> great. Thanks everyone for being flexible
5722020-08-06T19:44:47  <jnewbery> so it sounds like there are two options: 1500 UTC or 1900 UTC
5732020-08-06T19:45:11  <jnewbery> vote now
5742020-08-06T19:45:22  <sipa> and they voted so hard that the country exploded
5752020-08-06T19:45:22  <wumpus> both fine with me
5762020-08-06T19:45:27  <sdaftuar> i'm indifferent
5772020-08-06T19:45:39  <sipa> prefer 1900 UTC, but both are ok
5782020-08-06T19:45:51  <dongcarl> *jeopardy thinking noises*
5792020-08-06T19:46:02  <hebasto> If 1500 utc suits for aj then prefer it
5802020-08-06T19:46:03  <jonatack> 1500 UTC :)
5812020-08-06T19:46:13  <jonatack> got out of bed just to vote
5822020-08-06T19:46:26  <wumpus> :D
5832020-08-06T19:46:38  <sipa> it may be advantageous to pick a time that's intentionally different from this meeting
5842020-08-06T19:46:52  <wumpus> sipa: yes
5852020-08-06T19:47:05  *** dr-orlovsky has quit IRC
5862020-08-06T19:47:12  <jnewbery> aj: ?
5872020-08-06T19:47:29  <aj> 1500 utc tuesday ? fine by me
5882020-08-06T19:48:03  <jnewbery> ok, let's set it for 1500 utc on Tuesday Aug 11
5892020-08-06T19:48:05  *** dr-orlovsky has joined #bitcoin-core-dev
5902020-08-06T19:48:11  <instagibbs> is this every other week or?
5912020-08-06T19:48:19  *** Mercury_Vapor has joined #bitcoin-core-dev
5922020-08-06T19:48:26  <wumpus> yes
5932020-08-06T19:48:35  <jnewbery> if anyone isn't at this meeting and wants to complain, message me and we can reconsider
5942020-08-06T19:48:38  <sipa> jnewbery: every week or every 2 week?
5952020-08-06T19:48:49  <jnewbery> but for now, it's 1500 UTC every 2 weeks
5962020-08-06T19:48:51  <jeremyrubin> sipa: maybe just complain one time
5972020-08-06T19:48:52  <jnewbery> starting Aug 11
5982020-08-06T19:48:58  <aj> 1h, rigt?
5992020-08-06T19:49:08  <jnewbery> aj: maximum 1 hour
6002020-08-06T19:49:56  <jnewbery> but less if there's nothing to talk about
6012020-08-06T19:50:08  <instagibbs> aj is going to get his money's worth
6022020-08-06T19:50:27  <jnewbery> thanks everyone!
6032020-08-06T19:50:30  <aj> \o/
6042020-08-06T19:50:32  <sipa> can we start the meeting at 1600 UTC and run it backwards?
6052020-08-06T19:50:48  <wumpus> hehe
6062020-08-06T19:50:50  <hebasto> how to get know topics in advance?
6072020-08-06T19:51:04  <cfields> sipa: isn't that how it works below the equator?
6082020-08-06T19:51:07  <sipa> ooh, google calendar supports UTC now
6092020-08-06T19:51:10  <cfields> everything's backwards down there.
6102020-08-06T19:51:12  <sipa> well, GMT
6112020-08-06T19:51:20  <wumpus> sipa: no more Reykjavik?
6122020-08-06T19:51:42  <sipa> oh no, it's just showing "Greenwich Mean Time (Iceland)"
6132020-08-06T19:51:47  <sipa> well, it works
6142020-08-06T19:52:03  <wumpus> yes, that works
6152020-08-06T19:52:53  <wumpus> #endmeeting
6162020-08-06T19:52:53  <lightningbot> Meeting ended Thu Aug  6 19:52:53 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6172020-08-06T19:52:53  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-06-19.01.html
6182020-08-06T19:52:53  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-06-19.01.txt
6192020-08-06T19:52:53  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-06-19.01.log.html
6202020-08-06T19:54:50  <jnewbery> I'll make a gist with meeting time and suggested topics and post a link here
6212020-08-06T19:54:55  *** prk has left #bitcoin-core-dev
6222020-08-06T19:57:21  <sdaftuar> jnewbery: would be great to talk about people's sense of how we should prioritize all the PRs that are open right now
6232020-08-06T20:00:41  *** arowser_ has quit IRC
6242020-08-06T20:01:17  *** syperf has joined #bitcoin-core-dev
6252020-08-06T20:01:21  *** arowser_ has joined #bitcoin-core-dev
6262020-08-06T20:01:41  <jnewbery> sdaftuar: right. That's the first topic. Everyone gets to share what they're working on and what their prioirities are.
6272020-08-06T20:04:08  <sdaftuar> my hope is that people with opinions will make a case for particular PRs/areas of the code getting broader focus!
6282020-08-06T20:04:48  <sdaftuar> not sure i'll have any strong opinions, as i try to wrap my head around all the open PRs, but i'd be most interested in contributing to areas that several other people have agreed would be helpful for all of us to focus on
6292020-08-06T20:05:09  *** proofofkeags has quit IRC
6302020-08-06T20:05:16  <sdaftuar> s/all/many/
6312020-08-06T20:05:38  *** el_yapoo has quit IRC
6322020-08-06T20:05:38  *** el_yapooo has quit IRC
6332020-08-06T20:05:42  *** proofofkeags has joined #bitcoin-core-dev
6342020-08-06T20:05:46  <jnewbery> I have opinions!
6352020-08-06T20:05:47  <wumpus> no idea if I'm getting this right but google calender with all meetings (this one, IRC, P2P and PR review): https://calendar.google.com/calendar?cid=MTFwcXZkZ3BkOTlubGliZjliYTg2MXZ1OHNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ
6362020-08-06T20:06:40  <sdaftuar> wumpus: looks good to me
6372020-08-06T20:07:25  *** fox2p has quit IRC
6382020-08-06T20:07:49  <jnewbery> wumpus: yes, that's correct
6392020-08-06T20:07:58  <wumpus> awesome!
6402020-08-06T20:08:59  *** fox2p has joined #bitcoin-core-dev
6412020-08-06T20:09:45  *** proofofkeags has quit IRC
6422020-08-06T20:10:17  *** owowo has quit IRC
6432020-08-06T20:14:19  *** dr-orlovsky has quit IRC
6442020-08-06T20:16:01  *** Guyver2 has quit IRC
6452020-08-06T20:17:03  *** owowo has joined #bitcoin-core-dev
6462020-08-06T20:23:01  *** syperf has quit IRC
6472020-08-06T20:23:51  *** syperf4584 has joined #bitcoin-core-dev
6482020-08-06T20:27:22  <jnewbery> gist here: https://gist.github.com/jnewbery/dfaf34706f93a0608bb24869f13abcbf . Please suggest topics or leave any other feedback. Looking forward to it!
6492020-08-06T20:27:27  *** syperf has joined #bitcoin-core-dev
6502020-08-06T20:33:09  <wumpus> heh, either we need a #proposedmeetingtopi c for the different meetings or people need to specify what meeting it's for when they use it
6512020-08-06T20:33:31  *** dr-orlovsky has joined #bitcoin-core-dev
6522020-08-06T20:34:17  *** proofofkeags has joined #bitcoin-core-dev
6532020-08-06T20:39:14  *** davterra has quit IRC
6542020-08-06T20:39:19  <achow101> for the wallet meeting, we use #proposedwalletmeetingtopic
6552020-08-06T20:40:41  *** syperf has quit IRC
6562020-08-06T20:40:57  <wumpus> hah
6572020-08-06T20:41:18  *** syperf has joined #bitcoin-core-dev
6582020-08-06T20:42:12  <achow101> Oh, now I remember why I think zapwallettxes doesn't work with the wallet tool: the keep metadata option
6592020-08-06T20:42:53  <achow101> in order for that to work, the rescan needs to happen while we temporarily store the now-removed txs
6602020-08-06T20:43:03  *** syperf has quit IRC
6612020-08-06T20:43:20  *** syperf4584 has quit IRC
6622020-08-06T20:54:19  <wumpus> now that payment requests aren't a thing anymore, is transaction metadata much of a thing?
6632020-08-06T20:54:35  <achow101> labels?
6642020-08-06T20:54:42  <wumpus> there's label<->address mapping but that's not per transaction
6652020-08-06T20:55:10  <wumpus> you could just keep all of them
6662020-08-06T20:55:21  <achow101> CWalletTx's metadata is kind of opaque and hard to figure out
6672020-08-06T20:56:01  <achow101> there is a "comment"
6682020-08-06T20:56:19  <achow101> and some old metadata related to accounts
6692020-08-06T20:57:56  *** dr-orlovsky has quit IRC
6702020-08-06T20:58:40  <achow101> also time related stuff
6712020-08-06T21:00:02  *** Suntop1 has quit IRC
6722020-08-06T21:00:08  *** fox2p has quit IRC
6732020-08-06T21:01:50  *** fox2p has joined #bitcoin-core-dev
6742020-08-06T21:04:38  *** mrostecki has quit IRC
6752020-08-06T21:05:33  *** syperf has joined #bitcoin-core-dev
6762020-08-06T21:06:31  *** syperf has quit IRC
6772020-08-06T21:06:47  *** mrostecki has joined #bitcoin-core-dev
6782020-08-06T21:20:30  *** bitcoin-git has joined #bitcoin-core-dev
6792020-08-06T21:20:30  <bitcoin-git> [bitcoin] Warchant opened pull request #19675: Run clang-tidy -*,performance-* (master...master) https://github.com/bitcoin/bitcoin/pull/19675
6802020-08-06T21:20:31  *** bitcoin-git has left #bitcoin-core-dev
6812020-08-06T21:22:11  *** luka has joined #bitcoin-core-dev
6822020-08-06T21:22:36  *** luka is now known as Guest45455
6832020-08-06T21:35:20  *** luke-jr has quit IRC
6842020-08-06T21:36:23  *** dviola has quit IRC
6852020-08-06T21:36:27  *** luke-jr has joined #bitcoin-core-dev
6862020-08-06T21:44:31  *** dviola has joined #bitcoin-core-dev
6872020-08-06T21:46:07  *** watersnake1 has joined #bitcoin-core-dev
6882020-08-06T21:52:22  *** dr-orlovsky has joined #bitcoin-core-dev
6892020-08-06T22:02:03  *** gzhao408 has joined #bitcoin-core-dev
6902020-08-06T22:04:44  *** vincenzopalazzo has quit IRC
6912020-08-06T22:17:05  *** gzhao408 has quit IRC
6922020-08-06T22:26:47  *** Highway61 has quit IRC
6932020-08-06T22:41:01  *** marcoagner has quit IRC
6942020-08-06T22:56:10  *** davterra has joined #bitcoin-core-dev
6952020-08-06T22:58:43  *** vasild has quit IRC
6962020-08-06T23:00:30  *** vasild has joined #bitcoin-core-dev
6972020-08-06T23:04:57  *** Tennis has quit IRC
6982020-08-06T23:09:04  *** mdunnio has quit IRC
6992020-08-06T23:10:18  *** Highway61 has joined #bitcoin-core-dev
7002020-08-06T23:12:48  *** lightlike has quit IRC
7012020-08-06T23:12:54  *** gzhao408 has joined #bitcoin-core-dev
7022020-08-06T23:27:44  *** gzhao408 has quit IRC
7032020-08-06T23:33:31  *** bitdex has joined #bitcoin-core-dev
7042020-08-06T23:35:00  *** bitcoin-git has joined #bitcoin-core-dev
7052020-08-06T23:35:01  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/82127d27c900...6d8543504d8c
7062020-08-06T23:35:02  <bitcoin-git> bitcoin/master 7989901 Suhas Daftuar: Add txids with non-standard inputs to reject filter
7072020-08-06T23:35:03  <bitcoin-git> bitcoin/master 9f88ded Gregory Sanders: test addition of unknown segwit spends to txid reject filter
7082020-08-06T23:35:03  <bitcoin-git> bitcoin/master 6d85435 fanquake: Merge #19620: Add txids with non-standard inputs to reject filter
7092020-08-06T23:35:05  *** bitcoin-git has left #bitcoin-core-dev
7102020-08-06T23:35:20  *** bitcoin-git has joined #bitcoin-core-dev
7112020-08-06T23:35:20  <bitcoin-git> [bitcoin] fanquake merged pull request #19620: Add txids with non-standard inputs to reject filter (master...2020-07-reject-unknown-wit) https://github.com/bitcoin/bitcoin/pull/19620
7122020-08-06T23:35:21  *** bitcoin-git has left #bitcoin-core-dev
7132020-08-06T23:42:03  *** mdunnio has joined #bitcoin-core-dev
7142020-08-06T23:44:20  *** promag_ has joined #bitcoin-core-dev
7152020-08-06T23:46:35  *** troygiorshev has quit IRC
7162020-08-06T23:47:21  *** mdunnio has quit IRC
7172020-08-06T23:47:32  *** troygiorshev has joined #bitcoin-core-dev
7182020-08-06T23:58:42  *** Pavlenex has joined #bitcoin-core-dev
7192020-08-06T23:59:52  *** fox2p has quit IRC